ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/skill_util.C
(Generate patch)

Comparing deliantra/server/server/skill_util.C (file contents):
Revision 1.47 by root, Sun May 13 19:56:57 2007 UTC vs.
Revision 1.69 by root, Sun Nov 16 03:52:13 2008 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copryight (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/* Created July 95 to separate skill utilities from actual skills -b.t. */ 24/* Created July 95 to separate skill utilities from actual skills -b.t. */
26 25
27/* Reconfigured skills code to allow linking of skills to experience 26/* Reconfigured skills code to allow linking of skills to experience
… …
61 * subtypes. 60 * subtypes.
62 */ 61 */
63void 62void
64init_skills (void) 63init_skills (void)
65{ 64{
66 for (archetype *at = first_archetype; at; at = at->next) 65 for_all_archetypes (at)
67 if (at->clone.type == SKILL) 66 if (at->type == SKILL)
68 { 67 {
69 if (skill_names[at->clone.subtype]) 68 if (skill_names[at->subtype])
70 LOG (llevError, "init_skills: multiple skill using same subtype %d, %s, %s\n", 69 LOG (llevError, "init_skills: multiple skill using same subtype %d, %s, %s\n",
71 at->clone.subtype, &skill_names[at->clone.subtype], &at->clone.skill); 70 at->subtype, &skill_names[at->subtype], &at->skill);
72 else 71 else
73 skill_names[at->clone.subtype] = at->clone.skill; 72 skill_names[at->subtype] = at->skill;
74 } 73 }
75 74
76 /* This isn't really an error if there is no skill subtype set, but 75 /* This isn't really an error if there is no skill subtype set, but
77 * checking for this may catch some user errors. 76 * checking for this may catch some user errors.
78 */ 77 */
… …
85 * up the last_skills[] array in the player object. 84 * up the last_skills[] array in the player object.
86 * the last_skills[] is used to more quickly lookup skills - 85 * the last_skills[] is used to more quickly lookup skills -
87 * mostly used for sending exp. 86 * mostly used for sending exp.
88 */ 87 */
89void 88void
90link_player_skills (object *op) 89player::link_skills ()
91{ 90{
91 for (int i = 0; i < NUM_SKILLS; ++i)
92 last_skill_ob [i] = 0;
93
92 for (object *tmp = op->inv; tmp; tmp = tmp->below) 94 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
93 if (tmp->type == SKILL) 95 if (tmp->type == SKILL)
94 { 96 {
95 /* This is really a warning, hence no else below */ 97 assert (IN_RANGE_EXC (tmp->subtype, 0, NUM_SKILLS));
96 if (op->contr->last_skill_ob[tmp->subtype] && op->contr->last_skill_ob[tmp->subtype] != tmp)
97 LOG (llevError, "Multiple skills with the same subtype? %s, %s\n",
98 &op->contr->last_skill_ob[tmp->subtype]->skill, &tmp->skill);
99 98
100 if (tmp->subtype >= NUM_SKILLS) 99 if (last_skill_ob [tmp->subtype] != tmp)
101 LOG (llevError, "Invalid subtype number %d (range 0-%d)\n", tmp->subtype, NUM_SKILLS);
102 else
103 { 100 {
101 /* This is really a warning, hence no else below */
102 if (last_skill_ob [tmp->subtype])
103 LOG (llevError, "Multiple skills with the same subtype? %s, %s\n",
104 &last_skill_ob [tmp->subtype]->skill, &tmp->skill);
105
104 op->contr->last_skill_ob[tmp->subtype] = tmp; 106 last_skill_ob [tmp->subtype] = tmp;
105 op->contr->ns->last_skill_exp[tmp->subtype] = -1; //TODO: this should go 107 if (ns)
108 ns->last_skill_exp [tmp->subtype] = -1;
106 } 109 }
107 } 110 }
108} 111}
109 112
113static object *
114find_skill (object *who, const shstr &name)
115{
116 if (who->chosen_skill
117 && who->chosen_skill->skill == name
118 && who->chosen_skill->type == SKILL)
119 return who->chosen_skill;
120
121 for (object *tmp = who->inv; tmp; tmp = tmp->below)
122 if (tmp->skill == name && tmp->type == SKILL)
123 return splay (tmp);
124
125 return 0;
126}
127
128object *player::find_skill (const shstr &name) const
129{
130 // might want to use last_skill_obj at one point, or maybe not
131 return ::find_skill (ob, name);
132}
133
134object *player::find_skill (const char *name) const
135{
136 return find_skill (shstr (name));
137}
138
110/* This returns the skill pointer of the given name (the 139/* This returns the skill pointer of the given name (the
111 * one that accumlates exp, has the level, etc). 140 * one that accumulates exp, has the level, etc).
112 * 141 *
113 * It is presumed that the player will be needing to actually 142 * It is presumed that the player will be needing to actually
114 * use the skill, so thus if use of the skill requires a skill 143 * use the skill, so thus if use of the skill requires a skill
115 * tool, this code will equip it. 144 * tool, this code will equip it.
116 */ 145 */
117object * 146object *
118find_skill_by_name (object *who, const char *name) 147find_skill_by_name (object *who, const shstr &sh)
119{ 148{
120 if (!name) 149 object *skill_tool = 0;
150
151 for (object *tmp = who->inv; tmp; tmp = tmp->below)
152 if (tmp->skill == sh)
153 {
154 if (tmp->type == SKILL && (tmp->flag [FLAG_CAN_USE_SKILL] || tmp->flag [FLAG_APPLIED]))
155 /* If this is a skill that can be used without applying tool, return it */
156 return splay (tmp);
157 /* Try to find appropriate skilltool. If the player has one already
158 * applied, we try to keep using that one.
159 */
160 else if (tmp->type == SKILL_TOOL && !skill_tool)
161 skill_tool = tmp;
162 }
163
164 if (!skill_tool)
121 return 0; 165 return 0;
122
123 object *skill = 0, *skill_tool = 0;
124
125 /* We make sure the length of the string in the object is greater
126 * in length than the passed string. Eg, if we have a skill called
127 * 'hi', we don't want to match if the user passed 'high'
128 */
129 for (object *tmp = who->inv; tmp; tmp = tmp->below)
130 {
131 if (tmp->type == SKILL && !strncasecmp (name, tmp->skill, strlen (name)) && strlen (tmp->skill) >= strlen (name))
132 skill = tmp;
133
134 /* Try to find appropriate skilltool. If the player has one already
135 * applied, we try to keep using that one.
136 */
137 else if (tmp->type == SKILL_TOOL && !strncasecmp (name, tmp->skill, strlen (name)) && strlen (tmp->skill) >= strlen (name))
138 {
139 if (QUERY_FLAG (tmp, FLAG_APPLIED))
140 skill_tool = tmp;
141 else if (!skill_tool || !QUERY_FLAG (skill_tool, FLAG_APPLIED))
142 skill_tool = tmp;
143 }
144 }
145
146 /* If this is a skill that can be used without a tool, return it */
147 if (skill && QUERY_FLAG (skill, FLAG_CAN_USE_SKILL))
148 return skill;
149 166
150 /* Player has a tool to use the skill. If not applied, apply it - 167 /* Player has a tool to use the skill. If not applied, apply it -
151 * if not successful, return null. If they do have the skill tool 168 * if not successful, return null. If they do have the skill tool
152 * but not the skill itself, give it to them. 169 * but not the skill itself, give it to them.
153 */ 170 */
154 if (skill_tool) 171 object *skill = find_skill (who, skill_tool->skill);
155 {
156 if (!QUERY_FLAG (skill_tool, FLAG_APPLIED))
157 if (apply_special (who, skill_tool, 0))
158 return 0;
159 172
160 if (!skill) 173 if (!skill)
161 {
162 skill = give_skill_by_name (who, skill_tool->skill); 174 skill = give_skill_by_name (who, skill_tool->skill);
163 link_player_skills (who);
164 }
165 175
176 if (!skill_tool->flag [FLAG_APPLIED])
177 if (apply_special (who, splay (skill_tool), AP_APPLY | AP_NO_READY))
166 return skill; 178 return 0;
167 } 179
180 return splay (skill);
181}
182
183object *
184find_skill_by_name (object *who, const char *name)
185{
186 if (!name)
187 return 0;
188
189 for (object *tmp = who->inv; tmp; tmp = tmp->below)
190 if ((tmp->type == SKILL || tmp->type == SKILL_TOOL)
191 && tmp->skill.begins_with (name))
192 if (object *skop = find_skill_by_name (who, tmp->skill))
193 return skop;
168 194
169 return 0; 195 return 0;
170} 196}
171 197
172/* This returns the skill pointer of the given name (the 198/* This returns the skill pointer of the given name (the
173 * one that accumlates exp, has the level, etc). 199 * one that accumulates exp, has the level, etc).
174 * 200 *
175 * It is presumed that the player will be needing to actually 201 * It is presumed that the player will be needing to actually
176 * use the skill, so thus if use of the skill requires a skill 202 * use the skill, so thus if use of the skill requires a skill
177 * tool, this code will equip it. 203 * tool, this code will equip it.
178 * 204 *
… …
181 * this replaces find_skill. 207 * this replaces find_skill.
182 */ 208 */
183object * 209object *
184find_skill_by_number (object *who, int skillno) 210find_skill_by_number (object *who, int skillno)
185{ 211{
186 if (!IN_RANGE_EXC (skillno, 1, NUM_SKILLS)) 212 for (object *tmp = who->inv; tmp; tmp = tmp->below)
213 if (tmp->type == SKILL && tmp->subtype == skillno)
214 if (object *skop = find_skill_by_name (who, tmp->skill))
215 return skop;
216
217 return 0;
218}
219
220/* This changes the objects chosen_skill to new_skill.
221 * return 1 on success, 0 on error
222 */
223bool
224object::change_skill (object *new_skill)
225{
226 if (type != PLAYER)
187 return 0; 227 return 0;
188 228
189 object *skill = NULL, *skill_tool = NULL;
190
191 for (object *tmp = who->inv; tmp; tmp = tmp->below)
192 {
193 if (tmp->type == SKILL && tmp->subtype == skillno)
194 skill = tmp;
195
196 /* Try to find appropriate skilltool. If the player has one already
197 * applied, we try to keep using that one.
198 */
199 else if (tmp->type == SKILL_TOOL && tmp->subtype == skillno)
200 {
201 if (QUERY_FLAG (tmp, FLAG_APPLIED))
202 skill_tool = tmp;
203 else if (!skill_tool || !QUERY_FLAG (skill_tool, FLAG_APPLIED))
204 skill_tool = tmp;
205 }
206 }
207
208 /* If this is a skill that can be used without a tool, return it */
209 if (skill && QUERY_FLAG (skill, FLAG_CAN_USE_SKILL))
210 return skill;
211
212 /* Player has a tool to use the skill. If not applied, apply it -
213 * if not successful, return null. If they do have the skill tool
214 * but not the skill itself, give it to them.
215 */
216 if (skill_tool)
217 {
218 if (!QUERY_FLAG (skill_tool, FLAG_APPLIED))
219 {
220 if (apply_special (who, skill_tool, 0))
221 return NULL;
222 }
223
224 if (!skill)
225 {
226 skill = give_skill_by_name (who, skill_tool->skill);
227 link_player_skills (who);
228 }
229
230 return skill;
231 }
232
233 return NULL;
234}
235
236/* This changes the objects skill to new_skill.
237 * note that this function doesn't always need to get used -
238 * you can now add skill exp to the player without the chosen_skill being
239 * set. This function is of most interest to players to update
240 * the various range information.
241 * return 1 on success, 0 on error
242 */
243int
244change_skill (object *who, object *new_skill, int flag)
245{
246 if (who->type != PLAYER)
247 return 0;
248
249#if 0
250 // optimise this supposedly common case 229 // optimise this supposedly common case
251 if (new_skill == who->chosen_skill) 230 if (new_skill == chosen_skill)
252 return 1; 231 return 1;
253#endif
254 232
255 if (!new_skill) 233 if (chosen_skill)
256 {
257 LOG (llevError | logBacktrace, "change_skill called on %s with NULL skill\n",
258 who->debug_desc ());
259 return 0;
260 } 234 {
235 chosen_skill->flag [FLAG_APPLIED] = false;
236 change_abil (this, chosen_skill);
237 }
261 238
262 // the skill could be readied already because it is used by a weapon. 239 chosen_skill = new_skill;
263 who->change_weapon (0);
264 new_skill->inv_splay ();
265 240
266 if (apply_special (who, new_skill, AP_APPLY)) 241 if (chosen_skill)
267 return 0; 242 {
243 chosen_skill->flag [FLAG_APPLIED] = true;
244 change_abil (this, chosen_skill);
245 }
268 246
247 // always clear current weapon, as the selected skill could
248 // conflict with the current weapon skill, which would go
249 // undetected and exp would be given to the wrong skill.
250 current_weapon = 0;
251
252 update_stats ();
269 return 1; 253 return 1;
270}
271
272/* This function just clears the chosen_skill and range_skill values
273 * in the player.
274 */
275void
276clear_skill (object *who)
277{
278 who->chosen_skill = 0;
279 CLEAR_FLAG (who, FLAG_READY_SKILL);
280
281 if (who->type == PLAYER)
282 if (who->contr->ranged_ob && who->contr->ranged_ob->type == SKILL)
283 who->contr->ranged_ob = 0;
284} 254}
285 255
286/* do_skill() - Main skills use function-similar in scope to cast_spell(). 256/* do_skill() - Main skills use function-similar in scope to cast_spell().
287 * We handle all requests for skill use outside of some combat here. 257 * We handle all requests for skill use outside of some combat here.
288 * We require a separate routine outside of fire() so as to allow monsters 258 * We require a separate routine outside of fire() so as to allow monsters
… …
338 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth."); 308 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth.");
339 } 309 }
340 else 310 else
341 { 311 {
342 SET_FLAG (skill, FLAG_APPLIED); 312 SET_FLAG (skill, FLAG_APPLIED);
343 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!."); 313 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!");
344 } 314 }
345 315
346 op->update_stats (); 316 op->update_stats ();
347 success = 1; 317 success = 1;
348 break; 318 break;
… …
358 case SK_HIDING: 328 case SK_HIDING:
359 exp = success = hide (op, skill); 329 exp = success = hide (op, skill);
360 break; 330 break;
361 331
362 case SK_JUMPING: 332 case SK_JUMPING:
363 success = jump (op, dir, skill); 333 exp = success = jump (op, dir, skill);
364 break; 334 break;
365 335
366 case SK_INSCRIPTION: 336 case SK_INSCRIPTION:
367 exp = success = write_on_item (op, string, skill); 337 exp = success = write_on_item (op, string, skill);
368 break; 338 break;
… …
499 * Monsters have no skill use time because of the random nature in 469 * Monsters have no skill use time because of the random nature in
500 * which use_monster_skill is called already simulates this. 470 * which use_monster_skill is called already simulates this.
501 * If certain skills should take more/less time, that should be 471 * If certain skills should take more/less time, that should be
502 * in the code for the skill itself. 472 * in the code for the skill itself.
503 */ 473 */
504
505 if (op->type == PLAYER) 474 if (op->type == PLAYER)
506 op->speed_left -= 1.f; 475 op->speed_left -= 1.f;
507 476
508 /* this is a good place to add experience for successfull use of skills. 477 /* this is a good place to add experience for successfull use of skills.
509 * Note that add_exp() will figure out player/monster experience 478 * Note that add_exp() will figure out player/monster experience
… …
557 * If an object is not alive and magical we set the base exp higher to 526 * If an object is not alive and magical we set the base exp higher to
558 * help out exp awards for skill_ident skills. Also, if 527 * help out exp awards for skill_ident skills. Also, if
559 * an item is type RUNE, we give out exp based on stats.Cha 528 * an item is type RUNE, we give out exp based on stats.Cha
560 * and level (this was the old system) -b.t. 529 * and level (this was the old system) -b.t.
561 */ 530 */
562
563 if (!op) 531 if (!op)
564 { /* no item/creature */ 532 { /* no item/creature */
565 op_lvl = who->map->difficulty < 1 ? 1 : who->map->difficulty; 533 op_lvl = max (1, who->map->difficulty);
566 op_exp = 0; 534 op_exp = 0;
567 } 535 }
568 else if (op->type == RUNE || op->type == TRAP) 536 else if (op->type == RUNE || op->type == TRAP)
569 { /* all traps. If stats.Cha > 1 we use that 537 { /* all traps. If stats.Cha > 1 we use that
570 * for the amount of experience */ 538 * for the amount of experience */
… …
574 else 542 else
575 { /* all other items/living creatures */ 543 { /* all other items/living creatures */
576 op_exp = op->stats.exp; 544 op_exp = op->stats.exp;
577 op_lvl = op->level; 545 op_lvl = op->level;
578 if (!QUERY_FLAG (op, FLAG_ALIVE)) 546 if (!QUERY_FLAG (op, FLAG_ALIVE))
579 { /* for ident/make items */ 547 op_lvl += 5 * abs (op->magic); /* for ident/make items */
580 op_lvl += 5 * abs (op->magic);
581 }
582 } 548 }
583 549
584 if (op_lvl < 1) 550 if (op_lvl < 1)
585 op_lvl = 1; 551 op_lvl = 1;
586 552
… …
594 /* if skill really is a skill, then we can look at the skill archetype for 560 /* if skill really is a skill, then we can look at the skill archetype for
595 * bse reward value (exp) and level multiplier factor. 561 * bse reward value (exp) and level multiplier factor.
596 */ 562 */
597 if (skill->type == SKILL) 563 if (skill->type == SKILL)
598 { 564 {
599 base += skill->arch->clone.stats.exp; 565 base += skill->arch->stats.exp;
600 if (settings.simple_exp) 566 if (settings.simple_exp)
601 { 567 {
602 if (skill->arch->clone.level) 568 if (skill->arch->level)
603 lvl_mult = (float) skill->arch->clone.level / 100.0; 569 lvl_mult = (float) skill->arch->level / 100.0;
604 else 570 else
605 lvl_mult = 1.0; /* no adjustment */ 571 lvl_mult = 1.0; /* no adjustment */
606 } 572 }
607 else 573 else
608 { 574 {
609 if (skill->level) 575 if (skill->level)
610 lvl_mult = ((float) skill->arch->clone.level * (float) op_lvl) / ((float) skill->level * 100.0); 576 lvl_mult = ((float) skill->arch->level * (float) op_lvl) / ((float) skill->level * 100.0);
611 else 577 else
612 lvl_mult = 1.0; 578 lvl_mult = 1.0;
613 } 579 }
614 } 580 }
615 else 581 else
616 { 582 {
617 /* Don't divide by zero here! */ 583 /* Don't divide by zero here! */
618 lvl_mult = (float) op_lvl / (float) (skill->level ? skill->level : 1); 584 lvl_mult = (float) op_lvl / (float) max (1, skill->level);
619 } 585 }
620 } 586 }
621 587
622 /* assemble the exp total, and return value */ 588 /* assemble the exp total, and return value */
623 589
… …
640 * player learns the skill, 2 otherwise. 606 * player learns the skill, 2 otherwise.
641 */ 607 */
642int 608int
643learn_skill (object *pl, object *scroll) 609learn_skill (object *pl, object *scroll)
644{ 610{
645 object *tmp;
646
647 if (!scroll->skill) 611 if (!scroll->skill)
648 { 612 {
649 LOG (llevError, "skill scroll %s does not have skill pointer set.\n", &scroll->name); 613 LOG (llevError, "skill scroll %s does not have skill pointer set.\n", &scroll->name);
650 return 2; 614 return 2;
651 } 615 }
652 616
653 /* can't use find_skill_by_name because we want skills the player knows 617 object *tmp = find_skill (pl, scroll->skill);
654 * but can't use natively.
655 */
656
657 for (tmp = pl->inv; tmp != NULL; tmp = tmp->below)
658 if (tmp->type == SKILL && !strncasecmp (scroll->skill, tmp->skill, strlen (scroll->skill)))
659 break;
660 618
661 /* player already knows it */ 619 /* player already knows it */
662 if (tmp && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL)) 620 if (tmp && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL))
663 return 0; 621 return 0;
664 622
… …
677 LOG (llevError, "skill scroll %s does not have valid skill name (%s).\n", &scroll->name, &scroll->skill); 635 LOG (llevError, "skill scroll %s does not have valid skill name (%s).\n", &scroll->name, &scroll->skill);
678 return 2; 636 return 2;
679 } 637 }
680 638
681 SET_FLAG (tmp, FLAG_CAN_USE_SKILL); 639 SET_FLAG (tmp, FLAG_CAN_USE_SKILL);
682 link_player_skills (pl); 640
683 return 1; 641 return 1;
684} 642}
685 643
686/* Gives a percentage clipped to 0% -> 100% of a/b. */ 644/* Gives a percentage clipped to 0% -> 100% of a/b. */
687/* Probably belongs in some global utils-type file? */ 645/* Probably belongs in some global utils-type file? */
… …
711 * Note this function is a bit more complicated becauase we 669 * Note this function is a bit more complicated becauase we
712 * we want ot sort the skills before printing them. If we 670 * we want ot sort the skills before printing them. If we
713 * just dumped this as we found it, this would be a bit 671 * just dumped this as we found it, this would be a bit
714 * simpler. 672 * simpler.
715 */ 673 */
716 674//TODO: egad, do it in perl, do not suffer from the big buffer on stack, make it one single drawinfo.
717void 675void
718show_skills (object *op, const char *search) 676show_skills (object *pl, const char *search)
719{ 677{
720 object *tmp = NULL;
721 char buf[MAX_BUF];
722 const char *cp; 678 const char *cp;
723 int i, num_skills_found = 0; 679 int i, num_skills_found = 0;
724 static const char *const periods = "........................................"; 680 const char *const periods = ".............................."; // 30
725 681
726 /* Need to have a pointer and use strdup for qsort to work properly */ 682 /* Need to have a pointer and use strdup for qsort to work properly */
727 char skills[NUM_SKILLS][MAX_BUF]; 683 char skills[NUM_SKILLS][128]; // d'oh
728 684
685 object *op = pl->contr->ob;
729 686
730 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 687 for (object *tmp = op->inv; tmp; tmp = tmp->below)
731 { 688 {
732 if (tmp->type == SKILL) 689 if (tmp->type == SKILL)
733 { 690 {
734 if (search && strstr (tmp->name, search) == NULL) 691 if (search && !strstr (tmp->name, search))
735 continue; 692 continue;
693
694 char buf[30];
695
736 /* Basically want to fill this out to 40 spaces with periods */ 696 /* Basically want to fill this out to 30 spaces with periods */
737 sprintf (buf, "%s%s", &tmp->name, periods); 697 snprintf (buf, sizeof (buf), "%s%s", &tmp->name, periods);
738 buf[40] = 0;
739 698
740 if (settings.permanent_exp_ratio) 699 if (settings.permanent_exp_ratio)
741 {
742 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%" PRId64 "/%" PRId64 "/%d%%)", 700 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 "/%d%%)",
743 buf, tmp->level, tmp->stats.exp, 701 buf, tmp->level, tmp->stats.exp,
744 level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp)); 702 level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp));
745 }
746 else 703 else
747 {
748 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%" PRId64 "/%" PRId64 ")", 704 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 ")",
749 buf, tmp->level, tmp->stats.exp, level_exp (tmp->level + 1, op->expmul)); 705 buf, tmp->level, tmp->stats.exp, level_exp (tmp->level + 1, op->expmul));
750 } 706
751 /* I don't know why some characters get a bunch of skills, but 707 /* I don't know why some characters get a bunch of skills, but
752 * it sometimes happens (maybe a leftover from bugier earlier code 708 * it sometimes happens (maybe a leftover from bugier earlier code
753 * and those character are still about). In any case, lets handle 709 * and those character are still about). In any case, lets handle
754 * it so it doesn't crash the server - otherwise, one character may 710 * it so it doesn't crash the server - otherwise, one character may
755 * crash the server numerous times. 711 * crash the server numerous times.
… …
761 break; 717 break;
762 } 718 }
763 } 719 }
764 } 720 }
765 721
766 clear_win_info (op); 722 dynbuf_text msg (4096, 1024);
767 new_draw_info (NDI_UNIQUE, 0, op, "Player skills:"); 723
724 msg << "T<Player skills:>\n\n";
768 if (num_skills_found > 1) 725 if (num_skills_found > 1)
769 qsort (skills, num_skills_found, MAX_BUF, (int (*)(const void *, const void *)) std::strcmp); 726 qsort (skills, num_skills_found, sizeof (skills [0]), (int (*)(const void *, const void *)) std::strcmp);
770 727
771 for (i = 0; i < num_skills_found; i++) 728 for (i = 0; i < num_skills_found; i++)
772 new_draw_info (NDI_UNIQUE, 0, op, skills[i]); 729 msg << " C<" << skills [i] << ">\n";
773 730
774 new_draw_info_format (NDI_UNIQUE, 0, op, "You can handle %d weapon improvements.", op->level / 5 + 5); 731 msg << "\nYou can handle " << op->level / 5 + 5 << " weapon improvements.\r";
775 732
776 cp = determine_god (op); 733 cp = determine_god (op);
777 new_draw_info_format (NDI_UNIQUE, 0, op, "You worship %s.", cp ? cp : "no god at current time"); 734 msg << "You worship " << (cp ? cp : "no god at current time") << ".\r";
778 735
779 new_draw_info_format (NDI_UNIQUE, 0, op, "Your equipped item power is %d out of %d\n", 736 msg << "Your equipped item power is " << (int)op->contr->item_power
780 op->contr->item_power, (int) (op->level * settings.item_power_factor)); 737 << " out of " << int (op->level * settings.item_power_factor)
738 << ".\n";
739
740 pl->contr->infobox (MSG_CHANNEL ("skills"), msg);
781} 741}
782 742
783/* use_skill() - similar to invoke command, it executes the skill in the 743/* use_skill() - similar to invoke command, it executes the skill in the
784 * direction that the user is facing. Returns false if we are unable to 744 * direction that the user is facing. Returns false if we are unable to
785 * change to the requested skill, or were unable to use the skill properly. 745 * change to the requested skill, or were unable to use the skill properly.
… …
793 size_t len; 753 size_t len;
794 754
795 if (!string) 755 if (!string)
796 return 0; 756 return 0;
797 757
798 for (skop = op->inv; skop != NULL; skop = skop->below) 758 for (skop = op->inv; skop; skop = skop->below)
799 { 759 {
760 if (skop->type == SKILL
800 if (skop->type == SKILL && QUERY_FLAG (skop, FLAG_CAN_USE_SKILL) && 761 && QUERY_FLAG (skop, FLAG_CAN_USE_SKILL)
801 !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill)))) 762 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill))))
802 break; 763 break;
764 else if (skop->type == SKILL_TOOL
803 else if (skop->type == SKILL_TOOL && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill)))) 765 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill))))
804 break; 766 break;
805 } 767 }
768
806 if (!skop) 769 if (!skop)
807 { 770 {
808 new_draw_info_format (NDI_UNIQUE, 0, op, "Unable to find skill %s", string); 771 new_draw_info_format (NDI_UNIQUE, 0, op, "Unable to find skill %s", string);
809 return 0; 772 return 0;
810 } 773 }
… …
815 * options given to the skill. Its pretty simple - if there 778 * options given to the skill. Its pretty simple - if there
816 * are extra parameters (as deteremined by string length), we 779 * are extra parameters (as deteremined by string length), we
817 * want to skip over any leading spaces. 780 * want to skip over any leading spaces.
818 */ 781 */
819 if (len >= strlen (string)) 782 if (len >= strlen (string))
820 {
821 string = NULL; 783 string = NULL;
822 }
823 else 784 else
824 { 785 {
825 string += len; 786 string += len;
826 while (*string == 0x20) 787 while (*string == 0x20)
827 string++; 788 string++;
789
828 if (strlen (string) == 0) 790 if (strlen (string) == 0)
829 string = NULL; 791 string = NULL;
830 } 792 }
831 793
832#ifdef SKILL_UTIL_DEBUG 794#ifdef SKILL_UTIL_DEBUG
833 LOG (llevDebug, "use_skill() got skill: %s\n", sknum > -1 ? skills[sknum].name : "none"); 795 LOG (llevDebug, "use_skill() got skill: %s\n", sknum > -1 ? skills[sknum].name : "none");
834#endif 796#endif
835 797
836 /* Change to the new skill, then execute it. */
837 if (do_skill (op, op, skop, op->facing, string)) 798 if (do_skill (op, op, skop, op->facing, string))
838 return 1; 799 return 1;
839 800
840 return 0; 801 return 0;
841} 802}
… …
879 * the caller should have set it appropriately). We still want to pass 840 * the caller should have set it appropriately). We still want to pass
880 * through that code if skill is set to change to the skill. 841 * through that code if skill is set to change to the skill.
881 */ 842 */
882 if (player *pl = op->contr) 843 if (player *pl = op->contr)
883 { 844 {
884 if (!pl->combat_ob) 845 if (skill)
846 op->change_skill (skill);
847 else
885 { 848 {
886 if (QUERY_FLAG (op, FLAG_READY_WEAPON)) 849 if (!pl->combat_ob)
887 { 850 {
888 for (tmp = op->inv; tmp; tmp = tmp->below) 851 if (QUERY_FLAG (op, FLAG_READY_WEAPON))
889 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
890 break;
891
892 if (!tmp)
893 { 852 {
853 for (tmp = op->inv; tmp; tmp = tmp->below)
854 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
855 break;
856
857 if (!tmp)
894 LOG (llevError, "Could not find applied weapon on %s\n", &op->name); 858 LOG (llevError, "Could not find applied weapon on %s\n", &op->name);
895 return 0; 859
860 pl->combat_ob = tmp;
896 } 861 }
897 862
898 change_skill (op, find_skill_by_name (op, tmp->skill), 1); 863 if (!pl->combat_ob)
899 }
900 else
901 {
902 if (!skill)
903 { 864 {
904 /* See if the players chosen skill is a combat skill, and use 865 /* See if the players chosen skill is a combat skill, and use
905 * it if appropriate. 866 * it if appropriate.
906 */ 867 */
907 if (op->chosen_skill && hth_skill_p (op->chosen_skill)) 868 if (op->chosen_skill && hth_skill_p (op->chosen_skill))
… …
909 else 870 else
910 { 871 {
911 skill = find_player_hth_skill (op); 872 skill = find_player_hth_skill (op);
912 873
913 if (!skill) 874 if (!skill)
914 {
915 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!"); 875 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!");
916 return 0;
917 } 876 }
877
878 if (skill)
879 {
880 op->change_skill (0);
881 apply_special (op, skill, AP_APPLY);
918 } 882 }
919 } 883 }
920 884
921 /* now try to ready the new skill */ 885 if (!pl->combat_ob)
922 if (!change_skill (op, skill, 0)) 886 {
923 { /* oh oh, trouble! */ 887 LOG (llevError, "Could not find anything to attack on %s\n", &op->name);
924 new_draw_info_format (NDI_UNIQUE, 0, op, "Couldn't change to skill %s", &skill->name);
925 return 0; 888 return 0;
926 } 889 }
927 } 890 }
928 891
929 if (!pl->combat_ob) 892 if (!op->change_weapon (pl->combat_ob))
930 {
931 LOG (llevError, "Could not find anything to attack on %s\n", &op->name);
932 return 0; 893 return 0;
933 }
934 } 894 }
935
936 if (!op->change_weapon (pl->combat_ob))
937 return 0;
938 895
939 /* lose invisiblity/hiding status for running attacks */ 896 /* lose invisiblity/hiding status for running attacks */
940 if (pl->tmp_invis) 897 if (pl->tmp_invis)
941 { 898 {
942 pl->tmp_invis = 0; 899 pl->tmp_invis = 0;
943 op->invisible = 0; 900 op->invisible = 0;
944 op->hide = 0; 901 op->flag [FLAG_HIDDEN] = 0;
945 update_object (op, UP_OBJ_CHANGE); 902 update_object (op, UP_OBJ_CHANGE);
946 } 903 }
947 } 904 }
948 905
949 int success = attack_ob (tmp, op); 906 int success = attack_ob (tmp, op);
… …
961 return success; 918 return success;
962} 919}
963 920
964/* skill_attack() - Core routine for use when we attack using a skills 921/* skill_attack() - Core routine for use when we attack using a skills
965 * system. In essence, this code handles 922 * system. In essence, this code handles
966 * all skill-based attacks, ie hth, missile and melee weapons should be 923 * all skill-based attacks, i.e. hth, missile and melee weapons should be
967 * treated here. If an opponent is already supplied by move_player(), 924 * treated here. If an opponent is already supplied by move_player(),
968 * we move right onto do_skill_attack(), otherwise we find if an 925 * we move right onto do_skill_attack(), otherwise we find if an
969 * appropriate opponent exists. 926 * appropriate opponent exists.
970 * 927 *
971 * This is called by move_player() and attack_hth() 928 * This is called by move_player() and attack_hth()
… …
1076 1033
1077 return 0; 1034 return 0;
1078 } 1035 }
1079 1036
1080 return skill_attack (NULL, op, dir, string, skill); 1037 return skill_attack (NULL, op, dir, string, skill);
1081
1082} 1038}
1039

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines