ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/skill_util.C
(Generate patch)

Comparing deliantra/server/server/skill_util.C (file contents):
Revision 1.59 by root, Thu Nov 8 19:43:28 2007 UTC vs.
Revision 1.93 by root, Sat Apr 10 05:12:57 2010 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24/* Created July 95 to separate skill utilities from actual skills -b.t. */ 25/* Created July 95 to separate skill utilities from actual skills -b.t. */
… …
58/* init_skills basically just sets up the skill_names table 59/* init_skills basically just sets up the skill_names table
59 * above. The index into the array is set up by the 60 * above. The index into the array is set up by the
60 * subtypes. 61 * subtypes.
61 */ 62 */
62void 63void
63init_skills (void) 64init_skills ()
64{ 65{
65 for_all_archetypes (at) 66 for_all_archetypes (at)
66 if (at->type == SKILL) 67 if (at->type == SKILL)
67 { 68 {
68 if (skill_names[at->subtype]) 69 if (skill_names[at->subtype])
… …
84 * up the last_skills[] array in the player object. 85 * up the last_skills[] array in the player object.
85 * the last_skills[] is used to more quickly lookup skills - 86 * the last_skills[] is used to more quickly lookup skills -
86 * mostly used for sending exp. 87 * mostly used for sending exp.
87 */ 88 */
88void 89void
89link_player_skills (object *op) 90player::link_skills ()
90{ 91{
92 for (int i = 0; i < NUM_SKILLS; ++i)
93 last_skill_ob [i] = 0;
94
91 for (object *tmp = op->inv; tmp; tmp = tmp->below) 95 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
92 if (tmp->type == SKILL) 96 if (tmp->type == SKILL)
93 { 97 {
94 /* This is really a warning, hence no else below */ 98 assert (IN_RANGE_EXC (tmp->subtype, 0, NUM_SKILLS));
95 if (op->contr->last_skill_ob[tmp->subtype] && op->contr->last_skill_ob[tmp->subtype] != tmp)
96 LOG (llevError, "Multiple skills with the same subtype? %s, %s\n",
97 &op->contr->last_skill_ob[tmp->subtype]->skill, &tmp->skill);
98 99
99 if (tmp->subtype >= NUM_SKILLS) 100 if (last_skill_ob [tmp->subtype] != tmp)
100 LOG (llevError, "Invalid subtype number %d (range 0-%d)\n", tmp->subtype, NUM_SKILLS);
101 else
102 { 101 {
102 /* This is really a warning, hence no else below */
103 if (last_skill_ob [tmp->subtype])
104 LOG (llevError, "Multiple skills with the same subtype? %s, %s\n",
105 &last_skill_ob [tmp->subtype]->skill, &tmp->skill);
106
103 op->contr->last_skill_ob[tmp->subtype] = tmp; 107 last_skill_ob [tmp->subtype] = tmp;
104 op->contr->ns->last_skill_exp[tmp->subtype] = -1; //TODO: this should go 108 if (ns)
109 ns->last_skill_exp [tmp->subtype] = -1;
105 } 110 }
106 } 111 }
107} 112}
108 113
109static object * 114static object *
110find_skill (object *who, const shstr &sh) 115find_skill (object *who, shstr_cmp name)
111{ 116{
117 if (who->chosen_skill
118 && who->chosen_skill->skill == name
119 && who->chosen_skill->type == SKILL)
120 return who->chosen_skill;
121
112 for (object *tmp = who->inv; tmp; tmp = tmp->below) 122 for (object *tmp = who->inv; tmp; tmp = tmp->below)
113 if (tmp->skill == sh && tmp->type == SKILL) 123 if (tmp->skill == name && tmp->type == SKILL)
114 return tmp; 124 return splay (tmp);
115 125
116 return 0; 126 return 0;
127}
128
129object *player::find_skill (shstr_cmp name) const
130{
131 // might want to use last_skill_obj at one point, or maybe not
132 return ::find_skill (ob, name);
117} 133}
118 134
119/* This returns the skill pointer of the given name (the 135/* This returns the skill pointer of the given name (the
120 * one that accumulates exp, has the level, etc). 136 * one that accumulates exp, has the level, etc).
121 * 137 *
122 * It is presumed that the player will be needing to actually 138 * It is presumed that the player will be needing to actually
123 * use the skill, so thus if use of the skill requires a skill 139 * use the skill, so thus if use of the skill requires a skill
124 * tool, this code will equip it. 140 * tool, this code will equip it.
125 */ 141 */
126object * 142object *
127find_skill_by_name (object *who, const shstr &sh) 143find_skill_by_name (object *who, shstr_cmp sh)
128{ 144{
129 object *skill_tool = 0; 145 object *skill_tool = 0;
130 146
131 for (object *tmp = who->inv; tmp; tmp = tmp->below) 147 for (object *tmp = who->inv; tmp; tmp = tmp->below)
132 if (tmp->skill == sh) 148 if (tmp->skill == sh)
… …
149 * but not the skill itself, give it to them. 165 * but not the skill itself, give it to them.
150 */ 166 */
151 object *skill = find_skill (who, skill_tool->skill); 167 object *skill = find_skill (who, skill_tool->skill);
152 168
153 if (!skill) 169 if (!skill)
154 {
155 skill = give_skill_by_name (who, skill_tool->skill); 170 skill = give_skill_by_name (who, skill_tool->skill);
156 link_player_skills (who);
157 }
158 171
159 if (!skill_tool->flag [FLAG_APPLIED]) 172 if (!skill_tool->flag [FLAG_APPLIED])
160 if (apply_special (who, splay (skill_tool), AP_APPLY | AP_NO_READY)) 173 if (!who->apply (splay (skill_tool)))
161 return 0; 174 return 0;
162 175
163 return splay (skill); 176 return splay (skill);
164} 177}
165 178
166object * 179object *
167find_skill_by_name (object *who, const char *name) 180find_skill_by_name_fuzzy (object *who, const char *name)
168{ 181{
169 if (!name) 182 if (name)
170 return 0;
171
172 for (object *tmp = who->inv; tmp; tmp = tmp->below) 183 for (object *tmp = who->inv; tmp; tmp = tmp->below)
173 if ((tmp->type == SKILL || tmp->type == SKILL_TOOL) 184 if ((tmp->type == SKILL || tmp->type == SKILL_TOOL)
174 && tmp->skill.begins_with (name)) 185 && tmp->skill.starts_with (name))
175 if (object *skop = find_skill_by_name (who, tmp->skill)) 186 if (object *skop = find_skill_by_name (who, tmp->skill))
176 return skop; 187 return skop;
177 188
178 return 0; 189 return 0;
179} 190}
180 191
181/* This returns the skill pointer of the given name (the 192/* This returns the skill pointer of the given name (the
… …
198 return skop; 209 return skop;
199 210
200 return 0; 211 return 0;
201} 212}
202 213
203/* This changes the objects chosen_skill to new_skill.
204 * return 1 on success, 0 on error
205 */
206bool
207object::change_skill (object *new_skill)
208{
209 if (type != PLAYER)
210 return 0;
211
212 // optimise this supposedly common case
213 if (new_skill == chosen_skill)
214 return 1;
215
216 if (chosen_skill)
217 {
218 chosen_skill->flag [FLAG_APPLIED] = false;
219 change_abil (this, chosen_skill);
220 }
221
222 chosen_skill = new_skill;
223
224 if (chosen_skill)
225 {
226 chosen_skill->flag [FLAG_APPLIED] = true;
227 change_abil (this, chosen_skill);
228 }
229
230 // always clear current weapon, as the selected skill could
231 // conflict with the current weapon skill, which would go
232 // undetected and exp would be given to the wrong skill.
233 current_weapon = 0;
234
235 update_stats ();
236 return 1;
237}
238
239/* do_skill() - Main skills use function-similar in scope to cast_spell(). 214/* do_skill() - Main skills use function-similar in scope to cast_spell().
240 * We handle all requests for skill use outside of some combat here. 215 * We handle all requests for skill use outside of some combat here.
241 * We require a separate routine outside of fire() so as to allow monsters 216 * We require a separate routine outside of fire() so as to allow monsters
242 * to utilize skills. Returns 1 on use of skill, otherwise 0. 217 * to utilize skills. Returns 1 on use of skill, otherwise 0.
243 * This is changed (2002-11-30) from the old method that returned 218 * This is changed (2002-11-30) from the old method that returned
… …
248 */ 223 */
249int 224int
250do_skill (object *op, object *part, object *skill, int dir, const char *string) 225do_skill (object *op, object *part, object *skill, int dir, const char *string)
251{ 226{
252 int success = 0, exp = 0; 227 int success = 0, exp = 0;
253 int did_alc = 0;
254 228
255 if (!skill) 229 if (!skill)
256 return 0; 230 return 0;
257 231
258 /* The code below presumes that the skill points to the object that 232 /* The code below presumes that the skill points to the object that
… …
291 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth."); 265 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth.");
292 } 266 }
293 else 267 else
294 { 268 {
295 SET_FLAG (skill, FLAG_APPLIED); 269 SET_FLAG (skill, FLAG_APPLIED);
296 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!."); 270 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!");
297 } 271 }
298 272
299 op->update_stats (); 273 op->update_stats ();
300 success = 1; 274 success = 1;
301 break; 275 break;
… …
311 case SK_HIDING: 285 case SK_HIDING:
312 exp = success = hide (op, skill); 286 exp = success = hide (op, skill);
313 break; 287 break;
314 288
315 case SK_JUMPING: 289 case SK_JUMPING:
316 success = jump (op, dir, skill); 290 exp = success = jump (op, dir, skill);
317 break; 291 break;
318 292
319 case SK_INSCRIPTION: 293 case SK_INSCRIPTION:
320 exp = success = write_on_item (op, string, skill); 294 exp = success = write_on_item (op, string, skill);
321 break; 295 break;
… …
383 case SK_LITERACY: 357 case SK_LITERACY:
384 case SK_WOODSMAN: 358 case SK_WOODSMAN:
385 /* first, we try to find a cauldron, and do the alchemy thing. 359 /* first, we try to find a cauldron, and do the alchemy thing.
386 * failing that, we go and identify stuff. 360 * failing that, we go and identify stuff.
387 */ 361 */
362 {
363 bool found_cauldron = false;
364
388 for (object *next, *tmp = GET_MAP_OB (op->map, op->x, op->y); tmp; tmp = next) 365 for (object *next, *tmp = GET_MAP_OB (op->map, op->x, op->y); tmp; tmp = next)
389 { 366 {
390 next = tmp->above; 367 next = tmp->above;
391 368
392 if (QUERY_FLAG (tmp, FLAG_IS_CAULDRON)) 369 if (QUERY_FLAG (tmp, FLAG_IS_CAULDRON))
393 { 370 {
371 found_cauldron = true;
372
373 if (tmp->skill != skill->skill)
374 {
375 op->failmsgf ("You can't use the %s with the %s skill!",
376 query_name (tmp),
377 query_name (skill));
378 break;
379 }
380
394 attempt_do_alchemy (op, tmp); 381 attempt_do_alchemy (op, tmp, skill);
395 382
396 if (QUERY_FLAG (tmp, FLAG_APPLIED)) 383 if (QUERY_FLAG (tmp, FLAG_APPLIED))
397 esrv_send_inventory (op, tmp); 384 esrv_send_inventory (op, tmp);
398
399 did_alc = 1;
400 } 385 }
401 } 386 }
402 387
403 if (did_alc == 0) 388 if (!found_cauldron)
404 exp = success = skill_ident (op, skill); 389 exp = success = skill_ident (op, skill);
405 390 }
406 break; 391 break;
407 392
408 case SK_DET_MAGIC: 393 case SK_DET_MAGIC:
409 case SK_DET_CURSE: 394 case SK_DET_CURSE:
410 exp = success = skill_ident (op, skill); 395 exp = success = skill_ident (op, skill);
… …
441 case SK_SUMMONING: 426 case SK_SUMMONING:
442 case SK_CLIMBING: 427 case SK_CLIMBING:
443 new_draw_info (NDI_UNIQUE, 0, op, "This skill is already in effect."); 428 new_draw_info (NDI_UNIQUE, 0, op, "This skill is already in effect.");
444 break; 429 break;
445 430
431 case SK_MINING:
432 success = skill_mining (op, part, skill, dir, string);
433 break;
434
435 case SK_FISHING:
436 success = skill_fishing (op, part, skill, dir, string);
437 break;
438
446 default: 439 default:
447 LOG (llevDebug, "%s attempted to use unknown skill: %d\n", query_name (op), op->chosen_skill->stats.sp); 440 LOG (llevDebug, "%s attempted to use unknown skill: %d\n", query_name (op), op->chosen_skill->stats.sp);
448 break; 441 break;
449 } 442 }
450 443
… …
452 * Monsters have no skill use time because of the random nature in 445 * Monsters have no skill use time because of the random nature in
453 * which use_monster_skill is called already simulates this. 446 * which use_monster_skill is called already simulates this.
454 * If certain skills should take more/less time, that should be 447 * If certain skills should take more/less time, that should be
455 * in the code for the skill itself. 448 * in the code for the skill itself.
456 */ 449 */
457
458 if (op->type == PLAYER) 450 if (op->type == PLAYER)
459 op->speed_left -= 1.f; 451 op->speed_left -= 1.f;
460 452
461 /* this is a good place to add experience for successfull use of skills. 453 /* this is a good place to add experience for successfull use of skills.
462 * Note that add_exp() will figure out player/monster experience 454 * Note that add_exp() will figure out player/monster experience
… …
510 * If an object is not alive and magical we set the base exp higher to 502 * If an object is not alive and magical we set the base exp higher to
511 * help out exp awards for skill_ident skills. Also, if 503 * help out exp awards for skill_ident skills. Also, if
512 * an item is type RUNE, we give out exp based on stats.Cha 504 * an item is type RUNE, we give out exp based on stats.Cha
513 * and level (this was the old system) -b.t. 505 * and level (this was the old system) -b.t.
514 */ 506 */
515
516 if (!op) 507 if (!op)
517 { /* no item/creature */ 508 { /* no item/creature */
518 op_lvl = who->map->difficulty < 1 ? 1 : who->map->difficulty; 509 op_lvl = max (1, who->map->difficulty);
519 op_exp = 0; 510 op_exp = 0;
520 } 511 }
521 else if (op->type == RUNE || op->type == TRAP) 512 else if (op->type == RUNE || op->type == TRAP)
522 { /* all traps. If stats.Cha > 1 we use that 513 { /* all traps. If stats.Cha > 1 we use that
523 * for the amount of experience */ 514 * for the amount of experience */
… …
527 else 518 else
528 { /* all other items/living creatures */ 519 { /* all other items/living creatures */
529 op_exp = op->stats.exp; 520 op_exp = op->stats.exp;
530 op_lvl = op->level; 521 op_lvl = op->level;
531 if (!QUERY_FLAG (op, FLAG_ALIVE)) 522 if (!QUERY_FLAG (op, FLAG_ALIVE))
532 { /* for ident/make items */ 523 op_lvl += 5 * abs (op->magic); /* for ident/make items */
533 op_lvl += 5 * abs (op->magic);
534 }
535 } 524 }
536 525
537 if (op_lvl < 1) 526 if (op_lvl < 1)
538 op_lvl = 1; 527 op_lvl = 1;
539 528
… …
566 } 555 }
567 } 556 }
568 else 557 else
569 { 558 {
570 /* Don't divide by zero here! */ 559 /* Don't divide by zero here! */
571 lvl_mult = (float) op_lvl / (float) (skill->level ? skill->level : 1); 560 lvl_mult = (float) op_lvl / (float) max (1, skill->level);
572 } 561 }
573 } 562 }
574 563
575 /* assemble the exp total, and return value */ 564 /* assemble the exp total, and return value */
576 565
… …
622 LOG (llevError, "skill scroll %s does not have valid skill name (%s).\n", &scroll->name, &scroll->skill); 611 LOG (llevError, "skill scroll %s does not have valid skill name (%s).\n", &scroll->name, &scroll->skill);
623 return 2; 612 return 2;
624 } 613 }
625 614
626 SET_FLAG (tmp, FLAG_CAN_USE_SKILL); 615 SET_FLAG (tmp, FLAG_CAN_USE_SKILL);
627 link_player_skills (pl); 616
628 return 1; 617 return 1;
629} 618}
630 619
631/* Gives a percentage clipped to 0% -> 100% of a/b. */ 620/* Gives a percentage clipped to 0% -> 100% of a/b. */
632/* Probably belongs in some global utils-type file? */ 621/* Probably belongs in some global utils-type file? */
… …
658 * just dumped this as we found it, this would be a bit 647 * just dumped this as we found it, this would be a bit
659 * simpler. 648 * simpler.
660 */ 649 */
661//TODO: egad, do it in perl, do not suffer from the big buffer on stack, make it one single drawinfo. 650//TODO: egad, do it in perl, do not suffer from the big buffer on stack, make it one single drawinfo.
662void 651void
663show_skills (object *op, const char *search) 652show_skills (object *pl, const char *search)
664{ 653{
665 object *tmp = NULL;
666 char buf[MAX_BUF];
667 const char *cp; 654 const char *cp;
668 int i, num_skills_found = 0; 655 int i, num_skills_found = 0;
669 static const char *const periods = "........................................"; 656 const char *const periods = ".............................."; // 30
670 657
671 /* Need to have a pointer and use strdup for qsort to work properly */ 658 /* Need to have a pointer and use strdup for qsort to work properly */
672 char skills[NUM_SKILLS][MAX_BUF]; 659 char skills[NUM_SKILLS][128]; // d'oh
673 660
661 object *op = pl->contr->ob;
662
674 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 663 for (object *tmp = op->inv; tmp; tmp = tmp->below)
675 { 664 {
676 if (tmp->type == SKILL) 665 if (tmp->type == SKILL)
677 { 666 {
678 if (search && strstr (tmp->name, search) == NULL) 667 if (search && !tmp->name.contains (search))
679 continue; 668 continue;
669
670 char buf[30];
671
680 /* Basically want to fill this out to 40 spaces with periods */ 672 /* Basically want to fill this out to 30 spaces with periods */
681 sprintf (buf, "%s%s", &tmp->name, periods); 673 snprintf (buf, sizeof (buf), "%s%s", &tmp->name, periods);
682 buf[40] = 0;
683 674
684 if (settings.permanent_exp_ratio) 675 if (settings.permanent_exp_ratio)
685 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%" PRId64 "/%" PRId64 "/%d%%)", 676 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 "/%d%%)",
686 buf, tmp->level, tmp->stats.exp, 677 buf, tmp->level, tmp->stats.exp,
687 level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp)); 678 level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp));
688 else 679 else
689 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%" PRId64 "/%" PRId64 ")", 680 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 ")",
690 buf, tmp->level, tmp->stats.exp, level_exp (tmp->level + 1, op->expmul)); 681 buf, tmp->level, tmp->stats.exp, level_exp (tmp->level + 1, op->expmul));
691 682
692 /* I don't know why some characters get a bunch of skills, but 683 /* I don't know why some characters get a bunch of skills, but
693 * it sometimes happens (maybe a leftover from bugier earlier code 684 * it sometimes happens (maybe a leftover from bugier earlier code
694 * and those character are still about). In any case, lets handle 685 * and those character are still about). In any case, lets handle
695 * it so it doesn't crash the server - otherwise, one character may 686 * it so it doesn't crash the server - otherwise, one character may
696 * crash the server numerous times. 687 * crash the server numerous times.
697 */ 688 */
698 if (num_skills_found >= NUM_SKILLS) 689 if (num_skills_found >= NUM_SKILLS)
699 { 690 {
700 new_draw_info (NDI_RED, 0, op, "Your character has too many skills."); 691 new_draw_info (NDI_RED | NDI_REPLY, 0, op, "Your character has too many skills.");
701 new_draw_info (NDI_RED, 0, op, "Something isn't right - contact the server admin"); 692 new_draw_info (NDI_RED | NDI_REPLY, 0, op, "Something isn't right - contact the server admin");
702 break; 693 break;
703 } 694 }
704 } 695 }
705 } 696 }
706 697
707 new_draw_info (NDI_UNIQUE, 0, op, "Player skills:"); 698 dynbuf_text &msg = msg_dynbuf; msg.clear ();
699
700 msg << "T<Player skills:>\n\n";
708 if (num_skills_found > 1) 701 if (num_skills_found > 1)
709 qsort (skills, num_skills_found, MAX_BUF, (int (*)(const void *, const void *)) std::strcmp); 702 qsort (skills, num_skills_found, sizeof (skills [0]), (int (*)(const void *, const void *)) std::strcmp);
710 703
711 for (i = 0; i < num_skills_found; i++) 704 for (i = 0; i < num_skills_found; i++)
712 new_draw_info (NDI_UNIQUE, 0, op, skills[i]); 705 msg << " C<" << skills [i] << ">\n";
713 706
714 new_draw_info_format (NDI_UNIQUE, 0, op, "You can handle %d weapon improvements.", op->level / 5 + 5); 707 msg << "\nYou can handle " << op->level / 5 + 5 << " weapon improvements.\r";
715 708
716 cp = determine_god (op); 709 cp = determine_god (op);
717 new_draw_info_format (NDI_UNIQUE, 0, op, "You worship %s.", cp ? cp : "no god at current time"); 710 msg << "You worship " << (cp ? cp : "no god at current time") << ".\r";
718 711
719 new_draw_info_format (NDI_UNIQUE, 0, op, "Your equipped item power is %d out of %d\n", 712 msg << "Your equipped item power is " << (int)op->contr->item_power
720 op->contr->item_power, (int) (op->level * settings.item_power_factor)); 713 << " out of " << int (op->level * settings.item_power_factor)
714 << ".\n";
715
716 pl->contr->infobox (MSG_CHANNEL ("skills"), msg);
721} 717}
722 718
723/* use_skill() - similar to invoke command, it executes the skill in the 719/* use_skill() - similar to invoke command, it executes the skill in the
724 * direction that the user is facing. Returns false if we are unable to 720 * direction that the user is facing. Returns false if we are unable to
725 * change to the requested skill, or were unable to use the skill properly. 721 * change to the requested skill, or were unable to use the skill properly.
… …
734 730
735 if (!string) 731 if (!string)
736 return 0; 732 return 0;
737 733
738 for (skop = op->inv; skop; skop = skop->below) 734 for (skop = op->inv; skop; skop = skop->below)
739 { 735 if ((skop->type == SKILL || skop->type == SKILL_TOOL)
740 if (skop->type == SKILL
741 && QUERY_FLAG (skop, FLAG_CAN_USE_SKILL)
742 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill)))) 736 && !strncmp (string, skop->skill, min (strlen (string), strlen (skop->skill))))
737 {
738 skop = find_skill_by_name (op, skop->skill);
743 break; 739 break;
744 else if (skop->type == SKILL_TOOL
745 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill))))
746 break;
747 } 740 }
748 741
749 if (!skop) 742 if (!skop)
750 { 743 {
751 new_draw_info_format (NDI_UNIQUE, 0, op, "Unable to find skill %s", string); 744 op->failmsgf ("Unable to find skill %s.", string);
745 return 0;
746 }
747
748 if (!(skill_flags [skop->subtype] & SF_USE))
749 {
750 op->failmsgf (
751 "You feel as if you wanted to do something funny, but you can't remember what. "
752 "H<The %s skill cannot be C<use_skill>'ed - maybe you need to C<ready_skill> it, "
753 "use it with some item, or it's always active.>",
754 &skop->skill
755 );
752 return 0; 756 return 0;
753 } 757 }
754 758
755 len = strlen (skop->skill); 759 len = strlen (skop->skill);
756 760
… …
782} 786}
783 787
784static bool 788static bool
785hth_skill_p (object *skill) 789hth_skill_p (object *skill)
786{ 790{
787 return (skill_flags [skill->subtype] & (SF_COMBAT | SF_NEED_WEAPON)) == SF_COMBAT; 791 return (skill_flags [skill->subtype] & (SF_COMBAT | SF_NEED_ITEM)) == SF_COMBAT;
788} 792}
789 793
790/* This finds the first unarmed skill the player has, and returns it. 794/* This finds the first unarmed skill the player has, and returns it.
791 */ 795 */
792static object * 796static object *
… …
820 * the caller should have set it appropriately). We still want to pass 824 * the caller should have set it appropriately). We still want to pass
821 * through that code if skill is set to change to the skill. 825 * through that code if skill is set to change to the skill.
822 */ 826 */
823 if (player *pl = op->contr) 827 if (player *pl = op->contr)
824 { 828 {
825 if (!pl->combat_ob) 829 if (skill)
826 { 830 {
827 if (QUERY_FLAG (op, FLAG_READY_WEAPON)) 831 if (!op->apply (skill))
828 { 832 return 0;
829 for (tmp = op->inv; tmp; tmp = tmp->below)
830 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
831 break;
832
833 if (!tmp)
834 LOG (llevError, "Could not find applied weapon on %s\n", &op->name);
835
836 pl->combat_ob = tmp;
837 } 833 }
838 834 else
835 {
839 if (!pl->combat_ob) 836 if (!pl->combat_ob)
840 { 837 {
838 if (QUERY_FLAG (op, FLAG_READY_WEAPON))
839 {
840 for (tmp = op->inv; tmp; tmp = tmp->below)
841 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
842 break;
843
841 if (!skill) 844 if (!tmp)
845 LOG (llevError, "Could not find applied weapon on %s\n", &op->name);
846
847 pl->combat_ob = tmp;
848 }
849
850 if (!pl->combat_ob)
842 { 851 {
843 /* See if the players chosen skill is a combat skill, and use 852 /* See if the players chosen skill is a combat skill, and use
844 * it if appropriate. 853 * it if appropriate.
845 */ 854 */
846 if (op->chosen_skill && hth_skill_p (op->chosen_skill)) 855 if (op->chosen_skill && hth_skill_p (op->chosen_skill))
… …
850 skill = find_player_hth_skill (op); 859 skill = find_player_hth_skill (op);
851 860
852 if (!skill) 861 if (!skill)
853 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!"); 862 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!");
854 } 863 }
864
865 op->apply (skill);
855 } 866 }
856 867
857 if (skill) 868 if (!pl->combat_ob)
858 { 869 {
859 op->change_skill (0); 870 LOG (llevError, "Could not find anything to attack on %s\n", &op->name);
860 apply_special (op, skill, AP_APPLY); 871 return 0;
861 } 872 }
862 } 873 }
863 874
864 if (!pl->combat_ob) 875 if (!op->apply (pl->combat_ob))
865 {
866 LOG (llevError, "Could not find anything to attack on %s\n", &op->name);
867 return 0; 876 return 0;
868 }
869 } 877 }
870
871 if (!op->change_weapon (pl->combat_ob))
872 return 0;
873 878
874 /* lose invisiblity/hiding status for running attacks */ 879 /* lose invisiblity/hiding status for running attacks */
875 if (pl->tmp_invis) 880 if (pl->tmp_invis)
876 { 881 {
877 pl->tmp_invis = 0; 882 pl->tmp_invis = 0;
878 op->invisible = 0; 883 op->invisible = 0;
879 op->hide = 0; 884 op->flag [FLAG_HIDDEN] = 0;
880 update_object (op, UP_OBJ_CHANGE); 885 update_object (op, UP_OBJ_CHANGE);
881 } 886 }
882 } 887 }
883 888
884 int success = attack_ob (tmp, op); 889 int success = attack_ob (tmp, op);
… …
896 return success; 901 return success;
897} 902}
898 903
899/* skill_attack() - Core routine for use when we attack using a skills 904/* skill_attack() - Core routine for use when we attack using a skills
900 * system. In essence, this code handles 905 * system. In essence, this code handles
901 * all skill-based attacks, ie hth, missile and melee weapons should be 906 * all skill-based attacks, i.e. hth, missile and melee weapons should be
902 * treated here. If an opponent is already supplied by move_player(), 907 * treated here. If an opponent is already supplied by move_player(),
903 * we move right onto do_skill_attack(), otherwise we find if an 908 * we move right onto do_skill_attack(), otherwise we find if an
904 * appropriate opponent exists. 909 * appropriate opponent exists.
905 * 910 *
906 * This is called by move_player() and attack_hth() 911 * This is called by move_player() and attack_hth()

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines