ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/skill_util.C
(Generate patch)

Comparing deliantra/server/server/skill_util.C (file contents):
Revision 1.45 by root, Sat May 12 22:04:20 2007 UTC vs.
Revision 1.65 by root, Mon Sep 22 05:45:55 2008 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copryight (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/* Created July 95 to separate skill utilities from actual skills -b.t. */ 24/* Created July 95 to separate skill utilities from actual skills -b.t. */
26 25
27/* Reconfigured skills code to allow linking of skills to experience 26/* Reconfigured skills code to allow linking of skills to experience
… …
61 * subtypes. 60 * subtypes.
62 */ 61 */
63void 62void
64init_skills (void) 63init_skills (void)
65{ 64{
66 for (archetype *at = first_archetype; at; at = at->next) 65 for_all_archetypes (at)
67 if (at->clone.type == SKILL) 66 if (at->type == SKILL)
68 { 67 {
69 if (skill_names[at->clone.subtype]) 68 if (skill_names[at->subtype])
70 LOG (llevError, "init_skills: multiple skill using same subtype %d, %s, %s\n", 69 LOG (llevError, "init_skills: multiple skill using same subtype %d, %s, %s\n",
71 at->clone.subtype, &skill_names[at->clone.subtype], &at->clone.skill); 70 at->subtype, &skill_names[at->subtype], &at->skill);
72 else 71 else
73 skill_names[at->clone.subtype] = at->clone.skill; 72 skill_names[at->subtype] = at->skill;
74 } 73 }
75 74
76 /* This isn't really an error if there is no skill subtype set, but 75 /* This isn't really an error if there is no skill subtype set, but
77 * checking for this may catch some user errors. 76 * checking for this may catch some user errors.
78 */ 77 */
… …
105 op->contr->ns->last_skill_exp[tmp->subtype] = -1; //TODO: this should go 104 op->contr->ns->last_skill_exp[tmp->subtype] = -1; //TODO: this should go
106 } 105 }
107 } 106 }
108} 107}
109 108
109static object *
110find_skill (object *who, const shstr &sh)
111{
112 for (object *tmp = who->inv; tmp; tmp = tmp->below)
113 if (tmp->skill == sh && tmp->type == SKILL)
114 return tmp;
115
116 return 0;
117}
118
110/* This returns the skill pointer of the given name (the 119/* This returns the skill pointer of the given name (the
111 * one that accumlates exp, has the level, etc). 120 * one that accumulates exp, has the level, etc).
112 * 121 *
113 * It is presumed that the player will be needing to actually 122 * It is presumed that the player will be needing to actually
114 * use the skill, so thus if use of the skill requires a skill 123 * use the skill, so thus if use of the skill requires a skill
115 * tool, this code will equip it. 124 * tool, this code will equip it.
116 */ 125 */
117object * 126object *
118find_skill_by_name (object *who, const char *name) 127find_skill_by_name (object *who, const shstr &sh)
119{ 128{
120 if (!name) 129 object *skill_tool = 0;
130
131 for (object *tmp = who->inv; tmp; tmp = tmp->below)
132 if (tmp->skill == sh)
133 {
134 if (tmp->type == SKILL && (tmp->flag [FLAG_CAN_USE_SKILL] || tmp->flag [FLAG_APPLIED]))
135 /* If this is a skill that can be used without applying tool, return it */
136 return splay (tmp);
137 /* Try to find appropriate skilltool. If the player has one already
138 * applied, we try to keep using that one.
139 */
140 else if (tmp->type == SKILL_TOOL && !skill_tool)
141 skill_tool = tmp;
142 }
143
144 if (!skill_tool)
121 return 0; 145 return 0;
122
123 object *skill = 0, *skill_tool = 0;
124
125 /* We make sure the length of the string in the object is greater
126 * in length than the passed string. Eg, if we have a skill called
127 * 'hi', we don't want to match if the user passed 'high'
128 */
129 for (object *tmp = who->inv; tmp; tmp = tmp->below)
130 {
131 if (tmp->type == SKILL && !strncasecmp (name, tmp->skill, strlen (name)) && strlen (tmp->skill) >= strlen (name))
132 skill = tmp;
133
134 /* Try to find appropriate skilltool. If the player has one already
135 * applied, we try to keep using that one.
136 */
137 else if (tmp->type == SKILL_TOOL && !strncasecmp (name, tmp->skill, strlen (name)) && strlen (tmp->skill) >= strlen (name))
138 {
139 if (QUERY_FLAG (tmp, FLAG_APPLIED))
140 skill_tool = tmp;
141 else if (!skill_tool || !QUERY_FLAG (skill_tool, FLAG_APPLIED))
142 skill_tool = tmp;
143 }
144 }
145
146 /* If this is a skill that can be used without a tool, return it */
147 if (skill && QUERY_FLAG (skill, FLAG_CAN_USE_SKILL))
148 return skill;
149 146
150 /* Player has a tool to use the skill. If not applied, apply it - 147 /* Player has a tool to use the skill. If not applied, apply it -
151 * if not successful, return null. If they do have the skill tool 148 * if not successful, return null. If they do have the skill tool
152 * but not the skill itself, give it to them. 149 * but not the skill itself, give it to them.
153 */ 150 */
154 if (skill_tool) 151 object *skill = find_skill (who, skill_tool->skill);
155 {
156 if (!QUERY_FLAG (skill_tool, FLAG_APPLIED))
157 if (apply_special (who, skill_tool, 0))
158 return 0;
159 152
160 if (!skill) 153 if (!skill)
161 { 154 {
162 skill = give_skill_by_name (who, skill_tool->skill); 155 skill = give_skill_by_name (who, skill_tool->skill);
163 link_player_skills (who); 156 link_player_skills (who);
164 } 157 }
165 158
159 if (!skill_tool->flag [FLAG_APPLIED])
160 if (apply_special (who, splay (skill_tool), AP_APPLY | AP_NO_READY))
166 return skill; 161 return 0;
167 } 162
163 return splay (skill);
164}
165
166object *
167find_skill_by_name (object *who, const char *name)
168{
169 if (!name)
170 return 0;
171
172 for (object *tmp = who->inv; tmp; tmp = tmp->below)
173 if ((tmp->type == SKILL || tmp->type == SKILL_TOOL)
174 && tmp->skill.begins_with (name))
175 if (object *skop = find_skill_by_name (who, tmp->skill))
176 return skop;
168 177
169 return 0; 178 return 0;
170} 179}
171 180
172/* This returns the skill pointer of the given name (the 181/* This returns the skill pointer of the given name (the
173 * one that accumlates exp, has the level, etc). 182 * one that accumulates exp, has the level, etc).
174 * 183 *
175 * It is presumed that the player will be needing to actually 184 * It is presumed that the player will be needing to actually
176 * use the skill, so thus if use of the skill requires a skill 185 * use the skill, so thus if use of the skill requires a skill
177 * tool, this code will equip it. 186 * tool, this code will equip it.
178 * 187 *
… …
181 * this replaces find_skill. 190 * this replaces find_skill.
182 */ 191 */
183object * 192object *
184find_skill_by_number (object *who, int skillno) 193find_skill_by_number (object *who, int skillno)
185{ 194{
186 object *skill = NULL, *skill_tool = NULL, *tmp;
187
188 if (skillno < 1 || skillno >= NUM_SKILLS)
189 return NULL;
190
191 for (tmp = who->inv; tmp != NULL; tmp = tmp->below) 195 for (object *tmp = who->inv; tmp; tmp = tmp->below)
192 {
193 if (tmp->type == SKILL && tmp->subtype == skillno) 196 if (tmp->type == SKILL && tmp->subtype == skillno)
194 skill = tmp; 197 if (object *skop = find_skill_by_name (who, tmp->skill))
195
196 /* Try to find appropriate skilltool. If the player has one already
197 * applied, we try to keep using that one.
198 */
199 else if (tmp->type == SKILL_TOOL && tmp->subtype == skillno)
200 {
201 if (QUERY_FLAG (tmp, FLAG_APPLIED))
202 skill_tool = tmp;
203 else if (!skill_tool || !QUERY_FLAG (skill_tool, FLAG_APPLIED))
204 skill_tool = tmp;
205 }
206 }
207 /* If this is a skill that can be used without a tool, return it */
208 if (skill && QUERY_FLAG (skill, FLAG_CAN_USE_SKILL))
209 return skill;
210
211 /* Player has a tool to use the skill. IF not applied, apply it -
212 * if not successful, return null. If they do have the skill tool
213 * but not the skill itself, give it to them.
214 */
215 if (skill_tool)
216 {
217 if (!QUERY_FLAG (skill_tool, FLAG_APPLIED))
218 {
219 if (apply_special (who, skill_tool, 0))
220 return NULL;
221 }
222
223 if (!skill)
224 {
225 skill = give_skill_by_name (who, skill_tool->skill);
226 link_player_skills (who);
227 }
228
229 return skill; 198 return skop;
230 }
231 199
232 return NULL; 200 return 0;
233} 201}
234 202
235/* This changes the objects skill to new_skill. 203/* This changes the objects chosen_skill to new_skill.
236 * note that this function doesn't always need to get used -
237 * you can now add skill exp to the player without the chosen_skill being
238 * set. This function is of most interest to players to update
239 * the various range information.
240 * return 1 on success, 0 on error 204 * return 1 on success, 0 on error
241 */ 205 */
242int 206bool
243change_skill (object *who, object *new_skill, int flag) 207object::change_skill (object *new_skill)
244{ 208{
245 if (who->type != PLAYER) 209 if (type != PLAYER)
246 return 0; 210 return 0;
247 211
248 // optimise this supposedly common case 212 // optimise this supposedly common case
249 if (new_skill == who->chosen_skill) 213 if (new_skill == chosen_skill)
250 return 1; 214 return 1;
251 215
252 if (who->chosen_skill) 216 if (chosen_skill)
253 {
254 apply_special (who, who->chosen_skill, AP_UNAPPLY);
255 who->chosen_skill = 0;//D verify wether necessary
256 } 217 {
257 218 chosen_skill->flag [FLAG_APPLIED] = false;
258 if (!new_skill) 219 change_abil (this, chosen_skill);
259 { 220 }
260 LOG (llevError | logBacktrace, "change_skill called on %s with NULL skill\n", 221
261 who->debug_desc ()); 222 chosen_skill = new_skill;
262 return 0; 223
224 if (chosen_skill)
263 } 225 {
226 chosen_skill->flag [FLAG_APPLIED] = true;
227 change_abil (this, chosen_skill);
228 }
264 229
265 new_skill->inv_splay (); 230 // always clear current weapon, as the selected skill could
231 // conflict with the current weapon skill, which would go
232 // undetected and exp would be given to the wrong skill.
233 current_weapon = 0;
266 234
267 if (apply_special (who, new_skill, AP_APPLY)) 235 update_stats ();
268 return 0;
269
270 return 1; 236 return 1;
271}
272
273/* This function just clears the chosen_skill and range_skill values
274 * in the player.
275 */
276void
277clear_skill (object *who)
278{
279 who->chosen_skill = 0;
280 CLEAR_FLAG (who, FLAG_READY_SKILL);
281
282 if (who->type == PLAYER)
283 if (who->contr->ranged_ob && who->contr->ranged_ob->type == SKILL)
284 who->contr->ranged_ob = 0;
285} 237}
286 238
287/* do_skill() - Main skills use function-similar in scope to cast_spell(). 239/* do_skill() - Main skills use function-similar in scope to cast_spell().
288 * We handle all requests for skill use outside of some combat here. 240 * We handle all requests for skill use outside of some combat here.
289 * We require a separate routine outside of fire() so as to allow monsters 241 * We require a separate routine outside of fire() so as to allow monsters
… …
339 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth."); 291 new_draw_info (NDI_UNIQUE, 0, op, "You come to earth.");
340 } 292 }
341 else 293 else
342 { 294 {
343 SET_FLAG (skill, FLAG_APPLIED); 295 SET_FLAG (skill, FLAG_APPLIED);
344 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!."); 296 new_draw_info (NDI_UNIQUE, 0, op, "You rise into the air!");
345 } 297 }
346 298
347 op->update_stats (); 299 op->update_stats ();
348 success = 1; 300 success = 1;
349 break; 301 break;
… …
359 case SK_HIDING: 311 case SK_HIDING:
360 exp = success = hide (op, skill); 312 exp = success = hide (op, skill);
361 break; 313 break;
362 314
363 case SK_JUMPING: 315 case SK_JUMPING:
364 success = jump (op, dir, skill); 316 exp = success = jump (op, dir, skill);
365 break; 317 break;
366 318
367 case SK_INSCRIPTION: 319 case SK_INSCRIPTION:
368 exp = success = write_on_item (op, string, skill); 320 exp = success = write_on_item (op, string, skill);
369 break; 321 break;
… …
500 * Monsters have no skill use time because of the random nature in 452 * Monsters have no skill use time because of the random nature in
501 * which use_monster_skill is called already simulates this. 453 * which use_monster_skill is called already simulates this.
502 * If certain skills should take more/less time, that should be 454 * If certain skills should take more/less time, that should be
503 * in the code for the skill itself. 455 * in the code for the skill itself.
504 */ 456 */
505
506 if (op->type == PLAYER) 457 if (op->type == PLAYER)
507 op->speed_left -= 1.f; 458 op->speed_left -= 1.f;
508 459
509 /* this is a good place to add experience for successfull use of skills. 460 /* this is a good place to add experience for successfull use of skills.
510 * Note that add_exp() will figure out player/monster experience 461 * Note that add_exp() will figure out player/monster experience
… …
558 * If an object is not alive and magical we set the base exp higher to 509 * If an object is not alive and magical we set the base exp higher to
559 * help out exp awards for skill_ident skills. Also, if 510 * help out exp awards for skill_ident skills. Also, if
560 * an item is type RUNE, we give out exp based on stats.Cha 511 * an item is type RUNE, we give out exp based on stats.Cha
561 * and level (this was the old system) -b.t. 512 * and level (this was the old system) -b.t.
562 */ 513 */
563
564 if (!op) 514 if (!op)
565 { /* no item/creature */ 515 { /* no item/creature */
566 op_lvl = who->map->difficulty < 1 ? 1 : who->map->difficulty; 516 op_lvl = max (1, who->map->difficulty);
567 op_exp = 0; 517 op_exp = 0;
568 } 518 }
569 else if (op->type == RUNE || op->type == TRAP) 519 else if (op->type == RUNE || op->type == TRAP)
570 { /* all traps. If stats.Cha > 1 we use that 520 { /* all traps. If stats.Cha > 1 we use that
571 * for the amount of experience */ 521 * for the amount of experience */
… …
575 else 525 else
576 { /* all other items/living creatures */ 526 { /* all other items/living creatures */
577 op_exp = op->stats.exp; 527 op_exp = op->stats.exp;
578 op_lvl = op->level; 528 op_lvl = op->level;
579 if (!QUERY_FLAG (op, FLAG_ALIVE)) 529 if (!QUERY_FLAG (op, FLAG_ALIVE))
580 { /* for ident/make items */ 530 op_lvl += 5 * abs (op->magic); /* for ident/make items */
581 op_lvl += 5 * abs (op->magic);
582 }
583 } 531 }
584 532
585 if (op_lvl < 1) 533 if (op_lvl < 1)
586 op_lvl = 1; 534 op_lvl = 1;
587 535
… …
595 /* if skill really is a skill, then we can look at the skill archetype for 543 /* if skill really is a skill, then we can look at the skill archetype for
596 * bse reward value (exp) and level multiplier factor. 544 * bse reward value (exp) and level multiplier factor.
597 */ 545 */
598 if (skill->type == SKILL) 546 if (skill->type == SKILL)
599 { 547 {
600 base += skill->arch->clone.stats.exp; 548 base += skill->arch->stats.exp;
601 if (settings.simple_exp) 549 if (settings.simple_exp)
602 { 550 {
603 if (skill->arch->clone.level) 551 if (skill->arch->level)
604 lvl_mult = (float) skill->arch->clone.level / 100.0; 552 lvl_mult = (float) skill->arch->level / 100.0;
605 else 553 else
606 lvl_mult = 1.0; /* no adjustment */ 554 lvl_mult = 1.0; /* no adjustment */
607 } 555 }
608 else 556 else
609 { 557 {
610 if (skill->level) 558 if (skill->level)
611 lvl_mult = ((float) skill->arch->clone.level * (float) op_lvl) / ((float) skill->level * 100.0); 559 lvl_mult = ((float) skill->arch->level * (float) op_lvl) / ((float) skill->level * 100.0);
612 else 560 else
613 lvl_mult = 1.0; 561 lvl_mult = 1.0;
614 } 562 }
615 } 563 }
616 else 564 else
617 { 565 {
618 /* Don't divide by zero here! */ 566 /* Don't divide by zero here! */
619 lvl_mult = (float) op_lvl / (float) (skill->level ? skill->level : 1); 567 lvl_mult = (float) op_lvl / (float) max (1, skill->level);
620 } 568 }
621 } 569 }
622 570
623 /* assemble the exp total, and return value */ 571 /* assemble the exp total, and return value */
624 572
… …
641 * player learns the skill, 2 otherwise. 589 * player learns the skill, 2 otherwise.
642 */ 590 */
643int 591int
644learn_skill (object *pl, object *scroll) 592learn_skill (object *pl, object *scroll)
645{ 593{
646 object *tmp;
647
648 if (!scroll->skill) 594 if (!scroll->skill)
649 { 595 {
650 LOG (llevError, "skill scroll %s does not have skill pointer set.\n", &scroll->name); 596 LOG (llevError, "skill scroll %s does not have skill pointer set.\n", &scroll->name);
651 return 2; 597 return 2;
652 } 598 }
653 599
654 /* can't use find_skill_by_name because we want skills the player knows 600 object *tmp = find_skill (pl, scroll->skill);
655 * but can't use natively.
656 */
657
658 for (tmp = pl->inv; tmp != NULL; tmp = tmp->below)
659 if (tmp->type == SKILL && !strncasecmp (scroll->skill, tmp->skill, strlen (scroll->skill)))
660 break;
661 601
662 /* player already knows it */ 602 /* player already knows it */
663 if (tmp && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL)) 603 if (tmp && QUERY_FLAG (tmp, FLAG_CAN_USE_SKILL))
664 return 0; 604 return 0;
665 605
… …
712 * Note this function is a bit more complicated becauase we 652 * Note this function is a bit more complicated becauase we
713 * we want ot sort the skills before printing them. If we 653 * we want ot sort the skills before printing them. If we
714 * just dumped this as we found it, this would be a bit 654 * just dumped this as we found it, this would be a bit
715 * simpler. 655 * simpler.
716 */ 656 */
717 657//TODO: egad, do it in perl, do not suffer from the big buffer on stack, make it one single drawinfo.
718void 658void
719show_skills (object *op, const char *search) 659show_skills (object *op, const char *search)
720{ 660{
721 object *tmp = NULL;
722 char buf[MAX_BUF];
723 const char *cp; 661 const char *cp;
724 int i, num_skills_found = 0; 662 int i, num_skills_found = 0;
725 static const char *const periods = "........................................"; 663 const char *const periods = ".............................."; // 30
726 664
727 /* Need to have a pointer and use strdup for qsort to work properly */ 665 /* Need to have a pointer and use strdup for qsort to work properly */
728 char skills[NUM_SKILLS][MAX_BUF]; 666 char skills[NUM_SKILLS][128]; // d'oh
729 667
730
731 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 668 for (object *tmp = op->inv; tmp; tmp = tmp->below)
732 { 669 {
733 if (tmp->type == SKILL) 670 if (tmp->type == SKILL)
734 { 671 {
735 if (search && strstr (tmp->name, search) == NULL) 672 if (search && !strstr (tmp->name, search))
736 continue; 673 continue;
674
675 char buf[30];
676
737 /* Basically want to fill this out to 40 spaces with periods */ 677 /* Basically want to fill this out to 30 spaces with periods */
738 sprintf (buf, "%s%s", &tmp->name, periods); 678 snprintf (buf, sizeof (buf), "%s%s", &tmp->name, periods);
739 buf[40] = 0;
740 679
741 if (settings.permanent_exp_ratio) 680 if (settings.permanent_exp_ratio)
742 {
743 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%" PRId64 "/%" PRId64 "/%d%%)", 681 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 "/%d%%)",
744 buf, tmp->level, tmp->stats.exp, 682 buf, tmp->level, tmp->stats.exp,
745 level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp)); 683 level_exp (tmp->level + 1, op->expmul), clipped_percent (tmp->perm_exp, tmp->stats.exp));
746 }
747 else 684 else
748 {
749 sprintf (skills[num_skills_found++], "%slvl:%3d (xp:%" PRId64 "/%" PRId64 ")", 685 snprintf (skills[num_skills_found++], sizeof (skills [0]), "%slvl:%3d (xp:%" PRId64 "/%" PRId64 ")",
750 buf, tmp->level, tmp->stats.exp, level_exp (tmp->level + 1, op->expmul)); 686 buf, tmp->level, tmp->stats.exp, level_exp (tmp->level + 1, op->expmul));
751 } 687
752 /* I don't know why some characters get a bunch of skills, but 688 /* I don't know why some characters get a bunch of skills, but
753 * it sometimes happens (maybe a leftover from bugier earlier code 689 * it sometimes happens (maybe a leftover from bugier earlier code
754 * and those character are still about). In any case, lets handle 690 * and those character are still about). In any case, lets handle
755 * it so it doesn't crash the server - otherwise, one character may 691 * it so it doesn't crash the server - otherwise, one character may
756 * crash the server numerous times. 692 * crash the server numerous times.
… …
762 break; 698 break;
763 } 699 }
764 } 700 }
765 } 701 }
766 702
767 clear_win_info (op); 703 dynbuf_text msg (4096, 1024);
768 new_draw_info (NDI_UNIQUE, 0, op, "Player skills:"); 704
705 msg << "T<Player skills:>\n\n";
769 if (num_skills_found > 1) 706 if (num_skills_found > 1)
770 qsort (skills, num_skills_found, MAX_BUF, (int (*)(const void *, const void *)) std::strcmp); 707 qsort (skills, num_skills_found, sizeof (skills [0]), (int (*)(const void *, const void *)) std::strcmp);
771 708
772 for (i = 0; i < num_skills_found; i++) 709 for (i = 0; i < num_skills_found; i++)
773 new_draw_info (NDI_UNIQUE, 0, op, skills[i]); 710 msg << " C<" << skills [i] << ">\n";
774 711
775 new_draw_info_format (NDI_UNIQUE, 0, op, "You can handle %d weapon improvements.", op->level / 5 + 5); 712 msg << "\nYou can handle " << op->level / 5 + 5 << " weapon improvements.\r";
776 713
777 cp = determine_god (op); 714 cp = determine_god (op);
778 new_draw_info_format (NDI_UNIQUE, 0, op, "You worship %s.", cp ? cp : "no god at current time"); 715 msg << "You worship " << (cp ? cp : "no god at current time") << ".\r";
779 716
780 new_draw_info_format (NDI_UNIQUE, 0, op, "Your equipped item power is %d out of %d\n", 717 msg << "Your equipped item power is " << (int)op->contr->item_power
781 op->contr->item_power, (int) (op->level * settings.item_power_factor)); 718 << " out of " << int (op->level * settings.item_power_factor)
719 << ".\n";
720
721 op->contr->infobox (MSG_CHANNEL ("skills"), msg);
782} 722}
783 723
784/* use_skill() - similar to invoke command, it executes the skill in the 724/* use_skill() - similar to invoke command, it executes the skill in the
785 * direction that the user is facing. Returns false if we are unable to 725 * direction that the user is facing. Returns false if we are unable to
786 * change to the requested skill, or were unable to use the skill properly. 726 * change to the requested skill, or were unable to use the skill properly.
… …
794 size_t len; 734 size_t len;
795 735
796 if (!string) 736 if (!string)
797 return 0; 737 return 0;
798 738
799 for (skop = op->inv; skop != NULL; skop = skop->below) 739 for (skop = op->inv; skop; skop = skop->below)
800 { 740 {
741 if (skop->type == SKILL
801 if (skop->type == SKILL && QUERY_FLAG (skop, FLAG_CAN_USE_SKILL) && 742 && QUERY_FLAG (skop, FLAG_CAN_USE_SKILL)
802 !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill)))) 743 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill))))
803 break; 744 break;
745 else if (skop->type == SKILL_TOOL
804 else if (skop->type == SKILL_TOOL && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill)))) 746 && !strncasecmp (string, skop->skill, MIN (strlen (string), (size_t) strlen (skop->skill))))
805 break; 747 break;
806 } 748 }
749
807 if (!skop) 750 if (!skop)
808 { 751 {
809 new_draw_info_format (NDI_UNIQUE, 0, op, "Unable to find skill %s", string); 752 new_draw_info_format (NDI_UNIQUE, 0, op, "Unable to find skill %s", string);
810 return 0; 753 return 0;
811 } 754 }
… …
816 * options given to the skill. Its pretty simple - if there 759 * options given to the skill. Its pretty simple - if there
817 * are extra parameters (as deteremined by string length), we 760 * are extra parameters (as deteremined by string length), we
818 * want to skip over any leading spaces. 761 * want to skip over any leading spaces.
819 */ 762 */
820 if (len >= strlen (string)) 763 if (len >= strlen (string))
821 {
822 string = NULL; 764 string = NULL;
823 }
824 else 765 else
825 { 766 {
826 string += len; 767 string += len;
827 while (*string == 0x20) 768 while (*string == 0x20)
828 string++; 769 string++;
770
829 if (strlen (string) == 0) 771 if (strlen (string) == 0)
830 string = NULL; 772 string = NULL;
831 } 773 }
832 774
833#ifdef SKILL_UTIL_DEBUG 775#ifdef SKILL_UTIL_DEBUG
834 LOG (llevDebug, "use_skill() got skill: %s\n", sknum > -1 ? skills[sknum].name : "none"); 776 LOG (llevDebug, "use_skill() got skill: %s\n", sknum > -1 ? skills[sknum].name : "none");
835#endif 777#endif
836 778
837 /* Change to the new skill, then execute it. */
838 if (do_skill (op, op, skop, op->facing, string)) 779 if (do_skill (op, op, skop, op->facing, string))
839 return 1; 780 return 1;
840 781
841 return 0; 782 return 0;
842} 783}
… …
880 * the caller should have set it appropriately). We still want to pass 821 * the caller should have set it appropriately). We still want to pass
881 * through that code if skill is set to change to the skill. 822 * through that code if skill is set to change to the skill.
882 */ 823 */
883 if (player *pl = op->contr) 824 if (player *pl = op->contr)
884 { 825 {
885 if (!pl->combat_ob) 826 if (skill)
827 op->change_skill (skill);
828 else
886 { 829 {
887 if (QUERY_FLAG (op, FLAG_READY_WEAPON)) 830 if (!pl->combat_ob)
888 { 831 {
889 for (tmp = op->inv; tmp; tmp = tmp->below) 832 if (QUERY_FLAG (op, FLAG_READY_WEAPON))
890 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
891 break;
892
893 if (!tmp)
894 { 833 {
834 for (tmp = op->inv; tmp; tmp = tmp->below)
835 if (tmp->type == WEAPON && QUERY_FLAG (tmp, FLAG_APPLIED))
836 break;
837
838 if (!tmp)
895 LOG (llevError, "Could not find applied weapon on %s\n", &op->name); 839 LOG (llevError, "Could not find applied weapon on %s\n", &op->name);
896 return 0; 840
841 pl->combat_ob = tmp;
897 } 842 }
898 843
899 change_skill (op, find_skill_by_name (op, tmp->skill), 1); 844 if (!pl->combat_ob)
900 }
901 else
902 {
903 if (!skill)
904 { 845 {
905 /* See if the players chosen skill is a combat skill, and use 846 /* See if the players chosen skill is a combat skill, and use
906 * it if appropriate. 847 * it if appropriate.
907 */ 848 */
908 if (op->chosen_skill && hth_skill_p (op->chosen_skill)) 849 if (op->chosen_skill && hth_skill_p (op->chosen_skill))
… …
910 else 851 else
911 { 852 {
912 skill = find_player_hth_skill (op); 853 skill = find_player_hth_skill (op);
913 854
914 if (!skill) 855 if (!skill)
915 {
916 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!"); 856 new_draw_info (NDI_BLACK, 0, op, "You have no unarmed combat skills!");
917 return 0;
918 } 857 }
858
859 if (skill)
860 {
861 op->change_skill (0);
862 apply_special (op, skill, AP_APPLY);
919 } 863 }
920 } 864 }
921 865
922 /* now try to ready the new skill */ 866 if (!pl->combat_ob)
923 if (!change_skill (op, skill, 0)) 867 {
924 { /* oh oh, trouble! */ 868 LOG (llevError, "Could not find anything to attack on %s\n", &op->name);
925 new_draw_info_format (NDI_UNIQUE, 0, op, "Couldn't change to skill %s", &skill->name);
926 return 0; 869 return 0;
927 } 870 }
928 } 871 }
929 872
930 if (!pl->combat_ob) 873 if (!op->change_weapon (pl->combat_ob))
931 {
932 LOG (llevError, "Could not find anything to attack on %s\n", &op->name);
933 return 0; 874 return 0;
934 }
935 } 875 }
936
937 if (!op->change_weapon (pl->combat_ob))
938 return 0;
939 876
940 /* lose invisiblity/hiding status for running attacks */ 877 /* lose invisiblity/hiding status for running attacks */
941 if (pl->tmp_invis) 878 if (pl->tmp_invis)
942 { 879 {
943 pl->tmp_invis = 0; 880 pl->tmp_invis = 0;
… …
962 return success; 899 return success;
963} 900}
964 901
965/* skill_attack() - Core routine for use when we attack using a skills 902/* skill_attack() - Core routine for use when we attack using a skills
966 * system. In essence, this code handles 903 * system. In essence, this code handles
967 * all skill-based attacks, ie hth, missile and melee weapons should be 904 * all skill-based attacks, i.e. hth, missile and melee weapons should be
968 * treated here. If an opponent is already supplied by move_player(), 905 * treated here. If an opponent is already supplied by move_player(),
969 * we move right onto do_skill_attack(), otherwise we find if an 906 * we move right onto do_skill_attack(), otherwise we find if an
970 * appropriate opponent exists. 907 * appropriate opponent exists.
971 * 908 *
972 * This is called by move_player() and attack_hth() 909 * This is called by move_player() and attack_hth()
… …
1077 1014
1078 return 0; 1015 return 0;
1079 } 1016 }
1080 1017
1081 return skill_attack (NULL, op, dir, string, skill); 1018 return skill_attack (NULL, op, dir, string, skill);
1082
1083} 1019}
1020

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines