[ViewVC] Diff of: cvs/deliantra/server/server/skill

Comparing deliantra/server/server/skill_util.C (file contents):
Revision 1.94 by root, Sun Apr 11 00:34:06 2010 UTC vs.
Revision 1.97 by root, Thu Apr 15 00:36:51 2010 UTC

 # define def(uc, flags) flags,
 #  include "skillinc.h"
 # undef def
 };
+vector<object_ptr> skillvec;
 static int attack_hth (object *pl, int dir, const char *string, object *skill);
 static int attack_melee_weapon (object *op, int dir, const char *string, object *skill);
 /* init_skills basically just sets up the skill_names table
  * above.  The index into the array is set up by the
  * subtypes.
  */
 void
 init_skills ()
 {
-  for_all_archetypes (at)
+  // nop
-    if (at->type == SKILL)
+}
+void
+add_skill_archetype (object *o)
+{
+  printf ("<%s><%s>\n", &o->name, &o->skill);//D
+  assert (("skill name must equal skill skill", o->name == o->skill));
+  for (vector<object_ptr>::iterator i = skillvec.begin (); i != skillvec.end (); ++i)
+    if ((*i)->name == o->name)
       {
-        if (skill_names[at->subtype])
+        // replace existing entry
-          LOG (llevError, "init_skills: multiple skill using same subtype %d, %s, %s\n",
+        SKILL_INDEX (o) = i - skillvec.begin ();
-               at->subtype, &skill_names[at->subtype], &at->skill);
+        *i = o;
-        else
+        return;
-          skill_names[at->subtype] = at->skill;
       }
-  /* This isn't really an error if there is no skill subtype set, but
+  // add new entry
-   * checking for this may catch some user errors.
+  assert (("only CS_NUM_SKILLS skills supported by client protocol", skillvec.size () < CS_NUM_SKILLS));
-   */
+  SKILL_INDEX (o) = skillvec.size ();
-  for (int i = 1; i < NUM_SKILLS; i++)
+  skillvec.push_back (o);
-    if (!skill_names[i])
-      LOG (llevError, "init_skills: skill subtype %d doesn't have a name?\n", i);
 }
 /* This function goes through the player inventory and sets
  * up the last_skills[] array in the player object.
  * the last_skills[] is used to more quickly lookup skills -
  * mostly used for sending exp.
  */
 void
 player::link_skills ()
 {
-  for (int i = 0; i < NUM_SKILLS; ++i)
+  for (int i = 0; i < CS_NUM_SKILLS; ++i)
     last_skill_ob [i] = 0;
   for (object *tmp = ob->inv; tmp; tmp = tmp->below)
     if (tmp->type == SKILL)
       {
+        int idx = SKILL_INDEX (tmp);
-        assert (IN_RANGE_EXC (tmp->subtype, 0, NUM_SKILLS));
+        assert (IN_RANGE_EXC (idx, 0, CS_NUM_SKILLS));
-        if (last_skill_ob [tmp->subtype] != tmp)
+        if (last_skill_ob [idx] != tmp)
           {
-            /* This is really a warning, hence no else below */
-            if (last_skill_ob [tmp->subtype])
-              LOG (llevError, "Multiple skills with the same subtype? %s, %s\n",
-                   &last_skill_ob [tmp->subtype]->skill, &tmp->skill);
-            last_skill_ob [tmp->subtype] = tmp;
+            last_skill_ob [idx] = tmp;
             if (ns)
-              ns->last_skill_exp [tmp->subtype] = -1;
+              ns->last_skill_exp [idx] = -1;
           }
       }
 }
 static object *
       return splay (tmp);
   return 0;
 }
+object *
-object *player::find_skill (shstr_cmp name) const
+player::find_skill (shstr_cmp name) const
 {
   // might want to use last_skill_obj at one point, or maybe not
   return ::find_skill (ob, name);
 }
   /* Player has a tool to use the skill. If not applied, apply it -
    * if not successful, return null. If they do have the skill tool
    * but not the skill itself, give it to them.
    */
-  object *skill = find_skill (who, skill_tool->skill);
+  object *skill = who->give_skill (skill_tool->skill);
-  if (!skill)
-    skill = give_skill_by_name (who, skill_tool->skill);
   if (!skill_tool->flag [FLAG_APPLIED])
     if (!who->apply (splay (skill_tool)))
       return 0;
  * tool, this code will equip it.
  *
  * This code is basically the same as find_skill_by_name() above,
  * but instead a skill name, we search by matching number.
  * this replaces find_skill.
+ *
+ * MUST NOT BE USED IN NEW CODE! (schmorp)
  */
 object *
 find_skill_by_number (object *who, int skillno)
 {
   for (object *tmp = who->inv; tmp; tmp = tmp->below)
     if (tmp->type == SKILL && tmp->subtype == skillno)
       if (object *skop = find_skill_by_name (who, tmp->skill))
         return skop;
   return 0;
+}
+object *
+object::give_skill (shstr_cmp name, bool can_use)
+{
+  object *skill = find_skill (this, name);
+  if (!skill)
+    skill = give_skill_by_name (this, name);
+  if (skill && can_use)
+    skill->flag [FLAG_CAN_USE_SKILL] = true;
+  return skill;
 }
 /* do_skill() - Main skills use function-similar in scope to cast_spell().
  * We handle all requests for skill use outside of some combat here.
  * We require a separate routine outside of fire() so as to allow monsters
         new_draw_info (NDI_UNIQUE, 0, op, "This skill is already in effect.");
         break;
       case SK_MINING:
         success = skill_mining (op, part, skill, dir, string);
-        break;
-      case SK_FISHING:
-        success = skill_fishing (op, part, skill, dir, string);
         break;
       default:
         LOG (llevDebug, "%s attempted to use unknown skill: %d\n", query_name (op), op->chosen_skill->stats.sp);
         break;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/server/skill_util.C (file contents): Revision 1.94 by root, Sun Apr 11 00:34:06 2010 UTC vs. Revision 1.97 by root, Thu Apr 15 00:36:51 2010 UTC

Diff Legend

Comparing deliantra/server/server/skill_util.C (file contents):
Revision 1.94 by root, Sun Apr 11 00:34:06 2010 UTC vs.
Revision 1.97 by root, Thu Apr 15 00:36:51 2010 UTC