ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/skills.C
(Generate patch)

Comparing deliantra/server/server/skills.C (file contents):
Revision 1.11 by root, Sat Sep 16 22:24:13 2006 UTC vs.
Revision 1.50 by root, Tue Apr 22 07:01:47 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2003 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2003,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The authors can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23 23
24#include <global.h> 24#include <global.h>
25#include <object.h> 25#include <object.h>
26#ifndef __CEXTRACT__
27# include <sproto.h> 26#include <sproto.h>
28#endif
29#include <living.h> 27#include <living.h>
30#include <skills.h> 28#include <skills.h>
31#include <spells.h> 29#include <spells.h>
32#include <book.h> 30#include <book.h>
33 31
… …
41 return -1; 39 return -1;
42 40
43 /* Only prohibit stealing if the player does not have a free 41 /* Only prohibit stealing if the player does not have a free
44 * hand available and in fact does have hands. 42 * hand available and in fact does have hands.
45 */ 43 */
46 if (op->type == PLAYER && op->body_used[BODY_ARMS] <= 0 && op->body_info[BODY_ARMS]) 44 if (op->type == PLAYER && op->slot[body_arm].used <= 0 && op->slot[body_arm].info)
47 { 45 {
48 new_draw_info (NDI_UNIQUE, 0, op, "But you have no free hands to steal with!"); 46 new_draw_info (NDI_UNIQUE, 0, op, "But you have no free hands to steal with!");
49 return -1; 47 return -1;
50 } 48 }
51 49
… …
94 * or not. 92 * or not.
95 * op is the target (person being pilfered) 93 * op is the target (person being pilfered)
96 * who is the person doing the stealing. 94 * who is the person doing the stealing.
97 * skill is the skill object (stealing). 95 * skill is the skill object (stealing).
98 */ 96 */
99
100static int 97static int
101attempt_steal (object *op, object *who, object *skill) 98attempt_steal (object *op, object *who, object *skill)
102{ 99{
103 object *success = NULL, *tmp = NULL, *next; 100 object *success = NULL, *tmp = NULL, *next;
104 int roll = 0, chance = 0, stats_value; 101 int roll = 0, chance = 0, stats_value;
… …
122 else /* help npc to detect thief next time by raising its wisdom */ 119 else /* help npc to detect thief next time by raising its wisdom */
123 op->stats.Wis += (op->stats.Int / 5) + 1; 120 op->stats.Wis += (op->stats.Int / 5) + 1;
124 if (op->stats.Wis > MAX_STAT) 121 if (op->stats.Wis > MAX_STAT)
125 op->stats.Wis = MAX_STAT; 122 op->stats.Wis = MAX_STAT;
126 } 123 }
124
127 if (op->type == PLAYER && QUERY_FLAG (op, FLAG_WIZ)) 125 if (op->type == PLAYER && QUERY_FLAG (op, FLAG_WIZ))
128 { 126 {
129 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from the dungeon master!\n"); 127 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from the dungeon master!\n");
130 return 0; 128 return 0;
131 } 129 }
132#ifdef PROHIBIT_PLAYERKILL 130
131 // only allow stealing between hostile players (TODO: probably should change)
133 if (op->type == PLAYER && who->type == PLAYER && (who->contr->peaceful || op->contr->peaceful)) 132 if (op->type == PLAYER && who->type == PLAYER && (who->contr->peaceful || op->contr->peaceful))
134 { 133 {
135 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from other players!\n"); 134 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from other players!\n");
136 return 0; 135 return 0;
137 } 136 }
138#else
139 if (op->type == PLAYER && who->type == PLAYER && settings.no_player_stealing)
140 {
141 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from other players!\n");
142 return 0;
143 }
144#endif
145
146 137
147 /* Ok then, go thru their inventory, stealing */ 138 /* Ok then, go thru their inventory, stealing */
148 for (tmp = op->inv; tmp != NULL; tmp = next) 139 for (tmp = op->inv; tmp; tmp = next)
149 { 140 {
150 next = tmp->below; 141 next = tmp->below;
151 142
152 /* you can't steal worn items, starting items, wiz stuff, 143 /* you can't steal worn items, starting items, wiz stuff,
153 * innate abilities, or items w/o a type. Generally 144 * innate abilities, or items w/o a type. Generally
… …
157 * future possible problems. -b.t. 148 * future possible problems. -b.t.
158 * Flesh items generated w/ fix_flesh_item should have FLAG_NO_STEAL 149 * Flesh items generated w/ fix_flesh_item should have FLAG_NO_STEAL
159 * already -b.t. 150 * already -b.t.
160 */ 151 */
161 152
162 if (QUERY_FLAG (tmp, FLAG_WAS_WIZ) || QUERY_FLAG (tmp, FLAG_APPLIED) 153 if (QUERY_FLAG (tmp, FLAG_APPLIED)
163 || !(tmp->type) 154 || !tmp->type
164 || tmp->type == EXPERIENCE || tmp->type == SPELL 155 || tmp->type == SPELL
165 || QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_STEAL) || tmp->invisible) 156 || QUERY_FLAG (tmp, FLAG_STARTEQUIP)
157 || QUERY_FLAG (tmp, FLAG_NO_STEAL)
158 || tmp->invisible)
166 continue; 159 continue;
167 160
168 /* Okay, try stealing this item. Dependent on dexterity of thief, 161 /* Okay, try stealing this item. Dependent on dexterity of thief,
169 * skill level, see the adj_stealroll fctn for more detail. 162 * skill level, see the adj_stealroll fctn for more detail.
170 */ 163 */
… …
184 if (tmp->destroyed () || tmp->env != op) 177 if (tmp->destroyed () || tmp->env != op)
185 { 178 {
186 /* for players, play_sound: steals item */ 179 /* for players, play_sound: steals item */
187 success = tmp; 180 success = tmp;
188 CLEAR_FLAG (tmp, FLAG_INV_LOCKED); 181 CLEAR_FLAG (tmp, FLAG_INV_LOCKED);
189
190 /* Don't delete it from target player until we know
191 * the thief has picked it up. can't just look at tmp->count,
192 * as it's possible that it got merged when picked up.
193 */
194 if (op->type == PLAYER)
195 esrv_del_item (op->contr, tmp->count);
196 } 182 }
183
197 break; 184 break;
198 } 185 }
199 } /* for loop looking for an item */ 186 } /* for loop looking for an item */
200 187
201 if (!tmp) 188 if (!tmp)
… …
261 /* play_sound("stop! thief!"); kindofthing */ 248 /* play_sound("stop! thief!"); kindofthing */
262 } /* if you weren't 100% successful */ 249 } /* if you weren't 100% successful */
263 return success ? 1 : 0; 250 return success ? 1 : 0;
264} 251}
265 252
266
267int 253int
268steal (object *op, int dir, object *skill) 254steal (object *op, int dir, object *skill)
269{ 255{
270 object *tmp, *next; 256 object *tmp, *next;
271 sint16 x, y; 257 sint16 x, y;
… …
292 /* If player can't move onto the space, can't steal from it. */ 278 /* If player can't move onto the space, can't steal from it. */
293 if (OB_TYPE_MOVE_BLOCK (op, GET_MAP_MOVE_BLOCK (m, x, y))) 279 if (OB_TYPE_MOVE_BLOCK (op, GET_MAP_MOVE_BLOCK (m, x, y)))
294 return 0; 280 return 0;
295 281
296 /* Find the topmost object at this spot */ 282 /* Find the topmost object at this spot */
297 for (tmp = get_map_ob (m, x, y); tmp != NULL && tmp->above != NULL; tmp = tmp->above); 283 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL && tmp->above != NULL; tmp = tmp->above);
298 284
299 /* For all the stacked objects at this point, attempt a steal */ 285 /* For all the stacked objects at this point, attempt a steal */
300 for (; tmp != NULL; tmp = next) 286 for (; tmp != NULL; tmp = next)
301 { 287 {
302 next = tmp->below; 288 next = tmp->below;
… …
318 return 0; 304 return 0;
319 305
320 /* no xp for stealing from pets (of players) */ 306 /* no xp for stealing from pets (of players) */
321 if (QUERY_FLAG (tmp, FLAG_FRIENDLY) && tmp->attack_movement == PETMOVE) 307 if (QUERY_FLAG (tmp, FLAG_FRIENDLY) && tmp->attack_movement == PETMOVE)
322 { 308 {
323 object *owner = get_owner (tmp); 309 object *owner = tmp->owner;
324 310
325 if (owner != NULL && owner->type == PLAYER) 311 if (owner != NULL && owner->type == PLAYER)
326 return 0; 312 return 0;
327 } 313 }
328 314
… …
383 { 369 {
384 new_draw_info (NDI_UNIQUE, 0, pl, "There is no lock there."); 370 new_draw_info (NDI_UNIQUE, 0, pl, "There is no lock there.");
385 return 0; 371 return 0;
386 } 372 }
387 373
388 for (tmp = get_map_ob (pl->map, x, y); tmp; tmp = tmp->above) 374 for (tmp = GET_MAP_OB (pl->map, x, y); tmp; tmp = tmp->above)
389 if (tmp->type == DOOR || tmp->type == LOCKED_DOOR) 375 if (tmp->type == DOOR || tmp->type == LOCKED_DOOR)
390 break; 376 break;
391 377
392 if (!tmp) 378 if (!tmp)
393 { 379 {
… …
415 { 401 {
416 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to pick the lock."); 402 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to pick the lock.");
417 return 0; 403 return 0;
418 } 404 }
419} 405}
420
421 406
422/* HIDE CODE. The user becomes undetectable (not just 'invisible') for 407/* HIDE CODE. The user becomes undetectable (not just 'invisible') for
423 * a short while (success and duration dependant on player SK_level, 408 * a short while (success and duration dependant on player SK_level,
424 * dexterity, charisma, and map difficulty). 409 * dexterity, charisma, and map difficulty).
425 * Players have a good chance of becoming 'unhidden' if they move 410 * Players have a good chance of becoming 'unhidden' if they move
426 * and like invisiblity will be come visible if they attack 411 * and like invisiblity will be come visible if they attack
427 * Implemented by b.t. (thomas@astro.psu.edu) 412 * Implemented by b.t. (thomas@astro.psu.edu)
428 * July 7, 1995 - made hiding possible for monsters. -b.t. 413 * July 7, 1995 - made hiding possible for monsters. -b.t.
429 */ 414 */
430
431static int 415static int
432attempt_hide (object *op, object *skill) 416attempt_hide (object *op, object *skill)
433{ 417{
434 int number, difficulty = op->map->difficulty; 418 int number, difficulty = op->map->difficulty;
435 int terrain = hideability (op); 419 int terrain = hideability (op);
… …
438 return 0; 422 return 0;
439 423
440 /* Hiding success and duration dependant on skill level, 424 /* Hiding success and duration dependant on skill level,
441 * op->stats.Dex, map difficulty and terrain. 425 * op->stats.Dex, map difficulty and terrain.
442 */ 426 */
443
444 number = (die_roll (2, 25, op, PREFER_LOW) - 2) / 2; 427 number = (die_roll (2, 25, op, PREFER_LOW) - 2) / 2;
428
445 if (!stand_near_hostile (op) && (number < (op->stats.Dex + skill->level + terrain - difficulty))) 429 if (!stand_near_hostile (op) && (number < (op->stats.Dex + skill->level + terrain - difficulty)))
446 { 430 {
447 op->invisible += 100; /* set the level of 'hiddeness' */ 431 op->invisible += 100; /* set the level of 'hiddeness' */
432
448 if (op->type == PLAYER) 433 if (op->type == PLAYER)
449 op->contr->tmp_invis = 1; 434 op->contr->tmp_invis = 1;
435
450 op->hide = 1; 436 op->hide = 1;
451 return 1; 437 return 1;
452 } 438 }
439
453 return 0; 440 return 0;
454} 441}
455 442
456/* patched this to take terrain into consideration */ 443/* patched this to take terrain into consideration */
457int 444int
458hide (object *op, object *skill) 445hide (object *op, object *skill)
459{ 446{
460
461 /* the preliminaries -- Can we really hide now? */ 447 /* the preliminaries -- Can we really hide now? */
462 /* this keeps monsters from using invisibilty spells and hiding */ 448 /* this keeps monsters from using invisibilty spells and hiding */
463 449
464 if (QUERY_FLAG (op, FLAG_MAKE_INVIS)) 450 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
465 { 451 {
… …
470 { 456 {
471 new_draw_info (NDI_UNIQUE, 0, op, "Your attempt to hide breaks the invisibility spell!"); 457 new_draw_info (NDI_UNIQUE, 0, op, "Your attempt to hide breaks the invisibility spell!");
472 make_visible (op); 458 make_visible (op);
473 } 459 }
474 460
475 if (op->invisible > (50 * skill->level)) 461 if (op->invisible > 50 * skill->level)
476 { 462 {
477 new_draw_info (NDI_UNIQUE, 0, op, "You are as hidden as you can get."); 463 new_draw_info (NDI_UNIQUE, 0, op, "You are as hidden as you can get.");
478 return 0; 464 return 0;
479 } 465 }
480 466
… …
482 { 468 {
483 new_draw_info (NDI_UNIQUE, 0, op, "You hide in the shadows."); 469 new_draw_info (NDI_UNIQUE, 0, op, "You hide in the shadows.");
484 update_object (op, UP_OBJ_FACE); 470 update_object (op, UP_OBJ_FACE);
485 return calc_skill_exp (op, NULL, skill); 471 return calc_skill_exp (op, NULL, skill);
486 } 472 }
473
487 new_draw_info (NDI_UNIQUE, 0, op, "You fail to conceal yourself."); 474 new_draw_info (NDI_UNIQUE, 0, op, "You fail to conceal yourself.");
488 return 0; 475 return 0;
489} 476}
490
491 477
492/* stop_jump() - End of jump. Clear flags, restore the map, and 478/* stop_jump() - End of jump. Clear flags, restore the map, and
493 * freeze the jumper a while to simulate the exhaustion 479 * freeze the jumper a while to simulate the exhaustion
494 * of jumping. 480 * of jumping.
495 */ 481 */
496static void 482static void
497stop_jump (object *pl, int dist, int spaces) 483stop_jump (object *pl, int dist, int spaces)
498{ 484{
499 fix_player (pl); 485 pl->update_stats ();
500 insert_ob_in_map (pl, pl->map, pl, 0); 486 pl->map->insert (pl, pl->x, pl->y, pl);
501} 487}
502
503 488
504static int 489static int
505attempt_jump (object *pl, int dir, int spaces, object *skill) 490attempt_jump (object *pl, int dir, int spaces, object *skill)
506{ 491{
507 object *tmp; 492 object *tmp;
508 int i, exp = 0, dx = freearr_x[dir], dy = freearr_y[dir], mflags; 493 int i, exp = 0, dx = freearr_x[dir], dy = freearr_y[dir], mflags;
509 sint16 x, y; 494 sint16 x, y;
510 maptile *m; 495 maptile *m;
511 496
512 /* Jump loop. Go through spaces opject wants to jump. Halt the 497 /* Jump loop. Go through spaces object wants to jump. Halt the
513 * jump if a wall or creature is in the way. We set FLAG_FLYING 498 * jump if a wall or creature is in the way. We set FLAG_FLYING
514 * temporarily to allow player to aviod exits/archs that are not 499 * temporarily to allow player to aviod exits/archs that are not
515 * fly_on, fly_off. This will also prevent pickup of objects 500 * fly_on, fly_off. This will also prevent pickup of objects
516 * while jumping over them. 501 * while jumping over them.
517 */ 502 */
518 503 pl->remove ();
519 remove_ob (pl);
520 504
521 /* 505 /*
522 * I don't think this is actually needed - all the movement 506 * I don't think this is actually needed - all the movement
523 * code is handled in this function, and I don't see anyplace 507 * code is handled in this function, and I don't see anyplace
524 * that cares about the move_type being flying. 508 * that cares about the move_type being flying.
… …
533 517
534 mflags = get_map_flags (m, &m, x, y, &x, &y); 518 mflags = get_map_flags (m, &m, x, y, &x, &y);
535 519
536 if (mflags & P_OUT_OF_MAP) 520 if (mflags & P_OUT_OF_MAP)
537 { 521 {
538 (void) stop_jump (pl, i, spaces); 522 stop_jump (pl, i, spaces);
539 return 0; 523 return 0;
540 } 524 }
525
541 if (OB_TYPE_MOVE_BLOCK (pl, GET_MAP_MOVE_BLOCK (m, x, y))) 526 if (OB_TYPE_MOVE_BLOCK (pl, GET_MAP_MOVE_BLOCK (m, x, y)))
542 { 527 {
543 new_draw_info (NDI_UNIQUE, 0, pl, "Your jump is blocked."); 528 new_draw_info (NDI_UNIQUE, 0, pl, "Your jump is blocked.");
544 stop_jump (pl, i, spaces); 529 stop_jump (pl, i, spaces);
545 return 0; 530 return 0;
546 } 531 }
547 532
548 for (tmp = get_map_ob (m, x, y); tmp; tmp = tmp->above) 533 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
549 { 534 {
550 /* Jump into creature */ 535 /* Jump into creature */
551 if (QUERY_FLAG (tmp, FLAG_MONSTER) || (tmp->type == PLAYER && (!QUERY_FLAG (tmp, FLAG_WIZ) || !tmp->contr->hidden))) 536 if (QUERY_FLAG (tmp, FLAG_MONSTER) || (tmp->type == PLAYER && (!QUERY_FLAG (tmp, FLAG_WIZ) || !tmp->contr->hidden)))
552 { 537 {
553 new_draw_info_format (NDI_UNIQUE, 0, pl, "You jump into %s%s.", tmp->type == PLAYER ? "" : "the ", &tmp->name); 538 new_draw_info_format (NDI_UNIQUE, 0, pl, "You jump into %s%s.", tmp->type == PLAYER ? "" : "the ", &tmp->name);
539
540 stop_jump (pl, i, spaces);
541
554 if (tmp->type != PLAYER || 542 if (tmp->type != PLAYER ||
555 (pl->type == PLAYER && pl->contr->party == NULL) || 543 (pl->type == PLAYER && pl->contr->party == NULL) ||
556 (pl->type == PLAYER && tmp->type == PLAYER && pl->contr->party != tmp->contr->party)) 544 (pl->type == PLAYER && tmp->type == PLAYER && pl->contr->party != tmp->contr->party))
557 exp = skill_attack (tmp, pl, pl->facing, "kicked", skill); /* pl makes an attack */ 545 exp = skill_attack (tmp, pl, pl->facing, "kicked", skill); /* pl makes an attack */
558 stop_jump (pl, i, spaces); 546
559 return exp; /* note that calc_skill_exp() is already called by skill_attack() */ 547 return exp; /* note that calc_skill_exp() is already called by skill_attack() */
560 } 548 }
549
561 /* If the space has fly on set (no matter what the space is), 550 /* If the space has fly on set (no matter what the space is),
562 * we should get the effects - after all, the player is 551 * we should get the effects - after all, the player is
563 * effectively flying. 552 * effectively flying.
564 */ 553 */
565 if (tmp->move_on & MOVE_FLY_LOW) 554 if (tmp->move_on & MOVE_FLY_LOW)
… …
569 pl->map = m; 558 pl->map = m;
570 stop_jump (pl, i, spaces); 559 stop_jump (pl, i, spaces);
571 return calc_skill_exp (pl, NULL, skill); 560 return calc_skill_exp (pl, NULL, skill);
572 } 561 }
573 } 562 }
563
574 pl->x = x; 564 pl->x = x;
575 pl->y = y; 565 pl->y = y;
576 pl->map = m; 566 pl->map = m;
577 } 567 }
568
578 stop_jump (pl, i, spaces); 569 stop_jump (pl, i, spaces);
570
579 return calc_skill_exp (pl, NULL, skill); 571 return calc_skill_exp (pl, NULL, skill);
580} 572}
581 573
582/* jump() - this is both a new type of movement for player/monsters and 574/* jump() - this is both a new type of movement for player/monsters and
583 * an attack as well. 575 * an attack as well.
584 * Perhaps we should allow more spaces based on level, eg, level 50 576 * Perhaps we should allow more spaces based on level, eg, level 50
585 * jumper can jump several spaces? 577 * jumper can jump several spaces?
586 */ 578 */
587
588int 579int
589jump (object *pl, int dir, object *skill) 580jump (object *pl, int dir, object *skill)
590{ 581{
591 int spaces = 0, stats;
592 int str = pl->stats.Str; 582 int str = pl->stats.Str;
593 int dex = pl->stats.Dex; 583 int dex = pl->stats.Dex;
594 584
595 dex = dex ? dex : 15; 585 dex = dex ? dex : 15;
596 str = str ? str : 10; 586 str = str ? str : 10;
597 587
598 stats = str * str * str * dex * skill->level; 588 int stats = str * str * str * dex * skill->level;
589 int spaces = min (3, skill->level, stats / (pl->carrying + 1));
599 590
600 if (pl->carrying != 0) /* don't want div by zero !! */
601 spaces = (int) (stats / pl->carrying);
602 else
603 spaces = 2; /* pl has no objects - gets the far jump */
604
605 if (spaces > 2)
606 spaces = 2;
607 else if (spaces == 0) 591 if (spaces == 0)
608 { 592 {
609 new_draw_info (NDI_UNIQUE, 0, pl, "You are carrying too much weight to jump."); 593 new_draw_info (NDI_UNIQUE, 0, pl, "You are carrying too much weight to jump.");
610 return 0; 594 return 0;
611 } 595 }
596
612 return attempt_jump (pl, dir, spaces, skill); 597 return attempt_jump (pl, dir, spaces, skill);
613} 598}
614
615 599
616/* skill_ident() - this code is supposed to allow players to identify 600/* skill_ident() - this code is supposed to allow players to identify
617 * classes of objects with the various "auto-ident" skills. Player must 601 * classes of objects with the various "auto-ident" skills. Player must
618 * have unidentified objects of the right type in order for the skill 602 * have unidentified objects of the right type in order for the skill
619 * to work. While multiple classes of objects may be identified, 603 * to work. While multiple classes of objects may be identified,
620 * this code is kind of yucky -- it would be nice to make it a bit 604 * this code is kind of yucky -- it would be nice to make it a bit
621 * more generalized. Right now, skill indices are embedded in this routine. 605 * more generalized. Right now, skill indices are embedded in this routine.
622 * Returns amount of experience gained (on successful ident). 606 * Returns amount of experience gained (on successful ident).
623 * - b.t. (thomas@astro.psu.edu) 607 * - b.t. (thomas@astro.psu.edu)
624 */ 608 */
625
626static int 609static int
627do_skill_detect_curse (object *pl, object *skill) 610do_skill_detect_curse (object *pl, object *skill)
628{ 611{
629 object *tmp; 612 object *tmp;
630 int success = 0; 613 int success = 0;
… …
638 esrv_update_item (UPD_FLAGS, pl, tmp); 621 esrv_update_item (UPD_FLAGS, pl, tmp);
639 success += calc_skill_exp (pl, tmp, skill); 622 success += calc_skill_exp (pl, tmp, skill);
640 } 623 }
641 624
642 /* Check ground, too, but only objects the player could pick up */ 625 /* Check ground, too, but only objects the player could pick up */
643 for (tmp = get_map_ob (pl->map, pl->x, pl->y); tmp; tmp = tmp->above) 626 for (tmp = GET_MAP_OB (pl->map, pl->x, pl->y); tmp; tmp = tmp->above)
644 if (can_pick (pl, tmp) && 627 if (can_pick (pl, tmp) &&
645 !QUERY_FLAG (tmp, FLAG_IDENTIFIED) && 628 !QUERY_FLAG (tmp, FLAG_IDENTIFIED) &&
646 !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED) 629 !QUERY_FLAG (tmp, FLAG_KNOWN_CURSED)
647 && (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->item_power < skill->level) 630 && (QUERY_FLAG (tmp, FLAG_CURSED) || QUERY_FLAG (tmp, FLAG_DAMNED)) && tmp->item_power < skill->level)
648 { 631 {
… …
669 esrv_update_item (UPD_FLAGS, pl, tmp); 652 esrv_update_item (UPD_FLAGS, pl, tmp);
670 success += calc_skill_exp (pl, tmp, skill); 653 success += calc_skill_exp (pl, tmp, skill);
671 } 654 }
672 655
673 /* Check ground, too, but like above, only if the object can be picked up */ 656 /* Check ground, too, but like above, only if the object can be picked up */
674 for (tmp = get_map_ob (pl->map, pl->x, pl->y); tmp; tmp = tmp->above) 657 for (tmp = GET_MAP_OB (pl->map, pl->x, pl->y); tmp; tmp = tmp->above)
675 if (can_pick (pl, tmp) && 658 if (can_pick (pl, tmp) &&
676 !QUERY_FLAG (tmp, FLAG_IDENTIFIED) && !QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && (is_magical (tmp)) && tmp->item_power < skill->level) 659 !QUERY_FLAG (tmp, FLAG_IDENTIFIED) && !QUERY_FLAG (tmp, FLAG_KNOWN_MAGICAL) && (is_magical (tmp)) && tmp->item_power < skill->level)
677 { 660 {
678 SET_FLAG (tmp, FLAG_KNOWN_MAGICAL); 661 SET_FLAG (tmp, FLAG_KNOWN_MAGICAL);
679 esrv_update_item (UPD_FLAGS, pl, tmp); 662 esrv_update_item (UPD_FLAGS, pl, tmp);
… …
708 if (tmp->msg) 691 if (tmp->msg)
709 { 692 {
710 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 693 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:");
711 new_draw_info (NDI_UNIQUE, 0, pl, tmp->msg); 694 new_draw_info (NDI_UNIQUE, 0, pl, tmp->msg);
712 } 695 }
713
714 /* identify will take care of updating the item if it is in the players inventory. IF on map, do it here */
715 if (tmp->map)
716 esrv_send_item (pl, tmp);
717 } 696 }
697
718 success += calc_skill_exp (pl, tmp, skill); 698 success += calc_skill_exp (pl, tmp, skill);
719 } 699 }
720 else 700 else
721 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); 701 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT);
722 } 702 }
… …
727/* do_skill_ident() - workhorse for skill_ident() -b.t. 707/* do_skill_ident() - workhorse for skill_ident() -b.t.
728 */ 708 */
729static int 709static int
730do_skill_ident (object *pl, int obj_class, object *skill) 710do_skill_ident (object *pl, int obj_class, object *skill)
731{ 711{
732 object *tmp;
733 int success = 0; 712 int success = 0;
734 713
735 for (tmp = pl->inv; tmp; tmp = tmp->below) 714 for (object *tmp = pl->inv; tmp; tmp = tmp->below)
736 success += do_skill_ident2 (tmp, pl, obj_class, skill); 715 success += do_skill_ident2 (tmp, pl, obj_class, skill);
737 /* check the ground */ 716 /* check the ground */
738 717
739 for (tmp = get_map_ob (pl->map, pl->x, pl->y); tmp; tmp = tmp->above) 718 for (object *tmp = pl->ms ().bot; tmp; tmp = tmp->above)
740 success += do_skill_ident2 (tmp, pl, obj_class, skill); 719 success += do_skill_ident2 (tmp, pl, obj_class, skill);
741 720
742 return success; 721 return success;
743} 722}
744 723
… …
752 731
753 new_draw_info (NDI_UNIQUE, 0, pl, "You look at the objects nearby..."); 732 new_draw_info (NDI_UNIQUE, 0, pl, "You look at the objects nearby...");
754 733
755 switch (skill->subtype) 734 switch (skill->subtype)
756 { 735 {
757 case SK_SMITHERY: 736 case SK_SMITHERY:
758 success += do_skill_ident (pl, WEAPON, skill) + do_skill_ident (pl, ARMOUR, skill) 737 success += do_skill_ident (pl, WEAPON, skill) + do_skill_ident (pl, ARMOUR, skill)
759 + do_skill_ident (pl, BRACERS, skill) + do_skill_ident (pl, CLOAK, skill) 738 + do_skill_ident (pl, BRACERS, skill) + do_skill_ident (pl, CLOAK, skill)
760 + do_skill_ident (pl, BOOTS, skill) + do_skill_ident (pl, SHIELD, skill) 739 + do_skill_ident (pl, BOOTS, skill) + do_skill_ident (pl, SHIELD, skill)
761 + do_skill_ident (pl, GIRDLE, skill) + do_skill_ident (pl, HELMET, skill) + do_skill_ident (pl, GLOVES, skill); 740 + do_skill_ident (pl, GIRDLE, skill) + do_skill_ident (pl, HELMET, skill) + do_skill_ident (pl, GLOVES, skill);
762 break; 741 break;
763 742
764 case SK_BOWYER: 743 case SK_BOWYER:
765 success += do_skill_ident (pl, BOW, skill) + do_skill_ident (pl, ARROW, skill); 744 success += do_skill_ident (pl, BOW, skill) + do_skill_ident (pl, ARROW, skill);
766 break; 745 break;
767 746
768 case SK_ALCHEMY: 747 case SK_ALCHEMY:
769 success += do_skill_ident (pl, POTION, skill) + do_skill_ident (pl, POISON, skill) 748 success += do_skill_ident (pl, POTION, skill) + do_skill_ident (pl, POISON, skill)
770 + do_skill_ident (pl, CONTAINER, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, INORGANIC, skill); 749 + do_skill_ident (pl, CONTAINER, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, INORGANIC, skill);
771 break; 750 break;
772 751
773 case SK_WOODSMAN: 752 case SK_WOODSMAN:
774 success += do_skill_ident (pl, FOOD, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, FLESH, skill); 753 success += do_skill_ident (pl, FOOD, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, FLESH, skill);
775 break; 754 break;
776 755
777 case SK_JEWELER: 756 case SK_JEWELER:
778 success += do_skill_ident (pl, GEM, skill) + do_skill_ident (pl, RING, skill) + do_skill_ident (pl, AMULET, skill); 757 success += do_skill_ident (pl, GEM, skill) + do_skill_ident (pl, RING, skill) + do_skill_ident (pl, AMULET, skill);
779 break; 758 break;
780 759
781 case SK_LITERACY: 760 case SK_LITERACY:
782 success += do_skill_ident (pl, SPELLBOOK, skill) + do_skill_ident (pl, SCROLL, skill) + do_skill_ident (pl, BOOK, skill); 761 success += do_skill_ident (pl, SPELLBOOK, skill) + do_skill_ident (pl, SCROLL, skill) + do_skill_ident (pl, BOOK, skill);
783 break; 762 break;
784 763
785 case SK_THAUMATURGY: 764 case SK_THAUMATURGY:
786 success += do_skill_ident (pl, WAND, skill) + do_skill_ident (pl, ROD, skill) + do_skill_ident (pl, HORN, skill); 765 success += do_skill_ident (pl, WAND, skill) + do_skill_ident (pl, ROD, skill) + do_skill_ident (pl, HORN, skill);
787 break; 766 break;
788 767
789 case SK_DET_CURSE: 768 case SK_DET_CURSE:
790 success = do_skill_detect_curse (pl, skill); 769 success = do_skill_detect_curse (pl, skill);
791 if (success) 770 if (success)
792 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover cursed items!"); 771 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover cursed items!");
793 break; 772 break;
794 773
795 case SK_DET_MAGIC: 774 case SK_DET_MAGIC:
796 success = do_skill_detect_magic (pl, skill); 775 success = do_skill_detect_magic (pl, skill);
797 if (success) 776 if (success)
798 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover items imbued with mystic forces!"); 777 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover items imbued with mystic forces!");
799 break; 778 break;
800 779
801 default: 780 default:
802 LOG (llevError, "Error: bad call to skill_ident()\n"); 781 LOG (llevError, "Error: bad call to skill_ident()\n");
803 return 0; 782 return 0;
804 break; 783 break;
805 } 784 }
785
806 if (!success) 786 if (!success)
807 {
808 new_draw_info (NDI_UNIQUE, 0, pl, "...and learn nothing more."); 787 new_draw_info (NDI_UNIQUE, 0, pl, "...and learn nothing more.");
809 } 788
810 return success; 789 return success;
811} 790}
812
813 791
814/* players using this skill can 'charm' a monster -- 792/* players using this skill can 'charm' a monster --
815 * into working for them. It can only be used on 793 * into working for them. It can only be used on
816 * non-special (see below) 'neutral' creatures. 794 * non-special (see below) 'neutral' creatures.
817 * -b.t. (thomas@astro.psu.edu) 795 * -b.t. (thomas@astro.psu.edu)
818 */ 796 */
819
820int 797int
821use_oratory (object *pl, int dir, object *skill) 798use_oratory (object *pl, int dir, object *skill)
822{ 799{
823 sint16 x = pl->x + freearr_x[dir], y = pl->y + freearr_y[dir];
824 int mflags, chance;
825 object *tmp;
826 maptile *m;
827
828 if (pl->type != PLAYER) 800 if (pl->type != PLAYER)
829 return 0; /* only players use this skill */ 801 return 0; /* only players use this skill */
802
803 sint16 x = pl->x + freearr_x[dir],
804 y = pl->y + freearr_y[dir];
830 m = pl->map; 805 maptile *m = pl->map;
806
831 mflags = get_map_flags (m, &m, x, y, &x, &y); 807 int mflags = get_map_flags (m, &m, x, y, &x, &y);
832 if (mflags & P_OUT_OF_MAP) 808 if (mflags & P_OUT_OF_MAP)
833 return 0; 809 return 0;
834 810
835 /* Save some processing - we have the flag already anyways 811 /* Save some processing - we have the flag already anyways
836 */ 812 */
… …
838 { 814 {
839 new_draw_info (NDI_UNIQUE, 0, pl, "There is nothing to orate to."); 815 new_draw_info (NDI_UNIQUE, 0, pl, "There is nothing to orate to.");
840 return 0; 816 return 0;
841 } 817 }
842 818
819 object *tmp;
843 for (tmp = get_map_ob (m, x, y); tmp; tmp = tmp->above) 820 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
844 { 821 {
845 /* can't persuade players - return because there is nothing else 822 /* can't persuade players - return because there is nothing else
846 * on that space to charm. Same for multi space monsters and 823 * on that space to charm. Same for multi space monsters and
847 * special monsters - we don't allow them to be charmed, and there 824 * special monsters - we don't allow them to be charmed, and there
848 * is no reason to do further processing since they should be the 825 * is no reason to do further processing since they should be the
849 * only monster on the space. 826 * only monster on the space.
850 */ 827 */
851 if (tmp->type == PLAYER) 828 if (tmp->type == PLAYER
852 return 0; 829 || tmp->more || tmp->head_ () != tmp
853 if (tmp->more || tmp->head) 830 || tmp->msg)
854 return 0;
855 if (tmp->msg)
856 return 0; 831 return 0;
857 832
858 if (QUERY_FLAG (tmp, FLAG_MONSTER)) 833 if (QUERY_FLAG (tmp, FLAG_MONSTER))
859 break; 834 break;
860 } 835 }
… …
875 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp)); 850 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp));
876 return 0; 851 return 0;
877 } 852 }
878 853
879 /* it's already allied! */ 854 /* it's already allied! */
880 if (QUERY_FLAG (tmp, FLAG_FRIENDLY) && (tmp->attack_movement == PETMOVE)) 855 if (QUERY_FLAG (tmp, FLAG_FRIENDLY) && tmp->attack_movement == PETMOVE)
881 { 856 {
882 if (get_owner (tmp) == pl) 857 if (tmp->owner == pl)
883 { 858 {
884 new_draw_info (NDI_UNIQUE, 0, pl, "Your follower loves your speech.\n"); 859 new_draw_info (NDI_UNIQUE, 0, pl, "Your follower loves your speech.\n");
885 return 0; 860 return 0;
886 } 861 }
887 else if (skill->level > tmp->level) 862 else if (skill->level > tmp->level)
888 { 863 {
889 /* you steal the follower. Perhaps we should really look at the 864 /* you steal the follower. Perhaps we should really look at the
890 * level of the owner above? 865 * level of the owner above?
891 */ 866 */
892 set_owner (tmp, pl); 867 tmp->set_owner (pl);
868 tmp->skill = skill->skill;
869
893 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to follow you instead!\n", query_name (tmp)); 870 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to follow you instead!\n", query_name (tmp));
894 /* Abuse fix - don't give exp since this can otherwise 871 /* Abuse fix - don't give exp since this can otherwise
895 * be used by a couple players to gets lots of exp. 872 * be used by a couple players to gets lots of exp.
896 */ 873 */
897 return 0; 874 return 0;
… …
901 /* In this case, you can't steal it from the other player */ 878 /* In this case, you can't steal it from the other player */
902 return 0; 879 return 0;
903 } 880 }
904 } /* Creature was already a pet of someone */ 881 } /* Creature was already a pet of someone */
905 882
906 chance = skill->level * 2 + (pl->stats.Cha - 2 * tmp->stats.Int) / 2; 883 int level = skill->level + (pl->stats.Cha - tmp->stats.Int) / 2;
907 884
908 /* Ok, got a 'sucker' lets try to make them a follower */ 885 /* Ok, got a 'sucker' lets try to make them a follower */
909 if (chance > 0 && tmp->level < (random_roll (0, chance - 1, pl, PREFER_HIGH) - 1)) 886 if (level > 0 && tmp->level < (random_roll (0, level - 1, pl, PREFER_HIGH) - 1))
910 { 887 {
911 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to become your follower.\n", query_name (tmp)); 888 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to become your follower.\n", query_name (tmp));
912 889
913 set_owner (tmp, pl); 890 tmp->set_owner (pl);
891 tmp->skill = skill->skill;
914 tmp->stats.exp = 0; 892 tmp->stats.exp = 0;
915 add_friendly_object (tmp);
916 SET_FLAG (tmp, FLAG_FRIENDLY);
917 tmp->attack_movement = PETMOVE; 893 tmp->attack_movement = PETMOVE;
894
895 if (!QUERY_FLAG (tmp, FLAG_FRIENDLY))
896 add_friendly_object (tmp);
897
918 return calc_skill_exp (pl, tmp, skill); 898 return calc_skill_exp (pl, tmp, skill);
919 } 899 }
920 /* Charm failed. Creature may be angry now */ 900 /* Charm failed. Creature may be angry now */
921 else if ((skill->level + ((pl->stats.Cha - 10) / 2)) < random_roll (1, 2 * tmp->level, pl, PREFER_LOW)) 901 else if ((skill->level + ((pl->stats.Cha - 10) / 2)) < random_roll (1, 2 * tmp->level, pl, PREFER_LOW))
922 { 902 {
923 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your speech angers the %s!\n", query_name (tmp)); 903 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your speech angers the %s!\n", query_name (tmp));
924 if (QUERY_FLAG (tmp, FLAG_FRIENDLY)) 904 if (QUERY_FLAG (tmp, FLAG_FRIENDLY))
925 { 905 {
926 CLEAR_FLAG (tmp, FLAG_FRIENDLY);
927 remove_friendly_object (tmp); 906 remove_friendly_object (tmp);
928 tmp->attack_movement = 0; /* needed? */ 907 tmp->attack_movement = 0; /* needed? */
929 } 908 }
909
930 CLEAR_FLAG (tmp, FLAG_UNAGGRESSIVE); 910 CLEAR_FLAG (tmp, FLAG_UNAGGRESSIVE);
931 } 911 }
912
932 return 0; /* Fall through - if we get here, we didn't charm anything */ 913 return 0; /* Fall through - if we get here, we didn't charm anything */
933} 914}
934 915
935/* Singing() -this skill allows the player to pacify nearby creatures. 916/* Singing() -this skill allows the player to pacify nearby creatures.
936 * There are few limitations on who/what kind of 917 * There are few limitations on who/what kind of
… …
939 * successfully pacified the creature gets Int=1. Thus, a player 920 * successfully pacified the creature gets Int=1. Thus, a player
940 * may only pacify a creature once. 921 * may only pacify a creature once.
941 * BTW, I appologize for the naming of the skill, I couldnt think 922 * BTW, I appologize for the naming of the skill, I couldnt think
942 * of anything better! -b.t. 923 * of anything better! -b.t.
943 */ 924 */
944
945int 925int
946singing (object *pl, int dir, object *skill) 926singing (object *pl, int dir, object *skill)
947{ 927{
948 int i, exp = 0, chance, mflags; 928 int i, exp = 0;
949 object *tmp; 929 object *tmp;
950 maptile *m; 930 maptile *m;
951 sint16 x, y; 931 sint16 x, y;
952 932
953 if (pl->type != PLAYER) 933 if (pl->type != PLAYER)
… …
958 { 938 {
959 x = pl->x + freearr_x[i]; 939 x = pl->x + freearr_x[i];
960 y = pl->y + freearr_y[i]; 940 y = pl->y + freearr_y[i];
961 m = pl->map; 941 m = pl->map;
962 942
963 mflags = get_map_flags (m, &m, x, y, &x, &y); 943 int mflags = get_map_flags (m, &m, x, y, &x, &y);
964 if (mflags & P_OUT_OF_MAP) 944 if (mflags & P_OUT_OF_MAP)
965 continue; 945 continue;
966 if (!(mflags & P_IS_ALIVE)) 946 if (!(mflags & P_IS_ALIVE))
967 continue; 947 continue;
968 948
969 for (tmp = get_map_ob (m, x, y); tmp; tmp = tmp->above) 949 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
970 { 950 {
971 if (QUERY_FLAG (tmp, FLAG_MONSTER)) 951 if (QUERY_FLAG (tmp, FLAG_MONSTER))
972 break; 952 break;
973 /* can't affect players */ 953 /* can't affect players */
974 if (tmp->type == PLAYER) 954 if (tmp->type == PLAYER)
… …
987 967
988 /* stealing isn't really related (although, maybe it should 968 /* stealing isn't really related (although, maybe it should
989 * be). This is mainly to prevent singing to the same monster 969 * be). This is mainly to prevent singing to the same monster
990 * over and over again and getting exp for it. 970 * over and over again and getting exp for it.
991 */ 971 */
992 chance = skill->level * 2 + (pl->stats.Cha - 5 - tmp->stats.Int) / 2; 972 int level = skill->level + (pl->stats.Cha - 5 - tmp->stats.Int) / 2;
973
993 if (chance && tmp->level * 2 < random_roll (0, chance - 1, pl, PREFER_HIGH)) 974 if (level && tmp->level < random_roll (0, level - 1, pl, PREFER_HIGH))
994 { 975 {
995 SET_FLAG (tmp, FLAG_UNAGGRESSIVE); 976 SET_FLAG (tmp, FLAG_UNAGGRESSIVE);
996 new_draw_info_format (NDI_UNIQUE, 0, pl, "You calm down the %s\n", query_name (tmp)); 977 new_draw_info_format (NDI_UNIQUE, 0, pl, "You calm down the %s\n", query_name (tmp));
997 /* Give exp only if they are not aware */ 978 /* Give exp only if they are not aware */
979
998 if (!QUERY_FLAG (tmp, FLAG_NO_STEAL)) 980 if (!QUERY_FLAG (tmp, FLAG_NO_STEAL))
999 exp += calc_skill_exp (pl, tmp, skill); 981 exp += calc_skill_exp (pl, tmp, skill);
982
1000 SET_FLAG (tmp, FLAG_NO_STEAL); 983 SET_FLAG (tmp, FLAG_NO_STEAL);
1001 } 984 }
1002 else 985 else
1003 { 986 {
1004 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp)); 987 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp));
… …
1034 mflags = get_map_flags (m, &m, x, y, &x, &y); 1017 mflags = get_map_flags (m, &m, x, y, &x, &y);
1035 if (mflags & P_OUT_OF_MAP) 1018 if (mflags & P_OUT_OF_MAP)
1036 continue; 1019 continue;
1037 1020
1038 /* Check everything in the square for trapness */ 1021 /* Check everything in the square for trapness */
1039 for (tmp = get_map_ob (m, x, y); tmp != NULL; tmp = tmp->above) 1022 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1040 { 1023 {
1041 1024
1042 /* And now we'd better do an inventory traversal of each 1025 /* And now we'd better do an inventory traversal of each
1043 * of these objects' inventory 1026 * of these objects' inventory
1044 * We can narrow this down a bit - no reason to search through 1027 * We can narrow this down a bit - no reason to search through
… …
1097 mflags = get_map_flags (m, &m, x, y, &x, &y); 1080 mflags = get_map_flags (m, &m, x, y, &x, &y);
1098 if (mflags & P_OUT_OF_MAP) 1081 if (mflags & P_OUT_OF_MAP)
1099 continue; 1082 continue;
1100 1083
1101 /* Check everything in the square for trapness */ 1084 /* Check everything in the square for trapness */
1102 for (tmp = get_map_ob (m, x, y); tmp != NULL; tmp = tmp->above) 1085 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1103 { 1086 {
1104 /* And now we'd better do an inventory traversal of each 1087 /* And now we'd better do an inventory traversal of each
1105 * of these objects inventory. Like above, only 1088 * of these objects inventory. Like above, only
1106 * do this for interesting objects. 1089 * do this for interesting objects.
1107 */ 1090 */
… …
1128 success += calc_skill_exp (op, tmp, skill); 1111 success += calc_skill_exp (op, tmp, skill);
1129 } 1112 }
1130 } 1113 }
1131 } 1114 }
1132 } 1115 }
1116
1133 return success; 1117 return success;
1134} 1118}
1135
1136 1119
1137/* pray() - when this skill is called from do_skill(), it allows 1120/* pray() - when this skill is called from do_skill(), it allows
1138 * the player to regain lost grace points at a faster rate. -b.t. 1121 * the player to regain lost grace points at a faster rate. -b.t.
1139 * This always returns 0 - return value is used by calling function 1122 * This always returns 0 - return value is used by calling function
1140 * such that if it returns true, player gets exp in that skill. This 1123 * such that if it returns true, player gets exp in that skill. This
1141 * the effect here can be done on demand, we probably don't want to 1124 * the effect here can be done on demand, we probably don't want to
1142 * give infinite exp by returning true in any cases. 1125 * give infinite exp by returning true in any cases.
1143 */ 1126 */
1144
1145int 1127int
1146pray (object *pl, object *skill) 1128pray (object *pl, object *skill)
1147{ 1129{
1148 char buf[MAX_BUF]; 1130 char buf[MAX_BUF];
1149 object *tmp; 1131 object *tmp;
… …
1174 if (pl->stats.grace < pl->stats.maxgrace) 1156 if (pl->stats.grace < pl->stats.maxgrace)
1175 { 1157 {
1176 pl->stats.grace++; 1158 pl->stats.grace++;
1177 pl->last_grace = -1; 1159 pl->last_grace = -1;
1178 } 1160 }
1161
1179 return 0; 1162 return 0;
1180} 1163}
1181 1164
1182/* This skill allows the player to regain a few sp or hp for a 1165/* This skill allows the player to regain a few sp or hp for a
1183 * brief period of concentration. No armour or weapons may be 1166 * brief period of concentration. No armour or weapons may be
1184 * wielded/applied for this to work. The amount of time needed 1167 * wielded/applied for this to work. The amount of time needed
1185 * to concentrate and the # of points regained is dependant on 1168 * to concentrate and the # of points regained is dependant on
1186 * the level of the user. - b.t. thomas@astro.psu.edu 1169 * the level of the user. - b.t. thomas@astro.psu.edu
1187 */ 1170 */
1188
1189void 1171void
1190meditate (object *pl, object *skill) 1172meditate (object *pl, object *skill)
1191{ 1173{
1192 object *tmp; 1174 object *tmp;
1193 1175
… …
1201 return; 1183 return;
1202 } 1184 }
1203 else 1185 else
1204 { 1186 {
1205 for (tmp = pl->inv; tmp; tmp = tmp->below) 1187 for (tmp = pl->inv; tmp; tmp = tmp->below)
1206 if (((tmp->type == ARMOUR && skill->level < 12) 1188 if (((tmp->type == ARMOUR && skill->level < 12)
1207 || (tmp->type == HELMET && skill->level < 10) 1189 || (tmp->type == HELMET && skill->level < 10)
1208 || (tmp->type == SHIELD && skill->level < 6) 1190 || (tmp->type == SHIELD && skill->level < 6)
1209 || (tmp->type == BOOTS && skill->level < 4) || (tmp->type == GLOVES && skill->level < 2)) && QUERY_FLAG (tmp, FLAG_APPLIED)) 1191 || (tmp->type == BOOTS && skill->level < 4)
1192 || (tmp->type == GLOVES && skill->level < 2))
1193 && QUERY_FLAG (tmp, FLAG_APPLIED))
1210 { 1194 {
1211 new_draw_info (NDI_UNIQUE, 0, pl, "You can't concentrate while wearing so much armour!\n"); 1195 new_draw_info (NDI_UNIQUE, 0, pl, "You can't concentrate while wearing so much armour!\n");
1212 return; 1196 return;
1213 } 1197 }
1214 } 1198 }
… …
1234 pl->last_heal = -1; 1218 pl->last_heal = -1;
1235 } 1219 }
1236} 1220}
1237 1221
1238/* write_note() - this routine allows players to inscribe messages in 1222/* write_note() - this routine allows players to inscribe messages in
1239 * ordinary 'books' (anything that is type BOOK). b.t. 1223 * ordinary inscribable 'books' (anything that is not a SPELL). b.t.
1240 */ 1224 */
1241
1242static int 1225static int
1243write_note (object *pl, object *item, const char *msg, object *skill) 1226write_note (object *pl, object *item, const char *msg, object *skill)
1244{ 1227{
1228
1229 if (strstr (msg, "\nendmsg"))
1230 {
1231 new_draw_info (NDI_UNIQUE, 0, pl, "Trying to cheat now are we?");
1232 return 0;
1233 }
1234
1235 int len = strlen (msg);
1236
1237 if (!is_utf8_string ((U8 *)msg, len))
1238 {
1239 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message is garbled (text must be UTF-8, client-bug)!");
1240 return 0;
1241 }
1242
1243 if (INVOKE_OBJECT (INSCRIBE_NOTE, item, ARG_PLAYER (pl->contr), ARG_STRING (msg), ARG_OBJECT (skill)))
1244 return RESULT_INT (0);
1245
1245 char buf[1024]; 1246 char buf[1024];
1246 object *newBook = NULL;
1247 1247
1248 /* a pair of sanity checks */ 1248 if (len < sizeof (buf) - 2)
1249 if (!item || item->type != BOOK)
1250 return 0;
1251
1252 if (!msg)
1253 {
1254 new_draw_info (NDI_UNIQUE, 0, pl, "No message to write!");
1255 new_draw_info_format (NDI_UNIQUE, 0, pl, "Usage: use_skill %s <message>", &skill->skill);
1256 return 0;
1257 } 1249 {
1258 if (strcasestr_local (msg, "endmsg")) 1250 snprintf (buf, sizeof (buf), "%s\n", msg);
1259 {
1260 new_draw_info (NDI_UNIQUE, 0, pl, "Trying to cheat now are we?");
1261 return 0;
1262 }
1263 1251
1264 if (INVOKE_OBJECT (INSCRIBE_NOTE, item, ARG_PLAYER (pl->contr), ARG_STRING (msg), ARG_OBJECT (skill))) 1252 object *newbook = arch_to_object (item->other_arch);
1265 return strlen (msg); 1253 item->decrease ();
1266
1267 buf[0] = 0;
1268 if (!book_overflow (item->msg, msg, sizeof (buf)))
1269 { /* add msg string to book */
1270 if (item->msg)
1271 strcpy (buf, item->msg);
1272
1273 strcat (buf, msg);
1274 strcat (buf, "\n"); /* new msg needs a LF */
1275 if (item->nrof > 1)
1276 {
1277 newBook = get_object ();
1278 copy_object (item, newBook);
1279 decrease_ob (item);
1280 esrv_send_item (pl, item);
1281 newBook->nrof = 1; 1254 newbook->nrof = 1;
1282 newBook->msg = buf; 1255 newbook->msg = buf;
1283 newBook = insert_ob_in_ob (newBook, pl); 1256 newbook->flag [FLAG_IDENTIFIED] = true;
1284 esrv_send_item (pl, newBook); 1257
1258 if (item->subtype == 1) // mailscrolls
1285 } 1259 {
1286 else 1260 newbook->name = item->name;
1261 newbook->name_pl = item->name_pl;
1287 { 1262 }
1288 item->msg = buf; 1263
1289 /* This shouldn't be necessary - the object hasn't changed in any 1264 pl->insert (newbook);
1290 * visible way 1265
1291 */ 1266 pl->contr->play_sound (sound_find ("inscribe_success"));
1292 /* esrv_send_item(pl, item); */
1293 }
1294 new_draw_info_format (NDI_UNIQUE, 0, pl, "You write in the %s.", query_short_name (item)); 1267 new_draw_info_format (NDI_UNIQUE, 0, pl, "You write in the %s.", &item->name);
1295 return strlen (msg); 1268 return strlen (msg);
1296 } 1269 }
1297 else 1270 else
1298 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message won't fit in the %s!", query_short_name (item)); 1271 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message won't fit in the %s!", &item->name);
1299 1272
1300 return 0; 1273 return 0;
1301} 1274}
1302 1275
1303/* write_scroll() - this routine allows players to inscribe spell scrolls 1276/* write_scroll() - this routine allows players to inscribe spell scrolls
1304 * of spells which they know. Backfire effects are possible with the 1277 * of spells which they know. Backfire effects are possible with the
1305 * severity of the backlash correlated with the difficulty of the scroll 1278 * severity of the backlash correlated with the difficulty of the scroll
1306 * that is attempted. -b.t. thomas@astro.psu.edu 1279 * that is attempted. -b.t. thomas@astro.psu.edu
1307 */ 1280 */
1308
1309static int 1281static int
1310write_scroll (object *pl, object *scroll, object *skill) 1282write_scroll (object *pl, object *scroll, object *skill)
1311{ 1283{
1312 int success = 0, confused = 0; 1284 int success = 0, confused = 0;
1313 object *newscroll, *chosen_spell, *tmp;
1314
1315 /* this is a sanity check */
1316 if (scroll->type != SCROLL)
1317 {
1318 new_draw_info (NDI_UNIQUE, 0, pl, "A spell can only be inscribed into a scroll!");
1319 return 0;
1320 }
1321 1285
1322 /* Check if we are ready to attempt inscription */ 1286 /* Check if we are ready to attempt inscription */
1323 chosen_spell = pl->contr->ranges[range_magic]; 1287 object *chosen_spell = pl->contr->ranged_ob;
1324 if (!chosen_spell) 1288
1289 if (!chosen_spell || chosen_spell->type != SPELL)
1325 { 1290 {
1326 new_draw_info (NDI_UNIQUE, 0, pl, "You need a spell readied in order to inscribe!"); 1291 new_draw_info (NDI_UNIQUE, 0, pl, "You need a spell readied in order to inscribe!");
1327 return 0; 1292 return 0;
1328 } 1293 }
1294
1329 if (SP_level_spellpoint_cost (pl, chosen_spell, SPELL_GRACE) > pl->stats.grace) 1295 if (SP_level_spellpoint_cost (pl, chosen_spell, SPELL_GRACE) > pl->stats.grace)
1330 { 1296 {
1331 new_draw_info_format (NDI_UNIQUE, 0, pl, "You don't have enough grace to write a scroll of %s.", &chosen_spell->name); 1297 new_draw_info_format (NDI_UNIQUE, 0, pl, "You don't have enough grace to write a scroll of %s.", &chosen_spell->name);
1332 return 0; 1298 return 0;
1333 } 1299 }
1300
1334 if (SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA) > pl->stats.sp) 1301 if (SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA) > pl->stats.sp)
1335 { 1302 {
1336 new_draw_info_format (NDI_UNIQUE, 0, pl, "You don't have enough mana to write a scroll of %s.", &chosen_spell->name); 1303 new_draw_info_format (NDI_UNIQUE, 0, pl, "You don't have enough mana to write a scroll of %s.", &chosen_spell->name);
1337 return 0;
1338 }
1339
1340 /* if there is a spell already on the scroll then player could easily
1341 * accidently read it while trying to write the new one. give player
1342 * a 50% chance to overwrite spell at their own level
1343 */
1344 if ((scroll->stats.sp || scroll->inv) && random_roll (0, scroll->level * 2, pl, PREFER_LOW) > skill->level)
1345 {
1346 new_draw_info_format (NDI_UNIQUE, 0, pl, "Oops! You accidently read it while trying to write on it.");
1347 manual_apply (pl, scroll, 0);
1348 return 0; 1304 return 0;
1349 } 1305 }
1350 1306
1351 /* ok, we are ready to try inscription */ 1307 /* ok, we are ready to try inscription */
1352 if (QUERY_FLAG (pl, FLAG_CONFUSED)) 1308 if (QUERY_FLAG (pl, FLAG_CONFUSED))
… …
1356 pl->stats.grace -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_GRACE); 1312 pl->stats.grace -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_GRACE);
1357 pl->stats.sp -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA); 1313 pl->stats.sp -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA);
1358 1314
1359 if (random_roll (0, chosen_spell->level * 4 - 1, pl, PREFER_LOW) < skill->level) 1315 if (random_roll (0, chosen_spell->level * 4 - 1, pl, PREFER_LOW) < skill->level)
1360 { 1316 {
1361 if (scroll->nrof > 1) 1317 object *newscroll = arch_to_object (scroll->other_arch);
1362 { 1318 scroll->decrease ();
1363 newscroll = get_object ();
1364 copy_object (scroll, newscroll);
1365 decrease_ob (scroll);
1366 newscroll->nrof = 1; 1319 newscroll->nrof = 1;
1367 } 1320
1368 else 1321 pl->contr->play_sound (sound_find ("inscribe_success"));
1369 {
1370 newscroll = scroll;
1371 }
1372 1322
1373 if (!confused) 1323 if (!confused)
1374 { 1324 {
1375 newscroll->level = MAX (skill->level, chosen_spell->level); 1325 newscroll->level = MAX (skill->level, chosen_spell->level);
1326 newscroll->flag [FLAG_IDENTIFIED] = true;
1376 new_draw_info (NDI_UNIQUE, 0, pl, "You succeed in writing a new scroll."); 1327 new_draw_info (NDI_UNIQUE, 0, pl, "You succeed in writing the spell.");
1377 } 1328 }
1378 else 1329 else
1379 { 1330 {
1380 chosen_spell = find_random_spell_in_ob (pl, NULL); 1331 chosen_spell = find_random_spell_in_ob (pl, NULL);
1381 if (!chosen_spell) 1332 if (!chosen_spell)
… …
1383 1334
1384 newscroll->level = MAX (skill->level, chosen_spell->level); 1335 newscroll->level = MAX (skill->level, chosen_spell->level);
1385 new_draw_info (NDI_UNIQUE, 0, pl, "In your confused state, you write down some odd spell."); 1336 new_draw_info (NDI_UNIQUE, 0, pl, "In your confused state, you write down some odd spell.");
1386 } 1337 }
1387 1338
1388 if (newscroll->inv) 1339 object *tmp = chosen_spell->clone ();
1389 {
1390 object *ninv;
1391
1392 ninv = newscroll->inv;
1393 remove_ob (ninv);
1394 free_object (ninv);
1395 }
1396 tmp = get_object ();
1397 copy_object (chosen_spell, tmp);
1398 insert_ob_in_ob (tmp, newscroll); 1340 insert_ob_in_ob (tmp, newscroll);
1399 1341
1400 /* Same code as from treasure.c - so they can better merge. 1342 /* Same code as from treasure.C - so they can better merge.
1401 * if players want to sell them, so be it. 1343 * if players want to sell them, so be it.
1402 */ 1344 */
1403 newscroll->value = newscroll->arch->clone.value * newscroll->inv->value * (newscroll->level + 50) / (newscroll->inv->level + 50); 1345 newscroll->value = newscroll->arch->value * newscroll->inv->value * (newscroll->level + 50) / (newscroll->inv->level + 50);
1404 newscroll->stats.exp = newscroll->value / 5; 1346 newscroll->stats.exp = newscroll->value / 5;
1405 1347
1406 /* wait until finished manipulating the scroll before inserting it */ 1348 pl->insert (newscroll);
1407 if (newscroll == scroll) 1349
1408 {
1409 /* Remove to correctly merge with other items which may exist in inventory */
1410 remove_ob (newscroll);
1411 esrv_del_item (pl->contr, newscroll->count);
1412 }
1413 newscroll = insert_ob_in_ob (newscroll, pl);
1414 esrv_send_item (pl, newscroll);
1415 success = calc_skill_exp (pl, newscroll, skill); 1350 success = calc_skill_exp (pl, newscroll, skill);
1416 if (!confused) 1351 if (!confused)
1417 success *= 2; 1352 success *= 2;
1353
1418 success = success * skill->level; 1354 success = success * skill->level;
1419 return success; 1355 return success;
1420
1421 } 1356 }
1422 else 1357 else
1423 { /* Inscription has failed */ 1358 { /* Inscription has failed */
1359 pl->contr->play_sound (sound_find ("inscribe_fail"));
1424 1360
1425 if (chosen_spell->level > skill->level || confused) 1361 if (chosen_spell->level > skill->level || confused)
1426 { /*backfire! */ 1362 { /*backfire! */
1427 new_draw_info (NDI_UNIQUE, 0, pl, "Ouch! Your attempt to write a new scroll strains your mind!"); 1363 new_draw_info (NDI_UNIQUE, 0, pl, "Ouch! Your attempt to write a new scroll strains your mind!");
1364
1428 if (random_roll (0, 1, pl, PREFER_LOW) == 1) 1365 if (random_roll (0, 1, pl, PREFER_LOW) == 1)
1429 drain_specific_stat (pl, 4); 1366 pl->drain_specific_stat (4);
1430 else 1367 else
1431 { 1368 {
1432 confuse_player (pl, pl, 99); 1369 confuse_player (pl, pl, 99);
1433 return (-30 * chosen_spell->level); 1370 return -30 * chosen_spell->level;
1434 } 1371 }
1435 } 1372 }
1436 else if (random_roll (0, pl->stats.Int - 1, pl, PREFER_HIGH) < 15) 1373 else if (random_roll (0, pl->stats.Int - 1, pl, PREFER_HIGH) < 15)
1437 { 1374 {
1438 new_draw_info (NDI_UNIQUE, 0, pl, "Your attempt to write a new scroll rattles your mind!"); 1375 new_draw_info (NDI_UNIQUE, 0, pl, "Your attempt to write a new scroll rattles your mind! H<Frankly spoken, you were too dumb and unlucky.>");
1439 confuse_player (pl, pl, 99); 1376 confuse_player (pl, pl, 99);
1440 } 1377 }
1441 else 1378 else
1442 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to write a new scroll."); 1379 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to write a new scroll. H<Try a lower-level spell, if possible at all.>");
1443 } 1380 }
1381
1444 return 0; 1382 return 0;
1445} 1383}
1446 1384
1447/* write_on_item() - wrapper for write_note and write_scroll */ 1385/* write_on_item() - wrapper for write_note and write_scroll */
1448int 1386int
1449write_on_item (object *pl, const char *params, object *skill) 1387write_on_item (object *pl, const char *params, object *skill)
1450{ 1388{
1451 object *item;
1452 const char *string = params;
1453 int msgtype;
1454 archetype *skat; 1389 archetype *skat;
1455 1390
1456 if (pl->type != PLAYER) 1391 if (pl->type != PLAYER)
1457 return 0; 1392 return 0;
1458 1393
1459 if (!params) 1394 if (!params)
1460 {
1461 params = ""; 1395 params = "";
1462 string = params; 1396
1463 }
1464 skat = get_archetype_by_type_subtype (SKILL, SK_LITERACY); 1397 skat = get_archetype_by_type_subtype (SKILL, SK_LITERACY);
1465 1398
1466 /* Need to be able to read before we can write! */ 1399 /* Need to be able to read before we can write! */
1467 if (!find_skill_by_name (pl, skat->clone.skill)) 1400 if (!find_skill_by_name (pl, skat->skill))
1468 { 1401 {
1469 new_draw_info (NDI_UNIQUE, 0, pl, "You must learn to read before you can write!"); 1402 new_draw_info (NDI_UNIQUE, 0, pl, "You must learn to read before you can write! H<You lack the literacy skill.>");
1470 return 0; 1403 return 0;
1471 } 1404 }
1472 1405
1473 /* if there is a message then it goes in a book and no message means 1406 object *item = find_marked_object (pl);
1474 * write active spell into the scroll
1475 */
1476 msgtype = (string[0] != '\0') ? BOOK : SCROLL;
1477 1407
1478 /* find an item of correct type to write on */ 1408 /* find an item of correct type to write on */
1479 if (!(item = find_marked_object (pl))) 1409 if (!item)
1410 {
1411 new_draw_info (NDI_UNIQUE, 0, pl, "You don't have any marked item to write on. H<Use the mark command or the popup menu to makr an item.>");
1412 return 0;
1480 { 1413 }
1481 new_draw_info (NDI_UNIQUE, 0, pl, "You don't have any marked item to write on."); 1414
1415 if (item->type != INSCRIBABLE)
1416 {
1417 new_draw_info_format (NDI_UNIQUE, 0, pl, "You cannot inscribe this! H<You can only inscribe empty scrolls and books.>");
1482 return 0; 1418 return 0;
1483 } 1419 }
1484 1420
1485 if (QUERY_FLAG (item, FLAG_UNPAID)) 1421 if (QUERY_FLAG (item, FLAG_UNPAID))
1486 { 1422 {
1487 new_draw_info (NDI_UNIQUE, 0, pl, "You had better pay for that before you write on it."); 1423 new_draw_info (NDI_UNIQUE, 0, pl, "You had better pay for that before you write on it.");
1488 return 0; 1424 return 0;
1489 } 1425 }
1490 if (msgtype != item->type) 1426
1427 if (item->other_arch->type == SCROLL)
1491 { 1428 {
1492 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have no %s to write on", msgtype == BOOK ? "book" : "scroll"); 1429 if (*params)
1430 {
1431 // check readied scroll
1432 new_draw_info_format (NDI_UNIQUE, 0, pl,
1433 "When inscribing spells you need to ready a spell and do not specify a string argument.\n"
1434 "Usage: cast [spell name]; use_skill %s", &skill->skill);
1493 return 0; 1435 return 0;
1494 } 1436 }
1495 1437
1496 if (msgtype == SCROLL)
1497 {
1498 return write_scroll (pl, item, skill); 1438 return write_scroll (pl, item, skill);
1499 } 1439 }
1500 else if (msgtype == BOOK) 1440 else
1501 { 1441 {
1442 if (!*params)
1443 {
1444 new_draw_info_format (NDI_UNIQUE, 0, pl,
1445 "When inscribing books you need to specify the words you want to inscribe as command argument.\n"
1446 "Usage: use_skill %s <message>", &skill->skill);
1447 return 0;
1448 }
1449
1502 return write_note (pl, item, string, skill); 1450 return write_note (pl, item, params, skill);
1503 } 1451 }
1452
1504 return 0; 1453 return 0;
1505} 1454}
1506
1507
1508 1455
1509/* find_throw_ob() - if we request an object, then 1456/* find_throw_ob() - if we request an object, then
1510 * we search for it in the inventory of the owner (you've 1457 * we search for it in the inventory of the owner (you've
1511 * got to be carrying something in order to throw it!). 1458 * got to be carrying something in order to throw it!).
1512 * If we didnt request an object, then the top object in inventory 1459 * If we didnt request an object, then the top object in inventory
1513 * (that is "throwable", ie no throwing your skills away!) 1460 * (that is "throwable", ie no throwing your skills away!)
1514 * is the object of choice. Also check to see if object is 1461 * is the object of choice. Also check to see if object is
1515 * 'throwable' (ie not applied cursed obj, worn, etc). 1462 * 'throwable' (ie not applied cursed obj, worn, etc).
1516 */ 1463 */
1517
1518static object * 1464static object *
1519find_throw_ob (object *op, const char *request) 1465find_throw_ob (object *op, const char *request)
1520{ 1466{
1521 object *tmp; 1467 object *tmp;
1522 1468
… …
1594 1540
1595/* make_throw_ob() We construct the 'carrier' object in 1541/* make_throw_ob() We construct the 'carrier' object in
1596 * which we will insert the object that is being thrown. 1542 * which we will insert the object that is being thrown.
1597 * This combination becomes the 'thrown object'. -b.t. 1543 * This combination becomes the 'thrown object'. -b.t.
1598 */ 1544 */
1599
1600static object * 1545static object *
1601make_throw_ob (object *orig) 1546make_throw_ob (object *orig)
1602{ 1547{
1603 object *toss_item;
1604
1605 if (!orig) 1548 if (!orig)
1606 return NULL; 1549 return NULL;
1607 1550
1608 toss_item = get_object ();
1609 if (QUERY_FLAG (orig, FLAG_APPLIED)) 1551 if (QUERY_FLAG (orig, FLAG_APPLIED))
1610 { 1552 {
1611 LOG (llevError, "BUG: make_throw_ob(): ob is applied\n"); 1553 LOG (llevError, "BUG: make_throw_ob(): ob is applied\n");
1612 /* insufficient workaround, but better than nothing */ 1554 /* insufficient workaround, but better than nothing */
1613 CLEAR_FLAG (orig, FLAG_APPLIED); 1555 CLEAR_FLAG (orig, FLAG_APPLIED);
1614 } 1556 }
1615 copy_object (orig, toss_item); 1557
1558 object *toss_item = orig->clone ();
1559
1616 toss_item->type = THROWN_OBJ; 1560 toss_item->type = THROWN_OBJ;
1617 CLEAR_FLAG (toss_item, FLAG_CHANGING); 1561 CLEAR_FLAG (toss_item, FLAG_CHANGING);
1618 toss_item->stats.dam = 0; /* default damage */ 1562 toss_item->stats.dam = 0; /* default damage */
1619 insert_ob_in_ob (orig, toss_item); 1563 toss_item->insert (orig);
1564
1620 return toss_item; 1565 return toss_item;
1621} 1566}
1622
1623 1567
1624/* do_throw() - op throws any object toss_item. This code 1568/* do_throw() - op throws any object toss_item. This code
1625 * was borrowed from fire_bow. 1569 * was borrowed from fire_bow.
1626 * Returns 1 if skill was successfully used, 0 if not 1570 * Returns 1 if skill was successfully used, 0 if not
1627 */ 1571 */
1628
1629static int 1572static int
1630do_throw (object *op, object *part, object *toss_item, int dir, object *skill) 1573do_throw (object *op, object *part, object *toss_item, int dir, object *skill)
1631{ 1574{
1632 object *throw_ob = toss_item, *left = NULL; 1575 object *throw_ob = toss_item, *left = NULL;
1633 int eff_str = 0, maxc, str = op->stats.Str, dam = 0; 1576 int eff_str = 0, maxc, str = op->stats.Str, dam = 0;
… …
1698 */ 1641 */
1699 mflags = get_map_flags (part->map, &m, part->x + freearr_x[dir], part->y + freearr_y[dir], &sx, &sy); 1642 mflags = get_map_flags (part->map, &m, part->x + freearr_x[dir], part->y + freearr_y[dir], &sx, &sy);
1700 1643
1701 if (!dir || (eff_str <= 1) || (mflags & P_OUT_OF_MAP) || (GET_MAP_MOVE_BLOCK (m, sx, sy) & MOVE_FLY_LOW)) 1644 if (!dir || (eff_str <= 1) || (mflags & P_OUT_OF_MAP) || (GET_MAP_MOVE_BLOCK (m, sx, sy) & MOVE_FLY_LOW))
1702 { 1645 {
1703
1704 /* bounces off 'wall', and drops to feet */ 1646 /* bounces off 'wall', and drops to feet */
1705 remove_ob (throw_ob); 1647 throw_ob->insert_at (part, op);
1706 throw_ob->x = part->x; 1648
1707 throw_ob->y = part->y;
1708 insert_ob_in_map (throw_ob, part->map, op, 0);
1709 if (op->type == PLAYER) 1649 if (op->type == PLAYER)
1710 { 1650 {
1711 if (eff_str <= 1) 1651 if (eff_str <= 1)
1712 {
1713 new_draw_info_format (NDI_UNIQUE, 0, op, "Your load is so heavy you drop %s to the ground.", query_name (throw_ob)); 1652 new_draw_info_format (NDI_UNIQUE, 0, op, "Your load is so heavy you drop %s to the ground.", query_name (throw_ob));
1714 }
1715 else if (!dir) 1653 else if (!dir)
1716 {
1717 new_draw_info_format (NDI_UNIQUE, 0, op, "You throw %s at the ground.", query_name (throw_ob)); 1654 new_draw_info_format (NDI_UNIQUE, 0, op, "You throw %s at the ground.", query_name (throw_ob));
1718 }
1719 else 1655 else
1720 new_draw_info (NDI_UNIQUE, 0, op, "Something is in the way."); 1656 new_draw_info (NDI_UNIQUE, 0, op, "Something is in the way.");
1721 } 1657 }
1658
1722 return 0; 1659 return 0;
1723 } /* if object can't be thrown */ 1660 } /* if object can't be thrown */
1724 1661
1725 left = throw_ob; /* these are throwing objects left to the player */ 1662 left = throw_ob; /* these are throwing objects left to the player */
1726 1663
1727 /* sometimes get_split_ob can't split an object (because op->nrof==0?) 1664 /* sometimes get_split_ob can't split an object (because op->nrof==0?)
1728 * and returns NULL. We must use 'left' then 1665 * and returns NULL. We must use 'left' then
1729 */ 1666 */
1730 1667 if (!(throw_ob = throw_ob->split ()))
1731 if ((throw_ob = get_split_ob (throw_ob, 1)) == NULL)
1732 { 1668 {
1733 throw_ob = left; 1669 throw_ob = left;
1734 remove_ob (left); 1670 left->remove ();
1735 if (op->type == PLAYER)
1736 esrv_del_item (op->contr, left->count);
1737 }
1738 else if (op->type == PLAYER)
1739 {
1740 if (left->destroyed ())
1741 esrv_del_item (op->contr, left->count);
1742 else
1743 esrv_update_item (UPD_NROF, op, left);
1744 } 1671 }
1745 1672
1746 /* special case: throwing powdery substances like dust, dirt */ 1673 /* special case: throwing powdery substances like dust, dirt */
1747 if (throw_ob->type == POTION && throw_ob->subtype == POT_DUST) 1674 if (throw_ob->type == POTION && throw_ob->subtype == POT_DUST)
1748 { 1675 {
… …
1763 { 1690 {
1764 insert_ob_in_ob (throw_ob, op); 1691 insert_ob_in_ob (throw_ob, op);
1765 return 0; 1692 return 0;
1766 } 1693 }
1767 1694
1768 set_owner (throw_ob, op); 1695 throw_ob->set_owner (op);
1769 /* At some point in the attack code, the actual real object (op->inv) 1696 /* At some point in the attack code, the actual real object (op->inv)
1770 * becomes the hitter. As such, we need to make sure that has a proper 1697 * becomes the hitter. As such, we need to make sure that has a proper
1771 * owner value so exp goes to the right place. 1698 * owner value so exp goes to the right place.
1772 */ 1699 */
1773 set_owner (throw_ob->inv, op); 1700 throw_ob->inv->set_owner (op);
1774 throw_ob->direction = dir; 1701 throw_ob->direction = dir;
1775 throw_ob->x = part->x;
1776 throw_ob->y = part->y;
1777 1702
1778 /* the damage bonus from the force of the throw */ 1703 /* the damage bonus from the force of the throw */
1779 dam = (int) (str_factor * dam_bonus[eff_str]); 1704 dam = int (str_factor * dam_bonus[eff_str]);
1780 1705
1781 /* Now, lets adjust the properties of the thrown_ob. */ 1706 /* Now, lets adjust the properties of the thrown_ob. */
1782 1707
1783 /* how far to fly */ 1708 /* how far to fly */
1784 throw_ob->last_sp = (eff_str * 3) / 5; 1709 throw_ob->last_sp = (eff_str * 3) / 5;
1785 1710
1786 /* speed */ 1711 /* speed */
1787 throw_ob->speed = (speed_bonus[eff_str] + 1.0) / 1.5; 1712 throw_ob->set_speed (min (1.0, speed_bonus[eff_str] + 1.0) / 1.5); /* no faster than an arrow! */
1788 throw_ob->speed = MIN (1.0, throw_ob->speed); /* no faster than an arrow! */
1789 1713
1790 /* item damage. Eff_str and item weight influence damage done */ 1714 /* item damage. Eff_str and item weight influence damage done */
1791 weight_f = (throw_ob->weight / 2000) > MAX_STAT ? MAX_STAT : (throw_ob->weight / 2000); 1715 weight_f = (throw_ob->weight / 2000) > MAX_STAT ? MAX_STAT : (throw_ob->weight / 2000);
1792 throw_ob->stats.dam += (dam / 3) + dam_bonus[weight_f] + (throw_ob->weight / 15000) - 2; 1716 throw_ob->stats.dam += (dam / 3) + dam_bonus[weight_f] + (throw_ob->weight / 15000) - 2;
1793 1717
1794 /* chance of breaking. Proportional to force used and weight of item */ 1718 /* chance of breaking. Proportional to force used and weight of item */
1795 throw_ob->stats.food = (dam / 2) + (throw_ob->weight / 60000); 1719 throw_ob->stats.food = (dam / 2) + (throw_ob->weight / 60000);
1796 1720
1797 /* replace 25 with a call to clone.arch wc? messes up w/ NPC */ 1721 /* replace 25 with a call to clone.arch wc? messes up w/ NPC */
1798 throw_ob->stats.wc = 25 - dex_bonus[op->stats.Dex] - thaco_bonus[eff_str] - skill->level; 1722 throw_ob->stats.wc = 25 - dex_bonus[op->stats.Dex] - thaco_bonus[eff_str] - skill->level;
1799
1800 1723
1801 /* the properties of objects which are meant to be thrown (ie dart, 1724 /* the properties of objects which are meant to be thrown (ie dart,
1802 * throwing knife, etc) will differ from ordinary items. Lets tailor 1725 * throwing knife, etc) will differ from ordinary items. Lets tailor
1803 * this stuff in here. 1726 * this stuff in here.
1804 */ 1727 */
… …
1812 if (GET_ANIM_ID (throw_ob) && NUM_ANIMATIONS (throw_ob)) 1735 if (GET_ANIM_ID (throw_ob) && NUM_ANIMATIONS (throw_ob))
1813 SET_ANIMATION (throw_ob, dir); 1736 SET_ANIMATION (throw_ob, dir);
1814 } 1737 }
1815 else 1738 else
1816 { 1739 {
1740 uint16 mat = throw_ob->materials;
1741
1817 /* some materials will adjust properties.. */ 1742 /* some materials will adjust properties.. */
1818 if (throw_ob->material & M_LEATHER) 1743 if (mat & M_LEATHER)
1819 { 1744 {
1820 throw_ob->stats.dam -= 1; 1745 throw_ob->stats.dam -= 1;
1821 throw_ob->stats.food -= 10; 1746 throw_ob->stats.food -= 10;
1822 } 1747 }
1748
1823 if (throw_ob->material & M_GLASS) 1749 if (mat & M_GLASS)
1824 throw_ob->stats.food += 60; 1750 throw_ob->stats.food += 60;
1825 1751
1826 if (throw_ob->material & M_ORGANIC) 1752 if (mat & M_ORGANIC)
1827 { 1753 {
1828 throw_ob->stats.dam -= 3; 1754 throw_ob->stats.dam -= 3;
1829 throw_ob->stats.food += 55; 1755 throw_ob->stats.food += 55;
1830 } 1756 }
1831 if (throw_ob->material & M_PAPER || throw_ob->material & M_CLOTH) 1757
1758 if (mat & M_PAPER || mat & M_CLOTH)
1832 { 1759 {
1833 throw_ob->stats.dam -= 5; 1760 throw_ob->stats.dam -= 5;
1834 throw_ob->speed *= 0.8; 1761 throw_ob->speed *= 0.8;
1835 throw_ob->stats.wc += 3; 1762 throw_ob->stats.wc += 3;
1836 throw_ob->stats.food -= 30; 1763 throw_ob->stats.food -= 30;
1837 } 1764 }
1765
1838 /* light obj have more wind resistance, fly slower */ 1766 /* light obj have more wind resistance, fly slower */
1839 if (throw_ob->weight > 500) 1767 if (throw_ob->weight > 500)
1840 throw_ob->speed *= 0.8; 1768 throw_ob->speed *= 0.8;
1769
1841 if (throw_ob->weight > 50) 1770 if (throw_ob->weight > 50)
1842 throw_ob->speed *= 0.5; 1771 throw_ob->speed *= 0.5;
1843
1844 } /* else tailor thrown object */ 1772 } /* else tailor thrown object */
1845 1773
1846 /* some limits, and safeties (needed?) */ 1774 /* some limits, and safeties (needed?) */
1847 if (throw_ob->stats.dam < 0) 1775 if (throw_ob->stats.dam < 0)
1848 throw_ob->stats.dam = 0; 1776 throw_ob->stats.dam = 0;
… …
1868 * In short summary, a throw can take anywhere between speed 5 and 1796 * In short summary, a throw can take anywhere between speed 5 and
1869 * speed 0.5 1797 * speed 0.5
1870 */ 1798 */
1871 op->speed_left -= 50 / pause_f; 1799 op->speed_left -= 50 / pause_f;
1872 1800
1873 update_ob_speed (throw_ob);
1874 throw_ob->speed_left = 0; 1801 throw_ob->speed_left = 0;
1875 throw_ob->map = part->map; 1802 throw_ob->map = part->map;
1876 1803
1877 throw_ob->move_type = MOVE_FLY_LOW; 1804 throw_ob->move_type = MOVE_FLY_LOW;
1878 throw_ob->move_on = MOVE_FLY_LOW | MOVE_WALK; 1805 throw_ob->move_on = MOVE_FLY_LOW | MOVE_WALK;
… …
1888 LOG (llevDebug, " pause_f=%d \n", pause_f); 1815 LOG (llevDebug, " pause_f=%d \n", pause_f);
1889 LOG (llevDebug, " %s stats: wc=%d dam=%d dist=%d spd=%f break=%d\n", 1816 LOG (llevDebug, " %s stats: wc=%d dam=%d dist=%d spd=%f break=%d\n",
1890 throw_ob->name, throw_ob->stats.wc, throw_ob->stats.dam, throw_ob->last_sp, throw_ob->speed, throw_ob->stats.food); 1817 throw_ob->name, throw_ob->stats.wc, throw_ob->stats.dam, throw_ob->last_sp, throw_ob->speed, throw_ob->stats.food);
1891 LOG (llevDebug, "inserting tossitem (%d) into map\n", throw_ob->count); 1818 LOG (llevDebug, "inserting tossitem (%d) into map\n", throw_ob->count);
1892#endif 1819#endif
1893 insert_ob_in_map (throw_ob, part->map, op, 0); 1820
1821 throw_ob->insert_at (part, op);
1894 1822
1895 if (!throw_ob->destroyed ()) 1823 if (!throw_ob->destroyed ())
1896 move_arrow (throw_ob); 1824 move_arrow (throw_ob);
1897 1825
1898 return 1; 1826 return 1;

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines