[ViewVC] Diff of: cvs/deliantra/server/server/skills.C

Comparing deliantra/server/server/skills.C (file contents):
Revision 1.64 by root, Tue May 5 04:51:56 2009 UTC vs.
Revision 1.71 by root, Sat Nov 7 13:58:01 2009 UTC

  *
  * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
  * Copyright (©) 2003,2007 Mark Wedel & Crossfire Development Team
  * Copyright (©) 1992,2007 Frank Tore Johansen
  *
- * Deliantra is free software: you can redistribute it and/or modify
+ * Deliantra is free software: you can redistribute it and/or modify it under
- * it under the terms of the GNU General Public License as published by
+ * the terms of the Affero GNU General Public License as published by the
- * the Free Software Foundation, either version 3 of the License, or
+ * Free Software Foundation, either version 3 of the License, or (at your
- * (at your option) any later version.
+ * option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
+ * You should have received a copy of the Affero GNU General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * and the GNU General Public License along with this program. If not, see
+ * <http://www.gnu.org/licenses/>.
  *
  * The authors can be reached via e-mail to <support@deliantra.net>
  */
 #include <global.h>
       return -1;
     }
   /* ADJUSTMENTS */
-  /* Its harder to steal from hostile beings! */
+  /* It's harder to steal from hostile beings! */
   if (!QUERY_FLAG (victim, FLAG_UNAGGRESSIVE))
     roll = roll / 2;
   /* Easier to steal from sleeping beings, or if the thief is
    * unseen */
 }
 /* Helper function for do_skill_ident, so that we can loop
  * over inventory AND objects on the ground conveniently.
  */
-int
+static int
 do_skill_ident2 (object *tmp, object *pl, int obj_class, object *skill)
 {
   int success = 0, chance;
   int skill_value = skill->level * pl->stats.Int ? pl->stats.Int : 10;
 }
 /* remove_trap() - This skill will disarm any previously discovered trap
  * the algorithm is based (almost totally) on the old command_disarm() - b.t.
  */
 int
 remove_trap (object *op, int dir, object *skill)
 {
   object *tmp, *tmp2;
   int i, success = 0, mflags;
       mflags = get_map_flags (m, &m, x, y, &x, &y);
       if (mflags & P_OUT_OF_MAP)
         continue;
       /* Check everything in the square for trapness */
-      for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
+      for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
         {
           /* And now we'd better do an inventory traversal of each
            * of these objects inventory.  Like above, only
            * do this for interesting objects.
            */
           if (tmp->type != PLAYER && !QUERY_FLAG (tmp, FLAG_MONSTER))
             {
-              for (tmp2 = tmp->inv; tmp2 != NULL; tmp2 = tmp2->below)
+              for (tmp2 = tmp->inv; tmp2; tmp2 = tmp2->below)
                 if ((tmp2->type == RUNE || tmp2->type == TRAP) && tmp2->stats.Cha <= 1)
                   {
                     trap_show (tmp2, tmp);
                     if (trap_disarm (op, tmp2, 1, skill) && (!tmp2->owner || tmp2->owner->type != PLAYER))
                       {
                         tmp->stats.exp = tmp->stats.Cha * tmp->level;
                         success += calc_skill_exp (op, tmp2, skill);
                       }
                   }
             }
           if ((tmp->type == RUNE || tmp->type == TRAP) && tmp->stats.Cha <= 1)
             {
               trap_show (tmp, tmp);
               if (trap_disarm (op, tmp, 1, skill) && (!tmp->owner || tmp->owner->type != PLAYER))
                 {
                   tmp->stats.exp = tmp->stats.Cha * tmp->level;
                   success += calc_skill_exp (op, tmp, skill);
                 }
   /* Check all objects - we could stop at floor objects,
    * but if someone buries an altar, I don't see a problem with
    * going through all the objects, and it shouldn't be much slower
    * than extra checks on object attributes.
    */
-  for (tmp = pl->below; tmp != NULL; tmp = tmp->below)
+  for (tmp = pl->below; tmp; tmp = tmp->below)
     {
       /* Only if the altar actually belongs to someone do you get special benefits */
       if (tmp && tmp->type == HOLY_ALTAR && tmp->other_arch)
         {
           sprintf (buf, "You pray over the %s.", &tmp->name);
  * ordinary inscribable 'books' (anything that is not a SPELL). b.t.
  */
 static int
 write_note (object *pl, object *item, const char *msg, object *skill)
 {
-  if (strstr (msg, "\nendmsg"))
+  if (!msg_is_safe (msg))
     {
       new_draw_info (NDI_UNIQUE, 0, pl, "Trying to cheat now are we?");
+      LOG (llevInfo, "write_note: player %s tried to write bogus note %s\n", &pl->name, msg);
       return 0;
     }
   int len = strlen (msg);
     }
   if (INVOKE_OBJECT (INSCRIBE_NOTE, item, ARG_PLAYER (pl->contr), ARG_STRING (msg), ARG_OBJECT (skill)))
     return RESULT_INT (0);
-  char buf[1024];
+  STRLEN char_len = utf8_length ((U8 *)msg, (U8 *)(msg+len));
-  if (len < sizeof (buf) - 2)
+  if (char_len <= item->weight_limit)
     {
-      snprintf (buf, sizeof (buf), "%s\n", msg);
       object *newbook = arch_to_object (item->other_arch);
       item->decrease ();
       newbook->nrof = 1;
-      newbook->msg = buf;
+      newbook->msg = shstr (msg);
       newbook->flag [FLAG_IDENTIFIED] = true;
       if (item->subtype == 1) // mailscrolls
         {
           newbook->name    = item->name;
       pl->insert (newbook);
       pl->contr->play_sound (sound_find ("inscribe_success"));
       new_draw_info_format (NDI_UNIQUE, 0, pl, "You write in the %s.", &item->name);
-      return strlen (msg);
+      return char_len;
     }
   else
-    new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message won't fit in the %s!", &item->name);
+    new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message won't fit in the %s! H<It is only big enough for %d characters, your message had %d characters.>",
+                          &item->name, item->weight_limit, char_len);
   return 0;
 }
 /* write_scroll() - this routine allows players to inscribe spell scrolls

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/server/skills.C (file contents): Revision 1.64 by root, Tue May 5 04:51:56 2009 UTC vs. Revision 1.71 by root, Sat Nov 7 13:58:01 2009 UTC

Diff Legend

Comparing deliantra/server/server/skills.C (file contents):
Revision 1.64 by root, Tue May 5 04:51:56 2009 UTC vs.
Revision 1.71 by root, Sat Nov 7 13:58:01 2009 UTC