ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/skills.C
(Generate patch)

Comparing deliantra/server/server/skills.C (file contents):
Revision 1.25 by root, Mon Jan 29 17:57:22 2007 UTC vs.
Revision 1.71 by root, Sat Nov 7 13:58:01 2009 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2003 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2003,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
21 * 21 *
22 * The authors can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24 24
25#include <global.h> 25#include <global.h>
26#include <object.h> 26#include <object.h>
27#include <sproto.h> 27#include <sproto.h>
… …
40 return -1; 40 return -1;
41 41
42 /* Only prohibit stealing if the player does not have a free 42 /* Only prohibit stealing if the player does not have a free
43 * hand available and in fact does have hands. 43 * hand available and in fact does have hands.
44 */ 44 */
45 if (op->type == PLAYER && op->body_used[BODY_ARMS] <= 0 && op->body_info[BODY_ARMS]) 45 if (op->type == PLAYER && op->slot[body_arm].used <= 0 && op->slot[body_arm].info)
46 { 46 {
47 new_draw_info (NDI_UNIQUE, 0, op, "But you have no free hands to steal with!"); 47 new_draw_info (NDI_UNIQUE, 0, op, "But you have no free hands to steal with! "
48 "H<Try to unapply weapons or things you hold in your hands, use the C<body> command.>");
48 return -1; 49 return -1;
49 } 50 }
50 51
51 /* ADJUSTMENTS */ 52 /* ADJUSTMENTS */
52 53
53 /* Its harder to steal from hostile beings! */ 54 /* It's harder to steal from hostile beings! */
54 if (!QUERY_FLAG (victim, FLAG_UNAGGRESSIVE)) 55 if (!QUERY_FLAG (victim, FLAG_UNAGGRESSIVE))
55 roll = roll / 2; 56 roll = roll / 2;
56 57
57 /* Easier to steal from sleeping beings, or if the thief is 58 /* Easier to steal from sleeping beings, or if the thief is
58 * unseen */ 59 * unseen */
… …
65 * it quite a bit harder to steal. 66 * it quite a bit harder to steal.
66 */ 67 */
67 for (equip = op->inv; equip; equip = equip->below) 68 for (equip = op->inv; equip; equip = equip->below)
68 { 69 {
69 if (equip->type == WEAPON && QUERY_FLAG (equip, FLAG_APPLIED)) 70 if (equip->type == WEAPON && QUERY_FLAG (equip, FLAG_APPLIED))
70 {
71 roll -= equip->weight / 10000; 71 roll -= equip->weight / 10000;
72 } 72
73 if (equip->type == BOW && QUERY_FLAG (equip, FLAG_APPLIED)) 73 if (equip->type == BOW && QUERY_FLAG (equip, FLAG_APPLIED))
74 roll -= equip->weight / 5000; 74 roll -= equip->weight / 5000;
75
75 if (equip->type == SHIELD && QUERY_FLAG (equip, FLAG_APPLIED)) 76 if (equip->type == SHIELD && QUERY_FLAG (equip, FLAG_APPLIED))
76 {
77 roll -= equip->weight / 2000; 77 roll -= equip->weight / 2000;
78 } 78
79 if (equip->type == ARMOUR && QUERY_FLAG (equip, FLAG_APPLIED)) 79 if (equip->type == ARMOUR && QUERY_FLAG (equip, FLAG_APPLIED))
80 roll -= equip->weight / 5000; 80 roll -= equip->weight / 5000;
81
81 if (equip->type == GLOVES && QUERY_FLAG (equip, FLAG_APPLIED)) 82 if (equip->type == GLOVES && QUERY_FLAG (equip, FLAG_APPLIED))
82 roll -= equip->weight / 100; 83 roll -= equip->weight / 100;
83 } 84 }
85
84 if (roll < 0) 86 if (roll < 0)
85 roll = 0; 87 roll = 0;
88
86 return roll; 89 return roll;
87} 90}
88 91
89/* 92/*
90 * When stealing: dependent on the intelligence/wisdom of whom you're 93 * When stealing: dependent on the intelligence/wisdom of whom you're
… …
93 * or not. 96 * or not.
94 * op is the target (person being pilfered) 97 * op is the target (person being pilfered)
95 * who is the person doing the stealing. 98 * who is the person doing the stealing.
96 * skill is the skill object (stealing). 99 * skill is the skill object (stealing).
97 */ 100 */
98
99static int 101static int
100attempt_steal (object *op, object *who, object *skill) 102attempt_steal (object *op, object *who, object *skill)
101{ 103{
102 object *success = NULL, *tmp = NULL, *next; 104 object *success = NULL, *tmp = NULL, *next;
103 int roll = 0, chance = 0, stats_value; 105 int roll = 0, chance = 0, stats_value;
104 rv_vector rv; 106 rv_vector rv;
105 107
106 stats_value = ((who->stats.Dex + who->stats.Int) * 3) / 2; 108 stats_value = (who->stats.Dex + who->stats.Int) * 3 / 2;
107 109
108 /* if the victim is aware of a thief in the area (FLAG_NO_STEAL set on them) 110 /* if the victim is aware of a thief in the area (FLAG_NO_STEAL set on them)
109 * they will try to prevent stealing if they can. Only unseen theives will 111 * they will try to prevent stealing if they can. Only unseen theives will
110 * have much chance of success. 112 * have much chance of success.
111 */ 113 */
112 if (op->type != PLAYER && QUERY_FLAG (op, FLAG_NO_STEAL)) 114 if (!op->is_player () && op->flag [FLAG_NO_STEAL])
113 { 115 {
114 if (can_detect_enemy (op, who, &rv)) 116 if (can_detect_enemy (op, who, &rv))
115 { 117 {
116 npc_call_help (op); 118 npc_call_help (op);
117 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE); 119 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE);
118 new_draw_info (NDI_UNIQUE, 0, who, "Your attempt is prevented!"); 120 new_draw_info (NDI_UNIQUE, 0, who, "Your attempt is prevented!");
119 return 0; 121 return 0;
120 } 122 }
121 else /* help npc to detect thief next time by raising its wisdom */ 123 else /* help npc to detect thief next time by raising its wisdom */
122 op->stats.Wis += (op->stats.Int / 5) + 1; 124 op->stats.Wis += (op->stats.Int / 5) + 1;
125
123 if (op->stats.Wis > MAX_STAT) 126 if (op->stats.Wis > MAX_STAT)
124 op->stats.Wis = MAX_STAT; 127 op->stats.Wis = MAX_STAT;
125 } 128 }
126 if (op->type == PLAYER && QUERY_FLAG (op, FLAG_WIZ)) 129
130 if (op->is_player () && op->flag [FLAG_WIZ])
127 { 131 {
128 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from the dungeon master!\n"); 132 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from the dungeon master!\n");
129 return 0; 133 return 0;
130 } 134 }
131#ifdef PROHIBIT_PLAYERKILL 135
136 // only allow stealing between hostile players (TODO: probably should change)
132 if (op->type == PLAYER && who->type == PLAYER && (who->contr->peaceful || op->contr->peaceful)) 137 if (op->is_player () && who->is_player () && (who->contr->peaceful || op->contr->peaceful))
133 { 138 {
134 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from other players!\n"); 139 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from other players!\n");
135 return 0; 140 return 0;
136 } 141 }
137#else
138 if (op->type == PLAYER && who->type == PLAYER && settings.no_player_stealing)
139 {
140 new_draw_info (NDI_UNIQUE, 0, who, "You can't steal from other players!\n");
141 return 0;
142 }
143#endif
144 142
145
146 /* Ok then, go thru their inventory, stealing */ 143 /* Ok then, go through their inventory, stealing */
147 for (tmp = op->inv; tmp != NULL; tmp = next) 144 for (tmp = op->inv; tmp; tmp = next)
148 { 145 {
149 next = tmp->below; 146 next = tmp->below;
150 147
151 /* you can't steal worn items, starting items, wiz stuff, 148 /* you can't steal worn items, starting items, wiz stuff,
152 * innate abilities, or items w/o a type. Generally 149 * innate abilities, or items w/o a type. Generally
… …
156 * future possible problems. -b.t. 153 * future possible problems. -b.t.
157 * Flesh items generated w/ fix_flesh_item should have FLAG_NO_STEAL 154 * Flesh items generated w/ fix_flesh_item should have FLAG_NO_STEAL
158 * already -b.t. 155 * already -b.t.
159 */ 156 */
160 157
161 if (QUERY_FLAG (tmp, FLAG_WAS_WIZ) || QUERY_FLAG (tmp, FLAG_APPLIED) 158 if (QUERY_FLAG (tmp, FLAG_APPLIED)
162 || !(tmp->type) 159 || !tmp->type
163 || tmp->type == SPELL 160 || tmp->type == SPELL
164 || QUERY_FLAG (tmp, FLAG_STARTEQUIP) || QUERY_FLAG (tmp, FLAG_NO_STEAL) || tmp->invisible) 161 || QUERY_FLAG (tmp, FLAG_STARTEQUIP)
162 || QUERY_FLAG (tmp, FLAG_NO_STEAL)
163 || tmp->invisible)
165 continue; 164 continue;
166 165
167 /* Okay, try stealing this item. Dependent on dexterity of thief, 166 /* Okay, try stealing this item. Dependent on dexterity of thief,
168 * skill level, see the adj_stealroll fctn for more detail. 167 * skill level, see the adj_stealroll fctn for more detail.
169 */ 168 */
… …
183 if (tmp->destroyed () || tmp->env != op) 182 if (tmp->destroyed () || tmp->env != op)
184 { 183 {
185 /* for players, play_sound: steals item */ 184 /* for players, play_sound: steals item */
186 success = tmp; 185 success = tmp;
187 CLEAR_FLAG (tmp, FLAG_INV_LOCKED); 186 CLEAR_FLAG (tmp, FLAG_INV_LOCKED);
188
189 /* Don't delete it from target player until we know
190 * the thief has picked it up. can't just look at tmp->count,
191 * as it's possible that it got merged when picked up.
192 */
193 if (op->type == PLAYER)
194 esrv_del_item (op->contr, tmp->count);
195 } 187 }
188
196 break; 189 break;
197 } 190 }
198 } /* for loop looking for an item */ 191 } /* for loop looking for an item */
199 192
200 if (!tmp) 193 if (!tmp)
… …
209 */ 202 */
210 203
211 if ((roll >= skill->level) || !chance 204 if ((roll >= skill->level) || !chance
212 || (tmp && tmp->weight > (250 * (random_roll (0, stats_value + skill->level * 10 - 1, who, PREFER_LOW))))) 205 || (tmp && tmp->weight > (250 * (random_roll (0, stats_value + skill->level * 10 - 1, who, PREFER_LOW)))))
213 { 206 {
214
215 /* victim figures out where the thief is! */ 207 /* victim figures out where the thief is! */
216 if (who->hide) 208 if (who->flag [FLAG_HIDDEN])
217 make_visible (who); 209 make_visible (who);
218 210
219 if (op->type != PLAYER) 211 if (op->type != PLAYER)
220 { 212 {
221 /* The unaggressives look after themselves 8) */ 213 /* The unaggressives look after themselves 8) */
222 if (who->type == PLAYER) 214 if (who->type == PLAYER)
223 { 215 {
224 npc_call_help (op); 216 npc_call_help (op);
225 new_draw_info_format (NDI_UNIQUE, 0, who, "%s notices your attempted pilfering!", query_name (op)); 217 new_draw_info_format (NDI_UNIQUE, 0, who, "%s notices your attempted pilfering!", query_name (op));
226 } 218 }
219
227 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE); 220 CLEAR_FLAG (op, FLAG_UNAGGRESSIVE);
228 /* all remaining npc items are guarded now. Set flag NO_STEAL 221 /* all remaining npc items are guarded now. Set flag NO_STEAL
229 * on the victim. 222 * on the victim.
230 */ 223 */
231 SET_FLAG (op, FLAG_NO_STEAL); 224 SET_FLAG (op, FLAG_NO_STEAL);
… …
234 { /* stealing from another player */ 227 { /* stealing from another player */
235 char buf[MAX_BUF]; 228 char buf[MAX_BUF];
236 229
237 /* Notify the other player */ 230 /* Notify the other player */
238 if (success && who->stats.Int > random_roll (0, 19, op, PREFER_LOW)) 231 if (success && who->stats.Int > random_roll (0, 19, op, PREFER_LOW))
239 {
240 sprintf (buf, "Your %s is missing!", query_name (success)); 232 sprintf (buf, "Your %s is missing!", query_name (success));
241 }
242 else 233 else
243 {
244 sprintf (buf, "Your pack feels strangely lighter."); 234 sprintf (buf, "Your pack feels strangely lighter.");
245 } 235
246 new_draw_info (NDI_UNIQUE, 0, op, buf); 236 new_draw_info (NDI_UNIQUE, 0, op, buf);
247 if (!success) 237 if (!success)
248 { 238 {
249 if (who->invisible) 239 if (who->invisible)
250 {
251 sprintf (buf, "you feel itchy fingers getting at your pack."); 240 sprintf (buf, "you feel itchy fingers getting at your pack.");
252 }
253 else 241 else
254 {
255 sprintf (buf, "%s looks very shifty.", query_name (who)); 242 sprintf (buf, "%s looks very shifty.", query_name (who));
256 } 243
257 new_draw_info (NDI_UNIQUE, 0, op, buf); 244 new_draw_info (NDI_UNIQUE, 0, op, buf);
258 } 245 }
259 } /* else stealing from another player */ 246 } /* else stealing from another player */
260 /* play_sound("stop! thief!"); kindofthing */ 247 /* play_sound("stop! thief!"); kindofthing */
261 } /* if you weren't 100% successful */ 248 } /* if you weren't 100% successful */
249
262 return success ? 1 : 0; 250 return success ? 1 : 0;
263} 251}
264
265 252
266int 253int
267steal (object *op, int dir, object *skill) 254steal (object *op, int dir, object *skill)
268{ 255{
269 object *tmp, *next; 256 object *tmp, *next;
… …
414 { 401 {
415 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to pick the lock."); 402 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to pick the lock.");
416 return 0; 403 return 0;
417 } 404 }
418} 405}
419
420 406
421/* HIDE CODE. The user becomes undetectable (not just 'invisible') for 407/* HIDE CODE. The user becomes undetectable (not just 'invisible') for
422 * a short while (success and duration dependant on player SK_level, 408 * a short while (success and duration dependant on player SK_level,
423 * dexterity, charisma, and map difficulty). 409 * dexterity, charisma, and map difficulty).
424 * Players have a good chance of becoming 'unhidden' if they move 410 * Players have a good chance of becoming 'unhidden' if they move
425 * and like invisiblity will be come visible if they attack 411 * and like invisiblity will be come visible if they attack
426 * Implemented by b.t. (thomas@astro.psu.edu) 412 * Implemented by b.t. (thomas@astro.psu.edu)
427 * July 7, 1995 - made hiding possible for monsters. -b.t. 413 * July 7, 1995 - made hiding possible for monsters. -b.t.
428 */ 414 */
429
430static int 415static int
431attempt_hide (object *op, object *skill) 416attempt_hide (object *op, object *skill)
432{ 417{
433 int number, difficulty = op->map->difficulty; 418 int number, difficulty = op->map->difficulty;
434 int terrain = hideability (op); 419 int terrain = hideability (op);
… …
437 return 0; 422 return 0;
438 423
439 /* Hiding success and duration dependant on skill level, 424 /* Hiding success and duration dependant on skill level,
440 * op->stats.Dex, map difficulty and terrain. 425 * op->stats.Dex, map difficulty and terrain.
441 */ 426 */
442
443 number = (die_roll (2, 25, op, PREFER_LOW) - 2) / 2; 427 number = (die_roll (2, 25, op, PREFER_LOW) - 2) / 2;
428
444 if (!stand_near_hostile (op) && (number < (op->stats.Dex + skill->level + terrain - difficulty))) 429 if (!stand_near_hostile (op) && (number < (op->stats.Dex + skill->level + terrain - difficulty)))
445 { 430 {
446 op->invisible += 100; /* set the level of 'hiddeness' */ 431 op->invisible += 100; /* set the level of 'hiddeness' */
432
447 if (op->type == PLAYER) 433 if (op->type == PLAYER)
448 op->contr->tmp_invis = 1; 434 op->contr->tmp_invis = 1;
449 op->hide = 1; 435
436 op->flag [FLAG_HIDDEN] = 1;
450 return 1; 437 return 1;
451 } 438 }
439
452 return 0; 440 return 0;
453} 441}
454 442
455/* patched this to take terrain into consideration */ 443/* patched this to take terrain into consideration */
456int 444int
457hide (object *op, object *skill) 445hide (object *op, object *skill)
458{ 446{
459
460 /* the preliminaries -- Can we really hide now? */ 447 /* the preliminaries -- Can we really hide now? */
461 /* this keeps monsters from using invisibilty spells and hiding */ 448 /* this keeps monsters from using invisibilty spells and hiding */
462 449
463 if (QUERY_FLAG (op, FLAG_MAKE_INVIS)) 450 if (QUERY_FLAG (op, FLAG_MAKE_INVIS))
464 { 451 {
465 new_draw_info (NDI_UNIQUE, 0, op, "You don't need to hide while invisible!"); 452 new_draw_info (NDI_UNIQUE, 0, op, "You don't need to hide while invisible!");
466 return 0; 453 return 0;
467 } 454 }
468 else if (!op->hide && op->invisible > 0 && op->type == PLAYER) 455 else if (!op->flag [FLAG_HIDDEN] && op->invisible > 0 && op->type == PLAYER)
469 { 456 {
470 new_draw_info (NDI_UNIQUE, 0, op, "Your attempt to hide breaks the invisibility spell!"); 457 new_draw_info (NDI_UNIQUE, 0, op, "Your attempt to hide breaks the invisibility spell!");
471 make_visible (op); 458 make_visible (op);
472 } 459 }
473 460
474 if (op->invisible > (50 * skill->level)) 461 if (op->invisible > 50 * skill->level)
475 { 462 {
476 new_draw_info (NDI_UNIQUE, 0, op, "You are as hidden as you can get."); 463 new_draw_info (NDI_UNIQUE, 0, op, "You are as hidden as you can get.");
477 return 0; 464 return 0;
478 } 465 }
479 466
… …
481 { 468 {
482 new_draw_info (NDI_UNIQUE, 0, op, "You hide in the shadows."); 469 new_draw_info (NDI_UNIQUE, 0, op, "You hide in the shadows.");
483 update_object (op, UP_OBJ_FACE); 470 update_object (op, UP_OBJ_FACE);
484 return calc_skill_exp (op, NULL, skill); 471 return calc_skill_exp (op, NULL, skill);
485 } 472 }
473
486 new_draw_info (NDI_UNIQUE, 0, op, "You fail to conceal yourself."); 474 new_draw_info (NDI_UNIQUE, 0, op, "You fail to conceal yourself.");
487 return 0; 475 return 0;
488} 476}
489
490 477
491/* stop_jump() - End of jump. Clear flags, restore the map, and 478/* stop_jump() - End of jump. Clear flags, restore the map, and
492 * freeze the jumper a while to simulate the exhaustion 479 * freeze the jumper a while to simulate the exhaustion
493 * of jumping. 480 * of jumping.
494 */ 481 */
495static void 482static void
496stop_jump (object *pl, int dist, int spaces) 483stop_jump (object *pl, int dist, int spaces)
497{ 484{
498 pl->update_stats (); 485 pl->update_stats ();
499 pl->map->insert (pl, pl->x, pl->y, pl); 486 pl->map->insert (pl, pl->x, pl->y, pl);
487 pl->speed_left -= fabs (pl->speed * 8);
500} 488}
501 489
502static int 490static int
503attempt_jump (object *pl, int dir, int spaces, object *skill) 491attempt_jump (object *pl, int dir, int spaces, object *skill)
504{ 492{
505 object *tmp; 493 object *tmp;
506 int i, exp = 0, dx = freearr_x[dir], dy = freearr_y[dir], mflags; 494 int i, dx = freearr_x[dir], dy = freearr_y[dir], mflags;
507 sint16 x, y; 495 sint16 x, y;
508 maptile *m; 496 maptile *m;
509 497
510 /* Jump loop. Go through spaces opject wants to jump. Halt the 498 /* Jump loop. Go through spaces object wants to jump. Halt the
511 * jump if a wall or creature is in the way. We set FLAG_FLYING 499 * jump if a wall or creature is in the way. We set FLAG_FLYING
512 * temporarily to allow player to aviod exits/archs that are not 500 * temporarily to allow player to aviod exits/archs that are not
513 * fly_on, fly_off. This will also prevent pickup of objects 501 * fly_on, fly_off. This will also prevent pickup of objects
514 * while jumping over them. 502 * while jumping over them.
515 */ 503 */
516
517 pl->remove (); 504 pl->remove ();
518
519 /*
520 * I don't think this is actually needed - all the movement
521 * code is handled in this function, and I don't see anyplace
522 * that cares about the move_type being flying.
523 */
524 pl->move_type |= MOVE_FLY_LOW; 505 pl->move_type |= MOVE_FLY_LOW;
525 506
526 for (i = 0; i <= spaces; i++) 507 for (i = 0; i <= spaces; i++)
527 { 508 {
528 x = pl->x + dx; 509 x = pl->x + dx;
… …
531 512
532 mflags = get_map_flags (m, &m, x, y, &x, &y); 513 mflags = get_map_flags (m, &m, x, y, &x, &y);
533 514
534 if (mflags & P_OUT_OF_MAP) 515 if (mflags & P_OUT_OF_MAP)
535 { 516 {
536 (void) stop_jump (pl, i, spaces); 517 stop_jump (pl, i, spaces);
537 return 0; 518 return 0;
538 } 519 }
520
521 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
522 {
523 /* Jump into creature */
524 if (QUERY_FLAG (tmp, FLAG_MONSTER)
525 || (tmp->type == PLAYER && (!QUERY_FLAG (tmp, FLAG_WIZ) || !tmp->contr->hidden)))
526 {
527 new_draw_info_format (NDI_UNIQUE, 0, pl, "You jump into %s%s.", tmp->type == PLAYER ? "" : "the ", &tmp->name);
528
529 stop_jump (pl, i, spaces);
530
531 int exp = 0;
532
533 if (tmp->type != PLAYER
534 || (pl->type == PLAYER && !pl->contr->party)
535 || (pl->type == PLAYER && tmp->type == PLAYER && pl->contr->party != tmp->contr->party))
536 exp = skill_attack (tmp, pl, pl->facing, "kicked", skill); /* pl makes an attack */
537
538 return exp; /* note that calc_skill_exp() is already called by skill_attack() */
539 }
540 }
541
539 if (OB_TYPE_MOVE_BLOCK (pl, GET_MAP_MOVE_BLOCK (m, x, y))) 542 if (OB_TYPE_MOVE_BLOCK (pl, GET_MAP_MOVE_BLOCK (m, x, y)))
540 { 543 {
541 new_draw_info (NDI_UNIQUE, 0, pl, "Your jump is blocked."); 544 new_draw_info (NDI_UNIQUE, 0, pl, "Your jump is blocked.");
542 stop_jump (pl, i, spaces); 545 stop_jump (pl, i, spaces);
543 return 0; 546 return 0;
544 } 547 }
545 548
546 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
547 {
548 /* Jump into creature */
549 if (QUERY_FLAG (tmp, FLAG_MONSTER) || (tmp->type == PLAYER && (!QUERY_FLAG (tmp, FLAG_WIZ) || !tmp->contr->hidden)))
550 {
551 new_draw_info_format (NDI_UNIQUE, 0, pl, "You jump into %s%s.", tmp->type == PLAYER ? "" : "the ", &tmp->name);
552 if (tmp->type != PLAYER ||
553 (pl->type == PLAYER && pl->contr->party == NULL) ||
554 (pl->type == PLAYER && tmp->type == PLAYER && pl->contr->party != tmp->contr->party))
555 exp = skill_attack (tmp, pl, pl->facing, "kicked", skill); /* pl makes an attack */
556 stop_jump (pl, i, spaces);
557 return exp; /* note that calc_skill_exp() is already called by skill_attack() */
558 }
559 /* If the space has fly on set (no matter what the space is),
560 * we should get the effects - after all, the player is
561 * effectively flying.
562 */
563 if (tmp->move_on & MOVE_FLY_LOW)
564 {
565 pl->x = x;
566 pl->y = y;
567 pl->map = m;
568 stop_jump (pl, i, spaces);
569 return calc_skill_exp (pl, NULL, skill);
570 }
571 }
572 pl->x = x; 549 pl->x = x;
573 pl->y = y; 550 pl->y = y;
574 pl->map = m; 551 pl->map = m;
552
553 if (m->at (x, y).move_on & pl->move_type)
554 {
555 new_draw_info (NDI_UNIQUE, 0, pl, "Your jump is stopped.");
556 stop_jump (pl, i, spaces);
557 return 0;
558 }
575 } 559 }
560
576 stop_jump (pl, i, spaces); 561 stop_jump (pl, i, spaces);
562
577 return calc_skill_exp (pl, NULL, skill); 563 return calc_skill_exp (pl, NULL, skill);
578} 564}
579 565
580/* jump() - this is both a new type of movement for player/monsters and 566/* jump() - this is both a new type of movement for player/monsters and
581 * an attack as well. 567 * an attack as well.
582 * Perhaps we should allow more spaces based on level, eg, level 50 568 * Perhaps we should allow more spaces based on level, eg, level 50
583 * jumper can jump several spaces? 569 * jumper can jump several spaces?
584 */ 570 */
585
586int 571int
587jump (object *pl, int dir, object *skill) 572jump (object *pl, int dir, object *skill)
588{ 573{
589 int spaces = 0, stats;
590 int str = pl->stats.Str; 574 int str = pl->stats.Str;
591 int dex = pl->stats.Dex; 575 int dex = pl->stats.Dex;
592 576
593 dex = dex ? dex : 15; 577 dex = dex ? dex : 15;
594 str = str ? str : 10; 578 str = str ? str : 10;
595 579
596 stats = str * str * str * dex * skill->level; 580 int stats = str * str * str * dex * skill->level;
581 int spaces = min (3, skill->level, stats / (pl->carrying + 1));
597 582
598 if (pl->carrying != 0) /* don't want div by zero !! */
599 spaces = (int) (stats / pl->carrying);
600 else
601 spaces = 2; /* pl has no objects - gets the far jump */
602
603 if (spaces > 2)
604 spaces = 2;
605 else if (spaces == 0) 583 if (spaces == 0)
606 { 584 {
607 new_draw_info (NDI_UNIQUE, 0, pl, "You are carrying too much weight to jump."); 585 new_draw_info (NDI_UNIQUE, 0, pl, "You are carrying too much weight to jump.");
608 return 0; 586 return 0;
609 } 587 }
588
610 return attempt_jump (pl, dir, spaces, skill); 589 return attempt_jump (pl, dir, spaces, skill);
611} 590}
612
613 591
614/* skill_ident() - this code is supposed to allow players to identify 592/* skill_ident() - this code is supposed to allow players to identify
615 * classes of objects with the various "auto-ident" skills. Player must 593 * classes of objects with the various "auto-ident" skills. Player must
616 * have unidentified objects of the right type in order for the skill 594 * have unidentified objects of the right type in order for the skill
617 * to work. While multiple classes of objects may be identified, 595 * to work. While multiple classes of objects may be identified,
618 * this code is kind of yucky -- it would be nice to make it a bit 596 * this code is kind of yucky -- it would be nice to make it a bit
619 * more generalized. Right now, skill indices are embedded in this routine. 597 * more generalized. Right now, skill indices are embedded in this routine.
620 * Returns amount of experience gained (on successful ident). 598 * Returns amount of experience gained (on successful ident).
621 * - b.t. (thomas@astro.psu.edu) 599 * - b.t. (thomas@astro.psu.edu)
622 */ 600 */
623
624static int 601static int
625do_skill_detect_curse (object *pl, object *skill) 602do_skill_detect_curse (object *pl, object *skill)
626{ 603{
627 object *tmp; 604 object *tmp;
628 int success = 0; 605 int success = 0;
… …
682} 659}
683 660
684/* Helper function for do_skill_ident, so that we can loop 661/* Helper function for do_skill_ident, so that we can loop
685 * over inventory AND objects on the ground conveniently. 662 * over inventory AND objects on the ground conveniently.
686 */ 663 */
687int 664static int
688do_skill_ident2 (object *tmp, object *pl, int obj_class, object *skill) 665do_skill_ident2 (object *tmp, object *pl, int obj_class, object *skill)
689{ 666{
690 int success = 0, chance; 667 int success = 0, chance;
691 int skill_value = skill->level * pl->stats.Int ? pl->stats.Int : 10; 668 int skill_value = skill->level * pl->stats.Int ? pl->stats.Int : 10;
692 669
… …
706 if (tmp->msg) 683 if (tmp->msg)
707 { 684 {
708 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:"); 685 new_draw_info (NDI_UNIQUE, 0, pl, "The item has a story:");
709 new_draw_info (NDI_UNIQUE, 0, pl, tmp->msg); 686 new_draw_info (NDI_UNIQUE, 0, pl, tmp->msg);
710 } 687 }
711
712 /* identify will take care of updating the item if it is in the players inventory. IF on map, do it here */
713 if (tmp->map)
714 esrv_send_item (pl, tmp);
715 } 688 }
689
716 success += calc_skill_exp (pl, tmp, skill); 690 success += calc_skill_exp (pl, tmp, skill);
717 } 691 }
718 else 692 else
719 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT); 693 SET_FLAG (tmp, FLAG_NO_SKILL_IDENT);
720 } 694 }
… …
725/* do_skill_ident() - workhorse for skill_ident() -b.t. 699/* do_skill_ident() - workhorse for skill_ident() -b.t.
726 */ 700 */
727static int 701static int
728do_skill_ident (object *pl, int obj_class, object *skill) 702do_skill_ident (object *pl, int obj_class, object *skill)
729{ 703{
730 object *tmp;
731 int success = 0; 704 int success = 0;
732 705
733 for (tmp = pl->inv; tmp; tmp = tmp->below) 706 for (object *tmp = pl->inv; tmp; tmp = tmp->below)
734 success += do_skill_ident2 (tmp, pl, obj_class, skill); 707 success += do_skill_ident2 (tmp, pl, obj_class, skill);
735 /* check the ground */ 708 /* check the ground */
736 709
737 for (tmp = GET_MAP_OB (pl->map, pl->x, pl->y); tmp; tmp = tmp->above) 710 for (object *tmp = pl->ms ().bot; tmp; tmp = tmp->above)
738 success += do_skill_ident2 (tmp, pl, obj_class, skill); 711 success += do_skill_ident2 (tmp, pl, obj_class, skill);
739 712
740 return success; 713 return success;
741} 714}
742 715
… …
750 723
751 new_draw_info (NDI_UNIQUE, 0, pl, "You look at the objects nearby..."); 724 new_draw_info (NDI_UNIQUE, 0, pl, "You look at the objects nearby...");
752 725
753 switch (skill->subtype) 726 switch (skill->subtype)
754 { 727 {
755 case SK_SMITHERY: 728 case SK_SMITHERY:
756 success += do_skill_ident (pl, WEAPON, skill) + do_skill_ident (pl, ARMOUR, skill) 729 success += do_skill_ident (pl, WEAPON, skill) + do_skill_ident (pl, ARMOUR, skill)
757 + do_skill_ident (pl, BRACERS, skill) + do_skill_ident (pl, CLOAK, skill) 730 + do_skill_ident (pl, BRACERS, skill) + do_skill_ident (pl, CLOAK, skill)
758 + do_skill_ident (pl, BOOTS, skill) + do_skill_ident (pl, SHIELD, skill) 731 + do_skill_ident (pl, BOOTS, skill) + do_skill_ident (pl, SHIELD, skill)
759 + do_skill_ident (pl, GIRDLE, skill) + do_skill_ident (pl, HELMET, skill) + do_skill_ident (pl, GLOVES, skill); 732 + do_skill_ident (pl, GIRDLE, skill) + do_skill_ident (pl, HELMET, skill) + do_skill_ident (pl, GLOVES, skill);
760 break; 733 break;
761 734
762 case SK_BOWYER: 735 case SK_BOWYER:
763 success += do_skill_ident (pl, BOW, skill) + do_skill_ident (pl, ARROW, skill); 736 success += do_skill_ident (pl, BOW, skill) + do_skill_ident (pl, ARROW, skill);
764 break; 737 break;
765 738
766 case SK_ALCHEMY: 739 case SK_ALCHEMY:
767 success += do_skill_ident (pl, POTION, skill) + do_skill_ident (pl, POISON, skill) 740 success += do_skill_ident (pl, POTION, skill) + do_skill_ident (pl, POISON, skill)
768 + do_skill_ident (pl, CONTAINER, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, INORGANIC, skill); 741 + do_skill_ident (pl, CONTAINER, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, INORGANIC, skill);
769 break; 742 break;
770 743
771 case SK_WOODSMAN: 744 case SK_WOODSMAN:
772 success += do_skill_ident (pl, FOOD, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, FLESH, skill); 745 success += do_skill_ident (pl, FOOD, skill) + do_skill_ident (pl, DRINK, skill) + do_skill_ident (pl, FLESH, skill);
773 break; 746 break;
774 747
775 case SK_JEWELER: 748 case SK_JEWELER:
776 success += do_skill_ident (pl, GEM, skill) + do_skill_ident (pl, RING, skill) + do_skill_ident (pl, AMULET, skill); 749 success += do_skill_ident (pl, GEM, skill) + do_skill_ident (pl, RING, skill) + do_skill_ident (pl, AMULET, skill);
777 break; 750 break;
778 751
779 case SK_LITERACY: 752 case SK_LITERACY:
780 success += do_skill_ident (pl, SPELLBOOK, skill) + do_skill_ident (pl, SCROLL, skill) + do_skill_ident (pl, BOOK, skill); 753 success += do_skill_ident (pl, SPELLBOOK, skill) + do_skill_ident (pl, SCROLL, skill) + do_skill_ident (pl, BOOK, skill);
781 break; 754 break;
782 755
783 case SK_THAUMATURGY: 756 case SK_THAUMATURGY:
784 success += do_skill_ident (pl, WAND, skill) + do_skill_ident (pl, ROD, skill) + do_skill_ident (pl, HORN, skill); 757 success += do_skill_ident (pl, WAND, skill) + do_skill_ident (pl, ROD, skill) + do_skill_ident (pl, HORN, skill);
785 break; 758 break;
786 759
787 case SK_DET_CURSE: 760 case SK_DET_CURSE:
788 success = do_skill_detect_curse (pl, skill); 761 success = do_skill_detect_curse (pl, skill);
789 if (success) 762 if (success)
790 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover cursed items!"); 763 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover cursed items!");
791 break; 764 break;
792 765
793 case SK_DET_MAGIC: 766 case SK_DET_MAGIC:
794 success = do_skill_detect_magic (pl, skill); 767 success = do_skill_detect_magic (pl, skill);
795 if (success) 768 if (success)
796 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover items imbued with mystic forces!"); 769 new_draw_info (NDI_UNIQUE, 0, pl, "...and discover items imbued with mystic forces!");
797 break; 770 break;
798 771
799 default: 772 default:
800 LOG (llevError, "Error: bad call to skill_ident()\n"); 773 LOG (llevError, "Error: bad call to skill_ident()\n");
801 return 0; 774 return 0;
802 break; 775 break;
803 } 776 }
777
804 if (!success) 778 if (!success)
805 {
806 new_draw_info (NDI_UNIQUE, 0, pl, "...and learn nothing more."); 779 new_draw_info (NDI_UNIQUE, 0, pl, "...and learn nothing more.");
807 } 780
808 return success; 781 return success;
809} 782}
810 783
811/* players using this skill can 'charm' a monster -- 784/* players using this skill can 'charm' a monster --
812 * into working for them. It can only be used on 785 * into working for them. It can only be used on
… …
814 * -b.t. (thomas@astro.psu.edu) 787 * -b.t. (thomas@astro.psu.edu)
815 */ 788 */
816int 789int
817use_oratory (object *pl, int dir, object *skill) 790use_oratory (object *pl, int dir, object *skill)
818{ 791{
819 sint16 x = pl->x + freearr_x[dir], y = pl->y + freearr_y[dir];
820 int mflags, chance;
821 object *tmp;
822 maptile *m;
823
824 if (pl->type != PLAYER) 792 if (pl->type != PLAYER)
825 return 0; /* only players use this skill */ 793 return 0; /* only players use this skill */
794
795 sint16 x = pl->x + freearr_x[dir],
796 y = pl->y + freearr_y[dir];
826 m = pl->map; 797 maptile *m = pl->map;
798
827 mflags = get_map_flags (m, &m, x, y, &x, &y); 799 int mflags = get_map_flags (m, &m, x, y, &x, &y);
828 if (mflags & P_OUT_OF_MAP) 800 if (mflags & P_OUT_OF_MAP)
829 return 0; 801 return 0;
830 802
831 /* Save some processing - we have the flag already anyways 803 /* Save some processing - we have the flag already anyways
832 */ 804 */
… …
834 { 806 {
835 new_draw_info (NDI_UNIQUE, 0, pl, "There is nothing to orate to."); 807 new_draw_info (NDI_UNIQUE, 0, pl, "There is nothing to orate to.");
836 return 0; 808 return 0;
837 } 809 }
838 810
811 object *tmp;
839 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above) 812 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
840 { 813 {
841 /* can't persuade players - return because there is nothing else 814 /* can't persuade players - return because there is nothing else
842 * on that space to charm. Same for multi space monsters and 815 * on that space to charm. Same for multi space monsters and
843 * special monsters - we don't allow them to be charmed, and there 816 * special monsters - we don't allow them to be charmed, and there
844 * is no reason to do further processing since they should be the 817 * is no reason to do further processing since they should be the
845 * only monster on the space. 818 * only monster on the space.
846 */ 819 */
847 if (tmp->type == PLAYER) 820 if (tmp->type == PLAYER
848 return 0; 821 || tmp->more || tmp->head_ () != tmp
849 if (tmp->more || tmp->head) 822 || tmp->msg)
850 return 0;
851 if (tmp->msg)
852 return 0; 823 return 0;
853 824
854 if (QUERY_FLAG (tmp, FLAG_MONSTER)) 825 if (QUERY_FLAG (tmp, FLAG_MONSTER))
855 break; 826 break;
856 } 827 }
… …
871 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp)); 842 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp));
872 return 0; 843 return 0;
873 } 844 }
874 845
875 /* it's already allied! */ 846 /* it's already allied! */
876 if (QUERY_FLAG (tmp, FLAG_FRIENDLY) && (tmp->attack_movement == PETMOVE)) 847 if (QUERY_FLAG (tmp, FLAG_FRIENDLY) && tmp->attack_movement == PETMOVE)
877 { 848 {
878 if (tmp->owner == pl) 849 if (tmp->owner == pl)
879 { 850 {
880 new_draw_info (NDI_UNIQUE, 0, pl, "Your follower loves your speech.\n"); 851 new_draw_info (NDI_UNIQUE, 0, pl, "Your follower loves your speech.\n");
881 return 0; 852 return 0;
… …
884 { 855 {
885 /* you steal the follower. Perhaps we should really look at the 856 /* you steal the follower. Perhaps we should really look at the
886 * level of the owner above? 857 * level of the owner above?
887 */ 858 */
888 tmp->set_owner (pl); 859 tmp->set_owner (pl);
860 tmp->skill = skill->skill;
861
889 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to follow you instead!\n", query_name (tmp)); 862 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to follow you instead!\n", query_name (tmp));
890 /* Abuse fix - don't give exp since this can otherwise 863 /* Abuse fix - don't give exp since this can otherwise
891 * be used by a couple players to gets lots of exp. 864 * be used by a couple players to gets lots of exp.
892 */ 865 */
893 return 0; 866 return 0;
… …
897 /* In this case, you can't steal it from the other player */ 870 /* In this case, you can't steal it from the other player */
898 return 0; 871 return 0;
899 } 872 }
900 } /* Creature was already a pet of someone */ 873 } /* Creature was already a pet of someone */
901 874
902 chance = skill->level * 2 + (pl->stats.Cha - 2 * tmp->stats.Int) / 2; 875 int level = skill->level + (pl->stats.Cha - tmp->stats.Int) / 2;
903 876
904 /* Ok, got a 'sucker' lets try to make them a follower */ 877 /* Ok, got a 'sucker' lets try to make them a follower */
905 if (chance > 0 && tmp->level < (random_roll (0, chance - 1, pl, PREFER_HIGH) - 1)) 878 if (level > 0 && tmp->level < (random_roll (0, level - 1, pl, PREFER_HIGH) - 1))
906 { 879 {
907 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to become your follower.\n", query_name (tmp)); 880 new_draw_info_format (NDI_UNIQUE, 0, pl, "You convince the %s to become your follower.\n", query_name (tmp));
908 881
882 INVOKE_OBJECT (KILL, tmp, ARG_OBJECT (pl));
909 tmp->set_owner (pl); 883 tmp->set_owner (pl);
884 tmp->skill = skill->skill;
910 tmp->stats.exp = 0; 885 tmp->stats.exp = 0;
911 add_friendly_object (tmp);
912 tmp->attack_movement = PETMOVE; 886 tmp->attack_movement = PETMOVE;
887
888 if (!QUERY_FLAG (tmp, FLAG_FRIENDLY))
889 add_friendly_object (tmp);
890
913 return calc_skill_exp (pl, tmp, skill); 891 return calc_skill_exp (pl, tmp, skill);
914 } 892 }
915 /* Charm failed. Creature may be angry now */ 893 /* Charm failed. Creature may be angry now */
916 else if ((skill->level + ((pl->stats.Cha - 10) / 2)) < random_roll (1, 2 * tmp->level, pl, PREFER_LOW)) 894 else if ((skill->level + ((pl->stats.Cha - 10) / 2)) < random_roll (1, 2 * tmp->level, pl, PREFER_LOW))
917 { 895 {
918 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your speech angers the %s!\n", query_name (tmp)); 896 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your speech angers the %s!\n", query_name (tmp));
919 if (QUERY_FLAG (tmp, FLAG_FRIENDLY)) 897 if (QUERY_FLAG (tmp, FLAG_FRIENDLY))
920 { 898 {
921 CLEAR_FLAG (tmp, FLAG_FRIENDLY);
922 remove_friendly_object (tmp); 899 remove_friendly_object (tmp);
923 tmp->attack_movement = 0; /* needed? */ 900 tmp->attack_movement = 0; /* needed? */
924 } 901 }
902
925 CLEAR_FLAG (tmp, FLAG_UNAGGRESSIVE); 903 CLEAR_FLAG (tmp, FLAG_UNAGGRESSIVE);
926 } 904 }
927 905
928 return 0; /* Fall through - if we get here, we didn't charm anything */ 906 return 0; /* Fall through - if we get here, we didn't charm anything */
929} 907}
… …
935 * successfully pacified the creature gets Int=1. Thus, a player 913 * successfully pacified the creature gets Int=1. Thus, a player
936 * may only pacify a creature once. 914 * may only pacify a creature once.
937 * BTW, I appologize for the naming of the skill, I couldnt think 915 * BTW, I appologize for the naming of the skill, I couldnt think
938 * of anything better! -b.t. 916 * of anything better! -b.t.
939 */ 917 */
940
941int 918int
942singing (object *pl, int dir, object *skill) 919singing (object *pl, int dir, object *skill)
943{ 920{
944 int i, exp = 0, chance, mflags; 921 int i, exp = 0;
945 object *tmp; 922 object *tmp;
946 maptile *m; 923 maptile *m;
947 sint16 x, y; 924 sint16 x, y;
948 925
949 if (pl->type != PLAYER) 926 if (pl->type != PLAYER)
… …
954 { 931 {
955 x = pl->x + freearr_x[i]; 932 x = pl->x + freearr_x[i];
956 y = pl->y + freearr_y[i]; 933 y = pl->y + freearr_y[i];
957 m = pl->map; 934 m = pl->map;
958 935
959 mflags = get_map_flags (m, &m, x, y, &x, &y); 936 int mflags = get_map_flags (m, &m, x, y, &x, &y);
960 if (mflags & P_OUT_OF_MAP) 937 if (mflags & P_OUT_OF_MAP)
961 continue; 938 continue;
962 if (!(mflags & P_IS_ALIVE)) 939 if (!(mflags & P_IS_ALIVE))
963 continue; 940 continue;
964 941
… …
983 960
984 /* stealing isn't really related (although, maybe it should 961 /* stealing isn't really related (although, maybe it should
985 * be). This is mainly to prevent singing to the same monster 962 * be). This is mainly to prevent singing to the same monster
986 * over and over again and getting exp for it. 963 * over and over again and getting exp for it.
987 */ 964 */
988 chance = skill->level * 2 + (pl->stats.Cha - 5 - tmp->stats.Int) / 2; 965 int level = skill->level + (pl->stats.Cha - 5 - tmp->stats.Int) / 2;
966
989 if (chance && tmp->level * 2 < random_roll (0, chance - 1, pl, PREFER_HIGH)) 967 if (level && tmp->level < random_roll (0, level - 1, pl, PREFER_HIGH))
990 { 968 {
991 SET_FLAG (tmp, FLAG_UNAGGRESSIVE); 969 SET_FLAG (tmp, FLAG_UNAGGRESSIVE);
992 new_draw_info_format (NDI_UNIQUE, 0, pl, "You calm down the %s\n", query_name (tmp)); 970 new_draw_info_format (NDI_UNIQUE, 0, pl, "You calm down the %s\n", query_name (tmp));
993 /* Give exp only if they are not aware */ 971 /* Give exp only if they are not aware */
972
994 if (!QUERY_FLAG (tmp, FLAG_NO_STEAL)) 973 if (!QUERY_FLAG (tmp, FLAG_NO_STEAL))
995 exp += calc_skill_exp (pl, tmp, skill); 974 exp += calc_skill_exp (pl, tmp, skill);
975
996 SET_FLAG (tmp, FLAG_NO_STEAL); 976 SET_FLAG (tmp, FLAG_NO_STEAL);
997 } 977 }
998 else 978 else
999 { 979 {
1000 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp)); 980 new_draw_info_format (NDI_UNIQUE, 0, pl, "Too bad the %s isn't listening!\n", query_name (tmp));
… …
1073} 1053}
1074 1054
1075/* remove_trap() - This skill will disarm any previously discovered trap 1055/* remove_trap() - This skill will disarm any previously discovered trap
1076 * the algorithm is based (almost totally) on the old command_disarm() - b.t. 1056 * the algorithm is based (almost totally) on the old command_disarm() - b.t.
1077 */ 1057 */
1078
1079int 1058int
1080remove_trap (object *op, int dir, object *skill) 1059remove_trap (object *op, int dir, object *skill)
1081{ 1060{
1082 object *tmp, *tmp2; 1061 object *tmp, *tmp2;
1083 int i, success = 0, mflags; 1062 int i, success = 0, mflags;
… …
1093 mflags = get_map_flags (m, &m, x, y, &x, &y); 1072 mflags = get_map_flags (m, &m, x, y, &x, &y);
1094 if (mflags & P_OUT_OF_MAP) 1073 if (mflags & P_OUT_OF_MAP)
1095 continue; 1074 continue;
1096 1075
1097 /* Check everything in the square for trapness */ 1076 /* Check everything in the square for trapness */
1098 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1077 for (tmp = GET_MAP_OB (m, x, y); tmp; tmp = tmp->above)
1099 { 1078 {
1100 /* And now we'd better do an inventory traversal of each 1079 /* And now we'd better do an inventory traversal of each
1101 * of these objects inventory. Like above, only 1080 * of these objects inventory. Like above, only
1102 * do this for interesting objects. 1081 * do this for interesting objects.
1103 */ 1082 */
1104 1083
1105 if (tmp->type != PLAYER && !QUERY_FLAG (tmp, FLAG_MONSTER)) 1084 if (tmp->type != PLAYER && !QUERY_FLAG (tmp, FLAG_MONSTER))
1106 { 1085 {
1107 for (tmp2 = tmp->inv; tmp2 != NULL; tmp2 = tmp2->below) 1086 for (tmp2 = tmp->inv; tmp2; tmp2 = tmp2->below)
1108 if ((tmp2->type == RUNE || tmp2->type == TRAP) && tmp2->stats.Cha <= 1) 1087 if ((tmp2->type == RUNE || tmp2->type == TRAP) && tmp2->stats.Cha <= 1)
1109 { 1088 {
1110 trap_show (tmp2, tmp); 1089 trap_show (tmp2, tmp);
1090
1111 if (trap_disarm (op, tmp2, 1, skill) && (!tmp2->owner || tmp2->owner->type != PLAYER)) 1091 if (trap_disarm (op, tmp2, 1, skill) && (!tmp2->owner || tmp2->owner->type != PLAYER))
1112 { 1092 {
1113 tmp->stats.exp = tmp->stats.Cha * tmp->level; 1093 tmp->stats.exp = tmp->stats.Cha * tmp->level;
1114 success += calc_skill_exp (op, tmp2, skill); 1094 success += calc_skill_exp (op, tmp2, skill);
1115 } 1095 }
1116 } 1096 }
1117 } 1097 }
1098
1118 if ((tmp->type == RUNE || tmp->type == TRAP) && tmp->stats.Cha <= 1) 1099 if ((tmp->type == RUNE || tmp->type == TRAP) && tmp->stats.Cha <= 1)
1119 { 1100 {
1120 trap_show (tmp, tmp); 1101 trap_show (tmp, tmp);
1102
1121 if (trap_disarm (op, tmp, 1, skill) && (!tmp->owner || tmp->owner->type != PLAYER)) 1103 if (trap_disarm (op, tmp, 1, skill) && (!tmp->owner || tmp->owner->type != PLAYER))
1122 { 1104 {
1123 tmp->stats.exp = tmp->stats.Cha * tmp->level; 1105 tmp->stats.exp = tmp->stats.Cha * tmp->level;
1124 success += calc_skill_exp (op, tmp, skill); 1106 success += calc_skill_exp (op, tmp, skill);
1125 } 1107 }
1126 } 1108 }
1127 } 1109 }
1128 } 1110 }
1111
1129 return success; 1112 return success;
1130} 1113}
1131
1132 1114
1133/* pray() - when this skill is called from do_skill(), it allows 1115/* pray() - when this skill is called from do_skill(), it allows
1134 * the player to regain lost grace points at a faster rate. -b.t. 1116 * the player to regain lost grace points at a faster rate. -b.t.
1135 * This always returns 0 - return value is used by calling function 1117 * This always returns 0 - return value is used by calling function
1136 * such that if it returns true, player gets exp in that skill. This 1118 * such that if it returns true, player gets exp in that skill. This
1137 * the effect here can be done on demand, we probably don't want to 1119 * the effect here can be done on demand, we probably don't want to
1138 * give infinite exp by returning true in any cases. 1120 * give infinite exp by returning true in any cases.
1139 */ 1121 */
1140
1141int 1122int
1142pray (object *pl, object *skill) 1123pray (object *pl, object *skill)
1143{ 1124{
1144 char buf[MAX_BUF]; 1125 char buf[MAX_BUF];
1145 object *tmp; 1126 object *tmp;
… …
1152 /* Check all objects - we could stop at floor objects, 1133 /* Check all objects - we could stop at floor objects,
1153 * but if someone buries an altar, I don't see a problem with 1134 * but if someone buries an altar, I don't see a problem with
1154 * going through all the objects, and it shouldn't be much slower 1135 * going through all the objects, and it shouldn't be much slower
1155 * than extra checks on object attributes. 1136 * than extra checks on object attributes.
1156 */ 1137 */
1157 for (tmp = pl->below; tmp != NULL; tmp = tmp->below) 1138 for (tmp = pl->below; tmp; tmp = tmp->below)
1158 { 1139 {
1159 /* Only if the altar actually belongs to someone do you get special benefits */ 1140 /* Only if the altar actually belongs to someone do you get special benefits */
1160 if (tmp && tmp->type == HOLY_ALTAR && tmp->other_arch) 1141 if (tmp && tmp->type == HOLY_ALTAR && tmp->other_arch)
1161 { 1142 {
1162 sprintf (buf, "You pray over the %s.", &tmp->name); 1143 sprintf (buf, "You pray over the %s.", &tmp->name);
… …
1170 if (pl->stats.grace < pl->stats.maxgrace) 1151 if (pl->stats.grace < pl->stats.maxgrace)
1171 { 1152 {
1172 pl->stats.grace++; 1153 pl->stats.grace++;
1173 pl->last_grace = -1; 1154 pl->last_grace = -1;
1174 } 1155 }
1156
1175 return 0; 1157 return 0;
1176} 1158}
1177 1159
1178/* This skill allows the player to regain a few sp or hp for a 1160/* This skill allows the player to regain a few sp or hp for a
1179 * brief period of concentration. No armour or weapons may be 1161 * brief period of concentration. No armour or weapons may be
1180 * wielded/applied for this to work. The amount of time needed 1162 * wielded/applied for this to work. The amount of time needed
1181 * to concentrate and the # of points regained is dependant on 1163 * to concentrate and the # of points regained is dependant on
1182 * the level of the user. - b.t. thomas@astro.psu.edu 1164 * the level of the user. - b.t. thomas@astro.psu.edu
1183 */ 1165 */
1184
1185void 1166void
1186meditate (object *pl, object *skill) 1167meditate (object *pl, object *skill)
1187{ 1168{
1188 object *tmp; 1169 object *tmp;
1189 1170
… …
1197 return; 1178 return;
1198 } 1179 }
1199 else 1180 else
1200 { 1181 {
1201 for (tmp = pl->inv; tmp; tmp = tmp->below) 1182 for (tmp = pl->inv; tmp; tmp = tmp->below)
1202 if (((tmp->type == ARMOUR && skill->level < 12) 1183 if (((tmp->type == ARMOUR && skill->level < 12)
1203 || (tmp->type == HELMET && skill->level < 10) 1184 || (tmp->type == HELMET && skill->level < 10)
1204 || (tmp->type == SHIELD && skill->level < 6) 1185 || (tmp->type == SHIELD && skill->level < 6)
1205 || (tmp->type == BOOTS && skill->level < 4) || (tmp->type == GLOVES && skill->level < 2)) && QUERY_FLAG (tmp, FLAG_APPLIED)) 1186 || (tmp->type == BOOTS && skill->level < 4)
1187 || (tmp->type == GLOVES && skill->level < 2))
1188 && QUERY_FLAG (tmp, FLAG_APPLIED))
1206 { 1189 {
1207 new_draw_info (NDI_UNIQUE, 0, pl, "You can't concentrate while wearing so much armour!\n"); 1190 new_draw_info (NDI_UNIQUE, 0, pl, "You can't concentrate while wearing so much armour!\n");
1208 return; 1191 return;
1209 } 1192 }
1210 } 1193 }
… …
1230 pl->last_heal = -1; 1213 pl->last_heal = -1;
1231 } 1214 }
1232} 1215}
1233 1216
1234/* write_note() - this routine allows players to inscribe messages in 1217/* write_note() - this routine allows players to inscribe messages in
1235 * ordinary 'books' (anything that is type BOOK). b.t. 1218 * ordinary inscribable 'books' (anything that is not a SPELL). b.t.
1236 */ 1219 */
1237static int 1220static int
1238write_note (object *pl, object *item, const char *msg, object *skill) 1221write_note (object *pl, object *item, const char *msg, object *skill)
1239{ 1222{
1240 char buf[1024]; 1223 if (!msg_is_safe (msg))
1241 object *newBook = NULL;
1242
1243 /* a pair of sanity checks */
1244 if (!item || item->type != BOOK)
1245 return 0;
1246
1247 if (!msg)
1248 {
1249 new_draw_info (NDI_UNIQUE, 0, pl, "No message to write!");
1250 new_draw_info_format (NDI_UNIQUE, 0, pl, "Usage: use_skill %s <message>", &skill->skill);
1251 return 0;
1252 }
1253
1254 if (strcasestr_local (msg, "endmsg"))
1255 { 1224 {
1256 new_draw_info (NDI_UNIQUE, 0, pl, "Trying to cheat now are we?"); 1225 new_draw_info (NDI_UNIQUE, 0, pl, "Trying to cheat now are we?");
1226 LOG (llevInfo, "write_note: player %s tried to write bogus note %s\n", &pl->name, msg);
1227 return 0;
1228 }
1229
1230 int len = strlen (msg);
1231
1232 if (!is_utf8_string ((U8 *)msg, len))
1233 {
1234 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message is garbled (text must be UTF-8, client-bug)!");
1257 return 0; 1235 return 0;
1258 } 1236 }
1259 1237
1260 if (INVOKE_OBJECT (INSCRIBE_NOTE, item, ARG_PLAYER (pl->contr), ARG_STRING (msg), ARG_OBJECT (skill))) 1238 if (INVOKE_OBJECT (INSCRIBE_NOTE, item, ARG_PLAYER (pl->contr), ARG_STRING (msg), ARG_OBJECT (skill)))
1261 return strlen (msg); 1239 return RESULT_INT (0);
1262 1240
1263 buf[0] = 0; 1241 STRLEN char_len = utf8_length ((U8 *)msg, (U8 *)(msg+len));
1264 if (!book_overflow (item->msg, msg, sizeof (buf)))
1265 { /* add msg string to book */
1266 if (item->msg)
1267 strcpy (buf, item->msg);
1268 1242
1269 strcat (buf, msg); 1243 if (char_len <= item->weight_limit)
1270 strcat (buf, "\n"); /* new msg needs a LF */ 1244 {
1271 if (item->nrof > 1) 1245 object *newbook = arch_to_object (item->other_arch);
1272 { 1246 item->decrease ();
1273 newBook = item->clone ();
1274 decrease_ob (item);
1275 esrv_send_item (pl, item);
1276 newBook->nrof = 1; 1247 newbook->nrof = 1;
1277 newBook->msg = buf; 1248 newbook->msg = shstr (msg);
1278 newBook = insert_ob_in_ob (newBook, pl); 1249 newbook->flag [FLAG_IDENTIFIED] = true;
1279 esrv_send_item (pl, newBook); 1250
1251 if (item->subtype == 1) // mailscrolls
1280 } 1252 {
1281 else 1253 newbook->name = item->name;
1254 newbook->name_pl = item->name_pl;
1282 { 1255 }
1283 item->msg = buf;
1284 /* This shouldn't be necessary - the object hasn't changed in any
1285 * visible way
1286 */
1287 /* esrv_send_item(pl, item); */
1288 }
1289 1256
1257 pl->insert (newbook);
1258
1259 pl->contr->play_sound (sound_find ("inscribe_success"));
1290 new_draw_info_format (NDI_UNIQUE, 0, pl, "You write in the %s.", query_short_name (item)); 1260 new_draw_info_format (NDI_UNIQUE, 0, pl, "You write in the %s.", &item->name);
1291 return strlen (msg); 1261 return char_len;
1292 } 1262 }
1293 else 1263 else
1294 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message won't fit in the %s!", query_short_name (item)); 1264 new_draw_info_format (NDI_UNIQUE, 0, pl, "Your message won't fit in the %s! H<It is only big enough for %d characters, your message had %d characters.>",
1265 &item->name, item->weight_limit, char_len);
1295 1266
1296 return 0; 1267 return 0;
1297} 1268}
1298 1269
1299/* write_scroll() - this routine allows players to inscribe spell scrolls 1270/* write_scroll() - this routine allows players to inscribe spell scrolls
1300 * of spells which they know. Backfire effects are possible with the 1271 * of spells which they know. Backfire effects are possible with the
1301 * severity of the backlash correlated with the difficulty of the scroll 1272 * severity of the backlash correlated with the difficulty of the scroll
1302 * that is attempted. -b.t. thomas@astro.psu.edu 1273 * that is attempted. -b.t. thomas@astro.psu.edu
1303 */ 1274 */
1304
1305static int 1275static int
1306write_scroll (object *pl, object *scroll, object *skill) 1276write_scroll (object *pl, object *scroll, object *skill)
1307{ 1277{
1308 int success = 0, confused = 0; 1278 int success = 0, confused = 0;
1309 object *newscroll, *chosen_spell, *tmp;
1310
1311 /* this is a sanity check */
1312 if (scroll->type != SCROLL)
1313 {
1314 new_draw_info (NDI_UNIQUE, 0, pl, "A spell can only be inscribed into a scroll!");
1315 return 0;
1316 }
1317 1279
1318 /* Check if we are ready to attempt inscription */ 1280 /* Check if we are ready to attempt inscription */
1319 chosen_spell = pl->contr->ranges[range_magic]; 1281 object *chosen_spell = pl->contr->ranged_ob;
1320 if (!chosen_spell) 1282
1283 if (!chosen_spell || chosen_spell->type != SPELL)
1321 { 1284 {
1322 new_draw_info (NDI_UNIQUE, 0, pl, "You need a spell readied in order to inscribe!"); 1285 new_draw_info (NDI_UNIQUE, 0, pl, "You need a spell readied in order to inscribe!");
1323 return 0; 1286 return 0;
1324 } 1287 }
1325 1288
… …
1330 } 1293 }
1331 1294
1332 if (SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA) > pl->stats.sp) 1295 if (SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA) > pl->stats.sp)
1333 { 1296 {
1334 new_draw_info_format (NDI_UNIQUE, 0, pl, "You don't have enough mana to write a scroll of %s.", &chosen_spell->name); 1297 new_draw_info_format (NDI_UNIQUE, 0, pl, "You don't have enough mana to write a scroll of %s.", &chosen_spell->name);
1335 return 0;
1336 }
1337
1338 /* if there is a spell already on the scroll then player could easily
1339 * accidently read it while trying to write the new one. give player
1340 * a 50% chance to overwrite spell at their own level
1341 */
1342 if ((scroll->stats.sp || scroll->inv) && random_roll (0, scroll->level * 2, pl, PREFER_LOW) > skill->level)
1343 {
1344 new_draw_info_format (NDI_UNIQUE, 0, pl, "Oops! You accidently read it while trying to write on it.");
1345 manual_apply (pl, scroll, 0);
1346 return 0; 1298 return 0;
1347 } 1299 }
1348 1300
1349 /* ok, we are ready to try inscription */ 1301 /* ok, we are ready to try inscription */
1350 if (QUERY_FLAG (pl, FLAG_CONFUSED)) 1302 if (QUERY_FLAG (pl, FLAG_CONFUSED))
… …
1354 pl->stats.grace -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_GRACE); 1306 pl->stats.grace -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_GRACE);
1355 pl->stats.sp -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA); 1307 pl->stats.sp -= SP_level_spellpoint_cost (pl, chosen_spell, SPELL_MANA);
1356 1308
1357 if (random_roll (0, chosen_spell->level * 4 - 1, pl, PREFER_LOW) < skill->level) 1309 if (random_roll (0, chosen_spell->level * 4 - 1, pl, PREFER_LOW) < skill->level)
1358 { 1310 {
1359 if (scroll->nrof > 1) 1311 object *newscroll = arch_to_object (scroll->other_arch);
1360 { 1312 scroll->decrease ();
1361 newscroll = scroll->clone ();
1362 decrease_ob (scroll);
1363 newscroll->nrof = 1; 1313 newscroll->nrof = 1;
1364 } 1314
1365 else 1315 pl->contr->play_sound (sound_find ("inscribe_success"));
1366 newscroll = scroll;
1367 1316
1368 if (!confused) 1317 if (!confused)
1369 { 1318 {
1370 newscroll->level = MAX (skill->level, chosen_spell->level); 1319 newscroll->level = MAX (skill->level, chosen_spell->level);
1320 newscroll->flag [FLAG_IDENTIFIED] = true;
1371 new_draw_info (NDI_UNIQUE, 0, pl, "You succeed in writing a new scroll."); 1321 new_draw_info (NDI_UNIQUE, 0, pl, "You succeed in writing the spell.");
1372 } 1322 }
1373 else 1323 else
1374 { 1324 {
1375 chosen_spell = find_random_spell_in_ob (pl, NULL); 1325 chosen_spell = find_random_spell_in_ob (pl, NULL);
1376 if (!chosen_spell) 1326 if (!chosen_spell)
… …
1378 1328
1379 newscroll->level = MAX (skill->level, chosen_spell->level); 1329 newscroll->level = MAX (skill->level, chosen_spell->level);
1380 new_draw_info (NDI_UNIQUE, 0, pl, "In your confused state, you write down some odd spell."); 1330 new_draw_info (NDI_UNIQUE, 0, pl, "In your confused state, you write down some odd spell.");
1381 } 1331 }
1382 1332
1383 if (newscroll->inv)
1384 newscroll->inv->destroy ();
1385
1386 tmp = chosen_spell->clone (); 1333 object *tmp = chosen_spell->clone ();
1387 insert_ob_in_ob (tmp, newscroll); 1334 insert_ob_in_ob (tmp, newscroll);
1388 1335
1389 /* Same code as from treasure.c - so they can better merge. 1336 /* Same code as from treasure.C - so they can better merge.
1390 * if players want to sell them, so be it. 1337 * if players want to sell them, so be it.
1391 */ 1338 */
1392 newscroll->value = newscroll->arch->clone.value * newscroll->inv->value * (newscroll->level + 50) / (newscroll->inv->level + 50); 1339 newscroll->value = newscroll->arch->value * newscroll->inv->value * (newscroll->level + 50) / (newscroll->inv->level + 50);
1393 newscroll->stats.exp = newscroll->value / 5; 1340 newscroll->stats.exp = newscroll->value / 5;
1394 1341
1395 /* wait until finished manipulating the scroll before inserting it */ 1342 pl->insert (newscroll);
1396 if (newscroll == scroll)
1397 {
1398 /* Remove to correctly merge with other items which may exist in inventory */
1399 newscroll->remove ();
1400 esrv_del_item (pl->contr, newscroll->count);
1401 }
1402 1343
1403 newscroll = insert_ob_in_ob (newscroll, pl);
1404 esrv_send_item (pl, newscroll);
1405 success = calc_skill_exp (pl, newscroll, skill); 1344 success = calc_skill_exp (pl, newscroll, skill);
1406 if (!confused) 1345 if (!confused)
1407 success *= 2; 1346 success *= 2;
1347
1408 success = success * skill->level; 1348 success = success * skill->level;
1409 return success; 1349 return success;
1410
1411 } 1350 }
1412 else 1351 else
1413 { /* Inscription has failed */ 1352 { /* Inscription has failed */
1353 pl->contr->play_sound (sound_find ("inscribe_fail"));
1414 1354
1415 if (chosen_spell->level > skill->level || confused) 1355 if (chosen_spell->level > skill->level || confused)
1416 { /*backfire! */ 1356 { /*backfire! */
1417 new_draw_info (NDI_UNIQUE, 0, pl, "Ouch! Your attempt to write a new scroll strains your mind!"); 1357 new_draw_info (NDI_UNIQUE, 0, pl, "Ouch! Your attempt to write a new scroll strains your mind!");
1358
1418 if (random_roll (0, 1, pl, PREFER_LOW) == 1) 1359 if (random_roll (0, 1, pl, PREFER_LOW) == 1)
1419 pl->drain_specific_stat (4); 1360 pl->drain_specific_stat (4);
1420 else 1361 else
1421 { 1362 {
1422 confuse_player (pl, pl, 99); 1363 confuse_player (pl, pl, 99);
1423 return (-30 * chosen_spell->level); 1364 return -30 * chosen_spell->level;
1424 } 1365 }
1425 } 1366 }
1426 else if (random_roll (0, pl->stats.Int - 1, pl, PREFER_HIGH) < 15) 1367 else if (random_roll (0, pl->stats.Int - 1, pl, PREFER_HIGH) < 15)
1427 { 1368 {
1428 new_draw_info (NDI_UNIQUE, 0, pl, "Your attempt to write a new scroll rattles your mind!"); 1369 new_draw_info (NDI_UNIQUE, 0, pl, "Your attempt to write a new scroll rattles your mind! H<Frankly spoken, you were too dumb and unlucky.>");
1429 confuse_player (pl, pl, 99); 1370 confuse_player (pl, pl, 99);
1430 } 1371 }
1431 else 1372 else
1432 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to write a new scroll."); 1373 new_draw_info (NDI_UNIQUE, 0, pl, "You fail to write a new scroll. H<Try a lower-level spell, if possible at all.>");
1433 } 1374 }
1434 1375
1435 return 0; 1376 return 0;
1436} 1377}
1437 1378
1438/* write_on_item() - wrapper for write_note and write_scroll */ 1379/* write_on_item() - wrapper for write_note and write_scroll */
1439int 1380int
1440write_on_item (object *pl, const char *params, object *skill) 1381write_on_item (object *pl, const char *params, object *skill)
1441{ 1382{
1442 object *item;
1443 const char *string = params;
1444 int msgtype;
1445 archetype *skat; 1383 archetype *skat;
1446 1384
1447 if (pl->type != PLAYER) 1385 if (pl->type != PLAYER)
1448 return 0; 1386 return 0;
1449 1387
1450 if (!params) 1388 if (!params)
1451 {
1452 params = ""; 1389 params = "";
1453 string = params;
1454 }
1455 1390
1456 skat = get_archetype_by_type_subtype (SKILL, SK_LITERACY); 1391 skat = get_archetype_by_type_subtype (SKILL, SK_LITERACY);
1457 1392
1458 /* Need to be able to read before we can write! */ 1393 /* Need to be able to read before we can write! */
1459 if (!find_skill_by_name (pl, skat->clone.skill)) 1394 if (!find_skill_by_name (pl, skat->skill))
1460 { 1395 {
1461 new_draw_info (NDI_UNIQUE, 0, pl, "You must learn to read before you can write!"); 1396 new_draw_info (NDI_UNIQUE, 0, pl, "You must learn to read before you can write! H<You lack the literacy skill.>");
1462 return 0; 1397 return 0;
1463 } 1398 }
1464 1399
1465 /* if there is a message then it goes in a book and no message means 1400 object *item = find_marked_object (pl);
1466 * write active spell into the scroll
1467 */
1468 msgtype = (string[0] != '\0') ? BOOK : SCROLL;
1469 1401
1470 /* find an item of correct type to write on */ 1402 /* find an item of correct type to write on */
1471 if (!(item = find_marked_object (pl))) 1403 if (!item)
1404 {
1405 new_draw_info (NDI_UNIQUE, 0, pl, "You don't have any marked item to write on. H<Use the mark command or the popup menu to make an item.>");
1406 return 0;
1472 { 1407 }
1473 new_draw_info (NDI_UNIQUE, 0, pl, "You don't have any marked item to write on."); 1408
1409 if (item->type != INSCRIBABLE)
1410 {
1411 new_draw_info_format (NDI_UNIQUE, 0, pl, "You cannot inscribe this! H<You can only inscribe empty scrolls and books.>");
1474 return 0; 1412 return 0;
1475 } 1413 }
1476 1414
1477 if (QUERY_FLAG (item, FLAG_UNPAID)) 1415 if (QUERY_FLAG (item, FLAG_UNPAID))
1478 { 1416 {
1479 new_draw_info (NDI_UNIQUE, 0, pl, "You had better pay for that before you write on it."); 1417 new_draw_info (NDI_UNIQUE, 0, pl, "You had better pay for that before you write on it.");
1480 return 0; 1418 return 0;
1481 } 1419 }
1482 if (msgtype != item->type) 1420
1421 if (item->other_arch->type == SCROLL)
1483 { 1422 {
1484 new_draw_info_format (NDI_UNIQUE, 0, pl, "You have no %s to write on", msgtype == BOOK ? "book" : "scroll"); 1423 if (*params)
1424 {
1425 // check readied scroll
1426 new_draw_info_format (NDI_UNIQUE, 0, pl,
1427 "When inscribing spells you need to ready a spell and do not specify a string argument.\n"
1428 "Usage: cast [spell name]; use_skill %s", &skill->skill);
1485 return 0; 1429 return 0;
1486 } 1430 }
1487 1431
1488 if (msgtype == SCROLL)
1489 return write_scroll (pl, item, skill); 1432 return write_scroll (pl, item, skill);
1490 else if (msgtype == BOOK) 1433 }
1434 else
1435 {
1436 if (!*params)
1437 {
1438 new_draw_info_format (NDI_UNIQUE, 0, pl,
1439 "When inscribing books you need to specify the words you want to inscribe as command argument.\n"
1440 "Usage: use_skill %s <message>", &skill->skill);
1441 return 0;
1442 }
1443
1491 return write_note (pl, item, string, skill); 1444 return write_note (pl, item, params, skill);
1445 }
1492 1446
1493 return 0; 1447 return 0;
1494} 1448}
1495 1449
1496/* find_throw_ob() - if we request an object, then 1450/* find_throw_ob() - if we request an object, then
… …
1529 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1483 for (tmp = op->inv; tmp != NULL; tmp = tmp->below)
1530 { 1484 {
1531 /* can't toss invisible or inv-locked items */ 1485 /* can't toss invisible or inv-locked items */
1532 if (tmp->invisible || QUERY_FLAG (tmp, FLAG_INV_LOCKED)) 1486 if (tmp->invisible || QUERY_FLAG (tmp, FLAG_INV_LOCKED))
1533 continue; 1487 continue;
1534 if (!request || !strcmp (query_name (tmp), request) || !strcmp (tmp->name, request)) 1488 if (!request || !strcmp (query_name (tmp), request) || !strcmp (&tmp->name, request))
1535 break; 1489 break;
1536 } 1490 }
1537 } 1491 }
1538 1492
1539 /* this should prevent us from throwing away 1493 /* this should prevent us from throwing away
… …
1578 return tmp; 1532 return tmp;
1579} 1533}
1580 1534
1581/* make_throw_ob() We construct the 'carrier' object in 1535/* make_throw_ob() We construct the 'carrier' object in
1582 * which we will insert the object that is being thrown. 1536 * which we will insert the object that is being thrown.
1583 * This combination becomes the 'thrown object'. -b.t. 1537 * This combination becomes the 'thrown object'. -b.t.
1584 */ 1538 */
1585
1586static object * 1539static object *
1587make_throw_ob (object *orig) 1540make_throw_ob (object *orig)
1588{ 1541{
1589 if (!orig) 1542 if (!orig)
1590 return NULL; 1543 return 0;
1591 1544
1592 if (QUERY_FLAG (orig, FLAG_APPLIED)) 1545 if (QUERY_FLAG (orig, FLAG_APPLIED))
1593 { 1546 {
1594 LOG (llevError, "BUG: make_throw_ob(): ob is applied\n"); 1547 LOG (llevError, "BUG: make_throw_ob(): ob is applied\n");
1595 /* insufficient workaround, but better than nothing */ 1548 /* insufficient workaround, but better than nothing */
… …
1599 object *toss_item = orig->clone (); 1552 object *toss_item = orig->clone ();
1600 1553
1601 toss_item->type = THROWN_OBJ; 1554 toss_item->type = THROWN_OBJ;
1602 CLEAR_FLAG (toss_item, FLAG_CHANGING); 1555 CLEAR_FLAG (toss_item, FLAG_CHANGING);
1603 toss_item->stats.dam = 0; /* default damage */ 1556 toss_item->stats.dam = 0; /* default damage */
1604 insert_ob_in_ob (orig, toss_item); 1557 toss_item->insert (orig);
1558
1605 return toss_item; 1559 return toss_item;
1606} 1560}
1607
1608 1561
1609/* do_throw() - op throws any object toss_item. This code 1562/* do_throw() - op throws any object toss_item. This code
1610 * was borrowed from fire_bow. 1563 * was borrowed from fire_bow.
1611 * Returns 1 if skill was successfully used, 0 if not 1564 * Returns 1 if skill was successfully used, 0 if not
1612 */ 1565 */
1613
1614static int 1566static int
1615do_throw (object *op, object *part, object *toss_item, int dir, object *skill) 1567do_throw (object *op, object *part, object *toss_item, int dir, object *skill)
1616{ 1568{
1617 object *throw_ob = toss_item, *left = NULL; 1569 object *throw_ob = toss_item, *left = NULL;
1618 int eff_str = 0, maxc, str = op->stats.Str, dam = 0; 1570 int eff_str = 0, maxc, str = op->stats.Str, dam = 0;
… …
1704 left = throw_ob; /* these are throwing objects left to the player */ 1656 left = throw_ob; /* these are throwing objects left to the player */
1705 1657
1706 /* sometimes get_split_ob can't split an object (because op->nrof==0?) 1658 /* sometimes get_split_ob can't split an object (because op->nrof==0?)
1707 * and returns NULL. We must use 'left' then 1659 * and returns NULL. We must use 'left' then
1708 */ 1660 */
1709 1661 if (!(throw_ob = throw_ob->split ()))
1710 if ((throw_ob = get_split_ob (throw_ob, 1)) == NULL)
1711 { 1662 {
1712 throw_ob = left; 1663 throw_ob = left;
1713 left->remove (); 1664 left->remove ();
1714 if (op->type == PLAYER)
1715 esrv_del_item (op->contr, left->count);
1716 }
1717 else if (op->type == PLAYER)
1718 {
1719 if (left->destroyed ())
1720 esrv_del_item (op->contr, left->count);
1721 else
1722 esrv_update_item (UPD_NROF, op, left);
1723 } 1665 }
1724 1666
1725 /* special case: throwing powdery substances like dust, dirt */ 1667 /* special case: throwing powdery substances like dust, dirt */
1726 if (throw_ob->type == POTION && throw_ob->subtype == POT_DUST) 1668 if (throw_ob->type == POTION && throw_ob->subtype == POT_DUST)
1727 { 1669 {
… …
1751 */ 1693 */
1752 throw_ob->inv->set_owner (op); 1694 throw_ob->inv->set_owner (op);
1753 throw_ob->direction = dir; 1695 throw_ob->direction = dir;
1754 1696
1755 /* the damage bonus from the force of the throw */ 1697 /* the damage bonus from the force of the throw */
1756 dam = (int) (str_factor * dam_bonus[eff_str]); 1698 dam = int (str_factor * dam_bonus[eff_str]);
1757 1699
1758 /* Now, lets adjust the properties of the thrown_ob. */ 1700 /* Now, lets adjust the properties of the thrown_ob. */
1759 1701
1760 /* how far to fly */ 1702 /* how far to fly */
1761 throw_ob->last_sp = (eff_str * 3) / 5; 1703 throw_ob->last_sp = (eff_str * 3) / 5;
… …
1782 { 1724 {
1783 throw_ob->last_sp += eff_str / 3; /* fly a little further */ 1725 throw_ob->last_sp += eff_str / 3; /* fly a little further */
1784 throw_ob->stats.dam += throw_ob->inv->stats.dam + throw_ob->magic + 2; 1726 throw_ob->stats.dam += throw_ob->inv->stats.dam + throw_ob->magic + 2;
1785 throw_ob->stats.wc -= throw_ob->magic + throw_ob->inv->stats.wc; 1727 throw_ob->stats.wc -= throw_ob->magic + throw_ob->inv->stats.wc;
1786 /* only throw objects get directional faces */ 1728 /* only throw objects get directional faces */
1787 if (GET_ANIM_ID (throw_ob) && NUM_ANIMATIONS (throw_ob)) 1729 if (throw_ob->has_anim () && throw_ob->anim_frames ())
1788 SET_ANIMATION (throw_ob, dir); 1730 throw_ob->set_anim_frame (dir);
1789 } 1731 }
1790 else 1732 else
1791 { 1733 {
1734 uint16 mat = throw_ob->materials;
1735
1792 /* some materials will adjust properties.. */ 1736 /* some materials will adjust properties.. */
1793 if (throw_ob->material & M_LEATHER) 1737 if (mat & M_LEATHER)
1794 { 1738 {
1795 throw_ob->stats.dam -= 1; 1739 throw_ob->stats.dam -= 1;
1796 throw_ob->stats.food -= 10; 1740 throw_ob->stats.food -= 10;
1797 } 1741 }
1798 1742
1799 if (throw_ob->material & M_GLASS) 1743 if (mat & M_GLASS)
1800 throw_ob->stats.food += 60; 1744 throw_ob->stats.food += 60;
1801 1745
1802 if (throw_ob->material & M_ORGANIC) 1746 if (mat & M_ORGANIC)
1803 { 1747 {
1804 throw_ob->stats.dam -= 3; 1748 throw_ob->stats.dam -= 3;
1805 throw_ob->stats.food += 55; 1749 throw_ob->stats.food += 55;
1806 } 1750 }
1807 1751
1808 if (throw_ob->material & M_PAPER || throw_ob->material & M_CLOTH) 1752 if (mat & M_PAPER || mat & M_CLOTH)
1809 { 1753 {
1810 throw_ob->stats.dam -= 5; 1754 throw_ob->stats.dam -= 5;
1811 throw_ob->speed *= 0.8; 1755 throw_ob->speed *= 0.8;
1812 throw_ob->stats.wc += 3; 1756 throw_ob->stats.wc += 3;
1813 throw_ob->stats.food -= 30; 1757 throw_ob->stats.food -= 30;

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines