ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/spell_util.C
(Generate patch)

Comparing deliantra/server/server/spell_util.C (file contents):
Revision 1.63 by root, Thu Nov 8 19:43:29 2007 UTC vs.
Revision 1.122 by root, Sat Dec 31 06:18:02 2011 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
33/* This returns a random spell from 'ob'. If skill is set, then 34/* This returns a random spell from 'ob'. If skill is set, then
34 * the spell must be of this skill, it can be NULL in which case all 35 * the spell must be of this skill, it can be NULL in which case all
35 * matching spells are used. 36 * matching spells are used.
36 */ 37 */
37object * 38object *
38find_random_spell_in_ob (object *ob, const char *skill) 39find_random_spell_in_ob (object *ob, shstr_cmp skill)
39{ 40{
40 int k = 0, s; 41 int k = 0, s;
41 object *tmp;
42 42
43 for (tmp = ob->inv; tmp; tmp = tmp->below) 43 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
44 if (tmp->type == SPELL && (!skill || tmp->skill == skill)) 44 if (tmp->type == SPELL && (!skill || tmp->skill == skill))
45 k++; 45 k++;
46 46
47 /* No spells, no need to progess further */ 47 /* No spells, no need to progess further */
48 if (!k) 48 if (!k)
49 return NULL; 49 return NULL;
50 50
51 s = RANDOM () % k; 51 s = rndm (k);
52 52
53 for (tmp = ob->inv; tmp; tmp = tmp->below) 53 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
54 if (tmp->type == SPELL && (!skill || tmp->skill == skill)) 54 if (tmp->type == SPELL && (!skill || tmp->skill == skill))
55 {
56 if (!s) 55 if (!s)
57 return tmp; 56 return tmp;
58 else 57 else
59 s--; 58 s--;
60 } 59
61 /* Should never get here, but just in case */ 60 /* Should never get here, but just in case */
62 return NULL; 61 return 0;
63} 62}
64 63
65/* Relatively simple function that gets used a lot. 64/* Relatively simple function that gets used a lot.
66 * Basically, it sets up the skill pointer for the spell being 65 * Basically, it sets up the skill pointer for the spell being
67 * cast. If op is really casting the spell, then the skill 66 * cast. If op is really casting the spell, then the skill
77 dest->skill = spob->skill; 76 dest->skill = spob->skill;
78 else 77 else
79 dest->skill = caster->skill; 78 dest->skill = caster->skill;
80} 79}
81 80
82/* init_spells: This should really be called check_spells, as that
83 * is what it does. It goes through the spells looking for any
84 * obvious errors. This was most useful in debugging when re-doing
85 * all the spells to catch simple errors. To use it all the time
86 * will result in it spitting out messages that aren't really errors.
87 */
88void
89init_spells (void)
90{
91#ifdef SPELL_DEBUG
92 static int init_spells_done = 0;
93 int i;
94 archetype *at;
95
96 if (init_spells_done)
97 return;
98 LOG (llevDebug, "Checking spells...\n");
99
100 for_all_archetypes (at)
101 {
102 if (at->type == SPELL)
103 {
104 if (at->skill)
105 {
106 for (i = 1; i < NUM_SKILLS; i++)
107 if (!strcmp (skill_names[i], at->skill))
108 break;
109 if (i == NUM_SKILLS)
110 {
111 LOG (llevError, "Spell %s has improper associated skill %s\n", at->name, at->skill);
112 }
113 }
114 /* other_arch is already checked for in the loader */
115 }
116 }
117
118 i = 0;
119 while (spell_mapping[i])
120 {
121 if (!archetype::find (spell_mapping[i]))
122 {
123 LOG (llevError, "Unable to find spell mapping %s (%i)\n", spell_mapping[i], i);
124 }
125 i++;
126 }
127 LOG (llevDebug, "Checking spells completed.\n");
128#endif
129}
130
131/* Dumps all the spells - now also dumps skill associated with the spell.
132 * not sure what this would be used for, as the data seems pretty
133 * minimal, but easy enough to keep around.
134 */
135void
136dump_spells ()
137{
138 for_all_archetypes (at)
139 if (at->type == SPELL)
140 fprintf (stderr, "%s:%s:%s:%s:%d\n", &at->object::name,
141 &at->archname, at->other_arch ? &at->other_arch->archname : "<nil>", &at->skill, at->level);
142}
143
144/* pretty basic function - basically just takes 81/* pretty basic function - basically just takes
145 * an object, sets the x,y, and calls insert_ob_in_map 82 * an object, sets the x,y, and calls insert_ob_in_map
146 */ 83 */
147void 84void
148spell_effect (object *spob, int x, int y, maptile *map, object *originator) 85spell_effect (object *spob, int x, int y, maptile *map, object *originator)
149{ 86{
150 if (spob->other_arch) 87 if (spob->other_arch)
151 map->insert (arch_to_object (spob->other_arch), x, y, originator); 88 map->insert (spob->other_arch->instance (), x, y, originator);
152} 89}
153 90
154/* 91static int
155 * This function takes a caster and spell and presents the 92attuned_bonus (object *caster, object *spell, int level)
156 * effective level the caster needs to be to cast the spell.
157 * basically, it just adjusts the spell->level with attuned/repelled
158 * spellpaths. Was called path_level_mod.
159 *
160 * caster is person casting the spell.
161 * spell is the spell object.
162 * Returns modified level.
163 */
164int
165min_casting_level (object *caster, object *spell)
166{ 93{
167 int new_level; 94 // compute the attuned/repelled bonus
168 95 // attuned only increases up to 2 times the original level (i.e. bonus <= level) */
169 if (caster->path_denied & spell->path_attuned) 96 // repell has no such quarrels
170 return 1; 97 return (caster->path_attuned & spell->path_attuned ? min (level, +ATTUNE_REPELL) : 0)
171
172 new_level = spell->level
173 + (caster->path_repelled & spell->path_attuned ? +2 : 0) 98 + (caster->path_repelled & spell->path_attuned ? -ATTUNE_REPELL : 0);
174 + (caster->path_attuned & spell->path_attuned ? -2 : 0);
175
176 return max (1, new_level);
177} 99}
178 100
179/* This function returns the effective level the spell 101/* This function returns the effective level the spell
180 * is being cast at. 102 * is being cast at.
181 * Note that I changed the repelled/attuned bonus to 2 from 5.
182 * This is because the new code compares casting_level against
183 * min_caster_level, so the difference is effectively 4
184 */ 103 */
185int 104int
186caster_level (object *caster, object *spell) 105casting_level (object *caster, object *spell)
187{ 106{
188 int level = caster->level; 107 int level = caster->level;
189
190 /* If this is a player, try to find the matching skill */
191 if (caster->type == PLAYER && spell->skill)
192 for (int i = 0; i < NUM_SKILLS; i++)
193 if (caster->contr->last_skill_ob[i] && caster->contr->last_skill_ob[i]->skill == spell->skill)
194 {
195 level = caster->contr->last_skill_ob[i]->level;
196 break;
197 }
198 108
199 /* if a rod is fired by a player, take the use_magic_item skill in consideration. */ 109 /* if a rod is fired by a player, take the use_magic_item skill in consideration. */
200 if (caster->type == ROD && caster->env && caster->env->type == PLAYER) 110 if (caster->type == ROD && caster->env && caster->env->type == PLAYER)
201 { 111 {
202 object *skill = find_skill_by_number (caster->env, SK_USE_MAGIC_ITEM); 112 object *skill = find_skill_by_number (caster->env, SK_USE_MAGIC_ITEM);
203 int sk_level = skill ? skill->level : 1; 113 int sk_level = skill ? skill->level : 1;
204 114
205 level = MIN (level, sk_level + level / 10 + 1); 115 level = min (level, sk_level + level / 10 + 1);
206 } 116 }
117 else if (caster->type == PLAYER) /* If this is a player, try to find the matching skill */
118 if (object *skill = caster->contr->find_skill (spell->skill))
119 level = skill->level;
207 120
208 /* Got valid caster level. Now adjust for attunement */ 121 int bonus = attuned_bonus (caster, spell, level);
209 level += caster->path_repelled & spell->path_attuned ? -2 : 0; 122
210 level += caster->path_attuned & spell->path_attuned ? +2 : 0; 123 level += bonus;
124
125 // now scale the effective level from the startinglevel..100 range to 1..100
126 if (level < 100)
127 level = lerp (level, (int)spell->level, 100, 1, 100);
211 128
212 /* Always make this at least 1. If this is zero, we get divide by zero 129 /* Always make this at least 1. If this is zero, we get divide by zero
213 * errors in various places. 130 * errors in various places.
214 */ 131 */
215 return max (level, 1); 132 return clamp (level, 1, settings.max_level);
216} 133}
217 134
218/* The following function scales the spellpoint cost of 135/* The following function scales the spellpoint cost of
219 * a spell by it's increased effectiveness. Some of the 136 * a spell by it's increased effectiveness. Some of the
220 * lower level spells become incredibly vicious at high 137 * lower level spells become incredibly vicious at high
224 * caster is what is casting the spell, can be op. 141 * caster is what is casting the spell, can be op.
225 * spell is the spell object. 142 * spell is the spell object.
226 * Note that it is now possible for a spell to cost both grace and 143 * Note that it is now possible for a spell to cost both grace and
227 * mana. In that case, we return which ever value is higher. 144 * mana. In that case, we return which ever value is higher.
228 */ 145 */
229
230sint16 146sint16
231SP_level_spellpoint_cost (object *caster, object *spell, int flags) 147SP_level_spellpoint_cost (object *caster, object *spell, int flags)
232{ 148{
233 int sp, grace, level = caster_level (caster, spell); 149 int sp, grace, level = casting_level (caster, spell);
234 150
235 if (settings.spellpoint_level_depend == TRUE) 151 if (settings.spellpoint_level_depend == TRUE)
236 { 152 {
237 if (spell->stats.sp && spell->stats.maxsp) 153 if (spell->stats.sp && spell->stats.maxsp)
238 {
239 sp = (int) (spell->stats.sp * (1.0 + MAX (0, (float) (level - spell->level) / (float) spell->stats.maxsp))); 154 sp = spell->stats.sp * (1.f + max (0.f, float (level - spell->level) / spell->stats.maxsp));
240 }
241 else 155 else
242 sp = spell->stats.sp; 156 sp = spell->stats.sp;
243 157
244 sp *= (int) PATH_SP_MULT (caster, spell); 158 sp *= (int) PATH_SP_MULT (caster, spell);
245 if (!sp && spell->stats.sp) 159 if (!sp && spell->stats.sp)
246 sp = 1; 160 sp = 1;
247 161
248 if (spell->stats.grace && spell->stats.maxgrace) 162 if (spell->stats.grace && spell->stats.maxgrace)
249 {
250 grace = (int) (spell->stats.grace * (1.0 + MAX (0, (float) (level - spell->level) / (float) spell->stats.maxgrace))); 163 grace = spell->stats.grace * (1.f + max (0.f, float (level - spell->level) / spell->stats.maxgrace));
251 }
252 else 164 else
253 grace = spell->stats.grace; 165 grace = spell->stats.grace;
254 166
255 grace *= (int) PATH_SP_MULT (caster, spell); 167 grace *= PATH_SP_MULT (caster, spell);
256 if (spell->stats.grace && !grace) 168 if (spell->stats.grace && !grace)
257 grace = 1; 169 grace = 1;
258 } 170 }
259 else 171 else
260 { 172 {
261 sp = (int) (spell->stats.sp * PATH_SP_MULT (caster, spell)); 173 sp = (int) (spell->stats.sp * PATH_SP_MULT (caster, spell));
262 if (spell->stats.sp && !sp) 174 if (spell->stats.sp && !sp)
263 sp = 1; 175 sp = 1;
176
264 grace = (int) (spell->stats.grace * PATH_SP_MULT (caster, spell)); 177 grace = (int) (spell->stats.grace * PATH_SP_MULT (caster, spell));
265 if (spell->stats.grace && !grace) 178 if (spell->stats.grace && !grace)
266 grace = 1; 179 grace = 1;
267 } 180 }
268 181
269 if (flags == SPELL_HIGHEST) 182 if (flags == SPELL_HIGHEST)
270 return MAX (sp, grace); 183 return max (sp, grace);
271 else if (flags == SPELL_GRACE) 184 else if (flags == SPELL_GRACE)
272 return grace; 185 return grace;
273 else if (flags == SPELL_MANA) 186 else if (flags == SPELL_MANA)
274 return sp; 187 return sp;
275 else 188 else
277 LOG (llevError, "SP_level_spellpoint_cost: Unknown flags passed: %d\n", flags); 190 LOG (llevError, "SP_level_spellpoint_cost: Unknown flags passed: %d\n", flags);
278 return 0; 191 return 0;
279 } 192 }
280} 193}
281 194
195/*
196 * Return the effective casting level of the spell.
197 * To make spells independent of their starting level, this function
198 * scales the range spellstartlevel .. 100 into the range 1..100
199 */
200static int
201SP_casting_level (object *caster, object *spell)
202{
203 return casting_level (caster, spell);
204}
205
282/* SP_level_dam_adjust: Returns adjusted damage based on the caster. 206/* SP_level_dam_adjust: Returns adjusted damage based on the caster.
283 * spob is the spell we are adjusting. 207 * spob is the spell we are adjusting.
284 */ 208 */
285int 209int
286SP_level_dam_adjust (object *caster, object *spob) 210SP_level_dam_adjust (object *caster, object *spob)
287{ 211{
288 if (!spob->dam_modifier) 212 if (!spob->dam_modifier)
289 return 0; 213 return 0;
290 214
291 int level = caster_level (caster, spob);
292 return max (0, level - min_casting_level (caster, spob)) / spob->dam_modifier; 215 return SP_casting_level (caster, spob) / spob->dam_modifier;
293} 216}
294 217
295/* Adjust the strength of the spell based on level. 218/* Adjust the strength of the spell based on level.
296 * This is basically the same as SP_level_dam_adjust above, 219 * This is basically the same as SP_level_dam_adjust above,
297 * but instead looks at the level_modifier value. 220 * but instead looks at the level_modifier value.
300SP_level_duration_adjust (object *caster, object *spob) 223SP_level_duration_adjust (object *caster, object *spob)
301{ 224{
302 if (!spob->duration_modifier) 225 if (!spob->duration_modifier)
303 return 0; 226 return 0;
304 227
305 int level = caster_level (caster, spob);
306 return max (0, level - min_casting_level (caster, spob)) / spob->duration_modifier; 228 return SP_casting_level (caster, spob) / spob->duration_modifier;
307} 229}
308 230
309/* Adjust the strength of the spell based on level. 231/* Adjust the strength of the spell based on level.
310 * This is basically the same as SP_level_dam_adjust above, 232 * This is basically the same as SP_level_dam_adjust above,
311 * but instead looks at the level_modifier value. 233 * but instead looks at the level_modifier value.
314SP_level_range_adjust (object *caster, object *spob) 236SP_level_range_adjust (object *caster, object *spob)
315{ 237{
316 if (!spob->range_modifier) 238 if (!spob->range_modifier)
317 return 0; 239 return 0;
318 240
319 int level = caster_level (caster, spob);
320 return (level - min_casting_level (caster, spob)) / spob->range_modifier; 241 return SP_casting_level (caster, spob) / spob->range_modifier;
321} 242}
322 243
323/* Checks to see if player knows the spell. If the name is the same 244/* Checks to see if player knows the spell. If the name is the same
324 * as an existing spell, we presume they know it. 245 * as an existing spell, we presume they know it.
325 * returns 1 if they know the spell, 0 if they don't. 246 * returns 1 if they know the spell, 0 if they don't.
326 */ 247 */
327object * 248object *
328check_spell_known (object *op, const char *name) 249check_spell_known (object *op, shstr_cmp name)
329{ 250{
330 object *spop; 251 object *spop;
331 252
332 for (spop = op->inv; spop; spop = spop->below) 253 for (spop = op->inv; spop; spop = spop->below)
333 if (spop->type == SPELL && !strcmp (spop->name, name)) 254 if (spop->type == SPELL && spop->name == name)
334 return spop; 255 return spop;
335 256
336 return NULL; 257 return 0;
337} 258}
338
339 259
340/* 260/*
341 * Look at object 'op' and see if they know the spell 261 * Look at object 'op' and see if they know the spell
342 * spname. This is pretty close to check_spell_known 262 * spname. This is pretty close to check_spell_known
343 * above, but it uses a looser matching mechanism. 263 * above, but it uses a looser matching mechanism.
344 * returns the matching spell object, or NULL. 264 * returns the matching spell object, or NULL.
345 * If we match multiple spells but don't get an 265 * If we match multiple spells but don't get an
346 * exact match, we also return NULL. 266 * exact match, we also return NULL.
347 */ 267 */
348
349object * 268object *
350lookup_spell_by_name (object *op, const char *spname) 269lookup_spell_by_name (object *op, const char *spname)
351{ 270{
352 object *spob1 = NULL, *spob2 = NULL, *spob; 271 object *spob1 = 0, *spob2 = 0;
353 int nummatch = 0; 272 int nummatch = 0;
354 273
355 if (spname == NULL) 274 if (!spname)
356 return NULL; 275 return 0;
357 276
358 /* Try to find the spell. We store the results in spob1 277 /* Try to find the spell. We store the results in spob1
359 * and spob2 - spob1 is only taking the length of 278 * and spob2 - spob1 is only taking the length of
360 * the past spname, spob2 uses the length of the spell name. 279 * the past spname, spob2 uses the length of the spell name.
361 */ 280 */
362 for (spob = op->inv; spob; spob = spob->below) 281 for (object *spob = op->inv; spob; spob = spob->below)
363 { 282 {
364 if (spob->type == SPELL) 283 if (spob->type == SPELL)
365 { 284 {
285 // TODO: WTF?
366 if (!strncmp (spob->name, spname, strlen (spname))) 286 if (!strncmp (spob->name, spname, strlen (spname)))
367 { 287 {
368 nummatch++; 288 nummatch++;
369 spob1 = spob; 289 spob1 = spob;
370 } 290 }
375 * fall into this category). It shouldn't be hard to 295 * fall into this category). It shouldn't be hard to
376 * make sure spell names don't overlap in that fashion. 296 * make sure spell names don't overlap in that fashion.
377 */ 297 */
378 if (spob2) 298 if (spob2)
379 LOG (llevError, "Found multiple spells with overlapping base names: %s, %s\n", &spob2->name, &spob->name); 299 LOG (llevError, "Found multiple spells with overlapping base names: %s, %s\n", &spob2->name, &spob->name);
300
380 spob2 = spob; 301 spob2 = spob;
381 } 302 }
382 } 303 }
383 } 304 }
384 /* if we have best match, return it. Otherwise, if we have one match 305 /* if we have best match, return it. Otherwise, if we have one match
385 * on the loser match, return that, otehrwise null 306 * on the loser match, return that, otehrwise null
386 */ 307 */
387 if (spob2) 308 if (spob2)
388 return spob2; 309 return spob2;
310
389 if (spob1 && nummatch == 1) 311 if (spob1 && nummatch == 1)
390 return spob1; 312 return spob1;
313
391 return NULL; 314 return NULL;
392} 315}
393 316
394/* reflwall - decides weither the (spell-)object sp_op will 317/* reflwall - decides weither the (spell-)object sp_op will
395 * be reflected from the given mapsquare. Returns 1 if true. 318 * be reflected from the given mapsquare. Returns 1 if true.
399 * eg, updated for tiled maps. 322 * eg, updated for tiled maps.
400 */ 323 */
401int 324int
402reflwall (maptile *m, int x, int y, object *sp_op) 325reflwall (maptile *m, int x, int y, object *sp_op)
403{ 326{
404 object *op;
405
406 if (OUT_OF_REAL_MAP (m, x, y)) 327 if (OUT_OF_REAL_MAP (m, x, y))
407 return 0; 328 return 0;
329
408 for (op = GET_MAP_OB (m, x, y); op != NULL; op = op->above) 330 for (object *op = GET_MAP_OB (m, x, y); op; op = op->above)
409 if (QUERY_FLAG (op, FLAG_REFL_SPELL) 331 if (op->flag [FLAG_REFL_SPELL]
410 && (!QUERY_FLAG (op, FLAG_ALIVE) 332 && (!op->flag [FLAG_ALIVE]
411 || (rndm (0, 99)) < 90 - (sp_op->level / 10))) 333 || (rndm (0, 99)) < 90 - (sp_op->level / 10)))
412 return 1; 334 return 1;
413 335
414 return 0; 336 return 0;
415} 337}
434 new_draw_info (NDI_UNIQUE, 0, op, "Something is in the way."); 356 new_draw_info (NDI_UNIQUE, 0, op, "Something is in the way.");
435 new_draw_info (NDI_UNIQUE, 0, op, "You cast it at your feet."); 357 new_draw_info (NDI_UNIQUE, 0, op, "You cast it at your feet.");
436 dir = 0; 358 dir = 0;
437 } 359 }
438 360
439 SET_FLAG (new_op, FLAG_IDENTIFIED); 361 new_op->set_flag (FLAG_IDENTIFIED);
440 op->map->insert (new_op, 362 op->map->insert (new_op,
441 op->x + freearr_x[dir], op->y + freearr_y[dir], 363 op->x + freearr_x[dir], op->y + freearr_y[dir],
442 op, 364 op,
443 dir ? 0 : INS_BELOW_ORIGINATOR); 365 dir ? 0 : INS_BELOW_ORIGINATOR);
444 366
445 return dir; 367 return dir;
368}
369
370static bool
371mergable_owner (object *o1, object *o2)
372{
373 if (o1 == o2)
374 return 1;
375
376 if (!o1 || !o2)
377 return 0;
378
379 if (o1->flag [FLAG_FRIENDLY] != o1->flag [FLAG_FRIENDLY])
380 return 0;
381
382 if (o1->is_player () || o2->is_player ())
383 return 0;
384
385 return 1;
446} 386}
447 387
448/* Returns true if it is ok to put spell *op on the space/may provided. 388/* Returns true if it is ok to put spell *op on the space/may provided.
449 * immune_stop is basically the attacktype of the spell (why 389 * immune_stop is basically the attacktype of the spell (why
450 * passed as a different value, not sure of). If immune_stop 390 * passed as a different value, not sure of). If immune_stop
451 * has the AT_MAGIC bit set, and there is a counterwall 391 * has the AT_MAGIC bit set, and there is a counterwall
452 * on the space, the object doesn't get placed. if immune stop 392 * on the space, the object doesn't get placed. if immune stop
453 * does not have AT_MAGIC, then counterwalls do not effect the spell. 393 * does not have AT_MAGIC, then counterwalls do not effect the spell.
454 *
455 */ 394 */
456int 395int
457ok_to_put_more (maptile *m, sint16 x, sint16 y, object *op, int immune_stop) 396ok_to_put_more (maptile *m, sint16 x, sint16 y, object *op, int immune_stop)
458{ 397{
459 if (!xy_normalise (m, x, y)) 398 if (!xy_normalise (m, x, y))
460 return 0; 399 return 0;
461 400
462 mapspace &ms = m->at (x, y); 401 mapspace &ms = m->at (x, y);
402 ms.update ();
463 403
464 if (OB_TYPE_MOVE_BLOCK (op, ms.move_block)) 404 if (OB_TYPE_MOVE_BLOCK (op, ms.move_block))
465 return 0; 405 return 0;
466 406
407 int max_effects = 5; // max. number of similar spells per mapspace
408
467 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 409 for (object *tmp = ms.top; tmp; tmp = tmp->below)
468 { 410 {
469 /* If there is a counterspell on the space, and this 411 /* If there is a counterspell on the space, and this
470 * object is using magic, don't progress. I believe we could 412 * object is using magic, don't progress. I believe we could
471 * leave this out and let in progress, and other areas of the code 413 * leave this out and let in progress, and other areas of the code
472 * will then remove it, but that would seem to to use more 414 * will then remove it, but that would seem to to use more
474 * on top of a counterwall spell (may hit the player before being 416 * on top of a counterwall spell (may hit the player before being
475 * removed.) On the other hand, it may be more dramatic for the 417 * removed.) On the other hand, it may be more dramatic for the
476 * spell to actually hit the counterwall and be sucked up. 418 * spell to actually hit the counterwall and be sucked up.
477 */ 419 */
478 if ((tmp->attacktype & AT_COUNTERSPELL) 420 if ((tmp->attacktype & AT_COUNTERSPELL)
479 && !QUERY_FLAG (tmp, FLAG_MONSTER) 421 && !tmp->flag [FLAG_MONSTER]
480 && (tmp->type != PLAYER) 422 && (tmp->type != PLAYER)
481 && (tmp->type != WEAPON) 423 && (tmp->type != WEAPON)
482 && (tmp->type != BOW) 424 && (tmp->type != BOW)
483 && (tmp->type != ARROW) 425 && (tmp->type != ARROW)
484 && (tmp->type != GOLEM) 426 && (tmp->type != GOLEM)
485 && !QUERY_FLAG (tmp, FLAG_IS_FLOOR) // XXX: 427 && !tmp->flag [FLAG_IS_FLOOR] // XXX:
486 // we special case floor here because there 428 // we special case floor here because there
487 // are sometimes spell effect floors 429 // are sometimes spell effect floors
488 // which are used to inflict damage 430 // which are used to inflict damage
489 // (and those shouldn't go away from 431 // (and those shouldn't go away from
490 // sanctuary) see also: permanent lava 432 // sanctuary) see also: permanent lava
491 && (immune_stop & AT_MAGIC)) 433 && (immune_stop & AT_MAGIC))
492 return 0; 434 return 0;
493 435
494 /* This is to prevent 'out of control' spells. Basically, this
495 * limits one spell effect per space per spell. This is definately
496 * needed for performance reasons, and just for playability I believe.
497 * there are no such things as multispaced spells right now, so
498 * we don't need to worry about the head.
499 */
500 if ((tmp->stats.maxhp == op->stats.maxhp) && (tmp->type == op->type) && (tmp->subtype == op->subtype))
501 return 0;
502
503 /*
504 * Combine similar spell effects into one spell effect. Needed for
505 * performance reasons with meteor swarm and the like, but also for
506 * playability reasons.
507 */
508 if (tmp->arch == op->arch
509 && tmp->type == op->type 436 if (tmp->type == op->type)
510 && tmp->subtype == op->subtype
511 && tmp->owner == op->owner
512 && ((tmp->subtype == SP_EXPLOSION) || (tmp->subtype == SP_CONE && tmp->stats.sp == op->stats.sp)))
513 { 437 {
514 tmp->stats.dam = MAX (tmp->stats.dam, op->stats.dam); 438 if (tmp->subtype == op->subtype
515 tmp->range = MAX (tmp->range, op->range); 439 && tmp->arch == op->arch /* no harm if not comparing by name here */)
516 tmp->duration = MAX (tmp->duration, op->duration); 440 {
441 /* This is to prevent 'out of control' spells. Basically, this
442 * limits one spell effect per space per spell. This is definately
443 * needed for performance reasons, and just for playability I believe.
444 * there are no such things as multispaced spells right now, so
445 * we don't need to worry about the head.
446 */
447 if (tmp->stats.maxhp == op->stats.maxhp)
448 return 0;
449
450 /*
451 * Combine similar spell effects into one spell effect. Needed for
452 * performance reasons with meteor swarm and the like, but also for
453 * playability reasons.
454 */
455 if (((tmp->subtype == SP_EXPLOSION) || (tmp->subtype == SP_CONE && tmp->stats.sp == op->stats.sp)))
456 if (mergable_owner (tmp, op))
457 {
458 // if same owner, then combine, but reduce advantage of multiple spells
459 max_it (tmp->stats.dam, op->stats.dam);
460 max_it (tmp->range , op->range);
461 max_it (tmp->duration , op->duration);
462 return 0;
463 }
464 }
465
466 // if there are too many spell effects on this space,
467 // then don't allow more of them, for performance reasons.
468 if (tmp->type == SPELL_EFFECT
469 && !--max_effects)
517 return 0; 470 return 0;
518 } 471 }
519 472
520 /* Perhaps we should also put checks in for no magic and unholy 473 /* Perhaps we should also put checks in for no magic and unholy
521 * ground to prevent it from moving along? 474 * ground to prevent it from moving along?
522 */ 475 */
537 * returns 0 on failure, 1 on success. 490 * returns 0 on failure, 1 on success.
538 */ 491 */
539int 492int
540fire_arch_from_position (object *op, object *caster, sint16 x, sint16 y, int dir, object *spell) 493fire_arch_from_position (object *op, object *caster, sint16 x, sint16 y, int dir, object *spell)
541{ 494{
542 object *tmp;
543 int mflags;
544 maptile *m;
545
546 if (spell->other_arch == NULL) 495 if (!spell->other_arch)
547 return 0; 496 return 0;
548 497
549 m = op->map; 498 object *tmp = spell->other_arch->instance ();
550 mflags = get_map_flags (m, &m, x, y, &x, &y);
551 if (mflags & P_OUT_OF_MAP)
552 {
553 return 0;
554 }
555 499
556 tmp = arch_to_object (spell->other_arch); 500 if (!tmp)
557
558 if (tmp == NULL)
559 return 0; 501 return 0;
560
561 if (OB_TYPE_MOVE_BLOCK (tmp, GET_MAP_MOVE_BLOCK (m, x, y)))
562 {
563 new_draw_info (NDI_UNIQUE, 0, op, "You can't cast the spell on top of a wall!\n");
564 tmp->destroy ();
565 return 0;
566 }
567 502
568 tmp->stats.dam = spell->stats.dam + SP_level_dam_adjust (caster, spell); 503 tmp->stats.dam = spell->stats.dam + SP_level_dam_adjust (caster, spell);
569 tmp->duration = spell->duration + SP_level_duration_adjust (caster, spell); 504 tmp->duration = spell->duration + SP_level_duration_adjust (caster, spell);
570 /* code in time.c uses food for some things, duration for others */ 505 /* code in time.c uses food for some things, duration for others */
571 tmp->stats.food = tmp->duration; 506 tmp->stats.food = tmp->duration;
572 tmp->range = spell->range + SP_level_range_adjust (caster, spell); 507 tmp->range = spell->range + SP_level_range_adjust (caster, spell);
573 tmp->attacktype = spell->attacktype; 508 tmp->attacktype = spell->attacktype;
574 tmp->x = x;
575 tmp->y = y;
576 tmp->direction = dir; 509 tmp->direction = dir;
577 if (op->owner != NULL)
578 tmp->set_owner (op); 510 tmp->set_owner (op);
579 else
580 tmp->set_owner (op);
581 tmp->level = caster_level (caster, spell); 511 tmp->level = casting_level (caster, spell);
582 set_spell_skill (op, caster, spell, tmp); 512 set_spell_skill (op, caster, spell, tmp);
583 513
584 /* needed for AT_HOLYWORD,AT_GODPOWER stuff */ 514 /* needed for AT_HOLYWORD,AT_GODPOWER stuff */
585 if (tmp->attacktype & AT_HOLYWORD || tmp->attacktype & AT_GODPOWER) 515 if (tmp->attacktype & AT_HOLYWORD || tmp->attacktype & AT_GODPOWER)
586 {
587 if (!tailor_god_spell (tmp, op)) 516 if (!tailor_god_spell (tmp, op))
588 return 0; 517 return 0;
589 } 518
590 if (QUERY_FLAG (tmp, FLAG_IS_TURNABLE)) 519 if (tmp->flag [FLAG_IS_TURNABLE])
591 SET_ANIMATION (tmp, dir); 520 SET_ANIMATION (tmp, dir);
592 521
593 if ((tmp = insert_ob_in_map (tmp, m, op, 0))) 522 if ((tmp = op->map->insert (tmp, x, y, op)))
594 move_spell_effect (tmp); 523 move_spell_effect (tmp);
595 524
596 return 1; 525 return 1;
597} 526}
598 527
603 ****************************************************************************/ 532 ****************************************************************************/
604void 533void
605regenerate_rod (object *rod) 534regenerate_rod (object *rod)
606{ 535{
607 if (rod->stats.hp < rod->stats.maxhp) 536 if (rod->stats.hp < rod->stats.maxhp)
608 rod->stats.hp = min (rod->stats.maxhp, rod->stats.hp + 1 + rod->stats.maxhp / 10); 537 rod->stats.hp = min (rod->stats.maxhp, rod->stats.hp + 1 + rod->stats.maxhp / 20);
609} 538}
610 539
611void 540void
612drain_rod_charge (object *rod) 541drain_rod_charge (object *rod)
613{ 542{
633 { 562 {
634 tmp = op->owner; 563 tmp = op->owner;
635 /* If the owner does not exist, or is not a monster, than apply the spell 564 /* If the owner does not exist, or is not a monster, than apply the spell
636 * to the caster. 565 * to the caster.
637 */ 566 */
638 if (!tmp || !QUERY_FLAG (tmp, FLAG_MONSTER)) 567 if (!tmp || !tmp->flag [FLAG_MONSTER])
639 tmp = op; 568 tmp = op;
640 } 569 }
641 else 570 else
642 { 571 {
643 maptile *m = op->map; 572 maptile *m = op->map;
653 if (!tmp) 582 if (!tmp)
654 tmp = op->ms ().player (); 583 tmp = op->ms ().player ();
655 584
656 return tmp; 585 return tmp;
657} 586}
658
659
660 587
661/* raytrace: 588/* raytrace:
662 * spell_find_dir(map, x, y, exclude) will search first the center square 589 * spell_find_dir(map, x, y, exclude) will search first the center square
663 * then some close squares in the given map at the given coordinates for 590 * then some close squares in the given map at the given coordinates for
664 * live objects. 591 * live objects.
667 * monsters/generators only. If not, the spell will hunt players only. 594 * monsters/generators only. If not, the spell will hunt players only.
668 * It returns the direction toward the first/closest live object if it finds 595 * It returns the direction toward the first/closest live object if it finds
669 * any, otherwise -1. 596 * any, otherwise -1.
670 * note that exclude can be NULL, in which case all bets are off. 597 * note that exclude can be NULL, in which case all bets are off.
671 */ 598 */
672
673int 599int
674spell_find_dir (maptile *m, int x, int y, object *exclude) 600spell_find_dir (maptile *m, int x, int y, object *exclude)
675{ 601{
676 int i, max = SIZEOFFREE; 602 int i, max = SIZEOFFREE;
677 sint16 nx, ny; 603 sint16 nx, ny;
694 continue; 620 continue;
695 621
696 tmp = GET_MAP_OB (mp, nx, ny); 622 tmp = GET_MAP_OB (mp, nx, ny);
697 623
698 while (tmp != NULL && (((owner_type == PLAYER && 624 while (tmp != NULL && (((owner_type == PLAYER &&
699 !QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_GENERATOR)) || 625 !tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_GENERATOR]) ||
700 (owner_type != PLAYER && tmp->type != PLAYER)) || (tmp == exclude || (tmp->head && tmp->head == exclude)))) 626 (owner_type != PLAYER && tmp->type != PLAYER)) || (tmp == exclude || (tmp->head && tmp->head == exclude))))
701 tmp = tmp->above; 627 tmp = tmp->above;
702 628
703 if (tmp != NULL && can_see_monsterP (m, x, y, i)) 629 if (tmp != NULL && can_see_monsterP (m, x, y, i))
704 return freedir[i]; 630 return freedir[i];
708 634
709/* put_a_monster: puts a monster named monstername near by 635/* put_a_monster: puts a monster named monstername near by
710 * op. This creates the treasures for the monsters, and 636 * op. This creates the treasures for the monsters, and
711 * also deals with multipart monsters properly. 637 * also deals with multipart monsters properly.
712 */ 638 */
713void 639static void
714put_a_monster (object *op, const char *monstername) 640put_a_monster (object *op, const char *monstername)
715{ 641{
716 object *tmp, *head = NULL, *prev = NULL; 642 object *tmp, *head = NULL, *prev = NULL;
717 archetype *at; 643 archetype *at;
718 int dir; 644 int dir;
733 * insert multipart monsters properly 659 * insert multipart monsters properly
734 */ 660 */
735 //TODO: use expand_tail + ... 661 //TODO: use expand_tail + ...
736 while (at != NULL) 662 while (at != NULL)
737 { 663 {
738 tmp = arch_to_object (at); 664 tmp = at->instance ();
739 tmp->x = op->x + freearr_x[dir] + at->x; 665 tmp->x = op->x + freearr_x[dir] + at->x;
740 tmp->y = op->y + freearr_y[dir] + at->y; 666 tmp->y = op->y + freearr_y[dir] + at->y;
741 tmp->map = op->map; 667 tmp->map = op->map;
742 if (head) 668 if (head)
743 { 669 {
757 create_treasure (head->randomitems, head, GT_INVISIBLE, op->map->difficulty, 0); 683 create_treasure (head->randomitems, head, GT_INVISIBLE, op->map->difficulty, 0);
758 684
759 insert_ob_in_map (head, op->map, op, 0); 685 insert_ob_in_map (head, op->map, op, 0);
760 686
761 /* thought it'd be cool to insert a burnout, too. */ 687 /* thought it'd be cool to insert a burnout, too. */
762 op->map->insert (get_archetype ("burnout"), op->x + freearr_x[dir], op->y + freearr_y[dir], op); 688 op->map->insert (archetype::get (shstr_burnout), op->x + freearr_x[dir], op->y + freearr_y[dir], op);
763 } 689 }
764} 690}
765 691
766/* peterm: function which summons hostile monsters and 692/* peterm: function which summons hostile monsters and
767 * places them in nearby squares. 693 * places them in nearby squares.
774 * Note that this is not used by any spells (summon evil monsters 700 * Note that this is not used by any spells (summon evil monsters
775 * use to call this, but best I can tell, that spell/ability was 701 * use to call this, but best I can tell, that spell/ability was
776 * never used. This is however used by various failures on the 702 * never used. This is however used by various failures on the
777 * players part (alchemy, reincarnation, etc) 703 * players part (alchemy, reincarnation, etc)
778 */ 704 */
779
780int 705int
781summon_hostile_monsters (object *op, int n, const char *monstername) 706summon_hostile_monsters (object *op, int n, const char *monstername)
782{ 707{
783 int i; 708 int i;
784 709
849 { 774 {
850 SET_ANIMATION (op, ATTACKS[i].face); 775 SET_ANIMATION (op, ATTACKS[i].face);
851 } 776 }
852} 777}
853 778
854
855/* prayer_failure: This is called when a player fails 779/* prayer_failure: This is called when a player fails
856 * at casting a prayer. 780 * at casting a prayer.
857 * op is the player. 781 * op is the player.
858 * failure is basically how much grace they had. 782 * failure is basically how much grace they had.
859 * power is how much grace the spell would normally take to cast. 783 * power is how much grace the spell would normally take to cast.
860 */ 784 */
861 785
862void 786#define HINT_GRACE " H<Make sure you always have enough grace points for your prayers.>"
787
788static void
863prayer_failure (object *op, int failure, int power) 789prayer_failure (object *op, int failure, int power)
864{ 790{
865 const char *godname; 791 const char *godname;
866 object *tmp; 792 object *tmp;
867 793
868 if (!strcmp ((godname = determine_god (op)), "none")) 794 if (!strcmp ((godname = determine_god (op)), "none"))
869 godname = "Your spirit"; 795 godname = "Your spirit";
870 796
871 if (failure <= -20 && failure > -40) /* wonder */ 797 if (failure <= -20 && failure > -40) /* wonder */
872 { 798 {
873 new_draw_info_format (NDI_UNIQUE, 0, op, "%s gives a sign to renew your faith.", godname); 799 op->failmsgf ("%s gives a sign to renew your faith." HINT_GRACE, godname);
874 tmp = get_archetype (SPELL_WONDER); 800 tmp = archetype::get (SPELL_WONDER);
875 cast_cone (op, op, 0, tmp); 801 cast_cone (op, op, 0, tmp);
876 tmp->destroy (); 802 tmp->destroy ();
877 } 803 }
878 804
879 else if (failure <= -40 && failure > -60) /* confusion */ 805 else if (failure <= -40 && failure > -60) /* confusion */
880 { 806 {
881 new_draw_info (NDI_UNIQUE, 0, op, "Your diety touches your mind!"); 807 op->failmsg ("Your diety touches your mind!" HINT_GRACE);
882 confuse_player (op, op, 99); 808 confuse_player (op, op, 99);
883 } 809 }
884 else if (failure <= -60 && failure > -150) /* paralysis */ 810 else if (failure <= -60 && failure > -150) /* paralysis */
885 { 811 {
886 new_draw_info_format (NDI_UNIQUE, 0, op, "%s requires you to pray NOW.", godname); 812 op->failmsgf ("%s requires you to pray NOW. "
887 new_draw_info (NDI_UNIQUE, 0, op, "You comply, ignoring all else."); 813 "You comply, ignoring all else." HINT_GRACE,
814 godname);
888 paralyze_player (op, op, 99); 815 paralyze_player (op, op, 99);
889 } 816 }
890 else if (failure <= -150) /* blast the immediate area */ 817 else if (failure <= -150) /* blast the immediate area */
891 { 818 {
892 tmp = get_archetype (GOD_POWER); 819 tmp = archetype::get (GOD_POWER);
893 new_draw_info_format (NDI_UNIQUE, 0, op, "%s smites you!", godname); 820 op->failmsgf ("%s smites you!" HINT_GRACE, godname);
894 cast_magic_storm (op, tmp, power); 821 cast_magic_storm (op, tmp, power);
895 } 822 }
896} 823}
897 824
898/* 825/*
912 if (settings.spell_failure_effects == FALSE) 839 if (settings.spell_failure_effects == FALSE)
913 return; 840 return;
914 841
915 if (failure <= -20 && failure > -40) /* wonder */ 842 if (failure <= -20 && failure > -40) /* wonder */
916 { 843 {
917 new_draw_info (NDI_UNIQUE, 0, op, "Your spell causes an unexpected effect."); 844 op->failmsg ("Your spell causes an unexpected effect.");
918 tmp = get_archetype (SPELL_WONDER); 845 tmp = archetype::get (SPELL_WONDER);
919 cast_cone (op, op, 0, tmp); 846 cast_cone (op, op, 0, tmp);
920 tmp->destroy (); 847 tmp->destroy ();
921 } 848 }
922 849
923 else if (failure <= -40 && failure > -60) /* confusion */ 850 else if (failure <= -40 && failure > -60) /* confusion */
924 { 851 {
925 new_draw_info (NDI_UNIQUE, 0, op, "Your magic recoils on you, making you confused!"); 852 op->failmsg ("Your magic recoils on you, making you confused!");
926 confuse_player (op, op, 99); 853 confuse_player (op, op, 99);
927 } 854 }
928 else if (failure <= -60 && failure > -80) /* paralysis */ 855 else if (failure <= -60 && failure > -80) /* paralysis */
929 { 856 {
930 new_draw_info (NDI_UNIQUE, 0, op, "Your magic stuns you!"); 857 op->failmsg ("Your magic stuns you!");
931 paralyze_player (op, op, 99); 858 paralyze_player (op, op, 99);
932 } 859 }
933 else if (failure <= -80) /* blast the immediate area */ 860 else if (failure <= -80) /* blast the immediate area */
934 { 861 {
935 object *tmp; 862 object *tmp;
936 863
937 /* Safety check to make sure we don't get any mana storms in scorn */ 864 /* Safety check to make sure we don't get any mana storms in scorn */
938 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC) 865 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)
939 { 866 {
940 new_draw_info (NDI_UNIQUE, 0, op, "The magic warps and you are turned inside out!"); 867 op->failmsg ("The magic warps and you are turned inside out!");
941 hit_player (op, 9998, op, AT_INTERNAL, 1); 868 hit_player (op, 9998, op, AT_INTERNAL, 1);
942 869
943 } 870 }
944 else 871 else
945 { 872 {
946 new_draw_info (NDI_UNIQUE, 0, op, "You lose control of the mana! The uncontrolled magic blasts you!"); 873 op->failmsg ("You lose control of the mana! The uncontrolled magic blasts you!");
947 tmp = get_archetype (LOOSE_MANA); 874 tmp = archetype::get (LOOSE_MANA);
948 tmp->level = skill->level; 875 tmp->level = skill->level;
949 876
950 /* increase the area of destruction a little for more powerful spells */ 877 /* increase the area of destruction a little for more powerful spells */
951 tmp->range += isqrt (power); 878 tmp->range += isqrt (power);
952 879
960 tmp->insert_at (op); 887 tmp->insert_at (op);
961 } 888 }
962 } 889 }
963} 890}
964 891
965int 892static int
966cast_party_spell (object *op, object *caster, int dir, object *spell_ob, char *stringarg) 893cast_party_spell (object *op, object *caster, int dir, object *spell_ob, char *spellparam)
967{ 894{
968 int success;
969 object *spell;
970
971 if (!spell_ob->other_arch) 895 if (!spell_ob->other_arch)
972 { 896 {
973 LOG (llevError, "cast_party_spell: empty other arch\n"); 897 LOG (llevError, "cast_party_spell: empty other arch\n");
974 return 0; 898 return 0;
975 } 899 }
976 900
977 spell = arch_to_object (spell_ob->other_arch); 901 object *spell = spell_ob->other_arch->instance ();
978 902
979 /* Always cast spell on caster */ 903 /* Always cast spell on caster */
980 success = cast_spell (op, caster, dir, spell, stringarg); 904 int success = cast_spell (op, caster, dir, spell, spellparam);
981 905
982 if (caster->contr->party == NULL) 906 if (!op->contr || !op->contr->party)
983 { 907 {
984 spell->remove (); 908 spell->remove ();
985 return success; 909 return success;
986 } 910 }
987 911
988 for_all_players (pl) 912 for_all_players (pl)
989 if ((pl->ob->contr->party == caster->contr->party) && (on_same_map (pl->ob, caster))) 913 if ((pl->ob->contr->party == op->contr->party)
914 && on_same_map (pl->ob, op)
915 && pl->ob != op)
990 cast_spell (pl->ob, caster, pl->ob->facing, spell, stringarg); 916 cast_spell (pl->ob, caster, pl->ob->facing, spell, spellparam);
991 917
992 spell->remove (); 918 spell->remove ();
993 return success; 919 return success;
994} 920}
995 921
1001 * same as op. 927 * same as op.
1002 * dir is the direction to cast in. Note in some cases, if the spell 928 * dir is the direction to cast in. Note in some cases, if the spell
1003 * is self only, dir really doesn't make a difference. 929 * is self only, dir really doesn't make a difference.
1004 * spell_ob is the spell object that is being cast. From that, 930 * spell_ob is the spell object that is being cast. From that,
1005 * we can determine what to do. 931 * we can determine what to do.
1006 * stringarg is any options that are being used. It can be NULL. Almost 932 * spellparam is any options that are being used. It can be NULL. Almost
1007 * certainly, only players will set it. It is basically used as optional 933 * certainly, only players will set it. It is basically used as optional
1008 * parameters to a spell (eg, item to create, information for marking runes, 934 * parameters to a spell (eg, item to create, information for marking runes,
1009 * etc. 935 * etc.
1010 * returns 1 on successful cast, or 0 on error. These values should really 936 * returns 1 on successful cast, or 0 on error. These values should really
1011 * be swapped, so that 0 is successful, and non zero is failure, with a code 937 * be swapped, so that 0 is successful, and non zero is failure, with a code
1019 * if it is a player casting the spell (op->type == PLAYER, op == caster), 945 * if it is a player casting the spell (op->type == PLAYER, op == caster),
1020 * this function will decrease the mana/grace appropriately. For other 946 * this function will decrease the mana/grace appropriately. For other
1021 * objects, the caller should do what it considers appropriate. 947 * objects, the caller should do what it considers appropriate.
1022 */ 948 */
1023int 949int
1024cast_spell (object *op, object *caster, int dir, object *spell_ob, char *stringarg) 950cast_spell (object *op, object *caster, int dir, object *spell_ob, char *spellparam)
1025{ 951{
1026 const char *godname; 952 const char *godname;
1027 int success = 0, cast_level = 0; 953 int success = 0;
1028 object *skill = NULL; 954
955 // make sure spells always take a while, so a) we don't flood the
956 // user with messages and b) too many failures can be harmful (smiting).
957 op->speed_left -= 4 * op->speed; // ~0.5s on failure
1029 958
1030 if (!spell_ob) 959 if (!spell_ob)
1031 { 960 {
1032 LOG (llevError, "cast_spell: null spell object passed\n"); 961 LOG (llevError, "cast_spell: null spell object passed\n");
1033 return 0; 962 return 0;
1044 } 973 }
1045 974
1046 /* if caster is a spell casting object, this normally shouldn't be 975 /* if caster is a spell casting object, this normally shouldn't be
1047 * an issue, because they don't have any spellpaths set up. 976 * an issue, because they don't have any spellpaths set up.
1048 */ 977 */
1049 if (caster->path_denied & spell_ob->path_attuned && !QUERY_FLAG (caster, FLAG_WIZCAST)) 978 if (caster->path_denied & spell_ob->path_attuned && !caster->flag [FLAG_WIZCAST])
1050 { 979 {
1051 new_draw_info (NDI_UNIQUE, 0, op, "That spell path is denied to you."); 980 op->failmsg ("That spell path is denied to you.");
1052 return 0; 981 return 0;
1053 } 982 }
983
984 object *skill = 0;
1054 985
1055 /* if it is a player casting the spell, and they are really casting it 986 /* if it is a player casting the spell, and they are really casting it
1056 * (vs it coming from a wand, scroll, or whatever else), do some 987 * (vs it coming from a wand, scroll, or whatever else), do some
1057 * checks. We let monsters do special things - eg, they 988 * checks. We let monsters do special things - eg, they
1058 * don't need the skill, bypass level checks, etc. The monster function 989 * don't need the SKILL, BYpass level checks, etc. The monster function
1059 * should take care of that. 990 * should take care of that.
1060 * Remove the wiz check here and move it further down - some spells 991 * Remove the wiz check here and move it further down - some spells
1061 * need to have the right skill pointer passed, so we need to 992 * need to have the right skill pointer passed, so we need to
1062 * at least process that code. 993 * at least process that code.
1063 */ 994 */
1064 if (op->type == PLAYER && op == caster) 995 if (op->type == PLAYER && op == caster)
1065 { 996 {
1066 cast_level = caster_level (caster, spell_ob);
1067
1068 if (spell_ob->skill) 997 if (spell_ob->skill)
1069 { 998 {
1070 skill = find_skill_by_name (op, spell_ob->skill); 999 skill = find_skill_by_name (op, spell_ob->skill);
1071 1000
1072 if (!skill) 1001 if (!skill)
1073 { 1002 {
1074 op->failmsg (format ("You need the skill %s to cast %s!", &spell_ob->skill, &spell_ob->name)); 1003 op->failmsgf ("You need the %s skill to cast %s! "
1004 "H<You either need to learn the skill via a skill scroll "
1005 "or you need to wear a talisman, holy symbol or another skill tool.>",
1006 &spell_ob->skill, &spell_ob->name);
1075 return 0; 1007 return 0;
1076 } 1008 }
1077 1009
1078 if (min_casting_level (op, spell_ob) > cast_level && !QUERY_FLAG (op, FLAG_WIZ)) 1010 const char *msg = "";
1011
1012 int caster_level = skill->level;
1013
1014 if (op->path_attuned & spell_ob->path_attuned)
1079 { 1015 {
1016 caster_level += min (caster_level, ATTUNE_REPELL);
1017 msg = " (attuned)";
1018 }
1019
1020 if (op->path_repelled & spell_ob->path_attuned)
1021 {
1022 caster_level -= ATTUNE_REPELL; // negative is ok
1023 msg = " (repelled)";
1024 }
1025
1026 if (spell_ob->level > caster_level)
1027 {
1080 op->failmsg ("You lack enough skill to cast that spell!"); 1028 op->failmsgf ("You lack enough skill to cast that spell! "
1029 "H<Your effective cast level is %d%s, but level %d is required.>",
1030 caster_level, msg, spell_ob->level);
1031 if (!op->is_wiz ())
1081 return 0; 1032 return 0;
1082 } 1033 }
1083 } 1034 }
1084 1035
1085 /* If the caster is the wiz, they don't ever fail, and don't have 1036 /* If the caster is the wiz, they don't ever fail, and don't have
1086 * to have sufficient grace/mana. 1037 * to have sufficient grace/mana.
1087 */ 1038 */
1088 if (!QUERY_FLAG (op, FLAG_WIZ)) 1039 if (!op->flag [FLAG_WIZCAST])
1089 { 1040 {
1090 if (SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) && 1041 if (SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) &&
1091 SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) > op->stats.sp) 1042 SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) > op->stats.sp)
1092 { 1043 {
1093 op->failmsg ("You don't have enough mana!"); 1044 op->failmsg ("You don't have enough mana!");
1101 10 * SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) / op->stats.maxgrace > 0) 1052 10 * SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) / op->stats.maxgrace > 0)
1102 op->statusmsg (format ("%s grants your prayer, though you are unworthy.", godname)); 1053 op->statusmsg (format ("%s grants your prayer, though you are unworthy.", godname));
1103 else 1054 else
1104 { 1055 {
1105 prayer_failure (op, op->stats.grace, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) - op->stats.grace); 1056 prayer_failure (op, op->stats.grace, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) - op->stats.grace);
1106 op->failmsg (format ("%s ignores your prayer.", godname)); 1057 op->failmsgf ("%s ignores your prayer.", godname);
1107 return 0; 1058 return 0;
1108 } 1059 }
1109 } 1060 }
1110 1061
1111 /* player/monster is trying to cast the spell. might fumble it */ 1062 /* player/monster is trying to cast the spell. might fumble it */
1112 if (spell_ob->stats.grace && random_roll (0, 99, op, PREFER_HIGH) < 1063 if (spell_ob->stats.grace && random_roll (0, 99, op, PREFER_HIGH) <
1113 (spell_ob->level / (float) MAX (1, op->level) * cleric_chance[op->stats.Wis])) 1064 (spell_ob->level / (float) max (1, op->level) * cleric_chance[op->stats.Wis]))
1114 { 1065 {
1115 op->contr->play_sound (sound_find ("fumble_spell")); 1066 op->contr->play_sound (sound_find ("fumble_spell"));
1116 op->failmsg ("You fumble the prayer."); 1067 op->failmsg ("You fumble the prayer.");
1117 1068
1118 op->stats.grace -= random_roll (1, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE), op, PREFER_LOW); 1069 op->stats.grace -= random_roll (1, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE), op, PREFER_LOW);
1141 * not alive, then this would mean that the mapmaker put the 1092 * not alive, then this would mean that the mapmaker put the
1142 * objects on the space - presume that they know what they are 1093 * objects on the space - presume that they know what they are
1143 * doing. 1094 * doing.
1144 */ 1095 */
1145 1096
1146 if ((mflags & P_SAFE) && !QUERY_FLAG (op, FLAG_WIZCAST)) // There is _ABSOLUTELY_ no magic allowed here (except wizards :-)! 1097 if ((mflags & P_SAFE) && !op->flag [FLAG_WIZCAST]) // There is _ABSOLUTELY_ no magic allowed here (except wizards :-)!
1147 { 1098 {
1099 op->speed_left -= 2 * op->speed; // freeze for two ticks, so we don't flood
1148 op->failmsg ("This ground is sacred! The gods prevent any magical effects done by you here!"); 1100 op->failmsg ("This ground is sacred! The gods prevent any magical effects done by you here!");
1149 return 0; 1101 return 0;
1150 } 1102 }
1151 1103
1152 if ((spell_ob->type == SPELL) 1104 if ((spell_ob->type == SPELL)
1153 && (caster->type != POTION) 1105 && (caster->type != POTION)
1154 && !QUERY_FLAG (op, FLAG_WIZCAST) 1106 && !op->flag [FLAG_WIZCAST]
1155 && (QUERY_FLAG (caster, FLAG_ALIVE) 1107 && (caster->flag [FLAG_ALIVE]
1156 || QUERY_FLAG (op, FLAG_ALIVE)) 1108 || op->flag [FLAG_ALIVE])
1157 && (((mflags & P_NO_MAGIC) && spell_ob->stats.sp) || ((mflags & P_NO_CLERIC) && spell_ob->stats.grace))) 1109 && (((mflags & P_NO_MAGIC) && spell_ob->stats.sp) || ((mflags & P_NO_CLERIC) && spell_ob->stats.grace)))
1158 { 1110 {
1159 if (op->type != PLAYER) 1111 if (op->type != PLAYER)
1160 return 0; 1112 return 0;
1161 1113
1162 if ((mflags & P_NO_CLERIC) && spell_ob->stats.grace) 1114 if ((mflags & P_NO_CLERIC) && spell_ob->stats.grace)
1163 op->failmsg (format ("This ground is unholy! %s ignores you.", godname)); 1115 op->failmsgf ("This ground is unholy! %s ignores you.", godname);
1164 else if (object *item = op->contr->ranged_ob) 1116 else if (object *item = op->contr->ranged_ob)
1165 { 1117 {
1166 if (item->type == SPELL) 1118 if (item->type == SPELL)
1167 op->failmsg ("Something blocks your spellcasting."); 1119 op->failmsg ("Something blocks your spellcasting.");
1168 else if (item->type == SCROLL) 1120 else if (item->type == SCROLL)
1174 op->failmsg ("Something blocks the spell!"); 1126 op->failmsg ("Something blocks the spell!");
1175 1127
1176 return 0; 1128 return 0;
1177 } 1129 }
1178 1130
1131 // undo the flood protection from earlier
1132 op->speed_left += 4 * op->speed; // ~0.5s on failure
1133
1179 /* Take into account how long it takes to cast the spell. 1134 /* Take into account how long it takes to cast the spell.
1180 * if the player is casting it, then we use the time in 1135 * if the player is casting it, then we use the time in
1181 * the spell object. If it is a spell object, have it 1136 * the spell object. If it is a spell object, have it
1182 * take two ticks. Things that cast spells on the players 1137 * take two ticks. Things that cast spells on the players
1183 * behalf (eg, altars, and whatever else) shouldn't cost 1138 * behalf (eg, altars, and whatever else) shouldn't cost
1184 * the player any time. 1139 * the player any time.
1185 * Ignore casting time for firewalls 1140 * Ignore casting time for firewalls
1186 */ 1141 */
1187 if (caster == op && caster->type != FIREWALL) 1142 if (caster == op && caster->type != FIREWALL)
1188 { 1143 {
1189 op->speed_left -= spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed); 1144 op->speed_left -= spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed;
1190 /* Other portions of the code may also decrement the speed of the player, so 1145 /* Other portions of the code may also decrement the speed of the player, so
1191 * put a lower limit so that the player isn't stuck here too long 1146 * put a lower limit so that the player isn't stuck here too long
1192 */ 1147 */
1193 if ((spell_ob->casting_time > 0) && op->speed_left < -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed)) 1148 if ((spell_ob->casting_time > 0) && op->speed_left < -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed)
1194 op->speed_left = -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed); 1149 op->speed_left = -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed;
1195 } 1150 }
1196 else if (caster->type == WAND || caster->type == HORN || caster->type == ROD || caster->type == POTION || caster->type == SCROLL) 1151 else if (caster->type == WAND || caster->type == HORN || caster->type == ROD || caster->type == POTION || caster->type == SCROLL)
1197 op->speed_left -= 2 * FABS (op->speed); 1152 op->speed_left -= 2 * op->speed;
1198 1153
1199 if (op->type == PLAYER && op == caster) 1154 if (op->type == PLAYER && op == caster)
1200 { 1155 {
1201 op->stats.grace -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE); 1156 op->stats.grace -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE);
1202 op->stats.sp -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA); 1157 op->stats.sp -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA);
1207 * object requires. 1162 * object requires.
1208 */ 1163 */
1209 if (op != caster && !skill && caster->skill) 1164 if (op != caster && !skill && caster->skill)
1210 { 1165 {
1211 skill = find_skill_by_name (op, caster->skill); 1166 skill = find_skill_by_name (op, caster->skill);
1167
1212 if (!skill) 1168 if (!skill)
1213 { 1169 {
1214 op->failmsg (format ("You lack the skill %s to use the %s!", &caster->skill, query_name (caster))); 1170 op->failmsgf ("You lack the %s skill, which is required to use the %s!", &caster->skill, query_name (caster));
1215 return 0; 1171 return 0;
1216 } 1172 }
1217
1218 op->change_skill (skill); /* needed for proper exp credit */
1219 } 1173 }
1220 1174
1221 if (INVOKE_OBJECT (CAST_SPELL, spell_ob, ARG_OBJECT (op), ARG_OBJECT (caster), ARG_INT (dir), ARG_STRING (stringarg))) 1175 if (INVOKE_OBJECT (CAST_SPELL, spell_ob, ARG_OBJECT (op), ARG_OBJECT (caster), ARG_INT (dir), ARG_STRING (spellparam)))
1222 return RESULT_INT (0); 1176 return RESULT_INT (0);
1223 1177
1178 // temporaroly replace chosen_skill by skill, we assume skill *could* be applied,
1179 // at least temporarily, which might not be true due to slot restrictions, but hey
1180 // invoke requires it basically.
1181
1182 object *chosen_skill = op->chosen_skill;
1183 op->chosen_skill = skill;
1184
1224 switch (spell_ob->subtype) 1185 switch (spell_ob->subtype)
1225 { 1186 {
1226 /* The order of case statements is same as the order they show up 1187 /* The order of case statements is same as the order they show up
1227 * in in spells.h. 1188 * in spells.h.
1228 */ 1189 */
1229 case SP_RAISE_DEAD: 1190 case SP_RAISE_DEAD:
1230 success = cast_raise_dead_spell (op, caster, spell_ob, dir, stringarg); 1191 success = cast_raise_dead_spell (op, caster, spell_ob, dir, spellparam);
1231 break; 1192 break;
1232 1193
1233 case SP_RUNE: 1194 case SP_RUNE:
1234 success = write_rune (op, caster, spell_ob, dir, stringarg); 1195 success = write_rune (op, caster, spell_ob, dir, spellparam);
1235 break; 1196 break;
1236 1197
1237 case SP_MAKE_MARK: 1198 case SP_MAKE_MARK:
1238 success = write_mark (op, spell_ob, stringarg); 1199 success = write_mark (op, spell_ob, spellparam);
1239 break; 1200 break;
1240 1201
1241 case SP_BOLT: 1202 case SP_BOLT:
1242 success = fire_bolt (op, caster, dir, spell_ob, skill); 1203 success = fire_bolt (op, caster, dir, spell_ob, skill);
1243 break; 1204 break;
1261 case SP_SMITE: 1222 case SP_SMITE:
1262 success = cast_smite_spell (op, caster, dir, spell_ob); 1223 success = cast_smite_spell (op, caster, dir, spell_ob);
1263 break; 1224 break;
1264 1225
1265 case SP_MAGIC_MISSILE: 1226 case SP_MAGIC_MISSILE:
1266 success = fire_arch_from_position (op, caster, op->x + freearr_x[dir], op->y + freearr_y[dir], dir, spell_ob); 1227 success = fire_arch_from_position (op, caster, op->x, op->y, dir, spell_ob);
1267 break; 1228 break;
1268 1229
1269 case SP_SUMMON_GOLEM: 1230 case SP_SUMMON_GOLEM:
1270 success = summon_golem (op, caster, dir, spell_ob); 1231 success = summon_golem (op, caster, dir, spell_ob);
1271 break; 1232 break;
1272 1233
1273 case SP_DIMENSION_DOOR: 1234 case SP_DIMENSION_DOOR:
1274 /* dimension door needs the actual caster, because that is what is 1235 /* dimension door needs the actual caster, because that is what is
1275 * moved. 1236 * moved.
1276 */ 1237 */
1277 success = dimension_door (op, caster, spell_ob, dir); 1238 success = dimension_door (op, caster, spell_ob, dir, spellparam);
1278 break; 1239 break;
1279 1240
1280 case SP_MAGIC_MAPPING: 1241 case SP_MAGIC_MAPPING:
1281 if (op->type == PLAYER) 1242 if (op->type == PLAYER)
1282 { 1243 {
1315 case SP_HEALING: 1276 case SP_HEALING:
1316 success = cast_heal (op, caster, spell_ob, dir); 1277 success = cast_heal (op, caster, spell_ob, dir);
1317 break; 1278 break;
1318 1279
1319 case SP_CREATE_FOOD: 1280 case SP_CREATE_FOOD:
1320 success = cast_create_food (op, caster, spell_ob, dir, stringarg); 1281 success = cast_create_food (op, caster, spell_ob, dir, spellparam);
1321 break; 1282 break;
1322 1283
1323 case SP_EARTH_TO_DUST: 1284 case SP_EARTH_TO_DUST:
1324 success = cast_earth_to_dust (op, caster, spell_ob); 1285 success = cast_earth_to_dust (op, caster, spell_ob);
1325 break; 1286 break;
1335 case SP_CURSE: 1296 case SP_CURSE:
1336 success = cast_curse (op, caster, spell_ob, dir); 1297 success = cast_curse (op, caster, spell_ob, dir);
1337 break; 1298 break;
1338 1299
1339 case SP_SUMMON_MONSTER: 1300 case SP_SUMMON_MONSTER:
1340 success = summon_object (op, caster, spell_ob, dir, stringarg); 1301 success = summon_object (op, caster, spell_ob, dir, spellparam);
1341 break; 1302 break;
1342 1303
1343 case SP_CHARGING: 1304 case SP_CHARGING:
1344 success = recharge (op, caster, spell_ob); 1305 success = recharge (op, caster, spell_ob);
1345 break; 1306 break;
1378 break; 1339 break;
1379 1340
1380 case SP_MOVING_BALL: 1341 case SP_MOVING_BALL:
1381 if (spell_ob->path_repelled && (spell_ob->path_repelled & caster->path_attuned) != spell_ob->path_repelled) 1342 if (spell_ob->path_repelled && (spell_ob->path_repelled & caster->path_attuned) != spell_ob->path_repelled)
1382 { 1343 {
1383 op->failmsg (format ("You lack the proper attunement to cast %s!", &spell_ob->name)); 1344 op->failmsgf ("You lack the proper attunement to cast %s!", &spell_ob->name);
1384 success = 0; 1345 success = 0;
1385 } 1346 }
1386 else 1347 else
1387 success = fire_arch_from_position (op, caster, op->x + freearr_x[dir], op->y + freearr_y[dir], dir, spell_ob); 1348 success = fire_arch_from_position (op, caster, op->x, op->y, dir, spell_ob);
1388 break; 1349 break;
1389 1350
1390 case SP_SWARM: 1351 case SP_SWARM:
1391 success = fire_swarm (op, caster, spell_ob, dir); 1352 success = fire_swarm (op, caster, spell_ob, dir);
1392 break; 1353 break;
1399 /* in rune.c */ 1360 /* in rune.c */
1400 success = dispel_rune (op, caster, spell_ob, skill, dir); 1361 success = dispel_rune (op, caster, spell_ob, skill, dir);
1401 break; 1362 break;
1402 1363
1403 case SP_CREATE_MISSILE: 1364 case SP_CREATE_MISSILE:
1404 success = cast_create_missile (op, caster, spell_ob, dir, stringarg); 1365 success = cast_create_missile (op, caster, spell_ob, dir, spellparam);
1405 break; 1366 break;
1406 1367
1407 case SP_CONSECRATE: 1368 case SP_CONSECRATE:
1408 success = cast_consecrate (op, caster, spell_ob); 1369 success = cast_consecrate (op, caster, spell_ob);
1409 break; 1370 break;
1431 case SP_AURA: 1392 case SP_AURA:
1432 success = create_aura (op, caster, spell_ob); 1393 success = create_aura (op, caster, spell_ob);
1433 break; 1394 break;
1434 1395
1435 case SP_PARTY_SPELL: 1396 case SP_PARTY_SPELL:
1436 success = cast_party_spell (op, caster, dir, spell_ob, stringarg); 1397 success = cast_party_spell (op, caster, dir, spell_ob, spellparam);
1437 break; 1398 break;
1438 1399
1439 default: 1400 default:
1440 LOG (llevError, "cast_spell: Unhandled spell subtype %d\n", spell_ob->subtype); 1401 LOG (llevError, "cast_spell: Unhandled spell subtype %d\n", spell_ob->subtype);
1441 } 1402 }
1403
1404 // restore chosen_skill
1405 op->chosen_skill = chosen_skill;
1442 1406
1443 op->play_sound ( 1407 op->play_sound (
1444 success 1408 success
1445 ? spell_ob->sound 1409 ? spell_ob->sound
1446 ? spell_ob->sound 1410 ? spell_ob->sound
1500 move_aura (op); 1464 move_aura (op);
1501 break; 1465 break;
1502 } 1466 }
1503} 1467}
1504 1468
1505/* this checks to see if something special should happen if
1506 * something runs into the object.
1507 */
1508void
1509check_spell_effect (object *op)
1510{
1511 switch (op->subtype)
1512 {
1513 case SP_BOLT:
1514 move_bolt (op);
1515 return;
1516
1517 case SP_BULLET:
1518 check_bullet (op);
1519 return;
1520 }
1521}
1522
1523/* This is called by move_apply. Basically, if someone 1469/* This is called by move_apply. Basically, if someone
1524 * moves onto a spell effect and the walk_on or fly_on flags 1470 * moves onto a spell effect and the walk_on or fly_on flags
1525 * are set, this is called. This should only be called for 1471 * are set, this is called. This should only be called for
1526 * objects of the appropraite type. 1472 * objects of the appropriate type.
1527 */ 1473 */
1528void 1474void
1529apply_spell_effect (object *spell, object *victim) 1475apply_spell_effect (object *spell, object *victim)
1530{ 1476{
1531 switch (spell->subtype) 1477 switch (spell->subtype)
1532 { 1478 {
1533 case SP_CONE: 1479 case SP_CONE:
1534 if (QUERY_FLAG (victim, FLAG_ALIVE) && spell->speed && spell->attacktype) 1480 if (victim->flag [FLAG_ALIVE] && spell->has_active_speed () && spell->attacktype)
1535 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 0); 1481 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 0);
1536 break; 1482 break;
1537 1483
1538 case SP_MAGIC_MISSILE: 1484 case SP_MAGIC_MISSILE:
1539 if (QUERY_FLAG (victim, FLAG_ALIVE)) 1485 if (victim->flag [FLAG_ALIVE])
1540 { 1486 {
1541 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1); 1487 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1);
1542
1543 if (!spell->destroyed ())
1544 spell->destroy (); 1488 spell->destroy ();
1545 } 1489 }
1546 break; 1490 break;
1547 1491
1548 case SP_MOVING_BALL: 1492 case SP_MOVING_BALL:
1549 if (QUERY_FLAG (victim, FLAG_ALIVE)) 1493 if (victim->flag [FLAG_ALIVE])
1550 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1); 1494 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1);
1551 else if (victim->materialname) 1495 else if (victim->material != MATERIAL_NULL)
1552 save_throw_object (victim, spell->attacktype, spell); 1496 save_throw_object (victim, spell->attacktype, spell);
1553 break;
1554 }
1555}
1556 1497
1498 break;
1499 }
1500}
1501
1502/**
1503 * This function will let a fireball explode at the position of
1504 * the victim with a specific maximum level.
1505 */
1506void
1507create_exploding_ball_at (object *victim, int level)
1508{
1509 object *ball = archetype::get (EXPLODING_FIREBALL);
1510 ball->dam_modifier = random_roll (1, level, victim, PREFER_LOW) / 5 + 1;
1511 ball->stats.maxhp = random_roll (1, level, victim, PREFER_LOW) / 10 + 2;
1512 ball->insert_at (victim);
1513}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines