ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/spell_util.C
(Generate patch)

Comparing deliantra/server/server/spell_util.C (file contents):
Revision 1.66 by root, Sat Mar 15 13:52:38 2008 UTC vs.
Revision 1.125 by root, Mon Nov 12 03:48:34 2012 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <spells.h> 26#include <spells.h>
33/* This returns a random spell from 'ob'. If skill is set, then 34/* This returns a random spell from 'ob'. If skill is set, then
34 * the spell must be of this skill, it can be NULL in which case all 35 * the spell must be of this skill, it can be NULL in which case all
35 * matching spells are used. 36 * matching spells are used.
36 */ 37 */
37object * 38object *
38find_random_spell_in_ob (object *ob, const char *skill) 39find_random_spell_in_ob (object *ob, shstr_cmp skill)
39{ 40{
40 int k = 0, s; 41 int k = 0, s;
41 object *tmp;
42 42
43 for (tmp = ob->inv; tmp; tmp = tmp->below) 43 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
44 if (tmp->type == SPELL && (!skill || tmp->skill == skill)) 44 if (tmp->type == SPELL && (!skill || tmp->skill == skill))
45 k++; 45 k++;
46 46
47 /* No spells, no need to progess further */ 47 /* No spells, no need to progess further */
48 if (!k) 48 if (!k)
49 return NULL; 49 return NULL;
50 50
51 s = RANDOM () % k; 51 s = rndm (k);
52 52
53 for (tmp = ob->inv; tmp; tmp = tmp->below) 53 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
54 if (tmp->type == SPELL && (!skill || tmp->skill == skill)) 54 if (tmp->type == SPELL && (!skill || tmp->skill == skill))
55 {
56 if (!s) 55 if (!s)
57 return tmp; 56 return tmp;
58 else 57 else
59 s--; 58 s--;
60 } 59
61 /* Should never get here, but just in case */ 60 /* Should never get here, but just in case */
62 return NULL; 61 return 0;
63} 62}
64 63
65/* Relatively simple function that gets used a lot. 64/* Relatively simple function that gets used a lot.
66 * Basically, it sets up the skill pointer for the spell being 65 * Basically, it sets up the skill pointer for the spell being
67 * cast. If op is really casting the spell, then the skill 66 * cast. If op is really casting the spell, then the skill
77 dest->skill = spob->skill; 76 dest->skill = spob->skill;
78 else 77 else
79 dest->skill = caster->skill; 78 dest->skill = caster->skill;
80} 79}
81 80
82/* init_spells: This should really be called check_spells, as that
83 * is what it does. It goes through the spells looking for any
84 * obvious errors. This was most useful in debugging when re-doing
85 * all the spells to catch simple errors. To use it all the time
86 * will result in it spitting out messages that aren't really errors.
87 */
88void
89init_spells (void)
90{
91#ifdef SPELL_DEBUG
92 static int init_spells_done = 0;
93 int i;
94 archetype *at;
95
96 if (init_spells_done)
97 return;
98 LOG (llevDebug, "Checking spells...\n");
99
100 for_all_archetypes (at)
101 {
102 if (at->type == SPELL)
103 {
104 if (at->skill)
105 {
106 for (i = 1; i < NUM_SKILLS; i++)
107 if (!strcmp (skill_names[i], at->skill))
108 break;
109 if (i == NUM_SKILLS)
110 {
111 LOG (llevError, "Spell %s has improper associated skill %s\n", at->name, at->skill);
112 }
113 }
114 /* other_arch is already checked for in the loader */
115 }
116 }
117
118 i = 0;
119 while (spell_mapping[i])
120 {
121 if (!archetype::find (spell_mapping[i]))
122 {
123 LOG (llevError, "Unable to find spell mapping %s (%i)\n", spell_mapping[i], i);
124 }
125 i++;
126 }
127 LOG (llevDebug, "Checking spells completed.\n");
128#endif
129}
130
131/* Dumps all the spells - now also dumps skill associated with the spell.
132 * not sure what this would be used for, as the data seems pretty
133 * minimal, but easy enough to keep around.
134 */
135void
136dump_spells ()
137{
138 for_all_archetypes (at)
139 if (at->type == SPELL)
140 fprintf (stderr, "%s:%s:%s:%s:%d\n", &at->object::name,
141 &at->archname, at->other_arch ? &at->other_arch->archname : "<nil>", &at->skill, at->level);
142}
143
144/* pretty basic function - basically just takes 81/* pretty basic function - basically just takes
145 * an object, sets the x,y, and calls insert_ob_in_map 82 * an object, sets the x,y, and calls insert_ob_in_map
146 */ 83 */
147void 84void
148spell_effect (object *spob, int x, int y, maptile *map, object *originator) 85spell_effect (object *spob, int x, int y, maptile *map, object *originator)
149{ 86{
150 if (spob->other_arch) 87 if (spob->other_arch)
151 map->insert (arch_to_object (spob->other_arch), x, y, originator); 88 map->insert (spob->other_arch->instance (), x, y, originator);
152} 89}
153 90
154/* 91static int
155 * This function takes a caster and spell and presents the 92attuned_bonus (object *caster, object *spell, int level)
156 * effective level the caster needs to be to cast the spell.
157 * basically, it just adjusts the spell->level with attuned/repelled
158 * spellpaths. Was called path_level_mod.
159 *
160 * caster is person casting the spell.
161 * spell is the spell object.
162 * Returns modified level.
163 */
164int
165min_casting_level (object *caster, object *spell)
166{ 93{
167 if (caster->path_denied & spell->path_attuned) 94 // compute the attuned/repelled bonus
168 return 1; 95 // attuned only increases up to 2 times the original level (i.e. bonus <= level) */
169 96 // repell has no such quarrels
170 int new_level = spell->level 97 return (caster->path_attuned & spell->path_attuned ? min (level, +ATTUNE_REPELL) : 0)
171 + (caster->path_repelled & spell->path_attuned ? +8 : 0) 98 + (caster->path_repelled & spell->path_attuned ? -ATTUNE_REPELL : 0);
172 + (caster->path_attuned & spell->path_attuned ? -8 : 0);
173
174 return max (1, new_level);
175} 99}
176 100
177/* This function returns the effective level the spell 101/* This function returns the effective level the spell
178 * is being cast at. 102 * is being cast at.
179 * Note that I changed the repelled/attuned bonus to 2 from 5.
180 * This is because the new code compares casting_level against
181 * min_caster_level, so the difference is effectively 4
182 */ 103 */
183int 104int
184caster_level (object *caster, object *spell) 105casting_level (object *caster, object *spell)
185{ 106{
186 int level = caster->level; 107 int level = caster->level;
187 108
188 /* if a rod is fired by a player, take the use_magic_item skill in consideration. */ 109 /* if a rod is fired by a player, take the use_magic_item skill in consideration. */
189 if (caster->type == ROD && caster->env && caster->env->type == PLAYER) 110 if (caster->type == ROD && caster->env && caster->env->type == PLAYER)
191 object *skill = find_skill_by_number (caster->env, SK_USE_MAGIC_ITEM); 112 object *skill = find_skill_by_number (caster->env, SK_USE_MAGIC_ITEM);
192 int sk_level = skill ? skill->level : 1; 113 int sk_level = skill ? skill->level : 1;
193 114
194 level = min (level, sk_level + level / 10 + 1); 115 level = min (level, sk_level + level / 10 + 1);
195 } 116 }
196 else if (caster->type == PLAYER && spell->skill) /* If this is a player, try to find the matching skill */ 117 else if (caster->type == PLAYER) /* If this is a player, try to find the matching skill */
197 for (int i = 0; i < NUM_SKILLS; i++) 118 if (object *skill = caster->contr->find_skill (spell->skill))
198 if (caster->contr->last_skill_ob[i] && caster->contr->last_skill_ob[i]->skill == spell->skill) 119 level = skill->level;
199 {
200 level = caster->contr->last_skill_ob[i]->level;
201 break;
202 }
203 120
204 /* Got valid caster level. Now adjust for attunement */ 121 int bonus = attuned_bonus (caster, spell, level);
205 level += caster->path_repelled & spell->path_attuned ? -8 : 0; 122
206 level += caster->path_attuned & spell->path_attuned ? +8 : 0; 123 level += bonus;
124
125 // now scale the effective level from the startinglevel..100 range to 1..100
126 if (level < 100)
127 level = lerp (level, (int)spell->level, 100, 1, 100);
207 128
208 /* Always make this at least 1. If this is zero, we get divide by zero 129 /* Always make this at least 1. If this is zero, we get divide by zero
209 * errors in various places. 130 * errors in various places.
210 */ 131 */
211 return max (level, 1); 132 return clamp (level, 1, settings.max_level);
212} 133}
213 134
214/* The following function scales the spellpoint cost of 135/* The following function scales the spellpoint cost of
215 * a spell by it's increased effectiveness. Some of the 136 * a spell by it's increased effectiveness. Some of the
216 * lower level spells become incredibly vicious at high 137 * lower level spells become incredibly vicious at high
220 * caster is what is casting the spell, can be op. 141 * caster is what is casting the spell, can be op.
221 * spell is the spell object. 142 * spell is the spell object.
222 * Note that it is now possible for a spell to cost both grace and 143 * Note that it is now possible for a spell to cost both grace and
223 * mana. In that case, we return which ever value is higher. 144 * mana. In that case, we return which ever value is higher.
224 */ 145 */
225
226sint16 146sint16
227SP_level_spellpoint_cost (object *caster, object *spell, int flags) 147SP_level_spellpoint_cost (object *caster, object *spell, int flags)
228{ 148{
229 int sp, grace, level = caster_level (caster, spell); 149 int sp, grace, level = casting_level (caster, spell);
230 150
231 if (settings.spellpoint_level_depend == TRUE) 151 if (settings.spellpoint_level_depend == TRUE)
232 { 152 {
233 if (spell->stats.sp && spell->stats.maxsp) 153 if (spell->stats.sp && spell->stats.maxsp)
234 {
235 sp = (int) (spell->stats.sp * (1.0 + MAX (0, (float) (level - spell->level) / (float) spell->stats.maxsp))); 154 sp = spell->stats.sp * (1.f + max (0.f, float (level - spell->level) / spell->stats.maxsp));
236 }
237 else 155 else
238 sp = spell->stats.sp; 156 sp = spell->stats.sp;
239 157
240 sp *= (int) PATH_SP_MULT (caster, spell); 158 sp *= (int) PATH_SP_MULT (caster, spell);
241 if (!sp && spell->stats.sp) 159 if (!sp && spell->stats.sp)
242 sp = 1; 160 sp = 1;
243 161
244 if (spell->stats.grace && spell->stats.maxgrace) 162 if (spell->stats.grace && spell->stats.maxgrace)
245 {
246 grace = (int) (spell->stats.grace * (1.0 + MAX (0, (float) (level - spell->level) / (float) spell->stats.maxgrace))); 163 grace = spell->stats.grace * (1.f + max (0.f, float (level - spell->level) / spell->stats.maxgrace));
247 }
248 else 164 else
249 grace = spell->stats.grace; 165 grace = spell->stats.grace;
250 166
251 grace *= (int) PATH_SP_MULT (caster, spell); 167 grace *= PATH_SP_MULT (caster, spell);
252 if (spell->stats.grace && !grace) 168 if (spell->stats.grace && !grace)
253 grace = 1; 169 grace = 1;
254 } 170 }
255 else 171 else
256 { 172 {
262 if (spell->stats.grace && !grace) 178 if (spell->stats.grace && !grace)
263 grace = 1; 179 grace = 1;
264 } 180 }
265 181
266 if (flags == SPELL_HIGHEST) 182 if (flags == SPELL_HIGHEST)
267 return MAX (sp, grace); 183 return max (sp, grace);
268 else if (flags == SPELL_GRACE) 184 else if (flags == SPELL_GRACE)
269 return grace; 185 return grace;
270 else if (flags == SPELL_MANA) 186 else if (flags == SPELL_MANA)
271 return sp; 187 return sp;
272 else 188 else
274 LOG (llevError, "SP_level_spellpoint_cost: Unknown flags passed: %d\n", flags); 190 LOG (llevError, "SP_level_spellpoint_cost: Unknown flags passed: %d\n", flags);
275 return 0; 191 return 0;
276 } 192 }
277} 193}
278 194
195/*
196 * Return the effective casting level of the spell.
197 * To make spells independent of their starting level, this function
198 * scales the range spellstartlevel .. 100 into the range 1..100
199 */
200static int
201SP_casting_level (object *caster, object *spell)
202{
203 return casting_level (caster, spell);
204}
205
279/* SP_level_dam_adjust: Returns adjusted damage based on the caster. 206/* SP_level_dam_adjust: Returns adjusted damage based on the caster.
280 * spob is the spell we are adjusting. 207 * spob is the spell we are adjusting.
281 */ 208 */
282int 209int
283SP_level_dam_adjust (object *caster, object *spob) 210SP_level_dam_adjust (object *caster, object *spob)
284{ 211{
285 if (!spob->dam_modifier) 212 if (!spob->dam_modifier)
286 return 0; 213 return 0;
287 214
288 int level = caster_level (caster, spob);
289 return max (0, level - min_casting_level (caster, spob)) / spob->dam_modifier; 215 return SP_casting_level (caster, spob) / spob->dam_modifier;
290} 216}
291 217
292/* Adjust the strength of the spell based on level. 218/* Adjust the strength of the spell based on level.
293 * This is basically the same as SP_level_dam_adjust above, 219 * This is basically the same as SP_level_dam_adjust above,
294 * but instead looks at the level_modifier value. 220 * but instead looks at the level_modifier value.
297SP_level_duration_adjust (object *caster, object *spob) 223SP_level_duration_adjust (object *caster, object *spob)
298{ 224{
299 if (!spob->duration_modifier) 225 if (!spob->duration_modifier)
300 return 0; 226 return 0;
301 227
302 int level = caster_level (caster, spob);
303 return max (0, level - min_casting_level (caster, spob)) / spob->duration_modifier; 228 return SP_casting_level (caster, spob) / spob->duration_modifier;
304} 229}
305 230
306/* Adjust the strength of the spell based on level. 231/* Adjust the strength of the spell based on level.
307 * This is basically the same as SP_level_dam_adjust above, 232 * This is basically the same as SP_level_dam_adjust above,
308 * but instead looks at the level_modifier value. 233 * but instead looks at the level_modifier value.
311SP_level_range_adjust (object *caster, object *spob) 236SP_level_range_adjust (object *caster, object *spob)
312{ 237{
313 if (!spob->range_modifier) 238 if (!spob->range_modifier)
314 return 0; 239 return 0;
315 240
316 int level = caster_level (caster, spob);
317 return (level - min_casting_level (caster, spob)) / spob->range_modifier; 241 return SP_casting_level (caster, spob) / spob->range_modifier;
318} 242}
319 243
320/* Checks to see if player knows the spell. If the name is the same 244/* Checks to see if player knows the spell. If the name is the same
321 * as an existing spell, we presume they know it. 245 * as an existing spell, we presume they know it.
322 * returns 1 if they know the spell, 0 if they don't. 246 * returns 1 if they know the spell, 0 if they don't.
323 */ 247 */
324object * 248object *
325check_spell_known (object *op, const char *name) 249check_spell_known (object *op, shstr_cmp name)
326{ 250{
327 object *spop; 251 object *spop;
328 252
329 for (spop = op->inv; spop; spop = spop->below) 253 for (spop = op->inv; spop; spop = spop->below)
330 if (spop->type == SPELL && !strcmp (spop->name, name)) 254 if (spop->type == SPELL && spop->name == name)
331 return spop; 255 return spop;
332 256
333 return NULL; 257 return 0;
334} 258}
335
336 259
337/* 260/*
338 * Look at object 'op' and see if they know the spell 261 * Look at object 'op' and see if they know the spell
339 * spname. This is pretty close to check_spell_known 262 * spname. This is pretty close to check_spell_known
340 * above, but it uses a looser matching mechanism. 263 * above, but it uses a looser matching mechanism.
341 * returns the matching spell object, or NULL. 264 * returns the matching spell object, or NULL.
342 * If we match multiple spells but don't get an 265 * If we match multiple spells but don't get an
343 * exact match, we also return NULL. 266 * exact match, we also return NULL.
344 */ 267 */
345
346object * 268object *
347lookup_spell_by_name (object *op, const char *spname) 269lookup_spell_by_name (object *op, const char *spname)
348{ 270{
349 object *spob1 = NULL, *spob2 = NULL, *spob; 271 object *spob1 = 0, *spob2 = 0;
350 int nummatch = 0; 272 int nummatch = 0;
351 273
352 if (spname == NULL) 274 if (!spname)
353 return NULL; 275 return 0;
354 276
355 /* Try to find the spell. We store the results in spob1 277 /* Try to find the spell. We store the results in spob1
356 * and spob2 - spob1 is only taking the length of 278 * and spob2 - spob1 is only taking the length of
357 * the past spname, spob2 uses the length of the spell name. 279 * the past spname, spob2 uses the length of the spell name.
358 */ 280 */
359 for (spob = op->inv; spob; spob = spob->below) 281 for (object *spob = op->inv; spob; spob = spob->below)
360 { 282 {
361 if (spob->type == SPELL) 283 if (spob->type == SPELL)
362 { 284 {
285 // TODO: WTF?
363 if (!strncmp (spob->name, spname, strlen (spname))) 286 if (!strncmp (spob->name, spname, strlen (spname)))
364 { 287 {
365 nummatch++; 288 nummatch++;
366 spob1 = spob; 289 spob1 = spob;
367 } 290 }
372 * fall into this category). It shouldn't be hard to 295 * fall into this category). It shouldn't be hard to
373 * make sure spell names don't overlap in that fashion. 296 * make sure spell names don't overlap in that fashion.
374 */ 297 */
375 if (spob2) 298 if (spob2)
376 LOG (llevError, "Found multiple spells with overlapping base names: %s, %s\n", &spob2->name, &spob->name); 299 LOG (llevError, "Found multiple spells with overlapping base names: %s, %s\n", &spob2->name, &spob->name);
300
377 spob2 = spob; 301 spob2 = spob;
378 } 302 }
379 } 303 }
380 } 304 }
381 /* if we have best match, return it. Otherwise, if we have one match 305 /* if we have best match, return it. Otherwise, if we have one match
382 * on the loser match, return that, otehrwise null 306 * on the loser match, return that, otehrwise null
383 */ 307 */
384 if (spob2) 308 if (spob2)
385 return spob2; 309 return spob2;
310
386 if (spob1 && nummatch == 1) 311 if (spob1 && nummatch == 1)
387 return spob1; 312 return spob1;
313
388 return NULL; 314 return NULL;
389} 315}
390 316
391/* reflwall - decides weither the (spell-)object sp_op will 317/* reflwall - decides weither the (spell-)object sp_op will
392 * be reflected from the given mapsquare. Returns 1 if true. 318 * be reflected from the given mapsquare. Returns 1 if true.
396 * eg, updated for tiled maps. 322 * eg, updated for tiled maps.
397 */ 323 */
398int 324int
399reflwall (maptile *m, int x, int y, object *sp_op) 325reflwall (maptile *m, int x, int y, object *sp_op)
400{ 326{
401 object *op;
402
403 if (OUT_OF_REAL_MAP (m, x, y)) 327 if (OUT_OF_REAL_MAP (m, x, y))
404 return 0; 328 return 0;
329
405 for (op = GET_MAP_OB (m, x, y); op != NULL; op = op->above) 330 for (object *op = GET_MAP_OB (m, x, y); op; op = op->above)
406 if (QUERY_FLAG (op, FLAG_REFL_SPELL) 331 if (op->flag [FLAG_REFL_SPELL]
407 && (!QUERY_FLAG (op, FLAG_ALIVE) 332 && (!op->flag [FLAG_ALIVE]
408 || (rndm (0, 99)) < 90 - (sp_op->level / 10))) 333 || (rndm (0, 99)) < 90 - (sp_op->level / 10)))
409 return 1; 334 return 1;
410 335
411 return 0; 336 return 0;
412} 337}
413 338
414/* cast_create_object: creates object new_op in direction dir 339/* cast_create_object: creates object new_op in direction dir
415 * or if that is blocked, beneath the player (op). 340 * or if that is blocked, beneath the player (op).
416 * we pass 'caster', but don't use it for anything. 341 * we pass 'caster', but don't use it for anything.
417 * This is really just a simple wrapper function . 342 * This is really just a simple wrapper function .
418 * returns the direction that the object was actually placed 343 * returns true to indicate whether the operation was successful.
419 * in. 344 * destroys the object is unsuccessful.
420 */ 345 */
421int 346bool
422cast_create_obj (object *op, object *caster, object *new_op, int dir) 347cast_create_obj (object *op, object *caster, object *new_op, int dir)
423{ 348{
424 maptile *m; 349 mapxy pos (op);
425 sint16 sx, sy; 350 pos.move (dir);
426 351
427 if (dir && 352 if (!pos.normalise ()
428 ((get_map_flags (op->map, &m, op->x + freearr_x[dir], op->y + freearr_y[dir], &sx, &sy) & P_OUT_OF_MAP) || 353 || pos->blocks (op) // perversely enough, we check if the palyer can reach that space
429 OB_TYPE_MOVE_BLOCK (op, GET_MAP_MOVE_BLOCK (m, sx, sy)))) 354 || !new_op->can_drop_at (pos.m, pos.x, pos.y)
430 { 355 )
431 new_draw_info (NDI_UNIQUE, 0, op, "Something is in the way.");
432 new_draw_info (NDI_UNIQUE, 0, op, "You cast it at your feet.");
433 dir = 0;
434 } 356 {
357 op->failmsg ("Your spell fizzles! H<Something is in the way.>");
358 new_op->destroy ();
359 return 0;
360 }
435 361
436 SET_FLAG (new_op, FLAG_IDENTIFIED); 362 new_op->set_flag (FLAG_IDENTIFIED);
437 op->map->insert (new_op,
438 op->x + freearr_x[dir], op->y + freearr_y[dir],
439 op,
440 dir ? 0 : INS_BELOW_ORIGINATOR);
441 363
364 pos.insert (new_op, op, dir ? 0 : INS_BELOW_ORIGINATOR);
365
442 return dir; 366 return 1;
367}
368
369static bool
370mergable_owner (object *o1, object *o2)
371{
372 if (o1 == o2)
373 return 1;
374
375 if (!o1 || !o2)
376 return 0;
377
378 if (o1->flag [FLAG_FRIENDLY] != o1->flag [FLAG_FRIENDLY])
379 return 0;
380
381 if (o1->is_player () || o2->is_player ())
382 return 0;
383
384 return 1;
443} 385}
444 386
445/* Returns true if it is ok to put spell *op on the space/may provided. 387/* Returns true if it is ok to put spell *op on the space/may provided.
446 * immune_stop is basically the attacktype of the spell (why 388 * immune_stop is basically the attacktype of the spell (why
447 * passed as a different value, not sure of). If immune_stop 389 * passed as a different value, not sure of). If immune_stop
448 * has the AT_MAGIC bit set, and there is a counterwall 390 * has the AT_MAGIC bit set, and there is a counterwall
449 * on the space, the object doesn't get placed. if immune stop 391 * on the space, the object doesn't get placed. if immune stop
450 * does not have AT_MAGIC, then counterwalls do not effect the spell. 392 * does not have AT_MAGIC, then counterwalls do not effect the spell.
451 *
452 */ 393 */
453int 394int
454ok_to_put_more (maptile *m, sint16 x, sint16 y, object *op, int immune_stop) 395ok_to_put_more (maptile *m, sint16 x, sint16 y, object *op, int immune_stop)
455{ 396{
456 if (!xy_normalise (m, x, y)) 397 if (!xy_normalise (m, x, y))
457 return 0; 398 return 0;
458 399
459 mapspace &ms = m->at (x, y); 400 mapspace &ms = m->at (x, y);
401 ms.update ();
460 402
461 if (OB_TYPE_MOVE_BLOCK (op, ms.move_block)) 403 if (OB_TYPE_MOVE_BLOCK (op, ms.move_block))
462 return 0; 404 return 0;
463 405
406 int max_effects = 5; // max. number of similar spells per mapspace
407
464 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 408 for (object *tmp = ms.top; tmp; tmp = tmp->below)
465 { 409 {
466 /* If there is a counterspell on the space, and this 410 /* If there is a counterspell on the space, and this
467 * object is using magic, don't progress. I believe we could 411 * object is using magic, don't progress. I believe we could
468 * leave this out and let in progress, and other areas of the code 412 * leave this out and let in progress, and other areas of the code
469 * will then remove it, but that would seem to to use more 413 * will then remove it, but that would seem to to use more
471 * on top of a counterwall spell (may hit the player before being 415 * on top of a counterwall spell (may hit the player before being
472 * removed.) On the other hand, it may be more dramatic for the 416 * removed.) On the other hand, it may be more dramatic for the
473 * spell to actually hit the counterwall and be sucked up. 417 * spell to actually hit the counterwall and be sucked up.
474 */ 418 */
475 if ((tmp->attacktype & AT_COUNTERSPELL) 419 if ((tmp->attacktype & AT_COUNTERSPELL)
476 && !QUERY_FLAG (tmp, FLAG_MONSTER) 420 && !tmp->flag [FLAG_MONSTER]
477 && (tmp->type != PLAYER) 421 && (tmp->type != PLAYER)
478 && (tmp->type != WEAPON) 422 && (tmp->type != WEAPON)
479 && (tmp->type != BOW) 423 && (tmp->type != BOW)
480 && (tmp->type != ARROW) 424 && (tmp->type != ARROW)
481 && (tmp->type != GOLEM) 425 && (tmp->type != GOLEM)
482 && !QUERY_FLAG (tmp, FLAG_IS_FLOOR) // XXX: 426 && !tmp->flag [FLAG_IS_FLOOR] // XXX:
483 // we special case floor here because there 427 // we special case floor here because there
484 // are sometimes spell effect floors 428 // are sometimes spell effect floors
485 // which are used to inflict damage 429 // which are used to inflict damage
486 // (and those shouldn't go away from 430 // (and those shouldn't go away from
487 // sanctuary) see also: permanent lava 431 // sanctuary) see also: permanent lava
488 && (immune_stop & AT_MAGIC)) 432 && (immune_stop & AT_MAGIC))
489 return 0; 433 return 0;
490 434
491 /* This is to prevent 'out of control' spells. Basically, this
492 * limits one spell effect per space per spell. This is definately
493 * needed for performance reasons, and just for playability I believe.
494 * there are no such things as multispaced spells right now, so
495 * we don't need to worry about the head.
496 */
497 if ((tmp->stats.maxhp == op->stats.maxhp) && (tmp->type == op->type) && (tmp->subtype == op->subtype))
498 return 0;
499
500 /*
501 * Combine similar spell effects into one spell effect. Needed for
502 * performance reasons with meteor swarm and the like, but also for
503 * playability reasons.
504 */
505 if (tmp->arch == op->arch
506 && tmp->type == op->type 435 if (tmp->type == op->type)
507 && tmp->subtype == op->subtype
508 && tmp->owner == op->owner
509 && ((tmp->subtype == SP_EXPLOSION) || (tmp->subtype == SP_CONE && tmp->stats.sp == op->stats.sp)))
510 { 436 {
511 tmp->stats.dam = MAX (tmp->stats.dam, op->stats.dam); 437 if (tmp->subtype == op->subtype
512 tmp->range = MAX (tmp->range, op->range); 438 && tmp->arch == op->arch /* no harm if not comparing by name here */)
513 tmp->duration = MAX (tmp->duration, op->duration); 439 {
440 /* This is to prevent 'out of control' spells. Basically, this
441 * limits one spell effect per space per spell. This is definately
442 * needed for performance reasons, and just for playability I believe.
443 * there are no such things as multispaced spells right now, so
444 * we don't need to worry about the head.
445 */
446 if (tmp->stats.maxhp == op->stats.maxhp)
447 return 0;
448
449 /*
450 * Combine similar spell effects into one spell effect. Needed for
451 * performance reasons with meteor swarm and the like, but also for
452 * playability reasons.
453 */
454 if (((tmp->subtype == SP_EXPLOSION) || (tmp->subtype == SP_CONE && tmp->stats.sp == op->stats.sp)))
455 if (mergable_owner (tmp, op))
456 {
457 // if same owner, then combine, but reduce advantage of multiple spells
458 max_it (tmp->stats.dam, op->stats.dam);
459 max_it (tmp->range , op->range);
460 max_it (tmp->duration , op->duration);
461 return 0;
462 }
463 }
464
465 // if there are too many spell effects on this space,
466 // then don't allow more of them, for performance reasons.
467 if (tmp->type == SPELL_EFFECT
468 && !--max_effects)
514 return 0; 469 return 0;
515 } 470 }
516 471
517 /* Perhaps we should also put checks in for no magic and unholy 472 /* Perhaps we should also put checks in for no magic and unholy
518 * ground to prevent it from moving along? 473 * ground to prevent it from moving along?
519 */ 474 */
534 * returns 0 on failure, 1 on success. 489 * returns 0 on failure, 1 on success.
535 */ 490 */
536int 491int
537fire_arch_from_position (object *op, object *caster, sint16 x, sint16 y, int dir, object *spell) 492fire_arch_from_position (object *op, object *caster, sint16 x, sint16 y, int dir, object *spell)
538{ 493{
539 object *tmp;
540 int mflags;
541 maptile *m;
542
543 if (spell->other_arch == NULL) 494 if (!spell->other_arch)
544 return 0; 495 return 0;
545 496
546 m = op->map; 497 object *tmp = spell->other_arch->instance ();
547 mflags = get_map_flags (m, &m, x, y, &x, &y);
548 if (mflags & P_OUT_OF_MAP)
549 {
550 return 0;
551 }
552 498
553 tmp = arch_to_object (spell->other_arch); 499 if (!tmp)
554
555 if (tmp == NULL)
556 return 0; 500 return 0;
557
558 if (OB_TYPE_MOVE_BLOCK (tmp, GET_MAP_MOVE_BLOCK (m, x, y)))
559 {
560 new_draw_info (NDI_UNIQUE, 0, op, "You can't cast the spell on top of a wall!\n");
561 tmp->destroy ();
562 return 0;
563 }
564 501
565 tmp->stats.dam = spell->stats.dam + SP_level_dam_adjust (caster, spell); 502 tmp->stats.dam = spell->stats.dam + SP_level_dam_adjust (caster, spell);
566 tmp->duration = spell->duration + SP_level_duration_adjust (caster, spell); 503 tmp->duration = spell->duration + SP_level_duration_adjust (caster, spell);
567 /* code in time.c uses food for some things, duration for others */ 504 /* code in time.c uses food for some things, duration for others */
568 tmp->stats.food = tmp->duration; 505 tmp->stats.food = tmp->duration;
569 tmp->range = spell->range + SP_level_range_adjust (caster, spell); 506 tmp->range = spell->range + SP_level_range_adjust (caster, spell);
570 tmp->attacktype = spell->attacktype; 507 tmp->attacktype = spell->attacktype;
571 tmp->x = x;
572 tmp->y = y;
573 tmp->direction = dir; 508 tmp->direction = dir;
574 if (op->owner != NULL)
575 tmp->set_owner (op); 509 tmp->set_owner (op);
576 else
577 tmp->set_owner (op);
578 tmp->level = caster_level (caster, spell); 510 tmp->level = casting_level (caster, spell);
579 set_spell_skill (op, caster, spell, tmp); 511 set_spell_skill (op, caster, spell, tmp);
580 512
581 /* needed for AT_HOLYWORD,AT_GODPOWER stuff */ 513 /* needed for AT_HOLYWORD,AT_GODPOWER stuff */
582 if (tmp->attacktype & AT_HOLYWORD || tmp->attacktype & AT_GODPOWER) 514 if (tmp->attacktype & AT_HOLYWORD || tmp->attacktype & AT_GODPOWER)
583 {
584 if (!tailor_god_spell (tmp, op)) 515 if (!tailor_god_spell (tmp, op))
585 return 0; 516 return 0;
586 } 517
587 if (QUERY_FLAG (tmp, FLAG_IS_TURNABLE)) 518 if (tmp->flag [FLAG_IS_TURNABLE])
588 SET_ANIMATION (tmp, dir); 519 SET_ANIMATION (tmp, dir);
589 520
590 if ((tmp = insert_ob_in_map (tmp, m, op, 0))) 521 if ((tmp = op->map->insert (tmp, x, y, op)))
591 move_spell_effect (tmp); 522 move_spell_effect (tmp);
592 523
593 return 1; 524 return 1;
594} 525}
595 526
600 ****************************************************************************/ 531 ****************************************************************************/
601void 532void
602regenerate_rod (object *rod) 533regenerate_rod (object *rod)
603{ 534{
604 if (rod->stats.hp < rod->stats.maxhp) 535 if (rod->stats.hp < rod->stats.maxhp)
605 rod->stats.hp = min (rod->stats.maxhp, rod->stats.hp + 1 + rod->stats.maxhp / 10); 536 rod->stats.hp = min (rod->stats.maxhp, rod->stats.hp + 1 + rod->stats.maxhp / 20);
606} 537}
607 538
608void 539void
609drain_rod_charge (object *rod) 540drain_rod_charge (object *rod)
610{ 541{
630 { 561 {
631 tmp = op->owner; 562 tmp = op->owner;
632 /* If the owner does not exist, or is not a monster, than apply the spell 563 /* If the owner does not exist, or is not a monster, than apply the spell
633 * to the caster. 564 * to the caster.
634 */ 565 */
635 if (!tmp || !QUERY_FLAG (tmp, FLAG_MONSTER)) 566 if (!tmp || !tmp->flag [FLAG_MONSTER])
636 tmp = op; 567 tmp = op;
637 } 568 }
638 else 569 else
639 { 570 {
640 maptile *m = op->map; 571 maptile *m = op->map;
650 if (!tmp) 581 if (!tmp)
651 tmp = op->ms ().player (); 582 tmp = op->ms ().player ();
652 583
653 return tmp; 584 return tmp;
654} 585}
655
656
657 586
658/* raytrace: 587/* raytrace:
659 * spell_find_dir(map, x, y, exclude) will search first the center square 588 * spell_find_dir(map, x, y, exclude) will search first the center square
660 * then some close squares in the given map at the given coordinates for 589 * then some close squares in the given map at the given coordinates for
661 * live objects. 590 * live objects.
664 * monsters/generators only. If not, the spell will hunt players only. 593 * monsters/generators only. If not, the spell will hunt players only.
665 * It returns the direction toward the first/closest live object if it finds 594 * It returns the direction toward the first/closest live object if it finds
666 * any, otherwise -1. 595 * any, otherwise -1.
667 * note that exclude can be NULL, in which case all bets are off. 596 * note that exclude can be NULL, in which case all bets are off.
668 */ 597 */
669
670int 598int
671spell_find_dir (maptile *m, int x, int y, object *exclude) 599spell_find_dir (maptile *m, int x, int y, object *exclude)
672{ 600{
673 int i, max = SIZEOFFREE; 601 int i, max = SIZEOFFREE;
674 sint16 nx, ny; 602 sint16 nx, ny;
691 continue; 619 continue;
692 620
693 tmp = GET_MAP_OB (mp, nx, ny); 621 tmp = GET_MAP_OB (mp, nx, ny);
694 622
695 while (tmp != NULL && (((owner_type == PLAYER && 623 while (tmp != NULL && (((owner_type == PLAYER &&
696 !QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_GENERATOR)) || 624 !tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_GENERATOR]) ||
697 (owner_type != PLAYER && tmp->type != PLAYER)) || (tmp == exclude || (tmp->head && tmp->head == exclude)))) 625 (owner_type != PLAYER && tmp->type != PLAYER)) || (tmp == exclude || (tmp->head && tmp->head == exclude))))
698 tmp = tmp->above; 626 tmp = tmp->above;
699 627
700 if (tmp != NULL && can_see_monsterP (m, x, y, i)) 628 if (tmp != NULL && can_see_monsterP (m, x, y, i))
701 return freedir[i]; 629 return freedir[i];
705 633
706/* put_a_monster: puts a monster named monstername near by 634/* put_a_monster: puts a monster named monstername near by
707 * op. This creates the treasures for the monsters, and 635 * op. This creates the treasures for the monsters, and
708 * also deals with multipart monsters properly. 636 * also deals with multipart monsters properly.
709 */ 637 */
710void 638static void
711put_a_monster (object *op, const char *monstername) 639put_a_monster (object *op, const char *monstername)
712{ 640{
713 object *tmp, *head = NULL, *prev = NULL; 641 object *tmp, *head = NULL, *prev = NULL;
714 archetype *at; 642 archetype *at;
715 int dir; 643 int dir;
730 * insert multipart monsters properly 658 * insert multipart monsters properly
731 */ 659 */
732 //TODO: use expand_tail + ... 660 //TODO: use expand_tail + ...
733 while (at != NULL) 661 while (at != NULL)
734 { 662 {
735 tmp = arch_to_object (at); 663 tmp = at->instance ();
736 tmp->x = op->x + freearr_x[dir] + at->x; 664 tmp->x = op->x + freearr_x[dir] + at->x;
737 tmp->y = op->y + freearr_y[dir] + at->y; 665 tmp->y = op->y + freearr_y[dir] + at->y;
738 tmp->map = op->map; 666 tmp->map = op->map;
739 if (head) 667 if (head)
740 { 668 {
754 create_treasure (head->randomitems, head, GT_INVISIBLE, op->map->difficulty, 0); 682 create_treasure (head->randomitems, head, GT_INVISIBLE, op->map->difficulty, 0);
755 683
756 insert_ob_in_map (head, op->map, op, 0); 684 insert_ob_in_map (head, op->map, op, 0);
757 685
758 /* thought it'd be cool to insert a burnout, too. */ 686 /* thought it'd be cool to insert a burnout, too. */
759 op->map->insert (get_archetype ("burnout"), op->x + freearr_x[dir], op->y + freearr_y[dir], op); 687 op->map->insert (archetype::get (shstr_burnout), op->x + freearr_x[dir], op->y + freearr_y[dir], op);
760 } 688 }
761} 689}
762 690
763/* peterm: function which summons hostile monsters and 691/* peterm: function which summons hostile monsters and
764 * places them in nearby squares. 692 * places them in nearby squares.
771 * Note that this is not used by any spells (summon evil monsters 699 * Note that this is not used by any spells (summon evil monsters
772 * use to call this, but best I can tell, that spell/ability was 700 * use to call this, but best I can tell, that spell/ability was
773 * never used. This is however used by various failures on the 701 * never used. This is however used by various failures on the
774 * players part (alchemy, reincarnation, etc) 702 * players part (alchemy, reincarnation, etc)
775 */ 703 */
776
777int 704int
778summon_hostile_monsters (object *op, int n, const char *monstername) 705summon_hostile_monsters (object *op, int n, const char *monstername)
779{ 706{
780 int i; 707 int i;
781 708
846 { 773 {
847 SET_ANIMATION (op, ATTACKS[i].face); 774 SET_ANIMATION (op, ATTACKS[i].face);
848 } 775 }
849} 776}
850 777
851
852/* prayer_failure: This is called when a player fails 778/* prayer_failure: This is called when a player fails
853 * at casting a prayer. 779 * at casting a prayer.
854 * op is the player. 780 * op is the player.
855 * failure is basically how much grace they had. 781 * failure is basically how much grace they had.
856 * power is how much grace the spell would normally take to cast. 782 * power is how much grace the spell would normally take to cast.
857 */ 783 */
858 784
859void 785#define HINT_GRACE " H<Make sure you always have enough grace points for your prayers.>"
786
787static void
860prayer_failure (object *op, int failure, int power) 788prayer_failure (object *op, int failure, int power)
861{ 789{
862 const char *godname; 790 const char *godname;
863 object *tmp; 791 object *tmp;
864 792
865 if (!strcmp ((godname = determine_god (op)), "none")) 793 if (!strcmp ((godname = determine_god (op)), "none"))
866 godname = "Your spirit"; 794 godname = "Your spirit";
867 795
868 if (failure <= -20 && failure > -40) /* wonder */ 796 if (failure <= -20 && failure > -40) /* wonder */
869 { 797 {
870 new_draw_info_format (NDI_UNIQUE, 0, op, "%s gives a sign to renew your faith.", godname); 798 op->failmsgf ("%s gives a sign to renew your faith." HINT_GRACE, godname);
871 tmp = get_archetype (SPELL_WONDER); 799 tmp = archetype::get (SPELL_WONDER);
872 cast_cone (op, op, 0, tmp); 800 cast_cone (op, op, 0, tmp);
873 tmp->destroy (); 801 tmp->destroy ();
874 } 802 }
875 803
876 else if (failure <= -40 && failure > -60) /* confusion */ 804 else if (failure <= -40 && failure > -60) /* confusion */
877 { 805 {
878 new_draw_info (NDI_UNIQUE, 0, op, "Your diety touches your mind!"); 806 op->failmsg ("Your diety touches your mind!" HINT_GRACE);
879 confuse_player (op, op, 99); 807 confuse_player (op, op, 99);
880 } 808 }
881 else if (failure <= -60 && failure > -150) /* paralysis */ 809 else if (failure <= -60 && failure > -150) /* paralysis */
882 { 810 {
883 new_draw_info_format (NDI_UNIQUE, 0, op, "%s requires you to pray NOW.", godname); 811 op->failmsgf ("%s requires you to pray NOW. "
884 new_draw_info (NDI_UNIQUE, 0, op, "You comply, ignoring all else."); 812 "You comply, ignoring all else." HINT_GRACE,
813 godname);
885 paralyze_player (op, op, 99); 814 paralyze_player (op, op, 99);
886 } 815 }
887 else if (failure <= -150) /* blast the immediate area */ 816 else if (failure <= -150) /* blast the immediate area */
888 { 817 {
889 tmp = get_archetype (GOD_POWER); 818 tmp = archetype::get (GOD_POWER);
890 new_draw_info_format (NDI_UNIQUE, 0, op, "%s smites you!", godname); 819 op->failmsgf ("%s smites you!" HINT_GRACE, godname);
891 cast_magic_storm (op, tmp, power); 820 cast_magic_storm (op, tmp, power);
892 } 821 }
893} 822}
894 823
895/* 824/*
896 * spell_failure() handles the various effects for differing degrees 825 * spell_failure() handles the various effects for differing degrees
897 * of failure badness. 826 * of failure badness.
898 * op is the player that failed. 827 * op is the player that failed.
899 * failure is a random value of how badly you failed. 828 * failure is a random value of how badly you failed.
900 * power is how many spellpoints you'd normally need for the spell. 829 * power is how many spellpoints you'd normally need for the spell.
901 * skill is the skill you'd need to cast the spell. 830 * skill is the skill you'd need to cast the spell.
902 */ 831 */
903
904void 832void
905spell_failure (object *op, int failure, int power, object *skill) 833spell_failure (object *op, int failure, int power, object *skill)
906{ 834{
907 object *tmp; 835 object *tmp;
908 836
909 if (settings.spell_failure_effects == FALSE) 837 if (settings.spell_failure_effects == FALSE)
910 return; 838 return;
911 839
912 if (failure <= -20 && failure > -40) /* wonder */ 840 if (failure <= -20 && failure > -40) /* wonder */
913 { 841 {
914 new_draw_info (NDI_UNIQUE, 0, op, "Your spell causes an unexpected effect."); 842 op->failmsg ("Your spell causes an unexpected effect.");
915 tmp = get_archetype (SPELL_WONDER); 843 tmp = archetype::get (SPELL_WONDER);
916 cast_cone (op, op, 0, tmp); 844 cast_cone (op, op, 0, tmp);
917 tmp->destroy (); 845 tmp->destroy ();
918 } 846 }
919 847
920 else if (failure <= -40 && failure > -60) /* confusion */ 848 else if (failure <= -40 && failure > -60) /* confusion */
921 { 849 {
922 new_draw_info (NDI_UNIQUE, 0, op, "Your magic recoils on you, making you confused!"); 850 op->failmsg ("Your magic recoils on you, making you confused!");
923 confuse_player (op, op, 99); 851 confuse_player (op, op, 99);
924 } 852 }
925 else if (failure <= -60 && failure > -80) /* paralysis */ 853 else if (failure <= -60 && failure > -80) /* paralysis */
926 { 854 {
927 new_draw_info (NDI_UNIQUE, 0, op, "Your magic stuns you!"); 855 op->failmsg ("Your magic stuns you!");
928 paralyze_player (op, op, 99); 856 paralyze_player (op, op, 99);
929 } 857 }
930 else if (failure <= -80) /* blast the immediate area */ 858 else if (failure <= -80) /* blast the immediate area */
931 { 859 {
932 object *tmp; 860 object *tmp;
933 861
934 /* Safety check to make sure we don't get any mana storms in scorn */ 862 /* Safety check to make sure we don't get any mana storms in scorn */
935 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC) 863 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)
936 { 864 {
937 new_draw_info (NDI_UNIQUE, 0, op, "The magic warps and you are turned inside out!"); 865 op->failmsg ("The magic warps and you are turned inside out!");
938 hit_player (op, 9998, op, AT_INTERNAL, 1); 866 hit_player (op, 9998, op, AT_INTERNAL, 1);
939 867
940 } 868 }
941 else 869 else
942 { 870 {
943 new_draw_info (NDI_UNIQUE, 0, op, "You lose control of the mana! The uncontrolled magic blasts you!"); 871 op->failmsg ("You lose control of the mana! The uncontrolled magic blasts you!");
944 tmp = get_archetype (LOOSE_MANA); 872 tmp = archetype::get (LOOSE_MANA);
945 tmp->level = skill->level; 873 tmp->level = skill->level;
946 874
947 /* increase the area of destruction a little for more powerful spells */ 875 /* increase the area of destruction a little for more powerful spells */
948 tmp->range += isqrt (power); 876 tmp->range += isqrt (power);
949 877
957 tmp->insert_at (op); 885 tmp->insert_at (op);
958 } 886 }
959 } 887 }
960} 888}
961 889
962int 890static int
963cast_party_spell (object *op, object *caster, int dir, object *spell_ob, char *stringarg) 891cast_party_spell (object *op, object *caster, int dir, object *spell_ob, char *spellparam)
964{ 892{
965 int success;
966 object *spell;
967
968 if (!spell_ob->other_arch) 893 if (!spell_ob->other_arch)
969 { 894 {
970 LOG (llevError, "cast_party_spell: empty other arch\n"); 895 LOG (llevError, "cast_party_spell: empty other arch\n");
971 return 0; 896 return 0;
972 } 897 }
973 898
974 spell = arch_to_object (spell_ob->other_arch); 899 object *spell = spell_ob->other_arch->instance ();
975 900
976 /* Always cast spell on caster */ 901 /* Always cast spell on caster */
977 success = cast_spell (op, caster, dir, spell, stringarg); 902 int success = cast_spell (op, caster, dir, spell, spellparam);
978 903
979 if (caster->contr->party == NULL) 904 if (!op->contr || !op->contr->party)
980 { 905 {
981 spell->remove (); 906 spell->remove ();
982 return success; 907 return success;
983 } 908 }
984 909
985 for_all_players (pl) 910 for_all_players (pl)
986 if ((pl->ob->contr->party == caster->contr->party) && (on_same_map (pl->ob, caster))) 911 if ((pl->ob->contr->party == op->contr->party)
912 && on_same_map (pl->ob, op)
913 && pl->ob != op)
987 cast_spell (pl->ob, caster, pl->ob->facing, spell, stringarg); 914 cast_spell (pl->ob, caster, pl->ob->facing, spell, spellparam);
988 915
989 spell->remove (); 916 spell->remove ();
990 return success; 917 return success;
991} 918}
992 919
998 * same as op. 925 * same as op.
999 * dir is the direction to cast in. Note in some cases, if the spell 926 * dir is the direction to cast in. Note in some cases, if the spell
1000 * is self only, dir really doesn't make a difference. 927 * is self only, dir really doesn't make a difference.
1001 * spell_ob is the spell object that is being cast. From that, 928 * spell_ob is the spell object that is being cast. From that,
1002 * we can determine what to do. 929 * we can determine what to do.
1003 * stringarg is any options that are being used. It can be NULL. Almost 930 * spellparam is any options that are being used. It can be NULL. Almost
1004 * certainly, only players will set it. It is basically used as optional 931 * certainly, only players will set it. It is basically used as optional
1005 * parameters to a spell (eg, item to create, information for marking runes, 932 * parameters to a spell (eg, item to create, information for marking runes,
1006 * etc. 933 * etc.
1007 * returns 1 on successful cast, or 0 on error. These values should really 934 * returns 1 on successful cast, or 0 on error. These values should really
1008 * be swapped, so that 0 is successful, and non zero is failure, with a code 935 * be swapped, so that 0 is successful, and non zero is failure, with a code
1016 * if it is a player casting the spell (op->type == PLAYER, op == caster), 943 * if it is a player casting the spell (op->type == PLAYER, op == caster),
1017 * this function will decrease the mana/grace appropriately. For other 944 * this function will decrease the mana/grace appropriately. For other
1018 * objects, the caller should do what it considers appropriate. 945 * objects, the caller should do what it considers appropriate.
1019 */ 946 */
1020int 947int
1021cast_spell (object *op, object *caster, int dir, object *spell_ob, char *stringarg) 948cast_spell (object *op, object *caster, int dir, object *spell_ob, char *spellparam)
1022{ 949{
1023 const char *godname; 950 const char *godname;
1024 int success = 0, cast_level = 0; 951 int success = 0;
1025 object *skill = NULL; 952
953 // make sure spells always take a while, so a) we don't flood the
954 // user with messages and b) too many failures can be harmful (smiting).
955 op->speed_left -= 4 * op->speed; // ~0.5s on failure
1026 956
1027 if (!spell_ob) 957 if (!spell_ob)
1028 { 958 {
1029 LOG (llevError, "cast_spell: null spell object passed\n"); 959 LOG (llevError, "cast_spell: null spell object passed\n");
1030 return 0; 960 return 0;
1041 } 971 }
1042 972
1043 /* if caster is a spell casting object, this normally shouldn't be 973 /* if caster is a spell casting object, this normally shouldn't be
1044 * an issue, because they don't have any spellpaths set up. 974 * an issue, because they don't have any spellpaths set up.
1045 */ 975 */
1046 if (caster->path_denied & spell_ob->path_attuned && !QUERY_FLAG (caster, FLAG_WIZCAST)) 976 if (caster->path_denied & spell_ob->path_attuned && !caster->flag [FLAG_WIZCAST])
1047 { 977 {
1048 new_draw_info (NDI_UNIQUE, 0, op, "That spell path is denied to you."); 978 op->failmsg ("That spell path is denied to you.");
1049 return 0; 979 return 0;
1050 } 980 }
981
982 object *skill = 0;
1051 983
1052 /* if it is a player casting the spell, and they are really casting it 984 /* if it is a player casting the spell, and they are really casting it
1053 * (vs it coming from a wand, scroll, or whatever else), do some 985 * (vs it coming from a wand, scroll, or whatever else), do some
1054 * checks. We let monsters do special things - eg, they 986 * checks. We let monsters do special things - eg, they
1055 * don't need the skill, bypass level checks, etc. The monster function 987 * don't need the SKILL, BYpass level checks, etc. The monster function
1056 * should take care of that. 988 * should take care of that.
1057 * Remove the wiz check here and move it further down - some spells 989 * Remove the wiz check here and move it further down - some spells
1058 * need to have the right skill pointer passed, so we need to 990 * need to have the right skill pointer passed, so we need to
1059 * at least process that code. 991 * at least process that code.
1060 */ 992 */
1061 if (op->type == PLAYER && op == caster) 993 if (op->type == PLAYER && op == caster)
1062 { 994 {
1063 cast_level = caster_level (caster, spell_ob);
1064
1065 if (spell_ob->skill) 995 if (spell_ob->skill)
1066 { 996 {
1067 skill = find_skill_by_name (op, spell_ob->skill); 997 skill = find_skill_by_name (op, spell_ob->skill);
1068 998
1069 if (!skill) 999 if (!skill)
1070 { 1000 {
1071 op->failmsg (format ("You need the skill %s to cast %s!", &spell_ob->skill, &spell_ob->name)); 1001 op->failmsgf ("You need the %s skill to cast %s! "
1002 "H<You either need to learn the skill via a skill scroll "
1003 "or you need to wear a talisman, holy symbol or another skill tool.>",
1004 &spell_ob->skill, &spell_ob->name);
1072 return 0; 1005 return 0;
1073 } 1006 }
1074 1007
1075 if (min_casting_level (op, spell_ob) > cast_level && !QUERY_FLAG (op, FLAG_WIZ)) 1008 const char *msg = "";
1009
1010 int caster_level = skill->level;
1011
1012 if (op->path_attuned & spell_ob->path_attuned)
1076 { 1013 {
1014 caster_level += min (caster_level, ATTUNE_REPELL);
1015 msg = " (attuned)";
1016 }
1017
1018 if (op->path_repelled & spell_ob->path_attuned)
1019 {
1020 caster_level -= ATTUNE_REPELL; // negative is ok
1021 msg = " (repelled)";
1022 }
1023
1024 if (spell_ob->level > caster_level)
1025 {
1077 op->failmsg ("You lack enough skill to cast that spell!"); 1026 op->failmsgf ("You lack enough skill to cast that spell! "
1027 "H<Your effective cast level is %d%s, but level %d is required.>",
1028 caster_level, msg, spell_ob->level);
1029 if (!op->is_wiz ())
1078 return 0; 1030 return 0;
1079 } 1031 }
1080 } 1032 }
1081 1033
1082 /* If the caster is the wiz, they don't ever fail, and don't have 1034 /* If the caster is the wiz, they don't ever fail, and don't have
1083 * to have sufficient grace/mana. 1035 * to have sufficient grace/mana.
1084 */ 1036 */
1085 if (!QUERY_FLAG (op, FLAG_WIZ)) 1037 if (!op->flag [FLAG_WIZCAST])
1086 { 1038 {
1087 if (SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) && 1039 if (SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) &&
1088 SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) > op->stats.sp) 1040 SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) > op->stats.sp)
1089 { 1041 {
1090 op->failmsg ("You don't have enough mana!"); 1042 op->failmsg ("You don't have enough mana!");
1098 10 * SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) / op->stats.maxgrace > 0) 1050 10 * SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) / op->stats.maxgrace > 0)
1099 op->statusmsg (format ("%s grants your prayer, though you are unworthy.", godname)); 1051 op->statusmsg (format ("%s grants your prayer, though you are unworthy.", godname));
1100 else 1052 else
1101 { 1053 {
1102 prayer_failure (op, op->stats.grace, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) - op->stats.grace); 1054 prayer_failure (op, op->stats.grace, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) - op->stats.grace);
1103 op->failmsg (format ("%s ignores your prayer.", godname)); 1055 op->failmsgf ("%s ignores your prayer.", godname);
1104 return 0; 1056 return 0;
1105 } 1057 }
1106 } 1058 }
1107 1059
1108 /* player/monster is trying to cast the spell. might fumble it */ 1060 /* player/monster is trying to cast the spell. might fumble it */
1109 if (spell_ob->stats.grace && random_roll (0, 99, op, PREFER_HIGH) < 1061 if (spell_ob->stats.grace && random_roll (0, 99, op, PREFER_HIGH) <
1110 (spell_ob->level / (float) MAX (1, op->level) * cleric_chance[op->stats.Wis])) 1062 (spell_ob->level / (float) max (1, op->level) * cleric_chance[op->stats.Wis]))
1111 { 1063 {
1112 op->contr->play_sound (sound_find ("fumble_spell")); 1064 op->contr->play_sound (sound_find ("fumble_spell"));
1113 op->failmsg ("You fumble the prayer."); 1065 op->failmsg ("You fumble the prayer.");
1114 1066
1115 op->stats.grace -= random_roll (1, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE), op, PREFER_LOW); 1067 op->stats.grace -= random_roll (1, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE), op, PREFER_LOW);
1138 * not alive, then this would mean that the mapmaker put the 1090 * not alive, then this would mean that the mapmaker put the
1139 * objects on the space - presume that they know what they are 1091 * objects on the space - presume that they know what they are
1140 * doing. 1092 * doing.
1141 */ 1093 */
1142 1094
1143 if ((mflags & P_SAFE) && !QUERY_FLAG (op, FLAG_WIZCAST)) // There is _ABSOLUTELY_ no magic allowed here (except wizards :-)! 1095 if ((mflags & P_SAFE) && !op->flag [FLAG_WIZCAST]) // There is _ABSOLUTELY_ no magic allowed here (except wizards :-)!
1144 { 1096 {
1097 op->speed_left -= 2 * op->speed; // freeze for two ticks, so we don't flood
1145 op->failmsg ("This ground is sacred! The gods prevent any magical effects done by you here!"); 1098 op->failmsg ("This ground is sacred! The gods prevent any magical effects done by you here!");
1146 return 0; 1099 return 0;
1147 } 1100 }
1148 1101
1149 if ((spell_ob->type == SPELL) 1102 if ((spell_ob->type == SPELL)
1150 && (caster->type != POTION) 1103 && (caster->type != POTION)
1151 && !QUERY_FLAG (op, FLAG_WIZCAST) 1104 && !op->flag [FLAG_WIZCAST]
1152 && (QUERY_FLAG (caster, FLAG_ALIVE) 1105 && (caster->flag [FLAG_ALIVE]
1153 || QUERY_FLAG (op, FLAG_ALIVE)) 1106 || op->flag [FLAG_ALIVE])
1154 && (((mflags & P_NO_MAGIC) && spell_ob->stats.sp) || ((mflags & P_NO_CLERIC) && spell_ob->stats.grace))) 1107 && (((mflags & P_NO_MAGIC) && spell_ob->stats.sp) || ((mflags & P_NO_CLERIC) && spell_ob->stats.grace)))
1155 { 1108 {
1156 if (op->type != PLAYER) 1109 if (op->type != PLAYER)
1157 return 0; 1110 return 0;
1158 1111
1159 if ((mflags & P_NO_CLERIC) && spell_ob->stats.grace) 1112 if ((mflags & P_NO_CLERIC) && spell_ob->stats.grace)
1160 op->failmsg (format ("This ground is unholy! %s ignores you.", godname)); 1113 op->failmsgf ("This ground is unholy! %s ignores you.", godname);
1161 else if (object *item = op->contr->ranged_ob) 1114 else if (object *item = op->contr->ranged_ob)
1162 { 1115 {
1163 if (item->type == SPELL) 1116 if (item->type == SPELL)
1164 op->failmsg ("Something blocks your spellcasting."); 1117 op->failmsg ("Something blocks your spellcasting.");
1165 else if (item->type == SCROLL) 1118 else if (item->type == SCROLL)
1171 op->failmsg ("Something blocks the spell!"); 1124 op->failmsg ("Something blocks the spell!");
1172 1125
1173 return 0; 1126 return 0;
1174 } 1127 }
1175 1128
1129 // undo the flood protection from earlier
1130 op->speed_left += 4 * op->speed; // ~0.5s on failure
1131
1176 /* Take into account how long it takes to cast the spell. 1132 /* Take into account how long it takes to cast the spell.
1177 * if the player is casting it, then we use the time in 1133 * if the player is casting it, then we use the time in
1178 * the spell object. If it is a spell object, have it 1134 * the spell object. If it is a spell object, have it
1179 * take two ticks. Things that cast spells on the players 1135 * take two ticks. Things that cast spells on the players
1180 * behalf (eg, altars, and whatever else) shouldn't cost 1136 * behalf (eg, altars, and whatever else) shouldn't cost
1181 * the player any time. 1137 * the player any time.
1182 * Ignore casting time for firewalls 1138 * Ignore casting time for firewalls
1183 */ 1139 */
1184 if (caster == op && caster->type != FIREWALL) 1140 if (caster == op && caster->type != FIREWALL)
1185 { 1141 {
1186 op->speed_left -= spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed); 1142 op->speed_left -= spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed;
1187 /* Other portions of the code may also decrement the speed of the player, so 1143 /* Other portions of the code may also decrement the speed of the player, so
1188 * put a lower limit so that the player isn't stuck here too long 1144 * put a lower limit so that the player isn't stuck here too long
1189 */ 1145 */
1190 if ((spell_ob->casting_time > 0) && op->speed_left < -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed)) 1146 if ((spell_ob->casting_time > 0) && op->speed_left < -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed)
1191 op->speed_left = -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed); 1147 op->speed_left = -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed;
1192 } 1148 }
1193 else if (caster->type == WAND || caster->type == HORN || caster->type == ROD || caster->type == POTION || caster->type == SCROLL) 1149 else if (caster->type == WAND || caster->type == HORN || caster->type == ROD || caster->type == POTION || caster->type == SCROLL)
1194 op->speed_left -= 2 * FABS (op->speed); 1150 op->speed_left -= 2 * op->speed;
1195 1151
1196 if (op->type == PLAYER && op == caster) 1152 if (op->type == PLAYER && op == caster)
1197 { 1153 {
1198 op->stats.grace -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE); 1154 op->stats.grace -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE);
1199 op->stats.sp -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA); 1155 op->stats.sp -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA);
1204 * object requires. 1160 * object requires.
1205 */ 1161 */
1206 if (op != caster && !skill && caster->skill) 1162 if (op != caster && !skill && caster->skill)
1207 { 1163 {
1208 skill = find_skill_by_name (op, caster->skill); 1164 skill = find_skill_by_name (op, caster->skill);
1165
1209 if (!skill) 1166 if (!skill)
1210 { 1167 {
1211 op->failmsg (format ("You lack the skill %s to use the %s!", &caster->skill, query_name (caster))); 1168 op->failmsgf ("You lack the %s skill, which is required to use the %s!", &caster->skill, query_name (caster));
1212 return 0; 1169 return 0;
1213 } 1170 }
1214
1215 op->change_skill (skill); /* needed for proper exp credit */
1216 } 1171 }
1217 1172
1218 if (INVOKE_OBJECT (CAST_SPELL, spell_ob, ARG_OBJECT (op), ARG_OBJECT (caster), ARG_INT (dir), ARG_STRING (stringarg))) 1173 if (INVOKE_OBJECT (CAST_SPELL, spell_ob, ARG_OBJECT (op), ARG_OBJECT (caster), ARG_INT (dir), ARG_STRING (spellparam)))
1219 return RESULT_INT (0); 1174 return RESULT_INT (0);
1220 1175
1176 // temporaroly replace chosen_skill by skill, we assume skill *could* be applied,
1177 // at least temporarily, which might not be true due to slot restrictions, but hey
1178 // invoke requires it basically.
1179
1180 object *chosen_skill = op->chosen_skill;
1181 op->chosen_skill = skill;
1182
1221 switch (spell_ob->subtype) 1183 switch (spell_ob->subtype)
1222 { 1184 {
1223 /* The order of case statements is same as the order they show up 1185 /* The order of case statements is same as the order they show up
1224 * in in spells.h. 1186 * in spells.h.
1225 */ 1187 */
1226 case SP_RAISE_DEAD: 1188 case SP_RAISE_DEAD:
1227 success = cast_raise_dead_spell (op, caster, spell_ob, dir, stringarg); 1189 success = cast_raise_dead_spell (op, caster, spell_ob, dir, spellparam);
1228 break; 1190 break;
1229 1191
1230 case SP_RUNE: 1192 case SP_RUNE:
1231 success = write_rune (op, caster, spell_ob, dir, stringarg); 1193 success = write_rune (op, caster, spell_ob, dir, spellparam);
1232 break; 1194 break;
1233 1195
1234 case SP_MAKE_MARK: 1196 case SP_MAKE_MARK:
1235 success = write_mark (op, spell_ob, stringarg); 1197 success = write_mark (op, spell_ob, spellparam);
1236 break; 1198 break;
1237 1199
1238 case SP_BOLT: 1200 case SP_BOLT:
1239 success = fire_bolt (op, caster, dir, spell_ob, skill); 1201 success = fire_bolt (op, caster, dir, spell_ob, skill);
1240 break; 1202 break;
1258 case SP_SMITE: 1220 case SP_SMITE:
1259 success = cast_smite_spell (op, caster, dir, spell_ob); 1221 success = cast_smite_spell (op, caster, dir, spell_ob);
1260 break; 1222 break;
1261 1223
1262 case SP_MAGIC_MISSILE: 1224 case SP_MAGIC_MISSILE:
1263 success = fire_arch_from_position (op, caster, op->x + freearr_x[dir], op->y + freearr_y[dir], dir, spell_ob); 1225 success = fire_arch_from_position (op, caster, op->x, op->y, dir, spell_ob);
1264 break; 1226 break;
1265 1227
1266 case SP_SUMMON_GOLEM: 1228 case SP_SUMMON_GOLEM:
1267 success = summon_golem (op, caster, dir, spell_ob); 1229 success = summon_golem (op, caster, dir, spell_ob);
1268 break; 1230 break;
1269 1231
1270 case SP_DIMENSION_DOOR: 1232 case SP_DIMENSION_DOOR:
1271 /* dimension door needs the actual caster, because that is what is 1233 /* dimension door needs the actual caster, because that is what is
1272 * moved. 1234 * moved.
1273 */ 1235 */
1274 success = dimension_door (op, caster, spell_ob, dir); 1236 success = dimension_door (op, caster, spell_ob, dir, spellparam);
1275 break; 1237 break;
1276 1238
1277 case SP_MAGIC_MAPPING: 1239 case SP_MAGIC_MAPPING:
1278 if (op->type == PLAYER) 1240 if (op->type == PLAYER)
1279 { 1241 {
1312 case SP_HEALING: 1274 case SP_HEALING:
1313 success = cast_heal (op, caster, spell_ob, dir); 1275 success = cast_heal (op, caster, spell_ob, dir);
1314 break; 1276 break;
1315 1277
1316 case SP_CREATE_FOOD: 1278 case SP_CREATE_FOOD:
1317 success = cast_create_food (op, caster, spell_ob, dir, stringarg); 1279 success = cast_create_food (op, caster, spell_ob, dir, spellparam);
1318 break; 1280 break;
1319 1281
1320 case SP_EARTH_TO_DUST: 1282 case SP_EARTH_TO_DUST:
1321 success = cast_earth_to_dust (op, caster, spell_ob); 1283 success = cast_earth_to_dust (op, caster, spell_ob);
1322 break; 1284 break;
1332 case SP_CURSE: 1294 case SP_CURSE:
1333 success = cast_curse (op, caster, spell_ob, dir); 1295 success = cast_curse (op, caster, spell_ob, dir);
1334 break; 1296 break;
1335 1297
1336 case SP_SUMMON_MONSTER: 1298 case SP_SUMMON_MONSTER:
1337 success = summon_object (op, caster, spell_ob, dir, stringarg); 1299 success = summon_object (op, caster, spell_ob, dir, spellparam);
1338 break; 1300 break;
1339 1301
1340 case SP_CHARGING: 1302 case SP_CHARGING:
1341 success = recharge (op, caster, spell_ob); 1303 success = recharge (op, caster, spell_ob);
1342 break; 1304 break;
1375 break; 1337 break;
1376 1338
1377 case SP_MOVING_BALL: 1339 case SP_MOVING_BALL:
1378 if (spell_ob->path_repelled && (spell_ob->path_repelled & caster->path_attuned) != spell_ob->path_repelled) 1340 if (spell_ob->path_repelled && (spell_ob->path_repelled & caster->path_attuned) != spell_ob->path_repelled)
1379 { 1341 {
1380 op->failmsg (format ("You lack the proper attunement to cast %s!", &spell_ob->name)); 1342 op->failmsgf ("You lack the proper attunement to cast %s!", &spell_ob->name);
1381 success = 0; 1343 success = 0;
1382 } 1344 }
1383 else 1345 else
1384 success = fire_arch_from_position (op, caster, op->x + freearr_x[dir], op->y + freearr_y[dir], dir, spell_ob); 1346 success = fire_arch_from_position (op, caster, op->x, op->y, dir, spell_ob);
1385 break; 1347 break;
1386 1348
1387 case SP_SWARM: 1349 case SP_SWARM:
1388 success = fire_swarm (op, caster, spell_ob, dir); 1350 success = fire_swarm (op, caster, spell_ob, dir);
1389 break; 1351 break;
1396 /* in rune.c */ 1358 /* in rune.c */
1397 success = dispel_rune (op, caster, spell_ob, skill, dir); 1359 success = dispel_rune (op, caster, spell_ob, skill, dir);
1398 break; 1360 break;
1399 1361
1400 case SP_CREATE_MISSILE: 1362 case SP_CREATE_MISSILE:
1401 success = cast_create_missile (op, caster, spell_ob, dir, stringarg); 1363 success = cast_create_missile (op, caster, spell_ob, dir, spellparam);
1402 break; 1364 break;
1403 1365
1404 case SP_CONSECRATE: 1366 case SP_CONSECRATE:
1405 success = cast_consecrate (op, caster, spell_ob); 1367 success = cast_consecrate (op, caster, spell_ob);
1406 break; 1368 break;
1428 case SP_AURA: 1390 case SP_AURA:
1429 success = create_aura (op, caster, spell_ob); 1391 success = create_aura (op, caster, spell_ob);
1430 break; 1392 break;
1431 1393
1432 case SP_PARTY_SPELL: 1394 case SP_PARTY_SPELL:
1433 success = cast_party_spell (op, caster, dir, spell_ob, stringarg); 1395 success = cast_party_spell (op, caster, dir, spell_ob, spellparam);
1434 break; 1396 break;
1435 1397
1436 default: 1398 default:
1437 LOG (llevError, "cast_spell: Unhandled spell subtype %d\n", spell_ob->subtype); 1399 LOG (llevError, "cast_spell: Unhandled spell subtype %d\n", spell_ob->subtype);
1438 } 1400 }
1401
1402 // restore chosen_skill
1403 op->chosen_skill = chosen_skill;
1439 1404
1440 op->play_sound ( 1405 op->play_sound (
1441 success 1406 success
1442 ? spell_ob->sound 1407 ? spell_ob->sound
1443 ? spell_ob->sound 1408 ? spell_ob->sound
1497 move_aura (op); 1462 move_aura (op);
1498 break; 1463 break;
1499 } 1464 }
1500} 1465}
1501 1466
1502/* this checks to see if something special should happen if
1503 * something runs into the object.
1504 */
1505void
1506check_spell_effect (object *op)
1507{
1508 switch (op->subtype)
1509 {
1510 case SP_BOLT:
1511 move_bolt (op);
1512 return;
1513
1514 case SP_BULLET:
1515 check_bullet (op);
1516 return;
1517 }
1518}
1519
1520/* This is called by move_apply. Basically, if someone 1467/* This is called by move_apply. Basically, if someone
1521 * moves onto a spell effect and the walk_on or fly_on flags 1468 * moves onto a spell effect and the walk_on or fly_on flags
1522 * are set, this is called. This should only be called for 1469 * are set, this is called. This should only be called for
1523 * objects of the appropraite type. 1470 * objects of the appropriate type.
1524 */ 1471 */
1525void 1472void
1526apply_spell_effect (object *spell, object *victim) 1473apply_spell_effect (object *spell, object *victim)
1527{ 1474{
1528 switch (spell->subtype) 1475 switch (spell->subtype)
1529 { 1476 {
1530 case SP_CONE: 1477 case SP_CONE:
1531 if (QUERY_FLAG (victim, FLAG_ALIVE) && spell->speed && spell->attacktype) 1478 if (victim->flag [FLAG_ALIVE] && spell->has_active_speed () && spell->attacktype)
1532 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 0); 1479 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 0);
1533 break; 1480 break;
1534 1481
1535 case SP_MAGIC_MISSILE: 1482 case SP_MAGIC_MISSILE:
1536 if (QUERY_FLAG (victim, FLAG_ALIVE)) 1483 if (victim->flag [FLAG_ALIVE])
1537 { 1484 {
1538 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1); 1485 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1);
1539
1540 if (!spell->destroyed ())
1541 spell->destroy (); 1486 spell->destroy ();
1542 } 1487 }
1543 break; 1488 break;
1544 1489
1545 case SP_MOVING_BALL: 1490 case SP_MOVING_BALL:
1546 if (QUERY_FLAG (victim, FLAG_ALIVE)) 1491 if (victim->flag [FLAG_ALIVE])
1547 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1); 1492 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1);
1548 else if (victim->materialname) 1493 else if (victim->material != MATERIAL_NULL)
1549 save_throw_object (victim, spell->attacktype, spell); 1494 save_throw_object (victim, spell->attacktype, spell);
1550 break;
1551 }
1552}
1553 1495
1496 break;
1497 }
1498}
1499
1500/**
1501 * This function will let a fireball explode at the position of
1502 * the victim with a specific maximum level.
1503 */
1504void
1505create_exploding_ball_at (object *victim, int level)
1506{
1507 object *ball = archetype::get (EXPLODING_FIREBALL);
1508 ball->dam_modifier = random_roll (1, level, victim, PREFER_LOW) / 5 + 1;
1509 ball->stats.maxhp = random_roll (1, level, victim, PREFER_LOW) / 10 + 2;
1510 ball->insert_at (victim);
1511}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines