ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/server/spell_util.C
(Generate patch)

Comparing deliantra/server/server/spell_util.C (file contents):
Revision 1.84 by root, Tue Sep 30 03:34:01 2008 UTC vs.
Revision 1.128 by root, Wed Nov 16 23:42:03 2016 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
25#include <spells.h> 26#include <spells.h>
33/* This returns a random spell from 'ob'. If skill is set, then 34/* This returns a random spell from 'ob'. If skill is set, then
34 * the spell must be of this skill, it can be NULL in which case all 35 * the spell must be of this skill, it can be NULL in which case all
35 * matching spells are used. 36 * matching spells are used.
36 */ 37 */
37object * 38object *
38find_random_spell_in_ob (object *ob, const char *skill) 39find_random_spell_in_ob (object *ob, shstr_cmp skill)
39{ 40{
40 int k = 0, s; 41 int k = 0, s;
41 42
42 for (object *tmp = ob->inv; tmp; tmp = tmp->below) 43 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
43 if (tmp->type == SPELL && (!skill || tmp->skill == skill)) 44 if (tmp->type == SPELL && (!skill || tmp->skill == skill))
45 46
46 /* No spells, no need to progess further */ 47 /* No spells, no need to progess further */
47 if (!k) 48 if (!k)
48 return NULL; 49 return NULL;
49 50
50 s = RANDOM () % k; 51 s = rndm (k);
51 52
52 for (object *tmp = ob->inv; tmp; tmp = tmp->below) 53 for (object *tmp = ob->inv; tmp; tmp = tmp->below)
53 if (tmp->type == SPELL && (!skill || tmp->skill == skill)) 54 if (tmp->type == SPELL && (!skill || tmp->skill == skill))
54 if (!s) 55 if (!s)
55 return tmp; 56 return tmp;
82 */ 83 */
83void 84void
84spell_effect (object *spob, int x, int y, maptile *map, object *originator) 85spell_effect (object *spob, int x, int y, maptile *map, object *originator)
85{ 86{
86 if (spob->other_arch) 87 if (spob->other_arch)
87 map->insert (arch_to_object (spob->other_arch), x, y, originator); 88 map->insert (spob->other_arch->instance (), x, y, originator);
88} 89}
89 90
90static int 91static int
91attuned_bonus (object *caster, object *spell, int level) 92attuned_bonus (object *caster, object *spell, int level)
92{ 93{
126 level = lerp (level, (int)spell->level, 100, 1, 100); 127 level = lerp (level, (int)spell->level, 100, 1, 100);
127 128
128 /* Always make this at least 1. If this is zero, we get divide by zero 129 /* Always make this at least 1. If this is zero, we get divide by zero
129 * errors in various places. 130 * errors in various places.
130 */ 131 */
131 return max (level, 1); 132 return clamp (level, 1, settings.max_level);
132} 133}
133 134
134/* The following function scales the spellpoint cost of 135/* The following function scales the spellpoint cost of
135 * a spell by it's increased effectiveness. Some of the 136 * a spell by it's increased effectiveness. Some of the
136 * lower level spells become incredibly vicious at high 137 * lower level spells become incredibly vicious at high
148 int sp, grace, level = casting_level (caster, spell); 149 int sp, grace, level = casting_level (caster, spell);
149 150
150 if (settings.spellpoint_level_depend == TRUE) 151 if (settings.spellpoint_level_depend == TRUE)
151 { 152 {
152 if (spell->stats.sp && spell->stats.maxsp) 153 if (spell->stats.sp && spell->stats.maxsp)
153 {
154 sp = (int) (spell->stats.sp * (1.0 + MAX (0, (float) (level - spell->level) / (float) spell->stats.maxsp))); 154 sp = spell->stats.sp * (1.f + max (0.f, float (level - spell->level) / spell->stats.maxsp));
155 }
156 else 155 else
157 sp = spell->stats.sp; 156 sp = spell->stats.sp;
158 157
159 sp *= (int) PATH_SP_MULT (caster, spell); 158 sp *= (int) PATH_SP_MULT (caster, spell);
160 if (!sp && spell->stats.sp) 159 if (!sp && spell->stats.sp)
161 sp = 1; 160 sp = 1;
162 161
163 if (spell->stats.grace && spell->stats.maxgrace) 162 if (spell->stats.grace && spell->stats.maxgrace)
164 {
165 grace = (int) (spell->stats.grace * (1.0 + MAX (0, (float) (level - spell->level) / (float) spell->stats.maxgrace))); 163 grace = spell->stats.grace * (1.f + max (0.f, float (level - spell->level) / spell->stats.maxgrace));
166 }
167 else 164 else
168 grace = spell->stats.grace; 165 grace = spell->stats.grace;
169 166
170 grace *= (int) PATH_SP_MULT (caster, spell); 167 grace *= PATH_SP_MULT (caster, spell);
171 if (spell->stats.grace && !grace) 168 if (spell->stats.grace && !grace)
172 grace = 1; 169 grace = 1;
173 } 170 }
174 else 171 else
175 { 172 {
181 if (spell->stats.grace && !grace) 178 if (spell->stats.grace && !grace)
182 grace = 1; 179 grace = 1;
183 } 180 }
184 181
185 if (flags == SPELL_HIGHEST) 182 if (flags == SPELL_HIGHEST)
186 return MAX (sp, grace); 183 return max (sp, grace);
187 else if (flags == SPELL_GRACE) 184 else if (flags == SPELL_GRACE)
188 return grace; 185 return grace;
189 else if (flags == SPELL_MANA) 186 else if (flags == SPELL_MANA)
190 return sp; 187 return sp;
191 else 188 else
247/* Checks to see if player knows the spell. If the name is the same 244/* Checks to see if player knows the spell. If the name is the same
248 * as an existing spell, we presume they know it. 245 * as an existing spell, we presume they know it.
249 * returns 1 if they know the spell, 0 if they don't. 246 * returns 1 if they know the spell, 0 if they don't.
250 */ 247 */
251object * 248object *
252check_spell_known (object *op, const char *name) 249check_spell_known (object *op, shstr_cmp name)
253{ 250{
254 object *spop; 251 object *spop;
255 shstr_cmp name_ (name);
256 252
257 for (spop = op->inv; spop; spop = spop->below) 253 for (spop = op->inv; spop; spop = spop->below)
258 if (spop->type == SPELL && spop->name == name) 254 if (spop->type == SPELL && spop->name == name)
259 return spop; 255 return spop;
260 256
261 return 0; 257 return 0;
262} 258}
263 259
264/* 260/*
265 * Look at object 'op' and see if they know the spell 261 * Look at object 'op' and see if they know the spell
266 * spname. This is pretty close to check_spell_known 262 * spname. This is pretty close to check_spell_known
267 * above, but it uses a looser matching mechanism. 263 * above, but it uses a looser matching mechanism.
268 * returns the matching spell object, or NULL. 264 * returns the matching spell object, or NULL.
269 * If we match multiple spells but don't get an 265 * If we match multiple spells but don't get an
270 * exact match, we also return NULL. 266 * exact match, we also return NULL.
271 */ 267 */
272object * 268object *
273lookup_spell_by_name (object *op, const char *spname) 269object::find_spell (const_utf8_string prefix) const
274{ 270{
275 object *spob1 = NULL, *spob2 = NULL, *spob; 271 if (shstr_cmp name = prefix)
276 int nummatch = 0; 272 {
277 273 // case 1, match spell name exactly
278 if (spname == NULL)
279 return NULL;
280
281 /* Try to find the spell. We store the results in spob1
282 * and spob2 - spob1 is only taking the length of
283 * the past spname, spob2 uses the length of the spell name.
284 */
285 for (spob = op->inv; spob; spob = spob->below) 274 for (object *spob = inv; spob; spob = spob->below)
275 if (spob->name == name && spob->type == SPELL)
276 return spob;
286 { 277 }
278 else
279 {
280 // case 2, match prefix
281 int len = strlen (prefix);
282
283 for (object *spob = inv; spob; spob = spob->below)
287 if (spob->type == SPELL) 284 if (spob->type == SPELL
288 { 285 && spob->name.length () < len
289 if (!strncmp (spob->name, spname, strlen (spname))) 286 && prefix [spob->name.length ()] <= ' '
290 { 287 && !memcmp (prefix, spob->name, spob->name.length ()))
291 nummatch++;
292 spob1 = spob;
293 }
294 else if (!strncmp (spob->name, spname, strlen (spob->name)))
295 {
296 /* if spells have ambiguous names, it makes matching
297 * really difficult. (eg, fire and fireball would
298 * fall into this category). It shouldn't be hard to
299 * make sure spell names don't overlap in that fashion.
300 */
301 if (spob2)
302 LOG (llevError, "Found multiple spells with overlapping base names: %s, %s\n", &spob2->name, &spob->name);
303 spob2 = spob;
304 }
305 }
306 }
307 /* if we have best match, return it. Otherwise, if we have one match
308 * on the loser match, return that, otehrwise null
309 */
310 if (spob2)
311 return spob2; 288 return spob;
312 if (spob1 && nummatch == 1) 289 }
313 return spob1; 290
314 return NULL; 291 return 0;
315} 292}
316 293
317/* reflwall - decides weither the (spell-)object sp_op will 294/* reflwall - decides weither the (spell-)object sp_op will
318 * be reflected from the given mapsquare. Returns 1 if true. 295 * be reflected from the given mapsquare. Returns 1 if true.
319 * (Note that for living creatures there is a small chance that 296 * (Note that for living creatures there is a small chance that
326{ 303{
327 if (OUT_OF_REAL_MAP (m, x, y)) 304 if (OUT_OF_REAL_MAP (m, x, y))
328 return 0; 305 return 0;
329 306
330 for (object *op = GET_MAP_OB (m, x, y); op; op = op->above) 307 for (object *op = GET_MAP_OB (m, x, y); op; op = op->above)
331 if (QUERY_FLAG (op, FLAG_REFL_SPELL) 308 if (op->flag [FLAG_REFL_SPELL]
332 && (!QUERY_FLAG (op, FLAG_ALIVE) 309 && (!op->flag [FLAG_ALIVE]
333 || (rndm (0, 99)) < 90 - (sp_op->level / 10))) 310 || (rndm (0, 99)) < 90 - (sp_op->level / 10)))
334 return 1; 311 return 1;
335 312
336 return 0; 313 return 0;
337} 314}
338 315
339/* cast_create_object: creates object new_op in direction dir 316/* cast_create_object: creates object new_op in direction dir
340 * or if that is blocked, beneath the player (op). 317 * or if that is blocked, beneath the player (op).
341 * we pass 'caster', but don't use it for anything. 318 * we pass 'caster', but don't use it for anything.
342 * This is really just a simple wrapper function . 319 * This is really just a simple wrapper function .
343 * returns the direction that the object was actually placed 320 * returns true to indicate whether the operation was successful.
344 * in. 321 * destroys the object is unsuccessful.
345 */ 322 */
346int 323bool
347cast_create_obj (object *op, object *caster, object *new_op, int dir) 324cast_create_obj (object *op, object *caster, object *new_op, int dir)
348{ 325{
349 maptile *m; 326 mapxy pos (op);
350 sint16 sx, sy; 327 pos.move (dir);
351 328
352 if (dir && 329 if (!pos.normalise ()
353 ((get_map_flags (op->map, &m, op->x + freearr_x[dir], op->y + freearr_y[dir], &sx, &sy) & P_OUT_OF_MAP) || 330 || pos->blocks (op) // perversely enough, we check if the palyer can reach that space
354 OB_TYPE_MOVE_BLOCK (op, GET_MAP_MOVE_BLOCK (m, sx, sy)))) 331 || !new_op->can_drop_at (pos.m, pos.x, pos.y)
355 { 332 )
356 new_draw_info (NDI_UNIQUE, 0, op, "Something is in the way.");
357 new_draw_info (NDI_UNIQUE, 0, op, "You cast it at your feet.");
358 dir = 0;
359 } 333 {
334 op->failmsg ("Your spell fizzles! H<Something is in the way.>");
335 new_op->destroy ();
336 return 0;
337 }
360 338
361 SET_FLAG (new_op, FLAG_IDENTIFIED); 339 new_op->set_flag (FLAG_IDENTIFIED);
362 op->map->insert (new_op,
363 op->x + freearr_x[dir], op->y + freearr_y[dir],
364 op,
365 dir ? 0 : INS_BELOW_ORIGINATOR);
366 340
341 pos.insert (new_op, op, dir ? 0 : INS_BELOW_ORIGINATOR);
342
367 return dir; 343 return 1;
344}
345
346static bool
347mergable_owner (object *o1, object *o2)
348{
349 if (o1 == o2)
350 return 1;
351
352 if (!o1 || !o2)
353 return 0;
354
355 if (o1->flag [FLAG_FRIENDLY] != o1->flag [FLAG_FRIENDLY])
356 return 0;
357
358 if (o1->is_player () || o2->is_player ())
359 return 0;
360
361 return 1;
368} 362}
369 363
370/* Returns true if it is ok to put spell *op on the space/may provided. 364/* Returns true if it is ok to put spell *op on the space/may provided.
371 * immune_stop is basically the attacktype of the spell (why 365 * immune_stop is basically the attacktype of the spell (why
372 * passed as a different value, not sure of). If immune_stop 366 * passed as a different value, not sure of). If immune_stop
373 * has the AT_MAGIC bit set, and there is a counterwall 367 * has the AT_MAGIC bit set, and there is a counterwall
374 * on the space, the object doesn't get placed. if immune stop 368 * on the space, the object doesn't get placed. if immune stop
375 * does not have AT_MAGIC, then counterwalls do not effect the spell. 369 * does not have AT_MAGIC, then counterwalls do not effect the spell.
376 *
377 */ 370 */
378int 371int
379ok_to_put_more (maptile *m, sint16 x, sint16 y, object *op, int immune_stop) 372ok_to_put_more (maptile *m, sint16 x, sint16 y, object *op, int immune_stop)
380{ 373{
381 if (!xy_normalise (m, x, y)) 374 if (!xy_normalise (m, x, y))
385 ms.update (); 378 ms.update ();
386 379
387 if (OB_TYPE_MOVE_BLOCK (op, ms.move_block)) 380 if (OB_TYPE_MOVE_BLOCK (op, ms.move_block))
388 return 0; 381 return 0;
389 382
383 int max_effects = 5; // max. number of similar spells per mapspace
384
390 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 385 for (object *tmp = ms.top; tmp; tmp = tmp->below)
391 { 386 {
392 /* If there is a counterspell on the space, and this 387 /* If there is a counterspell on the space, and this
393 * object is using magic, don't progress. I believe we could 388 * object is using magic, don't progress. I believe we could
394 * leave this out and let in progress, and other areas of the code 389 * leave this out and let in progress, and other areas of the code
395 * will then remove it, but that would seem to to use more 390 * will then remove it, but that would seem to to use more
397 * on top of a counterwall spell (may hit the player before being 392 * on top of a counterwall spell (may hit the player before being
398 * removed.) On the other hand, it may be more dramatic for the 393 * removed.) On the other hand, it may be more dramatic for the
399 * spell to actually hit the counterwall and be sucked up. 394 * spell to actually hit the counterwall and be sucked up.
400 */ 395 */
401 if ((tmp->attacktype & AT_COUNTERSPELL) 396 if ((tmp->attacktype & AT_COUNTERSPELL)
402 && !QUERY_FLAG (tmp, FLAG_MONSTER) 397 && !tmp->flag [FLAG_MONSTER]
403 && (tmp->type != PLAYER) 398 && (tmp->type != PLAYER)
404 && (tmp->type != WEAPON) 399 && (tmp->type != WEAPON)
405 && (tmp->type != BOW) 400 && (tmp->type != BOW)
406 && (tmp->type != ARROW) 401 && (tmp->type != ARROW)
407 && (tmp->type != GOLEM) 402 && (tmp->type != GOLEM)
408 && !QUERY_FLAG (tmp, FLAG_IS_FLOOR) // XXX: 403 && !tmp->flag [FLAG_IS_FLOOR] // XXX:
409 // we special case floor here because there 404 // we special case floor here because there
410 // are sometimes spell effect floors 405 // are sometimes spell effect floors
411 // which are used to inflict damage 406 // which are used to inflict damage
412 // (and those shouldn't go away from 407 // (and those shouldn't go away from
413 // sanctuary) see also: permanent lava 408 // sanctuary) see also: permanent lava
414 && (immune_stop & AT_MAGIC)) 409 && (immune_stop & AT_MAGIC))
415 return 0; 410 return 0;
416 411
417 /* This is to prevent 'out of control' spells. Basically, this
418 * limits one spell effect per space per spell. This is definately
419 * needed for performance reasons, and just for playability I believe.
420 * there are no such things as multispaced spells right now, so
421 * we don't need to worry about the head.
422 */
423 if ((tmp->stats.maxhp == op->stats.maxhp) && (tmp->type == op->type) && (tmp->subtype == op->subtype))
424 return 0;
425
426 /*
427 * Combine similar spell effects into one spell effect. Needed for
428 * performance reasons with meteor swarm and the like, but also for
429 * playability reasons.
430 */
431 if (tmp->arch == op->arch /* no harm if not comparing by name here */
432 && tmp->type == op->type 412 if (tmp->type == op->type)
433 && tmp->subtype == op->subtype
434 && tmp->owner == op->owner
435 && ((tmp->subtype == SP_EXPLOSION) || (tmp->subtype == SP_CONE && tmp->stats.sp == op->stats.sp)))
436 { 413 {
437 tmp->stats.dam = MAX (tmp->stats.dam, op->stats.dam); 414 if (tmp->subtype == op->subtype
438 tmp->range = MAX (tmp->range, op->range); 415 && tmp->arch == op->arch /* no harm if not comparing by name here */)
439 tmp->duration = MAX (tmp->duration, op->duration); 416 {
417 /* This is to prevent 'out of control' spells. Basically, this
418 * limits one spell effect per space per spell. This is definately
419 * needed for performance reasons, and just for playability I believe.
420 * there are no such things as multispaced spells right now, so
421 * we don't need to worry about the head.
422 */
423 if (tmp->stats.maxhp == op->stats.maxhp)
424 return 0;
425
426 /*
427 * Combine similar spell effects into one spell effect. Needed for
428 * performance reasons with meteor swarm and the like, but also for
429 * playability reasons.
430 */
431 if (((tmp->subtype == SP_EXPLOSION) || (tmp->subtype == SP_CONE && tmp->stats.sp == op->stats.sp)))
432 if (mergable_owner (tmp, op))
433 {
434 // if same owner, then combine, but reduce advantage of multiple spells
435 max_it (tmp->stats.dam, op->stats.dam);
436 max_it (tmp->range , op->range);
437 max_it (tmp->duration , op->duration);
438 return 0;
439 }
440 }
441
442 // if there are too many spell effects on this space,
443 // then don't allow more of them, for performance reasons.
444 if (tmp->type == SPELL_EFFECT
445 && !--max_effects)
440 return 0; 446 return 0;
441 } 447 }
442 448
443 /* Perhaps we should also put checks in for no magic and unholy 449 /* Perhaps we should also put checks in for no magic and unholy
444 * ground to prevent it from moving along? 450 * ground to prevent it from moving along?
445 */ 451 */
484 /* needed for AT_HOLYWORD,AT_GODPOWER stuff */ 490 /* needed for AT_HOLYWORD,AT_GODPOWER stuff */
485 if (tmp->attacktype & AT_HOLYWORD || tmp->attacktype & AT_GODPOWER) 491 if (tmp->attacktype & AT_HOLYWORD || tmp->attacktype & AT_GODPOWER)
486 if (!tailor_god_spell (tmp, op)) 492 if (!tailor_god_spell (tmp, op))
487 return 0; 493 return 0;
488 494
489 if (QUERY_FLAG (tmp, FLAG_IS_TURNABLE)) 495 if (tmp->flag [FLAG_IS_TURNABLE])
490 SET_ANIMATION (tmp, dir); 496 SET_ANIMATION (tmp, dir);
491 497
492 if ((tmp = op->map->insert (tmp, x, y, op))) 498 if ((tmp = op->map->insert (tmp, x, y, op)))
493 move_spell_effect (tmp); 499 move_spell_effect (tmp);
494 500
502 ****************************************************************************/ 508 ****************************************************************************/
503void 509void
504regenerate_rod (object *rod) 510regenerate_rod (object *rod)
505{ 511{
506 if (rod->stats.hp < rod->stats.maxhp) 512 if (rod->stats.hp < rod->stats.maxhp)
507 rod->stats.hp = min (rod->stats.maxhp, rod->stats.hp + 1 + rod->stats.maxhp / 10); 513 rod->stats.hp = min (rod->stats.maxhp, rod->stats.hp + 1 + rod->stats.maxhp / 20);
508} 514}
509 515
510void 516void
511drain_rod_charge (object *rod) 517drain_rod_charge (object *rod)
512{ 518{
532 { 538 {
533 tmp = op->owner; 539 tmp = op->owner;
534 /* If the owner does not exist, or is not a monster, than apply the spell 540 /* If the owner does not exist, or is not a monster, than apply the spell
535 * to the caster. 541 * to the caster.
536 */ 542 */
537 if (!tmp || !QUERY_FLAG (tmp, FLAG_MONSTER)) 543 if (!tmp || !tmp->flag [FLAG_MONSTER])
538 tmp = op; 544 tmp = op;
539 } 545 }
540 else 546 else
541 { 547 {
542 maptile *m = op->map; 548 maptile *m = op->map;
590 continue; 596 continue;
591 597
592 tmp = GET_MAP_OB (mp, nx, ny); 598 tmp = GET_MAP_OB (mp, nx, ny);
593 599
594 while (tmp != NULL && (((owner_type == PLAYER && 600 while (tmp != NULL && (((owner_type == PLAYER &&
595 !QUERY_FLAG (tmp, FLAG_MONSTER) && !QUERY_FLAG (tmp, FLAG_GENERATOR)) || 601 !tmp->flag [FLAG_MONSTER] && !tmp->flag [FLAG_GENERATOR]) ||
596 (owner_type != PLAYER && tmp->type != PLAYER)) || (tmp == exclude || (tmp->head && tmp->head == exclude)))) 602 (owner_type != PLAYER && tmp->type != PLAYER)) || (tmp == exclude || (tmp->head && tmp->head == exclude))))
597 tmp = tmp->above; 603 tmp = tmp->above;
598 604
599 if (tmp != NULL && can_see_monsterP (m, x, y, i)) 605 if (tmp != NULL && can_see_monsterP (m, x, y, i))
600 return freedir[i]; 606 return freedir[i];
604 610
605/* put_a_monster: puts a monster named monstername near by 611/* put_a_monster: puts a monster named monstername near by
606 * op. This creates the treasures for the monsters, and 612 * op. This creates the treasures for the monsters, and
607 * also deals with multipart monsters properly. 613 * also deals with multipart monsters properly.
608 */ 614 */
609void 615static void
610put_a_monster (object *op, const char *monstername) 616put_a_monster (object *op, const char *monstername)
611{ 617{
612 object *tmp, *head = NULL, *prev = NULL; 618 object *tmp, *head = NULL, *prev = NULL;
613 archetype *at; 619 archetype *at;
614 int dir; 620 int dir;
629 * insert multipart monsters properly 635 * insert multipart monsters properly
630 */ 636 */
631 //TODO: use expand_tail + ... 637 //TODO: use expand_tail + ...
632 while (at != NULL) 638 while (at != NULL)
633 { 639 {
634 tmp = arch_to_object (at); 640 tmp = at->instance ();
635 tmp->x = op->x + freearr_x[dir] + at->x; 641 tmp->x = op->x + freearr_x[dir] + at->x;
636 tmp->y = op->y + freearr_y[dir] + at->y; 642 tmp->y = op->y + freearr_y[dir] + at->y;
637 tmp->map = op->map; 643 tmp->map = op->map;
638 if (head) 644 if (head)
639 { 645 {
670 * Note that this is not used by any spells (summon evil monsters 676 * Note that this is not used by any spells (summon evil monsters
671 * use to call this, but best I can tell, that spell/ability was 677 * use to call this, but best I can tell, that spell/ability was
672 * never used. This is however used by various failures on the 678 * never used. This is however used by various failures on the
673 * players part (alchemy, reincarnation, etc) 679 * players part (alchemy, reincarnation, etc)
674 */ 680 */
675
676int 681int
677summon_hostile_monsters (object *op, int n, const char *monstername) 682summon_hostile_monsters (object *op, int n, const char *monstername)
678{ 683{
679 int i; 684 int i;
680 685
745 { 750 {
746 SET_ANIMATION (op, ATTACKS[i].face); 751 SET_ANIMATION (op, ATTACKS[i].face);
747 } 752 }
748} 753}
749 754
750
751/* prayer_failure: This is called when a player fails 755/* prayer_failure: This is called when a player fails
752 * at casting a prayer. 756 * at casting a prayer.
753 * op is the player. 757 * op is the player.
754 * failure is basically how much grace they had. 758 * failure is basically how much grace they had.
755 * power is how much grace the spell would normally take to cast. 759 * power is how much grace the spell would normally take to cast.
756 */ 760 */
757 761
758void 762#define HINT_GRACE " H<Make sure you always have enough grace points for your prayers.>"
763
764static void
759prayer_failure (object *op, int failure, int power) 765prayer_failure (object *op, int failure, int power)
760{ 766{
761 const char *godname; 767 const char *godname;
762 object *tmp; 768 object *tmp;
763 769
764 if (!strcmp ((godname = determine_god (op)), "none")) 770 if (!strcmp ((godname = determine_god (op)), "none"))
765 godname = "Your spirit"; 771 godname = "Your spirit";
766 772
767 if (failure <= -20 && failure > -40) /* wonder */ 773 if (failure <= -20 && failure > -40) /* wonder */
768 { 774 {
769 new_draw_info_format (NDI_UNIQUE, 0, op, "%s gives a sign to renew your faith.", godname); 775 op->failmsgf ("%s gives a sign to renew your faith." HINT_GRACE, godname);
770 tmp = get_archetype (SPELL_WONDER); 776 tmp = archetype::get (SPELL_WONDER);
771 cast_cone (op, op, 0, tmp); 777 cast_cone (op, op, 0, tmp);
772 tmp->destroy (); 778 tmp->destroy ();
773 } 779 }
774 780
775 else if (failure <= -40 && failure > -60) /* confusion */ 781 else if (failure <= -40 && failure > -60) /* confusion */
776 { 782 {
777 new_draw_info (NDI_UNIQUE, 0, op, "Your diety touches your mind!"); 783 op->failmsg ("Your diety touches your mind!" HINT_GRACE);
778 confuse_player (op, op, 99); 784 confuse_player (op, op, 99);
779 } 785 }
780 else if (failure <= -60 && failure > -150) /* paralysis */ 786 else if (failure <= -60 && failure > -150) /* paralysis */
781 { 787 {
782 new_draw_info_format (NDI_UNIQUE, 0, op, "%s requires you to pray NOW.", godname); 788 op->failmsgf ("%s requires you to pray NOW. "
783 new_draw_info (NDI_UNIQUE, 0, op, "You comply, ignoring all else."); 789 "You comply, ignoring all else." HINT_GRACE,
790 godname);
784 paralyze_player (op, op, 99); 791 paralyze_player (op, op, 99);
785 } 792 }
786 else if (failure <= -150) /* blast the immediate area */ 793 else if (failure <= -150) /* blast the immediate area */
787 { 794 {
788 tmp = get_archetype (GOD_POWER); 795 tmp = archetype::get (GOD_POWER);
789 new_draw_info_format (NDI_UNIQUE, 0, op, "%s smites you!", godname); 796 op->failmsgf ("%s smites you!" HINT_GRACE, godname);
790 cast_magic_storm (op, tmp, power); 797 cast_magic_storm (op, tmp, power);
791 } 798 }
792} 799}
793 800
794/* 801/*
795 * spell_failure() handles the various effects for differing degrees 802 * spell_failure() handles the various effects for differing degrees
796 * of failure badness. 803 * of failure badness.
797 * op is the player that failed. 804 * op is the player that failed.
798 * failure is a random value of how badly you failed. 805 * failure is a random value of how badly you failed.
799 * power is how many spellpoints you'd normally need for the spell. 806 * power is how many spellpoints you'd normally need for the spell.
800 * skill is the skill you'd need to cast the spell. 807 * skill is the skill you'd need to cast the spell.
801 */ 808 */
802
803void 809void
804spell_failure (object *op, int failure, int power, object *skill) 810spell_failure (object *op, int failure, int power, object *skill)
805{ 811{
806 object *tmp; 812 object *tmp;
807 813
808 if (settings.spell_failure_effects == FALSE) 814 if (settings.spell_failure_effects == FALSE)
809 return; 815 return;
810 816
811 if (failure <= -20 && failure > -40) /* wonder */ 817 if (failure <= -20 && failure > -40) /* wonder */
812 { 818 {
813 new_draw_info (NDI_UNIQUE, 0, op, "Your spell causes an unexpected effect."); 819 op->failmsg ("Your spell causes an unexpected effect.");
814 tmp = get_archetype (SPELL_WONDER); 820 tmp = archetype::get (SPELL_WONDER);
815 cast_cone (op, op, 0, tmp); 821 cast_cone (op, op, 0, tmp);
816 tmp->destroy (); 822 tmp->destroy ();
817 } 823 }
818 824
819 else if (failure <= -40 && failure > -60) /* confusion */ 825 else if (failure <= -40 && failure > -60) /* confusion */
820 { 826 {
821 new_draw_info (NDI_UNIQUE, 0, op, "Your magic recoils on you, making you confused!"); 827 op->failmsg ("Your magic recoils on you, making you confused!");
822 confuse_player (op, op, 99); 828 confuse_player (op, op, 99);
823 } 829 }
824 else if (failure <= -60 && failure > -80) /* paralysis */ 830 else if (failure <= -60 && failure > -80) /* paralysis */
825 { 831 {
826 new_draw_info (NDI_UNIQUE, 0, op, "Your magic stuns you!"); 832 op->failmsg ("Your magic stuns you!");
827 paralyze_player (op, op, 99); 833 paralyze_player (op, op, 99);
828 } 834 }
829 else if (failure <= -80) /* blast the immediate area */ 835 else if (failure <= -80) /* blast the immediate area */
830 { 836 {
831 object *tmp; 837 object *tmp;
832 838
833 /* Safety check to make sure we don't get any mana storms in scorn */ 839 /* Safety check to make sure we don't get any mana storms in scorn */
834 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC) 840 if (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_NO_MAGIC)
835 { 841 {
836 new_draw_info (NDI_UNIQUE, 0, op, "The magic warps and you are turned inside out!"); 842 op->failmsg ("The magic warps and you are turned inside out!");
837 hit_player (op, 9998, op, AT_INTERNAL, 1); 843 hit_player (op, 9998, op, AT_INTERNAL, 1);
838 844
839 } 845 }
840 else 846 else
841 { 847 {
842 new_draw_info (NDI_UNIQUE, 0, op, "You lose control of the mana! The uncontrolled magic blasts you!"); 848 op->failmsg ("You lose control of the mana! The uncontrolled magic blasts you!");
843 tmp = get_archetype (LOOSE_MANA); 849 tmp = archetype::get (LOOSE_MANA);
844 tmp->level = skill->level; 850 tmp->level = skill->level;
845 851
846 /* increase the area of destruction a little for more powerful spells */ 852 /* increase the area of destruction a little for more powerful spells */
847 tmp->range += isqrt (power); 853 tmp->range += isqrt (power);
848 854
856 tmp->insert_at (op); 862 tmp->insert_at (op);
857 } 863 }
858 } 864 }
859} 865}
860 866
861int 867static int
862cast_party_spell (object *op, object *caster, int dir, object *spell_ob, char *stringarg) 868cast_party_spell (object *op, object *caster, int dir, object *spell_ob, char *spellparam)
863{ 869{
864 int success;
865 object *spell;
866
867 if (!spell_ob->other_arch) 870 if (!spell_ob->other_arch)
868 { 871 {
869 LOG (llevError, "cast_party_spell: empty other arch\n"); 872 LOG (llevError, "cast_party_spell: empty other arch\n");
870 return 0; 873 return 0;
871 } 874 }
872 875
873 spell = arch_to_object (spell_ob->other_arch); 876 object *spell = spell_ob->other_arch->instance ();
874 877
875 /* Always cast spell on caster */ 878 /* Always cast spell on caster */
876 success = cast_spell (op, caster, dir, spell, stringarg); 879 int success = cast_spell (op, caster, dir, spell, spellparam);
877 880
878 if (caster->contr->party == NULL) 881 if (!op->contr || !op->contr->party)
879 { 882 {
880 spell->remove (); 883 spell->remove ();
881 return success; 884 return success;
882 } 885 }
883 886
884 for_all_players (pl) 887 for_all_players (pl)
885 if ((pl->ob->contr->party == caster->contr->party) && (on_same_map (pl->ob, caster))) 888 if ((pl->ob->contr->party == op->contr->party)
889 && on_same_map (pl->ob, op)
890 && pl->ob != op)
886 cast_spell (pl->ob, caster, pl->ob->facing, spell, stringarg); 891 cast_spell (pl->ob, caster, pl->ob->facing, spell, spellparam);
887 892
888 spell->remove (); 893 spell->remove ();
889 return success; 894 return success;
890} 895}
891 896
897 * same as op. 902 * same as op.
898 * dir is the direction to cast in. Note in some cases, if the spell 903 * dir is the direction to cast in. Note in some cases, if the spell
899 * is self only, dir really doesn't make a difference. 904 * is self only, dir really doesn't make a difference.
900 * spell_ob is the spell object that is being cast. From that, 905 * spell_ob is the spell object that is being cast. From that,
901 * we can determine what to do. 906 * we can determine what to do.
902 * stringarg is any options that are being used. It can be NULL. Almost 907 * spellparam is any options that are being used. It can be NULL. Almost
903 * certainly, only players will set it. It is basically used as optional 908 * certainly, only players will set it. It is basically used as optional
904 * parameters to a spell (eg, item to create, information for marking runes, 909 * parameters to a spell (eg, item to create, information for marking runes,
905 * etc. 910 * etc.
906 * returns 1 on successful cast, or 0 on error. These values should really 911 * returns 1 on successful cast, or 0 on error. These values should really
907 * be swapped, so that 0 is successful, and non zero is failure, with a code 912 * be swapped, so that 0 is successful, and non zero is failure, with a code
915 * if it is a player casting the spell (op->type == PLAYER, op == caster), 920 * if it is a player casting the spell (op->type == PLAYER, op == caster),
916 * this function will decrease the mana/grace appropriately. For other 921 * this function will decrease the mana/grace appropriately. For other
917 * objects, the caller should do what it considers appropriate. 922 * objects, the caller should do what it considers appropriate.
918 */ 923 */
919int 924int
920cast_spell (object *op, object *caster, int dir, object *spell_ob, char *stringarg) 925cast_spell (object *op, object *caster, int dir, object *spell_ob, char *spellparam)
921{ 926{
922 const char *godname; 927 const char *godname;
923 int success = 0, cast_level = 0; 928 int success = 0;
924 object *skill = NULL; 929
930 // make sure spells always take a while, so a) we don't flood the
931 // user with messages and b) too many failures can be harmful (smiting).
932 op->speed_left -= 4 * op->speed; // ~0.5s on failure
925 933
926 if (!spell_ob) 934 if (!spell_ob)
927 { 935 {
928 LOG (llevError, "cast_spell: null spell object passed\n"); 936 LOG (llevError, "cast_spell: null spell object passed\n");
929 return 0; 937 return 0;
940 } 948 }
941 949
942 /* if caster is a spell casting object, this normally shouldn't be 950 /* if caster is a spell casting object, this normally shouldn't be
943 * an issue, because they don't have any spellpaths set up. 951 * an issue, because they don't have any spellpaths set up.
944 */ 952 */
945 if (caster->path_denied & spell_ob->path_attuned && !QUERY_FLAG (caster, FLAG_WIZCAST)) 953 if (caster->path_denied & spell_ob->path_attuned && !caster->flag [FLAG_WIZCAST])
946 { 954 {
947 new_draw_info (NDI_UNIQUE, 0, op, "That spell path is denied to you."); 955 op->failmsg ("That spell path is denied to you.");
948 return 0; 956 return 0;
949 } 957 }
958
959 object *skill = 0;
950 960
951 /* if it is a player casting the spell, and they are really casting it 961 /* if it is a player casting the spell, and they are really casting it
952 * (vs it coming from a wand, scroll, or whatever else), do some 962 * (vs it coming from a wand, scroll, or whatever else), do some
953 * checks. We let monsters do special things - eg, they 963 * checks. We let monsters do special things - eg, they
954 * don't need the skill, bypass level checks, etc. The monster function 964 * don't need the SKILL, BYpass level checks, etc. The monster function
955 * should take care of that. 965 * should take care of that.
956 * Remove the wiz check here and move it further down - some spells 966 * Remove the wiz check here and move it further down - some spells
957 * need to have the right skill pointer passed, so we need to 967 * need to have the right skill pointer passed, so we need to
958 * at least process that code. 968 * at least process that code.
959 */ 969 */
963 { 973 {
964 skill = find_skill_by_name (op, spell_ob->skill); 974 skill = find_skill_by_name (op, spell_ob->skill);
965 975
966 if (!skill) 976 if (!skill)
967 { 977 {
968 op->failmsg (format ("You need the skill %s to cast %s! " 978 op->failmsgf ("You need the %s skill to cast %s! "
969 "H<You either need to learn the skill via a skill scroll " 979 "H<You either need to learn the skill via a skill scroll "
970 "or you need to wear a talisman or holy symbol.>", 980 "or you need to wear a talisman, holy symbol or another skill tool.>",
971 &spell_ob->skill, &spell_ob->name)); 981 &spell_ob->skill, &spell_ob->name);
972 return 0; 982 return 0;
973 } 983 }
974 984
975 const char *msg = ""; 985 const char *msg = "";
976 986
977 int caster_level = skill->level; 987 int caster_level = skill->level;
978 988
979 if (op->path_attuned & spell_ob->path_attuned) 989 if (op->path_attuned & spell_ob->path_attuned)
980 { 990 {
981 caster_level += min (cast_level * 2, ATTUNE_REPELL); 991 caster_level += min (caster_level, ATTUNE_REPELL);
982 msg = " (attuned)"; 992 msg = " (attuned)";
983 } 993 }
984 994
985 if (op->path_repelled & spell_ob->path_attuned) 995 if (op->path_repelled & spell_ob->path_attuned)
986 { 996 {
988 msg = " (repelled)"; 998 msg = " (repelled)";
989 } 999 }
990 1000
991 if (spell_ob->level > caster_level) 1001 if (spell_ob->level > caster_level)
992 { 1002 {
993 op->failmsg (format ("You lack enough skill to cast that spell! " 1003 op->failmsgf ("You lack enough skill to cast that spell! "
994 "H<Your effective cast level is %d%s, but level %d is required.>", 1004 "H<Your effective cast level is %d%s, but level %d is required.>",
995 caster_level, msg, spell_ob->level)); 1005 caster_level, msg, spell_ob->level);
996 if (!op->is_wiz ()) 1006 if (!op->is_wiz ())
997 return 0; 1007 return 0;
998 } 1008 }
999 } 1009 }
1000 1010
1001 /* If the caster is the wiz, they don't ever fail, and don't have 1011 /* If the caster is the wiz, they don't ever fail, and don't have
1002 * to have sufficient grace/mana. 1012 * to have sufficient grace/mana.
1003 */ 1013 */
1004 if (!QUERY_FLAG (op, FLAG_WIZ)) 1014 if (!op->flag [FLAG_WIZCAST])
1005 { 1015 {
1006 if (SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) && 1016 if (SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) &&
1007 SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) > op->stats.sp) 1017 SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA) > op->stats.sp)
1008 { 1018 {
1009 op->failmsg ("You don't have enough mana!"); 1019 op->failmsg ("You don't have enough mana!");
1017 10 * SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) / op->stats.maxgrace > 0) 1027 10 * SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) / op->stats.maxgrace > 0)
1018 op->statusmsg (format ("%s grants your prayer, though you are unworthy.", godname)); 1028 op->statusmsg (format ("%s grants your prayer, though you are unworthy.", godname));
1019 else 1029 else
1020 { 1030 {
1021 prayer_failure (op, op->stats.grace, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) - op->stats.grace); 1031 prayer_failure (op, op->stats.grace, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE) - op->stats.grace);
1022 op->failmsg (format ("%s ignores your prayer.", godname)); 1032 op->failmsgf ("%s ignores your prayer.", godname);
1023 return 0; 1033 return 0;
1024 } 1034 }
1025 } 1035 }
1026 1036
1027 /* player/monster is trying to cast the spell. might fumble it */ 1037 /* player/monster is trying to cast the spell. might fumble it */
1028 if (spell_ob->stats.grace && random_roll (0, 99, op, PREFER_HIGH) < 1038 if (spell_ob->stats.grace && random_roll (0, 99, op, PREFER_HIGH) <
1029 (spell_ob->level / (float) MAX (1, op->level) * cleric_chance[op->stats.Wis])) 1039 (spell_ob->level / (float) max (1, op->level) * cleric_chance[op->stats.Wis]))
1030 { 1040 {
1031 op->contr->play_sound (sound_find ("fumble_spell")); 1041 op->contr->play_sound (sound_find ("fumble_spell"));
1032 op->failmsg ("You fumble the prayer."); 1042 op->failmsg ("You fumble the prayer.");
1033 1043
1034 op->stats.grace -= random_roll (1, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE), op, PREFER_LOW); 1044 op->stats.grace -= random_roll (1, SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE), op, PREFER_LOW);
1057 * not alive, then this would mean that the mapmaker put the 1067 * not alive, then this would mean that the mapmaker put the
1058 * objects on the space - presume that they know what they are 1068 * objects on the space - presume that they know what they are
1059 * doing. 1069 * doing.
1060 */ 1070 */
1061 1071
1062 if ((mflags & P_SAFE) && !QUERY_FLAG (op, FLAG_WIZCAST)) // There is _ABSOLUTELY_ no magic allowed here (except wizards :-)! 1072 if ((mflags & P_SAFE) && !op->flag [FLAG_WIZCAST]) // There is _ABSOLUTELY_ no magic allowed here (except wizards :-)!
1063 { 1073 {
1074 op->speed_left -= 2 * op->speed; // freeze for two ticks, so we don't flood
1064 op->failmsg ("This ground is sacred! The gods prevent any magical effects done by you here!"); 1075 op->failmsg ("This ground is sacred! The gods prevent any magical effects done by you here!");
1065 return 0; 1076 return 0;
1066 } 1077 }
1067 1078
1068 if ((spell_ob->type == SPELL) 1079 if ((spell_ob->type == SPELL)
1069 && (caster->type != POTION) 1080 && (caster->type != POTION)
1070 && !QUERY_FLAG (op, FLAG_WIZCAST) 1081 && !op->flag [FLAG_WIZCAST]
1071 && (QUERY_FLAG (caster, FLAG_ALIVE) 1082 && (caster->flag [FLAG_ALIVE]
1072 || QUERY_FLAG (op, FLAG_ALIVE)) 1083 || op->flag [FLAG_ALIVE])
1073 && (((mflags & P_NO_MAGIC) && spell_ob->stats.sp) || ((mflags & P_NO_CLERIC) && spell_ob->stats.grace))) 1084 && (((mflags & P_NO_MAGIC) && spell_ob->stats.sp) || ((mflags & P_NO_CLERIC) && spell_ob->stats.grace)))
1074 { 1085 {
1075 if (op->type != PLAYER) 1086 if (op->type != PLAYER)
1076 return 0; 1087 return 0;
1077 1088
1078 if ((mflags & P_NO_CLERIC) && spell_ob->stats.grace) 1089 if ((mflags & P_NO_CLERIC) && spell_ob->stats.grace)
1079 op->failmsg (format ("This ground is unholy! %s ignores you.", godname)); 1090 op->failmsgf ("This ground is unholy! %s ignores you.", godname);
1080 else if (object *item = op->contr->ranged_ob) 1091 else if (object *item = op->contr->ranged_ob)
1081 { 1092 {
1082 if (item->type == SPELL) 1093 if (item->type == SPELL)
1083 op->failmsg ("Something blocks your spellcasting."); 1094 op->failmsg ("Something blocks your spellcasting.");
1084 else if (item->type == SCROLL) 1095 else if (item->type == SCROLL)
1090 op->failmsg ("Something blocks the spell!"); 1101 op->failmsg ("Something blocks the spell!");
1091 1102
1092 return 0; 1103 return 0;
1093 } 1104 }
1094 1105
1106 // undo the flood protection from earlier
1107 op->speed_left += 4 * op->speed; // ~0.5s on failure
1108
1095 /* Take into account how long it takes to cast the spell. 1109 /* Take into account how long it takes to cast the spell.
1096 * if the player is casting it, then we use the time in 1110 * if the player is casting it, then we use the time in
1097 * the spell object. If it is a spell object, have it 1111 * the spell object. If it is a spell object, have it
1098 * take two ticks. Things that cast spells on the players 1112 * take two ticks. Things that cast spells on the players
1099 * behalf (eg, altars, and whatever else) shouldn't cost 1113 * behalf (eg, altars, and whatever else) shouldn't cost
1100 * the player any time. 1114 * the player any time.
1101 * Ignore casting time for firewalls 1115 * Ignore casting time for firewalls
1102 */ 1116 */
1103 if (caster == op && caster->type != FIREWALL) 1117 if (caster == op && caster->type != FIREWALL)
1104 { 1118 {
1105 op->speed_left -= spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed); 1119 op->speed_left -= spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed;
1106 /* Other portions of the code may also decrement the speed of the player, so 1120 /* Other portions of the code may also decrement the speed of the player, so
1107 * put a lower limit so that the player isn't stuck here too long 1121 * put a lower limit so that the player isn't stuck here too long
1108 */ 1122 */
1109 if ((spell_ob->casting_time > 0) && op->speed_left < -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed)) 1123 if ((spell_ob->casting_time > 0) && op->speed_left < -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed)
1110 op->speed_left = -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * FABS (op->speed); 1124 op->speed_left = -spell_ob->casting_time * PATH_TIME_MULT (op, spell_ob) * op->speed;
1111 } 1125 }
1112 else if (caster->type == WAND || caster->type == HORN || caster->type == ROD || caster->type == POTION || caster->type == SCROLL) 1126 else if (caster->type == WAND || caster->type == HORN || caster->type == ROD || caster->type == POTION || caster->type == SCROLL)
1113 op->speed_left -= 2 * FABS (op->speed); 1127 op->speed_left -= 2 * op->speed;
1114 1128
1115 if (op->type == PLAYER && op == caster) 1129 if (op->type == PLAYER && op == caster)
1116 { 1130 {
1117 op->stats.grace -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE); 1131 op->stats.grace -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_GRACE);
1118 op->stats.sp -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA); 1132 op->stats.sp -= SP_level_spellpoint_cost (caster, spell_ob, SPELL_MANA);
1123 * object requires. 1137 * object requires.
1124 */ 1138 */
1125 if (op != caster && !skill && caster->skill) 1139 if (op != caster && !skill && caster->skill)
1126 { 1140 {
1127 skill = find_skill_by_name (op, caster->skill); 1141 skill = find_skill_by_name (op, caster->skill);
1142
1128 if (!skill) 1143 if (!skill)
1129 { 1144 {
1130 op->failmsg (format ("You lack the skill %s to use the %s!", &caster->skill, query_name (caster))); 1145 op->failmsgf ("You lack the %s skill, which is required to use the %s!", &caster->skill, query_name (caster));
1131 return 0; 1146 return 0;
1132 } 1147 }
1133
1134 op->change_skill (skill); /* needed for proper exp credit */
1135 } 1148 }
1136 1149
1137 if (INVOKE_OBJECT (CAST_SPELL, spell_ob, ARG_OBJECT (op), ARG_OBJECT (caster), ARG_INT (dir), ARG_STRING (stringarg))) 1150 if (INVOKE_OBJECT (CAST_SPELL, spell_ob, ARG_OBJECT (op), ARG_OBJECT (caster), ARG_INT (dir), ARG_STRING (spellparam)))
1138 return RESULT_INT (0); 1151 return RESULT_INT (0);
1139 1152
1153 // temporaroly replace chosen_skill by skill, we assume skill *could* be applied,
1154 // at least temporarily, which might not be true due to slot restrictions, but hey
1155 // invoke requires it basically.
1156
1157 object *chosen_skill = op->chosen_skill;
1158 op->chosen_skill = skill;
1159
1140 switch (spell_ob->subtype) 1160 switch (spell_ob->subtype)
1141 { 1161 {
1142 /* The order of case statements is same as the order they show up 1162 /* The order of case statements is same as the order they show up
1143 * in in spells.h. 1163 * in spells.h.
1144 */ 1164 */
1145 case SP_RAISE_DEAD: 1165 case SP_RAISE_DEAD:
1146 success = cast_raise_dead_spell (op, caster, spell_ob, dir, stringarg); 1166 success = cast_raise_dead_spell (op, caster, spell_ob, dir, spellparam);
1147 break; 1167 break;
1148 1168
1149 case SP_RUNE: 1169 case SP_RUNE:
1150 success = write_rune (op, caster, spell_ob, dir, stringarg); 1170 success = write_rune (op, caster, spell_ob, dir, spellparam);
1151 break; 1171 break;
1152 1172
1153 case SP_MAKE_MARK: 1173 case SP_MAKE_MARK:
1154 success = write_mark (op, spell_ob, stringarg); 1174 success = write_mark (op, spell_ob, spellparam);
1155 break; 1175 break;
1156 1176
1157 case SP_BOLT: 1177 case SP_BOLT:
1158 success = fire_bolt (op, caster, dir, spell_ob, skill); 1178 success = fire_bolt (op, caster, dir, spell_ob, skill);
1159 break; 1179 break;
1188 1208
1189 case SP_DIMENSION_DOOR: 1209 case SP_DIMENSION_DOOR:
1190 /* dimension door needs the actual caster, because that is what is 1210 /* dimension door needs the actual caster, because that is what is
1191 * moved. 1211 * moved.
1192 */ 1212 */
1193 success = dimension_door (op, caster, spell_ob, dir); 1213 success = dimension_door (op, caster, spell_ob, dir, spellparam);
1194 break; 1214 break;
1195 1215
1196 case SP_MAGIC_MAPPING: 1216 case SP_MAGIC_MAPPING:
1197 if (op->type == PLAYER) 1217 if (op->type == PLAYER)
1198 { 1218 {
1231 case SP_HEALING: 1251 case SP_HEALING:
1232 success = cast_heal (op, caster, spell_ob, dir); 1252 success = cast_heal (op, caster, spell_ob, dir);
1233 break; 1253 break;
1234 1254
1235 case SP_CREATE_FOOD: 1255 case SP_CREATE_FOOD:
1236 success = cast_create_food (op, caster, spell_ob, dir, stringarg); 1256 success = cast_create_food (op, caster, spell_ob, dir, spellparam);
1237 break; 1257 break;
1238 1258
1239 case SP_EARTH_TO_DUST: 1259 case SP_EARTH_TO_DUST:
1240 success = cast_earth_to_dust (op, caster, spell_ob); 1260 success = cast_earth_to_dust (op, caster, spell_ob);
1241 break; 1261 break;
1251 case SP_CURSE: 1271 case SP_CURSE:
1252 success = cast_curse (op, caster, spell_ob, dir); 1272 success = cast_curse (op, caster, spell_ob, dir);
1253 break; 1273 break;
1254 1274
1255 case SP_SUMMON_MONSTER: 1275 case SP_SUMMON_MONSTER:
1256 success = summon_object (op, caster, spell_ob, dir, stringarg); 1276 success = summon_object (op, caster, spell_ob, dir, spellparam);
1257 break; 1277 break;
1258 1278
1259 case SP_CHARGING: 1279 case SP_CHARGING:
1260 success = recharge (op, caster, spell_ob); 1280 success = recharge (op, caster, spell_ob);
1261 break; 1281 break;
1294 break; 1314 break;
1295 1315
1296 case SP_MOVING_BALL: 1316 case SP_MOVING_BALL:
1297 if (spell_ob->path_repelled && (spell_ob->path_repelled & caster->path_attuned) != spell_ob->path_repelled) 1317 if (spell_ob->path_repelled && (spell_ob->path_repelled & caster->path_attuned) != spell_ob->path_repelled)
1298 { 1318 {
1299 op->failmsg (format ("You lack the proper attunement to cast %s!", &spell_ob->name)); 1319 op->failmsgf ("You lack the proper attunement to cast %s!", &spell_ob->name);
1300 success = 0; 1320 success = 0;
1301 } 1321 }
1302 else 1322 else
1303 success = fire_arch_from_position (op, caster, op->x, op->y, dir, spell_ob); 1323 success = fire_arch_from_position (op, caster, op->x, op->y, dir, spell_ob);
1304 break; 1324 break;
1315 /* in rune.c */ 1335 /* in rune.c */
1316 success = dispel_rune (op, caster, spell_ob, skill, dir); 1336 success = dispel_rune (op, caster, spell_ob, skill, dir);
1317 break; 1337 break;
1318 1338
1319 case SP_CREATE_MISSILE: 1339 case SP_CREATE_MISSILE:
1320 success = cast_create_missile (op, caster, spell_ob, dir, stringarg); 1340 success = cast_create_missile (op, caster, spell_ob, dir, spellparam);
1321 break; 1341 break;
1322 1342
1323 case SP_CONSECRATE: 1343 case SP_CONSECRATE:
1324 success = cast_consecrate (op, caster, spell_ob); 1344 success = cast_consecrate (op, caster, spell_ob);
1325 break; 1345 break;
1347 case SP_AURA: 1367 case SP_AURA:
1348 success = create_aura (op, caster, spell_ob); 1368 success = create_aura (op, caster, spell_ob);
1349 break; 1369 break;
1350 1370
1351 case SP_PARTY_SPELL: 1371 case SP_PARTY_SPELL:
1352 success = cast_party_spell (op, caster, dir, spell_ob, stringarg); 1372 success = cast_party_spell (op, caster, dir, spell_ob, spellparam);
1353 break; 1373 break;
1354 1374
1355 default: 1375 default:
1356 LOG (llevError, "cast_spell: Unhandled spell subtype %d\n", spell_ob->subtype); 1376 LOG (llevError, "cast_spell: Unhandled spell subtype %d\n", spell_ob->subtype);
1357 } 1377 }
1378
1379 // restore chosen_skill
1380 op->chosen_skill = chosen_skill;
1358 1381
1359 op->play_sound ( 1382 op->play_sound (
1360 success 1383 success
1361 ? spell_ob->sound 1384 ? spell_ob->sound
1362 ? spell_ob->sound 1385 ? spell_ob->sound
1416 move_aura (op); 1439 move_aura (op);
1417 break; 1440 break;
1418 } 1441 }
1419} 1442}
1420 1443
1421/* this checks to see if something special should happen if
1422 * something runs into the object.
1423 */
1424void
1425check_spell_effect (object *op)
1426{
1427 switch (op->subtype)
1428 {
1429 case SP_BOLT:
1430 move_bolt (op);
1431 return;
1432
1433 case SP_BULLET:
1434 check_bullet (op);
1435 return;
1436 }
1437}
1438
1439/* This is called by move_apply. Basically, if someone 1444/* This is called by move_apply. Basically, if someone
1440 * moves onto a spell effect and the walk_on or fly_on flags 1445 * moves onto a spell effect and the walk_on or fly_on flags
1441 * are set, this is called. This should only be called for 1446 * are set, this is called. This should only be called for
1442 * objects of the appropriate type. 1447 * objects of the appropriate type.
1443 */ 1448 */
1445apply_spell_effect (object *spell, object *victim) 1450apply_spell_effect (object *spell, object *victim)
1446{ 1451{
1447 switch (spell->subtype) 1452 switch (spell->subtype)
1448 { 1453 {
1449 case SP_CONE: 1454 case SP_CONE:
1450 if (QUERY_FLAG (victim, FLAG_ALIVE) && spell->speed && spell->attacktype) 1455 if (victim->flag [FLAG_ALIVE] && spell->has_active_speed () && spell->attacktype)
1451 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 0); 1456 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 0);
1452 break; 1457 break;
1453 1458
1454 case SP_MAGIC_MISSILE: 1459 case SP_MAGIC_MISSILE:
1455 if (QUERY_FLAG (victim, FLAG_ALIVE)) 1460 if (victim->flag [FLAG_ALIVE])
1456 { 1461 {
1457 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1); 1462 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1);
1458 spell->destroy (); 1463 spell->destroy ();
1459 } 1464 }
1460 break; 1465 break;
1461 1466
1462 case SP_MOVING_BALL: 1467 case SP_MOVING_BALL:
1463 if (QUERY_FLAG (victim, FLAG_ALIVE)) 1468 if (victim->flag [FLAG_ALIVE])
1464 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1); 1469 hit_player (victim, spell->stats.dam, spell, spell->attacktype, 1);
1465 else if (victim->materialname) 1470 else if (victim->material != MATERIAL_NULL)
1466 save_throw_object (victim, spell->attacktype, spell); 1471 save_throw_object (victim, spell->attacktype, spell);
1467 1472
1468 break; 1473 break;
1469 } 1474 }
1470} 1475}
1471 1476
1477/**
1478 * This function will let a fireball explode at the position of
1479 * the victim with a specific maximum level.
1480 */
1481void
1482create_exploding_ball_at (object *victim, int level)
1483{
1484 object *ball = archetype::get (EXPLODING_FIREBALL);
1485 ball->dam_modifier = random_roll (1, level, victim, PREFER_LOW) / 5 + 1;
1486 ball->stats.maxhp = random_roll (1, level, victim, PREFER_LOW) / 10 + 2;
1487 ball->insert_at (victim);
1488}

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines