--- deliantra/server/socket/image.C 2007/03/14 01:19:10 1.30 +++ deliantra/server/socket/image.C 2007/03/14 18:25:18 1.34 @@ -200,7 +200,7 @@ void SendFaceCmd (char *buf, int len, client *ns) { - ns->send_face (atoi (buf), 1); + ns->send_image (atoi (buf)); } // how lame @@ -210,10 +210,10 @@ sl.printf ("%02x", d.chksum [i]); } -// gcfclient uses the server-provided checksum for comparison, -// but always wrotes a broken checksum to its cache file, so we -// have to provide gcfclient with a useless checksum just to -// have to cache the image despite its bugs. +// gcfclient uses the server-provided checksum for comparison, but always +// writes a broken checksum to its cache file, so we have to provide +// gcfclient with the same broken (and useless) checksum just to have it +// cache the image despite its bugs. static uint32 gcfclient_checksum (const facedata *d) { uint32 csum = 0; @@ -238,7 +238,7 @@ * we look at the facecache, and if set, send the image name. */ void -client::send_face (faceidx facenum, bool forced) +client::send_face (faceidx facenum) { // never send face 0. ever. it does not exist. if (!facenum) @@ -252,50 +252,75 @@ return; } - packet sl; + if (faces_sent[facenum]) + return; - if (facecache && !forced) + faces_sent[facenum] = true; + + if (!facecache) { - if (faces_sent[facenum]) - return; + send_drawinfo ( + "*** Please enable image/face caching in preferences or use a client that supports it.\n", + NDI_RED + ); + return send_image (facenum); + } - faces_sent[facenum] = true; + packet sl; - faceinfo *f = face_info (facenum); - if (f->smooth && EMI_smooth) - { - send_face (f->smooth); + if (force_face0) + sl << "face " << uint16 (facenum); + else if (image2) + sl << "face2 " << uint16 (facenum) << uint8 (0) << uint32 (force_bad_checksum ? gcfclient_checksum (d) : 0); + else + sl << "face1 " << uint16 (facenum) << uint32 (force_bad_checksum ? gcfclient_checksum (d) : 0); - packet sl ("smooth"); + // how lame + print_facename (sl, *d); + send_packet (sl); - sl << uint16 (facenum) - << uint16 (f->smooth); + faceinfo *f = face_info (facenum); + if (f->smooth && EMI_smooth) + { + send_face (f->smooth); - send_packet (sl); - } + packet sl ("smooth"); - if (force_face0) - sl << "face " << uint16 (facenum); - else if (image2) - sl << "face2 " << uint16 (facenum) << uint8 (0) << uint32 (force_bad_checksum ? gcfclient_checksum (d) : 0); - else - sl << "face1 " << uint16 (facenum) << uint32 (force_bad_checksum ? gcfclient_checksum (d) : 0); + sl << uint16 (facenum) + << uint16 (f->smooth); - // how lame - print_facename (sl, *d); + send_packet (sl); } - else - { - sl << (image2 ? "image2 " : "image ") - << uint32 (facenum); +} - if (image2) - sl << uint8 (0); +void +client::send_image (faceidx facenum) +{ + // never send face 0. ever. it does not exist. + if (!facenum) + return; + + const facedata *d = face_data (facenum, faceset); - sl << uint32 (d->data.size ()) - << data (d->data.data (), d->data.size ()); + if (!d) + { + LOG (llevError, "client::send_image (%d) out of bounds??\n", facenum); + return; } + faces_sent[facenum] = true; + + packet sl; + + sl << (image2 ? "image2 " : "image ") + << uint32 (facenum); + + if (image2) + sl << uint8 (0); + + sl << uint32 (d->data.size ()) + << data (d->data.data (), d->data.size ()); + send_packet (sl); }