ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/image.C
(Generate patch)

Comparing deliantra/server/socket/image.C (file contents):
Revision 1.12 by root, Thu Dec 14 22:45:41 2006 UTC vs.
Revision 1.35 by root, Thu Mar 15 14:59:43 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (C) 2001 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 23 */
23 24
24/** \file 25/** \file
25 * Image related communication 26 * Image related communication
26 * 27 *
27 * \date 2003-12-02 28 * \date 2003-12-02
… …
33 */ 34 */
34 35
35#include <global.h> 36#include <global.h>
36#include <sproto.h> 37#include <sproto.h>
37 38
38#include <newclient.h> 39#include "crc.h"
39#include <newserver.h>
40#include <loader.h>
41 40
42#define MAX_FACE_SETS 20 /**< Maximum number of image sets the program will handle */ 41#define MAX_FACE_SETS 20 /**< Maximum number of image sets the program will handle */
43 42
44/** Information about one image */ 43/** Information about one image */
45typedef struct FaceInfo 44typedef struct FaceInfo
46{ 45{
47
48 uint8 *data; /**< image data */ 46 uint8 *data; /**< image data */
49
50 uint16 datalen; /**< length of the xpm data */ 47 uint16 datalen; /**< length of the xpm data */
51
52 uint32 checksum; /**< Checksum of face data */ 48 uint32 checksum; /**< Checksum of face data */
53} FaceInfo; 49} FaceInfo;
54 50
55/** Information about one face set */ 51/** Information about one face set */
56typedef struct 52typedef struct
57{ 53{
58
59 char *prefix; /**< */ 54 char *prefix; /**< */
60 char *fullname; 55 char *fullname;
61 56
62 uint8 fallback; /**< faceset to use when an image is not found in this faceset */ 57 uint8 fallback; /**< faceset to use when an image is not found in this faceset */
63 char *size; 58 char *size;
… …
91 86
92 for (num = 0; num < MAX_FACE_SETS; num++) 87 for (num = 0; num < MAX_FACE_SETS; num++)
93 { 88 {
94 if (facesets[num].prefix) 89 if (facesets[num].prefix)
95 { 90 {
96 for (q = 0; q < nrofpixmaps; q++) 91 for (q = 0; q < faces.size (); q++)
97 if (facesets[num].faces[q].data) 92 if (facesets[num].faces[q].data)
98 free (facesets[num].faces[q].data); 93 free (facesets[num].faces[q].data);
94
99 free (facesets[num].prefix); 95 free (facesets[num].prefix);
100 free (facesets[num].fullname); 96 free (facesets[num].fullname);
101 free (facesets[num].size); 97 free (facesets[num].size);
102 free (facesets[num].extension); 98 free (facesets[num].extension);
103 free (facesets[num].comment); 99 free (facesets[num].comment);
… …
133 if (!facesets[faceset].prefix) 129 if (!facesets[faceset].prefix)
134 { 130 {
135 LOG (llevError, "get_face_fallback called with unused set (%d)?\n", faceset); 131 LOG (llevError, "get_face_fallback called with unused set (%d)?\n", faceset);
136 return 0; /* use default set */ 132 return 0; /* use default set */
137 } 133 }
134
138 if (facesets[faceset].faces[imageno].data) 135 if (facesets[faceset].faces[imageno].data)
139 return faceset; 136 return faceset;
137
140 return get_face_fallback (facesets[faceset].fallback, imageno); 138 return get_face_fallback (facesets[faceset].fallback, imageno);
141} 139}
142 140
143/** 141/**
144 * Checks fallback are correctly defined. 142 * Checks fallback are correctly defined.
… …
160 if (!facesets[fallback].prefix) 158 if (!facesets[fallback].prefix)
161 { 159 {
162 LOG (llevError, "Face set %d falls to non set faceset %d\n", faceset, fallback); 160 LOG (llevError, "Face set %d falls to non set faceset %d\n", faceset, fallback);
163 abort (); 161 abort ();
164 } 162 }
163
165 togo--; 164 togo--;
166 if (togo == 0) 165 if (togo == 0)
167 { 166 {
168 LOG (llevError, "Infinite loop found in facesets. aborting.\n"); 167 LOG (llevError, "Infinite loop found in facesets. aborting.\n");
169 abort (); 168 abort ();
170 } 169 }
170
171 check_faceset_fallback (fallback, togo); 171 check_faceset_fallback (fallback, togo);
172} 172}
173 173
174#define MAX_IMAGE_SIZE 10000 174#define MAX_IMAGE_SIZE 10000
175
176/**
177 * Loads all the image types into memory.
178 *
179 * This way, we can easily send them to the client. We should really do something
180 * better than abort on any errors - on the other hand, these are all fatal
181 * to the server (can't work around them), but the abort just seems a bit
182 * messy (exit would probably be better.)
183 *
184 * Couple of notes: We assume that the faces are in a continous block.
185 * This works fine for now, but this could perhaps change in the future
186 *
187 * Function largely rewritten May 2000 to be more general purpose.
188 * The server itself does not care what the image data is - to the server,
189 * it is just data it needs to allocate. As such, the code is written
190 * to do such.
191 */
192
193void
194read_client_images (void)
195{
196 char filename[400];
197 char buf[HUGE_BUF];
198 char *cp, *cps[7];
199 FILE *infile;
200 int num, len, compressed, fileno, i, badline;
201
202 memset (facesets, 0, sizeof (facesets));
203 sprintf (filename, "%s/image_info", settings.datadir);
204 if ((infile = open_and_uncompress (filename, 0, &compressed)) == NULL)
205 {
206 LOG (llevError, "Unable to open %s\n", filename);
207 abort ();
208 }
209 while (fgets (buf, HUGE_BUF - 1, infile) != NULL)
210 {
211 badline = 0;
212
213 if (buf[0] == '#')
214 continue;
215 if (!(cps[0] = strtok (buf, ":")))
216 badline = 1;
217 for (i = 1; i < 7; i++)
218 {
219 if (!(cps[i] = strtok (NULL, ":")))
220 badline = 1;
221 }
222 if (badline)
223 {
224 LOG (llevError, "Bad line in image_info file, ignoring line:\n %s", buf);
225 }
226 else
227 {
228 len = atoi (cps[0]);
229 if (len >= MAX_FACE_SETS)
230 {
231 LOG (llevError, "To high a setnum in image_info file: %d > %d\n", len, MAX_FACE_SETS);
232 abort ();
233 }
234 facesets[len].prefix = strdup (cps[1]);
235 facesets[len].fullname = strdup (cps[2]);
236 facesets[len].fallback = atoi (cps[3]);
237 facesets[len].size = strdup (cps[4]);
238 facesets[len].extension = strdup (cps[5]);
239 facesets[len].comment = strdup (cps[6]);
240 }
241 }
242 close_and_delete (infile, compressed);
243 for (i = 0; i < MAX_FACE_SETS; i++)
244 {
245 if (facesets[i].prefix)
246 check_faceset_fallback (i, MAX_FACE_SETS);
247 }
248 /* Loaded the faceset information - now need to load up the
249 * actual faces.
250 */
251
252 for (fileno = 0; fileno < MAX_FACE_SETS; fileno++)
253 {
254 /* if prefix is not set, this is not used */
255 if (!facesets[fileno].prefix)
256 continue;
257 facesets[fileno].faces = (FaceInfo *) calloc (nrofpixmaps, sizeof (FaceInfo));
258
259 sprintf (filename, "%s/crossfire.%d", settings.datadir, fileno);
260 LOG (llevDebug, "Loading image file %s\n", filename);
261
262 if ((infile = open_and_uncompress (filename, 0, &compressed)) == NULL)
263 {
264 LOG (llevError, "Unable to open %s\n", filename);
265 abort ();
266 }
267 while (fgets (buf, HUGE_BUF - 1, infile) != NULL)
268 {
269 if (strncmp (buf, "IMAGE ", 6) != 0)
270 {
271 LOG (llevError, "read_client_images:Bad image line - not IMAGE, instead\n%s", buf);
272 abort ();
273 }
274 num = atoi (buf + 6);
275 if (num < 0 || num >= nrofpixmaps)
276 {
277 LOG (llevError, "read_client_images: Image num %d not in 0..%d\n%s", num, nrofpixmaps, buf);
278 abort ();
279 }
280 /* Skip accross the number data */
281 for (cp = buf + 6; *cp != ' '; cp++);
282 len = atoi (cp);
283 if (len == 0 || len > MAX_IMAGE_SIZE)
284 {
285 LOG (llevError, "read_client_images: length not valid: %d > %d \n%s", len, MAX_IMAGE_SIZE, buf);
286 abort ();
287 }
288 /* We don't actualy care about the name of the image that
289 * is embedded in the image file, so just ignore it.
290 */
291 facesets[fileno].faces[num].datalen = len;
292 facesets[fileno].faces[num].data = (uint8 *) malloc (len);
293 if ((i = fread (facesets[fileno].faces[num].data, len, 1, infile)) != 1)
294 {
295 LOG (llevError, "read_client_images: Did not read desired amount of data, wanted %d, got %d\n%s", len, i, buf);
296 abort ();
297 }
298 facesets[fileno].faces[num].checksum = 0;
299 for (i = 0; i < len; i++)
300 {
301 ROTATE_RIGHT (facesets[fileno].faces[num].checksum);
302 facesets[fileno].faces[num].checksum += facesets[fileno].faces[num].data[i];
303 facesets[fileno].faces[num].checksum &= 0xffffffff;
304 }
305 }
306 close_and_delete (infile, compressed);
307 } /* For fileno < MAX_FACE_SETS */
308}
309 175
310/** 176/**
311 * Client tells us what type of faces it wants. Also sets 177 * Client tells us what type of faces it wants. Also sets
312 * the caching attribute. 178 * the caching attribute.
313 * 179 *
314 */ 180 */
315
316void 181void
317SetFaceMode (char *buf, int len, client_socket *ns) 182SetFaceMode (char *buf, int len, client *ns)
318{ 183{
319 int mask = (atoi (buf) & CF_FACE_CACHE), mode = (atoi (buf) & ~CF_FACE_CACHE); 184 int mask = (atoi (buf) & CF_FACE_CACHE), mode = (atoi (buf) & ~CF_FACE_CACHE);
320 185
321 if (mode == CF_FACE_NONE) 186 if (mode == CF_FACE_NONE)
322 ns->facecache = 1; 187 ns->facecache = 1;
323 else if (mode != CF_FACE_PNG) 188 else if (mode != CF_FACE_PNG)
324 {
325 packet sl;
326 sl.printf ("drawinfo %d %s", NDI_RED, "Warning - send unsupported face mode. Will use Png"); 189 ns->send_packet_printf ("drawinfo %d %s", NDI_RED, "Warning - send unsupported face mode. Will use Png");
327 ns->send_packet (sl);
328 }
329 190
330 if (mask) 191 if (mask)
331 ns->facecache = 1; 192 ns->facecache = 1;
332} 193}
333 194
334/** 195/**
335 * Client has requested pixmap that it somehow missed getting. 196 * Client has requested pixmap that it somehow missed getting.
336 * This will be called often if the client is 197 * This will be called often if the client is
337 * caching images. 198 * caching images.
338 */ 199 */
339
340void 200void
341SendFaceCmd (char *buff, int len, client_socket * ns) 201SendFaceCmd (char *buf, int len, client *ns)
342{ 202{
343 long tmpnum = atoi (buff); 203 ns->send_image (atoi (buf));
344 short facenum = tmpnum & 0xffff; 204}
345 205
346 if (facenum != 0) 206// how lame
347 esrv_send_face (ns, facenum, 1); 207static void print_facename (packet &sl, const facedata &d)
208{
209 for (int i = 0; i < CHKSUM_SIZE; ++i)
210 sl.printf ("%02x", d.chksum [i]);
211}
212
213// gcfclient uses the server-provided checksum for comparison, but always
214// writes a broken checksum to its cache file, so we have to provide
215// gcfclient with the same broken (and useless) checksum just to have it
216// cache the image despite its bugs.
217static uint32 gcfclient_checksum (const facedata *d)
218{
219 uint32 csum = 0;
220
221 for (std::string::const_iterator i = d->data.begin ();
222 i != d->data.end ();
223 ++i)
224 {
225 csum = rotate_right (csum);
226 csum += *(uint8 *)&*i;
227 }
228
229 return csum;
348} 230}
349 231
350/** 232/**
351 * Sends a face to a client if they are in pixmap mode 233 * Sends a face to a client if they are in pixmap mode
352 * nothing gets sent in bitmap mode. 234 * nothing gets sent in bitmap mode.
353 * If nocache is true (nonzero), ignore the cache setting from the client - 235 * If nocache is true (nonzero), ignore the cache setting from the client -
354 * this is needed for the askface, in which we really do want to send the 236 * this is needed for the askface, in which we really do want to send the
355 * face (and askface is the only place that should be setting it). Otherwise, 237 * face (and askface is the only place that should be setting it). Otherwise,
356 * we look at the facecache, and if set, send the image name. 238 * we look at the facecache, and if set, send the image name.
357 */ 239 */
358
359void 240void
360esrv_send_face (client_socket *ns, short face_num, int nocache) 241client::send_face (faceidx facenum)
361{ 242{
362 char fallback; 243 // never send face 0. ever. it does not exist.
244 if (!facenum)
245 return;
363 246
364 if (face_num <= 0 || face_num >= nrofpixmaps) 247 const facedata *d = face_data (facenum, faceset);
248
249 if (!d)
365 { 250 {
366 LOG (llevError, "esrv_send_face (%d) out of bounds??\n", face_num); 251 LOG (llevError, "client::send_face (%d) out of bounds??\n", facenum);
367 return; 252 return;
368 } 253 }
369 254
255 if (faces_sent[facenum])
256 return;
257
258 faces_sent[facenum] = true;
259
260 if (!facecache)
261 {
262 send_drawinfo (
263 "\n"
264 "\n"
265 "***\n"
266 "*** WARNING:\n"
267 "*** Your client does not support face/image caching,\n"
268 "*** or it has been disabled. Face caching is mandatory\n"
269 "*** so please enable it or use a newer client.\n"
270 "***\n"
271 "*** Look at your client preferences:\n"
272 "***\n"
273 "*** CFPlus: all known versions automatically enable the facecache.\n"
274 "*** cfclient: use the -cache commandline option.\n"
275 "*** cfclient: map will not redraw automatically (bug).\n"
276 "*** gcfclient: use -cache commandline option, or enable\n"
277 "*** gcfclient: Client=>Configure=>Map & Image=>Cache Images.\n"
278 "*** jcrossclient: your client is broken, use CFPlus or gcfclient.\n"
279 "***\n"
280 "***\n",
281 NDI_RED
282 );
283 return;
284 //return send_image (facenum);
285 }
286
370 packet sl; 287 packet sl;
371 fallback = get_face_fallback (ns->faceset, face_num);
372 288
373 if (facesets[fallback].faces[face_num].data == NULL) 289 if (force_face0)
290 sl << "face " << uint16 (facenum);
291 else if (image2)
292 sl << "face2 " << uint16 (facenum) << uint8 (0) << uint32 (force_bad_checksum ? gcfclient_checksum (d) : 0);
293 else
294 sl << "face1 " << uint16 (facenum) << uint32 (force_bad_checksum ? gcfclient_checksum (d) : 0);
295
296 // how lame
297 print_facename (sl, *d);
298 send_packet (sl);
299
300 faceinfo *f = face_info (facenum);
301 if (f->smooth && EMI_smooth)
302 {
303 send_face (f->smooth);
304
305 packet sl ("smooth");
306
307 sl << uint16 (facenum)
308 << uint16 (f->smooth);
309
310 send_packet (sl);
374 { 311 }
375 LOG (llevError, "esrv_send_face: faces[%d].data == NULL\n", face_num); 312}
313
314void
315client::send_image (faceidx facenum)
316{
317 // never send face 0. ever. it does not exist.
318 if (!facenum)
319 return;
320
321 const facedata *d = face_data (facenum, faceset);
322
323 if (!d)
324 {
325 LOG (llevError, "client::send_image (%d) out of bounds??\n", facenum);
376 return; 326 return;
377 } 327 }
378 328
379 if (ns->facecache && !nocache) 329 faces_sent[facenum] = true;
380 {
381 sl << (ns->image2 ? "face2 " : "face1 ")
382 << uint16 (face_num);
383 330
384 if (ns->image2) 331 packet sl;
385 sl << uint8 (fallback);
386 332
387 sl << uint32 (facesets[fallback].faces[face_num].checksum)
388 << new_faces[face_num].name;
389
390 ns->send_packet (sl);
391 }
392 else
393 {
394 sl << (ns->image2 ? "image2 " : "image ") 333 sl << (image2 ? "image2 " : "image ")
395 << uint32 (face_num); 334 << uint32 (facenum);
396 335
397 if (ns->image2) 336 if (image2)
398 sl << uint8 (fallback); 337 sl << uint8 (0);
399 338
400 sl << uint32 (facesets[fallback].faces[face_num].datalen) 339 sl << uint32 (d->data.size ())
401 << data (facesets[fallback].faces[face_num].data, facesets[fallback].faces[face_num].datalen); 340 << data (d->data.data (), d->data.size ());
402 341
403 ns->send_packet (sl); 342 send_packet (sl);
343}
344
345// send all faces of this object to the client
346// this uses more bandwidth initially, but makes
347// animations look much smoother, and every client
348// is supposed to do client-side caching anyways.
349void
350client::send_faces (object *ob)
351{
352 send_face (ob->face);
353
354 if (ob->animation_id)
404 } 355 {
356 animation &anim = animations [ob->animation_id];
405 357
406 ns->faces_sent[face_num] |= NS_FACESENT_FACE; 358 for (int i = 0; i < anim.num_animations; i++)
359 send_face (anim.faces [i]);
360 }
361}
362
363/**
364 * Need to send an animation sequence to the client.
365 * We will send appropriate face commands to the client if we haven't
366 * sent them the face yet (this can become quite costly in terms of
367 * how much we are sending - on the other hand, this should only happen
368 * when the player logs in and picks stuff up.
369 */
370void
371client::send_animation (short anim_num)
372{
373 /* Do some checking on the anim_num we got. Note that the animations
374 * are added in contigous order, so if the number is in the valid
375 * range, it must be a valid animation.
376 */
377 if (anim_num < 0 || anim_num > num_animations)
378 {
379 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
380 return;
381 }
382
383 packet sl ("anim");
384
385 sl << uint16 (anim_num)
386 << uint16 (0); /* flags - not used right now */
387
388 /* Build up the list of faces. Also, send any information (ie, the
389 * the face itself) down to the client.
390 */
391 for (int i = 0; i < animations[anim_num].num_animations; i++)
392 {
393 send_face (animations[anim_num].faces[i]);
394 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
395 }
396
397 send_packet (sl);
398
399 anims_sent[anim_num] = 1;
407} 400}
408 401
409/** 402/**
410 * Sends the number of images, checksum of the face file, 403 * Sends the number of images, checksum of the face file,
411 * and the image_info file information. See the doc/Developers/protocol 404 * and the image_info file information. See the doc/Developers/protocol
412 * if you want further detail. 405 * if you want further detail.
413 */ 406 */
414
415void 407void
416send_image_info (client_socket * ns, char *params) 408send_image_info (client *ns, char *params)
417{ 409{
418 packet sl; 410 packet sl;
419 411
420 sl.printf ("replyinfo image_info\n%d\n%d\n", nrofpixmaps - 1, bmaps_checksum); 412 //TODO: second parameter is a checksum, but it makes no sense in this current framework
413 sl.printf ("replyinfo image_info\n%d\n%u\n", MAX_FACES, 0);
421 414
422 for (int i = 0; i < MAX_FACE_SETS; i++) 415 sl << "0:base:standard:0:32x32:none:The old 32x32 faceset.\n";
423 if (facesets[i].prefix)
424 sl.printf ("%d:%s:%s:%d:%s:%s:%s",
425 i, facesets[i].prefix, facesets[i].fullname, facesets[i].fallback,
426 facesets[i].size, facesets[i].extension, facesets[i].comment);
427 416
428 ns->send_packet (sl); 417 ns->send_packet (sl);
429} 418}
430 419
431/** 420/**
… …
436 * For each image in [start..stop] sends 425 * For each image in [start..stop] sends
437 * - checksum 426 * - checksum
438 * - name 427 * - name
439 */ 428 */
440void 429void
441send_image_sums (client_socket * ns, char *params) 430send_image_sums (client *ns, char *params)
442{ 431{
443 int start, stop; 432 int start, stop;
444 char *cp, buf[MAX_BUF]; 433 char *cp;
445 434
446 packet sl; 435 packet sl;
447 436
448 start = atoi (params); 437 start = atoi (params);
449 for (cp = params; *cp != '\0'; cp++) 438 for (cp = params; *cp != '\0'; cp++)
450 if (*cp == ' ') 439 if (*cp == ' ')
451 break; 440 break;
452 441
453 stop = atoi (cp); 442 stop = atoi (cp);
454 if (stop < start || *cp == '\0' || (stop - start) > 1000 || stop >= nrofpixmaps) 443 if (stop < start || *cp == '\0' || (stop - start) > 1000 || stop >= MAX_FACES)
455 { 444 {
456 sl.printf ("replyinfo image_sums %d %d", start, stop); 445 sl.printf ("replyinfo image_sums %d %d", start, stop);
457 ns->send_packet (sl); 446 ns->send_packet (sl);
458 sl.reset (); 447 sl.reset ();
459 return; 448 return;
460 } 449 }
461 450
462 sl.printf ("replyinfo image_sums %d %d ", start, stop); 451 sl.printf ("replyinfo image_sums %d %d ", start, stop);
463 452
464 for (int i = start; i <= stop; i++) 453 for (int i = start; i <= stop && i < faces.size (); i++)
465 { 454 {
466 ns->faces_sent[i] |= NS_FACESENT_FACE; 455 ns->faces_sent[i] = true;
467 456
468 int qq = get_face_fallback (ns->faceset, i); 457 const facedata *d = face_data (i, ns->faceset);
458
459 if (sl.room () < 2 + 4 + 1 + d->data.size () + 1)
460 break;
469 461
470 sl << uint16 (i) 462 sl << uint16 (i)
471 << uint32 (facesets[qq].faces[i].checksum) 463 << uint32 (0) // checksum
472 << uint8 (qq) 464 << uint8 (ns->faceset);
473 << data8 (&new_faces[i].name, new_faces[i].name.length () + 1); 465
466 print_facename (sl, *d); sl << uint8 (0);
474 } 467 }
475 468
476 /* It would make more sense to catch this pre-emptively in the code above. 469 /* It would make more sense to catch this pre-emptively in the code above.
477 * however, if this really happens, we probably just want to cut down the 470 * however, if this really happens, we probably just want to cut down the
478 * size to less than 1000, since that is what we claim the protocol would 471 * size to less than 1000, since that is what we claim the protocol would
479 * support. 472 * support.
480 */ 473 */
474 //TODO: taken care of above, should simply abort or make sure the above code is correct
481 if (sl.length () >= MAXSOCKBUF) 475 if (sl.length () >= MAXSOCKBUF)
482 { 476 {
483 LOG (llevError, "send_image_send: buffer overrun, %d > %d\n", sl.length (), MAXSOCKBUF); 477 LOG (llevError, "send_image_send: buffer overrun, %d > %d\n", sl.length (), MAXSOCKBUF);
484 abort (); 478 abort ();
485 } 479 }

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines