--- deliantra/server/socket/init.C	2006/12/16 03:08:26	1.21
+++ deliantra/server/socket/init.C	2006/12/25 11:25:50	1.31
@@ -32,18 +32,21 @@
  * The reading of data is handled in ericserver.c
  */
 
-
 #include <global.h>
 #include <sproto.h>
 #include <sys/types.h>
 #include <sys/time.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
+#include <netinet/tcp.h>
+#include <netinet/ip.h>
 #include <netdb.h>
 
 #include <unistd.h>
 #include <arpa/inet.h>
 
+#include <algorithm>
+
 sockvec clients;
 
 /**
@@ -54,7 +57,8 @@
 client::client (int fd, const char *peername)
 : fd (fd), host (strdup (peername)),
   socket_ev (this, &client::socket_cb),
-  cmd_ev    (this, &client::cmd_cb)
+  cmd_ev    (this, &client::cmd_cb),
+  cc_inv (this), cc_other (this)
 {
   {
     struct linger linger_opt;
@@ -63,10 +67,43 @@
     linger_opt.l_linger = 0;
 
     if (setsockopt (fd, SOL_SOCKET, SO_LINGER, &linger_opt, sizeof (struct linger)))
-      LOG (llevError, "Cannot setsockopt(SO_LINGER): %s\n", strerror (errno));
+      LOG (llevError, "SO_LINGER: %s\n", strerror (errno));
   }
 
   {
+    int val = IPTOS_LOWDELAY;
+
+    if (setsockopt (fd, IPPROTO_IP, IP_TOS, &val, sizeof (val)))
+      LOG (llevError, "IP_TOS: %s\n", strerror (errno));
+  }
+
+  {
+    int val = 1;
+
+    if (setsockopt (fd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof (val)))
+      LOG (llevError, "TCP_NODELAY: %s\n", strerror (errno));
+  }
+
+#ifdef __linux__
+  {
+     int val;
+
+     // set some very aggressive keepalive parameters
+     val = 10;
+     if (setsockopt (fd, IPPROTO_TCP, TCP_KEEPIDLE, &val, sizeof (val)))
+       LOG (llevError, "TCP_KEEPIDLE: %s\n", strerror (errno));
+
+     val = 5;
+     if (setsockopt (fd, IPPROTO_TCP, TCP_KEEPCNT, &val, sizeof (val)))
+       LOG (llevError, "TCP_KEEPCNT: %s\n", strerror (errno));
+
+     val = 1;
+     if (setsockopt (fd, IPPROTO_TCP, TCP_KEEPINTVL, &val, sizeof (val)))
+       LOG (llevError, "TCP_KEEPINTVL: %s\n", strerror (errno));
+  }
+#endif
+
+  {
     int bufsize = 65535;          /*Supposed absolute upper limit */
     int oldbufsize;
     int buflen = sizeof (int);
@@ -85,17 +122,14 @@
     getsockopt (fd, SOL_SOCKET, SO_SNDBUF, (char *) &oldbufsize, (socklen_t *) & buflen);
   }
 
+  state = ST_SETUP;
   mapmode = Map0Cmd;
   darkness = 1;
-  status = Ns_Add;
   mapx = 11;
   mapy = 11;
   itemcmd = 1;              /* Default is version item1 command */
 
-  faces_sent_len = nrofpixmaps;
-  faces_sent = (uint8 *)calloc (nrofpixmaps, sizeof (*faces_sent));
-  if (!faces_sent)
-    fatal (OUT_OF_MEMORY);
+  faces_sent = salloc0<uint8> (nrofpixmaps);
 
   /* Do this so we don't send a face command for the client for
    * this face.  Face 0 is sent to the client to say clear
@@ -114,10 +148,13 @@
   cmd_ev.prio (PE_PRIO_NORMAL + 2);
 
   // initialisation done, kick it!
-
   send_packet_printf ("version %d %d %s\n", VERSION_CS, VERSION_SC, VERSION_INFO);
   flush ();
 
+  // clients are externally referenced by the socket
+  refcnt_inc ();
+  clients.push_back (this);
+
 #if 0//TODO
   socket_info.nconns++;
   if (socket_info.nconns > cst_tot.max_conn) cst_tot.max_conn = socket_info.nconns;
@@ -127,23 +164,34 @@
 
 client::~client ()
 {
+  sfree<uint8> (faces_sent, nrofpixmaps);
+  free (stats.range);
+  free (stats.title);
+  free (host);
+}
+
+void
+client::do_destroy ()
+{
+  attachable::do_destroy ();
+
+  sockvec::iterator i = find (clients.begin (), clients.end (), this);
+  if (i != clients.end ())
+    clients.erase (i);
+
   if (pl)
-    pl->socket = 0;
+    pl->disconnect ();
 
   if (fd >= 0)
-    close (fd), fd = -1;
+    close (fd);
 
-  free (stats.range), stats.range = 0;
-  free (stats.title), stats.title = 0;
-  free (host), host = 0;
-}
+  state = ST_DEAD;
 
-void
-client::destroy ()
-{
-  status = Ns_Dead;
   socket_ev.suspend ();
   cmd_ev.suspend ();
+
+  // socket now longer references us
+  refcnt_dec ();
 }
 
 /** This sets up the socket and reads all the image information into memory. */
@@ -173,26 +221,23 @@
   free_socket_images ();
 }
 
-/** Sends the 'goodbye' command to the player, and closes connection. */
-void
-final_free_player (player *pl)
-{
-  free_player (pl);
-}
-
-bool
-add_client (int fd, const char *peername)
+client *
+client::create (int fd, const char *peername)
 {
   if (checkbanned (NULL, peername))
     {
       LOG (llevInfo, "Banned host tried to connect: [%s]\n", peername);
-      return false;
+      return 0;
     }
   else
     {
       client *ns = new client (dup (fd), peername);
-      clients.push_back (ns);
-      return true;
+
+      ns->instantiate (); // effectively a nop right now
+
+      INVOKE_CLIENT (CONNECT, ns);
+
+      return ns;
     }
 }