ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/item.C
(Generate patch)

Comparing deliantra/server/socket/item.C (file contents):
Revision 1.13 by root, Thu Dec 14 00:13:26 2006 UTC vs.
Revision 1.68 by root, Thu May 8 20:03:50 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23 23
24/** 24/**
25 * \file 25 * \file
26 * Client/server logic. 26 * Client/server logic.
27 * 27 *
28 * \date 2003-12-02 28 * \date 2003-12-02
29 * 29 *
30 * This containes item logic for client/server. It doesn't contain 30 * This contains item logic for client/server. It doesn't contain
31 * the actual commands that send the data, but does contain 31 * the actual commands that send the data, but does contain
32 * the logic for what items should be sent. 32 * the logic for what items should be sent.
33 */ 33 */
34 34
35
36#include <global.h> 35#include <global.h>
37#include <object.h> /* LOOK_OBJ */
38#include <newclient.h> 36#include <object.h>
39#include <newserver.h>
40#include <sproto.h> 37#include <sproto.h>
41 38
42/** This is the maximum number of bytes we expect any one item to take up */ 39/** This is the maximum number of bytes we expect any one item to take up */
43#define MAXITEMLEN 300 40#define MAXITEMLEN 300
41
42#if 0
43tag_t
44client_container::tag () const
45{
46 switch (type)
47 {
48 case CC_INVENTORY:
49 return ns->pl->count;
50 case CC_MAPSPACE:
51 return 0;
52 case CC_CONTAINER:
53 return env->count;
54 }
55
56 abort ();
57}
58
59void
60client_container::clear ()
61{
62 switch (type)
63 {
64 case CC_INVENTORY:
65 abort ();
66
67 case CC_MAPSPACE:
68 case CC_CONTAINER:
69 ns->send_packet_printf ("delinv %d", tag ());
70 break;
71 }
72
73 for (iterator i = begin (); i != end (); ++i)
74 i->op->seen_by = 0;
75
76 vector< refitem, slice_allocator<refitem> >::clear ();
77}
78
79inline iterator
80client_container::merge_item (iterator i, object *op)
81{
82 if (i != end () && i->op == op)
83 return ++i;
84
85 if (op->seen_by)
86 return; // seen by another entity already
87
88 op->seen_by = this;
89
90 refitem ref;
91 ref.op = op;
92
93 return insert (i, ref);
94}
95
96void
97client_container::update (int offset)
98{
99 iterator i = begin ();
100
101 switch (type)
102 {
103 case CC_INVENTORY:
104 case CC_CONTAINER:
105 {
106 object *env = type == CC_INVENTORY
107 ? ns->pl->ob
108 : this->env;
109
110 // pass 1, erase all objects no longer in container
111 for (iterator j = begin (); j != end (); ++j)
112 if (j->op->env != env)
113 {
114 j->op->seen_by = 0;
115 erase (j);
116 }
117
118 // pass 2 merge items
119 for (object *op = env->inv; op; op = op->below)
120 {
121 if (--offset < 0)
122 i = merge_item (i, op);
123 else if (offset < -FLOORBOX_PAGESIZE)
124 break;
125 }
126 }
127 break;
128
129 case CC_MAPSPACE:
130 {
131 // pass 1, erase all objects no longer on space
132 for (iterator j = begin (); j != end (); ++j)
133 if (j->op->x != x || j->op->y != y || j->op->map != map)
134 {
135 j->op->seen_by = 0;
136 erase (j);
137 }
138
139 // pass 2 merge items
140 for (object *op = GET_MAP_OB (map, x, y); op; op = op->above)
141 {
142 if (--offset < 0)
143 i = merge_item (i, op);
144 else if (offset < -FLOORBOX_PAGESIZE)
145 break;
146 }
147 }
148 break;
149 }
150
151 // pass 3, erase all extra items
152 for (iterator j = i; j != end (); ++j)
153 j->op->seen_by = 0;
154
155 if (i != end ())
156 erase (i, end ());
157}
158
159void
160client_container::set_mapspace (maptile *map, int x, int y)
161{
162 if (type == CC_MAPSPACE
163 && this->map == map
164 && this->x == x
165 && this->y == y)
166 return;
167
168 clear ();
169
170 type = CC_MAPSPACE;
171 this->map = map;
172 this->x = x;
173 this->y = y;
174}
175
176void
177client_container::set_container (object *env)
178{
179}
180#endif
44 181
45/******************************************************************************* 182/*******************************************************************************
46 * 183 *
47 * Functions related to sending object data to the client. 184 * Functions related to sending object data to the client.
48 * 185 *
49 ******************************************************************************/ 186 ******************************************************************************/
50 187
51/** 188/**
52 * Adds string to socklist.
53 *
54 * This is a simple function that we use a lot here. It basically
55 * adds the specified buffer into the socklist, but prepends a
56 * single byte in length. If the data is longer than that byte, it is
57 * truncated approprately.
58 */
59inline void
60add_stringlen_to_sockbuf (const char *buf, SockList * sl)
61{
62 int len;
63
64 len = strlen (buf);
65 if (len > 255)
66 len = 255;
67 SockList_AddChar (sl, (char) len);
68 strncpy ((char *) sl->buf + sl->len, buf, len);
69 sl->len += len;
70}
71
72/**
73 * This is a similar to query_name, but returns flags 189 * This is a similar to query_name, but returns flags
74 * to be sended to client. 190 * to be sent to client.
75 */ 191 */
76unsigned int 192unsigned int
77query_flags (object *op) 193query_flags (object *op)
78{ 194{
79 unsigned int flags = 0; 195 unsigned int flags = 0;
80 196
81 if (QUERY_FLAG (op, FLAG_APPLIED)) 197 if (QUERY_FLAG (op, FLAG_APPLIED))
82 {
83 switch (op->type) 198 switch (op->type)
84 { 199 {
85 case BOW: 200 case BOW:
86 case WAND: 201 case WAND:
87 case ROD: 202 case ROD:
88 case HORN: 203 case HORN:
89 flags = a_readied; 204 flags = a_readied;
90 break; 205 break;
91 case WEAPON: 206 case WEAPON:
92 flags = a_wielded; 207 flags = a_wielded;
93 break; 208 break;
94 case SKILL: 209 case SKILL:
95 case ARMOUR: 210 case ARMOUR:
96 case HELMET: 211 case HELMET:
97 case SHIELD: 212 case SHIELD:
98 case RING: 213 case RING:
99 case BOOTS: 214 case BOOTS:
100 case GLOVES: 215 case GLOVES:
101 case AMULET: 216 case AMULET:
102 case GIRDLE: 217 case GIRDLE:
103 case BRACERS: 218 case BRACERS:
104 case CLOAK: 219 case CLOAK:
105 flags = a_worn; 220 flags = a_worn;
106 break; 221 break;
107 case CONTAINER: 222 case CONTAINER:
108 flags = a_active; 223 flags = a_active;
109 break; 224 break;
110 default: 225 default:
111 flags = a_applied; 226 flags = a_applied;
112 break; 227 break;
113 } 228 }
114 } 229
115 if (op->type == CONTAINER && ((op->env && op->env->container == op) || (!op->env && QUERY_FLAG (op, FLAG_APPLIED)))) 230 if (op->type == CONTAINER && ((op->env && op->env->container == op) || (!op->env && QUERY_FLAG (op, FLAG_APPLIED))))
116 flags |= F_OPEN; 231 flags |= F_OPEN;
117 232
118 if (QUERY_FLAG (op, FLAG_KNOWN_CURSED)) 233 if (QUERY_FLAG (op, FLAG_KNOWN_CURSED))
119 { 234 {
120 if (QUERY_FLAG (op, FLAG_DAMNED)) 235 if (QUERY_FLAG (op, FLAG_DAMNED))
121 flags |= F_DAMNED; 236 flags |= F_DAMNED;
122 else if (QUERY_FLAG (op, FLAG_CURSED)) 237 else if (QUERY_FLAG (op, FLAG_CURSED))
123 flags |= F_CURSED; 238 flags |= F_CURSED;
124 } 239 }
240
125 if (QUERY_FLAG (op, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (op, FLAG_IDENTIFIED)) 241 if (QUERY_FLAG (op, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (op, FLAG_IDENTIFIED))
126 flags |= F_MAGIC; 242 flags |= F_MAGIC;
127 if (QUERY_FLAG (op, FLAG_UNPAID)) 243 if (QUERY_FLAG (op, FLAG_UNPAID))
128 flags |= F_UNPAID; 244 flags |= F_UNPAID;
129 if (QUERY_FLAG (op, FLAG_INV_LOCKED)) 245 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
130 flags |= F_LOCKED; 246 flags |= F_LOCKED;
131 247
132 return flags; 248 return flags;
133} 249}
134 250
135/* Used in the send_look to put object head into SockList 251/* Used in the send_look to put object head into packet
136 * sl for socket ns. Need socket to know if we need to send 252 * sl for socket ns. Need socket to know if we need to send
137 * animation of face to the client. 253 * animation of face to the client.
138 */ 254 */
139static void 255static void
140add_object_to_socklist (NewSocket &ns, SockList &sl, object *head) 256add_object_to_socklist (client &ns, packet &sl, object *head)
141{ 257{
142 int flags, len, anim_speed;
143 char item_n[MAX_BUF]; 258 char item_n[MAX_BUF];
144 const char *item_p; 259 const char *item_p;
145 260
146 flags = query_flags (head); 261 int flags = query_flags (head);
147 if (QUERY_FLAG (head, FLAG_NO_PICK)) 262 if (QUERY_FLAG (head, FLAG_NO_PICK))
148 flags |= F_NOPICK; 263 flags |= F_NOPICK;
149 264
150 if (!(ns.faces_sent[head->face->number] & NS_FACESENT_FACE)) 265 ns.send_face (head->face, -50);
151 esrv_send_face (&ns, head->face->number, 0); 266 ns.flush_fx ();
152 267
153 if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id]) 268 if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id])
154 esrv_send_animation (&ns, head->animation_id); 269 ns.send_animation (head->animation_id);
155 270
156 sl << uint32 (head->count) 271 sl << uint32 (head->count)
157 << uint32 (flags) 272 << uint32 (flags)
158 << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : WEIGHT (head)) 273 << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : head->client_weight ())
159 << uint32 (head->face->number); 274 << uint32 (head->face);
275
276 int len;
160 277
161 if (!head->custom_name) 278 if (!head->custom_name)
162 { 279 {
163 strncpy (item_n, query_base_name (head, 0), 127); 280 strncpy (item_n, query_base_name (head, 0), 127);
164 item_n[127] = 0; 281 item_n[127] = 0;
178 len += strlen (item_n + 1 + len) + 1; 295 len += strlen (item_n + 1 + len) + 1;
179 296
180 sl << data8 (item_n, len) 297 sl << data8 (item_n, len)
181 << uint16 (head->animation_id); 298 << uint16 (head->animation_id);
182 299
183 anim_speed = 0; 300 int anim_speed = !head->flag [FLAG_ANIMATE] ? 0
184 if (QUERY_FLAG (head, FLAG_ANIMATE)) 301 : head->anim_speed ? clamp (head->anim_speed, 1, 255)
185 { 302 : 1. / clamp (fabs (head->speed), 1./255., 1./1.);
186 if (head->anim_speed)
187 anim_speed = head->anim_speed;
188 else
189 {
190 if (FABS (head->speed) < 0.001)
191 anim_speed = 255;
192 else if (FABS (head->speed) >= 1.0)
193 anim_speed = 1;
194 else
195 anim_speed = (int) (1.0 / FABS (head->speed));
196 }
197
198 if (anim_speed > 255)
199 anim_speed = 255;
200 }
201 303
202 sl << uint8 (anim_speed) 304 sl << uint8 (anim_speed)
203 << uint32 (head->nrof); 305 << uint32 (head->nrof);
204 306
205 if (ns.itemcmd == 2) 307 if (ns.itemcmd == 2)
206 sl << uint16 (head->client_type); 308 sl << uint16 (head->client_type);
207 309
208 SET_FLAG (head, FLAG_CLIENT_SENT); 310 SET_FLAG (head, FLAG_CLIENT_SENT);
209} 311}
210 312
313static faceidx
314need_face_now (player *pl, const char *name)
315{
316 faceidx face = face_find (name, empty_face);
317
318 pl->ns->send_face (face, -50);
319 pl->ns->flush_fx ();
320
321 return face;
322}
323
324#define FINGER_UP "finger_up.x11"
325#define FINGER_DOWN "finger_down.x11"
211 326
212/** 327/**
213 * Send the look window. Don't need to do animations here 328 * Send the look window. Don't need to do animations here
214 * This sends all the faces to the client, not just updates. This is 329 * This sends all the faces to the client, not just updates. This is
215 * because object ordering would otherwise be inconsistent 330 * because object ordering would otherwise be inconsistent.
216 */ 331 */
217
218void 332void
219esrv_draw_look (object *pl) 333esrv_draw_look (player *pl)
220{ 334{
221 object *tmp, *last; 335 object *ob = pl->ob;
222 int got_one = 0, start_look = 0, end_look = 0;
223 char buf[MAX_BUF];
224 336
225 if (!pl->contr->socket.update_look) 337 if (!pl->ns->update_look)
226 { 338 {
227 LOG (llevDebug, "esrv_draw_look called when update_look was not set\n"); 339 LOG (llevDebug, "esrv_draw_look called when update_look was not set (player %s)\n", &ob->name);
228 return; 340 return;
229 } 341 }
230 else 342
231 pl->contr->socket.update_look = 0; 343 pl->ns->update_look = 0;
232 344
233 if (QUERY_FLAG (pl, FLAG_REMOVED) 345 if (QUERY_FLAG (ob, FLAG_REMOVED)
234 || !pl->map 346 || !ob->map
235 || pl->map->in_memory != MAP_IN_MEMORY 347 || ob->map->in_memory != MAP_ACTIVE
236 || out_of_map (pl->map, pl->x, pl->y)) 348 || out_of_map (ob->map, ob->x, ob->y))
237 return; 349 return;
238 350
239 for (tmp = get_map_ob (pl->map, pl->x, pl->y); tmp && tmp->above; tmp = tmp->above); 351 pl->ns->send_packet ("delinv 0");
240 352
241 SockList sl (MAXSOCKBUF); 353 packet sl;
242
243 Write_String_To_Socket (&pl->contr->socket, "delinv 0", sizeof ("delinv 0") - 1);
244
245 sl.printf ("item%d ", pl->contr->socket.itemcmd); 354 sl.printf ("item%d ", pl->ns->itemcmd);
246 355
247 sl << uint32 (0); 356 sl << uint32 (0);
248 357
249 if (!(pl->contr->socket.faces_sent[empty_face->number] & NS_FACESENT_FACE)) 358 int start_pos = pl->ns->look_position;
250 esrv_send_face (&pl->contr->socket, empty_face->number, 0); 359 bool dirty = false;
251 360
252 if (pl->contr->socket.look_position) 361 mapspace &ms = ob->ms ();
362
363 // manage a ring buffer of the "last FLOORBOX_PAGESIZE" items and
364 // start from the top
365 object *items [FLOORBOX_PAGESIZE];
366 int item_idx = 0, item_cnt = 0;
367 int pos = 0;
368
369 // find our items by walking down
370 object *item = ms.top;
371
372 for (; item && item_cnt < FLOORBOX_PAGESIZE; item = item->below)
373 {
374 if (!item->client_visible ())
375 continue;
376
377 if (++pos < start_pos)
378 continue;
379
380 // record item
381 items [item_idx] = item; item_idx = item_idx < FLOORBOX_PAGESIZE ? item_idx + 1 : 0;
382 item_cnt++;
383
384 // stop at first floor
385 if (item->flag [FLAG_IS_FLOOR])
386 {
387 // we are finished, don't append "next group of items"
388 // by setting item to ms.bot it becomes zero which is checked after the while loop
389 item = ms.bot;
390 }
253 { 391 }
254 sl << uint32 (0x80000000 | (pl->contr->socket.look_position - NUM_LOOK_OBJECTS)) 392
393 // see if there are more if we cared - we ignore invisible objects
394 if (item)
395 {
396 /* What we basically do is make a 'fake' object - when the user applies it,
397 * we notice the special tag the object has, and act accordingly.
398 */
399 sl << uint32 (0x80000000 | (start_pos + FLOORBOX_PAGESIZE))
400 << uint32 (0)
401 << uint32 ((uint32) - 1)
402 << uint32 (need_face_now (pl, FINGER_DOWN))
403 << data8 ("Apply this to see the items below")
404 << uint16 (0)
405 << uint8 (0)
406 << uint32 (0);
407
408 if (pl->ns->itemcmd == 2)
409 sl << uint16 (0);
410
411 dirty = true;
412 }
413
414 // now send out all items in the ring buffer in reverse order
415 while (item_cnt)
416 {
417 --item_cnt;
418 item_idx = (item_idx ? item_idx : FLOORBOX_PAGESIZE) - 1;
419 object *item = items [item_idx];
420
421 add_object_to_socklist (*pl->ns, sl, item->head_ ());
422
423 dirty = true;
424
425 // if packet got too large, send it and begin a new one
426 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
427 {
428 pl->ns->send_packet (sl);
429
430 sl.reset ();
431 sl.printf ("item%d ", pl->ns->itemcmd);
432 sl << uint32 (0);
433
434 dirty = false;
435 }
436 }
437
438 if (start_pos)
439 {
440 sl << uint32 (0x80000000 | (start_pos - FLOORBOX_PAGESIZE))
255 << uint32 (0) 441 << uint32 (0)
256 << sint32 (-1) 442 << sint32 (-1)
257 << uint32 (empty_face->number); 443 << uint32 (need_face_now (pl, FINGER_UP))
258 444 << data8 ("Apply this to see the items higher up")
259 sl.printf ("Click here to see %d previous items", NUM_LOOK_OBJECTS);
260
261 sl << uint16 (0) 445 << uint16 (0)
262 << uint8 (0) 446 << uint8 (0)
263 << uint32 (0); 447 << uint32 (0);
264 448
265 if (pl->contr->socket.itemcmd == 2) 449 if (pl->ns->itemcmd == 2)
266 sl << uint16 (0); 450 sl << uint16 (0);
267 }
268 451
269 for (last = NULL; tmp != last; tmp = tmp->below) 452 dirty = true;
270 { 453 }
271 object *head;
272 454
273 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !last) 455 if (dirty)
274 { 456 pl->ns->send_packet (sl);
275 last = tmp->below; /* assumes double floor mode */
276 if (last && QUERY_FLAG (last, FLAG_IS_FLOOR))
277 last = last->below;
278 }
279
280 if (LOOK_OBJ (tmp))
281 {
282 if (++start_look < pl->contr->socket.look_position)
283 continue;
284
285 end_look++;
286
287 if (end_look > NUM_LOOK_OBJECTS)
288 {
289 /* What we basically do is make a 'fake' object - when the user applies it,
290 * we notice the special tag the object has, and act accordingly.
291 */
292 SockList_AddInt (&sl, 0x80000000 | (pl->contr->socket.look_position + NUM_LOOK_OBJECTS));
293 SockList_AddInt (&sl, 0);
294 SockList_AddInt (&sl, (uint32) - 1);
295 SockList_AddInt (&sl, empty_face->number);
296 sprintf (buf, "Click here to see next group of items");
297 add_stringlen_to_sockbuf (buf, &sl);
298 SockList_AddShort (&sl, 0);
299 SockList_AddChar (&sl, 0);
300 SockList_AddInt (&sl, 0);
301 if (pl->contr->socket.itemcmd == 2)
302 SockList_AddShort (&sl, 0);
303 break;
304 }
305 if (tmp->head)
306 head = tmp->head;
307 else
308 head = tmp;
309
310 add_object_to_socklist (pl->contr->socket, sl, head);
311 got_one++;
312
313 if (sl.len >= (MAXSOCKBUF - MAXITEMLEN))
314 {
315 Send_With_Handling (&pl->contr->socket, &sl);
316 sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd);
317 sl.len = strlen ((char *) sl.buf);
318 SockList_AddInt (&sl, 0);
319 got_one = 0;
320 }
321 } /* If LOOK_OBJ() */
322 }
323
324 if (got_one)
325 Send_With_Handling (&pl->contr->socket, &sl);
326
327 sl.free ();
328} 457}
329 458
330/** 459/**
331 * Sends whole inventory. 460 * Sends whole inventory.
332 */ 461 */
333void 462void
334esrv_send_inventory (object *pl, object *op) 463esrv_send_inventory (object *pl, object *op)
335{ 464{
336 object *tmp; 465 if (!pl->contr->ns)//D
466 return;
467
337 int got_one = 0; 468 int got_one = 0;
338 SockList sl;
339 469
340 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 470 pl->contr->ns->send_packet_printf ("delinv %d", op->count);
341 471
342 sprintf ((char *) sl.buf, "delinv %d", op->count); 472 packet sl;
343 sl.len = strlen ((char *) sl.buf);
344 Send_With_Handling (&pl->contr->socket, &sl);
345
346 sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd); 473 sl.printf ("item%d ", pl->contr->ns->itemcmd);
347 sl.len = strlen ((char *) sl.buf);
348 474
349 SockList_AddInt (&sl, op->count); 475 sl << uint32 (op->count);
350 476
351 for (tmp = op->inv; tmp; tmp = tmp->below) 477 for (object *tmp = op->inv; tmp; tmp = tmp->below)
352 { 478 {
353 object *head; 479 object *head;
354 480
355 if (tmp->head) 481 if (tmp->head)
356 head = tmp->head; 482 head = tmp->head;
357 else 483 else
358 head = tmp; 484 head = tmp;
359 485
360 if (LOOK_OBJ (head)) 486 if (head->client_visible ())
361 { 487 {
362 add_object_to_socklist (pl->contr->socket, sl, head); 488 add_object_to_socklist (*pl->contr->ns, sl, head);
363 489
364 got_one++; 490 got_one++;
365 491
366 /* IT is possible for players to accumulate a huge amount of 492 /* IT is possible for players to accumulate a huge amount of
367 * items (especially with some of the bags out there) to 493 * items (especially with some of the bags out there) to
368 * overflow the buffer. IF so, send multiple item commands. 494 * overflow the buffer. IF so, send multiple item commands.
369 */ 495 */
370 if (sl.len >= (MAXSOCKBUF - MAXITEMLEN)) 496 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
371 { 497 {
372 Send_With_Handling (&pl->contr->socket, &sl); 498 pl->contr->ns->send_packet (sl);
499
500 sl.reset ();
373 sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd); 501 sl.printf ("item%d ", pl->contr->ns->itemcmd);
374 sl.len = strlen ((char *) sl.buf); 502 sl << uint32 (op->count);
375 SockList_AddInt (&sl, op->count);
376 got_one = 0; 503 got_one = 0;
377 } 504 }
378 } /* If LOOK_OBJ() */ 505 }
379 } 506 }
507
380 if (got_one) 508 if (got_one)
381 Send_With_Handling (&pl->contr->socket, &sl); 509 pl->contr->ns->send_packet (sl);
382 sl.free ();
383} 510}
384 511
385/** 512/**
386 * Updates object *op for player *pl. 513 * Updates object *op for player *pl.
387 * 514 *
388 * flags is a list of values to update 515 * flags is a list of values to update
389 * to the client (as defined in newclient.h - might as well use the 516 * to the client (as defined in newclient.h - might as well use the
390 * same value both places. 517 * same value both places.
391 */ 518 */
392
393void 519void
394esrv_update_item (int flags, object *pl, object *op) 520esrv_update_item (int flags, object *pl, object *op)
395{ 521{
396 SockList sl;
397
398 /* If we have a request to send the player item, skip a few checks. */ 522 /* If we have a request to send the player item, skip a few checks. */
399 if (op != pl) 523 if (op != pl && !op->client_visible ())
400 {
401 if (!LOOK_OBJ (op))
402 return; 524 return;
403 /* we remove the check for op->env, because in theory, the object 525
404 * is hopefully in the same place, so the client should preserve 526 client *ns = pl->contr->ns;
405 * order. 527 if (!ns)
406 */ 528 return;
407 }
408 529
409 if (!QUERY_FLAG (op, FLAG_CLIENT_SENT)) 530 if (!QUERY_FLAG (op, FLAG_CLIENT_SENT))
410 { 531 {
411 /* FLAG_CLIENT_SENT is debug only. We are using it to see where 532 /* FLAG_CLIENT_SENT is debug only. We are using it to see where
412 * this is happening - we can set a breakpoint here in the debugger 533 * this is happening - we can set a breakpoint here in the debugger
413 * and track back the call. 534 * and track back the call.
414 */ 535 */
415 LOG (llevDebug, "We have not sent item %s (%d)\n", &op->name, op->count); 536 LOG (llevDebug, "We have not sent item %s (%d)\n", &op->name, op->count);
416 } 537 }
417 538
418 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 539 packet sl ("upditem");
419 540
420 strcpy ((char *) sl.buf, "upditem "); 541 sl << uint8 (flags);
421 sl.len = strlen ((char *) sl.buf);
422 542
423 SockList_AddChar (&sl, (char) flags);
424
425 if (op->head)
426 op = op->head; 543 op = op->head_ ();
427 544
428 SockList_AddInt (&sl, op->count); 545 sl << uint32 (op->count);
429 546
430 if (flags & UPD_LOCATION) 547 if (flags & UPD_LOCATION)
431 SockList_AddInt (&sl, op->env ? op->env->count : 0); 548 sl << uint32 (op->env ? op->env->count : 0);
432 549
433 if (flags & UPD_FLAGS) 550 if (flags & UPD_FLAGS)
434 SockList_AddInt (&sl, query_flags (op)); 551 sl << uint32 (query_flags (op));
435 552
436 if (flags & UPD_WEIGHT) 553 if (flags & UPD_WEIGHT)
437 { 554 {
438 sint32 weight = WEIGHT (op); 555 sint32 weight = op->flag [FLAG_NO_PICK] ? -1 : op->client_weight ();
439 556
440 SockList_AddInt (&sl, QUERY_FLAG (op, FLAG_NO_PICK) ? -1 : weight);
441 if (pl == op) 557 if (op)
442 {
443 op->contr->last_weight = weight; 558 ns->last_weight = weight;
444 } 559
560 sl << uint32 (weight);
445 } 561 }
446 562
447 if (flags & UPD_FACE) 563 if (flags & UPD_FACE)
448 { 564 {
449 if (!(pl->contr->socket.faces_sent[op->face->number] & NS_FACESENT_FACE)) 565 ns->send_face (op->face, -50);
450 esrv_send_face (&pl->contr->socket, op->face->number, 0); 566 ns->flush_fx ();
451 SockList_AddInt (&sl, op->face->number); 567 sl << uint32 (op->face);
452 } 568 }
453 569
454 if (flags & UPD_NAME) 570 if (flags & UPD_NAME)
455 { 571 {
456 int len; 572 int len;
473 } 589 }
474 590
475 strncpy (item_n + len + 1, item_p, 127); 591 strncpy (item_n + len + 1, item_p, 127);
476 item_n[254] = 0; 592 item_n[254] = 0;
477 len += strlen (item_n + 1 + len) + 1; 593 len += strlen (item_n + 1 + len) + 1;
478 SockList_AddChar (&sl, (char) len); 594
479 memcpy (sl.buf + sl.len, item_n, len); 595 sl << data8 (item_n, len);
480 sl.len += len;
481 } 596 }
482 597
483 if (flags & UPD_ANIM) 598 if (flags & UPD_ANIM)
484 SockList_AddShort (&sl, op->animation_id); 599 sl << uint16 (op->animation_id);
485 600
486 if (flags & UPD_ANIMSPEED) 601 if (flags & UPD_ANIMSPEED)
487 { 602 {
488 int anim_speed = 0; 603 int anim_speed = 0;
489 604
491 { 606 {
492 if (op->anim_speed) 607 if (op->anim_speed)
493 anim_speed = op->anim_speed; 608 anim_speed = op->anim_speed;
494 else 609 else
495 { 610 {
496 if (FABS (op->speed) < 0.001) 611 if (fabs (op->speed) < 0.001)
497 anim_speed = 255; 612 anim_speed = 255;
498 else if (FABS (op->speed) >= 1.0) 613 else if (fabs (op->speed) >= 1.0)
499 anim_speed = 1; 614 anim_speed = 1;
500 else 615 else
501 anim_speed = (int) (1.0 / FABS (op->speed)); 616 anim_speed = (int) (1.0 / fabs (op->speed));
502 } 617 }
618
503 if (anim_speed > 255) 619 if (anim_speed > 255)
504 anim_speed = 255; 620 anim_speed = 255;
505 } 621 }
506 SockList_AddChar (&sl, (char) anim_speed); 622
623 sl << uint8 (anim_speed);
507 } 624 }
625
508 if (flags & UPD_NROF) 626 if (flags & UPD_NROF)
509 SockList_AddInt (&sl, op->nrof); 627 sl << uint32 (op->nrof);
510 628
511 Send_With_Handling (&pl->contr->socket, &sl); 629 pl->contr->ns->send_packet (sl);
512 sl.free ();
513} 630}
514 631
515/** 632/**
516 * Sends item's info to player. 633 * Sends item's info to player.
517 */ 634 */
518void 635void
519esrv_send_item (object *pl, object *op) 636esrv_send_item (object *pl, object *op)
520{ 637{
521 SockList sl; 638 if (!pl->contr->ns)
522
523 /* If this is not the player object, do some more checks */
524 if (op != pl)
525 {
526 /* We only send 'visibile' objects to the client */
527 if (!LOOK_OBJ (op))
528 return; 639 return;
529 /* if the item is on the ground, mark that the look needs to 640
530 * be updated. 641 /* We only send 'visible' objects to the client, and sometimes the player */
531 */ 642 if (!op->client_visible () && op->type != PLAYER)
532 if (!op->env)
533 {
534 pl->contr->socket.update_look = 1;
535 return; 643 return;
536 }
537 }
538 644
539 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 645 packet sl;
540 646
541 sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd); 647 sl.printf ("item%d ", pl->contr->ns->itemcmd);
542 sl.len = strlen ((char *) sl.buf);
543 648
544 if (op->head)
545 op = op->head; 649 op = op->head_ ();
546 650
547 SockList_AddInt (&sl, op->env ? op->env->count : 0); 651 sl << uint32 (op->env ? op->env->count : 0);
548 652
549 add_object_to_socklist (pl->contr->socket, sl, op); 653 add_object_to_socklist (*pl->contr->ns, sl, op);
550 654
551 Send_With_Handling (&pl->contr->socket, &sl); 655 pl->contr->ns->send_packet (sl);
552 SET_FLAG (op, FLAG_CLIENT_SENT); 656 SET_FLAG (op, FLAG_CLIENT_SENT);
553
554 sl.free ();
555} 657}
556 658
557/** 659/**
558 * Tells the client to delete an item. Uses the item 660 * Tells the client to delete an item.
559 * command with a -1 location.
560 */ 661 */
561
562void 662void
563esrv_del_item (player *pl, int tag) 663esrv_del_item (player *pl, int tag)
564{ 664{
565 SockList sl; 665 if (!pl->ns)
666 return;
566 667
567 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 668 packet sl ("delitem");
568 669
569 strcpy ((char *) sl.buf, "delitem "); 670 sl << uint32 (tag);
570 sl.len = strlen ((char *) sl.buf);
571 SockList_AddInt (&sl, tag);
572 671
573 Send_With_Handling (&pl->socket, &sl); 672 pl->ns->send_packet (sl);
574 sl.free ();
575} 673}
576 674
577 675
578/******************************************************************************* 676/*******************************************************************************
579 * 677 *
583 681
584/** 682/**
585 * Takes a player and object count (tag) and returns the actual object 683 * Takes a player and object count (tag) and returns the actual object
586 * pointer, or null if it can't be found. 684 * pointer, or null if it can't be found.
587 */ 685 */
588
589object * 686object *
590esrv_get_ob_from_count (object *pl, tag_t count) 687esrv_get_ob_from_count (object *pl, tag_t count)
591{ 688{
592 object *op, *tmp;
593
594 if (pl->count == count) 689 if (pl->count == count)
595 return pl; 690 return pl;
596 691
597 for (op = pl->inv; op; op = op->below) 692 for (object *op = pl->inv; op; op = op->below)
598 if (op->count == count) 693 if (op->count == count)
599 return op; 694 return op;
600 else if (op->type == CONTAINER && pl->container == op) 695 else if (op->type == CONTAINER && pl->container == op)
601 for (tmp = op->inv; tmp; tmp = tmp->below) 696 for (object *tmp = op->inv; tmp; tmp = tmp->below)
602 if (tmp->count == count) 697 if (tmp->count == count)
603 return tmp; 698 return tmp;
604 699
605 for (op = get_map_ob (pl->map, pl->x, pl->y); op; op = op->above) 700 for (object *op = GET_MAP_OB (pl->map, pl->x, pl->y); op; op = op->above)
606 if (op->head != NULL && op->head->count == count) 701 if (op->head && op->head->count == count)
607 return op; 702 return op;
608 else if (op->count == count) 703 else if (op->count == count)
609 return op; 704 return op;
610 else if (op->type == CONTAINER && pl->container == op) 705 else if (op->type == CONTAINER && pl->container == op)
611 for (tmp = op->inv; tmp; tmp = tmp->below) 706 for (object *tmp = op->inv; tmp; tmp = tmp->below)
612 if (tmp->count == count) 707 if (tmp->count == count)
613 return tmp; 708 return tmp;
614 709
710#if 0
711 /* If the high bit is set, player examined a pseudo object. */
712 if (count & 0x80000000)
713 return 0;
714#endif
715
615 return NULL; 716 return 0;
616} 717}
617
618 718
619/** Client wants to examine some object. So lets do so. */ 719/** Client wants to examine some object. So lets do so. */
620void 720void
621ExamineCmd (char *buf, int len, player *pl) 721ExamineCmd (char *buf, int len, player *pl)
622{ 722{
623 tag_t tag = atoi (buf); 723 tag_t tag = atoi (buf);
624
625 /* If the high bit is set, player examined a pseudo object. */
626 if (tag & 0x80000000)
627 return;
628
629 object *op = esrv_get_ob_from_count (pl->ob, tag);
630
631 if (!op)
632 {
633 LOG (llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", &pl->ob->name, tag);
634 return;
635 }
636
637 examine (pl->ob, op);
638}
639
640/** Client wants to apply some object. Lets do so. */
641void
642ApplyCmd (char *buf, int len, player *pl)
643{
644 tag_t tag = atoi (buf);
645
646 /* sort of a hack, but if the player saves and the player then manually
647 * applies a savebed (or otherwise tries to do stuff), we run into trouble.
648 */
649 if (QUERY_FLAG (pl->ob, FLAG_REMOVED))
650 return;
651 724
652 /* If the high bit is set, player applied a pseudo object. */ 725 /* If the high bit is set, player applied a pseudo object. */
653 if (tag & 0x80000000) 726 if (tag & 0x80000000)
654 { 727 {
655 pl->socket.look_position = tag & 0x7fffffff; 728 pl->ns->look_position = tag & 0x7fffffff;
656 pl->socket.update_look = 1; 729 pl->ns->floorbox_update ();
657 return; 730 return;
658 } 731 }
659 732
660 object *op = esrv_get_ob_from_count (pl->ob, tag); 733 object *op = esrv_get_ob_from_count (pl->ob, tag);
661 734
662 if (!op) 735 if (!op)
663 { 736 {
737 LOG (llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", &pl->ob->name, tag);
738 return;
739 }
740
741 examine (pl->ob, op);
742}
743
744/** Client wants to examine some object. So lets do so. */
745void
746ExCmd (char *buf, int len, player *pl)
747{
748 tag_t tag = atoi (buf);
749
750 if (object *op = esrv_get_ob_from_count (pl->ob, tag))
751 {
752 std::string s = op->describe (pl->ob);
753
754 if (msg_is_special (s.c_str (), false))
755 cfperl_expand_cfpod (pl, s);
756
757 packet sl ("ex");
758 sl << ber32 (tag) << s.c_str ();
759
760 pl->ns->send_packet (sl);
761 }
762}
763
764/** Client wants to apply some object. Lets do so. */
765void
766ApplyCmd (char *buf, int len, player *pl)
767{
768 tag_t tag = atoi (buf);
769
770 /* If the high bit is set, player applied a pseudo object. */
771 if (tag & 0x80000000)
772 {
773 pl->ns->look_position = tag & 0x7fffffff;
774 pl->ns->floorbox_update ();
775 return;
776 }
777
778 object *op = esrv_get_ob_from_count (pl->ob, tag);
779
780 if (!op)
781 {
664 LOG (llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", &pl->ob->name, tag); 782 LOG (llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", &pl->ob->name, tag);
665 return; 783 return;
666 } 784 }
667 785
668 player_apply (pl->ob, op, 0, 0); 786 player_apply (pl->ob, op, 0, 0);
669} 787}
670 788
671/** Client wants to apply some object. Lets do so. */ 789/** Client wants to lock some object. Lets do so. */
672void 790void
673LockItem (uint8 *data, int len, player *pl) 791LockItem (char *data, int len, player *pl)
674{ 792{
675 int flag = data[0]; 793 int flag = data[0];
676 tag_t tag = net_uint32 (data + 1); 794 tag_t tag = net_uint32 ((uint8 *)data + 1);
677 object *op = esrv_get_ob_from_count (pl->ob, tag); 795 object *op = esrv_get_ob_from_count (pl->ob, tag);
678 796
679 if (!op) 797 if (!op)
680 { 798 {
681 new_draw_info (NDI_UNIQUE, 0, pl->ob, "Could not find object to lock/unlock"); 799 pl->failmsg ("Could not find object to lock/unlock");
682 return; 800 return;
683 } 801 }
684 802
685 if (!flag) 803 if (!flag)
686 CLEAR_FLAG (op, FLAG_INV_LOCKED); 804 CLEAR_FLAG (op, FLAG_INV_LOCKED);
688 SET_FLAG (op, FLAG_INV_LOCKED); 806 SET_FLAG (op, FLAG_INV_LOCKED);
689 807
690 esrv_update_item (UPD_FLAGS, pl->ob, op); 808 esrv_update_item (UPD_FLAGS, pl->ob, op);
691} 809}
692 810
693/** Client wants to apply some object. Lets do so. */ 811/** Client wants to mark some object. Lets do so. */
694void 812void
695MarkItem (uint8 * data, int len, player *pl) 813MarkItem (char *data, int len, player *pl)
696{ 814{
697 tag_t tag = net_uint32 (data); 815 tag_t tag = net_uint32 ((uint8 *)data);
698 object *op = esrv_get_ob_from_count (pl->ob, tag); 816 object *op = esrv_get_ob_from_count (pl->ob, tag);
699 817
700 if (!op) 818 if (!op)
701 { 819 {
702 new_draw_info (NDI_UNIQUE, 0, pl->ob, "Could not find object to mark"); 820 pl->failmsg ("Could not find object to mark");
703 return; 821 return;
704 } 822 }
705 823
706 pl->mark = op; 824 pl->mark = op;
707 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "Marked item %s", query_name (op)); 825 pl->ob->statusmsg (format ("Marked item %s", query_name (op)));
708} 826}
709 827
710/** 828/**
711 * look_at prints items on the specified square. 829 * look_at prints items on the specified square.
712 * 830 *
713 * [ removed EARTHWALL check and added check for containers inventory. 831 * [ removed EARTHWALL check and added check for containers inventory.
714 * Tero.Haatanen@lut.fi ] 832 * Tero.Haatanen@lut.fi ]
715 */ 833 */
716void 834static void
717look_at (object *op, int dx, int dy) 835look_at (player *pl, int dx, int dy)
718{ 836{
719 object *tmp; 837 dynbuf_text buf;
720 int flag = 0; 838 object *ob = pl->ob;
721 sint16 x, y;
722 maptile *m;
723 839
724 x = op->x + dx; 840 if (!pl->observe->map)
725 y = op->y + dy;
726
727 if (out_of_map (op->map, x, y))
728 return; 841 return;
729 842
730 m = get_map_from_coord (op->map, &x, &y); 843 mapxy pos (pl->observe);
731 if (!m) 844 pos.move (dx, dy);
845
846 if (pos.normalise ())
847 for (object *tmp = pos->top; tmp; tmp = tmp->below)
848 {
849 if (tmp->invisible && !QUERY_FLAG (ob, FLAG_WIZ))
850 continue;
851
852 if (QUERY_FLAG (ob, FLAG_WIZ))
853 buf.printf ("- %s (%d).\n", query_name (tmp), tmp->count);
854 else
855 buf.printf ("- %s.\n", query_name (tmp));
856
857 object *head = tmp->head_ ();
858
859 if (head->inv)
860 if ((head->type != CONTAINER && head->type != FLESH)
861 || QUERY_FLAG (ob, FLAG_WIZ))
862 buf << head->query_inventory (ob, " ");
863
864 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !QUERY_FLAG (ob, FLAG_WIZ)) /* don't continue under the floor */
865 break;
866 }
867
868 if (buf.empty ())
869 pl->failmsg ("You see nothing there.");
870 else
871 pl->infobox (MSG_CHANNEL ("lookat"), buf);
872}
873
874/** Client wants to look at some object. Lets do so. */
875void
876LookAt (char *buf, int len, player *pl)
877{
878 char *cp;
879
880 int dx = atoi (buf);
881 if (!(cp = strchr (buf, ' ')))
732 return; 882 return;
733 883
734 for (tmp = get_map_ob (m, x, y); tmp != NULL && tmp->above != NULL; tmp = tmp->above);
735
736 for (; tmp != NULL; tmp = tmp->below)
737 {
738 if (tmp->invisible && !QUERY_FLAG (op, FLAG_WIZ))
739 continue;
740
741 if (!flag)
742 {
743 if (dx || dy)
744 new_draw_info (NDI_UNIQUE, 0, op, "There you see:");
745 else
746 {
747 clear_win_info (op);
748 new_draw_info (NDI_UNIQUE, 0, op, "You see:");
749 }
750 flag = 1;
751 }
752
753 if (QUERY_FLAG (op, FLAG_WIZ))
754 new_draw_info_format (NDI_UNIQUE, 0, op, "- %s (%d).", query_name (tmp), tmp->count);
755 else
756 new_draw_info_format (NDI_UNIQUE, 0, op, "- %s.", query_name (tmp));
757
758 if (((tmp->inv != NULL || (tmp->head && tmp->head->inv)) &&
759 (tmp->type != CONTAINER && tmp->type != FLESH)) || QUERY_FLAG (op, FLAG_WIZ))
760 inventory (op, tmp->head == NULL ? tmp : tmp->head);
761
762 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !QUERY_FLAG (op, FLAG_WIZ)) /* don't continue under the floor */
763 break;
764 }
765
766 if (!flag)
767 {
768 if (dx || dy)
769 new_draw_info (NDI_UNIQUE, 0, op, "You see nothing there.");
770 else
771 new_draw_info (NDI_UNIQUE, 0, op, "You see nothing.");
772 }
773}
774
775
776
777/** Client wants to look at some object. Lets do so. */
778void
779LookAt (char *buf, int len, player *pl)
780{
781 int dx, dy;
782 char *cp;
783
784 dx = atoi (buf);
785 if (!(cp = strchr (buf, ' ')))
786 {
787 return;
788 }
789 dy = atoi (cp); 884 int dy = atoi (cp);
790 885
791 if (FABS (dx) > pl->socket.mapx / 2 || FABS (dy) > pl->socket.mapy / 2) 886 if (player *opl = pl->observe->contr)
887 if (client *ns = opl->ns)
888 {
889 if (fabs (dx) > ns->mapx / 2 || fabs (dy) > ns->mapy / 2)
792 return; 890 return;
793 891
794 if (pl->blocked_los[dx + pl->socket.mapx / 2][dy + pl->socket.mapy / 2]) 892 if (opl->blocked_los[dx + ns->mapx / 2][dy + ns->mapy / 2])
795 return; 893 return;
894 }
796 895
797 look_at (pl->ob, dx, dy); 896 look_at (pl, dx, dy);
798} 897}
799 898
800/** Move an object to a new location */ 899/** Move an object to a new location */
801void 900void
802esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof) 901esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof)
803{ 902{
804 object *op, *env;
805
806 op = esrv_get_ob_from_count (pl, tag); 903 object *op = esrv_get_ob_from_count (pl, tag);
807 if (!op) 904 if (!op)
808 { 905 {
809 LOG (llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", &pl->name, tag); 906 LOG (llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", &pl->name, tag);
810 return; 907 return;
811 } 908 }
812 909
813 if (!to) 910 if (!to)
814 { /* drop it to the ground */ 911 { /* drop it to the ground */
815
816/* LOG(llevDebug, "Drop it on the ground.\n");*/
817
818 if (op->map && !op->env) 912 if (op->map && !op->env)
819 {
820
821/* LOG(llevDebug,"Dropping object to ground that is already on ground\n");*/
822 return; 913 return;
823 } 914
824 /* If it is an active container, then we should drop all objects 915 /* If it is an active container, then we should drop all objects
825 * in the container and not the container itself. 916 * in the container and not the container itself.
826 */ 917 */
827 if (op->inv && QUERY_FLAG (op, FLAG_APPLIED)) 918 if (op->inv && QUERY_FLAG (op, FLAG_APPLIED))
828 { 919 {
829 object *current, *next; 920 int cnt = MAX_ITEM_PER_DROP;
830 921
831 for (current = op->inv; current != NULL; current = next) 922 for (object *current = op->inv; current && cnt--; )
832 { 923 {
833 next = current->below; 924 object *next = current->below;
834 drop_object (pl, current, 0); 925 drop_object (pl, current, 0);
926 current = next;
835 } 927 }
836 esrv_update_item (UPD_WEIGHT, pl, op); 928
929 if (cnt <= 0)
930 op->failmsg ("Only dropped some items, can't drop that many items at once.");
837 } 931 }
838 else 932 else
839 {
840 drop_object (pl, op, nrof); 933 drop_object (pl, op, nrof);
841 } 934
842 return; 935 return;
843 } 936 }
844 else if (to == pl->count) 937 else if (to == pl->count)
845 { /* pick it up to the inventory */ 938 { /* pick it up to the inventory */
846 /* return if player has already picked it up */ 939 /* return if player has already picked it up */
849 942
850 pl->contr->count = nrof; 943 pl->contr->count = nrof;
851 pick_up (pl, op); 944 pick_up (pl, op);
852 return; 945 return;
853 } 946 }
947
854 env = esrv_get_ob_from_count (pl, to); 948 object *env = esrv_get_ob_from_count (pl, to);
855 if (!env) 949 if (!env)
856 { 950 {
857 LOG (llevDebug, "Player '%s' tried to move object to the unknown location (%d)\n", &pl->name, to); 951 LOG (llevDebug, "Player '%s' tried to move object to the unknown location (%d)\n", &pl->name, to);
858 return; 952 return;
859 } 953 }
954
860 /* put_object_in_sack presumes that necessary sanity checking 955 /* put_object_in_sack presumes that necessary sanity checking
861 * has already been done (eg, it can be picked up and fits in 956 * has already been done (eg, it can be picked up and fits in
862 * in a sack, so check for those things. We should also check 957 * in a sack, so check for those things. We should also check
863 * an make sure env is in fact a container for that matter. 958 * an make sure env is in fact a container for that matter.
864 */ 959 */
865 if (env->type == CONTAINER && can_pick (pl, op) && sack_can_hold (pl, env, op, nrof)) 960 if (env->type == CONTAINER
866 { 961 && can_pick (pl, op)
962 && sack_can_hold (pl, env, op, nrof))
867 put_object_in_sack (pl, env, op, nrof); 963 put_object_in_sack (pl, env, op, nrof);
868 }
869} 964}
965

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines