ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/item.C
(Generate patch)

Comparing deliantra/server/socket/item.C (file contents):
Revision 1.2 by root, Tue Aug 29 07:34:01 2006 UTC vs.
Revision 1.78 by root, Mon Apr 27 01:38:49 2009 UTC

1
2/* 1/*
3 * static char *rcsid_item_c = 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
4 * "$Id: item.C,v 1.2 2006/08/29 07:34:01 root Exp $"; 3 *
5 */ 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
6
7/*
8 CrossFire, A Multiplayer game for X-windows
9
10 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
12 7 *
13 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
14 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
15 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
16 (at your option) any later version. 11 * (at your option) any later version.
17 12 *
18 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details. 16 * GNU General Public License for more details.
22 17 *
23 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
26 21 * The authors can be reached via e-mail to <support@deliantra.net>
27 The author can be reached via e-mail to crossfire-devel@real-time.com
28*/ 22 */
29 23
30/** 24/**
31 * \file 25 * \file
32 * Client/server logic. 26 * Client/server logic.
33 * 27 *
34 * \date 2003-12-02 28 * \date 2003-12-02
35 * 29 *
36 * This containes item logic for client/server. It doesn't contain 30 * This contains item logic for client/server. It doesn't contain
37 * the actual commands that send the data, but does contain 31 * the actual commands that send the data, but does contain
38 * the logic for what items should be sent. 32 * the logic for what items should be sent.
39 */ 33 */
40 34
41
42#include <global.h> 35#include <global.h>
43#include <object.h> /* LOOK_OBJ */
44#include <newclient.h> 36#include <object.h>
45#include <newserver.h>
46#include <sproto.h> 37#include <sproto.h>
47 38
48/** This is the maximum number of bytes we expect any one item to take up */ 39/** This is the maximum number of bytes we expect any one item to take up */
49#define MAXITEMLEN 300 40#define MAXITEMLEN 300
50 41
… …
53 * Functions related to sending object data to the client. 44 * Functions related to sending object data to the client.
54 * 45 *
55 ******************************************************************************/ 46 ******************************************************************************/
56 47
57/** 48/**
58 * Adds string to socklist.
59 *
60 * This is a simple function that we use a lot here. It basically
61 * adds the specified buffer into the socklist, but prepends a
62 * single byte in length. If the data is longer than that byte, it is
63 * truncated approprately.
64 */
65inline void add_stringlen_to_sockbuf(const char *buf, SockList *sl)
66{
67 int len;
68
69 len=strlen(buf);
70 if (len>255) len=255;
71 SockList_AddChar(sl, (char) len);
72 strncpy((char*)sl->buf+sl->len, buf,len);
73 sl->len += len;
74}
75
76/**
77 * This is a similar to query_name, but returns flags 49 * This is a similar to query_name, but returns flags
78 * to be sended to client. 50 * to be sent to client.
79 */ 51 */
52unsigned int
80unsigned int query_flags (object *op) 53query_flags (object *op)
81{ 54{
82 unsigned int flags = 0; 55 unsigned int flags = 0;
83 56
84 if(QUERY_FLAG(op,FLAG_APPLIED)) { 57 if (QUERY_FLAG (op, FLAG_APPLIED))
85 switch(op->type) { 58 switch (op->type)
59 {
86 case BOW: 60 case BOW:
87 case WAND: 61 case WAND:
88 case ROD: 62 case ROD:
89 case HORN: 63 case HORN:
90 flags = a_readied; 64 flags = a_readied;
91 break; 65 break;
92 case WEAPON: 66 case WEAPON:
93 flags = a_wielded; 67 flags = a_wielded;
94 break; 68 break;
95 case SKILL: 69 case SKILL:
96 case ARMOUR: 70 case ARMOUR:
97 case HELMET: 71 case HELMET:
98 case SHIELD: 72 case SHIELD:
99 case RING: 73 case RING:
100 case BOOTS: 74 case BOOTS:
101 case GLOVES: 75 case GLOVES:
102 case AMULET: 76 case AMULET:
103 case GIRDLE: 77 case GIRDLE:
104 case BRACERS: 78 case BRACERS:
105 case CLOAK: 79 case CLOAK:
106 flags = a_worn; 80 flags = a_worn;
107 break; 81 break;
108 case CONTAINER: 82 case CONTAINER:
109 flags = a_active; 83 flags = a_active;
110 break; 84 break;
111 default: 85 default:
112 flags = a_applied; 86 flags = a_applied;
113 break; 87 break;
114 }
115 } 88 }
89
116 if (op->type == CONTAINER && ((op->env && op->env->container == op) || 90 if (op->type == CONTAINER && ((op->env && op->env->container == op) || (!op->env && QUERY_FLAG (op, FLAG_APPLIED))))
117 (!op->env && QUERY_FLAG(op,FLAG_APPLIED))))
118 flags |= F_OPEN; 91 flags |= F_OPEN;
119 92
120 if (QUERY_FLAG(op,FLAG_KNOWN_CURSED)) { 93 if (QUERY_FLAG (op, FLAG_KNOWN_CURSED))
94 {
121 if(QUERY_FLAG(op,FLAG_DAMNED)) 95 if (QUERY_FLAG (op, FLAG_DAMNED))
122 flags |= F_DAMNED; 96 flags |= F_DAMNED;
123 else if(QUERY_FLAG(op,FLAG_CURSED)) 97 else if (QUERY_FLAG (op, FLAG_CURSED))
124 flags |= F_CURSED; 98 flags |= F_CURSED;
125 } 99 }
100
126 if (QUERY_FLAG(op,FLAG_KNOWN_MAGICAL) && !QUERY_FLAG(op,FLAG_IDENTIFIED)) 101 if (QUERY_FLAG (op, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (op, FLAG_IDENTIFIED))
127 flags |= F_MAGIC; 102 flags |= F_MAGIC;
128 if (QUERY_FLAG(op,FLAG_UNPAID)) 103 if (QUERY_FLAG (op, FLAG_UNPAID))
129 flags |= F_UNPAID; 104 flags |= F_UNPAID;
130 if (QUERY_FLAG(op,FLAG_INV_LOCKED)) 105 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
131 flags |= F_LOCKED; 106 flags |= F_LOCKED;
132 107
133 return flags; 108 return flags;
134} 109}
135 110
136/* Used in the send_look to put object head into SockList 111/* Used in the send_look to put object head into packet
137 * sl for socket ns. Need socket to know if we need to send 112 * sl for socket ns. Need socket to know if we need to send
138 * animation of face to the client. 113 * animation of face to the client.
139 */ 114 */
140static void add_object_to_socklist(NewSocket *ns, SockList *sl, object *head) 115static void
116add_object_to_socklist (client &ns, packet &sl, object *head)
141{ 117{
142 int flags, len, anim_speed;
143 char item_n[MAX_BUF]; 118 char item_n[MAX_BUF];
144 const char *item_p; 119 const char *item_p;
145 120
146 flags = query_flags (head); 121 int flags = query_flags (head);
147 if (QUERY_FLAG(head, FLAG_NO_PICK)) 122 if (QUERY_FLAG (head, FLAG_NO_PICK))
148 flags |= F_NOPICK; 123 flags |= F_NOPICK;
149 124
150 if (!(ns->faces_sent[head->face->number] & NS_FACESENT_FACE)) 125 ns.send_face (head->face, -50);
151 esrv_send_face(ns, head->face->number,0); 126 ns.flush_fx ();
152 127
153 if (QUERY_FLAG(head,FLAG_ANIMATE) && !ns->anims_sent[head->animation_id]) 128 if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id])
154 esrv_send_animation(ns, head->animation_id); 129 ns.send_animation (head->animation_id);
155 130
156 SockList_AddInt(sl, head->count); 131 sl << uint32 (head->count)
157 SockList_AddInt(sl, flags); 132 << uint32 (flags)
158 SockList_AddInt(sl, QUERY_FLAG(head, FLAG_NO_PICK) ? -1 : WEIGHT(head)); 133 << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : head->client_weight ())
159 SockList_AddInt(sl, head->face->number); 134 << uint32 (head->face);
160 135
136 int len;
137
161 if (!head->custom_name) { 138 if (!head->custom_name)
139 {
162 strncpy(item_n,query_base_name(head, 0),127); 140 strncpy (item_n, query_base_name (head, 0), 127);
163 item_n[127]=0; 141 item_n[127] = 0;
164 len=strlen(item_n); 142 len = strlen (item_n);
165 item_p=query_base_name(head, 1); 143 item_p = query_base_name (head, 1);
166 } else { 144 }
145 else
146 {
167 strncpy(item_n,head->custom_name,127); 147 strncpy (item_n, head->custom_name, 127);
168 item_n[127]=0; 148 item_n[127] = 0;
169 len=strlen(item_n); 149 len = strlen (item_n);
170 item_p=head->custom_name; 150 item_p = head->custom_name;
171 } 151 }
152
172 strncpy(item_n+len+1, item_p, 127); 153 strncpy (item_n + len + 1, item_p, 127);
173 item_n[254]=0; 154 item_n[254] = 0;
174 len += strlen(item_n+1+len) + 1; 155 len += strlen (item_n + 1 + len) + 1;
175 SockList_AddChar(sl, (char ) len);
176 memcpy(sl->buf+sl->len, item_n, len);
177 sl->len += len;
178 156
179 SockList_AddShort(sl,head->animation_id); 157 sl << data8 (item_n, len)
180 anim_speed=0; 158 << uint16 (head->animation_id);
181 if (QUERY_FLAG(head,FLAG_ANIMATE)) {
182 if (head->anim_speed) anim_speed=head->anim_speed;
183 else {
184 if (FABS(head->speed)<0.001) anim_speed=255;
185 else if (FABS(head->speed)>=1.0) anim_speed=1;
186 else anim_speed = (int) (1.0/FABS(head->speed));
187 }
188 if (anim_speed>255) anim_speed=255;
189 }
190 SockList_AddChar(sl, (char) anim_speed);
191 SockList_AddInt(sl, head->nrof);
192 159
160 int anim_speed = !head->flag [FLAG_ANIMATE] ? 0
161 : head->anim_speed ? clamp (head->anim_speed, 1, 255)
162 : 1. / clamp (fabs (head->speed), 1./255., 1./1.);
163
164 sl << uint8 (anim_speed)
165 << uint32 (head->nrof);
166
193 if (ns->itemcmd == 2) 167 if (ns.itemcmd == 2)
194 SockList_AddShort(sl, head->client_type); 168 sl << uint16 (head->client_type);
195
196 SET_FLAG(head, FLAG_CLIENT_SENT);
197} 169}
198 170
171static faceidx
172need_face_now (player *pl, const char *name)
173{
174 faceidx face = face_find (name, empty_face);
175
176 pl->ns->send_face (face, -50);
177 pl->ns->flush_fx ();
178
179 return face;
180}
181
182#define FINGER_UP "finger_up.x11"
183#define FINGER_DOWN "finger_down.x11"
199 184
200/** 185/**
201 * Send the look window. Don't need to do animations here 186 * Send the look window. Don't need to do animations here
202 * This sends all the faces to the client, not just updates. This is 187 * This sends all the faces to the client, not just updates. This is
203 * because object ordering would otherwise be inconsistent 188 * because object ordering would otherwise be inconsistent.
204 */ 189 */
205 190void
206void esrv_draw_look(object *pl) 191esrv_draw_look (player *pl)
207{ 192{
208 object *tmp, *last; 193 object *ob = pl->ob;
209 int got_one=0,start_look=0, end_look=0;
210 SockList sl;
211 char buf[MAX_BUF];
212 194
213 if (!pl->contr->socket.update_look) { 195 if (!pl->ns->update_look)
196 {
214 LOG(llevDebug,"esrv_draw_look called when update_look was not set\n"); 197 LOG (llevDebug, "esrv_draw_look called when update_look was not set (player %s)\n", &ob->name);
215 return; 198 return;
216 } else {
217 pl->contr->socket.update_look=0;
218 } 199 }
219 200
220 if(QUERY_FLAG(pl, FLAG_REMOVED) || pl->map == NULL || 201 pl->ns->update_look = 0;
221 pl->map->in_memory != MAP_IN_MEMORY || out_of_map(pl->map,pl->x,pl->y)) 202
203 if (QUERY_FLAG (ob, FLAG_REMOVED)
204 || !ob->map
205 || ob->map->in_memory != MAP_ACTIVE
206 || out_of_map (ob->map, ob->x, ob->y))
222 return; 207 return;
223 208
224 for (tmp=get_map_ob(pl->map,pl->x,pl->y); tmp && tmp->above;tmp=tmp->above) ; 209 pl->ns->send_packet ("delinv 0");
225 210
226 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 211 packet sl;
212 sl.printf ("item%d ", pl->ns->itemcmd);
227 213
228 Write_String_To_Socket(&pl->contr->socket, "delinv 0", strlen("delinv 0")); 214 sl << uint32 (0);
229 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
230 sl.len=strlen((char*)sl.buf);
231 215
232 SockList_AddInt(&sl, 0); 216 int start_pos = pl->ns->look_position;
217 bool dirty = false;
233 218
234 if (!(pl->contr->socket.faces_sent[empty_face->number]&NS_FACESENT_FACE)) 219 mapspace &ms = ob->ms ();
235 esrv_send_face(&pl->contr->socket, empty_face->number,0);
236 220
237 if (pl->contr->socket.look_position) { 221 // manage a ring buffer of the "last FLOORBOX_PAGESIZE" items and
238 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position- NUM_LOOK_OBJECTS)); 222 // start from the top
239 SockList_AddInt(&sl, 0); 223 object *items [FLOORBOX_PAGESIZE];
240 SockList_AddInt(&sl, (uint32) -1); 224 int item_idx = 0, item_cnt = 0;
241 SockList_AddInt(&sl, empty_face->number); 225 int pos = 0;
242 sprintf(buf,"Click here to see %d previous items", NUM_LOOK_OBJECTS); 226
243 add_stringlen_to_sockbuf(buf, &sl); 227 // find our items by walking down
244 SockList_AddShort(&sl,0); 228 object *item = ms.top;
245 SockList_AddChar(&sl, 0); 229
246 SockList_AddInt(&sl, 0); 230 for (; item && item_cnt < FLOORBOX_PAGESIZE; item = item->below)
247 if (pl->contr->socket.itemcmd == 2)
248 SockList_AddShort(&sl, 0);
249 } 231 {
232 if (!item->client_visible ())
233 continue;
250 234
251 for (last=NULL; tmp!=last; tmp=tmp->below) { 235 if (++pos < start_pos)
252 object *head; 236 continue;
253 237
254 if (QUERY_FLAG(tmp, FLAG_IS_FLOOR) && !last) { 238 // record item
255 last = tmp->below; /* assumes double floor mode */ 239 items [item_idx] = item; item_idx = item_idx < FLOORBOX_PAGESIZE ? item_idx + 1 : 0;
256 if (last && QUERY_FLAG(last, FLAG_IS_FLOOR)) 240 item_cnt++;
257 last = last->below; 241
258 } 242 // stop at first floor
259 if (LOOK_OBJ(tmp)) { 243 if (item->flag [FLAG_IS_FLOOR])
260 if (++start_look < pl->contr->socket.look_position) continue; 244 {
261 end_look++; 245 // we are finished, don't append "next group of items"
262 if (end_look > NUM_LOOK_OBJECTS) { 246 // by setting item to ms.bot it becomes zero which is checked after the while loop
247 item = ms.bot;
248 }
249 }
250
251 // see if there are more if we cared - we ignore invisible objects
252 if (item)
253 {
263 /* What we basically do is make a 'fake' object - when the user applies it, 254 /* What we basically do is make a 'fake' object - when the user applies it,
264 * we notice the special tag the object has, and act accordingly. 255 * we notice the special tag the object has, and act accordingly.
265 */ 256 */
266 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position+ NUM_LOOK_OBJECTS)); 257 sl << uint32 (0x80000000 | (start_pos + FLOORBOX_PAGESIZE))
267 SockList_AddInt(&sl, 0); 258 << uint32 (0)
268 SockList_AddInt(&sl, (uint32) -1); 259 << uint32 ((uint32) - 1)
269 SockList_AddInt(&sl, empty_face->number); 260 << uint32 (need_face_now (pl, FINGER_DOWN))
270 sprintf(buf,"Click here to see next group of items"); 261 << data8 ("Apply this to see the items below")
271 add_stringlen_to_sockbuf(buf, &sl); 262 << uint16 (0)
272 SockList_AddShort(&sl,0); 263 << uint8 (0)
273 SockList_AddChar(&sl, 0); 264 << uint32 (0);
274 SockList_AddInt(&sl, 0); 265
275 if (pl->contr->socket.itemcmd == 2) 266 if (pl->ns->itemcmd == 2)
276 SockList_AddShort(&sl, 0); 267 sl << uint16 (0);
277 break; 268
269 dirty = true;
278 } 270 }
279 if (tmp->head) head = tmp->head;
280 else head = tmp;
281 271
272 // now send out all items in the ring buffer in reverse order
273 while (item_cnt)
274 {
275 --item_cnt;
276 item_idx = (item_idx ? item_idx : FLOORBOX_PAGESIZE) - 1;
277 object *item = items [item_idx];
278
282 add_object_to_socklist(&pl->contr->socket, &sl, head); 279 add_object_to_socklist (*pl->ns, sl, item->head_ ());
283 got_one++;
284 280
281 dirty = true;
282
283 // if packet got too large, send it and begin a new one
285 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) { 284 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
286 Send_With_Handling(&pl->contr->socket, &sl); 285 {
287 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 286 pl->ns->send_packet (sl);
288 sl.len=strlen((char*)sl.buf); 287
289 SockList_AddInt(&sl, 0); 288 sl.reset ();
290 got_one=0; 289 sl.printf ("item%d ", pl->ns->itemcmd);
290 sl << uint32 (0);
291
292 dirty = false;
293 }
291 } 294 }
292 } /* If LOOK_OBJ() */ 295
296 if (start_pos)
293 } 297 {
294 if (got_one) 298 sl << uint32 (0x80000000 | (start_pos - FLOORBOX_PAGESIZE))
295 Send_With_Handling(&pl->contr->socket, &sl); 299 << uint32 (0)
300 << sint32 (-1)
301 << uint32 (need_face_now (pl, FINGER_UP))
302 << data8 ("Apply this to see the items higher up")
303 << uint16 (0)
304 << uint8 (0)
305 << uint32 (0);
296 306
297 free(sl.buf); 307 if (pl->ns->itemcmd == 2)
308 sl << uint16 (0);
309
310 dirty = true;
311 }
312
313 if (dirty)
314 pl->ns->send_packet (sl);
298} 315}
299 316
300/** 317/**
301 * Sends whole inventory. 318 * Sends whole inventory.
302 */ 319 */
320void
303void esrv_send_inventory(object *pl, object *op) 321esrv_send_inventory (object *pl, object *op)
304{ 322{
305 object *tmp; 323 if (!pl->contr->ns)//D
324 return;
325
306 int got_one=0; 326 int got_one = 0;
307 SockList sl; 327
328 pl->contr->ns->send_packet_printf ("delinv %d", op->count);
329
330 packet sl;
331 sl.printf ("item%d ", pl->contr->ns->itemcmd);
332
333 sl << uint32 (op->count);
334
335 for (object *tmp = op->inv; tmp; tmp = tmp->below)
308 336 {
309 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
310
311 sprintf((char*)sl.buf,"delinv %d", op->count);
312 sl.len=strlen((char*)sl.buf);
313 Send_With_Handling(&pl->contr->socket, &sl);
314
315 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
316 sl.len=strlen((char*)sl.buf);
317
318 SockList_AddInt(&sl, op->count);
319
320 for (tmp=op->inv; tmp; tmp=tmp->below) {
321 object *head; 337 object *head;
322 338
323 if (tmp->head) head = tmp->head; 339 if (tmp->head)
324 else head = tmp; 340 head = tmp->head;
341 else
342 head = tmp;
325 343
326 if (LOOK_OBJ(head)) { 344 if (head->client_visible ())
327 add_object_to_socklist(&pl->contr->socket, &sl, head);
328 345 {
346 add_object_to_socklist (*pl->contr->ns, sl, head);
347
329 got_one++; 348 got_one++;
330 349
331 /* IT is possible for players to accumulate a huge amount of 350 /* IT is possible for players to accumulate a huge amount of
332 * items (especially with some of the bags out there) to 351 * items (especially with some of the bags out there) to
333 * overflow the buffer. IF so, send multiple item commands. 352 * overflow the buffer. IF so, send multiple item commands.
334 */ 353 */
335 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) { 354 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
336 Send_With_Handling(&pl->contr->socket, &sl); 355 {
337 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 356 pl->contr->ns->send_packet (sl);
338 sl.len=strlen((char*)sl.buf); 357
339 SockList_AddInt(&sl, op->count); 358 sl.reset ();
340 got_one=0; 359 sl.printf ("item%d ", pl->contr->ns->itemcmd);
360 sl << uint32 (op->count);
361 got_one = 0;
362 }
363 }
341 } 364 }
342 } /* If LOOK_OBJ() */ 365
343 }
344 if (got_one) 366 if (got_one)
345 Send_With_Handling(&pl->contr->socket, &sl); 367 pl->contr->ns->send_packet (sl);
346 free(sl.buf);
347} 368}
348 369
349/** 370/**
350 * Updates object *op for player *pl. 371 * Updates object *op for player *pl.
351 * 372 *
352 * flags is a list of values to update 373 * flags is a list of values to update
353 * to the client (as defined in newclient.h - might as well use the 374 * to the client (as defined in newclient.h - might as well use the
354 * same value both places. 375 * same value both places.
355 */ 376 */
356 377void
357void esrv_update_item(int flags, object *pl, object *op) 378esrv_update_item (int flags, object *pl, object *op)
358{ 379{
359 SockList sl;
360
361 /* If we have a request to send the player item, skip a few checks. */ 380 /* If we have a request to send the player item, skip a few checks. */
362 if (op!=pl) { 381 if (op != pl && !op->client_visible ())
363 if (! LOOK_OBJ(op))
364 return; 382 return;
365 /* we remove the check for op->env, because in theory, the object
366 * is hopefully in the same place, so the client should preserve
367 * order.
368 */
369 }
370 if (!QUERY_FLAG(op, FLAG_CLIENT_SENT)) {
371 /* FLAG_CLIENT_SENT is debug only. We are using it to see where
372 * this is happening - we can set a breakpoint here in the debugger
373 * and track back the call.
374 */
375 LOG(llevDebug,"We have not sent item %s (%d)\n", op->name, op->count);
376 }
377 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
378 383
379 strcpy((char*)sl.buf,"upditem "); 384 client *ns = pl->contr->ns;
380 sl.len=strlen((char*)sl.buf); 385 if (!ns)
386 return;
381 387
382 SockList_AddChar(&sl, (char) flags); 388 packet sl ("upditem");
383 389
384 if (op->head) op=op->head; 390 sl << uint8 (flags);
385 391
386 SockList_AddInt(&sl, op->count); 392 op = op->head_ ();
387 393
394 sl << uint32 (op->count);
395
388 if (flags & UPD_LOCATION) 396 if (flags & UPD_LOCATION)
389 SockList_AddInt(&sl, op->env? op->env->count:0); 397 sl << uint32 (op->env ? op->env->count : 0);
390 398
391 if (flags & UPD_FLAGS) 399 if (flags & UPD_FLAGS)
392 SockList_AddInt(&sl, query_flags(op)); 400 sl << uint32 (query_flags (op));
393 401
394 if (flags & UPD_WEIGHT) { 402 if (flags & UPD_WEIGHT)
395 sint32 weight = WEIGHT(op);
396
397 SockList_AddInt(&sl, QUERY_FLAG(op, FLAG_NO_PICK) ? -1 : weight);
398 if (pl == op) {
399 op->contr->last_weight = weight;
400 }
401 } 403 {
404 sint32 weight = op->client_weight ();
402 405
406 if (op == pl)
407 ns->last_weight = weight;
408
409 sl << uint32 (weight);
410 }
411
403 if (flags & UPD_FACE) { 412 if (flags & UPD_FACE)
404 if (!(pl->contr->socket.faces_sent[op->face->number] & NS_FACESENT_FACE))
405 esrv_send_face(&pl->contr->socket, op->face->number,0);
406 SockList_AddInt(&sl, op->face->number);
407 } 413 {
414 ns->send_face (op->face, -50);
415 ns->flush_fx ();
416 sl << uint32 (op->face);
417 }
418
408 if (flags & UPD_NAME) { 419 if (flags & UPD_NAME)
409 int len; 420 {
421 int len;
410 const char *item_p; 422 const char *item_p;
411 char item_n[MAX_BUF]; 423 char item_n[127 * 2];
412 424
413 if (!op->custom_name) { 425 if (!op->custom_name)
414 strncpy(item_n,query_base_name(op, 0),127); 426 {
415 item_n[127]=0; 427 len = assign (item_n, query_base_name (op, 0), 127);
416 len=strlen(item_n);
417 item_p=query_base_name(op, 1); 428 item_p = query_base_name (op, 1);
418 } 429 }
419 else { 430 else
420 strncpy(item_n,op->custom_name,127); 431 {
421 item_n[127]=0; 432 len = assign (item_n, &op->custom_name, 127);
422 len=strlen(item_n);
423 item_p=op->custom_name; 433 item_p = &op->custom_name;
424 } 434 }
425 435
426 strncpy(item_n+len+1, item_p, 127); 436 len += assign (item_n + len, item_p, 127);
427 item_n[254]=0; 437
428 len += strlen(item_n+1+len) + 1; 438 sl << data8 (item_n, len);
429 SockList_AddChar(&sl, (char)len);
430 memcpy(sl.buf+sl.len, item_n, len);
431 sl.len += len;
432 } 439 }
440
433 if (flags & UPD_ANIM) 441 if (flags & UPD_ANIM)
434 SockList_AddShort(&sl,op->animation_id); 442 sl << uint16 (op->animation_id);
435 443
436 if (flags & UPD_ANIMSPEED) { 444 if (flags & UPD_ANIMSPEED)
445 {
437 int anim_speed=0; 446 int anim_speed = 0;
447
438 if (QUERY_FLAG(op,FLAG_ANIMATE)) { 448 if (QUERY_FLAG (op, FLAG_ANIMATE))
439 if (op->anim_speed) anim_speed=op->anim_speed; 449 {
440 else { 450 if (op->anim_speed)
441 if (FABS(op->speed)<0.001) anim_speed=255; 451 anim_speed = op->anim_speed;
442 else if (FABS(op->speed)>=1.0) anim_speed=1; 452 else
443 else anim_speed = (int) (1.0/FABS(op->speed)); 453 {
454 if (fabs (op->speed) < 0.001)
455 anim_speed = 255;
456 else if (fabs (op->speed) >= 1.0)
457 anim_speed = 1;
458 else
459 anim_speed = (int) (1.0 / fabs (op->speed));
460 }
461
462 if (anim_speed > 255)
463 anim_speed = 255;
464 }
465
466 sl << uint8 (anim_speed);
444 } 467 }
445 if (anim_speed>255) anim_speed=255; 468
446 }
447 SockList_AddChar(&sl, (char)anim_speed);
448 }
449 if (flags & UPD_NROF) 469 if (flags & UPD_NROF)
450 SockList_AddInt(&sl, op->nrof); 470 sl << uint32 (op->nrof);
451 471
452 Send_With_Handling(&pl->contr->socket, &sl); 472 pl->contr->ns->send_packet (sl);
453 free(sl.buf);
454} 473}
455 474
456/** 475/**
457 * Sends item's info to player. 476 * Sends item's info to player.
458 */ 477 */
478void
459void esrv_send_item(object *pl, object*op) 479esrv_send_item (object *pl, object *op)
460{ 480{
461 SockList sl; 481 if (!pl->contr->ns)
462
463 /* If this is not the player object, do some more checks */
464 if (op!=pl) {
465 /* We only send 'visibile' objects to the client */
466 if (! LOOK_OBJ(op))
467 return; 482 return;
468 /* if the item is on the ground, mark that the look needs to 483
469 * be updated. 484 /* We only send 'visible' objects to the client, and sometimes the player */
470 */ 485 if (!op->client_visible () && op->type != PLAYER)
471 if (!op->env) {
472 pl->contr->socket.update_look=1;
473 return; 486 return;
474 }
475 }
476 487
477 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 488 packet sl;
478 489
479 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 490 sl.printf ("item%d ", pl->contr->ns->itemcmd);
480 sl.len=strlen((char*)sl.buf);
481 491
482 if (op->head) op=op->head; 492 op = op->head_ ();
483 493
484 SockList_AddInt(&sl, op->env? op->env->count:0); 494 sl << uint32 (op->env ? op->env->count : 0);
485 495
486 add_object_to_socklist(&pl->contr->socket, &sl, op); 496 add_object_to_socklist (*pl->contr->ns, sl, op);
487 497
488 Send_With_Handling(&pl->contr->socket, &sl); 498 pl->contr->ns->send_packet (sl);
489 SET_FLAG(op, FLAG_CLIENT_SENT);
490 free(sl.buf);
491} 499}
492 500
493/** 501/**
494 * Tells the client to delete an item. Uses the item 502 * Tells the client to delete an item.
495 * command with a -1 location.
496 */ 503 */
497 504void
498void esrv_del_item(player *pl, int tag) 505esrv_del_item (player *pl, int tag)
499{ 506{
500 SockList sl; 507 if (!pl->ns)
508 return;
501 509
502 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 510 packet sl ("delitem");
503 511
504 strcpy((char*)sl.buf,"delitem "); 512 sl << uint32 (tag);
505 sl.len=strlen((char*)sl.buf);
506 SockList_AddInt(&sl, tag);
507 513
508 Send_With_Handling(&pl->socket, &sl); 514 pl->ns->send_packet (sl);
509 free(sl.buf);
510} 515}
511 516
512 517
513/******************************************************************************* 518/*******************************************************************************
514 * 519 *
… …
518 523
519/** 524/**
520 * Takes a player and object count (tag) and returns the actual object 525 * Takes a player and object count (tag) and returns the actual object
521 * pointer, or null if it can't be found. 526 * pointer, or null if it can't be found.
522 */ 527 */
523 528object *
524object *esrv_get_ob_from_count(object *pl, tag_t count) 529esrv_get_ob_from_count (object *pl, tag_t count)
525{ 530{
526 object *op, *tmp; 531 if (pl->count == count)
532 return pl;
527 533
534 for (object *op = pl->inv; op; op = op->below)
528 if (pl->count == count) 535 if (op->count == count)
529 return pl;
530
531 for(op = pl->inv; op; op = op->below)
532 if (op->count == count)
533 return op; 536 return op;
534 else if (op->type == CONTAINER && pl->container == op) 537 else if (op->type == CONTAINER && pl->container == op)
535 for(tmp = op->inv; tmp; tmp = tmp->below) 538 for (object *tmp = op->inv; tmp; tmp = tmp->below)
536 if (tmp->count == count) 539 if (tmp->count == count)
537 return tmp; 540 return tmp;
538 541
539 for(op = get_map_ob (pl->map, pl->x, pl->y); op; op = op->above) 542 for (object *op = GET_MAP_OB (pl->map, pl->x, pl->y); op; op = op->above)
540 if (op->head != NULL && op->head->count == count) 543 if (op->head && op->head->count == count)
541 return op; 544 return op;
542 else if (op->count == count) 545 else if (op->count == count)
543 return op; 546 return op;
544 else if (op->type == CONTAINER && pl->container == op) 547 else if (op->type == CONTAINER && pl->container == op)
545 for(tmp = op->inv; tmp; tmp = tmp->below) 548 for (object *tmp = op->inv; tmp; tmp = tmp->below)
546 if (tmp->count == count) 549 if (tmp->count == count)
547 return tmp; 550 return tmp;
548 551
552#if 0
553 /* If the high bit is set, player examined a pseudo object. */
554 if (count & 0x80000000)
549 return NULL; 555 return 0;
550} 556#endif
551 557
558 return 0;
559}
552 560
553/** Client wants to examine some object. So lets do so. */ 561/** Client wants to examine some object. So lets do so. */
562void
554void ExamineCmd(char *buf, int len,player *pl) 563ExamineCmd (char *buf, int len, player *pl)
555{ 564{
556 long tag = atoi(buf); 565 tag_t tag = atoi (buf);
566
567 /* If the high bit is set, player applied a pseudo object. */
568 if (tag & 0x80000000)
569 {
570 pl->ns->look_position = tag & 0x7fffffff;
571 pl->ns->floorbox_update ();
572 return;
573 }
574
557 object *op = esrv_get_ob_from_count(pl->ob, tag); 575 object *op = esrv_get_ob_from_count (pl->ob, tag);
558 576
559 if (!op) { 577 if (!op)
578 {
560 LOG(llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", 579 LOG (llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", &pl->ob->name, tag);
561 pl->ob->name, tag); 580 return;
562 return;
563 } 581 }
582
564 examine (pl->ob, op); 583 examine (pl->ob, op);
565} 584}
566 585
586/** Client wants to examine some object. So lets do so. */
587void
588ExCmd (char *buf, int len, player *pl)
589{
590 tag_t tag = atoi (buf);
591
592 if (object *op = esrv_get_ob_from_count (pl->ob, tag))
593 {
594 std::string s = op->describe (pl->ob);
595
596 packet sl ("ex");
597 sl << ber32 (tag)
598 << data (*pl->expand_cfpod (s.c_str ()));
599
600 pl->ns->send_packet (sl);
601 }
602}
603
567/** Client wants to apply some object. Lets do so. */ 604/** Client wants to apply some object. Lets do so. */
605void
568void ApplyCmd(char *buf, int len,player *pl) 606ApplyCmd (char *buf, int len, player *pl)
569{ 607{
570 uint32 tag = atoi(buf); 608 tag_t tag = atoi (buf);
571 object *op = esrv_get_ob_from_count(pl->ob, tag);
572 609
573 /* sort of a hack, but if the player saves and the player then manually
574 * applies a savebed (or otherwise tries to do stuff), we run into trouble.
575 */
576 if (QUERY_FLAG(pl->ob, FLAG_REMOVED)) return;
577
578 /* If the high bit is set, player applied a pseudo object. */ 610 /* If the high bit is set, player applied a pseudo object. */
579 if (tag & 0x80000000) { 611 if (tag & 0x80000000)
612 {
580 pl->socket.look_position = tag & 0x7fffffff; 613 pl->ns->look_position = tag & 0x7fffffff;
581 pl->socket.update_look = 1; 614 pl->ns->floorbox_update ();
582 return; 615 return;
583 } 616 }
584 617
618 object *op = esrv_get_ob_from_count (pl->ob, tag);
619
585 if (!op) { 620 if (!op)
621 {
586 LOG(llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", 622 LOG (llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", &pl->ob->name, tag);
587 pl->ob->name, tag); 623 return;
588 return;
589 } 624 }
625
590 player_apply (pl->ob, op, 0, 0); 626 player_apply (pl->ob, op, 0, 0);
591} 627}
592 628
593/** Client wants to apply some object. Lets do so. */ 629/** Client wants to lock some object. Lets do so. */
630void
594void LockItem(uint8 *data, int len,player *pl) 631LockItem (char *data, int len, player *pl)
595{ 632{
596 int flag, tag;
597 object *op;
598
599 flag = data[0]; 633 int flag = data[0];
600 tag = GetInt_String(data+1); 634 tag_t tag = net_uint32 ((uint8 *)data + 1);
601 op = esrv_get_ob_from_count(pl->ob, tag); 635 object *op = esrv_get_ob_from_count (pl->ob, tag);
602 636
603 if (!op) { 637 if (!op)
604 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to lock/unlock");
605 return;
606 } 638 {
639 pl->failmsg ("Could not find object to lock/unlock");
640 return;
641 }
642
607 if (!flag) 643 if (!flag)
608 CLEAR_FLAG(op,FLAG_INV_LOCKED); 644 CLEAR_FLAG (op, FLAG_INV_LOCKED);
609 else 645 else
610 SET_FLAG(op,FLAG_INV_LOCKED); 646 SET_FLAG (op, FLAG_INV_LOCKED);
647
611 esrv_update_item(UPD_FLAGS, pl->ob, op); 648 esrv_update_item (UPD_FLAGS, pl->ob, op);
612} 649}
613 650
614/** Client wants to apply some object. Lets do so. */ 651/** Client wants to mark some object. Lets do so. */
652void
615void MarkItem(uint8 *data, int len,player *pl) 653MarkItem (char *data, int len, player *pl)
616{ 654{
617 int tag; 655 tag_t tag = net_uint32 ((uint8 *)data);
618 object *op;
619
620 tag = GetInt_String(data);
621 op = esrv_get_ob_from_count(pl->ob, tag); 656 object *op = esrv_get_ob_from_count (pl->ob, tag);
657
622 if (!op) { 658 if (!op)
623 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to mark");
624 return;
625 } 659 {
660 pl->failmsg ("Could not find object to mark");
661 return;
662 }
663
626 pl->mark = op; 664 pl->mark = op;
627 pl->mark_count = op->count; 665 pl->ob->statusmsg (format ("Marked item %s", query_name (op)));
628 new_draw_info_format(NDI_UNIQUE, 0, pl->ob, "Marked item %s", query_name(op));
629} 666}
630
631 667
632/** 668/**
633 * look_at prints items on the specified square. 669 * look_at prints items on the specified square.
634 * 670 *
635 * [ removed EARTHWALL check and added check for containers inventory. 671 * [ removed EARTHWALL check and added check for containers inventory.
636 * Tero.Haatanen@lut.fi ] 672 * Tero.Haatanen@lut.fi ]
637 */ 673 */
638void look_at(object *op,int dx,int dy) { 674static void
639 object *tmp; 675look_at (player *pl, int dx, int dy)
640 int flag=0; 676{
641 sint16 x,y; 677 dynbuf_text &buf = msg_dynbuf; buf.clear ();
642 mapstruct *m; 678 object *ob = pl->ob;
643 679
644 x = op->x + dx; 680 if (!pl->observe->map)
645 y = op->y + dy; 681 return;
646 682
647 if (out_of_map(op->map, x, y)) return; 683 bool wiz = ob->flag [FLAG_WIZ] || ob->flag [FLAG_WIZLOOK];
648 684
649 m = get_map_from_coord(op->map, &x, &y); 685 mapxy pos (pl->observe);
650 if (!m) return; 686 pos.move (dx, dy);
651 687
652 for(tmp=get_map_ob(m, x ,y);tmp!=NULL&&tmp->above!=NULL; 688 if (wiz)
653 tmp=tmp->above); 689 {
690 if (pos.normalise ())
691 {
692 mapspace &ms = *pos;
693 ms.update ();
654 694
655 for ( ; tmp != NULL; tmp=tmp->below ) { 695 buf.printf (" map: %s%+d%+d (%+d%+d)\n"
656 if (tmp->invisible && !QUERY_FLAG(op, FLAG_WIZ)) continue; 696 " smell %u/%u; flags %x; light %d; block %x; slow %x; on %x; off %x; volume %lld\n\n",
657 697 &pos.m->path, pos.x, pos.y, dx, dy,
658 if(!flag) { 698 (unsigned int)ms.smell, (unsigned int)mapspace::smellcount, ms.flags (), ms.light,
659 if(dx||dy) 699 ms.move_block, ms.move_slow, ms.move_on, ms.move_off, (long long)ms.volume ()
660 new_draw_info(NDI_UNIQUE, 0,op,"There you see:"); 700 );
701 }
661 else { 702 else
662 clear_win_info(op); 703 buf << "off-map\n\n";
663 new_draw_info(NDI_UNIQUE, 0,op,"You see:");
664 } 704 }
665 flag=1;
666 }
667 705
668 if (QUERY_FLAG(op, FLAG_WIZ)) 706 int darkness = pl->blocked_los (dx, dy);
669 new_draw_info_format(NDI_UNIQUE,0, op, "- %s (%d).",query_name(tmp),tmp->count); 707
708 if (darkness == LOS_BLOCKED)
709 buf << "You cannot see that place from your position. H<Something is in between or it is too far away.>";
710 else if (darkness == LOS_MAX)
711 buf << "That place is too dark to see anything. H<Move nearer or find better lighting.>";
670 else 712 else
671 new_draw_info_format(NDI_UNIQUE,0, op, "- %s.",query_name(tmp));
672
673 if (((tmp->inv!=NULL || (tmp->head && tmp->head->inv)) &&
674 (tmp->type != CONTAINER && tmp->type!=FLESH)) || QUERY_FLAG(op, FLAG_WIZ))
675 inventory(op,tmp->head==NULL?tmp:tmp->head);
676
677 if(QUERY_FLAG(tmp, FLAG_IS_FLOOR)&&!QUERY_FLAG(op, FLAG_WIZ)) /* don't continue under the floor */
678 break;
679 } 713 {
714 if (pos.normalise ())
715 for (object *tmp = pos->top; tmp; tmp = tmp->below)
716 {
717 if (tmp->invisible && !QUERY_FLAG (ob, FLAG_WIZ))
718 continue;
680 719
681 if(!flag) { 720 if (wiz)
682 if(dx||dy) 721 buf.printf (" - %s (%d).\n", query_name (tmp), tmp->count);
683 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing there."); 722 else
684 else 723 buf.printf (" - %s.\n", query_name (tmp));
685 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing.");
686 }
687}
688 724
725 object *head = tmp->head_ ();
689 726
727 if (head->inv)
728 if ((head->type != CONTAINER && head->type != FLESH)
729 || QUERY_FLAG (ob, FLAG_WIZ))
730 buf << head->query_inventory (ob, " ");
731
732 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !wiz) /* don't continue under the floor */
733 break;
734 }
735 }
736
737 if (buf.empty ())
738 buf << "You see nothing there.";
739
740 pl->infobox (MSG_CHANNEL ("lookat"), buf);
741}
690 742
691/** Client wants to look at some object. Lets do so. */ 743/** Client wants to look at some object. Lets do so. */
744void
692void LookAt(char *buf, int len,player *pl) 745LookAt (char *buf, int len, player *pl)
693{ 746{
694 int dx, dy;
695 char *cp; 747 char *cp;
696 748
697 dx=atoi(buf); 749 int dx = atoi (buf);
698 if (!(cp=strchr(buf,' '))) { 750 if (!(cp = strchr (buf, ' ')))
699 return; 751 return;
700 } 752
701 dy=atoi(cp); 753 int dy = atoi (cp);
702 754
703 if (FABS(dx) > pl->socket.mapx / 2 || FABS(dy) > pl->socket.mapy / 2)
704 return;
705
706 if(pl->blocked_los[dx + pl->socket.mapx / 2][dy + pl->socket.mapy / 2])
707 return;
708
709 look_at(pl->ob, dx, dy); 755 look_at (pl, dx, dy);
710} 756}
711 757
712/** Move an object to a new location */ 758/** Move an object to a new location */
759void
713void esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof) 760esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof)
714{ 761{
715 object *op, *env;
716
717 op = esrv_get_ob_from_count(pl, tag); 762 object *op = esrv_get_ob_from_count (pl, tag);
718 if (!op) { 763 if (!op)
764 {
719 LOG(llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", 765 LOG (llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", &pl->name, tag);
720 pl->name, tag);
721 return;
722 }
723
724 if (!to) { /* drop it to the ground */
725/* LOG(llevDebug, "Drop it on the ground.\n");*/
726
727 if (op->map && !op->env) {
728/* LOG(llevDebug,"Dropping object to ground that is already on ground\n");*/
729 return; 766 return;
730 }
731 /* If it is an active container, then we should drop all objects
732 * in the container and not the container itself.
733 */
734 if (op->inv && QUERY_FLAG(op, FLAG_APPLIED)) {
735 object *current, *next;
736 for (current=op->inv; current!=NULL; current=next) {
737 next=current->below;
738 drop_object(pl, current, 0);
739 } 767 }
740 esrv_update_item(UPD_WEIGHT, pl, op);
741 }
742 else {
743 drop_object (pl, op, nrof);
744 }
745 return;
746 } else if (to == pl->count) { /* pick it up to the inventory */
747 /* return if player has already picked it up */
748 if (op->env == pl) return;
749 768
750 pl->contr->count = nrof; 769 if (!to)
751 pick_up(pl, op); 770 { /* drop it to the ground */
752 return ; 771 if (op->map && !op->env)
753 }
754 env = esrv_get_ob_from_count(pl, to);
755 if (!env) {
756 LOG(llevDebug,
757 "Player '%s' tried to move object to the unknown location (%d)\n",
758 pl->name, to);
759 return; 772 return;
773
774 /* If it is an active container, then we should drop all objects
775 * in the container and not the container itself.
776 */
777 if (op->inv && QUERY_FLAG (op, FLAG_APPLIED))
778 {
779 int cnt = MAX_ITEM_PER_DROP;
780
781 for (object *current = op->inv; current && cnt--; )
782 {
783 object *next = current->below;
784 drop_object (pl, current, 0);
785 current = next;
786 }
787
788 if (cnt <= 0)
789 op->failmsg ("Only dropped some items, can't drop that many items at once.");
790 }
791 else
792 drop_object (pl, op, nrof);
793
794 return;
795 }
796 else if (to == pl->count)
797 { /* pick it up to the inventory */
798 /* return if player has already picked it up */
799 if (op->env == pl)
800 return;
801
802 pl->contr->count = nrof;
803 pick_up (pl, op);
804 return;
805 }
806
807 object *env = esrv_get_ob_from_count (pl, to);
808 if (!env)
760 } 809 {
810 LOG (llevDebug, "Player '%s' tried to move object to the unknown location (%d)\n", &pl->name, to);
811 return;
812 }
813
761 /* put_object_in_sack presumes that necessary sanity checking 814 /* put_object_in_sack presumes that necessary sanity checking
762 * has already been done (eg, it can be picked up and fits in 815 * has already been done (eg, it can be picked up and fits in
763 * in a sack, so check for those things. We should also check 816 * in a sack, so check for those things. We should also check
764 * an make sure env is in fact a container for that matter. 817 * an make sure env is in fact a container for that matter.
765 */ 818 */
766 if (env->type == CONTAINER 819 if (env->type == CONTAINER
820 && can_pick (pl, op)
767 && can_pick(pl, op) && sack_can_hold(pl, env, op, nrof)) { 821 && sack_can_hold (pl, env, op, nrof))
768 put_object_in_sack (pl, env, op, nrof); 822 put_object_in_sack (pl, env, op, nrof);
769 }
770} 823}
771 824
772

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines