--- deliantra/server/socket/item.C	2006/12/14 00:13:26	1.13
+++ deliantra/server/socket/item.C	2006/12/14 00:23:59	1.14
@@ -49,27 +49,6 @@
  ******************************************************************************/
 
 /**
- * Adds string to socklist.
- *
- * This is a simple function that we use a lot here.  It basically
- * adds the specified buffer into the socklist, but prepends a
- * single byte in length.  If the data is longer than that byte, it is
- * truncated approprately.
- */
-inline void
-add_stringlen_to_sockbuf (const char *buf, SockList * sl)
-{
-  int len;
-
-  len = strlen (buf);
-  if (len > 255)
-    len = 255;
-  SockList_AddChar (sl, (char) len);
-  strncpy ((char *) sl->buf + sl->len, buf, len);
-  sl->len += len;
-}
-
-/**
  *  This is a similar to query_name, but returns flags
  *  to be sended to client. 
  */
@@ -236,7 +215,8 @@
       || out_of_map (pl->map, pl->x, pl->y))
     return;
 
-  for (tmp = get_map_ob (pl->map, pl->x, pl->y); tmp && tmp->above; tmp = tmp->above);
+  for (tmp = get_map_ob (pl->map, pl->x, pl->y); tmp && tmp->above; tmp = tmp->above)
+    ;
 
   SockList sl (MAXSOCKBUF);
 
@@ -289,19 +269,23 @@
               /* What we basically do is make a 'fake' object - when the user applies it,
                * we notice the special tag the object has, and act accordingly.
                */
-              SockList_AddInt (&sl, 0x80000000 | (pl->contr->socket.look_position + NUM_LOOK_OBJECTS));
-              SockList_AddInt (&sl, 0);
-              SockList_AddInt (&sl, (uint32) - 1);
-              SockList_AddInt (&sl, empty_face->number);
-              sprintf (buf, "Click here to see next group of items");
-              add_stringlen_to_sockbuf (buf, &sl);
-              SockList_AddShort (&sl, 0);
-              SockList_AddChar (&sl, 0);
-              SockList_AddInt (&sl, 0);
+              sl << uint32 (0x80000000 | (pl->contr->socket.look_position + NUM_LOOK_OBJECTS))
+                 << uint32 (0)
+                 << uint32 ((uint32) - 1)
+                 << uint32 (empty_face->number);
+
+              sl.printf ("Click here to see next group of items");
+
+              sl << uint16 (0)
+                 << uint8  (0)
+                 << uint32 (0);
+
               if (pl->contr->socket.itemcmd == 2)
-                SockList_AddShort (&sl, 0);
+                sl << uint16 (0);
+
               break;
             }
+
           if (tmp->head)
             head = tmp->head;
           else
@@ -313,9 +297,10 @@
           if (sl.len >= (MAXSOCKBUF - MAXITEMLEN))
             {
               Send_With_Handling (&pl->contr->socket, &sl);
-              sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd);
-              sl.len = strlen ((char *) sl.buf);
-              SockList_AddInt (&sl, 0);
+
+              sl.reset ();
+              sl.printf ("item%d ", pl->contr->socket.itemcmd);
+              sl << uint32 (0);
               got_one = 0;
             }
         }                       /* If LOOK_OBJ() */
@@ -335,18 +320,16 @@
 {
   object *tmp;
   int got_one = 0;
-  SockList sl;
 
-  sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
+  SockList sl (MAXSOCKBUF);
 
-  sprintf ((char *) sl.buf, "delinv %d", op->count);
-  sl.len = strlen ((char *) sl.buf);
+  sl.printf ("delinv %d", op->count);
   Send_With_Handling (&pl->contr->socket, &sl);
 
-  sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd);
-  sl.len = strlen ((char *) sl.buf);
+  sl.reset ();
+  sl.printf ("item%d ", pl->contr->socket.itemcmd);
 
-  SockList_AddInt (&sl, op->count);
+  sl << uint32 (op->count);
 
   for (tmp = op->inv; tmp; tmp = tmp->below)
     {
@@ -372,13 +355,15 @@
               Send_With_Handling (&pl->contr->socket, &sl);
               sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd);
               sl.len = strlen ((char *) sl.buf);
-              SockList_AddInt (&sl, op->count);
+              sl << uint32 (op->count);
               got_one = 0;
             }
         }                       /* If LOOK_OBJ() */
     }
+
   if (got_one)
     Send_With_Handling (&pl->contr->socket, &sl);
+
   sl.free ();
 }
 
@@ -393,8 +378,6 @@
 void
 esrv_update_item (int flags, object *pl, object *op)
 {
-  SockList sl;
-
   /* If we have a request to send the player item, skip a few checks. */
   if (op != pl)
     {
@@ -415,40 +398,38 @@
       LOG (llevDebug, "We have not sent item %s (%d)\n", &op->name, op->count);
     }
 
-  sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
-
-  strcpy ((char *) sl.buf, "upditem ");
-  sl.len = strlen ((char *) sl.buf);
+  SockList sl (MAXSOCKBUF);
 
-  SockList_AddChar (&sl, (char) flags);
+  sl << "upditem "
+     << uint8 (flags);
 
   if (op->head)
     op = op->head;
 
-  SockList_AddInt (&sl, op->count);
+  sl << uint32 (op->count);
 
   if (flags & UPD_LOCATION)
-    SockList_AddInt (&sl, op->env ? op->env->count : 0);
+    sl << uint32 (op->env ? op->env->count : 0);
 
   if (flags & UPD_FLAGS)
-    SockList_AddInt (&sl, query_flags (op));
+    sl << uint32 (query_flags (op));
 
   if (flags & UPD_WEIGHT)
     {
       sint32 weight = WEIGHT (op);
 
-      SockList_AddInt (&sl, QUERY_FLAG (op, FLAG_NO_PICK) ? -1 : weight);
+      sl << uint32 (QUERY_FLAG (op, FLAG_NO_PICK) ? -1 : weight);
+
       if (pl == op)
-        {
-          op->contr->last_weight = weight;
-        }
+        op->contr->last_weight = weight;
     }
 
   if (flags & UPD_FACE)
     {
       if (!(pl->contr->socket.faces_sent[op->face->number] & NS_FACESENT_FACE))
         esrv_send_face (&pl->contr->socket, op->face->number, 0);
-      SockList_AddInt (&sl, op->face->number);
+
+      sl << uint32 (op->face->number);
     }
 
   if (flags & UPD_NAME)
@@ -475,13 +456,12 @@
       strncpy (item_n + len + 1, item_p, 127);
       item_n[254] = 0;
       len += strlen (item_n + 1 + len) + 1;
-      SockList_AddChar (&sl, (char) len);
-      memcpy (sl.buf + sl.len, item_n, len);
-      sl.len += len;
+
+      sl << data8 (item_n, len);
     }
 
   if (flags & UPD_ANIM)
-    SockList_AddShort (&sl, op->animation_id);
+    sl << uint16 (op->animation_id);
 
   if (flags & UPD_ANIMSPEED)
     {
@@ -500,13 +480,16 @@
               else
                 anim_speed = (int) (1.0 / FABS (op->speed));
             }
+
           if (anim_speed > 255)
             anim_speed = 255;
         }
-      SockList_AddChar (&sl, (char) anim_speed);
+
+      sl << uint8  (anim_speed);
     }
+
   if (flags & UPD_NROF)
-    SockList_AddInt (&sl, op->nrof);
+    sl << uint32 (op->nrof);
 
   Send_With_Handling (&pl->contr->socket, &sl);
   sl.free ();
@@ -518,8 +501,6 @@
 void
 esrv_send_item (object *pl, object *op)
 {
-  SockList sl;
-
   /* If this is not the player object, do some more checks */
   if (op != pl)
     {
@@ -536,15 +517,14 @@
         }
     }
 
-  sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
+  SockList sl (MAXSOCKBUF);
 
-  sprintf ((char *) sl.buf, "item%d ", pl->contr->socket.itemcmd);
-  sl.len = strlen ((char *) sl.buf);
+  sl.printf ("item%d ", pl->contr->socket.itemcmd);
 
   if (op->head)
     op = op->head;
 
-  SockList_AddInt (&sl, op->env ? op->env->count : 0);
+  sl << uint32 (op->env ? op->env->count : 0);
 
   add_object_to_socklist (pl->contr->socket, sl, op);
 
@@ -562,13 +542,10 @@
 void
 esrv_del_item (player *pl, int tag)
 {
-  SockList sl;
-
-  sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
+  SockList sl (MAXSOCKBUF);
 
-  strcpy ((char *) sl.buf, "delitem ");
-  sl.len = strlen ((char *) sl.buf);
-  SockList_AddInt (&sl, tag);
+  sl << "delitem "
+     << uint32 (tag);
 
   Send_With_Handling (&pl->socket, &sl);
   sl.free ();
@@ -812,15 +789,9 @@
 
   if (!to)
     {                           /* drop it to the ground */
-
-/*	LOG(llevDebug, "Drop it on the ground.\n");*/
-
       if (op->map && !op->env)
-        {
+        return;
 
-/*	    LOG(llevDebug,"Dropping object to ground that is already on ground\n");*/
-          return;
-        }
       /* If it is an active container, then we should drop all objects
        * in the container and not the container itself.
        */
@@ -833,6 +804,7 @@
               next = current->below;
               drop_object (pl, current, 0);
             }
+
           esrv_update_item (UPD_WEIGHT, pl, op);
         }
       else
@@ -851,12 +823,14 @@
       pick_up (pl, op);
       return;
     }
+
   env = esrv_get_ob_from_count (pl, to);
   if (!env)
     {
       LOG (llevDebug, "Player '%s' tried to move object to the unknown location (%d)\n", &pl->name, to);
       return;
     }
+
   /* put_object_in_sack presumes that necessary sanity checking
    * has already been done (eg, it can be picked up and fits in
    * in a sack, so check for those things.  We should also check
@@ -867,3 +841,4 @@
       put_object_in_sack (pl, env, op, nrof);
     }
 }
+