ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/item.C
(Generate patch)

Comparing deliantra/server/socket/item.C (file contents):
Revision 1.3 by root, Tue Aug 29 08:01:38 2006 UTC vs.
Revision 1.105 by root, Wed Nov 14 23:24:27 2018 UTC

1
2/* 1/*
3 * static char *rcsid_item_c = 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
4 * "$Id: item.C,v 1.3 2006/08/29 08:01:38 root Exp $";
5 */ 3 *
6 4 * Copyright (©) 2018 Marc Alexander Lehmann / the Deliantra team
7/* 5 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
8 CrossFire, A Multiplayer game for X-windows
9
10 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 6 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 7 * Copyright (©) 1992 Frank Tore Johansen
12 8 *
13 This program is free software; you can redistribute it and/or modify 9 * Deliantra is free software: you can redistribute it and/or modify it under
14 it under the terms of the GNU General Public License as published by 10 * the terms of the Affero GNU General Public License as published by the
15 the Free Software Foundation; either version 2 of the License, or 11 * Free Software Foundation, either version 3 of the License, or (at your
16 (at your option) any later version. 12 * option) any later version.
17 13 *
18 This program is distributed in the hope that it will be useful, 14 * This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of 15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details. 17 * GNU General Public License for more details.
22 18 *
23 You should have received a copy of the GNU General Public License 19 * You should have received a copy of the Affero GNU General Public License
24 along with this program; if not, write to the Free Software 20 * and the GNU General Public License along with this program. If not, see
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 21 * <http://www.gnu.org/licenses/>.
26 22 *
27 The author can be reached via e-mail to crossfire-devel@real-time.com 23 * The authors can be reached via e-mail to <support@deliantra.net>
28*/ 24 */
29 25
30/** 26/**
31 * \file 27 * \file
32 * Client/server logic. 28 * Client/server logic.
33 * 29 *
34 * \date 2003-12-02 30 * \date 2003-12-02
35 * 31 *
36 * This containes item logic for client/server. It doesn't contain 32 * This contains item logic for client/server. It doesn't contain
37 * the actual commands that send the data, but does contain 33 * the actual commands that send the data, but does contain
38 * the logic for what items should be sent. 34 * the logic for what items should be sent.
39 */ 35 */
40 36
41
42#include <global.h> 37#include <global.h>
43#include <object.h> /* LOOK_OBJ */
44#include <newclient.h> 38#include <object.h>
45#include <newserver.h>
46#include <sproto.h> 39#include <sproto.h>
47 40
48/** This is the maximum number of bytes we expect any one item to take up */ 41/** This is the maximum number of bytes we expect any one item to take up */
49#define MAXITEMLEN 300 42#define MAXITEMLEN 300
50 43
… …
53 * Functions related to sending object data to the client. 46 * Functions related to sending object data to the client.
54 * 47 *
55 ******************************************************************************/ 48 ******************************************************************************/
56 49
57/** 50/**
58 * Adds string to socklist.
59 *
60 * This is a simple function that we use a lot here. It basically
61 * adds the specified buffer into the socklist, but prepends a
62 * single byte in length. If the data is longer than that byte, it is
63 * truncated approprately.
64 */
65inline void add_stringlen_to_sockbuf(const char *buf, SockList *sl)
66{
67 int len;
68
69 len=strlen(buf);
70 if (len>255) len=255;
71 SockList_AddChar(sl, (char) len);
72 strncpy((char*)sl->buf+sl->len, buf,len);
73 sl->len += len;
74}
75
76/**
77 * This is a similar to query_name, but returns flags 51 * This is a similar to query_name, but returns flags
78 * to be sended to client. 52 * to be sent to client.
79 */ 53 */
54static unsigned int
80unsigned int query_flags (object *op) 55query_flags (object *op)
81{ 56{
82 unsigned int flags = 0; 57 unsigned int flags = 0;
83 58
84 if(QUERY_FLAG(op,FLAG_APPLIED)) { 59 if (op->flag [FLAG_APPLIED])
85 switch(op->type) { 60 switch (op->type)
61 {
86 case BOW: 62 case BOW:
87 case WAND: 63 case WAND:
88 case ROD: 64 case ROD:
89 case HORN: 65 case HORN:
90 flags = a_readied; 66 flags = a_readied;
91 break; 67 break;
92 case WEAPON: 68 case WEAPON:
93 flags = a_wielded; 69 flags = a_wielded;
94 break; 70 break;
95 case SKILL: 71 case SKILL:
96 case ARMOUR: 72 case ARMOUR:
97 case HELMET: 73 case HELMET:
98 case SHIELD: 74 case SHIELD:
99 case RING: 75 case RING:
100 case BOOTS: 76 case BOOTS:
101 case GLOVES: 77 case GLOVES:
102 case AMULET: 78 case AMULET:
103 case GIRDLE: 79 case GIRDLE:
104 case BRACERS: 80 case BRACERS:
105 case CLOAK: 81 case CLOAK:
106 flags = a_worn; 82 flags = a_worn;
107 break; 83 break;
108 case CONTAINER: 84 case CONTAINER:
109 flags = a_active; 85 flags = a_active;
110 break; 86 break;
111 default: 87 default:
112 flags = a_applied; 88 flags = a_applied;
113 break; 89 break;
114 } 90 }
115 } 91
116 if (op->type == CONTAINER && ((op->env && op->env->container == op) || 92 if (op->is_open_container ())
117 (!op->env && QUERY_FLAG(op,FLAG_APPLIED))))
118 flags |= F_OPEN; 93 flags |= F_OPEN;
94
95 if (op->flag [FLAG_KNOWN_CURSED])
119 96 {
120 if (QUERY_FLAG(op,FLAG_KNOWN_CURSED)) { 97 if (op->flag [FLAG_DAMNED])
121 if(QUERY_FLAG(op,FLAG_DAMNED))
122 flags |= F_DAMNED; 98 flags |= F_DAMNED;
123 else if(QUERY_FLAG(op,FLAG_CURSED)) 99 else if (op->flag [FLAG_CURSED])
124 flags |= F_CURSED; 100 flags |= F_CURSED;
125 } 101 }
126 if (QUERY_FLAG(op,FLAG_KNOWN_MAGICAL) && !QUERY_FLAG(op,FLAG_IDENTIFIED)) 102
103 if (op->flag [FLAG_KNOWN_MAGICAL] && !op->flag [FLAG_IDENTIFIED])
127 flags |= F_MAGIC; 104 flags |= F_MAGIC;
128 if (QUERY_FLAG(op,FLAG_UNPAID)) 105 if (op->flag [FLAG_UNPAID])
129 flags |= F_UNPAID; 106 flags |= F_UNPAID;
130 if (QUERY_FLAG(op,FLAG_INV_LOCKED)) 107 if (op->flag [FLAG_INV_LOCKED])
131 flags |= F_LOCKED; 108 flags |= F_LOCKED;
132 109
133 return flags; 110 return flags;
134} 111}
135 112
136/* Used in the send_look to put object head into SockList 113/* Used in the send_look to put object head into packet
137 * sl for socket ns. Need socket to know if we need to send 114 * sl for socket ns. Need socket to know if we need to send
138 * animation of face to the client. 115 * animation of face to the client.
139 */ 116 */
140static void add_object_to_socklist(NewSocket *ns, SockList *sl, object *head) 117static void
118add_object_to_socklist (client &ns, packet &sl, object *head)
141{ 119{
142 int flags, len, anim_speed;
143 char item_n[MAX_BUF];
144 const char *item_p;
145
146 flags = query_flags (head); 120 int flags = query_flags (head);
147 if (QUERY_FLAG(head, FLAG_NO_PICK)) 121
122 if (head->flag [FLAG_NO_PICK])
148 flags |= F_NOPICK; 123 flags |= F_NOPICK;
149 124
150 if (!(ns->faces_sent[head->face->number] & NS_FACESENT_FACE)) 125 ns.send_face (head->face, -50);
151 esrv_send_face(ns, head->face->number,0);
152 126
153 if (QUERY_FLAG(head,FLAG_ANIMATE) && !ns->anims_sent[head->animation_id]) 127 if (head->flag [FLAG_ANIMATE] && !ns.anims_sent[head->animation_id])
154 esrv_send_animation(ns, head->animation_id); 128 ns.send_animation (head->animation_id);
155 129
156 SockList_AddInt(sl, head->count); 130 sl << uint32 (head->count)
157 SockList_AddInt(sl, flags); 131 << uint32 (flags)
158 SockList_AddInt(sl, QUERY_FLAG(head, FLAG_NO_PICK) ? -1 : WEIGHT(head)); 132 << uint32 (head->flag [FLAG_NO_PICK] ? -1 : head->client_weight ())
159 SockList_AddInt(sl, head->face->number); 133 << uint32 (head->face);
160 134
161 if (!head->custom_name) { 135 if (!head->custom_name)
162 strncpy(item_n,query_base_name(head, 0),127);
163 item_n[127]=0;
164 len=strlen(item_n);
165 item_p=query_base_name(head, 1);
166 } else {
167 strncpy(item_n,head->custom_name,127);
168 item_n[127]=0;
169 len=strlen(item_n);
170 item_p=head->custom_name;
171 } 136 {
172 strncpy(item_n+len+1, item_p, 127); 137 const char *name;
173 item_n[254]=0; 138 uint8 *len = sl.cur++; // patch up length later
174 len += strlen(item_n+1+len) + 1;
175 SockList_AddChar(sl, (char ) len);
176 memcpy(sl->buf+sl->len, item_n, len);
177 sl->len += len;
178 139
179 SockList_AddShort(sl,head->animation_id); 140 name = query_base_name (head, 0); sl << data_n (name, min (127, strlen (name)));
180 anim_speed=0; 141 sl << uint8 (0);
181 if (QUERY_FLAG(head,FLAG_ANIMATE)) { 142 name = query_base_name (head, 1); sl << data_n (name, min (127, strlen (name)));
182 if (head->anim_speed) anim_speed=head->anim_speed; 143
144 *len = sl.cur - len - 1;
145 }
146 else
147 {
148 int len = min (127, head->custom_name.length ());
149
150 sl << uint8 (len * 2 + 1)
151 << data_n (head->custom_name, len)
152 << uint8 (0)
153 << data_n (head->custom_name, len);
154 }
155
156 sl << uint16 (head->animation_id);
157
158 int anim_speed = !head->flag [FLAG_ANIMATE] ? 0
159 : head->anim_speed ? clamp (head->anim_speed, 1, 255)
160 : 1. / clamp (head->speed, 1./255., 1./1.);
161
162 sl << uint8 (anim_speed)
163 << uint32 (head->nrof);
164
165 if (ns.itemcmd == 2)
166 sl << uint16 (head->client_type);
167}
168
169static faceidx
170need_face_now (player *pl, const char *name)
171{
172 faceidx face = face_find (name, empty_face);
173
174 pl->ns->send_face (face, -50);
175 pl->ns->flush_fx ();
176
177 return face;
178}
179
180#define FINGER_UP "finger_up.x11"
181#define FINGER_DOWN "finger_down.x11"
182
183/**
184 * Send the look window. Don't need to do animations here
185 * This sends all the faces to the client, not just updates. This is
186 * because object ordering would otherwise be inconsistent.
187 */
188void
189esrv_draw_look (player *pl)
190{
191 object *ob = pl->ob;
192
193 if (!pl->ns->update_look)
194 {
195 LOG (llevDebug, "esrv_draw_look called when update_look was not set (player %s)\n", &ob->name);
196 return;
197 }
198
199 if (pl->ns->need_delinv0)
200 {
201 pl->ns->need_delinv0 = 0;
202 pl->ns->send_packet ("delinv 0");
203 }
204
205 if (pl->run_on)
206 return;
207
208 pl->ns->update_look = 0;
209 pl->ns->need_delinv0 = 1;
210
211 if (ob->flag [FLAG_REMOVED]
212 || !ob->map
213 || ob->map->state != MAP_ACTIVE
214 || out_of_map (ob->map, ob->x, ob->y))
215 return;
216
217 packet sl;
218 sl.printf ("item%d ", pl->ns->itemcmd);
219
220 sl << uint32 (0);
221
222 int start_pos = pl->ns->look_position;
223 bool dirty = false;
224
225 mapspace &ms = ob->ms ();
226
227 // manage a ring buffer of the "last FLOORBOX_PAGESIZE" items and
228 // start from the top
229 object *items [FLOORBOX_PAGESIZE];
230 int item_idx = 0, item_cnt = 0;
231 int pos = 0;
232
233 // find our items by walking down
234 object *item = ms.top;
235
236 for (; item && item_cnt < FLOORBOX_PAGESIZE; item = item->below)
237 {
238 if (!item->client_visible ())
239 continue;
240
241 if (++pos < start_pos)
242 continue;
243
244 // record item
245 items [item_idx] = item; item_idx = item_idx < FLOORBOX_PAGESIZE ? item_idx + 1 : 0;
246 item_cnt++;
247
248 // stop at first floor
249 if (item->flag [FLAG_IS_FLOOR])
183 else { 250 {
184 if (FABS(head->speed)<0.001) anim_speed=255; 251 // we are finished, don't append "next group of items"
185 else if (FABS(head->speed)>=1.0) anim_speed=1; 252 // by setting item to ms.bot it becomes zero which is checked after the while loop
186 else anim_speed = (int) (1.0/FABS(head->speed)); 253 item = ms.bot;
187 } 254 }
188 if (anim_speed>255) anim_speed=255; 255 }
256
257 // see if there are more if we cared - we ignore invisible objects
258 if (item)
189 } 259 {
190 SockList_AddChar(sl, (char) anim_speed); 260 /* What we basically do is make a 'fake' object - when the user applies it,
191 SockList_AddInt(sl, head->nrof); 261 * we notice the special tag the object has, and act accordingly.
262 */
263 sl << uint32 (0x80000000 | (start_pos + FLOORBOX_PAGESIZE))
264 << uint32 (0)
265 << uint32 ((uint32) - 1)
266 << uint32 (need_face_now (pl, FINGER_DOWN))
267 << data8 ("Apply this to see the items below")
268 << uint16 (0)
269 << uint8 (0)
270 << uint32 (0);
192 271
193 if (ns->itemcmd == 2) 272 if (pl->ns->itemcmd == 2)
194 SockList_AddShort(sl, head->client_type); 273 sl << uint16 (0);
195 274
196 SET_FLAG(head, FLAG_CLIENT_SENT); 275 dirty = true;
197} 276 }
198 277
199 278 // now send out all items in the ring buffer in reverse order
200/** 279 while (item_cnt)
201 * Send the look window. Don't need to do animations here
202 * This sends all the faces to the client, not just updates. This is
203 * because object ordering would otherwise be inconsistent
204 */
205
206void esrv_draw_look(object *pl)
207{
208 object *tmp, *last;
209 int got_one=0,start_look=0, end_look=0;
210 SockList sl;
211 char buf[MAX_BUF];
212
213 if (!pl->contr->socket.update_look) {
214 LOG(llevDebug,"esrv_draw_look called when update_look was not set\n");
215 return;
216 } else {
217 pl->contr->socket.update_look=0;
218 } 280 {
281 --item_cnt;
282 item_idx = (item_idx ? item_idx : FLOORBOX_PAGESIZE) - 1;
283 object *item = items [item_idx];
219 284
220 if(QUERY_FLAG(pl, FLAG_REMOVED) || pl->map == NULL || 285 add_object_to_socklist (*pl->ns, sl, item->head_ ());
221 pl->map->in_memory != MAP_IN_MEMORY || out_of_map(pl->map,pl->x,pl->y))
222 return;
223 286
224 for (tmp=get_map_ob(pl->map,pl->x,pl->y); tmp && tmp->above;tmp=tmp->above) ; 287 dirty = true;
225 288
226 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 289 // if packet got too large, send it and begin a new one
290 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
291 {
292 pl->ns->flush_fx ();
293 pl->ns->send_packet (sl);
227 294
228 Write_String_To_Socket(&pl->contr->socket, "delinv 0", strlen("delinv 0")); 295 sl.reset ();
229 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 296 sl.printf ("item%d ", pl->ns->itemcmd);
230 sl.len=strlen((char*)sl.buf); 297 sl << uint32 (0);
231 298
232 SockList_AddInt(&sl, 0); 299 dirty = false;
233
234 if (!(pl->contr->socket.faces_sent[empty_face->number]&NS_FACESENT_FACE))
235 esrv_send_face(&pl->contr->socket, empty_face->number,0);
236
237 if (pl->contr->socket.look_position) {
238 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position- NUM_LOOK_OBJECTS));
239 SockList_AddInt(&sl, 0);
240 SockList_AddInt(&sl, (uint32) -1);
241 SockList_AddInt(&sl, empty_face->number);
242 sprintf(buf,"Click here to see %d previous items", NUM_LOOK_OBJECTS);
243 add_stringlen_to_sockbuf(buf, &sl);
244 SockList_AddShort(&sl,0);
245 SockList_AddChar(&sl, 0);
246 SockList_AddInt(&sl, 0);
247 if (pl->contr->socket.itemcmd == 2)
248 SockList_AddShort(&sl, 0);
249 }
250
251 for (last=NULL; tmp!=last; tmp=tmp->below) {
252 object *head;
253
254 if (QUERY_FLAG(tmp, FLAG_IS_FLOOR) && !last) {
255 last = tmp->below; /* assumes double floor mode */
256 if (last && QUERY_FLAG(last, FLAG_IS_FLOOR))
257 last = last->below;
258 } 300 }
259 if (LOOK_OBJ(tmp)) { 301 }
260 if (++start_look < pl->contr->socket.look_position) continue; 302
261 end_look++; 303 if (start_pos)
262 if (end_look > NUM_LOOK_OBJECTS) {
263 /* What we basically do is make a 'fake' object - when the user applies it,
264 * we notice the special tag the object has, and act accordingly.
265 */
266 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position+ NUM_LOOK_OBJECTS));
267 SockList_AddInt(&sl, 0);
268 SockList_AddInt(&sl, (uint32) -1);
269 SockList_AddInt(&sl, empty_face->number);
270 sprintf(buf,"Click here to see next group of items");
271 add_stringlen_to_sockbuf(buf, &sl);
272 SockList_AddShort(&sl,0);
273 SockList_AddChar(&sl, 0);
274 SockList_AddInt(&sl, 0);
275 if (pl->contr->socket.itemcmd == 2)
276 SockList_AddShort(&sl, 0);
277 break;
278 }
279 if (tmp->head) head = tmp->head;
280 else head = tmp;
281
282 add_object_to_socklist(&pl->contr->socket, &sl, head);
283 got_one++;
284
285 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) {
286 Send_With_Handling(&pl->contr->socket, &sl);
287 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
288 sl.len=strlen((char*)sl.buf);
289 SockList_AddInt(&sl, 0);
290 got_one=0;
291 }
292 } /* If LOOK_OBJ() */
293 } 304 {
294 if (got_one) 305 sl << uint32 (0x80000000 | (start_pos - FLOORBOX_PAGESIZE))
295 Send_With_Handling(&pl->contr->socket, &sl); 306 << uint32 (0)
307 << sint32 (-1)
308 << uint32 (need_face_now (pl, FINGER_UP))
309 << data8 ("Apply this to see the items higher up")
310 << uint16 (0)
311 << uint8 (0)
312 << uint32 (0);
296 313
297 free(sl.buf); 314 if (pl->ns->itemcmd == 2)
315 sl << uint16 (0);
316
317 dirty = true;
318 }
319
320 if (dirty)
321 {
322 pl->ns->flush_fx ();
323 pl->ns->send_packet (sl);
324 }
298} 325}
299 326
300/** 327/**
301 * Sends whole inventory. 328 * Sends whole inventory.
302 */ 329 */
330void
303void esrv_send_inventory(object *pl, object *op) 331esrv_send_inventory (object *pl, object *op)
304{ 332{
305 object *tmp; 333 if (!pl->contr->ns)//D
334 return;
335
306 int got_one=0; 336 int got_one = 0;
307 SockList sl; 337
338 pl->contr->ns->send_packet_printf ("delinv %d", op->count);
339
340 packet sl;
341 sl.printf ("item%d ", pl->contr->ns->itemcmd);
342
343 sl << uint32 (op->count);
344
345 for (object *tmp = op->inv; tmp; tmp = tmp->below)
308 346 {
309 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
310
311 sprintf((char*)sl.buf,"delinv %d", op->count);
312 sl.len=strlen((char*)sl.buf);
313 Send_With_Handling(&pl->contr->socket, &sl);
314
315 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
316 sl.len=strlen((char*)sl.buf);
317
318 SockList_AddInt(&sl, op->count);
319
320 for (tmp=op->inv; tmp; tmp=tmp->below) {
321 object *head; 347 object *head;
322 348
349 if (tmp->head)
323 if (tmp->head) head = tmp->head; 350 head = tmp->head;
351 else
324 else head = tmp; 352 head = tmp;
325 353
326 if (LOOK_OBJ(head)) { 354 if (head->client_visible ())
327 add_object_to_socklist(&pl->contr->socket, &sl, head);
328 355 {
356 add_object_to_socklist (*pl->contr->ns, sl, head);
357
329 got_one++; 358 got_one++;
330 359
331 /* IT is possible for players to accumulate a huge amount of 360 /* IT is possible for players to accumulate a huge amount of
332 * items (especially with some of the bags out there) to 361 * items (especially with some of the bags out there) to
333 * overflow the buffer. IF so, send multiple item commands. 362 * overflow the buffer. IF so, send multiple item commands.
334 */ 363 */
335 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) { 364 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
336 Send_With_Handling(&pl->contr->socket, &sl); 365 {
366 pl->contr->ns->flush_fx ();
367 pl->contr->ns->send_packet (sl);
368
369 sl.reset ();
337 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 370 sl.printf ("item%d ", pl->contr->ns->itemcmd);
338 sl.len=strlen((char*)sl.buf); 371 sl << uint32 (op->count);
339 SockList_AddInt(&sl, op->count);
340 got_one=0; 372 got_one = 0;
341 } 373 }
342 } /* If LOOK_OBJ() */ 374 }
343 } 375 }
376
344 if (got_one) 377 if (got_one)
345 Send_With_Handling(&pl->contr->socket, &sl); 378 {
346 free(sl.buf); 379 pl->contr->ns->flush_fx ();
380 pl->contr->ns->send_packet (sl);
381 }
347} 382}
348 383
349/** 384/**
350 * Updates object *op for player *pl. 385 * Updates object *op for player *pl.
351 * 386 *
352 * flags is a list of values to update 387 * flags is a list of values to update
353 * to the client (as defined in newclient.h - might as well use the 388 * to the client (as defined in newclient.h - might as well use the
354 * same value both places. 389 * same value both places.
355 */ 390 */
356 391void
357void esrv_update_item(int flags, object *pl, object *op) 392esrv_update_item (int flags, object *pl, object *op)
358{ 393{
359 SockList sl;
360
361 /* If we have a request to send the player item, skip a few checks. */ 394 /* If we have a request to send the player item, skip a few checks. */
362 if (op!=pl) { 395 if (op != pl && !op->client_visible ())
363 if (! LOOK_OBJ(op)) 396 return;
364 return;
365 /* we remove the check for op->env, because in theory, the object
366 * is hopefully in the same place, so the client should preserve
367 * order.
368 */
369 }
370 if (!QUERY_FLAG(op, FLAG_CLIENT_SENT)) {
371 /* FLAG_CLIENT_SENT is debug only. We are using it to see where
372 * this is happening - we can set a breakpoint here in the debugger
373 * and track back the call.
374 */
375 LOG(llevDebug,"We have not sent item %s (%d)\n", op->name, op->count);
376 }
377 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
378 397
379 strcpy((char*)sl.buf,"upditem "); 398 client *ns = pl->contr->ns;
380 sl.len=strlen((char*)sl.buf); 399 if (!ns)
400 return;
381 401
382 SockList_AddChar(&sl, (char) flags); 402 packet sl ("upditem");
383 403
384 if (op->head) op=op->head; 404 sl << uint8 (flags);
385 405
386 SockList_AddInt(&sl, op->count); 406 op = op->head_ ();
387 407
408 sl << uint32 (op->count);
409
388 if (flags & UPD_LOCATION) 410 if (flags & UPD_LOCATION)
389 SockList_AddInt(&sl, op->env? op->env->count:0); 411 sl << uint32 (op->env ? op->env->count : 0);
390 412
391 if (flags & UPD_FLAGS) 413 if (flags & UPD_FLAGS)
392 SockList_AddInt(&sl, query_flags(op)); 414 sl << uint32 (query_flags (op));
393 415
394 if (flags & UPD_WEIGHT) { 416 if (flags & UPD_WEIGHT)
395 sint32 weight = WEIGHT(op); 417 {
418 sint32 weight = op->client_weight ();
396 419
397 SockList_AddInt(&sl, QUERY_FLAG(op, FLAG_NO_PICK) ? -1 : weight); 420 if (op == pl)
398 if (pl == op) {
399 op->contr->last_weight = weight; 421 ns->last_weight = weight;
422
423 sl << uint32 (weight);
424 }
425
426 if (flags & UPD_FACE)
427 {
428 ns->send_face (op->face, -50);
429 ns->flush_fx ();
430 sl << uint32 (op->face);
431 }
432
433 if (flags & UPD_NAME)
434 {
435 int len;
436 const char *item_p;
437 char item_n[127 * 2];
438
439 if (!op->custom_name)
440 {
441 len = assign (item_n, query_base_name (op, 0), 127);
442 item_p = query_base_name (op, 1);
400 } 443 }
401 } 444 else
402 445 {
403 if (flags & UPD_FACE) { 446 len = assign (item_n, &op->custom_name, 127);
404 if (!(pl->contr->socket.faces_sent[op->face->number] & NS_FACESENT_FACE)) 447 item_p = &op->custom_name;
405 esrv_send_face(&pl->contr->socket, op->face->number,0);
406 SockList_AddInt(&sl, op->face->number);
407 }
408 if (flags & UPD_NAME) {
409 int len;
410 const char *item_p;
411 char item_n[MAX_BUF];
412
413 if (!op->custom_name) {
414 strncpy(item_n,query_base_name(op, 0),127);
415 item_n[127]=0;
416 len=strlen(item_n);
417 item_p=query_base_name(op, 1);
418 } 448 }
449
450 len += assign (item_n + len, item_p, 127);
451
452 sl << data8 (item_n, len);
453 }
454
455 if (flags & UPD_ANIM)
456 sl << uint16 (op->animation_id);
457
458 if (flags & UPD_ANIMSPEED)
459 {
460 int anim_speed = 0;
461
462 if (op->flag [FLAG_ANIMATE])
463 {
464 if (op->anim_speed)
465 anim_speed = op->anim_speed;
419 else { 466 else
420 strncpy(item_n,op->custom_name,127); 467 {
421 item_n[127]=0; 468 if (op->speed < 0.001)
422 len=strlen(item_n); 469 anim_speed = 255;
423 item_p=op->custom_name; 470 else if (op->speed >= 1.0)
471 anim_speed = 1;
472 else
473 anim_speed = 1. / op->speed;
474 }
475
476 if (anim_speed > 255)
477 anim_speed = 255;
424 } 478 }
425 479
426 strncpy(item_n+len+1, item_p, 127); 480 sl << uint8 (anim_speed);
427 item_n[254]=0;
428 len += strlen(item_n+1+len) + 1;
429 SockList_AddChar(&sl, (char)len);
430 memcpy(sl.buf+sl.len, item_n, len);
431 sl.len += len;
432 } 481 }
433 if (flags & UPD_ANIM)
434 SockList_AddShort(&sl,op->animation_id);
435 482
436 if (flags & UPD_ANIMSPEED) {
437 int anim_speed=0;
438 if (QUERY_FLAG(op,FLAG_ANIMATE)) {
439 if (op->anim_speed) anim_speed=op->anim_speed;
440 else {
441 if (FABS(op->speed)<0.001) anim_speed=255;
442 else if (FABS(op->speed)>=1.0) anim_speed=1;
443 else anim_speed = (int) (1.0/FABS(op->speed));
444 }
445 if (anim_speed>255) anim_speed=255;
446 }
447 SockList_AddChar(&sl, (char)anim_speed);
448 }
449 if (flags & UPD_NROF) 483 if (flags & UPD_NROF)
450 SockList_AddInt(&sl, op->nrof); 484 sl << uint32 (op->nrof);
451 485
452 Send_With_Handling(&pl->contr->socket, &sl); 486 pl->contr->ns->send_packet (sl);
453 free(sl.buf);
454} 487}
455 488
456/** 489/**
457 * Sends item's info to player. 490 * Sends item's info to player.
458 */ 491 */
492void
459void esrv_send_item(object *pl, object*op) 493esrv_send_item (object *pl, object *op)
460{ 494{
461 SockList sl; 495 if (!pl->contr->ns)
462 496 return;
463 /* If this is not the player object, do some more checks */ 497
464 if (op!=pl) {
465 /* We only send 'visibile' objects to the client */ 498 /* We only send 'visible' objects to the client, and sometimes the player */
466 if (! LOOK_OBJ(op)) 499 if (!op->client_visible () && op->type != PLAYER)
467 return; 500 return;
468 /* if the item is on the ground, mark that the look needs to
469 * be updated.
470 */
471 if (!op->env) {
472 pl->contr->socket.update_look=1;
473 return;
474 }
475 }
476 501
477 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 502 packet sl;
478 503
479 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 504 sl.printf ("item%d ", pl->contr->ns->itemcmd);
480 sl.len=strlen((char*)sl.buf);
481 505
482 if (op->head) op=op->head; 506 op = op->head_ ();
483 507
484 SockList_AddInt(&sl, op->env? op->env->count:0); 508 sl << uint32 (op->env ? op->env->count : 0);
485 509
486 add_object_to_socklist(&pl->contr->socket, &sl, op); 510 add_object_to_socklist (*pl->contr->ns, sl, op);
487 511
488 Send_With_Handling(&pl->contr->socket, &sl); 512 pl->contr->ns->flush_fx ();
489 SET_FLAG(op, FLAG_CLIENT_SENT); 513 pl->contr->ns->send_packet (sl);
490 free(sl.buf);
491} 514}
492 515
493/** 516/**
494 * Tells the client to delete an item. Uses the item 517 * Tells the client to delete an item.
495 * command with a -1 location.
496 */ 518 */
497 519void
498void esrv_del_item(player *pl, int tag) 520esrv_del_item (player *pl, int tag)
499{ 521{
500 SockList sl; 522 if (!pl->ns)
523 return;
501 524
502 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 525 packet sl ("delitem");
503 526
504 strcpy((char*)sl.buf,"delitem "); 527 sl << uint32 (tag);
505 sl.len=strlen((char*)sl.buf);
506 SockList_AddInt(&sl, tag);
507 528
508 Send_With_Handling(&pl->socket, &sl); 529 pl->ns->send_packet (sl);
509 free(sl.buf);
510} 530}
511 531
512 532
513/******************************************************************************* 533/*******************************************************************************
514 * 534 *
… …
518 538
519/** 539/**
520 * Takes a player and object count (tag) and returns the actual object 540 * Takes a player and object count (tag) and returns the actual object
521 * pointer, or null if it can't be found. 541 * pointer, or null if it can't be found.
522 */ 542 */
523 543static object *
524object *esrv_get_ob_from_count(object *pl, tag_t count) 544esrv_get_ob_from_count (object *pl, tag_t count)
525{ 545{
526 object *op, *tmp; 546 if (pl->count == count)
547 return pl;
527 548
549 for (object *op = pl->inv; op; op = op->below)
528 if (pl->count == count) 550 if (op->count == count)
529 return pl; 551 return op;
530 552 else if (op->type == CONTAINER && pl->container_ () == op)
531 for(op = pl->inv; op; op = op->below) 553 for (object *tmp = op->inv; tmp; tmp = tmp->below)
532 if (op->count == count) 554 if (tmp->count == count)
533 return op; 555 return tmp;
534 else if (op->type == CONTAINER && pl->container == op)
535 for(tmp = op->inv; tmp; tmp = tmp->below)
536 if (tmp->count == count)
537 return tmp;
538 556
539 for(op = get_map_ob (pl->map, pl->x, pl->y); op; op = op->above) 557 for (object *op = GET_MAP_OB (pl->map, pl->x, pl->y); op; op = op->above)
540 if (op->head != NULL && op->head->count == count) 558 if (op->head && op->head->count == count)
541 return op; 559 return op;
542 else if (op->count == count) 560 else if (op->count == count)
543 return op; 561 return op;
544 else if (op->type == CONTAINER && pl->container == op) 562 else if (op->type == CONTAINER && pl->container_ () == op)
545 for(tmp = op->inv; tmp; tmp = tmp->below) 563 for (object *tmp = op->inv; tmp; tmp = tmp->below)
546 if (tmp->count == count) 564 if (tmp->count == count)
547 return tmp; 565 return tmp;
548 566
567#if 0
568 /* If the high bit is set, player examined a pseudo object. */
569 if (count & 0x80000000)
549 return NULL; 570 return 0;
550} 571#endif
551 572
573 return 0;
574}
552 575
553/** Client wants to examine some object. So lets do so. */ 576/** Client wants to examine some object. So lets do so. */
577void
554void ExamineCmd(char *buf, int len,player *pl) 578ExamineCmd (char *buf, int len, player *pl)
555{ 579{
556 long tag = atoi(buf); 580 tag_t tag = atoi (buf);
581
582 /* If the high bit is set, player applied a pseudo object. */
583 if (tag & 0x80000000)
584 {
585 pl->ns->look_position = tag & 0x7fffffff;
586 pl->ns->floorbox_update ();
587 return;
588 }
589
557 object *op = esrv_get_ob_from_count(pl->ob, tag); 590 object *op = esrv_get_ob_from_count (pl->ob, tag);
558 591
559 if (!op) { 592 if (!op)
593 {
560 LOG(llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", 594 LOG (llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", &pl->ob->name, tag);
561 pl->ob->name, tag);
562 return; 595 return;
563 } 596 }
597
564 examine (pl->ob, op); 598 examine (pl->ob, op);
565} 599}
566 600
601/** Client wants to examine some object. So lets do so. */
602void
603ExCmd (char *buf, int len, player *pl)
604{
605 tag_t tag = atoi (buf);
606
607 if (object *op = esrv_get_ob_from_count (pl->ob, tag))
608 {
609 std::string s = op->describe (pl->ob);
610
611 packet sl ("ex");
612 sl << ber32 (tag)
613 << data_n (*pl->expand_cfpod (s.c_str ()));
614
615 pl->ns->send_packet (sl);
616 }
617}
618
567/** Client wants to apply some object. Lets do so. */ 619/** Client wants to apply some object. Lets do so. */
620void
568void ApplyCmd(char *buf, int len,player *pl) 621ApplyCmd (char *buf, int len, player *pl)
569{ 622{
570 uint32 tag = atoi(buf); 623 tag_t tag = atoi (buf);
571 object *op = esrv_get_ob_from_count(pl->ob, tag);
572 624
573 /* sort of a hack, but if the player saves and the player then manually
574 * applies a savebed (or otherwise tries to do stuff), we run into trouble.
575 */
576 if (QUERY_FLAG(pl->ob, FLAG_REMOVED)) return;
577
578 /* If the high bit is set, player applied a pseudo object. */ 625 /* If the high bit is set, player applied a pseudo object. */
579 if (tag & 0x80000000) { 626 if (tag & 0x80000000)
627 {
580 pl->socket.look_position = tag & 0x7fffffff; 628 pl->ns->look_position = tag & 0x7fffffff;
581 pl->socket.update_look = 1; 629 pl->ns->floorbox_update ();
582 return; 630 return;
583 } 631 }
584 632
633 // the object might be legally gone already
634 if (object *op = esrv_get_ob_from_count (pl->ob, tag))
635 pl->ob->apply (op, AP_TOGGLE);
636}
637
638/** Client wants to lock some object. Lets do so. */
639void
640LockItem (char *data, int len, player *pl)
641{
642 int flag = data[0];
643 tag_t tag = net_uint32 ((uint8 *)data + 1);
644 object *op = esrv_get_ob_from_count (pl->ob, tag);
645
585 if (!op) { 646 if (!op)
586 LOG(llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", 647 {
587 pl->ob->name, tag); 648 pl->failmsgf ("Could not find object %d to lock/unlock", tag);
588 return; 649 return;
589 } 650 }
590 player_apply (pl->ob, op, 0, 0);
591}
592 651
593/** Client wants to apply some object. Lets do so. */
594void LockItem(uint8 *data, int len,player *pl)
595{
596 int flag, tag;
597 object *op;
598
599 flag = data[0];
600 tag = GetInt_String(data+1);
601 op = esrv_get_ob_from_count(pl->ob, tag);
602
603 if (!op) {
604 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to lock/unlock");
605 return;
606 }
607 if (!flag) 652 if (!flag)
608 CLEAR_FLAG(op,FLAG_INV_LOCKED); 653 op->clr_flag (FLAG_INV_LOCKED);
609 else 654 else
610 SET_FLAG(op,FLAG_INV_LOCKED); 655 op->set_flag (FLAG_INV_LOCKED);
656
611 esrv_update_item(UPD_FLAGS, pl->ob, op); 657 esrv_update_item (UPD_FLAGS, pl->ob, op);
612} 658}
613 659
614/** Client wants to apply some object. Lets do so. */ 660/** Client wants to mark some object. Lets do so. */
661void
615void MarkItem(uint8 *data, int len,player *pl) 662MarkItem (char *data, int len, player *pl)
616{ 663{
617 int tag; 664 tag_t tag = net_uint32 ((uint8 *)data);
618 object *op;
619
620 tag = GetInt_String(data);
621 op = esrv_get_ob_from_count(pl->ob, tag); 665 object *op = esrv_get_ob_from_count (pl->ob, tag);
666
622 if (!op) { 667 if (!op)
623 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to mark"); 668 {
669 pl->failmsgf ("Could not find object %d to mark", tag);
624 return; 670 return;
625 } 671 }
672
626 pl->mark = op; 673 pl->mark = op;
627 pl->mark_count = op->count; 674 pl->ob->statusmsg (format ("Marked item %s", query_name (op)));
628 new_draw_info_format(NDI_UNIQUE, 0, pl->ob, "Marked item %s", query_name(op));
629} 675}
630
631 676
632/** 677/**
633 * look_at prints items on the specified square. 678 * look_at prints items on the specified square.
634 * 679 *
635 * [ removed EARTHWALL check and added check for containers inventory. 680 * [ removed EARTHWALL check and added check for containers inventory.
636 * Tero.Haatanen@lut.fi ] 681 * Tero.Haatanen@lut.fi ]
637 */ 682 */
638void look_at(object *op,int dx,int dy) { 683static void
639 object *tmp; 684look_at (player *pl, int dx, int dy)
640 int flag=0; 685{
641 sint16 x,y; 686 dynbuf_text &buf = msg_dynbuf; buf.clear ();
642 mapstruct *m; 687 object *ob = pl->ob;
643 688
644 x = op->x + dx; 689 if (!pl->observe->map)
645 y = op->y + dy; 690 return;
646 691
647 if (out_of_map(op->map, x, y)) return; 692 bool wiz = ob->flag [FLAG_WIZ] || ob->flag [FLAG_WIZLOOK];
648 693
649 m = get_map_from_coord(op->map, &x, &y); 694 mapxy pos (pl->observe);
650 if (!m) return; 695 pos.move (dx, dy);
651 696
652 for(tmp=get_map_ob(m, x ,y);tmp!=NULL&&tmp->above!=NULL; 697 if (wiz)
653 tmp=tmp->above); 698 {
699 if (pos.normalise ())
700 {
701 mapspace &ms = *pos;
702 ms.update ();
654 703
655 for ( ; tmp != NULL; tmp=tmp->below ) { 704 buf.printf (" map: %s%+d%+d (%+d%+d)\n"
656 if (tmp->invisible && !QUERY_FLAG(op, FLAG_WIZ)) continue; 705 " smell %u/%u; flags %x; light %d; block %x; slow %x; on %x; off %x; items %d, volume %lld\n\n",
706 &pos.m->path, pos.x, pos.y, dx, dy,
707 (unsigned int)ms.smell, (unsigned int)mapspace::smellcount, ms.flags (), ms.light,
708 ms.move_block, ms.move_slow, ms.move_on, ms.move_off, (int)ms.items (), (long long)ms.volume ()
709 );
710 }
711 else
712 buf << "off-map\n\n";
713 }
657 714
658 if(!flag) { 715 int darkness = pl->blocked_los (dx, dy);
716
717 if (darkness == LOS_BLOCKED)
718 buf << "You cannot see that place from your position. H<Something is in between or it is too far away.>";
719 else if (darkness == LOS_MAX)
720 buf << "That place is too dark to see anything. H<Move nearer or find better lighting.>";
721 else
722 {
723 if (pos.normalise ())
724 for (object *tmp = pos->top; tmp; tmp = tmp->below)
725 {
726 if (tmp->invisible && !ob->flag [FLAG_WIZ])
727 continue;
728
659 if(dx||dy) 729 if (wiz)
660 new_draw_info(NDI_UNIQUE, 0,op,"There you see:"); 730 buf.printf (" - %s (%d) %s\n", query_name (tmp), tmp->count, tmp->uuid.c_str ());
661 else { 731 else
662 clear_win_info(op); 732 buf.printf (" - %s.\n", query_name (tmp));
663 new_draw_info(NDI_UNIQUE, 0,op,"You see:"); 733
734 object *head = tmp->head_ ();
735
736 if (head->inv)
737 if ((head->type != CONTAINER && head->type != FLESH)
738 || ob->flag [FLAG_WIZ])
739 buf << head->query_inventory (ob, " ");
740
741 if (tmp->flag [FLAG_IS_FLOOR] && !wiz) /* don't continue under the floor */
742 break;
743 }
744 }
745
746 if (buf.empty ())
747 buf << "You see nothing there.";
748
749 pl->infobox (MSG_CHANNEL ("lookat"), buf);
750}
751
752/** Client wants to look at some object. Lets do so. */
753void
754LookAt (char *buf, int len, player *pl)
755{
756 char *cp;
757
758 int dx = atoi (buf);
759 if (!(cp = strchr (buf, ' ')))
760 return;
761
762 int dy = atoi (cp);
763
764 look_at (pl, dx, dy);
765}
766
767/** Move an object to a new location */
768void
769esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof)
770{
771 object *op = esrv_get_ob_from_count (pl, tag);
772 if (!op)
773 {
774 LOG (llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", &pl->name, tag);
775 return;
776 }
777
778 if (!to)
779 { /* drop it to the ground */
780 if (op->map && !op->env)
781 return;
782
783 /* If it is an active container, then we should drop all objects
784 * in the container and not the container itself.
785 */
786 if (op->inv && op->flag [FLAG_APPLIED])
787 {
788 int cnt = MAX_ITEM_PER_ACTION;
789
790 for (object *current = op->inv; current && cnt--; )
791 {
792 object *next = current->below;
793 drop_object (pl, current, 0);
794 current = next;
664 } 795 }
665 flag=1; 796
797 if (cnt <= 0)
798 op->failmsg ("Only dropped some items, can't drop that many items at once.");
666 } 799 }
667
668 if (QUERY_FLAG(op, FLAG_WIZ))
669 new_draw_info_format(NDI_UNIQUE,0, op, "- %s (%d).",query_name(tmp),tmp->count);
670 else
671 new_draw_info_format(NDI_UNIQUE,0, op, "- %s.",query_name(tmp));
672
673 if (((tmp->inv!=NULL || (tmp->head && tmp->head->inv)) &&
674 (tmp->type != CONTAINER && tmp->type!=FLESH)) || QUERY_FLAG(op, FLAG_WIZ))
675 inventory(op,tmp->head==NULL?tmp:tmp->head);
676
677 if(QUERY_FLAG(tmp, FLAG_IS_FLOOR)&&!QUERY_FLAG(op, FLAG_WIZ)) /* don't continue under the floor */
678 break;
679 }
680
681 if(!flag) {
682 if(dx||dy)
683 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing there.");
684 else 800 else
685 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing."); 801 drop_object (pl, op, nrof);
686 }
687}
688 802
689 803 return;
690 804 }
691/** Client wants to look at some object. Lets do so. */ 805 else if (to == pl->count)
692void LookAt(char *buf, int len,player *pl) 806 { /* pick it up to the inventory */
693{ 807 /* return if player has already picked it up */
694 int dx, dy; 808 if (op->env == pl)
695 char *cp;
696
697 dx=atoi(buf);
698 if (!(cp=strchr(buf,' '))) {
699 return; 809 return;
700 }
701 dy=atoi(cp);
702 810
703 if (FABS(dx) > pl->socket.mapx / 2 || FABS(dy) > pl->socket.mapy / 2)
704 return;
705
706 if(pl->blocked_los[dx + pl->socket.mapx / 2][dy + pl->socket.mapy / 2])
707 return;
708
709 look_at(pl->ob, dx, dy);
710}
711
712/** Move an object to a new location */
713void esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof)
714{
715 object *op, *env;
716
717 op = esrv_get_ob_from_count(pl, tag);
718 if (!op) {
719 LOG(llevDebug, "Player '%s' tried to move an unknown object (%ld)\n",
720 pl->name, tag);
721 return;
722 }
723
724 if (!to) { /* drop it to the ground */
725/* LOG(llevDebug, "Drop it on the ground.\n");*/
726
727 if (op->map && !op->env) {
728/* LOG(llevDebug,"Dropping object to ground that is already on ground\n");*/
729 return;
730 }
731 /* If it is an active container, then we should drop all objects
732 * in the container and not the container itself.
733 */
734 if (op->inv && QUERY_FLAG(op, FLAG_APPLIED)) {
735 object *current, *next;
736 for (current=op->inv; current!=NULL; current=next) {
737 next=current->below;
738 drop_object(pl, current, 0);
739 }
740 esrv_update_item(UPD_WEIGHT, pl, op);
741 }
742 else {
743 drop_object (pl, op, nrof);
744 }
745 return;
746 } else if (to == pl->count) { /* pick it up to the inventory */
747 /* return if player has already picked it up */
748 if (op->env == pl) return;
749
750 pl->contr->count = nrof; 811 pl->contr->count = nrof;
751 pick_up(pl, op); 812 pick_up (pl, op);
752 return ;
753 }
754 env = esrv_get_ob_from_count(pl, to);
755 if (!env) {
756 LOG(llevDebug,
757 "Player '%s' tried to move object to the unknown location (%d)\n",
758 pl->name, to);
759 return; 813 return;
814 }
815
816 object *env = esrv_get_ob_from_count (pl, to);
817 if (!env)
760 } 818 {
819 LOG (llevDebug, "Player '%s' tried to move object to the unknown location (%d)\n", &pl->name, to);
820 return;
821 }
822
761 /* put_object_in_sack presumes that necessary sanity checking 823 /* put_object_in_sack presumes that necessary sanity checking
762 * has already been done (eg, it can be picked up and fits in 824 * has already been done (eg, it can be picked up and fits in
763 * in a sack, so check for those things. We should also check 825 * in a sack, so check for those things. We should also check
764 * an make sure env is in fact a container for that matter. 826 * an make sure env is in fact a container for that matter.
765 */ 827 */
766 if (env->type == CONTAINER 828 if (env->type == CONTAINER
829 && can_pick (pl, op)
767 && can_pick(pl, op) && sack_can_hold(pl, env, op, nrof)) { 830 && sack_can_hold (pl, env, op, nrof))
768 put_object_in_sack (pl, env, op, nrof); 831 put_object_in_sack (pl, env, op, nrof);
769 }
770} 832}
771 833
772

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines