--- deliantra/server/socket/item.C 2009/04/27 01:38:49 1.78
+++ deliantra/server/socket/item.C 2012/01/03 11:25:37 1.99
@@ -1,22 +1,23 @@
/*
* This file is part of Deliantra, the Roguelike Realtime MMORPG.
*
- * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
- * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
- * Copyright (©) 1992,2007 Frank Tore Johansen
+ * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
+ * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
+ * Copyright (©) 1992 Frank Tore Johansen
*
- * Deliantra is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+ * Deliantra is free software: you can redistribute it and/or modify it under
+ * the terms of the Affero GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the License, or (at your
+ * option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see .
+ * You should have received a copy of the Affero GNU General Public License
+ * and the GNU General Public License along with this program. If not, see
+ * .
*
* The authors can be reached via e-mail to
*/
@@ -49,12 +50,12 @@
* This is a similar to query_name, but returns flags
* to be sent to client.
*/
-unsigned int
+static unsigned int
query_flags (object *op)
{
unsigned int flags = 0;
- if (QUERY_FLAG (op, FLAG_APPLIED))
+ if (op->flag [FLAG_APPLIED])
switch (op->type)
{
case BOW:
@@ -87,22 +88,22 @@
break;
}
- if (op->type == CONTAINER && ((op->env && op->env->container == op) || (!op->env && QUERY_FLAG (op, FLAG_APPLIED))))
+ if (op->is_open_container ())
flags |= F_OPEN;
- if (QUERY_FLAG (op, FLAG_KNOWN_CURSED))
+ if (op->flag [FLAG_KNOWN_CURSED])
{
- if (QUERY_FLAG (op, FLAG_DAMNED))
+ if (op->flag [FLAG_DAMNED])
flags |= F_DAMNED;
- else if (QUERY_FLAG (op, FLAG_CURSED))
+ else if (op->flag [FLAG_CURSED])
flags |= F_CURSED;
}
- if (QUERY_FLAG (op, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (op, FLAG_IDENTIFIED))
+ if (op->flag [FLAG_KNOWN_MAGICAL] && !op->flag [FLAG_IDENTIFIED])
flags |= F_MAGIC;
- if (QUERY_FLAG (op, FLAG_UNPAID))
+ if (op->flag [FLAG_UNPAID])
flags |= F_UNPAID;
- if (QUERY_FLAG (op, FLAG_INV_LOCKED))
+ if (op->flag [FLAG_INV_LOCKED])
flags |= F_LOCKED;
return flags;
@@ -115,51 +116,47 @@
static void
add_object_to_socklist (client &ns, packet &sl, object *head)
{
- char item_n[MAX_BUF];
- const char *item_p;
-
int flags = query_flags (head);
- if (QUERY_FLAG (head, FLAG_NO_PICK))
+
+ if (head->flag [FLAG_NO_PICK])
flags |= F_NOPICK;
ns.send_face (head->face, -50);
- ns.flush_fx ();
- if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id])
+ if (head->flag [FLAG_ANIMATE] && !ns.anims_sent[head->animation_id])
ns.send_animation (head->animation_id);
sl << uint32 (head->count)
<< uint32 (flags)
- << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : head->client_weight ())
+ << uint32 (head->flag [FLAG_NO_PICK] ? -1 : head->client_weight ())
<< uint32 (head->face);
- int len;
-
if (!head->custom_name)
{
- strncpy (item_n, query_base_name (head, 0), 127);
- item_n[127] = 0;
- len = strlen (item_n);
- item_p = query_base_name (head, 1);
+ const char *name;
+ uint8 *len = sl.cur++; // patch up length later
+
+ name = query_base_name (head, 0); sl << data (name, min (127, strlen (name)));
+ sl << uint8 (0);
+ name = query_base_name (head, 1); sl << data (name, min (127, strlen (name)));
+
+ *len = sl.cur - len - 1;
}
else
{
- strncpy (item_n, head->custom_name, 127);
- item_n[127] = 0;
- len = strlen (item_n);
- item_p = head->custom_name;
- }
+ int len = min (127, head->custom_name.length ());
- strncpy (item_n + len + 1, item_p, 127);
- item_n[254] = 0;
- len += strlen (item_n + 1 + len) + 1;
+ sl << uint8 (len * 2 + 1)
+ << data (head->custom_name, len)
+ << uint8 (0)
+ << data (head->custom_name, len);
+ }
- sl << data8 (item_n, len)
- << uint16 (head->animation_id);
+ sl << uint16 (head->animation_id);
int anim_speed = !head->flag [FLAG_ANIMATE] ? 0
: head->anim_speed ? clamp (head->anim_speed, 1, 255)
- : 1. / clamp (fabs (head->speed), 1./255., 1./1.);
+ : 1. / clamp (head->speed, 1./255., 1./1.);
sl << uint8 (anim_speed)
<< uint32 (head->nrof);
@@ -198,16 +195,24 @@
return;
}
- pl->ns->update_look = 0;
+ if (pl->ns->need_delinv0)
+ {
+ pl->ns->need_delinv0 = 0;
+ pl->ns->send_packet ("delinv 0");
+ }
+
+ if (pl->run_on)
+ return;
+
+ pl->ns->update_look = 0;
+ pl->ns->need_delinv0 = 1;
- if (QUERY_FLAG (ob, FLAG_REMOVED)
+ if (ob->flag [FLAG_REMOVED]
|| !ob->map
- || ob->map->in_memory != MAP_ACTIVE
+ || ob->map->state != MAP_ACTIVE
|| out_of_map (ob->map, ob->x, ob->y))
return;
- pl->ns->send_packet ("delinv 0");
-
packet sl;
sl.printf ("item%d ", pl->ns->itemcmd);
@@ -283,6 +288,7 @@
// if packet got too large, send it and begin a new one
if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
{
+ pl->ns->flush_fx ();
pl->ns->send_packet (sl);
sl.reset ();
@@ -311,7 +317,10 @@
}
if (dirty)
- pl->ns->send_packet (sl);
+ {
+ pl->ns->flush_fx ();
+ pl->ns->send_packet (sl);
+ }
}
/**
@@ -353,6 +362,7 @@
*/
if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
{
+ pl->contr->ns->flush_fx ();
pl->contr->ns->send_packet (sl);
sl.reset ();
@@ -364,7 +374,10 @@
}
if (got_one)
- pl->contr->ns->send_packet (sl);
+ {
+ pl->contr->ns->flush_fx ();
+ pl->contr->ns->send_packet (sl);
+ }
}
/**
@@ -445,18 +458,18 @@
{
int anim_speed = 0;
- if (QUERY_FLAG (op, FLAG_ANIMATE))
+ if (op->flag [FLAG_ANIMATE])
{
if (op->anim_speed)
anim_speed = op->anim_speed;
else
{
- if (fabs (op->speed) < 0.001)
+ if (op->speed < 0.001)
anim_speed = 255;
- else if (fabs (op->speed) >= 1.0)
+ else if (op->speed >= 1.0)
anim_speed = 1;
else
- anim_speed = (int) (1.0 / fabs (op->speed));
+ anim_speed = 1. / op->speed;
}
if (anim_speed > 255)
@@ -495,6 +508,7 @@
add_object_to_socklist (*pl->contr->ns, sl, op);
+ pl->contr->ns->flush_fx ();
pl->contr->ns->send_packet (sl);
}
@@ -525,7 +539,7 @@
* Takes a player and object count (tag) and returns the actual object
* pointer, or null if it can't be found.
*/
-object *
+static object *
esrv_get_ob_from_count (object *pl, tag_t count)
{
if (pl->count == count)
@@ -534,7 +548,7 @@
for (object *op = pl->inv; op; op = op->below)
if (op->count == count)
return op;
- else if (op->type == CONTAINER && pl->container == op)
+ else if (op->type == CONTAINER && pl->container_ () == op)
for (object *tmp = op->inv; tmp; tmp = tmp->below)
if (tmp->count == count)
return tmp;
@@ -544,7 +558,7 @@
return op;
else if (op->count == count)
return op;
- else if (op->type == CONTAINER && pl->container == op)
+ else if (op->type == CONTAINER && pl->container_ () == op)
for (object *tmp = op->inv; tmp; tmp = tmp->below)
if (tmp->count == count)
return tmp;
@@ -615,15 +629,9 @@
return;
}
- object *op = esrv_get_ob_from_count (pl->ob, tag);
-
- if (!op)
- {
- LOG (llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", &pl->ob->name, tag);
- return;
- }
-
- player_apply (pl->ob, op, 0, 0);
+ // the object might be legally gone already
+ if (object *op = esrv_get_ob_from_count (pl->ob, tag))
+ pl->ob->apply (op, AP_TOGGLE);
}
/** Client wants to lock some object. Lets do so. */
@@ -641,9 +649,9 @@
}
if (!flag)
- CLEAR_FLAG (op, FLAG_INV_LOCKED);
+ op->clr_flag (FLAG_INV_LOCKED);
else
- SET_FLAG (op, FLAG_INV_LOCKED);
+ op->set_flag (FLAG_INV_LOCKED);
esrv_update_item (UPD_FLAGS, pl->ob, op);
}
@@ -693,10 +701,10 @@
ms.update ();
buf.printf (" map: %s%+d%+d (%+d%+d)\n"
- " smell %u/%u; flags %x; light %d; block %x; slow %x; on %x; off %x; volume %lld\n\n",
+ " smell %u/%u; flags %x; light %d; block %x; slow %x; on %x; off %x; items %d, volume %lld\n\n",
&pos.m->path, pos.x, pos.y, dx, dy,
(unsigned int)ms.smell, (unsigned int)mapspace::smellcount, ms.flags (), ms.light,
- ms.move_block, ms.move_slow, ms.move_on, ms.move_off, (long long)ms.volume ()
+ ms.move_block, ms.move_slow, ms.move_on, ms.move_off, (int)ms.items (), (long long)ms.volume ()
);
}
else
@@ -714,11 +722,11 @@
if (pos.normalise ())
for (object *tmp = pos->top; tmp; tmp = tmp->below)
{
- if (tmp->invisible && !QUERY_FLAG (ob, FLAG_WIZ))
+ if (tmp->invisible && !ob->flag [FLAG_WIZ])
continue;
if (wiz)
- buf.printf (" - %s (%d).\n", query_name (tmp), tmp->count);
+ buf.printf (" - %s (%d) %s\n", query_name (tmp), tmp->count, tmp->uuid.c_str ());
else
buf.printf (" - %s.\n", query_name (tmp));
@@ -726,10 +734,10 @@
if (head->inv)
if ((head->type != CONTAINER && head->type != FLESH)
- || QUERY_FLAG (ob, FLAG_WIZ))
+ || ob->flag [FLAG_WIZ])
buf << head->query_inventory (ob, " ");
- if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !wiz) /* don't continue under the floor */
+ if (tmp->flag [FLAG_IS_FLOOR] && !wiz) /* don't continue under the floor */
break;
}
}
@@ -774,9 +782,9 @@
/* If it is an active container, then we should drop all objects
* in the container and not the container itself.
*/
- if (op->inv && QUERY_FLAG (op, FLAG_APPLIED))
+ if (op->inv && op->flag [FLAG_APPLIED])
{
- int cnt = MAX_ITEM_PER_DROP;
+ int cnt = MAX_ITEM_PER_ACTION;
for (object *current = op->inv; current && cnt--; )
{