ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/item.C
(Generate patch)

Comparing deliantra/server/socket/item.C (file contents):
Revision 1.44 by root, Mon Apr 23 19:10:17 2007 UTC vs.
Revision 1.63 by root, Thu Apr 24 00:30:52 2008 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/** 24/**
26 * \file 25 * \file
27 * Client/server logic. 26 * Client/server logic.
194query_flags (object *op) 193query_flags (object *op)
195{ 194{
196 unsigned int flags = 0; 195 unsigned int flags = 0;
197 196
198 if (QUERY_FLAG (op, FLAG_APPLIED)) 197 if (QUERY_FLAG (op, FLAG_APPLIED))
199 {
200 switch (op->type) 198 switch (op->type)
201 { 199 {
202 case BOW: 200 case BOW:
203 case WAND: 201 case WAND:
204 case ROD: 202 case ROD:
205 case HORN: 203 case HORN:
206 flags = a_readied; 204 flags = a_readied;
207 break; 205 break;
208 case WEAPON: 206 case WEAPON:
209 flags = a_wielded; 207 flags = a_wielded;
210 break; 208 break;
211 case SKILL: 209 case SKILL:
212 case ARMOUR: 210 case ARMOUR:
213 case HELMET: 211 case HELMET:
214 case SHIELD: 212 case SHIELD:
215 case RING: 213 case RING:
216 case BOOTS: 214 case BOOTS:
217 case GLOVES: 215 case GLOVES:
218 case AMULET: 216 case AMULET:
219 case GIRDLE: 217 case GIRDLE:
220 case BRACERS: 218 case BRACERS:
221 case CLOAK: 219 case CLOAK:
222 flags = a_worn; 220 flags = a_worn;
223 break; 221 break;
224 case CONTAINER: 222 case CONTAINER:
225 flags = a_active; 223 flags = a_active;
226 break; 224 break;
227 default: 225 default:
228 flags = a_applied; 226 flags = a_applied;
229 break; 227 break;
230 } 228 }
231 }
232 229
233 if (op->type == CONTAINER && ((op->env && op->env->container == op) || (!op->env && QUERY_FLAG (op, FLAG_APPLIED)))) 230 if (op->type == CONTAINER && ((op->env && op->env->container == op) || (!op->env && QUERY_FLAG (op, FLAG_APPLIED))))
234 flags |= F_OPEN; 231 flags |= F_OPEN;
235 232
236 if (QUERY_FLAG (op, FLAG_KNOWN_CURSED)) 233 if (QUERY_FLAG (op, FLAG_KNOWN_CURSED))
264 261
265 flags = query_flags (head); 262 flags = query_flags (head);
266 if (QUERY_FLAG (head, FLAG_NO_PICK)) 263 if (QUERY_FLAG (head, FLAG_NO_PICK))
267 flags |= F_NOPICK; 264 flags |= F_NOPICK;
268 265
269 ns.send_face (head->face); 266 ns.send_face (head->face, -50);
270 ns.flush_fx (); 267 ns.flush_fx ();
271 268
272 if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id]) 269 if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id])
273 ns.send_animation (head->animation_id); 270 ns.send_animation (head->animation_id);
274 271
275 sl << uint32 (head->count) 272 sl << uint32 (head->count)
276 << uint32 (flags) 273 << uint32 (flags)
277 << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : WEIGHT (head)) 274 << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : head->client_weight ())
278 << uint32 (head->face); 275 << uint32 (head->face);
279 276
280 if (!head->custom_name) 277 if (!head->custom_name)
281 { 278 {
282 strncpy (item_n, query_base_name (head, 0), 127); 279 strncpy (item_n, query_base_name (head, 0), 127);
331 * Send the look window. Don't need to do animations here 328 * Send the look window. Don't need to do animations here
332 * This sends all the faces to the client, not just updates. This is 329 * This sends all the faces to the client, not just updates. This is
333 * because object ordering would otherwise be inconsistent. 330 * because object ordering would otherwise be inconsistent.
334 */ 331 */
335void 332void
336esrv_draw_look (object *pl) 333esrv_draw_look (player *pl)
337{ 334{
338 int got_one = 0, start_look = 0, end_look = 0; 335 int got_one = 0, start_look = 0, end_look = 0;
339 336
337 object *ob = pl->ob;
338
340 if (!pl->contr->ns->update_look) 339 if (!pl->ns->update_look)
341 { 340 {
342 LOG (llevDebug, "esrv_draw_look called when update_look was not set (player %s)\n", &pl->name); 341 LOG (llevDebug, "esrv_draw_look called when update_look was not set (player %s)\n", &ob->name);
343 return; 342 return;
344 } 343 }
345 else 344
346 pl->contr->ns->update_look = 0; 345 pl->ns->update_look = 0;
347 346
348 if (QUERY_FLAG (pl, FLAG_REMOVED) 347 if (QUERY_FLAG (ob, FLAG_REMOVED)
349 || !pl->map 348 || !ob->map
350 || pl->map->in_memory != MAP_IN_MEMORY 349 || ob->map->in_memory != MAP_ACTIVE
351 || out_of_map (pl->map, pl->x, pl->y)) 350 || out_of_map (ob->map, ob->x, ob->y))
352 return; 351 return;
353 352
354 pl->contr->ns->send_packet ("delinv 0"); 353 pl->ns->send_packet ("delinv 0");
355 354
356 packet sl; 355 packet sl;
357 sl.printf ("item%d ", pl->contr->ns->itemcmd); 356 sl.printf ("item%d ", pl->ns->itemcmd);
358 357
359 sl << uint32 (0); 358 sl << uint32 (0);
360 359
361 pl->contr->ns->send_face (empty_face); 360 pl->ns->send_face (empty_face, -50);
362 pl->contr->ns->flush_fx (); 361 pl->ns->flush_fx ();
363 362
364 if (pl->contr->ns->look_position) 363 if (pl->ns->look_position)
365 { 364 {
366 char buf[80]; 365 char buf[80];
367 snprintf (buf, 80, "Apply this to see %d previous items", FLOORBOX_PAGESIZE); 366 snprintf (buf, 80, "Apply this to see %d previous items", FLOORBOX_PAGESIZE);
368 367
369 sl << uint32 (0x80000000 | (pl->contr->ns->look_position - FLOORBOX_PAGESIZE)) 368 sl << uint32 (0x80000000 | (pl->ns->look_position - FLOORBOX_PAGESIZE))
370 << uint32 (0) 369 << uint32 (0)
371 << sint32 (-1) 370 << sint32 (-1)
372 << uint32 (empty_face) 371 << uint32 (empty_face)
373 << data8 (buf) 372 << data8 (buf)
374 << uint16 (0) 373 << uint16 (0)
375 << uint8 (0) 374 << uint8 (0)
376 << uint32 (0); 375 << uint32 (0);
377 376
378 if (pl->contr->ns->itemcmd == 2) 377 if (pl->ns->itemcmd == 2)
379 sl << uint16 (0); 378 sl << uint16 (0);
380 } 379 }
381 380
382 object *tmp = pl->ms ().top; 381 object *tmp = ob->ms ().top;
383 for (object *last = 0; tmp != last; tmp = tmp->below) 382 for (object *last = 0; tmp != last; tmp = tmp->below)
384 { 383 {
385 object *head;
386
387 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !last) 384 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !last)
388 { 385 {
389 last = tmp->below; /* assumes double floor mode */ 386 last = tmp->below; /* assumes double floor mode */
390 if (last && QUERY_FLAG (last, FLAG_IS_FLOOR)) 387 if (last && QUERY_FLAG (last, FLAG_IS_FLOOR))
391 last = last->below; 388 last = last->below;
392 } 389 }
393 390
394 if (tmp->client_visible ()) 391 if (tmp->client_visible ())
395 { 392 {
396 if (++start_look < pl->contr->ns->look_position) 393 if (++start_look < pl->ns->look_position)
397 continue; 394 continue;
398 395
399 end_look++; 396 end_look++;
400 397
401 if (end_look > FLOORBOX_PAGESIZE) 398 if (end_look > FLOORBOX_PAGESIZE)
402 { 399 {
403 /* What we basically do is make a 'fake' object - when the user applies it, 400 /* What we basically do is make a 'fake' object - when the user applies it,
404 * we notice the special tag the object has, and act accordingly. 401 * we notice the special tag the object has, and act accordingly.
405 */ 402 */
406 sl << uint32 (0x80000000 | (pl->contr->ns->look_position + FLOORBOX_PAGESIZE)) 403 sl << uint32 (0x80000000 | (pl->ns->look_position + FLOORBOX_PAGESIZE))
407 << uint32 (0) 404 << uint32 (0)
408 << uint32 ((uint32) - 1) 405 << uint32 ((uint32) - 1)
409 << uint32 (empty_face) 406 << uint32 (empty_face)
410 << data8 ("Apply this to see next group of items") 407 << data8 ("Apply this to see next group of items")
411 << uint16 (0) 408 << uint16 (0)
412 << uint8 (0) 409 << uint8 (0)
413 << uint32 (0); 410 << uint32 (0);
414 411
415 if (pl->contr->ns->itemcmd == 2) 412 if (pl->ns->itemcmd == 2)
416 sl << uint16 (0); 413 sl << uint16 (0);
417 414
418 break; 415 break;
419 } 416 }
420 417
421 if (tmp->head)
422 head = tmp->head;
423 else
424 head = tmp;
425
426 add_object_to_socklist (*pl->contr->ns, sl, head); 418 add_object_to_socklist (*pl->ns, sl, tmp->head_ ());
427 got_one++; 419 got_one++;
428 420
429 if (sl.length () >= (MAXSOCKBUF - MAXITEMLEN)) 421 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
430 { 422 {
431 pl->contr->ns->send_packet (sl); 423 pl->ns->send_packet (sl);
432 424
433 sl.reset (); 425 sl.reset ();
434 sl.printf ("item%d ", pl->contr->ns->itemcmd); 426 sl.printf ("item%d ", pl->ns->itemcmd);
435 sl << uint32 (0); 427 sl << uint32 (0);
436 got_one = 0; 428 got_one = 0;
437 } 429 }
438 } 430 }
439 } 431 }
440 432
441 if (got_one) 433 if (got_one)
442 pl->contr->ns->send_packet (sl); 434 pl->ns->send_packet (sl);
443 435
444} 436}
445 437
446/** 438/**
447 * Sends whole inventory. 439 * Sends whole inventory.
478 470
479 /* IT is possible for players to accumulate a huge amount of 471 /* IT is possible for players to accumulate a huge amount of
480 * items (especially with some of the bags out there) to 472 * items (especially with some of the bags out there) to
481 * overflow the buffer. IF so, send multiple item commands. 473 * overflow the buffer. IF so, send multiple item commands.
482 */ 474 */
483 if (sl.length () >= (MAXSOCKBUF - MAXITEMLEN)) 475 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
484 { 476 {
485 pl->contr->ns->send_packet (sl); 477 pl->contr->ns->send_packet (sl);
486 478
487 sl.reset (); 479 sl.reset ();
488 sl.printf ("item%d ", pl->contr->ns->itemcmd); 480 sl.printf ("item%d ", pl->contr->ns->itemcmd);
505 */ 497 */
506void 498void
507esrv_update_item (int flags, object *pl, object *op) 499esrv_update_item (int flags, object *pl, object *op)
508{ 500{
509 /* If we have a request to send the player item, skip a few checks. */ 501 /* If we have a request to send the player item, skip a few checks. */
510 if (op != pl)
511 {
512 if (!op->client_visible ()) 502 if (op != pl && !op->client_visible ())
513 return; 503 return;
514 /* we remove the check for op->env, because in theory, the object
515 * is hopefully in the same place, so the client should preserve
516 * order.
517 */
518 }
519 504
520 client *ns = pl->contr->ns; 505 client *ns = pl->contr->ns;
521 if (!ns) 506 if (!ns)
522 return; 507 return;
523 508
532 517
533 packet sl ("upditem"); 518 packet sl ("upditem");
534 519
535 sl << uint8 (flags); 520 sl << uint8 (flags);
536 521
537 if (op->head)
538 op = op->head; 522 op = op->head_ ();
539 523
540 sl << uint32 (op->count); 524 sl << uint32 (op->count);
541 525
542 if (flags & UPD_LOCATION) 526 if (flags & UPD_LOCATION)
543 sl << uint32 (op->env ? op->env->count : 0); 527 sl << uint32 (op->env ? op->env->count : 0);
545 if (flags & UPD_FLAGS) 529 if (flags & UPD_FLAGS)
546 sl << uint32 (query_flags (op)); 530 sl << uint32 (query_flags (op));
547 531
548 if (flags & UPD_WEIGHT) 532 if (flags & UPD_WEIGHT)
549 { 533 {
550 sint32 weight = WEIGHT (op); 534 sint32 weight = op->flag [FLAG_NO_PICK] ? -1 : op->client_weight ();
551 535
552 sl << uint32 (QUERY_FLAG (op, FLAG_NO_PICK) ? -1 : weight);
553
554 if (pl == op) 536 if (op)
555 ns->last_weight = weight; 537 ns->last_weight = weight;
538
539 sl << uint32 (weight);
556 } 540 }
557 541
558 if (flags & UPD_FACE) 542 if (flags & UPD_FACE)
559 { 543 {
560 ns->send_face (op->face); 544 ns->send_face (op->face, -50);
561 ns->flush_fx (); 545 ns->flush_fx ();
562 sl << uint32 (op->face); 546 sl << uint32 (op->face);
563 } 547 }
564 548
565 if (flags & UPD_NAME) 549 if (flags & UPD_NAME)
631esrv_send_item (object *pl, object *op) 615esrv_send_item (object *pl, object *op)
632{ 616{
633 if (!pl->contr->ns) 617 if (!pl->contr->ns)
634 return; 618 return;
635 619
636 /* If this is not the player object, do some more checks */
637 if (op != pl)
638 {
639 /* We only send 'visibile' objects to the client */ 620 /* We only send 'visible' objects to the client, and sometimes the player */
640 if (!op->client_visible ()) 621 if (!op->client_visible () && op->type != PLAYER)
641 return; 622 return;
642
643 /* if the item is on the ground, mark that the look needs to
644 * be updated.
645 */
646 if (!op->env)
647 {
648 pl->contr->ns->floorbox_update ();
649 return;
650 }
651 }
652 623
653 packet sl; 624 packet sl;
654 625
655 sl.printf ("item%d ", pl->contr->ns->itemcmd); 626 sl.printf ("item%d ", pl->contr->ns->itemcmd);
656 627
657 if (op->head)
658 op = op->head; 628 op = op->head_ ();
659 629
660 sl << uint32 (op->env ? op->env->count : 0); 630 sl << uint32 (op->env ? op->env->count : 0);
661 631
662 add_object_to_socklist (*pl->contr->ns, sl, op); 632 add_object_to_socklist (*pl->contr->ns, sl, op);
663 633
664 pl->contr->ns->send_packet (sl); 634 pl->contr->ns->send_packet (sl);
665 SET_FLAG (op, FLAG_CLIENT_SENT); 635 SET_FLAG (op, FLAG_CLIENT_SENT);
666} 636}
667 637
668/** 638/**
669 * Tells the client to delete an item. Uses the item 639 * Tells the client to delete an item.
670 * command with a -1 location.
671 */ 640 */
672void 641void
673esrv_del_item (player *pl, int tag) 642esrv_del_item (player *pl, int tag)
674{ 643{
675 if (!pl->ns) 644 if (!pl->ns)
799 tag_t tag = net_uint32 ((uint8 *)data + 1); 768 tag_t tag = net_uint32 ((uint8 *)data + 1);
800 object *op = esrv_get_ob_from_count (pl->ob, tag); 769 object *op = esrv_get_ob_from_count (pl->ob, tag);
801 770
802 if (!op) 771 if (!op)
803 { 772 {
804 new_draw_info (NDI_UNIQUE, 0, pl->ob, "Could not find object to lock/unlock"); 773 pl->failmsg ("Could not find object to lock/unlock");
805 return; 774 return;
806 } 775 }
807 776
808 if (!flag) 777 if (!flag)
809 CLEAR_FLAG (op, FLAG_INV_LOCKED); 778 CLEAR_FLAG (op, FLAG_INV_LOCKED);
820 tag_t tag = net_uint32 ((uint8 *)data); 789 tag_t tag = net_uint32 ((uint8 *)data);
821 object *op = esrv_get_ob_from_count (pl->ob, tag); 790 object *op = esrv_get_ob_from_count (pl->ob, tag);
822 791
823 if (!op) 792 if (!op)
824 { 793 {
825 new_draw_info (NDI_UNIQUE, 0, pl->ob, "Could not find object to mark"); 794 pl->failmsg ("Could not find object to mark");
826 return; 795 return;
827 } 796 }
828 797
829 pl->mark = op; 798 pl->mark = op;
830 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "Marked item %s", query_name (op)); 799 pl->ob->statusmsg (format ("Marked item %s", query_name (op)));
831} 800}
832 801
833/** 802/**
834 * look_at prints items on the specified square. 803 * look_at prints items on the specified square.
835 * 804 *
836 * [ removed EARTHWALL check and added check for containers inventory. 805 * [ removed EARTHWALL check and added check for containers inventory.
837 * Tero.Haatanen@lut.fi ] 806 * Tero.Haatanen@lut.fi ]
838 */ 807 */
839void 808static void
840look_at (object *op, int dx, int dy) 809look_at (player *pl, int dx, int dy)
841{ 810{
842 object *tmp; 811 dynbuf_text buf;
843 int flag = 0; 812 object *ob = pl->ob;
844 sint16 x, y;
845 maptile *m;
846 813
847 x = op->x + dx; 814 if (!pl->observe->map)
848 y = op->y + dy;
849
850 if (out_of_map (op->map, x, y))
851 return; 815 return;
852 816
853 m = get_map_from_coord (op->map, &x, &y); 817 mapxy pos (pl->observe);
854 if (!m) 818 pos.move (dx, dy);
855 return;
856 819
857 for (tmp = GET_MAP_OB (m, x, y); tmp && tmp->above; tmp = tmp->above) 820 if (pos.normalise ())
858 ; 821 for (object *tmp = pos->top; tmp; tmp = tmp->below)
859
860 for (; tmp; tmp = tmp->below)
861 { 822 {
862 if (tmp->invisible && !QUERY_FLAG (op, FLAG_WIZ)) 823 if (tmp->invisible && !QUERY_FLAG (ob, FLAG_WIZ))
863 continue; 824 continue;
864 825
865 if (!flag)
866 {
867 if (dx || dy)
868 new_draw_info (NDI_UNIQUE, 0, op, "There you see:");
869 else
870 {
871 clear_win_info (op);
872 new_draw_info (NDI_UNIQUE, 0, op, "You see:");
873 }
874 flag = 1;
875 }
876
877 if (QUERY_FLAG (op, FLAG_WIZ)) 826 if (QUERY_FLAG (ob, FLAG_WIZ))
878 new_draw_info_format (NDI_UNIQUE, 0, op, "- %s (%d).", query_name (tmp), tmp->count); 827 buf.printf ("- %s (%d).\n", query_name (tmp), tmp->count);
879 else 828 else
880 new_draw_info_format (NDI_UNIQUE, 0, op, "- %s.", query_name (tmp)); 829 buf.printf ("- %s.\n", query_name (tmp));
881 830
882 if (((tmp->inv != NULL || (tmp->head && tmp->head->inv)) && 831 object *head = tmp->head_ ();
883 (tmp->type != CONTAINER && tmp->type != FLESH)) || QUERY_FLAG (op, FLAG_WIZ))
884 inventory (op, tmp->head == NULL ? tmp : tmp->head);
885 832
833 if (head->inv)
834 if ((head->type != CONTAINER && head->type != FLESH)
835 || QUERY_FLAG (ob, FLAG_WIZ))
836 buf << head->query_inventory (ob, " ");
837
886 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !QUERY_FLAG (op, FLAG_WIZ)) /* don't continue under the floor */ 838 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !QUERY_FLAG (ob, FLAG_WIZ)) /* don't continue under the floor */
887 break; 839 break;
888 } 840 }
889 841
890 if (!flag) 842 if (buf.empty ())
891 { 843 pl->failmsg ("You see nothing there.");
892 if (dx || dy)
893 new_draw_info (NDI_UNIQUE, 0, op, "You see nothing there.");
894 else 844 else
895 new_draw_info (NDI_UNIQUE, 0, op, "You see nothing."); 845 pl->infobox (MSG_CHANNEL ("lookat"), buf);
896 }
897} 846}
898 847
899/** Client wants to look at some object. Lets do so. */ 848/** Client wants to look at some object. Lets do so. */
900void 849void
901LookAt (char *buf, int len, player *pl) 850LookAt (char *buf, int len, player *pl)
902{ 851{
903 int dx, dy;
904 char *cp; 852 char *cp;
905 853
906 dx = atoi (buf); 854 int dx = atoi (buf);
907 if (!(cp = strchr (buf, ' '))) 855 if (!(cp = strchr (buf, ' ')))
908 return; 856 return;
909 857
910 dy = atoi (cp); 858 int dy = atoi (cp);
859
860 if (player *opl = pl->observe->contr)
861 if (client *ns = opl->ns)
862 {
911 if (fabs (dx) > pl->ns->mapx / 2 || fabs (dy) > pl->ns->mapy / 2) 863 if (fabs (dx) > ns->mapx / 2 || fabs (dy) > ns->mapy / 2)
912 return; 864 return;
913 865
914 if (pl->blocked_los[dx + pl->ns->mapx / 2][dy + pl->ns->mapy / 2]) 866 if (opl->blocked_los[dx + ns->mapx / 2][dy + ns->mapy / 2])
915 return; 867 return;
868 }
916 869
917 look_at (pl->ob, dx, dy); 870 look_at (pl, dx, dy);
918} 871}
919 872
920/** Move an object to a new location */ 873/** Move an object to a new location */
921void 874void
922esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof) 875esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof)
938 /* If it is an active container, then we should drop all objects 891 /* If it is an active container, then we should drop all objects
939 * in the container and not the container itself. 892 * in the container and not the container itself.
940 */ 893 */
941 if (op->inv && QUERY_FLAG (op, FLAG_APPLIED)) 894 if (op->inv && QUERY_FLAG (op, FLAG_APPLIED))
942 { 895 {
943 object *current, *next; 896 int cnt = MAX_ITEM_PER_DROP;
944 897
945 for (current = op->inv; current != NULL; current = next) 898 for (object *current = op->inv; current; )
946 { 899 {
947 next = current->below; 900 object *next = current->below;
901
948 drop_object (pl, current, 0); 902 drop_object (pl, current, 0);
903
904 if (--cnt <= 0) break;
905
906 current = next;
949 } 907 }
950 908
951 esrv_update_item (UPD_WEIGHT, pl, op); 909 if (cnt <= 0)
910 op->failmsg ("Only dropped some items, can't drop that many items at once.");
952 } 911 }
953 else 912 else
954 drop_object (pl, op, nrof); 913 drop_object (pl, op, nrof);
955 914
956 return; 915 return;
976 /* put_object_in_sack presumes that necessary sanity checking 935 /* put_object_in_sack presumes that necessary sanity checking
977 * has already been done (eg, it can be picked up and fits in 936 * has already been done (eg, it can be picked up and fits in
978 * in a sack, so check for those things. We should also check 937 * in a sack, so check for those things. We should also check
979 * an make sure env is in fact a container for that matter. 938 * an make sure env is in fact a container for that matter.
980 */ 939 */
981 if (env->type == CONTAINER && can_pick (pl, op) && sack_can_hold (pl, env, op, nrof)) 940 if (env->type == CONTAINER
941 && can_pick (pl, op)
942 && sack_can_hold (pl, env, op, nrof))
982 put_object_in_sack (pl, env, op, nrof); 943 put_object_in_sack (pl, env, op, nrof);
983} 944}
984 945

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines