ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/item.C
(Generate patch)

Comparing deliantra/server/socket/item.C (file contents):
Revision 1.1 by elmex, Sun Aug 13 17:16:06 2006 UTC vs.
Revision 1.71 by root, Mon Sep 8 11:27:25 2008 UTC

1
2/* 1/*
3 * static char *rcsid_item_c = 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
4 * "$Id: item.C,v 1.1 2006/08/13 17:16:06 elmex Exp $"; 3 *
5 */ 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
6
7/*
8 CrossFire, A Multiplayer game for X-windows
9
10 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
12 7 *
13 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
14 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
15 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
16 (at your option) any later version. 11 * (at your option) any later version.
17 12 *
18 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details. 16 * GNU General Public License for more details.
22 17 *
23 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
26 21 * The authors can be reached via e-mail to <support@deliantra.net>
27 The author can be reached via e-mail to crossfire-devel@real-time.com
28*/ 22 */
29 23
30/** 24/**
31 * \file 25 * \file
32 * Client/server logic. 26 * Client/server logic.
33 * 27 *
34 * \date 2003-12-02 28 * \date 2003-12-02
35 * 29 *
36 * This containes item logic for client/server. It doesn't contain 30 * This contains item logic for client/server. It doesn't contain
37 * the actual commands that send the data, but does contain 31 * the actual commands that send the data, but does contain
38 * the logic for what items should be sent. 32 * the logic for what items should be sent.
39 */ 33 */
40 34
41
42#include <global.h> 35#include <global.h>
43#include <object.h> /* LOOK_OBJ */
44#include <newclient.h> 36#include <object.h>
45#include <newserver.h>
46#include <sproto.h> 37#include <sproto.h>
47 38
48/** This is the maximum number of bytes we expect any one item to take up */ 39/** This is the maximum number of bytes we expect any one item to take up */
49#define MAXITEMLEN 300 40#define MAXITEMLEN 300
50 41
… …
53 * Functions related to sending object data to the client. 44 * Functions related to sending object data to the client.
54 * 45 *
55 ******************************************************************************/ 46 ******************************************************************************/
56 47
57/** 48/**
58 * Adds string to socklist.
59 *
60 * This is a simple function that we use a lot here. It basically
61 * adds the specified buffer into the socklist, but prepends a
62 * single byte in length. If the data is longer than that byte, it is
63 * truncated approprately.
64 */
65inline void add_stringlen_to_sockbuf(const char *buf, SockList *sl)
66{
67 int len;
68
69 len=strlen(buf);
70 if (len>255) len=255;
71 SockList_AddChar(sl, (char) len);
72 strncpy((char*)sl->buf+sl->len, buf,len);
73 sl->len += len;
74}
75
76/**
77 * This is a similar to query_name, but returns flags 49 * This is a similar to query_name, but returns flags
78 * to be sended to client. 50 * to be sent to client.
79 */ 51 */
52unsigned int
80unsigned int query_flags (object *op) 53query_flags (object *op)
81{ 54{
82 unsigned int flags = 0; 55 unsigned int flags = 0;
83 56
84 if(QUERY_FLAG(op,FLAG_APPLIED)) { 57 if (QUERY_FLAG (op, FLAG_APPLIED))
85 switch(op->type) { 58 switch (op->type)
59 {
86 case BOW: 60 case BOW:
87 case WAND: 61 case WAND:
88 case ROD: 62 case ROD:
89 case HORN: 63 case HORN:
90 flags = a_readied; 64 flags = a_readied;
91 break; 65 break;
92 case WEAPON: 66 case WEAPON:
93 flags = a_wielded; 67 flags = a_wielded;
94 break; 68 break;
95 case SKILL: 69 case SKILL:
96 case ARMOUR: 70 case ARMOUR:
97 case HELMET: 71 case HELMET:
98 case SHIELD: 72 case SHIELD:
99 case RING: 73 case RING:
100 case BOOTS: 74 case BOOTS:
101 case GLOVES: 75 case GLOVES:
102 case AMULET: 76 case AMULET:
103 case GIRDLE: 77 case GIRDLE:
104 case BRACERS: 78 case BRACERS:
105 case CLOAK: 79 case CLOAK:
106 flags = a_worn; 80 flags = a_worn;
107 break; 81 break;
108 case CONTAINER: 82 case CONTAINER:
109 flags = a_active; 83 flags = a_active;
110 break; 84 break;
111 default: 85 default:
112 flags = a_applied; 86 flags = a_applied;
113 break; 87 break;
114 }
115 } 88 }
89
116 if (op->type == CONTAINER && ((op->env && op->env->container == op) || 90 if (op->type == CONTAINER && ((op->env && op->env->container == op) || (!op->env && QUERY_FLAG (op, FLAG_APPLIED))))
117 (!op->env && QUERY_FLAG(op,FLAG_APPLIED))))
118 flags |= F_OPEN; 91 flags |= F_OPEN;
119 92
120 if (QUERY_FLAG(op,FLAG_KNOWN_CURSED)) { 93 if (QUERY_FLAG (op, FLAG_KNOWN_CURSED))
94 {
121 if(QUERY_FLAG(op,FLAG_DAMNED)) 95 if (QUERY_FLAG (op, FLAG_DAMNED))
122 flags |= F_DAMNED; 96 flags |= F_DAMNED;
123 else if(QUERY_FLAG(op,FLAG_CURSED)) 97 else if (QUERY_FLAG (op, FLAG_CURSED))
124 flags |= F_CURSED; 98 flags |= F_CURSED;
125 } 99 }
100
126 if (QUERY_FLAG(op,FLAG_KNOWN_MAGICAL) && !QUERY_FLAG(op,FLAG_IDENTIFIED)) 101 if (QUERY_FLAG (op, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (op, FLAG_IDENTIFIED))
127 flags |= F_MAGIC; 102 flags |= F_MAGIC;
128 if (QUERY_FLAG(op,FLAG_UNPAID)) 103 if (QUERY_FLAG (op, FLAG_UNPAID))
129 flags |= F_UNPAID; 104 flags |= F_UNPAID;
130 if (QUERY_FLAG(op,FLAG_INV_LOCKED)) 105 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
131 flags |= F_LOCKED; 106 flags |= F_LOCKED;
132 107
133 return flags; 108 return flags;
134} 109}
135 110
136/* Used in the send_look to put object head into SockList 111/* Used in the send_look to put object head into packet
137 * sl for socket ns. Need socket to know if we need to send 112 * sl for socket ns. Need socket to know if we need to send
138 * animation of face to the client. 113 * animation of face to the client.
139 */ 114 */
140static void add_object_to_socklist(NewSocket *ns, SockList *sl, object *head) 115static void
116add_object_to_socklist (client &ns, packet &sl, object *head)
141{ 117{
142 int flags, len, anim_speed;
143 char item_n[MAX_BUF]; 118 char item_n[MAX_BUF];
144 const char *item_p; 119 const char *item_p;
145 120
146 flags = query_flags (head); 121 int flags = query_flags (head);
147 if (QUERY_FLAG(head, FLAG_NO_PICK)) 122 if (QUERY_FLAG (head, FLAG_NO_PICK))
148 flags |= F_NOPICK; 123 flags |= F_NOPICK;
149 124
150 if (!(ns->faces_sent[head->face->number] & NS_FACESENT_FACE)) 125 ns.send_face (head->face, -50);
151 esrv_send_face(ns, head->face->number,0); 126 ns.flush_fx ();
152 127
153 if (QUERY_FLAG(head,FLAG_ANIMATE) && !ns->anims_sent[head->animation_id]) 128 if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id])
154 esrv_send_animation(ns, head->animation_id); 129 ns.send_animation (head->animation_id);
155 130
156 SockList_AddInt(sl, head->count); 131 sl << uint32 (head->count)
157 SockList_AddInt(sl, flags); 132 << uint32 (flags)
158 SockList_AddInt(sl, QUERY_FLAG(head, FLAG_NO_PICK) ? -1 : WEIGHT(head)); 133 << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : head->client_weight ())
159 SockList_AddInt(sl, head->face->number); 134 << uint32 (head->face);
160 135
136 int len;
137
161 if (!head->custom_name) { 138 if (!head->custom_name)
139 {
162 strncpy(item_n,query_base_name(head, 0),127); 140 strncpy (item_n, query_base_name (head, 0), 127);
163 item_n[127]=0; 141 item_n[127] = 0;
164 len=strlen(item_n); 142 len = strlen (item_n);
165 item_p=query_base_name(head, 1); 143 item_p = query_base_name (head, 1);
166 } else { 144 }
145 else
146 {
167 strncpy(item_n,head->custom_name,127); 147 strncpy (item_n, head->custom_name, 127);
168 item_n[127]=0; 148 item_n[127] = 0;
169 len=strlen(item_n); 149 len = strlen (item_n);
170 item_p=head->custom_name; 150 item_p = head->custom_name;
171 } 151 }
152
172 strncpy(item_n+len+1, item_p, 127); 153 strncpy (item_n + len + 1, item_p, 127);
173 item_n[254]=0; 154 item_n[254] = 0;
174 len += strlen(item_n+1+len) + 1; 155 len += strlen (item_n + 1 + len) + 1;
175 SockList_AddChar(sl, (char ) len);
176 memcpy(sl->buf+sl->len, item_n, len);
177 sl->len += len;
178 156
179 SockList_AddShort(sl,head->animation_id); 157 sl << data8 (item_n, len)
180 anim_speed=0; 158 << uint16 (head->animation_id);
181 if (QUERY_FLAG(head,FLAG_ANIMATE)) {
182 if (head->anim_speed) anim_speed=head->anim_speed;
183 else {
184 if (FABS(head->speed)<0.001) anim_speed=255;
185 else if (FABS(head->speed)>=1.0) anim_speed=1;
186 else anim_speed = (int) (1.0/FABS(head->speed));
187 }
188 if (anim_speed>255) anim_speed=255;
189 }
190 SockList_AddChar(sl, (char) anim_speed);
191 SockList_AddInt(sl, head->nrof);
192 159
160 int anim_speed = !head->flag [FLAG_ANIMATE] ? 0
161 : head->anim_speed ? clamp (head->anim_speed, 1, 255)
162 : 1. / clamp (fabs (head->speed), 1./255., 1./1.);
163
164 sl << uint8 (anim_speed)
165 << uint32 (head->nrof);
166
193 if (ns->itemcmd == 2) 167 if (ns.itemcmd == 2)
194 SockList_AddShort(sl, head->client_type); 168 sl << uint16 (head->client_type);
195
196 SET_FLAG(head, FLAG_CLIENT_SENT);
197} 169}
198 170
171static faceidx
172need_face_now (player *pl, const char *name)
173{
174 faceidx face = face_find (name, empty_face);
175
176 pl->ns->send_face (face, -50);
177 pl->ns->flush_fx ();
178
179 return face;
180}
181
182#define FINGER_UP "finger_up.x11"
183#define FINGER_DOWN "finger_down.x11"
199 184
200/** 185/**
201 * Send the look window. Don't need to do animations here 186 * Send the look window. Don't need to do animations here
202 * This sends all the faces to the client, not just updates. This is 187 * This sends all the faces to the client, not just updates. This is
203 * because object ordering would otherwise be inconsistent 188 * because object ordering would otherwise be inconsistent.
204 */ 189 */
205 190void
206void esrv_draw_look(object *pl) 191esrv_draw_look (player *pl)
207{ 192{
208 object *tmp, *last; 193 object *ob = pl->ob;
209 int got_one=0,start_look=0, end_look=0;
210 SockList sl;
211 char buf[MAX_BUF];
212 194
213 if (!pl->contr->socket.update_look) { 195 if (!pl->ns->update_look)
196 {
214 LOG(llevDebug,"esrv_draw_look called when update_look was not set\n"); 197 LOG (llevDebug, "esrv_draw_look called when update_look was not set (player %s)\n", &ob->name);
215 return; 198 return;
216 } else {
217 pl->contr->socket.update_look=0;
218 } 199 }
219 200
220 if(QUERY_FLAG(pl, FLAG_REMOVED) || pl->map == NULL || 201 pl->ns->update_look = 0;
221 pl->map->in_memory != MAP_IN_MEMORY || out_of_map(pl->map,pl->x,pl->y)) 202
203 if (QUERY_FLAG (ob, FLAG_REMOVED)
204 || !ob->map
205 || ob->map->in_memory != MAP_ACTIVE
206 || out_of_map (ob->map, ob->x, ob->y))
222 return; 207 return;
223 208
224 if (pl->contr->transport) 209 pl->ns->send_packet ("delinv 0");
225 for (tmp=pl->contr->transport->inv; tmp && tmp->above;tmp=tmp->above) ;
226 else
227 for (tmp=get_map_ob(pl->map,pl->x,pl->y); tmp && tmp->above;tmp=tmp->above) ;
228 210
229 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 211 packet sl;
212 sl.printf ("item%d ", pl->ns->itemcmd);
230 213
231 Write_String_To_Socket(&pl->contr->socket, "delinv 0", strlen("delinv 0")); 214 sl << uint32 (0);
232 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
233 sl.len=strlen((char*)sl.buf);
234 215
235 SockList_AddInt(&sl, 0); 216 int start_pos = pl->ns->look_position;
217 bool dirty = false;
236 218
237 if (!(pl->contr->socket.faces_sent[empty_face->number]&NS_FACESENT_FACE)) 219 mapspace &ms = ob->ms ();
238 esrv_send_face(&pl->contr->socket, empty_face->number,0);
239 220
240 if (pl->contr->socket.look_position) { 221 // manage a ring buffer of the "last FLOORBOX_PAGESIZE" items and
241 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position- NUM_LOOK_OBJECTS)); 222 // start from the top
242 SockList_AddInt(&sl, 0); 223 object *items [FLOORBOX_PAGESIZE];
243 SockList_AddInt(&sl, (uint32) -1); 224 int item_idx = 0, item_cnt = 0;
244 SockList_AddInt(&sl, empty_face->number); 225 int pos = 0;
245 sprintf(buf,"Click here to see %d previous items", NUM_LOOK_OBJECTS); 226
246 add_stringlen_to_sockbuf(buf, &sl); 227 // find our items by walking down
247 SockList_AddShort(&sl,0); 228 object *item = ms.top;
248 SockList_AddChar(&sl, 0); 229
249 SockList_AddInt(&sl, 0); 230 for (; item && item_cnt < FLOORBOX_PAGESIZE; item = item->below)
250 if (pl->contr->socket.itemcmd == 2)
251 SockList_AddShort(&sl, 0);
252 } 231 {
232 if (!item->client_visible ())
233 continue;
253 234
254 if (pl->contr->transport) { 235 if (++pos < start_pos)
255 add_object_to_socklist(&pl->contr->socket, &sl, pl->contr->transport); 236 continue;
256 got_one++; 237
238 // record item
239 items [item_idx] = item; item_idx = item_idx < FLOORBOX_PAGESIZE ? item_idx + 1 : 0;
240 item_cnt++;
241
242 // stop at first floor
243 if (item->flag [FLAG_IS_FLOOR])
244 {
245 // we are finished, don't append "next group of items"
246 // by setting item to ms.bot it becomes zero which is checked after the while loop
247 item = ms.bot;
248 }
249 }
250
251 // see if there are more if we cared - we ignore invisible objects
252 if (item)
257 } 253 {
258
259 for (last=NULL; tmp!=last; tmp=tmp->below) {
260 object *head;
261
262 if (QUERY_FLAG(tmp, FLAG_IS_FLOOR) && !last) {
263 last = tmp->below; /* assumes double floor mode */
264 if (last && QUERY_FLAG(last, FLAG_IS_FLOOR))
265 last = last->below;
266 }
267 if (LOOK_OBJ(tmp)) {
268 if (++start_look < pl->contr->socket.look_position) continue;
269 end_look++;
270 if (end_look > NUM_LOOK_OBJECTS) {
271 /* What we basically do is make a 'fake' object - when the user applies it, 254 /* What we basically do is make a 'fake' object - when the user applies it,
272 * we notice the special tag the object has, and act accordingly. 255 * we notice the special tag the object has, and act accordingly.
273 */ 256 */
274 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position+ NUM_LOOK_OBJECTS)); 257 sl << uint32 (0x80000000 | (start_pos + FLOORBOX_PAGESIZE))
275 SockList_AddInt(&sl, 0); 258 << uint32 (0)
276 SockList_AddInt(&sl, (uint32) -1); 259 << uint32 ((uint32) - 1)
277 SockList_AddInt(&sl, empty_face->number); 260 << uint32 (need_face_now (pl, FINGER_DOWN))
278 sprintf(buf,"Click here to see next group of items"); 261 << data8 ("Apply this to see the items below")
279 add_stringlen_to_sockbuf(buf, &sl); 262 << uint16 (0)
280 SockList_AddShort(&sl,0); 263 << uint8 (0)
281 SockList_AddChar(&sl, 0); 264 << uint32 (0);
282 SockList_AddInt(&sl, 0); 265
283 if (pl->contr->socket.itemcmd == 2) 266 if (pl->ns->itemcmd == 2)
284 SockList_AddShort(&sl, 0); 267 sl << uint16 (0);
285 break; 268
269 dirty = true;
286 } 270 }
287 if (tmp->head) head = tmp->head;
288 else head = tmp;
289 271
272 // now send out all items in the ring buffer in reverse order
273 while (item_cnt)
274 {
275 --item_cnt;
276 item_idx = (item_idx ? item_idx : FLOORBOX_PAGESIZE) - 1;
277 object *item = items [item_idx];
278
290 add_object_to_socklist(&pl->contr->socket, &sl, head); 279 add_object_to_socklist (*pl->ns, sl, item->head_ ());
291 got_one++;
292 280
281 dirty = true;
282
283 // if packet got too large, send it and begin a new one
293 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) { 284 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
294 Send_With_Handling(&pl->contr->socket, &sl); 285 {
295 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 286 pl->ns->send_packet (sl);
296 sl.len=strlen((char*)sl.buf); 287
297 SockList_AddInt(&sl, 0); 288 sl.reset ();
298 got_one=0; 289 sl.printf ("item%d ", pl->ns->itemcmd);
290 sl << uint32 (0);
291
292 dirty = false;
293 }
299 } 294 }
300 } /* If LOOK_OBJ() */ 295
296 if (start_pos)
301 } 297 {
302 if (got_one) 298 sl << uint32 (0x80000000 | (start_pos - FLOORBOX_PAGESIZE))
303 Send_With_Handling(&pl->contr->socket, &sl); 299 << uint32 (0)
300 << sint32 (-1)
301 << uint32 (need_face_now (pl, FINGER_UP))
302 << data8 ("Apply this to see the items higher up")
303 << uint16 (0)
304 << uint8 (0)
305 << uint32 (0);
304 306
305 free(sl.buf); 307 if (pl->ns->itemcmd == 2)
308 sl << uint16 (0);
309
310 dirty = true;
311 }
312
313 if (dirty)
314 pl->ns->send_packet (sl);
306} 315}
307 316
308/** 317/**
309 * Sends whole inventory. 318 * Sends whole inventory.
310 */ 319 */
320void
311void esrv_send_inventory(object *pl, object *op) 321esrv_send_inventory (object *pl, object *op)
312{ 322{
313 object *tmp; 323 if (!pl->contr->ns)//D
324 return;
325
314 int got_one=0; 326 int got_one = 0;
315 SockList sl; 327
328 pl->contr->ns->send_packet_printf ("delinv %d", op->count);
329
330 packet sl;
331 sl.printf ("item%d ", pl->contr->ns->itemcmd);
332
333 sl << uint32 (op->count);
334
335 for (object *tmp = op->inv; tmp; tmp = tmp->below)
316 336 {
317 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
318
319 sprintf((char*)sl.buf,"delinv %d", op->count);
320 sl.len=strlen((char*)sl.buf);
321 Send_With_Handling(&pl->contr->socket, &sl);
322
323 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
324 sl.len=strlen((char*)sl.buf);
325
326 SockList_AddInt(&sl, op->count);
327
328 for (tmp=op->inv; tmp; tmp=tmp->below) {
329 object *head; 337 object *head;
330 338
331 if (tmp->head) head = tmp->head; 339 if (tmp->head)
332 else head = tmp; 340 head = tmp->head;
341 else
342 head = tmp;
333 343
334 if (LOOK_OBJ(head)) { 344 if (head->client_visible ())
335 add_object_to_socklist(&pl->contr->socket, &sl, head);
336 345 {
346 add_object_to_socklist (*pl->contr->ns, sl, head);
347
337 got_one++; 348 got_one++;
338 349
339 /* IT is possible for players to accumulate a huge amount of 350 /* IT is possible for players to accumulate a huge amount of
340 * items (especially with some of the bags out there) to 351 * items (especially with some of the bags out there) to
341 * overflow the buffer. IF so, send multiple item commands. 352 * overflow the buffer. IF so, send multiple item commands.
342 */ 353 */
343 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) { 354 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
344 Send_With_Handling(&pl->contr->socket, &sl); 355 {
345 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 356 pl->contr->ns->send_packet (sl);
346 sl.len=strlen((char*)sl.buf); 357
347 SockList_AddInt(&sl, op->count); 358 sl.reset ();
348 got_one=0; 359 sl.printf ("item%d ", pl->contr->ns->itemcmd);
360 sl << uint32 (op->count);
361 got_one = 0;
362 }
363 }
349 } 364 }
350 } /* If LOOK_OBJ() */ 365
351 }
352 if (got_one) 366 if (got_one)
353 Send_With_Handling(&pl->contr->socket, &sl); 367 pl->contr->ns->send_packet (sl);
354 free(sl.buf);
355} 368}
356 369
357/** 370/**
358 * Updates object *op for player *pl. 371 * Updates object *op for player *pl.
359 * 372 *
360 * flags is a list of values to update 373 * flags is a list of values to update
361 * to the client (as defined in newclient.h - might as well use the 374 * to the client (as defined in newclient.h - might as well use the
362 * same value both places. 375 * same value both places.
363 */ 376 */
364 377void
365void esrv_update_item(int flags, object *pl, object *op) 378esrv_update_item (int flags, object *pl, object *op)
366{ 379{
367 SockList sl;
368
369 /* If we have a request to send the player item, skip a few checks. */ 380 /* If we have a request to send the player item, skip a few checks. */
370 if (op!=pl) { 381 if (op != pl && !op->client_visible ())
371 if (! LOOK_OBJ(op))
372 return; 382 return;
373 /* we remove the check for op->env, because in theory, the object
374 * is hopefully in the same place, so the client should preserve
375 * order.
376 */
377 }
378 if (!QUERY_FLAG(op, FLAG_CLIENT_SENT)) {
379 /* FLAG_CLIENT_SENT is debug only. We are using it to see where
380 * this is happening - we can set a breakpoint here in the debugger
381 * and track back the call.
382 */
383 LOG(llevDebug,"We have not sent item %s (%d)\n", op->name, op->count);
384 }
385 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
386 383
387 strcpy((char*)sl.buf,"upditem "); 384 client *ns = pl->contr->ns;
388 sl.len=strlen((char*)sl.buf); 385 if (!ns)
386 return;
389 387
390 SockList_AddChar(&sl, (char) flags); 388 packet sl ("upditem");
391 389
392 if (op->head) op=op->head; 390 sl << uint8 (flags);
393 391
394 SockList_AddInt(&sl, op->count); 392 op = op->head_ ();
395 393
394 sl << uint32 (op->count);
395
396 if (flags & UPD_LOCATION) 396 if (flags & UPD_LOCATION)
397 SockList_AddInt(&sl, op->env? op->env->count:0); 397 sl << uint32 (op->env ? op->env->count : 0);
398 398
399 if (flags & UPD_FLAGS) 399 if (flags & UPD_FLAGS)
400 SockList_AddInt(&sl, query_flags(op)); 400 sl << uint32 (query_flags (op));
401 401
402 if (flags & UPD_WEIGHT) { 402 if (flags & UPD_WEIGHT)
403 sint32 weight = WEIGHT(op);
404
405 /* TRANSPORTS are odd - they sort of look like containers, yet can't be
406 * picked up. So we don't to send the weight, as it is odd that you see
407 * weight sometimes and not other (the draw_look won't send it
408 * for example.
409 */
410 SockList_AddInt(&sl, QUERY_FLAG(op, FLAG_NO_PICK) ? -1 : weight);
411 if (pl == op) {
412 op->contr->last_weight = weight;
413 }
414 } 403 {
404 sint32 weight = op->flag [FLAG_NO_PICK] ? -1 : op->client_weight ();
415 405
406 if (op)
407 ns->last_weight = weight;
408
409 sl << uint32 (weight);
410 }
411
416 if (flags & UPD_FACE) { 412 if (flags & UPD_FACE)
417 if (!(pl->contr->socket.faces_sent[op->face->number] & NS_FACESENT_FACE))
418 esrv_send_face(&pl->contr->socket, op->face->number,0);
419 SockList_AddInt(&sl, op->face->number);
420 } 413 {
414 ns->send_face (op->face, -50);
415 ns->flush_fx ();
416 sl << uint32 (op->face);
417 }
418
421 if (flags & UPD_NAME) { 419 if (flags & UPD_NAME)
422 int len; 420 {
421 int len;
423 const char *item_p; 422 const char *item_p;
424 char item_n[MAX_BUF]; 423 char item_n[MAX_BUF];
425 424
426 if (!op->custom_name) { 425 if (!op->custom_name)
426 {
427 strncpy(item_n,query_base_name(op, 0),127); 427 strncpy (item_n, query_base_name (op, 0), 127);
428 item_n[127]=0; 428 item_n[127] = 0;
429 len=strlen(item_n); 429 len = strlen (item_n);
430 item_p=query_base_name(op, 1); 430 item_p = query_base_name (op, 1);
431 } 431 }
432 else { 432 else
433 {
433 strncpy(item_n,op->custom_name,127); 434 strncpy (item_n, op->custom_name, 127);
434 item_n[127]=0; 435 item_n[127] = 0;
435 len=strlen(item_n); 436 len = strlen (item_n);
436 item_p=op->custom_name; 437 item_p = op->custom_name;
437 } 438 }
438 439
439 strncpy(item_n+len+1, item_p, 127); 440 strncpy (item_n + len + 1, item_p, 127);
440 item_n[254]=0; 441 item_n[254] = 0;
441 len += strlen(item_n+1+len) + 1; 442 len += strlen (item_n + 1 + len) + 1;
442 SockList_AddChar(&sl, (char)len); 443
443 memcpy(sl.buf+sl.len, item_n, len); 444 sl << data8 (item_n, len);
444 sl.len += len;
445 } 445 }
446
446 if (flags & UPD_ANIM) 447 if (flags & UPD_ANIM)
447 SockList_AddShort(&sl,op->animation_id); 448 sl << uint16 (op->animation_id);
448 449
449 if (flags & UPD_ANIMSPEED) { 450 if (flags & UPD_ANIMSPEED)
451 {
450 int anim_speed=0; 452 int anim_speed = 0;
453
451 if (QUERY_FLAG(op,FLAG_ANIMATE)) { 454 if (QUERY_FLAG (op, FLAG_ANIMATE))
452 if (op->anim_speed) anim_speed=op->anim_speed; 455 {
453 else { 456 if (op->anim_speed)
454 if (FABS(op->speed)<0.001) anim_speed=255; 457 anim_speed = op->anim_speed;
455 else if (FABS(op->speed)>=1.0) anim_speed=1; 458 else
456 else anim_speed = (int) (1.0/FABS(op->speed)); 459 {
460 if (fabs (op->speed) < 0.001)
461 anim_speed = 255;
462 else if (fabs (op->speed) >= 1.0)
463 anim_speed = 1;
464 else
465 anim_speed = (int) (1.0 / fabs (op->speed));
466 }
467
468 if (anim_speed > 255)
469 anim_speed = 255;
470 }
471
472 sl << uint8 (anim_speed);
457 } 473 }
458 if (anim_speed>255) anim_speed=255; 474
459 }
460 SockList_AddChar(&sl, (char)anim_speed);
461 }
462 if (flags & UPD_NROF) 475 if (flags & UPD_NROF)
463 SockList_AddInt(&sl, op->nrof); 476 sl << uint32 (op->nrof);
464 477
465 Send_With_Handling(&pl->contr->socket, &sl); 478 pl->contr->ns->send_packet (sl);
466 free(sl.buf);
467} 479}
468 480
469/** 481/**
470 * Sends item's info to player. 482 * Sends item's info to player.
471 */ 483 */
484void
472void esrv_send_item(object *pl, object*op) 485esrv_send_item (object *pl, object *op)
473{ 486{
474 SockList sl; 487 if (!pl->contr->ns)
475
476 /* If this is not the player object, do some more checks */
477 if (op!=pl) {
478 /* We only send 'visibile' objects to the client */
479 if (! LOOK_OBJ(op))
480 return; 488 return;
481 /* if the item is on the ground, mark that the look needs to 489
482 * be updated. 490 /* We only send 'visible' objects to the client, and sometimes the player */
483 */ 491 if (!op->client_visible () && op->type != PLAYER)
484 if (!op->env) {
485 pl->contr->socket.update_look=1;
486 return; 492 return;
487 }
488 }
489 493
490 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 494 packet sl;
491 495
492 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 496 sl.printf ("item%d ", pl->contr->ns->itemcmd);
493 sl.len=strlen((char*)sl.buf);
494 497
495 if (op->head) op=op->head; 498 op = op->head_ ();
496 499
497 SockList_AddInt(&sl, op->env? op->env->count:0); 500 sl << uint32 (op->env ? op->env->count : 0);
498 501
499 add_object_to_socklist(&pl->contr->socket, &sl, op); 502 add_object_to_socklist (*pl->contr->ns, sl, op);
500 503
501 Send_With_Handling(&pl->contr->socket, &sl); 504 pl->contr->ns->send_packet (sl);
502 SET_FLAG(op, FLAG_CLIENT_SENT);
503 free(sl.buf);
504} 505}
505 506
506/** 507/**
507 * Tells the client to delete an item. Uses the item 508 * Tells the client to delete an item.
508 * command with a -1 location.
509 */ 509 */
510 510void
511void esrv_del_item(player *pl, int tag) 511esrv_del_item (player *pl, int tag)
512{ 512{
513 SockList sl; 513 if (!pl->ns)
514 return;
514 515
515 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 516 packet sl ("delitem");
516 517
517 strcpy((char*)sl.buf,"delitem "); 518 sl << uint32 (tag);
518 sl.len=strlen((char*)sl.buf);
519 SockList_AddInt(&sl, tag);
520 519
521 Send_With_Handling(&pl->socket, &sl); 520 pl->ns->send_packet (sl);
522 free(sl.buf);
523} 521}
524 522
525 523
526/******************************************************************************* 524/*******************************************************************************
527 * 525 *
… …
531 529
532/** 530/**
533 * Takes a player and object count (tag) and returns the actual object 531 * Takes a player and object count (tag) and returns the actual object
534 * pointer, or null if it can't be found. 532 * pointer, or null if it can't be found.
535 */ 533 */
536 534object *
537object *esrv_get_ob_from_count(object *pl, tag_t count) 535esrv_get_ob_from_count (object *pl, tag_t count)
538{ 536{
539 object *op, *tmp; 537 if (pl->count == count)
538 return pl;
540 539
540 for (object *op = pl->inv; op; op = op->below)
541 if (pl->count == count) 541 if (op->count == count)
542 return pl;
543
544 for(op = pl->inv; op; op = op->below)
545 if (op->count == count)
546 return op; 542 return op;
547 else if (op->type == CONTAINER && pl->container == op) 543 else if (op->type == CONTAINER && pl->container == op)
548 for(tmp = op->inv; tmp; tmp = tmp->below) 544 for (object *tmp = op->inv; tmp; tmp = tmp->below)
549 if (tmp->count == count) 545 if (tmp->count == count)
550 return tmp; 546 return tmp;
551 547
552 for(op = get_map_ob (pl->map, pl->x, pl->y); op; op = op->above) 548 for (object *op = GET_MAP_OB (pl->map, pl->x, pl->y); op; op = op->above)
553 if (op->head != NULL && op->head->count == count) 549 if (op->head && op->head->count == count)
554 return op; 550 return op;
555 else if (op->count == count) 551 else if (op->count == count)
556 return op; 552 return op;
557 else if (op->type == CONTAINER && pl->container == op) 553 else if (op->type == CONTAINER && pl->container == op)
558 for(tmp = op->inv; tmp; tmp = tmp->below) 554 for (object *tmp = op->inv; tmp; tmp = tmp->below)
559 if (tmp->count == count)
560 return tmp;
561
562 if (pl->contr->transport) {
563 for(tmp = pl->contr->transport->inv; tmp; tmp = tmp->below)
564 if (tmp->count == count) 555 if (tmp->count == count)
565 return tmp; 556 return tmp;
566 } 557
558#if 0
559 /* If the high bit is set, player examined a pseudo object. */
560 if (count & 0x80000000)
567 return NULL; 561 return 0;
568} 562#endif
569 563
564 return 0;
565}
570 566
571/** Client wants to examine some object. So lets do so. */ 567/** Client wants to examine some object. So lets do so. */
568void
572void ExamineCmd(char *buf, int len,player *pl) 569ExamineCmd (char *buf, int len, player *pl)
573{ 570{
574 long tag = atoi(buf); 571 tag_t tag = atoi (buf);
572
573 /* If the high bit is set, player applied a pseudo object. */
574 if (tag & 0x80000000)
575 {
576 pl->ns->look_position = tag & 0x7fffffff;
577 pl->ns->floorbox_update ();
578 return;
579 }
580
575 object *op = esrv_get_ob_from_count(pl->ob, tag); 581 object *op = esrv_get_ob_from_count (pl->ob, tag);
576 582
577 if (!op) { 583 if (!op)
584 {
578 LOG(llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", 585 LOG (llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", &pl->ob->name, tag);
579 pl->ob->name, tag); 586 return;
580 return;
581 } 587 }
588
582 examine (pl->ob, op); 589 examine (pl->ob, op);
583} 590}
584 591
592/** Client wants to examine some object. So lets do so. */
593void
594ExCmd (char *buf, int len, player *pl)
595{
596 tag_t tag = atoi (buf);
597
598 if (object *op = esrv_get_ob_from_count (pl->ob, tag))
599 {
600 std::string s = op->describe (pl->ob);
601
602 packet sl ("ex");
603 sl << ber32 (tag)
604 << data (*pl->expand_cfpod (s.c_str ()));
605
606 pl->ns->send_packet (sl);
607 }
608}
609
585/** Client wants to apply some object. Lets do so. */ 610/** Client wants to apply some object. Lets do so. */
611void
586void ApplyCmd(char *buf, int len,player *pl) 612ApplyCmd (char *buf, int len, player *pl)
587{ 613{
588 uint32 tag = atoi(buf); 614 tag_t tag = atoi (buf);
589 object *op = esrv_get_ob_from_count(pl->ob, tag);
590 615
591 /* sort of a hack, but if the player saves and the player then manually
592 * applies a savebed (or otherwise tries to do stuff), we run into trouble.
593 */
594 if (QUERY_FLAG(pl->ob, FLAG_REMOVED)) return;
595
596 /* If the high bit is set, player applied a pseudo object. */ 616 /* If the high bit is set, player applied a pseudo object. */
597 if (tag & 0x80000000) { 617 if (tag & 0x80000000)
618 {
598 pl->socket.look_position = tag & 0x7fffffff; 619 pl->ns->look_position = tag & 0x7fffffff;
599 pl->socket.update_look = 1; 620 pl->ns->floorbox_update ();
600 return; 621 return;
601 } 622 }
602 623
624 object *op = esrv_get_ob_from_count (pl->ob, tag);
625
603 if (!op) { 626 if (!op)
627 {
604 LOG(llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", 628 LOG (llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", &pl->ob->name, tag);
605 pl->ob->name, tag); 629 return;
606 return;
607 } 630 }
631
608 player_apply (pl->ob, op, 0, 0); 632 player_apply (pl->ob, op, 0, 0);
609} 633}
610 634
611/** Client wants to apply some object. Lets do so. */ 635/** Client wants to lock some object. Lets do so. */
636void
612void LockItem(uint8 *data, int len,player *pl) 637LockItem (char *data, int len, player *pl)
613{ 638{
614 int flag, tag;
615 object *op;
616
617 flag = data[0]; 639 int flag = data[0];
618 tag = GetInt_String(data+1); 640 tag_t tag = net_uint32 ((uint8 *)data + 1);
619 op = esrv_get_ob_from_count(pl->ob, tag); 641 object *op = esrv_get_ob_from_count (pl->ob, tag);
620 642
621 if (!op) { 643 if (!op)
622 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to lock/unlock");
623 return;
624 } 644 {
645 pl->failmsg ("Could not find object to lock/unlock");
646 return;
647 }
648
625 if (!flag) 649 if (!flag)
626 CLEAR_FLAG(op,FLAG_INV_LOCKED); 650 CLEAR_FLAG (op, FLAG_INV_LOCKED);
627 else 651 else
628 SET_FLAG(op,FLAG_INV_LOCKED); 652 SET_FLAG (op, FLAG_INV_LOCKED);
653
629 esrv_update_item(UPD_FLAGS, pl->ob, op); 654 esrv_update_item (UPD_FLAGS, pl->ob, op);
630} 655}
631 656
632/** Client wants to apply some object. Lets do so. */ 657/** Client wants to mark some object. Lets do so. */
658void
633void MarkItem(uint8 *data, int len,player *pl) 659MarkItem (char *data, int len, player *pl)
634{ 660{
635 int tag; 661 tag_t tag = net_uint32 ((uint8 *)data);
636 object *op;
637
638 tag = GetInt_String(data);
639 op = esrv_get_ob_from_count(pl->ob, tag); 662 object *op = esrv_get_ob_from_count (pl->ob, tag);
663
640 if (!op) { 664 if (!op)
641 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to mark");
642 return;
643 } 665 {
666 pl->failmsg ("Could not find object to mark");
667 return;
668 }
669
644 pl->mark = op; 670 pl->mark = op;
645 pl->mark_count = op->count; 671 pl->ob->statusmsg (format ("Marked item %s", query_name (op)));
646 new_draw_info_format(NDI_UNIQUE, 0, pl->ob, "Marked item %s", query_name(op));
647} 672}
648
649 673
650/** 674/**
651 * look_at prints items on the specified square. 675 * look_at prints items on the specified square.
652 * 676 *
653 * [ removed EARTHWALL check and added check for containers inventory. 677 * [ removed EARTHWALL check and added check for containers inventory.
654 * Tero.Haatanen@lut.fi ] 678 * Tero.Haatanen@lut.fi ]
655 */ 679 */
656void look_at(object *op,int dx,int dy) { 680static void
657 object *tmp; 681look_at (player *pl, int dx, int dy)
658 int flag=0; 682{
659 sint16 x,y; 683 dynbuf_text buf;
660 mapstruct *m; 684 object *ob = pl->ob;
661 685
662 x = op->x + dx; 686 if (!pl->observe->map)
663 y = op->y + dy; 687 return;
664 688
665 if (out_of_map(op->map, x, y)) return; 689 mapxy pos (pl->observe);
690 pos.move (dx, dy);
666 691
667 m = get_map_from_coord(op->map, &x, &y); 692 if (pos.normalise ())
668 if (!m) return; 693 for (object *tmp = pos->top; tmp; tmp = tmp->below)
669 694 {
670 for(tmp=get_map_ob(m, x ,y);tmp!=NULL&&tmp->above!=NULL;
671 tmp=tmp->above);
672
673 for ( ; tmp != NULL; tmp=tmp->below ) {
674 if (tmp->invisible && !QUERY_FLAG(op, FLAG_WIZ)) continue; 695 if (tmp->invisible && !QUERY_FLAG (ob, FLAG_WIZ))
696 continue;
675 697
676 if(!flag) {
677 if(dx||dy)
678 new_draw_info(NDI_UNIQUE, 0,op,"There you see:");
679 else {
680 clear_win_info(op);
681 new_draw_info(NDI_UNIQUE, 0,op,"You see:");
682 }
683 flag=1;
684 }
685
686 if (QUERY_FLAG(op, FLAG_WIZ)) 698 if (QUERY_FLAG (ob, FLAG_WIZ))
687 new_draw_info_format(NDI_UNIQUE,0, op, "- %s (%d).",query_name(tmp),tmp->count); 699 buf.printf (" - %s (%d).\n", query_name (tmp), tmp->count);
688 else 700 else
689 new_draw_info_format(NDI_UNIQUE,0, op, "- %s.",query_name(tmp)); 701 buf.printf (" - %s.\n", query_name (tmp));
690 702
691 if (((tmp->inv!=NULL || (tmp->head && tmp->head->inv)) && 703 object *head = tmp->head_ ();
692 (tmp->type != CONTAINER && tmp->type!=FLESH)) || QUERY_FLAG(op, FLAG_WIZ))
693 inventory(op,tmp->head==NULL?tmp:tmp->head);
694 704
705 if (head->inv)
706 if ((head->type != CONTAINER && head->type != FLESH)
707 || QUERY_FLAG (ob, FLAG_WIZ))
708 buf << head->query_inventory (ob, " ");
709
695 if(QUERY_FLAG(tmp, FLAG_IS_FLOOR)&&!QUERY_FLAG(op, FLAG_WIZ)) /* don't continue under the floor */ 710 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !QUERY_FLAG (ob, FLAG_WIZ)) /* don't continue under the floor */
696 break; 711 break;
697 } 712 }
698 713
699 if(!flag) { 714 if (buf.empty ())
700 if(dx||dy) 715 pl->failmsg ("You see nothing there.");
701 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing there."); 716 else
702 else 717 pl->infobox (MSG_CHANNEL ("lookat"), buf);
703 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing.");
704 }
705} 718}
706
707
708 719
709/** Client wants to look at some object. Lets do so. */ 720/** Client wants to look at some object. Lets do so. */
721void
710void LookAt(char *buf, int len,player *pl) 722LookAt (char *buf, int len, player *pl)
711{ 723{
712 int dx, dy;
713 char *cp; 724 char *cp;
714 725
715 dx=atoi(buf); 726 int dx = atoi (buf);
716 if (!(cp=strchr(buf,' '))) { 727 if (!(cp = strchr (buf, ' ')))
717 return; 728 return;
718 } 729
719 dy=atoi(cp); 730 int dy = atoi (cp);
720 731
721 if (FABS(dx) > pl->socket.mapx / 2 || FABS(dy) > pl->socket.mapy / 2) 732 if (player *opl = pl->observe->contr)
733 if (client *ns = opl->ns)
734 {
735 if (fabs (dx) > ns->mapx / 2 || fabs (dy) > ns->mapy / 2)
722 return; 736 return;
723 737
724 if(pl->blocked_los[dx + pl->socket.mapx / 2][dy + pl->socket.mapy / 2]) 738 if (opl->blocked_los[dx + ns->mapx / 2][dy + ns->mapy / 2])
725 return; 739 return;
740 }
726 741
727 look_at(pl->ob, dx, dy); 742 look_at (pl, dx, dy);
728} 743}
729 744
730/** Move an object to a new location */ 745/** Move an object to a new location */
746void
731void esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof) 747esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof)
732{ 748{
733 object *op, *env;
734
735 op = esrv_get_ob_from_count(pl, tag); 749 object *op = esrv_get_ob_from_count (pl, tag);
736 if (!op) { 750 if (!op)
751 {
737 LOG(llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", 752 LOG (llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", &pl->name, tag);
738 pl->name, tag);
739 return;
740 }
741
742 /* If on a transport, you don't drop to the ground - you drop to the
743 * transport.
744 */
745 if (!to && !pl->contr->transport) { /* drop it to the ground */
746/* LOG(llevDebug, "Drop it on the ground.\n");*/
747
748 if (op->map && !op->env) {
749/* LOG(llevDebug,"Dropping object to ground that is already on ground\n");*/
750 return; 753 return;
751 } 754 }
755
756 if (!to)
757 { /* drop it to the ground */
758 if (op->map && !op->env)
759 return;
760
752 /* If it is an active container, then we should drop all objects 761 /* If it is an active container, then we should drop all objects
753 * in the container and not the container itself. 762 * in the container and not the container itself.
754 */ 763 */
755 if (op->inv && QUERY_FLAG(op, FLAG_APPLIED)) { 764 if (op->inv && QUERY_FLAG (op, FLAG_APPLIED))
756 object *current, *next; 765 {
757 for (current=op->inv; current!=NULL; current=next) { 766 int cnt = MAX_ITEM_PER_DROP;
758 next=current->below; 767
768 for (object *current = op->inv; current && cnt--; )
769 {
770 object *next = current->below;
759 drop_object(pl, current, 0); 771 drop_object (pl, current, 0);
760 } 772 current = next;
761 esrv_update_item(UPD_WEIGHT, pl, op); 773 }
762 } 774
763 else { 775 if (cnt <= 0)
776 op->failmsg ("Only dropped some items, can't drop that many items at once.");
777 }
778 else
764 drop_object (pl, op, nrof); 779 drop_object (pl, op, nrof);
765 } 780
766 return; 781 return;
767 } else if (to == pl->count) { /* pick it up to the inventory */ 782 }
783 else if (to == pl->count)
784 { /* pick it up to the inventory */
768 /* return if player has already picked it up */ 785 /* return if player has already picked it up */
769 if (op->env == pl) return; 786 if (op->env == pl)
787 return;
770 788
771 pl->contr->count = nrof; 789 pl->contr->count = nrof;
772 pick_up(pl, op); 790 pick_up (pl, op);
773 return ;
774 }
775 /* If not dropped or picked up, we are putting it into a sack */
776 if (pl->contr->transport) {
777 if (can_pick(pl, op) && transport_can_hold(pl->contr->transport, op, nrof)) {
778 put_object_in_sack (pl, pl->contr->transport, op, nrof);
779 }
780 } else {
781 env = esrv_get_ob_from_count(pl, to);
782 if (!env) {
783 LOG(llevDebug,
784 "Player '%s' tried to move object to the unknown location (%d)\n",
785 pl->name, to);
786 return; 791 return;
787 } 792 }
793
794 object *env = esrv_get_ob_from_count (pl, to);
795 if (!env)
796 {
797 LOG (llevDebug, "Player '%s' tried to move object to the unknown location (%d)\n", &pl->name, to);
798 return;
799 }
800
788 /* put_object_in_sack presumes that necessary sanity checking 801 /* put_object_in_sack presumes that necessary sanity checking
789 * has already been done (eg, it can be picked up and fits in 802 * has already been done (eg, it can be picked up and fits in
790 * in a sack, so check for those things. We should also check 803 * in a sack, so check for those things. We should also check
791 * an make sure env is in fact a container for that matter. 804 * an make sure env is in fact a container for that matter.
792 */ 805 */
793 if (env->type == CONTAINER 806 if (env->type == CONTAINER
807 && can_pick (pl, op)
794 && can_pick(pl, op) && sack_can_hold(pl, env, op, nrof)) { 808 && sack_can_hold (pl, env, op, nrof))
795 put_object_in_sack (pl, env, op, nrof); 809 put_object_in_sack (pl, env, op, nrof);
796 }
797 }
798} 810}
799 811
800

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines