ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/item.C
(Generate patch)

Comparing deliantra/server/socket/item.C (file contents):
Revision 1.2 by root, Tue Aug 29 07:34:01 2006 UTC vs.
Revision 1.89 by root, Sat Apr 3 02:27:24 2010 UTC

1
2/* 1/*
3 * static char *rcsid_item_c = 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
4 * "$Id: item.C,v 1.2 2006/08/29 07:34:01 root Exp $"; 3 *
5 */ 4 * Copyright (©) 2005,2006,2007,2008,2009,2010 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
6
7/*
8 CrossFire, A Multiplayer game for X-windows
9
10 Copyright (C) 2002 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
12 7 *
13 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
14 it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
15 the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
16 (at your option) any later version. 11 * option) any later version.
17 12 *
18 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details. 16 * GNU General Public License for more details.
22 17 *
23 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
24 along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
26 21 *
27 The author can be reached via e-mail to crossfire-devel@real-time.com 22 * The authors can be reached via e-mail to <support@deliantra.net>
28*/ 23 */
29 24
30/** 25/**
31 * \file 26 * \file
32 * Client/server logic. 27 * Client/server logic.
33 * 28 *
34 * \date 2003-12-02 29 * \date 2003-12-02
35 * 30 *
36 * This containes item logic for client/server. It doesn't contain 31 * This contains item logic for client/server. It doesn't contain
37 * the actual commands that send the data, but does contain 32 * the actual commands that send the data, but does contain
38 * the logic for what items should be sent. 33 * the logic for what items should be sent.
39 */ 34 */
40 35
41
42#include <global.h> 36#include <global.h>
43#include <object.h> /* LOOK_OBJ */
44#include <newclient.h> 37#include <object.h>
45#include <newserver.h>
46#include <sproto.h> 38#include <sproto.h>
47 39
48/** This is the maximum number of bytes we expect any one item to take up */ 40/** This is the maximum number of bytes we expect any one item to take up */
49#define MAXITEMLEN 300 41#define MAXITEMLEN 300
50 42
… …
53 * Functions related to sending object data to the client. 45 * Functions related to sending object data to the client.
54 * 46 *
55 ******************************************************************************/ 47 ******************************************************************************/
56 48
57/** 49/**
58 * Adds string to socklist.
59 *
60 * This is a simple function that we use a lot here. It basically
61 * adds the specified buffer into the socklist, but prepends a
62 * single byte in length. If the data is longer than that byte, it is
63 * truncated approprately.
64 */
65inline void add_stringlen_to_sockbuf(const char *buf, SockList *sl)
66{
67 int len;
68
69 len=strlen(buf);
70 if (len>255) len=255;
71 SockList_AddChar(sl, (char) len);
72 strncpy((char*)sl->buf+sl->len, buf,len);
73 sl->len += len;
74}
75
76/**
77 * This is a similar to query_name, but returns flags 50 * This is a similar to query_name, but returns flags
78 * to be sended to client. 51 * to be sent to client.
79 */ 52 */
53static unsigned int
80unsigned int query_flags (object *op) 54query_flags (object *op)
81{ 55{
82 unsigned int flags = 0; 56 unsigned int flags = 0;
83 57
84 if(QUERY_FLAG(op,FLAG_APPLIED)) { 58 if (QUERY_FLAG (op, FLAG_APPLIED))
85 switch(op->type) { 59 switch (op->type)
60 {
86 case BOW: 61 case BOW:
87 case WAND: 62 case WAND:
88 case ROD: 63 case ROD:
89 case HORN: 64 case HORN:
90 flags = a_readied; 65 flags = a_readied;
91 break; 66 break;
92 case WEAPON: 67 case WEAPON:
93 flags = a_wielded; 68 flags = a_wielded;
94 break; 69 break;
95 case SKILL: 70 case SKILL:
96 case ARMOUR: 71 case ARMOUR:
97 case HELMET: 72 case HELMET:
98 case SHIELD: 73 case SHIELD:
99 case RING: 74 case RING:
100 case BOOTS: 75 case BOOTS:
101 case GLOVES: 76 case GLOVES:
102 case AMULET: 77 case AMULET:
103 case GIRDLE: 78 case GIRDLE:
104 case BRACERS: 79 case BRACERS:
105 case CLOAK: 80 case CLOAK:
106 flags = a_worn; 81 flags = a_worn;
107 break; 82 break;
108 case CONTAINER: 83 case CONTAINER:
109 flags = a_active; 84 flags = a_active;
110 break; 85 break;
111 default: 86 default:
112 flags = a_applied; 87 flags = a_applied;
113 break; 88 break;
114 }
115 } 89 }
116 if (op->type == CONTAINER && ((op->env && op->env->container == op) || 90
117 (!op->env && QUERY_FLAG(op,FLAG_APPLIED)))) 91 if (op->is_open_container ())
118 flags |= F_OPEN; 92 flags |= F_OPEN;
119 93
120 if (QUERY_FLAG(op,FLAG_KNOWN_CURSED)) { 94 if (QUERY_FLAG (op, FLAG_KNOWN_CURSED))
95 {
121 if(QUERY_FLAG(op,FLAG_DAMNED)) 96 if (QUERY_FLAG (op, FLAG_DAMNED))
122 flags |= F_DAMNED; 97 flags |= F_DAMNED;
123 else if(QUERY_FLAG(op,FLAG_CURSED)) 98 else if (QUERY_FLAG (op, FLAG_CURSED))
124 flags |= F_CURSED; 99 flags |= F_CURSED;
125 } 100 }
101
126 if (QUERY_FLAG(op,FLAG_KNOWN_MAGICAL) && !QUERY_FLAG(op,FLAG_IDENTIFIED)) 102 if (QUERY_FLAG (op, FLAG_KNOWN_MAGICAL) && !QUERY_FLAG (op, FLAG_IDENTIFIED))
127 flags |= F_MAGIC; 103 flags |= F_MAGIC;
128 if (QUERY_FLAG(op,FLAG_UNPAID)) 104 if (QUERY_FLAG (op, FLAG_UNPAID))
129 flags |= F_UNPAID; 105 flags |= F_UNPAID;
130 if (QUERY_FLAG(op,FLAG_INV_LOCKED)) 106 if (QUERY_FLAG (op, FLAG_INV_LOCKED))
131 flags |= F_LOCKED; 107 flags |= F_LOCKED;
132 108
133 return flags; 109 return flags;
134} 110}
135 111
136/* Used in the send_look to put object head into SockList 112/* Used in the send_look to put object head into packet
137 * sl for socket ns. Need socket to know if we need to send 113 * sl for socket ns. Need socket to know if we need to send
138 * animation of face to the client. 114 * animation of face to the client.
139 */ 115 */
140static void add_object_to_socklist(NewSocket *ns, SockList *sl, object *head) 116static void
117add_object_to_socklist (client &ns, packet &sl, object *head)
141{ 118{
142 int flags, len, anim_speed;
143 char item_n[MAX_BUF];
144 const char *item_p;
145
146 flags = query_flags (head); 119 int flags = query_flags (head);
120
147 if (QUERY_FLAG(head, FLAG_NO_PICK)) 121 if (QUERY_FLAG (head, FLAG_NO_PICK))
148 flags |= F_NOPICK; 122 flags |= F_NOPICK;
149 123
150 if (!(ns->faces_sent[head->face->number] & NS_FACESENT_FACE)) 124 ns.send_face (head->face, -50);
151 esrv_send_face(ns, head->face->number,0); 125 ns.flush_fx ();
152 126
153 if (QUERY_FLAG(head,FLAG_ANIMATE) && !ns->anims_sent[head->animation_id]) 127 if (QUERY_FLAG (head, FLAG_ANIMATE) && !ns.anims_sent[head->animation_id])
154 esrv_send_animation(ns, head->animation_id); 128 ns.send_animation (head->animation_id);
155 129
156 SockList_AddInt(sl, head->count); 130 sl << uint32 (head->count)
157 SockList_AddInt(sl, flags); 131 << uint32 (flags)
158 SockList_AddInt(sl, QUERY_FLAG(head, FLAG_NO_PICK) ? -1 : WEIGHT(head)); 132 << uint32 (QUERY_FLAG (head, FLAG_NO_PICK) ? -1 : head->client_weight ())
159 SockList_AddInt(sl, head->face->number); 133 << uint32 (head->face);
160 134
161 if (!head->custom_name) { 135 if (!head->custom_name)
162 strncpy(item_n,query_base_name(head, 0),127);
163 item_n[127]=0;
164 len=strlen(item_n);
165 item_p=query_base_name(head, 1);
166 } else {
167 strncpy(item_n,head->custom_name,127);
168 item_n[127]=0;
169 len=strlen(item_n);
170 item_p=head->custom_name;
171 } 136 {
172 strncpy(item_n+len+1, item_p, 127); 137 const char *name;
173 item_n[254]=0; 138 uint8 *len = sl.cur++; // patch up length later
174 len += strlen(item_n+1+len) + 1;
175 SockList_AddChar(sl, (char ) len);
176 memcpy(sl->buf+sl->len, item_n, len);
177 sl->len += len;
178 139
179 SockList_AddShort(sl,head->animation_id); 140 name = query_base_name (head, 0); sl << data (name, min (127, strlen (name)));
180 anim_speed=0; 141 sl << uint8 (0);
181 if (QUERY_FLAG(head,FLAG_ANIMATE)) { 142 name = query_base_name (head, 1); sl << data (name, min (127, strlen (name)));
182 if (head->anim_speed) anim_speed=head->anim_speed; 143
183 else { 144 *len = sl.cur - len - 1;
184 if (FABS(head->speed)<0.001) anim_speed=255; 145 }
185 else if (FABS(head->speed)>=1.0) anim_speed=1; 146 else
186 else anim_speed = (int) (1.0/FABS(head->speed));
187 }
188 if (anim_speed>255) anim_speed=255;
189 } 147 {
190 SockList_AddChar(sl, (char) anim_speed); 148 int len = min (head->custom_name.length (), 127);
191 SockList_AddInt(sl, head->nrof);
192 149
150 sl << uint8 (len * 2 + 1)
151 << data (head->custom_name, len)
152 << uint8 (0)
153 << data (head->custom_name, len);
154 }
155
156 sl << uint16 (head->animation_id);
157
158 int anim_speed = !head->flag [FLAG_ANIMATE] ? 0
159 : head->anim_speed ? clamp (head->anim_speed, 1, 255)
160 : 1. / clamp (head->speed, 1./255., 1./1.);
161
162 sl << uint8 (anim_speed)
163 << uint32 (head->nrof);
164
193 if (ns->itemcmd == 2) 165 if (ns.itemcmd == 2)
194 SockList_AddShort(sl, head->client_type); 166 sl << uint16 (head->client_type);
195
196 SET_FLAG(head, FLAG_CLIENT_SENT);
197} 167}
198 168
169static faceidx
170need_face_now (player *pl, const char *name)
171{
172 faceidx face = face_find (name, empty_face);
173
174 pl->ns->send_face (face, -50);
175 pl->ns->flush_fx ();
176
177 return face;
178}
179
180#define FINGER_UP "finger_up.x11"
181#define FINGER_DOWN "finger_down.x11"
199 182
200/** 183/**
201 * Send the look window. Don't need to do animations here 184 * Send the look window. Don't need to do animations here
202 * This sends all the faces to the client, not just updates. This is 185 * This sends all the faces to the client, not just updates. This is
203 * because object ordering would otherwise be inconsistent 186 * because object ordering would otherwise be inconsistent.
204 */ 187 */
205 188void
206void esrv_draw_look(object *pl) 189esrv_draw_look (player *pl)
207{ 190{
208 object *tmp, *last; 191 object *ob = pl->ob;
209 int got_one=0,start_look=0, end_look=0;
210 SockList sl;
211 char buf[MAX_BUF];
212 192
213 if (!pl->contr->socket.update_look) { 193 if (!pl->ns->update_look)
194 {
214 LOG(llevDebug,"esrv_draw_look called when update_look was not set\n"); 195 LOG (llevDebug, "esrv_draw_look called when update_look was not set (player %s)\n", &ob->name);
215 return; 196 return;
216 } else {
217 pl->contr->socket.update_look=0;
218 } 197 }
219 198
220 if(QUERY_FLAG(pl, FLAG_REMOVED) || pl->map == NULL || 199 pl->ns->update_look = 0;
221 pl->map->in_memory != MAP_IN_MEMORY || out_of_map(pl->map,pl->x,pl->y)) 200
201 if (QUERY_FLAG (ob, FLAG_REMOVED)
202 || !ob->map
203 || ob->map->in_memory != MAP_ACTIVE
204 || out_of_map (ob->map, ob->x, ob->y))
222 return; 205 return;
223 206
224 for (tmp=get_map_ob(pl->map,pl->x,pl->y); tmp && tmp->above;tmp=tmp->above) ; 207 pl->ns->send_packet ("delinv 0");
225 208
226 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 209 packet sl;
210 sl.printf ("item%d ", pl->ns->itemcmd);
227 211
228 Write_String_To_Socket(&pl->contr->socket, "delinv 0", strlen("delinv 0")); 212 sl << uint32 (0);
229 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
230 sl.len=strlen((char*)sl.buf);
231 213
232 SockList_AddInt(&sl, 0); 214 int start_pos = pl->ns->look_position;
215 bool dirty = false;
233 216
234 if (!(pl->contr->socket.faces_sent[empty_face->number]&NS_FACESENT_FACE)) 217 mapspace &ms = ob->ms ();
235 esrv_send_face(&pl->contr->socket, empty_face->number,0);
236 218
237 if (pl->contr->socket.look_position) { 219 // manage a ring buffer of the "last FLOORBOX_PAGESIZE" items and
238 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position- NUM_LOOK_OBJECTS)); 220 // start from the top
239 SockList_AddInt(&sl, 0); 221 object *items [FLOORBOX_PAGESIZE];
240 SockList_AddInt(&sl, (uint32) -1); 222 int item_idx = 0, item_cnt = 0;
241 SockList_AddInt(&sl, empty_face->number); 223 int pos = 0;
242 sprintf(buf,"Click here to see %d previous items", NUM_LOOK_OBJECTS); 224
243 add_stringlen_to_sockbuf(buf, &sl); 225 // find our items by walking down
244 SockList_AddShort(&sl,0); 226 object *item = ms.top;
245 SockList_AddChar(&sl, 0); 227
246 SockList_AddInt(&sl, 0); 228 for (; item && item_cnt < FLOORBOX_PAGESIZE; item = item->below)
247 if (pl->contr->socket.itemcmd == 2)
248 SockList_AddShort(&sl, 0);
249 } 229 {
230 if (!item->client_visible ())
231 continue;
250 232
251 for (last=NULL; tmp!=last; tmp=tmp->below) { 233 if (++pos < start_pos)
252 object *head; 234 continue;
253 235
254 if (QUERY_FLAG(tmp, FLAG_IS_FLOOR) && !last) { 236 // record item
255 last = tmp->below; /* assumes double floor mode */ 237 items [item_idx] = item; item_idx = item_idx < FLOORBOX_PAGESIZE ? item_idx + 1 : 0;
256 if (last && QUERY_FLAG(last, FLAG_IS_FLOOR)) 238 item_cnt++;
257 last = last->below; 239
258 } 240 // stop at first floor
259 if (LOOK_OBJ(tmp)) { 241 if (item->flag [FLAG_IS_FLOOR])
260 if (++start_look < pl->contr->socket.look_position) continue; 242 {
261 end_look++; 243 // we are finished, don't append "next group of items"
262 if (end_look > NUM_LOOK_OBJECTS) { 244 // by setting item to ms.bot it becomes zero which is checked after the while loop
245 item = ms.bot;
246 }
247 }
248
249 // see if there are more if we cared - we ignore invisible objects
250 if (item)
251 {
263 /* What we basically do is make a 'fake' object - when the user applies it, 252 /* What we basically do is make a 'fake' object - when the user applies it,
264 * we notice the special tag the object has, and act accordingly. 253 * we notice the special tag the object has, and act accordingly.
265 */ 254 */
266 SockList_AddInt(&sl, 0x80000000 | (pl->contr->socket.look_position+ NUM_LOOK_OBJECTS)); 255 sl << uint32 (0x80000000 | (start_pos + FLOORBOX_PAGESIZE))
267 SockList_AddInt(&sl, 0); 256 << uint32 (0)
268 SockList_AddInt(&sl, (uint32) -1); 257 << uint32 ((uint32) - 1)
269 SockList_AddInt(&sl, empty_face->number); 258 << uint32 (need_face_now (pl, FINGER_DOWN))
270 sprintf(buf,"Click here to see next group of items"); 259 << data8 ("Apply this to see the items below")
271 add_stringlen_to_sockbuf(buf, &sl); 260 << uint16 (0)
272 SockList_AddShort(&sl,0); 261 << uint8 (0)
273 SockList_AddChar(&sl, 0); 262 << uint32 (0);
274 SockList_AddInt(&sl, 0); 263
275 if (pl->contr->socket.itemcmd == 2) 264 if (pl->ns->itemcmd == 2)
276 SockList_AddShort(&sl, 0); 265 sl << uint16 (0);
277 break; 266
267 dirty = true;
278 } 268 }
279 if (tmp->head) head = tmp->head;
280 else head = tmp;
281 269
270 // now send out all items in the ring buffer in reverse order
271 while (item_cnt)
272 {
273 --item_cnt;
274 item_idx = (item_idx ? item_idx : FLOORBOX_PAGESIZE) - 1;
275 object *item = items [item_idx];
276
282 add_object_to_socklist(&pl->contr->socket, &sl, head); 277 add_object_to_socklist (*pl->ns, sl, item->head_ ());
283 got_one++;
284 278
279 dirty = true;
280
281 // if packet got too large, send it and begin a new one
285 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) { 282 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
286 Send_With_Handling(&pl->contr->socket, &sl); 283 {
287 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 284 pl->ns->send_packet (sl);
288 sl.len=strlen((char*)sl.buf); 285
289 SockList_AddInt(&sl, 0); 286 sl.reset ();
290 got_one=0; 287 sl.printf ("item%d ", pl->ns->itemcmd);
288 sl << uint32 (0);
289
290 dirty = false;
291 }
291 } 292 }
292 } /* If LOOK_OBJ() */ 293
294 if (start_pos)
293 } 295 {
294 if (got_one) 296 sl << uint32 (0x80000000 | (start_pos - FLOORBOX_PAGESIZE))
295 Send_With_Handling(&pl->contr->socket, &sl); 297 << uint32 (0)
298 << sint32 (-1)
299 << uint32 (need_face_now (pl, FINGER_UP))
300 << data8 ("Apply this to see the items higher up")
301 << uint16 (0)
302 << uint8 (0)
303 << uint32 (0);
296 304
297 free(sl.buf); 305 if (pl->ns->itemcmd == 2)
306 sl << uint16 (0);
307
308 dirty = true;
309 }
310
311 if (dirty)
312 pl->ns->send_packet (sl);
298} 313}
299 314
300/** 315/**
301 * Sends whole inventory. 316 * Sends whole inventory.
302 */ 317 */
318void
303void esrv_send_inventory(object *pl, object *op) 319esrv_send_inventory (object *pl, object *op)
304{ 320{
305 object *tmp; 321 if (!pl->contr->ns)//D
322 return;
323
306 int got_one=0; 324 int got_one = 0;
307 SockList sl; 325
326 pl->contr->ns->send_packet_printf ("delinv %d", op->count);
327
328 packet sl;
329 sl.printf ("item%d ", pl->contr->ns->itemcmd);
330
331 sl << uint32 (op->count);
332
333 for (object *tmp = op->inv; tmp; tmp = tmp->below)
308 334 {
309 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
310
311 sprintf((char*)sl.buf,"delinv %d", op->count);
312 sl.len=strlen((char*)sl.buf);
313 Send_With_Handling(&pl->contr->socket, &sl);
314
315 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd);
316 sl.len=strlen((char*)sl.buf);
317
318 SockList_AddInt(&sl, op->count);
319
320 for (tmp=op->inv; tmp; tmp=tmp->below) {
321 object *head; 335 object *head;
322 336
323 if (tmp->head) head = tmp->head; 337 if (tmp->head)
324 else head = tmp; 338 head = tmp->head;
339 else
340 head = tmp;
325 341
326 if (LOOK_OBJ(head)) { 342 if (head->client_visible ())
327 add_object_to_socklist(&pl->contr->socket, &sl, head);
328 343 {
344 add_object_to_socklist (*pl->contr->ns, sl, head);
345
329 got_one++; 346 got_one++;
330 347
331 /* IT is possible for players to accumulate a huge amount of 348 /* IT is possible for players to accumulate a huge amount of
332 * items (especially with some of the bags out there) to 349 * items (especially with some of the bags out there) to
333 * overflow the buffer. IF so, send multiple item commands. 350 * overflow the buffer. IF so, send multiple item commands.
334 */ 351 */
335 if (sl.len >= (MAXSOCKBUF-MAXITEMLEN)) { 352 if (sl.length () > MAXSOCKBUF - MAXITEMLEN)
336 Send_With_Handling(&pl->contr->socket, &sl); 353 {
337 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 354 pl->contr->ns->send_packet (sl);
338 sl.len=strlen((char*)sl.buf); 355
339 SockList_AddInt(&sl, op->count); 356 sl.reset ();
340 got_one=0; 357 sl.printf ("item%d ", pl->contr->ns->itemcmd);
358 sl << uint32 (op->count);
359 got_one = 0;
360 }
361 }
341 } 362 }
342 } /* If LOOK_OBJ() */ 363
343 }
344 if (got_one) 364 if (got_one)
345 Send_With_Handling(&pl->contr->socket, &sl); 365 pl->contr->ns->send_packet (sl);
346 free(sl.buf);
347} 366}
348 367
349/** 368/**
350 * Updates object *op for player *pl. 369 * Updates object *op for player *pl.
351 * 370 *
352 * flags is a list of values to update 371 * flags is a list of values to update
353 * to the client (as defined in newclient.h - might as well use the 372 * to the client (as defined in newclient.h - might as well use the
354 * same value both places. 373 * same value both places.
355 */ 374 */
356 375void
357void esrv_update_item(int flags, object *pl, object *op) 376esrv_update_item (int flags, object *pl, object *op)
358{ 377{
359 SockList sl;
360
361 /* If we have a request to send the player item, skip a few checks. */ 378 /* If we have a request to send the player item, skip a few checks. */
362 if (op!=pl) { 379 if (op != pl && !op->client_visible ())
363 if (! LOOK_OBJ(op))
364 return; 380 return;
365 /* we remove the check for op->env, because in theory, the object
366 * is hopefully in the same place, so the client should preserve
367 * order.
368 */
369 }
370 if (!QUERY_FLAG(op, FLAG_CLIENT_SENT)) {
371 /* FLAG_CLIENT_SENT is debug only. We are using it to see where
372 * this is happening - we can set a breakpoint here in the debugger
373 * and track back the call.
374 */
375 LOG(llevDebug,"We have not sent item %s (%d)\n", op->name, op->count);
376 }
377 sl.buf= (unsigned char *) malloc(MAXSOCKBUF);
378 381
379 strcpy((char*)sl.buf,"upditem "); 382 client *ns = pl->contr->ns;
380 sl.len=strlen((char*)sl.buf); 383 if (!ns)
384 return;
381 385
382 SockList_AddChar(&sl, (char) flags); 386 packet sl ("upditem");
383 387
384 if (op->head) op=op->head; 388 sl << uint8 (flags);
385 389
386 SockList_AddInt(&sl, op->count); 390 op = op->head_ ();
387 391
392 sl << uint32 (op->count);
393
388 if (flags & UPD_LOCATION) 394 if (flags & UPD_LOCATION)
389 SockList_AddInt(&sl, op->env? op->env->count:0); 395 sl << uint32 (op->env ? op->env->count : 0);
390 396
391 if (flags & UPD_FLAGS) 397 if (flags & UPD_FLAGS)
392 SockList_AddInt(&sl, query_flags(op)); 398 sl << uint32 (query_flags (op));
393 399
394 if (flags & UPD_WEIGHT) { 400 if (flags & UPD_WEIGHT)
395 sint32 weight = WEIGHT(op);
396
397 SockList_AddInt(&sl, QUERY_FLAG(op, FLAG_NO_PICK) ? -1 : weight);
398 if (pl == op) {
399 op->contr->last_weight = weight;
400 }
401 } 401 {
402 sint32 weight = op->client_weight ();
402 403
404 if (op == pl)
405 ns->last_weight = weight;
406
407 sl << uint32 (weight);
408 }
409
403 if (flags & UPD_FACE) { 410 if (flags & UPD_FACE)
404 if (!(pl->contr->socket.faces_sent[op->face->number] & NS_FACESENT_FACE))
405 esrv_send_face(&pl->contr->socket, op->face->number,0);
406 SockList_AddInt(&sl, op->face->number);
407 } 411 {
412 ns->send_face (op->face, -50);
413 ns->flush_fx ();
414 sl << uint32 (op->face);
415 }
416
408 if (flags & UPD_NAME) { 417 if (flags & UPD_NAME)
409 int len; 418 {
419 int len;
410 const char *item_p; 420 const char *item_p;
411 char item_n[MAX_BUF]; 421 char item_n[127 * 2];
412 422
413 if (!op->custom_name) { 423 if (!op->custom_name)
414 strncpy(item_n,query_base_name(op, 0),127); 424 {
415 item_n[127]=0; 425 len = assign (item_n, query_base_name (op, 0), 127);
416 len=strlen(item_n);
417 item_p=query_base_name(op, 1); 426 item_p = query_base_name (op, 1);
418 } 427 }
419 else { 428 else
420 strncpy(item_n,op->custom_name,127); 429 {
421 item_n[127]=0; 430 len = assign (item_n, &op->custom_name, 127);
422 len=strlen(item_n);
423 item_p=op->custom_name; 431 item_p = &op->custom_name;
424 } 432 }
425 433
426 strncpy(item_n+len+1, item_p, 127); 434 len += assign (item_n + len, item_p, 127);
427 item_n[254]=0; 435
428 len += strlen(item_n+1+len) + 1; 436 sl << data8 (item_n, len);
429 SockList_AddChar(&sl, (char)len);
430 memcpy(sl.buf+sl.len, item_n, len);
431 sl.len += len;
432 } 437 }
438
433 if (flags & UPD_ANIM) 439 if (flags & UPD_ANIM)
434 SockList_AddShort(&sl,op->animation_id); 440 sl << uint16 (op->animation_id);
435 441
436 if (flags & UPD_ANIMSPEED) { 442 if (flags & UPD_ANIMSPEED)
443 {
437 int anim_speed=0; 444 int anim_speed = 0;
445
438 if (QUERY_FLAG(op,FLAG_ANIMATE)) { 446 if (QUERY_FLAG (op, FLAG_ANIMATE))
439 if (op->anim_speed) anim_speed=op->anim_speed; 447 {
440 else { 448 if (op->anim_speed)
441 if (FABS(op->speed)<0.001) anim_speed=255; 449 anim_speed = op->anim_speed;
442 else if (FABS(op->speed)>=1.0) anim_speed=1; 450 else
443 else anim_speed = (int) (1.0/FABS(op->speed)); 451 {
452 if (op->speed < 0.001)
453 anim_speed = 255;
454 else if (op->speed >= 1.0)
455 anim_speed = 1;
456 else
457 anim_speed = 1. / op->speed;
458 }
459
460 if (anim_speed > 255)
461 anim_speed = 255;
462 }
463
464 sl << uint8 (anim_speed);
444 } 465 }
445 if (anim_speed>255) anim_speed=255; 466
446 }
447 SockList_AddChar(&sl, (char)anim_speed);
448 }
449 if (flags & UPD_NROF) 467 if (flags & UPD_NROF)
450 SockList_AddInt(&sl, op->nrof); 468 sl << uint32 (op->nrof);
451 469
452 Send_With_Handling(&pl->contr->socket, &sl); 470 pl->contr->ns->send_packet (sl);
453 free(sl.buf);
454} 471}
455 472
456/** 473/**
457 * Sends item's info to player. 474 * Sends item's info to player.
458 */ 475 */
476void
459void esrv_send_item(object *pl, object*op) 477esrv_send_item (object *pl, object *op)
460{ 478{
461 SockList sl; 479 if (!pl->contr->ns)
462
463 /* If this is not the player object, do some more checks */
464 if (op!=pl) {
465 /* We only send 'visibile' objects to the client */
466 if (! LOOK_OBJ(op))
467 return; 480 return;
468 /* if the item is on the ground, mark that the look needs to 481
469 * be updated. 482 /* We only send 'visible' objects to the client, and sometimes the player */
470 */ 483 if (!op->client_visible () && op->type != PLAYER)
471 if (!op->env) {
472 pl->contr->socket.update_look=1;
473 return; 484 return;
474 }
475 }
476 485
477 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 486 packet sl;
478 487
479 sprintf((char*)sl.buf,"item%d ", pl->contr->socket.itemcmd); 488 sl.printf ("item%d ", pl->contr->ns->itemcmd);
480 sl.len=strlen((char*)sl.buf);
481 489
482 if (op->head) op=op->head; 490 op = op->head_ ();
483 491
484 SockList_AddInt(&sl, op->env? op->env->count:0); 492 sl << uint32 (op->env ? op->env->count : 0);
485 493
486 add_object_to_socklist(&pl->contr->socket, &sl, op); 494 add_object_to_socklist (*pl->contr->ns, sl, op);
487 495
488 Send_With_Handling(&pl->contr->socket, &sl); 496 pl->contr->ns->send_packet (sl);
489 SET_FLAG(op, FLAG_CLIENT_SENT);
490 free(sl.buf);
491} 497}
492 498
493/** 499/**
494 * Tells the client to delete an item. Uses the item 500 * Tells the client to delete an item.
495 * command with a -1 location.
496 */ 501 */
497 502void
498void esrv_del_item(player *pl, int tag) 503esrv_del_item (player *pl, int tag)
499{ 504{
500 SockList sl; 505 if (!pl->ns)
506 return;
501 507
502 sl.buf= (unsigned char *) malloc(MAXSOCKBUF); 508 packet sl ("delitem");
503 509
504 strcpy((char*)sl.buf,"delitem "); 510 sl << uint32 (tag);
505 sl.len=strlen((char*)sl.buf);
506 SockList_AddInt(&sl, tag);
507 511
508 Send_With_Handling(&pl->socket, &sl); 512 pl->ns->send_packet (sl);
509 free(sl.buf);
510} 513}
511 514
512 515
513/******************************************************************************* 516/*******************************************************************************
514 * 517 *
… …
518 521
519/** 522/**
520 * Takes a player and object count (tag) and returns the actual object 523 * Takes a player and object count (tag) and returns the actual object
521 * pointer, or null if it can't be found. 524 * pointer, or null if it can't be found.
522 */ 525 */
523 526static object *
524object *esrv_get_ob_from_count(object *pl, tag_t count) 527esrv_get_ob_from_count (object *pl, tag_t count)
525{ 528{
526 object *op, *tmp; 529 if (pl->count == count)
530 return pl;
527 531
532 for (object *op = pl->inv; op; op = op->below)
528 if (pl->count == count) 533 if (op->count == count)
529 return pl;
530
531 for(op = pl->inv; op; op = op->below)
532 if (op->count == count)
533 return op; 534 return op;
534 else if (op->type == CONTAINER && pl->container == op) 535 else if (op->type == CONTAINER && pl->container_ () == op)
535 for(tmp = op->inv; tmp; tmp = tmp->below) 536 for (object *tmp = op->inv; tmp; tmp = tmp->below)
536 if (tmp->count == count) 537 if (tmp->count == count)
537 return tmp; 538 return tmp;
538 539
539 for(op = get_map_ob (pl->map, pl->x, pl->y); op; op = op->above) 540 for (object *op = GET_MAP_OB (pl->map, pl->x, pl->y); op; op = op->above)
540 if (op->head != NULL && op->head->count == count) 541 if (op->head && op->head->count == count)
541 return op; 542 return op;
542 else if (op->count == count) 543 else if (op->count == count)
543 return op; 544 return op;
544 else if (op->type == CONTAINER && pl->container == op) 545 else if (op->type == CONTAINER && pl->container_ () == op)
545 for(tmp = op->inv; tmp; tmp = tmp->below) 546 for (object *tmp = op->inv; tmp; tmp = tmp->below)
546 if (tmp->count == count) 547 if (tmp->count == count)
547 return tmp; 548 return tmp;
548 549
550#if 0
551 /* If the high bit is set, player examined a pseudo object. */
552 if (count & 0x80000000)
549 return NULL; 553 return 0;
550} 554#endif
551 555
556 return 0;
557}
552 558
553/** Client wants to examine some object. So lets do so. */ 559/** Client wants to examine some object. So lets do so. */
560void
554void ExamineCmd(char *buf, int len,player *pl) 561ExamineCmd (char *buf, int len, player *pl)
555{ 562{
556 long tag = atoi(buf); 563 tag_t tag = atoi (buf);
564
565 /* If the high bit is set, player applied a pseudo object. */
566 if (tag & 0x80000000)
567 {
568 pl->ns->look_position = tag & 0x7fffffff;
569 pl->ns->floorbox_update ();
570 return;
571 }
572
557 object *op = esrv_get_ob_from_count(pl->ob, tag); 573 object *op = esrv_get_ob_from_count (pl->ob, tag);
558 574
559 if (!op) { 575 if (!op)
576 {
560 LOG(llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", 577 LOG (llevDebug, "Player '%s' tried to examine the unknown object (%ld)\n", &pl->ob->name, tag);
561 pl->ob->name, tag); 578 return;
562 return;
563 } 579 }
580
564 examine (pl->ob, op); 581 examine (pl->ob, op);
565} 582}
566 583
584/** Client wants to examine some object. So lets do so. */
585void
586ExCmd (char *buf, int len, player *pl)
587{
588 tag_t tag = atoi (buf);
589
590 if (object *op = esrv_get_ob_from_count (pl->ob, tag))
591 {
592 std::string s = op->describe (pl->ob);
593
594 packet sl ("ex");
595 sl << ber32 (tag)
596 << data (*pl->expand_cfpod (s.c_str ()));
597
598 pl->ns->send_packet (sl);
599 }
600}
601
567/** Client wants to apply some object. Lets do so. */ 602/** Client wants to apply some object. Lets do so. */
603void
568void ApplyCmd(char *buf, int len,player *pl) 604ApplyCmd (char *buf, int len, player *pl)
569{ 605{
570 uint32 tag = atoi(buf); 606 tag_t tag = atoi (buf);
571 object *op = esrv_get_ob_from_count(pl->ob, tag);
572 607
573 /* sort of a hack, but if the player saves and the player then manually
574 * applies a savebed (or otherwise tries to do stuff), we run into trouble.
575 */
576 if (QUERY_FLAG(pl->ob, FLAG_REMOVED)) return;
577
578 /* If the high bit is set, player applied a pseudo object. */ 608 /* If the high bit is set, player applied a pseudo object. */
579 if (tag & 0x80000000) { 609 if (tag & 0x80000000)
610 {
580 pl->socket.look_position = tag & 0x7fffffff; 611 pl->ns->look_position = tag & 0x7fffffff;
581 pl->socket.update_look = 1; 612 pl->ns->floorbox_update ();
582 return; 613 return;
583 } 614 }
584 615
616 object *op = esrv_get_ob_from_count (pl->ob, tag);
617
585 if (!op) { 618 if (!op)
619 {
586 LOG(llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", 620 LOG (llevDebug, "Player '%s' tried to apply the unknown object (%d)\n", &pl->ob->name, tag);
587 pl->ob->name, tag); 621 return;
588 return;
589 } 622 }
590 player_apply (pl->ob, op, 0, 0);
591}
592 623
624 pl->ob->apply (op);
625}
626
593/** Client wants to apply some object. Lets do so. */ 627/** Client wants to lock some object. Lets do so. */
628void
594void LockItem(uint8 *data, int len,player *pl) 629LockItem (char *data, int len, player *pl)
595{ 630{
596 int flag, tag;
597 object *op;
598
599 flag = data[0]; 631 int flag = data[0];
600 tag = GetInt_String(data+1); 632 tag_t tag = net_uint32 ((uint8 *)data + 1);
601 op = esrv_get_ob_from_count(pl->ob, tag); 633 object *op = esrv_get_ob_from_count (pl->ob, tag);
602 634
603 if (!op) { 635 if (!op)
604 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to lock/unlock");
605 return;
606 } 636 {
637 pl->failmsg ("Could not find object to lock/unlock");
638 return;
639 }
640
607 if (!flag) 641 if (!flag)
608 CLEAR_FLAG(op,FLAG_INV_LOCKED); 642 CLEAR_FLAG (op, FLAG_INV_LOCKED);
609 else 643 else
610 SET_FLAG(op,FLAG_INV_LOCKED); 644 SET_FLAG (op, FLAG_INV_LOCKED);
645
611 esrv_update_item(UPD_FLAGS, pl->ob, op); 646 esrv_update_item (UPD_FLAGS, pl->ob, op);
612} 647}
613 648
614/** Client wants to apply some object. Lets do so. */ 649/** Client wants to mark some object. Lets do so. */
650void
615void MarkItem(uint8 *data, int len,player *pl) 651MarkItem (char *data, int len, player *pl)
616{ 652{
617 int tag; 653 tag_t tag = net_uint32 ((uint8 *)data);
618 object *op;
619
620 tag = GetInt_String(data);
621 op = esrv_get_ob_from_count(pl->ob, tag); 654 object *op = esrv_get_ob_from_count (pl->ob, tag);
655
622 if (!op) { 656 if (!op)
623 new_draw_info(NDI_UNIQUE, 0, pl->ob,"Could not find object to mark");
624 return;
625 } 657 {
658 pl->failmsg ("Could not find object to mark");
659 return;
660 }
661
626 pl->mark = op; 662 pl->mark = op;
627 pl->mark_count = op->count; 663 pl->ob->statusmsg (format ("Marked item %s", query_name (op)));
628 new_draw_info_format(NDI_UNIQUE, 0, pl->ob, "Marked item %s", query_name(op));
629} 664}
630
631 665
632/** 666/**
633 * look_at prints items on the specified square. 667 * look_at prints items on the specified square.
634 * 668 *
635 * [ removed EARTHWALL check and added check for containers inventory. 669 * [ removed EARTHWALL check and added check for containers inventory.
636 * Tero.Haatanen@lut.fi ] 670 * Tero.Haatanen@lut.fi ]
637 */ 671 */
638void look_at(object *op,int dx,int dy) { 672static void
639 object *tmp; 673look_at (player *pl, int dx, int dy)
640 int flag=0; 674{
641 sint16 x,y; 675 dynbuf_text &buf = msg_dynbuf; buf.clear ();
642 mapstruct *m; 676 object *ob = pl->ob;
643 677
644 x = op->x + dx; 678 if (!pl->observe->map)
645 y = op->y + dy; 679 return;
646 680
647 if (out_of_map(op->map, x, y)) return; 681 bool wiz = ob->flag [FLAG_WIZ] || ob->flag [FLAG_WIZLOOK];
648 682
649 m = get_map_from_coord(op->map, &x, &y); 683 mapxy pos (pl->observe);
650 if (!m) return; 684 pos.move (dx, dy);
651 685
652 for(tmp=get_map_ob(m, x ,y);tmp!=NULL&&tmp->above!=NULL; 686 if (wiz)
653 tmp=tmp->above); 687 {
688 if (pos.normalise ())
689 {
690 mapspace &ms = *pos;
691 ms.update ();
654 692
655 for ( ; tmp != NULL; tmp=tmp->below ) { 693 buf.printf (" map: %s%+d%+d (%+d%+d)\n"
656 if (tmp->invisible && !QUERY_FLAG(op, FLAG_WIZ)) continue; 694 " smell %u/%u; flags %x; light %d; block %x; slow %x; on %x; off %x; items %d, volume %lld\n\n",
657 695 &pos.m->path, pos.x, pos.y, dx, dy,
658 if(!flag) { 696 (unsigned int)ms.smell, (unsigned int)mapspace::smellcount, ms.flags (), ms.light,
659 if(dx||dy) 697 ms.move_block, ms.move_slow, ms.move_on, ms.move_off, (int)ms.items (), (long long)ms.volume ()
660 new_draw_info(NDI_UNIQUE, 0,op,"There you see:"); 698 );
699 }
661 else { 700 else
662 clear_win_info(op); 701 buf << "off-map\n\n";
663 new_draw_info(NDI_UNIQUE, 0,op,"You see:");
664 } 702 }
665 flag=1;
666 }
667 703
668 if (QUERY_FLAG(op, FLAG_WIZ)) 704 int darkness = pl->blocked_los (dx, dy);
669 new_draw_info_format(NDI_UNIQUE,0, op, "- %s (%d).",query_name(tmp),tmp->count); 705
706 if (darkness == LOS_BLOCKED)
707 buf << "You cannot see that place from your position. H<Something is in between or it is too far away.>";
708 else if (darkness == LOS_MAX)
709 buf << "That place is too dark to see anything. H<Move nearer or find better lighting.>";
670 else 710 else
671 new_draw_info_format(NDI_UNIQUE,0, op, "- %s.",query_name(tmp));
672
673 if (((tmp->inv!=NULL || (tmp->head && tmp->head->inv)) &&
674 (tmp->type != CONTAINER && tmp->type!=FLESH)) || QUERY_FLAG(op, FLAG_WIZ))
675 inventory(op,tmp->head==NULL?tmp:tmp->head);
676
677 if(QUERY_FLAG(tmp, FLAG_IS_FLOOR)&&!QUERY_FLAG(op, FLAG_WIZ)) /* don't continue under the floor */
678 break;
679 } 711 {
712 if (pos.normalise ())
713 for (object *tmp = pos->top; tmp; tmp = tmp->below)
714 {
715 if (tmp->invisible && !QUERY_FLAG (ob, FLAG_WIZ))
716 continue;
680 717
681 if(!flag) { 718 if (wiz)
682 if(dx||dy) 719 buf.printf (" - %s (%d) %s\n", query_name (tmp), tmp->count, tmp->uuid.c_str ());
683 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing there."); 720 else
684 else 721 buf.printf (" - %s.\n", query_name (tmp));
685 new_draw_info(NDI_UNIQUE, 0,op,"You see nothing.");
686 }
687}
688 722
723 object *head = tmp->head_ ();
689 724
725 if (head->inv)
726 if ((head->type != CONTAINER && head->type != FLESH)
727 || QUERY_FLAG (ob, FLAG_WIZ))
728 buf << head->query_inventory (ob, " ");
729
730 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) && !wiz) /* don't continue under the floor */
731 break;
732 }
733 }
734
735 if (buf.empty ())
736 buf << "You see nothing there.";
737
738 pl->infobox (MSG_CHANNEL ("lookat"), buf);
739}
690 740
691/** Client wants to look at some object. Lets do so. */ 741/** Client wants to look at some object. Lets do so. */
742void
692void LookAt(char *buf, int len,player *pl) 743LookAt (char *buf, int len, player *pl)
693{ 744{
694 int dx, dy;
695 char *cp; 745 char *cp;
696 746
697 dx=atoi(buf); 747 int dx = atoi (buf);
698 if (!(cp=strchr(buf,' '))) { 748 if (!(cp = strchr (buf, ' ')))
699 return; 749 return;
700 } 750
701 dy=atoi(cp); 751 int dy = atoi (cp);
702 752
703 if (FABS(dx) > pl->socket.mapx / 2 || FABS(dy) > pl->socket.mapy / 2)
704 return;
705
706 if(pl->blocked_los[dx + pl->socket.mapx / 2][dy + pl->socket.mapy / 2])
707 return;
708
709 look_at(pl->ob, dx, dy); 753 look_at (pl, dx, dy);
710} 754}
711 755
712/** Move an object to a new location */ 756/** Move an object to a new location */
757void
713void esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof) 758esrv_move_object (object *pl, tag_t to, tag_t tag, long nrof)
714{ 759{
715 object *op, *env;
716
717 op = esrv_get_ob_from_count(pl, tag); 760 object *op = esrv_get_ob_from_count (pl, tag);
718 if (!op) { 761 if (!op)
762 {
719 LOG(llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", 763 LOG (llevDebug, "Player '%s' tried to move an unknown object (%ld)\n", &pl->name, tag);
720 pl->name, tag);
721 return;
722 }
723
724 if (!to) { /* drop it to the ground */
725/* LOG(llevDebug, "Drop it on the ground.\n");*/
726
727 if (op->map && !op->env) {
728/* LOG(llevDebug,"Dropping object to ground that is already on ground\n");*/
729 return; 764 return;
730 }
731 /* If it is an active container, then we should drop all objects
732 * in the container and not the container itself.
733 */
734 if (op->inv && QUERY_FLAG(op, FLAG_APPLIED)) {
735 object *current, *next;
736 for (current=op->inv; current!=NULL; current=next) {
737 next=current->below;
738 drop_object(pl, current, 0);
739 } 765 }
740 esrv_update_item(UPD_WEIGHT, pl, op);
741 }
742 else {
743 drop_object (pl, op, nrof);
744 }
745 return;
746 } else if (to == pl->count) { /* pick it up to the inventory */
747 /* return if player has already picked it up */
748 if (op->env == pl) return;
749 766
750 pl->contr->count = nrof; 767 if (!to)
751 pick_up(pl, op); 768 { /* drop it to the ground */
752 return ; 769 if (op->map && !op->env)
753 }
754 env = esrv_get_ob_from_count(pl, to);
755 if (!env) {
756 LOG(llevDebug,
757 "Player '%s' tried to move object to the unknown location (%d)\n",
758 pl->name, to);
759 return; 770 return;
771
772 /* If it is an active container, then we should drop all objects
773 * in the container and not the container itself.
774 */
775 if (op->inv && QUERY_FLAG (op, FLAG_APPLIED))
776 {
777 int cnt = MAX_ITEM_PER_ACTION;
778
779 for (object *current = op->inv; current && cnt--; )
780 {
781 object *next = current->below;
782 drop_object (pl, current, 0);
783 current = next;
784 }
785
786 if (cnt <= 0)
787 op->failmsg ("Only dropped some items, can't drop that many items at once.");
788 }
789 else
790 drop_object (pl, op, nrof);
791
792 return;
793 }
794 else if (to == pl->count)
795 { /* pick it up to the inventory */
796 /* return if player has already picked it up */
797 if (op->env == pl)
798 return;
799
800 pl->contr->count = nrof;
801 pick_up (pl, op);
802 return;
803 }
804
805 object *env = esrv_get_ob_from_count (pl, to);
806 if (!env)
760 } 807 {
808 LOG (llevDebug, "Player '%s' tried to move object to the unknown location (%d)\n", &pl->name, to);
809 return;
810 }
811
761 /* put_object_in_sack presumes that necessary sanity checking 812 /* put_object_in_sack presumes that necessary sanity checking
762 * has already been done (eg, it can be picked up and fits in 813 * has already been done (eg, it can be picked up and fits in
763 * in a sack, so check for those things. We should also check 814 * in a sack, so check for those things. We should also check
764 * an make sure env is in fact a container for that matter. 815 * an make sure env is in fact a container for that matter.
765 */ 816 */
766 if (env->type == CONTAINER 817 if (env->type == CONTAINER
818 && can_pick (pl, op)
767 && can_pick(pl, op) && sack_can_hold(pl, env, op, nrof)) { 819 && sack_can_hold (pl, env, op, nrof))
768 put_object_in_sack (pl, env, op, nrof); 820 put_object_in_sack (pl, env, op, nrof);
769 }
770} 821}
771 822
772

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines