ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/lowlevel.C
(Generate patch)

Comparing deliantra/server/socket/lowlevel.C (file contents):
Revision 1.22 by root, Fri Dec 15 19:59:20 2006 UTC vs.
Revision 1.68 by root, Sat Dec 27 01:25:00 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 1992 Frank Tore Johansen 5 * Copyright (©) 1992,2007 Frank Tore Johansen
5 6 *
6 This program is free software; you can redistribute it and/or modify 7 * Deliantra is free software: you can redistribute it and/or modify
7 it under the terms of the GNU General Public License as published by 8 * it under the terms of the GNU General Public License as published by
8 the Free Software Foundation; either version 2 of the License, or 9 * the Free Software Foundation, either version 3 of the License, or
9 (at your option) any later version. 10 * (at your option) any later version.
10 11 *
11 This program is distributed in the hope that it will be useful, 12 * This program is distributed in the hope that it will be useful,
12 but WITHOUT ANY WARRANTY; without even the implied warranty of 13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 GNU General Public License for more details. 15 * GNU General Public License for more details.
15 16 *
16 You should have received a copy of the GNU General Public License 17 * You should have received a copy of the GNU General Public License
17 along with this program; if not, write to the Free Software 18 * along with this program. If not, see <http://www.gnu.org/licenses/>.
18 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
19
20 The author can be reached via e-mail to mark@pyramid.com
21*/
22
23/**
24 * \file
25 * Low-level socket-related functions.
26 * 19 *
27 * \date 2003-12-02 20 * The authors can be reached via e-mail to <support@deliantra.net>
28 *
29 * Contains some base functions that both the client and server
30 * can use. As such, depending what we are being compiled for will
31 * determine what we can include. the client is designed have
32 * CFCLIENT defined as part of its compile flags.
33 */ 21 */
34 22
35using namespace std; 23using namespace std;
36 24
37#include <global.h> 25#include <global.h>
38#include <sproto.h> 26#include <sproto.h>
39#include <cstdarg> 27#include <cstdarg>
40 28
41#ifdef __linux__ 29#if HAVE_TCP_INFO
42# include <sys/types.h> 30# include <sys/types.h>
43# include <sys/socket.h> 31# include <sys/socket.h>
44# include <netinet/in.h> 32# include <netinet/in.h>
45# define TCP_HZ 1000 // sorry...
46# include <netinet/tcp.h> 33# include <netinet/tcp.h>
47#endif 34#endif
48 35
49// use a really low timeout, as it doesn't cost any bandwidth, and you can 36// force a packet when idle for more than this many seconds,
50// easily die in 20 seconds... 37// forcing an ack regularly.
51#define SOCKET_TIMEOUT1 10 38#define IDLE_PING 2.
52#define SOCKET_TIMEOUT2 20
53 39
54void 40void
55client::flush () 41client::flush ()
56{ 42{
57#ifdef __linux__ 43 if (destroyed ())
58 // check time of last ack, and, if too old, kill connection 44 return;
59 struct tcp_info tcpi;
60 socklen_t len = sizeof (tcpi);
61
62 if (!getsockopt (fd, IPPROTO_TCP, TCP_INFO, &tcpi, &len) && len == sizeof (tcpi))
63 {
64 unsigned int diff = tcpi.tcpi_last_ack_recv - tcpi.tcpi_last_data_sent;
65
66 rtt = tcpi.tcpi_rtt;
67 rttvar = tcpi.tcpi_rttvar;
68
69 if (tcpi.tcpi_unacked && SOCKET_TIMEOUT1 * TCP_HZ < diff && diff < 0x80000000UL // ack delayed for 20s
70 && SOCKET_TIMEOUT2 * TCP_HZ < tcpi.tcpi_last_data_sent) // no data sent for 10s
71 {
72 LOG (llevDebug, "Connection on fd %d closed due to ack timeout (%u/%u/%u)\n", fd,
73 (unsigned) tcpi.tcpi_last_ack_recv, (unsigned) tcpi.tcpi_last_data_sent, (unsigned) tcpi.tcpi_unacked);
74 status = Ns_Dead;
75 }
76 }
77#endif
78 45
79 /** 46 /**
80 * Writes data to socket. 47 * Writes data to socket.
81 * 48 *
82 * When the socket is clear to write, and we have backlogged data, this 49 * When the socket is clear to write, and we have backlogged data, this
83 * is called to write it out. 50 * is called to write it out.
84 */ 51 */
85 52
86 if (!outputbuffer.len || socket_ev.poll () & PE_W) 53 // write a nop to the socket at least every IDLE_NOP seconds.
54 if (!outputbuffer.len)
55 {
56 if (last_send + IDLE_PING <= NOW && pl && pl->active)
57 {
58 // this is a bit ugly, but map1/map1a seem to be the only
59 // nop'able commands and they are quite small.
60 packet sl (mapmode == Map1Cmd ? "map1" : "map1a");
61 send_packet (sl);
62 }
63 else
64 return;
65 }
66
67 if (socket_ev.poll () & EV_WRITE)
87 return; 68 return;
88 69
70 last_send = NOW;
89 write_outputbuffer (); 71 write_outputbuffer ();
90} 72}
91 73
92void 74void
93client::write_outputbuffer () 75client::write_outputbuffer ()
103 /* wrap back to start of buffer */ 85 /* wrap back to start of buffer */
104 if (outputbuffer.start == SOCKETBUFSIZE) 86 if (outputbuffer.start == SOCKETBUFSIZE)
105 outputbuffer.start = 0; 87 outputbuffer.start = 0;
106 88
107 outputbuffer.len -= res; 89 outputbuffer.len -= res;
108#ifdef CS_LOGSTATS
109 cst_tot.obytes += res;
110 cst_lst.obytes += res;
111#endif
112 } 90 }
113 else if (res == 0) 91 else if (res == 0)
114 { 92 {
115 LOG (llevError, "socket write failed, connection closed.\n"); 93 LOG (llevError, "socket write failed, connection closed.\n");
116 status = Ns_Dead; 94 destroy ();
117 return; 95 return;
118 } 96 }
119 else if (errno == EINTR) 97 else if (errno == EINTR)
120 { 98 {
121 // just retry 99 // just retry
122 } 100 }
123 else if (errno == EAGAIN) 101 else if (errno == EAGAIN)
124 { 102 {
125 // delay till ready 103 // delay till ready
126 socket_ev.poll (socket_ev.poll () | PE_W); 104 socket_ev.poll (socket_ev.poll () | EV_WRITE);
127 socket_ev.start (); 105 socket_ev.start ();
128 return; 106 return;
129 } 107 }
130 else 108 else
131 { 109 {
132 LOG (llevError, "socket write failed: %s\n", strerror (errno)); 110 LOG (llevError, "socket write failed: %s\n", strerror (errno));
133 status = Ns_Dead; 111 destroy ();
134 return; 112 return;
135 } 113 }
136 } 114 }
137 115
138 socket_ev.poll (socket_ev.poll () & ~PE_W); 116 socket_ev.poll (socket_ev.poll () & ~EV_WRITE);
139} 117}
140 118
119/******************************************************************************
120 *
121 * Start of read routines.
122 *
123 ******************************************************************************/
124
125int
126client::next_packet ()
127{
128 if (inbuf_len >= 2)
129 {
130 int pkt_len = (inbuf [0] << 8) | inbuf [1];
131
132 if (inbuf_len >= 2 + pkt_len)
133 return 2 + pkt_len;
134
135 if (inbuf_len == sizeof (inbuf))
136 {
137 send_packet_printf ("drawinfo %d input buffer overflow - closing connection.", NDI_RED | NDI_REPLY);
138 destroy ();
139 return -1;
140 }
141 }
142
143 return 0;
144}
145
146void
147client::skip_packet (int len)
148{
149 inbuf_len -= len;
150 memmove (inbuf, inbuf + len, inbuf_len);
151}
152
141/*********************************************************************** 153/*****************************************************************************
142 * 154 * Start of command dispatch area.
143 * packet functions/utilities 155 * The commands here are protocol commands.
144 *
145 **********************************************************************/ 156 ****************************************************************************/
146 157
147packet &packet::operator <<(const data &v) 158// SocketCommand, PlayingCommand, should not exist with those ugly casts
159#define SC(cb) (void *)static_cast<void (*)(char *, int, client *)>(cb),
160#define PC(cb) (void *)static_cast<void (*)(char *, int, player *)>(cb), PF_PLAYER |
161
162/**
163 * Dispatch table for the server.
164 */
165static struct packet_type packets[] = {
166 {"ncom", PC(NewPlayerCmd) PF_PLAYING | PF_COMMAND6 },
167 {"command", PC(PlayerCmd) PF_PLAYING | PF_COMMAND0 },
168
169 {"examine", PC(ExamineCmd) PF_PLAYING },
170 {"ex", PC(ExCmd) PF_PLAYING },
171 {"apply", PC(ApplyCmd) PF_PLAYING },
172 {"lookat", PC(LookAt) PF_PLAYING },
173 {"lock", PC(LockItem) PF_PLAYING },
174 {"mark", PC(MarkItem) PF_PLAYING },
175 {"move", PC(MoveCmd) PF_PLAYING },
176 {"ext", PC(ExtCmd) 0 }, // CF+
177 {"mapredraw", PC(MapRedrawCmd) 0 },
178 {"mapinfo", PC(MapInfoCmd) 0 }, // CF+
179
180 {"reply", SC(ReplyCmd) 0 },
181 {"exti", SC(ExtiCmd) 0 }, // CF+
182 {"addme", SC(AddMeCmd) 0 },
183 {"askface", SC(AskFaceCmd) 0 },
184 {"requestinfo", SC(RequestInfo) 0 },
185 {"setsound", SC(SetSound) 0 },
186 {"setup", SC(SetUp) 0 },
187 {"version", SC(VersionCmd) 0 },
188 {"toggleextendedtext", SC(ToggleExtendedText) 0 }, /*Added: tchize */
189};
190
191bool
192client::may_execute (const packet_type *pkt) const
148{ 193{
149 if (room () < v.len) 194 return (!(pkt->flags & PF_PLAYER) || pl)
150 reset (); 195 && (!(pkt->flags & PF_PLAYING) || state == ST_PLAYING);
196}
197
198// HACK: some commands currently should be executed
199// even when the player is frozen. this hack detects
200// those commands. it should be folded into may_execute,
201// but kept seperate to emphasise the hack aspect, i.e.
202// do it better, then remove.
203static bool
204always_immediate (const client *ns, const packet_type *pkt, const char *data, int len)
205{
206 if (!(pkt->flags & (PF_COMMAND0 | PF_COMMAND6)))
207 return false;
208
209 if (!ns->pl || !ns->pl->ob || !ns->pl->ob->map)
210 return false;
211
212 if (pkt->flags & PF_COMMAND6)
213 {
214 data += 6;
215 len -= 6;
216 }
217
218 if (len > 4 && data [3] == ' ' && !strncmp (data, "say " , 4)) return true;
219 if (len > 5 && data [4] == ' ' && !strncmp (data, "chat " , 5)) return true;
220 if (len > 6 && data [5] == ' ' && !strncmp (data, "shout ", 6)) return true;
221
222 if (len == 7 && !strcmp (data, "suicide")) return true;
223
224 return false;
225}
226
227void
228client::execute (const packet_type *pkt, char *data, int datalen)
229{
230 if (may_execute (pkt) || always_immediate (this, pkt, data, datalen))
231 {
232 //TODO: only one format
233 if (pkt->flags & PF_PLAYER)
234 ((void (*)(char *, int, player *))pkt->cb)((char *)data, datalen, pl);
235 else
236 ((void (*)(char *, int, client *))pkt->cb)((char *)data, datalen, this);
237 }
151 else 238 else
239 send_packet_printf ("drawinfo %d ERROR: you cannot execute '%s' now.", NDI_RED | NDI_REPLY, pkt->name);
240}
241
242bool
243client::handle_packet ()
244{
245 int pkt_len = next_packet ();
246
247 if (!pkt_len)
248 return false;
249 else if (pkt_len < 0)
250 {
251 LOG (llevError, "read error on player %s\n",
252 pl && pl->ob ? &pl->ob->name : "[anonymous]");
253 destroy ();
254 return false;
152 { 255 }
153 if (v.len) 256
257 inbuf [pkt_len] = 0; /* Terminate buffer - useful for string data */
258
259 /* First, break out beginning word. There are at least
260 * a few commands that do not have any paremeters. If
261 * we get such a command, don't worry about trying
262 * to break it up.
263 */
264 int datalen;
265 char *data = strchr ((char *)inbuf + 2, ' ');
266
267 if (data)
268 {
269 *data++ = 0;
270 datalen = pkt_len - (data - (char *)inbuf);
271 }
272 else
273 {
274 data = (char *)inbuf + 2; // better read garbage than segfault
275 datalen = 0;
276 }
277
278 for (packet_type *pkt = packets; pkt < packets + (sizeof (packets) / sizeof (packets[0])); ++pkt)
279 if (!strcmp ((char *)inbuf + 2, pkt->name))
154 { 280 {
155 memcpy (cur, v.ptr, v.len); 281 if (pkt->flags & PF_PLAYER && !always_immediate (this, pkt, data, datalen))
156 cur += v.len; 282 queue_command (pkt, data, datalen);
283 else
284 execute (pkt, data, datalen);
285
286 goto next_packet;
157 } 287 }
288
289 // If we get here, we didn't find a valid command.
290 send_packet_printf ("drawinfo %d ERROR: command '%s' not supported.", NDI_RED | NDI_REPLY, (char *)inbuf + 2);
291next_packet:
292 skip_packet (pkt_len);
293
294 // input buffer has space again
295 socket_ev.poll (socket_ev.poll () | EV_READ);
296
297 return true;
298}
299
300// callback called when socket is either readable or writable
301void
302client::socket_cb (iow &w, int revents)
303{
304 //TODO remove when we have better socket cleanup logic
305 if (destroyed ())
158 } 306 {
159 307 socket_ev.poll (0);
160 return *this; 308 return;
161}
162
163packet &packet::operator <<(const data8 &v)
164{
165 unsigned int len = min (v.len, 0x00FF);
166 return *this << uint8 (len) << data (v.ptr, len);
167}
168
169packet &packet::operator <<(const data16 &v)
170{
171 unsigned int len = min (v.len, 0xFFFF);
172 return *this << uint16 (len) << data (v.ptr, len);
173}
174
175packet &packet::operator <<(const char *v)
176{
177 return *this << data (v, strlen (v ? v : 0));
178}
179
180void
181packet::printf (const char *format, ...)
182{
183 int size = room ();
184
185 va_list ap;
186 va_start (ap, format);
187 int len = vsnprintf ((char *)cur, size, format, ap);
188 va_end (ap);
189
190 if (len >= size)
191 return reset ();
192
193 cur += len;
194}
195
196/******************************************************************************
197 *
198 * Start of read routines.
199 *
200 ******************************************************************************/
201
202int
203client::read_packet ()
204{
205 for (;;)
206 { 309 }
207 if (inbuf_len >= 2)
208 {
209 unsigned int pkt_len = (inbuf [0] << 8) | inbuf [1];
210 310
211 if (inbuf_len >= 2 + pkt_len) 311 if (revents & EV_WRITE)
212 return pkt_len + 2; 312 {
213 } 313 write_outputbuffer ();
314
315 if (!outputbuffer.len)
316 socket_ev.poll (socket_ev.poll () & ~EV_WRITE);
317 }
318
319 if (revents & EV_READ)
320 {
321 //TODO: rate-limit tcp connection in better ways, important
214 322
215 int amount = sizeof (inbuf) - inbuf_len; 323 int amount = sizeof (inbuf) - inbuf_len;
216 324
217 if (amount <= 0) 325 if (!amount)
218 { 326 {
219 LOG (llevError, "packet too large");//TODO 327 // input buffer full
328 socket_ev.poll (socket_ev.poll () & ~EV_READ);
220 return -1; 329 return;
221 } 330 }
222 331
223 amount = read (fd, inbuf + inbuf_len, amount); 332 amount = read (fd, inbuf + inbuf_len, amount);
224 333
225 if (!amount) 334 if (!amount)
226 { 335 {
227 status = Ns_Dead; 336 destroy ();
228 return -1; 337 return;
229 } 338 }
230 else if (amount < 0) 339 else if (amount < 0)
231 { 340 {
232 if (errno != EAGAIN && errno != EINTR) 341 if (errno != EAGAIN && errno != EINTR)
233 { 342 {
234 LOG (llevError, "read error: %s\n", strerror (errno)); 343 LOG (llevError, "read error: %s\n", strerror (errno));
344 destroy ();
235 return -1; 345 return;
236 } 346 }
237 347
238 return 0; 348 // should not be here, normally
349 }
350 else
239 } 351 {
240
241 inbuf_len += amount; 352 inbuf_len += amount;
242 353
243 cst_tot.ibytes += amount; 354 if (handle_packet ())
244 cst_lst.ibytes += amount; 355 {
245 } 356 while (handle_packet ())
246} 357 ;
247 358
248void 359 flush ();
249client::skip_packet (int len) 360 }
250{ 361 }
251 inbuf_len -= len; 362 }
252 memmove (inbuf, inbuf + len, inbuf_len);
253} 363}
254 364
255/******************************************************************************* 365/*******************************************************************************
256 * 366 *
257 * Start of write related routines. 367 * Start of write related routines.
266 */ 376 */
267void 377void
268client::send (void *buf_, int len) 378client::send (void *buf_, int len)
269{ 379{
270 char *buf = (char *)buf_; 380 char *buf = (char *)buf_;
271 char *pos = buf;
272 int amt = 0;
273 381
274 if (status == Ns_Dead || !buf) 382 if (destroyed () || !buf)
275 {
276 LOG (llevDebug, "Write_To_Socket called with dead socket\n");
277 return; 383 return;
278 }
279 384
280 if ((len + outputbuffer.len) > SOCKETBUFSIZE) 385 if (len + outputbuffer.len > SOCKETBUFSIZE)
281 { 386 {
282 LOG (llevDebug, "Socket on fd %d has overrun internal buffer - marking as dead\n", fd); 387 LOG (llevDebug, "socket on fd %d has overrun internal buffer - marking as dead\n", fd);
283 status = Ns_Dead; 388 // shutdown the socket, this is safer than destroying it immediately
389 // as lots of code in the callchain might still access the map etc.
390 shutdown (fd, SHUT_RDWR);
284 return; 391 return;
285 } 392 }
286 393
287 int avail, end; 394 int avail, end;
288 395
306 } 413 }
307 414
308 outputbuffer.len += len; 415 outputbuffer.len += len;
309} 416}
310 417
311void
312client::socket_cb (iow &w, int got)
313{
314 write_outputbuffer ();
315
316 if (!outputbuffer.len)
317 socket_ev.poll (socket_ev.poll () & ~PE_W);
318}
319
320/** 418/**
321 * Takes a string of data, and writes it out to the socket. A very handy 419 * Takes a string of data, and writes it out to the socket. A very handy
322 * shortcut function. 420 * shortcut function.
323 */ 421 */
324void 422void
325client::send_packet (packet &sl) 423client::send_packet (packet &sl)
326{ 424{
327 if (status == Ns_Dead) 425 if (destroyed ())
328 return; 426 return;
329 427
330 if (sl.length () >= MAXSOCKBUF) 428 if (sl.length () > MAXSOCKBUF)
331 { 429 {
332 LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", sl.length ()); 430 LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", sl.length ());
333 /* Almost certainly we've overflowed a buffer, so quit now to make 431 /* Almost certainly we've overflowed a buffer, so quit now to make
334 * it easier to debug. 432 * it easier to debug.
335 */ 433 */
360client::send_packet (const char *buf) 458client::send_packet (const char *buf)
361{ 459{
362 send_packet (buf, strlen (buf)); 460 send_packet (buf, strlen (buf));
363} 461}
364 462
463void
464client::send_packet_printf (const char *format, ...)
465{
466 packet sl;
467
468 va_list ap;
469 va_start (ap, format);
470 sl.vprintf (format, ap);
471 va_end (ap);
472
473 send_packet (sl);
474}
475
476void
477client::send_msg (int color, const char *type, const char *msg)
478{
479 if (!msg || !type) // it can happen (for example, missing attack messages cause this)
480 {
481 LOG (logBacktrace | llevError, "send_msg(%d,%p,%p) called with NULL msg or type.\n", color, type, msg);
482 return;
483 }
484
485 int len = strlen (msg);
486
487 if (!(color & NDI_VERBATIM)
488 && (msg_is_special (msg)
489 || (type [0] == 'c' && type [1] == '/') || len > (MAXSOCKBUF - 128)))
490 cfperl_send_msg (this, color, type, msg);
491 else if (can_msg)
492 send_packet_printf ("msg %d %s %s", color & NDI_CLIENT_MASK, type, msg);
493 else if (color < 0)
494 return; // client cannot handle this
495 else
496 send_packet_printf ("drawinfo %d %s", color & NDI_COLOR_MASK, msg);
497}
498
499void
500client::send_drawinfo (const char *msg, int flags)
501{
502 send_msg (flags, "log", msg);
503}
504
365/****************************************************************************** 505/***********************************************************************
366 * 506 *
367 * statistics logging functions. 507 * packet functions/utilities
368 * 508 *
369 ******************************************************************************/ 509 **********************************************************************/
370 510
371#ifdef CS_LOGSTATS 511packet::packet (const char *name)
372
373/* cst_tot is for the life of the server, cst_last is for the last series of
374 * stats
375 */
376CS_Stats cst_tot, cst_lst;
377
378/**
379 * Writes out the gathered stats. We clear cst_lst.
380 */
381void
382write_cs_stats (void)
383{ 512{
384 time_t now = time (NULL); 513 reset ();
385 514
386 /* If no connections recently, don't both to log anything */ 515 int len = strlen (name);
387 if (cst_lst.ibytes == 0 && cst_lst.obytes == 0) 516 memcpy (cur, name, len); cur += len;
388 return; 517 *cur++ = ' ';
389
390 /* CSSTAT is put in so scripts can easily find the line */
391 LOG (llevInfo, "CSSTAT: %.16s tot %d %d %d %d inc %d %d %d %d\n",
392 ctime (&now), cst_tot.ibytes, cst_tot.obytes, cst_tot.max_conn,
393 now - cst_tot.time_start, cst_lst.ibytes, cst_lst.obytes, cst_lst.max_conn, now - cst_lst.time_start);
394 cst_lst.ibytes = 0;
395 cst_lst.obytes = 0;
396 cst_lst.time_start = now;
397} 518}
398#endif
399 519
520packet &packet::operator <<(const ber32 v)
521{
522 enum { maxlen = 32 / 7 + 1};
523 uint8 buf[maxlen];
524 uint8 *p = buf + maxlen;
525 uint32 val = v.val;
526
527 *--p = val & 0x7F;
528
529 while (val > 0x7F)
530 {
531 val >>= 7;
532 *--p = (val & 0x7F) | 0x80;
533 }
534
535 return *this << data (p, buf + maxlen - p);
536}
537
538packet &packet::operator <<(const data &v)
539{
540 if (room () < v.len)
541 reset ();
542 else
543 {
544 if (v.len)
545 {
546 memcpy (cur, v.ptr, v.len);
547 cur += v.len;
548 }
549 }
550
551 return *this;
552}
553
554packet &packet::operator <<(const data8 &v)
555{
556 unsigned int len = min (v.len, 0x00FF);
557 return *this << uint8 (len) << data (v.ptr, len);
558}
559
560packet &packet::operator <<(const data16 &v)
561{
562 unsigned int len = min (v.len, 0xFFFF);
563 return *this << uint16 (len) << data (v.ptr, len);
564}
565
566packet &packet::operator <<(const char *v)
567{
568 return *this << data (v, strlen (v ? v : 0));
569}
570
571void
572packet::vprintf (const char *format, va_list ap)
573{
574 int size = room ();
575
576 int len = vsnprintf ((char *)cur, size, format, ap);
577
578 if (len >= size)
579 return reset ();
580
581 cur += len;
582}
583

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines