--- deliantra/server/socket/lowlevel.C 2006/12/14 00:01:37 1.12 +++ deliantra/server/socket/lowlevel.C 2006/12/15 00:14:13 1.21 @@ -53,76 +53,145 @@ #define SOCKET_TIMEOUT2 20 void -Socket_Flush (NewSocket * ns) +client_socket::flush () { #ifdef __linux__ // check time of last ack, and, if too old, kill connection struct tcp_info tcpi; socklen_t len = sizeof (tcpi); - if (!getsockopt (ns->fd, IPPROTO_TCP, TCP_INFO, &tcpi, &len) && len == sizeof (tcpi)) + if (!getsockopt (fd, IPPROTO_TCP, TCP_INFO, &tcpi, &len) && len == sizeof (tcpi)) { unsigned int diff = tcpi.tcpi_last_ack_recv - tcpi.tcpi_last_data_sent; + rtt = tcpi.tcpi_rtt; + rttvar = tcpi.tcpi_rttvar; + if (tcpi.tcpi_unacked && SOCKET_TIMEOUT1 * TCP_HZ < diff && diff < 0x80000000UL // ack delayed for 20s && SOCKET_TIMEOUT2 * TCP_HZ < tcpi.tcpi_last_data_sent) // no data sent for 10s { - LOG (llevDebug, "Connection on fd %d closed due to ack timeout (%u/%u/%u)\n", ns->fd, + LOG (llevDebug, "Connection on fd %d closed due to ack timeout (%u/%u/%u)\n", fd, (unsigned) tcpi.tcpi_last_ack_recv, (unsigned) tcpi.tcpi_last_data_sent, (unsigned) tcpi.tcpi_unacked); - ns->status = Ns_Dead; + status = Ns_Dead; } } +#endif + + /** + * Writes data to socket. + * + * When the socket is clear to write, and we have backlogged data, this + * is called to write it out. + */ + + if (!outputbuffer.len || socket_ev.poll () & PE_W) + return; + + write_outputbuffer (); +} + +void +client_socket::write_outputbuffer () +{ + while (outputbuffer.len) + { + int res = write (fd, outputbuffer.data + outputbuffer.start, + min (outputbuffer.len, SOCKETBUFSIZE - outputbuffer.start)); - int val; + if (res > 0) + { + outputbuffer.start += res; + /* wrap back to start of buffer */ + if (outputbuffer.start == SOCKETBUFSIZE) + outputbuffer.start = 0; - val = 0; setsockopt (ns->fd, IPPROTO_TCP, TCP_CORK, &val, sizeof (val)); - val = 1; setsockopt (ns->fd, IPPROTO_TCP, TCP_CORK, &val, sizeof (val)); + outputbuffer.len -= res; +#ifdef CS_LOGSTATS + cst_tot.obytes += res; + cst_lst.obytes += res; #endif + } + else if (res == 0) + { + LOG (llevError, "socket write failed, connection closed.\n"); + status = Ns_Dead; + return; + } + else if (errno == EINTR) + { + // just retry + } + else if (errno == EAGAIN) + { + // delay till ready + socket_ev.poll (socket_ev.poll () | PE_W); + socket_ev.start (); + return; + } + else + { + LOG (llevError, "socket write failed: %s\n", strerror (errno)); + status = Ns_Dead; + return; + } + } + + socket_ev.poll (socket_ev.poll () & ~PE_W); } /*********************************************************************** * - * SockList functions/utilities + * packet functions/utilities * **********************************************************************/ -SockList &SockList::operator <<(const data &v) +packet &packet::operator <<(const data &v) { - if (v.len) + if (room () < v.len) + reset (); + else { - memcpy (buf + len, v.ptr, v.len); - len += v.len; + if (v.len) + { + memcpy (cur, v.ptr, v.len); + cur += v.len; + } } return *this; } -SockList &SockList::operator <<(const data8 &v) +packet &packet::operator <<(const data8 &v) { unsigned int len = min (v.len, 0x00FF); return *this << uint8 (len) << data (v.ptr, len); } -SockList &SockList::operator <<(const data16 &v) +packet &packet::operator <<(const data16 &v) { unsigned int len = min (v.len, 0xFFFF); return *this << uint16 (len) << data (v.ptr, len); } -SockList &SockList::operator <<(const char *v) +packet &packet::operator <<(const char *v) { return *this << data (v, strlen (v ? v : 0)); } void -SockList::printf (const char *format, ...) +packet::printf (const char *format, ...) { + int size = room (); + va_list ap; va_start (ap, format); + int len = vsnprintf ((char *)cur, size, format, ap); + va_end (ap); - len += vsprintf ((char *)buf + len, format, ap); + if (len >= size) + return reset (); - va_end (ap); + cur += len; } /****************************************************************************** @@ -132,7 +201,7 @@ ******************************************************************************/ int -NewSocket::read_packet () +client_socket::read_packet () { for (;;) { @@ -163,7 +232,7 @@ { if (errno != EAGAIN && errno != EINTR) { - LOG (llevError, "read error: %s", strerror (errno)); + LOG (llevError, "read error: %s\n", strerror (errno)); return -1; } @@ -178,7 +247,7 @@ } void -NewSocket::skip_packet (int len) +client_socket::skip_packet (int len) { inbuf_len -= len; memmove (inbuf, inbuf + len, inbuf_len); @@ -196,24 +265,32 @@ * ns is the socket we are adding the data to, buf is the start of the * data, and len is the number of bytes to add. */ - -static void -add_to_buffer (NewSocket *ns, char *buf, int len) +void +client_socket::send (void *buf_, int len) { - int avail, end; + char *buf = (char *)buf_; + char *pos = buf; + int amt = 0; - if ((len + ns->outputbuffer.len) > SOCKETBUFSIZE) + if (status == Ns_Dead || !buf) { - LOG (llevDebug, "Socket on fd %d has overrun internal buffer - marking as dead\n", ns->fd); - ns->status = Ns_Dead; + LOG (llevDebug, "Write_To_Socket called with dead socket\n"); return; } + if ((len + outputbuffer.len) > SOCKETBUFSIZE) + { + LOG (llevDebug, "Socket on fd %d has overrun internal buffer - marking as dead\n", fd); + status = Ns_Dead; + return; + } + + int avail, end; + /* data + end is where we start putting the new data. The last byte * currently in use is actually data + end -1 */ - - end = ns->outputbuffer.start + ns->outputbuffer.len; + end = outputbuffer.start + outputbuffer.len; /* The buffer is already in a wrapped state, so adjust end */ if (end >= SOCKETBUFSIZE) end -= SOCKETBUFSIZE; @@ -222,206 +299,70 @@ /* We can all fit it behind the current data without wrapping */ if (avail >= len) - memcpy (ns->outputbuffer.data + end, buf, len); + memcpy (outputbuffer.data + end, buf, len); else { - memcpy (ns->outputbuffer.data + end, buf, avail); - memcpy (ns->outputbuffer.data, buf + avail, len - avail); + memcpy (outputbuffer.data + end, buf, avail); + memcpy (outputbuffer.data, buf + avail, len - avail); } - ns->outputbuffer.len += len; -#if 0 - LOG (llevDebug, "Added %d to output buffer, total length now %d, start=%d\n", len, ns->outputbuffer.len, ns->outputbuffer.start); -#endif + outputbuffer.len += len; } -/** - * Writes data to socket. - * - * When the socket is clear to write, and we have backlogged data, this - * is called to write it out. - */ void -write_socket_buffer (NewSocket * ns) +client_socket::socket_cb (iow &w, int got) { - int amt, max; - - if (ns->outputbuffer.len == 0) - { - LOG (llevDebug, "write_socket_buffer called when there is no data, fd=%d\n", ns->fd); - return; - } - - do - { - max = SOCKETBUFSIZE - ns->outputbuffer.start; - if (ns->outputbuffer.len < max) - max = ns->outputbuffer.len; - - do - { - amt = write (ns->fd, ns->outputbuffer.data + ns->outputbuffer.start, max); - } - while ((amt < 0) && (errno == EINTR)); - - if (amt < 0) - { /* We got an error */ + write_outputbuffer (); - if (errno != EWOULDBLOCK) - { - LOG (llevError, "New socket write failed (wsb) (%d: %s).\n", errno, strerror (errno)); - ns->status = Ns_Dead; - return; - } - else - { /* EWOULDBLOCK */ - /* can't write it, so store it away. */ - ns->can_write = 0; - return; - } - } - ns->outputbuffer.start += amt; - /* wrap back to start of buffer */ - if (ns->outputbuffer.start == SOCKETBUFSIZE) - ns->outputbuffer.start = 0; - ns->outputbuffer.len -= amt; -#ifdef CS_LOGSTATS - cst_tot.obytes += amt; - cst_lst.obytes += amt; -#endif - } - while (ns->outputbuffer.len > 0); + if (!outputbuffer.len) + socket_ev.poll (socket_ev.poll () & ~PE_W); } /** - * This writes data to the socket. - It is very low level - - * all we try and do is write out the data to the socket - * provided (ns). buf is the data to write, len is the number - * of bytes to write. IT doesn't return anything - rather, it - * updates the ns structure if we get an error. + * Takes a string of data, and writes it out to the socket. A very handy + * shortcut function. */ void -Write_To_Socket (NewSocket * ns, char *buf, int len) +client_socket::send_packet (packet &sl) { - int amt = 0; - char *pos = buf; - - if (ns->status == Ns_Dead || !buf) - { - LOG (llevDebug, "Write_To_Socket called with dead socket\n"); - return; - } + if (status == Ns_Dead) + return; -#ifndef __GNU__ /* This caused problems on Hurd */ - if (!ns->can_write) - { - add_to_buffer (ns, buf, len); - return; - } -#endif - /* If we manage to write more than we wanted, take it as a bonus */ - while (len > 0) + if (sl.length () >= MAXSOCKBUF) { - - do - { - amt = write (ns->fd, pos, len); - } - while ((amt < 0) && (errno == EINTR)); - - if (amt < 0) - { /* We got an error */ - if (errno != EWOULDBLOCK) - { - LOG (llevError, "New socket write failed WTS (%d: %s).\n", /* ---WIN32 */ - errno, strerror (errno)); - ns->status = Ns_Dead; - return; - } - else - { /* EWOULDBLOCK */ - /* can't write it, so store it away. */ - add_to_buffer (ns, pos, len); - ns->can_write = 0; - return; - } - } - /* amt gets set to 0 above in blocking code, so we do this as - * an else if to make sure we don't reprocess it. + LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", sl.length ()); + /* Almost certainly we've overflowed a buffer, so quit now to make + * it easier to debug. */ - else if (amt == 0) - { - LOG (llevError, "Write_To_Socket: No data written out.\n"); - } - len -= amt; - pos += amt; -#ifdef CS_LOGSTATS - cst_tot.obytes += amt; - cst_lst.obytes += amt; -#endif + abort (); } -} + if (!sl.length ()) + return; -/** - * Takes a string of data, and writes it out to the socket. A very handy - * shortcut function. - */ -void -cs_write_string (NewSocket *ns, const char *buf, int len) -{ - SockList sl; + assert (sl.hdrlen == 2); - sl.len = len; - sl.buf = (unsigned char *) buf; - Send_With_Handling (ns, &sl); -} + sl.buf_ [0] = sl.length () >> 8; + sl.buf_ [1] = sl.length () ; + send (sl.buf_, sl.length () + sl.hdrlen); +} -/** - * Calls Write_To_Socket to send data to the client. - * - * The only difference in this function is that we take a SockList - *, and we prepend the length information. - */ void -Send_With_Handling (NewSocket *ns, SockList *msg) +client_socket::send_packet (const char *buf, int len) { - unsigned char sbuf[4]; - - if (ns->status == Ns_Dead || !msg) - return; + packet sl; - if (msg->len >= MAXSOCKBUF) - { - LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", msg->len); - /* Almost certainly we've overflowed a buffer, so quite now to make - * it easier to debug. - */ - abort (); - } - sbuf[0] = ((uint32) (msg->len) >> 8) & 0xFF; - sbuf[1] = ((uint32) (msg->len)) & 0xFF; - if (ns->status != Ns_Old) - Write_To_Socket (ns, (char *) sbuf, 2); - Write_To_Socket (ns, (char *) msg->buf, msg->len); + sl << data (buf, len); + send_packet (sl); } -/** - * Takes a string of data, and writes it out to the socket. A very handy - * shortcut function. - */ void -Write_String_To_Socket (NewSocket *ns, char *buf, int len) +client_socket::send_packet (const char *buf) { - SockList sl; - - sl.len = len; - sl.buf = (unsigned char *) buf; - Send_With_Handling (ns, &sl); + send_packet (buf, strlen (buf)); } - /****************************************************************************** * * statistics logging functions. @@ -453,7 +394,6 @@ now - cst_tot.time_start, cst_lst.ibytes, cst_lst.obytes, cst_lst.max_conn, now - cst_lst.time_start); cst_lst.ibytes = 0; cst_lst.obytes = 0; - cst_lst.max_conn = socket_info.nconns; cst_lst.time_start = now; } #endif