--- deliantra/server/socket/lowlevel.C 2006/11/26 19:48:50 1.7 +++ deliantra/server/socket/lowlevel.C 2006/12/11 19:46:47 1.8 @@ -159,39 +159,21 @@ /* We already have a partial packet */ if (sl->len < 2) { -#ifdef WIN32 /* ***WIN32 SockList_ReadPacket: change read() to recv() */ - - stat = recv (fd, sl->buf + sl->len, 2 - sl->len, 0); - -#else do { stat = read (fd, sl->buf + sl->len, 2 - sl->len); } while ((stat == -1) && (errno == EINTR)); -#endif + if (stat < 0) { /* In non blocking mode, EAGAIN is set when there is no * data available. */ -#ifdef WIN32 /* ***WIN32 SockList_ReadPacket: error handling for win32 */ - if ((stat == -1) && WSAGetLastError () != WSAEWOULDBLOCK) - { - if (WSAGetLastError () == WSAECONNRESET) - LOG (llevDebug, "Connection closed by client\n"); - else - { - LOG (llevDebug, "ReadPacket got error %d, returning 0\n", WSAGetLastError ()); - } - return -1; /* kick this user! */ - } -#else if (errno != EAGAIN && errno != EWOULDBLOCK) { LOG (llevDebug, "ReadPacket got error %s, returning 0\n", strerror (errno)); } -#endif return 0; /*Error */ } if (stat == 0) @@ -215,46 +197,25 @@ * closing the socket anyways, then reading this extra 100 bytes * shouldn't hurt. */ -#ifdef WIN32 /* ***win32 SockList_ReadPacket: change read() to recv() */ - recv (fd, sl->buf + 2, 100, 0); -#else read (fd, sl->buf + 2, 100); -#endif /* end win32 */ /* return error so the socket is closed */ return -1; } do { -#ifdef WIN32 /* ***win32 SockList_ReadPacket: change read() to recv() */ - stat = recv (fd, sl->buf + sl->len, toread, 0); -#else do { stat = read (fd, sl->buf + sl->len, toread); } while ((stat < 0) && (errno == EINTR)); -#endif if (stat < 0) { -#ifdef WIN32 /* ***win32 SockList_ReadPacket: change error handling for win32 */ - if ((stat == -1) && WSAGetLastError () != WSAEWOULDBLOCK) - { - if (WSAGetLastError () == WSAECONNRESET) - LOG (llevDebug, "Connection closed by client\n"); - else - { - LOG (llevDebug, "ReadPacket got error %d, returning 0\n", WSAGetLastError ()); - } - return -1; /* kick this user! */ - } -#else if (errno != EAGAIN && errno != EWOULDBLOCK) { LOG (llevDebug, "ReadPacket got error %s, returning 0\n", strerror (errno)); } -#endif return 0; /*Error */ } if (stat == 0) @@ -351,28 +312,18 @@ if (ns->outputbuffer.len < max) max = ns->outputbuffer.len; -#ifdef WIN32 /* ***win32 write_socket_buffer: change write() to send() */ - amt = send (ns->fd, ns->outputbuffer.data + ns->outputbuffer.start, max, 0); -#else do { amt = write (ns->fd, ns->outputbuffer.data + ns->outputbuffer.start, max); } while ((amt < 0) && (errno == EINTR)); -#endif if (amt < 0) { /* We got an error */ -#ifdef WIN32 /* ***win32 write_socket_buffer: change error handling */ - if (amt == -1 && WSAGetLastError () != WSAEWOULDBLOCK) - { - LOG (llevError, "New socket write failed (wsb) (%d).\n", WSAGetLastError ()); -#else if (errno != EWOULDBLOCK) { LOG (llevError, "New socket write failed (wsb) (%d: %s).\n", errno, strerror (errno)); -#endif ns->status = Ns_Dead; return; } @@ -426,28 +377,18 @@ while (len > 0) { -#ifdef WIN32 /* ***win32 Write_To_Socket: change write() to send() */ - amt = send (ns->fd, pos, len, 0); -#else do { amt = write (ns->fd, pos, len); } while ((amt < 0) && (errno == EINTR)); -#endif if (amt < 0) { /* We got an error */ -#ifdef WIN32 /* ***win32 Write_To_Socket: change error handling */ - if (amt == -1 && WSAGetLastError () != WSAEWOULDBLOCK) - { - LOG (llevError, "New socket write failed WTS (%d).\n", WSAGetLastError ()); -#else if (errno != EWOULDBLOCK) { LOG (llevError, "New socket write failed WTS (%d: %s).\n", /* ---WIN32 */ errno, strerror (errno)); -#endif ns->status = Ns_Dead; return; }