--- deliantra/server/socket/lowlevel.C 2006/12/13 21:27:09 1.11 +++ deliantra/server/socket/lowlevel.C 2006/12/14 01:21:58 1.14 @@ -82,11 +82,11 @@ /*********************************************************************** * - * SockList functions/utilities + * packet functions/utilities * **********************************************************************/ -SockList &SockList::operator <<(const data &v) +packet &packet::operator <<(const data &v) { if (v.len) { @@ -97,153 +97,91 @@ return *this; } -SockList &SockList::operator <<(const data8 &v) +packet &packet::operator <<(const data8 &v) { unsigned int len = min (v.len, 0x00FF); return *this << uint8 (len) << data (v.ptr, len); } -SockList &SockList::operator <<(const data16 &v) +packet &packet::operator <<(const data16 &v) { unsigned int len = min (v.len, 0xFFFF); return *this << uint16 (len) << data (v.ptr, len); } -SockList &SockList::operator <<(const char *v) +packet &packet::operator <<(const char *v) { return *this << data (v, strlen (v ? v : 0)); } void -SockList::printf (const char *format, ...) +packet::printf (const char *format, ...) { va_list ap; va_start (ap, format); - len += vsprintf ((char *)buf + len, format, ap); + len += vsnprintf ((char *)buf + len, MAXSOCKBUF, format, ap); va_end (ap); } -/* Basically does the reverse of SockList_AddInt, but on - * strings instead. Same for the GetShort, but for 16 bits. - */ -int -GetInt_String (unsigned char *data) -{ - return ((data[0] << 24) + (data[1] << 16) + (data[2] << 8) + data[3]); -} - -short -GetShort_String (unsigned char *data) -{ - return ((data[0] << 8) + data[1]); -} - /****************************************************************************** * * Start of read routines. * ******************************************************************************/ -/** - * This reads from fd and puts the data in sl. We return true if we think - * we have a full packet, 0 if we have a partial packet. The only processing - * we do is remove the intial size value. len (As passed) is the size of the - * buffer allocated in the socklist. We make the assumption the buffer is - * at least 2 bytes long. - */ - int -SockList_ReadPacket (int fd, SockList *sl, int len) +NewSocket::read_packet () { - int stat, toread; - - /* Sanity check - shouldn't happen */ - if (sl->len < 0) + for (;;) { - abort (); - } - /* We already have a partial packet */ - if (sl->len < 2) - { - do + if (inbuf_len >= 2) { - stat = read (fd, sl->buf + sl->len, 2 - sl->len); + unsigned int pkt_len = (inbuf [0] << 8) | inbuf [1]; + + if (inbuf_len >= 2 + pkt_len) + return pkt_len + 2; } - while ((stat == -1) && (errno == EINTR)); - if (stat < 0) + int amount = sizeof (inbuf) - inbuf_len; + + if (amount <= 0) { - /* In non blocking mode, EAGAIN is set when there is no - * data available. - */ - if (errno != EAGAIN && errno != EWOULDBLOCK) - { - LOG (llevDebug, "ReadPacket got error %s, returning 0\n", strerror (errno)); - } - return 0; /*Error */ + LOG (llevError, "packet too large");//TODO + return -1; } - if (stat == 0) - return -1; - sl->len += stat; -#ifdef CS_LOGSTATS - cst_tot.ibytes += stat; - cst_lst.ibytes += stat; -#endif - if (stat < 2) - return 0; /* Still don't have a full packet */ - } - /* Figure out how much more data we need to read. Add 2 from the - * end of this - size header information is not included. - */ - toread = 2 + (sl->buf[0] << 8) + sl->buf[1] - sl->len; - if ((toread + sl->len) >= len) - { - LOG (llevError, "SockList_ReadPacket: Want to read more bytes than will fit in buffer (%d>=%d).\n", toread + sl->len, len); - /* Quick hack in case for 'oldsocketmode' input. If we are - * closing the socket anyways, then reading this extra 100 bytes - * shouldn't hurt. - */ - read (fd, sl->buf + 2, 100); - /* return error so the socket is closed */ - return -1; - } - do - { - do + amount = read (fd, inbuf + inbuf_len, amount); + + if (!amount) { - stat = read (fd, sl->buf + sl->len, toread); + status = Ns_Dead; + return -1; } - while ((stat < 0) && (errno == EINTR)); - if (stat < 0) + else if (amount < 0) { - - if (errno != EAGAIN && errno != EWOULDBLOCK) + if (errno != EAGAIN && errno != EINTR) { - LOG (llevDebug, "ReadPacket got error %s, returning 0\n", strerror (errno)); + LOG (llevError, "read error: %s", strerror (errno)); + return -1; } - return 0; /*Error */ - } - if (stat == 0) - return -1; - sl->len += stat; -#ifdef CS_LOGSTATS - cst_tot.ibytes += stat; - cst_lst.ibytes += stat; -#endif - toread -= stat; - if (toread == 0) - return 1; - if (toread < 0) - { - LOG (llevError, "SockList_ReadPacket: Read more bytes than desired.\n"); - return 1; + + return 0; } + + inbuf_len += amount; + + cst_tot.ibytes += amount; + cst_lst.ibytes += amount; } - while (toread > 0); - return 0; +} + +void +NewSocket::skip_packet (int len) +{ + inbuf_len -= len; + memmove (inbuf, inbuf + len, inbuf_len); } /******************************************************************************* @@ -260,7 +198,7 @@ */ static void -add_to_buffer (NewSocket * ns, char *buf, int len) +add_to_buffer (NewSocket *ns, char *buf, int len) { int avail, end; @@ -424,30 +362,40 @@ } } - /** * Takes a string of data, and writes it out to the socket. A very handy * shortcut function. */ + void -cs_write_string (NewSocket *ns, const char *buf, int len) +NewSocket::send_packet (packet &sl) { - SockList sl; + Send_With_Handling (this, &sl); +} - sl.len = len; - sl.buf = (unsigned char *) buf; - Send_With_Handling (ns, &sl); +void +NewSocket::send_packet (const char *buf, int len) +{ + packet sl; + + sl << data (buf, len); + send_packet (sl); } +void +NewSocket::send_packet (const char *buf) +{ + send_packet (buf, strlen (buf)); +} /** * Calls Write_To_Socket to send data to the client. * - * The only difference in this function is that we take a SockList + * The only difference in this function is that we take a packet *, and we prepend the length information. */ void -Send_With_Handling (NewSocket *ns, SockList *msg) +Send_With_Handling (NewSocket *ns, packet *msg) { unsigned char sbuf[4]; @@ -469,21 +417,6 @@ Write_To_Socket (ns, (char *) msg->buf, msg->len); } -/** - * Takes a string of data, and writes it out to the socket. A very handy - * shortcut function. - */ -void -Write_String_To_Socket (NewSocket *ns, char *buf, int len) -{ - SockList sl; - - sl.len = len; - sl.buf = (unsigned char *) buf; - Send_With_Handling (ns, &sl); -} - - /****************************************************************************** * * statistics logging functions.