--- deliantra/server/socket/lowlevel.C 2006/11/26 19:48:50 1.7 +++ deliantra/server/socket/lowlevel.C 2006/12/14 05:09:32 1.18 @@ -37,6 +37,7 @@ #include #include #include +#include #ifdef __linux__ # include @@ -52,7 +53,7 @@ #define SOCKET_TIMEOUT2 20 void -Socket_Flush (NewSocket * ns) +Socket_Flush (client_socket * ns) { #ifdef __linux__ // check time of last ack, and, if too old, kill connection @@ -74,62 +75,64 @@ int val; - val = 0; - setsockopt (ns->fd, IPPROTO_TCP, TCP_CORK, &val, sizeof (val)); - val = 1; - setsockopt (ns->fd, IPPROTO_TCP, TCP_CORK, &val, sizeof (val)); + val = 0; setsockopt (ns->fd, IPPROTO_TCP, TCP_CORK, &val, sizeof (val)); + val = 1; setsockopt (ns->fd, IPPROTO_TCP, TCP_CORK, &val, sizeof (val)); #endif } /*********************************************************************** * - * SockList functions/utilities + * packet functions/utilities * **********************************************************************/ -void -SockList_Init (SockList * sl) +packet &packet::operator <<(const data &v) { - sl->len = 0; - sl->buf = NULL; + if (room () < v.len) + reset (); + else + { + if (v.len) + { + memcpy (cur, v.ptr, v.len); + cur += v.len; + } + } + + return *this; } -void -SockList_AddInt (SockList * sl, uint32 data) +packet &packet::operator <<(const data8 &v) { - sl->buf[sl->len++] = (data >> 24) & 0xff; - sl->buf[sl->len++] = (data >> 16) & 0xff; - sl->buf[sl->len++] = (data >> 8) & 0xff; - sl->buf[sl->len++] = data & 0xff; + unsigned int len = min (v.len, 0x00FF); + return *this << uint8 (len) << data (v.ptr, len); } -void -SockList_AddInt64 (SockList * sl, uint64 data) +packet &packet::operator <<(const data16 &v) { - sl->buf[sl->len++] = (char) ((data >> 56) & 0xff); - sl->buf[sl->len++] = (char) ((data >> 48) & 0xff); - sl->buf[sl->len++] = (char) ((data >> 40) & 0xff); - sl->buf[sl->len++] = (char) ((data >> 32) & 0xff); - - sl->buf[sl->len++] = (char) ((data >> 24) & 0xff); - sl->buf[sl->len++] = (char) ((data >> 16) & 0xff); - sl->buf[sl->len++] = (char) ((data >> 8) & 0xff); - sl->buf[sl->len++] = (char) (data & 0xff); + unsigned int len = min (v.len, 0xFFFF); + return *this << uint16 (len) << data (v.ptr, len); } -/* Basically does the reverse of SockList_AddInt, but on - * strings instead. Same for the GetShort, but for 16 bits. - */ -int -GetInt_String (unsigned char *data) +packet &packet::operator <<(const char *v) { - return ((data[0] << 24) + (data[1] << 16) + (data[2] << 8) + data[3]); + return *this << data (v, strlen (v ? v : 0)); } -short -GetShort_String (unsigned char *data) +void +packet::printf (const char *format, ...) { - return ((data[0] << 8) + data[1]); + int size = room (); + + va_list ap; + va_start (ap, format); + int len = vsnprintf ((char *)cur, size, format, ap); + va_end (ap); + + if (len >= size) + return reset (); + + cur += len; } /****************************************************************************** @@ -138,143 +141,57 @@ * ******************************************************************************/ -/** - * This reads from fd and puts the data in sl. We return true if we think - * we have a full packet, 0 if we have a partial packet. The only processing - * we do is remove the intial size value. len (As passed) is the size of the - * buffer allocated in the socklist. We make the assumption the buffer is - * at least 2 bytes long. - */ - int -SockList_ReadPacket (int fd, SockList * sl, int len) +client_socket::read_packet () { - int stat, toread; - - /* Sanity check - shouldn't happen */ - if (sl->len < 0) - { - abort (); - } - /* We already have a partial packet */ - if (sl->len < 2) + for (;;) { -#ifdef WIN32 /* ***WIN32 SockList_ReadPacket: change read() to recv() */ - - stat = recv (fd, sl->buf + sl->len, 2 - sl->len, 0); - -#else - do + if (inbuf_len >= 2) { - stat = read (fd, sl->buf + sl->len, 2 - sl->len); + unsigned int pkt_len = (inbuf [0] << 8) | inbuf [1]; + + if (inbuf_len >= 2 + pkt_len) + return pkt_len + 2; } - while ((stat == -1) && (errno == EINTR)); -#endif - if (stat < 0) + + int amount = sizeof (inbuf) - inbuf_len; + + if (amount <= 0) { - /* In non blocking mode, EAGAIN is set when there is no - * data available. - */ -#ifdef WIN32 /* ***WIN32 SockList_ReadPacket: error handling for win32 */ - if ((stat == -1) && WSAGetLastError () != WSAEWOULDBLOCK) - { - if (WSAGetLastError () == WSAECONNRESET) - LOG (llevDebug, "Connection closed by client\n"); - else - { - LOG (llevDebug, "ReadPacket got error %d, returning 0\n", WSAGetLastError ()); - } - return -1; /* kick this user! */ - } -#else - if (errno != EAGAIN && errno != EWOULDBLOCK) - { - LOG (llevDebug, "ReadPacket got error %s, returning 0\n", strerror (errno)); - } -#endif - return 0; /*Error */ + LOG (llevError, "packet too large");//TODO + return -1; } - if (stat == 0) - return -1; - sl->len += stat; -#ifdef CS_LOGSTATS - cst_tot.ibytes += stat; - cst_lst.ibytes += stat; -#endif - if (stat < 2) - return 0; /* Still don't have a full packet */ - } - /* Figure out how much more data we need to read. Add 2 from the - * end of this - size header information is not included. - */ - toread = 2 + (sl->buf[0] << 8) + sl->buf[1] - sl->len; - if ((toread + sl->len) >= len) - { - LOG (llevError, "SockList_ReadPacket: Want to read more bytes than will fit in buffer (%d>=%d).\n", toread + sl->len, len); - /* Quick hack in case for 'oldsocketmode' input. If we are - * closing the socket anyways, then reading this extra 100 bytes - * shouldn't hurt. - */ -#ifdef WIN32 /* ***win32 SockList_ReadPacket: change read() to recv() */ - recv (fd, sl->buf + 2, 100, 0); -#else - read (fd, sl->buf + 2, 100); -#endif /* end win32 */ - /* return error so the socket is closed */ - return -1; - } - do - { -#ifdef WIN32 /* ***win32 SockList_ReadPacket: change read() to recv() */ - stat = recv (fd, sl->buf + sl->len, toread, 0); -#else - do + amount = read (fd, inbuf + inbuf_len, amount); + + if (!amount) { - stat = read (fd, sl->buf + sl->len, toread); + status = Ns_Dead; + return -1; } - while ((stat < 0) && (errno == EINTR)); -#endif - if (stat < 0) + else if (amount < 0) { - -#ifdef WIN32 /* ***win32 SockList_ReadPacket: change error handling for win32 */ - if ((stat == -1) && WSAGetLastError () != WSAEWOULDBLOCK) + if (errno != EAGAIN && errno != EINTR) { - if (WSAGetLastError () == WSAECONNRESET) - LOG (llevDebug, "Connection closed by client\n"); - else - { - LOG (llevDebug, "ReadPacket got error %d, returning 0\n", WSAGetLastError ()); - } - return -1; /* kick this user! */ + LOG (llevError, "read error: %s", strerror (errno)); + return -1; } -#else - if (errno != EAGAIN && errno != EWOULDBLOCK) - { - LOG (llevDebug, "ReadPacket got error %s, returning 0\n", strerror (errno)); - } -#endif - return 0; /*Error */ - } - if (stat == 0) - return -1; - sl->len += stat; -#ifdef CS_LOGSTATS - cst_tot.ibytes += stat; - cst_lst.ibytes += stat; -#endif - toread -= stat; - if (toread == 0) - return 1; - if (toread < 0) - { - LOG (llevError, "SockList_ReadPacket: Read more bytes than desired.\n"); - return 1; + + return 0; } + + inbuf_len += amount; + + cst_tot.ibytes += amount; + cst_lst.ibytes += amount; } - while (toread > 0); - return 0; +} + +void +client_socket::skip_packet (int len) +{ + inbuf_len -= len; + memmove (inbuf, inbuf + len, inbuf_len); } /******************************************************************************* @@ -291,7 +208,7 @@ */ static void -add_to_buffer (NewSocket * ns, char *buf, int len) +add_to_buffer (client_socket *ns, char *buf, int len) { int avail, end; @@ -335,7 +252,7 @@ * is called to write it out. */ void -write_socket_buffer (NewSocket * ns) +write_socket_buffer (client_socket * ns) { int amt, max; @@ -351,28 +268,18 @@ if (ns->outputbuffer.len < max) max = ns->outputbuffer.len; -#ifdef WIN32 /* ***win32 write_socket_buffer: change write() to send() */ - amt = send (ns->fd, ns->outputbuffer.data + ns->outputbuffer.start, max, 0); -#else do { amt = write (ns->fd, ns->outputbuffer.data + ns->outputbuffer.start, max); } while ((amt < 0) && (errno == EINTR)); -#endif if (amt < 0) { /* We got an error */ -#ifdef WIN32 /* ***win32 write_socket_buffer: change error handling */ - if (amt == -1 && WSAGetLastError () != WSAEWOULDBLOCK) - { - LOG (llevError, "New socket write failed (wsb) (%d).\n", WSAGetLastError ()); -#else if (errno != EWOULDBLOCK) { LOG (llevError, "New socket write failed (wsb) (%d: %s).\n", errno, strerror (errno)); -#endif ns->status = Ns_Dead; return; } @@ -404,58 +311,49 @@ * updates the ns structure if we get an error. */ void -Write_To_Socket (NewSocket * ns, char *buf, int len) +client_socket::send (void *buf_, int len) { - int amt = 0; + char *buf = (char *)buf_; char *pos = buf; + int amt = 0; - if (ns->status == Ns_Dead || !buf) + if (status == Ns_Dead || !buf) { LOG (llevDebug, "Write_To_Socket called with dead socket\n"); return; } #ifndef __GNU__ /* This caused problems on Hurd */ - if (!ns->can_write) + if (!can_write) { - add_to_buffer (ns, buf, len); + add_to_buffer (this, buf, len); return; } #endif + /* If we manage to write more than we wanted, take it as a bonus */ while (len > 0) { - -#ifdef WIN32 /* ***win32 Write_To_Socket: change write() to send() */ - amt = send (ns->fd, pos, len, 0); -#else do { - amt = write (ns->fd, pos, len); + amt = write (fd, pos, len); } while ((amt < 0) && (errno == EINTR)); -#endif if (amt < 0) { /* We got an error */ -#ifdef WIN32 /* ***win32 Write_To_Socket: change error handling */ - if (amt == -1 && WSAGetLastError () != WSAEWOULDBLOCK) - { - LOG (llevError, "New socket write failed WTS (%d).\n", WSAGetLastError ()); -#else if (errno != EWOULDBLOCK) { LOG (llevError, "New socket write failed WTS (%d: %s).\n", /* ---WIN32 */ errno, strerror (errno)); -#endif - ns->status = Ns_Dead; + status = Ns_Dead; return; } else { /* EWOULDBLOCK */ /* can't write it, so store it away. */ - add_to_buffer (ns, pos, len); - ns->can_write = 0; + add_to_buffer (this, pos, len); + can_write = 0; return; } } @@ -463,9 +361,8 @@ * an else if to make sure we don't reprocess it. */ else if (amt == 0) - { - LOG (llevError, "Write_To_Socket: No data written out.\n"); - } + LOG (llevError, "Write_To_Socket: No data written out.\n"); + len -= amt; pos += amt; #ifdef CS_LOGSTATS @@ -475,66 +372,63 @@ } } - /** * Takes a string of data, and writes it out to the socket. A very handy * shortcut function. */ + +void +client_socket::send_packet (packet &sl) +{ + Send_With_Handling (this, &sl); +} + void -cs_write_string (NewSocket * ns, const char *buf, int len) +client_socket::send_packet (const char *buf, int len) { - SockList sl; + packet sl; - sl.len = len; - sl.buf = (unsigned char *) buf; - Send_With_Handling (ns, &sl); + sl << data (buf, len); + send_packet (sl); } +void +client_socket::send_packet (const char *buf) +{ + send_packet (buf, strlen (buf)); +} /** * Calls Write_To_Socket to send data to the client. * - * The only difference in this function is that we take a SockList + * The only difference in this function is that we take a packet *, and we prepend the length information. */ void -Send_With_Handling (NewSocket * ns, SockList * msg) +Send_With_Handling (client_socket *ns, packet *msg) { unsigned char sbuf[4]; if (ns->status == Ns_Dead || !msg) return; - if (msg->len >= MAXSOCKBUF) + if (msg->length () >= MAXSOCKBUF) { - LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", msg->len); + LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", msg->length ()); /* Almost certainly we've overflowed a buffer, so quite now to make * it easier to debug. */ abort (); } - sbuf[0] = ((uint32) (msg->len) >> 8) & 0xFF; - sbuf[1] = ((uint32) (msg->len)) & 0xFF; - if (ns->status != Ns_Old) - Write_To_Socket (ns, (char *) sbuf, 2); - Write_To_Socket (ns, (char *) msg->buf, msg->len); -} -/** - * Takes a string of data, and writes it out to the socket. A very handy - * shortcut function. - */ -void -Write_String_To_Socket (NewSocket * ns, char *buf, int len) -{ - SockList sl; + sbuf[0] = ((uint32) (msg->length ()) >> 8); + sbuf[1] = ((uint32) (msg->length ()) ); - sl.len = len; - sl.buf = (unsigned char *) buf; - Send_With_Handling (ns, &sl); + //TODO: single write, or writev + ns->send (sbuf, 2); + ns->send (msg->buf, msg->length ()); } - /****************************************************************************** * * statistics logging functions. @@ -566,7 +460,7 @@ now - cst_tot.time_start, cst_lst.ibytes, cst_lst.obytes, cst_lst.max_conn, now - cst_lst.time_start); cst_lst.ibytes = 0; cst_lst.obytes = 0; - cst_lst.max_conn = socket_info.nconns; cst_lst.time_start = now; } #endif +