--- deliantra/server/socket/lowlevel.C	2007/07/28 00:15:18	1.52
+++ deliantra/server/socket/lowlevel.C	2007/10/05 23:03:49	1.61
@@ -33,9 +33,6 @@
 # include <netinet/tcp.h>
 #endif
 
-// disconnect a socket after this many seconds without an ack
-#define SOCKET_TIMEOUT 8.
-
 // force a packet when idle for more than this many seconds,
 // forcing an ack regularly.
 #define IDLE_PING 2.
@@ -46,35 +43,6 @@
   if (destroyed ())
     return;
 
-#if HAVE_TCP_INFO
-  // check about once per second, spread evenly over all clients
-  // do this only when player is active
-  if (!((pticks + fd) & 7) && pl && pl->active)
-    {
-      // check time of last ack, and, if too old, kill connection
-      socklen_t len = sizeof (tcpi);
-
-      if (!getsockopt (fd, IPPROTO_TCP, TCP_INFO, &tcpi, &len) && len == sizeof (tcpi))
-        {
-          if (tcpi.tcpi_snd_mss)
-            mss = tcpi.tcpi_snd_mss;
-
-          //fprintf (stderr, "uack %d sst %d cwnd %d mss %d pmtu %d\n",
-          //         tcpi.tcpi_unacked, tcpi.tcpi_snd_ssthresh, tcpi.tcpi_snd_cwnd, tcpi.tcpi_advmss, tcpi.tcpi_pmtu);
-
-          if (tcpi.tcpi_last_ack_recv > int (SOCKET_TIMEOUT * 1000))
-            {
-              send_msg (NDI_RED, "connection-timeout", "safety disconnect due to tcp/ip timeout (no packets received)");
-              write_outputbuffer ();
-
-              LOG (llevDebug, "connection on fd %d closed due to ack timeout (%u/%u/%u)\n", fd,
-                   (unsigned)tcpi.tcpi_last_ack_recv, (unsigned)tcpi.tcpi_last_data_sent, (unsigned)tcpi.tcpi_unacked);
-              destroy ();
-            }
-        }
-    }
-#endif
-
   /**
    * Writes data to socket.
    *
@@ -166,7 +134,7 @@
 
       if (inbuf_len == sizeof (inbuf))
         {
-          send_packet_printf ("drawinfo %d input buffer overflow - closing connection.", NDI_RED);
+          send_packet_printf ("drawinfo %d input buffer overflow - closing connection.", NDI_RED | NDI_REPLY);
           destroy ();
           return -1;
         }
@@ -250,10 +218,11 @@
       len  -= 6;
     }
 
-  if (len > 4 && !strncmp (data, "say " , 4))
-    return true;
-  if (len > 5 && !strncmp (data, "chat ", 5))
-    return true;
+  if (len > 4 && data [3] == ' ' && !strncmp (data, "say "  , 4)) return true;
+  if (len > 5 && data [4] == ' ' && !strncmp (data, "chat " , 5)) return true;
+  if (len > 6 && data [5] == ' ' && !strncmp (data, "shout ", 6)) return true;
+
+  if (len == 7 && !strcmp (data, "suicide")) return true;
 
   return false;
 }
@@ -270,7 +239,7 @@
         ((void (*)(char *, int, client *))pkt->cb)((char *)data, datalen, this);
     }
   else
-    send_packet_printf ("drawinfo %d ERROR: you cannot execute '%s' now.", NDI_RED, pkt->name);
+    send_packet_printf ("drawinfo %d ERROR: you cannot execute '%s' now.", NDI_RED | NDI_REPLY, pkt->name);
 }
 
 bool
@@ -321,7 +290,7 @@
       }
 
   // If we get here, we didn't find a valid command.
-  send_packet_printf ("drawinfo %d ERROR: command '%s' not supported.", NDI_RED, (char *)inbuf + 2);
+  send_packet_printf ("drawinfo %d ERROR: command '%s' not supported.", NDI_RED | NDI_REPLY, (char *)inbuf + 2);
 next_packet:
   skip_packet (pkt_len);
 
@@ -385,21 +354,17 @@
         {
           inbuf_len += amount;
 
-          cmd_ev.start ();
+          if (handle_packet ())
+            {
+              while (handle_packet ())
+                ;
+
+              flush ();
+            }
         }
     }
 }
 
-// called whenever we have additional commands to process
-void
-client::cmd_cb (iw &w)
-{
-  if (handle_packet ())
-    w.start ();
-  else
-    flush ();
-}
-
 /*******************************************************************************
  *
  * Start of write related routines.
@@ -463,7 +428,7 @@
   if (destroyed ())
     return;
 
-  if (sl.length () >= MAXSOCKBUF)
+  if (sl.length () > MAXSOCKBUF)
     {
       LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", sl.length ());
       /* Almost certainly we've overflowed a buffer, so quit now to make
@@ -521,14 +486,22 @@
 void
 client::send_msg (int color, const char *type, const char *msg)
 {
-  if (msg_is_special (msg))
+  if (!msg || !type) // it can happen (for example, missing attack messages cause this)
+    {
+      LOG (logBacktrace | llevError, "send_msg(%d,%p,%p) called with NULL msg or type.\n", color, type, msg);
+      return;
+    }
+
+  int len = strlen (msg);
+
+  if (msg_is_special (msg) || (type [0] == 'c' && type [1] == '/') || len > (MAXSOCKBUF - 128))
     cfperl_send_msg (this, color, type, msg);
   else if (can_msg)
-    send_packet_printf ("msg %d %s %s", color, type, msg);
+    send_packet_printf ("msg %d %s %s", color & NDI_CLIENT_MASK, type, msg);
   else if (color < 0)
     return; // client cannot handle this
   else
-    send_packet_printf ("drawinfo %d %s", color, msg);
+    send_packet_printf ("drawinfo %d %s", color & NDI_COLOR_MASK, msg);
 }
 
 void