[ViewVC] Diff of: cvs/deliantra/server/socket/lowlevel.C

Comparing deliantra/server/socket/lowlevel.C (file contents):
Revision 1.42 by root, Mon May 28 21:22:26 2007 UTC vs.
Revision 1.59 by root, Sun Sep 30 20:22:25 2007 UTC

 /*
- * This file is part of Crossfire TRT, the Multiplayer Online Role Playing Game.
+ * This file is part of Crossfire TRT, the Roguelike Realtime MORPG.
  *
  * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team
  * Copyright (©) 1992,2007 Frank Tore Johansen
  *
- * Crossfire TRT is free software; you can redistribute it and/or modify it
+ * Crossfire TRT is free software: you can redistribute it and/or modify
- * under the terms of the GNU General Public License as published by the Free
+ * it under the terms of the GNU General Public License as published by
- * Software Foundation; either version 2 of the License, or (at your option)
+ * the Free Software Foundation, either version 3 of the License, or
- * any later version.
+ * (at your option) any later version.
  *
- * This program is distributed in the hope that it will be useful, but
+ * This program is distributed in the hope that it will be useful,
- * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * for more details.
+ * GNU General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License along
+ * You should have received a copy of the GNU General Public License
- * with Crossfire TRT; if not, write to the Free Software Foundation, Inc. 51
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  *
  * The authors can be reached via e-mail to <crossfire@schmorp.de>
  */
-/**
- * \file
- * Low-level socket-related functions.
- *
- * \date 2003-12-02
- *
- * Contains some base functions that both the client and server
- * can use.  As such, depending what we are being compiled for will
- * determine what we can include.  the client is designed have
- * CFCLIENT defined as part of its compile flags.
- */
 using namespace std;
 #include <global.h>
 #include <sproto.h>
 #include <cstdarg>
-#ifdef __linux__
+#if HAVE_TCP_INFO
 # include <sys/types.h>
 # include <sys/socket.h>
 # include <netinet/in.h>
 # include <netinet/tcp.h>
 #endif
-// use a really low timeout, as it doesn't cost any bandwidth, and you can
+// force a packet when idle for more than this many seconds,
-// easily die in 20 seconds...
+// forcing an ack regularly.
-#define SOCKET_TIMEOUT1 10 * 1000
+#define IDLE_PING 2.
-#define SOCKET_TIMEOUT2 20 * 1000
 void
 client::flush ()
 {
   if (destroyed ())
     return;
-#ifdef __linux__
-  // check time of last ack, and, if too old, kill connection
-  struct tcp_info tcpi;
-  socklen_t len = sizeof (tcpi);
-  if (!getsockopt (fd, IPPROTO_TCP, TCP_INFO, &tcpi, &len) && len == sizeof (tcpi))
-    {
-      unsigned int diff = tcpi.tcpi_last_ack_recv - tcpi.tcpi_last_data_sent;
-      rtt    = tcpi.tcpi_rtt;
-      rttvar = tcpi.tcpi_rttvar;
-      if (tcpi.tcpi_unacked && SOCKET_TIMEOUT1 < diff && diff < 0x80000000UL   // ack delayed for 20s
-          && SOCKET_TIMEOUT2 < tcpi.tcpi_last_data_sent)       // no data sent for 10s
-        {
-          LOG (llevDebug, "Connection on fd %d closed due to ack timeout (%u/%u/%u)\n", fd,
-               (unsigned) tcpi.tcpi_last_ack_recv, (unsigned) tcpi.tcpi_last_data_sent, (unsigned) tcpi.tcpi_unacked);
-          destroy ();
-        }
-    }
-#endif
   /**
    * Writes data to socket.
    *
    * When the socket is clear to write, and we have backlogged data, this
    * is called to write it out.
    */
-  if (!outputbuffer.len || socket_ev.poll () & PE_W)
+  // write a nop to the socket at least every IDLE_NOP seconds.
+  if (!outputbuffer.len)
+    {
+      if (last_send + IDLE_PING <= NOW && pl && pl->active)
+        {
+          // this is a bit ugly, but map1/map1a seem to be the only
+          // nop'able commands and they are quite small.
+          packet sl (mapmode == Map1Cmd ? "map1" : "map1a");
+          send_packet (sl);
+        }
+      else
+        return;
+    }
+  if (socket_ev.poll () & PE_W)
     return;
+  last_send = NOW;
   write_outputbuffer ();
 }
 void
 client::write_outputbuffer ()
           /* wrap back to start of buffer */
           if (outputbuffer.start == SOCKETBUFSIZE)
             outputbuffer.start = 0;
           outputbuffer.len -= res;
-#ifdef CS_LOGSTATS
-          cst_tot.obytes += res;
-          cst_lst.obytes += res;
-#endif
         }
       else if (res == 0)
         {
           LOG (llevError, "socket write failed, connection closed.\n");
           destroy ();
       if (inbuf_len >= 2 + pkt_len)
         return 2 + pkt_len;
       if (inbuf_len == sizeof (inbuf))
         {
-          send_packet_printf ("drawinfo %d input buffer overflow - closing connection.", NDI_RED);
+          send_packet_printf ("drawinfo %d input buffer overflow - closing connection.", NDI_RED | NDI_REPLY);
           destroy ();
           return -1;
         }
     }
         ((void (*)(char *, int, player *))pkt->cb)((char *)data, datalen, pl);
       else
         ((void (*)(char *, int, client *))pkt->cb)((char *)data, datalen, this);
     }
   else
-    send_packet_printf ("drawinfo %d ERROR: you cannot execute '%s' now.", NDI_RED, pkt->name);
+    send_packet_printf ("drawinfo %d ERROR: you cannot execute '%s' now.", NDI_RED | NDI_REPLY, pkt->name);
 }
 bool
 client::handle_packet ()
 {
         goto next_packet;
       }
   // If we get here, we didn't find a valid command.
-  send_packet_printf ("drawinfo %d ERROR: command '%s' not supported.", NDI_RED, (char *)inbuf + 2);
+  send_packet_printf ("drawinfo %d ERROR: command '%s' not supported.", NDI_RED | NDI_REPLY, (char *)inbuf + 2);
 next_packet:
   skip_packet (pkt_len);
   // input buffer has space again
   socket_ev.poll (socket_ev.poll () | PE_R);
           // should not be here, normally
         }
       else
         {
           inbuf_len += amount;
-          cst_tot.ibytes += amount;
-          cst_lst.ibytes += amount;
           cmd_ev.start ();
         }
     }
 }
 client::send_packet (packet &sl)
 {
   if (destroyed ())
     return;
-  if (sl.length () >= MAXSOCKBUF)
+  if (sl.length () > MAXSOCKBUF)
     {
       LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", sl.length ());
       /* Almost certainly we've overflowed a buffer, so quit now to make
        * it easier to debug.
        */
   va_end (ap);
   send_packet (sl);
 }
-void
+// returns true when the message needs special (read: perl) treatment
-client::send_drawinfo (const char *msg, int flags)
+static bool
-{
+msg_is_special (const char *msg)
-  send_packet_printf ("drawinfo %d %s", flags, msg);
+{
+  return msg [strcspn (msg, "<[&\n")];
 }
 void
 client::send_msg (int color, const char *type, const char *msg)
 {
+  if (!msg || !type) // it can happen (for example, missing attack messages cause this)
+    {
+      LOG (logBacktrace | llevError, "send_msg(%d,%p,%p) called with NULL msg or type.\n", color, type, msg);
+      return;
+    }
+  int len = strlen (msg);
+  if (msg_is_special (msg) || (type [0] == 'c' && type [1] == '/') || len > (MAXSOCKBUF - 128))
+    cfperl_send_msg (this, color, type, msg);
-  if (can_msg)
+  else if (can_msg)
-    send_packet_printf ("msg %d %s %s", color, type, msg);
+    send_packet_printf ("msg %d %s %s", color & NDI_CLIENT_MASK, type, msg);
   else if (color < 0)
     return; // client cannot handle this
-  else if (strchr (msg, '<') || strchr (msg, '&'))
-    {
-      //TODO: should escape/modify to old syntax
-      send_packet_printf ("drawinfo %d %s", color, msg);
-    }
   else
-    send_packet_printf ("drawinfo %d %s", color, msg);
+    send_packet_printf ("drawinfo %d %s", color & NDI_COLOR_MASK, msg);
+}
+void
+client::send_drawinfo (const char *msg, int flags)
+{
+  send_msg (flags, "log", msg);
 }
 /***********************************************************************
  *
  * packet functions/utilities
     return reset ();
   cur += len;
 }
-/******************************************************************************
- *
- * statistics logging functions.
- *
- ******************************************************************************/
-#ifdef CS_LOGSTATS
-/* cst_tot is for the life of the server, cst_last is for the last series of
- * stats
- */
-CS_Stats cst_tot, cst_lst;
-/**
- * Writes out the gathered stats.  We clear cst_lst.
- */
-void
-write_cs_stats (void)
-{
-  time_t now = time (NULL);
-  /* If no connections recently, don't both to log anything */
-  if (cst_lst.ibytes == 0 && cst_lst.obytes == 0)
-    return;
-  /* CSSTAT is put in so scripts can easily find the line */
-  LOG (llevInfo, "CSSTAT: %.16s tot %d %d %d %d inc %d %d %d %d\n",
-       ctime (&now), cst_tot.ibytes, cst_tot.obytes, cst_tot.max_conn,
-       now - cst_tot.time_start, cst_lst.ibytes, cst_lst.obytes, cst_lst.max_conn, now - cst_lst.time_start);
-  cst_lst.ibytes = 0;
-  cst_lst.obytes = 0;
-  cst_lst.time_start = now;
-}
-#endif

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/socket/lowlevel.C (file contents): Revision 1.42 by root, Mon May 28 21:22:26 2007 UTC vs. Revision 1.59 by root, Sun Sep 30 20:22:25 2007 UTC

Diff Legend

Comparing deliantra/server/socket/lowlevel.C (file contents):
Revision 1.42 by root, Mon May 28 21:22:26 2007 UTC vs.
Revision 1.59 by root, Sun Sep 30 20:22:25 2007 UTC