--- deliantra/server/socket/lowlevel.C 2007/07/12 19:36:58 1.50
+++ deliantra/server/socket/lowlevel.C 2007/11/14 08:09:46 1.63
@@ -1,10 +1,10 @@
/*
- * This file is part of Crossfire TRT, the Roguelike Realtime MORPG.
+ * This file is part of Deliantra, the Roguelike Realtime MMORPG.
*
- * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team
+ * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
* Copyright (©) 1992,2007 Frank Tore Johansen
*
- * Crossfire TRT is free software: you can redistribute it and/or modify
+ * Deliantra is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
@@ -17,7 +17,7 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see .
*
- * The authors can be reached via e-mail to
+ * The authors can be reached via e-mail to
*/
using namespace std;
@@ -33,14 +33,6 @@
# include
#endif
-#define HAVE_SIOCOUTQ 1 //TODO configure.ac support
-#if HAVE_SIOCOUTQ
-# include
-#endif
-
-// disconnect a socket after this many seconds without an ack
-#define SOCKET_TIMEOUT 8.
-
// force a packet when idle for more than this many seconds,
// forcing an ack regularly.
#define IDLE_PING 2.
@@ -51,45 +43,6 @@
if (destroyed ())
return;
-# if HAVE_SIOCOUTQ
- {
- int value;
-
- if (!ioctl (fd, SIOCOUTQ, &value))
- outq = value;
- }
-# endif
-
-#if HAVE_TCP_INFO
- // check about once per second, spread evenly over all clients
- // do this only when player is active
- if (!((pticks + fd) & 7) && pl && pl->active)
- {
- // check time of last ack, and, if too old, kill connection
- struct tcp_info tcpi;
- socklen_t len = sizeof (tcpi);
-
- if (!getsockopt (fd, IPPROTO_TCP, TCP_INFO, &tcpi, &len) && len == sizeof (tcpi))
- {
- if (tcpi.tcpi_snd_mss)
- mss = tcpi.tcpi_snd_mss;
-
- rtt = tcpi.tcpi_rtt;
- rttvar = tcpi.tcpi_rttvar;
-
- if (tcpi.tcpi_last_ack_recv > int (SOCKET_TIMEOUT * 1000))
- {
- send_msg (NDI_RED, "connection-timeout", "safety disconnect due to tcp/ip timeout (no packets received)");
- write_outputbuffer ();
-
- LOG (llevDebug, "connection on fd %d closed due to ack timeout (%u/%u/%u)\n", fd,
- (unsigned)tcpi.tcpi_last_ack_recv, (unsigned)tcpi.tcpi_last_data_sent, (unsigned)tcpi.tcpi_unacked);
- destroy ();
- }
- }
- }
-#endif
-
/**
* Writes data to socket.
*
@@ -111,7 +64,7 @@
return;
}
- if (socket_ev.poll () & PE_W)
+ if (socket_ev.poll () & EV_WRITE)
return;
last_send = NOW;
@@ -148,7 +101,7 @@
else if (errno == EAGAIN)
{
// delay till ready
- socket_ev.poll (socket_ev.poll () | PE_W);
+ socket_ev.poll (socket_ev.poll () | EV_WRITE);
socket_ev.start ();
return;
}
@@ -160,7 +113,7 @@
}
}
- socket_ev.poll (socket_ev.poll () & ~PE_W);
+ socket_ev.poll (socket_ev.poll () & ~EV_WRITE);
}
/******************************************************************************
@@ -181,7 +134,7 @@
if (inbuf_len == sizeof (inbuf))
{
- send_packet_printf ("drawinfo %d input buffer overflow - closing connection.", NDI_RED);
+ send_packet_printf ("drawinfo %d input buffer overflow - closing connection.", NDI_RED | NDI_REPLY);
destroy ();
return -1;
}
@@ -265,10 +218,11 @@
len -= 6;
}
- if (len > 4 && !strncmp (data, "say " , 4))
- return true;
- if (len > 5 && !strncmp (data, "chat ", 5))
- return true;
+ if (len > 4 && data [3] == ' ' && !strncmp (data, "say " , 4)) return true;
+ if (len > 5 && data [4] == ' ' && !strncmp (data, "chat " , 5)) return true;
+ if (len > 6 && data [5] == ' ' && !strncmp (data, "shout ", 6)) return true;
+
+ if (len == 7 && !strcmp (data, "suicide")) return true;
return false;
}
@@ -285,7 +239,7 @@
((void (*)(char *, int, client *))pkt->cb)((char *)data, datalen, this);
}
else
- send_packet_printf ("drawinfo %d ERROR: you cannot execute '%s' now.", NDI_RED, pkt->name);
+ send_packet_printf ("drawinfo %d ERROR: you cannot execute '%s' now.", NDI_RED | NDI_REPLY, pkt->name);
}
bool
@@ -336,19 +290,19 @@
}
// If we get here, we didn't find a valid command.
- send_packet_printf ("drawinfo %d ERROR: command '%s' not supported.", NDI_RED, (char *)inbuf + 2);
+ send_packet_printf ("drawinfo %d ERROR: command '%s' not supported.", NDI_RED | NDI_REPLY, (char *)inbuf + 2);
next_packet:
skip_packet (pkt_len);
// input buffer has space again
- socket_ev.poll (socket_ev.poll () | PE_R);
+ socket_ev.poll (socket_ev.poll () | EV_READ);
return true;
}
// callback called when socket is either readable or writable
void
-client::socket_cb (iow &w, int got)
+client::socket_cb (iow &w, int revents)
{
//TODO remove when we have better socket cleanup logic
if (destroyed ())
@@ -357,15 +311,15 @@
return;
}
- if (got & PE_W)
+ if (revents & EV_WRITE)
{
write_outputbuffer ();
if (!outputbuffer.len)
- socket_ev.poll (socket_ev.poll () & ~PE_W);
+ socket_ev.poll (socket_ev.poll () & ~EV_WRITE);
}
- if (got & PE_R)
+ if (revents & EV_READ)
{
//TODO: rate-limit tcp connection in better ways, important
@@ -374,7 +328,7 @@
if (!amount)
{
// input buffer full
- socket_ev.poll (socket_ev.poll () & ~PE_R);
+ socket_ev.poll (socket_ev.poll () & ~EV_READ);
return;
}
@@ -400,21 +354,17 @@
{
inbuf_len += amount;
- cmd_ev.start ();
+ if (handle_packet ())
+ {
+ while (handle_packet ())
+ ;
+
+ flush ();
+ }
}
}
}
-// called whenever we have additional commands to process
-void
-client::cmd_cb (iw &w)
-{
- if (handle_packet ())
- w.start ();
- else
- flush ();
-}
-
/*******************************************************************************
*
* Start of write related routines.
@@ -478,7 +428,7 @@
if (destroyed ())
return;
- if (sl.length () >= MAXSOCKBUF)
+ if (sl.length () > MAXSOCKBUF)
{
LOG (llevError, "Trying to send a buffer beyond properly size, len =%d\n", sl.length ());
/* Almost certainly we've overflowed a buffer, so quit now to make
@@ -536,14 +486,22 @@
void
client::send_msg (int color, const char *type, const char *msg)
{
- if (msg_is_special (msg))
+ if (!msg || !type) // it can happen (for example, missing attack messages cause this)
+ {
+ LOG (logBacktrace | llevError, "send_msg(%d,%p,%p) called with NULL msg or type.\n", color, type, msg);
+ return;
+ }
+
+ int len = strlen (msg);
+
+ if (msg_is_special (msg) || (type [0] == 'c' && type [1] == '/') || len > (MAXSOCKBUF - 128))
cfperl_send_msg (this, color, type, msg);
else if (can_msg)
- send_packet_printf ("msg %d %s %s", color, type, msg);
+ send_packet_printf ("msg %d %s %s", color & NDI_CLIENT_MASK, type, msg);
else if (color < 0)
return; // client cannot handle this
else
- send_packet_printf ("drawinfo %d %s", color, msg);
+ send_packet_printf ("drawinfo %d %s", color & NDI_COLOR_MASK, msg);
}
void