ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.26 by pippijn, Mon Dec 11 19:46:47 2006 UTC vs.
Revision 1.66 by root, Thu Feb 15 04:04:23 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (C) 2001 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 23 */
23 24
24/** 25/**
25 * \file 26 * \file
26 * Client handling. 27 * Client handling.
27 * 28 *
… …
38 * esrv_map_new starts updating the map 39 * esrv_map_new starts updating the map
39 * 40 *
40 * esrv_map_setbelow allows filling in all of the faces for the map. 41 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now. 42 * if a face has not already been sent to the client, it is sent now.
42 * 43 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations
45 *
46 * esrv_map_doneredraw finishes the map update, and ships across the
47 * map updates.
48 *
49 */ 44 */
50 45
51#include <global.h> 46#include <global.h>
52#include <sproto.h> 47#include <sproto.h>
53 48
54#include <newclient.h>
55#include <newserver.h>
56#include <living.h> 49#include <living.h>
57#include <commands.h> 50#include <commands.h>
58 51
59/* This block is basically taken from socket.c - I assume if it works there, 52/* This block is basically taken from socket.c - I assume if it works there,
60 * it should work here. 53 * it should work here.
… …
63#include <sys/time.h> 56#include <sys/time.h>
64#include <sys/socket.h> 57#include <sys/socket.h>
65#include <netinet/in.h> 58#include <netinet/in.h>
66#include <netdb.h> 59#include <netdb.h>
67 60
68#ifdef HAVE_UNISTD_H
69# include <unistd.h> 61#include <unistd.h>
70#endif
71
72#ifdef HAVE_SYS_TIME_H
73# include <sys/time.h> 62#include <sys/time.h>
74#endif
75 63
76#include "sounds.h" 64#include "sounds.h"
77 65
78/** 66/**
79 * This table translates the attack numbers as used within the 67 * This table translates the attack numbers as used within the
… …
96 -1, /* life stealing */ 84 -1, /* life stealing */
97 -1 /* Disease - not fully done yet */ 85 -1 /* Disease - not fully done yet */
98}; 86};
99 87
100static void 88static void
101socket_map_scroll (NewSocket * ns, int dx, int dy) 89socket_map_scroll (client *ns, int dx, int dy)
102{ 90{
103 struct Map newmap; 91 struct Map newmap;
104 int x, y, mx, my; 92 int x, y, mx, my;
105 93
106 {
107 char buf[MAXSOCKBUF];
108
109 sprintf (buf, "map_scroll %d %d", dx, dy); 94 ns->send_packet_printf ("map_scroll %d %d", dx, dy);
110 Write_String_To_Socket (ns, buf, strlen (buf));
111 }
112 95
113 /* If we are using the Map1aCmd, we may in fact send 96 /* If we are using the Map1aCmd, we may in fact send
114 * head information that is outside the viewable map. 97 * head information that is outside the viewable map.
115 * So set the mx,my to the max value we want to 98 * So set the mx,my to the max value we want to
116 * look for. Removed code to do so - it caused extra 99 * look for. Removed code to do so - it caused extra
… …
156} 139}
157 140
158static void 141static void
159clear_map (player *pl) 142clear_map (player *pl)
160{ 143{
161 NewSocket & socket = pl->socket;
162
163 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 144 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
164 145
165 if (socket.newmapcmd == 1) 146 if (pl->ns->newmapcmd == 1)
166 Write_String_To_Socket (&socket, "newmap", 6); 147 pl->ns->send_packet ("newmap");
167 148
168 socket.update_look = 1; 149 pl->ns->floorbox_reset ();
169 socket.look_position = 0;
170} 150}
171 151
172/** check for map change and send new map data */ 152/** check for map/region change and send new map data */
173static void 153static void
174check_map_change (player *pl) 154check_map_change (player *pl)
175{ 155{
176 NewSocket & socket = pl->socket; 156 client &socket = *pl->ns;
177 object *ob = pl->ob; 157 object *ob = pl->ob;
178 char buf[MAX_BUF]; /* eauugggh */ 158 char buf[MAX_BUF]; /* eauugggh */
179 159
180 if (socket.current_map != ob->map) 160 if (socket.current_map != ob->map)
181 { 161 {
… …
197 flags |= 4; 177 flags |= 4;
198 if (ob->map->tile_path[3]) 178 if (ob->map->tile_path[3])
199 flags |= 8; 179 flags |= 8;
200 180
201 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s", 181 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s",
202 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 182 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, &ob->map->path);
203 } 183 }
204 else 184 else
205 snprintf (buf, MAX_BUF, "mapinfo current"); 185 snprintf (buf, MAX_BUF, "mapinfo current");
206 186
207 Write_String_To_Socket (&socket, buf, strlen (buf)); 187 socket.send_packet (buf);
208 } 188 }
209 } 189 }
210 else if (socket.current_x != ob->x || socket.current_y != ob->y) 190 else if (socket.current_x != ob->x || socket.current_y != ob->y)
211 { 191 {
212 int dx = ob->x - socket.current_x; 192 int dx = ob->x - socket.current_x;
… …
215 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8)) 195 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
216 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows 196 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
217 else 197 else
218 { 198 {
219 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 199 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
220 socket.update_look = 1; 200 socket.floorbox_reset ();
221 socket.look_position = 0;
222 } 201 }
223 } 202 }
224 203
225 socket.current_x = ob->x; 204 socket.current_x = ob->x;
226 socket.current_y = ob->y; 205 socket.current_y = ob->y;
206
207 region *reg = ob->region ();
208 if (socket.current_region != reg)
209 {
210 socket.current_region = reg;
211 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
212 }
213}
214
215/**
216 * RequestInfo is sort of a meta command. There is some specific
217 * request of information, but we call other functions to provide
218 * that information.
219 */
220void
221RequestInfo (char *buf, int len, client * ns)
222{
223 char *params = NULL, *cp;
224
225 /* No match */
226 char bigbuf[MAX_BUF];
227 int slen;
228
229 /* Set up replyinfo before we modify any of the buffers - this is used
230 * if we don't find a match.
231 */
232 strcpy (bigbuf, "replyinfo ");
233 slen = strlen (bigbuf);
234 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
235
236 /* find the first space, make it null, and update the
237 * params pointer.
238 */
239 for (cp = buf; *cp != '\0'; cp++)
240 if (*cp == ' ')
241 {
242 *cp = '\0';
243 params = cp + 1;
244 break;
245 }
246
247 if (!strcmp (buf, "image_info"))
248 send_image_info (ns, params);
249 else if (!strcmp (buf, "image_sums"))
250 send_image_sums (ns, params);
251 else if (!strcmp (buf, "skill_info"))
252 send_skill_info (ns, params);
253 else if (!strcmp (buf, "spell_paths"))
254 send_spell_paths (ns, params);
255 else
256 ns->send_packet (bigbuf, len);
227} 257}
228 258
229void 259void
230ExtCmd (char *buf, int len, player *pl) 260ExtCmd (char *buf, int len, player *pl)
231{ 261{
232 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len)); 262 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
263}
264
265void
266ExtiCmd (char *buf, int len, client *ns)
267{
268 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
233} 269}
234 270
235void 271void
236MapInfoCmd (char *buf, int len, player *pl) 272MapInfoCmd (char *buf, int len, player *pl)
237{ 273{
… …
252 buf += 8; 288 buf += 8;
253 289
254 // initial map and its origin 290 // initial map and its origin
255 maptile *map = pl->ob->map; 291 maptile *map = pl->ob->map;
256 sint16 dx, dy; 292 sint16 dx, dy;
257 int mapx = pl->socket.mapx / 2 - pl->ob->x; 293 int mapx = pl->ns->mapx / 2 - pl->ob->x;
258 int mapy = pl->socket.mapy / 2 - pl->ob->y; 294 int mapy = pl->ns->mapy / 2 - pl->ob->y;
259 int max_distance = 8; // limit maximum path length to something generous 295 int max_distance = 8; // limit maximum path length to something generous
260 296
261 while (*buf && map && max_distance) 297 while (*buf && map && max_distance)
262 { 298 {
263 int dir = *buf++; 299 int dir = *buf++;
264 300
265 switch (dir) 301 switch (dir)
266 { 302 {
267 case '1': 303 case '1':
268 dx = 0; 304 dx = 0;
269 dy = -1; 305 dy = -1;
270 map = get_map_from_coord (map, &dx, &dy); 306 map = map->xy_find (dx, dy);
271 map && (mapy -= map->height); 307 map && (mapy -= map->height);
272 break; 308 break;
273 case '2': 309 case '2':
274 mapx += map->width; 310 mapx += map->width;
275 dx = map->width; 311 dx = map->width;
276 dy = 0; 312 dy = 0;
277 map = get_map_from_coord (map, &dx, &dy); 313 map = map->xy_find (dx, dy);
278 break; 314 break;
279 case '3': 315 case '3':
280 mapy += map->height; 316 mapy += map->height;
281 dx = 0; 317 dx = 0;
282 dy = map->height; 318 dy = map->height;
283 map = get_map_from_coord (map, &dx, &dy); 319 map = map->xy_find (dx, dy);
284 break; 320 break;
285 case '4': 321 case '4':
286 dx = -1; 322 dx = -1;
287 dy = 0; 323 dy = 0;
288 map = get_map_from_coord (map, &dx, &dy); 324 map = map->xy_find (dx, dy);
289 map && (mapx -= map->width); 325 map && (mapx -= map->width);
290 break; 326 break;
291 } 327 }
292 328
293 --max_distance; 329 --max_distance;
294 } 330 }
295 331
… …
306 if (map->tile_path[2]) 342 if (map->tile_path[2])
307 flags |= 4; 343 flags |= 4;
308 if (map->tile_path[3]) 344 if (map->tile_path[3])
309 flags |= 8; 345 flags |= 8;
310 346
311 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, map->path); 347 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
312 } 348 }
313 else 349 else
314 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 350 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token);
315 } 351 }
316 else 352 else
317 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 353 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
318 354
319 Write_String_To_Socket (&pl->socket, bigbuf, strlen (bigbuf)); 355 pl->ns->send_packet (bigbuf);
320} 356}
321 357
322/** This is the Setup cmd - easy first implementation */ 358/** This is the Setup cmd - easy first implementation */
323void 359void
324SetUp (char *buf, int len, NewSocket * ns) 360SetUp (char *buf, int len, client * ns)
325{ 361{
326 int s, slen; 362 int s, slen;
327 char *cmd, *param, cmdback[HUGE_BUF]; 363 char *cmd, *param, cmdback[HUGE_BUF];
328 364
329 /* run through the cmds of setup 365 /* run through the cmds of setup
… …
331 * 367 *
332 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown 368 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
333 * The client then must sort this out 369 * The client then must sort this out
334 */ 370 */
335 371
336 LOG (llevInfo, "Get SetupCmd:: %s\n", buf); 372 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
373
337 strcpy (cmdback, "setup"); 374 strcpy (cmdback, "setup");
338 for (s = 0; s < len;) 375 for (s = 0; s < len; )
339 { 376 {
340
341 cmd = &buf[s]; 377 cmd = &buf[s];
342 378
343 /* find the next space, and put a null there */ 379 /* find the next space, and put a null there */
344 for (; buf[s] && buf[s] != ' '; s++); 380 for (; buf[s] && buf[s] != ' '; s++)
381 ;
382
345 buf[s++] = 0; 383 buf[s++] = 0;
384
346 while (buf[s] == ' ') 385 while (buf[s] == ' ')
347 s++; 386 s++;
348 387
349 if (s >= len) 388 if (s >= len)
350 break; 389 break;
351 390
352 param = &buf[s]; 391 param = &buf[s];
353 392
354 for (; buf[s] && buf[s] != ' '; s++); 393 for (; buf[s] && buf[s] != ' '; s++)
394 ;
395
355 buf[s++] = 0; 396 buf[s++] = 0;
397
356 while (buf[s] == ' ') 398 while (buf[s] == ' ')
357 s++; 399 s++;
358 400
359 slen = strlen (cmdback); 401 slen = strlen (cmdback);
360 safe_strcat (cmdback, " ", &slen, HUGE_BUF); 402 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
… …
365 { 407 {
366 ns->sound = atoi (param); 408 ns->sound = atoi (param);
367 safe_strcat (cmdback, param, &slen, HUGE_BUF); 409 safe_strcat (cmdback, param, &slen, HUGE_BUF);
368 } 410 }
369 else if (!strcmp (cmd, "exp64")) 411 else if (!strcmp (cmd, "exp64"))
370 {
371 ns->exp64 = atoi (param);
372 safe_strcat (cmdback, param, &slen, HUGE_BUF); 412 safe_strcat (cmdback, param, &slen, HUGE_BUF);
373 }
374 else if (!strcmp (cmd, "spellmon")) 413 else if (!strcmp (cmd, "spellmon"))
375 { 414 {
376 ns->monitor_spells = atoi (param); 415 ns->monitor_spells = atoi (param);
377 safe_strcat (cmdback, param, &slen, HUGE_BUF); 416 safe_strcat (cmdback, param, &slen, HUGE_BUF);
378 } 417 }
… …
521 * report a failure to the client. 560 * report a failure to the client.
522 */ 561 */
523 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF); 562 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
524 } 563 }
525 } /* for processing all the setup commands */ 564 } /* for processing all the setup commands */
565
526 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback); 566 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
527 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 567 ns->send_packet (cmdback);
528} 568}
529 569
530/** 570/**
531 * The client has requested to be added to the game. 571 * The client has requested to be added to the game.
532 * This is what takes care of it. We tell the client how things worked out. 572 * This is what takes care of it. We tell the client how things worked out.
533 * I am not sure if this file is the best place for this function. however, 573 * I am not sure if this file is the best place for this function. however,
534 * it either has to be here or init_sockets needs to be exported. 574 * it either has to be here or init_sockets needs to be exported.
535 */ 575 */
536void 576void
537AddMeCmd (char *buf, int len, NewSocket * ns) 577AddMeCmd (char *buf, int len, client * ns)
538{ 578{
539 Settings oldsettings; 579 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
540
541 oldsettings = settings;
542 if (ns->status != Ns_Add || add_player (ns))
543 {
544 Write_String_To_Socket (ns, "addme_failed", 12);
545 }
546 else
547 {
548 /* Basically, the add_player copies the socket structure into
549 * the player structure, so this one (which is from init_sockets)
550 * is not needed anymore. The write below should still work, as the
551 * stuff in ns is still relevant.
552 */
553 Write_String_To_Socket (ns, "addme_success", 13);
554 socket_info.nconns--;
555 ns->status = Ns_Avail;
556 }
557 settings = oldsettings;
558} 580}
559 581
560/** Reply to ExtendedInfos command */ 582/** Reply to ExtendedInfos command */
561void 583void
562ToggleExtendedInfos (char *buf, int len, NewSocket * ns) 584ToggleExtendedInfos (char *buf, int len, client * ns)
563{ 585{
564 char cmdback[MAX_BUF]; 586 char cmdback[MAX_BUF];
565 char command[50]; 587 char command[50];
566 int info, nextinfo; 588 int info, nextinfo;
567 589
… …
605 { 627 {
606 strcat (cmdback, " "); 628 strcat (cmdback, " ");
607 strcat (cmdback, "smoothing"); 629 strcat (cmdback, "smoothing");
608 } 630 }
609 631
610 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 632 ns->send_packet (cmdback);
611} 633}
612 634
613/* 635/*
614#define MSG_TYPE_BOOK 1 636#define MSG_TYPE_BOOK 1
615#define MSG_TYPE_CARD 2 637#define MSG_TYPE_CARD 2
… …
618#define MSG_TYPE_MONUMENT 5 640#define MSG_TYPE_MONUMENT 5
619#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 641#define MSG_TYPE_SCRIPTED_DIALOG 6*/
620 642
621/** Reply to ExtendedInfos command */ 643/** Reply to ExtendedInfos command */
622void 644void
623ToggleExtendedText (char *buf, int len, NewSocket * ns) 645ToggleExtendedText (char *buf, int len, client * ns)
624{ 646{
625 char cmdback[MAX_BUF]; 647 char cmdback[MAX_BUF];
626 char temp[10]; 648 char temp[10];
627 char command[50]; 649 char command[50];
628 int info, nextinfo, i, flag; 650 int info, nextinfo, i, flag;
… …
668 strcat (cmdback, " "); 690 strcat (cmdback, " ");
669 snprintf (temp, sizeof (temp), "%d", i); 691 snprintf (temp, sizeof (temp), "%d", i);
670 strcat (cmdback, temp); 692 strcat (cmdback, temp);
671 } 693 }
672 694
673 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 695 ns->send_packet (cmdback);
674} 696}
675 697
676/** 698/**
677 * A lot like the old AskSmooth (in fact, now called by AskSmooth). 699 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
678 * Basically, it makes no sense to wait for the client to request a 700 * Basically, it makes no sense to wait for the client to request a
679 * a piece of data from us that we know the client wants. So 701 * a piece of data from us that we know the client wants. So
680 * if we know the client wants it, might as well push it to the 702 * if we know the client wants it, might as well push it to the
681 * client. 703 * client.
682 */ 704 */
683static void 705static void
684SendSmooth (NewSocket * ns, uint16 face) 706SendSmooth (client *ns, uint16 face)
685{ 707{
686 uint16 smoothface; 708 uint16 smoothface;
687 unsigned char reply[MAX_BUF];
688 SockList sl;
689 709
690 /* If we can't find a face, return and set it so we won't try to send this 710 /* If we can't find a face, return and set it so we won't try to send this
691 * again. 711 * again.
692 */ 712 */
693 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface))) 713 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
… …
701 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE)) 721 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
702 esrv_send_face (ns, smoothface, 0); 722 esrv_send_face (ns, smoothface, 0);
703 723
704 ns->faces_sent[face] |= NS_FACESENT_SMOOTH; 724 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
705 725
706 sl.buf = reply; 726 packet sl ("smooth");
707 strcpy ((char *) sl.buf, "smooth "); 727
708 sl.len = strlen ((char *) sl.buf); 728 sl << uint16 (face)
709 SockList_AddShort (&sl, face); 729 << uint16 (smoothface);
710 SockList_AddShort (&sl, smoothface); 730
711 Send_With_Handling (ns, &sl); 731 ns->send_packet (sl);
712} 732}
713 733
714 /** 734 /**
715 * Tells client the picture it has to use 735 * Tells client the picture it has to use
716 * to smooth a picture number given as argument. 736 * to smooth a picture number given as argument.
717 */ 737 */
718void 738void
719AskSmooth (char *buf, int len, NewSocket * ns) 739AskSmooth (char *buf, int len, client *ns)
720{ 740{
721 uint16 facenbr; 741 SendSmooth (ns, atoi (buf));
722
723 facenbr = atoi (buf);
724 SendSmooth (ns, facenbr);
725} 742}
726
727
728
729
730 743
731/** 744/**
732 * This handles the general commands from the client (ie, north, fire, cast, 745 * This handles the general commands from the client (ie, north, fire, cast,
733 * etc.) 746 * etc.)
734 */ 747 */
735void 748void
736PlayerCmd (char *buf, int len, player *pl) 749PlayerCmd (char *buf, int len, player *pl)
737{ 750{
738
739 /* The following should never happen with a proper or honest client.
740 * Therefore, the error message doesn't have to be too clear - if
741 * someone is playing with a hacked/non working client, this gives them
742 * an idea of the problem, but they deserve what they get
743 */
744 if (pl->state != ST_PLAYING)
745 {
746 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
747 return;
748 }
749 /* Check if there is a count. In theory, a zero count could also be 751 /* Check if there is a count. In theory, a zero count could also be
750 * sent, so check for that also. 752 * sent, so check for that also.
751 */ 753 */
752 if (atoi (buf) || buf[0] == '0') 754 if (atoi (buf) || buf[0] == '0')
753 { 755 {
754 pl->count = atoi ((char *) buf); 756 pl->count = atoi ((char *) buf);
757
755 buf = strchr (buf, ' '); /* advance beyond the numbers */ 758 buf = strchr (buf, ' '); /* advance beyond the numbers */
756 if (!buf) 759 if (!buf)
757 {
758#ifdef ESRV_DEBUG
759 LOG (llevDebug, "PlayerCmd: Got count but no command.\n");
760#endif
761 return; 760 return;
762 } 761
763 buf++; 762 buf++;
764 } 763 }
765 /* This should not happen anymore. */ 764
766 if (pl->ob->speed_left < -1.0)
767 {
768 LOG (llevError, "Player has negative time - shouldn't do command.\n");
769 }
770 /* In c_new.c */
771 execute_newserver_command (pl->ob, (char *) buf); 765 execute_newserver_command (pl->ob, (char *) buf);
766
772 /* Perhaps something better should be done with a left over count. 767 /* Perhaps something better should be done with a left over count.
773 * Cleaning up the input should probably be done first - all actions 768 * Cleaning up the input should probably be done first - all actions
774 * for the command that issued the count should be done before any other 769 * for the command that issued the count should be done before any other
775 * commands. 770 * commands.
776 */ 771 */
777
778 pl->count = 0; 772 pl->count = 0;
779
780} 773}
781 774
782 775
783/** 776/**
784 * This handles the general commands from the client (ie, north, fire, cast, 777 * This handles the general commands from the client (ie, north, fire, cast,
785 * etc.). It is a lot like PlayerCmd above, but is called with the 778 * etc.). It is a lot like PlayerCmd above, but is called with the
786 * 'ncom' method which gives more information back to the client so it 779 * 'ncom' method which gives more information back to the client so it
787 * can throttle. 780 * can throttle.
788 */ 781 */
789void 782void
790NewPlayerCmd (uint8 * buf, int len, player *pl) 783NewPlayerCmd (char *buf, int len, player *pl)
791{ 784{
792 int time, repeat;
793 short packet;
794 unsigned char command[MAX_BUF];
795 SockList sl;
796
797 if (len < 7) 785 if (len <= 6)
798 { 786 {
799 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 787 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
800 return; 788 return;
801 } 789 }
802 790
803 packet = GetShort_String (buf); 791 uint16 cmdid = net_uint16 ((uint8 *)buf);
804 repeat = GetInt_String (buf + 2); 792 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
793
805 /* -1 is special - no repeat, but don't update */ 794 /* -1 is special - no repeat, but don't update */
806 if (repeat != -1) 795 if (repeat != -1)
807 {
808 pl->count = repeat; 796 pl->count = repeat;
809 }
810 if ((len - 4) >= MAX_BUF)
811 len = MAX_BUF - 5;
812 797
813 strncpy ((char *) command, (char *) buf + 6, len - 4); 798 buf += 6; //len -= 6;
814 command[len - 4] = '\0';
815 799
816 /* The following should never happen with a proper or honest client.
817 * Therefore, the error message doesn't have to be too clear - if
818 * someone is playing with a hacked/non working client, this gives them
819 * an idea of the problem, but they deserve what they get
820 */
821 if (pl->state != ST_PLAYING)
822 {
823 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
824 return;
825 }
826
827 /* This should not happen anymore. */
828 if (pl->ob->speed_left < -1.0)
829 {
830 LOG (llevError, "Player has negative time - shouldn't do command.\n");
831 }
832 /* In c_new.c */
833 execute_newserver_command (pl->ob, (char *) command); 800 execute_newserver_command (pl->ob, buf);
801
834 /* Perhaps something better should be done with a left over count. 802 /* Perhaps something better should be done with a left over count.
835 * Cleaning up the input should probably be done first - all actions 803 * Cleaning up the input should probably be done first - all actions
836 * for the command that issued the count should be done before any other 804 * for the command that issued the count should be done before any other
837 * commands. 805 * commands.
838 */ 806 */
839 pl->count = 0; 807 pl->count = 0;
840 808
809 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
810 int time = fabs (pl->ob->speed) < 0.001
811 ? time = MAX_TIME * 100
812 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
813
841 /* Send confirmation of command execution now */ 814 /* Send confirmation of command execution now */
842 sl.buf = command; 815 packet sl ("comc");
843 strcpy ((char *) sl.buf, "comc "); 816 sl << uint16 (cmdid) << uint32 (time);
844 sl.len = 5; 817 pl->ns->send_packet (sl);
845 SockList_AddShort (&sl, packet);
846 if (FABS (pl->ob->speed) < 0.001)
847 time = MAX_TIME * 100;
848 else
849 time = (int) (MAX_TIME / FABS (pl->ob->speed));
850 SockList_AddInt (&sl, time);
851 Send_With_Handling (&pl->socket, &sl);
852} 818}
853
854 819
855/** This is a reply to a previous query. */ 820/** This is a reply to a previous query. */
856void 821void
857ReplyCmd (char *buf, int len, player *pl) 822ReplyCmd (char *buf, int len, client *ns)
858{ 823{
824 if (ns->state == ST_CUSTOM)
825 {
826 INVOKE_CLIENT (REPLY, ns, ARG_DATA (buf, len));
827 return;
828 }
829
830 if (!ns->pl)
831 return; //TODO: depends on the exact reply we are after
832 //TODO: but right now, we always have a ns->pl
833
834 player *pl = ns->pl;
835
859 /* This is to synthesize how the data would be stored if it 836 /* This is to synthesize how the data would be stored if it
860 * was normally entered. A bit of a hack, and should be cleaned up 837 * was normally entered. A bit of a hack, and should be cleaned up
861 * once all the X11 code is removed from the server. 838 * once all the X11 code is removed from the server.
862 * 839 *
863 * We pass 13 to many of the functions because this way they 840 * We pass 13 to many of the functions because this way they
864 * think it was the carriage return that was entered, and the 841 * think it was the carriage return that was entered, and the
865 * function then does not try to do additional input. 842 * function then does not try to do additional input.
866 */ 843 */
867 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf); 844 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
868 845
869 /* this avoids any hacking here */ 846 /* this avoids any hacking here */
870 847
871 switch (pl->state) 848 switch (ns->state)
872 { 849 {
873 case ST_PLAYING: 850 case ST_PLAYING:
874 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 851 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
875 break; 852 break;
876 853
877 case ST_PLAY_AGAIN:
878 /* We can check this for return value (2==quit). Maybe we
879 * should, and do something appropriate?
880 */
881 receive_play_again (pl->ob, buf[0]);
882 break;
883
884 case ST_ROLL_STAT:
885 key_roll_stat (pl->ob, buf[0]);
886 break;
887
888 case ST_CHANGE_CLASS: 854 case ST_CHANGE_CLASS:
889
890 key_change_class (pl->ob, buf[0]); 855 key_change_class (pl->ob, buf[0]);
891 break; 856 break;
892 857
893 case ST_CONFIRM_QUIT:
894 key_confirm_quit (pl->ob, buf[0]);
895 break;
896
897 case ST_CONFIGURE:
898 LOG (llevError, "In client input handling, but into configure state\n");
899 pl->state = ST_PLAYING;
900 break;
901
902 case ST_GET_NAME:
903 receive_player_name (pl->ob, 13);
904 break;
905
906 case ST_GET_PASSWORD:
907 case ST_CONFIRM_PASSWORD:
908 receive_player_password (pl->ob, 13);
909 break;
910
911 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 858 case ST_GET_PARTY_PASSWORD: /* Get password for party */
912 receive_party_password (pl->ob, 13); 859 receive_party_password (pl->ob, 13);
913 break; 860 break;
914 861
915 default: 862 default:
916 LOG (llevError, "Unknown input state: %d\n", pl->state); 863 LOG (llevError, "Unknown input state: %d\n", ns->state);
917 } 864 }
918} 865}
919 866
920/** 867/**
921 * Client tells its version. If there is a mismatch, we close the 868 * Client tells its version. If there is a mismatch, we close the
… …
923 * something older than the server. If we assume the client will be 870 * something older than the server. If we assume the client will be
924 * backwards compatible, having it be a later version should not be a 871 * backwards compatible, having it be a later version should not be a
925 * problem. 872 * problem.
926 */ 873 */
927void 874void
928VersionCmd (char *buf, int len, NewSocket * ns) 875VersionCmd (char *buf, int len, client * ns)
929{ 876{
930 char *cp;
931 char version_warning[256];
932
933 if (!buf) 877 if (!buf)
934 { 878 {
935 LOG (llevError, "CS: received corrupted version command\n"); 879 LOG (llevError, "CS: received corrupted version command\n");
936 return; 880 return;
937 } 881 }
938 882
939 ns->cs_version = atoi (buf); 883 ns->cs_version = atoi (buf);
940 ns->sc_version = ns->cs_version; 884 ns->sc_version = ns->cs_version;
885
886 LOG (llevDebug, "connection from client <%s>\n", buf);
887
888
889 //TODO: should log here just for statistics
890
941 if (VERSION_CS != ns->cs_version) 891 //if (VERSION_CS != ns->cs_version)
942 { 892 // unchecked;
943#ifdef ESRV_DEBUG 893
944 LOG (llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS, ns->cs_version);
945#endif
946 }
947 cp = strchr (buf + 1, ' '); 894 char *cp = strchr (buf + 1, ' ');
948 if (!cp) 895 if (!cp)
949 return; 896 return;
897
950 ns->sc_version = atoi (cp); 898 ns->sc_version = atoi (cp);
899
951 if (VERSION_SC != ns->sc_version) 900 //if (VERSION_SC != ns->sc_version)
952 { 901 // unchecked;
953#ifdef ESRV_DEBUG 902
954 LOG (llevDebug, "CS: scversion mismatch (%d,%d)\n", VERSION_SC, ns->sc_version);
955#endif
956 }
957 cp = strchr (cp + 1, ' '); 903 cp = strchr (cp + 1, ' ');
904
958 if (cp) 905 if (cp)
959 { 906 {
960 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host); 907 assign (ns->version, cp + 1);
961 908
962 snprintf (ns->client, sizeof (ns->client), "%s", cp + 1); 909 if (ns->sc_version < 1026)
963 910 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
964 /* This is first implementation - i skip all beta DX clients with it
965 * Add later stuff here for other clients
966 */
967
968 /* these are old dxclients */
969 /* Version 1024 added support for singular + plural name values -
970 * requiing this minimal value reduces complexity of that code, and it
971 * has been around for a long time.
972 */
973 if (!strcmp (" CF DX CLIENT", cp) || ns->sc_version < 1024)
974 {
975 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
976 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 911 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
977 Write_String_To_Socket (ns, version_warning, strlen (version_warning));
978 }
979
980 } 912 }
981} 913}
982 914
983/** sound related functions. */ 915/** sound related functions. */
984
985void 916void
986SetSound (char *buf, int len, NewSocket * ns) 917SetSound (char *buf, int len, client * ns)
987{ 918{
988 ns->sound = atoi (buf); 919 ns->sound = atoi (buf);
989} 920}
990 921
991/** client wants the map resent */ 922/** client wants the map resent */
992
993void 923void
994MapRedrawCmd (char *buf, int len, player *pl) 924MapRedrawCmd (char *buf, int len, player *pl)
995{ 925{
996
997/* This function is currently disabled; just clearing the map state results in 926/* This function is currently disabled; just clearing the map state results in
998 * display errors. It should clear the cache and send a newmap command. 927 * display errors. It should clear the cache and send a newmap command.
999 * Unfortunately this solution does not work because some client versions send 928 * Unfortunately this solution does not work because some client versions send
1000 * a mapredraw command after receiving a newmap command. 929 * a mapredraw command after receiving a newmap command.
1001 */ 930 */
1002#if 0
1003 /* Okay, this is MAJOR UGLY. but the only way I know how to
1004 * clear the "cache"
1005 */
1006 memset (&pl->socket.lastmap, 0, sizeof (struct Map));
1007 draw_client_map (pl->ob);
1008#endif
1009} 931}
1010 932
1011/** 933/**
1012 * Moves an object (typically, container to inventory). 934 * Moves an object (typically, container to inventory).
1013 * syntax is: move (to) (tag) (nrof) 935 * syntax is: move (to) (tag) (nrof)
… …
1016MoveCmd (char *buf, int len, player *pl) 938MoveCmd (char *buf, int len, player *pl)
1017{ 939{
1018 int vals[3], i; 940 int vals[3], i;
1019 941
1020 /* A little funky here. We only cycle for 2 records, because 942 /* A little funky here. We only cycle for 2 records, because
1021 * we obviously am not going to find a space after the third 943 * we obviously are not going to find a space after the third
1022 * record. Perhaps we should just replace this with a 944 * record. Perhaps we should just replace this with a
1023 * sscanf? 945 * sscanf?
1024 */ 946 */
1025 for (i = 0; i < 2; i++) 947 for (i = 0; i < 2; i++)
1026 { 948 {
1027 vals[i] = atoi (buf); 949 vals[i] = atoi (buf);
950
1028 if (!(buf = strchr (buf, ' '))) 951 if (!(buf = strchr (buf, ' ')))
1029 { 952 {
1030 LOG (llevError, "Incomplete move command: %s\n", buf); 953 LOG (llevError, "Incomplete move command: %s\n", buf);
1031 return; 954 return;
1032 } 955 }
956
1033 buf++; 957 buf++;
1034 } 958 }
959
1035 vals[2] = atoi (buf); 960 vals[2] = atoi (buf);
1036 961
1037/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/ 962/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
1038 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]); 963 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
1039} 964}
1040
1041
1042 965
1043/****************************************************************************** 966/******************************************************************************
1044 * 967 *
1045 * Start of commands the server sends to the client. 968 * Start of commands the server sends to the client.
1046 * 969 *
… …
1049/** 972/**
1050 * Asks the client to query the user. This way, the client knows 973 * Asks the client to query the user. This way, the client knows
1051 * it needs to send something back (vs just printing out a message) 974 * it needs to send something back (vs just printing out a message)
1052 */ 975 */
1053void 976void
1054send_query (NewSocket * ns, uint8 flags, char *text) 977send_query (client *ns, uint8 flags, char *text)
1055{ 978{
1056 char buf[MAX_BUF];
1057
1058 sprintf (buf, "query %d %s", flags, text ? text : ""); 979 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
1059 Write_String_To_Socket (ns, buf, strlen (buf));
1060} 980}
1061 981
1062#define AddIfInt64(Old,New,Type) if (Old != New) {\ 982#define AddIfInt64(Old,New,Type) if (Old != New) {\
1063 Old = New; \ 983 Old = New; \
1064 SockList_AddChar(&sl, Type); \ 984 sl << uint8 (Type) << uint64 (New); \
1065 SockList_AddInt64(&sl, New); \
1066 } 985 }
1067 986
1068#define AddIfInt(Old,New,Type) if (Old != New) {\ 987#define AddIfInt(Old,New,Type) if (Old != New) {\
1069 Old = New; \ 988 Old = New; \
1070 SockList_AddChar(&sl, Type); \ 989 sl << uint8 (Type) << uint32 (New); \
1071 SockList_AddInt(&sl, New); \
1072 } 990 }
1073 991
1074#define AddIfShort(Old,New,Type) if (Old != New) {\ 992#define AddIfShort(Old,New,Type) if (Old != New) {\
1075 Old = New; \ 993 Old = New; \
1076 SockList_AddChar(&sl, Type); \ 994 sl << uint8 (Type) << uint16 (New); \
1077 SockList_AddShort(&sl, New); \
1078 } 995 }
1079 996
1080#define AddIfFloat(Old,New,Type) if (Old != New) {\ 997#define AddIfFloat(Old,New,Type) if (Old != New) {\
1081 Old = New; \ 998 Old = New; \
1082 SockList_AddChar(&sl, Type); \ 999 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \
1083 SockList_AddInt(&sl,(long)(New*FLOAT_MULTI));\
1084 } 1000 }
1085 1001
1086#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 1002#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1087 if (Old) free(Old);\
1088 Old = strdup_local(New);\ 1003 free(Old); Old = strdup (New);\
1089 SockList_AddChar(&sl, Type); \ 1004 sl << uint8 (Type) << data8 (New); \
1090 SockList_AddChar(&sl, ( char )strlen(New)); \
1091 strcpy((char*)sl.buf + sl.len, New); \
1092 sl.len += strlen(New); \
1093 } 1005 }
1094 1006
1095/** 1007/**
1096 * Sends a statistics update. We look at the old values, 1008 * Sends a statistics update. We look at the old values,
1097 * and only send what has changed. Stat mapping values are in newclient.h 1009 * and only send what has changed. Stat mapping values are in newclient.h
… …
1099 * commands for now. 1011 * commands for now.
1100 */ 1012 */
1101void 1013void
1102esrv_update_stats (player *pl) 1014esrv_update_stats (player *pl)
1103{ 1015{
1104 SockList sl;
1105 char buf[MAX_BUF]; 1016 char buf[MAX_BUF];
1106 uint16 flags; 1017 uint16 flags;
1107 1018
1108 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1019 client *ns = pl->ns;
1109 strcpy ((char *) sl.buf, "stats "); 1020 if (!ns)
1110 sl.len = strlen ((char *) sl.buf); 1021 return;
1111 1022
1112 if (pl->ob != NULL) 1023 object *ob = pl->ob;
1113 { 1024 if (!ob)
1025 return;
1026
1027 packet sl ("stats");
1028
1114 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 1029 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1115 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 1030 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1116 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 1031 AddIfShort (ns->last_stats.sp, ob->stats.sp, CS_STAT_SP);
1117 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 1032 AddIfShort (ns->last_stats.maxsp, ob->stats.maxsp, CS_STAT_MAXSP);
1118 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 1033 AddIfShort (ns->last_stats.grace, ob->stats.grace, CS_STAT_GRACE);
1119 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 1034 AddIfShort (ns->last_stats.maxgrace, ob->stats.maxgrace, CS_STAT_MAXGRACE);
1120 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 1035 AddIfShort (ns->last_stats.Str, ob->stats.Str, CS_STAT_STR);
1121 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT);
1122 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW);
1123 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1124 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 1036 AddIfShort (ns->last_stats.Dex, ob->stats.Dex, CS_STAT_DEX);
1125 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 1037 AddIfShort (ns->last_stats.Con, ob->stats.Con, CS_STAT_CON);
1038 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
1039 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
1040 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1126 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 1041 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1127 }
1128 1042
1129 if (pl->socket.exp64)
1130 {
1131 uint8 s;
1132
1133 for (s = 0; s < NUM_SKILLS; s++) 1043 for (int s = 0; s < NUM_SKILLS; s++)
1134 { 1044 if (object *skill = pl->last_skill_ob[s])
1135 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 1045 if (skill->stats.exp != ns->last_skill_exp [s])
1136 { 1046 {
1047 ns->last_skill_exp [s] = skill->stats.exp;
1137 1048
1138 /* Always send along the level if exp changes. This is only 1049 /* Always send along the level if exp changes. This is only
1139 * 1 extra byte, but keeps processing simpler. 1050 * 1 extra byte, but keeps processing simpler.
1140 */ 1051 */
1141 SockList_AddChar (&sl, (char) (s + CS_STAT_SKILLINFO)); 1052 sl << uint8 (s + CS_STAT_SKILLINFO)
1142 SockList_AddChar (&sl, (char) pl->last_skill_ob[s]->level); 1053 << uint8 (skill->level)
1143 SockList_AddInt64 (&sl, pl->last_skill_ob[s]->stats.exp); 1054 << uint64 (skill->stats.exp);
1144 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1145 } 1055 }
1146 }
1147 }
1148 1056
1149 if (pl->socket.exp64)
1150 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) } 1057 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
1151 else
1152 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1153
1154 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 1058 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
1155 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 1059 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
1156 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 1060 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
1157 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 1061 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
1158 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 1062 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED);
1159 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 1063 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
1160 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 1064 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1161 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 1065 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
1066
1162 flags = 0; 1067 flags = 0;
1163 1068
1164 if (pl->fire_on) 1069 if (pl->fire_on)
1165 flags |= SF_FIREON; 1070 flags |= SF_FIREON;
1166 1071
1167 if (pl->run_on) 1072 if (pl->run_on)
1168 flags |= SF_RUNON; 1073 flags |= SF_RUNON;
1169 1074
1170 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 1075 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
1171 1076
1172 if (pl->socket.sc_version < 1025) 1077 if (ns->sc_version < 1025)
1173 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) } 1078 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1174 else 1079 else
1175 {
1176 int i;
1177
1178 for (i = 0; i < NROFATTACKS; i++) 1080 for (int i = 0; i < NROFATTACKS; i++)
1179 { 1081 {
1180 /* Skip ones we won't send */ 1082 /* Skip ones we won't send */
1181 if (atnr_cs_stat[i] == -1) 1083 if (atnr_cs_stat[i] == -1)
1182 continue; 1084 continue;
1183 1085
1184 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 1086 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
1185 } 1087 }
1186 }
1187 1088
1188 if (pl->socket.monitor_spells) 1089 if (pl->ns->monitor_spells)
1189 { 1090 {
1190 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 1091 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1191 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 1092 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1192 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 1093 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1193 } 1094 }
1194 1095
1195 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 1096 rangetostring (ob, buf); /* we want use the new fire & run system in new client */
1196 AddIfString (pl->socket.stats.range, buf, CS_STAT_RANGE); 1097 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1197 set_title (pl->ob, buf); 1098 set_title (ob, buf);
1198 AddIfString (pl->socket.stats.title, buf, CS_STAT_TITLE); 1099 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1199 1100
1200 /* Only send it away if we have some actual data */ 1101 /* Only send it away if we have some actual data */
1201 if (sl.len > 6) 1102 if (sl.length () > 6)
1202 { 1103 ns->send_packet (sl);
1203#ifdef ESRV_DEBUG
1204 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1205#endif
1206 Send_With_Handling (&pl->socket, &sl);
1207 }
1208
1209 free (sl.buf);
1210} 1104}
1211 1105
1212/** 1106/**
1213 * Tells the client that here is a player it should start using. 1107 * Tells the client that here is a player it should start using.
1214 */ 1108 */
1215void 1109void
1216esrv_new_player (player *pl, uint32 weight) 1110esrv_new_player (player *pl, uint32 weight)
1217{ 1111{
1218 SockList sl; 1112 packet sl ("player");
1219 1113
1114 sl << uint32 (pl->ob->count)
1115 << uint32 (weight)
1116 << uint32 (pl->ob->face->number)
1117 << data8 (pl->ob->name);
1118
1220 pl->last_weight = weight; 1119 pl->ns->last_weight = weight;
1221 1120 pl->ns->send_packet (sl);
1222 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1223
1224 strcpy ((char *) sl.buf, "player ");
1225 sl.len = strlen ((char *) sl.buf);
1226 SockList_AddInt (&sl, pl->ob->count);
1227 SockList_AddInt (&sl, weight);
1228 SockList_AddInt (&sl, pl->ob->face->number);
1229
1230 SockList_AddChar (&sl, (char) strlen (pl->ob->name));
1231 strcpy ((char *) sl.buf + sl.len, pl->ob->name);
1232 sl.len += strlen (pl->ob->name);
1233
1234 Send_With_Handling (&pl->socket, &sl);
1235 free (sl.buf);
1236 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1121 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1237} 1122}
1238 1123
1239/** 1124/**
1240 * Need to send an animation sequence to the client. 1125 * Need to send an animation sequence to the client.
… …
1242 * sent them the face yet (this can become quite costly in terms of 1127 * sent them the face yet (this can become quite costly in terms of
1243 * how much we are sending - on the other hand, this should only happen 1128 * how much we are sending - on the other hand, this should only happen
1244 * when the player logs in and picks stuff up. 1129 * when the player logs in and picks stuff up.
1245 */ 1130 */
1246void 1131void
1247esrv_send_animation (NewSocket * ns, short anim_num) 1132esrv_send_animation (client * ns, short anim_num)
1248{ 1133{
1249 SockList sl;
1250 int i;
1251
1252 /* Do some checking on the anim_num we got. Note that the animations 1134 /* Do some checking on the anim_num we got. Note that the animations
1253 * are added in contigous order, so if the number is in the valid 1135 * are added in contigous order, so if the number is in the valid
1254 * range, it must be a valid animation. 1136 * range, it must be a valid animation.
1255 */ 1137 */
1256 if (anim_num < 0 || anim_num > num_animations) 1138 if (anim_num < 0 || anim_num > num_animations)
1257 { 1139 {
1258 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num); 1140 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1259 return; 1141 return;
1260 } 1142 }
1261 1143
1262 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1144 packet sl ("anim");
1263 strcpy ((char *) sl.buf, "anim "); 1145
1264 sl.len = 5; 1146 sl << uint16 (anim_num)
1265 SockList_AddShort (&sl, anim_num); 1147 << uint16 (0); /* flags - not used right now */
1266 SockList_AddShort (&sl, 0); /* flags - not used right now */ 1148
1267 /* Build up the list of faces. Also, send any information (ie, the 1149 /* Build up the list of faces. Also, send any information (ie, the
1268 * the face itself) down to the client. 1150 * the face itself) down to the client.
1269 */ 1151 */
1270 for (i = 0; i < animations[anim_num].num_animations; i++) 1152 for (int i = 0; i < animations[anim_num].num_animations; i++)
1271 { 1153 {
1272 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE)) 1154 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1273 esrv_send_face (ns, animations[anim_num].faces[i], 0); 1155 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1156
1274 SockList_AddShort (&sl, animations[anim_num].faces[i]); /* flags - not used right now */ 1157 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1275 } 1158 }
1276 Send_With_Handling (ns, &sl); 1159
1277 free (sl.buf); 1160 ns->send_packet (sl);
1161
1278 ns->anims_sent[anim_num] = 1; 1162 ns->anims_sent[anim_num] = 1;
1279} 1163}
1280 1164
1281 1165
1282/****************************************************************************** 1166/******************************************************************************
… …
1288/** 1172/**
1289 * This adds face_num to a map cell at x,y. If the client doesn't have 1173 * This adds face_num to a map cell at x,y. If the client doesn't have
1290 * the face yet, we will also send it. 1174 * the face yet, we will also send it.
1291 */ 1175 */
1292static void 1176static void
1293esrv_map_setbelow (NewSocket * ns, int x, int y, short face_num, struct Map *newmap) 1177esrv_map_setbelow (client * ns, int x, int y, short face_num, struct Map *newmap)
1294{ 1178{
1295 if (newmap->cells[x][y].count >= MAP_LAYERS) 1179 if (newmap->cells[x][y].count >= MAP_LAYERS)
1296 { 1180 {
1181 //TODO: one or the other, can't both have abort and return, verify and act
1297 LOG (llevError, "Too many faces in map cell %d %d\n", x, y); 1182 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1298 return; 1183 return;
1299 abort (); 1184 abort ();
1300 } 1185 }
1186
1301 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num; 1187 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1302 newmap->cells[x][y].count++; 1188 newmap->cells[x][y].count++;
1189
1303 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1190 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1304 esrv_send_face (ns, face_num, 0); 1191 esrv_send_face (ns, face_num, 0);
1305} 1192}
1306
1307struct LayerCell
1308{
1309 uint16 xy;
1310 short face;
1311};
1312
1313struct MapLayer
1314{
1315 int count;
1316 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1317};
1318
1319/** Checkes if map cells have changed */
1320static int
1321mapcellchanged (NewSocket * ns, int i, int j, struct Map *newmap)
1322{
1323 int k;
1324
1325 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1326 return 1;
1327 for (k = 0; k < newmap->cells[i][j].count; k++)
1328 {
1329 if (ns->lastmap.cells[i][j].faces[k] != newmap->cells[i][j].faces[k])
1330 {
1331 return 1;
1332 }
1333 }
1334 return 0;
1335}
1336
1337/**
1338 * Basically, what this does is pack the data into layers.
1339 * cnum is the client number, cur is the the buffer we put all of
1340 * this data into. we return the end of the data. layers is
1341 * how many layers of data we should back.
1342 */
1343static uint8 *
1344compactlayer (NewSocket * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1345{
1346 int x, y, k;
1347 int face;
1348 unsigned char *fcur;
1349 struct MapLayer layers[MAP_LAYERS];
1350
1351 for (k = 0; k < MAP_LAYERS; k++)
1352 layers[k].count = 0;
1353 fcur = cur;
1354 for (x = 0; x < ns->mapx; x++)
1355 {
1356 for (y = 0; y < ns->mapy; y++)
1357 {
1358 if (!mapcellchanged (ns, x, y, newmap))
1359 continue;
1360 if (newmap->cells[x][y].count == 0)
1361 {
1362 *cur = x * ns->mapy + y; /* mark empty space */
1363 cur++;
1364 continue;
1365 }
1366 for (k = 0; k < newmap->cells[x][y].count; k++)
1367 {
1368 layers[k].lcells[layers[k].count].xy = x * ns->mapy + y;
1369 layers[k].lcells[layers[k].count].face = newmap->cells[x][y].faces[k];
1370 layers[k].count++;
1371 }
1372 }
1373 }
1374 /* If no data, return now. */
1375 if (fcur == cur && layers[0].count == 0)
1376 return cur;
1377 *cur = 255; /* mark end of explicitly cleared cells */
1378 cur++;
1379 /* First pack by layers. */
1380 for (k = 0; k < numlayers; k++)
1381 {
1382 if (layers[k].count == 0)
1383 break; /* once a layer is entirely empty, no layer below it can
1384 have anything in it either */
1385 /* Pack by entries in thie layer */
1386 for (x = 0; x < layers[k].count;)
1387 {
1388 fcur = cur;
1389 *cur = layers[k].lcells[x].face >> 8;
1390 cur++;
1391 *cur = layers[k].lcells[x].face & 0xFF;
1392 cur++;
1393 face = layers[k].lcells[x].face;
1394 /* Now, we back the redundant data into 1 byte xy pairings */
1395 for (y = x; y < layers[k].count; y++)
1396 {
1397 if (layers[k].lcells[y].face == face)
1398 {
1399 *cur = (uint8) layers[k].lcells[y].xy;
1400 cur++;
1401 layers[k].lcells[y].face = -1;
1402 }
1403 }
1404 *(cur - 1) = *(cur - 1) | 128; /* mark for end of xy's; 11*11 < 128 */
1405 /* forward over the now redundant data */
1406 while (x < layers[k].count && layers[k].lcells[x].face == -1)
1407 x++;
1408 }
1409 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1410 }
1411 return cur;
1412}
1413
1414static void
1415esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1416{
1417 static long frames, bytes, tbytes, tframes;
1418 char *cur;
1419 SockList sl;
1420
1421
1422 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1423 strcpy ((char *) sl.buf, "map ");
1424 sl.len = strlen ((char *) sl.buf);
1425
1426 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1427 sl.len = cur - (char *) sl.buf;
1428
1429/* LOG(llevDebug, "Sending map command.\n");*/
1430
1431 if (sl.len > (int) strlen ("map ") || ns->sent_scroll)
1432 {
1433 /* All of this is just accounting stuff */
1434 if (tframes > 100)
1435 tframes = tbytes = 0;
1436
1437 tframes++;
1438 frames++;
1439 tbytes += sl.len;
1440 bytes += sl.len;
1441 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1442 Send_With_Handling (ns, &sl);
1443 ns->sent_scroll = 0;
1444 }
1445
1446 free (sl.buf);
1447}
1448
1449 1193
1450/** Clears a map cell */ 1194/** Clears a map cell */
1451static void 1195static void
1452map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 1196map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count)
1453{ 1197{
… …
1464#define MAX_LAYERS 3 1208#define MAX_LAYERS 3
1465 1209
1466/* Using a global really isn't a good approach, but saves the over head of 1210/* Using a global really isn't a good approach, but saves the over head of
1467 * allocating and deallocating such a block of data each time run through, 1211 * allocating and deallocating such a block of data each time run through,
1468 * and saves the space of allocating this in the socket object when we only 1212 * and saves the space of allocating this in the socket object when we only
1469 * need it for this cycle. If the serve is ever threaded, this needs to be 1213 * need it for this cycle. If the server is ever threaded, this needs to be
1470 * re-examined. 1214 * re-examined.
1471 */ 1215 */
1472
1473static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS]; 1216static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1474 1217
1475/** 1218/**
1476 * Returns true if any of the heads for this 1219 * Returns true if any of the heads for this
1477 * space is set. Returns false if all are blank - this is used 1220 * space is set. Returns false if all are blank - this is used
1478 * for empty space checking. 1221 * for empty space checking.
1479 */ 1222 */
1480static inline int 1223static inline int
1481have_head (int ax, int ay) 1224have_head (int ax, int ay)
1482{ 1225{
1483
1484 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] || 1226 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1485 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2]) 1227 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1486 return 1; 1228 return 1;
1229
1487 return 0; 1230 return 0;
1488} 1231}
1489 1232
1490/** 1233/**
1491 * check_head is a bit simplistic version of update_space below. 1234 * check_head is a bit simplistic version of update_space below.
1492 * basically, it only checks the that the head on space ax,ay at layer 1235 * basically, it only checks the that the head on space ax,ay at layer
1493 * needs to get sent - if so, it adds the data, sending the head 1236 * needs to get sent - if so, it adds the data, sending the head
1494 * if needed, and returning 1. If this no data needs to get 1237 * if needed, and returning 1. If this no data needs to get
1495 * sent, it returns zero. 1238 * sent, it returns zero.
1496 */ 1239 */
1497static int 1240static int
1498check_head (SockList & sl, NewSocket & ns, int ax, int ay, int layer) 1241check_head (packet &sl, client &ns, int ax, int ay, int layer)
1499{ 1242{
1500 short face_num; 1243 short face_num;
1501 1244
1502 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]) 1245 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1503 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number; 1246 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1504 else 1247 else
1505 face_num = 0; 1248 face_num = 0;
1506 1249
1507 if (face_num != ns.lastmap.cells[ax][ay].faces[layer]) 1250 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1508 { 1251 {
1509 SockList_AddShort (&sl, face_num); 1252 sl << uint16 (face_num);
1510 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1253 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1511 esrv_send_face (&ns, face_num, 0); 1254 esrv_send_face (&ns, face_num, 0);
1255
1512 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL; 1256 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1513 ns.lastmap.cells[ax][ay].faces[layer] = face_num; 1257 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1514 return 1; 1258 return 1;
1515 } 1259 }
1516 1260
… …
1534 * numbers the spaces differently - I think this was a leftover from 1278 * numbers the spaces differently - I think this was a leftover from
1535 * the map command, where the faces stack up. Sinces that is no longer 1279 * the map command, where the faces stack up. Sinces that is no longer
1536 * the case, it seems to make more sense to have these layer values 1280 * the case, it seems to make more sense to have these layer values
1537 * actually match. 1281 * actually match.
1538 */ 1282 */
1539
1540static int 1283static int
1541update_space (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1284update_space (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1542{ 1285{
1543 object *ob, *head; 1286 object *ob, *head;
1544 uint16 face_num; 1287 uint16 face_num;
1545 int bx, by, i; 1288 int bx, by, i;
1546 1289
1547 /* If there is a multipart object stored away, treat that as more important. 1290 /* If there is a multipart object stored away, treat that as more important.
1548 * If not, then do the normal processing. 1291 * If not, then do the normal processing.
1549 */ 1292 */
1550
1551 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer]; 1293 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1552 1294
1553 /* Check to see if this head is part of the set of objects 1295 /* Check to see if this head is part of the set of objects
1554 * we would normally send for this space. If so, then 1296 * we would normally send for this space. If so, then
1555 * don't use the head value. We need to do the check 1297 * don't use the head value. We need to do the check
… …
1720 1462
1721 /* Another hack - because of heads and whatnot, this face may match one 1463 /* Another hack - because of heads and whatnot, this face may match one
1722 * we already sent for a lower layer. In that case, don't send 1464 * we already sent for a lower layer. In that case, don't send
1723 * this one. 1465 * this one.
1724 */ 1466 */
1725 if (face_num && layer + 1 < MAP_LAYERS && ns->lastmap.cells[sx][sy].faces[layer + 1] == face_num) 1467 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1726 {
1727 face_num = 0; 1468 face_num = 0;
1728 }
1729 1469
1730 /* We've gotten what face we want to use for the object. Now see if 1470 /* We've gotten what face we want to use for the object. Now see if
1731 * if it has changed since we last sent it to the client. 1471 * if it has changed since we last sent it to the client.
1732 */ 1472 */
1733 if (ns->lastmap.cells[sx][sy].faces[layer] != face_num) 1473 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num)
1734 { 1474 {
1735 ns->lastmap.cells[sx][sy].faces[layer] = face_num; 1475 ns.lastmap.cells[sx][sy].faces[layer] = face_num;
1736 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1476 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1737 esrv_send_face (ns, face_num, 0); 1477 esrv_send_face (&ns, face_num, 0);
1738 SockList_AddShort (sl, face_num); 1478
1479 sl << uint16 (face_num);
1739 return 1; 1480 return 1;
1740 } 1481 }
1482
1741 /* Nothing changed */ 1483 /* Nothing changed */
1742 return 0; 1484 return 0;
1743} 1485}
1744 1486
1745/** 1487/**
… …
1760 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ 1502 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1761 * take. 1503 * take.
1762 */ 1504 */
1763 1505
1764static inline int 1506static inline int
1765update_smooth (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1507update_smooth (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1766{ 1508{
1767 object *ob; 1509 object *ob;
1768 int smoothlevel; /* old face_num; */ 1510 int smoothlevel; /* old face_num; */
1769 1511
1770 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer); 1512 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1771 1513
1772 /* If there is no object for this space, or if the face for the object 1514 /* If there is no object for this space, or if the face for the object
1773 * is the blank face, set the smoothlevel to zero. 1515 * is the blank face, set the smoothlevel to zero.
1774 */ 1516 */
1775 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp)) 1517 if (!ob || ob->face == blank_face)
1776 smoothlevel = 0; 1518 smoothlevel = 0;
1777 else 1519 else
1778 { 1520 {
1779 smoothlevel = ob->smoothlevel; 1521 smoothlevel = ob->smoothlevel;
1780 if (smoothlevel && !(ns->faces_sent[ob->face->number] & NS_FACESENT_SMOOTH)) 1522 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1781 SendSmooth (ns, ob->face->number); 1523 SendSmooth (&ns, ob->face->number);
1782 } /* else not already head object or blank face */ 1524 } /* else not already head object or blank face */
1783 1525
1784 /* We've gotten what face we want to use for the object. Now see if 1526 /* We've gotten what face we want to use for the object. Now see if
1785 * if it has changed since we last sent it to the client. 1527 * if it has changed since we last sent it to the client.
1786 */ 1528 */
1787 if (smoothlevel > 255) 1529 if (smoothlevel > 255)
1788 smoothlevel = 255; 1530 smoothlevel = 255;
1789 else if (smoothlevel < 0) 1531 else if (smoothlevel < 0)
1790 smoothlevel = 0; 1532 smoothlevel = 0;
1533
1791 if (ns->lastmap.cells[sx][sy].smooth[layer] != smoothlevel) 1534 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1792 { 1535 {
1793 ns->lastmap.cells[sx][sy].smooth[layer] = smoothlevel; 1536 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1794 SockList_AddChar (sl, (uint8) (smoothlevel & 0xFF)); 1537 sl << uint8 (smoothlevel);
1795 return 1; 1538 return 1;
1796 } 1539 }
1540
1797 /* Nothing changed */ 1541 /* Nothing changed */
1798 return 0; 1542 return 0;
1799} 1543}
1800 1544
1801/** 1545/**
1802 * Returns the size of a data for a map square as returned by 1546 * Returns the size of a data for a map square as returned by
1803 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries 1547 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1804 * available. 1548 * available.
1805 */ 1549 */
1806int 1550int
1807getExtendedMapInfoSize (NewSocket * ns) 1551getExtendedMapInfoSize (client * ns)
1808{ 1552{
1809 int result = 0; 1553 int result = 0;
1810 1554
1811 if (ns->ext_mapinfos) 1555 if (ns->ext_mapinfos)
1812 { 1556 {
1813 if (ns->EMI_smooth) 1557 if (ns->EMI_smooth)
1814 result += 1; /*One byte for smoothlevel */ 1558 result += 1; /*One byte for smoothlevel */
1815 } 1559 }
1560
1816 return result; 1561 return result;
1562}
1563
1564// prefetch (and touch) all maps within a specific distancd
1565static void
1566prefetch_surrounding_maps (maptile *map, int distance)
1567{
1568 map->last_access = runtime;
1569
1570 if (--distance)
1571 for (int dir = 4; --dir; )
1572 if (const shstr &path = map->tile_path [dir])
1573 if (maptile *&neigh = map->tile_map [dir])
1574 prefetch_surrounding_maps (neigh, distance);
1575 else
1576 neigh = maptile::find_async (path, map);
1577}
1578
1579// prefetch a generous area around the player
1580static void
1581prefetch_surrounding_maps (object *op)
1582{
1583 prefetch_surrounding_maps (op->map, 3);
1817} 1584}
1818 1585
1819/** 1586/**
1820 * This function uses the new map1 protocol command to send the map 1587 * This function uses the new map1 protocol command to send the map
1821 * to the client. It is necessary because the old map command supports 1588 * to the client. It is necessary because the old map command supports
… …
1827 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off 1594 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1828 * maps no sense. Instead, we actually really only use 12 bits for coordinates, 1595 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1829 * and use the other 4 bits for other informatiion. For full documentation 1596 * and use the other 4 bits for other informatiion. For full documentation
1830 * of what we send, see the doc/Protocol file. 1597 * of what we send, see the doc/Protocol file.
1831 * I will describe internally what we do: 1598 * I will describe internally what we do:
1832 * the socket->lastmap shows how the map last looked when sent to the client. 1599 * the ns->lastmap shows how the map last looked when sent to the client.
1833 * in the lastmap structure, there is a cells array, which is set to the 1600 * in the lastmap structure, there is a cells array, which is set to the
1834 * maximum viewable size (As set in config.h). 1601 * maximum viewable size (As set in config.h).
1835 * in the cells, there are faces and a count value. 1602 * in the cells, there are faces and a count value.
1836 * we use the count value to hold the darkness value. If -1, then this space 1603 * we use the count value to hold the darkness value. If -1, then this space
1837 * is not viewable. 1604 * is not viewable.
… …
1842draw_client_map1 (object *pl) 1609draw_client_map1 (object *pl)
1843{ 1610{
1844 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1611 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen;
1845 sint16 nx, ny; 1612 sint16 nx, ny;
1846 int estartlen, eoldlen; 1613 int estartlen, eoldlen;
1847 SockList sl;
1848 SockList esl; /*For extended Map info */
1849 uint16 mask, emask; 1614 uint16 mask, emask;
1850 uint8 eentrysize; 1615 uint8 eentrysize;
1851 uint16 ewhatstart, ewhatflag; 1616 uint16 ewhatstart, ewhatflag;
1852 uint8 extendedinfos; 1617 uint8 extendedinfos;
1853 maptile *m; 1618 maptile *m;
1854 1619
1855 NewSocket & socket = pl->contr->socket; 1620 client &socket = *pl->contr->ns;
1621
1622 if (!pl->active)
1623 return;
1856 1624
1857 check_map_change (pl->contr); 1625 check_map_change (pl->contr);
1626 prefetch_surrounding_maps (pl);
1858 1627
1859 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1628 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1860 if (socket.mapmode == Map1Cmd) 1629 packet esl;
1861 strcpy ((char *) sl.buf, "map1 "); 1630
1862 else
1863 strcpy ((char *) sl.buf, "map1a ");
1864 sl.len = strlen ((char *) sl.buf);
1865 startlen = sl.len; 1631 startlen = sl.length ();
1866 1632
1867 /*Extendedmapinfo structure initialisation */ 1633 /*Extendedmapinfo structure initialisation */
1868 if (socket.ext_mapinfos) 1634 if (socket.ext_mapinfos)
1869 { 1635 {
1870 esl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1871 strcpy ((char *) esl.buf, "mapextended ");
1872 esl.len = strlen ((char *) esl.buf);
1873 extendedinfos = EMI_NOREDRAW; 1636 extendedinfos = EMI_NOREDRAW;
1874 1637
1875 if (socket.EMI_smooth) 1638 if (socket.EMI_smooth)
1876 extendedinfos |= EMI_SMOOTH; 1639 extendedinfos |= EMI_SMOOTH;
1877 1640
1878 ewhatstart = esl.len; 1641 ewhatstart = esl.length ();
1879 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 1642 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1880 could need to be taken away */ 1643 could need to be taken away */
1881 SockList_AddChar (&esl, extendedinfos);
1882 eentrysize = getExtendedMapInfoSize (&socket); 1644 eentrysize = getExtendedMapInfoSize (&socket);
1883 SockList_AddChar (&esl, eentrysize); 1645 esl << "mapextended "
1646 << uint8 (extendedinfos)
1647 << uint8 (eentrysize);
1648
1884 estartlen = esl.len; 1649 estartlen = esl.length ();
1885 } 1650 }
1886 else 1651 else
1887 { 1652 {
1888 /* suppress compiler warnings */ 1653 /* suppress compiler warnings */
1889 ewhatstart = 0; 1654 ewhatstart = 0;
… …
1914 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1679 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1915 { 1680 {
1916 ax = 0; 1681 ax = 0;
1917 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1682 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1918 { 1683 {
1919
1920 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1684 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1921 1685
1922 /* If this space is out of the normal viewable area, we only check 1686 /* If this space is out of the normal viewable area, we only check
1923 * the heads value ax or ay will only be greater than what 1687 * the heads value ax or ay will only be greater than what
1924 * the client wants if using the map1a command - this is because 1688 * the client wants if using the map1a command - this is because
… …
1927 */ 1691 */
1928 if (ax >= socket.mapx || ay >= socket.mapy) 1692 if (ax >= socket.mapx || ay >= socket.mapy)
1929 { 1693 {
1930 int i, got_one; 1694 int i, got_one;
1931 1695
1932 oldlen = sl.len; 1696 oldlen = sl.length ();
1933 1697
1934 SockList_AddShort (&sl, mask); 1698 sl << uint16 (mask);
1935 1699
1936 if (check_head (sl, socket, ax, ay, 2)) 1700 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1937 mask |= 0x4;
1938 if (check_head (sl, socket, ax, ay, 1)) 1701 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1939 mask |= 0x2;
1940 if (check_head (sl, socket, ax, ay, 0)) 1702 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1941 mask |= 0x1;
1942 1703
1943 /* If all we are doing is sending 0 (blank) faces, we don't 1704 /* If all we are doing is sending 0 (blank) faces, we don't
1944 * actually need to send that - just the coordinates 1705 * actually need to send that - just the coordinates
1945 * with no faces tells the client to blank out the 1706 * with no faces tells the client to blank out the
1946 * space. 1707 * space.
1947 */ 1708 */
1948 got_one = 0; 1709 got_one = 0;
1949 for (i = oldlen + 2; i < sl.len; i++) 1710 for (i = oldlen + 2; i < sl.length (); i++)
1950 if (sl.buf[i]) 1711 if (sl[i])
1951 got_one = 1; 1712 got_one = 1;
1952 1713
1953 if (got_one && (mask & 0xf)) 1714 if (got_one && (mask & 0xf))
1954 sl.buf[oldlen + 1] = mask & 0xff; 1715 sl[oldlen + 1] = mask & 0xff;
1955 else 1716 else
1956 { /*either all faces blank, either no face at all */ 1717 { /*either all faces blank, either no face at all */
1957 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */ 1718 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1958 sl.len = oldlen + 2; 1719 sl.reset (oldlen + 2);
1959 else 1720 else
1960 sl.len = oldlen; 1721 sl.reset (oldlen);
1961 } 1722 }
1962 1723
1963 /*What concerns extendinfos, nothing to be done for now 1724 /*What concerns extendinfos, nothing to be done for now
1964 * (perhaps effects layer later) 1725 * (perhaps effects layer later)
1965 */ 1726 */
… …
1983 * if this hasn't already been done. If the space is out 1744 * if this hasn't already been done. If the space is out
1984 * of the map, it shouldn't have a head 1745 * of the map, it shouldn't have a head
1985 */ 1746 */
1986 if (lastcell.count != -1) 1747 if (lastcell.count != -1)
1987 { 1748 {
1988 SockList_AddShort (&sl, mask); 1749 sl << uint16 (mask);
1989 map_clearcell (&lastcell, 0, 0, 0, -1); 1750 map_clearcell (&lastcell, 0, 0, 0, -1);
1990 } 1751 }
1991 } 1752 }
1992 else if (d > 3) 1753 else if (d > 3)
1993 { 1754 {
1755 m->touch ();
1756
1994 int need_send = 0, count; 1757 int need_send = 0, count;
1995 1758
1996 /* This block deals with spaces that are not visible for whatever 1759 /* This block deals with spaces that are not visible for whatever
1997 * reason. Still may need to send the head for this space. 1760 * reason. Still may need to send the head for this space.
1998 */ 1761 */
1999 1762
2000 oldlen = sl.len; 1763 oldlen = sl.length ();
2001 1764
2002 SockList_AddShort (&sl, mask); 1765 sl << uint16 (mask);
2003 1766
2004 if (lastcell.count != -1) 1767 if (lastcell.count != -1)
2005 need_send = 1; 1768 need_send = 1;
2006 1769
2007 count = -1; 1770 count = -1;
2008 1771
2009 if (socket.mapmode == Map1aCmd && have_head (ax, ay)) 1772 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
2010 { 1773 {
2011 /* Now check to see if any heads need to be sent */ 1774 /* Now check to see if any heads need to be sent */
2012 1775
2013 if (check_head (sl, socket, ax, ay, 2)) 1776 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
2014 mask |= 0x4;
2015 if (check_head (sl, socket, ax, ay, 1)) 1777 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
2016 mask |= 0x2;
2017 if (check_head (sl, socket, ax, ay, 0)) 1778 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
2018 mask |= 0x1;
2019 1779
2020 lastcell.count = count; 1780 lastcell.count = count;
2021 } 1781 }
2022 else 1782 else
2023 { 1783 {
… …
2028 1788
2029 map_clearcell (&lastcell, 0, 0, 0, count); 1789 map_clearcell (&lastcell, 0, 0, 0, count);
2030 } 1790 }
2031 1791
2032 if ((mask & 0xf) || need_send) 1792 if ((mask & 0xf) || need_send)
2033 sl.buf[oldlen + 1] = mask & 0xff; 1793 sl[oldlen + 1] = mask & 0xff;
2034 else 1794 else
2035 sl.len = oldlen; 1795 sl.reset (oldlen);
2036 } 1796 }
2037 else 1797 else
2038 { 1798 {
1799 m->touch ();
1800
2039 /* In this block, the space is visible or there are head objects 1801 /* In this block, the space is visible or there are head objects
2040 * we need to send. 1802 * we need to send.
2041 */ 1803 */
2042 1804
2043 /* Rather than try to figure out what everything that we might 1805 /* Rather than try to figure out what everything that we might
2044 * need to send is, then form the packet after that, 1806 * need to send is, then form the packet after that,
2045 * we presume that we will in fact form a packet, and update 1807 * we presume that we will in fact form a packet, and update
2046 * the bits by what we do actually send. If we send nothing, 1808 * the bits by what we do actually send. If we send nothing,
2047 * we just back out sl.len to the old value, and no harm 1809 * we just back out sl.length () to the old value, and no harm
2048 * is done. 1810 * is done.
2049 * I think this is simpler than doing a bunch of checks to see 1811 * I think this is simpler than doing a bunch of checks to see
2050 * what if anything we need to send, setting the bits, then 1812 * what if anything we need to send, setting the bits, then
2051 * doing those checks again to add the real data. 1813 * doing those checks again to add the real data.
2052 */ 1814 */
2053 oldlen = sl.len; 1815 oldlen = sl.length ();
2054 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1816 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2055 eoldlen = esl.len; 1817 eoldlen = esl.length ();
2056 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1818 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2057 SockList_AddShort (&sl, mask); 1819 sl << uint16 (mask);
2058 1820
2059 if (socket.ext_mapinfos) 1821 if (socket.ext_mapinfos)
2060 SockList_AddShort (&esl, emask); 1822 esl << uint16 (emask);
2061 1823
2062 unsigned char dummy; 1824 unsigned char dummy;
2063 unsigned char *last_ext = &dummy; 1825 unsigned char *last_ext = &dummy;
2064 1826
2065 /* Darkness changed */ 1827 /* Darkness changed */
… …
2068 mask |= 0x8; 1830 mask |= 0x8;
2069 1831
2070 if (socket.extmap) 1832 if (socket.extmap)
2071 { 1833 {
2072 *last_ext |= 0x80; 1834 *last_ext |= 0x80;
2073 last_ext = sl.buf + sl.len; 1835 last_ext = &sl[sl.length ()];
2074 SockList_AddChar (&sl, d); 1836 sl << uint8 (d);
2075 } 1837 }
2076 else 1838 else
2077 SockList_AddChar (&sl, 255 - 64 * d); 1839 sl << uint8 (255 - 64 * d);
2078 } 1840 }
2079 1841
2080 lastcell.count = d; 1842 lastcell.count = d;
2081 1843
2082 if (socket.extmap) 1844 if (socket.extmap)
2083 { 1845 {
2084 uint8 stat_hp = 0; 1846 uint8 stat_hp = 0;
2085 uint8 stat_width = 0; 1847 uint8 stat_width = 0;
2086 uint8 flags = 0; 1848 uint8 flags = 0;
2087 tag_t player = 0; 1849 UUID player = 0;
2088 1850
2089 // send hp information, if applicable 1851 // send hp information, if applicable
2090 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1852 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0))
2091 { 1853 {
2092 if (op->head || op->invisible) 1854 if (op->head || op->invisible)
… …
2112 { 1874 {
2113 lastcell.stat_hp = stat_hp; 1875 lastcell.stat_hp = stat_hp;
2114 1876
2115 mask |= 0x8; 1877 mask |= 0x8;
2116 *last_ext |= 0x80; 1878 *last_ext |= 0x80;
2117 last_ext = sl.buf + sl.len; 1879 last_ext = &sl[sl.length ()];
2118 SockList_AddChar (&sl, 5); 1880
2119 SockList_AddChar (&sl, stat_hp); 1881 sl << uint8 (5) << uint8 (stat_hp);
2120 1882
2121 if (stat_width > 1) 1883 if (stat_width > 1)
2122 { 1884 {
2123 *last_ext |= 0x80; 1885 *last_ext |= 0x80;
2124 last_ext = sl.buf + sl.len; 1886 last_ext = &sl[sl.length ()];
2125 SockList_AddChar (&sl, 6); 1887
2126 SockList_AddChar (&sl, stat_width); 1888 sl << uint8 (6) << uint8 (stat_width);
2127 } 1889 }
2128 } 1890 }
2129 1891
2130 if (lastcell.player != player) 1892 if (lastcell.player != player)
2131 { 1893 {
2132 lastcell.player = player; 1894 lastcell.player = player;
2133 1895
2134 mask |= 0x8; 1896 mask |= 0x8;
2135 *last_ext |= 0x80; 1897 *last_ext |= 0x80;
2136 last_ext = sl.buf + sl.len; 1898 last_ext = &sl[sl.length ()];
2137 SockList_AddChar (&sl, 0x47); 1899
2138 SockList_AddChar (&sl, 4); 1900 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2139 SockList_AddInt (&sl, player);
2140 } 1901 }
2141 1902
2142 if (lastcell.flags != flags) 1903 if (lastcell.flags != flags)
2143 { 1904 {
2144 lastcell.flags = flags; 1905 lastcell.flags = flags;
2145 1906
2146 mask |= 0x8; 1907 mask |= 0x8;
2147 *last_ext |= 0x80; 1908 *last_ext |= 0x80;
2148 last_ext = sl.buf + sl.len; 1909 last_ext = &sl[sl.length ()];
2149 SockList_AddChar (&sl, 8); 1910
2150 SockList_AddChar (&sl, flags); 1911 sl << uint8 (8) << uint8 (flags);
2151 } 1912 }
2152 } 1913 }
2153 1914
2154 /* Floor face */ 1915 /* Floor face */
2155 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 2)) 1916 if (update_space (sl, socket, m, nx, ny, ax, ay, 2))
2156 mask |= 0x4; 1917 mask |= 0x4;
2157 1918
2158 if (socket.EMI_smooth) 1919 if (socket.EMI_smooth)
2159 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 2)) 1920 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2160 emask |= 0x4; 1921 emask |= 0x4;
2161 1922
2162 /* Middle face */ 1923 /* Middle face */
2163 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 1)) 1924 if (update_space (sl, socket, m, nx, ny, ax, ay, 1))
2164 mask |= 0x2; 1925 mask |= 0x2;
2165 1926
2166 if (socket.EMI_smooth) 1927 if (socket.EMI_smooth)
2167 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 1)) 1928 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1))
2168 emask |= 0x2; 1929 emask |= 0x2;
2169 1930
2170 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1)) 1931 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2171 { 1932 {
2172 if (lastcell.faces[0] != pl->face->number) 1933 if (lastcell.faces[0] != pl->face->number)
… …
2175 mask |= 0x1; 1936 mask |= 0x1;
2176 1937
2177 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE)) 1938 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2178 esrv_send_face (&socket, pl->face->number, 0); 1939 esrv_send_face (&socket, pl->face->number, 0);
2179 1940
2180 SockList_AddShort (&sl, pl->face->number); 1941 sl << uint16 (pl->face->number);
2181 } 1942 }
2182 } 1943 }
2183 else 1944 else
2184 { 1945 {
2185 /* Top face */ 1946 /* Top face */
2186 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 0)) 1947 if (update_space (sl, socket, m, nx, ny, ax, ay, 0))
2187 mask |= 0x1; 1948 mask |= 0x1;
2188 1949
2189 if (socket.EMI_smooth) 1950 if (socket.EMI_smooth)
2190 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 0)) 1951 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2191 emask |= 0x1; 1952 emask |= 0x1;
2192 } 1953 }
2193 1954
2194 /* Check to see if we are in fact sending anything for this 1955 /* Check to see if we are in fact sending anything for this
2195 * space by checking the mask. If so, update the mask. 1956 * space by checking the mask. If so, update the mask.
2196 * if not, reset the len to that from before adding the mask 1957 * if not, reset the len to that from before adding the mask
2197 * value, so we don't send those bits. 1958 * value, so we don't send those bits.
2198 */ 1959 */
2199 if (mask & 0xf) 1960 if (mask & 0xf)
2200 sl.buf[oldlen + 1] = mask & 0xff; 1961 sl[oldlen + 1] = mask & 0xff;
2201 else 1962 else
2202 sl.len = oldlen; 1963 sl.reset (oldlen);
2203 1964
2204 if (emask & 0xf) 1965 if (emask & 0xf)
2205 esl.buf[eoldlen + 1] = emask & 0xff; 1966 esl[eoldlen + 1] = emask & 0xff;
2206 else 1967 else
2207 esl.len = eoldlen; 1968 esl.reset (eoldlen);
2208 } /* else this is a viewable space */ 1969 } /* else this is a viewable space */
2209 } /* for x loop */ 1970 } /* for x loop */
2210 } /* for y loop */ 1971 } /* for y loop */
2211 1972
2212 /* Verify that we in fact do need to send this */ 1973 /* Verify that we in fact do need to send this */
2213 if (socket.ext_mapinfos) 1974 if (socket.ext_mapinfos)
2214 { 1975 {
2215 if (!(sl.len > startlen || socket.sent_scroll)) 1976 if (!(sl.length () > startlen || socket.sent_scroll))
2216 { 1977 {
2217 /* No map data will follow, so don't say the client 1978 /* No map data will follow, so don't say the client
2218 * it doesn't need draw! 1979 * it doesn't need draw!
2219 */ 1980 */
2220 ewhatflag &= (~EMI_NOREDRAW); 1981 ewhatflag &= (~EMI_NOREDRAW);
2221 esl.buf[ewhatstart + 1] = ewhatflag & 0xff; 1982 esl[ewhatstart + 1] = ewhatflag & 0xff;
2222 } 1983 }
2223 1984
2224 if (esl.len > estartlen) 1985 if (esl.length () > estartlen)
2225 Send_With_Handling (&socket, &esl); 1986 socket.send_packet (esl);
2226
2227 free (esl.buf);
2228 } 1987 }
2229 1988
2230 if (sl.len > startlen || socket.sent_scroll) 1989 if (sl.length () > startlen || socket.sent_scroll)
2231 { 1990 {
2232 Send_With_Handling (&socket, &sl); 1991 socket.send_packet (sl);
2233 socket.sent_scroll = 0; 1992 socket.sent_scroll = 0;
2234 } 1993 }
2235
2236 free (sl.buf);
2237} 1994}
2238 1995
2239/** 1996/**
2240 * Draws client map. 1997 * Draws client map.
2241 */ 1998 */
2242void 1999void
2243draw_client_map (object *pl) 2000draw_client_map (object *pl)
2244{ 2001{
2245 int i, j; 2002 int i, j;
2246 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */ 2003 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */
2247 New_Face *face, *floor; 2004 facetile *face, *floor;
2248 New_Face *floor2; 2005 facetile *floor2;
2249 int d, mflags; 2006 int d, mflags;
2250 struct Map newmap; 2007 struct Map newmap;
2251 maptile *m, *pm; 2008 maptile *m, *pm;
2252 2009
2253 if (pl->type != PLAYER) 2010 if (pl->type != PLAYER)
… …
2265 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 2022 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2266 return; 2023 return;
2267 2024
2268 memset (&newmap, 0, sizeof (struct Map)); 2025 memset (&newmap, 0, sizeof (struct Map));
2269 2026
2270 for (j = (pl->y - pl->contr->socket.mapy / 2); j < (pl->y + (pl->contr->socket.mapy + 1) / 2); j++) 2027 for (j = (pl->y - pl->contr->ns->mapy / 2); j < (pl->y + (pl->contr->ns->mapy + 1) / 2); j++)
2271 {
2272 for (i = (pl->x - pl->contr->socket.mapx / 2); i < (pl->x + (pl->contr->socket.mapx + 1) / 2); i++) 2028 for (i = (pl->x - pl->contr->ns->mapx / 2); i < (pl->x + (pl->contr->ns->mapx + 1) / 2); i++)
2273 { 2029 {
2274 ax = i; 2030 ax = i;
2275 ay = j; 2031 ay = j;
2276 m = pm; 2032 m = pm;
2277 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay); 2033 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
2034
2278 if (mflags & P_OUT_OF_MAP) 2035 if (mflags & P_OUT_OF_MAP)
2279 continue; 2036 continue;
2280 if (mflags & P_NEED_UPDATE) 2037
2281 update_position (m, ax, ay);
2282 /* If a map is visible to the player, we don't want to swap it out 2038 /* If a map is visible to the player, we don't want to swap it out
2283 * just to reload it. This should really call something like 2039 * just to reload it. This should really call something like
2284 * swap_map, but this is much more efficient and 'good enough' 2040 * swap_map, but this is much more efficient and 'good enough'
2285 */ 2041 */
2286 if (mflags & P_NEW_MAP) 2042 if (mflags & P_NEW_MAP)
2287 m->timeout = 50; 2043 m->timeout = 50;
2288 } 2044 }
2289 } 2045
2290 /* do LOS after calls to update_position */ 2046 /* do LOS after calls to update_position */
2291 if (pl->contr->do_los) 2047 if (pl->contr->do_los)
2292 { 2048 {
2293 update_los (pl); 2049 update_los (pl);
2294 pl->contr->do_los = 0; 2050 pl->contr->do_los = 0;
2295 } 2051 }
2296 2052
2297 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd)
2298 {
2299 /* Big maps need a different drawing mechanism to work */ 2053 /* Big maps need a different drawing mechanism to work */
2300 draw_client_map1 (pl); 2054 draw_client_map1 (pl);
2301 return;
2302 }
2303
2304 if (pl->invisible & (pl->invisible < 50 ? 4 : 1))
2305 {
2306 esrv_map_setbelow (&pl->contr->socket, pl->contr->socket.mapx / 2, pl->contr->socket.mapy / 2, pl->face->number, &newmap);
2307 }
2308
2309 /* j and i are the y and x coordinates of the real map (which is
2310 * basically some number of spaces around the player)
2311 * ax and ay are values from within the viewport (ie, 0, 0 is upper
2312 * left corner) and are thus disconnected from the map values.
2313 * Subtract 1 from the max values so that we properly handle cases where
2314 * player has specified an even map. Otherwise, we try to send them too
2315 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually
2316 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is
2317 * odd, this still works fine.
2318 */
2319 ay = 0;
2320 for (j = pl->y - pl->contr->socket.mapy / 2; j <= pl->y + (pl->contr->socket.mapy - 1) / 2; j++, ay++)
2321 {
2322 ax = 0;
2323 for (i = pl->x - pl->contr->socket.mapx / 2; i <= pl->x + (pl->contr->socket.mapx - 1) / 2; i++, ax++)
2324 {
2325
2326 d = pl->contr->blocked_los[ax][ay];
2327 /* note the out_of_map and d>3 checks are both within the same
2328 * negation check.
2329 */
2330 nx = i;
2331 ny = j;
2332 m = get_map_from_coord (pm, &nx, &ny);
2333 if (m && d < 4)
2334 {
2335 face = GET_MAP_FACE (m, nx, ny, 0);
2336 floor2 = GET_MAP_FACE (m, nx, ny, 1);
2337 floor = GET_MAP_FACE (m, nx, ny, 2);
2338
2339 /* If all is blank, send a blank face. */
2340 if ((!face || face == blank_face) && (!floor2 || floor2 == blank_face) && (!floor || floor == blank_face))
2341 {
2342 esrv_map_setbelow (&pl->contr->socket, ax, ay, blank_face->number, &newmap);
2343 }
2344 else
2345 { /* actually have something interesting */
2346 /* send the darkness mask, if any. */
2347 if (d && pl->contr->socket.darkness)
2348 esrv_map_setbelow (&pl->contr->socket, ax, ay, dark_faces[d - 1]->number, &newmap);
2349
2350 if (face && face != blank_face)
2351 esrv_map_setbelow (&pl->contr->socket, ax, ay, face->number, &newmap);
2352 if (floor2 && floor2 != blank_face)
2353 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor2->number, &newmap);
2354 if (floor && floor != blank_face)
2355 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2356 }
2357 } /* Is a valid space */
2358 }
2359 }
2360 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2361
2362 check_map_change (pl->contr);
2363} 2055}
2364 2056
2365 2057
2366/*****************************************************************************/ 2058/*****************************************************************************/
2367 2059
… …
2373 2065
2374/*****************************************************************************/ 2066/*****************************************************************************/
2375void 2067void
2376send_plugin_custom_message (object *pl, char *buf) 2068send_plugin_custom_message (object *pl, char *buf)
2377{ 2069{
2378 cs_write_string (&pl->contr->socket, buf, strlen (buf)); 2070 pl->contr->ns->send_packet (buf);
2379} 2071}
2380 2072
2381/** 2073/**
2382 * This sends the skill number to name mapping. We ignore 2074 * This sends the skill number to name mapping. We ignore
2383 * the params - we always send the same info no matter what. 2075 * the params - we always send the same info no matter what.
2384 */ 2076 */
2385void 2077void
2386send_skill_info (NewSocket * ns, char *params) 2078send_skill_info (client *ns, char *params)
2387{ 2079{
2388 SockList sl; 2080 packet sl;
2389 int i; 2081 sl << "replyinfo skill_info\n";
2390 2082
2391 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
2392 strcpy ((char *) sl.buf, "replyinfo skill_info\n");
2393 for (i = 1; i < NUM_SKILLS; i++) 2083 for (int i = 1; i < NUM_SKILLS; i++)
2394 { 2084 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2395 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 2085
2396 }
2397 sl.len = strlen ((char *) sl.buf);
2398 if (sl.len >= MAXSOCKBUF) 2086 if (sl.length () >= MAXSOCKBUF)
2399 { 2087 {
2400 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 2088 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2401 fatal (0); 2089 fatal (0);
2402 } 2090 }
2403 Send_With_Handling (ns, &sl); 2091
2404 free (sl.buf); 2092 ns->send_packet (sl);
2405} 2093}
2406 2094
2407/** 2095/**
2408 * This sends the spell path to name mapping. We ignore 2096 * This sends the spell path to name mapping. We ignore
2409 * the params - we always send the same info no matter what. 2097 * the params - we always send the same info no matter what.
2410 */ 2098 */
2411void 2099void
2412send_spell_paths (NewSocket * ns, char *params) 2100send_spell_paths (client * ns, char *params)
2413{ 2101{
2414 SockList sl; 2102 packet sl;
2415 int i;
2416 2103
2417 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2104 sl << "replyinfo spell_paths\n";
2418 strcpy ((char *) sl.buf, "replyinfo spell_paths\n"); 2105
2419 for (i = 0; i < NRSPELLPATHS; i++) 2106 for (int i = 0; i < NRSPELLPATHS; i++)
2420 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", 1 << i, spellpathnames[i]); 2107 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2421 sl.len = strlen ((char *) sl.buf); 2108
2422 if (sl.len >= MAXSOCKBUF) 2109 if (sl.length () >= MAXSOCKBUF)
2423 { 2110 {
2424 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 2111 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2425 fatal (0); 2112 fatal (0);
2426 } 2113 }
2427 Send_With_Handling (ns, &sl); 2114
2428 free (sl.buf); 2115 ns->send_packet (sl);
2429} 2116}
2430 2117
2431/** 2118/**
2432 * This looks for any spells the player may have that have changed their stats. 2119 * This looks for any spells the player may have that have changed their stats.
2433 * it then sends an updspell packet for each spell that has changed in this way 2120 * it then sends an updspell packet for each spell that has changed in this way
2434 */ 2121 */
2435void 2122void
2436esrv_update_spells (player *pl) 2123esrv_update_spells (player *pl)
2437{ 2124{
2438 SockList sl; 2125 if (!pl->ns)
2439 int flags = 0;
2440 object *spell;
2441
2442 if (!pl->socket.monitor_spells)
2443 return; 2126 return;
2127
2128 if (!pl->ns->monitor_spells)
2129 return;
2130
2444 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2131 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2445 { 2132 {
2446 if (spell->type == SPELL) 2133 if (spell->type == SPELL)
2447 { 2134 {
2135 int flags = 0;
2136
2448 /* check if we need to update it */ 2137 /* check if we need to update it */
2449 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 2138 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
2450 { 2139 {
2451 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2140 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2452 flags |= UPD_SP_MANA; 2141 flags |= UPD_SP_MANA;
2453 } 2142 }
2143
2454 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 2144 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
2455 { 2145 {
2456 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2146 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2457 flags |= UPD_SP_GRACE; 2147 flags |= UPD_SP_GRACE;
2458 } 2148 }
2149
2459 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 2150 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
2460 { 2151 {
2461 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2152 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2462 flags |= UPD_SP_DAMAGE; 2153 flags |= UPD_SP_DAMAGE;
2463 } 2154 }
2155
2464 if (flags != 0) 2156 if (flags)
2465 { 2157 {
2466 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2158 packet sl;
2467 strcpy ((char *) sl.buf, "updspell "); 2159
2468 sl.len = strlen ((char *) sl.buf); 2160 sl << "updspell "
2469 SockList_AddChar (&sl, flags); 2161 << uint8 (flags)
2470 SockList_AddInt (&sl, spell->count); 2162 << uint32 (spell->count);
2471 if (flags & UPD_SP_MANA) 2163
2472 SockList_AddShort (&sl, spell->last_sp); 2164 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2473 if (flags & UPD_SP_GRACE) 2165 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2474 SockList_AddShort (&sl, spell->last_grace); 2166 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2475 if (flags & UPD_SP_DAMAGE) 2167
2476 SockList_AddShort (&sl, spell->last_eat); 2168 pl->ns->send_packet (sl);
2477 flags = 0;
2478 Send_With_Handling (&pl->socket, &sl);
2479 free (sl.buf);
2480 } 2169 }
2481 } 2170 }
2482 } 2171 }
2483} 2172}
2484 2173
2485void 2174void
2486esrv_remove_spell (player *pl, object *spell) 2175esrv_remove_spell (player *pl, object *spell)
2487{ 2176{
2488 SockList sl;
2489
2490 if (!pl->socket.monitor_spells) 2177 if (!pl->ns->monitor_spells)
2491 return; 2178 return;
2179
2492 if (!pl || !spell || spell->env != pl->ob) 2180 if (!pl || !spell || spell->env != pl->ob)
2493 { 2181 {
2494 LOG (llevError, "Invalid call to esrv_remove_spell"); 2182 LOG (llevError, "Invalid call to esrv_remove_spell");
2495 return; 2183 return;
2496 } 2184 }
2497 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2185
2498 strcpy ((char *) sl.buf, "delspell "); 2186 packet sl ("delspell");
2499 sl.len = strlen ((char *) sl.buf); 2187
2500 SockList_AddInt (&sl, spell->count); 2188 sl << uint32 (spell->count);
2501 Send_With_Handling (&pl->socket, &sl); 2189
2502 free (sl.buf); 2190 pl->ns->send_packet (sl);
2503} 2191}
2504 2192
2505/* appends the spell *spell to the Socklist we will send the data to. */ 2193/* appends the spell *spell to the Socklist we will send the data to. */
2506static void 2194static void
2507append_spell (player *pl, SockList * sl, object *spell) 2195append_spell (player *pl, packet &sl, object *spell)
2508{ 2196{
2509 int len, i, skill = 0; 2197 int len, i, skill = 0;
2510 2198
2511 if (!(spell->name)) 2199 if (!(spell->name))
2512 { 2200 {
2513 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 2201 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2514 return; 2202 return;
2515 } 2203 }
2516 SockList_AddInt (sl, spell->count); 2204
2517 SockList_AddShort (sl, spell->level);
2518 SockList_AddShort (sl, spell->casting_time);
2519 /* store costs and damage in the object struct, to compare to later */ 2205 /* store costs and damage in the object struct, to compare to later */
2520 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2206 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2521 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2207 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2522 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2208 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2523 /* send the current values */
2524 SockList_AddShort (sl, spell->last_sp);
2525 SockList_AddShort (sl, spell->last_grace);
2526 SockList_AddShort (sl, spell->last_eat);
2527 2209
2528 /* figure out which skill it uses, if it uses one */ 2210 /* figure out which skill it uses, if it uses one */
2529 if (spell->skill) 2211 if (spell->skill)
2530 { 2212 {
2531 for (i = 1; i < NUM_SKILLS; i++) 2213 for (i = 1; i < NUM_SKILLS; i++)
… …
2533 { 2215 {
2534 skill = i + CS_STAT_SKILLINFO; 2216 skill = i + CS_STAT_SKILLINFO;
2535 break; 2217 break;
2536 } 2218 }
2537 } 2219 }
2538 SockList_AddChar (sl, skill);
2539 2220
2540 SockList_AddInt (sl, spell->path_attuned); 2221 /* send the current values */
2222 sl << uint32 (spell->count)
2223 << uint16 (spell->level)
2224 << uint16 (spell->casting_time)
2225 << uint16 (spell->last_sp)
2226 << uint16 (spell->last_grace)
2227 << uint16 (spell->last_eat)
2228 << uint8 (skill)
2229 << uint32 (spell->path_attuned)
2541 SockList_AddInt (sl, (spell->face) ? spell->face->number : 0); 2230 << uint32 (spell->face ? spell->face->number : 0)
2542 2231 << data8 (spell->name)
2543 len = strlen (spell->name); 2232 << data16 (spell->msg);
2544 SockList_AddChar (sl, (char) len);
2545 memcpy (sl->buf + sl->len, spell->name, len);
2546 sl->len += len;
2547
2548 if (!spell->msg)
2549 {
2550 SockList_AddShort (sl, 0);
2551 }
2552 else
2553 {
2554 len = strlen (spell->msg);
2555 SockList_AddShort (sl, len);
2556 memcpy (sl->buf + sl->len, spell->msg, len);
2557 sl->len += len;
2558 }
2559} 2233}
2560 2234
2561/** 2235/**
2562 * This tells the client to add the spell *ob, if *ob is NULL, then add 2236 * This tells the client to add the spell *ob, if *ob is NULL, then add
2563 * all spells in the player's inventory. 2237 * all spells in the player's inventory.
2564 */ 2238 */
2565void 2239void
2566esrv_add_spells (player *pl, object *spell) 2240esrv_add_spells (player *pl, object *spell)
2567{ 2241{
2568 SockList sl;
2569
2570 if (!pl) 2242 if (!pl)
2571 { 2243 {
2572 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 2244 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2573 return; 2245 return;
2574 } 2246 }
2247
2575 if (!pl->socket.monitor_spells) 2248 if (!pl->ns->monitor_spells)
2576 return; 2249 return;
2577 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2250
2578 strcpy ((char *) sl.buf, "addspell "); 2251 packet sl ("addspell");
2579 sl.len = strlen ((char *) sl.buf); 2252
2580 if (!spell) 2253 if (!spell)
2581 { 2254 {
2582 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2255 for (spell = pl->ob->inv; spell != NULL; spell = spell->below)
2583 { 2256 {
2584 /* were we to simply keep appending data here, we could exceed 2257 /* were we to simply keep appending data here, we could exceed
… …
2594 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 2267 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2595 * like it will fix this 2268 * like it will fix this
2596 */ 2269 */
2597 if (spell->type != SPELL) 2270 if (spell->type != SPELL)
2598 continue; 2271 continue;
2272
2599 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 2273 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2600 { 2274 {
2601 Send_With_Handling (&pl->socket, &sl); 2275 pl->ns->send_packet (sl);
2602 strcpy ((char *) sl.buf, "addspell "); 2276
2603 sl.len = strlen ((char *) sl.buf); 2277 sl.reset ();
2278 sl << "addspell ";
2604 } 2279 }
2280
2605 append_spell (pl, &sl, spell); 2281 append_spell (pl, sl, spell);
2606 } 2282 }
2607 } 2283 }
2608 else if (spell->type != SPELL) 2284 else if (spell->type != SPELL)
2609 { 2285 {
2610 LOG (llevError, "Asked to send a non-spell object as a spell"); 2286 LOG (llevError, "Asked to send a non-spell object as a spell");
2611 return; 2287 return;
2612 } 2288 }
2613 else 2289 else
2614 append_spell (pl, &sl, spell); 2290 append_spell (pl, sl, spell);
2291
2615 if (sl.len >= MAXSOCKBUF) 2292 if (sl.length () >= MAXSOCKBUF)
2616 { 2293 {
2617 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 2294 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2618 fatal (0); 2295 fatal (0);
2619 } 2296 }
2297
2620 /* finally, we can send the packet */ 2298 /* finally, we can send the packet */
2621 Send_With_Handling (&pl->socket, &sl); 2299 pl->ns->send_packet (sl);
2622 free (sl.buf);
2623} 2300}
2301

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines