ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.19 by root, Thu Sep 14 22:34:06 2006 UTC vs.
Revision 1.50 by root, Thu Dec 21 23:37:06 2006 UTC

… …
38 * esrv_map_new starts updating the map 38 * esrv_map_new starts updating the map
39 * 39 *
40 * esrv_map_setbelow allows filling in all of the faces for the map. 40 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now. 41 * if a face has not already been sent to the client, it is sent now.
42 * 42 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations
45 *
46 * esrv_map_doneredraw finishes the map update, and ships across the
47 * map updates.
48 *
49 */ 43 */
50 44
51#include <global.h> 45#include <global.h>
52#include <sproto.h> 46#include <sproto.h>
53 47
54#include <newclient.h>
55#include <newserver.h>
56#include <living.h> 48#include <living.h>
57#include <commands.h> 49#include <commands.h>
58 50
59/* This block is basically taken from socket.c - I assume if it works there, 51/* This block is basically taken from socket.c - I assume if it works there,
60 * it should work here. 52 * it should work here.
61 */ 53 */
62#ifndef WIN32 /* ---win32 exclude unix headers */
63# include <sys/types.h> 54#include <sys/types.h>
64# include <sys/time.h> 55#include <sys/time.h>
65# include <sys/socket.h> 56#include <sys/socket.h>
66# include <netinet/in.h> 57#include <netinet/in.h>
67# include <netdb.h> 58#include <netdb.h>
68#endif /* win32 */
69 59
70#ifdef HAVE_UNISTD_H
71# include <unistd.h> 60#include <unistd.h>
72#endif
73
74#ifdef HAVE_SYS_TIME_H
75# include <sys/time.h> 61#include <sys/time.h>
76#endif
77 62
78#include "sounds.h" 63#include "sounds.h"
79 64
80/** 65/**
81 * This table translates the attack numbers as used within the 66 * This table translates the attack numbers as used within the
… …
98 -1, /* life stealing */ 83 -1, /* life stealing */
99 -1 /* Disease - not fully done yet */ 84 -1 /* Disease - not fully done yet */
100}; 85};
101 86
102static void 87static void
103socket_map_scroll (NewSocket * ns, int dx, int dy) 88socket_map_scroll (client *ns, int dx, int dy)
104{ 89{
105 struct Map newmap; 90 struct Map newmap;
106 int x, y, mx, my; 91 int x, y, mx, my;
107 92
108 {
109 char buf[MAXSOCKBUF];
110
111 sprintf (buf, "map_scroll %d %d", dx, dy); 93 ns->send_packet_printf ("map_scroll %d %d", dx, dy);
112 Write_String_To_Socket (ns, buf, strlen (buf));
113 }
114 94
115 /* If we are using the Map1aCmd, we may in fact send 95 /* If we are using the Map1aCmd, we may in fact send
116 * head information that is outside the viewable map. 96 * head information that is outside the viewable map.
117 * So set the mx,my to the max value we want to 97 * So set the mx,my to the max value we want to
118 * look for. Removed code to do so - it caused extra 98 * look for. Removed code to do so - it caused extra
… …
137 for (x = 0; x < mx; x++) 117 for (x = 0; x < mx; x++)
138 { 118 {
139 for (y = 0; y < my; y++) 119 for (y = 0; y < my; y++)
140 { 120 {
141 if (x >= ns->mapx || y >= ns->mapy) 121 if (x >= ns->mapx || y >= ns->mapy)
142 {
143 /* clear cells outside the viewable area */ 122 /* clear cells outside the viewable area */
144 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell)); 123 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
145 }
146 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy) 124 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
147 {
148 /* clear newly visible tiles within the viewable area */ 125 /* clear newly visible tiles within the viewable area */
149 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell)); 126 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
150 }
151 else 127 else
152 {
153 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell)); 128 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
154 }
155 } 129 }
156 } 130 }
157 131
158 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map)); 132 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
159 133
… …
164} 138}
165 139
166static void 140static void
167clear_map (player *pl) 141clear_map (player *pl)
168{ 142{
169 NewSocket & socket = pl->socket;
170
171 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 143 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
172 144
173 if (socket.newmapcmd == 1) 145 if (pl->ns->newmapcmd == 1)
174 Write_String_To_Socket (&socket, "newmap", 6); 146 pl->ns->send_packet ("newmap");
175 147
176 socket.update_look = 1; 148 pl->ns->floorbox_reset ();
177 socket.look_position = 0;
178} 149}
179 150
180/** check for map change and send new map data */ 151/** check for map change and send new map data */
181static void 152static void
182check_map_change (player *pl) 153check_map_change (player *pl)
183{ 154{
184 NewSocket & socket = pl->socket; 155 client &socket = *pl->ns;
185 object *ob = pl->ob; 156 object *ob = pl->ob;
186 char buf[MAX_BUF]; /* eauugggh */ 157 char buf[MAX_BUF]; /* eauugggh */
187 158
188 if (socket.current_map != ob->map) 159 if (socket.current_map != ob->map)
189 { 160 {
… …
210 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 181 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path);
211 } 182 }
212 else 183 else
213 snprintf (buf, MAX_BUF, "mapinfo current"); 184 snprintf (buf, MAX_BUF, "mapinfo current");
214 185
215 Write_String_To_Socket (&socket, buf, strlen (buf)); 186 socket.send_packet (buf);
216 } 187 }
217 } 188 }
218 else if (socket.current_x != ob->x || socket.current_y != ob->y) 189 else if (socket.current_x != ob->x || socket.current_y != ob->y)
219 { 190 {
220 int dx = ob->x - socket.current_x; 191 int dx = ob->x - socket.current_x;
… …
223 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8)) 194 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
224 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows 195 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
225 else 196 else
226 { 197 {
227 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 198 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
228 socket.update_look = 1; 199 socket.floorbox_reset ();
229 socket.look_position = 0;
230 } 200 }
231 } 201 }
232 202
233 socket.current_x = ob->x; 203 socket.current_x = ob->x;
234 socket.current_y = ob->y; 204 socket.current_y = ob->y;
235} 205}
236 206
207/**
208 * RequestInfo is sort of a meta command. There is some specific
209 * request of information, but we call other functions to provide
210 * that information.
211 */
212void
213RequestInfo (char *buf, int len, client * ns)
214{
215 char *params = NULL, *cp;
216
217 /* No match */
218 char bigbuf[MAX_BUF];
219 int slen;
220
221 /* Set up replyinfo before we modify any of the buffers - this is used
222 * if we don't find a match.
223 */
224 strcpy (bigbuf, "replyinfo ");
225 slen = strlen (bigbuf);
226 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
227
228 /* find the first space, make it null, and update the
229 * params pointer.
230 */
231 for (cp = buf; *cp != '\0'; cp++)
232 if (*cp == ' ')
233 {
234 *cp = '\0';
235 params = cp + 1;
236 break;
237 }
238
239 if (!strcmp (buf, "image_info"))
240 send_image_info (ns, params);
241 else if (!strcmp (buf, "image_sums"))
242 send_image_sums (ns, params);
243 else if (!strcmp (buf, "skill_info"))
244 send_skill_info (ns, params);
245 else if (!strcmp (buf, "spell_paths"))
246 send_spell_paths (ns, params);
247 else
248 ns->send_packet (bigbuf, len);
249}
250
237void 251void
238ExtCmd (char *buf, int len, player *pl) 252ExtCmd (char *buf, int len, player *pl)
239{ 253{
240 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len)); 254 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
255}
256
257void
258ExtiCmd (char *buf, int len, client *ns)
259{
260 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
241} 261}
242 262
243void 263void
244MapInfoCmd (char *buf, int len, player *pl) 264MapInfoCmd (char *buf, int len, player *pl)
245{ 265{
… …
258 if (!strncmp (buf, "spatial ", 8)) 278 if (!strncmp (buf, "spatial ", 8))
259 { 279 {
260 buf += 8; 280 buf += 8;
261 281
262 // initial map and its origin 282 // initial map and its origin
263 mapstruct *map = pl->ob->map; 283 maptile *map = pl->ob->map;
264 sint16 dx, dy; 284 sint16 dx, dy;
265 int mapx = pl->socket.mapx / 2 - pl->ob->x; 285 int mapx = pl->ns->mapx / 2 - pl->ob->x;
266 int mapy = pl->socket.mapy / 2 - pl->ob->y; 286 int mapy = pl->ns->mapy / 2 - pl->ob->y;
267 int max_distance = 8; // limit maximum path length to something generous 287 int max_distance = 8; // limit maximum path length to something generous
268 288
269 while (*buf && map && max_distance) 289 while (*buf && map && max_distance)
270 { 290 {
271 int dir = *buf++; 291 int dir = *buf++;
… …
322 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 342 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token);
323 } 343 }
324 else 344 else
325 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 345 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
326 346
327 Write_String_To_Socket (&pl->socket, bigbuf, strlen (bigbuf)); 347 pl->ns->send_packet (bigbuf);
328} 348}
329 349
330/** This is the Setup cmd - easy first implementation */ 350/** This is the Setup cmd - easy first implementation */
331void 351void
332SetUp (char *buf, int len, NewSocket * ns) 352SetUp (char *buf, int len, client * ns)
333{ 353{
334 int s, slen; 354 int s, slen;
335 char *cmd, *param, cmdback[HUGE_BUF]; 355 char *cmd, *param, cmdback[HUGE_BUF];
336 356
337 /* run through the cmds of setup 357 /* run through the cmds of setup
… …
339 * 359 *
340 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown 360 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
341 * The client then must sort this out 361 * The client then must sort this out
342 */ 362 */
343 363
344 LOG (llevInfo, "Get SetupCmd:: %s\n", buf); 364 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
365
345 strcpy (cmdback, "setup"); 366 strcpy (cmdback, "setup");
346 for (s = 0; s < len;) 367 for (s = 0; s < len; )
347 { 368 {
348
349 cmd = &buf[s]; 369 cmd = &buf[s];
350 370
351 /* find the next space, and put a null there */ 371 /* find the next space, and put a null there */
352 for (; buf[s] && buf[s] != ' '; s++); 372 for (; buf[s] && buf[s] != ' '; s++)
373 ;
374
353 buf[s++] = 0; 375 buf[s++] = 0;
376
354 while (buf[s] == ' ') 377 while (buf[s] == ' ')
355 s++; 378 s++;
356 379
357 if (s >= len) 380 if (s >= len)
358 break; 381 break;
359 382
360 param = &buf[s]; 383 param = &buf[s];
361 384
362 for (; buf[s] && buf[s] != ' '; s++); 385 for (; buf[s] && buf[s] != ' '; s++)
386 ;
387
363 buf[s++] = 0; 388 buf[s++] = 0;
389
364 while (buf[s] == ' ') 390 while (buf[s] == ' ')
365 s++; 391 s++;
366 392
367 slen = strlen (cmdback); 393 slen = strlen (cmdback);
368 safe_strcat (cmdback, " ", &slen, HUGE_BUF); 394 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
… …
529 * report a failure to the client. 555 * report a failure to the client.
530 */ 556 */
531 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF); 557 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
532 } 558 }
533 } /* for processing all the setup commands */ 559 } /* for processing all the setup commands */
560
534 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback); 561 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
535 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 562 ns->send_packet (cmdback);
536} 563}
537 564
538/** 565/**
539 * The client has requested to be added to the game. 566 * The client has requested to be added to the game.
540 * This is what takes care of it. We tell the client how things worked out. 567 * This is what takes care of it. We tell the client how things worked out.
541 * I am not sure if this file is the best place for this function. however, 568 * I am not sure if this file is the best place for this function. however,
542 * it either has to be here or init_sockets needs to be exported. 569 * it either has to be here or init_sockets needs to be exported.
543 */ 570 */
544void 571void
545AddMeCmd (char *buf, int len, NewSocket * ns) 572AddMeCmd (char *buf, int len, client * ns)
546{ 573{
547 Settings oldsettings; 574 if (INVOKE_CLIENT (ADDME, ns))
575 return;
548 576
549 oldsettings = settings;
550 if (ns->status != Ns_Add || add_player (ns)) 577 if (ns->pl || add_player (ns))
551 { 578 ns->send_packet ("addme_failed");
552 Write_String_To_Socket (ns, "addme_failed", 12);
553 }
554 else 579 else
555 { 580 ns->send_packet ("addme_success");
556 /* Basically, the add_player copies the socket structure into
557 * the player structure, so this one (which is from init_sockets)
558 * is not needed anymore. The write below should still work, as the
559 * stuff in ns is still relevant.
560 */
561 Write_String_To_Socket (ns, "addme_success", 13);
562 socket_info.nconns--;
563 ns->status = Ns_Avail;
564 }
565 settings = oldsettings;
566} 581}
567 582
568/** Reply to ExtendedInfos command */ 583/** Reply to ExtendedInfos command */
569void 584void
570ToggleExtendedInfos (char *buf, int len, NewSocket * ns) 585ToggleExtendedInfos (char *buf, int len, client * ns)
571{ 586{
572 char cmdback[MAX_BUF]; 587 char cmdback[MAX_BUF];
573 char command[50]; 588 char command[50];
574 int info, nextinfo; 589 int info, nextinfo;
575 590
… …
613 { 628 {
614 strcat (cmdback, " "); 629 strcat (cmdback, " ");
615 strcat (cmdback, "smoothing"); 630 strcat (cmdback, "smoothing");
616 } 631 }
617 632
618 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 633 ns->send_packet (cmdback);
619} 634}
620 635
621/* 636/*
622#define MSG_TYPE_BOOK 1 637#define MSG_TYPE_BOOK 1
623#define MSG_TYPE_CARD 2 638#define MSG_TYPE_CARD 2
… …
626#define MSG_TYPE_MONUMENT 5 641#define MSG_TYPE_MONUMENT 5
627#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 642#define MSG_TYPE_SCRIPTED_DIALOG 6*/
628 643
629/** Reply to ExtendedInfos command */ 644/** Reply to ExtendedInfos command */
630void 645void
631ToggleExtendedText (char *buf, int len, NewSocket * ns) 646ToggleExtendedText (char *buf, int len, client * ns)
632{ 647{
633 char cmdback[MAX_BUF]; 648 char cmdback[MAX_BUF];
634 char temp[10]; 649 char temp[10];
635 char command[50]; 650 char command[50];
636 int info, nextinfo, i, flag; 651 int info, nextinfo, i, flag;
… …
676 strcat (cmdback, " "); 691 strcat (cmdback, " ");
677 snprintf (temp, sizeof (temp), "%d", i); 692 snprintf (temp, sizeof (temp), "%d", i);
678 strcat (cmdback, temp); 693 strcat (cmdback, temp);
679 } 694 }
680 695
681 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 696 ns->send_packet (cmdback);
682} 697}
683 698
684/** 699/**
685 * A lot like the old AskSmooth (in fact, now called by AskSmooth). 700 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
686 * Basically, it makes no sense to wait for the client to request a 701 * Basically, it makes no sense to wait for the client to request a
687 * a piece of data from us that we know the client wants. So 702 * a piece of data from us that we know the client wants. So
688 * if we know the client wants it, might as well push it to the 703 * if we know the client wants it, might as well push it to the
689 * client. 704 * client.
690 */ 705 */
691static void 706static void
692SendSmooth (NewSocket * ns, uint16 face) 707SendSmooth (client *ns, uint16 face)
693{ 708{
694 uint16 smoothface; 709 uint16 smoothface;
695 unsigned char reply[MAX_BUF];
696 SockList sl;
697 710
698 /* If we can't find a face, return and set it so we won't try to send this 711 /* If we can't find a face, return and set it so we won't try to send this
699 * again. 712 * again.
700 */ 713 */
701 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface))) 714 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
… …
709 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE)) 722 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
710 esrv_send_face (ns, smoothface, 0); 723 esrv_send_face (ns, smoothface, 0);
711 724
712 ns->faces_sent[face] |= NS_FACESENT_SMOOTH; 725 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
713 726
714 sl.buf = reply; 727 packet sl ("smooth");
715 strcpy ((char *) sl.buf, "smooth "); 728
716 sl.len = strlen ((char *) sl.buf); 729 sl << uint16 (face)
717 SockList_AddShort (&sl, face); 730 << uint16 (smoothface);
718 SockList_AddShort (&sl, smoothface); 731
719 Send_With_Handling (ns, &sl); 732 ns->send_packet (sl);
720} 733}
721 734
722 /** 735 /**
723 * Tells client the picture it has to use 736 * Tells client the picture it has to use
724 * to smooth a picture number given as argument. 737 * to smooth a picture number given as argument.
725 */ 738 */
726void 739void
727AskSmooth (char *buf, int len, NewSocket * ns) 740AskSmooth (char *buf, int len, client *ns)
728{ 741{
729 uint16 facenbr; 742 SendSmooth (ns, atoi (buf));
730
731 facenbr = atoi (buf);
732 SendSmooth (ns, facenbr);
733} 743}
734
735
736
737
738 744
739/** 745/**
740 * This handles the general commands from the client (ie, north, fire, cast, 746 * This handles the general commands from the client (ie, north, fire, cast,
741 * etc.) 747 * etc.)
742 */ 748 */
743void 749void
744PlayerCmd (char *buf, int len, player *pl) 750PlayerCmd (char *buf, int len, player *pl)
745{ 751{
746
747 /* The following should never happen with a proper or honest client.
748 * Therefore, the error message doesn't have to be too clear - if
749 * someone is playing with a hacked/non working client, this gives them
750 * an idea of the problem, but they deserve what they get
751 */
752 if (pl->state != ST_PLAYING)
753 {
754 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
755 return;
756 }
757 /* Check if there is a count. In theory, a zero count could also be 752 /* Check if there is a count. In theory, a zero count could also be
758 * sent, so check for that also. 753 * sent, so check for that also.
759 */ 754 */
760 if (atoi (buf) || buf[0] == '0') 755 if (atoi (buf) || buf[0] == '0')
761 { 756 {
762 pl->count = atoi ((char *) buf); 757 pl->count = atoi ((char *) buf);
758
763 buf = strchr (buf, ' '); /* advance beyond the numbers */ 759 buf = strchr (buf, ' '); /* advance beyond the numbers */
764 if (!buf) 760 if (!buf)
765 {
766#ifdef ESRV_DEBUG
767 LOG (llevDebug, "PlayerCmd: Got count but no command.\n");
768#endif
769 return; 761 return;
770 } 762
771 buf++; 763 buf++;
772 } 764 }
773 /* This should not happen anymore. */ 765
774 if (pl->ob->speed_left < -1.0)
775 {
776 LOG (llevError, "Player has negative time - shouldn't do command.\n");
777 }
778 /* In c_new.c */
779 execute_newserver_command (pl->ob, (char *) buf); 766 execute_newserver_command (pl->ob, (char *) buf);
767
780 /* Perhaps something better should be done with a left over count. 768 /* Perhaps something better should be done with a left over count.
781 * Cleaning up the input should probably be done first - all actions 769 * Cleaning up the input should probably be done first - all actions
782 * for the command that issued the count should be done before any other 770 * for the command that issued the count should be done before any other
783 * commands. 771 * commands.
784 */ 772 */
785
786 pl->count = 0; 773 pl->count = 0;
787
788} 774}
789 775
790 776
791/** 777/**
792 * This handles the general commands from the client (ie, north, fire, cast, 778 * This handles the general commands from the client (ie, north, fire, cast,
793 * etc.). It is a lot like PlayerCmd above, but is called with the 779 * etc.). It is a lot like PlayerCmd above, but is called with the
794 * 'ncom' method which gives more information back to the client so it 780 * 'ncom' method which gives more information back to the client so it
795 * can throttle. 781 * can throttle.
796 */ 782 */
797void 783void
798NewPlayerCmd (uint8 * buf, int len, player *pl) 784NewPlayerCmd (char *buf, int len, player *pl)
799{ 785{
800 int time, repeat;
801 short packet;
802 unsigned char command[MAX_BUF];
803 SockList sl;
804
805 if (len < 7) 786 if (len <= 6)
806 { 787 {
807 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 788 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
808 return; 789 return;
809 } 790 }
810 791
811 packet = GetShort_String (buf); 792 uint16 cmdid = net_uint16 ((uint8 *)buf);
812 repeat = GetInt_String (buf + 2); 793 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
794
813 /* -1 is special - no repeat, but don't update */ 795 /* -1 is special - no repeat, but don't update */
814 if (repeat != -1) 796 if (repeat != -1)
815 {
816 pl->count = repeat; 797 pl->count = repeat;
817 }
818 if ((len - 4) >= MAX_BUF)
819 len = MAX_BUF - 5;
820 798
821 strncpy ((char *) command, (char *) buf + 6, len - 4); 799 buf += 6; //len -= 6;
822 command[len - 4] = '\0';
823 800
824 /* The following should never happen with a proper or honest client.
825 * Therefore, the error message doesn't have to be too clear - if
826 * someone is playing with a hacked/non working client, this gives them
827 * an idea of the problem, but they deserve what they get
828 */
829 if (pl->state != ST_PLAYING)
830 {
831 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
832 return;
833 }
834
835 /* This should not happen anymore. */
836 if (pl->ob->speed_left < -1.0)
837 {
838 LOG (llevError, "Player has negative time - shouldn't do command.\n");
839 }
840 /* In c_new.c */
841 execute_newserver_command (pl->ob, (char *) command); 801 execute_newserver_command (pl->ob, buf);
802
842 /* Perhaps something better should be done with a left over count. 803 /* Perhaps something better should be done with a left over count.
843 * Cleaning up the input should probably be done first - all actions 804 * Cleaning up the input should probably be done first - all actions
844 * for the command that issued the count should be done before any other 805 * for the command that issued the count should be done before any other
845 * commands. 806 * commands.
846 */ 807 */
847 pl->count = 0; 808 pl->count = 0;
848 809
810 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
811 int time = FABS (pl->ob->speed) < 0.001
812 ? time = MAX_TIME * 100
813 : time = (int) (MAX_TIME / FABS (pl->ob->speed));
814
849 /* Send confirmation of command execution now */ 815 /* Send confirmation of command execution now */
850 sl.buf = command; 816 packet sl ("comc");
851 strcpy ((char *) sl.buf, "comc "); 817 sl << uint16 (cmdid) << uint32 (time);
852 sl.len = 5; 818 pl->ns->send_packet (sl);
853 SockList_AddShort (&sl, packet);
854 if (FABS (pl->ob->speed) < 0.001)
855 time = MAX_TIME * 100;
856 else
857 time = (int) (MAX_TIME / FABS (pl->ob->speed));
858 SockList_AddInt (&sl, time);
859 Send_With_Handling (&pl->socket, &sl);
860} 819}
861
862 820
863/** This is a reply to a previous query. */ 821/** This is a reply to a previous query. */
864void 822void
865ReplyCmd (char *buf, int len, player *pl) 823ReplyCmd (char *buf, int len, client *ns)
866{ 824{
825 if (ns->state == ST_CUSTOM)
826 {
827 INVOKE_CLIENT (REPLY, ns, ARG_DATA (buf, len));
828 return;
829 }
830
831 if (!ns->pl)
832 return; //TODO: depends on the exact reply we are after
833 //TODO: but right now, we always have a ns->pl
834
835 player *pl = ns->pl;
836
867 /* This is to synthesize how the data would be stored if it 837 /* This is to synthesize how the data would be stored if it
868 * was normally entered. A bit of a hack, and should be cleaned up 838 * was normally entered. A bit of a hack, and should be cleaned up
869 * once all the X11 code is removed from the server. 839 * once all the X11 code is removed from the server.
870 * 840 *
871 * We pass 13 to many of the functions because this way they 841 * We pass 13 to many of the functions because this way they
872 * think it was the carriage return that was entered, and the 842 * think it was the carriage return that was entered, and the
873 * function then does not try to do additional input. 843 * function then does not try to do additional input.
874 */ 844 */
875 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf); 845 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
876 846
877 /* this avoids any hacking here */ 847 /* this avoids any hacking here */
878 848
879 switch (pl->state) 849 switch (ns->state)
880 { 850 {
881 case ST_PLAYING: 851 case ST_PLAYING:
882 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 852 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
883 break; 853 break;
884 854
885 case ST_PLAY_AGAIN: 855 case ST_PLAY_AGAIN:
886 /* We can check this for return value (2==quit). Maybe we 856 /* We can check this for return value (2==quit). Maybe we
887 * should, and do something appropriate? 857 * should, and do something appropriate?
888 */ 858 */
889 receive_play_again (pl->ob, buf[0]); 859 receive_play_again (pl->ob, buf[0]);
890 break; 860 break;
891 861
892 case ST_ROLL_STAT: 862 case ST_ROLL_STAT:
893 key_roll_stat (pl->ob, buf[0]); 863 key_roll_stat (pl->ob, buf[0]);
894 break; 864 break;
895 865
896 case ST_CHANGE_CLASS: 866 case ST_CHANGE_CLASS:
897
898 key_change_class (pl->ob, buf[0]); 867 key_change_class (pl->ob, buf[0]);
899 break; 868 break;
900 869
901 case ST_CONFIRM_QUIT: 870 case ST_CONFIRM_QUIT:
902 key_confirm_quit (pl->ob, buf[0]); 871 key_confirm_quit (pl->ob, buf[0]);
903 break; 872 break;
904 873
905 case ST_CONFIGURE: 874 case ST_CONFIGURE:
906 LOG (llevError, "In client input handling, but into configure state\n"); 875 LOG (llevError, "In client input handling, but into configure state\n");
907 pl->state = ST_PLAYING; 876 ns->state = ST_PLAYING;
908 break; 877 break;
909 878
910 case ST_GET_NAME: 879 case ST_GET_NAME:
911 receive_player_name (pl->ob, 13); 880 receive_player_name (pl->ob, 13);
912 break; 881 break;
913 882
914 case ST_GET_PASSWORD: 883 case ST_GET_PASSWORD:
915 case ST_CONFIRM_PASSWORD: 884 case ST_CONFIRM_PASSWORD:
916 receive_player_password (pl->ob, 13); 885 receive_player_password (pl->ob, 13);
917 break; 886 break;
918 887
919 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 888 case ST_GET_PARTY_PASSWORD: /* Get password for party */
920 receive_party_password (pl->ob, 13); 889 receive_party_password (pl->ob, 13);
921 break; 890 break;
922 891
923 default: 892 default:
924 LOG (llevError, "Unknown input state: %d\n", pl->state); 893 LOG (llevError, "Unknown input state: %d\n", ns->state);
925 } 894 }
926} 895}
927 896
928/** 897/**
929 * Client tells its version. If there is a mismatch, we close the 898 * Client tells its version. If there is a mismatch, we close the
… …
931 * something older than the server. If we assume the client will be 900 * something older than the server. If we assume the client will be
932 * backwards compatible, having it be a later version should not be a 901 * backwards compatible, having it be a later version should not be a
933 * problem. 902 * problem.
934 */ 903 */
935void 904void
936VersionCmd (char *buf, int len, NewSocket * ns) 905VersionCmd (char *buf, int len, client * ns)
937{ 906{
938 char *cp;
939 char version_warning[256];
940
941 if (!buf) 907 if (!buf)
942 { 908 {
943 LOG (llevError, "CS: received corrupted version command\n"); 909 LOG (llevError, "CS: received corrupted version command\n");
944 return; 910 return;
945 } 911 }
946 912
947 ns->cs_version = atoi (buf); 913 ns->cs_version = atoi (buf);
948 ns->sc_version = ns->cs_version; 914 ns->sc_version = ns->cs_version;
915
916 LOG (llevDebug, "connection from client <%s>\n", buf);
917
918
919 //TODO: should log here just for statistics
920
949 if (VERSION_CS != ns->cs_version) 921 //if (VERSION_CS != ns->cs_version)
950 { 922 // unchecked;
951#ifdef ESRV_DEBUG 923
952 LOG (llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS, ns->cs_version);
953#endif
954 }
955 cp = strchr (buf + 1, ' '); 924 char *cp = strchr (buf + 1, ' ');
956 if (!cp) 925 if (!cp)
957 return; 926 return;
927
958 ns->sc_version = atoi (cp); 928 ns->sc_version = atoi (cp);
929
959 if (VERSION_SC != ns->sc_version) 930 //if (VERSION_SC != ns->sc_version)
960 { 931 // unchecked;
961#ifdef ESRV_DEBUG 932
962 LOG (llevDebug, "CS: scversion mismatch (%d,%d)\n", VERSION_SC, ns->sc_version);
963#endif
964 }
965 cp = strchr (cp + 1, ' '); 933 cp = strchr (cp + 1, ' ');
934
966 if (cp) 935 if (cp)
967 { 936 {
968 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host); 937 assign (ns->version, cp + 1);
969 938
970 snprintf (ns->client, sizeof (ns->client), "%s", cp + 1); 939 if (ns->sc_version < 1026)
971 940 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
972 /* This is first implementation - i skip all beta DX clients with it
973 * Add later stuff here for other clients
974 */
975
976 /* these are old dxclients */
977 /* Version 1024 added support for singular + plural name values -
978 * requiing this minimal value reduces complexity of that code, and it
979 * has been around for a long time.
980 */
981 if (!strcmp (" CF DX CLIENT", cp) || ns->sc_version < 1024)
982 {
983 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
984 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 941 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
985 Write_String_To_Socket (ns, version_warning, strlen (version_warning));
986 }
987
988 } 942 }
989} 943}
990 944
991/** sound related functions. */ 945/** sound related functions. */
992
993void 946void
994SetSound (char *buf, int len, NewSocket * ns) 947SetSound (char *buf, int len, client * ns)
995{ 948{
996 ns->sound = atoi (buf); 949 ns->sound = atoi (buf);
997} 950}
998 951
999/** client wants the map resent */ 952/** client wants the map resent */
1000 953
1001void 954void
1002MapRedrawCmd (char *buf, int len, player *pl) 955MapRedrawCmd (char *buf, int len, player *pl)
1003{ 956{
1004
1005/* This function is currently disabled; just clearing the map state results in 957/* This function is currently disabled; just clearing the map state results in
1006 * display errors. It should clear the cache and send a newmap command. 958 * display errors. It should clear the cache and send a newmap command.
1007 * Unfortunately this solution does not work because some client versions send 959 * Unfortunately this solution does not work because some client versions send
1008 * a mapredraw command after receiving a newmap command. 960 * a mapredraw command after receiving a newmap command.
1009 */ 961 */
1010#if 0
1011 /* Okay, this is MAJOR UGLY. but the only way I know how to
1012 * clear the "cache"
1013 */
1014 memset (&pl->socket.lastmap, 0, sizeof (struct Map));
1015 draw_client_map (pl->ob);
1016#endif
1017} 962}
1018 963
1019/** 964/**
1020 * Moves an object (typically, container to inventory). 965 * Moves an object (typically, container to inventory).
1021 * syntax is: move (to) (tag) (nrof) 966 * syntax is: move (to) (tag) (nrof)
… …
1024MoveCmd (char *buf, int len, player *pl) 969MoveCmd (char *buf, int len, player *pl)
1025{ 970{
1026 int vals[3], i; 971 int vals[3], i;
1027 972
1028 /* A little funky here. We only cycle for 2 records, because 973 /* A little funky here. We only cycle for 2 records, because
1029 * we obviously am not going to find a space after the third 974 * we obviously are not going to find a space after the third
1030 * record. Perhaps we should just replace this with a 975 * record. Perhaps we should just replace this with a
1031 * sscanf? 976 * sscanf?
1032 */ 977 */
1033 for (i = 0; i < 2; i++) 978 for (i = 0; i < 2; i++)
1034 { 979 {
1035 vals[i] = atoi (buf); 980 vals[i] = atoi (buf);
981
1036 if (!(buf = strchr (buf, ' '))) 982 if (!(buf = strchr (buf, ' ')))
1037 { 983 {
1038 LOG (llevError, "Incomplete move command: %s\n", buf); 984 LOG (llevError, "Incomplete move command: %s\n", buf);
1039 return; 985 return;
1040 } 986 }
987
1041 buf++; 988 buf++;
1042 } 989 }
990
1043 vals[2] = atoi (buf); 991 vals[2] = atoi (buf);
1044 992
1045/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/ 993/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
1046 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]); 994 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
1047} 995}
1048
1049
1050 996
1051/****************************************************************************** 997/******************************************************************************
1052 * 998 *
1053 * Start of commands the server sends to the client. 999 * Start of commands the server sends to the client.
1054 * 1000 *
… …
1057/** 1003/**
1058 * Asks the client to query the user. This way, the client knows 1004 * Asks the client to query the user. This way, the client knows
1059 * it needs to send something back (vs just printing out a message) 1005 * it needs to send something back (vs just printing out a message)
1060 */ 1006 */
1061void 1007void
1062send_query (NewSocket * ns, uint8 flags, char *text) 1008send_query (client *ns, uint8 flags, char *text)
1063{ 1009{
1064 char buf[MAX_BUF];
1065
1066 sprintf (buf, "query %d %s", flags, text ? text : ""); 1010 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
1067 Write_String_To_Socket (ns, buf, strlen (buf));
1068} 1011}
1069 1012
1070#define AddIfInt64(Old,New,Type) if (Old != New) {\ 1013#define AddIfInt64(Old,New,Type) if (Old != New) {\
1071 Old = New; \ 1014 Old = New; \
1072 SockList_AddChar(&sl, Type); \ 1015 sl << uint8 (Type) << uint64 (New); \
1073 SockList_AddInt64(&sl, New); \
1074 } 1016 }
1075 1017
1076#define AddIfInt(Old,New,Type) if (Old != New) {\ 1018#define AddIfInt(Old,New,Type) if (Old != New) {\
1077 Old = New; \ 1019 Old = New; \
1078 SockList_AddChar(&sl, Type); \ 1020 sl << uint8 (Type) << uint32 (New); \
1079 SockList_AddInt(&sl, New); \
1080 } 1021 }
1081 1022
1082#define AddIfShort(Old,New,Type) if (Old != New) {\ 1023#define AddIfShort(Old,New,Type) if (Old != New) {\
1083 Old = New; \ 1024 Old = New; \
1084 SockList_AddChar(&sl, Type); \ 1025 sl << uint8 (Type) << uint16 (New); \
1085 SockList_AddShort(&sl, New); \
1086 } 1026 }
1087 1027
1088#define AddIfFloat(Old,New,Type) if (Old != New) {\ 1028#define AddIfFloat(Old,New,Type) if (Old != New) {\
1089 Old = New; \ 1029 Old = New; \
1090 SockList_AddChar(&sl, Type); \ 1030 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \
1091 SockList_AddInt(&sl,(long)(New*FLOAT_MULTI));\
1092 } 1031 }
1093 1032
1094#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 1033#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1095 if (Old) free(Old);\
1096 Old = strdup_local(New);\ 1034 free(Old); Old = strdup (New);\
1097 SockList_AddChar(&sl, Type); \ 1035 sl << uint8 (Type) << data8 (New); \
1098 SockList_AddChar(&sl, ( char )strlen(New)); \
1099 strcpy((char*)sl.buf + sl.len, New); \
1100 sl.len += strlen(New); \
1101 } 1036 }
1102 1037
1103/** 1038/**
1104 * Sends a statistics update. We look at the old values, 1039 * Sends a statistics update. We look at the old values,
1105 * and only send what has changed. Stat mapping values are in newclient.h 1040 * and only send what has changed. Stat mapping values are in newclient.h
… …
1107 * commands for now. 1042 * commands for now.
1108 */ 1043 */
1109void 1044void
1110esrv_update_stats (player *pl) 1045esrv_update_stats (player *pl)
1111{ 1046{
1112 SockList sl;
1113 char buf[MAX_BUF]; 1047 char buf[MAX_BUF];
1114 uint16 flags; 1048 uint16 flags;
1115 1049
1116 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1050 packet sl ("stats");
1117 strcpy ((char *) sl.buf, "stats ");
1118 sl.len = strlen ((char *) sl.buf);
1119 1051
1120 if (pl->ob != NULL) 1052 if (pl->ob)
1121 { 1053 {
1122 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 1054 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP);
1123 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 1055 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP);
1124 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 1056 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP);
1125 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 1057 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP);
… …
1131 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS); 1063 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1132 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 1064 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX);
1133 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 1065 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON);
1134 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 1066 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA);
1135 } 1067 }
1068
1136 if (pl->socket.exp64) 1069 if (pl->ns->exp64)
1137 {
1138 uint8 s;
1139
1140 for (s = 0; s < NUM_SKILLS; s++) 1070 for (int s = 0; s < NUM_SKILLS; s++)
1141 {
1142 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 1071 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp)
1143 { 1072 {
1144
1145 /* Always send along the level if exp changes. This is only 1073 /* Always send along the level if exp changes. This is only
1146 * 1 extra byte, but keeps processing simpler. 1074 * 1 extra byte, but keeps processing simpler.
1147 */ 1075 */
1148 SockList_AddChar (&sl, (char) (s + CS_STAT_SKILLINFO)); 1076 sl << uint8 (s + CS_STAT_SKILLINFO)
1149 SockList_AddChar (&sl, (char) pl->last_skill_ob[s]->level); 1077 << uint8 (pl->last_skill_ob[s]->level)
1150 SockList_AddInt64 (&sl, pl->last_skill_ob[s]->stats.exp); 1078 << uint64 (pl->last_skill_ob[s]->stats.exp);
1079
1151 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp; 1080 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1152 } 1081 }
1153 } 1082
1154 }
1155 if (pl->socket.exp64) 1083 if (pl->ns->exp64)
1156 {
1157 AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64); 1084 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) }
1158 }
1159 else 1085 else
1160 {
1161 AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP); 1086 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1162 } 1087
1163 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 1088 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL);
1164 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 1089 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC);
1165 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 1090 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC);
1166 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 1091 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM);
1167 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 1092 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED);
1168 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 1093 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD);
1169 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 1094 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1170 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 1095 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM);
1171 flags = 0; 1096 flags = 0;
1097
1172 if (pl->fire_on) 1098 if (pl->fire_on)
1173 flags |= SF_FIREON; 1099 flags |= SF_FIREON;
1100
1174 if (pl->run_on) 1101 if (pl->run_on)
1175 flags |= SF_RUNON; 1102 flags |= SF_RUNON;
1176 1103
1177 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 1104 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS);
1105
1178 if (pl->socket.sc_version < 1025) 1106 if (pl->ns->sc_version < 1025)
1179 {
1180 AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR); 1107 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1181 }
1182 else 1108 else
1183 {
1184 int i;
1185
1186 for (i = 0; i < NROFATTACKS; i++) 1109 for (int i = 0; i < NROFATTACKS; i++)
1187 { 1110 {
1188 /* Skip ones we won't send */ 1111 /* Skip ones we won't send */
1189 if (atnr_cs_stat[i] == -1) 1112 if (atnr_cs_stat[i] == -1)
1190 continue; 1113 continue;
1114
1191 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 1115 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]);
1192 } 1116 }
1193 } 1117
1194 if (pl->socket.monitor_spells) 1118 if (pl->ns->monitor_spells)
1195 { 1119 {
1196 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 1120 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1197 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 1121 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL);
1198 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 1122 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY);
1199 } 1123 }
1124
1200 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 1125 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */
1201 AddIfString (pl->socket.stats.range, buf, CS_STAT_RANGE); 1126 AddIfString (pl->ns->stats.range, buf, CS_STAT_RANGE);
1202 set_title (pl->ob, buf); 1127 set_title (pl->ob, buf);
1203 AddIfString (pl->socket.stats.title, buf, CS_STAT_TITLE); 1128 AddIfString (pl->ns->stats.title, buf, CS_STAT_TITLE);
1204 1129
1205 /* Only send it away if we have some actual data */ 1130 /* Only send it away if we have some actual data */
1206 if (sl.len > 6) 1131 if (sl.length () > 6)
1207 { 1132 pl->ns->send_packet (sl);
1208#ifdef ESRV_DEBUG
1209 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1210#endif
1211 Send_With_Handling (&pl->socket, &sl);
1212 }
1213 free (sl.buf);
1214} 1133}
1215
1216 1134
1217/** 1135/**
1218 * Tells the client that here is a player it should start using. 1136 * Tells the client that here is a player it should start using.
1219 */ 1137 */
1220void 1138void
1221esrv_new_player (player *pl, uint32 weight) 1139esrv_new_player (player *pl, uint32 weight)
1222{ 1140{
1223 SockList sl;
1224
1225 pl->last_weight = weight; 1141 pl->last_weight = weight;
1226 1142
1227 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1143 packet sl ("player");
1228 1144
1229 strcpy ((char *) sl.buf, "player "); 1145 sl << uint32 (pl->ob->count)
1230 sl.len = strlen ((char *) sl.buf); 1146 << uint32 (weight)
1231 SockList_AddInt (&sl, pl->ob->count); 1147 << uint32 (pl->ob->face->number)
1232 SockList_AddInt (&sl, weight); 1148 << data8 (pl->ob->name);
1233 SockList_AddInt (&sl, pl->ob->face->number);
1234 1149
1235 SockList_AddChar (&sl, (char) strlen (pl->ob->name)); 1150 pl->ns->send_packet (sl);
1236 strcpy ((char *) sl.buf + sl.len, pl->ob->name);
1237 sl.len += strlen (pl->ob->name);
1238
1239 Send_With_Handling (&pl->socket, &sl);
1240 free (sl.buf);
1241 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1151 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1242} 1152}
1243
1244 1153
1245/** 1154/**
1246 * Need to send an animation sequence to the client. 1155 * Need to send an animation sequence to the client.
1247 * We will send appropriate face commands to the client if we haven't 1156 * We will send appropriate face commands to the client if we haven't
1248 * sent them the face yet (this can become quite costly in terms of 1157 * sent them the face yet (this can become quite costly in terms of
1249 * how much we are sending - on the other hand, this should only happen 1158 * how much we are sending - on the other hand, this should only happen
1250 * when the player logs in and picks stuff up. 1159 * when the player logs in and picks stuff up.
1251 */ 1160 */
1252void 1161void
1253esrv_send_animation (NewSocket * ns, short anim_num) 1162esrv_send_animation (client * ns, short anim_num)
1254{ 1163{
1255 SockList sl;
1256 int i;
1257
1258 /* Do some checking on the anim_num we got. Note that the animations 1164 /* Do some checking on the anim_num we got. Note that the animations
1259 * are added in contigous order, so if the number is in the valid 1165 * are added in contigous order, so if the number is in the valid
1260 * range, it must be a valid animation. 1166 * range, it must be a valid animation.
1261 */ 1167 */
1262 if (anim_num < 0 || anim_num > num_animations) 1168 if (anim_num < 0 || anim_num > num_animations)
1263 { 1169 {
1264 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num); 1170 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1265 return; 1171 return;
1266 } 1172 }
1267 1173
1268 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1174 packet sl ("anim");
1269 strcpy ((char *) sl.buf, "anim "); 1175
1270 sl.len = 5; 1176 sl << uint16 (anim_num)
1271 SockList_AddShort (&sl, anim_num); 1177 << uint16 (0); /* flags - not used right now */
1272 SockList_AddShort (&sl, 0); /* flags - not used right now */ 1178
1273 /* Build up the list of faces. Also, send any information (ie, the 1179 /* Build up the list of faces. Also, send any information (ie, the
1274 * the face itself) down to the client. 1180 * the face itself) down to the client.
1275 */ 1181 */
1276 for (i = 0; i < animations[anim_num].num_animations; i++) 1182 for (int i = 0; i < animations[anim_num].num_animations; i++)
1277 { 1183 {
1278 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE)) 1184 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1279 esrv_send_face (ns, animations[anim_num].faces[i], 0); 1185 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1186
1280 SockList_AddShort (&sl, animations[anim_num].faces[i]); /* flags - not used right now */ 1187 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1281 } 1188 }
1282 Send_With_Handling (ns, &sl); 1189
1283 free (sl.buf); 1190 ns->send_packet (sl);
1191
1284 ns->anims_sent[anim_num] = 1; 1192 ns->anims_sent[anim_num] = 1;
1285} 1193}
1286 1194
1287 1195
1288/****************************************************************************** 1196/******************************************************************************
… …
1294/** 1202/**
1295 * This adds face_num to a map cell at x,y. If the client doesn't have 1203 * This adds face_num to a map cell at x,y. If the client doesn't have
1296 * the face yet, we will also send it. 1204 * the face yet, we will also send it.
1297 */ 1205 */
1298static void 1206static void
1299esrv_map_setbelow (NewSocket * ns, int x, int y, short face_num, struct Map *newmap) 1207esrv_map_setbelow (client * ns, int x, int y, short face_num, struct Map *newmap)
1300{ 1208{
1301 if (newmap->cells[x][y].count >= MAP_LAYERS) 1209 if (newmap->cells[x][y].count >= MAP_LAYERS)
1302 { 1210 {
1211 //TODO: one or the other, can't both have abort and return, verify and act
1303 LOG (llevError, "Too many faces in map cell %d %d\n", x, y); 1212 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1304 return; 1213 return;
1305 abort (); 1214 abort ();
1306 } 1215 }
1216
1307 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num; 1217 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1308 newmap->cells[x][y].count++; 1218 newmap->cells[x][y].count++;
1219
1309 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1220 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1310 esrv_send_face (ns, face_num, 0); 1221 esrv_send_face (ns, face_num, 0);
1311} 1222}
1312
1313struct LayerCell
1314{
1315 uint16 xy;
1316 short face;
1317};
1318
1319struct MapLayer
1320{
1321 int count;
1322 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1323};
1324
1325/** Checkes if map cells have changed */
1326static int
1327mapcellchanged (NewSocket * ns, int i, int j, struct Map *newmap)
1328{
1329 int k;
1330
1331 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1332 return 1;
1333 for (k = 0; k < newmap->cells[i][j].count; k++)
1334 {
1335 if (ns->lastmap.cells[i][j].faces[k] != newmap->cells[i][j].faces[k])
1336 {
1337 return 1;
1338 }
1339 }
1340 return 0;
1341}
1342
1343/**
1344 * Basically, what this does is pack the data into layers.
1345 * cnum is the client number, cur is the the buffer we put all of
1346 * this data into. we return the end of the data. layers is
1347 * how many layers of data we should back.
1348 */
1349static uint8 *
1350compactlayer (NewSocket * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1351{
1352 int x, y, k;
1353 int face;
1354 unsigned char *fcur;
1355 struct MapLayer layers[MAP_LAYERS];
1356
1357 for (k = 0; k < MAP_LAYERS; k++)
1358 layers[k].count = 0;
1359 fcur = cur;
1360 for (x = 0; x < ns->mapx; x++)
1361 {
1362 for (y = 0; y < ns->mapy; y++)
1363 {
1364 if (!mapcellchanged (ns, x, y, newmap))
1365 continue;
1366 if (newmap->cells[x][y].count == 0)
1367 {
1368 *cur = x * ns->mapy + y; /* mark empty space */
1369 cur++;
1370 continue;
1371 }
1372 for (k = 0; k < newmap->cells[x][y].count; k++)
1373 {
1374 layers[k].lcells[layers[k].count].xy = x * ns->mapy + y;
1375 layers[k].lcells[layers[k].count].face = newmap->cells[x][y].faces[k];
1376 layers[k].count++;
1377 }
1378 }
1379 }
1380 /* If no data, return now. */
1381 if (fcur == cur && layers[0].count == 0)
1382 return cur;
1383 *cur = 255; /* mark end of explicitly cleared cells */
1384 cur++;
1385 /* First pack by layers. */
1386 for (k = 0; k < numlayers; k++)
1387 {
1388 if (layers[k].count == 0)
1389 break; /* once a layer is entirely empty, no layer below it can
1390 have anything in it either */
1391 /* Pack by entries in thie layer */
1392 for (x = 0; x < layers[k].count;)
1393 {
1394 fcur = cur;
1395 *cur = layers[k].lcells[x].face >> 8;
1396 cur++;
1397 *cur = layers[k].lcells[x].face & 0xFF;
1398 cur++;
1399 face = layers[k].lcells[x].face;
1400 /* Now, we back the redundant data into 1 byte xy pairings */
1401 for (y = x; y < layers[k].count; y++)
1402 {
1403 if (layers[k].lcells[y].face == face)
1404 {
1405 *cur = (uint8) layers[k].lcells[y].xy;
1406 cur++;
1407 layers[k].lcells[y].face = -1;
1408 }
1409 }
1410 *(cur - 1) = *(cur - 1) | 128; /* mark for end of xy's; 11*11 < 128 */
1411 /* forward over the now redundant data */
1412 while (x < layers[k].count && layers[k].lcells[x].face == -1)
1413 x++;
1414 }
1415 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1416 }
1417 return cur;
1418}
1419
1420static void
1421esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1422{
1423 static long frames, bytes, tbytes, tframes;
1424 char *cur;
1425 SockList sl;
1426
1427
1428 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1429 strcpy ((char *) sl.buf, "map ");
1430 sl.len = strlen ((char *) sl.buf);
1431
1432 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1433 sl.len = cur - (char *) sl.buf;
1434
1435/* LOG(llevDebug, "Sending map command.\n");*/
1436
1437 if (sl.len > (int) strlen ("map ") || ns->sent_scroll)
1438 {
1439 /* All of this is just accounting stuff */
1440 if (tframes > 100)
1441 tframes = tbytes = 0;
1442
1443 tframes++;
1444 frames++;
1445 tbytes += sl.len;
1446 bytes += sl.len;
1447 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1448 Send_With_Handling (ns, &sl);
1449 ns->sent_scroll = 0;
1450 }
1451
1452 free (sl.buf);
1453}
1454
1455 1223
1456/** Clears a map cell */ 1224/** Clears a map cell */
1457static void 1225static void
1458map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 1226map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count)
1459{ 1227{
1460 cell->faces[0] = face0; 1228 cell->faces[0] = face0;
1461 cell->faces[1] = face1; 1229 cell->faces[1] = face1;
1462 cell->faces[2] = face2; 1230 cell->faces[2] = face2;
1463 cell->count = count; 1231 cell->count = count;
1464 cell->stat_hp = 0; 1232 cell->stat_hp = 0;
1233 cell->flags = 0;
1465 cell->player = 0; 1234 cell->player = 0;
1466} 1235}
1467 1236
1468#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y) 1237#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1469#define MAX_LAYERS 3 1238#define MAX_LAYERS 3
1470 1239
1471/* Using a global really isn't a good approach, but saves the over head of 1240/* Using a global really isn't a good approach, but saves the over head of
1472 * allocating and deallocating such a block of data each time run through, 1241 * allocating and deallocating such a block of data each time run through,
1473 * and saves the space of allocating this in the socket object when we only 1242 * and saves the space of allocating this in the socket object when we only
1474 * need it for this cycle. If the serve is ever threaded, this needs to be 1243 * need it for this cycle. If the server is ever threaded, this needs to be
1475 * re-examined. 1244 * re-examined.
1476 */ 1245 */
1477
1478static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS]; 1246static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1479 1247
1480/** 1248/**
1481 * Returns true if any of the heads for this 1249 * Returns true if any of the heads for this
1482 * space is set. Returns false if all are blank - this is used 1250 * space is set. Returns false if all are blank - this is used
1483 * for empty space checking. 1251 * for empty space checking.
1484 */ 1252 */
1485static inline int 1253static inline int
1486have_head (int ax, int ay) 1254have_head (int ax, int ay)
1487{ 1255{
1488
1489 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] || 1256 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1490 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2]) 1257 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1491 return 1; 1258 return 1;
1259
1492 return 0; 1260 return 0;
1493} 1261}
1494 1262
1495/** 1263/**
1496 * check_head is a bit simplistic version of update_space below. 1264 * check_head is a bit simplistic version of update_space below.
1497 * basically, it only checks the that the head on space ax,ay at layer 1265 * basically, it only checks the that the head on space ax,ay at layer
1498 * needs to get sent - if so, it adds the data, sending the head 1266 * needs to get sent - if so, it adds the data, sending the head
1499 * if needed, and returning 1. If this no data needs to get 1267 * if needed, and returning 1. If this no data needs to get
1500 * sent, it returns zero. 1268 * sent, it returns zero.
1501 */ 1269 */
1502static int 1270static int
1503check_head (SockList & sl, NewSocket & ns, int ax, int ay, int layer) 1271check_head (packet &sl, client &ns, int ax, int ay, int layer)
1504{ 1272{
1505 short face_num; 1273 short face_num;
1506 1274
1507 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]) 1275 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1508 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number; 1276 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1509 else 1277 else
1510 face_num = 0; 1278 face_num = 0;
1511 1279
1512 if (face_num != ns.lastmap.cells[ax][ay].faces[layer]) 1280 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1513 { 1281 {
1514 SockList_AddShort (&sl, face_num); 1282 sl << uint16 (face_num);
1515 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1283 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1516 esrv_send_face (&ns, face_num, 0); 1284 esrv_send_face (&ns, face_num, 0);
1285
1517 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL; 1286 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1518 ns.lastmap.cells[ax][ay].faces[layer] = face_num; 1287 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1519 return 1; 1288 return 1;
1520 } 1289 }
1521 1290
… …
1539 * numbers the spaces differently - I think this was a leftover from 1308 * numbers the spaces differently - I think this was a leftover from
1540 * the map command, where the faces stack up. Sinces that is no longer 1309 * the map command, where the faces stack up. Sinces that is no longer
1541 * the case, it seems to make more sense to have these layer values 1310 * the case, it seems to make more sense to have these layer values
1542 * actually match. 1311 * actually match.
1543 */ 1312 */
1544
1545static int 1313static int
1546update_space (SockList * sl, NewSocket * ns, mapstruct *mp, int mx, int my, int sx, int sy, int layer) 1314update_space (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1547{ 1315{
1548 object *ob, *head; 1316 object *ob, *head;
1549 uint16 face_num; 1317 uint16 face_num;
1550 int bx, by, i; 1318 int bx, by, i;
1551 1319
1552 /* If there is a multipart object stored away, treat that as more important. 1320 /* If there is a multipart object stored away, treat that as more important.
1553 * If not, then do the normal processing. 1321 * If not, then do the normal processing.
1554 */ 1322 */
1555
1556 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer]; 1323 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1557 1324
1558 /* Check to see if this head is part of the set of objects 1325 /* Check to see if this head is part of the set of objects
1559 * we would normally send for this space. If so, then 1326 * we would normally send for this space. If so, then
1560 * don't use the head value. We need to do the check 1327 * don't use the head value. We need to do the check
… …
1725 1492
1726 /* Another hack - because of heads and whatnot, this face may match one 1493 /* Another hack - because of heads and whatnot, this face may match one
1727 * we already sent for a lower layer. In that case, don't send 1494 * we already sent for a lower layer. In that case, don't send
1728 * this one. 1495 * this one.
1729 */ 1496 */
1730 if (face_num && layer + 1 < MAP_LAYERS && ns->lastmap.cells[sx][sy].faces[layer + 1] == face_num) 1497 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1731 {
1732 face_num = 0; 1498 face_num = 0;
1733 }
1734 1499
1735 /* We've gotten what face we want to use for the object. Now see if 1500 /* We've gotten what face we want to use for the object. Now see if
1736 * if it has changed since we last sent it to the client. 1501 * if it has changed since we last sent it to the client.
1737 */ 1502 */
1738 if (ns->lastmap.cells[sx][sy].faces[layer] != face_num) 1503 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num)
1739 { 1504 {
1740 ns->lastmap.cells[sx][sy].faces[layer] = face_num; 1505 ns.lastmap.cells[sx][sy].faces[layer] = face_num;
1741 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1506 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1742 esrv_send_face (ns, face_num, 0); 1507 esrv_send_face (&ns, face_num, 0);
1743 SockList_AddShort (sl, face_num); 1508
1509 sl << uint16 (face_num);
1744 return 1; 1510 return 1;
1745 } 1511 }
1512
1746 /* Nothing changed */ 1513 /* Nothing changed */
1747 return 0; 1514 return 0;
1748} 1515}
1749 1516
1750/** 1517/**
… …
1765 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ 1532 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1766 * take. 1533 * take.
1767 */ 1534 */
1768 1535
1769static inline int 1536static inline int
1770update_smooth (SockList * sl, NewSocket * ns, mapstruct *mp, int mx, int my, int sx, int sy, int layer) 1537update_smooth (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1771{ 1538{
1772 object *ob; 1539 object *ob;
1773 int smoothlevel; /* old face_num; */ 1540 int smoothlevel; /* old face_num; */
1774 1541
1775 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer); 1542 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
… …
1780 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp)) 1547 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1781 smoothlevel = 0; 1548 smoothlevel = 0;
1782 else 1549 else
1783 { 1550 {
1784 smoothlevel = ob->smoothlevel; 1551 smoothlevel = ob->smoothlevel;
1785 if (smoothlevel && !(ns->faces_sent[ob->face->number] & NS_FACESENT_SMOOTH)) 1552 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1786 SendSmooth (ns, ob->face->number); 1553 SendSmooth (&ns, ob->face->number);
1787 } /* else not already head object or blank face */ 1554 } /* else not already head object or blank face */
1788 1555
1789 /* We've gotten what face we want to use for the object. Now see if 1556 /* We've gotten what face we want to use for the object. Now see if
1790 * if it has changed since we last sent it to the client. 1557 * if it has changed since we last sent it to the client.
1791 */ 1558 */
1792 if (smoothlevel > 255) 1559 if (smoothlevel > 255)
1793 smoothlevel = 255; 1560 smoothlevel = 255;
1794 else if (smoothlevel < 0) 1561 else if (smoothlevel < 0)
1795 smoothlevel = 0; 1562 smoothlevel = 0;
1563
1796 if (ns->lastmap.cells[sx][sy].smooth[layer] != smoothlevel) 1564 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1797 { 1565 {
1798 ns->lastmap.cells[sx][sy].smooth[layer] = smoothlevel; 1566 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1799 SockList_AddChar (sl, (uint8) (smoothlevel & 0xFF)); 1567 sl << uint8 (smoothlevel);
1800 return 1; 1568 return 1;
1801 } 1569 }
1570
1802 /* Nothing changed */ 1571 /* Nothing changed */
1803 return 0; 1572 return 0;
1804} 1573}
1805 1574
1806/** 1575/**
1807 * Returns the size of a data for a map square as returned by 1576 * Returns the size of a data for a map square as returned by
1808 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries 1577 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1809 * available. 1578 * available.
1810 */ 1579 */
1811int 1580int
1812getExtendedMapInfoSize (NewSocket * ns) 1581getExtendedMapInfoSize (client * ns)
1813{ 1582{
1814 int result = 0; 1583 int result = 0;
1815 1584
1816 if (ns->ext_mapinfos) 1585 if (ns->ext_mapinfos)
1817 { 1586 {
1818 if (ns->EMI_smooth) 1587 if (ns->EMI_smooth)
1819 result += 1; /*One byte for smoothlevel */ 1588 result += 1; /*One byte for smoothlevel */
1820 } 1589 }
1590
1821 return result; 1591 return result;
1822} 1592}
1823 1593
1824/** 1594/**
1825 * This function uses the new map1 protocol command to send the map 1595 * This function uses the new map1 protocol command to send the map
… …
1832 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off 1602 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1833 * maps no sense. Instead, we actually really only use 12 bits for coordinates, 1603 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1834 * and use the other 4 bits for other informatiion. For full documentation 1604 * and use the other 4 bits for other informatiion. For full documentation
1835 * of what we send, see the doc/Protocol file. 1605 * of what we send, see the doc/Protocol file.
1836 * I will describe internally what we do: 1606 * I will describe internally what we do:
1837 * the socket->lastmap shows how the map last looked when sent to the client. 1607 * the ns->lastmap shows how the map last looked when sent to the client.
1838 * in the lastmap structure, there is a cells array, which is set to the 1608 * in the lastmap structure, there is a cells array, which is set to the
1839 * maximum viewable size (As set in config.h). 1609 * maximum viewable size (As set in config.h).
1840 * in the cells, there are faces and a count value. 1610 * in the cells, there are faces and a count value.
1841 * we use the count value to hold the darkness value. If -1, then this space 1611 * we use the count value to hold the darkness value. If -1, then this space
1842 * is not viewable. 1612 * is not viewable.
… …
1847draw_client_map1 (object *pl) 1617draw_client_map1 (object *pl)
1848{ 1618{
1849 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1619 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen;
1850 sint16 nx, ny; 1620 sint16 nx, ny;
1851 int estartlen, eoldlen; 1621 int estartlen, eoldlen;
1852 SockList sl;
1853 SockList esl; /*For extended Map info */
1854 uint16 mask, emask; 1622 uint16 mask, emask;
1855 uint8 eentrysize; 1623 uint8 eentrysize;
1856 uint16 ewhatstart, ewhatflag; 1624 uint16 ewhatstart, ewhatflag;
1857 uint8 extendedinfos; 1625 uint8 extendedinfos;
1858 mapstruct *m; 1626 maptile *m;
1859 1627
1860 NewSocket & socket = pl->contr->socket; 1628 client &socket = *pl->contr->ns;
1861 1629
1862 check_map_change (pl->contr); 1630 check_map_change (pl->contr);
1863 1631
1864 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1632 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1865 if (socket.mapmode == Map1Cmd) 1633 packet esl;
1866 strcpy ((char *) sl.buf, "map1 "); 1634
1867 else
1868 strcpy ((char *) sl.buf, "map1a ");
1869 sl.len = strlen ((char *) sl.buf);
1870 startlen = sl.len; 1635 startlen = sl.length ();
1636
1871 /*Extendedmapinfo structure initialisation */ 1637 /*Extendedmapinfo structure initialisation */
1872 if (socket.ext_mapinfos) 1638 if (socket.ext_mapinfos)
1873 { 1639 {
1874 esl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1875 strcpy ((char *) esl.buf, "mapextended ");
1876 esl.len = strlen ((char *) esl.buf);
1877 extendedinfos = EMI_NOREDRAW; 1640 extendedinfos = EMI_NOREDRAW;
1641
1878 if (socket.EMI_smooth) 1642 if (socket.EMI_smooth)
1879 extendedinfos |= EMI_SMOOTH; 1643 extendedinfos |= EMI_SMOOTH;
1644
1880 ewhatstart = esl.len; 1645 ewhatstart = esl.length ();
1881 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 1646 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1882 could need to be taken away */ 1647 could need to be taken away */
1883 SockList_AddChar (&esl, extendedinfos);
1884 eentrysize = getExtendedMapInfoSize (&socket); 1648 eentrysize = getExtendedMapInfoSize (&socket);
1885 SockList_AddChar (&esl, eentrysize); 1649 esl << "mapextended "
1650 << uint8 (extendedinfos)
1651 << uint8 (eentrysize);
1652
1886 estartlen = esl.len; 1653 estartlen = esl.length ();
1887 } 1654 }
1888 else 1655 else
1889 { 1656 {
1890 /* suppress compiler warnings */ 1657 /* suppress compiler warnings */
1891 ewhatstart = 0; 1658 ewhatstart = 0;
1892 ewhatflag = 0; 1659 ewhatflag = 0;
1893 estartlen = 0; 1660 estartlen = 0;
1894 } 1661 }
1662
1895 /* Init data to zero */ 1663 /* Init data to zero */
1896 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS); 1664 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1897 1665
1898 /* x,y are the real map locations. ax, ay are viewport relative 1666 /* x,y are the real map locations. ax, ay are viewport relative
1899 * locations. 1667 * locations.
… …
1903 /* We could do this logic as conditionals in the if statement, 1671 /* We could do this logic as conditionals in the if statement,
1904 * but that started to get a bit messy to look at. 1672 * but that started to get a bit messy to look at.
1905 */ 1673 */
1906 max_x = pl->x + (socket.mapx + 1) / 2; 1674 max_x = pl->x + (socket.mapx + 1) / 2;
1907 max_y = pl->y + (socket.mapy + 1) / 2; 1675 max_y = pl->y + (socket.mapy + 1) / 2;
1676
1908 if (socket.mapmode == Map1aCmd) 1677 if (socket.mapmode == Map1aCmd)
1909 { 1678 {
1910 max_x += MAX_HEAD_OFFSET; 1679 max_x += MAX_HEAD_OFFSET;
1911 max_y += MAX_HEAD_OFFSET; 1680 max_y += MAX_HEAD_OFFSET;
1912 } 1681 }
… …
1914 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1683 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1915 { 1684 {
1916 ax = 0; 1685 ax = 0;
1917 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1686 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1918 { 1687 {
1919
1920 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1688 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1921 1689
1922 /* If this space is out of the normal viewable area, we only check 1690 /* If this space is out of the normal viewable area, we only check
1923 * the heads value ax or ay will only be greater than what 1691 * the heads value ax or ay will only be greater than what
1924 * the client wants if using the map1a command - this is because 1692 * the client wants if using the map1a command - this is because
… …
1927 */ 1695 */
1928 if (ax >= socket.mapx || ay >= socket.mapy) 1696 if (ax >= socket.mapx || ay >= socket.mapy)
1929 { 1697 {
1930 int i, got_one; 1698 int i, got_one;
1931 1699
1932 oldlen = sl.len; 1700 oldlen = sl.length ();
1933 1701
1934 SockList_AddShort (&sl, mask); 1702 sl << uint16 (mask);
1935 1703
1936 if (check_head (sl, socket, ax, ay, 2)) 1704 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1937 mask |= 0x4;
1938 if (check_head (sl, socket, ax, ay, 1)) 1705 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1939 mask |= 0x2;
1940 if (check_head (sl, socket, ax, ay, 0)) 1706 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1941 mask |= 0x1;
1942 1707
1943 /* If all we are doing is sending 0 (blank) faces, we don't 1708 /* If all we are doing is sending 0 (blank) faces, we don't
1944 * actually need to send that - just the coordinates 1709 * actually need to send that - just the coordinates
1945 * with no faces tells the client to blank out the 1710 * with no faces tells the client to blank out the
1946 * space. 1711 * space.
1947 */ 1712 */
1948 got_one = 0; 1713 got_one = 0;
1949 for (i = oldlen + 2; i < sl.len; i++) 1714 for (i = oldlen + 2; i < sl.length (); i++)
1950 {
1951 if (sl.buf[i]) 1715 if (sl[i])
1952 got_one = 1; 1716 got_one = 1;
1953 }
1954 1717
1955 if (got_one && (mask & 0xf)) 1718 if (got_one && (mask & 0xf))
1956 {
1957 sl.buf[oldlen + 1] = mask & 0xff; 1719 sl[oldlen + 1] = mask & 0xff;
1958 }
1959 else 1720 else
1960 { /*either all faces blank, either no face at all */ 1721 { /*either all faces blank, either no face at all */
1961 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */ 1722 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1962 sl.len = oldlen + 2; 1723 sl.reset (oldlen + 2);
1963 else 1724 else
1964 sl.len = oldlen; 1725 sl.reset (oldlen);
1965 } 1726 }
1727
1966 /*What concerns extendinfos, nothing to be done for now 1728 /*What concerns extendinfos, nothing to be done for now
1967 * (perhaps effects layer later) 1729 * (perhaps effects layer later)
1968 */ 1730 */
1969 continue; /* don't do processing below */ 1731 continue; /* don't do processing below */
1970 } 1732 }
1971 1733
1972 MapCell & lastcell = socket.lastmap.cells[ax][ay]; 1734 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1973 1735
1974 d = pl->contr->blocked_los[ax][ay]; 1736 d = pl->contr->blocked_los[ax][ay];
1975 1737
1976 /* If the coordinates are not valid, or it is too dark to see, 1738 /* If the coordinates are not valid, or it is too dark to see,
1977 * we tell the client as such 1739 * we tell the client as such
1978 */ 1740 */
1979 nx = x; 1741 nx = x;
1980 ny = y; 1742 ny = y;
1981 m = get_map_from_coord (pl->map, &nx, &ny); 1743 m = get_map_from_coord (pl->map, &nx, &ny);
1744
1982 if (!m) 1745 if (!m)
1983 { 1746 {
1984 /* space is out of map. Update space and clear values 1747 /* space is out of map. Update space and clear values
1985 * if this hasn't already been done. If the space is out 1748 * if this hasn't already been done. If the space is out
1986 * of the map, it shouldn't have a head 1749 * of the map, it shouldn't have a head
1987 */ 1750 */
1988 if (lastcell.count != -1) 1751 if (lastcell.count != -1)
1989 { 1752 {
1990 SockList_AddShort (&sl, mask); 1753 sl << uint16 (mask);
1991 map_clearcell (&lastcell, 0, 0, 0, -1); 1754 map_clearcell (&lastcell, 0, 0, 0, -1);
1992 } 1755 }
1993 } 1756 }
1994 else if (d > 3) 1757 else if (d > 3)
1995 { 1758 {
… …
1997 1760
1998 /* This block deals with spaces that are not visible for whatever 1761 /* This block deals with spaces that are not visible for whatever
1999 * reason. Still may need to send the head for this space. 1762 * reason. Still may need to send the head for this space.
2000 */ 1763 */
2001 1764
2002 oldlen = sl.len; 1765 oldlen = sl.length ();
2003 1766
2004 SockList_AddShort (&sl, mask); 1767 sl << uint16 (mask);
1768
2005 if (lastcell.count != -1) 1769 if (lastcell.count != -1)
2006 need_send = 1; 1770 need_send = 1;
1771
2007 count = -1; 1772 count = -1;
2008 1773
2009 if (socket.mapmode == Map1aCmd && have_head (ax, ay)) 1774 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
2010 { 1775 {
2011 /* Now check to see if any heads need to be sent */ 1776 /* Now check to see if any heads need to be sent */
2012 1777
2013 if (check_head (sl, socket, ax, ay, 2)) 1778 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
2014 mask |= 0x4;
2015 if (check_head (sl, socket, ax, ay, 1)) 1779 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
2016 mask |= 0x2;
2017 if (check_head (sl, socket, ax, ay, 0)) 1780 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
2018 mask |= 0x1;
2019 1781
2020 lastcell.count = count; 1782 lastcell.count = count;
2021
2022 } 1783 }
2023 else 1784 else
2024 { 1785 {
2025 struct MapCell *cell = &lastcell;
2026
2027 /* properly clear a previously sent big face */ 1786 /* properly clear a previously sent big face */
2028 if (cell->faces[0] != 0 || cell->faces[1] != 0 || cell->faces[2] != 0) 1787 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0
1788 || lastcell.stat_hp || lastcell.flags || lastcell.player)
2029 need_send = 1; 1789 need_send = 1;
1790
2030 map_clearcell (&lastcell, 0, 0, 0, count); 1791 map_clearcell (&lastcell, 0, 0, 0, count);
2031 } 1792 }
2032 1793
2033 if ((mask & 0xf) || need_send) 1794 if ((mask & 0xf) || need_send)
2034 {
2035 sl.buf[oldlen + 1] = mask & 0xff; 1795 sl[oldlen + 1] = mask & 0xff;
2036 }
2037 else 1796 else
2038 {
2039 sl.len = oldlen; 1797 sl.reset (oldlen);
2040 }
2041 } 1798 }
2042 else 1799 else
2043 { 1800 {
2044 /* In this block, the space is visible or there are head objects 1801 /* In this block, the space is visible or there are head objects
2045 * we need to send. 1802 * we need to send.
… …
2047 1804
2048 /* Rather than try to figure out what everything that we might 1805 /* Rather than try to figure out what everything that we might
2049 * need to send is, then form the packet after that, 1806 * need to send is, then form the packet after that,
2050 * we presume that we will in fact form a packet, and update 1807 * we presume that we will in fact form a packet, and update
2051 * the bits by what we do actually send. If we send nothing, 1808 * the bits by what we do actually send. If we send nothing,
2052 * we just back out sl.len to the old value, and no harm 1809 * we just back out sl.length () to the old value, and no harm
2053 * is done. 1810 * is done.
2054 * I think this is simpler than doing a bunch of checks to see 1811 * I think this is simpler than doing a bunch of checks to see
2055 * what if anything we need to send, setting the bits, then 1812 * what if anything we need to send, setting the bits, then
2056 * doing those checks again to add the real data. 1813 * doing those checks again to add the real data.
2057 */ 1814 */
2058 oldlen = sl.len; 1815 oldlen = sl.length ();
2059 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1816 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2060 eoldlen = esl.len; 1817 eoldlen = esl.length ();
2061 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1818 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2062 SockList_AddShort (&sl, mask); 1819 sl << uint16 (mask);
2063 1820
2064 if (socket.ext_mapinfos) 1821 if (socket.ext_mapinfos)
2065 SockList_AddShort (&esl, emask); 1822 esl << uint16 (emask);
2066 1823
2067 unsigned char dummy; 1824 unsigned char dummy;
2068 unsigned char *last_ext = &dummy; 1825 unsigned char *last_ext = &dummy;
2069 1826
2070 /* Darkness changed */ 1827 /* Darkness changed */
… …
2073 mask |= 0x8; 1830 mask |= 0x8;
2074 1831
2075 if (socket.extmap) 1832 if (socket.extmap)
2076 { 1833 {
2077 *last_ext |= 0x80; 1834 *last_ext |= 0x80;
2078 last_ext = sl.buf + sl.len; 1835 last_ext = &sl[sl.length ()];
2079 SockList_AddChar (&sl, d); 1836 sl << uint8 (d);
2080 } 1837 }
2081 else 1838 else
2082 SockList_AddChar (&sl, 255 - 64 * d); 1839 sl << uint8 (255 - 64 * d);
2083 } 1840 }
2084 1841
2085 lastcell.count = d; 1842 lastcell.count = d;
2086 1843
2087 if (socket.extmap) 1844 if (socket.extmap)
2088 { 1845 {
2089 uint8 stat_hp = 0; 1846 uint8 stat_hp = 0;
2090 uint8 stat_width = 0; 1847 uint8 stat_width = 0;
1848 uint8 flags = 0;
2091 tag_t player = 0; 1849 UUID player = 0;
2092 1850
2093 // send hp information, if applicable 1851 // send hp information, if applicable
2094 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1852 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0))
2095 { 1853 {
2096 if (op->head || op->invisible) 1854 if (op->head || op->invisible)
… …
2103 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp; 1861 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
2104 stat_width = op->arch->tail_x; 1862 stat_width = op->arch->tail_x;
2105 } 1863 }
2106 } 1864 }
2107 1865
1866 if (op->msg && op->msg[0] == '@')
1867 flags |= 1;
1868
2108 if (op->type == PLAYER && op != pl) 1869 if (op->type == PLAYER && op != pl)
2109 player = op->count; 1870 player = op->count;
2110 } 1871 }
2111 1872
2112 if (lastcell.stat_hp != stat_hp) 1873 if (lastcell.stat_hp != stat_hp)
2113 { 1874 {
2114 lastcell.stat_hp = stat_hp; 1875 lastcell.stat_hp = stat_hp;
2115 1876
2116 mask |= 0x8; 1877 mask |= 0x8;
2117 *last_ext |= 0x80; 1878 *last_ext |= 0x80;
2118 last_ext = sl.buf + sl.len; 1879 last_ext = &sl[sl.length ()];
2119 SockList_AddChar (&sl, 5); 1880
2120 SockList_AddChar (&sl, stat_hp); 1881 sl << uint8 (5) << uint8 (stat_hp);
2121 1882
2122 if (stat_width > 1) 1883 if (stat_width > 1)
2123 { 1884 {
2124 *last_ext |= 0x80; 1885 *last_ext |= 0x80;
2125 last_ext = sl.buf + sl.len; 1886 last_ext = &sl[sl.length ()];
2126 SockList_AddChar (&sl, 6); 1887
2127 SockList_AddChar (&sl, stat_width); 1888 sl << uint8 (6) << uint8 (stat_width);
2128 } 1889 }
2129 } 1890 }
2130 1891
2131 if (lastcell.player !=player) 1892 if (lastcell.player != player)
2132 { 1893 {
2133 lastcell.player = player; 1894 lastcell.player = player;
2134 1895
2135 mask |= 0x8; 1896 mask |= 0x8;
2136 *last_ext |= 0x80; 1897 *last_ext |= 0x80;
2137 last_ext = sl.buf + sl.len; 1898 last_ext = &sl[sl.length ()];
2138 SockList_AddChar (&sl, 0x47); 1899
2139 SockList_AddChar (&sl, 4); 1900 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2140 SockList_AddInt (&sl, player); 1901 }
1902
1903 if (lastcell.flags != flags)
1904 {
1905 lastcell.flags = flags;
1906
1907 mask |= 0x8;
1908 *last_ext |= 0x80;
1909 last_ext = &sl[sl.length ()];
1910
1911 sl << uint8 (8) << uint8 (flags);
2141 } 1912 }
2142 } 1913 }
2143 1914
2144 /* Floor face */ 1915 /* Floor face */
2145 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 2)) 1916 if (update_space (sl, socket, m, nx, ny, ax, ay, 2))
2146 mask |= 0x4; 1917 mask |= 0x4;
2147 1918
2148 if (socket.EMI_smooth) 1919 if (socket.EMI_smooth)
2149 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 2)) 1920 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2150 emask |= 0x4; 1921 emask |= 0x4;
2151 1922
2152 /* Middle face */ 1923 /* Middle face */
2153 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 1)) 1924 if (update_space (sl, socket, m, nx, ny, ax, ay, 1))
2154 mask |= 0x2; 1925 mask |= 0x2;
2155 1926
2156 if (socket.EMI_smooth) 1927 if (socket.EMI_smooth)
2157 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 1)) 1928 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1))
2158 emask |= 0x2; 1929 emask |= 0x2;
2159 1930
2160 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1)) 1931 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2161 { 1932 {
2162 if (lastcell.faces[0] != pl->face->number) 1933 if (lastcell.faces[0] != pl->face->number)
2163 { 1934 {
2164 lastcell.faces[0] = pl->face->number; 1935 lastcell.faces[0] = pl->face->number;
2165 mask |= 0x1; 1936 mask |= 0x1;
1937
2166 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE)) 1938 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2167 esrv_send_face (&socket, pl->face->number, 0); 1939 esrv_send_face (&socket, pl->face->number, 0);
2168 SockList_AddShort (&sl, pl->face->number); 1940
1941 sl << uint16 (pl->face->number);
2169 } 1942 }
2170 } 1943 }
2171 /* Top face */
2172 else 1944 else
2173 { 1945 {
1946 /* Top face */
2174 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 0)) 1947 if (update_space (sl, socket, m, nx, ny, ax, ay, 0))
2175 mask |= 0x1; 1948 mask |= 0x1;
1949
2176 if (socket.EMI_smooth) 1950 if (socket.EMI_smooth)
2177 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 0)) 1951 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2178 {
2179 emask |= 0x1; 1952 emask |= 0x1;
2180 }
2181 } 1953 }
1954
2182 /* Check to see if we are in fact sending anything for this 1955 /* Check to see if we are in fact sending anything for this
2183 * space by checking the mask. If so, update the mask. 1956 * space by checking the mask. If so, update the mask.
2184 * if not, reset the len to that from before adding the mask 1957 * if not, reset the len to that from before adding the mask
2185 * value, so we don't send those bits. 1958 * value, so we don't send those bits.
2186 */ 1959 */
2187 if (mask & 0xf) 1960 if (mask & 0xf)
2188 {
2189 sl.buf[oldlen + 1] = mask & 0xff; 1961 sl[oldlen + 1] = mask & 0xff;
2190 }
2191 else 1962 else
2192 {
2193 sl.len = oldlen; 1963 sl.reset (oldlen);
2194 } 1964
2195 if (emask & 0xf) 1965 if (emask & 0xf)
2196 {
2197 esl.buf[eoldlen + 1] = emask & 0xff; 1966 esl[eoldlen + 1] = emask & 0xff;
2198 }
2199 else 1967 else
2200 {
2201 esl.len = eoldlen; 1968 esl.reset (eoldlen);
2202 }
2203 } /* else this is a viewable space */ 1969 } /* else this is a viewable space */
2204 } /* for x loop */ 1970 } /* for x loop */
2205 } /* for y loop */ 1971 } /* for y loop */
2206 1972
2207 /* Verify that we in fact do need to send this */ 1973 /* Verify that we in fact do need to send this */
2208 if (socket.ext_mapinfos) 1974 if (socket.ext_mapinfos)
2209 { 1975 {
2210 if (!(sl.len > startlen || socket.sent_scroll)) 1976 if (!(sl.length () > startlen || socket.sent_scroll))
2211 { 1977 {
2212 /* No map data will follow, so don't say the client 1978 /* No map data will follow, so don't say the client
2213 * it doesn't need draw! 1979 * it doesn't need draw!
2214 */ 1980 */
2215 ewhatflag &= (~EMI_NOREDRAW); 1981 ewhatflag &= (~EMI_NOREDRAW);
2216 esl.buf[ewhatstart + 1] = ewhatflag & 0xff; 1982 esl[ewhatstart + 1] = ewhatflag & 0xff;
2217 } 1983 }
2218 1984
2219 if (esl.len > estartlen) 1985 if (esl.length () > estartlen)
2220 Send_With_Handling (&socket, &esl); 1986 socket.send_packet (esl);
2221
2222 free (esl.buf);
2223 } 1987 }
2224 1988
2225 if (sl.len > startlen || socket.sent_scroll) 1989 if (sl.length () > startlen || socket.sent_scroll)
2226 { 1990 {
2227 Send_With_Handling (&socket, &sl); 1991 socket.send_packet (sl);
2228 socket.sent_scroll = 0; 1992 socket.sent_scroll = 0;
2229 } 1993 }
2230
2231 free (sl.buf);
2232} 1994}
2233 1995
2234/** 1996/**
2235 * Draws client map. 1997 * Draws client map.
2236 */ 1998 */
… …
2241 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */ 2003 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */
2242 New_Face *face, *floor; 2004 New_Face *face, *floor;
2243 New_Face *floor2; 2005 New_Face *floor2;
2244 int d, mflags; 2006 int d, mflags;
2245 struct Map newmap; 2007 struct Map newmap;
2246 mapstruct *m, *pm; 2008 maptile *m, *pm;
2247 2009
2248 if (pl->type != PLAYER) 2010 if (pl->type != PLAYER)
2249 { 2011 {
2250 LOG (llevError, "draw_client_map called with non player/non eric-server\n"); 2012 LOG (llevError, "draw_client_map called with non player/non eric-server\n");
2251 return; 2013 return;
… …
2260 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 2022 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2261 return; 2023 return;
2262 2024
2263 memset (&newmap, 0, sizeof (struct Map)); 2025 memset (&newmap, 0, sizeof (struct Map));
2264 2026
2265 for (j = (pl->y - pl->contr->socket.mapy / 2); j < (pl->y + (pl->contr->socket.mapy + 1) / 2); j++) 2027 for (j = (pl->y - pl->contr->ns->mapy / 2); j < (pl->y + (pl->contr->ns->mapy + 1) / 2); j++)
2266 {
2267 for (i = (pl->x - pl->contr->socket.mapx / 2); i < (pl->x + (pl->contr->socket.mapx + 1) / 2); i++) 2028 for (i = (pl->x - pl->contr->ns->mapx / 2); i < (pl->x + (pl->contr->ns->mapx + 1) / 2); i++)
2268 { 2029 {
2269 ax = i; 2030 ax = i;
2270 ay = j; 2031 ay = j;
2271 m = pm; 2032 m = pm;
2272 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay); 2033 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
2034
2273 if (mflags & P_OUT_OF_MAP) 2035 if (mflags & P_OUT_OF_MAP)
2274 continue; 2036 continue;
2275 if (mflags & P_NEED_UPDATE) 2037
2276 update_position (m, ax, ay);
2277 /* If a map is visible to the player, we don't want to swap it out 2038 /* If a map is visible to the player, we don't want to swap it out
2278 * just to reload it. This should really call something like 2039 * just to reload it. This should really call something like
2279 * swap_map, but this is much more efficient and 'good enough' 2040 * swap_map, but this is much more efficient and 'good enough'
2280 */ 2041 */
2281 if (mflags & P_NEW_MAP) 2042 if (mflags & P_NEW_MAP)
2282 m->timeout = 50; 2043 m->timeout = 50;
2283 } 2044 }
2284 } 2045
2285 /* do LOS after calls to update_position */ 2046 /* do LOS after calls to update_position */
2286 if (pl->contr->do_los) 2047 if (pl->contr->do_los)
2287 { 2048 {
2288 update_los (pl); 2049 update_los (pl);
2289 pl->contr->do_los = 0; 2050 pl->contr->do_los = 0;
2290 } 2051 }
2291 2052
2292 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd)
2293 {
2294 /* Big maps need a different drawing mechanism to work */ 2053 /* Big maps need a different drawing mechanism to work */
2295 draw_client_map1 (pl); 2054 draw_client_map1 (pl);
2296 return;
2297 }
2298
2299 if (pl->invisible & (pl->invisible < 50 ? 4 : 1))
2300 {
2301 esrv_map_setbelow (&pl->contr->socket, pl->contr->socket.mapx / 2, pl->contr->socket.mapy / 2, pl->face->number, &newmap);
2302 }
2303
2304 /* j and i are the y and x coordinates of the real map (which is
2305 * basically some number of spaces around the player)
2306 * ax and ay are values from within the viewport (ie, 0, 0 is upper
2307 * left corner) and are thus disconnected from the map values.
2308 * Subtract 1 from the max values so that we properly handle cases where
2309 * player has specified an even map. Otherwise, we try to send them too
2310 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually
2311 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is
2312 * odd, this still works fine.
2313 */
2314 ay = 0;
2315 for (j = pl->y - pl->contr->socket.mapy / 2; j <= pl->y + (pl->contr->socket.mapy - 1) / 2; j++, ay++)
2316 {
2317 ax = 0;
2318 for (i = pl->x - pl->contr->socket.mapx / 2; i <= pl->x + (pl->contr->socket.mapx - 1) / 2; i++, ax++)
2319 {
2320
2321 d = pl->contr->blocked_los[ax][ay];
2322 /* note the out_of_map and d>3 checks are both within the same
2323 * negation check.
2324 */
2325 nx = i;
2326 ny = j;
2327 m = get_map_from_coord (pm, &nx, &ny);
2328 if (m && d < 4)
2329 {
2330 face = GET_MAP_FACE (m, nx, ny, 0);
2331 floor2 = GET_MAP_FACE (m, nx, ny, 1);
2332 floor = GET_MAP_FACE (m, nx, ny, 2);
2333
2334 /* If all is blank, send a blank face. */
2335 if ((!face || face == blank_face) && (!floor2 || floor2 == blank_face) && (!floor || floor == blank_face))
2336 {
2337 esrv_map_setbelow (&pl->contr->socket, ax, ay, blank_face->number, &newmap);
2338 }
2339 else
2340 { /* actually have something interesting */
2341 /* send the darkness mask, if any. */
2342 if (d && pl->contr->socket.darkness)
2343 esrv_map_setbelow (&pl->contr->socket, ax, ay, dark_faces[d - 1]->number, &newmap);
2344
2345 if (face && face != blank_face)
2346 esrv_map_setbelow (&pl->contr->socket, ax, ay, face->number, &newmap);
2347 if (floor2 && floor2 != blank_face)
2348 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor2->number, &newmap);
2349 if (floor && floor != blank_face)
2350 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2351 }
2352 } /* Is a valid space */
2353 }
2354 }
2355 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2356
2357 check_map_change (pl->contr);
2358} 2055}
2359 2056
2360 2057
2361/*****************************************************************************/ 2058/*****************************************************************************/
2362 2059
… …
2368 2065
2369/*****************************************************************************/ 2066/*****************************************************************************/
2370void 2067void
2371send_plugin_custom_message (object *pl, char *buf) 2068send_plugin_custom_message (object *pl, char *buf)
2372{ 2069{
2373 cs_write_string (&pl->contr->socket, buf, strlen (buf)); 2070 pl->contr->ns->send_packet (buf);
2374} 2071}
2375 2072
2376/** 2073/**
2377 * This sends the skill number to name mapping. We ignore 2074 * This sends the skill number to name mapping. We ignore
2378 * the params - we always send the same info no matter what. 2075 * the params - we always send the same info no matter what.
2379 */ 2076 */
2380void 2077void
2381send_skill_info (NewSocket * ns, char *params) 2078send_skill_info (client *ns, char *params)
2382{ 2079{
2383 SockList sl; 2080 packet sl;
2384 int i; 2081 sl << "replyinfo skill_info\n";
2385 2082
2386 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
2387 strcpy ((char *) sl.buf, "replyinfo skill_info\n");
2388 for (i = 1; i < NUM_SKILLS; i++) 2083 for (int i = 1; i < NUM_SKILLS; i++)
2389 { 2084 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2390 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 2085
2391 }
2392 sl.len = strlen ((char *) sl.buf);
2393 if (sl.len >= MAXSOCKBUF) 2086 if (sl.length () >= MAXSOCKBUF)
2394 { 2087 {
2395 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 2088 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2396 fatal (0); 2089 fatal (0);
2397 } 2090 }
2398 Send_With_Handling (ns, &sl); 2091
2399 free (sl.buf); 2092 ns->send_packet (sl);
2400} 2093}
2401 2094
2402/** 2095/**
2403 * This sends the spell path to name mapping. We ignore 2096 * This sends the spell path to name mapping. We ignore
2404 * the params - we always send the same info no matter what. 2097 * the params - we always send the same info no matter what.
2405 */ 2098 */
2406void 2099void
2407send_spell_paths (NewSocket * ns, char *params) 2100send_spell_paths (client * ns, char *params)
2408{ 2101{
2409 SockList sl; 2102 packet sl;
2410 int i;
2411 2103
2412 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2104 sl << "replyinfo spell_paths\n";
2413 strcpy ((char *) sl.buf, "replyinfo spell_paths\n"); 2105
2414 for (i = 0; i < NRSPELLPATHS; i++) 2106 for (int i = 0; i < NRSPELLPATHS; i++)
2415 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", 1 << i, spellpathnames[i]); 2107 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2416 sl.len = strlen ((char *) sl.buf); 2108
2417 if (sl.len >= MAXSOCKBUF) 2109 if (sl.length () >= MAXSOCKBUF)
2418 { 2110 {
2419 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 2111 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2420 fatal (0); 2112 fatal (0);
2421 } 2113 }
2422 Send_With_Handling (ns, &sl); 2114
2423 free (sl.buf); 2115 ns->send_packet (sl);
2424} 2116}
2425 2117
2426/** 2118/**
2427 * This looks for any spells the player may have that have changed their stats. 2119 * This looks for any spells the player may have that have changed their stats.
2428 * it then sends an updspell packet for each spell that has changed in this way 2120 * it then sends an updspell packet for each spell that has changed in this way
2429 */ 2121 */
2430void 2122void
2431esrv_update_spells (player *pl) 2123esrv_update_spells (player *pl)
2432{ 2124{
2433 SockList sl;
2434 int flags = 0;
2435 object *spell;
2436
2437 if (!pl->socket.monitor_spells) 2125 if (!pl->ns->monitor_spells)
2438 return; 2126 return;
2127
2439 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2128 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2440 { 2129 {
2441 if (spell->type == SPELL) 2130 if (spell->type == SPELL)
2442 { 2131 {
2132 int flags = 0;
2133
2443 /* check if we need to update it */ 2134 /* check if we need to update it */
2444 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 2135 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
2445 { 2136 {
2446 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2137 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2447 flags |= UPD_SP_MANA; 2138 flags |= UPD_SP_MANA;
2448 } 2139 }
2140
2449 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 2141 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
2450 { 2142 {
2451 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2143 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2452 flags |= UPD_SP_GRACE; 2144 flags |= UPD_SP_GRACE;
2453 } 2145 }
2146
2454 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 2147 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
2455 { 2148 {
2456 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2149 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2457 flags |= UPD_SP_DAMAGE; 2150 flags |= UPD_SP_DAMAGE;
2458 } 2151 }
2152
2459 if (flags != 0) 2153 if (flags)
2460 { 2154 {
2461 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2155 packet sl;
2462 strcpy ((char *) sl.buf, "updspell "); 2156
2463 sl.len = strlen ((char *) sl.buf); 2157 sl << "updspell "
2464 SockList_AddChar (&sl, flags); 2158 << uint8 (flags)
2465 SockList_AddInt (&sl, spell->count); 2159 << uint32 (spell->count);
2466 if (flags & UPD_SP_MANA) 2160
2467 SockList_AddShort (&sl, spell->last_sp); 2161 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2468 if (flags & UPD_SP_GRACE) 2162 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2469 SockList_AddShort (&sl, spell->last_grace); 2163 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2470 if (flags & UPD_SP_DAMAGE) 2164
2471 SockList_AddShort (&sl, spell->last_eat); 2165 pl->ns->send_packet (sl);
2472 flags = 0;
2473 Send_With_Handling (&pl->socket, &sl);
2474 free (sl.buf);
2475 } 2166 }
2476 } 2167 }
2477 } 2168 }
2478} 2169}
2479 2170
2480void 2171void
2481esrv_remove_spell (player *pl, object *spell) 2172esrv_remove_spell (player *pl, object *spell)
2482{ 2173{
2483 SockList sl;
2484
2485 if (!pl->socket.monitor_spells) 2174 if (!pl->ns->monitor_spells)
2486 return; 2175 return;
2176
2487 if (!pl || !spell || spell->env != pl->ob) 2177 if (!pl || !spell || spell->env != pl->ob)
2488 { 2178 {
2489 LOG (llevError, "Invalid call to esrv_remove_spell"); 2179 LOG (llevError, "Invalid call to esrv_remove_spell");
2490 return; 2180 return;
2491 } 2181 }
2492 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2182
2493 strcpy ((char *) sl.buf, "delspell "); 2183 packet sl ("delspell");
2494 sl.len = strlen ((char *) sl.buf); 2184
2495 SockList_AddInt (&sl, spell->count); 2185 sl << uint32 (spell->count);
2496 Send_With_Handling (&pl->socket, &sl); 2186
2497 free (sl.buf); 2187 pl->ns->send_packet (sl);
2498} 2188}
2499 2189
2500/* appends the spell *spell to the Socklist we will send the data to. */ 2190/* appends the spell *spell to the Socklist we will send the data to. */
2501static void 2191static void
2502append_spell (player *pl, SockList * sl, object *spell) 2192append_spell (player *pl, packet &sl, object *spell)
2503{ 2193{
2504 int len, i, skill = 0; 2194 int len, i, skill = 0;
2505 2195
2506 if (!(spell->name)) 2196 if (!(spell->name))
2507 { 2197 {
2508 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 2198 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2509 return; 2199 return;
2510 } 2200 }
2511 SockList_AddInt (sl, spell->count); 2201
2512 SockList_AddShort (sl, spell->level);
2513 SockList_AddShort (sl, spell->casting_time);
2514 /* store costs and damage in the object struct, to compare to later */ 2202 /* store costs and damage in the object struct, to compare to later */
2515 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2203 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2516 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2204 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2517 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2205 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2518 /* send the current values */
2519 SockList_AddShort (sl, spell->last_sp);
2520 SockList_AddShort (sl, spell->last_grace);
2521 SockList_AddShort (sl, spell->last_eat);
2522 2206
2523 /* figure out which skill it uses, if it uses one */ 2207 /* figure out which skill it uses, if it uses one */
2524 if (spell->skill) 2208 if (spell->skill)
2525 { 2209 {
2526 for (i = 1; i < NUM_SKILLS; i++) 2210 for (i = 1; i < NUM_SKILLS; i++)
… …
2528 { 2212 {
2529 skill = i + CS_STAT_SKILLINFO; 2213 skill = i + CS_STAT_SKILLINFO;
2530 break; 2214 break;
2531 } 2215 }
2532 } 2216 }
2533 SockList_AddChar (sl, skill);
2534 2217
2535 SockList_AddInt (sl, spell->path_attuned); 2218 /* send the current values */
2219 sl << uint32 (spell->count)
2220 << uint16 (spell->level)
2221 << uint16 (spell->casting_time)
2222 << uint16 (spell->last_sp)
2223 << uint16 (spell->last_grace)
2224 << uint16 (spell->last_eat)
2225 << uint8 (skill)
2226 << uint32 (spell->path_attuned)
2536 SockList_AddInt (sl, (spell->face) ? spell->face->number : 0); 2227 << uint32 (spell->face ? spell->face->number : 0)
2537 2228 << data8 (spell->name)
2538 len = strlen (spell->name); 2229 << data16 (spell->msg);
2539 SockList_AddChar (sl, (char) len);
2540 memcpy (sl->buf + sl->len, spell->name, len);
2541 sl->len += len;
2542
2543 if (!spell->msg)
2544 {
2545 SockList_AddShort (sl, 0);
2546 }
2547 else
2548 {
2549 len = strlen (spell->msg);
2550 SockList_AddShort (sl, len);
2551 memcpy (sl->buf + sl->len, spell->msg, len);
2552 sl->len += len;
2553 }
2554} 2230}
2555 2231
2556/** 2232/**
2557 * This tells the client to add the spell *ob, if *ob is NULL, then add 2233 * This tells the client to add the spell *ob, if *ob is NULL, then add
2558 * all spells in the player's inventory. 2234 * all spells in the player's inventory.
2559 */ 2235 */
2560void 2236void
2561esrv_add_spells (player *pl, object *spell) 2237esrv_add_spells (player *pl, object *spell)
2562{ 2238{
2563 SockList sl;
2564
2565 if (!pl) 2239 if (!pl)
2566 { 2240 {
2567 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 2241 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2568 return; 2242 return;
2569 } 2243 }
2244
2570 if (!pl->socket.monitor_spells) 2245 if (!pl->ns->monitor_spells)
2571 return; 2246 return;
2572 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2247
2573 strcpy ((char *) sl.buf, "addspell "); 2248 packet sl ("addspell");
2574 sl.len = strlen ((char *) sl.buf); 2249
2575 if (!spell) 2250 if (!spell)
2576 { 2251 {
2577 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2252 for (spell = pl->ob->inv; spell != NULL; spell = spell->below)
2578 { 2253 {
2579 /* were we to simply keep appending data here, we could exceed 2254 /* were we to simply keep appending data here, we could exceed
… …
2589 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 2264 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2590 * like it will fix this 2265 * like it will fix this
2591 */ 2266 */
2592 if (spell->type != SPELL) 2267 if (spell->type != SPELL)
2593 continue; 2268 continue;
2269
2594 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 2270 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2595 { 2271 {
2596 Send_With_Handling (&pl->socket, &sl); 2272 pl->ns->send_packet (sl);
2597 strcpy ((char *) sl.buf, "addspell "); 2273
2598 sl.len = strlen ((char *) sl.buf); 2274 sl.reset ();
2275 sl << "addspell ";
2599 } 2276 }
2277
2600 append_spell (pl, &sl, spell); 2278 append_spell (pl, sl, spell);
2601 } 2279 }
2602 } 2280 }
2603 else if (spell->type != SPELL) 2281 else if (spell->type != SPELL)
2604 { 2282 {
2605 LOG (llevError, "Asked to send a non-spell object as a spell"); 2283 LOG (llevError, "Asked to send a non-spell object as a spell");
2606 return; 2284 return;
2607 } 2285 }
2608 else 2286 else
2609 append_spell (pl, &sl, spell); 2287 append_spell (pl, sl, spell);
2288
2610 if (sl.len >= MAXSOCKBUF) 2289 if (sl.length () >= MAXSOCKBUF)
2611 { 2290 {
2612 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 2291 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2613 fatal (0); 2292 fatal (0);
2614 } 2293 }
2294
2615 /* finally, we can send the packet */ 2295 /* finally, we can send the packet */
2616 Send_With_Handling (&pl->socket, &sl); 2296 pl->ns->send_packet (sl);
2617 free (sl.buf);
2618} 2297}
2298

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines