ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.26 by pippijn, Mon Dec 11 19:46:47 2006 UTC vs.
Revision 1.29 by root, Wed Dec 13 21:27:09 2006 UTC

… …
682 */ 682 */
683static void 683static void
684SendSmooth (NewSocket * ns, uint16 face) 684SendSmooth (NewSocket * ns, uint16 face)
685{ 685{
686 uint16 smoothface; 686 uint16 smoothface;
687 unsigned char reply[MAX_BUF];
688 SockList sl;
689 687
690 /* If we can't find a face, return and set it so we won't try to send this 688 /* If we can't find a face, return and set it so we won't try to send this
691 * again. 689 * again.
692 */ 690 */
693 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface))) 691 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
… …
701 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE)) 699 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
702 esrv_send_face (ns, smoothface, 0); 700 esrv_send_face (ns, smoothface, 0);
703 701
704 ns->faces_sent[face] |= NS_FACESENT_SMOOTH; 702 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
705 703
706 sl.buf = reply; 704 SockList sl (MAXSOCKBUF);
707 strcpy ((char *) sl.buf, "smooth "); 705
708 sl.len = strlen ((char *) sl.buf); 706 sl << "smooth "
709 SockList_AddShort (&sl, face); 707 << uint16 (face)
710 SockList_AddShort (&sl, smoothface); 708 << uint16 (smoothface);
709
711 Send_With_Handling (ns, &sl); 710 Send_With_Handling (ns, &sl);
711 sl.free ();
712} 712}
713 713
714 /** 714 /**
715 * Tells client the picture it has to use 715 * Tells client the picture it has to use
716 * to smooth a picture number given as argument. 716 * to smooth a picture number given as argument.
… …
722 722
723 facenbr = atoi (buf); 723 facenbr = atoi (buf);
724 SendSmooth (ns, facenbr); 724 SendSmooth (ns, facenbr);
725} 725}
726 726
727
728
729
730
731/** 727/**
732 * This handles the general commands from the client (ie, north, fire, cast, 728 * This handles the general commands from the client (ie, north, fire, cast,
733 * etc.) 729 * etc.)
734 */ 730 */
735void 731void
… …
788 */ 784 */
789void 785void
790NewPlayerCmd (uint8 * buf, int len, player *pl) 786NewPlayerCmd (uint8 * buf, int len, player *pl)
791{ 787{
792 int time, repeat; 788 int time, repeat;
789 char command[MAX_BUF];
793 short packet; 790 short packet;
794 unsigned char command[MAX_BUF];
795 SockList sl;
796 791
797 if (len < 7) 792 if (len < 7)
798 { 793 {
799 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 794 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
800 return; 795 return;
… …
802 797
803 packet = GetShort_String (buf); 798 packet = GetShort_String (buf);
804 repeat = GetInt_String (buf + 2); 799 repeat = GetInt_String (buf + 2);
805 /* -1 is special - no repeat, but don't update */ 800 /* -1 is special - no repeat, but don't update */
806 if (repeat != -1) 801 if (repeat != -1)
807 {
808 pl->count = repeat; 802 pl->count = repeat;
809 } 803
810 if ((len - 4) >= MAX_BUF) 804 if ((len - 4) >= MAX_BUF)
811 len = MAX_BUF - 5; 805 len = MAX_BUF - 5;
812 806
813 strncpy ((char *) command, (char *) buf + 6, len - 4); 807 strncpy ((char *) command, (char *) buf + 6, len - 4);
814 command[len - 4] = '\0'; 808 command[len - 4] = '\0';
… …
824 return; 818 return;
825 } 819 }
826 820
827 /* This should not happen anymore. */ 821 /* This should not happen anymore. */
828 if (pl->ob->speed_left < -1.0) 822 if (pl->ob->speed_left < -1.0)
829 {
830 LOG (llevError, "Player has negative time - shouldn't do command.\n"); 823 LOG (llevError, "Player has negative time - shouldn't do command.\n");
831 } 824
832 /* In c_new.c */ 825 /* In c_new.c */
833 execute_newserver_command (pl->ob, (char *) command); 826 execute_newserver_command (pl->ob, (char *) command);
834 /* Perhaps something better should be done with a left over count. 827 /* Perhaps something better should be done with a left over count.
835 * Cleaning up the input should probably be done first - all actions 828 * Cleaning up the input should probably be done first - all actions
836 * for the command that issued the count should be done before any other 829 * for the command that issued the count should be done before any other
837 * commands. 830 * commands.
838 */ 831 */
839 pl->count = 0; 832 pl->count = 0;
840 833
841 /* Send confirmation of command execution now */
842 sl.buf = command;
843 strcpy ((char *) sl.buf, "comc ");
844 sl.len = 5;
845 SockList_AddShort (&sl, packet);
846 if (FABS (pl->ob->speed) < 0.001) 834 if (FABS (pl->ob->speed) < 0.001)
847 time = MAX_TIME * 100; 835 time = MAX_TIME * 100;
848 else 836 else
849 time = (int) (MAX_TIME / FABS (pl->ob->speed)); 837 time = (int) (MAX_TIME / FABS (pl->ob->speed));
850 SockList_AddInt (&sl, time); 838
839 /* Send confirmation of command execution now */
840
841 SockList sl (MAXSOCKBUF);
842 sl << "comc " << uint16 (packet) << uint32 (time);
851 Send_With_Handling (&pl->socket, &sl); 843 Send_With_Handling (&pl->socket, &sl);
844 sl.free ();
852} 845}
853 846
854 847
855/** This is a reply to a previous query. */ 848/** This is a reply to a previous query. */
856void 849void
… …
968 /* these are old dxclients */ 961 /* these are old dxclients */
969 /* Version 1024 added support for singular + plural name values - 962 /* Version 1024 added support for singular + plural name values -
970 * requiing this minimal value reduces complexity of that code, and it 963 * requiing this minimal value reduces complexity of that code, and it
971 * has been around for a long time. 964 * has been around for a long time.
972 */ 965 */
973 if (!strcmp (" CF DX CLIENT", cp) || ns->sc_version < 1024) 966 if (ns->sc_version < 1026)
974 { 967 {
975 sprintf (version_warning, "drawinfo %d %s", NDI_RED, 968 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
976 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 969 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
977 Write_String_To_Socket (ns, version_warning, strlen (version_warning)); 970 Write_String_To_Socket (ns, version_warning, strlen (version_warning));
978 } 971 }
… …
1059 Write_String_To_Socket (ns, buf, strlen (buf)); 1052 Write_String_To_Socket (ns, buf, strlen (buf));
1060} 1053}
1061 1054
1062#define AddIfInt64(Old,New,Type) if (Old != New) {\ 1055#define AddIfInt64(Old,New,Type) if (Old != New) {\
1063 Old = New; \ 1056 Old = New; \
1064 SockList_AddChar(&sl, Type); \ 1057 sl << uint8 (Type) << uint64 (New); \
1065 SockList_AddInt64(&sl, New); \
1066 } 1058 }
1067 1059
1068#define AddIfInt(Old,New,Type) if (Old != New) {\ 1060#define AddIfInt(Old,New,Type) if (Old != New) {\
1069 Old = New; \ 1061 Old = New; \
1070 SockList_AddChar(&sl, Type); \ 1062 sl << uint8 (Type) << uint32 (New); \
1071 SockList_AddInt(&sl, New); \
1072 } 1063 }
1073 1064
1074#define AddIfShort(Old,New,Type) if (Old != New) {\ 1065#define AddIfShort(Old,New,Type) if (Old != New) {\
1075 Old = New; \ 1066 Old = New; \
1076 SockList_AddChar(&sl, Type); \ 1067 sl << uint8 (Type) << uint16 (New); \
1077 SockList_AddShort(&sl, New); \
1078 } 1068 }
1079 1069
1080#define AddIfFloat(Old,New,Type) if (Old != New) {\ 1070#define AddIfFloat(Old,New,Type) if (Old != New) {\
1081 Old = New; \ 1071 Old = New; \
1082 SockList_AddChar(&sl, Type); \ 1072 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \
1083 SockList_AddInt(&sl,(long)(New*FLOAT_MULTI));\
1084 } 1073 }
1085 1074
1086#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 1075#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1087 if (Old) free(Old);\
1088 Old = strdup_local(New);\ 1076 free(Old); Old = strdup (New);\
1089 SockList_AddChar(&sl, Type); \ 1077 sl << uint8 (Type) << data8 (New); \
1090 SockList_AddChar(&sl, ( char )strlen(New)); \
1091 strcpy((char*)sl.buf + sl.len, New); \
1092 sl.len += strlen(New); \
1093 } 1078 }
1094 1079
1095/** 1080/**
1096 * Sends a statistics update. We look at the old values, 1081 * Sends a statistics update. We look at the old values,
1097 * and only send what has changed. Stat mapping values are in newclient.h 1082 * and only send what has changed. Stat mapping values are in newclient.h
… …
1099 * commands for now. 1084 * commands for now.
1100 */ 1085 */
1101void 1086void
1102esrv_update_stats (player *pl) 1087esrv_update_stats (player *pl)
1103{ 1088{
1104 SockList sl;
1105 char buf[MAX_BUF]; 1089 char buf[MAX_BUF];
1106 uint16 flags; 1090 uint16 flags;
1107 1091
1108 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1092 SockList sl (MAXSOCKBUF);
1109 strcpy ((char *) sl.buf, "stats "); 1093 sl << "stats ";
1110 sl.len = strlen ((char *) sl.buf);
1111 1094
1112 if (pl->ob != NULL) 1095 if (pl->ob != NULL)
1113 { 1096 {
1114 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 1097 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP);
1115 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 1098 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP);
… …
1132 1115
1133 for (s = 0; s < NUM_SKILLS; s++) 1116 for (s = 0; s < NUM_SKILLS; s++)
1134 { 1117 {
1135 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 1118 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp)
1136 { 1119 {
1137
1138 /* Always send along the level if exp changes. This is only 1120 /* Always send along the level if exp changes. This is only
1139 * 1 extra byte, but keeps processing simpler. 1121 * 1 extra byte, but keeps processing simpler.
1140 */ 1122 */
1141 SockList_AddChar (&sl, (char) (s + CS_STAT_SKILLINFO)); 1123 sl << uint8 (s + CS_STAT_SKILLINFO)
1142 SockList_AddChar (&sl, (char) pl->last_skill_ob[s]->level); 1124 << uint8 (pl->last_skill_ob[s]->level)
1143 SockList_AddInt64 (&sl, pl->last_skill_ob[s]->stats.exp); 1125 << uint64 (pl->last_skill_ob[s]->stats.exp);
1126
1144 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp; 1127 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1145 } 1128 }
1146 } 1129 }
1147 } 1130 }
1148 1131
… …
1204 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len); 1187 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1205#endif 1188#endif
1206 Send_With_Handling (&pl->socket, &sl); 1189 Send_With_Handling (&pl->socket, &sl);
1207 } 1190 }
1208 1191
1209 free (sl.buf); 1192 sl.free ();
1210} 1193}
1211 1194
1212/** 1195/**
1213 * Tells the client that here is a player it should start using. 1196 * Tells the client that here is a player it should start using.
1214 */ 1197 */
1215void 1198void
1216esrv_new_player (player *pl, uint32 weight) 1199esrv_new_player (player *pl, uint32 weight)
1217{ 1200{
1218 SockList sl;
1219
1220 pl->last_weight = weight; 1201 pl->last_weight = weight;
1221 1202
1222 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1203 SockList sl (MAXSOCKBUF);
1204 sl << "player ";
1223 1205
1224 strcpy ((char *) sl.buf, "player "); 1206 sl << uint32 (pl->ob->count)
1225 sl.len = strlen ((char *) sl.buf); 1207 << uint32 (weight)
1226 SockList_AddInt (&sl, pl->ob->count); 1208 << uint32 (pl->ob->face->number)
1227 SockList_AddInt (&sl, weight); 1209 << data8 (pl->ob->name);
1228 SockList_AddInt (&sl, pl->ob->face->number);
1229
1230 SockList_AddChar (&sl, (char) strlen (pl->ob->name));
1231 strcpy ((char *) sl.buf + sl.len, pl->ob->name);
1232 sl.len += strlen (pl->ob->name);
1233 1210
1234 Send_With_Handling (&pl->socket, &sl); 1211 Send_With_Handling (&pl->socket, &sl);
1235 free (sl.buf); 1212 sl.free ();
1236 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1213 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1237} 1214}
1238 1215
1239/** 1216/**
1240 * Need to send an animation sequence to the client. 1217 * Need to send an animation sequence to the client.
… …
1244 * when the player logs in and picks stuff up. 1221 * when the player logs in and picks stuff up.
1245 */ 1222 */
1246void 1223void
1247esrv_send_animation (NewSocket * ns, short anim_num) 1224esrv_send_animation (NewSocket * ns, short anim_num)
1248{ 1225{
1249 SockList sl;
1250 int i; 1226 int i;
1251 1227
1252 /* Do some checking on the anim_num we got. Note that the animations 1228 /* Do some checking on the anim_num we got. Note that the animations
1253 * are added in contigous order, so if the number is in the valid 1229 * are added in contigous order, so if the number is in the valid
1254 * range, it must be a valid animation. 1230 * range, it must be a valid animation.
… …
1257 { 1233 {
1258 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num); 1234 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1259 return; 1235 return;
1260 } 1236 }
1261 1237
1262 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1238 SockList sl (MAXSOCKBUF);
1263 strcpy ((char *) sl.buf, "anim "); 1239
1264 sl.len = 5; 1240 sl << "anim "
1265 SockList_AddShort (&sl, anim_num); 1241 << uint16 (anim_num)
1266 SockList_AddShort (&sl, 0); /* flags - not used right now */ 1242 << uint16 (0); /* flags - not used right now */
1243
1267 /* Build up the list of faces. Also, send any information (ie, the 1244 /* Build up the list of faces. Also, send any information (ie, the
1268 * the face itself) down to the client. 1245 * the face itself) down to the client.
1269 */ 1246 */
1270 for (i = 0; i < animations[anim_num].num_animations; i++) 1247 for (i = 0; i < animations[anim_num].num_animations; i++)
1271 { 1248 {
1272 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE)) 1249 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1273 esrv_send_face (ns, animations[anim_num].faces[i], 0); 1250 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1274 SockList_AddShort (&sl, animations[anim_num].faces[i]); /* flags - not used right now */ 1251 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1275 } 1252 }
1253
1276 Send_With_Handling (ns, &sl); 1254 Send_With_Handling (ns, &sl);
1277 free (sl.buf); 1255 sl.free ();
1256
1278 ns->anims_sent[anim_num] = 1; 1257 ns->anims_sent[anim_num] = 1;
1279} 1258}
1280 1259
1281 1260
1282/****************************************************************************** 1261/******************************************************************************
… …
1296 { 1275 {
1297 LOG (llevError, "Too many faces in map cell %d %d\n", x, y); 1276 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1298 return; 1277 return;
1299 abort (); 1278 abort ();
1300 } 1279 }
1280
1301 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num; 1281 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1302 newmap->cells[x][y].count++; 1282 newmap->cells[x][y].count++;
1283
1303 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1284 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1304 esrv_send_face (ns, face_num, 0); 1285 esrv_send_face (ns, face_num, 0);
1305} 1286}
1306 1287
1307struct LayerCell 1288struct LayerCell
… …
1414static void 1395static void
1415esrv_map_doneredraw (NewSocket * ns, struct Map *newmap) 1396esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1416{ 1397{
1417 static long frames, bytes, tbytes, tframes; 1398 static long frames, bytes, tbytes, tframes;
1418 char *cur; 1399 char *cur;
1419 SockList sl;
1420 1400
1421 1401 SockList sl (MAXSOCKBUF);
1422 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1402 sl << "map ";
1423 strcpy ((char *) sl.buf, "map ");
1424 sl.len = strlen ((char *) sl.buf);
1425 1403
1426 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap); 1404 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1427 sl.len = cur - (char *) sl.buf; 1405 sl.len = cur - (char *) sl.buf;
1428 1406
1429/* LOG(llevDebug, "Sending map command.\n");*/ 1407/* LOG(llevDebug, "Sending map command.\n");*/
… …
1441 memcpy (&ns->lastmap, newmap, sizeof (struct Map)); 1419 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1442 Send_With_Handling (ns, &sl); 1420 Send_With_Handling (ns, &sl);
1443 ns->sent_scroll = 0; 1421 ns->sent_scroll = 0;
1444 } 1422 }
1445 1423
1446 free (sl.buf); 1424 sl.free ();
1447} 1425}
1448 1426
1449 1427
1450/** Clears a map cell */ 1428/** Clears a map cell */
1451static void 1429static void
… …
1493 * needs to get sent - if so, it adds the data, sending the head 1471 * needs to get sent - if so, it adds the data, sending the head
1494 * if needed, and returning 1. If this no data needs to get 1472 * if needed, and returning 1. If this no data needs to get
1495 * sent, it returns zero. 1473 * sent, it returns zero.
1496 */ 1474 */
1497static int 1475static int
1498check_head (SockList & sl, NewSocket & ns, int ax, int ay, int layer) 1476check_head (SockList &sl, NewSocket &ns, int ax, int ay, int layer)
1499{ 1477{
1500 short face_num; 1478 short face_num;
1501 1479
1502 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]) 1480 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1503 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number; 1481 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
… …
1507 if (face_num != ns.lastmap.cells[ax][ay].faces[layer]) 1485 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1508 { 1486 {
1509 SockList_AddShort (&sl, face_num); 1487 SockList_AddShort (&sl, face_num);
1510 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1488 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1511 esrv_send_face (&ns, face_num, 0); 1489 esrv_send_face (&ns, face_num, 0);
1490
1512 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL; 1491 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1513 ns.lastmap.cells[ax][ay].faces[layer] = face_num; 1492 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1514 return 1; 1493 return 1;
1515 } 1494 }
1516 1495
… …
1536 * the case, it seems to make more sense to have these layer values 1515 * the case, it seems to make more sense to have these layer values
1537 * actually match. 1516 * actually match.
1538 */ 1517 */
1539 1518
1540static int 1519static int
1541update_space (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1520update_space (SockList &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1542{ 1521{
1543 object *ob, *head; 1522 object *ob, *head;
1544 uint16 face_num; 1523 uint16 face_num;
1545 int bx, by, i; 1524 int bx, by, i;
1546 1525
1547 /* If there is a multipart object stored away, treat that as more important. 1526 /* If there is a multipart object stored away, treat that as more important.
1548 * If not, then do the normal processing. 1527 * If not, then do the normal processing.
1549 */ 1528 */
1550
1551 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer]; 1529 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1552 1530
1553 /* Check to see if this head is part of the set of objects 1531 /* Check to see if this head is part of the set of objects
1554 * we would normally send for this space. If so, then 1532 * we would normally send for this space. If so, then
1555 * don't use the head value. We need to do the check 1533 * don't use the head value. We need to do the check
… …
1720 1698
1721 /* Another hack - because of heads and whatnot, this face may match one 1699 /* Another hack - because of heads and whatnot, this face may match one
1722 * we already sent for a lower layer. In that case, don't send 1700 * we already sent for a lower layer. In that case, don't send
1723 * this one. 1701 * this one.
1724 */ 1702 */
1725 if (face_num && layer + 1 < MAP_LAYERS && ns->lastmap.cells[sx][sy].faces[layer + 1] == face_num) 1703 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1726 {
1727 face_num = 0; 1704 face_num = 0;
1728 }
1729 1705
1730 /* We've gotten what face we want to use for the object. Now see if 1706 /* We've gotten what face we want to use for the object. Now see if
1731 * if it has changed since we last sent it to the client. 1707 * if it has changed since we last sent it to the client.
1732 */ 1708 */
1733 if (ns->lastmap.cells[sx][sy].faces[layer] != face_num) 1709 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num)
1734 { 1710 {
1735 ns->lastmap.cells[sx][sy].faces[layer] = face_num; 1711 ns.lastmap.cells[sx][sy].faces[layer] = face_num;
1736 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1712 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1737 esrv_send_face (ns, face_num, 0); 1713 esrv_send_face (&ns, face_num, 0);
1738 SockList_AddShort (sl, face_num); 1714
1715 sl << uint16 (face_num);
1739 return 1; 1716 return 1;
1740 } 1717 }
1718
1741 /* Nothing changed */ 1719 /* Nothing changed */
1742 return 0; 1720 return 0;
1743} 1721}
1744 1722
1745/** 1723/**
… …
1760 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ 1738 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1761 * take. 1739 * take.
1762 */ 1740 */
1763 1741
1764static inline int 1742static inline int
1765update_smooth (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1743update_smooth (SockList &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1766{ 1744{
1767 object *ob; 1745 object *ob;
1768 int smoothlevel; /* old face_num; */ 1746 int smoothlevel; /* old face_num; */
1769 1747
1770 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer); 1748 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
… …
1775 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp)) 1753 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1776 smoothlevel = 0; 1754 smoothlevel = 0;
1777 else 1755 else
1778 { 1756 {
1779 smoothlevel = ob->smoothlevel; 1757 smoothlevel = ob->smoothlevel;
1780 if (smoothlevel && !(ns->faces_sent[ob->face->number] & NS_FACESENT_SMOOTH)) 1758 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1781 SendSmooth (ns, ob->face->number); 1759 SendSmooth (&ns, ob->face->number);
1782 } /* else not already head object or blank face */ 1760 } /* else not already head object or blank face */
1783 1761
1784 /* We've gotten what face we want to use for the object. Now see if 1762 /* We've gotten what face we want to use for the object. Now see if
1785 * if it has changed since we last sent it to the client. 1763 * if it has changed since we last sent it to the client.
1786 */ 1764 */
1787 if (smoothlevel > 255) 1765 if (smoothlevel > 255)
1788 smoothlevel = 255; 1766 smoothlevel = 255;
1789 else if (smoothlevel < 0) 1767 else if (smoothlevel < 0)
1790 smoothlevel = 0; 1768 smoothlevel = 0;
1769
1791 if (ns->lastmap.cells[sx][sy].smooth[layer] != smoothlevel) 1770 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1792 { 1771 {
1793 ns->lastmap.cells[sx][sy].smooth[layer] = smoothlevel; 1772 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1794 SockList_AddChar (sl, (uint8) (smoothlevel & 0xFF)); 1773 sl << uint8 (smoothlevel);
1795 return 1; 1774 return 1;
1796 } 1775 }
1776
1797 /* Nothing changed */ 1777 /* Nothing changed */
1798 return 0; 1778 return 0;
1799} 1779}
1800 1780
1801/** 1781/**
… …
1842draw_client_map1 (object *pl) 1822draw_client_map1 (object *pl)
1843{ 1823{
1844 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1824 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen;
1845 sint16 nx, ny; 1825 sint16 nx, ny;
1846 int estartlen, eoldlen; 1826 int estartlen, eoldlen;
1847 SockList sl;
1848 SockList esl; /*For extended Map info */
1849 uint16 mask, emask; 1827 uint16 mask, emask;
1850 uint8 eentrysize; 1828 uint8 eentrysize;
1851 uint16 ewhatstart, ewhatflag; 1829 uint16 ewhatstart, ewhatflag;
1852 uint8 extendedinfos; 1830 uint8 extendedinfos;
1853 maptile *m; 1831 maptile *m;
1854 1832
1855 NewSocket & socket = pl->contr->socket; 1833 NewSocket &socket = pl->contr->socket;
1856 1834
1857 check_map_change (pl->contr); 1835 check_map_change (pl->contr);
1858 1836
1859 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1837 SockList sl (MAXSOCKBUF);
1860 if (socket.mapmode == Map1Cmd) 1838 SockList esl (MAXSOCKBUF);
1861 strcpy ((char *) sl.buf, "map1 "); 1839
1862 else 1840 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1863 strcpy ((char *) sl.buf, "map1a ");
1864 sl.len = strlen ((char *) sl.buf);
1865 startlen = sl.len; 1841 startlen = sl.len;
1866 1842
1867 /*Extendedmapinfo structure initialisation */ 1843 /*Extendedmapinfo structure initialisation */
1868 if (socket.ext_mapinfos) 1844 if (socket.ext_mapinfos)
1869 { 1845 {
1870 esl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1871 strcpy ((char *) esl.buf, "mapextended ");
1872 esl.len = strlen ((char *) esl.buf);
1873 extendedinfos = EMI_NOREDRAW; 1846 extendedinfos = EMI_NOREDRAW;
1874 1847
1875 if (socket.EMI_smooth) 1848 if (socket.EMI_smooth)
1876 extendedinfos |= EMI_SMOOTH; 1849 extendedinfos |= EMI_SMOOTH;
1877 1850
1878 ewhatstart = esl.len; 1851 ewhatstart = esl.len;
1879 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 1852 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1880 could need to be taken away */ 1853 could need to be taken away */
1881 SockList_AddChar (&esl, extendedinfos);
1882 eentrysize = getExtendedMapInfoSize (&socket); 1854 eentrysize = getExtendedMapInfoSize (&socket);
1883 SockList_AddChar (&esl, eentrysize); 1855 esl << "mapextended "
1856 << uint8 (extendedinfos)
1857 << uint8 (eentrysize);
1884 estartlen = esl.len; 1858 estartlen = esl.len;
1885 } 1859 }
1886 else 1860 else
1887 { 1861 {
1888 /* suppress compiler warnings */ 1862 /* suppress compiler warnings */
… …
1929 { 1903 {
1930 int i, got_one; 1904 int i, got_one;
1931 1905
1932 oldlen = sl.len; 1906 oldlen = sl.len;
1933 1907
1934 SockList_AddShort (&sl, mask); 1908 sl << uint16 (mask);
1935 1909
1936 if (check_head (sl, socket, ax, ay, 2)) 1910 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1937 mask |= 0x4;
1938 if (check_head (sl, socket, ax, ay, 1)) 1911 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1939 mask |= 0x2;
1940 if (check_head (sl, socket, ax, ay, 0)) 1912 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1941 mask |= 0x1;
1942 1913
1943 /* If all we are doing is sending 0 (blank) faces, we don't 1914 /* If all we are doing is sending 0 (blank) faces, we don't
1944 * actually need to send that - just the coordinates 1915 * actually need to send that - just the coordinates
1945 * with no faces tells the client to blank out the 1916 * with no faces tells the client to blank out the
1946 * space. 1917 * space.
… …
1983 * if this hasn't already been done. If the space is out 1954 * if this hasn't already been done. If the space is out
1984 * of the map, it shouldn't have a head 1955 * of the map, it shouldn't have a head
1985 */ 1956 */
1986 if (lastcell.count != -1) 1957 if (lastcell.count != -1)
1987 { 1958 {
1988 SockList_AddShort (&sl, mask); 1959 sl << uint16 (mask);
1989 map_clearcell (&lastcell, 0, 0, 0, -1); 1960 map_clearcell (&lastcell, 0, 0, 0, -1);
1990 } 1961 }
1991 } 1962 }
1992 else if (d > 3) 1963 else if (d > 3)
1993 { 1964 {
… …
1997 * reason. Still may need to send the head for this space. 1968 * reason. Still may need to send the head for this space.
1998 */ 1969 */
1999 1970
2000 oldlen = sl.len; 1971 oldlen = sl.len;
2001 1972
2002 SockList_AddShort (&sl, mask); 1973 sl << uint16 (mask);
2003 1974
2004 if (lastcell.count != -1) 1975 if (lastcell.count != -1)
2005 need_send = 1; 1976 need_send = 1;
2006 1977
2007 count = -1; 1978 count = -1;
2008 1979
2009 if (socket.mapmode == Map1aCmd && have_head (ax, ay)) 1980 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
2010 { 1981 {
2011 /* Now check to see if any heads need to be sent */ 1982 /* Now check to see if any heads need to be sent */
2012 1983
2013 if (check_head (sl, socket, ax, ay, 2)) 1984 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
2014 mask |= 0x4;
2015 if (check_head (sl, socket, ax, ay, 1)) 1985 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
2016 mask |= 0x2;
2017 if (check_head (sl, socket, ax, ay, 0)) 1986 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
2018 mask |= 0x1;
2019 1987
2020 lastcell.count = count; 1988 lastcell.count = count;
2021 } 1989 }
2022 else 1990 else
2023 { 1991 {
… …
2052 */ 2020 */
2053 oldlen = sl.len; 2021 oldlen = sl.len;
2054 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 2022 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2055 eoldlen = esl.len; 2023 eoldlen = esl.len;
2056 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 2024 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2057 SockList_AddShort (&sl, mask); 2025 sl << uint16 (mask);
2058 2026
2059 if (socket.ext_mapinfos) 2027 if (socket.ext_mapinfos)
2060 SockList_AddShort (&esl, emask); 2028 esl << uint16 (emask);
2061 2029
2062 unsigned char dummy; 2030 unsigned char dummy;
2063 unsigned char *last_ext = &dummy; 2031 unsigned char *last_ext = &dummy;
2064 2032
2065 /* Darkness changed */ 2033 /* Darkness changed */
… …
2069 2037
2070 if (socket.extmap) 2038 if (socket.extmap)
2071 { 2039 {
2072 *last_ext |= 0x80; 2040 *last_ext |= 0x80;
2073 last_ext = sl.buf + sl.len; 2041 last_ext = sl.buf + sl.len;
2074 SockList_AddChar (&sl, d); 2042 sl << uint8 (d);
2075 } 2043 }
2076 else 2044 else
2077 SockList_AddChar (&sl, 255 - 64 * d); 2045 sl << uint8 (255 - 64 * d);
2078 } 2046 }
2079 2047
2080 lastcell.count = d; 2048 lastcell.count = d;
2081 2049
2082 if (socket.extmap) 2050 if (socket.extmap)
2083 { 2051 {
2084 uint8 stat_hp = 0; 2052 uint8 stat_hp = 0;
2085 uint8 stat_width = 0; 2053 uint8 stat_width = 0;
2086 uint8 flags = 0; 2054 uint8 flags = 0;
2087 tag_t player = 0; 2055 UUID player = 0;
2088 2056
2089 // send hp information, if applicable 2057 // send hp information, if applicable
2090 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 2058 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0))
2091 { 2059 {
2092 if (op->head || op->invisible) 2060 if (op->head || op->invisible)
… …
2113 lastcell.stat_hp = stat_hp; 2081 lastcell.stat_hp = stat_hp;
2114 2082
2115 mask |= 0x8; 2083 mask |= 0x8;
2116 *last_ext |= 0x80; 2084 *last_ext |= 0x80;
2117 last_ext = sl.buf + sl.len; 2085 last_ext = sl.buf + sl.len;
2118 SockList_AddChar (&sl, 5); 2086
2119 SockList_AddChar (&sl, stat_hp); 2087 sl << uint8 (5) << uint8 (stat_hp);
2120 2088
2121 if (stat_width > 1) 2089 if (stat_width > 1)
2122 { 2090 {
2123 *last_ext |= 0x80; 2091 *last_ext |= 0x80;
2124 last_ext = sl.buf + sl.len; 2092 last_ext = sl.buf + sl.len;
2125 SockList_AddChar (&sl, 6); 2093
2126 SockList_AddChar (&sl, stat_width); 2094 sl << uint8 (6) << uint8 (stat_width);
2127 } 2095 }
2128 } 2096 }
2129 2097
2130 if (lastcell.player != player) 2098 if (lastcell.player != player)
2131 { 2099 {
2132 lastcell.player = player; 2100 lastcell.player = player;
2133 2101
2134 mask |= 0x8; 2102 mask |= 0x8;
2135 *last_ext |= 0x80; 2103 *last_ext |= 0x80;
2136 last_ext = sl.buf + sl.len; 2104 last_ext = sl.buf + sl.len;
2137 SockList_AddChar (&sl, 0x47); 2105
2138 SockList_AddChar (&sl, 4); 2106 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2139 SockList_AddInt (&sl, player);
2140 } 2107 }
2141 2108
2142 if (lastcell.flags != flags) 2109 if (lastcell.flags != flags)
2143 { 2110 {
2144 lastcell.flags = flags; 2111 lastcell.flags = flags;
2145 2112
2146 mask |= 0x8; 2113 mask |= 0x8;
2147 *last_ext |= 0x80; 2114 *last_ext |= 0x80;
2148 last_ext = sl.buf + sl.len; 2115 last_ext = sl.buf + sl.len;
2149 SockList_AddChar (&sl, 8); 2116
2150 SockList_AddChar (&sl, flags); 2117 sl << uint8 (8) << uint8 (flags);
2151 } 2118 }
2152 } 2119 }
2153 2120
2154 /* Floor face */ 2121 /* Floor face */
2155 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 2)) 2122 if (update_space (sl, socket, m, nx, ny, ax, ay, 2))
2156 mask |= 0x4; 2123 mask |= 0x4;
2157 2124
2158 if (socket.EMI_smooth) 2125 if (socket.EMI_smooth)
2159 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 2)) 2126 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2160 emask |= 0x4; 2127 emask |= 0x4;
2161 2128
2162 /* Middle face */ 2129 /* Middle face */
2163 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 1)) 2130 if (update_space (sl, socket, m, nx, ny, ax, ay, 1))
2164 mask |= 0x2; 2131 mask |= 0x2;
2165 2132
2166 if (socket.EMI_smooth) 2133 if (socket.EMI_smooth)
2167 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 1)) 2134 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1))
2168 emask |= 0x2; 2135 emask |= 0x2;
2169 2136
2170 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1)) 2137 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2171 { 2138 {
2172 if (lastcell.faces[0] != pl->face->number) 2139 if (lastcell.faces[0] != pl->face->number)
… …
2175 mask |= 0x1; 2142 mask |= 0x1;
2176 2143
2177 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE)) 2144 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2178 esrv_send_face (&socket, pl->face->number, 0); 2145 esrv_send_face (&socket, pl->face->number, 0);
2179 2146
2180 SockList_AddShort (&sl, pl->face->number); 2147 sl << uint16 (pl->face->number);
2181 } 2148 }
2182 } 2149 }
2183 else 2150 else
2184 { 2151 {
2185 /* Top face */ 2152 /* Top face */
2186 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 0)) 2153 if (update_space (sl, socket, m, nx, ny, ax, ay, 0))
2187 mask |= 0x1; 2154 mask |= 0x1;
2188 2155
2189 if (socket.EMI_smooth) 2156 if (socket.EMI_smooth)
2190 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 0)) 2157 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2191 emask |= 0x1; 2158 emask |= 0x1;
2192 } 2159 }
2193 2160
2194 /* Check to see if we are in fact sending anything for this 2161 /* Check to see if we are in fact sending anything for this
2195 * space by checking the mask. If so, update the mask. 2162 * space by checking the mask. If so, update the mask.
… …
2221 esl.buf[ewhatstart + 1] = ewhatflag & 0xff; 2188 esl.buf[ewhatstart + 1] = ewhatflag & 0xff;
2222 } 2189 }
2223 2190
2224 if (esl.len > estartlen) 2191 if (esl.len > estartlen)
2225 Send_With_Handling (&socket, &esl); 2192 Send_With_Handling (&socket, &esl);
2226
2227 free (esl.buf);
2228 } 2193 }
2229 2194
2230 if (sl.len > startlen || socket.sent_scroll) 2195 if (sl.len > startlen || socket.sent_scroll)
2231 { 2196 {
2232 Send_With_Handling (&socket, &sl); 2197 Send_With_Handling (&socket, &sl);
2233 socket.sent_scroll = 0; 2198 socket.sent_scroll = 0;
2234 } 2199 }
2235 2200
2236 free (sl.buf); 2201 sl.free ();
2202 esl.free ();
2237} 2203}
2238 2204
2239/** 2205/**
2240 * Draws client map. 2206 * Draws client map.
2241 */ 2207 */
… …
2355 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap); 2321 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2356 } 2322 }
2357 } /* Is a valid space */ 2323 } /* Is a valid space */
2358 } 2324 }
2359 } 2325 }
2326
2360 esrv_map_doneredraw (&pl->contr->socket, &newmap); 2327 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2361 2328
2362 check_map_change (pl->contr); 2329 check_map_change (pl->contr);
2363} 2330}
2364 2331
… …
2381/** 2348/**
2382 * This sends the skill number to name mapping. We ignore 2349 * This sends the skill number to name mapping. We ignore
2383 * the params - we always send the same info no matter what. 2350 * the params - we always send the same info no matter what.
2384 */ 2351 */
2385void 2352void
2386send_skill_info (NewSocket * ns, char *params) 2353send_skill_info (NewSocket *ns, char *params)
2387{ 2354{
2388 SockList sl; 2355 SockList sl (MAXSOCKBUF);
2389 int i; 2356 sl << "replyinfo skill_info\n";
2390 2357
2391 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
2392 strcpy ((char *) sl.buf, "replyinfo skill_info\n");
2393 for (i = 1; i < NUM_SKILLS; i++) 2358 for (int i = 1; i < NUM_SKILLS; i++)
2394 { 2359 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2395 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 2360
2396 }
2397 sl.len = strlen ((char *) sl.buf);
2398 if (sl.len >= MAXSOCKBUF) 2361 if (sl.len >= MAXSOCKBUF)
2399 { 2362 {
2400 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 2363 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2401 fatal (0); 2364 fatal (0);
2402 } 2365 }
2366
2403 Send_With_Handling (ns, &sl); 2367 Send_With_Handling (ns, &sl);
2404 free (sl.buf); 2368 sl.free ();
2405} 2369}
2406 2370
2407/** 2371/**
2408 * This sends the spell path to name mapping. We ignore 2372 * This sends the spell path to name mapping. We ignore
2409 * the params - we always send the same info no matter what. 2373 * the params - we always send the same info no matter what.
2410 */ 2374 */
2411void 2375void
2412send_spell_paths (NewSocket * ns, char *params) 2376send_spell_paths (NewSocket * ns, char *params)
2413{ 2377{
2414 SockList sl; 2378 SockList sl (MAXSOCKBUF);
2415 int i;
2416 2379
2417 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2380 sl << "replyinfo spell_paths\n";
2418 strcpy ((char *) sl.buf, "replyinfo spell_paths\n"); 2381
2419 for (i = 0; i < NRSPELLPATHS; i++) 2382 for (int i = 0; i < NRSPELLPATHS; i++)
2420 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", 1 << i, spellpathnames[i]); 2383 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2421 sl.len = strlen ((char *) sl.buf); 2384
2422 if (sl.len >= MAXSOCKBUF) 2385 if (sl.len >= MAXSOCKBUF)
2423 { 2386 {
2424 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 2387 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2425 fatal (0); 2388 fatal (0);
2426 } 2389 }
2390
2427 Send_With_Handling (ns, &sl); 2391 Send_With_Handling (ns, &sl);
2428 free (sl.buf); 2392 sl.free ();
2429} 2393}
2430 2394
2431/** 2395/**
2432 * This looks for any spells the player may have that have changed their stats. 2396 * This looks for any spells the player may have that have changed their stats.
2433 * it then sends an updspell packet for each spell that has changed in this way 2397 * it then sends an updspell packet for each spell that has changed in this way
2434 */ 2398 */
2435void 2399void
2436esrv_update_spells (player *pl) 2400esrv_update_spells (player *pl)
2437{ 2401{
2438 SockList sl;
2439 int flags = 0;
2440 object *spell;
2441
2442 if (!pl->socket.monitor_spells) 2402 if (!pl->socket.monitor_spells)
2443 return; 2403 return;
2404
2444 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2405 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2445 { 2406 {
2446 if (spell->type == SPELL) 2407 if (spell->type == SPELL)
2447 { 2408 {
2409 int flags = 0;
2410
2448 /* check if we need to update it */ 2411 /* check if we need to update it */
2449 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 2412 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
2450 { 2413 {
2451 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2414 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2452 flags |= UPD_SP_MANA; 2415 flags |= UPD_SP_MANA;
2453 } 2416 }
2417
2454 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 2418 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
2455 { 2419 {
2456 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2420 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2457 flags |= UPD_SP_GRACE; 2421 flags |= UPD_SP_GRACE;
2458 } 2422 }
2423
2459 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 2424 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
2460 { 2425 {
2461 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2426 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2462 flags |= UPD_SP_DAMAGE; 2427 flags |= UPD_SP_DAMAGE;
2463 } 2428 }
2429
2464 if (flags != 0) 2430 if (flags)
2465 { 2431 {
2466 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2432 SockList sl (MAXSOCKBUF);
2467 strcpy ((char *) sl.buf, "updspell "); 2433
2468 sl.len = strlen ((char *) sl.buf); 2434 sl << "updspell "
2469 SockList_AddChar (&sl, flags); 2435 << uint8 (flags)
2470 SockList_AddInt (&sl, spell->count); 2436 << uint32 (spell->count);
2471 if (flags & UPD_SP_MANA) 2437
2472 SockList_AddShort (&sl, spell->last_sp); 2438 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2473 if (flags & UPD_SP_GRACE) 2439 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2474 SockList_AddShort (&sl, spell->last_grace); 2440 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2475 if (flags & UPD_SP_DAMAGE) 2441
2476 SockList_AddShort (&sl, spell->last_eat);
2477 flags = 0;
2478 Send_With_Handling (&pl->socket, &sl); 2442 Send_With_Handling (&pl->socket, &sl);
2479 free (sl.buf); 2443 sl.free ();
2480 } 2444 }
2481 } 2445 }
2482 } 2446 }
2483} 2447}
2484 2448
2485void 2449void
2486esrv_remove_spell (player *pl, object *spell) 2450esrv_remove_spell (player *pl, object *spell)
2487{ 2451{
2488 SockList sl;
2489
2490 if (!pl->socket.monitor_spells) 2452 if (!pl->socket.monitor_spells)
2491 return; 2453 return;
2454
2492 if (!pl || !spell || spell->env != pl->ob) 2455 if (!pl || !spell || spell->env != pl->ob)
2493 { 2456 {
2494 LOG (llevError, "Invalid call to esrv_remove_spell"); 2457 LOG (llevError, "Invalid call to esrv_remove_spell");
2495 return; 2458 return;
2496 } 2459 }
2497 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2460
2498 strcpy ((char *) sl.buf, "delspell "); 2461 SockList sl (MAXSOCKBUF);
2499 sl.len = strlen ((char *) sl.buf); 2462
2500 SockList_AddInt (&sl, spell->count); 2463 sl << "delspell "
2464 << uint32 (spell->count);
2465
2501 Send_With_Handling (&pl->socket, &sl); 2466 Send_With_Handling (&pl->socket, &sl);
2502 free (sl.buf); 2467 sl.free ();
2503} 2468}
2504 2469
2505/* appends the spell *spell to the Socklist we will send the data to. */ 2470/* appends the spell *spell to the Socklist we will send the data to. */
2506static void 2471static void
2507append_spell (player *pl, SockList * sl, object *spell) 2472append_spell (player *pl, SockList &sl, object *spell)
2508{ 2473{
2509 int len, i, skill = 0; 2474 int len, i, skill = 0;
2510 2475
2511 if (!(spell->name)) 2476 if (!(spell->name))
2512 { 2477 {
2513 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 2478 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2514 return; 2479 return;
2515 } 2480 }
2516 SockList_AddInt (sl, spell->count); 2481
2517 SockList_AddShort (sl, spell->level);
2518 SockList_AddShort (sl, spell->casting_time);
2519 /* store costs and damage in the object struct, to compare to later */ 2482 /* store costs and damage in the object struct, to compare to later */
2520 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2483 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2521 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2484 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2522 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2485 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2523 /* send the current values */
2524 SockList_AddShort (sl, spell->last_sp);
2525 SockList_AddShort (sl, spell->last_grace);
2526 SockList_AddShort (sl, spell->last_eat);
2527 2486
2528 /* figure out which skill it uses, if it uses one */ 2487 /* figure out which skill it uses, if it uses one */
2529 if (spell->skill) 2488 if (spell->skill)
2530 { 2489 {
2531 for (i = 1; i < NUM_SKILLS; i++) 2490 for (i = 1; i < NUM_SKILLS; i++)
… …
2533 { 2492 {
2534 skill = i + CS_STAT_SKILLINFO; 2493 skill = i + CS_STAT_SKILLINFO;
2535 break; 2494 break;
2536 } 2495 }
2537 } 2496 }
2538 SockList_AddChar (sl, skill);
2539 2497
2540 SockList_AddInt (sl, spell->path_attuned); 2498 /* send the current values */
2499 sl << uint32 (spell->count)
2500 << uint16 (spell->level)
2501 << uint16 (spell->casting_time)
2502 << uint16 (spell->last_sp)
2503 << uint16 (spell->last_grace)
2504 << uint16 (spell->last_eat)
2505 << uint8 (skill)
2506 << uint32 (spell->path_attuned)
2541 SockList_AddInt (sl, (spell->face) ? spell->face->number : 0); 2507 << uint32 (spell->face ? spell->face->number : 0)
2542 2508 << data8 (spell->name)
2543 len = strlen (spell->name); 2509 << data16 (spell->msg);
2544 SockList_AddChar (sl, (char) len);
2545 memcpy (sl->buf + sl->len, spell->name, len);
2546 sl->len += len;
2547
2548 if (!spell->msg)
2549 {
2550 SockList_AddShort (sl, 0);
2551 }
2552 else
2553 {
2554 len = strlen (spell->msg);
2555 SockList_AddShort (sl, len);
2556 memcpy (sl->buf + sl->len, spell->msg, len);
2557 sl->len += len;
2558 }
2559} 2510}
2560 2511
2561/** 2512/**
2562 * This tells the client to add the spell *ob, if *ob is NULL, then add 2513 * This tells the client to add the spell *ob, if *ob is NULL, then add
2563 * all spells in the player's inventory. 2514 * all spells in the player's inventory.
2564 */ 2515 */
2565void 2516void
2566esrv_add_spells (player *pl, object *spell) 2517esrv_add_spells (player *pl, object *spell)
2567{ 2518{
2568 SockList sl;
2569
2570 if (!pl) 2519 if (!pl)
2571 { 2520 {
2572 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 2521 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2573 return; 2522 return;
2574 } 2523 }
2524
2575 if (!pl->socket.monitor_spells) 2525 if (!pl->socket.monitor_spells)
2576 return; 2526 return;
2577 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2527
2578 strcpy ((char *) sl.buf, "addspell "); 2528 SockList sl (MAXSOCKBUF);
2579 sl.len = strlen ((char *) sl.buf); 2529
2530 sl << "addspell ";
2531
2580 if (!spell) 2532 if (!spell)
2581 { 2533 {
2582 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2534 for (spell = pl->ob->inv; spell != NULL; spell = spell->below)
2583 { 2535 {
2584 /* were we to simply keep appending data here, we could exceed 2536 /* were we to simply keep appending data here, we could exceed
… …
2594 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 2546 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2595 * like it will fix this 2547 * like it will fix this
2596 */ 2548 */
2597 if (spell->type != SPELL) 2549 if (spell->type != SPELL)
2598 continue; 2550 continue;
2551
2599 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 2552 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2600 { 2553 {
2601 Send_With_Handling (&pl->socket, &sl); 2554 Send_With_Handling (&pl->socket, &sl);
2602 strcpy ((char *) sl.buf, "addspell "); 2555 strcpy ((char *) sl.buf, "addspell ");
2603 sl.len = strlen ((char *) sl.buf); 2556 sl.len = strlen ((char *) sl.buf);
2604 } 2557 }
2558
2605 append_spell (pl, &sl, spell); 2559 append_spell (pl, sl, spell);
2606 } 2560 }
2607 } 2561 }
2608 else if (spell->type != SPELL) 2562 else if (spell->type != SPELL)
2609 { 2563 {
2610 LOG (llevError, "Asked to send a non-spell object as a spell"); 2564 LOG (llevError, "Asked to send a non-spell object as a spell");
2611 return; 2565 return;
2612 } 2566 }
2613 else 2567 else
2614 append_spell (pl, &sl, spell); 2568 append_spell (pl, sl, spell);
2569
2615 if (sl.len >= MAXSOCKBUF) 2570 if (sl.length () >= MAXSOCKBUF)
2616 { 2571 {
2617 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 2572 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2618 fatal (0); 2573 fatal (0);
2619 } 2574 }
2575
2620 /* finally, we can send the packet */ 2576 /* finally, we can send the packet */
2621 Send_With_Handling (&pl->socket, &sl); 2577 Send_With_Handling (&pl->socket, &sl);
2622 free (sl.buf); 2578
2579 sl.free ();
2623} 2580}
2581

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines