ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.24 by root, Tue Sep 19 22:05:55 2006 UTC vs.
Revision 1.41 by root, Fri Dec 15 19:59:20 2006 UTC

… …
41 * if a face has not already been sent to the client, it is sent now. 41 * if a face has not already been sent to the client, it is sent now.
42 * 42 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing 43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations 44 * operations
45 * 45 *
46 * esrv_map_doneredraw finishes the map update, and ships across the
47 * map updates.
48 *
49 */ 46 */
50 47
51#include <global.h> 48#include <global.h>
52#include <sproto.h> 49#include <sproto.h>
53 50
54#include <newclient.h>
55#include <newserver.h>
56#include <living.h> 51#include <living.h>
57#include <commands.h> 52#include <commands.h>
58 53
59/* This block is basically taken from socket.c - I assume if it works there, 54/* This block is basically taken from socket.c - I assume if it works there,
60 * it should work here. 55 * it should work here.
61 */ 56 */
62#ifndef WIN32 /* ---win32 exclude unix headers */
63# include <sys/types.h> 57#include <sys/types.h>
64# include <sys/time.h> 58#include <sys/time.h>
65# include <sys/socket.h> 59#include <sys/socket.h>
66# include <netinet/in.h> 60#include <netinet/in.h>
67# include <netdb.h> 61#include <netdb.h>
68#endif /* win32 */
69 62
70#ifdef HAVE_UNISTD_H
71# include <unistd.h> 63#include <unistd.h>
72#endif
73
74#ifdef HAVE_SYS_TIME_H
75# include <sys/time.h> 64#include <sys/time.h>
76#endif
77 65
78#include "sounds.h" 66#include "sounds.h"
79 67
80/** 68/**
81 * This table translates the attack numbers as used within the 69 * This table translates the attack numbers as used within the
… …
98 -1, /* life stealing */ 86 -1, /* life stealing */
99 -1 /* Disease - not fully done yet */ 87 -1 /* Disease - not fully done yet */
100}; 88};
101 89
102static void 90static void
103socket_map_scroll (NewSocket * ns, int dx, int dy) 91socket_map_scroll (client * ns, int dx, int dy)
104{ 92{
105 struct Map newmap; 93 struct Map newmap;
106 int x, y, mx, my; 94 int x, y, mx, my;
107 95
108 { 96 {
109 char buf[MAXSOCKBUF]; 97 packet sl;
110 98
111 sprintf (buf, "map_scroll %d %d", dx, dy); 99 sl.printf ("map_scroll %d %d", dx, dy);
112 Write_String_To_Socket (ns, buf, strlen (buf)); 100 ns->send_packet (sl);
113 } 101 }
114 102
115 /* If we are using the Map1aCmd, we may in fact send 103 /* If we are using the Map1aCmd, we may in fact send
116 * head information that is outside the viewable map. 104 * head information that is outside the viewable map.
117 * So set the mx,my to the max value we want to 105 * So set the mx,my to the max value we want to
… …
137 for (x = 0; x < mx; x++) 125 for (x = 0; x < mx; x++)
138 { 126 {
139 for (y = 0; y < my; y++) 127 for (y = 0; y < my; y++)
140 { 128 {
141 if (x >= ns->mapx || y >= ns->mapy) 129 if (x >= ns->mapx || y >= ns->mapy)
142 {
143 /* clear cells outside the viewable area */ 130 /* clear cells outside the viewable area */
144 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell)); 131 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
145 }
146 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy) 132 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
147 {
148 /* clear newly visible tiles within the viewable area */ 133 /* clear newly visible tiles within the viewable area */
149 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell)); 134 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
150 }
151 else 135 else
152 {
153 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell)); 136 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
154 }
155 } 137 }
156 } 138 }
157 139
158 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map)); 140 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
159 141
… …
164} 146}
165 147
166static void 148static void
167clear_map (player *pl) 149clear_map (player *pl)
168{ 150{
169 NewSocket & socket = pl->socket; 151 client &socket = *pl->socket;
170 152
171 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 153 memset (&socket.lastmap, 0, sizeof (socket.lastmap));
172 154
173 if (socket.newmapcmd == 1) 155 if (socket.newmapcmd == 1)
174 Write_String_To_Socket (&socket, "newmap", 6); 156 socket.send_packet ("newmap");
175 157
176 socket.update_look = 1; 158 socket.update_look = 1;
177 socket.look_position = 0; 159 socket.look_position = 0;
178} 160}
179 161
180/** check for map change and send new map data */ 162/** check for map change and send new map data */
181static void 163static void
182check_map_change (player *pl) 164check_map_change (player *pl)
183{ 165{
184 NewSocket & socket = pl->socket; 166 client &socket = *pl->socket;
185 object *ob = pl->ob; 167 object *ob = pl->ob;
186 char buf[MAX_BUF]; /* eauugggh */ 168 char buf[MAX_BUF]; /* eauugggh */
187 169
188 if (socket.current_map != ob->map) 170 if (socket.current_map != ob->map)
189 { 171 {
… …
210 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 192 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path);
211 } 193 }
212 else 194 else
213 snprintf (buf, MAX_BUF, "mapinfo current"); 195 snprintf (buf, MAX_BUF, "mapinfo current");
214 196
215 Write_String_To_Socket (&socket, buf, strlen (buf)); 197 socket.send_packet (buf);
216 } 198 }
217 } 199 }
218 else if (socket.current_x != ob->x || socket.current_y != ob->y) 200 else if (socket.current_x != ob->x || socket.current_y != ob->y)
219 { 201 {
220 int dx = ob->x - socket.current_x; 202 int dx = ob->x - socket.current_x;
… …
230 } 212 }
231 } 213 }
232 214
233 socket.current_x = ob->x; 215 socket.current_x = ob->x;
234 socket.current_y = ob->y; 216 socket.current_y = ob->y;
217}
218
219/**
220 * RequestInfo is sort of a meta command. There is some specific
221 * request of information, but we call other functions to provide
222 * that information.
223 */
224void
225RequestInfo (char *buf, int len, client * ns)
226{
227 char *params = NULL, *cp;
228
229 /* No match */
230 char bigbuf[MAX_BUF];
231 int slen;
232
233 /* Set up replyinfo before we modify any of the buffers - this is used
234 * if we don't find a match.
235 */
236 strcpy (bigbuf, "replyinfo ");
237 slen = strlen (bigbuf);
238 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
239
240 /* find the first space, make it null, and update the
241 * params pointer.
242 */
243 for (cp = buf; *cp != '\0'; cp++)
244 if (*cp == ' ')
245 {
246 *cp = '\0';
247 params = cp + 1;
248 break;
249 }
250
251 if (!strcmp (buf, "image_info"))
252 send_image_info (ns, params);
253 else if (!strcmp (buf, "image_sums"))
254 send_image_sums (ns, params);
255 else if (!strcmp (buf, "skill_info"))
256 send_skill_info (ns, params);
257 else if (!strcmp (buf, "spell_paths"))
258 send_spell_paths (ns, params);
259 else
260 ns->send_packet (bigbuf, len);
235} 261}
236 262
237void 263void
238ExtCmd (char *buf, int len, player *pl) 264ExtCmd (char *buf, int len, player *pl)
239{ 265{
… …
260 buf += 8; 286 buf += 8;
261 287
262 // initial map and its origin 288 // initial map and its origin
263 maptile *map = pl->ob->map; 289 maptile *map = pl->ob->map;
264 sint16 dx, dy; 290 sint16 dx, dy;
265 int mapx = pl->socket.mapx / 2 - pl->ob->x; 291 int mapx = pl->socket->mapx / 2 - pl->ob->x;
266 int mapy = pl->socket.mapy / 2 - pl->ob->y; 292 int mapy = pl->socket->mapy / 2 - pl->ob->y;
267 int max_distance = 8; // limit maximum path length to something generous 293 int max_distance = 8; // limit maximum path length to something generous
268 294
269 while (*buf && map && max_distance) 295 while (*buf && map && max_distance)
270 { 296 {
271 int dir = *buf++; 297 int dir = *buf++;
… …
322 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 348 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token);
323 } 349 }
324 else 350 else
325 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 351 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
326 352
327 Write_String_To_Socket (&pl->socket, bigbuf, strlen (bigbuf)); 353 pl->socket->send_packet (bigbuf);
328} 354}
329 355
330/** This is the Setup cmd - easy first implementation */ 356/** This is the Setup cmd - easy first implementation */
331void 357void
332SetUp (char *buf, int len, NewSocket * ns) 358SetUp (char *buf, int len, client * ns)
333{ 359{
334 int s, slen; 360 int s, slen;
335 char *cmd, *param, cmdback[HUGE_BUF]; 361 char *cmd, *param, cmdback[HUGE_BUF];
336 362
337 /* run through the cmds of setup 363 /* run through the cmds of setup
… …
339 * 365 *
340 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown 366 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
341 * The client then must sort this out 367 * The client then must sort this out
342 */ 368 */
343 369
344 LOG (llevInfo, "Get SetupCmd:: %s\n", buf); 370 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
371
345 strcpy (cmdback, "setup"); 372 strcpy (cmdback, "setup");
346 for (s = 0; s < len;) 373 for (s = 0; s < len; )
347 { 374 {
348
349 cmd = &buf[s]; 375 cmd = &buf[s];
350 376
351 /* find the next space, and put a null there */ 377 /* find the next space, and put a null there */
352 for (; buf[s] && buf[s] != ' '; s++); 378 for (; buf[s] && buf[s] != ' '; s++)
379 ;
380
353 buf[s++] = 0; 381 buf[s++] = 0;
382
354 while (buf[s] == ' ') 383 while (buf[s] == ' ')
355 s++; 384 s++;
356 385
357 if (s >= len) 386 if (s >= len)
358 break; 387 break;
359 388
360 param = &buf[s]; 389 param = &buf[s];
361 390
362 for (; buf[s] && buf[s] != ' '; s++); 391 for (; buf[s] && buf[s] != ' '; s++)
392 ;
393
363 buf[s++] = 0; 394 buf[s++] = 0;
395
364 while (buf[s] == ' ') 396 while (buf[s] == ' ')
365 s++; 397 s++;
366 398
367 slen = strlen (cmdback); 399 slen = strlen (cmdback);
368 safe_strcat (cmdback, " ", &slen, HUGE_BUF); 400 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
… …
529 * report a failure to the client. 561 * report a failure to the client.
530 */ 562 */
531 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF); 563 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
532 } 564 }
533 } /* for processing all the setup commands */ 565 } /* for processing all the setup commands */
566
534 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback); 567 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
535 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 568 ns->send_packet (cmdback);
536} 569}
537 570
538/** 571/**
539 * The client has requested to be added to the game. 572 * The client has requested to be added to the game.
540 * This is what takes care of it. We tell the client how things worked out. 573 * This is what takes care of it. We tell the client how things worked out.
541 * I am not sure if this file is the best place for this function. however, 574 * I am not sure if this file is the best place for this function. however,
542 * it either has to be here or init_sockets needs to be exported. 575 * it either has to be here or init_sockets needs to be exported.
543 */ 576 */
544void 577void
545AddMeCmd (char *buf, int len, NewSocket * ns) 578AddMeCmd (char *buf, int len, client * ns)
546{ 579{
547 Settings oldsettings; 580 Settings oldsettings;
548 581
549 oldsettings = settings; 582 oldsettings = settings;
550 if (ns->status != Ns_Add || add_player (ns)) 583 if (ns->status != Ns_Add || add_player (ns))
551 { 584 ns->send_packet ("addme_failed");
552 Write_String_To_Socket (ns, "addme_failed", 12);
553 }
554 else 585 else
555 { 586 ns->send_packet ("addme_success");
556 /* Basically, the add_player copies the socket structure into 587
557 * the player structure, so this one (which is from init_sockets)
558 * is not needed anymore. The write below should still work, as the
559 * stuff in ns is still relevant.
560 */
561 Write_String_To_Socket (ns, "addme_success", 13);
562 socket_info.nconns--;
563 ns->status = Ns_Avail;
564 }
565 settings = oldsettings; 588 settings = oldsettings;
566} 589}
567 590
568/** Reply to ExtendedInfos command */ 591/** Reply to ExtendedInfos command */
569void 592void
570ToggleExtendedInfos (char *buf, int len, NewSocket * ns) 593ToggleExtendedInfos (char *buf, int len, client * ns)
571{ 594{
572 char cmdback[MAX_BUF]; 595 char cmdback[MAX_BUF];
573 char command[50]; 596 char command[50];
574 int info, nextinfo; 597 int info, nextinfo;
575 598
… …
613 { 636 {
614 strcat (cmdback, " "); 637 strcat (cmdback, " ");
615 strcat (cmdback, "smoothing"); 638 strcat (cmdback, "smoothing");
616 } 639 }
617 640
618 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 641 ns->send_packet (cmdback);
619} 642}
620 643
621/* 644/*
622#define MSG_TYPE_BOOK 1 645#define MSG_TYPE_BOOK 1
623#define MSG_TYPE_CARD 2 646#define MSG_TYPE_CARD 2
… …
626#define MSG_TYPE_MONUMENT 5 649#define MSG_TYPE_MONUMENT 5
627#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 650#define MSG_TYPE_SCRIPTED_DIALOG 6*/
628 651
629/** Reply to ExtendedInfos command */ 652/** Reply to ExtendedInfos command */
630void 653void
631ToggleExtendedText (char *buf, int len, NewSocket * ns) 654ToggleExtendedText (char *buf, int len, client * ns)
632{ 655{
633 char cmdback[MAX_BUF]; 656 char cmdback[MAX_BUF];
634 char temp[10]; 657 char temp[10];
635 char command[50]; 658 char command[50];
636 int info, nextinfo, i, flag; 659 int info, nextinfo, i, flag;
… …
676 strcat (cmdback, " "); 699 strcat (cmdback, " ");
677 snprintf (temp, sizeof (temp), "%d", i); 700 snprintf (temp, sizeof (temp), "%d", i);
678 strcat (cmdback, temp); 701 strcat (cmdback, temp);
679 } 702 }
680 703
681 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 704 ns->send_packet (cmdback);
682} 705}
683 706
684/** 707/**
685 * A lot like the old AskSmooth (in fact, now called by AskSmooth). 708 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
686 * Basically, it makes no sense to wait for the client to request a 709 * Basically, it makes no sense to wait for the client to request a
687 * a piece of data from us that we know the client wants. So 710 * a piece of data from us that we know the client wants. So
688 * if we know the client wants it, might as well push it to the 711 * if we know the client wants it, might as well push it to the
689 * client. 712 * client.
690 */ 713 */
691static void 714static void
692SendSmooth (NewSocket * ns, uint16 face) 715SendSmooth (client * ns, uint16 face)
693{ 716{
694 uint16 smoothface; 717 uint16 smoothface;
695 unsigned char reply[MAX_BUF];
696 SockList sl;
697 718
698 /* If we can't find a face, return and set it so we won't try to send this 719 /* If we can't find a face, return and set it so we won't try to send this
699 * again. 720 * again.
700 */ 721 */
701 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface))) 722 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
… …
709 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE)) 730 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
710 esrv_send_face (ns, smoothface, 0); 731 esrv_send_face (ns, smoothface, 0);
711 732
712 ns->faces_sent[face] |= NS_FACESENT_SMOOTH; 733 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
713 734
714 sl.buf = reply; 735 packet sl;
715 strcpy ((char *) sl.buf, "smooth "); 736
716 sl.len = strlen ((char *) sl.buf); 737 sl << "smooth "
717 SockList_AddShort (&sl, face); 738 << uint16 (face)
718 SockList_AddShort (&sl, smoothface); 739 << uint16 (smoothface);
719 Send_With_Handling (ns, &sl); 740
741 ns->send_packet (sl);
720} 742}
721 743
722 /** 744 /**
723 * Tells client the picture it has to use 745 * Tells client the picture it has to use
724 * to smooth a picture number given as argument. 746 * to smooth a picture number given as argument.
725 */ 747 */
726void 748void
727AskSmooth (char *buf, int len, NewSocket * ns) 749AskSmooth (char *buf, int len, client * ns)
728{ 750{
729 uint16 facenbr; 751 uint16 facenbr;
730 752
731 facenbr = atoi (buf); 753 facenbr = atoi (buf);
732 SendSmooth (ns, facenbr); 754 SendSmooth (ns, facenbr);
733} 755}
734
735
736
737
738 756
739/** 757/**
740 * This handles the general commands from the client (ie, north, fire, cast, 758 * This handles the general commands from the client (ie, north, fire, cast,
741 * etc.) 759 * etc.)
742 */ 760 */
… …
793 * etc.). It is a lot like PlayerCmd above, but is called with the 811 * etc.). It is a lot like PlayerCmd above, but is called with the
794 * 'ncom' method which gives more information back to the client so it 812 * 'ncom' method which gives more information back to the client so it
795 * can throttle. 813 * can throttle.
796 */ 814 */
797void 815void
798NewPlayerCmd (uint8 * buf, int len, player *pl) 816NewPlayerCmd (char *buf, int len, player *pl)
799{ 817{
800 int time, repeat; 818 int time, repeat;
801 short packet;
802 unsigned char command[MAX_BUF]; 819 char command[MAX_BUF];
803 SockList sl; 820 int pktlen;
804 821
805 if (len < 7) 822 if (len < 7)
806 { 823 {
807 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 824 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
808 return; 825 return;
809 } 826 }
810 827
811 packet = GetShort_String (buf); 828 pktlen = net_uint16 ((uint8 *)buf);
812 repeat = GetInt_String (buf + 2); 829 repeat = net_uint32 ((uint8 *)buf + 2);
830
813 /* -1 is special - no repeat, but don't update */ 831 /* -1 is special - no repeat, but don't update */
814 if (repeat != -1) 832 if (repeat != -1)
815 {
816 pl->count = repeat; 833 pl->count = repeat;
817 } 834
818 if ((len - 4) >= MAX_BUF) 835 if ((len - 4) >= MAX_BUF)
819 len = MAX_BUF - 5; 836 len = MAX_BUF - 5;
820 837
821 strncpy ((char *) command, (char *) buf + 6, len - 4); 838 strncpy ((char *) command, (char *) buf + 6, len - 4);
822 command[len - 4] = '\0'; 839 command[len - 4] = 0;
823
824 /* The following should never happen with a proper or honest client.
825 * Therefore, the error message doesn't have to be too clear - if
826 * someone is playing with a hacked/non working client, this gives them
827 * an idea of the problem, but they deserve what they get
828 */
829 if (pl->state != ST_PLAYING)
830 {
831 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
832 return;
833 }
834 840
835 /* This should not happen anymore. */ 841 /* This should not happen anymore. */
836 if (pl->ob->speed_left < -1.0) 842 if (pl->ob->speed_left < -1.0)
837 {
838 LOG (llevError, "Player has negative time - shouldn't do command.\n"); 843 LOG (llevError, "Player has negative time - shouldn't do command.\n");
839 } 844
840 /* In c_new.c */ 845 /* In c_new.c */
841 execute_newserver_command (pl->ob, (char *) command); 846 execute_newserver_command (pl->ob, (char *) command);
842 /* Perhaps something better should be done with a left over count. 847 /* Perhaps something better should be done with a left over count.
843 * Cleaning up the input should probably be done first - all actions 848 * Cleaning up the input should probably be done first - all actions
844 * for the command that issued the count should be done before any other 849 * for the command that issued the count should be done before any other
845 * commands. 850 * commands.
846 */ 851 */
847 pl->count = 0; 852 pl->count = 0;
848 853
849 /* Send confirmation of command execution now */
850 sl.buf = command;
851 strcpy ((char *) sl.buf, "comc ");
852 sl.len = 5;
853 SockList_AddShort (&sl, packet);
854 if (FABS (pl->ob->speed) < 0.001) 854 if (FABS (pl->ob->speed) < 0.001)
855 time = MAX_TIME * 100; 855 time = MAX_TIME * 100;
856 else 856 else
857 time = (int) (MAX_TIME / FABS (pl->ob->speed)); 857 time = (int) (MAX_TIME / FABS (pl->ob->speed));
858 SockList_AddInt (&sl, time); 858
859 Send_With_Handling (&pl->socket, &sl); 859 /* Send confirmation of command execution now */
860
861 packet sl;
862 sl << "comc " << uint16 (pktlen) << uint32 (time);
863 pl->socket->send_packet (sl);
860} 864}
861 865
862 866
863/** This is a reply to a previous query. */ 867/** This is a reply to a previous query. */
864void 868void
… …
931 * something older than the server. If we assume the client will be 935 * something older than the server. If we assume the client will be
932 * backwards compatible, having it be a later version should not be a 936 * backwards compatible, having it be a later version should not be a
933 * problem. 937 * problem.
934 */ 938 */
935void 939void
936VersionCmd (char *buf, int len, NewSocket * ns) 940VersionCmd (char *buf, int len, client * ns)
937{ 941{
938 char *cp; 942 char *cp;
939 char version_warning[256]; 943 char version_warning[256];
940 944
941 if (!buf) 945 if (!buf)
… …
965 cp = strchr (cp + 1, ' '); 969 cp = strchr (cp + 1, ' ');
966 if (cp) 970 if (cp)
967 { 971 {
968 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host); 972 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host);
969 973
970 snprintf (ns->client, sizeof (ns->client), "%s", cp + 1); 974 assign (ns->version, cp + 1);
971 975
972 /* This is first implementation - i skip all beta DX clients with it 976 if (ns->sc_version < 1026)
973 * Add later stuff here for other clients
974 */
975
976 /* these are old dxclients */
977 /* Version 1024 added support for singular + plural name values -
978 * requiing this minimal value reduces complexity of that code, and it
979 * has been around for a long time.
980 */
981 if (!strcmp (" CF DX CLIENT", cp) || ns->sc_version < 1024)
982 { 977 {
983 sprintf (version_warning, "drawinfo %d %s", NDI_RED, 978 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
984 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 979 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
985 Write_String_To_Socket (ns, version_warning, strlen (version_warning)); 980 ns->send_packet (version_warning);
986 } 981 }
987 982
988 } 983 }
989} 984}
990 985
991/** sound related functions. */ 986/** sound related functions. */
992
993void 987void
994SetSound (char *buf, int len, NewSocket * ns) 988SetSound (char *buf, int len, client * ns)
995{ 989{
996 ns->sound = atoi (buf); 990 ns->sound = atoi (buf);
997} 991}
998 992
999/** client wants the map resent */ 993/** client wants the map resent */
… …
1009 */ 1003 */
1010#if 0 1004#if 0
1011 /* Okay, this is MAJOR UGLY. but the only way I know how to 1005 /* Okay, this is MAJOR UGLY. but the only way I know how to
1012 * clear the "cache" 1006 * clear the "cache"
1013 */ 1007 */
1014 memset (&pl->socket.lastmap, 0, sizeof (struct Map)); 1008 memset (&pl->socket->lastmap, 0, sizeof (struct Map));
1015 draw_client_map (pl->ob); 1009 draw_client_map (pl->ob);
1016#endif 1010#endif
1017} 1011}
1018 1012
1019/** 1013/**
… …
1057/** 1051/**
1058 * Asks the client to query the user. This way, the client knows 1052 * Asks the client to query the user. This way, the client knows
1059 * it needs to send something back (vs just printing out a message) 1053 * it needs to send something back (vs just printing out a message)
1060 */ 1054 */
1061void 1055void
1062send_query (NewSocket * ns, uint8 flags, char *text) 1056send_query (client * ns, uint8 flags, char *text)
1063{ 1057{
1064 char buf[MAX_BUF]; 1058 char buf[MAX_BUF];
1065 1059
1066 sprintf (buf, "query %d %s", flags, text ? text : ""); 1060 sprintf (buf, "query %d %s", flags, text ? text : "");
1067 Write_String_To_Socket (ns, buf, strlen (buf)); 1061 ns->send_packet (buf);
1068} 1062}
1069 1063
1070#define AddIfInt64(Old,New,Type) if (Old != New) {\ 1064#define AddIfInt64(Old,New,Type) if (Old != New) {\
1071 Old = New; \ 1065 Old = New; \
1072 SockList_AddChar(&sl, Type); \ 1066 sl << uint8 (Type) << uint64 (New); \
1073 SockList_AddInt64(&sl, New); \
1074 } 1067 }
1075 1068
1076#define AddIfInt(Old,New,Type) if (Old != New) {\ 1069#define AddIfInt(Old,New,Type) if (Old != New) {\
1077 Old = New; \ 1070 Old = New; \
1078 SockList_AddChar(&sl, Type); \ 1071 sl << uint8 (Type) << uint32 (New); \
1079 SockList_AddInt(&sl, New); \
1080 } 1072 }
1081 1073
1082#define AddIfShort(Old,New,Type) if (Old != New) {\ 1074#define AddIfShort(Old,New,Type) if (Old != New) {\
1083 Old = New; \ 1075 Old = New; \
1084 SockList_AddChar(&sl, Type); \ 1076 sl << uint8 (Type) << uint16 (New); \
1085 SockList_AddShort(&sl, New); \
1086 } 1077 }
1087 1078
1088#define AddIfFloat(Old,New,Type) if (Old != New) {\ 1079#define AddIfFloat(Old,New,Type) if (Old != New) {\
1089 Old = New; \ 1080 Old = New; \
1090 SockList_AddChar(&sl, Type); \ 1081 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \
1091 SockList_AddInt(&sl,(long)(New*FLOAT_MULTI));\
1092 } 1082 }
1093 1083
1094#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 1084#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1095 if (Old) free(Old);\
1096 Old = strdup_local(New);\ 1085 free(Old); Old = strdup (New);\
1097 SockList_AddChar(&sl, Type); \ 1086 sl << uint8 (Type) << data8 (New); \
1098 SockList_AddChar(&sl, ( char )strlen(New)); \
1099 strcpy((char*)sl.buf + sl.len, New); \
1100 sl.len += strlen(New); \
1101 } 1087 }
1102 1088
1103/** 1089/**
1104 * Sends a statistics update. We look at the old values, 1090 * Sends a statistics update. We look at the old values,
1105 * and only send what has changed. Stat mapping values are in newclient.h 1091 * and only send what has changed. Stat mapping values are in newclient.h
… …
1107 * commands for now. 1093 * commands for now.
1108 */ 1094 */
1109void 1095void
1110esrv_update_stats (player *pl) 1096esrv_update_stats (player *pl)
1111{ 1097{
1112 SockList sl;
1113 char buf[MAX_BUF]; 1098 char buf[MAX_BUF];
1114 uint16 flags; 1099 uint16 flags;
1115 1100
1116 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1101 packet sl;
1117 strcpy ((char *) sl.buf, "stats "); 1102 sl << "stats ";
1118 sl.len = strlen ((char *) sl.buf);
1119 1103
1120 if (pl->ob != NULL) 1104 if (pl->ob != NULL)
1121 { 1105 {
1122 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 1106 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP);
1123 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 1107 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP);
… …
1132 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 1116 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX);
1133 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 1117 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON);
1134 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 1118 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA);
1135 } 1119 }
1136 1120
1137 if (pl->socket.exp64) 1121 if (pl->socket->exp64)
1138 { 1122 {
1139 uint8 s; 1123 uint8 s;
1140 1124
1141 for (s = 0; s < NUM_SKILLS; s++) 1125 for (s = 0; s < NUM_SKILLS; s++)
1142 { 1126 {
1143 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 1127 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp)
1144 { 1128 {
1145
1146 /* Always send along the level if exp changes. This is only 1129 /* Always send along the level if exp changes. This is only
1147 * 1 extra byte, but keeps processing simpler. 1130 * 1 extra byte, but keeps processing simpler.
1148 */ 1131 */
1149 SockList_AddChar (&sl, (char) (s + CS_STAT_SKILLINFO)); 1132 sl << uint8 (s + CS_STAT_SKILLINFO)
1150 SockList_AddChar (&sl, (char) pl->last_skill_ob[s]->level); 1133 << uint8 (pl->last_skill_ob[s]->level)
1151 SockList_AddInt64 (&sl, pl->last_skill_ob[s]->stats.exp); 1134 << uint64 (pl->last_skill_ob[s]->stats.exp);
1135
1152 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp; 1136 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1153 } 1137 }
1154 } 1138 }
1155 } 1139 }
1156 1140
1157 if (pl->socket.exp64) 1141 if (pl->socket->exp64)
1158 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) } 1142 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) }
1159 else 1143 else
1160 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) } 1144 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1161 1145
1162 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 1146 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL);
… …
1175 if (pl->run_on) 1159 if (pl->run_on)
1176 flags |= SF_RUNON; 1160 flags |= SF_RUNON;
1177 1161
1178 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 1162 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS);
1179 1163
1180 if (pl->socket.sc_version < 1025) 1164 if (pl->socket->sc_version < 1025)
1181 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) } 1165 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1182 else 1166 else
1183 { 1167 {
1184 int i; 1168 int i;
1185 1169
… …
1191 1175
1192 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 1176 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]);
1193 } 1177 }
1194 } 1178 }
1195 1179
1196 if (pl->socket.monitor_spells) 1180 if (pl->socket->monitor_spells)
1197 { 1181 {
1198 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 1182 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1199 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 1183 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL);
1200 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 1184 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY);
1201 } 1185 }
1202 1186
1203 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 1187 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */
1204 AddIfString (pl->socket.stats.range, buf, CS_STAT_RANGE); 1188 AddIfString (pl->socket->stats.range, buf, CS_STAT_RANGE);
1205 set_title (pl->ob, buf); 1189 set_title (pl->ob, buf);
1206 AddIfString (pl->socket.stats.title, buf, CS_STAT_TITLE); 1190 AddIfString (pl->socket->stats.title, buf, CS_STAT_TITLE);
1207 1191
1208 /* Only send it away if we have some actual data */ 1192 /* Only send it away if we have some actual data */
1209 if (sl.len > 6) 1193 if (sl.length () > 6)
1210 { 1194 pl->socket->send_packet (sl);
1211#ifdef ESRV_DEBUG
1212 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1213#endif
1214 Send_With_Handling (&pl->socket, &sl);
1215 }
1216
1217 free (sl.buf);
1218} 1195}
1219 1196
1220/** 1197/**
1221 * Tells the client that here is a player it should start using. 1198 * Tells the client that here is a player it should start using.
1222 */ 1199 */
1223void 1200void
1224esrv_new_player (player *pl, uint32 weight) 1201esrv_new_player (player *pl, uint32 weight)
1225{ 1202{
1226 SockList sl;
1227
1228 pl->last_weight = weight; 1203 pl->last_weight = weight;
1229 1204
1230 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1205 packet sl;
1206 sl << "player ";
1231 1207
1232 strcpy ((char *) sl.buf, "player "); 1208 sl << uint32 (pl->ob->count)
1233 sl.len = strlen ((char *) sl.buf); 1209 << uint32 (weight)
1234 SockList_AddInt (&sl, pl->ob->count); 1210 << uint32 (pl->ob->face->number)
1235 SockList_AddInt (&sl, weight); 1211 << data8 (pl->ob->name);
1236 SockList_AddInt (&sl, pl->ob->face->number);
1237 1212
1238 SockList_AddChar (&sl, (char) strlen (pl->ob->name)); 1213 pl->socket->send_packet (sl);
1239 strcpy ((char *) sl.buf + sl.len, pl->ob->name);
1240 sl.len += strlen (pl->ob->name);
1241
1242 Send_With_Handling (&pl->socket, &sl);
1243 free (sl.buf);
1244 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1214 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1245} 1215}
1246 1216
1247/** 1217/**
1248 * Need to send an animation sequence to the client. 1218 * Need to send an animation sequence to the client.
… …
1250 * sent them the face yet (this can become quite costly in terms of 1220 * sent them the face yet (this can become quite costly in terms of
1251 * how much we are sending - on the other hand, this should only happen 1221 * how much we are sending - on the other hand, this should only happen
1252 * when the player logs in and picks stuff up. 1222 * when the player logs in and picks stuff up.
1253 */ 1223 */
1254void 1224void
1255esrv_send_animation (NewSocket * ns, short anim_num) 1225esrv_send_animation (client * ns, short anim_num)
1256{ 1226{
1257 SockList sl;
1258 int i; 1227 int i;
1259 1228
1260 /* Do some checking on the anim_num we got. Note that the animations 1229 /* Do some checking on the anim_num we got. Note that the animations
1261 * are added in contigous order, so if the number is in the valid 1230 * are added in contigous order, so if the number is in the valid
1262 * range, it must be a valid animation. 1231 * range, it must be a valid animation.
… …
1265 { 1234 {
1266 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num); 1235 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1267 return; 1236 return;
1268 } 1237 }
1269 1238
1270 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1239 packet sl;
1271 strcpy ((char *) sl.buf, "anim "); 1240
1272 sl.len = 5; 1241 sl << "anim "
1273 SockList_AddShort (&sl, anim_num); 1242 << uint16 (anim_num)
1274 SockList_AddShort (&sl, 0); /* flags - not used right now */ 1243 << uint16 (0); /* flags - not used right now */
1244
1275 /* Build up the list of faces. Also, send any information (ie, the 1245 /* Build up the list of faces. Also, send any information (ie, the
1276 * the face itself) down to the client. 1246 * the face itself) down to the client.
1277 */ 1247 */
1278 for (i = 0; i < animations[anim_num].num_animations; i++) 1248 for (i = 0; i < animations[anim_num].num_animations; i++)
1279 { 1249 {
1280 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE)) 1250 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1281 esrv_send_face (ns, animations[anim_num].faces[i], 0); 1251 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1282 SockList_AddShort (&sl, animations[anim_num].faces[i]); /* flags - not used right now */ 1252 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1283 } 1253 }
1284 Send_With_Handling (ns, &sl); 1254
1285 free (sl.buf); 1255 ns->send_packet (sl);
1256
1286 ns->anims_sent[anim_num] = 1; 1257 ns->anims_sent[anim_num] = 1;
1287} 1258}
1288 1259
1289 1260
1290/****************************************************************************** 1261/******************************************************************************
… …
1296/** 1267/**
1297 * This adds face_num to a map cell at x,y. If the client doesn't have 1268 * This adds face_num to a map cell at x,y. If the client doesn't have
1298 * the face yet, we will also send it. 1269 * the face yet, we will also send it.
1299 */ 1270 */
1300static void 1271static void
1301esrv_map_setbelow (NewSocket * ns, int x, int y, short face_num, struct Map *newmap) 1272esrv_map_setbelow (client * ns, int x, int y, short face_num, struct Map *newmap)
1302{ 1273{
1303 if (newmap->cells[x][y].count >= MAP_LAYERS) 1274 if (newmap->cells[x][y].count >= MAP_LAYERS)
1304 { 1275 {
1305 LOG (llevError, "Too many faces in map cell %d %d\n", x, y); 1276 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1306 return; 1277 return;
1307 abort (); 1278 abort ();
1308 } 1279 }
1280
1309 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num; 1281 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1310 newmap->cells[x][y].count++; 1282 newmap->cells[x][y].count++;
1283
1311 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1284 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1312 esrv_send_face (ns, face_num, 0); 1285 esrv_send_face (ns, face_num, 0);
1313} 1286}
1314 1287
1315struct LayerCell 1288struct LayerCell
… …
1324 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y]; 1297 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1325}; 1298};
1326 1299
1327/** Checkes if map cells have changed */ 1300/** Checkes if map cells have changed */
1328static int 1301static int
1329mapcellchanged (NewSocket * ns, int i, int j, struct Map *newmap) 1302mapcellchanged (client * ns, int i, int j, struct Map *newmap)
1330{ 1303{
1331 int k; 1304 int k;
1332 1305
1333 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count) 1306 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1334 return 1; 1307 return 1;
… …
1347 * cnum is the client number, cur is the the buffer we put all of 1320 * cnum is the client number, cur is the the buffer we put all of
1348 * this data into. we return the end of the data. layers is 1321 * this data into. we return the end of the data. layers is
1349 * how many layers of data we should back. 1322 * how many layers of data we should back.
1350 */ 1323 */
1351static uint8 * 1324static uint8 *
1352compactlayer (NewSocket * ns, unsigned char *cur, int numlayers, struct Map *newmap) 1325compactlayer (client * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1353{ 1326{
1354 int x, y, k; 1327 int x, y, k;
1355 int face; 1328 int face;
1356 unsigned char *fcur; 1329 unsigned char *fcur;
1357 struct MapLayer layers[MAP_LAYERS]; 1330 struct MapLayer layers[MAP_LAYERS];
… …
1417 *fcur = *fcur | 128; /* mark for end of faces at this layer */ 1390 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1418 } 1391 }
1419 return cur; 1392 return cur;
1420} 1393}
1421 1394
1422static void
1423esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1424{
1425 static long frames, bytes, tbytes, tframes;
1426 char *cur;
1427 SockList sl;
1428
1429
1430 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1431 strcpy ((char *) sl.buf, "map ");
1432 sl.len = strlen ((char *) sl.buf);
1433
1434 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1435 sl.len = cur - (char *) sl.buf;
1436
1437/* LOG(llevDebug, "Sending map command.\n");*/
1438
1439 if (sl.len > (int) strlen ("map ") || ns->sent_scroll)
1440 {
1441 /* All of this is just accounting stuff */
1442 if (tframes > 100)
1443 tframes = tbytes = 0;
1444
1445 tframes++;
1446 frames++;
1447 tbytes += sl.len;
1448 bytes += sl.len;
1449 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1450 Send_With_Handling (ns, &sl);
1451 ns->sent_scroll = 0;
1452 }
1453
1454 free (sl.buf);
1455}
1456
1457
1458/** Clears a map cell */ 1395/** Clears a map cell */
1459static void 1396static void
1460map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 1397map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count)
1461{ 1398{
1462 cell->faces[0] = face0; 1399 cell->faces[0] = face0;
1463 cell->faces[1] = face1; 1400 cell->faces[1] = face1;
1464 cell->faces[2] = face2; 1401 cell->faces[2] = face2;
1465 cell->count = count; 1402 cell->count = count;
1466 cell->stat_hp = 0; 1403 cell->stat_hp = 0;
1404 cell->flags = 0;
1467 cell->player = 0; 1405 cell->player = 0;
1468} 1406}
1469 1407
1470#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y) 1408#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1471#define MAX_LAYERS 3 1409#define MAX_LAYERS 3
1472 1410
… …
1500 * needs to get sent - if so, it adds the data, sending the head 1438 * needs to get sent - if so, it adds the data, sending the head
1501 * if needed, and returning 1. If this no data needs to get 1439 * if needed, and returning 1. If this no data needs to get
1502 * sent, it returns zero. 1440 * sent, it returns zero.
1503 */ 1441 */
1504static int 1442static int
1505check_head (SockList & sl, NewSocket & ns, int ax, int ay, int layer) 1443check_head (packet &sl, client &ns, int ax, int ay, int layer)
1506{ 1444{
1507 short face_num; 1445 short face_num;
1508 1446
1509 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]) 1447 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1510 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number; 1448 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1511 else 1449 else
1512 face_num = 0; 1450 face_num = 0;
1513 1451
1514 if (face_num != ns.lastmap.cells[ax][ay].faces[layer]) 1452 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1515 { 1453 {
1516 SockList_AddShort (&sl, face_num); 1454 sl << uint16 (face_num);
1517 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1455 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1518 esrv_send_face (&ns, face_num, 0); 1456 esrv_send_face (&ns, face_num, 0);
1457
1519 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL; 1458 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1520 ns.lastmap.cells[ax][ay].faces[layer] = face_num; 1459 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1521 return 1; 1460 return 1;
1522 } 1461 }
1523 1462
… …
1543 * the case, it seems to make more sense to have these layer values 1482 * the case, it seems to make more sense to have these layer values
1544 * actually match. 1483 * actually match.
1545 */ 1484 */
1546 1485
1547static int 1486static int
1548update_space (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1487update_space (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1549{ 1488{
1550 object *ob, *head; 1489 object *ob, *head;
1551 uint16 face_num; 1490 uint16 face_num;
1552 int bx, by, i; 1491 int bx, by, i;
1553 1492
1554 /* If there is a multipart object stored away, treat that as more important. 1493 /* If there is a multipart object stored away, treat that as more important.
1555 * If not, then do the normal processing. 1494 * If not, then do the normal processing.
1556 */ 1495 */
1557
1558 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer]; 1496 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1559 1497
1560 /* Check to see if this head is part of the set of objects 1498 /* Check to see if this head is part of the set of objects
1561 * we would normally send for this space. If so, then 1499 * we would normally send for this space. If so, then
1562 * don't use the head value. We need to do the check 1500 * don't use the head value. We need to do the check
… …
1727 1665
1728 /* Another hack - because of heads and whatnot, this face may match one 1666 /* Another hack - because of heads and whatnot, this face may match one
1729 * we already sent for a lower layer. In that case, don't send 1667 * we already sent for a lower layer. In that case, don't send
1730 * this one. 1668 * this one.
1731 */ 1669 */
1732 if (face_num && layer + 1 < MAP_LAYERS && ns->lastmap.cells[sx][sy].faces[layer + 1] == face_num) 1670 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1733 {
1734 face_num = 0; 1671 face_num = 0;
1735 }
1736 1672
1737 /* We've gotten what face we want to use for the object. Now see if 1673 /* We've gotten what face we want to use for the object. Now see if
1738 * if it has changed since we last sent it to the client. 1674 * if it has changed since we last sent it to the client.
1739 */ 1675 */
1740 if (ns->lastmap.cells[sx][sy].faces[layer] != face_num) 1676 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num)
1741 { 1677 {
1742 ns->lastmap.cells[sx][sy].faces[layer] = face_num; 1678 ns.lastmap.cells[sx][sy].faces[layer] = face_num;
1743 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1679 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1744 esrv_send_face (ns, face_num, 0); 1680 esrv_send_face (&ns, face_num, 0);
1745 SockList_AddShort (sl, face_num); 1681
1682 sl << uint16 (face_num);
1746 return 1; 1683 return 1;
1747 } 1684 }
1685
1748 /* Nothing changed */ 1686 /* Nothing changed */
1749 return 0; 1687 return 0;
1750} 1688}
1751 1689
1752/** 1690/**
… …
1767 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ 1705 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1768 * take. 1706 * take.
1769 */ 1707 */
1770 1708
1771static inline int 1709static inline int
1772update_smooth (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1710update_smooth (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1773{ 1711{
1774 object *ob; 1712 object *ob;
1775 int smoothlevel; /* old face_num; */ 1713 int smoothlevel; /* old face_num; */
1776 1714
1777 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer); 1715 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
… …
1782 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp)) 1720 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1783 smoothlevel = 0; 1721 smoothlevel = 0;
1784 else 1722 else
1785 { 1723 {
1786 smoothlevel = ob->smoothlevel; 1724 smoothlevel = ob->smoothlevel;
1787 if (smoothlevel && !(ns->faces_sent[ob->face->number] & NS_FACESENT_SMOOTH)) 1725 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1788 SendSmooth (ns, ob->face->number); 1726 SendSmooth (&ns, ob->face->number);
1789 } /* else not already head object or blank face */ 1727 } /* else not already head object or blank face */
1790 1728
1791 /* We've gotten what face we want to use for the object. Now see if 1729 /* We've gotten what face we want to use for the object. Now see if
1792 * if it has changed since we last sent it to the client. 1730 * if it has changed since we last sent it to the client.
1793 */ 1731 */
1794 if (smoothlevel > 255) 1732 if (smoothlevel > 255)
1795 smoothlevel = 255; 1733 smoothlevel = 255;
1796 else if (smoothlevel < 0) 1734 else if (smoothlevel < 0)
1797 smoothlevel = 0; 1735 smoothlevel = 0;
1736
1798 if (ns->lastmap.cells[sx][sy].smooth[layer] != smoothlevel) 1737 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1799 { 1738 {
1800 ns->lastmap.cells[sx][sy].smooth[layer] = smoothlevel; 1739 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1801 SockList_AddChar (sl, (uint8) (smoothlevel & 0xFF)); 1740 sl << uint8 (smoothlevel);
1802 return 1; 1741 return 1;
1803 } 1742 }
1743
1804 /* Nothing changed */ 1744 /* Nothing changed */
1805 return 0; 1745 return 0;
1806} 1746}
1807 1747
1808/** 1748/**
1809 * Returns the size of a data for a map square as returned by 1749 * Returns the size of a data for a map square as returned by
1810 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries 1750 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1811 * available. 1751 * available.
1812 */ 1752 */
1813int 1753int
1814getExtendedMapInfoSize (NewSocket * ns) 1754getExtendedMapInfoSize (client * ns)
1815{ 1755{
1816 int result = 0; 1756 int result = 0;
1817 1757
1818 if (ns->ext_mapinfos) 1758 if (ns->ext_mapinfos)
1819 { 1759 {
… …
1849draw_client_map1 (object *pl) 1789draw_client_map1 (object *pl)
1850{ 1790{
1851 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1791 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen;
1852 sint16 nx, ny; 1792 sint16 nx, ny;
1853 int estartlen, eoldlen; 1793 int estartlen, eoldlen;
1854 SockList sl;
1855 SockList esl; /*For extended Map info */
1856 uint16 mask, emask; 1794 uint16 mask, emask;
1857 uint8 eentrysize; 1795 uint8 eentrysize;
1858 uint16 ewhatstart, ewhatflag; 1796 uint16 ewhatstart, ewhatflag;
1859 uint8 extendedinfos; 1797 uint8 extendedinfos;
1860 maptile *m; 1798 maptile *m;
1861 1799
1862 NewSocket & socket = pl->contr->socket; 1800 client &socket = *pl->contr->socket;
1863 1801
1864 check_map_change (pl->contr); 1802 check_map_change (pl->contr);
1865 1803
1866 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1804 packet sl;
1867 if (socket.mapmode == Map1Cmd) 1805 packet esl;
1868 strcpy ((char *) sl.buf, "map1 "); 1806
1869 else 1807 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1870 strcpy ((char *) sl.buf, "map1a ");
1871 sl.len = strlen ((char *) sl.buf);
1872 startlen = sl.len; 1808 startlen = sl.length ();
1809
1873 /*Extendedmapinfo structure initialisation */ 1810 /*Extendedmapinfo structure initialisation */
1874 if (socket.ext_mapinfos) 1811 if (socket.ext_mapinfos)
1875 { 1812 {
1876 esl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1877 strcpy ((char *) esl.buf, "mapextended ");
1878 esl.len = strlen ((char *) esl.buf);
1879 extendedinfos = EMI_NOREDRAW; 1813 extendedinfos = EMI_NOREDRAW;
1814
1880 if (socket.EMI_smooth) 1815 if (socket.EMI_smooth)
1881 extendedinfos |= EMI_SMOOTH; 1816 extendedinfos |= EMI_SMOOTH;
1817
1882 ewhatstart = esl.len; 1818 ewhatstart = esl.length ();
1883 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 1819 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1884 could need to be taken away */ 1820 could need to be taken away */
1885 SockList_AddChar (&esl, extendedinfos);
1886 eentrysize = getExtendedMapInfoSize (&socket); 1821 eentrysize = getExtendedMapInfoSize (&socket);
1887 SockList_AddChar (&esl, eentrysize); 1822 esl << "mapextended "
1823 << uint8 (extendedinfos)
1824 << uint8 (eentrysize);
1825
1888 estartlen = esl.len; 1826 estartlen = esl.length ();
1889 } 1827 }
1890 else 1828 else
1891 { 1829 {
1892 /* suppress compiler warnings */ 1830 /* suppress compiler warnings */
1893 ewhatstart = 0; 1831 ewhatstart = 0;
1894 ewhatflag = 0; 1832 ewhatflag = 0;
1895 estartlen = 0; 1833 estartlen = 0;
1896 } 1834 }
1835
1897 /* Init data to zero */ 1836 /* Init data to zero */
1898 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS); 1837 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1899 1838
1900 /* x,y are the real map locations. ax, ay are viewport relative 1839 /* x,y are the real map locations. ax, ay are viewport relative
1901 * locations. 1840 * locations.
… …
1905 /* We could do this logic as conditionals in the if statement, 1844 /* We could do this logic as conditionals in the if statement,
1906 * but that started to get a bit messy to look at. 1845 * but that started to get a bit messy to look at.
1907 */ 1846 */
1908 max_x = pl->x + (socket.mapx + 1) / 2; 1847 max_x = pl->x + (socket.mapx + 1) / 2;
1909 max_y = pl->y + (socket.mapy + 1) / 2; 1848 max_y = pl->y + (socket.mapy + 1) / 2;
1849
1910 if (socket.mapmode == Map1aCmd) 1850 if (socket.mapmode == Map1aCmd)
1911 { 1851 {
1912 max_x += MAX_HEAD_OFFSET; 1852 max_x += MAX_HEAD_OFFSET;
1913 max_y += MAX_HEAD_OFFSET; 1853 max_y += MAX_HEAD_OFFSET;
1914 } 1854 }
… …
1929 */ 1869 */
1930 if (ax >= socket.mapx || ay >= socket.mapy) 1870 if (ax >= socket.mapx || ay >= socket.mapy)
1931 { 1871 {
1932 int i, got_one; 1872 int i, got_one;
1933 1873
1934 oldlen = sl.len; 1874 oldlen = sl.length ();
1935 1875
1936 SockList_AddShort (&sl, mask); 1876 sl << uint16 (mask);
1937 1877
1938 if (check_head (sl, socket, ax, ay, 2)) 1878 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1939 mask |= 0x4;
1940 if (check_head (sl, socket, ax, ay, 1)) 1879 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1941 mask |= 0x2;
1942 if (check_head (sl, socket, ax, ay, 0)) 1880 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1943 mask |= 0x1;
1944 1881
1945 /* If all we are doing is sending 0 (blank) faces, we don't 1882 /* If all we are doing is sending 0 (blank) faces, we don't
1946 * actually need to send that - just the coordinates 1883 * actually need to send that - just the coordinates
1947 * with no faces tells the client to blank out the 1884 * with no faces tells the client to blank out the
1948 * space. 1885 * space.
1949 */ 1886 */
1950 got_one = 0; 1887 got_one = 0;
1951 for (i = oldlen + 2; i < sl.len; i++) 1888 for (i = oldlen + 2; i < sl.length (); i++)
1952 {
1953 if (sl.buf[i]) 1889 if (sl[i])
1954 got_one = 1; 1890 got_one = 1;
1955 }
1956 1891
1957 if (got_one && (mask & 0xf)) 1892 if (got_one && (mask & 0xf))
1958 {
1959 sl.buf[oldlen + 1] = mask & 0xff; 1893 sl[oldlen + 1] = mask & 0xff;
1960 }
1961 else 1894 else
1962 { /*either all faces blank, either no face at all */ 1895 { /*either all faces blank, either no face at all */
1963 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */ 1896 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1964 sl.len = oldlen + 2; 1897 sl.reset (oldlen + 2);
1965 else 1898 else
1966 sl.len = oldlen; 1899 sl.reset (oldlen);
1967 } 1900 }
1901
1968 /*What concerns extendinfos, nothing to be done for now 1902 /*What concerns extendinfos, nothing to be done for now
1969 * (perhaps effects layer later) 1903 * (perhaps effects layer later)
1970 */ 1904 */
1971 continue; /* don't do processing below */ 1905 continue; /* don't do processing below */
1972 } 1906 }
1973 1907
1974 MapCell & lastcell = socket.lastmap.cells[ax][ay]; 1908 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1975 1909
1976 d = pl->contr->blocked_los[ax][ay]; 1910 d = pl->contr->blocked_los[ax][ay];
1977 1911
1978 /* If the coordinates are not valid, or it is too dark to see, 1912 /* If the coordinates are not valid, or it is too dark to see,
1979 * we tell the client as such 1913 * we tell the client as such
1980 */ 1914 */
1981 nx = x; 1915 nx = x;
1982 ny = y; 1916 ny = y;
1983 m = get_map_from_coord (pl->map, &nx, &ny); 1917 m = get_map_from_coord (pl->map, &nx, &ny);
1918
1984 if (!m) 1919 if (!m)
1985 { 1920 {
1986 /* space is out of map. Update space and clear values 1921 /* space is out of map. Update space and clear values
1987 * if this hasn't already been done. If the space is out 1922 * if this hasn't already been done. If the space is out
1988 * of the map, it shouldn't have a head 1923 * of the map, it shouldn't have a head
1989 */ 1924 */
1990 if (lastcell.count != -1) 1925 if (lastcell.count != -1)
1991 { 1926 {
1992 SockList_AddShort (&sl, mask); 1927 sl << uint16 (mask);
1993 map_clearcell (&lastcell, 0, 0, 0, -1); 1928 map_clearcell (&lastcell, 0, 0, 0, -1);
1994 } 1929 }
1995 } 1930 }
1996 else if (d > 3) 1931 else if (d > 3)
1997 { 1932 {
… …
1999 1934
2000 /* This block deals with spaces that are not visible for whatever 1935 /* This block deals with spaces that are not visible for whatever
2001 * reason. Still may need to send the head for this space. 1936 * reason. Still may need to send the head for this space.
2002 */ 1937 */
2003 1938
2004 oldlen = sl.len; 1939 oldlen = sl.length ();
2005 1940
2006 SockList_AddShort (&sl, mask); 1941 sl << uint16 (mask);
1942
2007 if (lastcell.count != -1) 1943 if (lastcell.count != -1)
2008 need_send = 1; 1944 need_send = 1;
1945
2009 count = -1; 1946 count = -1;
2010 1947
2011 if (socket.mapmode == Map1aCmd && have_head (ax, ay)) 1948 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
2012 { 1949 {
2013 /* Now check to see if any heads need to be sent */ 1950 /* Now check to see if any heads need to be sent */
2014 1951
2015 if (check_head (sl, socket, ax, ay, 2)) 1952 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
2016 mask |= 0x4;
2017 if (check_head (sl, socket, ax, ay, 1)) 1953 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
2018 mask |= 0x2;
2019 if (check_head (sl, socket, ax, ay, 0)) 1954 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
2020 mask |= 0x1;
2021 1955
2022 lastcell.count = count; 1956 lastcell.count = count;
2023
2024 } 1957 }
2025 else 1958 else
2026 { 1959 {
2027 struct MapCell *cell = &lastcell;
2028
2029 /* properly clear a previously sent big face */ 1960 /* properly clear a previously sent big face */
2030 if (cell->faces[0] != 0 || cell->faces[1] != 0 || cell->faces[2] != 0) 1961 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0
1962 || lastcell.stat_hp || lastcell.flags || lastcell.player)
2031 need_send = 1; 1963 need_send = 1;
1964
2032 map_clearcell (&lastcell, 0, 0, 0, count); 1965 map_clearcell (&lastcell, 0, 0, 0, count);
2033 } 1966 }
2034 1967
2035 if ((mask & 0xf) || need_send) 1968 if ((mask & 0xf) || need_send)
2036 {
2037 sl.buf[oldlen + 1] = mask & 0xff; 1969 sl[oldlen + 1] = mask & 0xff;
2038 }
2039 else 1970 else
2040 {
2041 sl.len = oldlen; 1971 sl.reset (oldlen);
2042 }
2043 } 1972 }
2044 else 1973 else
2045 { 1974 {
2046 /* In this block, the space is visible or there are head objects 1975 /* In this block, the space is visible or there are head objects
2047 * we need to send. 1976 * we need to send.
… …
2049 1978
2050 /* Rather than try to figure out what everything that we might 1979 /* Rather than try to figure out what everything that we might
2051 * need to send is, then form the packet after that, 1980 * need to send is, then form the packet after that,
2052 * we presume that we will in fact form a packet, and update 1981 * we presume that we will in fact form a packet, and update
2053 * the bits by what we do actually send. If we send nothing, 1982 * the bits by what we do actually send. If we send nothing,
2054 * we just back out sl.len to the old value, and no harm 1983 * we just back out sl.length () to the old value, and no harm
2055 * is done. 1984 * is done.
2056 * I think this is simpler than doing a bunch of checks to see 1985 * I think this is simpler than doing a bunch of checks to see
2057 * what if anything we need to send, setting the bits, then 1986 * what if anything we need to send, setting the bits, then
2058 * doing those checks again to add the real data. 1987 * doing those checks again to add the real data.
2059 */ 1988 */
2060 oldlen = sl.len; 1989 oldlen = sl.length ();
2061 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1990 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2062 eoldlen = esl.len; 1991 eoldlen = esl.length ();
2063 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1992 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2064 SockList_AddShort (&sl, mask); 1993 sl << uint16 (mask);
2065 1994
2066 if (socket.ext_mapinfos) 1995 if (socket.ext_mapinfos)
2067 SockList_AddShort (&esl, emask); 1996 esl << uint16 (emask);
2068 1997
2069 unsigned char dummy; 1998 unsigned char dummy;
2070 unsigned char *last_ext = &dummy; 1999 unsigned char *last_ext = &dummy;
2071 2000
2072 /* Darkness changed */ 2001 /* Darkness changed */
… …
2075 mask |= 0x8; 2004 mask |= 0x8;
2076 2005
2077 if (socket.extmap) 2006 if (socket.extmap)
2078 { 2007 {
2079 *last_ext |= 0x80; 2008 *last_ext |= 0x80;
2080 last_ext = sl.buf + sl.len; 2009 last_ext = &sl[sl.length ()];
2081 SockList_AddChar (&sl, d); 2010 sl << uint8 (d);
2082 } 2011 }
2083 else 2012 else
2084 SockList_AddChar (&sl, 255 - 64 * d); 2013 sl << uint8 (255 - 64 * d);
2085 } 2014 }
2086 2015
2087 lastcell.count = d; 2016 lastcell.count = d;
2088 2017
2089 if (socket.extmap) 2018 if (socket.extmap)
2090 { 2019 {
2091 uint8 stat_hp = 0; 2020 uint8 stat_hp = 0;
2092 uint8 stat_width = 0; 2021 uint8 stat_width = 0;
2093 uint8 flags = 0; 2022 uint8 flags = 0;
2094 tag_t player = 0; 2023 UUID player = 0;
2095 2024
2096 // send hp information, if applicable 2025 // send hp information, if applicable
2097 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 2026 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0))
2098 { 2027 {
2099 if (op->head || op->invisible) 2028 if (op->head || op->invisible)
… …
2119 { 2048 {
2120 lastcell.stat_hp = stat_hp; 2049 lastcell.stat_hp = stat_hp;
2121 2050
2122 mask |= 0x8; 2051 mask |= 0x8;
2123 *last_ext |= 0x80; 2052 *last_ext |= 0x80;
2124 last_ext = sl.buf + sl.len; 2053 last_ext = &sl[sl.length ()];
2125 SockList_AddChar (&sl, 5); 2054
2126 SockList_AddChar (&sl, stat_hp); 2055 sl << uint8 (5) << uint8 (stat_hp);
2127 2056
2128 if (stat_width > 1) 2057 if (stat_width > 1)
2129 { 2058 {
2130 *last_ext |= 0x80; 2059 *last_ext |= 0x80;
2131 last_ext = sl.buf + sl.len; 2060 last_ext = &sl[sl.length ()];
2132 SockList_AddChar (&sl, 6); 2061
2133 SockList_AddChar (&sl, stat_width); 2062 sl << uint8 (6) << uint8 (stat_width);
2134 } 2063 }
2135 } 2064 }
2136 2065
2137 if (lastcell.player != player) 2066 if (lastcell.player != player)
2138 { 2067 {
2139 lastcell.player = player; 2068 lastcell.player = player;
2140 2069
2141 mask |= 0x8; 2070 mask |= 0x8;
2142 *last_ext |= 0x80; 2071 *last_ext |= 0x80;
2143 last_ext = sl.buf + sl.len; 2072 last_ext = &sl[sl.length ()];
2144 SockList_AddChar (&sl, 0x47); 2073
2145 SockList_AddChar (&sl, 4); 2074 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2146 SockList_AddInt (&sl, player);
2147 } 2075 }
2148 2076
2149 if (lastcell.flags != flags) 2077 if (lastcell.flags != flags)
2150 { 2078 {
2151 lastcell.flags = flags; 2079 lastcell.flags = flags;
2152 2080
2153 mask |= 0x8; 2081 mask |= 0x8;
2154 *last_ext |= 0x80; 2082 *last_ext |= 0x80;
2155 last_ext = sl.buf + sl.len; 2083 last_ext = &sl[sl.length ()];
2156 SockList_AddChar (&sl, 8); 2084
2157 SockList_AddChar (&sl, flags); 2085 sl << uint8 (8) << uint8 (flags);
2158 } 2086 }
2159 } 2087 }
2160 2088
2161 /* Floor face */ 2089 /* Floor face */
2162 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 2)) 2090 if (update_space (sl, socket, m, nx, ny, ax, ay, 2))
2163 mask |= 0x4; 2091 mask |= 0x4;
2164 2092
2165 if (socket.EMI_smooth) 2093 if (socket.EMI_smooth)
2166 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 2)) 2094 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2167 emask |= 0x4; 2095 emask |= 0x4;
2168 2096
2169 /* Middle face */ 2097 /* Middle face */
2170 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 1)) 2098 if (update_space (sl, socket, m, nx, ny, ax, ay, 1))
2171 mask |= 0x2; 2099 mask |= 0x2;
2172 2100
2173 if (socket.EMI_smooth) 2101 if (socket.EMI_smooth)
2174 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 1)) 2102 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1))
2175 emask |= 0x2; 2103 emask |= 0x2;
2176 2104
2177 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1)) 2105 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2178 { 2106 {
2179 if (lastcell.faces[0] != pl->face->number) 2107 if (lastcell.faces[0] != pl->face->number)
2180 { 2108 {
2181 lastcell.faces[0] = pl->face->number; 2109 lastcell.faces[0] = pl->face->number;
2182 mask |= 0x1; 2110 mask |= 0x1;
2111
2183 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE)) 2112 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2184 esrv_send_face (&socket, pl->face->number, 0); 2113 esrv_send_face (&socket, pl->face->number, 0);
2185 SockList_AddShort (&sl, pl->face->number); 2114
2115 sl << uint16 (pl->face->number);
2186 } 2116 }
2187 } 2117 }
2188 /* Top face */
2189 else 2118 else
2190 { 2119 {
2120 /* Top face */
2191 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 0)) 2121 if (update_space (sl, socket, m, nx, ny, ax, ay, 0))
2192 mask |= 0x1; 2122 mask |= 0x1;
2123
2193 if (socket.EMI_smooth) 2124 if (socket.EMI_smooth)
2194 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 0)) 2125 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2195 {
2196 emask |= 0x1; 2126 emask |= 0x1;
2197 }
2198 } 2127 }
2128
2199 /* Check to see if we are in fact sending anything for this 2129 /* Check to see if we are in fact sending anything for this
2200 * space by checking the mask. If so, update the mask. 2130 * space by checking the mask. If so, update the mask.
2201 * if not, reset the len to that from before adding the mask 2131 * if not, reset the len to that from before adding the mask
2202 * value, so we don't send those bits. 2132 * value, so we don't send those bits.
2203 */ 2133 */
2204 if (mask & 0xf) 2134 if (mask & 0xf)
2205 {
2206 sl.buf[oldlen + 1] = mask & 0xff; 2135 sl[oldlen + 1] = mask & 0xff;
2207 }
2208 else 2136 else
2209 {
2210 sl.len = oldlen; 2137 sl.reset (oldlen);
2211 } 2138
2212 if (emask & 0xf) 2139 if (emask & 0xf)
2213 {
2214 esl.buf[eoldlen + 1] = emask & 0xff; 2140 esl[eoldlen + 1] = emask & 0xff;
2215 }
2216 else 2141 else
2217 {
2218 esl.len = eoldlen; 2142 esl.reset (eoldlen);
2219 }
2220 } /* else this is a viewable space */ 2143 } /* else this is a viewable space */
2221 } /* for x loop */ 2144 } /* for x loop */
2222 } /* for y loop */ 2145 } /* for y loop */
2223 2146
2224 /* Verify that we in fact do need to send this */ 2147 /* Verify that we in fact do need to send this */
2225 if (socket.ext_mapinfos) 2148 if (socket.ext_mapinfos)
2226 { 2149 {
2227 if (!(sl.len > startlen || socket.sent_scroll)) 2150 if (!(sl.length () > startlen || socket.sent_scroll))
2228 { 2151 {
2229 /* No map data will follow, so don't say the client 2152 /* No map data will follow, so don't say the client
2230 * it doesn't need draw! 2153 * it doesn't need draw!
2231 */ 2154 */
2232 ewhatflag &= (~EMI_NOREDRAW); 2155 ewhatflag &= (~EMI_NOREDRAW);
2233 esl.buf[ewhatstart + 1] = ewhatflag & 0xff; 2156 esl[ewhatstart + 1] = ewhatflag & 0xff;
2234 } 2157 }
2235 2158
2236 if (esl.len > estartlen) 2159 if (esl.length () > estartlen)
2237 Send_With_Handling (&socket, &esl); 2160 socket.send_packet (esl);
2238
2239 free (esl.buf);
2240 } 2161 }
2241 2162
2242 if (sl.len > startlen || socket.sent_scroll) 2163 if (sl.length () > startlen || socket.sent_scroll)
2243 { 2164 {
2244 Send_With_Handling (&socket, &sl); 2165 socket.send_packet (sl);
2245 socket.sent_scroll = 0; 2166 socket.sent_scroll = 0;
2246 } 2167 }
2247
2248 free (sl.buf);
2249} 2168}
2250 2169
2251/** 2170/**
2252 * Draws client map. 2171 * Draws client map.
2253 */ 2172 */
… …
2277 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 2196 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2278 return; 2197 return;
2279 2198
2280 memset (&newmap, 0, sizeof (struct Map)); 2199 memset (&newmap, 0, sizeof (struct Map));
2281 2200
2282 for (j = (pl->y - pl->contr->socket.mapy / 2); j < (pl->y + (pl->contr->socket.mapy + 1) / 2); j++) 2201 for (j = (pl->y - pl->contr->socket->mapy / 2); j < (pl->y + (pl->contr->socket->mapy + 1) / 2); j++)
2283 { 2202 {
2284 for (i = (pl->x - pl->contr->socket.mapx / 2); i < (pl->x + (pl->contr->socket.mapx + 1) / 2); i++) 2203 for (i = (pl->x - pl->contr->socket->mapx / 2); i < (pl->x + (pl->contr->socket->mapx + 1) / 2); i++)
2285 { 2204 {
2286 ax = i; 2205 ax = i;
2287 ay = j; 2206 ay = j;
2288 m = pm; 2207 m = pm;
2289 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay); 2208 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
… …
2304 { 2223 {
2305 update_los (pl); 2224 update_los (pl);
2306 pl->contr->do_los = 0; 2225 pl->contr->do_los = 0;
2307 } 2226 }
2308 2227
2309 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd)
2310 {
2311 /* Big maps need a different drawing mechanism to work */ 2228 /* Big maps need a different drawing mechanism to work */
2312 draw_client_map1 (pl); 2229 draw_client_map1 (pl);
2313 return;
2314 }
2315
2316 if (pl->invisible & (pl->invisible < 50 ? 4 : 1))
2317 {
2318 esrv_map_setbelow (&pl->contr->socket, pl->contr->socket.mapx / 2, pl->contr->socket.mapy / 2, pl->face->number, &newmap);
2319 }
2320
2321 /* j and i are the y and x coordinates of the real map (which is
2322 * basically some number of spaces around the player)
2323 * ax and ay are values from within the viewport (ie, 0, 0 is upper
2324 * left corner) and are thus disconnected from the map values.
2325 * Subtract 1 from the max values so that we properly handle cases where
2326 * player has specified an even map. Otherwise, we try to send them too
2327 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually
2328 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is
2329 * odd, this still works fine.
2330 */
2331 ay = 0;
2332 for (j = pl->y - pl->contr->socket.mapy / 2; j <= pl->y + (pl->contr->socket.mapy - 1) / 2; j++, ay++)
2333 {
2334 ax = 0;
2335 for (i = pl->x - pl->contr->socket.mapx / 2; i <= pl->x + (pl->contr->socket.mapx - 1) / 2; i++, ax++)
2336 {
2337
2338 d = pl->contr->blocked_los[ax][ay];
2339 /* note the out_of_map and d>3 checks are both within the same
2340 * negation check.
2341 */
2342 nx = i;
2343 ny = j;
2344 m = get_map_from_coord (pm, &nx, &ny);
2345 if (m && d < 4)
2346 {
2347 face = GET_MAP_FACE (m, nx, ny, 0);
2348 floor2 = GET_MAP_FACE (m, nx, ny, 1);
2349 floor = GET_MAP_FACE (m, nx, ny, 2);
2350
2351 /* If all is blank, send a blank face. */
2352 if ((!face || face == blank_face) && (!floor2 || floor2 == blank_face) && (!floor || floor == blank_face))
2353 {
2354 esrv_map_setbelow (&pl->contr->socket, ax, ay, blank_face->number, &newmap);
2355 }
2356 else
2357 { /* actually have something interesting */
2358 /* send the darkness mask, if any. */
2359 if (d && pl->contr->socket.darkness)
2360 esrv_map_setbelow (&pl->contr->socket, ax, ay, dark_faces[d - 1]->number, &newmap);
2361
2362 if (face && face != blank_face)
2363 esrv_map_setbelow (&pl->contr->socket, ax, ay, face->number, &newmap);
2364 if (floor2 && floor2 != blank_face)
2365 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor2->number, &newmap);
2366 if (floor && floor != blank_face)
2367 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2368 }
2369 } /* Is a valid space */
2370 }
2371 }
2372 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2373
2374 check_map_change (pl->contr);
2375} 2230}
2376 2231
2377 2232
2378/*****************************************************************************/ 2233/*****************************************************************************/
2379 2234
… …
2385 2240
2386/*****************************************************************************/ 2241/*****************************************************************************/
2387void 2242void
2388send_plugin_custom_message (object *pl, char *buf) 2243send_plugin_custom_message (object *pl, char *buf)
2389{ 2244{
2390 cs_write_string (&pl->contr->socket, buf, strlen (buf)); 2245 pl->contr->socket->send_packet (buf);
2391} 2246}
2392 2247
2393/** 2248/**
2394 * This sends the skill number to name mapping. We ignore 2249 * This sends the skill number to name mapping. We ignore
2395 * the params - we always send the same info no matter what. 2250 * the params - we always send the same info no matter what.
2396 */ 2251 */
2397void 2252void
2398send_skill_info (NewSocket * ns, char *params) 2253send_skill_info (client *ns, char *params)
2399{ 2254{
2400 SockList sl; 2255 packet sl;
2401 int i; 2256 sl << "replyinfo skill_info\n";
2402 2257
2403 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
2404 strcpy ((char *) sl.buf, "replyinfo skill_info\n");
2405 for (i = 1; i < NUM_SKILLS; i++) 2258 for (int i = 1; i < NUM_SKILLS; i++)
2406 { 2259 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2407 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 2260
2408 }
2409 sl.len = strlen ((char *) sl.buf);
2410 if (sl.len >= MAXSOCKBUF) 2261 if (sl.length () >= MAXSOCKBUF)
2411 { 2262 {
2412 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 2263 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2413 fatal (0); 2264 fatal (0);
2414 } 2265 }
2415 Send_With_Handling (ns, &sl); 2266
2416 free (sl.buf); 2267 ns->send_packet (sl);
2417} 2268}
2418 2269
2419/** 2270/**
2420 * This sends the spell path to name mapping. We ignore 2271 * This sends the spell path to name mapping. We ignore
2421 * the params - we always send the same info no matter what. 2272 * the params - we always send the same info no matter what.
2422 */ 2273 */
2423void 2274void
2424send_spell_paths (NewSocket * ns, char *params) 2275send_spell_paths (client * ns, char *params)
2425{ 2276{
2426 SockList sl; 2277 packet sl;
2427 int i;
2428 2278
2429 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2279 sl << "replyinfo spell_paths\n";
2430 strcpy ((char *) sl.buf, "replyinfo spell_paths\n"); 2280
2431 for (i = 0; i < NRSPELLPATHS; i++) 2281 for (int i = 0; i < NRSPELLPATHS; i++)
2432 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", 1 << i, spellpathnames[i]); 2282 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2433 sl.len = strlen ((char *) sl.buf); 2283
2434 if (sl.len >= MAXSOCKBUF) 2284 if (sl.length () >= MAXSOCKBUF)
2435 { 2285 {
2436 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 2286 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2437 fatal (0); 2287 fatal (0);
2438 } 2288 }
2439 Send_With_Handling (ns, &sl); 2289
2440 free (sl.buf); 2290 ns->send_packet (sl);
2441} 2291}
2442 2292
2443/** 2293/**
2444 * This looks for any spells the player may have that have changed their stats. 2294 * This looks for any spells the player may have that have changed their stats.
2445 * it then sends an updspell packet for each spell that has changed in this way 2295 * it then sends an updspell packet for each spell that has changed in this way
2446 */ 2296 */
2447void 2297void
2448esrv_update_spells (player *pl) 2298esrv_update_spells (player *pl)
2449{ 2299{
2450 SockList sl;
2451 int flags = 0;
2452 object *spell;
2453
2454 if (!pl->socket.monitor_spells) 2300 if (!pl->socket->monitor_spells)
2455 return; 2301 return;
2302
2456 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2303 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2457 { 2304 {
2458 if (spell->type == SPELL) 2305 if (spell->type == SPELL)
2459 { 2306 {
2307 int flags = 0;
2308
2460 /* check if we need to update it */ 2309 /* check if we need to update it */
2461 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 2310 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
2462 { 2311 {
2463 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2312 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2464 flags |= UPD_SP_MANA; 2313 flags |= UPD_SP_MANA;
2465 } 2314 }
2315
2466 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 2316 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
2467 { 2317 {
2468 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2318 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2469 flags |= UPD_SP_GRACE; 2319 flags |= UPD_SP_GRACE;
2470 } 2320 }
2321
2471 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 2322 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
2472 { 2323 {
2473 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2324 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2474 flags |= UPD_SP_DAMAGE; 2325 flags |= UPD_SP_DAMAGE;
2475 } 2326 }
2327
2476 if (flags != 0) 2328 if (flags)
2477 { 2329 {
2478 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2330 packet sl;
2479 strcpy ((char *) sl.buf, "updspell "); 2331
2480 sl.len = strlen ((char *) sl.buf); 2332 sl << "updspell "
2481 SockList_AddChar (&sl, flags); 2333 << uint8 (flags)
2482 SockList_AddInt (&sl, spell->count); 2334 << uint32 (spell->count);
2483 if (flags & UPD_SP_MANA) 2335
2484 SockList_AddShort (&sl, spell->last_sp); 2336 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2485 if (flags & UPD_SP_GRACE) 2337 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2486 SockList_AddShort (&sl, spell->last_grace); 2338 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2487 if (flags & UPD_SP_DAMAGE) 2339
2488 SockList_AddShort (&sl, spell->last_eat); 2340 pl->socket->send_packet (sl);
2489 flags = 0;
2490 Send_With_Handling (&pl->socket, &sl);
2491 free (sl.buf);
2492 } 2341 }
2493 } 2342 }
2494 } 2343 }
2495} 2344}
2496 2345
2497void 2346void
2498esrv_remove_spell (player *pl, object *spell) 2347esrv_remove_spell (player *pl, object *spell)
2499{ 2348{
2500 SockList sl;
2501
2502 if (!pl->socket.monitor_spells) 2349 if (!pl->socket->monitor_spells)
2503 return; 2350 return;
2351
2504 if (!pl || !spell || spell->env != pl->ob) 2352 if (!pl || !spell || spell->env != pl->ob)
2505 { 2353 {
2506 LOG (llevError, "Invalid call to esrv_remove_spell"); 2354 LOG (llevError, "Invalid call to esrv_remove_spell");
2507 return; 2355 return;
2508 } 2356 }
2509 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2357
2510 strcpy ((char *) sl.buf, "delspell "); 2358 packet sl;
2511 sl.len = strlen ((char *) sl.buf); 2359
2512 SockList_AddInt (&sl, spell->count); 2360 sl << "delspell "
2513 Send_With_Handling (&pl->socket, &sl); 2361 << uint32 (spell->count);
2514 free (sl.buf); 2362
2363 pl->socket->send_packet (sl);
2515} 2364}
2516 2365
2517/* appends the spell *spell to the Socklist we will send the data to. */ 2366/* appends the spell *spell to the Socklist we will send the data to. */
2518static void 2367static void
2519append_spell (player *pl, SockList * sl, object *spell) 2368append_spell (player *pl, packet &sl, object *spell)
2520{ 2369{
2521 int len, i, skill = 0; 2370 int len, i, skill = 0;
2522 2371
2523 if (!(spell->name)) 2372 if (!(spell->name))
2524 { 2373 {
2525 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 2374 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2526 return; 2375 return;
2527 } 2376 }
2528 SockList_AddInt (sl, spell->count); 2377
2529 SockList_AddShort (sl, spell->level);
2530 SockList_AddShort (sl, spell->casting_time);
2531 /* store costs and damage in the object struct, to compare to later */ 2378 /* store costs and damage in the object struct, to compare to later */
2532 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2379 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2533 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2380 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2534 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2381 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2535 /* send the current values */
2536 SockList_AddShort (sl, spell->last_sp);
2537 SockList_AddShort (sl, spell->last_grace);
2538 SockList_AddShort (sl, spell->last_eat);
2539 2382
2540 /* figure out which skill it uses, if it uses one */ 2383 /* figure out which skill it uses, if it uses one */
2541 if (spell->skill) 2384 if (spell->skill)
2542 { 2385 {
2543 for (i = 1; i < NUM_SKILLS; i++) 2386 for (i = 1; i < NUM_SKILLS; i++)
… …
2545 { 2388 {
2546 skill = i + CS_STAT_SKILLINFO; 2389 skill = i + CS_STAT_SKILLINFO;
2547 break; 2390 break;
2548 } 2391 }
2549 } 2392 }
2550 SockList_AddChar (sl, skill);
2551 2393
2552 SockList_AddInt (sl, spell->path_attuned); 2394 /* send the current values */
2395 sl << uint32 (spell->count)
2396 << uint16 (spell->level)
2397 << uint16 (spell->casting_time)
2398 << uint16 (spell->last_sp)
2399 << uint16 (spell->last_grace)
2400 << uint16 (spell->last_eat)
2401 << uint8 (skill)
2402 << uint32 (spell->path_attuned)
2553 SockList_AddInt (sl, (spell->face) ? spell->face->number : 0); 2403 << uint32 (spell->face ? spell->face->number : 0)
2554 2404 << data8 (spell->name)
2555 len = strlen (spell->name); 2405 << data16 (spell->msg);
2556 SockList_AddChar (sl, (char) len);
2557 memcpy (sl->buf + sl->len, spell->name, len);
2558 sl->len += len;
2559
2560 if (!spell->msg)
2561 {
2562 SockList_AddShort (sl, 0);
2563 }
2564 else
2565 {
2566 len = strlen (spell->msg);
2567 SockList_AddShort (sl, len);
2568 memcpy (sl->buf + sl->len, spell->msg, len);
2569 sl->len += len;
2570 }
2571} 2406}
2572 2407
2573/** 2408/**
2574 * This tells the client to add the spell *ob, if *ob is NULL, then add 2409 * This tells the client to add the spell *ob, if *ob is NULL, then add
2575 * all spells in the player's inventory. 2410 * all spells in the player's inventory.
2576 */ 2411 */
2577void 2412void
2578esrv_add_spells (player *pl, object *spell) 2413esrv_add_spells (player *pl, object *spell)
2579{ 2414{
2580 SockList sl;
2581
2582 if (!pl) 2415 if (!pl)
2583 { 2416 {
2584 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 2417 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2585 return; 2418 return;
2586 } 2419 }
2420
2587 if (!pl->socket.monitor_spells) 2421 if (!pl->socket->monitor_spells)
2588 return; 2422 return;
2589 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2423
2590 strcpy ((char *) sl.buf, "addspell "); 2424 packet sl;
2591 sl.len = strlen ((char *) sl.buf); 2425
2426 sl << "addspell ";
2427
2592 if (!spell) 2428 if (!spell)
2593 { 2429 {
2594 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2430 for (spell = pl->ob->inv; spell != NULL; spell = spell->below)
2595 { 2431 {
2596 /* were we to simply keep appending data here, we could exceed 2432 /* were we to simply keep appending data here, we could exceed
… …
2606 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 2442 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2607 * like it will fix this 2443 * like it will fix this
2608 */ 2444 */
2609 if (spell->type != SPELL) 2445 if (spell->type != SPELL)
2610 continue; 2446 continue;
2447
2611 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 2448 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2612 { 2449 {
2613 Send_With_Handling (&pl->socket, &sl); 2450 pl->socket->send_packet (sl);
2614 strcpy ((char *) sl.buf, "addspell "); 2451
2615 sl.len = strlen ((char *) sl.buf); 2452 sl.reset ();
2453 sl << "addspell ";
2616 } 2454 }
2455
2617 append_spell (pl, &sl, spell); 2456 append_spell (pl, sl, spell);
2618 } 2457 }
2619 } 2458 }
2620 else if (spell->type != SPELL) 2459 else if (spell->type != SPELL)
2621 { 2460 {
2622 LOG (llevError, "Asked to send a non-spell object as a spell"); 2461 LOG (llevError, "Asked to send a non-spell object as a spell");
2623 return; 2462 return;
2624 } 2463 }
2625 else 2464 else
2626 append_spell (pl, &sl, spell); 2465 append_spell (pl, sl, spell);
2466
2627 if (sl.len >= MAXSOCKBUF) 2467 if (sl.length () >= MAXSOCKBUF)
2628 { 2468 {
2629 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 2469 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2630 fatal (0); 2470 fatal (0);
2631 } 2471 }
2472
2632 /* finally, we can send the packet */ 2473 /* finally, we can send the packet */
2633 Send_With_Handling (&pl->socket, &sl); 2474 pl->socket->send_packet (sl);
2634 free (sl.buf);
2635} 2475}
2476

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines