ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.42 by root, Sat Dec 16 03:08:26 2006 UTC vs.
Revision 1.76 by root, Wed Mar 14 13:05:30 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (C) 2001 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 23 */
23 24
24/** 25/**
25 * \file 26 * \file
26 * Client handling. 27 * Client handling.
27 * 28 *
… …
35 * have the prototype of (char *data, int datalen, int client_num). This 36 * have the prototype of (char *data, int datalen, int client_num). This
36 * way, we can use one dispatch table. 37 * way, we can use one dispatch table.
37 * 38 *
38 * esrv_map_new starts updating the map 39 * esrv_map_new starts updating the map
39 * 40 *
40 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now.
42 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations
45 *
46 */ 41 */
47 42
48#include <global.h> 43#include <global.h>
49#include <sproto.h> 44#include <sproto.h>
50 45
… …
86 -1, /* life stealing */ 81 -1, /* life stealing */
87 -1 /* Disease - not fully done yet */ 82 -1 /* Disease - not fully done yet */
88}; 83};
89 84
90static void 85static void
91socket_map_scroll (client * ns, int dx, int dy) 86socket_map_scroll (client *ns, int dx, int dy)
92{ 87{
93 struct Map newmap; 88 struct Map newmap;
94 int x, y, mx, my; 89 int x, y, mx, my;
95 90
96 ns->send_packet_printf ("map_scroll %d %d", dx, dy); 91 ns->send_packet_printf ("map_scroll %d %d", dx, dy);
… …
103 * that much difference in bandwidth. 98 * that much difference in bandwidth.
104 */ 99 */
105 mx = ns->mapx; 100 mx = ns->mapx;
106 my = ns->mapy; 101 my = ns->mapy;
107 102
108 if (ns->mapmode == Map1aCmd)
109 {
110 mx += MAX_HEAD_OFFSET;
111 my += MAX_HEAD_OFFSET;
112 }
113
114 /* the x and y here are coordinates for the new map, i.e. if we moved 103 /* the x and y here are coordinates for the new map, i.e. if we moved
115 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 104 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
116 * if the destination x or y coordinate is outside the viewable 105 * if the destination x or y coordinate is outside the viewable
117 * area, we clear the values - otherwise, the old values 106 * area, we clear the values - otherwise, the old values
118 * are preserved, and the check_head thinks it needs to clear them. 107 * are preserved, and the check_head thinks it needs to clear them.
… …
141} 130}
142 131
143static void 132static void
144clear_map (player *pl) 133clear_map (player *pl)
145{ 134{
146 client &socket = *pl->socket;
147
148 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
149 136
150 if (socket.newmapcmd == 1) 137 if (pl->ns->newmapcmd == 1)
151 socket.send_packet ("newmap"); 138 pl->ns->send_packet ("newmap");
152 139
153 socket.update_look = 1; 140 pl->ns->floorbox_reset ();
154 socket.look_position = 0;
155} 141}
156 142
157/** check for map change and send new map data */ 143/** check for map/region change and send new map data */
158static void 144static void
159check_map_change (player *pl) 145check_map_change (player *pl)
160{ 146{
161 client &socket = *pl->socket; 147 client &socket = *pl->ns;
162 object *ob = pl->ob; 148 object *ob = pl->ob;
163 char buf[MAX_BUF]; /* eauugggh */ 149 char buf[MAX_BUF]; /* eauugggh */
164 150
165 if (socket.current_map != ob->map) 151 if (socket.current_map != ob->map)
166 { 152 {
… …
182 flags |= 4; 168 flags |= 4;
183 if (ob->map->tile_path[3]) 169 if (ob->map->tile_path[3])
184 flags |= 8; 170 flags |= 8;
185 171
186 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s", 172 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s",
187 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 173 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, &ob->map->path);
188 } 174 }
189 else 175 else
190 snprintf (buf, MAX_BUF, "mapinfo current"); 176 snprintf (buf, MAX_BUF, "mapinfo current");
191 177
192 socket.send_packet (buf); 178 socket.send_packet (buf);
… …
200 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8)) 186 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
201 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows 187 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
202 else 188 else
203 { 189 {
204 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 190 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
205 socket.update_look = 1; 191 socket.floorbox_reset ();
206 socket.look_position = 0;
207 } 192 }
208 } 193 }
209 194
210 socket.current_x = ob->x; 195 socket.current_x = ob->x;
211 socket.current_y = ob->y; 196 socket.current_y = ob->y;
197
198 region *reg = ob->region ();
199 if (socket.current_region != reg)
200 {
201 socket.current_region = reg;
202 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
203 }
212} 204}
213 205
214/** 206/**
215 * RequestInfo is sort of a meta command. There is some specific 207 * RequestInfo is sort of a meta command. There is some specific
216 * request of information, but we call other functions to provide 208 * request of information, but we call other functions to provide
… …
260{ 252{
261 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len)); 253 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
262} 254}
263 255
264void 256void
257ExtiCmd (char *buf, int len, client *ns)
258{
259 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
260}
261
262void
265MapInfoCmd (char *buf, int len, player *pl) 263MapInfoCmd (char *buf, int len, player *pl)
266{ 264{
267 // <mapinfo tag spatial tile-path 265 // <mapinfo tag spatial tile-path
268 // >mapinfo tag spatial flags x y w h hash 266 // >mapinfo tag spatial flags x y w h hash
269 267
… …
281 buf += 8; 279 buf += 8;
282 280
283 // initial map and its origin 281 // initial map and its origin
284 maptile *map = pl->ob->map; 282 maptile *map = pl->ob->map;
285 sint16 dx, dy; 283 sint16 dx, dy;
286 int mapx = pl->socket->mapx / 2 - pl->ob->x; 284 int mapx = pl->ns->mapx / 2 - pl->ob->x;
287 int mapy = pl->socket->mapy / 2 - pl->ob->y; 285 int mapy = pl->ns->mapy / 2 - pl->ob->y;
288 int max_distance = 8; // limit maximum path length to something generous 286 int max_distance = 8; // limit maximum path length to something generous
289 287
290 while (*buf && map && max_distance) 288 while (*buf && map && max_distance)
291 { 289 {
292 int dir = *buf++; 290 int dir = *buf++;
293 291
294 switch (dir) 292 switch (dir)
295 { 293 {
296 case '1': 294 case '1':
297 dx = 0; 295 dx = 0;
298 dy = -1; 296 dy = -1;
299 map = get_map_from_coord (map, &dx, &dy); 297 map = map->xy_find (dx, dy);
300 map && (mapy -= map->height); 298 map && (mapy -= map->height);
301 break; 299 break;
302 case '2': 300 case '2':
303 mapx += map->width; 301 mapx += map->width;
304 dx = map->width; 302 dx = map->width;
305 dy = 0; 303 dy = 0;
306 map = get_map_from_coord (map, &dx, &dy); 304 map = map->xy_find (dx, dy);
307 break; 305 break;
308 case '3': 306 case '3':
309 mapy += map->height; 307 mapy += map->height;
310 dx = 0; 308 dx = 0;
311 dy = map->height; 309 dy = map->height;
312 map = get_map_from_coord (map, &dx, &dy); 310 map = map->xy_find (dx, dy);
313 break; 311 break;
314 case '4': 312 case '4':
315 dx = -1; 313 dx = -1;
316 dy = 0; 314 dy = 0;
317 map = get_map_from_coord (map, &dx, &dy); 315 map = map->xy_find (dx, dy);
318 map && (mapx -= map->width); 316 map && (mapx -= map->width);
319 break; 317 break;
320 } 318 }
321 319
322 --max_distance; 320 --max_distance;
323 } 321 }
324 322
… …
335 if (map->tile_path[2]) 333 if (map->tile_path[2])
336 flags |= 4; 334 flags |= 4;
337 if (map->tile_path[3]) 335 if (map->tile_path[3])
338 flags |= 8; 336 flags |= 8;
339 337
340 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, map->path); 338 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
341 } 339 }
342 else 340 else
343 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 341 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token);
344 } 342 }
345 else 343 else
346 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 344 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
347 345
348 pl->socket->send_packet (bigbuf); 346 pl->ns->send_packet (bigbuf);
349} 347}
350 348
351/** This is the Setup cmd - easy first implementation */ 349/** This is the Setup cmd - easy first implementation */
352void 350void
353SetUp (char *buf, int len, client * ns) 351SetUp (char *buf, int len, client * ns)
… …
400 { 398 {
401 ns->sound = atoi (param); 399 ns->sound = atoi (param);
402 safe_strcat (cmdback, param, &slen, HUGE_BUF); 400 safe_strcat (cmdback, param, &slen, HUGE_BUF);
403 } 401 }
404 else if (!strcmp (cmd, "exp64")) 402 else if (!strcmp (cmd, "exp64"))
405 {
406 ns->exp64 = atoi (param);
407 safe_strcat (cmdback, param, &slen, HUGE_BUF); 403 safe_strcat (cmdback, param, &slen, HUGE_BUF);
408 }
409 else if (!strcmp (cmd, "spellmon")) 404 else if (!strcmp (cmd, "spellmon"))
410 { 405 {
411 ns->monitor_spells = atoi (param); 406 ns->monitor_spells = atoi (param);
412 safe_strcat (cmdback, param, &slen, HUGE_BUF); 407 safe_strcat (cmdback, param, &slen, HUGE_BUF);
413 } 408 }
… …
436 } 431 }
437 else if (!strcmp (cmd, "newmapcmd")) 432 else if (!strcmp (cmd, "newmapcmd"))
438 { 433 {
439 ns->newmapcmd = atoi (param); 434 ns->newmapcmd = atoi (param);
440 safe_strcat (cmdback, param, &slen, HUGE_BUF); 435 safe_strcat (cmdback, param, &slen, HUGE_BUF);
441// } else if (!strcmp(cmd,"plugincmd")) {
442// ns->plugincmd = atoi(param);
443// safe_strcat(cmdback, param, &slen, HUGE_BUF);
444 } 436 }
445 else if (!strcmp (cmd, "mapinfocmd")) 437 else if (!strcmp (cmd, "mapinfocmd"))
446 { 438 {
447 ns->mapinfocmd = atoi (param); 439 ns->mapinfocmd = atoi (param);
448 safe_strcat (cmdback, "1", &slen, HUGE_BUF); 440 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
… …
467 char tmpbuf[20]; 459 char tmpbuf[20];
468 int q = atoi (param); 460 int q = atoi (param);
469 461
470 if (is_valid_faceset (q)) 462 if (is_valid_faceset (q))
471 ns->faceset = q; 463 ns->faceset = q;
464
472 sprintf (tmpbuf, "%d", ns->faceset); 465 sprintf (tmpbuf, "%d", ns->faceset);
473 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF); 466 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
474 /* if the client is using faceset, it knows about image2 command */ 467 /* if the client is using faceset, it knows about image2 command */
475 ns->image2 = 1; 468 ns->image2 = 1;
476 } 469 }
… …
504 if (*cp == 'x' || *cp == 'X') 497 if (*cp == 'x' || *cp == 'X')
505 { 498 {
506 y = atoi (cp + 1); 499 y = atoi (cp + 1);
507 break; 500 break;
508 } 501 }
502
509 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y) 503 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
510 { 504 {
511 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y); 505 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
512 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF); 506 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
513 } 507 }
… …
570 * it either has to be here or init_sockets needs to be exported. 564 * it either has to be here or init_sockets needs to be exported.
571 */ 565 */
572void 566void
573AddMeCmd (char *buf, int len, client * ns) 567AddMeCmd (char *buf, int len, client * ns)
574{ 568{
575 Settings oldsettings; 569 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
576
577 oldsettings = settings;
578 if (ns->status != Ns_Add || add_player (ns))
579 ns->send_packet ("addme_failed");
580 else
581 ns->send_packet ("addme_success");
582
583 settings = oldsettings;
584} 570}
585 571
586/** Reply to ExtendedInfos command */ 572/** Reply to ExtendedInfos command */
587void 573void
588ToggleExtendedInfos (char *buf, int len, client * ns) 574ToggleExtendedInfos (char *buf, int len, client * ns)
… …
698 684
699 ns->send_packet (cmdback); 685 ns->send_packet (cmdback);
700} 686}
701 687
702/** 688/**
703 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
704 * Basically, it makes no sense to wait for the client to request a
705 * a piece of data from us that we know the client wants. So
706 * if we know the client wants it, might as well push it to the
707 * client.
708 */
709static void
710SendSmooth (client * ns, uint16 face)
711{
712 uint16 smoothface;
713
714 /* If we can't find a face, return and set it so we won't try to send this
715 * again.
716 */
717 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
718 {
719
720 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name);
721 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
722 return;
723 }
724
725 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
726 esrv_send_face (ns, smoothface, 0);
727
728 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
729
730 packet sl;
731
732 sl << "smooth "
733 << uint16 (face)
734 << uint16 (smoothface);
735
736 ns->send_packet (sl);
737}
738
739 /**
740 * Tells client the picture it has to use 689 * Tells client the picture it has to use
741 * to smooth a picture number given as argument. 690 * to smooth a picture number given as argument.
742 */ 691 */
743void 692void
744AskSmooth (char *buf, int len, client * ns) 693AskSmooth (char *buf, int len, client *ns)
745{ 694{
746 uint16 facenbr; 695 ns->send_face (atoi (buf));
747
748 facenbr = atoi (buf);
749 SendSmooth (ns, facenbr);
750} 696}
751 697
752/** 698/**
753 * This handles the general commands from the client (ie, north, fire, cast, 699 * This handles the general commands from the client (ie, north, fire, cast,
754 * etc.) 700 * etc.)
755 */ 701 */
756void 702void
757PlayerCmd (char *buf, int len, player *pl) 703PlayerCmd (char *buf, int len, player *pl)
758{ 704{
759
760 /* The following should never happen with a proper or honest client.
761 * Therefore, the error message doesn't have to be too clear - if
762 * someone is playing with a hacked/non working client, this gives them
763 * an idea of the problem, but they deserve what they get
764 */
765 if (pl->state != ST_PLAYING)
766 {
767 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
768 return;
769 }
770 /* Check if there is a count. In theory, a zero count could also be 705 /* Check if there is a count. In theory, a zero count could also be
771 * sent, so check for that also. 706 * sent, so check for that also.
772 */ 707 */
773 if (atoi (buf) || buf[0] == '0') 708 if (atoi (buf) || buf[0] == '0')
774 { 709 {
775 pl->count = atoi ((char *) buf); 710 pl->count = atoi ((char *) buf);
711
776 buf = strchr (buf, ' '); /* advance beyond the numbers */ 712 buf = strchr (buf, ' '); /* advance beyond the numbers */
777 if (!buf) 713 if (!buf)
778 {
779#ifdef ESRV_DEBUG
780 LOG (llevDebug, "PlayerCmd: Got count but no command.\n");
781#endif
782 return; 714 return;
783 } 715
784 buf++; 716 buf++;
785 } 717 }
786 /* This should not happen anymore. */ 718
787 if (pl->ob->speed_left < -1.0)
788 {
789 LOG (llevError, "Player has negative time - shouldn't do command.\n");
790 }
791 /* In c_new.c */
792 execute_newserver_command (pl->ob, (char *) buf); 719 execute_newserver_command (pl->ob, (char *) buf);
793 /* Perhaps something better should be done with a left over count.
794 * Cleaning up the input should probably be done first - all actions
795 * for the command that issued the count should be done before any other
796 * commands.
797 */
798 720
799 pl->count = 0;
800
801}
802
803
804/**
805 * This handles the general commands from the client (ie, north, fire, cast,
806 * etc.). It is a lot like PlayerCmd above, but is called with the
807 * 'ncom' method which gives more information back to the client so it
808 * can throttle.
809 */
810void
811NewPlayerCmd (char *buf, int len, player *pl)
812{
813 int time, repeat;
814 char command[MAX_BUF];
815 int pktlen;
816
817 if (len < 7)
818 {
819 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
820 return;
821 }
822
823 pktlen = net_uint16 ((uint8 *)buf);
824 repeat = net_uint32 ((uint8 *)buf + 2);
825
826 /* -1 is special - no repeat, but don't update */
827 if (repeat != -1)
828 pl->count = repeat;
829
830 if ((len - 4) >= MAX_BUF)
831 len = MAX_BUF - 5;
832
833 strncpy ((char *) command, (char *) buf + 6, len - 4);
834 command[len - 4] = 0;
835
836 /* This should not happen anymore. */
837 if (pl->ob->speed_left < -1.0)
838 LOG (llevError, "Player has negative time - shouldn't do command.\n");
839
840 /* In c_new.c */
841 execute_newserver_command (pl->ob, (char *) command);
842 /* Perhaps something better should be done with a left over count. 721 /* Perhaps something better should be done with a left over count.
843 * Cleaning up the input should probably be done first - all actions 722 * Cleaning up the input should probably be done first - all actions
844 * for the command that issued the count should be done before any other 723 * for the command that issued the count should be done before any other
845 * commands. 724 * commands.
846 */ 725 */
847 pl->count = 0; 726 pl->count = 0;
727}
848 728
849 if (FABS (pl->ob->speed) < 0.001) 729
730/**
731 * This handles the general commands from the client (ie, north, fire, cast,
732 * etc.). It is a lot like PlayerCmd above, but is called with the
733 * 'ncom' method which gives more information back to the client so it
734 * can throttle.
735 */
736void
737NewPlayerCmd (char *buf, int len, player *pl)
738{
739 if (len <= 6)
740 {
741 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
742 return;
743 }
744
745 uint16 cmdid = net_uint16 ((uint8 *)buf);
746 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
747
748 /* -1 is special - no repeat, but don't update */
749 if (repeat != -1)
750 pl->count = repeat;
751
752 buf += 6; //len -= 6;
753
754 execute_newserver_command (pl->ob, buf);
755
756 /* Perhaps something better should be done with a left over count.
757 * Cleaning up the input should probably be done first - all actions
758 * for the command that issued the count should be done before any other
759 * commands.
760 */
761 pl->count = 0;
762
763 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
764 int time = fabs (pl->ob->speed) < 0.001
850 time = MAX_TIME * 100; 765 ? time = MAX_TIME * 100
851 else
852 time = (int) (MAX_TIME / FABS (pl->ob->speed)); 766 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
853 767
854 /* Send confirmation of command execution now */ 768 /* Send confirmation of command execution now */
855 769 packet sl ("comc");
856 packet sl;
857 sl << "comc " << uint16 (pktlen) << uint32 (time); 770 sl << uint16 (cmdid) << uint32 (time);
858 pl->socket->send_packet (sl); 771 pl->ns->send_packet (sl);
859} 772}
860
861 773
862/** This is a reply to a previous query. */ 774/** This is a reply to a previous query. */
863void 775void
864ReplyCmd (char *buf, int len, player *pl) 776ReplyCmd (char *buf, int len, client *ns)
865{ 777{
778 if (ns->state == ST_CUSTOM)
779 {
780 INVOKE_CLIENT (REPLY, ns, ARG_DATA (buf, len));
781 return;
782 }
783
784 if (!ns->pl)
785 return; //TODO: depends on the exact reply we are after
786 //TODO: but right now, we always have a ns->pl
787
788 player *pl = ns->pl;
789
866 /* This is to synthesize how the data would be stored if it 790 /* This is to synthesize how the data would be stored if it
867 * was normally entered. A bit of a hack, and should be cleaned up 791 * was normally entered. A bit of a hack, and should be cleaned up
868 * once all the X11 code is removed from the server. 792 * once all the X11 code is removed from the server.
869 * 793 *
870 * We pass 13 to many of the functions because this way they 794 * We pass 13 to many of the functions because this way they
871 * think it was the carriage return that was entered, and the 795 * think it was the carriage return that was entered, and the
872 * function then does not try to do additional input. 796 * function then does not try to do additional input.
873 */ 797 */
874 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf); 798 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
875 799
876 /* this avoids any hacking here */ 800 /* this avoids any hacking here */
877 801
878 switch (pl->state) 802 switch (ns->state)
879 { 803 {
880 case ST_PLAYING: 804 case ST_PLAYING:
881 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 805 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
882 break; 806 break;
883 807
884 case ST_PLAY_AGAIN:
885 /* We can check this for return value (2==quit). Maybe we
886 * should, and do something appropriate?
887 */
888 receive_play_again (pl->ob, buf[0]);
889 break;
890
891 case ST_ROLL_STAT:
892 key_roll_stat (pl->ob, buf[0]);
893 break;
894
895 case ST_CHANGE_CLASS: 808 case ST_CHANGE_CLASS:
896
897 key_change_class (pl->ob, buf[0]); 809 key_change_class (pl->ob, buf[0]);
898 break; 810 break;
899 811
900 case ST_CONFIRM_QUIT:
901 key_confirm_quit (pl->ob, buf[0]);
902 break;
903
904 case ST_CONFIGURE:
905 LOG (llevError, "In client input handling, but into configure state\n");
906 pl->state = ST_PLAYING;
907 break;
908
909 case ST_GET_NAME:
910 receive_player_name (pl->ob, 13);
911 break;
912
913 case ST_GET_PASSWORD:
914 case ST_CONFIRM_PASSWORD:
915 receive_player_password (pl->ob, 13);
916 break;
917
918 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 812 case ST_GET_PARTY_PASSWORD: /* Get password for party */
919 receive_party_password (pl->ob, 13); 813 receive_party_password (pl->ob, 13);
920 break; 814 break;
921 815
922 default: 816 default:
923 LOG (llevError, "Unknown input state: %d\n", pl->state); 817 LOG (llevError, "Unknown input state: %d\n", ns->state);
924 } 818 }
925} 819}
926 820
927/** 821/**
928 * Client tells its version. If there is a mismatch, we close the 822 * Client tells its version. If there is a mismatch, we close the
… …
932 * problem. 826 * problem.
933 */ 827 */
934void 828void
935VersionCmd (char *buf, int len, client * ns) 829VersionCmd (char *buf, int len, client * ns)
936{ 830{
937 char *cp;
938 char version_warning[256];
939
940 if (!buf) 831 if (!buf)
941 { 832 {
942 LOG (llevError, "CS: received corrupted version command\n"); 833 LOG (llevError, "CS: received corrupted version command\n");
943 return; 834 return;
944 } 835 }
945 836
946 ns->cs_version = atoi (buf); 837 ns->cs_version = atoi (buf);
947 ns->sc_version = ns->cs_version; 838 ns->sc_version = ns->cs_version;
839
840 LOG (llevDebug, "connection from client <%s>\n", buf);
841
842 //TODO: should log here just for statistics
843
948 if (VERSION_CS != ns->cs_version) 844 //if (VERSION_CS != ns->cs_version)
949 { 845 // unchecked;
950#ifdef ESRV_DEBUG 846
951 LOG (llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS, ns->cs_version);
952#endif
953 }
954 cp = strchr (buf + 1, ' '); 847 char *cp = strchr (buf + 1, ' ');
955 if (!cp) 848 if (!cp)
956 return; 849 return;
850
957 ns->sc_version = atoi (cp); 851 ns->sc_version = atoi (cp);
852
958 if (VERSION_SC != ns->sc_version) 853 //if (VERSION_SC != ns->sc_version)
959 { 854 // unchecked;
960#ifdef ESRV_DEBUG 855
961 LOG (llevDebug, "CS: scversion mismatch (%d,%d)\n", VERSION_SC, ns->sc_version);
962#endif
963 }
964 cp = strchr (cp + 1, ' '); 856 cp = strchr (cp + 1, ' ');
857
965 if (cp) 858 if (cp)
966 { 859 {
967 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host);
968
969 assign (ns->version, cp + 1); 860 assign (ns->version, cp + 1);
970 861
971 if (ns->sc_version < 1026) 862 if (ns->sc_version < 1026)
972 { 863 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
973 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
974 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 864 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
975 ns->send_packet (version_warning);
976 }
977
978 } 865 }
979} 866}
980 867
981/** sound related functions. */ 868/** sound related functions. */
982void 869void
… …
984{ 871{
985 ns->sound = atoi (buf); 872 ns->sound = atoi (buf);
986} 873}
987 874
988/** client wants the map resent */ 875/** client wants the map resent */
989
990void 876void
991MapRedrawCmd (char *buf, int len, player *pl) 877MapRedrawCmd (char *buf, int len, player *pl)
992{ 878{
993
994/* This function is currently disabled; just clearing the map state results in 879/* This function is currently disabled; just clearing the map state results in
995 * display errors. It should clear the cache and send a newmap command. 880 * display errors. It should clear the cache and send a newmap command.
996 * Unfortunately this solution does not work because some client versions send 881 * Unfortunately this solution does not work because some client versions send
997 * a mapredraw command after receiving a newmap command. 882 * a mapredraw command after receiving a newmap command.
998 */ 883 */
999#if 0
1000 /* Okay, this is MAJOR UGLY. but the only way I know how to
1001 * clear the "cache"
1002 */
1003 memset (&pl->socket->lastmap, 0, sizeof (struct Map));
1004 draw_client_map (pl->ob);
1005#endif
1006} 884}
1007 885
1008/** 886/**
1009 * Moves an object (typically, container to inventory). 887 * Moves an object (typically, container to inventory).
1010 * syntax is: move (to) (tag) (nrof) 888 * syntax is: move (to) (tag) (nrof)
… …
1013MoveCmd (char *buf, int len, player *pl) 891MoveCmd (char *buf, int len, player *pl)
1014{ 892{
1015 int vals[3], i; 893 int vals[3], i;
1016 894
1017 /* A little funky here. We only cycle for 2 records, because 895 /* A little funky here. We only cycle for 2 records, because
1018 * we obviously am not going to find a space after the third 896 * we obviously are not going to find a space after the third
1019 * record. Perhaps we should just replace this with a 897 * record. Perhaps we should just replace this with a
1020 * sscanf? 898 * sscanf?
1021 */ 899 */
1022 for (i = 0; i < 2; i++) 900 for (i = 0; i < 2; i++)
1023 { 901 {
1024 vals[i] = atoi (buf); 902 vals[i] = atoi (buf);
903
1025 if (!(buf = strchr (buf, ' '))) 904 if (!(buf = strchr (buf, ' ')))
1026 { 905 {
1027 LOG (llevError, "Incomplete move command: %s\n", buf); 906 LOG (llevError, "Incomplete move command: %s\n", buf);
1028 return; 907 return;
1029 } 908 }
909
1030 buf++; 910 buf++;
1031 } 911 }
912
1032 vals[2] = atoi (buf); 913 vals[2] = atoi (buf);
1033 914
1034/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/ 915/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
1035 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]); 916 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
1036} 917}
1037
1038
1039 918
1040/****************************************************************************** 919/******************************************************************************
1041 * 920 *
1042 * Start of commands the server sends to the client. 921 * Start of commands the server sends to the client.
1043 * 922 *
… …
1046/** 925/**
1047 * Asks the client to query the user. This way, the client knows 926 * Asks the client to query the user. This way, the client knows
1048 * it needs to send something back (vs just printing out a message) 927 * it needs to send something back (vs just printing out a message)
1049 */ 928 */
1050void 929void
1051send_query (client * ns, uint8 flags, char *text) 930send_query (client *ns, uint8 flags, char *text)
1052{ 931{
1053 char buf[MAX_BUF];
1054
1055 sprintf (buf, "query %d %s", flags, text ? text : ""); 932 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
1056 ns->send_packet (buf);
1057} 933}
1058 934
1059#define AddIfInt64(Old,New,Type) if (Old != New) {\ 935#define AddIfInt64(Old,New,Type) if (Old != New) {\
1060 Old = New; \ 936 Old = New; \
1061 sl << uint8 (Type) << uint64 (New); \ 937 sl << uint8 (Type) << uint64 (New); \
… …
1091esrv_update_stats (player *pl) 967esrv_update_stats (player *pl)
1092{ 968{
1093 char buf[MAX_BUF]; 969 char buf[MAX_BUF];
1094 uint16 flags; 970 uint16 flags;
1095 971
1096 packet sl; 972 client *ns = pl->ns;
1097 sl << "stats "; 973 if (!ns)
974 return;
1098 975
1099 if (pl->ob != NULL) 976 object *ob = pl->ob;
1100 { 977 if (!ob)
978 return;
979
980 packet sl ("stats");
981
1101 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 982 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1102 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 983 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1103 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 984 AddIfShort (ns->last_stats.sp, ob->stats.sp, CS_STAT_SP);
1104 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 985 AddIfShort (ns->last_stats.maxsp, ob->stats.maxsp, CS_STAT_MAXSP);
1105 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 986 AddIfShort (ns->last_stats.grace, ob->stats.grace, CS_STAT_GRACE);
1106 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 987 AddIfShort (ns->last_stats.maxgrace, ob->stats.maxgrace, CS_STAT_MAXGRACE);
1107 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 988 AddIfShort (ns->last_stats.Str, ob->stats.Str, CS_STAT_STR);
1108 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT);
1109 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW);
1110 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1111 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 989 AddIfShort (ns->last_stats.Dex, ob->stats.Dex, CS_STAT_DEX);
1112 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 990 AddIfShort (ns->last_stats.Con, ob->stats.Con, CS_STAT_CON);
991 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
992 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
993 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1113 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 994 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1114 }
1115 995
1116 if (pl->socket->exp64)
1117 {
1118 uint8 s;
1119
1120 for (s = 0; s < NUM_SKILLS; s++) 996 for (int s = 0; s < NUM_SKILLS; s++)
1121 { 997 if (object *skill = pl->last_skill_ob[s])
1122 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 998 if (skill->stats.exp != ns->last_skill_exp [s])
1123 { 999 {
1000 ns->last_skill_exp [s] = skill->stats.exp;
1001
1124 /* Always send along the level if exp changes. This is only 1002 /* Always send along the level if exp changes. This is only
1125 * 1 extra byte, but keeps processing simpler. 1003 * 1 extra byte, but keeps processing simpler.
1126 */ 1004 */
1127 sl << uint8 (s + CS_STAT_SKILLINFO) 1005 sl << uint8 (s + CS_STAT_SKILLINFO)
1128 << uint8 (pl->last_skill_ob[s]->level) 1006 << uint8 (skill->level)
1129 << uint64 (pl->last_skill_ob[s]->stats.exp); 1007 << uint64 (skill->stats.exp);
1130
1131 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1132 } 1008 }
1133 }
1134 }
1135 1009
1136 if (pl->socket->exp64)
1137 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) } 1010 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
1138 else
1139 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1140
1141 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 1011 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
1142 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 1012 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
1143 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 1013 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
1144 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 1014 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
1145 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 1015 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED);
1146 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 1016 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
1147 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 1017 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1148 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 1018 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
1019
1149 flags = 0; 1020 flags = 0;
1150 1021
1151 if (pl->fire_on) 1022 if (pl->fire_on)
1152 flags |= SF_FIREON; 1023 flags |= SF_FIREON;
1153 1024
1154 if (pl->run_on) 1025 if (pl->run_on)
1155 flags |= SF_RUNON; 1026 flags |= SF_RUNON;
1156 1027
1157 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 1028 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
1158 1029
1159 if (pl->socket->sc_version < 1025) 1030 if (ns->sc_version < 1025)
1160 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) } 1031 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1161 else 1032 else
1162 {
1163 int i;
1164
1165 for (i = 0; i < NROFATTACKS; i++) 1033 for (int i = 0; i < NROFATTACKS; i++)
1166 { 1034 {
1167 /* Skip ones we won't send */ 1035 /* Skip ones we won't send */
1168 if (atnr_cs_stat[i] == -1) 1036 if (atnr_cs_stat[i] == -1)
1169 continue; 1037 continue;
1170 1038
1171 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 1039 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
1172 } 1040 }
1173 }
1174 1041
1175 if (pl->socket->monitor_spells) 1042 if (pl->ns->monitor_spells)
1176 { 1043 {
1177 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 1044 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1178 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 1045 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1179 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 1046 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1180 } 1047 }
1181 1048
1182 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 1049 rangetostring (ob, buf); /* we want use the new fire & run system in new client */
1183 AddIfString (pl->socket->stats.range, buf, CS_STAT_RANGE); 1050 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1184 set_title (pl->ob, buf); 1051 set_title (ob, buf);
1185 AddIfString (pl->socket->stats.title, buf, CS_STAT_TITLE); 1052 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1186 1053
1187 /* Only send it away if we have some actual data */ 1054 /* Only send it away if we have some actual data */
1188 if (sl.length () > 6) 1055 if (sl.length () > 6)
1189 pl->socket->send_packet (sl); 1056 ns->send_packet (sl);
1190} 1057}
1191 1058
1192/** 1059/**
1193 * Tells the client that here is a player it should start using. 1060 * Tells the client that here is a player it should start using.
1194 */ 1061 */
1195void 1062void
1196esrv_new_player (player *pl, uint32 weight) 1063esrv_new_player (player *pl, uint32 weight)
1197{ 1064{
1198 pl->last_weight = weight; 1065 packet sl ("player");
1199
1200 packet sl;
1201 sl << "player ";
1202 1066
1203 sl << uint32 (pl->ob->count) 1067 sl << uint32 (pl->ob->count)
1204 << uint32 (weight) 1068 << uint32 (weight)
1205 << uint32 (pl->ob->face->number) 1069 << uint32 (pl->ob->face)
1206 << data8 (pl->ob->name); 1070 << data8 (pl->ob->name);
1207 1071
1072 pl->ns->last_weight = weight;
1208 pl->socket->send_packet (sl); 1073 pl->ns->send_packet (sl);
1209 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1074 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1210} 1075}
1211
1212/**
1213 * Need to send an animation sequence to the client.
1214 * We will send appropriate face commands to the client if we haven't
1215 * sent them the face yet (this can become quite costly in terms of
1216 * how much we are sending - on the other hand, this should only happen
1217 * when the player logs in and picks stuff up.
1218 */
1219void
1220esrv_send_animation (client * ns, short anim_num)
1221{
1222 int i;
1223
1224 /* Do some checking on the anim_num we got. Note that the animations
1225 * are added in contigous order, so if the number is in the valid
1226 * range, it must be a valid animation.
1227 */
1228 if (anim_num < 0 || anim_num > num_animations)
1229 {
1230 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1231 return;
1232 }
1233
1234 packet sl;
1235
1236 sl << "anim "
1237 << uint16 (anim_num)
1238 << uint16 (0); /* flags - not used right now */
1239
1240 /* Build up the list of faces. Also, send any information (ie, the
1241 * the face itself) down to the client.
1242 */
1243 for (i = 0; i < animations[anim_num].num_animations; i++)
1244 {
1245 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1246 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1247 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1248 }
1249
1250 ns->send_packet (sl);
1251
1252 ns->anims_sent[anim_num] = 1;
1253}
1254
1255 1076
1256/****************************************************************************** 1077/******************************************************************************
1257 * 1078 *
1258 * Start of map related commands. 1079 * Start of map related commands.
1259 * 1080 *
1260 ******************************************************************************/ 1081 ******************************************************************************/
1261 1082
1262/**
1263 * This adds face_num to a map cell at x,y. If the client doesn't have
1264 * the face yet, we will also send it.
1265 */
1266static void
1267esrv_map_setbelow (client * ns, int x, int y, short face_num, struct Map *newmap)
1268{
1269 if (newmap->cells[x][y].count >= MAP_LAYERS)
1270 {
1271 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1272 return;
1273 abort ();
1274 }
1275
1276 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1277 newmap->cells[x][y].count++;
1278
1279 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1280 esrv_send_face (ns, face_num, 0);
1281}
1282
1283struct LayerCell
1284{
1285 uint16 xy;
1286 short face;
1287};
1288
1289struct MapLayer
1290{
1291 int count;
1292 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1293};
1294
1295/** Checkes if map cells have changed */
1296static int
1297mapcellchanged (client * ns, int i, int j, struct Map *newmap)
1298{
1299 int k;
1300
1301 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1302 return 1;
1303 for (k = 0; k < newmap->cells[i][j].count; k++)
1304 {
1305 if (ns->lastmap.cells[i][j].faces[k] != newmap->cells[i][j].faces[k])
1306 {
1307 return 1;
1308 }
1309 }
1310 return 0;
1311}
1312
1313/**
1314 * Basically, what this does is pack the data into layers.
1315 * cnum is the client number, cur is the the buffer we put all of
1316 * this data into. we return the end of the data. layers is
1317 * how many layers of data we should back.
1318 */
1319static uint8 *
1320compactlayer (client * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1321{
1322 int x, y, k;
1323 int face;
1324 unsigned char *fcur;
1325 struct MapLayer layers[MAP_LAYERS];
1326
1327 for (k = 0; k < MAP_LAYERS; k++)
1328 layers[k].count = 0;
1329 fcur = cur;
1330 for (x = 0; x < ns->mapx; x++)
1331 {
1332 for (y = 0; y < ns->mapy; y++)
1333 {
1334 if (!mapcellchanged (ns, x, y, newmap))
1335 continue;
1336 if (newmap->cells[x][y].count == 0)
1337 {
1338 *cur = x * ns->mapy + y; /* mark empty space */
1339 cur++;
1340 continue;
1341 }
1342 for (k = 0; k < newmap->cells[x][y].count; k++)
1343 {
1344 layers[k].lcells[layers[k].count].xy = x * ns->mapy + y;
1345 layers[k].lcells[layers[k].count].face = newmap->cells[x][y].faces[k];
1346 layers[k].count++;
1347 }
1348 }
1349 }
1350 /* If no data, return now. */
1351 if (fcur == cur && layers[0].count == 0)
1352 return cur;
1353 *cur = 255; /* mark end of explicitly cleared cells */
1354 cur++;
1355 /* First pack by layers. */
1356 for (k = 0; k < numlayers; k++)
1357 {
1358 if (layers[k].count == 0)
1359 break; /* once a layer is entirely empty, no layer below it can
1360 have anything in it either */
1361 /* Pack by entries in thie layer */
1362 for (x = 0; x < layers[k].count;)
1363 {
1364 fcur = cur;
1365 *cur = layers[k].lcells[x].face >> 8;
1366 cur++;
1367 *cur = layers[k].lcells[x].face & 0xFF;
1368 cur++;
1369 face = layers[k].lcells[x].face;
1370 /* Now, we back the redundant data into 1 byte xy pairings */
1371 for (y = x; y < layers[k].count; y++)
1372 {
1373 if (layers[k].lcells[y].face == face)
1374 {
1375 *cur = (uint8) layers[k].lcells[y].xy;
1376 cur++;
1377 layers[k].lcells[y].face = -1;
1378 }
1379 }
1380 *(cur - 1) = *(cur - 1) | 128; /* mark for end of xy's; 11*11 < 128 */
1381 /* forward over the now redundant data */
1382 while (x < layers[k].count && layers[k].lcells[x].face == -1)
1383 x++;
1384 }
1385 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1386 }
1387 return cur;
1388}
1389
1390/** Clears a map cell */ 1083/** Clears a map cell */
1391static void 1084static void
1392map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 1085map_clearcell (struct MapCell *cell, int count)
1393{ 1086{
1394 cell->faces[0] = face0; 1087 cell->faces[0] = 0;
1395 cell->faces[1] = face1; 1088 cell->faces[1] = 0;
1396 cell->faces[2] = face2; 1089 cell->faces[2] = 0;
1090 cell->smooth[0] = 0;
1091 cell->smooth[1] = 0;
1092 cell->smooth[2] = 0;
1397 cell->count = count; 1093 cell->count = count;
1398 cell->stat_hp = 0; 1094 cell->stat_hp = 0;
1399 cell->flags = 0; 1095 cell->flags = 0;
1400 cell->player = 0; 1096 cell->player = 0;
1401} 1097}
1402 1098
1403#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1404#define MAX_LAYERS 3 1099#define MAX_LAYERS 3
1405
1406/* Using a global really isn't a good approach, but saves the over head of
1407 * allocating and deallocating such a block of data each time run through,
1408 * and saves the space of allocating this in the socket object when we only
1409 * need it for this cycle. If the serve is ever threaded, this needs to be
1410 * re-examined.
1411 */
1412
1413static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1414
1415/**
1416 * Returns true if any of the heads for this
1417 * space is set. Returns false if all are blank - this is used
1418 * for empty space checking.
1419 */
1420static inline int
1421have_head (int ax, int ay)
1422{
1423
1424 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1425 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1426 return 1;
1427 return 0;
1428}
1429
1430/**
1431 * check_head is a bit simplistic version of update_space below.
1432 * basically, it only checks the that the head on space ax,ay at layer
1433 * needs to get sent - if so, it adds the data, sending the head
1434 * if needed, and returning 1. If this no data needs to get
1435 * sent, it returns zero.
1436 */
1437static int
1438check_head (packet &sl, client &ns, int ax, int ay, int layer)
1439{
1440 short face_num;
1441
1442 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1443 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1444 else
1445 face_num = 0;
1446
1447 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1448 {
1449 sl << uint16 (face_num);
1450 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1451 esrv_send_face (&ns, face_num, 0);
1452
1453 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1454 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1455 return 1;
1456 }
1457
1458 return 0; /* No change */
1459}
1460 1100
1461/** 1101/**
1462 * Removes the need to replicate the same code for each layer. 1102 * Removes the need to replicate the same code for each layer.
1463 * this returns true if this space is now in fact different than 1103 * this returns true if this space is now in fact different than
1464 * it was. 1104 * it was.
1465 * sl is the socklist this data is going into. 1105 * sl is the socklist this data is going into.
1466 * ns is the socket we are working on - all the info we care 1106 * ns is the socket we are working on - all the info we care
1467 * about is in this socket structure, so now need not pass the 1107 * about is in this socket structure, so now need not pass the
1468 * entire player object. 1108 * entire player object.
1469 * mx and my are map coordinate offsets for map mp
1470 * sx and sy are the offsets into the socket structure that
1471 * holds the old values.
1472 * layer is the layer to update, with 2 being the floor and 0 the 1109 * layer is the layer to update, with 2 being the floor and 0 the
1473 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ) 1110 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ)
1474 * take. Interesting to note that before this function, the map1 function 1111 * take. Interesting to note that before this function, the map1 function
1475 * numbers the spaces differently - I think this was a leftover from 1112 * numbers the spaces differently - I think this was a leftover from
1476 * the map command, where the faces stack up. Sinces that is no longer 1113 * the map command, where the faces stack up. Sinces that is no longer
1477 * the case, it seems to make more sense to have these layer values 1114 * the case, it seems to make more sense to have these layer values
1478 * actually match. 1115 * actually match.
1479 */ 1116 */
1480
1481static int 1117static int
1482update_space (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1118update_space (packet &sl, client &ns, mapspace &ms, MapCell &lastcell, int layer)
1483{ 1119{
1484 object *ob, *head; 1120 object *ob = ms.faces_obj [layer];
1485 uint16 face_num;
1486 int bx, by, i;
1487
1488 /* If there is a multipart object stored away, treat that as more important.
1489 * If not, then do the normal processing.
1490 */
1491 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1492
1493 /* Check to see if this head is part of the set of objects
1494 * we would normally send for this space. If so, then
1495 * don't use the head value. We need to do the check
1496 * here and not when setting up the heads[] value for two reasons -
1497 * 1) the heads[] values will get used even if the space is not visible.
1498 * 2) its possible the head is not on the same map as a part, and I'd
1499 * rather not need to do the map translation overhead.
1500 * 3) We need to do some extra checking to make sure that we will
1501 * otherwise send the image as this layer, eg, either it matches
1502 * the head value, or is not multipart.
1503 */
1504 if (head && !head->more)
1505 {
1506 for (i = 0; i < MAP_LAYERS; i++)
1507 {
1508 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1509 if (!ob)
1510 continue;
1511
1512 if (ob->head)
1513 ob = ob->head;
1514
1515 if (ob == head)
1516 {
1517 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1518 head = NULL;
1519 break;
1520 }
1521 }
1522 }
1523
1524 ob = head;
1525 if (!ob)
1526 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1527 1121
1528 /* If there is no object for this space, or if the face for the object 1122 /* If there is no object for this space, or if the face for the object
1529 * is the blank face, set the face number to zero. 1123 * is the blank face, set the face number to zero.
1530 * else if we have the stored head object for this space, that takes 1124 * else if we have the stored head object for this space, that takes
1531 * precedence over the other object for this space. 1125 * precedence over the other object for this space.
1532 * otherwise, we do special head processing 1126 * otherwise, we do special head processing
1533 */ 1127 */
1534 if (!ob || ob->face == blank_face) 1128 uint16 face_num = ob && ob->face != blank_face ? ob->face : 0;
1535 face_num = 0;
1536 else if (head)
1537 {
1538 /* if this is a head that had previously been stored */
1539 face_num = ob->face->number;
1540 }
1541 else
1542 {
1543 /* if the faces for the different parts of a multipart object
1544 * are the same, we only want to send the bottom right most
1545 * portion of the object. That info is in the tail_.. values
1546 * of the head. Note that for the head itself, ob->head will
1547 * be null, so we only do this block if we are working on
1548 * a tail piece.
1549 */
1550
1551 /* tail_x and tail_y will only be set in the head object. If
1552 * this is the head object and these are set, we proceed
1553 * with logic to only send bottom right. Similarly, if
1554 * this is one of the more parts but the head has those values
1555 * set, we want to do the processing. There can be cases where
1556 * the head is not visible but one of its parts is, so we just
1557 * can always expect that ob->arch->tail_x will be true for all
1558 * object we may want to display.
1559 */
1560 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1561 {
1562
1563 if (ob->head)
1564 head = ob->head;
1565 else
1566 head = ob;
1567
1568 /* Basically figure out where the offset is from where we are right
1569 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1570 * piece is from the head, and the tail is where the tail is from the
1571 * head. Note that bx and by will equal sx and sy if we are already working
1572 * on the bottom right corner. If ob is the head, the clone values
1573 * will be zero, so the right thing will still happen.
1574 */
1575 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1576 by = sy + head->arch->tail_y - ob->arch->clone.y;
1577
1578 /* I don't think this can ever happen, but better to check for it just
1579 * in case.
1580 */
1581 if (bx < sx || by < sy)
1582 {
1583 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1584 face_num = 0;
1585 }
1586 /* single part object, multipart object with non merged faces,
1587 * of multipart object already at lower right.
1588 */
1589 else if (bx == sx && by == sy)
1590 {
1591 face_num = ob->face->number;
1592
1593 /* if this face matches one stored away, clear that one away.
1594 * this code relies on the fact that the map1 commands
1595 * goes from 2 down to 0.
1596 */
1597 for (i = 0; i < MAP_LAYERS; i++)
1598 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1599 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1600 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1601 }
1602 else
1603 {
1604 /* If this head is stored away, clear it - otherwise,
1605 * there can be cases where a object is on multiple layers -
1606 * we only want to send it once.
1607 */
1608 face_num = head->face->number;
1609 for (i = 0; i < MAP_LAYERS; i++)
1610 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1611 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1612 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1613
1614 /* First, try to put the new head on the same layer. If that is used up,
1615 * then find another layer.
1616 */
1617 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1618 {
1619 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1620 }
1621 else
1622 for (i = 0; i < MAX_LAYERS; i++)
1623 {
1624 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1625 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1626 {
1627 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1628 }
1629 }
1630 face_num = 0; /* Don't send this object - we'll send the head later */
1631 }
1632 }
1633 else
1634 {
1635 /* In this case, we are already at the lower right or single part object,
1636 * so nothing special
1637 */
1638 face_num = ob->face->number;
1639
1640 /* clear out any head entries that have the same face as this one */
1641 for (bx = 0; bx < layer; bx++)
1642 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1643 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1644 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1645 }
1646 } /* else not already head object or blank face */
1647
1648 /* This is a real hack. Basically, if we have nothing to send for this layer,
1649 * but there is a head on the next layer, send that instead.
1650 * Without this, what happens is you can get the case where the player stands
1651 * on the same space as the head. However, if you have overlapping big objects
1652 * of the same type, what happens then is it doesn't think it needs to send
1653 * This tends to make stacking also work/look better.
1654 */
1655 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1656 {
1657 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1658 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1659 }
1660
1661 /* Another hack - because of heads and whatnot, this face may match one
1662 * we already sent for a lower layer. In that case, don't send
1663 * this one.
1664 */
1665 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1666 face_num = 0;
1667 1129
1668 /* We've gotten what face we want to use for the object. Now see if 1130 /* We've gotten what face we want to use for the object. Now see if
1669 * if it has changed since we last sent it to the client. 1131 * if it has changed since we last sent it to the client.
1670 */ 1132 */
1671 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num) 1133 if (lastcell.faces[layer] != face_num)
1672 { 1134 {
1673 ns.lastmap.cells[sx][sy].faces[layer] = face_num; 1135 lastcell.faces[layer] = face_num;
1136
1674 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1137 if (!ns.faces_sent[face_num])
1138 if (ob)
1139 ns.send_faces (ob);
1140 else
1675 esrv_send_face (&ns, face_num, 0); 1141 ns.send_face (face_num);
1676 1142
1677 sl << uint16 (face_num); 1143 sl << uint16 (face_num);
1678 return 1;
1679 }
1680
1681 /* Nothing changed */
1682 return 0;
1683}
1684
1685/**
1686 * This function is mainly a copy of update_space,
1687 * except it handles update of the smoothing updates,
1688 * not the face updates.
1689 * Removes the need to replicate the same code for each layer.
1690 * this returns true if this smooth is now in fact different
1691 * than it was.
1692 * sl is the socklist this data is going into.
1693 * ns is the socket we are working on - all the info we care
1694 * about is in this socket structure, so know need to pass the
1695 * entire player object.
1696 * mx and my are map coordinate offsets for map mp
1697 * sx and sy are the offsets into the socket structure that
1698 * holds the old values.
1699 * layer is the layer to update, with 2 being the floor and 0 the
1700 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1701 * take.
1702 */
1703
1704static inline int
1705update_smooth (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1706{
1707 object *ob;
1708 int smoothlevel; /* old face_num; */
1709
1710 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1711
1712 /* If there is no object for this space, or if the face for the object
1713 * is the blank face, set the smoothlevel to zero.
1714 */
1715 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1716 smoothlevel = 0;
1717 else
1718 {
1719 smoothlevel = ob->smoothlevel;
1720 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1721 SendSmooth (&ns, ob->face->number);
1722 } /* else not already head object or blank face */
1723
1724 /* We've gotten what face we want to use for the object. Now see if
1725 * if it has changed since we last sent it to the client.
1726 */
1727 if (smoothlevel > 255)
1728 smoothlevel = 255;
1729 else if (smoothlevel < 0)
1730 smoothlevel = 0;
1731
1732 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1733 {
1734 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1735 sl << uint8 (smoothlevel);
1736 return 1; 1144 return 1;
1737 } 1145 }
1738 1146
1739 /* Nothing changed */ 1147 /* Nothing changed */
1740 return 0; 1148 return 0;
… …
1753 if (ns->ext_mapinfos) 1161 if (ns->ext_mapinfos)
1754 { 1162 {
1755 if (ns->EMI_smooth) 1163 if (ns->EMI_smooth)
1756 result += 1; /*One byte for smoothlevel */ 1164 result += 1; /*One byte for smoothlevel */
1757 } 1165 }
1166
1758 return result; 1167 return result;
1168}
1169
1170// prefetch (and touch) all maps within a specific distancd
1171static void
1172prefetch_surrounding_maps (maptile *map, int distance)
1173{
1174 map->last_access = runtime;
1175
1176 if (--distance)
1177 for (int dir = 4; --dir; )
1178 if (const shstr &path = map->tile_path [dir])
1179 if (maptile *&neigh = map->tile_map [dir])
1180 prefetch_surrounding_maps (neigh, distance);
1181 else
1182 neigh = maptile::find_async (path, map);
1183}
1184
1185// prefetch a generous area around the player
1186static void
1187prefetch_surrounding_maps (object *op)
1188{
1189 prefetch_surrounding_maps (op->map, 3);
1759} 1190}
1760 1191
1761/** 1192/**
1762 * This function uses the new map1 protocol command to send the map 1193 * This function uses the new map1 protocol command to send the map
1763 * to the client. It is necessary because the old map command supports 1194 * to the client. It is necessary because the old map command supports
… …
1769 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off 1200 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1770 * maps no sense. Instead, we actually really only use 12 bits for coordinates, 1201 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1771 * and use the other 4 bits for other informatiion. For full documentation 1202 * and use the other 4 bits for other informatiion. For full documentation
1772 * of what we send, see the doc/Protocol file. 1203 * of what we send, see the doc/Protocol file.
1773 * I will describe internally what we do: 1204 * I will describe internally what we do:
1774 * the socket->lastmap shows how the map last looked when sent to the client. 1205 * the ns->lastmap shows how the map last looked when sent to the client.
1775 * in the lastmap structure, there is a cells array, which is set to the 1206 * in the lastmap structure, there is a cells array, which is set to the
1776 * maximum viewable size (As set in config.h). 1207 * maximum viewable size (As set in config.h).
1777 * in the cells, there are faces and a count value. 1208 * in the cells, there are faces and a count value.
1778 * we use the count value to hold the darkness value. If -1, then this space 1209 * we use the count value to hold the darkness value. If -1, then this space
1779 * is not viewable. 1210 * is not viewable.
… …
1781 * look like. 1212 * look like.
1782 */ 1213 */
1783void 1214void
1784draw_client_map1 (object *pl) 1215draw_client_map1 (object *pl)
1785{ 1216{
1786 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1217 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1787 sint16 nx, ny; 1218 sint16 nx, ny;
1788 int estartlen, eoldlen; 1219 int estartlen, eoldlen;
1789 uint16 mask, emask;
1790 uint8 eentrysize; 1220 uint8 eentrysize;
1791 uint16 ewhatstart, ewhatflag; 1221 uint16 ewhatstart, ewhatflag;
1792 uint8 extendedinfos; 1222 uint8 extendedinfos;
1793 maptile *m; 1223 maptile *m;
1794 1224
1795 client &socket = *pl->contr->socket; 1225 client &socket = *pl->contr->ns;
1226
1227 if (!pl->active)
1228 return;
1796 1229
1797 check_map_change (pl->contr); 1230 check_map_change (pl->contr);
1231 prefetch_surrounding_maps (pl);
1798 1232
1799 packet sl; 1233 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1800 packet esl; 1234 packet esl;
1801 1235
1802 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1803 startlen = sl.length (); 1236 startlen = sl.length ();
1804 1237
1805 /*Extendedmapinfo structure initialisation */ 1238 /*Extendedmapinfo structure initialisation */
1806 if (socket.ext_mapinfos) 1239 if (socket.ext_mapinfos)
1807 { 1240 {
… …
1826 ewhatstart = 0; 1259 ewhatstart = 0;
1827 ewhatflag = 0; 1260 ewhatflag = 0;
1828 estartlen = 0; 1261 estartlen = 0;
1829 } 1262 }
1830 1263
1831 /* Init data to zero */
1832 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1833
1834 /* x,y are the real map locations. ax, ay are viewport relative 1264 /* x,y are the real map locations. ax, ay are viewport relative
1835 * locations. 1265 * locations.
1836 */ 1266 */
1837 ay = 0; 1267 ay = 0;
1838 1268
… …
1840 * but that started to get a bit messy to look at. 1270 * but that started to get a bit messy to look at.
1841 */ 1271 */
1842 max_x = pl->x + (socket.mapx + 1) / 2; 1272 max_x = pl->x + (socket.mapx + 1) / 2;
1843 max_y = pl->y + (socket.mapy + 1) / 2; 1273 max_y = pl->y + (socket.mapy + 1) / 2;
1844 1274
1845 if (socket.mapmode == Map1aCmd) 1275 maptile *plmap = pl->map;
1846 {
1847 max_x += MAX_HEAD_OFFSET;
1848 max_y += MAX_HEAD_OFFSET;
1849 }
1850 1276
1851 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1277 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1852 { 1278 {
1853 ax = 0; 1279 ax = 0;
1854 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1280 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1855 { 1281 {
1856 1282 int emask, mask;
1857 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1283 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1858 1284
1859 /* If this space is out of the normal viewable area, we only check
1860 * the heads value ax or ay will only be greater than what
1861 * the client wants if using the map1a command - this is because
1862 * if the map1a command is not used, max_x and max_y will be
1863 * set to lower values.
1864 */
1865 if (ax >= socket.mapx || ay >= socket.mapy)
1866 {
1867 int i, got_one;
1868
1869 oldlen = sl.length ();
1870
1871 sl << uint16 (mask);
1872
1873 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1874 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1875 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1876
1877 /* If all we are doing is sending 0 (blank) faces, we don't
1878 * actually need to send that - just the coordinates
1879 * with no faces tells the client to blank out the
1880 * space.
1881 */
1882 got_one = 0;
1883 for (i = oldlen + 2; i < sl.length (); i++)
1884 if (sl[i])
1885 got_one = 1;
1886
1887 if (got_one && (mask & 0xf))
1888 sl[oldlen + 1] = mask & 0xff;
1889 else
1890 { /*either all faces blank, either no face at all */
1891 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1892 sl.reset (oldlen + 2);
1893 else
1894 sl.reset (oldlen);
1895 }
1896
1897 /*What concerns extendinfos, nothing to be done for now
1898 * (perhaps effects layer later)
1899 */
1900 continue; /* don't do processing below */
1901 }
1902
1903 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1285 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1904
1905 d = pl->contr->blocked_los[ax][ay];
1906 1286
1907 /* If the coordinates are not valid, or it is too dark to see, 1287 /* If the coordinates are not valid, or it is too dark to see,
1908 * we tell the client as such 1288 * we tell the client as such
1909 */ 1289 */
1910 nx = x; 1290 nx = x;
1911 ny = y; 1291 ny = y;
1912 m = get_map_from_coord (pl->map, &nx, &ny); 1292 m = get_map_from_coord (plmap, &nx, &ny);
1913 1293
1914 if (!m) 1294 if (!m)
1915 { 1295 {
1916 /* space is out of map. Update space and clear values 1296 /* space is out of map. Update space and clear values
1917 * if this hasn't already been done. If the space is out 1297 * if this hasn't already been done. If the space is out
1918 * of the map, it shouldn't have a head 1298 * of the map, it shouldn't have a head
1919 */ 1299 */
1920 if (lastcell.count != -1) 1300 if (lastcell.count != -1)
1921 { 1301 {
1922 sl << uint16 (mask); 1302 sl << uint16 (mask);
1923 map_clearcell (&lastcell, 0, 0, 0, -1); 1303 map_clearcell (&lastcell, -1);
1924 } 1304 }
1305
1306 continue;
1925 } 1307 }
1308
1309 m->touch ();
1310
1311 int d = pl->contr->blocked_los[ax][ay];
1312
1926 else if (d > 3) 1313 if (d > 3)
1927 { 1314 {
1315
1928 int need_send = 0, count; 1316 int need_send = 0, count;
1929 1317
1930 /* This block deals with spaces that are not visible for whatever 1318 /* This block deals with spaces that are not visible for whatever
1931 * reason. Still may need to send the head for this space. 1319 * reason. Still may need to send the head for this space.
1932 */ 1320 */
1933 1321
1934 oldlen = sl.length (); 1322 oldlen = sl.length ();
1935 1323
1936 sl << uint16 (mask); 1324 sl << uint16 (mask);
… …
1938 if (lastcell.count != -1) 1326 if (lastcell.count != -1)
1939 need_send = 1; 1327 need_send = 1;
1940 1328
1941 count = -1; 1329 count = -1;
1942 1330
1943 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
1944 {
1945 /* Now check to see if any heads need to be sent */
1946
1947 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1948 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1949 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1950
1951 lastcell.count = count;
1952 }
1953 else
1954 {
1955 /* properly clear a previously sent big face */ 1331 /* properly clear a previously sent big face */
1956 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0 1332 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1957 || lastcell.stat_hp || lastcell.flags || lastcell.player) 1333 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1958 need_send = 1; 1334 need_send = 1;
1959 1335
1960 map_clearcell (&lastcell, 0, 0, 0, count); 1336 map_clearcell (&lastcell, count);
1961 }
1962 1337
1963 if ((mask & 0xf) || need_send) 1338 if ((mask & 0xf) || need_send)
1964 sl[oldlen + 1] = mask & 0xff; 1339 sl[oldlen + 1] = mask & 0xff;
1965 else 1340 else
1966 sl.reset (oldlen); 1341 sl.reset (oldlen);
1967 } 1342 }
1968 else 1343 else
1969 { 1344 {
1970 /* In this block, the space is visible or there are head objects 1345 /* In this block, the space is visible.
1971 * we need to send.
1972 */ 1346 */
1973 1347
1974 /* Rather than try to figure out what everything that we might 1348 /* Rather than try to figure out what everything that we might
1975 * need to send is, then form the packet after that, 1349 * need to send is, then form the packet after that,
1976 * we presume that we will in fact form a packet, and update 1350 * we presume that we will in fact form a packet, and update
… …
1979 * is done. 1353 * is done.
1980 * I think this is simpler than doing a bunch of checks to see 1354 * I think this is simpler than doing a bunch of checks to see
1981 * what if anything we need to send, setting the bits, then 1355 * what if anything we need to send, setting the bits, then
1982 * doing those checks again to add the real data. 1356 * doing those checks again to add the real data.
1983 */ 1357 */
1984 oldlen = sl.length (); 1358 oldlen = sl.length ();
1985 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1986 eoldlen = esl.length (); 1359 eoldlen = esl.length ();
1987 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1360
1988 sl << uint16 (mask); 1361 sl << uint16 (mask);
1989
1990 if (socket.ext_mapinfos)
1991 esl << uint16 (emask);
1992 1362
1993 unsigned char dummy; 1363 unsigned char dummy;
1994 unsigned char *last_ext = &dummy; 1364 unsigned char *last_ext = &dummy;
1995 1365
1996 /* Darkness changed */ 1366 /* Darkness changed */
… …
2008 sl << uint8 (255 - 64 * d); 1378 sl << uint8 (255 - 64 * d);
2009 } 1379 }
2010 1380
2011 lastcell.count = d; 1381 lastcell.count = d;
2012 1382
1383 mapspace &ms = m->at (nx, ny);
1384
2013 if (socket.extmap) 1385 if (socket.extmap)
2014 { 1386 {
2015 uint8 stat_hp = 0; 1387 uint8 stat_hp = 0;
2016 uint8 stat_width = 0; 1388 uint8 stat_width = 0;
2017 uint8 flags = 0; 1389 uint8 flags = 0;
2018 UUID player = 0; 1390 UUID player = 0;
2019 1391
2020 // send hp information, if applicable 1392 // send hp information, if applicable
2021 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1393 if (object *op = ms.faces_obj [0])
2022 { 1394 {
2023 if (op->head || op->invisible) 1395 if (op->head || op->invisible)
2024 ; // do not show 1396 ; // do not show
2025 else if (op->type == PLAYER 1397 else if (op->type == PLAYER
2026 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1398 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
… …
2080 sl << uint8 (8) << uint8 (flags); 1452 sl << uint8 (8) << uint8 (flags);
2081 } 1453 }
2082 } 1454 }
2083 1455
2084 /* Floor face */ 1456 /* Floor face */
2085 if (update_space (sl, socket, m, nx, ny, ax, ay, 2)) 1457 if (update_space (sl, socket, ms, lastcell, 2))
2086 mask |= 0x4; 1458 mask |= 0x4;
2087 1459
2088 if (socket.EMI_smooth)
2089 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2090 emask |= 0x4;
2091
2092 /* Middle face */ 1460 /* Middle face */
2093 if (update_space (sl, socket, m, nx, ny, ax, ay, 1)) 1461 if (update_space (sl, socket, ms, lastcell, 1))
2094 mask |= 0x2; 1462 mask |= 0x2;
2095 1463
2096 if (socket.EMI_smooth) 1464 if (ms.player () == pl
2097 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1)) 1465 && (pl->invisible & (pl->invisible < 50 ? 1 : 7)))
2098 emask |= 0x2;
2099
2100 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2101 { 1466 {
1467 // force player to be visible to himself if invisible
2102 if (lastcell.faces[0] != pl->face->number) 1468 if (lastcell.faces[0] != pl->face)
2103 { 1469 {
2104 lastcell.faces[0] = pl->face->number; 1470 lastcell.faces[0] = pl->face;
1471
2105 mask |= 0x1; 1472 mask |= 0x1;
2106
2107 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2108 esrv_send_face (&socket, pl->face->number, 0);
2109
2110 sl << uint16 (pl->face->number); 1473 sl << uint16 (pl->face);
1474
1475 socket.send_faces (pl);
2111 } 1476 }
2112 } 1477 }
2113 else
2114 {
2115 /* Top face */ 1478 /* Top face */
2116 if (update_space (sl, socket, m, nx, ny, ax, ay, 0)) 1479 else if (update_space (sl, socket, ms, lastcell, 0))
2117 mask |= 0x1; 1480 mask |= 0x1;
2118
2119 if (socket.EMI_smooth)
2120 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2121 emask |= 0x1;
2122 } 1481
2123 1482
2124 /* Check to see if we are in fact sending anything for this 1483 /* Check to see if we are in fact sending anything for this
2125 * space by checking the mask. If so, update the mask. 1484 * space by checking the mask. If so, update the mask.
2126 * if not, reset the len to that from before adding the mask 1485 * if not, reset the len to that from before adding the mask
2127 * value, so we don't send those bits. 1486 * value, so we don't send those bits.
… …
2129 if (mask & 0xf) 1488 if (mask & 0xf)
2130 sl[oldlen + 1] = mask & 0xff; 1489 sl[oldlen + 1] = mask & 0xff;
2131 else 1490 else
2132 sl.reset (oldlen); 1491 sl.reset (oldlen);
2133 1492
1493 if (socket.ext_mapinfos)
1494 esl << uint16 (emask);
1495
1496 if (socket.EMI_smooth)
1497 {
1498 for (int layer = 2+1; layer--; )
1499 {
1500 object *ob = ms.faces_obj [layer];
1501
1502 // If there is no object for this space, or if the face for the object
1503 // is the blank face, set the smoothlevel to zero.
1504 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1505
1506 // We've gotten what face we want to use for the object. Now see if
1507 // if it has changed since we last sent it to the client.
1508 if (lastcell.smooth[layer] != smoothlevel)
1509 {
1510 lastcell.smooth[layer] = smoothlevel;
1511 esl << uint8 (smoothlevel);
1512 emask |= 1 << layer;
1513 }
1514 }
1515
2134 if (emask & 0xf) 1516 if (emask & 0xf)
2135 esl[eoldlen + 1] = emask & 0xff; 1517 esl[eoldlen + 1] = emask & 0xff;
2136 else 1518 else
2137 esl.reset (eoldlen); 1519 esl.reset (eoldlen);
1520 }
2138 } /* else this is a viewable space */ 1521 } /* else this is a viewable space */
2139 } /* for x loop */ 1522 } /* for x loop */
2140 } /* for y loop */ 1523 } /* for y loop */
2141 1524
2142 /* Verify that we in fact do need to send this */ 1525 /* Verify that we in fact do need to send this */
… …
2145 if (!(sl.length () > startlen || socket.sent_scroll)) 1528 if (!(sl.length () > startlen || socket.sent_scroll))
2146 { 1529 {
2147 /* No map data will follow, so don't say the client 1530 /* No map data will follow, so don't say the client
2148 * it doesn't need draw! 1531 * it doesn't need draw!
2149 */ 1532 */
2150 ewhatflag &= (~EMI_NOREDRAW); 1533 ewhatflag &= ~EMI_NOREDRAW;
2151 esl[ewhatstart + 1] = ewhatflag & 0xff; 1534 esl[ewhatstart + 1] = ewhatflag & 0xff;
2152 } 1535 }
2153 1536
2154 if (esl.length () > estartlen) 1537 if (esl.length () > estartlen)
2155 socket.send_packet (esl); 1538 socket.send_packet (esl);
… …
2167 */ 1550 */
2168void 1551void
2169draw_client_map (object *pl) 1552draw_client_map (object *pl)
2170{ 1553{
2171 int i, j; 1554 int i, j;
2172 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */ 1555 sint16 ax, ay; /* ax and ay goes from 0 to max-size of arrays */
2173 New_Face *face, *floor;
2174 New_Face *floor2;
2175 int d, mflags; 1556 int mflags;
2176 struct Map newmap; 1557 struct Map newmap;
2177 maptile *m, *pm; 1558 maptile *m, *pm;
2178 1559
2179 if (pl->type != PLAYER) 1560 if (pl->type != PLAYER)
2180 { 1561 {
… …
2191 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 1572 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2192 return; 1573 return;
2193 1574
2194 memset (&newmap, 0, sizeof (struct Map)); 1575 memset (&newmap, 0, sizeof (struct Map));
2195 1576
2196 for (j = (pl->y - pl->contr->socket->mapy / 2); j < (pl->y + (pl->contr->socket->mapy + 1) / 2); j++) 1577 for (j = (pl->y - pl->contr->ns->mapy / 2); j < (pl->y + (pl->contr->ns->mapy + 1) / 2); j++)
2197 {
2198 for (i = (pl->x - pl->contr->socket->mapx / 2); i < (pl->x + (pl->contr->socket->mapx + 1) / 2); i++) 1578 for (i = (pl->x - pl->contr->ns->mapx / 2); i < (pl->x + (pl->contr->ns->mapx + 1) / 2); i++)
2199 { 1579 {
2200 ax = i; 1580 ax = i;
2201 ay = j; 1581 ay = j;
2202 m = pm; 1582 m = pm;
2203 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay); 1583 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
1584
2204 if (mflags & P_OUT_OF_MAP) 1585 if (mflags & P_OUT_OF_MAP)
2205 continue; 1586 continue;
2206 if (mflags & P_NEED_UPDATE) 1587
2207 update_position (m, ax, ay);
2208 /* If a map is visible to the player, we don't want to swap it out 1588 /* If a map is visible to the player, we don't want to swap it out
2209 * just to reload it. This should really call something like 1589 * just to reload it. This should really call something like
2210 * swap_map, but this is much more efficient and 'good enough' 1590 * swap_map, but this is much more efficient and 'good enough'
2211 */ 1591 */
2212 if (mflags & P_NEW_MAP) 1592 if (mflags & P_NEW_MAP)
2213 m->timeout = 50; 1593 m->timeout = 50;
2214 } 1594 }
2215 } 1595
2216 /* do LOS after calls to update_position */ 1596 /* do LOS after calls to update_position */
2217 if (pl->contr->do_los) 1597 if (pl->contr->do_los)
2218 { 1598 {
2219 update_los (pl); 1599 update_los (pl);
2220 pl->contr->do_los = 0; 1600 pl->contr->do_los = 0;
… …
2235 1615
2236/*****************************************************************************/ 1616/*****************************************************************************/
2237void 1617void
2238send_plugin_custom_message (object *pl, char *buf) 1618send_plugin_custom_message (object *pl, char *buf)
2239{ 1619{
2240 pl->contr->socket->send_packet (buf); 1620 pl->contr->ns->send_packet (buf);
2241} 1621}
2242 1622
2243/** 1623/**
2244 * This sends the skill number to name mapping. We ignore 1624 * This sends the skill number to name mapping. We ignore
2245 * the params - we always send the same info no matter what. 1625 * the params - we always send the same info no matter what.
… …
2290 * it then sends an updspell packet for each spell that has changed in this way 1670 * it then sends an updspell packet for each spell that has changed in this way
2291 */ 1671 */
2292void 1672void
2293esrv_update_spells (player *pl) 1673esrv_update_spells (player *pl)
2294{ 1674{
1675 if (!pl->ns)
1676 return;
1677
2295 if (!pl->socket->monitor_spells) 1678 if (!pl->ns->monitor_spells)
2296 return; 1679 return;
2297 1680
2298 for (object *spell = pl->ob->inv; spell; spell = spell->below) 1681 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2299 { 1682 {
2300 if (spell->type == SPELL) 1683 if (spell->type == SPELL)
… …
2330 1713
2331 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1714 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2332 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1715 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2333 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1716 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2334 1717
2335 pl->socket->send_packet (sl); 1718 pl->ns->send_packet (sl);
2336 } 1719 }
2337 } 1720 }
2338 } 1721 }
2339} 1722}
2340 1723
2341void 1724void
2342esrv_remove_spell (player *pl, object *spell) 1725esrv_remove_spell (player *pl, object *spell)
2343{ 1726{
2344 if (!pl->socket->monitor_spells) 1727 if (!pl->ns->monitor_spells)
2345 return; 1728 return;
2346 1729
2347 if (!pl || !spell || spell->env != pl->ob) 1730 if (!pl || !spell || spell->env != pl->ob)
2348 { 1731 {
2349 LOG (llevError, "Invalid call to esrv_remove_spell"); 1732 LOG (llevError, "Invalid call to esrv_remove_spell");
2350 return; 1733 return;
2351 } 1734 }
2352 1735
2353 packet sl; 1736 packet sl ("delspell");
2354 1737
2355 sl << "delspell "
2356 << uint32 (spell->count); 1738 sl << uint32 (spell->count);
2357 1739
2358 pl->socket->send_packet (sl); 1740 pl->ns->send_packet (sl);
2359} 1741}
2360 1742
2361/* appends the spell *spell to the Socklist we will send the data to. */ 1743/* appends the spell *spell to the Socklist we will send the data to. */
2362static void 1744static void
2363append_spell (player *pl, packet &sl, object *spell) 1745append_spell (player *pl, packet &sl, object *spell)
2364{ 1746{
2365 int len, i, skill = 0; 1747 int i, skill = 0;
2366 1748
2367 if (!(spell->name)) 1749 if (!(spell->name))
2368 { 1750 {
2369 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1751 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2370 return; 1752 return;
… …
2382 if (!strcmp (spell->skill, skill_names[i])) 1764 if (!strcmp (spell->skill, skill_names[i]))
2383 { 1765 {
2384 skill = i + CS_STAT_SKILLINFO; 1766 skill = i + CS_STAT_SKILLINFO;
2385 break; 1767 break;
2386 } 1768 }
1769 }
1770
1771 // spells better have a face
1772 if (!spell->face)
1773 {
1774 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1775 spell->face = face_find ("burnout.x11", blank_face);
2387 } 1776 }
2388 1777
2389 /* send the current values */ 1778 /* send the current values */
2390 sl << uint32 (spell->count) 1779 sl << uint32 (spell->count)
2391 << uint16 (spell->level) 1780 << uint16 (spell->level)
… …
2393 << uint16 (spell->last_sp) 1782 << uint16 (spell->last_sp)
2394 << uint16 (spell->last_grace) 1783 << uint16 (spell->last_grace)
2395 << uint16 (spell->last_eat) 1784 << uint16 (spell->last_eat)
2396 << uint8 (skill) 1785 << uint8 (skill)
2397 << uint32 (spell->path_attuned) 1786 << uint32 (spell->path_attuned)
2398 << uint32 (spell->face ? spell->face->number : 0) 1787 << uint32 (spell->face)
2399 << data8 (spell->name) 1788 << data8 (spell->name)
2400 << data16 (spell->msg); 1789 << data16 (spell->msg);
2401} 1790}
2402 1791
2403/** 1792/**
… …
2411 { 1800 {
2412 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 1801 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2413 return; 1802 return;
2414 } 1803 }
2415 1804
2416 if (!pl->socket->monitor_spells) 1805 if (!pl->ns->monitor_spells)
2417 return; 1806 return;
2418 1807
2419 packet sl; 1808 packet sl ("addspell");
2420
2421 sl << "addspell ";
2422 1809
2423 if (!spell) 1810 if (!spell)
2424 { 1811 {
2425 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 1812 for (spell = pl->ob->inv; spell; spell = spell->below)
2426 { 1813 {
2427 /* were we to simply keep appending data here, we could exceed 1814 /* were we to simply keep appending data here, we could exceed
2428 * MAXSOCKBUF if the player has enough spells to add, we know that 1815 * MAXSOCKBUF if the player has enough spells to add, we know that
2429 * append_spells will always append 19 data bytes, plus 4 length 1816 * append_spells will always append 19 data bytes, plus 4 length
2430 * bytes and 3 strings (because that is the spec) so we need to 1817 * bytes and 3 strings (because that is the spec) so we need to
… …
2440 if (spell->type != SPELL) 1827 if (spell->type != SPELL)
2441 continue; 1828 continue;
2442 1829
2443 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1830 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2444 { 1831 {
2445 pl->socket->send_packet (sl); 1832 pl->ns->send_packet (sl);
2446 1833
2447 sl.reset (); 1834 sl.reset ();
2448 sl << "addspell "; 1835 sl << "addspell ";
2449 } 1836 }
2450 1837
… …
2464 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1851 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2465 fatal (0); 1852 fatal (0);
2466 } 1853 }
2467 1854
2468 /* finally, we can send the packet */ 1855 /* finally, we can send the packet */
2469 pl->socket->send_packet (sl); 1856 pl->ns->send_packet (sl);
2470} 1857}
2471 1858

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines