ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.45 by root, Tue Dec 19 04:58:05 2006 UTC vs.
Revision 1.131 by root, Tue May 20 13:25:55 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23 23
24/** 24/**
25 * \file 25 * \file
26 * Client handling. 26 * Client handling.
27 * 27 *
… …
35 * have the prototype of (char *data, int datalen, int client_num). This 35 * have the prototype of (char *data, int datalen, int client_num). This
36 * way, we can use one dispatch table. 36 * way, we can use one dispatch table.
37 * 37 *
38 * esrv_map_new starts updating the map 38 * esrv_map_new starts updating the map
39 * 39 *
40 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now.
42 *
43 */ 40 */
44 41
45#include <global.h> 42#include <global.h>
46#include <sproto.h> 43#include <sproto.h>
47 44
… …
100 * that much difference in bandwidth. 97 * that much difference in bandwidth.
101 */ 98 */
102 mx = ns->mapx; 99 mx = ns->mapx;
103 my = ns->mapy; 100 my = ns->mapy;
104 101
105 if (ns->mapmode == Map1aCmd)
106 {
107 mx += MAX_HEAD_OFFSET;
108 my += MAX_HEAD_OFFSET;
109 }
110
111 /* the x and y here are coordinates for the new map, i.e. if we moved 102 /* the x and y here are coordinates for the new map, i.e. if we moved
112 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 103 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
113 * if the destination x or y coordinate is outside the viewable 104 * if the destination x or y coordinate is outside the viewable
114 * area, we clear the values - otherwise, the old values 105 * area, we clear the values - otherwise, the old values
115 * are preserved, and the check_head thinks it needs to clear them. 106 * are preserved, and the check_head thinks it needs to clear them.
… …
138} 129}
139 130
140static void 131static void
141clear_map (player *pl) 132clear_map (player *pl)
142{ 133{
134 pl->ns->mapinfo_queue_clear ();
135
136 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
137
138 pl->ns->force_newmap = false;
139
140 if (pl->ns->newmapcmd == 1)
141 pl->ns->send_packet ("newmap");
142
143 pl->ns->floorbox_reset ();
144}
145
146static void
147send_map_info (player *pl)
148{
143 client &socket = *pl->socket; 149 client &socket = *pl->ns;
150 object *ob = pl->observe;
144 151
145 memset (&socket.lastmap, 0, sizeof (socket.lastmap));
146
147 if (socket.newmapcmd == 1) 152 if (socket.mapinfocmd)
153 {
154 if (ob->map && ob->map->path[0])
155 {
156 int flags = 0;
157
158 if (ob->map->tile_path[0]) flags |= 1;
159 if (ob->map->tile_path[1]) flags |= 2;
160 if (ob->map->tile_path[2]) flags |= 4;
161 if (ob->map->tile_path[3]) flags |= 8;
162
163 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
164 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
165 ob->map->width, ob->map->height, &ob->map->path);
166 }
167 else
148 socket.send_packet ("newmap"); 168 socket.send_packet ("mapinfo current");
149 169 }
150 socket.update_look = 1;
151 socket.look_position = 0;
152} 170}
153 171
154/** check for map change and send new map data */ 172/** check for map/region change and send new map data */
155static void 173static void
156check_map_change (player *pl) 174check_map_change (player *pl)
157{ 175{
158 client &socket = *pl->socket; 176 client &socket = *pl->ns;
159 object *ob = pl->ob; 177 object *ob = pl->observe;
160 char buf[MAX_BUF]; /* eauugggh */
161 178
162 if (socket.current_map != ob->map) 179 region *reg = ob->region ();
180 if (socket.current_region != reg)
181 {
182 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
183 socket.current_region = reg;
163 { 184 }
185
186 // first try to aovid a full newmap on tiled map scrolls
187 if (socket.current_map != ob->map && !socket.force_newmap)
188 {
189 rv_vector rv;
190
191 get_rangevector_from_mapcoord (socket.current_map, socket.current_x, socket.current_y, ob, &rv, 0);
192
193 // manhattan distance is very handy here
194 if (rv.distance < 8) // 8 works nicely for speed << 70 and buggy gcfclient
195 {
196 socket.current_map = ob->map;
197 socket.current_x = ob->x;
198 socket.current_y = ob->y;
199
200 socket_map_scroll (&socket, rv.distance_x, rv.distance_y);
201 socket.floorbox_reset ();
202 send_map_info (pl);
203 }
204 }
205
206 if (socket.current_map != ob->map || socket.force_newmap)
207 {
208 clear_map (pl);
164 socket.current_map = ob->map; 209 socket.current_map = ob->map;
165 210 send_map_info (pl);
166 clear_map (pl);
167
168 if (socket.mapinfocmd)
169 {
170 if (ob->map && ob->map->path[0])
171 {
172 int flags = 0;
173
174 if (ob->map->tile_path[0])
175 flags |= 1;
176 if (ob->map->tile_path[1])
177 flags |= 2;
178 if (ob->map->tile_path[2])
179 flags |= 4;
180 if (ob->map->tile_path[3])
181 flags |= 8;
182
183 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s",
184 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path);
185 }
186 else
187 snprintf (buf, MAX_BUF, "mapinfo current");
188
189 socket.send_packet (buf);
190 }
191 } 211 }
192 else if (socket.current_x != ob->x || socket.current_y != ob->y) 212 else if (socket.current_x != ob->x || socket.current_y != ob->y)
193 { 213 {
194 int dx = ob->x - socket.current_x; 214 int dx = ob->x - socket.current_x;
195 int dy = ob->y - socket.current_y; 215 int dy = ob->y - socket.current_y;
… …
197 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8)) 217 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
198 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows 218 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
199 else 219 else
200 { 220 {
201 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 221 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
202 socket.update_look = 1; 222 socket.floorbox_reset ();
203 socket.look_position = 0;
204 } 223 }
205 } 224 }
206 225
207 socket.current_x = ob->x; 226 socket.current_x = ob->x;
208 socket.current_y = ob->y; 227 socket.current_y = ob->y;
… …
212 * RequestInfo is sort of a meta command. There is some specific 231 * RequestInfo is sort of a meta command. There is some specific
213 * request of information, but we call other functions to provide 232 * request of information, but we call other functions to provide
214 * that information. 233 * that information.
215 */ 234 */
216void 235void
217RequestInfo (char *buf, int len, client * ns) 236RequestInfo (char *buf, int len, client *ns)
218{ 237{
219 char *params = NULL, *cp; 238 char *params;
220
221 /* No match */
222 char bigbuf[MAX_BUF];
223 int slen;
224
225 /* Set up replyinfo before we modify any of the buffers - this is used
226 * if we don't find a match.
227 */
228 strcpy (bigbuf, "replyinfo ");
229 slen = strlen (bigbuf);
230 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
231 239
232 /* find the first space, make it null, and update the 240 /* find the first space, make it null, and update the
233 * params pointer. 241 * params pointer.
234 */ 242 */
235 for (cp = buf; *cp != '\0'; cp++) 243 for (params = buf; *params; params++)
236 if (*cp == ' ') 244 if (*params == ' ')
237 { 245 {
238 *cp = '\0';
239 params = cp + 1; 246 *params++ = 0;
240 break; 247 break;
241 } 248 }
242 249
243 if (!strcmp (buf, "image_info")) 250 if (!strcmp (buf, "image_info"))
244 send_image_info (ns, params); 251 send_image_info (ns, params);
… …
247 else if (!strcmp (buf, "skill_info")) 254 else if (!strcmp (buf, "skill_info"))
248 send_skill_info (ns, params); 255 send_skill_info (ns, params);
249 else if (!strcmp (buf, "spell_paths")) 256 else if (!strcmp (buf, "spell_paths"))
250 send_spell_paths (ns, params); 257 send_spell_paths (ns, params);
251 else 258 else
252 ns->send_packet (bigbuf, len); 259 {
260 // undo tokenisation above and send replyinfo with the request unchanged
261 if (*params)
262 *--params = ' ';
263
264 ns->send_packet_printf ("replyinfo %s", buf);
265 }
253} 266}
254 267
255void 268void
256ExtCmd (char *buf, int len, player *pl) 269ExtCmd (char *buf, int len, player *pl)
257{ 270{
… …
260 273
261void 274void
262ExtiCmd (char *buf, int len, client *ns) 275ExtiCmd (char *buf, int len, client *ns)
263{ 276{
264 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len)); 277 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
278}
279
280void
281client::mapinfo_queue_clear ()
282{
283 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
284 free (*i);
285
286 mapinfo_queue.clear ();
287}
288
289bool
290client::mapinfo_try (char *buf)
291{
292 char *token = buf;
293 buf += strlen (buf) + 9;
294
295 // initial map and its origin
296 maptile *map = pl->observe->map;
297 int mapx = pl->ns->mapx / 2 - pl->observe->x;
298 int mapy = pl->ns->mapy / 2 - pl->observe->y;
299 int max_distance = 8; // limit maximum path length to something generous
300
301 while (*buf && map && max_distance)
302 {
303 int dir = *buf++ - '1';
304
305 if (dir >= 0 && dir <= 3)
306 {
307 if (!map->tile_path [dir])
308 map = 0;
309 else if (map->tile_available (dir, false))
310 {
311 maptile *neigh = map->tile_map [dir];
312
313 switch (dir)
314 {
315 case 0: mapy -= neigh->height; break;
316 case 2: mapy += map ->height; break;
317 case 3: mapx -= neigh->width ; break;
318 case 1: mapx += map ->width ; break;
319 }
320
321 map = neigh;
322 --max_distance;
323 }
324 else
325 return 0;
326 }
327 else
328 max_distance = 0;
329 }
330
331 if (!max_distance)
332 send_packet_printf ("mapinfo %s error", token);
333 else if (!map || !map->path)
334 send_packet_printf ("mapinfo %s nomap", token);
335 else
336 {
337 int flags = 0;
338
339 if (map->tile_path[0]) flags |= 1;
340 if (map->tile_path[1]) flags |= 2;
341 if (map->tile_path[2]) flags |= 4;
342 if (map->tile_path[3]) flags |= 8;
343
344 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
345 }
346
347 return 1;
348}
349
350void
351client::mapinfo_queue_run ()
352{
353 if (mapinfo_queue.empty () || !pl)
354 return;
355
356 for (int i = 0; i < mapinfo_queue.size (); ++i)
357 if (mapinfo_try (mapinfo_queue [i]))
358 {
359 free (mapinfo_queue [i]);
360 mapinfo_queue.erase (i);
361 }
362 else
363 ++i;
265} 364}
266 365
267void 366void
268MapInfoCmd (char *buf, int len, player *pl) 367MapInfoCmd (char *buf, int len, player *pl)
269{ 368{
270 // <mapinfo tag spatial tile-path 369 // <mapinfo tag spatial tile-path
271 // >mapinfo tag spatial flags x y w h hash 370 // >mapinfo tag spatial flags x y w h hash
272 371
273 char bigbuf[MAX_BUF], *token;
274
275 token = buf; 372 char *token = buf;
276 // copy token 373
277 if (!(buf = strchr (buf, ' '))) 374 if (!(buf = strchr (buf, ' ')))
278 return; 375 return;
279 376
280 *buf++ = 0;
281
282 if (!strncmp (buf, "spatial ", 8)) 377 if (!strncmp (buf, " spatial ", 9))
283 { 378 {
284 buf += 8; 379 char *copy = strdup (token);
380 copy [buf - token] = 0;
285 381
286 // initial map and its origin 382#if 0
287 maptile *map = pl->ob->map; 383 // this makes only sense when we flush the buffer immediately
288 sint16 dx, dy; 384 if (pl->ns->mapinfo_try (copy))
289 int mapx = pl->socket->mapx / 2 - pl->ob->x; 385 free (copy);
290 int mapy = pl->socket->mapy / 2 - pl->ob->y;
291 int max_distance = 8; // limit maximum path length to something generous
292
293 while (*buf && map && max_distance)
294 {
295 int dir = *buf++;
296
297 switch (dir)
298 {
299 case '1':
300 dx = 0;
301 dy = -1;
302 map = get_map_from_coord (map, &dx, &dy);
303 map && (mapy -= map->height);
304 break;
305 case '2':
306 mapx += map->width;
307 dx = map->width;
308 dy = 0;
309 map = get_map_from_coord (map, &dx, &dy);
310 break;
311 case '3':
312 mapy += map->height;
313 dx = 0;
314 dy = map->height;
315 map = get_map_from_coord (map, &dx, &dy);
316 break;
317 case '4':
318 dx = -1;
319 dy = 0;
320 map = get_map_from_coord (map, &dx, &dy);
321 map && (mapx -= map->width);
322 break;
323 }
324
325 --max_distance;
326 }
327
328 if (!max_distance)
329 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
330 else if (map && map->path[0])
331 {
332 int flags = 0;
333
334 if (map->tile_path[0])
335 flags |= 1;
336 if (map->tile_path[1])
337 flags |= 2;
338 if (map->tile_path[2])
339 flags |= 4;
340 if (map->tile_path[3])
341 flags |= 8;
342
343 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, map->path);
344 }
345 else 386 else
346 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 387#endif
388 pl->ns->mapinfo_queue.push_back (copy);
347 } 389 }
348 else 390 else
349 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 391 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
350
351 pl->socket->send_packet (bigbuf);
352} 392}
353 393
354/** This is the Setup cmd - easy first implementation */ 394/** This is the Setup cmd */
355void 395void
356SetUp (char *buf, int len, client * ns) 396SetUp (char *buf, int len, client * ns)
357{ 397{
358 int s, slen; 398 INVOKE_CLIENT (SETUP, ns, ARG_DATA (buf, len));
359 char *cmd, *param, cmdback[HUGE_BUF];
360
361 /* run through the cmds of setup
362 * syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
363 *
364 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
365 * The client then must sort this out
366 */
367
368 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
369
370 strcpy (cmdback, "setup");
371 for (s = 0; s < len; )
372 {
373 cmd = &buf[s];
374
375 /* find the next space, and put a null there */
376 for (; buf[s] && buf[s] != ' '; s++)
377 ;
378
379 buf[s++] = 0;
380
381 while (buf[s] == ' ')
382 s++;
383
384 if (s >= len)
385 break;
386
387 param = &buf[s];
388
389 for (; buf[s] && buf[s] != ' '; s++)
390 ;
391
392 buf[s++] = 0;
393
394 while (buf[s] == ' ')
395 s++;
396
397 slen = strlen (cmdback);
398 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
399 safe_strcat (cmdback, cmd, &slen, HUGE_BUF);
400 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
401
402 if (!strcmp (cmd, "sound"))
403 {
404 ns->sound = atoi (param);
405 safe_strcat (cmdback, param, &slen, HUGE_BUF);
406 }
407 else if (!strcmp (cmd, "exp64"))
408 {
409 ns->exp64 = atoi (param);
410 safe_strcat (cmdback, param, &slen, HUGE_BUF);
411 }
412 else if (!strcmp (cmd, "spellmon"))
413 {
414 ns->monitor_spells = atoi (param);
415 safe_strcat (cmdback, param, &slen, HUGE_BUF);
416 }
417 else if (!strcmp (cmd, "darkness"))
418 {
419 ns->darkness = atoi (param);
420 safe_strcat (cmdback, param, &slen, HUGE_BUF);
421 }
422 else if (!strcmp (cmd, "map1cmd"))
423 {
424 if (atoi (param))
425 ns->mapmode = Map1Cmd;
426 /* if beyond this size, need to use map1cmd no matter what */
427 if (ns->mapx > 11 || ns->mapy > 11)
428 ns->mapmode = Map1Cmd;
429 safe_strcat (cmdback, ns->mapmode == Map1Cmd ? "1" : "0", &slen, HUGE_BUF);
430 }
431 else if (!strcmp (cmd, "map1acmd"))
432 {
433 if (atoi (param))
434 ns->mapmode = Map1aCmd;
435 /* if beyond this size, need to use map1acmd no matter what */
436 if (ns->mapx > 11 || ns->mapy > 11)
437 ns->mapmode = Map1aCmd;
438 safe_strcat (cmdback, ns->mapmode == Map1aCmd ? "1" : "0", &slen, HUGE_BUF);
439 }
440 else if (!strcmp (cmd, "newmapcmd"))
441 {
442 ns->newmapcmd = atoi (param);
443 safe_strcat (cmdback, param, &slen, HUGE_BUF);
444// } else if (!strcmp(cmd,"plugincmd")) {
445// ns->plugincmd = atoi(param);
446// safe_strcat(cmdback, param, &slen, HUGE_BUF);
447 }
448 else if (!strcmp (cmd, "mapinfocmd"))
449 {
450 ns->mapinfocmd = atoi (param);
451 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
452 }
453 else if (!strcmp (cmd, "extcmd"))
454 {
455 ns->extcmd = atoi (param);
456 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
457 }
458 else if (!strcmp (cmd, "extmap"))
459 {
460 ns->extmap = atoi (param);
461 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
462 }
463 else if (!strcmp (cmd, "facecache"))
464 {
465 ns->facecache = atoi (param);
466 safe_strcat (cmdback, param, &slen, HUGE_BUF);
467 }
468 else if (!strcmp (cmd, "faceset"))
469 {
470 char tmpbuf[20];
471 int q = atoi (param);
472
473 if (is_valid_faceset (q))
474 ns->faceset = q;
475 sprintf (tmpbuf, "%d", ns->faceset);
476 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
477 /* if the client is using faceset, it knows about image2 command */
478 ns->image2 = 1;
479 }
480 else if (!strcmp (cmd, "itemcmd"))
481 {
482 /* Version of the item protocol command to use. Currently,
483 * only supported versions are 1 and 2. Using a numeric
484 * value will make it very easy to extend this in the future.
485 */
486 char tmpbuf[20];
487 int q = atoi (param);
488
489 if (q < 1 || q > 2)
490 {
491 strcpy (tmpbuf, "FALSE");
492 }
493 else
494 {
495 ns->itemcmd = q;
496 sprintf (tmpbuf, "%d", ns->itemcmd);
497 }
498 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
499 }
500 else if (!strcmp (cmd, "mapsize"))
501 {
502 int x, y = 0;
503 char tmpbuf[MAX_BUF], *cp;
504
505 x = atoi (param);
506 for (cp = param; *cp != 0; cp++)
507 if (*cp == 'x' || *cp == 'X')
508 {
509 y = atoi (cp + 1);
510 break;
511 }
512 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
513 {
514 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
515 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
516 }
517 else
518 {
519 ns->mapx = x;
520 ns->mapy = y;
521 /* better to send back what we are really using and not the
522 * param as given to us in case it gets parsed differently.
523 */
524 sprintf (tmpbuf, "%dx%d", x, y);
525 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
526 /* If beyond this size and still using orig map command, need to
527 * go to map1cmd.
528 */
529 if ((x > 11 || y > 11) && ns->mapmode == Map0Cmd)
530 ns->mapmode = Map1Cmd;
531 }
532 }
533 else if (!strcmp (cmd, "extendedMapInfos"))
534 {
535 /* Added by tchize
536 * prepare to use the mapextended command
537 */
538 char tmpbuf[20];
539
540 ns->ext_mapinfos = (atoi (param));
541 sprintf (tmpbuf, "%d", ns->ext_mapinfos);
542 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
543 }
544 else if (!strcmp (cmd, "extendedTextInfos"))
545 {
546 /* Added by tchize
547 * prepare to use the extended text commands
548 * Client toggle this to non zero to get exttext
549 */
550 char tmpbuf[20];
551
552 ns->has_readable_type = (atoi (param));
553 sprintf (tmpbuf, "%d", ns->has_readable_type);
554 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
555 }
556 else
557 {
558 /* Didn't get a setup command we understood -
559 * report a failure to the client.
560 */
561 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
562 }
563 } /* for processing all the setup commands */
564
565 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
566 ns->send_packet (cmdback);
567} 399}
568 400
569/** 401/**
570 * The client has requested to be added to the game. 402 * The client has requested to be added to the game.
571 * This is what takes care of it. We tell the client how things worked out. 403 * This is what takes care of it. We tell the client how things worked out.
572 * I am not sure if this file is the best place for this function. however, 404 * I am not sure if this file is the best place for this function. however,
573 * it either has to be here or init_sockets needs to be exported. 405 * it either has to be here or init_sockets needs to be exported.
574 */ 406 */
575void 407void
576AddMeCmd (char *buf, int len, client * ns) 408AddMeCmd (char *buf, int len, client *ns)
577{ 409{
578 if (ns->status != Ns_Add || add_player (ns)) 410 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
579 ns->send_packet ("addme_failed");
580 else
581 ns->send_packet ("addme_success");
582} 411}
583 412
584/** Reply to ExtendedInfos command */ 413/** Reply to ExtendedInfos command */
585void 414void
586ToggleExtendedInfos (char *buf, int len, client * ns) 415ToggleExtendedInfos (char *buf, int len, client * ns)
… …
696 525
697 ns->send_packet (cmdback); 526 ns->send_packet (cmdback);
698} 527}
699 528
700/** 529/**
701 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
702 * Basically, it makes no sense to wait for the client to request a
703 * a piece of data from us that we know the client wants. So
704 * if we know the client wants it, might as well push it to the
705 * client.
706 */
707static void
708SendSmooth (client *ns, uint16 face)
709{
710 uint16 smoothface;
711
712 /* If we can't find a face, return and set it so we won't try to send this
713 * again.
714 */
715 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
716 {
717
718 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name);
719 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
720 return;
721 }
722
723 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
724 esrv_send_face (ns, smoothface, 0);
725
726 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
727
728 packet sl;
729
730 sl << "smooth "
731 << uint16 (face)
732 << uint16 (smoothface);
733
734 ns->send_packet (sl);
735}
736
737 /**
738 * Tells client the picture it has to use
739 * to smooth a picture number given as argument.
740 */
741void
742AskSmooth (char *buf, int len, client *ns)
743{
744 SendSmooth (ns, atoi (buf));
745}
746
747/**
748 * This handles the general commands from the client (ie, north, fire, cast, 530 * This handles the general commands from the client (ie, north, fire, cast,
749 * etc.) 531 * etc.)
750 */ 532 */
751void 533void
752PlayerCmd (char *buf, int len, player *pl) 534PlayerCmd (char *buf, int len, player *pl)
… …
773 * commands. 555 * commands.
774 */ 556 */
775 pl->count = 0; 557 pl->count = 0;
776} 558}
777 559
778
779/** 560/**
780 * This handles the general commands from the client (ie, north, fire, cast, 561 * This handles the general commands from the client (ie, north, fire, cast,
781 * etc.). It is a lot like PlayerCmd above, but is called with the 562 * etc.). It is a lot like PlayerCmd above, but is called with the
782 * 'ncom' method which gives more information back to the client so it 563 * 'ncom' method which gives more information back to the client so it
783 * can throttle. 564 * can throttle.
… …
785void 566void
786NewPlayerCmd (char *buf, int len, player *pl) 567NewPlayerCmd (char *buf, int len, player *pl)
787{ 568{
788 if (len <= 6) 569 if (len <= 6)
789 { 570 {
790 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 571 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
791 return; 572 return;
792 } 573 }
793 574
794 uint16 cmdid = net_uint16 ((uint8 *)buf); 575 uint16 cmdid = net_uint16 ((uint8 *)buf);
795 sint32 repeat = net_sint32 ((uint8 *)buf + 2); 576 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
… …
808 * commands. 589 * commands.
809 */ 590 */
810 pl->count = 0; 591 pl->count = 0;
811 592
812 //TODO: schmorp thinks whatever this calculates, it makes no sense at all 593 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
813 int time = FABS (pl->ob->speed) < 0.001 594 int time = fabs (pl->ob->speed) < 0.001
814 ? time = MAX_TIME * 100 595 ? time = MAX_TIME * 100
815 : time = (int) (MAX_TIME / FABS (pl->ob->speed)); 596 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
816 597
817 /* Send confirmation of command execution now */ 598 /* Send confirmation of command execution now */
818 packet sl; 599 packet sl ("comc");
819 sl << "comc " << uint16 (cmdid) << uint32 (time); 600 sl << uint16 (cmdid) << uint32 (time);
820 pl->socket->send_packet (sl); 601 pl->ns->send_packet (sl);
821} 602}
822
823 603
824/** This is a reply to a previous query. */ 604/** This is a reply to a previous query. */
825void 605void
826ReplyCmd (char *buf, int len, player *pl) 606ReplyCmd (char *buf, int len, client *ns)
827{ 607{
608 if (ns->state == ST_CUSTOM)
609 {
610 INVOKE_CLIENT (REPLY, ns, ARG_DATA (buf, len));
611 return;
612 }
613
614 if (!ns->pl)
615 return; //TODO: depends on the exact reply we are after
616 //TODO: but right now, we always have a ns->pl
617
618 player *pl = ns->pl;
619
828 /* This is to synthesize how the data would be stored if it 620 /* This is to synthesize how the data would be stored if it
829 * was normally entered. A bit of a hack, and should be cleaned up 621 * was normally entered. A bit of a hack, and should be cleaned up
830 * once all the X11 code is removed from the server. 622 * once all the X11 code is removed from the server.
831 * 623 *
832 * We pass 13 to many of the functions because this way they 624 * We pass 13 to many of the functions because this way they
… …
835 */ 627 */
836 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf); 628 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
837 629
838 /* this avoids any hacking here */ 630 /* this avoids any hacking here */
839 631
840 switch (pl->state) 632 switch (ns->state)
841 { 633 {
842 case ST_PLAYING: 634 case ST_PLAYING:
843 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 635 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
844 break; 636 break;
845 637
846 case ST_PLAY_AGAIN:
847 /* We can check this for return value (2==quit). Maybe we
848 * should, and do something appropriate?
849 */
850 receive_play_again (pl->ob, buf[0]);
851 break;
852
853 case ST_ROLL_STAT:
854 key_roll_stat (pl->ob, buf[0]);
855 break;
856
857 case ST_CHANGE_CLASS:
858
859 key_change_class (pl->ob, buf[0]);
860 break;
861
862 case ST_CONFIRM_QUIT:
863 key_confirm_quit (pl->ob, buf[0]);
864 break;
865
866 case ST_CONFIGURE:
867 LOG (llevError, "In client input handling, but into configure state\n");
868 pl->state = ST_PLAYING;
869 break;
870
871 case ST_GET_NAME:
872 receive_player_name (pl->ob, 13);
873 break;
874
875 case ST_GET_PASSWORD:
876 case ST_CONFIRM_PASSWORD:
877 receive_player_password (pl->ob, 13);
878 break;
879
880 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 638 case ST_GET_PARTY_PASSWORD: /* Get password for party */
881 receive_party_password (pl->ob, 13); 639 receive_party_password (pl->ob, 13);
882 break; 640 break;
883 641
884 default: 642 default:
885 LOG (llevError, "Unknown input state: %d\n", pl->state); 643 LOG (llevError, "Unknown input state: %d\n", ns->state);
886 } 644 }
887} 645}
888 646
889/** 647/**
890 * Client tells its version. If there is a mismatch, we close the 648 * Client tells its version. If there is a mismatch, we close the
… …
905 ns->cs_version = atoi (buf); 663 ns->cs_version = atoi (buf);
906 ns->sc_version = ns->cs_version; 664 ns->sc_version = ns->cs_version;
907 665
908 LOG (llevDebug, "connection from client <%s>\n", buf); 666 LOG (llevDebug, "connection from client <%s>\n", buf);
909 667
910
911 //TODO: should log here just for statistics 668 //TODO: should log here just for statistics
912 669
913 //if (VERSION_CS != ns->cs_version) 670 //if (VERSION_CS != ns->cs_version)
914 // unchecked; 671 // unchecked;
915 672
… …
924 681
925 cp = strchr (cp + 1, ' '); 682 cp = strchr (cp + 1, ' ');
926 683
927 if (cp) 684 if (cp)
928 { 685 {
929 assign (ns->version, cp + 1); 686 ns->version = cp + 1;
930 687
931 if (ns->sc_version < 1026) 688 if (ns->sc_version < 1026)
932 ns->send_packet_printf ("drawinfo %d %s", NDI_RED, 689 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
933 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 690 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
934 } 691 }
… …
940{ 697{
941 ns->sound = atoi (buf); 698 ns->sound = atoi (buf);
942} 699}
943 700
944/** client wants the map resent */ 701/** client wants the map resent */
945
946void 702void
947MapRedrawCmd (char *buf, int len, player *pl) 703MapRedrawCmd (char *buf, int len, player *pl)
948{ 704{
949/* This function is currently disabled; just clearing the map state results in 705/* This function is currently disabled; just clearing the map state results in
950 * display errors. It should clear the cache and send a newmap command. 706 * display errors. It should clear the cache and send a newmap command.
… …
958 * syntax is: move (to) (tag) (nrof) 714 * syntax is: move (to) (tag) (nrof)
959 */ 715 */
960void 716void
961MoveCmd (char *buf, int len, player *pl) 717MoveCmd (char *buf, int len, player *pl)
962{ 718{
963 int vals[3], i; 719 int to, tag, nrof;
964 720
965 /* A little funky here. We only cycle for 2 records, because 721 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
966 * we obviously are not going to find a space after the third
967 * record. Perhaps we should just replace this with a
968 * sscanf?
969 */
970 for (i = 0; i < 2; i++)
971 { 722 {
972 vals[i] = atoi (buf);
973
974 if (!(buf = strchr (buf, ' ')))
975 {
976 LOG (llevError, "Incomplete move command: %s\n", buf); 723 LOG (llevError, "Incomplete move command: %s\n", buf);
977 return; 724 return;
978 }
979
980 buf++;
981 } 725 }
982 726
983 vals[2] = atoi (buf); 727 esrv_move_object (pl->ob, to, tag, nrof);
984
985/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
986 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
987} 728}
988 729
989/****************************************************************************** 730/******************************************************************************
990 * 731 *
991 * Start of commands the server sends to the client. 732 * Start of commands the server sends to the client.
… …
995/** 736/**
996 * Asks the client to query the user. This way, the client knows 737 * Asks the client to query the user. This way, the client knows
997 * it needs to send something back (vs just printing out a message) 738 * it needs to send something back (vs just printing out a message)
998 */ 739 */
999void 740void
1000send_query (client *ns, uint8 flags, char *text) 741send_query (client *ns, uint8 flags, const char *text)
1001{ 742{
1002 ns->send_packet_printf ("query %d %s", flags, text ? text : ""); 743 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
744}
745
746/**
747 * Get player's current range attack in obuf.
748 */
749static void
750rangetostring (player *pl, char *obuf)
751{
752 dynbuf_text buf;
753
754 if (pl->ranged_ob)
755 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name;
756
757 if (pl->combat_ob)
758 buf << " Combat" << (pl->ob->current_weapon == pl->combat_ob ? "*" : "") << ": " << pl->combat_ob->name;
759
760#if 0
761 //TODO: remove this when slot system is working, this is only for debugging
762 if (pl->ob->chosen_skill)
763 buf << " Skill*: " << pl->ob->chosen_skill->name;
764#endif
765
766 //TODO: maybe golem should become the current_weapon, quite simply?
767 if (pl->golem)
768 buf << " Golem*: " << pl->golem->name;
769
770 buf << '\0';
771 buf.linearise (obuf);
1003} 772}
1004 773
1005#define AddIfInt64(Old,New,Type) if (Old != New) {\ 774#define AddIfInt64(Old,New,Type) if (Old != New) {\
1006 Old = New; \ 775 Old = New; \
1007 sl << uint8 (Type) << uint64 (New); \ 776 sl << uint8 (Type) << uint64 (New); \
… …
1015#define AddIfShort(Old,New,Type) if (Old != New) {\ 784#define AddIfShort(Old,New,Type) if (Old != New) {\
1016 Old = New; \ 785 Old = New; \
1017 sl << uint8 (Type) << uint16 (New); \ 786 sl << uint8 (Type) << uint16 (New); \
1018 } 787 }
1019 788
1020#define AddIfFloat(Old,New,Type) if (Old != New) {\ 789#define AddIfFloat(Old,New,Type,mult) if (Old != New) {\
1021 Old = New; \ 790 Old = New; \
1022 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \ 791 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI*mult); \
1023 } 792 }
1024 793
1025#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 794#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1026 free(Old); Old = strdup (New);\ 795 free(Old); Old = strdup (New);\
1027 sl << uint8 (Type) << data8 (New); \ 796 sl << uint8 (Type) << data8 (New); \
… …
1037esrv_update_stats (player *pl) 806esrv_update_stats (player *pl)
1038{ 807{
1039 char buf[MAX_BUF]; 808 char buf[MAX_BUF];
1040 uint16 flags; 809 uint16 flags;
1041 810
1042 packet sl; 811 client *ns = pl->ns;
1043 sl << "stats "; 812 if (!ns)
813 return;
1044 814
815 object *ob = pl->observe;
1045 if (pl->ob) 816 if (!ob)
1046 { 817 return;
818
819 player *opl = ob->contr ? static_cast<player *>(ob->contr) : pl;
820
821 packet sl ("stats");
822
1047 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 823 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1048 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 824 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1049 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 825 AddIfShort (ns->last_stats.sp, ob->stats.sp, CS_STAT_SP);
1050 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 826 AddIfShort (ns->last_stats.maxsp, ob->stats.maxsp, CS_STAT_MAXSP);
1051 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 827 AddIfShort (ns->last_stats.grace, ob->stats.grace, CS_STAT_GRACE);
1052 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 828 AddIfShort (ns->last_stats.maxgrace, ob->stats.maxgrace, CS_STAT_MAXGRACE);
1053 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 829 AddIfShort (ns->last_stats.Str, ob->stats.Str, CS_STAT_STR);
1054 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT);
1055 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW);
1056 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1057 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 830 AddIfShort (ns->last_stats.Dex, ob->stats.Dex, CS_STAT_DEX);
1058 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 831 AddIfShort (ns->last_stats.Con, ob->stats.Con, CS_STAT_CON);
832 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
833 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
834 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1059 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 835 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1060 }
1061 836
1062 if (pl->socket->exp64)
1063 for (int s = 0; s < NUM_SKILLS; s++) 837 for (int s = 0; s < NUM_SKILLS; s++)
1064 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 838 if (object *skill = opl->last_skill_ob[s])
839 if (skill->stats.exp != ns->last_skill_exp [s])
1065 { 840 {
841 ns->last_skill_exp [s] = skill->stats.exp;
842
1066 /* Always send along the level if exp changes. This is only 843 /* Always send along the level if exp changes. This is only
1067 * 1 extra byte, but keeps processing simpler. 844 * 1 extra byte, but keeps processing simpler.
1068 */ 845 */
1069 sl << uint8 (s + CS_STAT_SKILLINFO) 846 sl << uint8 (s + CS_STAT_SKILLINFO)
1070 << uint8 (pl->last_skill_ob[s]->level) 847 << uint8 (skill->level)
1071 << uint64 (pl->last_skill_ob[s]->stats.exp); 848 << uint64 (skill->stats.exp);
1072
1073 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1074 } 849 }
1075 850
1076 if (pl->socket->exp64)
1077 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) } 851 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
1078 else
1079 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1080
1081 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 852 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
1082 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 853 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
1083 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 854 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
1084 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 855 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
1085 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 856 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED, 1.f/TICK);
1086 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 857 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
1087 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 858 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP, 1.f/TICK);
1088 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 859 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
860
1089 flags = 0; 861 flags = 0;
1090 862
1091 if (pl->fire_on) 863 if (opl->fire_on)
1092 flags |= SF_FIREON; 864 flags |= SF_FIREON;
1093 865
1094 if (pl->run_on) 866 if (opl->run_on)
1095 flags |= SF_RUNON; 867 flags |= SF_RUNON;
1096 868
1097 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 869 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
1098 870
1099 if (pl->socket->sc_version < 1025) 871 if (ns->sc_version < 1025)
1100 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) } 872 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1101 else 873 else
1102 for (int i = 0; i < NROFATTACKS; i++) 874 for (int i = 0; i < NROFATTACKS; i++)
1103 { 875 {
1104 /* Skip ones we won't send */ 876 /* Skip ones we won't send */
1105 if (atnr_cs_stat[i] == -1) 877 if (atnr_cs_stat[i] == -1)
1106 continue; 878 continue;
1107 879
1108 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 880 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
1109 } 881 }
1110 882
1111 if (pl->socket->monitor_spells) 883 if (pl->ns->monitor_spells)
1112 { 884 {
1113 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 885 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1114 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 886 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1115 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 887 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1116 } 888 }
1117 889
1118 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 890 rangetostring (opl, buf); /* we want use the new fire & run system in new client */
1119 AddIfString (pl->socket->stats.range, buf, CS_STAT_RANGE); 891 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1120 set_title (pl->ob, buf); 892 set_title (ob, buf);
1121 AddIfString (pl->socket->stats.title, buf, CS_STAT_TITLE); 893 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1122 894
1123 /* Only send it away if we have some actual data */ 895 /* Only send it away if we have some actual data */
1124 if (sl.length () > 6) 896 if (sl.length () > 6)
1125 pl->socket->send_packet (sl); 897 ns->send_packet (sl);
1126} 898}
1127 899
1128/** 900/**
1129 * Tells the client that here is a player it should start using. 901 * Tells the client that here is a player it should start using.
1130 */ 902 */
1131void 903void
1132esrv_new_player (player *pl, uint32 weight) 904esrv_new_player (player *pl)
1133{ 905{
1134 pl->last_weight = weight; 906 sint32 weight = pl->ob->client_weight ();
1135 907
1136 packet sl; 908 packet sl ("player");
1137 sl << "player ";
1138 909
1139 sl << uint32 (pl->ob->count) 910 sl << uint32 (pl->ob->count)
1140 << uint32 (weight) 911 << uint32 (weight)
1141 << uint32 (pl->ob->face->number) 912 << uint32 (pl->ob->face)
1142 << data8 (pl->ob->name); 913 << data8 (pl->ob->name);
1143 914
915 pl->ns->last_weight = weight;
1144 pl->socket->send_packet (sl); 916 pl->ns->send_packet (sl);
1145 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 917 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1146} 918}
1147
1148/**
1149 * Need to send an animation sequence to the client.
1150 * We will send appropriate face commands to the client if we haven't
1151 * sent them the face yet (this can become quite costly in terms of
1152 * how much we are sending - on the other hand, this should only happen
1153 * when the player logs in and picks stuff up.
1154 */
1155void
1156esrv_send_animation (client * ns, short anim_num)
1157{
1158 /* Do some checking on the anim_num we got. Note that the animations
1159 * are added in contigous order, so if the number is in the valid
1160 * range, it must be a valid animation.
1161 */
1162 if (anim_num < 0 || anim_num > num_animations)
1163 {
1164 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1165 return;
1166 }
1167
1168 packet sl;
1169
1170 sl << "anim "
1171 << uint16 (anim_num)
1172 << uint16 (0); /* flags - not used right now */
1173
1174 /* Build up the list of faces. Also, send any information (ie, the
1175 * the face itself) down to the client.
1176 */
1177 for (int i = 0; i < animations[anim_num].num_animations; i++)
1178 {
1179 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1180 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1181
1182 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1183 }
1184
1185 ns->send_packet (sl);
1186
1187 ns->anims_sent[anim_num] = 1;
1188}
1189
1190 919
1191/****************************************************************************** 920/******************************************************************************
1192 * 921 *
1193 * Start of map related commands. 922 * Start of map related commands.
1194 * 923 *
1195 ******************************************************************************/ 924 ******************************************************************************/
1196 925
1197/**
1198 * This adds face_num to a map cell at x,y. If the client doesn't have
1199 * the face yet, we will also send it.
1200 */
1201static void
1202esrv_map_setbelow (client * ns, int x, int y, short face_num, struct Map *newmap)
1203{
1204 if (newmap->cells[x][y].count >= MAP_LAYERS)
1205 {
1206 //TODO: one or the other, can't both have abort and return, verify and act
1207 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1208 return;
1209 abort ();
1210 }
1211
1212 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1213 newmap->cells[x][y].count++;
1214
1215 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1216 esrv_send_face (ns, face_num, 0);
1217}
1218
1219/** Clears a map cell */ 926/** Clears a map cell */
1220static void 927static void
1221map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 928map_clearcell (struct MapCell *cell, int count)
1222{ 929{
1223 cell->faces[0] = face0; 930 cell->faces[0] = 0;
1224 cell->faces[1] = face1; 931 cell->faces[1] = 0;
1225 cell->faces[2] = face2; 932 cell->faces[2] = 0;
933 cell->smooth[0] = 0;
934 cell->smooth[1] = 0;
935 cell->smooth[2] = 0;
1226 cell->count = count; 936 cell->count = count;
1227 cell->stat_hp = 0; 937 cell->stat_hp = 0;
1228 cell->flags = 0; 938 cell->flags = 0;
1229 cell->player = 0; 939 cell->player = 0;
1230} 940}
1231 941
1232#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1233#define MAX_LAYERS 3 942#define MAX_LAYERS 3
1234
1235/* Using a global really isn't a good approach, but saves the over head of
1236 * allocating and deallocating such a block of data each time run through,
1237 * and saves the space of allocating this in the socket object when we only
1238 * need it for this cycle. If the server is ever threaded, this needs to be
1239 * re-examined.
1240 */
1241static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1242
1243/**
1244 * Returns true if any of the heads for this
1245 * space is set. Returns false if all are blank - this is used
1246 * for empty space checking.
1247 */
1248static inline int
1249have_head (int ax, int ay)
1250{
1251 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1252 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1253 return 1;
1254
1255 return 0;
1256}
1257
1258/**
1259 * check_head is a bit simplistic version of update_space below.
1260 * basically, it only checks the that the head on space ax,ay at layer
1261 * needs to get sent - if so, it adds the data, sending the head
1262 * if needed, and returning 1. If this no data needs to get
1263 * sent, it returns zero.
1264 */
1265static int
1266check_head (packet &sl, client &ns, int ax, int ay, int layer)
1267{
1268 short face_num;
1269
1270 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1271 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1272 else
1273 face_num = 0;
1274
1275 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1276 {
1277 sl << uint16 (face_num);
1278 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1279 esrv_send_face (&ns, face_num, 0);
1280
1281 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1282 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1283 return 1;
1284 }
1285
1286 return 0; /* No change */
1287}
1288 943
1289/** 944/**
1290 * Removes the need to replicate the same code for each layer. 945 * Removes the need to replicate the same code for each layer.
1291 * this returns true if this space is now in fact different than 946 * this returns true if this space is now in fact different than
1292 * it was. 947 * it was.
1293 * sl is the socklist this data is going into. 948 * sl is the socklist this data is going into.
1294 * ns is the socket we are working on - all the info we care 949 * ns is the socket we are working on - all the info we care
1295 * about is in this socket structure, so now need not pass the 950 * about is in this socket structure, so now need not pass the
1296 * entire player object. 951 * entire player object.
1297 * mx and my are map coordinate offsets for map mp
1298 * sx and sy are the offsets into the socket structure that
1299 * holds the old values.
1300 * layer is the layer to update, with 2 being the floor and 0 the 952 * layer is the layer to update, with 2 being the floor and 0 the
1301 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ) 953 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ)
1302 * take. Interesting to note that before this function, the map1 function 954 * take. Interesting to note that before this function, the map1 function
1303 * numbers the spaces differently - I think this was a leftover from 955 * numbers the spaces differently - I think this was a leftover from
1304 * the map command, where the faces stack up. Sinces that is no longer 956 * the map command, where the faces stack up. Sinces that is no longer
1305 * the case, it seems to make more sense to have these layer values 957 * the case, it seems to make more sense to have these layer values
1306 * actually match. 958 * actually match.
1307 */ 959 */
1308static int 960static int
1309update_space (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 961update_space (packet &sl, client &ns, mapspace &ms, MapCell &lastcell, int layer)
1310{ 962{
1311 object *ob, *head; 963 object *ob = ms.faces_obj [layer];
1312 uint16 face_num;
1313 int bx, by, i;
1314
1315 /* If there is a multipart object stored away, treat that as more important.
1316 * If not, then do the normal processing.
1317 */
1318 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1319
1320 /* Check to see if this head is part of the set of objects
1321 * we would normally send for this space. If so, then
1322 * don't use the head value. We need to do the check
1323 * here and not when setting up the heads[] value for two reasons -
1324 * 1) the heads[] values will get used even if the space is not visible.
1325 * 2) its possible the head is not on the same map as a part, and I'd
1326 * rather not need to do the map translation overhead.
1327 * 3) We need to do some extra checking to make sure that we will
1328 * otherwise send the image as this layer, eg, either it matches
1329 * the head value, or is not multipart.
1330 */
1331 if (head && !head->more)
1332 {
1333 for (i = 0; i < MAP_LAYERS; i++)
1334 {
1335 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1336 if (!ob)
1337 continue;
1338
1339 if (ob->head)
1340 ob = ob->head;
1341
1342 if (ob == head)
1343 {
1344 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1345 head = NULL;
1346 break;
1347 }
1348 }
1349 }
1350
1351 ob = head;
1352 if (!ob)
1353 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1354 964
1355 /* If there is no object for this space, or if the face for the object 965 /* If there is no object for this space, or if the face for the object
1356 * is the blank face, set the face number to zero. 966 * is the blank face, set the face number to zero.
1357 * else if we have the stored head object for this space, that takes 967 * else if we have the stored head object for this space, that takes
1358 * precedence over the other object for this space. 968 * precedence over the other object for this space.
1359 * otherwise, we do special head processing 969 * otherwise, we do special head processing
1360 */ 970 */
1361 if (!ob || ob->face == blank_face) 971 uint16 face_num = ob && ob->face != blank_face ? ob->face : 0;
1362 face_num = 0;
1363 else if (head)
1364 {
1365 /* if this is a head that had previously been stored */
1366 face_num = ob->face->number;
1367 }
1368 else
1369 {
1370 /* if the faces for the different parts of a multipart object
1371 * are the same, we only want to send the bottom right most
1372 * portion of the object. That info is in the tail_.. values
1373 * of the head. Note that for the head itself, ob->head will
1374 * be null, so we only do this block if we are working on
1375 * a tail piece.
1376 */
1377
1378 /* tail_x and tail_y will only be set in the head object. If
1379 * this is the head object and these are set, we proceed
1380 * with logic to only send bottom right. Similarly, if
1381 * this is one of the more parts but the head has those values
1382 * set, we want to do the processing. There can be cases where
1383 * the head is not visible but one of its parts is, so we just
1384 * can always expect that ob->arch->tail_x will be true for all
1385 * object we may want to display.
1386 */
1387 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1388 {
1389
1390 if (ob->head)
1391 head = ob->head;
1392 else
1393 head = ob;
1394
1395 /* Basically figure out where the offset is from where we are right
1396 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1397 * piece is from the head, and the tail is where the tail is from the
1398 * head. Note that bx and by will equal sx and sy if we are already working
1399 * on the bottom right corner. If ob is the head, the clone values
1400 * will be zero, so the right thing will still happen.
1401 */
1402 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1403 by = sy + head->arch->tail_y - ob->arch->clone.y;
1404
1405 /* I don't think this can ever happen, but better to check for it just
1406 * in case.
1407 */
1408 if (bx < sx || by < sy)
1409 {
1410 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1411 face_num = 0;
1412 }
1413 /* single part object, multipart object with non merged faces,
1414 * of multipart object already at lower right.
1415 */
1416 else if (bx == sx && by == sy)
1417 {
1418 face_num = ob->face->number;
1419
1420 /* if this face matches one stored away, clear that one away.
1421 * this code relies on the fact that the map1 commands
1422 * goes from 2 down to 0.
1423 */
1424 for (i = 0; i < MAP_LAYERS; i++)
1425 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1426 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1427 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1428 }
1429 else
1430 {
1431 /* If this head is stored away, clear it - otherwise,
1432 * there can be cases where a object is on multiple layers -
1433 * we only want to send it once.
1434 */
1435 face_num = head->face->number;
1436 for (i = 0; i < MAP_LAYERS; i++)
1437 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1438 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1439 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1440
1441 /* First, try to put the new head on the same layer. If that is used up,
1442 * then find another layer.
1443 */
1444 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1445 {
1446 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1447 }
1448 else
1449 for (i = 0; i < MAX_LAYERS; i++)
1450 {
1451 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1452 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1453 {
1454 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1455 }
1456 }
1457 face_num = 0; /* Don't send this object - we'll send the head later */
1458 }
1459 }
1460 else
1461 {
1462 /* In this case, we are already at the lower right or single part object,
1463 * so nothing special
1464 */
1465 face_num = ob->face->number;
1466
1467 /* clear out any head entries that have the same face as this one */
1468 for (bx = 0; bx < layer; bx++)
1469 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1470 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1471 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1472 }
1473 } /* else not already head object or blank face */
1474
1475 /* This is a real hack. Basically, if we have nothing to send for this layer,
1476 * but there is a head on the next layer, send that instead.
1477 * Without this, what happens is you can get the case where the player stands
1478 * on the same space as the head. However, if you have overlapping big objects
1479 * of the same type, what happens then is it doesn't think it needs to send
1480 * This tends to make stacking also work/look better.
1481 */
1482 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1483 {
1484 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1485 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1486 }
1487
1488 /* Another hack - because of heads and whatnot, this face may match one
1489 * we already sent for a lower layer. In that case, don't send
1490 * this one.
1491 */
1492 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1493 face_num = 0;
1494 972
1495 /* We've gotten what face we want to use for the object. Now see if 973 /* We've gotten what face we want to use for the object. Now see if
1496 * if it has changed since we last sent it to the client. 974 * if it has changed since we last sent it to the client.
1497 */ 975 */
1498 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num) 976 if (lastcell.faces[layer] != face_num)
1499 { 977 {
1500 ns.lastmap.cells[sx][sy].faces[layer] = face_num; 978 lastcell.faces[layer] = face_num;
979
1501 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 980 if (!ns.faces_sent[face_num])
981 if (ob)
982 ns.send_faces (ob);
983 else
1502 esrv_send_face (&ns, face_num, 0); 984 ns.send_face (face_num, 10);
1503 985
1504 sl << uint16 (face_num); 986 sl << uint16 (face_num);
1505 return 1;
1506 }
1507
1508 /* Nothing changed */
1509 return 0;
1510}
1511
1512/**
1513 * This function is mainly a copy of update_space,
1514 * except it handles update of the smoothing updates,
1515 * not the face updates.
1516 * Removes the need to replicate the same code for each layer.
1517 * this returns true if this smooth is now in fact different
1518 * than it was.
1519 * sl is the socklist this data is going into.
1520 * ns is the socket we are working on - all the info we care
1521 * about is in this socket structure, so know need to pass the
1522 * entire player object.
1523 * mx and my are map coordinate offsets for map mp
1524 * sx and sy are the offsets into the socket structure that
1525 * holds the old values.
1526 * layer is the layer to update, with 2 being the floor and 0 the
1527 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1528 * take.
1529 */
1530
1531static inline int
1532update_smooth (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1533{
1534 object *ob;
1535 int smoothlevel; /* old face_num; */
1536
1537 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1538
1539 /* If there is no object for this space, or if the face for the object
1540 * is the blank face, set the smoothlevel to zero.
1541 */
1542 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1543 smoothlevel = 0;
1544 else
1545 {
1546 smoothlevel = ob->smoothlevel;
1547 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1548 SendSmooth (&ns, ob->face->number);
1549 } /* else not already head object or blank face */
1550
1551 /* We've gotten what face we want to use for the object. Now see if
1552 * if it has changed since we last sent it to the client.
1553 */
1554 if (smoothlevel > 255)
1555 smoothlevel = 255;
1556 else if (smoothlevel < 0)
1557 smoothlevel = 0;
1558
1559 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1560 {
1561 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1562 sl << uint8 (smoothlevel);
1563 return 1; 987 return 1;
1564 } 988 }
1565 989
1566 /* Nothing changed */ 990 /* Nothing changed */
1567 return 0; 991 return 0;
… …
1584 } 1008 }
1585 1009
1586 return result; 1010 return result;
1587} 1011}
1588 1012
1013// prefetch (and touch) all maps within a specific distancd
1014static void
1015prefetch_surrounding_maps (maptile *map, int distance)
1016{
1017 map->last_access = runtime;
1018
1019 if (--distance)
1020 for (int dir = 4; --dir; )
1021 if (const shstr &path = map->tile_path [dir])
1022 if (maptile *&neigh = map->tile_map [dir])
1023 prefetch_surrounding_maps (neigh, distance);
1024 else
1025 neigh = maptile::find_async (path, map);
1026}
1027
1028// prefetch a generous area around the player
1029static void
1030prefetch_surrounding_maps (object *op)
1031{
1032 prefetch_surrounding_maps (op->map, 3);
1033}
1034
1589/** 1035/**
1590 * This function uses the new map1 protocol command to send the map 1036 * Draws client map.
1591 * to the client. It is necessary because the old map command supports
1592 * a maximum map size of 15x15.
1593 * This function is much simpler than the old one. This is because
1594 * the old function optimized to send as few face identifiers as possible,
1595 * at the expense of sending more coordinate location (coordinates were
1596 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1597 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1598 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1599 * and use the other 4 bits for other informatiion. For full documentation
1600 * of what we send, see the doc/Protocol file.
1601 * I will describe internally what we do:
1602 * the socket->lastmap shows how the map last looked when sent to the client.
1603 * in the lastmap structure, there is a cells array, which is set to the
1604 * maximum viewable size (As set in config.h).
1605 * in the cells, there are faces and a count value.
1606 * we use the count value to hold the darkness value. If -1, then this space
1607 * is not viewable.
1608 * we use faces[0] faces[1] faces[2] to hold what the three layers
1609 * look like.
1610 */ 1037 */
1611void 1038void
1612draw_client_map1 (object *pl) 1039draw_client_map (player *pl)
1613{ 1040{
1041 object *ob = pl->observe;
1042 if (!ob->active)
1043 return;
1044
1045 maptile *plmap = ob->map;
1046
1047 /* If player is just joining the game, he isn't here yet, so the map
1048 * can get swapped out. If so, don't try to send them a map. All will
1049 * be OK once they really log in.
1050 */
1051 if (!plmap || plmap->in_memory != MAP_ACTIVE)
1052 return;
1053
1614 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1054 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1615 sint16 nx, ny;
1616 int estartlen, eoldlen; 1055 int estartlen, eoldlen;
1617 uint16 mask, emask;
1618 uint8 eentrysize; 1056 uint8 eentrysize;
1619 uint16 ewhatstart, ewhatflag; 1057 uint16 ewhatstart, ewhatflag;
1620 uint8 extendedinfos; 1058 uint8 extendedinfos;
1621 maptile *m;
1622 1059
1623 client &socket = *pl->contr->socket;
1624
1625 check_map_change (pl->contr); 1060 check_map_change (pl);
1061 prefetch_surrounding_maps (pl->ob);
1626 1062
1627 packet sl; 1063 /* do LOS after calls to update_position */
1064 if (ob != pl->ob)
1065 clear_los (pl);
1066 else if (pl->do_los)
1067 {
1068 update_los (ob);
1069 pl->do_los = 0;
1070 }
1071
1072 /**
1073 * This function uses the new map1 protocol command to send the map
1074 * to the client. It is necessary because the old map command supports
1075 * a maximum map size of 15x15.
1076 * This function is much simpler than the old one. This is because
1077 * the old function optimized to send as few face identifiers as possible,
1078 * at the expense of sending more coordinate location (coordinates were
1079 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1080 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1081 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1082 * and use the other 4 bits for other informatiion. For full documentation
1083 * of what we send, see the doc/Protocol file.
1084 * I will describe internally what we do:
1085 * the ns->lastmap shows how the map last looked when sent to the client.
1086 * in the lastmap structure, there is a cells array, which is set to the
1087 * maximum viewable size (As set in config.h).
1088 * in the cells, there are faces and a count value.
1089 * we use the count value to hold the darkness value. If -1, then this space
1090 * is not viewable.
1091 * we use faces[0] faces[1] faces[2] to hold what the three layers
1092 * look like.
1093 */
1094
1095 client &socket = *pl->ns;
1096
1097 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1628 packet esl; 1098 packet esl;
1629 1099
1630 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1631 startlen = sl.length (); 1100 startlen = sl.length ();
1632 1101
1633 /*Extendedmapinfo structure initialisation */ 1102 /*Extendedmapinfo structure initialisation */
1634 if (socket.ext_mapinfos) 1103 if (socket.ext_mapinfos)
1635 { 1104 {
… …
1646 << uint8 (extendedinfos) 1115 << uint8 (extendedinfos)
1647 << uint8 (eentrysize); 1116 << uint8 (eentrysize);
1648 1117
1649 estartlen = esl.length (); 1118 estartlen = esl.length ();
1650 } 1119 }
1651 else
1652 {
1653 /* suppress compiler warnings */
1654 ewhatstart = 0;
1655 ewhatflag = 0;
1656 estartlen = 0;
1657 }
1658
1659 /* Init data to zero */
1660 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1661 1120
1662 /* x,y are the real map locations. ax, ay are viewport relative 1121 /* x,y are the real map locations. ax, ay are viewport relative
1663 * locations. 1122 * locations.
1664 */ 1123 */
1665 ay = 0; 1124 ay = 0;
1666 1125
1667 /* We could do this logic as conditionals in the if statement, 1126 /* We could do this logic as conditionals in the if statement,
1668 * but that started to get a bit messy to look at. 1127 * but that started to get a bit messy to look at.
1669 */ 1128 */
1670 max_x = pl->x + (socket.mapx + 1) / 2; 1129 max_x = ob->x + (socket.mapx + 1) / 2;
1671 max_y = pl->y + (socket.mapy + 1) / 2; 1130 max_y = ob->y + (socket.mapy + 1) / 2;
1672 1131
1673 if (socket.mapmode == Map1aCmd)
1674 {
1675 max_x += MAX_HEAD_OFFSET;
1676 max_y += MAX_HEAD_OFFSET;
1677 }
1678
1679 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1132 for (y = ob->y - socket.mapy / 2; y < max_y; y++, ay++)
1680 { 1133 {
1134 sint16 nx, ny;
1135 maptile *m = 0;
1136
1681 ax = 0; 1137 ax = 0;
1682 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1138 for (x = ob->x - socket.mapx / 2; x < max_x; x++, ax++)
1683 { 1139 {
1140 // check to see if we can simply go one right quickly
1141 ++nx;
1142 if (m && nx >= m->width)
1143 m = 0;
1684 1144
1145 if (!m)
1146 {
1147 nx = x; ny = y; m = plmap;
1148
1149 if (xy_normalise (m, nx, ny))
1150 m->touch ();
1151 else
1152 m = 0;
1153 }
1154
1155 int emask, mask;
1685 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1156 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1686 1157
1687 /* If this space is out of the normal viewable area, we only check
1688 * the heads value ax or ay will only be greater than what
1689 * the client wants if using the map1a command - this is because
1690 * if the map1a command is not used, max_x and max_y will be
1691 * set to lower values.
1692 */
1693 if (ax >= socket.mapx || ay >= socket.mapy)
1694 {
1695 int i, got_one;
1696
1697 oldlen = sl.length ();
1698
1699 sl << uint16 (mask);
1700
1701 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1702 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1703 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1704
1705 /* If all we are doing is sending 0 (blank) faces, we don't
1706 * actually need to send that - just the coordinates
1707 * with no faces tells the client to blank out the
1708 * space.
1709 */
1710 got_one = 0;
1711 for (i = oldlen + 2; i < sl.length (); i++)
1712 if (sl[i])
1713 got_one = 1;
1714
1715 if (got_one && (mask & 0xf))
1716 sl[oldlen + 1] = mask & 0xff;
1717 else
1718 { /*either all faces blank, either no face at all */
1719 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1720 sl.reset (oldlen + 2);
1721 else
1722 sl.reset (oldlen);
1723 }
1724
1725 /*What concerns extendinfos, nothing to be done for now
1726 * (perhaps effects layer later)
1727 */
1728 continue; /* don't do processing below */
1729 }
1730
1731 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1158 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1732
1733 d = pl->contr->blocked_los[ax][ay];
1734 1159
1735 /* If the coordinates are not valid, or it is too dark to see, 1160 /* If the coordinates are not valid, or it is too dark to see,
1736 * we tell the client as such 1161 * we tell the client as such
1737 */ 1162 */
1738 nx = x;
1739 ny = y;
1740 m = get_map_from_coord (pl->map, &nx, &ny);
1741
1742 if (!m) 1163 if (!m)
1743 { 1164 {
1744 /* space is out of map. Update space and clear values 1165 /* space is out of map. Update space and clear values
1745 * if this hasn't already been done. If the space is out 1166 * if this hasn't already been done. If the space is out
1746 * of the map, it shouldn't have a head 1167 * of the map, it shouldn't have a head
1747 */ 1168 */
1748 if (lastcell.count != -1) 1169 if (lastcell.count != -1)
1749 { 1170 {
1750 sl << uint16 (mask); 1171 sl << uint16 (mask);
1751 map_clearcell (&lastcell, 0, 0, 0, -1); 1172 map_clearcell (&lastcell, -1);
1752 } 1173 }
1174
1175 continue;
1753 } 1176 }
1177
1178 int d = pl->blocked_los[ax][ay];
1179
1754 else if (d > 3) 1180 if (d > 3)
1755 { 1181 {
1182
1756 int need_send = 0, count; 1183 int need_send = 0, count;
1757 1184
1758 /* This block deals with spaces that are not visible for whatever 1185 /* This block deals with spaces that are not visible for whatever
1759 * reason. Still may need to send the head for this space. 1186 * reason. Still may need to send the head for this space.
1760 */ 1187 */
1761 1188
1762 oldlen = sl.length (); 1189 oldlen = sl.length ();
1763 1190
1764 sl << uint16 (mask); 1191 sl << uint16 (mask);
… …
1766 if (lastcell.count != -1) 1193 if (lastcell.count != -1)
1767 need_send = 1; 1194 need_send = 1;
1768 1195
1769 count = -1; 1196 count = -1;
1770 1197
1771 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
1772 {
1773 /* Now check to see if any heads need to be sent */
1774
1775 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1776 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1777 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1778
1779 lastcell.count = count;
1780 }
1781 else
1782 {
1783 /* properly clear a previously sent big face */ 1198 /* properly clear a previously sent big face */
1784 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0 1199 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1785 || lastcell.stat_hp || lastcell.flags || lastcell.player) 1200 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1786 need_send = 1; 1201 need_send = 1;
1787 1202
1788 map_clearcell (&lastcell, 0, 0, 0, count); 1203 map_clearcell (&lastcell, count);
1789 }
1790 1204
1791 if ((mask & 0xf) || need_send) 1205 if ((mask & 0xf) || need_send)
1792 sl[oldlen + 1] = mask & 0xff; 1206 sl[oldlen + 1] = mask & 0xff;
1793 else 1207 else
1794 sl.reset (oldlen); 1208 sl.reset (oldlen);
1795 } 1209 }
1796 else 1210 else
1797 { 1211 {
1798 /* In this block, the space is visible or there are head objects 1212 /* In this block, the space is visible.
1799 * we need to send.
1800 */ 1213 */
1801 1214
1802 /* Rather than try to figure out what everything that we might 1215 /* Rather than try to figure out what everything that we might
1803 * need to send is, then form the packet after that, 1216 * need to send is, then form the packet after that,
1804 * we presume that we will in fact form a packet, and update 1217 * we presume that we will in fact form a packet, and update
… …
1807 * is done. 1220 * is done.
1808 * I think this is simpler than doing a bunch of checks to see 1221 * I think this is simpler than doing a bunch of checks to see
1809 * what if anything we need to send, setting the bits, then 1222 * what if anything we need to send, setting the bits, then
1810 * doing those checks again to add the real data. 1223 * doing those checks again to add the real data.
1811 */ 1224 */
1812 oldlen = sl.length (); 1225 oldlen = sl.length ();
1813 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1814 eoldlen = esl.length (); 1226 eoldlen = esl.length ();
1815 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1227
1816 sl << uint16 (mask); 1228 sl << uint16 (mask);
1817
1818 if (socket.ext_mapinfos)
1819 esl << uint16 (emask);
1820 1229
1821 unsigned char dummy; 1230 unsigned char dummy;
1822 unsigned char *last_ext = &dummy; 1231 unsigned char *last_ext = &dummy;
1823 1232
1824 /* Darkness changed */ 1233 /* Darkness changed */
… …
1836 sl << uint8 (255 - 64 * d); 1245 sl << uint8 (255 - 64 * d);
1837 } 1246 }
1838 1247
1839 lastcell.count = d; 1248 lastcell.count = d;
1840 1249
1250 mapspace &ms = m->at (nx, ny);
1251 ms.update ();
1252
1841 if (socket.extmap) 1253 if (socket.extmap)
1842 { 1254 {
1843 uint8 stat_hp = 0; 1255 uint8 stat_hp = 0;
1844 uint8 stat_width = 0; 1256 uint8 stat_width = 0;
1845 uint8 flags = 0; 1257 uint8 flags = 0;
1846 UUID player = 0; 1258 tag_t player = 0;
1847 1259
1848 // send hp information, if applicable 1260 // send hp information, if applicable
1849 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1261 if (object *op = ms.faces_obj [0])
1262 if (op->is_head () && !op->invisible)
1850 { 1263 {
1851 if (op->head || op->invisible) 1264 if (op->stats.maxhp > op->stats.hp
1852 ; // do not show 1265 && op->stats.maxhp > 0
1853 else if (op->type == PLAYER 1266 && (op->type == PLAYER
1267 || op->type == DOOR // does not work, have maxhp 0
1854 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1268 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)))
1855 {
1856 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
1857 { 1269 {
1858 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp; 1270 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1859 stat_width = op->arch->tail_x; 1271 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1860 } 1272 }
1861 }
1862 1273
1863 if (op->msg && op->msg[0] == '@') 1274 if (op->msg && op->msg[0] == '@')
1864 flags |= 1; 1275 flags |= 1;
1865 1276
1866 if (op->type == PLAYER && op != pl) 1277 if (op->type == PLAYER && op != ob)
1867 player = op->count; 1278 player = op->count;
1868 } 1279 }
1869 1280
1870 if (lastcell.stat_hp != stat_hp) 1281 if (lastcell.stat_hp != stat_hp)
1871 { 1282 {
1872 lastcell.stat_hp = stat_hp; 1283 lastcell.stat_hp = stat_hp;
1873 1284
… …
1892 1303
1893 mask |= 0x8; 1304 mask |= 0x8;
1894 *last_ext |= 0x80; 1305 *last_ext |= 0x80;
1895 last_ext = &sl[sl.length ()]; 1306 last_ext = &sl[sl.length ()];
1896 1307
1897 sl << uint8 (0x47) << uint8 (8) << (uint64)player; 1308 sl << uint8 (0x47) << uint8 (4) << (uint32)player;
1898 } 1309 }
1899 1310
1900 if (lastcell.flags != flags) 1311 if (lastcell.flags != flags)
1901 { 1312 {
1902 lastcell.flags = flags; 1313 lastcell.flags = flags;
… …
1908 sl << uint8 (8) << uint8 (flags); 1319 sl << uint8 (8) << uint8 (flags);
1909 } 1320 }
1910 } 1321 }
1911 1322
1912 /* Floor face */ 1323 /* Floor face */
1913 if (update_space (sl, socket, m, nx, ny, ax, ay, 2)) 1324 if (update_space (sl, socket, ms, lastcell, 2))
1914 mask |= 0x4; 1325 mask |= 0x4;
1915 1326
1916 if (socket.EMI_smooth)
1917 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
1918 emask |= 0x4;
1919
1920 /* Middle face */ 1327 /* Middle face */
1921 if (update_space (sl, socket, m, nx, ny, ax, ay, 1)) 1328 if (update_space (sl, socket, ms, lastcell, 1))
1922 mask |= 0x2; 1329 mask |= 0x2;
1923 1330
1924 if (socket.EMI_smooth) 1331 if (ms.player () == ob
1925 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1)) 1332 && (ob->invisible & (ob->invisible < 50 ? 1 : 7)))
1926 emask |= 0x2;
1927
1928 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
1929 { 1333 {
1334 // force player to be visible to himself if invisible
1930 if (lastcell.faces[0] != pl->face->number) 1335 if (lastcell.faces[0] != ob->face)
1931 { 1336 {
1932 lastcell.faces[0] = pl->face->number; 1337 lastcell.faces[0] = ob->face;
1338
1933 mask |= 0x1; 1339 mask |= 0x1;
1934
1935 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
1936 esrv_send_face (&socket, pl->face->number, 0);
1937
1938 sl << uint16 (pl->face->number); 1340 sl << uint16 (ob->face);
1341
1342 socket.send_faces (ob);
1939 } 1343 }
1940 } 1344 }
1941 else
1942 {
1943 /* Top face */ 1345 /* Top face */
1944 if (update_space (sl, socket, m, nx, ny, ax, ay, 0)) 1346 else if (update_space (sl, socket, ms, lastcell, 0))
1945 mask |= 0x1; 1347 mask |= 0x1;
1946
1947 if (socket.EMI_smooth)
1948 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
1949 emask |= 0x1;
1950 }
1951 1348
1952 /* Check to see if we are in fact sending anything for this 1349 /* Check to see if we are in fact sending anything for this
1953 * space by checking the mask. If so, update the mask. 1350 * space by checking the mask. If so, update the mask.
1954 * if not, reset the len to that from before adding the mask 1351 * if not, reset the len to that from before adding the mask
1955 * value, so we don't send those bits. 1352 * value, so we don't send those bits.
… …
1957 if (mask & 0xf) 1354 if (mask & 0xf)
1958 sl[oldlen + 1] = mask & 0xff; 1355 sl[oldlen + 1] = mask & 0xff;
1959 else 1356 else
1960 sl.reset (oldlen); 1357 sl.reset (oldlen);
1961 1358
1359 if (socket.ext_mapinfos)
1360 esl << uint16 (emask);
1361
1362 if (socket.EMI_smooth)
1363 {
1364 for (int layer = 2+1; layer--; )
1365 {
1366 object *ob = ms.faces_obj [layer];
1367
1368 // If there is no object for this space, or if the face for the object
1369 // is the blank face, set the smoothlevel to zero.
1370 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1371
1372 // We've gotten what face we want to use for the object. Now see if
1373 // if it has changed since we last sent it to the client.
1374 if (lastcell.smooth[layer] != smoothlevel)
1375 {
1376 lastcell.smooth[layer] = smoothlevel;
1377 esl << uint8 (smoothlevel);
1378 emask |= 1 << layer;
1379 }
1380 }
1381
1962 if (emask & 0xf) 1382 if (emask & 0xf)
1963 esl[eoldlen + 1] = emask & 0xff; 1383 esl[eoldlen + 1] = emask & 0xff;
1964 else 1384 else
1965 esl.reset (eoldlen); 1385 esl.reset (eoldlen);
1386 }
1966 } /* else this is a viewable space */ 1387 } /* else this is a viewable space */
1967 } /* for x loop */ 1388 } /* for x loop */
1968 } /* for y loop */ 1389 } /* for y loop */
1390
1391 socket.flush_fx ();
1969 1392
1970 /* Verify that we in fact do need to send this */ 1393 /* Verify that we in fact do need to send this */
1971 if (socket.ext_mapinfos) 1394 if (socket.ext_mapinfos)
1972 { 1395 {
1973 if (!(sl.length () > startlen || socket.sent_scroll)) 1396 if (!(sl.length () > startlen || socket.sent_scroll))
1974 { 1397 {
1975 /* No map data will follow, so don't say the client 1398 /* No map data will follow, so don't say the client
1976 * it doesn't need draw! 1399 * it doesn't need draw!
1977 */ 1400 */
1978 ewhatflag &= (~EMI_NOREDRAW); 1401 ewhatflag &= ~EMI_NOREDRAW;
1979 esl[ewhatstart + 1] = ewhatflag & 0xff; 1402 esl[ewhatstart + 1] = ewhatflag & 0xff;
1980 } 1403 }
1981 1404
1982 if (esl.length () > estartlen) 1405 if (esl.length () > estartlen)
1983 socket.send_packet (esl); 1406 socket.send_packet (esl);
… …
1988 socket.send_packet (sl); 1411 socket.send_packet (sl);
1989 socket.sent_scroll = 0; 1412 socket.sent_scroll = 0;
1990 } 1413 }
1991} 1414}
1992 1415
1993/**
1994 * Draws client map.
1995 */
1996void
1997draw_client_map (object *pl)
1998{
1999 int i, j;
2000 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */
2001 New_Face *face, *floor;
2002 New_Face *floor2;
2003 int d, mflags;
2004 struct Map newmap;
2005 maptile *m, *pm;
2006
2007 if (pl->type != PLAYER)
2008 {
2009 LOG (llevError, "draw_client_map called with non player/non eric-server\n");
2010 return;
2011 }
2012
2013 pm = pl->map;
2014
2015 /* If player is just joining the game, he isn't here yet, so the map
2016 * can get swapped out. If so, don't try to send them a map. All will
2017 * be OK once they really log in.
2018 */
2019 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2020 return;
2021
2022 memset (&newmap, 0, sizeof (struct Map));
2023
2024 for (j = (pl->y - pl->contr->socket->mapy / 2); j < (pl->y + (pl->contr->socket->mapy + 1) / 2); j++)
2025 {
2026 for (i = (pl->x - pl->contr->socket->mapx / 2); i < (pl->x + (pl->contr->socket->mapx + 1) / 2); i++)
2027 {
2028 ax = i;
2029 ay = j;
2030 m = pm;
2031 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
2032
2033 if (mflags & P_OUT_OF_MAP)
2034 continue;
2035
2036 if (mflags & P_NEED_UPDATE)
2037 update_position (m, ax, ay);
2038
2039 /* If a map is visible to the player, we don't want to swap it out
2040 * just to reload it. This should really call something like
2041 * swap_map, but this is much more efficient and 'good enough'
2042 */
2043 if (mflags & P_NEW_MAP)
2044 m->timeout = 50;
2045 }
2046 }
2047 /* do LOS after calls to update_position */
2048 if (pl->contr->do_los)
2049 {
2050 update_los (pl);
2051 pl->contr->do_los = 0;
2052 }
2053
2054 /* Big maps need a different drawing mechanism to work */
2055 draw_client_map1 (pl);
2056}
2057
2058
2059/*****************************************************************************/ 1416/*****************************************************************************/
2060
2061/* GROS: The following one is used to allow a plugin to send a generic cmd to*/ 1417/* GROS: The following one is used to allow a plugin to send a generic cmd to*/
2062
2063/* a player. Of course, the client need to know the command to be able to */ 1418/* a player. Of course, the client need to know the command to be able to */
2064
2065/* manage it ! */ 1419/* manage it ! */
2066
2067/*****************************************************************************/ 1420/*****************************************************************************/
2068void 1421void
2069send_plugin_custom_message (object *pl, char *buf) 1422send_plugin_custom_message (object *pl, char *buf)
2070{ 1423{
2071 pl->contr->socket->send_packet (buf); 1424 pl->contr->ns->send_packet (buf);
2072} 1425}
2073 1426
2074/** 1427/**
2075 * This sends the skill number to name mapping. We ignore 1428 * This sends the skill number to name mapping. We ignore
2076 * the params - we always send the same info no matter what. 1429 * the params - we always send the same info no matter what.
… …
2082 sl << "replyinfo skill_info\n"; 1435 sl << "replyinfo skill_info\n";
2083 1436
2084 for (int i = 1; i < NUM_SKILLS; i++) 1437 for (int i = 1; i < NUM_SKILLS; i++)
2085 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1438 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2086 1439
2087 if (sl.length () >= MAXSOCKBUF) 1440 if (sl.length () > MAXSOCKBUF)
2088 { 1441 {
2089 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1442 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2090 fatal (0); 1443 fatal (0);
2091 } 1444 }
2092 1445
… …
2105 sl << "replyinfo spell_paths\n"; 1458 sl << "replyinfo spell_paths\n";
2106 1459
2107 for (int i = 0; i < NRSPELLPATHS; i++) 1460 for (int i = 0; i < NRSPELLPATHS; i++)
2108 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1461 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2109 1462
2110 if (sl.length () >= MAXSOCKBUF) 1463 if (sl.length () > MAXSOCKBUF)
2111 { 1464 {
2112 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1465 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2113 fatal (0); 1466 fatal (0);
2114 } 1467 }
2115 1468
… …
2121 * it then sends an updspell packet for each spell that has changed in this way 1474 * it then sends an updspell packet for each spell that has changed in this way
2122 */ 1475 */
2123void 1476void
2124esrv_update_spells (player *pl) 1477esrv_update_spells (player *pl)
2125{ 1478{
1479 if (!pl->ns)
1480 return;
1481
2126 if (!pl->socket->monitor_spells) 1482 if (!pl->ns->monitor_spells)
2127 return; 1483 return;
2128 1484
2129 for (object *spell = pl->ob->inv; spell; spell = spell->below) 1485 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2130 { 1486 {
2131 if (spell->type == SPELL) 1487 if (spell->type == SPELL)
… …
2161 1517
2162 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1518 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2163 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1519 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2164 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1520 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2165 1521
2166 pl->socket->send_packet (sl); 1522 pl->ns->send_packet (sl);
2167 } 1523 }
2168 } 1524 }
2169 } 1525 }
2170} 1526}
2171 1527
2172void 1528void
2173esrv_remove_spell (player *pl, object *spell) 1529esrv_remove_spell (player *pl, object *spell)
2174{ 1530{
2175 if (!pl->socket->monitor_spells) 1531 if (!pl->ns->monitor_spells)
2176 return; 1532 return;
2177 1533
2178 if (!pl || !spell || spell->env != pl->ob) 1534 if (!pl || !spell || spell->env != pl->ob)
2179 { 1535 {
2180 LOG (llevError, "Invalid call to esrv_remove_spell"); 1536 LOG (llevError, "Invalid call to esrv_remove_spell");
2181 return; 1537 return;
2182 } 1538 }
2183 1539
2184 packet sl; 1540 packet sl ("delspell");
2185 1541
2186 sl << "delspell "
2187 << uint32 (spell->count); 1542 sl << uint32 (spell->count);
2188 1543
2189 pl->socket->send_packet (sl); 1544 pl->ns->send_packet (sl);
2190} 1545}
2191 1546
2192/* appends the spell *spell to the Socklist we will send the data to. */ 1547/* appends the spell *spell to the Socklist we will send the data to. */
2193static void 1548static void
2194append_spell (player *pl, packet &sl, object *spell) 1549append_spell (player *pl, packet &sl, object *spell)
2195{ 1550{
2196 int len, i, skill = 0; 1551 int i, skill = 0;
2197 1552
2198 if (!(spell->name)) 1553 if (!(spell->name))
2199 { 1554 {
2200 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1555 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2201 return; 1556 return;
… …
2214 { 1569 {
2215 skill = i + CS_STAT_SKILLINFO; 1570 skill = i + CS_STAT_SKILLINFO;
2216 break; 1571 break;
2217 } 1572 }
2218 } 1573 }
1574
1575 // spells better have a face
1576 if (!spell->face)
1577 {
1578 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1579 spell->face = face_find ("burnout.x11", blank_face);
1580 }
1581
1582 pl->ns->send_face (spell->face);
2219 1583
2220 /* send the current values */ 1584 /* send the current values */
2221 sl << uint32 (spell->count) 1585 sl << uint32 (spell->count)
2222 << uint16 (spell->level) 1586 << uint16 (spell->level)
2223 << uint16 (spell->casting_time) 1587 << uint16 (spell->casting_time)
2224 << uint16 (spell->last_sp) 1588 << uint16 (spell->last_sp)
2225 << uint16 (spell->last_grace) 1589 << uint16 (spell->last_grace)
2226 << uint16 (spell->last_eat) 1590 << uint16 (spell->last_eat)
2227 << uint8 (skill) 1591 << uint8 (skill)
2228 << uint32 (spell->path_attuned) 1592 << uint32 (spell->path_attuned)
2229 << uint32 (spell->face ? spell->face->number : 0) 1593 << uint32 (spell->face)
2230 << data8 (spell->name) 1594 << data8 (spell->name)
2231 << data16 (spell->msg); 1595 << data16 (spell->msg);
2232} 1596}
2233 1597
2234/** 1598/**
… …
2242 { 1606 {
2243 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 1607 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2244 return; 1608 return;
2245 } 1609 }
2246 1610
2247 if (!pl->socket->monitor_spells) 1611 if (!pl->ns->monitor_spells)
2248 return; 1612 return;
2249 1613
2250 packet sl; 1614 packet sl ("addspell");
2251 sl << "addspell ";
2252 1615
2253 if (!spell) 1616 if (!spell)
2254 { 1617 {
2255 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 1618 for (spell = pl->ob->inv; spell; spell = spell->below)
2256 { 1619 {
2257 /* were we to simply keep appending data here, we could exceed 1620 /* were we to simply keep appending data here, we could exceed
2258 * MAXSOCKBUF if the player has enough spells to add, we know that 1621 * MAXSOCKBUF if the player has enough spells to add, we know that
2259 * append_spells will always append 19 data bytes, plus 4 length 1622 * append_spells will always append 19 data bytes, plus 4 length
2260 * bytes and 3 strings (because that is the spec) so we need to 1623 * bytes and 3 strings (because that is the spec) so we need to
2261 * check that the length of those 3 strings, plus the 23 bytes, 1624 * check that the length of those 3 strings, plus the 23 bytes,
2262 * won't take us over the length limit for the socket, if it does, 1625 * won't take us over the length limit for the socket, if it does,
2263 * we need to send what we already have, and restart packet formation 1626 * we need to send what we already have, and restart packet formation
2264 */ 1627 */
1628 if (spell->type != SPELL)
1629 continue;
1630
2265 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1631 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
2266 * to show add_spell is 26 bytes + 2 strings. However, the overun 1632 * to show add_spell is 26 bytes + 2 strings. However, the overun
2267 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1633 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2268 * like it will fix this 1634 * like it will fix this
2269 */ 1635 */
2270 if (spell->type != SPELL)
2271 continue;
2272
2273 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1636 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2274 { 1637 {
1638 pl->ns->flush_fx ();
2275 pl->socket->send_packet (sl); 1639 pl->ns->send_packet (sl);
2276 1640
2277 sl.reset (); 1641 sl.reset ();
2278 sl << "addspell "; 1642 sl << "addspell ";
2279 } 1643 }
2280 1644
… …
2287 return; 1651 return;
2288 } 1652 }
2289 else 1653 else
2290 append_spell (pl, sl, spell); 1654 append_spell (pl, sl, spell);
2291 1655
2292 if (sl.length () >= MAXSOCKBUF) 1656 if (sl.length () > MAXSOCKBUF)
2293 { 1657 {
2294 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1658 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2295 fatal (0); 1659 fatal (0);
2296 } 1660 }
2297 1661
2298 /* finally, we can send the packet */ 1662 /* finally, we can send the packet */
1663 pl->ns->flush_fx ();
2299 pl->socket->send_packet (sl); 1664 pl->ns->send_packet (sl);
2300} 1665}
2301 1666

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines