ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.111 by root, Sun Jul 1 04:08:14 2007 UTC vs.
Revision 1.132 by elmex, Sun Jun 15 19:34:31 2008 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Multiplayer Online Role Playing Game. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software; you can redistribute it and/or modify it 8 * Deliantra is free software: you can redistribute it and/or modify
9 * under the terms of the GNU General Public License as published by the Free 9 * it under the terms of the GNU General Public License as published by
10 * Software Foundation; either version 2 of the License, or (at your option) 10 * the Free Software Foundation, either version 3 of the License, or
11 * any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, but 13 * This program is distributed in the hope that it will be useful,
14 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License along 18 * You should have received a copy of the GNU General Public License
19 * with Crossfire TRT; if not, write to the Free Software Foundation, Inc. 51 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
21 * 20 *
22 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/** 24/**
26 * \file 25 * \file
27 * Client handling. 26 * Client handling.
… …
130} 129}
131 130
132static void 131static void
133clear_map (player *pl) 132clear_map (player *pl)
134{ 133{
134 pl->ns->mapinfo_queue_clear ();
135
135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap)); 136 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
136 137
137 pl->ns->force_newmap = false; 138 pl->ns->force_newmap = false;
138 139
139 if (pl->ns->newmapcmd == 1) 140 if (pl->ns->newmapcmd == 1)
140 pl->ns->send_packet ("newmap"); 141 pl->ns->send_packet ("newmap");
141 142
142 pl->ns->floorbox_reset (); 143 pl->ns->floorbox_reset ();
144}
145
146static void
147send_map_info (player *pl)
148{
149 client &socket = *pl->ns;
150 object *ob = pl->observe;
151
152 if (socket.mapinfocmd)
153 {
154 if (ob->map && ob->map->path[0])
155 {
156 int flags = 0;
157
158 if (ob->map->tile_path[0]) flags |= 1;
159 if (ob->map->tile_path[1]) flags |= 2;
160 if (ob->map->tile_path[2]) flags |= 4;
161 if (ob->map->tile_path[3]) flags |= 8;
162
163 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
164 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
165 ob->map->width, ob->map->height, &ob->map->path);
166 }
167 else
168 socket.send_packet ("mapinfo current");
169 }
143} 170}
144 171
145/** check for map/region change and send new map data */ 172/** check for map/region change and send new map data */
146static void 173static void
147check_map_change (player *pl) 174check_map_change (player *pl)
148{ 175{
149 client &socket = *pl->ns; 176 client &socket = *pl->ns;
150 object *ob = pl->observe; 177 object *ob = pl->observe;
151 178
179 region *reg = ob->region ();
180 if (socket.current_region != reg)
181 {
182 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
183 socket.current_region = reg;
184 }
185
186 // first try to aovid a full newmap on tiled map scrolls
187 if (socket.current_map != ob->map && !socket.force_newmap)
188 {
189 rv_vector rv;
190
191 get_rangevector_from_mapcoord (socket.current_map, socket.current_x, socket.current_y, ob, &rv, 0);
192
193 // manhattan distance is very handy here
194 if (rv.distance < 8) // 8 works nicely for speed << 70 and buggy gcfclient
195 {
196 socket.current_map = ob->map;
197 socket.current_x = ob->x;
198 socket.current_y = ob->y;
199
200 socket_map_scroll (&socket, rv.distance_x, rv.distance_y);
201 socket.floorbox_reset ();
202 send_map_info (pl);
203 }
204 }
205
152 if (socket.current_map != ob->map || socket.force_newmap) 206 if (socket.current_map != ob->map || socket.force_newmap)
153 { 207 {
154 clear_map (pl); 208 clear_map (pl);
155 socket.current_map = ob->map; 209 socket.current_map = ob->map;
156 210 send_map_info (pl);
157 if (socket.mapinfocmd)
158 {
159 if (ob->map && ob->map->path[0])
160 {
161 int flags = 0;
162
163 if (ob->map->tile_path[0]) flags |= 1;
164 if (ob->map->tile_path[1]) flags |= 2;
165 if (ob->map->tile_path[2]) flags |= 4;
166 if (ob->map->tile_path[3]) flags |= 8;
167
168 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
169 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
170 ob->map->width, ob->map->height, &ob->map->path);
171 }
172 else
173 socket.send_packet ("mapinfo current");
174 }
175 } 211 }
176 else if (socket.current_x != ob->x || socket.current_y != ob->y) 212 else if (socket.current_x != ob->x || socket.current_y != ob->y)
177 { 213 {
178 int dx = ob->x - socket.current_x; 214 int dx = ob->x - socket.current_x;
179 int dy = ob->y - socket.current_y; 215 int dy = ob->y - socket.current_y;
… …
187 } 223 }
188 } 224 }
189 225
190 socket.current_x = ob->x; 226 socket.current_x = ob->x;
191 socket.current_y = ob->y; 227 socket.current_y = ob->y;
192
193 region *reg = ob->region ();
194 if (socket.current_region != reg)
195 {
196 socket.current_region = reg;
197 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
198 }
199} 228}
200 229
201/** 230/**
202 * RequestInfo is sort of a meta command. There is some specific 231 * RequestInfo is sort of a meta command. There is some specific
203 * request of information, but we call other functions to provide 232 * request of information, but we call other functions to provide
204 * that information. 233 * that information.
205 */ 234 */
206void 235void
207RequestInfo (char *buf, int len, client * ns) 236RequestInfo (char *buf, int len, client *ns)
208{ 237{
209 char *params = NULL, *cp; 238 char *params;
210
211 /* No match */
212 char bigbuf[MAX_BUF];
213 int slen;
214
215 /* Set up replyinfo before we modify any of the buffers - this is used
216 * if we don't find a match.
217 */
218 strcpy (bigbuf, "replyinfo ");
219 slen = strlen (bigbuf);
220 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
221 239
222 /* find the first space, make it null, and update the 240 /* find the first space, make it null, and update the
223 * params pointer. 241 * params pointer.
224 */ 242 */
225 for (cp = buf; *cp != '\0'; cp++) 243 for (params = buf; *params; params++)
226 if (*cp == ' ') 244 if (*params == ' ')
227 { 245 {
228 *cp = '\0';
229 params = cp + 1; 246 *params++ = 0;
230 break; 247 break;
231 } 248 }
232 249
233 if (!strcmp (buf, "image_info")) 250 if (!strcmp (buf, "image_info"))
234 send_image_info (ns, params); 251 send_image_info (ns, params);
… …
237 else if (!strcmp (buf, "skill_info")) 254 else if (!strcmp (buf, "skill_info"))
238 send_skill_info (ns, params); 255 send_skill_info (ns, params);
239 else if (!strcmp (buf, "spell_paths")) 256 else if (!strcmp (buf, "spell_paths"))
240 send_spell_paths (ns, params); 257 send_spell_paths (ns, params);
241 else 258 else
242 ns->send_packet (bigbuf, len); 259 {
260 // undo tokenisation above and send replyinfo with the request unchanged
261 if (*params)
262 *--params = ' ';
263
264 ns->send_packet_printf ("replyinfo %s", buf);
265 }
243} 266}
244 267
245void 268void
246ExtCmd (char *buf, int len, player *pl) 269ExtCmd (char *buf, int len, player *pl)
247{ 270{
… …
250 273
251void 274void
252ExtiCmd (char *buf, int len, client *ns) 275ExtiCmd (char *buf, int len, client *ns)
253{ 276{
254 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len)); 277 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
278}
279
280void
281client::mapinfo_queue_clear ()
282{
283 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
284 free (*i);
285
286 mapinfo_queue.clear ();
287}
288
289bool
290client::mapinfo_try (char *buf)
291{
292 char *token = buf;
293 buf += strlen (buf) + 9;
294
295 // initial map and its origin
296 maptile *map = pl->observe->map;
297 int mapx = pl->ns->mapx / 2 - pl->observe->x;
298 int mapy = pl->ns->mapy / 2 - pl->observe->y;
299 int max_distance = 8; // limit maximum path length to something generous
300
301 while (*buf && map && max_distance)
302 {
303 int dir = *buf++ - '1';
304
305 if (dir >= 0 && dir <= 3)
306 {
307 if (!map->tile_path [dir])
308 map = 0;
309 else if (map->tile_available (dir, false))
310 {
311 maptile *neigh = map->tile_map [dir];
312
313 switch (dir)
314 {
315 case 0: mapy -= neigh->height; break;
316 case 2: mapy += map ->height; break;
317 case 3: mapx -= neigh->width ; break;
318 case 1: mapx += map ->width ; break;
319 }
320
321 map = neigh;
322 --max_distance;
323 }
324 else
325 return 0;
326 }
327 else
328 max_distance = 0;
329 }
330
331 if (!max_distance)
332 send_packet_printf ("mapinfo %s error", token);
333 else if (!map || !map->path)
334 send_packet_printf ("mapinfo %s nomap", token);
335 else
336 {
337 int flags = 0;
338
339 if (map->tile_path[0]) flags |= 1;
340 if (map->tile_path[1]) flags |= 2;
341 if (map->tile_path[2]) flags |= 4;
342 if (map->tile_path[3]) flags |= 8;
343
344 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
345 }
346
347 return 1;
348}
349
350void
351client::mapinfo_queue_run ()
352{
353 if (mapinfo_queue.empty () || !pl)
354 return;
355
356 for (int i = 0; i < mapinfo_queue.size (); ++i)
357 if (mapinfo_try (mapinfo_queue [i]))
358 {
359 free (mapinfo_queue [i]);
360 mapinfo_queue.erase (i);
361 }
362 else
363 ++i;
255} 364}
256 365
257void 366void
258MapInfoCmd (char *buf, int len, player *pl) 367MapInfoCmd (char *buf, int len, player *pl)
259{ 368{
260 // <mapinfo tag spatial tile-path 369 // <mapinfo tag spatial tile-path
261 // >mapinfo tag spatial flags x y w h hash 370 // >mapinfo tag spatial flags x y w h hash
262 371
263 char bigbuf[MAX_BUF], *token;
264
265 token = buf; 372 char *token = buf;
266 // copy token 373
267 if (!(buf = strchr (buf, ' '))) 374 if (!(buf = strchr (buf, ' ')))
268 return; 375 return;
269 376
270 *buf++ = 0;
271
272 if (!strncmp (buf, "spatial ", 8)) 377 if (!strncmp (buf, " spatial ", 9))
273 { 378 {
274 buf += 8; 379 char *copy = strdup (token);
380 copy [buf - token] = 0;
275 381
276 // initial map and its origin 382#if 0
277 maptile *map = pl->ob->map; 383 // this makes only sense when we flush the buffer immediately
278 sint16 dx, dy; 384 if (pl->ns->mapinfo_try (copy))
279 int mapx = pl->ns->mapx / 2 - pl->ob->x; 385 free (copy);
280 int mapy = pl->ns->mapy / 2 - pl->ob->y;
281 int max_distance = 8; // limit maximum path length to something generous
282
283 while (*buf && map && max_distance)
284 {
285 int dir = *buf++;
286
287 switch (dir)
288 {
289 case '1':
290 dx = 0;
291 dy = -1;
292 map = map->xy_find (dx, dy);
293 map && (mapy -= map->height);
294 break;
295 case '2':
296 mapx += map->width;
297 dx = map->width;
298 dy = 0;
299 map = map->xy_find (dx, dy);
300 break;
301 case '3':
302 mapy += map->height;
303 dx = 0;
304 dy = map->height;
305 map = map->xy_find (dx, dy);
306 break;
307 case '4':
308 dx = -1;
309 dy = 0;
310 map = map->xy_find (dx, dy);
311 map && (mapx -= map->width);
312 break;
313 }
314
315 --max_distance;
316 }
317
318 if (!max_distance)
319 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
320 else if (map && map->path[0])
321 {
322 int flags = 0;
323
324 if (map->tile_path[0]) flags |= 1;
325 if (map->tile_path[1]) flags |= 2;
326 if (map->tile_path[2]) flags |= 4;
327 if (map->tile_path[3]) flags |= 8;
328
329 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
330 }
331 else 386 else
332 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 387#endif
388 pl->ns->mapinfo_queue.push_back (copy);
333 } 389 }
334 else 390 else
335 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 391 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
336
337 pl->ns->send_packet (bigbuf);
338} 392}
339 393
340/** This is the Setup cmd */ 394/** This is the Setup cmd */
341void 395void
342SetUp (char *buf, int len, client * ns) 396SetUp (char *buf, int len, client * ns)
… …
512void 566void
513NewPlayerCmd (char *buf, int len, player *pl) 567NewPlayerCmd (char *buf, int len, player *pl)
514{ 568{
515 if (len <= 6) 569 if (len <= 6)
516 { 570 {
517 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 571 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
518 return; 572 return;
519 } 573 }
520 574
521 uint16 cmdid = net_uint16 ((uint8 *)buf); 575 uint16 cmdid = net_uint16 ((uint8 *)buf);
522 sint32 repeat = net_sint32 ((uint8 *)buf + 2); 576 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
… …
660 * syntax is: move (to) (tag) (nrof) 714 * syntax is: move (to) (tag) (nrof)
661 */ 715 */
662void 716void
663MoveCmd (char *buf, int len, player *pl) 717MoveCmd (char *buf, int len, player *pl)
664{ 718{
665 int vals[3], i; 719 int to, tag, nrof;
666 720
667 /* A little funky here. We only cycle for 2 records, because 721 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
668 * we obviously are not going to find a space after the third
669 * record. Perhaps we should just replace this with a
670 * sscanf?
671 */
672 for (i = 0; i < 2; i++)
673 { 722 {
674 vals[i] = atoi (buf);
675
676 if (!(buf = strchr (buf, ' ')))
677 {
678 LOG (llevError, "Incomplete move command: %s\n", buf); 723 LOG (llevError, "Incomplete move command: %s\n", buf);
679 return; 724 return;
680 }
681
682 buf++;
683 } 725 }
684 726
685 vals[2] = atoi (buf); 727 esrv_move_object (pl->ob, to, tag, nrof);
686
687/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
688 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
689} 728}
690 729
691/****************************************************************************** 730/******************************************************************************
692 * 731 *
693 * Start of commands the server sends to the client. 732 * Start of commands the server sends to the client.
… …
860 899
861/** 900/**
862 * Tells the client that here is a player it should start using. 901 * Tells the client that here is a player it should start using.
863 */ 902 */
864void 903void
865esrv_new_player (player *pl, uint32 weight) 904esrv_new_player (player *pl)
866{ 905{
906 sint32 weight = pl->ob->client_weight ();
907
867 packet sl ("player"); 908 packet sl ("player");
868 909
869 sl << uint32 (pl->ob->count) 910 sl << uint32 (pl->ob->count)
870 << uint32 (weight) 911 << uint32 (weight)
871 << uint32 (pl->ob->face) 912 << uint32 (pl->ob->face)
… …
938 979
939 if (!ns.faces_sent[face_num]) 980 if (!ns.faces_sent[face_num])
940 if (ob) 981 if (ob)
941 ns.send_faces (ob); 982 ns.send_faces (ob);
942 else 983 else
943 ns.send_face (face_num); 984 ns.send_face (face_num, 10);
944 985
945 sl << uint16 (face_num); 986 sl << uint16 (face_num);
946 return 1; 987 return 1;
947 } 988 }
948 989
… …
1005 1046
1006 /* If player is just joining the game, he isn't here yet, so the map 1047 /* If player is just joining the game, he isn't here yet, so the map
1007 * can get swapped out. If so, don't try to send them a map. All will 1048 * can get swapped out. If so, don't try to send them a map. All will
1008 * be OK once they really log in. 1049 * be OK once they really log in.
1009 */ 1050 */
1010 if (!plmap || plmap->in_memory != MAP_IN_MEMORY) 1051 if (!plmap || plmap->in_memory != MAP_ACTIVE)
1011 return; 1052 return;
1012 1053
1013 int x, y, ax, ay, startlen, max_x, max_y, oldlen; 1054 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1014 int estartlen, eoldlen; 1055 int estartlen, eoldlen;
1015 uint8 eentrysize; 1056 uint8 eentrysize;
… …
1103 1144
1104 if (!m) 1145 if (!m)
1105 { 1146 {
1106 nx = x; ny = y; m = plmap; 1147 nx = x; ny = y; m = plmap;
1107 1148
1108 if (!xy_normalise (m, nx, ny)) 1149 if (xy_normalise (m, nx, ny))
1150 m->touch ();
1151 else
1109 m = 0; 1152 m = 0;
1110 } 1153 }
1111 1154
1112 int emask, mask; 1155 int emask, mask;
1113 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1156 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
… …
1130 } 1173 }
1131 1174
1132 continue; 1175 continue;
1133 } 1176 }
1134 1177
1135 m->touch ();
1136
1137 int d = pl->blocked_los[ax][ay]; 1178 int d = pl->blocked_los[ax][ay];
1138 1179
1139 if (d > 3) 1180 if (d > 3)
1140 { 1181 {
1141 1182
… …
1216 uint8 flags = 0; 1257 uint8 flags = 0;
1217 tag_t player = 0; 1258 tag_t player = 0;
1218 1259
1219 // send hp information, if applicable 1260 // send hp information, if applicable
1220 if (object *op = ms.faces_obj [0]) 1261 if (object *op = ms.faces_obj [0])
1262 if (op->is_head () && !op->invisible)
1221 { 1263 {
1222 if (op->head || op->invisible) 1264 if (op->stats.maxhp > op->stats.hp
1223 ; // do not show 1265 && op->stats.maxhp > 0
1224 else if (op->type == PLAYER 1266 && (op->type == PLAYER
1267 || op->type == DOOR // does not work, have maxhp 0
1225 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1268 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)))
1226 {
1227 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
1228 { 1269 {
1229 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp; 1270 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1230 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge 1271 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1231 } 1272 }
1232 }
1233 1273
1234 if (op->msg && op->msg[0] == '@') 1274 if (op->msg && op->msg[0] == '@')
1235 flags |= 1; 1275 flags |= 1;
1236 1276
1237 if (op->type == PLAYER && op != ob) 1277 if (op->type == PLAYER && op != ob)
1238 player = op->count; 1278 player = op->count;
1239 } 1279 }
1240 1280
1241 if (lastcell.stat_hp != stat_hp) 1281 if (lastcell.stat_hp != stat_hp)
1242 { 1282 {
1243 lastcell.stat_hp = stat_hp; 1283 lastcell.stat_hp = stat_hp;
1244 1284
… …
1395 sl << "replyinfo skill_info\n"; 1435 sl << "replyinfo skill_info\n";
1396 1436
1397 for (int i = 1; i < NUM_SKILLS; i++) 1437 for (int i = 1; i < NUM_SKILLS; i++)
1398 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1438 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
1399 1439
1400 if (sl.length () >= MAXSOCKBUF) 1440 if (sl.length () > MAXSOCKBUF)
1401 { 1441 {
1402 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1442 LOG (llevError, "Buffer overflow in send_skill_info!\n");
1403 fatal (0); 1443 fatal (0);
1404 } 1444 }
1405 1445
… …
1418 sl << "replyinfo spell_paths\n"; 1458 sl << "replyinfo spell_paths\n";
1419 1459
1420 for (int i = 0; i < NRSPELLPATHS; i++) 1460 for (int i = 0; i < NRSPELLPATHS; i++)
1421 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1461 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
1422 1462
1423 if (sl.length () >= MAXSOCKBUF) 1463 if (sl.length () > MAXSOCKBUF)
1424 { 1464 {
1425 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1465 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
1426 fatal (0); 1466 fatal (0);
1427 } 1467 }
1428 1468
… …
1447 if (spell->type == SPELL) 1487 if (spell->type == SPELL)
1448 { 1488 {
1449 int flags = 0; 1489 int flags = 0;
1450 1490
1451 /* check if we need to update it */ 1491 /* check if we need to update it */
1452 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 1492 if (spell->cached_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
1453 { 1493 {
1454 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1494 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1455 flags |= UPD_SP_MANA; 1495 flags |= UPD_SP_MANA;
1456 } 1496 }
1457 1497
1458 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 1498 if (spell->cached_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
1459 { 1499 {
1460 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1500 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1461 flags |= UPD_SP_GRACE; 1501 flags |= UPD_SP_GRACE;
1462 } 1502 }
1463 1503
1464 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 1504 if (spell->cached_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
1465 { 1505 {
1466 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1506 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1467 flags |= UPD_SP_DAMAGE; 1507 flags |= UPD_SP_DAMAGE;
1468 } 1508 }
1469 1509
1470 if (flags) 1510 if (flags)
1471 { 1511 {
… …
1473 1513
1474 sl << "updspell " 1514 sl << "updspell "
1475 << uint8 (flags) 1515 << uint8 (flags)
1476 << uint32 (spell->count); 1516 << uint32 (spell->count);
1477 1517
1478 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1518 if (flags & UPD_SP_MANA ) sl << uint16 (spell->cached_sp);
1479 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1519 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->cached_grace);
1480 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1520 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->cached_eat);
1481 1521
1482 pl->ns->send_packet (sl); 1522 pl->ns->send_packet (sl);
1483 } 1523 }
1484 } 1524 }
1485 } 1525 }
… …
1515 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1555 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
1516 return; 1556 return;
1517 } 1557 }
1518 1558
1519 /* store costs and damage in the object struct, to compare to later */ 1559 /* store costs and damage in the object struct, to compare to later */
1520 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1560 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1521 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1561 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1522 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1562 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1523 1563
1524 /* figure out which skill it uses, if it uses one */ 1564 /* figure out which skill it uses, if it uses one */
1525 if (spell->skill) 1565 if (spell->skill)
1526 { 1566 {
1527 for (i = 1; i < NUM_SKILLS; i++) 1567 for (i = 1; i < NUM_SKILLS; i++)
… …
1537 { 1577 {
1538 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name); 1578 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1539 spell->face = face_find ("burnout.x11", blank_face); 1579 spell->face = face_find ("burnout.x11", blank_face);
1540 } 1580 }
1541 1581
1582 pl->ns->send_face (spell->face);
1583
1542 /* send the current values */ 1584 /* send the current values */
1543 sl << uint32 (spell->count) 1585 sl << uint32 (spell->count)
1544 << uint16 (spell->level) 1586 << uint16 (spell->level)
1545 << uint16 (spell->casting_time) 1587 << uint16 (spell->casting_time)
1546 << uint16 (spell->last_sp) 1588 << uint16 (spell->cached_sp)
1547 << uint16 (spell->last_grace) 1589 << uint16 (spell->cached_grace)
1548 << uint16 (spell->last_eat) 1590 << uint16 (spell->cached_eat)
1549 << uint8 (skill) 1591 << uint8 (skill)
1550 << uint32 (spell->path_attuned) 1592 << uint32 (spell->path_attuned)
1551 << uint32 (spell->face) 1593 << uint32 (spell->face)
1552 << data8 (spell->name) 1594 << data8 (spell->name)
1553 << data16 (spell->msg); 1595 << data16 (spell->msg);
… …
1581 * bytes and 3 strings (because that is the spec) so we need to 1623 * bytes and 3 strings (because that is the spec) so we need to
1582 * check that the length of those 3 strings, plus the 23 bytes, 1624 * check that the length of those 3 strings, plus the 23 bytes,
1583 * won't take us over the length limit for the socket, if it does, 1625 * won't take us over the length limit for the socket, if it does,
1584 * we need to send what we already have, and restart packet formation 1626 * we need to send what we already have, and restart packet formation
1585 */ 1627 */
1628 if (spell->type != SPELL)
1629 continue;
1630
1586 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1631 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
1587 * to show add_spell is 26 bytes + 2 strings. However, the overun 1632 * to show add_spell is 26 bytes + 2 strings. However, the overun
1588 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1633 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
1589 * like it will fix this 1634 * like it will fix this
1590 */ 1635 */
1591 if (spell->type != SPELL)
1592 continue;
1593
1594 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1636 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
1595 { 1637 {
1638 pl->ns->flush_fx ();
1596 pl->ns->send_packet (sl); 1639 pl->ns->send_packet (sl);
1597 1640
1598 sl.reset (); 1641 sl.reset ();
1599 sl << "addspell "; 1642 sl << "addspell ";
1600 } 1643 }
… …
1608 return; 1651 return;
1609 } 1652 }
1610 else 1653 else
1611 append_spell (pl, sl, spell); 1654 append_spell (pl, sl, spell);
1612 1655
1613 if (sl.length () >= MAXSOCKBUF) 1656 if (sl.length () > MAXSOCKBUF)
1614 { 1657 {
1615 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1658 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
1616 fatal (0); 1659 fatal (0);
1617 } 1660 }
1618 1661
1619 /* finally, we can send the packet */ 1662 /* finally, we can send the packet */
1663 pl->ns->flush_fx ();
1620 pl->ns->send_packet (sl); 1664 pl->ns->send_packet (sl);
1621} 1665}
1622 1666

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines