ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.108 by root, Sat Jun 9 20:51:45 2007 UTC vs.
Revision 1.129 by root, Tue May 6 19:37:01 2008 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Multiplayer Online Role Playing Game. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software; you can redistribute it and/or modify it 8 * Deliantra is free software: you can redistribute it and/or modify
9 * under the terms of the GNU General Public License as published by the Free 9 * it under the terms of the GNU General Public License as published by
10 * Software Foundation; either version 2 of the License, or (at your option) 10 * the Free Software Foundation, either version 3 of the License, or
11 * any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, but 13 * This program is distributed in the hope that it will be useful,
14 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License along 18 * You should have received a copy of the GNU General Public License
19 * with Crossfire TRT; if not, write to the Free Software Foundation, Inc. 51 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
21 * 20 *
22 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/** 24/**
26 * \file 25 * \file
27 * Client handling. 26 * Client handling.
… …
130} 129}
131 130
132static void 131static void
133clear_map (player *pl) 132clear_map (player *pl)
134{ 133{
134 pl->ns->mapinfo_queue_clear ();
135
135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap)); 136 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
136 137
137 pl->ns->force_newmap = false; 138 pl->ns->force_newmap = false;
138 139
139 if (pl->ns->newmapcmd == 1) 140 if (pl->ns->newmapcmd == 1)
… …
191 socket.current_y = ob->y; 192 socket.current_y = ob->y;
192 193
193 region *reg = ob->region (); 194 region *reg = ob->region ();
194 if (socket.current_region != reg) 195 if (socket.current_region != reg)
195 { 196 {
197 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
196 socket.current_region = reg; 198 socket.current_region = reg;
197 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
198 } 199 }
199} 200}
200 201
201/** 202/**
202 * RequestInfo is sort of a meta command. There is some specific 203 * RequestInfo is sort of a meta command. There is some specific
203 * request of information, but we call other functions to provide 204 * request of information, but we call other functions to provide
204 * that information. 205 * that information.
205 */ 206 */
206void 207void
207RequestInfo (char *buf, int len, client * ns) 208RequestInfo (char *buf, int len, client *ns)
208{ 209{
209 char *params = NULL, *cp; 210 char *params;
210
211 /* No match */
212 char bigbuf[MAX_BUF];
213 int slen;
214
215 /* Set up replyinfo before we modify any of the buffers - this is used
216 * if we don't find a match.
217 */
218 strcpy (bigbuf, "replyinfo ");
219 slen = strlen (bigbuf);
220 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
221 211
222 /* find the first space, make it null, and update the 212 /* find the first space, make it null, and update the
223 * params pointer. 213 * params pointer.
224 */ 214 */
225 for (cp = buf; *cp != '\0'; cp++) 215 for (params = buf; *params; params++)
226 if (*cp == ' ') 216 if (*params == ' ')
227 { 217 {
228 *cp = '\0';
229 params = cp + 1; 218 *params++ = 0;
230 break; 219 break;
231 } 220 }
232 221
233 if (!strcmp (buf, "image_info")) 222 if (!strcmp (buf, "image_info"))
234 send_image_info (ns, params); 223 send_image_info (ns, params);
… …
237 else if (!strcmp (buf, "skill_info")) 226 else if (!strcmp (buf, "skill_info"))
238 send_skill_info (ns, params); 227 send_skill_info (ns, params);
239 else if (!strcmp (buf, "spell_paths")) 228 else if (!strcmp (buf, "spell_paths"))
240 send_spell_paths (ns, params); 229 send_spell_paths (ns, params);
241 else 230 else
242 ns->send_packet (bigbuf, len); 231 {
232 // undo tokenisation above and send replyinfo with the request unchanged
233 if (*params)
234 *--params = ' ';
235
236 ns->send_packet_printf ("replyinfo %s", buf);
237 }
243} 238}
244 239
245void 240void
246ExtCmd (char *buf, int len, player *pl) 241ExtCmd (char *buf, int len, player *pl)
247{ 242{
… …
250 245
251void 246void
252ExtiCmd (char *buf, int len, client *ns) 247ExtiCmd (char *buf, int len, client *ns)
253{ 248{
254 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len)); 249 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
250}
251
252void
253client::mapinfo_queue_clear ()
254{
255 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
256 free (*i);
257
258 mapinfo_queue.clear ();
259}
260
261bool
262client::mapinfo_try (char *buf)
263{
264 char *token = buf;
265 buf += strlen (buf) + 9;
266
267 // initial map and its origin
268 maptile *map = pl->observe->map;
269 int mapx = pl->ns->mapx / 2 - pl->observe->x;
270 int mapy = pl->ns->mapy / 2 - pl->observe->y;
271 int max_distance = 8; // limit maximum path length to something generous
272
273 while (*buf && map && max_distance)
274 {
275 int dir = *buf++ - '1';
276
277 if (dir >= 0 && dir <= 3)
278 {
279 if (!map->tile_path [dir])
280 map = 0;
281 else if (map->tile_available (dir, false))
282 {
283 maptile *neigh = map->tile_map [dir];
284
285 switch (dir)
286 {
287 case 0: mapy -= neigh->height; break;
288 case 2: mapy += map ->height; break;
289 case 3: mapx -= neigh->width ; break;
290 case 1: mapx += map ->width ; break;
291 }
292
293 map = neigh;
294 --max_distance;
295 }
296 else
297 return 0;
298 }
299 else
300 max_distance = 0;
301 }
302
303 if (!max_distance)
304 send_packet_printf ("mapinfo %s error", token);
305 else if (!map || !map->path)
306 send_packet_printf ("mapinfo %s nomap", token);
307 else
308 {
309 int flags = 0;
310
311 if (map->tile_path[0]) flags |= 1;
312 if (map->tile_path[1]) flags |= 2;
313 if (map->tile_path[2]) flags |= 4;
314 if (map->tile_path[3]) flags |= 8;
315
316 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
317 }
318
319 return 1;
320}
321
322void
323client::mapinfo_queue_run ()
324{
325 if (mapinfo_queue.empty () || !pl)
326 return;
327
328 for (int i = 0; i < mapinfo_queue.size (); ++i)
329 if (mapinfo_try (mapinfo_queue [i]))
330 {
331 free (mapinfo_queue [i]);
332 mapinfo_queue.erase (i);
333 }
334 else
335 ++i;
255} 336}
256 337
257void 338void
258MapInfoCmd (char *buf, int len, player *pl) 339MapInfoCmd (char *buf, int len, player *pl)
259{ 340{
260 // <mapinfo tag spatial tile-path 341 // <mapinfo tag spatial tile-path
261 // >mapinfo tag spatial flags x y w h hash 342 // >mapinfo tag spatial flags x y w h hash
262 343
263 char bigbuf[MAX_BUF], *token;
264
265 token = buf; 344 char *token = buf;
266 // copy token 345
267 if (!(buf = strchr (buf, ' '))) 346 if (!(buf = strchr (buf, ' ')))
268 return; 347 return;
269 348
270 *buf++ = 0;
271
272 if (!strncmp (buf, "spatial ", 8)) 349 if (!strncmp (buf, " spatial ", 9))
273 { 350 {
274 buf += 8; 351 char *copy = strdup (token);
352 copy [buf - token] = 0;
275 353
276 // initial map and its origin 354#if 0
277 maptile *map = pl->ob->map; 355 // this makes only sense when we flush the buffer immediately
278 sint16 dx, dy; 356 if (pl->ns->mapinfo_try (copy))
279 int mapx = pl->ns->mapx / 2 - pl->ob->x; 357 free (copy);
280 int mapy = pl->ns->mapy / 2 - pl->ob->y;
281 int max_distance = 8; // limit maximum path length to something generous
282
283 while (*buf && map && max_distance)
284 {
285 int dir = *buf++;
286
287 switch (dir)
288 {
289 case '1':
290 dx = 0;
291 dy = -1;
292 map = map->xy_find (dx, dy);
293 map && (mapy -= map->height);
294 break;
295 case '2':
296 mapx += map->width;
297 dx = map->width;
298 dy = 0;
299 map = map->xy_find (dx, dy);
300 break;
301 case '3':
302 mapy += map->height;
303 dx = 0;
304 dy = map->height;
305 map = map->xy_find (dx, dy);
306 break;
307 case '4':
308 dx = -1;
309 dy = 0;
310 map = map->xy_find (dx, dy);
311 map && (mapx -= map->width);
312 break;
313 }
314
315 --max_distance;
316 }
317
318 if (!max_distance)
319 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
320 else if (map && map->path[0])
321 {
322 int flags = 0;
323
324 if (map->tile_path[0]) flags |= 1;
325 if (map->tile_path[1]) flags |= 2;
326 if (map->tile_path[2]) flags |= 4;
327 if (map->tile_path[3]) flags |= 8;
328
329 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
330 }
331 else 358 else
332 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 359#endif
360 pl->ns->mapinfo_queue.push_back (copy);
333 } 361 }
334 else 362 else
335 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 363 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
336
337 pl->ns->send_packet (bigbuf);
338} 364}
339 365
340/** This is the Setup cmd */ 366/** This is the Setup cmd */
341void 367void
342SetUp (char *buf, int len, client * ns) 368SetUp (char *buf, int len, client * ns)
… …
471 497
472 ns->send_packet (cmdback); 498 ns->send_packet (cmdback);
473} 499}
474 500
475/** 501/**
476 * client requested an image. send it rate-limited
477 * before flushing.
478 */
479void
480AskFaceCmd (char *buf, int len, client *ns)
481{
482 ns->askface.push_back (atoi (buf));
483}
484
485/**
486 * Tells client the picture it has to use
487 * to smooth a picture number given as argument.
488 */
489void
490AskSmooth (char *buf, int len, client *ns)
491{
492 ns->send_face (atoi (buf));
493 ns->flush_fx ();
494}
495
496/**
497 * This handles the general commands from the client (ie, north, fire, cast, 502 * This handles the general commands from the client (ie, north, fire, cast,
498 * etc.) 503 * etc.)
499 */ 504 */
500void 505void
501PlayerCmd (char *buf, int len, player *pl) 506PlayerCmd (char *buf, int len, player *pl)
… …
533void 538void
534NewPlayerCmd (char *buf, int len, player *pl) 539NewPlayerCmd (char *buf, int len, player *pl)
535{ 540{
536 if (len <= 6) 541 if (len <= 6)
537 { 542 {
538 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 543 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
539 return; 544 return;
540 } 545 }
541 546
542 uint16 cmdid = net_uint16 ((uint8 *)buf); 547 uint16 cmdid = net_uint16 ((uint8 *)buf);
543 sint32 repeat = net_sint32 ((uint8 *)buf + 2); 548 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
… …
681 * syntax is: move (to) (tag) (nrof) 686 * syntax is: move (to) (tag) (nrof)
682 */ 687 */
683void 688void
684MoveCmd (char *buf, int len, player *pl) 689MoveCmd (char *buf, int len, player *pl)
685{ 690{
686 int vals[3], i; 691 int to, tag, nrof;
687 692
688 /* A little funky here. We only cycle for 2 records, because 693 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
689 * we obviously are not going to find a space after the third
690 * record. Perhaps we should just replace this with a
691 * sscanf?
692 */
693 for (i = 0; i < 2; i++)
694 { 694 {
695 vals[i] = atoi (buf);
696
697 if (!(buf = strchr (buf, ' ')))
698 {
699 LOG (llevError, "Incomplete move command: %s\n", buf); 695 LOG (llevError, "Incomplete move command: %s\n", buf);
700 return; 696 return;
701 }
702
703 buf++;
704 } 697 }
705 698
706 vals[2] = atoi (buf); 699 esrv_move_object (pl->ob, to, tag, nrof);
707
708/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
709 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
710} 700}
711 701
712/****************************************************************************** 702/******************************************************************************
713 * 703 *
714 * Start of commands the server sends to the client. 704 * Start of commands the server sends to the client.
… …
747 737
748 //TODO: maybe golem should become the current_weapon, quite simply? 738 //TODO: maybe golem should become the current_weapon, quite simply?
749 if (pl->golem) 739 if (pl->golem)
750 buf << " Golem*: " << pl->golem->name; 740 buf << " Golem*: " << pl->golem->name;
751 741
742 buf << '\0';
752 buf.linearise (obuf); 743 buf.linearise (obuf);
753 obuf [buf.size ()] = 0;
754} 744}
755 745
756#define AddIfInt64(Old,New,Type) if (Old != New) {\ 746#define AddIfInt64(Old,New,Type) if (Old != New) {\
757 Old = New; \ 747 Old = New; \
758 sl << uint8 (Type) << uint64 (New); \ 748 sl << uint8 (Type) << uint64 (New); \
… …
881 871
882/** 872/**
883 * Tells the client that here is a player it should start using. 873 * Tells the client that here is a player it should start using.
884 */ 874 */
885void 875void
886esrv_new_player (player *pl, uint32 weight) 876esrv_new_player (player *pl)
887{ 877{
878 sint32 weight = pl->ob->client_weight ();
879
888 packet sl ("player"); 880 packet sl ("player");
889 881
890 sl << uint32 (pl->ob->count) 882 sl << uint32 (pl->ob->count)
891 << uint32 (weight) 883 << uint32 (weight)
892 << uint32 (pl->ob->face) 884 << uint32 (pl->ob->face)
… …
959 951
960 if (!ns.faces_sent[face_num]) 952 if (!ns.faces_sent[face_num])
961 if (ob) 953 if (ob)
962 ns.send_faces (ob); 954 ns.send_faces (ob);
963 else 955 else
964 ns.send_face (face_num); 956 ns.send_face (face_num, 10);
965 957
966 sl << uint16 (face_num); 958 sl << uint16 (face_num);
967 return 1; 959 return 1;
968 } 960 }
969 961
… …
1026 1018
1027 /* If player is just joining the game, he isn't here yet, so the map 1019 /* If player is just joining the game, he isn't here yet, so the map
1028 * can get swapped out. If so, don't try to send them a map. All will 1020 * can get swapped out. If so, don't try to send them a map. All will
1029 * be OK once they really log in. 1021 * be OK once they really log in.
1030 */ 1022 */
1031 if (!plmap || plmap->in_memory != MAP_IN_MEMORY) 1023 if (!plmap || plmap->in_memory != MAP_ACTIVE)
1032 return; 1024 return;
1033 1025
1034 int x, y, ax, ay, startlen, max_x, max_y, oldlen; 1026 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1035 int estartlen, eoldlen; 1027 int estartlen, eoldlen;
1036 uint8 eentrysize; 1028 uint8 eentrysize;
… …
1124 1116
1125 if (!m) 1117 if (!m)
1126 { 1118 {
1127 nx = x; ny = y; m = plmap; 1119 nx = x; ny = y; m = plmap;
1128 1120
1129 if (!xy_normalise (m, nx, ny)) 1121 if (xy_normalise (m, nx, ny))
1122 m->touch ();
1123 else
1130 m = 0; 1124 m = 0;
1131 } 1125 }
1132 1126
1133 int emask, mask; 1127 int emask, mask;
1134 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1128 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
… …
1151 } 1145 }
1152 1146
1153 continue; 1147 continue;
1154 } 1148 }
1155 1149
1156 m->touch ();
1157
1158 int d = pl->blocked_los[ax][ay]; 1150 int d = pl->blocked_los[ax][ay];
1159 1151
1160 if (d > 3) 1152 if (d > 3)
1161 { 1153 {
1162 1154
… …
1237 uint8 flags = 0; 1229 uint8 flags = 0;
1238 tag_t player = 0; 1230 tag_t player = 0;
1239 1231
1240 // send hp information, if applicable 1232 // send hp information, if applicable
1241 if (object *op = ms.faces_obj [0]) 1233 if (object *op = ms.faces_obj [0])
1234 if (op->is_head () && !op->invisible)
1242 { 1235 {
1243 if (op->head || op->invisible) 1236 if (op->stats.maxhp > op->stats.hp
1244 ; // do not show 1237 && op->stats.maxhp > 0
1245 else if (op->type == PLAYER 1238 && (op->type == PLAYER
1239 || op->type == DOOR // does not work, have maxhp 0
1246 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1240 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)))
1247 {
1248 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
1249 { 1241 {
1250 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp; 1242 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1251 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge 1243 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1252 } 1244 }
1253 }
1254 1245
1255 if (op->msg && op->msg[0] == '@') 1246 if (op->msg && op->msg[0] == '@')
1256 flags |= 1; 1247 flags |= 1;
1257 1248
1258 if (op->type == PLAYER && op != ob) 1249 if (op->type == PLAYER && op != ob)
1259 player = op->count; 1250 player = op->count;
1260 } 1251 }
1261 1252
1262 if (lastcell.stat_hp != stat_hp) 1253 if (lastcell.stat_hp != stat_hp)
1263 { 1254 {
1264 lastcell.stat_hp = stat_hp; 1255 lastcell.stat_hp = stat_hp;
1265 1256
… …
1416 sl << "replyinfo skill_info\n"; 1407 sl << "replyinfo skill_info\n";
1417 1408
1418 for (int i = 1; i < NUM_SKILLS; i++) 1409 for (int i = 1; i < NUM_SKILLS; i++)
1419 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1410 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
1420 1411
1421 if (sl.length () >= MAXSOCKBUF) 1412 if (sl.length () > MAXSOCKBUF)
1422 { 1413 {
1423 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1414 LOG (llevError, "Buffer overflow in send_skill_info!\n");
1424 fatal (0); 1415 fatal (0);
1425 } 1416 }
1426 1417
… …
1439 sl << "replyinfo spell_paths\n"; 1430 sl << "replyinfo spell_paths\n";
1440 1431
1441 for (int i = 0; i < NRSPELLPATHS; i++) 1432 for (int i = 0; i < NRSPELLPATHS; i++)
1442 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1433 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
1443 1434
1444 if (sl.length () >= MAXSOCKBUF) 1435 if (sl.length () > MAXSOCKBUF)
1445 { 1436 {
1446 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1437 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
1447 fatal (0); 1438 fatal (0);
1448 } 1439 }
1449 1440
… …
1557 if (!spell->face) 1548 if (!spell->face)
1558 { 1549 {
1559 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name); 1550 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1560 spell->face = face_find ("burnout.x11", blank_face); 1551 spell->face = face_find ("burnout.x11", blank_face);
1561 } 1552 }
1553
1554 pl->ns->send_face (spell->face);
1562 1555
1563 /* send the current values */ 1556 /* send the current values */
1564 sl << uint32 (spell->count) 1557 sl << uint32 (spell->count)
1565 << uint16 (spell->level) 1558 << uint16 (spell->level)
1566 << uint16 (spell->casting_time) 1559 << uint16 (spell->casting_time)
… …
1602 * bytes and 3 strings (because that is the spec) so we need to 1595 * bytes and 3 strings (because that is the spec) so we need to
1603 * check that the length of those 3 strings, plus the 23 bytes, 1596 * check that the length of those 3 strings, plus the 23 bytes,
1604 * won't take us over the length limit for the socket, if it does, 1597 * won't take us over the length limit for the socket, if it does,
1605 * we need to send what we already have, and restart packet formation 1598 * we need to send what we already have, and restart packet formation
1606 */ 1599 */
1600 if (spell->type != SPELL)
1601 continue;
1602
1607 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1603 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
1608 * to show add_spell is 26 bytes + 2 strings. However, the overun 1604 * to show add_spell is 26 bytes + 2 strings. However, the overun
1609 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1605 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
1610 * like it will fix this 1606 * like it will fix this
1611 */ 1607 */
1612 if (spell->type != SPELL)
1613 continue;
1614
1615 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1608 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
1616 { 1609 {
1610 pl->ns->flush_fx ();
1617 pl->ns->send_packet (sl); 1611 pl->ns->send_packet (sl);
1618 1612
1619 sl.reset (); 1613 sl.reset ();
1620 sl << "addspell "; 1614 sl << "addspell ";
1621 } 1615 }
… …
1629 return; 1623 return;
1630 } 1624 }
1631 else 1625 else
1632 append_spell (pl, sl, spell); 1626 append_spell (pl, sl, spell);
1633 1627
1634 if (sl.length () >= MAXSOCKBUF) 1628 if (sl.length () > MAXSOCKBUF)
1635 { 1629 {
1636 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1630 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
1637 fatal (0); 1631 fatal (0);
1638 } 1632 }
1639 1633
1640 /* finally, we can send the packet */ 1634 /* finally, we can send the packet */
1635 pl->ns->flush_fx ();
1641 pl->ns->send_packet (sl); 1636 pl->ns->send_packet (sl);
1642} 1637}
1643 1638

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines