ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.108 by root, Sat Jun 9 20:51:45 2007 UTC vs.
Revision 1.193 by root, Wed Nov 16 23:42:03 2016 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Multiplayer Online Role Playing Game. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008,2009,2010,2011,2012,2013,2014,2015,2016 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel 5 * Copyright (©) 2001 Mark Wedel
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software; you can redistribute it and/or modify it 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * under the terms of the GNU General Public License as published by the Free 9 * the terms of the Affero GNU General Public License as published by the
10 * Software Foundation; either version 2 of the License, or (at your option) 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, but 13 * This program is distributed in the hope that it will be useful,
14 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License along 18 * You should have received a copy of the Affero GNU General Public License
19 * with Crossfire TRT; if not, write to the Free Software Foundation, Inc. 51 19 * and the GNU General Public License along with this program. If not, see
20 * Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA 20 * <http://www.gnu.org/licenses/>.
21 * 21 *
22 * The authors can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 23 */
24
25//+GPL
24 26
25/** 27/**
26 * \file 28 * \file
27 * Client handling. 29 * Client handling.
28 * 30 *
42 44
43#include <global.h> 45#include <global.h>
44#include <sproto.h> 46#include <sproto.h>
45 47
46#include <living.h> 48#include <living.h>
47#include <commands.h>
48 49
49/* This block is basically taken from socket.c - I assume if it works there, 50/* This block is basically taken from socket.c - I assume if it works there,
50 * it should work here. 51 * it should work here.
51 */ 52 */
52#include <sys/types.h> 53#include <sys/types.h>
64 * This table translates the attack numbers as used within the 65 * This table translates the attack numbers as used within the
65 * program to the value we use when sending STATS command to the 66 * program to the value we use when sending STATS command to the
66 * client. If a value is -1, then we don't send that to the 67 * client. If a value is -1, then we don't send that to the
67 * client. 68 * client.
68 */ 69 */
69short atnr_cs_stat[NROFATTACKS] = { CS_STAT_RES_PHYS, 70static short atnr_cs_stat[NROFATTACKS] =
70 CS_STAT_RES_MAG, CS_STAT_RES_FIRE, CS_STAT_RES_ELEC, 71{
71 CS_STAT_RES_COLD, CS_STAT_RES_CONF, CS_STAT_RES_ACID, 72 CS_STAT_RES_PHYS,
72 CS_STAT_RES_DRAIN, -1 /* weaponmagic */ , 73 CS_STAT_RES_MAG,
73 CS_STAT_RES_GHOSTHIT, CS_STAT_RES_POISON, 74 CS_STAT_RES_FIRE,
74 CS_STAT_RES_SLOW, CS_STAT_RES_PARA, CS_STAT_TURN_UNDEAD, 75 CS_STAT_RES_ELEC,
75 CS_STAT_RES_FEAR, -1 /* Cancellation */ , 76 CS_STAT_RES_COLD,
76 CS_STAT_RES_DEPLETE, CS_STAT_RES_DEATH, 77 CS_STAT_RES_CONF,
77 -1 /* Chaos */ , -1 /* Counterspell */ , 78 CS_STAT_RES_ACID,
78 -1 /* Godpower */ , CS_STAT_RES_HOLYWORD, 79 CS_STAT_RES_DRAIN,
80 -1 /* weaponmagic */,
81 CS_STAT_RES_GHOSTHIT,
82 CS_STAT_RES_POISON,
83 CS_STAT_RES_SLOW,
84 CS_STAT_RES_PARA,
85 CS_STAT_TURN_UNDEAD,
86 CS_STAT_RES_FEAR,
87 -1 /* Cancellation */,
88 CS_STAT_RES_DEPLETE,
89 CS_STAT_RES_DEATH,
90 -1 /* Chaos */,
91 -1 /* Counterspell */,
92 -1 /* Godpower */,
93 CS_STAT_RES_HOLYWORD,
79 CS_STAT_RES_BLIND, 94 CS_STAT_RES_BLIND,
80 -1, /* Internal */ 95 -1, /* Internal */
81 -1, /* life stealing */ 96 -1, /* life stealing */
82 -1 /* Disease - not fully done yet */ 97 -1 /* Disease - not fully done yet */
83}; 98};
99 */ 114 */
100 mx = ns->mapx; 115 mx = ns->mapx;
101 my = ns->mapy; 116 my = ns->mapy;
102 117
103 /* the x and y here are coordinates for the new map, i.e. if we moved 118 /* the x and y here are coordinates for the new map, i.e. if we moved
104 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 119 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
105 * if the destination x or y coordinate is outside the viewable 120 * if the destination x or y coordinate is outside the viewable
106 * area, we clear the values - otherwise, the old values 121 * area, we clear the values - otherwise, the old values
107 * are preserved, and the check_head thinks it needs to clear them. 122 * are preserved, and the check_head thinks it needs to clear them.
108 */ 123 */
109 for (x = 0; x < mx; x++) 124 for (x = 0; x < mx; x++)
110 {
111 for (y = 0; y < my; y++) 125 for (y = 0; y < my; y++)
112 {
113 if (x >= ns->mapx || y >= ns->mapy) 126 if (x >= ns->mapx || y >= ns->mapy)
114 /* clear cells outside the viewable area */ 127 /* clear cells outside the viewable area */
115 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell)); 128 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
116 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy) 129 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
117 /* clear newly visible tiles within the viewable area */ 130 /* clear newly visible tiles within the viewable area */
118 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell)); 131 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
119 else 132 else
120 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell)); 133 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
121 }
122 }
123 134
124 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map)); 135 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
125 136
126 /* Make sure that the next "map1" command will be sent (even if it is 137 /* Make sure that the next "map1" command will be sent (even if it is
127 * empty). 138 * empty).
130} 141}
131 142
132static void 143static void
133clear_map (player *pl) 144clear_map (player *pl)
134{ 145{
146 pl->ns->mapinfo_queue_clear ();
147
135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap)); 148 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
136 149
137 pl->ns->force_newmap = false; 150 pl->ns->force_newmap = false;
138
139 if (pl->ns->newmapcmd == 1)
140 pl->ns->send_packet ("newmap"); 151 pl->ns->send_packet ("newmap");
141
142 pl->ns->floorbox_reset (); 152 pl->ns->floorbox_reset ();
153}
154
155static void
156send_map_info (player *pl)
157{
158 client &socket = *pl->ns;
159 object *ob = pl->viewpoint;
160
161 if (socket.mapinfocmd)
162 {
163 if (ob->map && ob->map->path)
164 {
165 int flags = 0;
166
167 // due to historical glitches, the bit ordering and map index ordering differs
168 if (ob->map->tile_path [TILE_NORTH]) flags |= 0x01;
169 if (ob->map->tile_path [TILE_EAST ]) flags |= 0x02;
170 if (ob->map->tile_path [TILE_SOUTH]) flags |= 0x04;
171 if (ob->map->tile_path [TILE_WEST ]) flags |= 0x08;
172 // these two are debatable
173 if (ob->map->tile_path [TILE_UP ]) flags |= 0x10;
174 if (ob->map->tile_path [TILE_DOWN ]) flags |= 0x20;
175
176 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
177 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
178 ob->map->width, ob->map->height, &ob->map->path);
179 }
180 else
181 socket.send_packet ("mapinfo current");
182 }
143} 183}
144 184
145/** check for map/region change and send new map data */ 185/** check for map/region change and send new map data */
146static void 186static void
147check_map_change (player *pl) 187check_map_change (player *pl)
148{ 188{
149 client &socket = *pl->ns; 189 client &socket = *pl->ns;
150 object *ob = pl->observe; 190 object *ob = pl->viewpoint;
191
192 region *reg = ob->region ();
193 if (socket.current_region != reg)
194 {
195 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
196 socket.current_region = reg;
197 }
198
199 // first try to avoid a full newmap on tiled map scrolls
200 if (socket.current_map != ob->map && !socket.force_newmap)
201 {
202 rv_vector rv;
203
204 get_rangevector_from_mapcoord (socket.current_map, socket.current_x, socket.current_y, ob, &rv, 0);
205
206 // manhattan distance is very handy here
207 if (rv.distance < 8) // 8 works nicely for speed << 70 and buggy gcfclient
208 {
209 socket.current_map = ob->map;
210 socket.current_x = ob->x;
211 socket.current_y = ob->y;
212
213 socket_map_scroll (&socket, rv.distance_x, rv.distance_y);
214 socket.floorbox_reset ();
215 send_map_info (pl);
216 }
217 }
151 218
152 if (socket.current_map != ob->map || socket.force_newmap) 219 if (socket.current_map != ob->map || socket.force_newmap)
153 { 220 {
154 clear_map (pl); 221 clear_map (pl);
155 socket.current_map = ob->map; 222 socket.current_map = ob->map;
156 223 send_map_info (pl);
157 if (socket.mapinfocmd)
158 {
159 if (ob->map && ob->map->path[0])
160 {
161 int flags = 0;
162
163 if (ob->map->tile_path[0]) flags |= 1;
164 if (ob->map->tile_path[1]) flags |= 2;
165 if (ob->map->tile_path[2]) flags |= 4;
166 if (ob->map->tile_path[3]) flags |= 8;
167
168 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
169 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
170 ob->map->width, ob->map->height, &ob->map->path);
171 }
172 else
173 socket.send_packet ("mapinfo current");
174 }
175 } 224 }
176 else if (socket.current_x != ob->x || socket.current_y != ob->y) 225 else if (socket.current_x != ob->x || socket.current_y != ob->y)
177 { 226 {
178 int dx = ob->x - socket.current_x; 227 int dx = ob->x - socket.current_x;
179 int dy = ob->y - socket.current_y; 228 int dy = ob->y - socket.current_y;
180 229
181 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
182 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
183 else
184 {
185 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 230 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
186 socket.floorbox_reset (); 231 socket.floorbox_reset ();
187 }
188 } 232 }
189 233
190 socket.current_x = ob->x; 234 socket.current_x = ob->x;
191 socket.current_y = ob->y; 235 socket.current_y = ob->y;
236}
192 237
193 region *reg = ob->region (); 238/**
194 if (socket.current_region != reg) 239 * This sends the skill number to name mapping. We ignore
195 { 240 * the params - we always send the same info no matter what.
196 socket.current_region = reg; 241 */
197 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname); 242static void
198 } 243send_skill_info (client *ns, char *params)
244{
245 packet sl;
246 sl << "replyinfo skill_info\n";
247
248 for (int i = 0; i < skillvec.size (); ++i)
249 sl.printf ("%d:%s\n", CS_STAT_SKILLINFO + i, &skillvec [i]->name);
250
251 if (sl.length () > MAXSOCKBUF)
252 cleanup ("buffer overflow in send_skill_info!");
253
254 ns->send_packet (sl);
255}
256
257/**
258 * This sends the spell path to name mapping. We ignore
259 * the params - we always send the same info no matter what.
260 */
261static void
262send_spell_paths (client * ns, char *params)
263{
264 packet sl;
265
266 sl << "replyinfo spell_paths\n";
267
268 for (int i = 0; i < NRSPELLPATHS; i++)
269 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
270
271 if (sl.length () > MAXSOCKBUF)
272 cleanup ("buffer overflow in send_spell_paths!");
273
274 ns->send_packet (sl);
199} 275}
200 276
201/** 277/**
202 * RequestInfo is sort of a meta command. There is some specific 278 * RequestInfo is sort of a meta command. There is some specific
203 * request of information, but we call other functions to provide 279 * request of information, but we call other functions to provide
204 * that information. 280 * that information.
281 * requestinfo is completely deprecated, use resource exti request
282 * and the fxix or http protocols.
205 */ 283 */
206void 284void
207RequestInfo (char *buf, int len, client * ns) 285RequestInfo (char *buf, int len, client *ns)
208{ 286{
209 char *params = NULL, *cp; 287 char *params;
210
211 /* No match */
212 char bigbuf[MAX_BUF];
213 int slen;
214
215 /* Set up replyinfo before we modify any of the buffers - this is used
216 * if we don't find a match.
217 */
218 strcpy (bigbuf, "replyinfo ");
219 slen = strlen (bigbuf);
220 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
221 288
222 /* find the first space, make it null, and update the 289 /* find the first space, make it null, and update the
223 * params pointer. 290 * params pointer.
224 */ 291 */
225 for (cp = buf; *cp != '\0'; cp++) 292 for (params = buf; *params; params++)
226 if (*cp == ' ') 293 if (*params == ' ')
227 { 294 {
228 *cp = '\0';
229 params = cp + 1; 295 *params++ = 0;
230 break; 296 break;
231 } 297 }
232 298
233 if (!strcmp (buf, "image_info"))
234 send_image_info (ns, params);
235 else if (!strcmp (buf, "image_sums"))
236 send_image_sums (ns, params);
237 else if (!strcmp (buf, "skill_info")) 299 if (!strcmp (buf, "skill_info"))
238 send_skill_info (ns, params); 300 send_skill_info (ns, params);
239 else if (!strcmp (buf, "spell_paths")) 301 else if (!strcmp (buf, "spell_paths"))
240 send_spell_paths (ns, params); 302 send_spell_paths (ns, params);
241 else 303 else
242 ns->send_packet (bigbuf, len); 304 {
305 // undo tokenisation above and send replyinfo with the request unchanged
306 if (*params)
307 *--params = ' ';
308
309 ns->send_packet_printf ("replyinfo %s", buf);
310 }
243} 311}
244 312
245void 313void
246ExtCmd (char *buf, int len, player *pl) 314ExtCmd (char *buf, int len, player *pl)
247{ 315{
250 318
251void 319void
252ExtiCmd (char *buf, int len, client *ns) 320ExtiCmd (char *buf, int len, client *ns)
253{ 321{
254 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len)); 322 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
323}
324
325//-GPL
326
327void
328client::mapinfo_queue_clear ()
329{
330 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
331 free (*i);
332
333 mapinfo_queue.clear ();
334}
335
336bool
337client::mapinfo_try (char *buf)
338{
339 char *token = buf;
340 buf += strlen (buf) + 9;
341
342 // initial map and its origin
343 maptile *map = pl->viewpoint->map;
344 int mapx = pl->ns->mapx / 2 - pl->viewpoint->x;
345 int mapy = pl->ns->mapy / 2 - pl->viewpoint->y;
346 int max_distance = 8; // limit maximum path length to something generous
347
348 while (*buf && map && max_distance)
349 {
350 int dir = *buf++ - '1';
351
352 // due to historical glitches, the mapinfo index and tile index differs
353 static unsigned char dirmap [] = { TILE_NORTH, TILE_EAST, TILE_SOUTH, TILE_WEST, TILE_UP, TILE_DOWN };
354
355 // maybe we should only allow the four flat directions
356 if (IN_RANGE_EXC (dir, 0, array_length (dirmap)))
357 {
358 dir = dirmap [dir];
359
360 if (!map->tile_path [dir])
361 map = 0;
362 else if (map->tile_available (dir, false))
363 {
364 maptile *neigh = map->tile_map [dir];
365
366 switch (dir)
367 {
368 case 0: mapy -= neigh->height; break;
369 case 2: mapy += map ->height; break;
370 case 3: mapx -= neigh->width ; break;
371 case 1: mapx += map ->width ; break;
372 }
373
374 map = neigh;
375 --max_distance;
376 }
377 else
378 return 0;
379 }
380 else
381 max_distance = 0;
382 }
383
384 if (!max_distance)
385 send_packet_printf ("mapinfo %s error", token);
386 else if (!map || !map->path)
387 send_packet_printf ("mapinfo %s nomap", token);
388 else
389 {
390 int flags = 0;
391
392 // due to historical glitches, the bit ordering and map index ordering differs
393 if (map->tile_path [TILE_NORTH]) flags |= 0x01;
394 if (map->tile_path [TILE_EAST ]) flags |= 0x02;
395 if (map->tile_path [TILE_SOUTH]) flags |= 0x04;
396 if (map->tile_path [TILE_WEST ]) flags |= 0x08;
397 // these two are debatable
398 if (map->tile_path [TILE_UP ]) flags |= 0x10;
399 if (map->tile_path [TILE_DOWN ]) flags |= 0x20;
400
401 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
402 }
403
404 return 1;
405}
406
407void
408client::mapinfo_queue_run ()
409{
410 if (mapinfo_queue.empty () || !pl)
411 return;
412
413 for (int i = 0; i < mapinfo_queue.size (); ++i)
414 if (mapinfo_try (mapinfo_queue [i]))
415 {
416 free (mapinfo_queue [i]);
417 mapinfo_queue.erase (i);
418 }
419 else
420 ++i;
255} 421}
256 422
257void 423void
258MapInfoCmd (char *buf, int len, player *pl) 424MapInfoCmd (char *buf, int len, player *pl)
259{ 425{
260 // <mapinfo tag spatial tile-path 426 // <mapinfo tag spatial tile-path
261 // >mapinfo tag spatial flags x y w h hash 427 // >mapinfo tag spatial flags x y w h hash
262 428
263 char bigbuf[MAX_BUF], *token;
264
265 token = buf; 429 char *token = buf;
266 // copy token 430
267 if (!(buf = strchr (buf, ' '))) 431 if (!(buf = strchr (buf, ' ')))
268 return; 432 return;
269 433
270 *buf++ = 0;
271
272 if (!strncmp (buf, "spatial ", 8)) 434 if (!strncmp (buf, " spatial ", 9))
273 { 435 {
274 buf += 8; 436 char *copy = strdup (token);
437 copy [buf - token] = 0;
275 438
276 // initial map and its origin 439#if 0
277 maptile *map = pl->ob->map; 440 // this makes only sense when we flush the buffer immediately
278 sint16 dx, dy; 441 if (pl->ns->mapinfo_try (copy))
279 int mapx = pl->ns->mapx / 2 - pl->ob->x; 442 free (copy);
280 int mapy = pl->ns->mapy / 2 - pl->ob->y;
281 int max_distance = 8; // limit maximum path length to something generous
282
283 while (*buf && map && max_distance)
284 {
285 int dir = *buf++;
286
287 switch (dir)
288 {
289 case '1':
290 dx = 0;
291 dy = -1;
292 map = map->xy_find (dx, dy);
293 map && (mapy -= map->height);
294 break;
295 case '2':
296 mapx += map->width;
297 dx = map->width;
298 dy = 0;
299 map = map->xy_find (dx, dy);
300 break;
301 case '3':
302 mapy += map->height;
303 dx = 0;
304 dy = map->height;
305 map = map->xy_find (dx, dy);
306 break;
307 case '4':
308 dx = -1;
309 dy = 0;
310 map = map->xy_find (dx, dy);
311 map && (mapx -= map->width);
312 break;
313 }
314
315 --max_distance;
316 }
317
318 if (!max_distance)
319 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
320 else if (map && map->path[0])
321 {
322 int flags = 0;
323
324 if (map->tile_path[0]) flags |= 1;
325 if (map->tile_path[1]) flags |= 2;
326 if (map->tile_path[2]) flags |= 4;
327 if (map->tile_path[3]) flags |= 8;
328
329 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
330 }
331 else 443 else
332 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 444#endif
445 pl->ns->mapinfo_queue.push_back (copy);
333 } 446 }
334 else 447 else
335 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 448 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
336
337 pl->ns->send_packet (bigbuf);
338} 449}
339 450
340/** This is the Setup cmd */ 451/** This is the Setup cmd */
341void 452void
342SetUp (char *buf, int len, client * ns) 453SetUp (char *buf, int len, client * ns)
354AddMeCmd (char *buf, int len, client *ns) 465AddMeCmd (char *buf, int len, client *ns)
355{ 466{
356 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len)); 467 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
357} 468}
358 469
359/** Reply to ExtendedInfos command */ 470//+GPL
360void
361ToggleExtendedInfos (char *buf, int len, client * ns)
362{
363 char cmdback[MAX_BUF];
364 char command[50];
365 int info, nextinfo;
366
367 cmdback[0] = '\0';
368 nextinfo = 0;
369
370 while (1)
371 {
372 /* 1. Extract an info */
373 info = nextinfo;
374
375 while ((info < len) && (buf[info] == ' '))
376 info++;
377
378 if (info >= len)
379 break;
380
381 nextinfo = info + 1;
382
383 while ((nextinfo < len) && (buf[nextinfo] != ' '))
384 nextinfo++;
385
386 if (nextinfo - info >= 49) /*Erroneous info asked */
387 continue;
388
389 strncpy (command, &(buf[info]), nextinfo - info);
390
391 /* 2. Interpret info */
392 if (!strcmp ("smooth", command))
393 /* Toggle smoothing */
394 ns->EMI_smooth = !ns->EMI_smooth;
395 else
396 /*bad value */;
397
398 /*3. Next info */
399 }
400
401 strcpy (cmdback, "ExtendedInfoSet");
402
403 if (ns->EMI_smooth)
404 {
405 strcat (cmdback, " ");
406 strcat (cmdback, "smoothing");
407 }
408
409 ns->send_packet (cmdback);
410}
411
412/*
413#define MSG_TYPE_BOOK 1
414#define MSG_TYPE_CARD 2
415#define MSG_TYPE_PAPER 3
416#define MSG_TYPE_SIGN 4
417#define MSG_TYPE_MONUMENT 5
418#define MSG_TYPE_SCRIPTED_DIALOG 6*/
419
420/** Reply to ExtendedInfos command */
421void
422ToggleExtendedText (char *buf, int len, client * ns)
423{
424 char cmdback[MAX_BUF];
425 char temp[10];
426 char command[50];
427 int info, nextinfo, i, flag;
428
429 cmdback[0] = '\0';
430
431 nextinfo = 0;
432 while (1)
433 {
434 /* 1. Extract an info */
435 info = nextinfo;
436
437 while ((info < len) && (buf[info] == ' '))
438 info++;
439
440 if (info >= len)
441 break;
442
443 nextinfo = info + 1;
444
445 while ((nextinfo < len) && (buf[nextinfo] != ' '))
446 nextinfo++;
447
448 if (nextinfo - info >= 49) /*Erroneous info asked */
449 continue;
450
451 strncpy (command, &(buf[info]), nextinfo - info);
452 command[nextinfo - info] = '\0';
453 /* 2. Interpret info */
454 i = sscanf (command, "%d", &flag);
455
456 if ((i == 1) && (flag > 0) && (flag <= MSG_TYPE_LAST))
457 ns->supported_readables |= (1 << flag);
458 /*3. Next info */
459 }
460
461 /* Send resulting state */
462 strcpy (cmdback, "ExtendedTextSet");
463
464 for (i = 0; i <= MSG_TYPE_LAST; i++)
465 if (ns->supported_readables & (1 << i))
466 {
467 strcat (cmdback, " ");
468 snprintf (temp, sizeof (temp), "%d", i);
469 strcat (cmdback, temp);
470 }
471
472 ns->send_packet (cmdback);
473}
474
475/**
476 * client requested an image. send it rate-limited
477 * before flushing.
478 */
479void
480AskFaceCmd (char *buf, int len, client *ns)
481{
482 ns->askface.push_back (atoi (buf));
483}
484
485/**
486 * Tells client the picture it has to use
487 * to smooth a picture number given as argument.
488 */
489void
490AskSmooth (char *buf, int len, client *ns)
491{
492 ns->send_face (atoi (buf));
493 ns->flush_fx ();
494}
495 471
496/** 472/**
497 * This handles the general commands from the client (ie, north, fire, cast, 473 * This handles the general commands from the client (ie, north, fire, cast,
498 * etc.) 474 * etc.)
499 */ 475 */
512 return; 488 return;
513 489
514 buf++; 490 buf++;
515 } 491 }
516 492
517 execute_newserver_command (pl->ob, (char *) buf); 493 execute_newserver_command (pl->ob, (char *)buf);
518 494
519 /* Perhaps something better should be done with a left over count. 495 /* Perhaps something better should be done with a left over count.
520 * Cleaning up the input should probably be done first - all actions 496 * Cleaning up the input should probably be done first - all actions
521 * for the command that issued the count should be done before any other 497 * for the command that issued the count should be done before any other
522 * commands. 498 * commands.
523 */ 499 */
524 pl->count = 0; 500 pl->count = 0;
525}
526
527/**
528 * This handles the general commands from the client (ie, north, fire, cast,
529 * etc.). It is a lot like PlayerCmd above, but is called with the
530 * 'ncom' method which gives more information back to the client so it
531 * can throttle.
532 */
533void
534NewPlayerCmd (char *buf, int len, player *pl)
535{
536 if (len <= 6)
537 {
538 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
539 return;
540 }
541
542 uint16 cmdid = net_uint16 ((uint8 *)buf);
543 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
544
545 /* -1 is special - no repeat, but don't update */
546 if (repeat != -1)
547 pl->count = repeat;
548
549 buf += 6; //len -= 6;
550
551 execute_newserver_command (pl->ob, buf);
552
553 /* Perhaps something better should be done with a left over count.
554 * Cleaning up the input should probably be done first - all actions
555 * for the command that issued the count should be done before any other
556 * commands.
557 */
558 pl->count = 0;
559
560 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
561 int time = fabs (pl->ob->speed) < 0.001
562 ? time = MAX_TIME * 100
563 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
564
565 /* Send confirmation of command execution now */
566 packet sl ("comc");
567 sl << uint16 (cmdid) << uint32 (time);
568 pl->ns->send_packet (sl);
569} 501}
570 502
571/** This is a reply to a previous query. */ 503/** This is a reply to a previous query. */
572void 504void
573ReplyCmd (char *buf, int len, client *ns) 505ReplyCmd (char *buf, int len, client *ns)
610 LOG (llevError, "Unknown input state: %d\n", ns->state); 542 LOG (llevError, "Unknown input state: %d\n", ns->state);
611 } 543 }
612} 544}
613 545
614/** 546/**
615 * Client tells its version. If there is a mismatch, we close the 547 * Client tells its version info.
616 * socket. In real life, all we should care about is the client having
617 * something older than the server. If we assume the client will be
618 * backwards compatible, having it be a later version should not be a
619 * problem.
620 */ 548 */
621void 549void
622VersionCmd (char *buf, int len, client * ns) 550VersionCmd (char *buf, int len, client *ns)
623{ 551{
624 if (!buf) 552 INVOKE_CLIENT (VERSION, ns, ARG_DATA (buf, len));
625 {
626 LOG (llevError, "CS: received corrupted version command\n");
627 return;
628 }
629
630 ns->cs_version = atoi (buf);
631 ns->sc_version = ns->cs_version;
632
633 LOG (llevDebug, "connection from client <%s>\n", buf);
634
635 //TODO: should log here just for statistics
636
637 //if (VERSION_CS != ns->cs_version)
638 // unchecked;
639
640 char *cp = strchr (buf + 1, ' ');
641 if (!cp)
642 return;
643
644 ns->sc_version = atoi (cp);
645
646 //if (VERSION_SC != ns->sc_version)
647 // unchecked;
648
649 cp = strchr (cp + 1, ' ');
650
651 if (cp)
652 {
653 ns->version = cp + 1;
654
655 if (ns->sc_version < 1026)
656 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
657 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
658 }
659} 553}
660 554
661/** sound related functions. */ 555/** sound related functions. */
662void 556void
663SetSound (char *buf, int len, client * ns) 557SetSound (char *buf, int len, client * ns)
681 * syntax is: move (to) (tag) (nrof) 575 * syntax is: move (to) (tag) (nrof)
682 */ 576 */
683void 577void
684MoveCmd (char *buf, int len, player *pl) 578MoveCmd (char *buf, int len, player *pl)
685{ 579{
686 int vals[3], i; 580 int to, tag, nrof;
687 581
688 /* A little funky here. We only cycle for 2 records, because 582 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
689 * we obviously are not going to find a space after the third
690 * record. Perhaps we should just replace this with a
691 * sscanf?
692 */
693 for (i = 0; i < 2; i++)
694 { 583 {
695 vals[i] = atoi (buf);
696
697 if (!(buf = strchr (buf, ' ')))
698 {
699 LOG (llevError, "Incomplete move command: %s\n", buf); 584 LOG (llevError, "Incomplete move command: %s\n", buf);
700 return; 585 return;
701 }
702
703 buf++;
704 } 586 }
705 587
706 vals[2] = atoi (buf); 588 esrv_move_object (pl->ob, to, tag, nrof);
707
708/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
709 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
710} 589}
711 590
712/****************************************************************************** 591/******************************************************************************
713 * 592 *
714 * Start of commands the server sends to the client. 593 * Start of commands the server sends to the client.
729 * Get player's current range attack in obuf. 608 * Get player's current range attack in obuf.
730 */ 609 */
731static void 610static void
732rangetostring (player *pl, char *obuf) 611rangetostring (player *pl, char *obuf)
733{ 612{
734 dynbuf_text buf; 613 dynbuf_text &buf = msg_dynbuf; buf.clear ();
614
615#if 0
616 // print ranged/chosen_skill etc. objects every call
617 printf ("%s %s => %s (%s)\n",
618 pl->ranged_ob ? &pl->ranged_ob->name : "-",
619 pl->combat_ob ? &pl->combat_ob->name : "-",
620 pl->ob->current_weapon ? &pl->ob->current_weapon->name : "-",
621 pl->ob->chosen_skill ? &pl->ob->chosen_skill->name : "-"
622 );
623#endif
735 624
736 if (pl->ranged_ob) 625 if (pl->ranged_ob)
737 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name; 626 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name;
738 627
739 if (pl->combat_ob) 628 if (pl->combat_ob)
747 636
748 //TODO: maybe golem should become the current_weapon, quite simply? 637 //TODO: maybe golem should become the current_weapon, quite simply?
749 if (pl->golem) 638 if (pl->golem)
750 buf << " Golem*: " << pl->golem->name; 639 buf << " Golem*: " << pl->golem->name;
751 640
641 buf << '\0';
752 buf.linearise (obuf); 642 buf.linearise (obuf);
753 obuf [buf.size ()] = 0;
754} 643}
755 644
756#define AddIfInt64(Old,New,Type) if (Old != New) {\ 645#define AddIfInt64(Old,New,Type) if (Old != New) {\
757 Old = New; \ 646 Old = New; \
758 sl << uint8 (Type) << uint64 (New); \ 647 sl << uint8 (Type) << uint64 (New); \
785 * commands for now. 674 * commands for now.
786 */ 675 */
787void 676void
788esrv_update_stats (player *pl) 677esrv_update_stats (player *pl)
789{ 678{
790 char buf[MAX_BUF];
791 uint16 flags;
792
793 client *ns = pl->ns; 679 client *ns = pl->ns;
794 if (!ns) 680 if (!ns)
795 return; 681 return;
796 682
797 object *ob = pl->observe; 683 object *ob = pl->observe;
814 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT); 700 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
815 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS); 701 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
816 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW); 702 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
817 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA); 703 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
818 704
819 for (int s = 0; s < NUM_SKILLS; s++) 705 for (int s = 0; s < CS_NUM_SKILLS; s++)
820 if (object *skill = opl->last_skill_ob[s]) 706 if (object *skill = opl->last_skill_ob [s])
821 if (skill->stats.exp != ns->last_skill_exp [s]) 707 if (skill->stats.exp != ns->last_skill_exp [s])
822 { 708 {
823 ns->last_skill_exp [s] = skill->stats.exp; 709 ns->last_skill_exp [s] = skill->stats.exp;
824 710
825 /* Always send along the level if exp changes. This is only 711 /* Always send along the level if exp changes. This is only
826 * 1 extra byte, but keeps processing simpler. 712 * 1 extra byte, but keeps processing simpler.
827 */ 713 */
828 sl << uint8 (s + CS_STAT_SKILLINFO) 714 sl << uint8 (CS_STAT_SKILLINFO + s)
829 << uint8 (skill->level) 715 << uint8 (skill->level)
830 << uint64 (skill->stats.exp); 716 << uint64 (skill->stats.exp);
831 } 717 }
832 718
833 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64); 719 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
834 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL); 720 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
835 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC); 721 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
836 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC); 722 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
837 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM); 723 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
838 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED, 1.f/TICK); 724 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED, 1.f / TICK);
839 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD); 725 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
840 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP, 1.f/TICK); 726 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP, 1.f / TICK);
841 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM); 727 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
842 728
843 flags = 0; 729 int flags = (opl->fire_on ? SF_FIREON : 0)
844 730 | (opl->run_on ? SF_RUNON : 0);
845 if (opl->fire_on)
846 flags |= SF_FIREON;
847
848 if (opl->run_on)
849 flags |= SF_RUNON;
850 731
851 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS); 732 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
852 733
853 if (ns->sc_version < 1025)
854 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
855 else
856 for (int i = 0; i < NROFATTACKS; i++) 734 for (int i = 0; i < NROFATTACKS; i++)
857 {
858 /* Skip ones we won't send */ 735 /* Skip ones we won't send */
859 if (atnr_cs_stat[i] == -1) 736 if (atnr_cs_stat[i] >= 0)
860 continue;
861
862 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]); 737 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
863 }
864 738
865 if (pl->ns->monitor_spells) 739 if (pl->ns->monitor_spells)
866 { 740 {
867 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE); 741 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
868 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL); 742 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
869 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY); 743 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
870 } 744 }
871 745
746 char buf[MAX_BUF];
872 rangetostring (opl, buf); /* we want use the new fire & run system in new client */ 747 rangetostring (opl, buf); /* we want use the new fire & run system in new client */
873 AddIfString (ns->stats.range, buf, CS_STAT_RANGE); 748 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
874 set_title (ob, buf); 749 set_title (ob, buf);
875 AddIfString (ns->stats.title, buf, CS_STAT_TITLE); 750 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
876 751
881 756
882/** 757/**
883 * Tells the client that here is a player it should start using. 758 * Tells the client that here is a player it should start using.
884 */ 759 */
885void 760void
886esrv_new_player (player *pl, uint32 weight) 761esrv_new_player (player *pl)
887{ 762{
763 sint32 weight = pl->ob->client_weight ();
764
888 packet sl ("player"); 765 packet sl ("player");
889 766
890 sl << uint32 (pl->ob->count) 767 sl << uint32 (pl->ob->count)
891 << uint32 (weight) 768 << uint32 (weight)
892 << uint32 (pl->ob->face) 769 << uint32 (pl->ob->face)
893 << data8 (pl->ob->name); 770 << data8 (pl->ob->name);
894 771
895 pl->ns->last_weight = weight; 772 pl->ns->last_weight = weight;
896 pl->ns->send_packet (sl); 773 pl->ns->send_packet (sl);
897 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
898} 774}
899 775
900/****************************************************************************** 776/******************************************************************************
901 * 777 *
902 * Start of map related commands. 778 * Start of map related commands.
959 835
960 if (!ns.faces_sent[face_num]) 836 if (!ns.faces_sent[face_num])
961 if (ob) 837 if (ob)
962 ns.send_faces (ob); 838 ns.send_faces (ob);
963 else 839 else
964 ns.send_face (face_num); 840 ns.send_face (face_num, 10);
965 841
966 sl << uint16 (face_num); 842 sl << uint16 (face_num);
967 return 1; 843 return 1;
968 } 844 }
969 845
970 /* Nothing changed */ 846 /* Nothing changed */
971 return 0; 847 return 0;
972} 848}
973 849
974/** 850/**
975 * Returns the size of a data for a map square as returned by
976 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
977 * available.
978 */
979int
980getExtendedMapInfoSize (client * ns)
981{
982 int result = 0;
983
984 if (ns->ext_mapinfos)
985 {
986 if (ns->EMI_smooth)
987 result += 1; /*One byte for smoothlevel */
988 }
989
990 return result;
991}
992
993// prefetch (and touch) all maps within a specific distancd
994static void
995prefetch_surrounding_maps (maptile *map, int distance)
996{
997 map->last_access = runtime;
998
999 if (--distance)
1000 for (int dir = 4; --dir; )
1001 if (const shstr &path = map->tile_path [dir])
1002 if (maptile *&neigh = map->tile_map [dir])
1003 prefetch_surrounding_maps (neigh, distance);
1004 else
1005 neigh = maptile::find_async (path, map);
1006}
1007
1008// prefetch a generous area around the player
1009static void
1010prefetch_surrounding_maps (object *op)
1011{
1012 prefetch_surrounding_maps (op->map, 3);
1013}
1014
1015/**
1016 * Draws client map. 851 * Draws client map.
1017 */ 852 */
1018void 853void
1019draw_client_map (player *pl) 854draw_client_map (player *pl)
1020{ 855{
1021 object *ob = pl->observe; 856 object *ob = pl->viewpoint;
1022 if (!ob->active) 857 if (!pl->observe->active)
1023 return; 858 return;
1024
1025 maptile *plmap = ob->map;
1026 859
1027 /* If player is just joining the game, he isn't here yet, so the map 860 /* If player is just joining the game, he isn't here yet, so the map
1028 * can get swapped out. If so, don't try to send them a map. All will 861 * can get swapped out. If so, don't try to send them a map. All will
1029 * be OK once they really log in. 862 * be OK once they really log in.
1030 */ 863 */
1031 if (!plmap || plmap->in_memory != MAP_IN_MEMORY) 864 if (!ob->map || ob->map->state != MAP_ACTIVE)
1032 return; 865 return;
1033 866
1034 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1035 int estartlen, eoldlen; 867 int startlen, oldlen;
1036 uint8 eentrysize;
1037 uint16 ewhatstart, ewhatflag;
1038 uint8 extendedinfos;
1039 868
1040 check_map_change (pl); 869 check_map_change (pl);
1041 prefetch_surrounding_maps (pl->ob); 870 pl->ob->prefetch_surrounding_maps ();
1042 871
1043 /* do LOS after calls to update_position */ 872 /* do LOS after calls to update_position */
1044 if (ob != pl->ob) 873 /* unfortunately, we need to udpate los when observing, currently */
1045 clear_los (pl); 874 if (pl->do_los || pl->viewpoint != pl->ob)
1046 else if (pl->do_los)
1047 { 875 {
1048 update_los (ob);
1049 pl->do_los = 0; 876 pl->do_los = 0;
877 pl->update_los ();
1050 } 878 }
1051 879
1052 /** 880 /**
1053 * This function uses the new map1 protocol command to send the map 881 * This function uses the new map1 protocol command to send the map
1054 * to the client. It is necessary because the old map command supports 882 * to the client. It is necessary because the old map command supports
1072 * look like. 900 * look like.
1073 */ 901 */
1074 902
1075 client &socket = *pl->ns; 903 client &socket = *pl->ns;
1076 904
1077 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a"); 905 packet sl ("map1a");
1078 packet esl;
1079 906
1080 startlen = sl.length (); 907 startlen = sl.length ();
1081 908
1082 /*Extendedmapinfo structure initialisation */ 909 int hx = socket.mapx / 2;
1083 if (socket.ext_mapinfos) 910 int hy = socket.mapy / 2;
1084 {
1085 extendedinfos = EMI_NOREDRAW;
1086 911
1087 if (socket.EMI_smooth) 912 ordered_mapwalk_begin (ob, -hx, -hy, hx, hy)
1088 extendedinfos |= EMI_SMOOTH; 913 int ax = dx + hx;
914 int ay = dy + hy;
1089 915
1090 ewhatstart = esl.length (); 916 int mask = (ax << 10) | (ay << 4);
1091 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 917 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1092 could need to be taken away */
1093 eentrysize = getExtendedMapInfoSize (&socket);
1094 esl << "mapextended "
1095 << uint8 (extendedinfos)
1096 << uint8 (eentrysize);
1097 918
1098 estartlen = esl.length (); 919 /* If the coordinates are not valid, or it is too dark to see,
1099 } 920 * we tell the client as such
1100
1101 /* x,y are the real map locations. ax, ay are viewport relative
1102 * locations.
1103 */ 921 */
1104 ay = 0; 922 if (!m)
1105
1106 /* We could do this logic as conditionals in the if statement,
1107 * but that started to get a bit messy to look at.
1108 */
1109 max_x = ob->x + (socket.mapx + 1) / 2;
1110 max_y = ob->y + (socket.mapy + 1) / 2;
1111
1112 for (y = ob->y - socket.mapy / 2; y < max_y; y++, ay++)
1113 { 923 {
1114 sint16 nx, ny; 924 /* space is out of map. Update space and clear values
1115 maptile *m = 0; 925 * if this hasn't already been done. If the space is out
1116 926 * of the map, it shouldn't have a head.
1117 ax = 0; 927 */
1118 for (x = ob->x - socket.mapx / 2; x < max_x; x++, ax++) 928 if (lastcell.count != -1)
1119 { 929 {
1120 // check to see if we can simply go one right quickly 930 sl << uint16 (mask);
931 map_clearcell (&lastcell, -1);
1121 ++nx; 932 }
1122 if (m && nx >= m->width) 933
934 continue;
935 }
936
937 int d = pl->blocked_los_uc (dx, dy);
938
939 if (d > 3)
940 {
941 /* This block deals with spaces that are not visible for whatever
942 * reason. Still may need to send the head for this space.
943 */
944 if (lastcell.count != -1
945 || lastcell.faces[0]
946 || lastcell.faces[1]
947 || lastcell.faces[2]
948 || lastcell.stat_hp
949 || lastcell.flags
950 || lastcell.player)
951 sl << uint16 (mask);
952
953 /* properly clear a previously sent big face */
954 map_clearcell (&lastcell, -1);
955 }
956 else
957 {
958 /* In this block, the space is visible.
959 */
960
961 /* Rather than try to figure out what everything that we might
962 * need to send is, then form the packet after that,
963 * we presume that we will in fact form a packet, and update
964 * the bits by what we do actually send. If we send nothing,
965 * we just back out sl.length () to the old value, and no harm
966 * is done.
967 * I think this is simpler than doing a bunch of checks to see
968 * what if anything we need to send, setting the bits, then
969 * doing those checks again to add the real data.
970 */
971 oldlen = sl.length ();
972
973 sl << uint16 (mask);
974
975 unsigned char dummy;
976 unsigned char *last_ext = &dummy;
977
978 /* Darkness changed */
979 if (lastcell.count != d)
980 {
1123 m = 0; 981 mask |= 0x8;
1124 982
1125 if (!m) 983 *last_ext |= 0x80;
984 last_ext = &sl[sl.length ()];
985 sl << uint8 (d);
986 }
987
988 lastcell.count = d;
989
990 mapspace &ms = m->at (nx, ny);
991 ms.update ();
992
993 // extmap handling
994 uint8 stat_hp = 0;
995 uint8 stat_width = 0;
996 uint8 flags = 0;
997 tag_t player = 0;
998
999 // send hp information, if applicable
1000 if (object *op = ms.faces_obj [0])
1001 if (op->is_head () && !op->invisible)
1126 { 1002 {
1127 nx = x; ny = y; m = plmap; 1003 if (op->stats.maxhp > op->stats.hp
1128 1004 && op->stats.maxhp > 0
1129 if (!xy_normalise (m, nx, ny)) 1005 && (op->type == PLAYER
1006 || op->type == DOOR // does not work, have maxhp 0
1007 || op->flag [FLAG_MONSTER]
1008 || op->flag [FLAG_ALIVE]
1009 || op->flag [FLAG_GENERATOR]))
1130 m = 0; 1010 {
1011 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1012 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1013 }
1014
1015 if (expect_false (op->has_dialogue ()))
1016 flags |= 1;
1017
1018 if (expect_false (op->type == PLAYER))
1019 player = op == ob ? pl->ob->count
1020 : op == pl->ob ? ob->count
1021 : op->count;
1131 } 1022 }
1132 1023
1133 int emask, mask; 1024 if (expect_false (lastcell.stat_hp != stat_hp))
1134 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1135
1136 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1137
1138 /* If the coordinates are not valid, or it is too dark to see,
1139 * we tell the client as such
1140 */
1141 if (!m)
1142 { 1025 {
1143 /* space is out of map. Update space and clear values 1026 lastcell.stat_hp = stat_hp;
1144 * if this hasn't already been done. If the space is out 1027
1145 * of the map, it shouldn't have a head 1028 mask |= 0x8;
1146 */ 1029 *last_ext |= 0x80;
1147 if (lastcell.count != -1) 1030 last_ext = &sl[sl.length ()];
1031
1032 sl << uint8 (5) << uint8 (stat_hp);
1033
1034 if (stat_width > 1)
1148 { 1035 {
1149 sl << uint16 (mask);
1150 map_clearcell (&lastcell, -1);
1151 }
1152
1153 continue;
1154 }
1155
1156 m->touch ();
1157
1158 int d = pl->blocked_los[ax][ay];
1159
1160 if (d > 3)
1161 {
1162
1163 int need_send = 0, count;
1164
1165 /* This block deals with spaces that are not visible for whatever
1166 * reason. Still may need to send the head for this space.
1167 */
1168
1169 oldlen = sl.length ();
1170
1171 sl << uint16 (mask);
1172
1173 if (lastcell.count != -1)
1174 need_send = 1;
1175
1176 count = -1;
1177
1178 /* properly clear a previously sent big face */
1179 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1180 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1181 need_send = 1;
1182
1183 map_clearcell (&lastcell, count);
1184
1185 if ((mask & 0xf) || need_send)
1186 sl[oldlen + 1] = mask & 0xff;
1187 else
1188 sl.reset (oldlen);
1189 }
1190 else
1191 {
1192 /* In this block, the space is visible.
1193 */
1194
1195 /* Rather than try to figure out what everything that we might
1196 * need to send is, then form the packet after that,
1197 * we presume that we will in fact form a packet, and update
1198 * the bits by what we do actually send. If we send nothing,
1199 * we just back out sl.length () to the old value, and no harm
1200 * is done.
1201 * I think this is simpler than doing a bunch of checks to see
1202 * what if anything we need to send, setting the bits, then
1203 * doing those checks again to add the real data.
1204 */
1205 oldlen = sl.length ();
1206 eoldlen = esl.length ();
1207
1208 sl << uint16 (mask);
1209
1210 unsigned char dummy;
1211 unsigned char *last_ext = &dummy;
1212
1213 /* Darkness changed */
1214 if (lastcell.count != d && socket.darkness)
1215 {
1216 mask |= 0x8;
1217
1218 if (socket.extmap)
1219 {
1220 *last_ext |= 0x80; 1036 *last_ext |= 0x80;
1221 last_ext = &sl[sl.length ()]; 1037 last_ext = &sl[sl.length ()];
1222 sl << uint8 (d); 1038
1223 } 1039 sl << uint8 (6) << uint8 (stat_width);
1224 else
1225 sl << uint8 (255 - 64 * d);
1226 } 1040 }
1041 }
1227 1042
1228 lastcell.count = d; 1043 if (expect_false (lastcell.player != player))
1229
1230 mapspace &ms = m->at (nx, ny);
1231 ms.update ();
1232
1233 if (socket.extmap)
1234 { 1044 {
1235 uint8 stat_hp = 0; 1045 lastcell.player = player;
1236 uint8 stat_width = 0;
1237 uint8 flags = 0;
1238 tag_t player = 0;
1239 1046
1240 // send hp information, if applicable
1241 if (object *op = ms.faces_obj [0])
1242 {
1243 if (op->head || op->invisible)
1244 ; // do not show
1245 else if (op->type == PLAYER
1246 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
1247 {
1248 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
1249 {
1250 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1251 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1252 }
1253 }
1254
1255 if (op->msg && op->msg[0] == '@')
1256 flags |= 1;
1257
1258 if (op->type == PLAYER && op != ob)
1259 player = op->count;
1260 }
1261
1262 if (lastcell.stat_hp != stat_hp)
1263 {
1264 lastcell.stat_hp = stat_hp;
1265
1266 mask |= 0x8; 1047 mask |= 0x8;
1267 *last_ext |= 0x80; 1048 *last_ext |= 0x80;
1268 last_ext = &sl[sl.length ()]; 1049 last_ext = &sl[sl.length ()];
1269 1050
1270 sl << uint8 (5) << uint8 (stat_hp);
1271
1272 if (stat_width > 1)
1273 {
1274 *last_ext |= 0x80;
1275 last_ext = &sl[sl.length ()];
1276
1277 sl << uint8 (6) << uint8 (stat_width);
1278 }
1279 }
1280
1281 if (lastcell.player != player)
1282 {
1283 lastcell.player = player;
1284
1285 mask |= 0x8;
1286 *last_ext |= 0x80;
1287 last_ext = &sl[sl.length ()];
1288
1289 sl << uint8 (0x47) << uint8 (4) << (uint32)player; 1051 sl << uint8 (0x47) << uint8 (4) << (uint32)player;
1290 } 1052 }
1291 1053
1292 if (lastcell.flags != flags) 1054 if (expect_false (lastcell.flags != flags))
1293 { 1055 {
1294 lastcell.flags = flags; 1056 lastcell.flags = flags;
1295 1057
1296 mask |= 0x8; 1058 mask |= 0x8;
1297 *last_ext |= 0x80; 1059 *last_ext |= 0x80;
1298 last_ext = &sl[sl.length ()]; 1060 last_ext = &sl[sl.length ()];
1299 1061
1300 sl << uint8 (8) << uint8 (flags); 1062 sl << uint8 (8) << uint8 (flags);
1301 }
1302 } 1063 }
1303 1064
1065 // faces
1066
1304 /* Floor face */ 1067 /* Floor face */
1305 if (update_space (sl, socket, ms, lastcell, 2)) 1068 if (update_space (sl, socket, ms, lastcell, 2))
1306 mask |= 0x4; 1069 mask |= 0x4;
1307 1070
1308 /* Middle face */ 1071 /* Middle face */
1309 if (update_space (sl, socket, ms, lastcell, 1)) 1072 if (update_space (sl, socket, ms, lastcell, 1))
1310 mask |= 0x2; 1073 mask |= 0x2;
1311 1074
1075 if (expect_false (ob->invisible)
1076 && ob->invisible & (ob->invisible < 50 ? 1 : 7)
1312 if (ms.player () == ob 1077 && ms.player () == ob)
1313 && (ob->invisible & (ob->invisible < 50 ? 1 : 7)))
1314 { 1078 {
1315 // force player to be visible to himself if invisible 1079 // force player to be visible to himself if invisible
1316 if (lastcell.faces[0] != ob->face) 1080 if (lastcell.faces[0] != ob->face)
1317 { 1081 {
1318 lastcell.faces[0] = ob->face; 1082 lastcell.faces[0] = ob->face;
1319 1083
1320 mask |= 0x1;
1321 sl << uint16 (ob->face);
1322
1323 socket.send_faces (ob);
1324 }
1325 }
1326 /* Top face */
1327 else if (update_space (sl, socket, ms, lastcell, 0))
1328 mask |= 0x1; 1084 mask |= 0x1;
1085 sl << uint16 (ob->face);
1329 1086
1087 socket.send_faces (ob);
1088 }
1089 }
1090 /* Top face */
1091 else if (update_space (sl, socket, ms, lastcell, 0))
1092 mask |= 0x1;
1093
1330 /* Check to see if we are in fact sending anything for this 1094 /* Check to see if we are in fact sending anything for this
1331 * space by checking the mask. If so, update the mask. 1095 * space by checking the mask. If so, update the mask.
1332 * if not, reset the len to that from before adding the mask 1096 * if not, reset the len to that from before adding the mask
1333 * value, so we don't send those bits. 1097 * value, so we don't send those bits.
1334 */ 1098 */
1335 if (mask & 0xf) 1099 if (mask & 0xf)
1336 sl[oldlen + 1] = mask & 0xff; 1100 sl[oldlen + 1] = mask & 0xff;
1337 else 1101 else
1338 sl.reset (oldlen); 1102 sl.reset (oldlen);
1339
1340 if (socket.ext_mapinfos)
1341 esl << uint16 (emask);
1342
1343 if (socket.EMI_smooth)
1344 {
1345 for (int layer = 2+1; layer--; )
1346 {
1347 object *ob = ms.faces_obj [layer];
1348
1349 // If there is no object for this space, or if the face for the object
1350 // is the blank face, set the smoothlevel to zero.
1351 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1352
1353 // We've gotten what face we want to use for the object. Now see if
1354 // if it has changed since we last sent it to the client.
1355 if (lastcell.smooth[layer] != smoothlevel)
1356 {
1357 lastcell.smooth[layer] = smoothlevel;
1358 esl << uint8 (smoothlevel);
1359 emask |= 1 << layer;
1360 }
1361 }
1362
1363 if (emask & 0xf)
1364 esl[eoldlen + 1] = emask & 0xff;
1365 else
1366 esl.reset (eoldlen);
1367 }
1368 } /* else this is a viewable space */ 1103 } /* else this is a viewable space */
1369 } /* for x loop */ 1104 ordered_mapwalk_end
1370 } /* for y loop */
1371 1105
1372 socket.flush_fx (); 1106 socket.flush_fx ();
1373
1374 /* Verify that we in fact do need to send this */
1375 if (socket.ext_mapinfos)
1376 {
1377 if (!(sl.length () > startlen || socket.sent_scroll))
1378 {
1379 /* No map data will follow, so don't say the client
1380 * it doesn't need draw!
1381 */
1382 ewhatflag &= ~EMI_NOREDRAW;
1383 esl[ewhatstart + 1] = ewhatflag & 0xff;
1384 }
1385
1386 if (esl.length () > estartlen)
1387 socket.send_packet (esl);
1388 }
1389 1107
1390 if (sl.length () > startlen || socket.sent_scroll) 1108 if (sl.length () > startlen || socket.sent_scroll)
1391 { 1109 {
1392 socket.send_packet (sl); 1110 socket.send_packet (sl);
1393 socket.sent_scroll = 0; 1111 socket.sent_scroll = 0;
1394 } 1112 }
1395} 1113}
1396 1114
1397/*****************************************************************************/
1398/* GROS: The following one is used to allow a plugin to send a generic cmd to*/
1399/* a player. Of course, the client need to know the command to be able to */
1400/* manage it ! */
1401/*****************************************************************************/
1402void
1403send_plugin_custom_message (object *pl, char *buf)
1404{
1405 pl->contr->ns->send_packet (buf);
1406}
1407
1408/**
1409 * This sends the skill number to name mapping. We ignore
1410 * the params - we always send the same info no matter what.
1411 */
1412void
1413send_skill_info (client *ns, char *params)
1414{
1415 packet sl;
1416 sl << "replyinfo skill_info\n";
1417
1418 for (int i = 1; i < NUM_SKILLS; i++)
1419 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
1420
1421 if (sl.length () >= MAXSOCKBUF)
1422 {
1423 LOG (llevError, "Buffer overflow in send_skill_info!\n");
1424 fatal (0);
1425 }
1426
1427 ns->send_packet (sl);
1428}
1429
1430/**
1431 * This sends the spell path to name mapping. We ignore
1432 * the params - we always send the same info no matter what.
1433 */
1434void
1435send_spell_paths (client * ns, char *params)
1436{
1437 packet sl;
1438
1439 sl << "replyinfo spell_paths\n";
1440
1441 for (int i = 0; i < NRSPELLPATHS; i++)
1442 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
1443
1444 if (sl.length () >= MAXSOCKBUF)
1445 {
1446 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
1447 fatal (0);
1448 }
1449
1450 ns->send_packet (sl);
1451}
1452
1453/** 1115/**
1454 * This looks for any spells the player may have that have changed their stats. 1116 * This looks for any spells the player may have that have changed their stats.
1455 * it then sends an updspell packet for each spell that has changed in this way 1117 * it then sends an updspell packet for each spell that has changed in this way
1456 */ 1118 */
1457void 1119void
1458esrv_update_spells (player *pl) 1120esrv_update_spells (player *pl)
1459{ 1121{
1460 if (!pl->ns) 1122 if (!pl->ns)
1461 return; 1123 return;
1462 1124
1125 pl->ns->update_spells = false;
1126
1463 if (!pl->ns->monitor_spells) 1127 if (!pl->ns->monitor_spells)
1464 return; 1128 return;
1465 1129
1466 for (object *spell = pl->ob->inv; spell; spell = spell->below) 1130 for (object *spell = pl->ob->inv; spell; spell = spell->below)
1467 {
1468 if (spell->type == SPELL) 1131 if (spell->type == SPELL)
1469 { 1132 {
1470 int flags = 0; 1133 int flags = 0;
1134 int val;
1471 1135
1472 /* check if we need to update it */ 1136 /* check if we need to update it */
1473 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 1137 val = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1138 if (spell->cached_sp != val)
1474 { 1139 {
1475 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1140 spell->cached_sp = val;
1476 flags |= UPD_SP_MANA; 1141 flags |= UPD_SP_MANA;
1477 } 1142 }
1478 1143
1479 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 1144 val = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1145 if (spell->cached_grace != val)
1480 { 1146 {
1481 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1147 spell->cached_grace = val;
1482 flags |= UPD_SP_GRACE; 1148 flags |= UPD_SP_GRACE;
1483 } 1149 }
1484 1150
1485 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 1151 val = casting_level (pl->ob, spell);
1152 if (spell->cached_eat != val)
1486 { 1153 {
1487 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1154 spell->cached_eat = val;
1488 flags |= UPD_SP_DAMAGE; 1155 flags |= UPD_SP_LEVEL;
1489 } 1156 }
1490 1157
1491 if (flags) 1158 if (flags)
1492 { 1159 {
1493 packet sl; 1160 packet sl;
1494 1161
1495 sl << "updspell " 1162 sl << "updspell "
1496 << uint8 (flags) 1163 << uint8 (flags)
1497 << uint32 (spell->count); 1164 << uint32 (spell->count);
1498 1165
1499 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1166 if (flags & UPD_SP_MANA ) sl << uint16 (spell->cached_sp);
1500 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1167 if (flags & UPD_SP_GRACE) sl << uint16 (spell->cached_grace);
1501 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1168 if (flags & UPD_SP_LEVEL) sl << uint16 (spell->cached_eat);
1502 1169
1503 pl->ns->send_packet (sl); 1170 pl->ns->send_packet (sl);
1504 } 1171 }
1505 } 1172 }
1506 }
1507} 1173}
1508 1174
1509void 1175void
1510esrv_remove_spell (player *pl, object *spell) 1176esrv_remove_spell (player *pl, object *spell)
1511{ 1177{
1527 1193
1528/* appends the spell *spell to the Socklist we will send the data to. */ 1194/* appends the spell *spell to the Socklist we will send the data to. */
1529static void 1195static void
1530append_spell (player *pl, packet &sl, object *spell) 1196append_spell (player *pl, packet &sl, object *spell)
1531{ 1197{
1532 int i, skill = 0; 1198 int skill = 0;
1533 1199
1534 if (!(spell->name)) 1200 if (!(spell->name))
1535 { 1201 {
1536 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1202 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
1537 return; 1203 return;
1538 } 1204 }
1539 1205
1540 /* store costs and damage in the object struct, to compare to later */ 1206 /* store costs and damage in the object struct, to compare to later */
1541 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1207 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1542 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1208 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1543 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1209 spell->cached_eat = casting_level (pl->ob, spell);
1544 1210
1545 /* figure out which skill it uses, if it uses one */ 1211 /* figure out which skill it uses, if it uses one */
1546 if (spell->skill) 1212 if (spell->skill)
1547 { 1213 if (object *tmp = pl->find_skill (spell->skill))
1548 for (i = 1; i < NUM_SKILLS; i++) 1214 skill = CS_STAT_SKILLINFO + SKILL_INDEX (tmp);
1549 if (!strcmp (spell->skill, skill_names[i]))
1550 {
1551 skill = i + CS_STAT_SKILLINFO;
1552 break;
1553 }
1554 }
1555 1215
1556 // spells better have a face 1216 // spells better have a face
1557 if (!spell->face) 1217 if (!spell->face)
1558 { 1218 {
1559 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name); 1219 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1560 spell->face = face_find ("burnout.x11", blank_face); 1220 spell->face = face_find ("burnout.x11", blank_face);
1561 } 1221 }
1222
1223 pl->ns->send_face (spell->face);
1562 1224
1563 /* send the current values */ 1225 /* send the current values */
1564 sl << uint32 (spell->count) 1226 sl << uint32 (spell->count)
1565 << uint16 (spell->level) 1227 << uint16 (spell->level)
1566 << uint16 (spell->casting_time) 1228 << uint16 (spell->casting_time)
1567 << uint16 (spell->last_sp) 1229 << uint16 (spell->cached_sp)
1568 << uint16 (spell->last_grace) 1230 << uint16 (spell->cached_grace)
1569 << uint16 (spell->last_eat) 1231 << uint16 (spell->cached_eat)
1570 << uint8 (skill) 1232 << uint8 (skill)
1571 << uint32 (spell->path_attuned) 1233 << uint32 (spell->path_attuned)
1572 << uint32 (spell->face) 1234 << uint32 (spell->face)
1573 << data8 (spell->name) 1235 << data8 (spell->name);
1236
1237 if (pl->ns->monitor_spells < 2)
1574 << data16 (spell->msg); 1238 sl << data16 (spell->msg);
1575} 1239}
1576 1240
1577/** 1241/**
1578 * This tells the client to add the spell *ob, if *ob is NULL, then add 1242 * This tells the client to add the spell *ob, if *ob is NULL, then add
1579 * all spells in the player's inventory. 1243 * all spells in the player's inventory.
1602 * bytes and 3 strings (because that is the spec) so we need to 1266 * bytes and 3 strings (because that is the spec) so we need to
1603 * check that the length of those 3 strings, plus the 23 bytes, 1267 * check that the length of those 3 strings, plus the 23 bytes,
1604 * won't take us over the length limit for the socket, if it does, 1268 * won't take us over the length limit for the socket, if it does,
1605 * we need to send what we already have, and restart packet formation 1269 * we need to send what we already have, and restart packet formation
1606 */ 1270 */
1271 if (spell->type != SPELL)
1272 continue;
1273
1607 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1274 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
1608 * to show add_spell is 26 bytes + 2 strings. However, the overun 1275 * to show add_spell is 26 bytes + 2 strings. However, the overun
1609 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1276 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
1610 * like it will fix this 1277 * like it will fix this
1611 */ 1278 */
1612 if (spell->type != SPELL)
1613 continue;
1614
1615 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1279 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
1616 { 1280 {
1281 pl->ns->flush_fx ();
1617 pl->ns->send_packet (sl); 1282 pl->ns->send_packet (sl);
1618 1283
1619 sl.reset (); 1284 sl.reset ();
1620 sl << "addspell "; 1285 sl << "addspell ";
1621 } 1286 }
1629 return; 1294 return;
1630 } 1295 }
1631 else 1296 else
1632 append_spell (pl, sl, spell); 1297 append_spell (pl, sl, spell);
1633 1298
1634 if (sl.length () >= MAXSOCKBUF) 1299 if (sl.length () > MAXSOCKBUF)
1635 {
1636 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1300 cleanup ("buffer overflow in esrv_add_spells!");
1637 fatal (0);
1638 }
1639 1301
1640 /* finally, we can send the packet */ 1302 /* finally, we can send the packet */
1303 pl->ns->flush_fx ();
1641 pl->ns->send_packet (sl); 1304 pl->ns->send_packet (sl);
1642} 1305}
1643 1306
1307//-GPL
1308

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines