ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.33 by root, Thu Dec 14 01:21:58 2006 UTC vs.
Revision 1.125 by root, Tue Apr 22 04:33:20 2008 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 *
20 21 * The authors can be reached via e-mail to <support@deliantra.net>
21 The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 22 */
23 23
24/** 24/**
25 * \file 25 * \file
26 * Client handling. 26 * Client handling.
27 * 27 *
… …
35 * have the prototype of (char *data, int datalen, int client_num). This 35 * have the prototype of (char *data, int datalen, int client_num). This
36 * way, we can use one dispatch table. 36 * way, we can use one dispatch table.
37 * 37 *
38 * esrv_map_new starts updating the map 38 * esrv_map_new starts updating the map
39 * 39 *
40 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now.
42 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations
45 *
46 * esrv_map_doneredraw finishes the map update, and ships across the
47 * map updates.
48 *
49 */ 40 */
50 41
51#include <global.h> 42#include <global.h>
52#include <sproto.h> 43#include <sproto.h>
53 44
54#include <newclient.h>
55#include <newserver.h>
56#include <living.h> 45#include <living.h>
57#include <commands.h> 46#include <commands.h>
58 47
59/* This block is basically taken from socket.c - I assume if it works there, 48/* This block is basically taken from socket.c - I assume if it works there,
60 * it should work here. 49 * it should work here.
… …
63#include <sys/time.h> 52#include <sys/time.h>
64#include <sys/socket.h> 53#include <sys/socket.h>
65#include <netinet/in.h> 54#include <netinet/in.h>
66#include <netdb.h> 55#include <netdb.h>
67 56
68#ifdef HAVE_UNISTD_H
69# include <unistd.h> 57#include <unistd.h>
70#endif
71
72#ifdef HAVE_SYS_TIME_H
73# include <sys/time.h> 58#include <sys/time.h>
74#endif
75 59
76#include "sounds.h" 60#include "sounds.h"
77 61
78/** 62/**
79 * This table translates the attack numbers as used within the 63 * This table translates the attack numbers as used within the
… …
96 -1, /* life stealing */ 80 -1, /* life stealing */
97 -1 /* Disease - not fully done yet */ 81 -1 /* Disease - not fully done yet */
98}; 82};
99 83
100static void 84static void
101socket_map_scroll (NewSocket * ns, int dx, int dy) 85socket_map_scroll (client *ns, int dx, int dy)
102{ 86{
103 struct Map newmap; 87 struct Map newmap;
104 int x, y, mx, my; 88 int x, y, mx, my;
105 89
106 {
107 packet sl;
108
109 sl.printf ("map_scroll %d %d", dx, dy); 90 ns->send_packet_printf ("map_scroll %d %d", dx, dy);
110 ns->send_packet (sl);
111 }
112 91
113 /* If we are using the Map1aCmd, we may in fact send 92 /* If we are using the Map1aCmd, we may in fact send
114 * head information that is outside the viewable map. 93 * head information that is outside the viewable map.
115 * So set the mx,my to the max value we want to 94 * So set the mx,my to the max value we want to
116 * look for. Removed code to do so - it caused extra 95 * look for. Removed code to do so - it caused extra
117 * complexities for the client, and probably doesn't make 96 * complexities for the client, and probably doesn't make
118 * that much difference in bandwidth. 97 * that much difference in bandwidth.
119 */ 98 */
120 mx = ns->mapx; 99 mx = ns->mapx;
121 my = ns->mapy; 100 my = ns->mapy;
122
123 if (ns->mapmode == Map1aCmd)
124 {
125 mx += MAX_HEAD_OFFSET;
126 my += MAX_HEAD_OFFSET;
127 }
128 101
129 /* the x and y here are coordinates for the new map, i.e. if we moved 102 /* the x and y here are coordinates for the new map, i.e. if we moved
130 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 103 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
131 * if the destination x or y coordinate is outside the viewable 104 * if the destination x or y coordinate is outside the viewable
132 * area, we clear the values - otherwise, the old values 105 * area, we clear the values - otherwise, the old values
… …
156} 129}
157 130
158static void 131static void
159clear_map (player *pl) 132clear_map (player *pl)
160{ 133{
161 NewSocket & socket = pl->socket; 134 pl->ns->mapinfo_queue_clear ();
162 135
163 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 136 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
164 137
138 pl->ns->force_newmap = false;
139
165 if (socket.newmapcmd == 1) 140 if (pl->ns->newmapcmd == 1)
166 socket.send_packet ("newmap"); 141 pl->ns->send_packet ("newmap");
167 142
168 socket.update_look = 1; 143 pl->ns->floorbox_reset ();
169 socket.look_position = 0;
170} 144}
171 145
172/** check for map change and send new map data */ 146/** check for map/region change and send new map data */
173static void 147static void
174check_map_change (player *pl) 148check_map_change (player *pl)
175{ 149{
176 NewSocket & socket = pl->socket; 150 client &socket = *pl->ns;
177 object *ob = pl->ob; 151 object *ob = pl->observe;
178 char buf[MAX_BUF]; /* eauugggh */
179 152
180 if (socket.current_map != ob->map) 153 if (socket.current_map != ob->map || socket.force_newmap)
181 { 154 {
155 clear_map (pl);
182 socket.current_map = ob->map; 156 socket.current_map = ob->map;
183
184 clear_map (pl);
185 157
186 if (socket.mapinfocmd) 158 if (socket.mapinfocmd)
187 { 159 {
188 if (ob->map && ob->map->path[0]) 160 if (ob->map && ob->map->path[0])
189 { 161 {
190 int flags = 0; 162 int flags = 0;
191 163
192 if (ob->map->tile_path[0]) 164 if (ob->map->tile_path[0]) flags |= 1;
193 flags |= 1;
194 if (ob->map->tile_path[1]) 165 if (ob->map->tile_path[1]) flags |= 2;
195 flags |= 2;
196 if (ob->map->tile_path[2]) 166 if (ob->map->tile_path[2]) flags |= 4;
197 flags |= 4;
198 if (ob->map->tile_path[3]) 167 if (ob->map->tile_path[3]) flags |= 8;
199 flags |= 8;
200 168
201 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s", 169 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
202 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 170 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
171 ob->map->width, ob->map->height, &ob->map->path);
203 } 172 }
204 else 173 else
205 snprintf (buf, MAX_BUF, "mapinfo current");
206
207 socket.send_packet (buf); 174 socket.send_packet ("mapinfo current");
208 } 175 }
209 } 176 }
210 else if (socket.current_x != ob->x || socket.current_y != ob->y) 177 else if (socket.current_x != ob->x || socket.current_y != ob->y)
211 { 178 {
212 int dx = ob->x - socket.current_x; 179 int dx = ob->x - socket.current_x;
… …
215 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8)) 182 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
216 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows 183 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
217 else 184 else
218 { 185 {
219 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 186 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
220 socket.update_look = 1; 187 socket.floorbox_reset ();
221 socket.look_position = 0;
222 } 188 }
223 } 189 }
224 190
225 socket.current_x = ob->x; 191 socket.current_x = ob->x;
226 socket.current_y = ob->y; 192 socket.current_y = ob->y;
193
194 region *reg = ob->region ();
195 if (socket.current_region != reg)
196 {
197 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
198 socket.current_region = reg;
199 }
200}
201
202/**
203 * RequestInfo is sort of a meta command. There is some specific
204 * request of information, but we call other functions to provide
205 * that information.
206 */
207void
208RequestInfo (char *buf, int len, client *ns)
209{
210 char *params;
211
212 /* find the first space, make it null, and update the
213 * params pointer.
214 */
215 for (params = buf; *params; params++)
216 if (*params == ' ')
217 {
218 *params++ = 0;
219 break;
220 }
221
222 if (!strcmp (buf, "image_info"))
223 send_image_info (ns, params);
224 else if (!strcmp (buf, "image_sums"))
225 send_image_sums (ns, params);
226 else if (!strcmp (buf, "skill_info"))
227 send_skill_info (ns, params);
228 else if (!strcmp (buf, "spell_paths"))
229 send_spell_paths (ns, params);
230 else
231 {
232 // undo tokenisation above and send replyinfo with the request unchanged
233 if (*params)
234 *--params = ' ';
235
236 ns->send_packet_printf ("replyinfo %s", buf);
237 }
227} 238}
228 239
229void 240void
230ExtCmd (char *buf, int len, player *pl) 241ExtCmd (char *buf, int len, player *pl)
231{ 242{
232 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len)); 243 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
244}
245
246void
247ExtiCmd (char *buf, int len, client *ns)
248{
249 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
250}
251
252void
253client::mapinfo_queue_clear ()
254{
255 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
256 free (*i);
257
258 mapinfo_queue.clear ();
259}
260
261bool
262client::mapinfo_try (char *buf)
263{
264 char *token = buf;
265 buf += strlen (buf) + 9;
266
267 // initial map and its origin
268 maptile *map = pl->observe->map;
269 int mapx = pl->ns->mapx / 2 - pl->observe->x;
270 int mapy = pl->ns->mapy / 2 - pl->observe->y;
271 int max_distance = 8; // limit maximum path length to something generous
272
273 while (*buf && map && max_distance)
274 {
275 int dir = *buf++ - '1';
276
277 if (dir >= 0 && dir <= 3)
278 {
279 if (!map->tile_path [dir])
280 map = 0;
281 else if (map->tile_available (dir, false))
282 {
283 maptile *neigh = map->tile_map [dir];
284
285 switch (dir)
286 {
287 case 0: mapy -= neigh->height; break;
288 case 2: mapy += map ->height; break;
289 case 3: mapx -= neigh->width ; break;
290 case 1: mapx += map ->width ; break;
291 }
292
293 map = neigh;
294 --max_distance;
295 }
296 else
297 return 0;
298 }
299 else
300 max_distance = 0;
301 }
302
303 if (!max_distance)
304 send_packet_printf ("mapinfo %s error", token);
305 else if (!map || !map->path)
306 send_packet_printf ("mapinfo %s nomap", token);
307 else
308 {
309 int flags = 0;
310
311 if (map->tile_path[0]) flags |= 1;
312 if (map->tile_path[1]) flags |= 2;
313 if (map->tile_path[2]) flags |= 4;
314 if (map->tile_path[3]) flags |= 8;
315
316 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
317 }
318
319 return 1;
320}
321
322void
323client::mapinfo_queue_run ()
324{
325 if (mapinfo_queue.empty () || !pl)
326 return;
327
328 for (int i = 0; i < mapinfo_queue.size (); ++i)
329 if (mapinfo_try (mapinfo_queue [i]))
330 {
331 free (mapinfo_queue [i]);
332 mapinfo_queue.erase (i);
333 }
334 else
335 ++i;
233} 336}
234 337
235void 338void
236MapInfoCmd (char *buf, int len, player *pl) 339MapInfoCmd (char *buf, int len, player *pl)
237{ 340{
238 // <mapinfo tag spatial tile-path 341 // <mapinfo tag spatial tile-path
239 // >mapinfo tag spatial flags x y w h hash 342 // >mapinfo tag spatial flags x y w h hash
240 343
241 char bigbuf[MAX_BUF], *token;
242
243 token = buf; 344 char *token = buf;
244 // copy token 345
245 if (!(buf = strchr (buf, ' '))) 346 if (!(buf = strchr (buf, ' ')))
246 return; 347 return;
247 348
248 *buf++ = 0;
249
250 if (!strncmp (buf, "spatial ", 8)) 349 if (!strncmp (buf, " spatial ", 9))
251 { 350 {
252 buf += 8; 351 char *copy = strdup (token);
352 copy [buf - token] = 0;
253 353
254 // initial map and its origin 354#if 0
255 maptile *map = pl->ob->map; 355 // this makes only sense when we flush the buffer immediately
256 sint16 dx, dy; 356 if (pl->ns->mapinfo_try (copy))
257 int mapx = pl->socket.mapx / 2 - pl->ob->x; 357 free (copy);
258 int mapy = pl->socket.mapy / 2 - pl->ob->y;
259 int max_distance = 8; // limit maximum path length to something generous
260
261 while (*buf && map && max_distance)
262 {
263 int dir = *buf++;
264
265 switch (dir)
266 {
267 case '1':
268 dx = 0;
269 dy = -1;
270 map = get_map_from_coord (map, &dx, &dy);
271 map && (mapy -= map->height);
272 break;
273 case '2':
274 mapx += map->width;
275 dx = map->width;
276 dy = 0;
277 map = get_map_from_coord (map, &dx, &dy);
278 break;
279 case '3':
280 mapy += map->height;
281 dx = 0;
282 dy = map->height;
283 map = get_map_from_coord (map, &dx, &dy);
284 break;
285 case '4':
286 dx = -1;
287 dy = 0;
288 map = get_map_from_coord (map, &dx, &dy);
289 map && (mapx -= map->width);
290 break;
291 }
292
293 --max_distance;
294 }
295
296 if (!max_distance)
297 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
298 else if (map && map->path[0])
299 {
300 int flags = 0;
301
302 if (map->tile_path[0])
303 flags |= 1;
304 if (map->tile_path[1])
305 flags |= 2;
306 if (map->tile_path[2])
307 flags |= 4;
308 if (map->tile_path[3])
309 flags |= 8;
310
311 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, map->path);
312 }
313 else 358 else
314 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 359#endif
360 pl->ns->mapinfo_queue.push_back (copy);
315 } 361 }
316 else 362 else
317 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 363 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
318
319 pl->socket.send_packet (bigbuf);
320} 364}
321 365
322/** This is the Setup cmd - easy first implementation */ 366/** This is the Setup cmd */
323void 367void
324SetUp (char *buf, int len, NewSocket * ns) 368SetUp (char *buf, int len, client * ns)
325{ 369{
326 int s, slen; 370 INVOKE_CLIENT (SETUP, ns, ARG_DATA (buf, len));
327 char *cmd, *param, cmdback[HUGE_BUF];
328
329 /* run through the cmds of setup
330 * syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
331 *
332 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
333 * The client then must sort this out
334 */
335
336 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
337
338 strcpy (cmdback, "setup");
339 for (s = 0; s < len; )
340 {
341 cmd = &buf[s];
342
343 /* find the next space, and put a null there */
344 for (; buf[s] && buf[s] != ' '; s++)
345 ;
346
347 buf[s++] = 0;
348
349 while (buf[s] == ' ')
350 s++;
351
352 if (s >= len)
353 break;
354
355 param = &buf[s];
356
357 for (; buf[s] && buf[s] != ' '; s++)
358 ;
359
360 buf[s++] = 0;
361
362 while (buf[s] == ' ')
363 s++;
364
365 slen = strlen (cmdback);
366 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
367 safe_strcat (cmdback, cmd, &slen, HUGE_BUF);
368 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
369
370 if (!strcmp (cmd, "sound"))
371 {
372 ns->sound = atoi (param);
373 safe_strcat (cmdback, param, &slen, HUGE_BUF);
374 }
375 else if (!strcmp (cmd, "exp64"))
376 {
377 ns->exp64 = atoi (param);
378 safe_strcat (cmdback, param, &slen, HUGE_BUF);
379 }
380 else if (!strcmp (cmd, "spellmon"))
381 {
382 ns->monitor_spells = atoi (param);
383 safe_strcat (cmdback, param, &slen, HUGE_BUF);
384 }
385 else if (!strcmp (cmd, "darkness"))
386 {
387 ns->darkness = atoi (param);
388 safe_strcat (cmdback, param, &slen, HUGE_BUF);
389 }
390 else if (!strcmp (cmd, "map1cmd"))
391 {
392 if (atoi (param))
393 ns->mapmode = Map1Cmd;
394 /* if beyond this size, need to use map1cmd no matter what */
395 if (ns->mapx > 11 || ns->mapy > 11)
396 ns->mapmode = Map1Cmd;
397 safe_strcat (cmdback, ns->mapmode == Map1Cmd ? "1" : "0", &slen, HUGE_BUF);
398 }
399 else if (!strcmp (cmd, "map1acmd"))
400 {
401 if (atoi (param))
402 ns->mapmode = Map1aCmd;
403 /* if beyond this size, need to use map1acmd no matter what */
404 if (ns->mapx > 11 || ns->mapy > 11)
405 ns->mapmode = Map1aCmd;
406 safe_strcat (cmdback, ns->mapmode == Map1aCmd ? "1" : "0", &slen, HUGE_BUF);
407 }
408 else if (!strcmp (cmd, "newmapcmd"))
409 {
410 ns->newmapcmd = atoi (param);
411 safe_strcat (cmdback, param, &slen, HUGE_BUF);
412// } else if (!strcmp(cmd,"plugincmd")) {
413// ns->plugincmd = atoi(param);
414// safe_strcat(cmdback, param, &slen, HUGE_BUF);
415 }
416 else if (!strcmp (cmd, "mapinfocmd"))
417 {
418 ns->mapinfocmd = atoi (param);
419 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
420 }
421 else if (!strcmp (cmd, "extcmd"))
422 {
423 ns->extcmd = atoi (param);
424 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
425 }
426 else if (!strcmp (cmd, "extmap"))
427 {
428 ns->extmap = atoi (param);
429 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
430 }
431 else if (!strcmp (cmd, "facecache"))
432 {
433 ns->facecache = atoi (param);
434 safe_strcat (cmdback, param, &slen, HUGE_BUF);
435 }
436 else if (!strcmp (cmd, "faceset"))
437 {
438 char tmpbuf[20];
439 int q = atoi (param);
440
441 if (is_valid_faceset (q))
442 ns->faceset = q;
443 sprintf (tmpbuf, "%d", ns->faceset);
444 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
445 /* if the client is using faceset, it knows about image2 command */
446 ns->image2 = 1;
447 }
448 else if (!strcmp (cmd, "itemcmd"))
449 {
450 /* Version of the item protocol command to use. Currently,
451 * only supported versions are 1 and 2. Using a numeric
452 * value will make it very easy to extend this in the future.
453 */
454 char tmpbuf[20];
455 int q = atoi (param);
456
457 if (q < 1 || q > 2)
458 {
459 strcpy (tmpbuf, "FALSE");
460 }
461 else
462 {
463 ns->itemcmd = q;
464 sprintf (tmpbuf, "%d", ns->itemcmd);
465 }
466 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
467 }
468 else if (!strcmp (cmd, "mapsize"))
469 {
470 int x, y = 0;
471 char tmpbuf[MAX_BUF], *cp;
472
473 x = atoi (param);
474 for (cp = param; *cp != 0; cp++)
475 if (*cp == 'x' || *cp == 'X')
476 {
477 y = atoi (cp + 1);
478 break;
479 }
480 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
481 {
482 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
483 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
484 }
485 else
486 {
487 ns->mapx = x;
488 ns->mapy = y;
489 /* better to send back what we are really using and not the
490 * param as given to us in case it gets parsed differently.
491 */
492 sprintf (tmpbuf, "%dx%d", x, y);
493 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
494 /* If beyond this size and still using orig map command, need to
495 * go to map1cmd.
496 */
497 if ((x > 11 || y > 11) && ns->mapmode == Map0Cmd)
498 ns->mapmode = Map1Cmd;
499 }
500 }
501 else if (!strcmp (cmd, "extendedMapInfos"))
502 {
503 /* Added by tchize
504 * prepare to use the mapextended command
505 */
506 char tmpbuf[20];
507
508 ns->ext_mapinfos = (atoi (param));
509 sprintf (tmpbuf, "%d", ns->ext_mapinfos);
510 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
511 }
512 else if (!strcmp (cmd, "extendedTextInfos"))
513 {
514 /* Added by tchize
515 * prepare to use the extended text commands
516 * Client toggle this to non zero to get exttext
517 */
518 char tmpbuf[20];
519
520 ns->has_readable_type = (atoi (param));
521 sprintf (tmpbuf, "%d", ns->has_readable_type);
522 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
523 }
524 else
525 {
526 /* Didn't get a setup command we understood -
527 * report a failure to the client.
528 */
529 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
530 }
531 } /* for processing all the setup commands */
532
533 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
534 ns->send_packet (cmdback);
535} 371}
536 372
537/** 373/**
538 * The client has requested to be added to the game. 374 * The client has requested to be added to the game.
539 * This is what takes care of it. We tell the client how things worked out. 375 * This is what takes care of it. We tell the client how things worked out.
540 * I am not sure if this file is the best place for this function. however, 376 * I am not sure if this file is the best place for this function. however,
541 * it either has to be here or init_sockets needs to be exported. 377 * it either has to be here or init_sockets needs to be exported.
542 */ 378 */
543void 379void
544AddMeCmd (char *buf, int len, NewSocket * ns) 380AddMeCmd (char *buf, int len, client *ns)
545{ 381{
546 Settings oldsettings; 382 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
547
548 oldsettings = settings;
549 if (ns->status != Ns_Add || add_player (ns))
550 ns->send_packet ("addme_failed");
551 else
552 {
553 /* Basically, the add_player copies the socket structure into
554 * the player structure, so this one (which is from init_sockets)
555 * is not needed anymore. The write below should still work, as the
556 * stuff in ns is still relevant.
557 */
558 ns->send_packet ("addme_success");
559 socket_info.nconns--;
560 ns->status = Ns_Avail;
561 }
562
563 settings = oldsettings;
564} 383}
565 384
566/** Reply to ExtendedInfos command */ 385/** Reply to ExtendedInfos command */
567void 386void
568ToggleExtendedInfos (char *buf, int len, NewSocket * ns) 387ToggleExtendedInfos (char *buf, int len, client * ns)
569{ 388{
570 char cmdback[MAX_BUF]; 389 char cmdback[MAX_BUF];
571 char command[50]; 390 char command[50];
572 int info, nextinfo; 391 int info, nextinfo;
573 392
… …
624#define MSG_TYPE_MONUMENT 5 443#define MSG_TYPE_MONUMENT 5
625#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 444#define MSG_TYPE_SCRIPTED_DIALOG 6*/
626 445
627/** Reply to ExtendedInfos command */ 446/** Reply to ExtendedInfos command */
628void 447void
629ToggleExtendedText (char *buf, int len, NewSocket * ns) 448ToggleExtendedText (char *buf, int len, client * ns)
630{ 449{
631 char cmdback[MAX_BUF]; 450 char cmdback[MAX_BUF];
632 char temp[10]; 451 char temp[10];
633 char command[50]; 452 char command[50];
634 int info, nextinfo, i, flag; 453 int info, nextinfo, i, flag;
… …
678 497
679 ns->send_packet (cmdback); 498 ns->send_packet (cmdback);
680} 499}
681 500
682/** 501/**
683 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
684 * Basically, it makes no sense to wait for the client to request a
685 * a piece of data from us that we know the client wants. So
686 * if we know the client wants it, might as well push it to the
687 * client.
688 */
689static void
690SendSmooth (NewSocket * ns, uint16 face)
691{
692 uint16 smoothface;
693
694 /* If we can't find a face, return and set it so we won't try to send this
695 * again.
696 */
697 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
698 {
699
700 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name);
701 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
702 return;
703 }
704
705 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
706 esrv_send_face (ns, smoothface, 0);
707
708 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
709
710 packet sl;
711
712 sl << "smooth "
713 << uint16 (face)
714 << uint16 (smoothface);
715
716 Send_With_Handling (ns, &sl);
717}
718
719 /**
720 * Tells client the picture it has to use
721 * to smooth a picture number given as argument.
722 */
723void
724AskSmooth (char *buf, int len, NewSocket * ns)
725{
726 uint16 facenbr;
727
728 facenbr = atoi (buf);
729 SendSmooth (ns, facenbr);
730}
731
732/**
733 * This handles the general commands from the client (ie, north, fire, cast, 502 * This handles the general commands from the client (ie, north, fire, cast,
734 * etc.) 503 * etc.)
735 */ 504 */
736void 505void
737PlayerCmd (char *buf, int len, player *pl) 506PlayerCmd (char *buf, int len, player *pl)
738{ 507{
739
740 /* The following should never happen with a proper or honest client.
741 * Therefore, the error message doesn't have to be too clear - if
742 * someone is playing with a hacked/non working client, this gives them
743 * an idea of the problem, but they deserve what they get
744 */
745 if (pl->state != ST_PLAYING)
746 {
747 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
748 return;
749 }
750 /* Check if there is a count. In theory, a zero count could also be 508 /* Check if there is a count. In theory, a zero count could also be
751 * sent, so check for that also. 509 * sent, so check for that also.
752 */ 510 */
753 if (atoi (buf) || buf[0] == '0') 511 if (atoi (buf) || buf[0] == '0')
754 { 512 {
755 pl->count = atoi ((char *) buf); 513 pl->count = atoi ((char *) buf);
514
756 buf = strchr (buf, ' '); /* advance beyond the numbers */ 515 buf = strchr (buf, ' '); /* advance beyond the numbers */
757 if (!buf) 516 if (!buf)
758 {
759#ifdef ESRV_DEBUG
760 LOG (llevDebug, "PlayerCmd: Got count but no command.\n");
761#endif
762 return; 517 return;
763 } 518
764 buf++; 519 buf++;
765 } 520 }
766 /* This should not happen anymore. */ 521
767 if (pl->ob->speed_left < -1.0)
768 {
769 LOG (llevError, "Player has negative time - shouldn't do command.\n");
770 }
771 /* In c_new.c */
772 execute_newserver_command (pl->ob, (char *) buf); 522 execute_newserver_command (pl->ob, (char *) buf);
773 /* Perhaps something better should be done with a left over count.
774 * Cleaning up the input should probably be done first - all actions
775 * for the command that issued the count should be done before any other
776 * commands.
777 */
778 523
779 pl->count = 0;
780
781}
782
783
784/**
785 * This handles the general commands from the client (ie, north, fire, cast,
786 * etc.). It is a lot like PlayerCmd above, but is called with the
787 * 'ncom' method which gives more information back to the client so it
788 * can throttle.
789 */
790void
791NewPlayerCmd (uint8 * buf, int len, player *pl)
792{
793 int time, repeat;
794 char command[MAX_BUF];
795 int pktlen;
796
797 if (len < 7)
798 {
799 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
800 return;
801 }
802
803 pktlen = net_uint16 (buf);
804 repeat = net_uint32 (buf + 2);
805
806 /* -1 is special - no repeat, but don't update */
807 if (repeat != -1)
808 pl->count = repeat;
809
810 if ((len - 4) >= MAX_BUF)
811 len = MAX_BUF - 5;
812
813 strncpy ((char *) command, (char *) buf + 6, len - 4);
814 command[len - 4] = '\0';
815
816 /* The following should never happen with a proper or honest client.
817 * Therefore, the error message doesn't have to be too clear - if
818 * someone is playing with a hacked/non working client, this gives them
819 * an idea of the problem, but they deserve what they get
820 */
821 if (pl->state != ST_PLAYING)
822 {
823 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
824 return;
825 }
826
827 /* This should not happen anymore. */
828 if (pl->ob->speed_left < -1.0)
829 LOG (llevError, "Player has negative time - shouldn't do command.\n");
830
831 /* In c_new.c */
832 execute_newserver_command (pl->ob, (char *) command);
833 /* Perhaps something better should be done with a left over count. 524 /* Perhaps something better should be done with a left over count.
834 * Cleaning up the input should probably be done first - all actions 525 * Cleaning up the input should probably be done first - all actions
835 * for the command that issued the count should be done before any other 526 * for the command that issued the count should be done before any other
836 * commands. 527 * commands.
837 */ 528 */
838 pl->count = 0; 529 pl->count = 0;
530}
839 531
840 if (FABS (pl->ob->speed) < 0.001) 532/**
533 * This handles the general commands from the client (ie, north, fire, cast,
534 * etc.). It is a lot like PlayerCmd above, but is called with the
535 * 'ncom' method which gives more information back to the client so it
536 * can throttle.
537 */
538void
539NewPlayerCmd (char *buf, int len, player *pl)
540{
541 if (len <= 6)
542 {
543 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
544 return;
545 }
546
547 uint16 cmdid = net_uint16 ((uint8 *)buf);
548 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
549
550 /* -1 is special - no repeat, but don't update */
551 if (repeat != -1)
552 pl->count = repeat;
553
554 buf += 6; //len -= 6;
555
556 execute_newserver_command (pl->ob, buf);
557
558 /* Perhaps something better should be done with a left over count.
559 * Cleaning up the input should probably be done first - all actions
560 * for the command that issued the count should be done before any other
561 * commands.
562 */
563 pl->count = 0;
564
565 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
566 int time = fabs (pl->ob->speed) < 0.001
841 time = MAX_TIME * 100; 567 ? time = MAX_TIME * 100
842 else
843 time = (int) (MAX_TIME / FABS (pl->ob->speed)); 568 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
844 569
845 /* Send confirmation of command execution now */ 570 /* Send confirmation of command execution now */
846 571 packet sl ("comc");
847 packet sl;
848 sl << "comc " << uint16 (pktlen) << uint32 (time); 572 sl << uint16 (cmdid) << uint32 (time);
849 Send_With_Handling (&pl->socket, &sl); 573 pl->ns->send_packet (sl);
850} 574}
851
852 575
853/** This is a reply to a previous query. */ 576/** This is a reply to a previous query. */
854void 577void
855ReplyCmd (char *buf, int len, player *pl) 578ReplyCmd (char *buf, int len, client *ns)
856{ 579{
580 if (ns->state == ST_CUSTOM)
581 {
582 INVOKE_CLIENT (REPLY, ns, ARG_DATA (buf, len));
583 return;
584 }
585
586 if (!ns->pl)
587 return; //TODO: depends on the exact reply we are after
588 //TODO: but right now, we always have a ns->pl
589
590 player *pl = ns->pl;
591
857 /* This is to synthesize how the data would be stored if it 592 /* This is to synthesize how the data would be stored if it
858 * was normally entered. A bit of a hack, and should be cleaned up 593 * was normally entered. A bit of a hack, and should be cleaned up
859 * once all the X11 code is removed from the server. 594 * once all the X11 code is removed from the server.
860 * 595 *
861 * We pass 13 to many of the functions because this way they 596 * We pass 13 to many of the functions because this way they
862 * think it was the carriage return that was entered, and the 597 * think it was the carriage return that was entered, and the
863 * function then does not try to do additional input. 598 * function then does not try to do additional input.
864 */ 599 */
865 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf); 600 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
866 601
867 /* this avoids any hacking here */ 602 /* this avoids any hacking here */
868 603
869 switch (pl->state) 604 switch (ns->state)
870 { 605 {
871 case ST_PLAYING: 606 case ST_PLAYING:
872 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 607 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
873 break; 608 break;
874 609
875 case ST_PLAY_AGAIN:
876 /* We can check this for return value (2==quit). Maybe we
877 * should, and do something appropriate?
878 */
879 receive_play_again (pl->ob, buf[0]);
880 break;
881
882 case ST_ROLL_STAT:
883 key_roll_stat (pl->ob, buf[0]);
884 break;
885
886 case ST_CHANGE_CLASS:
887
888 key_change_class (pl->ob, buf[0]);
889 break;
890
891 case ST_CONFIRM_QUIT:
892 key_confirm_quit (pl->ob, buf[0]);
893 break;
894
895 case ST_CONFIGURE:
896 LOG (llevError, "In client input handling, but into configure state\n");
897 pl->state = ST_PLAYING;
898 break;
899
900 case ST_GET_NAME:
901 receive_player_name (pl->ob, 13);
902 break;
903
904 case ST_GET_PASSWORD:
905 case ST_CONFIRM_PASSWORD:
906 receive_player_password (pl->ob, 13);
907 break;
908
909 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 610 case ST_GET_PARTY_PASSWORD: /* Get password for party */
910 receive_party_password (pl->ob, 13); 611 receive_party_password (pl->ob, 13);
911 break; 612 break;
912 613
913 default: 614 default:
914 LOG (llevError, "Unknown input state: %d\n", pl->state); 615 LOG (llevError, "Unknown input state: %d\n", ns->state);
915 } 616 }
916} 617}
917 618
918/** 619/**
919 * Client tells its version. If there is a mismatch, we close the 620 * Client tells its version. If there is a mismatch, we close the
… …
921 * something older than the server. If we assume the client will be 622 * something older than the server. If we assume the client will be
922 * backwards compatible, having it be a later version should not be a 623 * backwards compatible, having it be a later version should not be a
923 * problem. 624 * problem.
924 */ 625 */
925void 626void
926VersionCmd (char *buf, int len, NewSocket * ns) 627VersionCmd (char *buf, int len, client * ns)
927{ 628{
928 char *cp;
929 char version_warning[256];
930
931 if (!buf) 629 if (!buf)
932 { 630 {
933 LOG (llevError, "CS: received corrupted version command\n"); 631 LOG (llevError, "CS: received corrupted version command\n");
934 return; 632 return;
935 } 633 }
936 634
937 ns->cs_version = atoi (buf); 635 ns->cs_version = atoi (buf);
938 ns->sc_version = ns->cs_version; 636 ns->sc_version = ns->cs_version;
637
638 LOG (llevDebug, "connection from client <%s>\n", buf);
639
640 //TODO: should log here just for statistics
641
939 if (VERSION_CS != ns->cs_version) 642 //if (VERSION_CS != ns->cs_version)
940 { 643 // unchecked;
941#ifdef ESRV_DEBUG 644
942 LOG (llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS, ns->cs_version);
943#endif
944 }
945 cp = strchr (buf + 1, ' '); 645 char *cp = strchr (buf + 1, ' ');
946 if (!cp) 646 if (!cp)
947 return; 647 return;
648
948 ns->sc_version = atoi (cp); 649 ns->sc_version = atoi (cp);
650
949 if (VERSION_SC != ns->sc_version) 651 //if (VERSION_SC != ns->sc_version)
950 { 652 // unchecked;
951#ifdef ESRV_DEBUG 653
952 LOG (llevDebug, "CS: scversion mismatch (%d,%d)\n", VERSION_SC, ns->sc_version);
953#endif
954 }
955 cp = strchr (cp + 1, ' '); 654 cp = strchr (cp + 1, ' ');
655
956 if (cp) 656 if (cp)
957 { 657 {
958 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host); 658 ns->version = cp + 1;
959 659
960 snprintf (ns->client, sizeof (ns->client), "%s", cp + 1);
961
962 /* This is first implementation - i skip all beta DX clients with it
963 * Add later stuff here for other clients
964 */
965
966 /* these are old dxclients */
967 /* Version 1024 added support for singular + plural name values -
968 * requiing this minimal value reduces complexity of that code, and it
969 * has been around for a long time.
970 */
971 if (ns->sc_version < 1026) 660 if (ns->sc_version < 1026)
972 { 661 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
973 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
974 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 662 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
975 ns->send_packet (version_warning);
976 }
977
978 } 663 }
979} 664}
980 665
981/** sound related functions. */ 666/** sound related functions. */
982
983void 667void
984SetSound (char *buf, int len, NewSocket * ns) 668SetSound (char *buf, int len, client * ns)
985{ 669{
986 ns->sound = atoi (buf); 670 ns->sound = atoi (buf);
987} 671}
988 672
989/** client wants the map resent */ 673/** client wants the map resent */
990
991void 674void
992MapRedrawCmd (char *buf, int len, player *pl) 675MapRedrawCmd (char *buf, int len, player *pl)
993{ 676{
994
995/* This function is currently disabled; just clearing the map state results in 677/* This function is currently disabled; just clearing the map state results in
996 * display errors. It should clear the cache and send a newmap command. 678 * display errors. It should clear the cache and send a newmap command.
997 * Unfortunately this solution does not work because some client versions send 679 * Unfortunately this solution does not work because some client versions send
998 * a mapredraw command after receiving a newmap command. 680 * a mapredraw command after receiving a newmap command.
999 */ 681 */
1000#if 0
1001 /* Okay, this is MAJOR UGLY. but the only way I know how to
1002 * clear the "cache"
1003 */
1004 memset (&pl->socket.lastmap, 0, sizeof (struct Map));
1005 draw_client_map (pl->ob);
1006#endif
1007} 682}
1008 683
1009/** 684/**
1010 * Moves an object (typically, container to inventory). 685 * Moves an object (typically, container to inventory).
1011 * syntax is: move (to) (tag) (nrof) 686 * syntax is: move (to) (tag) (nrof)
… …
1014MoveCmd (char *buf, int len, player *pl) 689MoveCmd (char *buf, int len, player *pl)
1015{ 690{
1016 int vals[3], i; 691 int vals[3], i;
1017 692
1018 /* A little funky here. We only cycle for 2 records, because 693 /* A little funky here. We only cycle for 2 records, because
1019 * we obviously am not going to find a space after the third 694 * we obviously are not going to find a space after the third
1020 * record. Perhaps we should just replace this with a 695 * record. Perhaps we should just replace this with a
1021 * sscanf? 696 * sscanf?
1022 */ 697 */
1023 for (i = 0; i < 2; i++) 698 for (i = 0; i < 2; i++)
1024 { 699 {
1025 vals[i] = atoi (buf); 700 vals[i] = atoi (buf);
701
1026 if (!(buf = strchr (buf, ' '))) 702 if (!(buf = strchr (buf, ' ')))
1027 { 703 {
1028 LOG (llevError, "Incomplete move command: %s\n", buf); 704 LOG (llevError, "Incomplete move command: %s\n", buf);
1029 return; 705 return;
1030 } 706 }
707
1031 buf++; 708 buf++;
1032 } 709 }
710
1033 vals[2] = atoi (buf); 711 vals[2] = atoi (buf);
1034 712
1035/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/ 713/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
1036 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]); 714 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
1037} 715}
1038
1039
1040 716
1041/****************************************************************************** 717/******************************************************************************
1042 * 718 *
1043 * Start of commands the server sends to the client. 719 * Start of commands the server sends to the client.
1044 * 720 *
… …
1047/** 723/**
1048 * Asks the client to query the user. This way, the client knows 724 * Asks the client to query the user. This way, the client knows
1049 * it needs to send something back (vs just printing out a message) 725 * it needs to send something back (vs just printing out a message)
1050 */ 726 */
1051void 727void
1052send_query (NewSocket * ns, uint8 flags, char *text) 728send_query (client *ns, uint8 flags, const char *text)
1053{ 729{
1054 char buf[MAX_BUF];
1055
1056 sprintf (buf, "query %d %s", flags, text ? text : ""); 730 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
1057 ns->send_packet (buf); 731}
732
733/**
734 * Get player's current range attack in obuf.
735 */
736static void
737rangetostring (player *pl, char *obuf)
738{
739 dynbuf_text buf;
740
741 if (pl->ranged_ob)
742 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name;
743
744 if (pl->combat_ob)
745 buf << " Combat" << (pl->ob->current_weapon == pl->combat_ob ? "*" : "") << ": " << pl->combat_ob->name;
746
747#if 0
748 //TODO: remove this when slot system is working, this is only for debugging
749 if (pl->ob->chosen_skill)
750 buf << " Skill*: " << pl->ob->chosen_skill->name;
751#endif
752
753 //TODO: maybe golem should become the current_weapon, quite simply?
754 if (pl->golem)
755 buf << " Golem*: " << pl->golem->name;
756
757 buf << '\0';
758 buf.linearise (obuf);
1058} 759}
1059 760
1060#define AddIfInt64(Old,New,Type) if (Old != New) {\ 761#define AddIfInt64(Old,New,Type) if (Old != New) {\
1061 Old = New; \ 762 Old = New; \
1062 sl << uint8 (Type) << uint64 (New); \ 763 sl << uint8 (Type) << uint64 (New); \
… …
1070#define AddIfShort(Old,New,Type) if (Old != New) {\ 771#define AddIfShort(Old,New,Type) if (Old != New) {\
1071 Old = New; \ 772 Old = New; \
1072 sl << uint8 (Type) << uint16 (New); \ 773 sl << uint8 (Type) << uint16 (New); \
1073 } 774 }
1074 775
1075#define AddIfFloat(Old,New,Type) if (Old != New) {\ 776#define AddIfFloat(Old,New,Type,mult) if (Old != New) {\
1076 Old = New; \ 777 Old = New; \
1077 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \ 778 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI*mult); \
1078 } 779 }
1079 780
1080#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 781#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1081 free(Old); Old = strdup (New);\ 782 free(Old); Old = strdup (New);\
1082 sl << uint8 (Type) << data8 (New); \ 783 sl << uint8 (Type) << data8 (New); \
… …
1092esrv_update_stats (player *pl) 793esrv_update_stats (player *pl)
1093{ 794{
1094 char buf[MAX_BUF]; 795 char buf[MAX_BUF];
1095 uint16 flags; 796 uint16 flags;
1096 797
1097 packet sl; 798 client *ns = pl->ns;
1098 sl << "stats "; 799 if (!ns)
800 return;
1099 801
1100 if (pl->ob != NULL) 802 object *ob = pl->observe;
1101 { 803 if (!ob)
804 return;
805
806 player *opl = ob->contr ? static_cast<player *>(ob->contr) : pl;
807
808 packet sl ("stats");
809
1102 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 810 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1103 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 811 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1104 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 812 AddIfShort (ns->last_stats.sp, ob->stats.sp, CS_STAT_SP);
1105 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 813 AddIfShort (ns->last_stats.maxsp, ob->stats.maxsp, CS_STAT_MAXSP);
1106 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 814 AddIfShort (ns->last_stats.grace, ob->stats.grace, CS_STAT_GRACE);
1107 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 815 AddIfShort (ns->last_stats.maxgrace, ob->stats.maxgrace, CS_STAT_MAXGRACE);
1108 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 816 AddIfShort (ns->last_stats.Str, ob->stats.Str, CS_STAT_STR);
1109 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT);
1110 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW);
1111 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1112 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 817 AddIfShort (ns->last_stats.Dex, ob->stats.Dex, CS_STAT_DEX);
1113 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 818 AddIfShort (ns->last_stats.Con, ob->stats.Con, CS_STAT_CON);
819 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
820 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
821 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1114 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 822 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1115 }
1116 823
1117 if (pl->socket.exp64)
1118 {
1119 uint8 s;
1120
1121 for (s = 0; s < NUM_SKILLS; s++) 824 for (int s = 0; s < NUM_SKILLS; s++)
825 if (object *skill = opl->last_skill_ob[s])
826 if (skill->stats.exp != ns->last_skill_exp [s])
1122 { 827 {
1123 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 828 ns->last_skill_exp [s] = skill->stats.exp;
1124 { 829
1125 /* Always send along the level if exp changes. This is only 830 /* Always send along the level if exp changes. This is only
1126 * 1 extra byte, but keeps processing simpler. 831 * 1 extra byte, but keeps processing simpler.
1127 */ 832 */
1128 sl << uint8 (s + CS_STAT_SKILLINFO) 833 sl << uint8 (s + CS_STAT_SKILLINFO)
1129 << uint8 (pl->last_skill_ob[s]->level) 834 << uint8 (skill->level)
1130 << uint64 (pl->last_skill_ob[s]->stats.exp); 835 << uint64 (skill->stats.exp);
1131
1132 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1133 }
1134 } 836 }
1135 }
1136 837
1137 if (pl->socket.exp64)
1138 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) } 838 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
839 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
840 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
841 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
842 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
843 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED, 1.f/TICK);
844 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
845 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP, 1.f/TICK);
846 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
847
848 flags = 0;
849
850 if (opl->fire_on)
851 flags |= SF_FIREON;
852
853 if (opl->run_on)
854 flags |= SF_RUNON;
855
856 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
857
858 if (ns->sc_version < 1025)
859 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1139 else 860 else
1140 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1141
1142 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL);
1143 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC);
1144 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC);
1145 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM);
1146 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED);
1147 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD);
1148 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1149 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM);
1150 flags = 0;
1151
1152 if (pl->fire_on)
1153 flags |= SF_FIREON;
1154
1155 if (pl->run_on)
1156 flags |= SF_RUNON;
1157
1158 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS);
1159
1160 if (pl->socket.sc_version < 1025)
1161 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1162 else
1163 {
1164 int i;
1165
1166 for (i = 0; i < NROFATTACKS; i++) 861 for (int i = 0; i < NROFATTACKS; i++)
1167 { 862 {
1168 /* Skip ones we won't send */ 863 /* Skip ones we won't send */
1169 if (atnr_cs_stat[i] == -1) 864 if (atnr_cs_stat[i] == -1)
1170 continue; 865 continue;
1171 866
1172 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 867 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
1173 } 868 }
1174 }
1175 869
1176 if (pl->socket.monitor_spells) 870 if (pl->ns->monitor_spells)
1177 { 871 {
1178 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 872 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1179 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 873 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1180 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 874 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1181 } 875 }
1182 876
1183 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 877 rangetostring (opl, buf); /* we want use the new fire & run system in new client */
1184 AddIfString (pl->socket.stats.range, buf, CS_STAT_RANGE); 878 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1185 set_title (pl->ob, buf); 879 set_title (ob, buf);
1186 AddIfString (pl->socket.stats.title, buf, CS_STAT_TITLE); 880 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1187 881
1188 /* Only send it away if we have some actual data */ 882 /* Only send it away if we have some actual data */
1189 if (sl.len > 6) 883 if (sl.length () > 6)
1190 { 884 ns->send_packet (sl);
1191#ifdef ESRV_DEBUG
1192 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1193#endif
1194 Send_With_Handling (&pl->socket, &sl);
1195 }
1196
1197} 885}
1198 886
1199/** 887/**
1200 * Tells the client that here is a player it should start using. 888 * Tells the client that here is a player it should start using.
1201 */ 889 */
1202void 890void
1203esrv_new_player (player *pl, uint32 weight) 891esrv_new_player (player *pl, uint32 weight)
1204{ 892{
1205 pl->last_weight = weight; 893 packet sl ("player");
1206
1207 packet sl;
1208 sl << "player ";
1209 894
1210 sl << uint32 (pl->ob->count) 895 sl << uint32 (pl->ob->count)
1211 << uint32 (weight) 896 << uint32 (weight)
1212 << uint32 (pl->ob->face->number) 897 << uint32 (pl->ob->face)
1213 << data8 (pl->ob->name); 898 << data8 (pl->ob->name);
1214 899
1215 Send_With_Handling (&pl->socket, &sl); 900 pl->ns->last_weight = weight;
901 pl->ns->send_packet (sl);
1216 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 902 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1217} 903}
1218
1219/**
1220 * Need to send an animation sequence to the client.
1221 * We will send appropriate face commands to the client if we haven't
1222 * sent them the face yet (this can become quite costly in terms of
1223 * how much we are sending - on the other hand, this should only happen
1224 * when the player logs in and picks stuff up.
1225 */
1226void
1227esrv_send_animation (NewSocket * ns, short anim_num)
1228{
1229 int i;
1230
1231 /* Do some checking on the anim_num we got. Note that the animations
1232 * are added in contigous order, so if the number is in the valid
1233 * range, it must be a valid animation.
1234 */
1235 if (anim_num < 0 || anim_num > num_animations)
1236 {
1237 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1238 return;
1239 }
1240
1241 packet sl;
1242
1243 sl << "anim "
1244 << uint16 (anim_num)
1245 << uint16 (0); /* flags - not used right now */
1246
1247 /* Build up the list of faces. Also, send any information (ie, the
1248 * the face itself) down to the client.
1249 */
1250 for (i = 0; i < animations[anim_num].num_animations; i++)
1251 {
1252 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1253 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1254 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1255 }
1256
1257 Send_With_Handling (ns, &sl);
1258
1259 ns->anims_sent[anim_num] = 1;
1260}
1261
1262 904
1263/****************************************************************************** 905/******************************************************************************
1264 * 906 *
1265 * Start of map related commands. 907 * Start of map related commands.
1266 * 908 *
1267 ******************************************************************************/ 909 ******************************************************************************/
1268 910
1269/**
1270 * This adds face_num to a map cell at x,y. If the client doesn't have
1271 * the face yet, we will also send it.
1272 */
1273static void
1274esrv_map_setbelow (NewSocket * ns, int x, int y, short face_num, struct Map *newmap)
1275{
1276 if (newmap->cells[x][y].count >= MAP_LAYERS)
1277 {
1278 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1279 return;
1280 abort ();
1281 }
1282
1283 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1284 newmap->cells[x][y].count++;
1285
1286 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1287 esrv_send_face (ns, face_num, 0);
1288}
1289
1290struct LayerCell
1291{
1292 uint16 xy;
1293 short face;
1294};
1295
1296struct MapLayer
1297{
1298 int count;
1299 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1300};
1301
1302/** Checkes if map cells have changed */
1303static int
1304mapcellchanged (NewSocket * ns, int i, int j, struct Map *newmap)
1305{
1306 int k;
1307
1308 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1309 return 1;
1310 for (k = 0; k < newmap->cells[i][j].count; k++)
1311 {
1312 if (ns->lastmap.cells[i][j].faces[k] != newmap->cells[i][j].faces[k])
1313 {
1314 return 1;
1315 }
1316 }
1317 return 0;
1318}
1319
1320/**
1321 * Basically, what this does is pack the data into layers.
1322 * cnum is the client number, cur is the the buffer we put all of
1323 * this data into. we return the end of the data. layers is
1324 * how many layers of data we should back.
1325 */
1326static uint8 *
1327compactlayer (NewSocket * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1328{
1329 int x, y, k;
1330 int face;
1331 unsigned char *fcur;
1332 struct MapLayer layers[MAP_LAYERS];
1333
1334 for (k = 0; k < MAP_LAYERS; k++)
1335 layers[k].count = 0;
1336 fcur = cur;
1337 for (x = 0; x < ns->mapx; x++)
1338 {
1339 for (y = 0; y < ns->mapy; y++)
1340 {
1341 if (!mapcellchanged (ns, x, y, newmap))
1342 continue;
1343 if (newmap->cells[x][y].count == 0)
1344 {
1345 *cur = x * ns->mapy + y; /* mark empty space */
1346 cur++;
1347 continue;
1348 }
1349 for (k = 0; k < newmap->cells[x][y].count; k++)
1350 {
1351 layers[k].lcells[layers[k].count].xy = x * ns->mapy + y;
1352 layers[k].lcells[layers[k].count].face = newmap->cells[x][y].faces[k];
1353 layers[k].count++;
1354 }
1355 }
1356 }
1357 /* If no data, return now. */
1358 if (fcur == cur && layers[0].count == 0)
1359 return cur;
1360 *cur = 255; /* mark end of explicitly cleared cells */
1361 cur++;
1362 /* First pack by layers. */
1363 for (k = 0; k < numlayers; k++)
1364 {
1365 if (layers[k].count == 0)
1366 break; /* once a layer is entirely empty, no layer below it can
1367 have anything in it either */
1368 /* Pack by entries in thie layer */
1369 for (x = 0; x < layers[k].count;)
1370 {
1371 fcur = cur;
1372 *cur = layers[k].lcells[x].face >> 8;
1373 cur++;
1374 *cur = layers[k].lcells[x].face & 0xFF;
1375 cur++;
1376 face = layers[k].lcells[x].face;
1377 /* Now, we back the redundant data into 1 byte xy pairings */
1378 for (y = x; y < layers[k].count; y++)
1379 {
1380 if (layers[k].lcells[y].face == face)
1381 {
1382 *cur = (uint8) layers[k].lcells[y].xy;
1383 cur++;
1384 layers[k].lcells[y].face = -1;
1385 }
1386 }
1387 *(cur - 1) = *(cur - 1) | 128; /* mark for end of xy's; 11*11 < 128 */
1388 /* forward over the now redundant data */
1389 while (x < layers[k].count && layers[k].lcells[x].face == -1)
1390 x++;
1391 }
1392 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1393 }
1394 return cur;
1395}
1396
1397static void
1398esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1399{
1400 static long frames, bytes, tbytes, tframes;
1401 char *cur;
1402
1403 packet sl;
1404 sl << "map ";
1405
1406 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1407 sl.len = cur - (char *) sl.buf;
1408
1409/* LOG(llevDebug, "Sending map command.\n");*/
1410
1411 if (sl.len > (int) strlen ("map ") || ns->sent_scroll)
1412 {
1413 /* All of this is just accounting stuff */
1414 if (tframes > 100)
1415 tframes = tbytes = 0;
1416
1417 tframes++;
1418 frames++;
1419 tbytes += sl.len;
1420 bytes += sl.len;
1421 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1422 Send_With_Handling (ns, &sl);
1423 ns->sent_scroll = 0;
1424 }
1425
1426}
1427
1428
1429/** Clears a map cell */ 911/** Clears a map cell */
1430static void 912static void
1431map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 913map_clearcell (struct MapCell *cell, int count)
1432{ 914{
1433 cell->faces[0] = face0; 915 cell->faces[0] = 0;
1434 cell->faces[1] = face1; 916 cell->faces[1] = 0;
1435 cell->faces[2] = face2; 917 cell->faces[2] = 0;
918 cell->smooth[0] = 0;
919 cell->smooth[1] = 0;
920 cell->smooth[2] = 0;
1436 cell->count = count; 921 cell->count = count;
1437 cell->stat_hp = 0; 922 cell->stat_hp = 0;
1438 cell->flags = 0; 923 cell->flags = 0;
1439 cell->player = 0; 924 cell->player = 0;
1440} 925}
1441 926
1442#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1443#define MAX_LAYERS 3 927#define MAX_LAYERS 3
1444
1445/* Using a global really isn't a good approach, but saves the over head of
1446 * allocating and deallocating such a block of data each time run through,
1447 * and saves the space of allocating this in the socket object when we only
1448 * need it for this cycle. If the serve is ever threaded, this needs to be
1449 * re-examined.
1450 */
1451
1452static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1453
1454/**
1455 * Returns true if any of the heads for this
1456 * space is set. Returns false if all are blank - this is used
1457 * for empty space checking.
1458 */
1459static inline int
1460have_head (int ax, int ay)
1461{
1462
1463 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1464 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1465 return 1;
1466 return 0;
1467}
1468
1469/**
1470 * check_head is a bit simplistic version of update_space below.
1471 * basically, it only checks the that the head on space ax,ay at layer
1472 * needs to get sent - if so, it adds the data, sending the head
1473 * if needed, and returning 1. If this no data needs to get
1474 * sent, it returns zero.
1475 */
1476static int
1477check_head (packet &sl, NewSocket &ns, int ax, int ay, int layer)
1478{
1479 short face_num;
1480
1481 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1482 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1483 else
1484 face_num = 0;
1485
1486 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1487 {
1488 sl << uint16 (face_num);
1489 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1490 esrv_send_face (&ns, face_num, 0);
1491
1492 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1493 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1494 return 1;
1495 }
1496
1497 return 0; /* No change */
1498}
1499 928
1500/** 929/**
1501 * Removes the need to replicate the same code for each layer. 930 * Removes the need to replicate the same code for each layer.
1502 * this returns true if this space is now in fact different than 931 * this returns true if this space is now in fact different than
1503 * it was. 932 * it was.
1504 * sl is the socklist this data is going into. 933 * sl is the socklist this data is going into.
1505 * ns is the socket we are working on - all the info we care 934 * ns is the socket we are working on - all the info we care
1506 * about is in this socket structure, so now need not pass the 935 * about is in this socket structure, so now need not pass the
1507 * entire player object. 936 * entire player object.
1508 * mx and my are map coordinate offsets for map mp
1509 * sx and sy are the offsets into the socket structure that
1510 * holds the old values.
1511 * layer is the layer to update, with 2 being the floor and 0 the 937 * layer is the layer to update, with 2 being the floor and 0 the
1512 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ) 938 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ)
1513 * take. Interesting to note that before this function, the map1 function 939 * take. Interesting to note that before this function, the map1 function
1514 * numbers the spaces differently - I think this was a leftover from 940 * numbers the spaces differently - I think this was a leftover from
1515 * the map command, where the faces stack up. Sinces that is no longer 941 * the map command, where the faces stack up. Sinces that is no longer
1516 * the case, it seems to make more sense to have these layer values 942 * the case, it seems to make more sense to have these layer values
1517 * actually match. 943 * actually match.
1518 */ 944 */
1519
1520static int 945static int
1521update_space (packet &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 946update_space (packet &sl, client &ns, mapspace &ms, MapCell &lastcell, int layer)
1522{ 947{
1523 object *ob, *head; 948 object *ob = ms.faces_obj [layer];
1524 uint16 face_num;
1525 int bx, by, i;
1526
1527 /* If there is a multipart object stored away, treat that as more important.
1528 * If not, then do the normal processing.
1529 */
1530 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1531
1532 /* Check to see if this head is part of the set of objects
1533 * we would normally send for this space. If so, then
1534 * don't use the head value. We need to do the check
1535 * here and not when setting up the heads[] value for two reasons -
1536 * 1) the heads[] values will get used even if the space is not visible.
1537 * 2) its possible the head is not on the same map as a part, and I'd
1538 * rather not need to do the map translation overhead.
1539 * 3) We need to do some extra checking to make sure that we will
1540 * otherwise send the image as this layer, eg, either it matches
1541 * the head value, or is not multipart.
1542 */
1543 if (head && !head->more)
1544 {
1545 for (i = 0; i < MAP_LAYERS; i++)
1546 {
1547 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1548 if (!ob)
1549 continue;
1550
1551 if (ob->head)
1552 ob = ob->head;
1553
1554 if (ob == head)
1555 {
1556 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1557 head = NULL;
1558 break;
1559 }
1560 }
1561 }
1562
1563 ob = head;
1564 if (!ob)
1565 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1566 949
1567 /* If there is no object for this space, or if the face for the object 950 /* If there is no object for this space, or if the face for the object
1568 * is the blank face, set the face number to zero. 951 * is the blank face, set the face number to zero.
1569 * else if we have the stored head object for this space, that takes 952 * else if we have the stored head object for this space, that takes
1570 * precedence over the other object for this space. 953 * precedence over the other object for this space.
1571 * otherwise, we do special head processing 954 * otherwise, we do special head processing
1572 */ 955 */
1573 if (!ob || ob->face == blank_face) 956 uint16 face_num = ob && ob->face != blank_face ? ob->face : 0;
1574 face_num = 0;
1575 else if (head)
1576 {
1577 /* if this is a head that had previously been stored */
1578 face_num = ob->face->number;
1579 }
1580 else
1581 {
1582 /* if the faces for the different parts of a multipart object
1583 * are the same, we only want to send the bottom right most
1584 * portion of the object. That info is in the tail_.. values
1585 * of the head. Note that for the head itself, ob->head will
1586 * be null, so we only do this block if we are working on
1587 * a tail piece.
1588 */
1589
1590 /* tail_x and tail_y will only be set in the head object. If
1591 * this is the head object and these are set, we proceed
1592 * with logic to only send bottom right. Similarly, if
1593 * this is one of the more parts but the head has those values
1594 * set, we want to do the processing. There can be cases where
1595 * the head is not visible but one of its parts is, so we just
1596 * can always expect that ob->arch->tail_x will be true for all
1597 * object we may want to display.
1598 */
1599 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1600 {
1601
1602 if (ob->head)
1603 head = ob->head;
1604 else
1605 head = ob;
1606
1607 /* Basically figure out where the offset is from where we are right
1608 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1609 * piece is from the head, and the tail is where the tail is from the
1610 * head. Note that bx and by will equal sx and sy if we are already working
1611 * on the bottom right corner. If ob is the head, the clone values
1612 * will be zero, so the right thing will still happen.
1613 */
1614 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1615 by = sy + head->arch->tail_y - ob->arch->clone.y;
1616
1617 /* I don't think this can ever happen, but better to check for it just
1618 * in case.
1619 */
1620 if (bx < sx || by < sy)
1621 {
1622 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1623 face_num = 0;
1624 }
1625 /* single part object, multipart object with non merged faces,
1626 * of multipart object already at lower right.
1627 */
1628 else if (bx == sx && by == sy)
1629 {
1630 face_num = ob->face->number;
1631
1632 /* if this face matches one stored away, clear that one away.
1633 * this code relies on the fact that the map1 commands
1634 * goes from 2 down to 0.
1635 */
1636 for (i = 0; i < MAP_LAYERS; i++)
1637 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1638 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1639 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1640 }
1641 else
1642 {
1643 /* If this head is stored away, clear it - otherwise,
1644 * there can be cases where a object is on multiple layers -
1645 * we only want to send it once.
1646 */
1647 face_num = head->face->number;
1648 for (i = 0; i < MAP_LAYERS; i++)
1649 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1650 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1651 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1652
1653 /* First, try to put the new head on the same layer. If that is used up,
1654 * then find another layer.
1655 */
1656 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1657 {
1658 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1659 }
1660 else
1661 for (i = 0; i < MAX_LAYERS; i++)
1662 {
1663 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1664 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1665 {
1666 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1667 }
1668 }
1669 face_num = 0; /* Don't send this object - we'll send the head later */
1670 }
1671 }
1672 else
1673 {
1674 /* In this case, we are already at the lower right or single part object,
1675 * so nothing special
1676 */
1677 face_num = ob->face->number;
1678
1679 /* clear out any head entries that have the same face as this one */
1680 for (bx = 0; bx < layer; bx++)
1681 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1682 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1683 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1684 }
1685 } /* else not already head object or blank face */
1686
1687 /* This is a real hack. Basically, if we have nothing to send for this layer,
1688 * but there is a head on the next layer, send that instead.
1689 * Without this, what happens is you can get the case where the player stands
1690 * on the same space as the head. However, if you have overlapping big objects
1691 * of the same type, what happens then is it doesn't think it needs to send
1692 * This tends to make stacking also work/look better.
1693 */
1694 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1695 {
1696 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1697 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1698 }
1699
1700 /* Another hack - because of heads and whatnot, this face may match one
1701 * we already sent for a lower layer. In that case, don't send
1702 * this one.
1703 */
1704 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1705 face_num = 0;
1706 957
1707 /* We've gotten what face we want to use for the object. Now see if 958 /* We've gotten what face we want to use for the object. Now see if
1708 * if it has changed since we last sent it to the client. 959 * if it has changed since we last sent it to the client.
1709 */ 960 */
1710 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num) 961 if (lastcell.faces[layer] != face_num)
1711 { 962 {
1712 ns.lastmap.cells[sx][sy].faces[layer] = face_num; 963 lastcell.faces[layer] = face_num;
964
1713 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 965 if (!ns.faces_sent[face_num])
966 if (ob)
967 ns.send_faces (ob);
968 else
1714 esrv_send_face (&ns, face_num, 0); 969 ns.send_face (face_num, 10);
1715 970
1716 sl << uint16 (face_num); 971 sl << uint16 (face_num);
1717 return 1;
1718 }
1719
1720 /* Nothing changed */
1721 return 0;
1722}
1723
1724/**
1725 * This function is mainly a copy of update_space,
1726 * except it handles update of the smoothing updates,
1727 * not the face updates.
1728 * Removes the need to replicate the same code for each layer.
1729 * this returns true if this smooth is now in fact different
1730 * than it was.
1731 * sl is the socklist this data is going into.
1732 * ns is the socket we are working on - all the info we care
1733 * about is in this socket structure, so know need to pass the
1734 * entire player object.
1735 * mx and my are map coordinate offsets for map mp
1736 * sx and sy are the offsets into the socket structure that
1737 * holds the old values.
1738 * layer is the layer to update, with 2 being the floor and 0 the
1739 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1740 * take.
1741 */
1742
1743static inline int
1744update_smooth (packet &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1745{
1746 object *ob;
1747 int smoothlevel; /* old face_num; */
1748
1749 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1750
1751 /* If there is no object for this space, or if the face for the object
1752 * is the blank face, set the smoothlevel to zero.
1753 */
1754 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1755 smoothlevel = 0;
1756 else
1757 {
1758 smoothlevel = ob->smoothlevel;
1759 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1760 SendSmooth (&ns, ob->face->number);
1761 } /* else not already head object or blank face */
1762
1763 /* We've gotten what face we want to use for the object. Now see if
1764 * if it has changed since we last sent it to the client.
1765 */
1766 if (smoothlevel > 255)
1767 smoothlevel = 255;
1768 else if (smoothlevel < 0)
1769 smoothlevel = 0;
1770
1771 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1772 {
1773 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1774 sl << uint8 (smoothlevel);
1775 return 1; 972 return 1;
1776 } 973 }
1777 974
1778 /* Nothing changed */ 975 /* Nothing changed */
1779 return 0; 976 return 0;
… …
1783 * Returns the size of a data for a map square as returned by 980 * Returns the size of a data for a map square as returned by
1784 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries 981 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1785 * available. 982 * available.
1786 */ 983 */
1787int 984int
1788getExtendedMapInfoSize (NewSocket * ns) 985getExtendedMapInfoSize (client * ns)
1789{ 986{
1790 int result = 0; 987 int result = 0;
1791 988
1792 if (ns->ext_mapinfos) 989 if (ns->ext_mapinfos)
1793 { 990 {
1794 if (ns->EMI_smooth) 991 if (ns->EMI_smooth)
1795 result += 1; /*One byte for smoothlevel */ 992 result += 1; /*One byte for smoothlevel */
1796 } 993 }
994
1797 return result; 995 return result;
1798} 996}
1799 997
998// prefetch (and touch) all maps within a specific distancd
999static void
1000prefetch_surrounding_maps (maptile *map, int distance)
1001{
1002 map->last_access = runtime;
1003
1004 if (--distance)
1005 for (int dir = 4; --dir; )
1006 if (const shstr &path = map->tile_path [dir])
1007 if (maptile *&neigh = map->tile_map [dir])
1008 prefetch_surrounding_maps (neigh, distance);
1009 else
1010 neigh = maptile::find_async (path, map);
1011}
1012
1013// prefetch a generous area around the player
1014static void
1015prefetch_surrounding_maps (object *op)
1016{
1017 prefetch_surrounding_maps (op->map, 3);
1018}
1019
1800/** 1020/**
1801 * This function uses the new map1 protocol command to send the map 1021 * Draws client map.
1802 * to the client. It is necessary because the old map command supports
1803 * a maximum map size of 15x15.
1804 * This function is much simpler than the old one. This is because
1805 * the old function optimized to send as few face identifiers as possible,
1806 * at the expense of sending more coordinate location (coordinates were
1807 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1808 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1809 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1810 * and use the other 4 bits for other informatiion. For full documentation
1811 * of what we send, see the doc/Protocol file.
1812 * I will describe internally what we do:
1813 * the socket->lastmap shows how the map last looked when sent to the client.
1814 * in the lastmap structure, there is a cells array, which is set to the
1815 * maximum viewable size (As set in config.h).
1816 * in the cells, there are faces and a count value.
1817 * we use the count value to hold the darkness value. If -1, then this space
1818 * is not viewable.
1819 * we use faces[0] faces[1] faces[2] to hold what the three layers
1820 * look like.
1821 */ 1022 */
1822void 1023void
1823draw_client_map1 (object *pl) 1024draw_client_map (player *pl)
1824{ 1025{
1026 object *ob = pl->observe;
1027 if (!ob->active)
1028 return;
1029
1030 maptile *plmap = ob->map;
1031
1032 /* If player is just joining the game, he isn't here yet, so the map
1033 * can get swapped out. If so, don't try to send them a map. All will
1034 * be OK once they really log in.
1035 */
1036 if (!plmap || plmap->in_memory != MAP_ACTIVE)
1037 return;
1038
1825 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1039 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1826 sint16 nx, ny;
1827 int estartlen, eoldlen; 1040 int estartlen, eoldlen;
1828 uint16 mask, emask;
1829 uint8 eentrysize; 1041 uint8 eentrysize;
1830 uint16 ewhatstart, ewhatflag; 1042 uint16 ewhatstart, ewhatflag;
1831 uint8 extendedinfos; 1043 uint8 extendedinfos;
1832 maptile *m;
1833 1044
1834 NewSocket &socket = pl->contr->socket;
1835
1836 check_map_change (pl->contr); 1045 check_map_change (pl);
1046 prefetch_surrounding_maps (pl->ob);
1837 1047
1838 packet sl; 1048 /* do LOS after calls to update_position */
1049 if (ob != pl->ob)
1050 clear_los (pl);
1051 else if (pl->do_los)
1052 {
1053 update_los (ob);
1054 pl->do_los = 0;
1055 }
1056
1057 /**
1058 * This function uses the new map1 protocol command to send the map
1059 * to the client. It is necessary because the old map command supports
1060 * a maximum map size of 15x15.
1061 * This function is much simpler than the old one. This is because
1062 * the old function optimized to send as few face identifiers as possible,
1063 * at the expense of sending more coordinate location (coordinates were
1064 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1065 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1066 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1067 * and use the other 4 bits for other informatiion. For full documentation
1068 * of what we send, see the doc/Protocol file.
1069 * I will describe internally what we do:
1070 * the ns->lastmap shows how the map last looked when sent to the client.
1071 * in the lastmap structure, there is a cells array, which is set to the
1072 * maximum viewable size (As set in config.h).
1073 * in the cells, there are faces and a count value.
1074 * we use the count value to hold the darkness value. If -1, then this space
1075 * is not viewable.
1076 * we use faces[0] faces[1] faces[2] to hold what the three layers
1077 * look like.
1078 */
1079
1080 client &socket = *pl->ns;
1081
1082 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1839 packet esl; 1083 packet esl;
1840 1084
1841 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1842 startlen = sl.len; 1085 startlen = sl.length ();
1843 1086
1844 /*Extendedmapinfo structure initialisation */ 1087 /*Extendedmapinfo structure initialisation */
1845 if (socket.ext_mapinfos) 1088 if (socket.ext_mapinfos)
1846 { 1089 {
1847 extendedinfos = EMI_NOREDRAW; 1090 extendedinfos = EMI_NOREDRAW;
1848 1091
1849 if (socket.EMI_smooth) 1092 if (socket.EMI_smooth)
1850 extendedinfos |= EMI_SMOOTH; 1093 extendedinfos |= EMI_SMOOTH;
1851 1094
1852 ewhatstart = esl.len; 1095 ewhatstart = esl.length ();
1853 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 1096 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1854 could need to be taken away */ 1097 could need to be taken away */
1855 eentrysize = getExtendedMapInfoSize (&socket); 1098 eentrysize = getExtendedMapInfoSize (&socket);
1856 esl << "mapextended " 1099 esl << "mapextended "
1857 << uint8 (extendedinfos) 1100 << uint8 (extendedinfos)
1858 << uint8 (eentrysize); 1101 << uint8 (eentrysize);
1102
1859 estartlen = esl.len; 1103 estartlen = esl.length ();
1860 }
1861 else
1862 { 1104 }
1863 /* suppress compiler warnings */
1864 ewhatstart = 0;
1865 ewhatflag = 0;
1866 estartlen = 0;
1867 }
1868
1869 /* Init data to zero */
1870 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1871 1105
1872 /* x,y are the real map locations. ax, ay are viewport relative 1106 /* x,y are the real map locations. ax, ay are viewport relative
1873 * locations. 1107 * locations.
1874 */ 1108 */
1875 ay = 0; 1109 ay = 0;
1876 1110
1877 /* We could do this logic as conditionals in the if statement, 1111 /* We could do this logic as conditionals in the if statement,
1878 * but that started to get a bit messy to look at. 1112 * but that started to get a bit messy to look at.
1879 */ 1113 */
1880 max_x = pl->x + (socket.mapx + 1) / 2; 1114 max_x = ob->x + (socket.mapx + 1) / 2;
1881 max_y = pl->y + (socket.mapy + 1) / 2; 1115 max_y = ob->y + (socket.mapy + 1) / 2;
1882 1116
1883 if (socket.mapmode == Map1aCmd)
1884 {
1885 max_x += MAX_HEAD_OFFSET;
1886 max_y += MAX_HEAD_OFFSET;
1887 }
1888
1889 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1117 for (y = ob->y - socket.mapy / 2; y < max_y; y++, ay++)
1890 { 1118 {
1119 sint16 nx, ny;
1120 maptile *m = 0;
1121
1891 ax = 0; 1122 ax = 0;
1892 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1123 for (x = ob->x - socket.mapx / 2; x < max_x; x++, ax++)
1893 { 1124 {
1125 // check to see if we can simply go one right quickly
1126 ++nx;
1127 if (m && nx >= m->width)
1128 m = 0;
1894 1129
1130 if (!m)
1131 {
1132 nx = x; ny = y; m = plmap;
1133
1134 if (xy_normalise (m, nx, ny))
1135 m->touch ();
1136 else
1137 m = 0;
1138 }
1139
1140 int emask, mask;
1895 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1141 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1896 1142
1897 /* If this space is out of the normal viewable area, we only check
1898 * the heads value ax or ay will only be greater than what
1899 * the client wants if using the map1a command - this is because
1900 * if the map1a command is not used, max_x and max_y will be
1901 * set to lower values.
1902 */
1903 if (ax >= socket.mapx || ay >= socket.mapy)
1904 {
1905 int i, got_one;
1906
1907 oldlen = sl.len;
1908
1909 sl << uint16 (mask);
1910
1911 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1912 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1913 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1914
1915 /* If all we are doing is sending 0 (blank) faces, we don't
1916 * actually need to send that - just the coordinates
1917 * with no faces tells the client to blank out the
1918 * space.
1919 */
1920 got_one = 0;
1921 for (i = oldlen + 2; i < sl.len; i++)
1922 if (sl.buf[i])
1923 got_one = 1;
1924
1925 if (got_one && (mask & 0xf))
1926 sl.buf[oldlen + 1] = mask & 0xff;
1927 else
1928 { /*either all faces blank, either no face at all */
1929 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1930 sl.len = oldlen + 2;
1931 else
1932 sl.len = oldlen;
1933 }
1934
1935 /*What concerns extendinfos, nothing to be done for now
1936 * (perhaps effects layer later)
1937 */
1938 continue; /* don't do processing below */
1939 }
1940
1941 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1143 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1942
1943 d = pl->contr->blocked_los[ax][ay];
1944 1144
1945 /* If the coordinates are not valid, or it is too dark to see, 1145 /* If the coordinates are not valid, or it is too dark to see,
1946 * we tell the client as such 1146 * we tell the client as such
1947 */ 1147 */
1948 nx = x;
1949 ny = y;
1950 m = get_map_from_coord (pl->map, &nx, &ny);
1951
1952 if (!m) 1148 if (!m)
1953 { 1149 {
1954 /* space is out of map. Update space and clear values 1150 /* space is out of map. Update space and clear values
1955 * if this hasn't already been done. If the space is out 1151 * if this hasn't already been done. If the space is out
1956 * of the map, it shouldn't have a head 1152 * of the map, it shouldn't have a head
1957 */ 1153 */
1958 if (lastcell.count != -1) 1154 if (lastcell.count != -1)
1959 { 1155 {
1960 sl << uint16 (mask); 1156 sl << uint16 (mask);
1961 map_clearcell (&lastcell, 0, 0, 0, -1); 1157 map_clearcell (&lastcell, -1);
1962 } 1158 }
1159
1160 continue;
1963 } 1161 }
1162
1163 int d = pl->blocked_los[ax][ay];
1164
1964 else if (d > 3) 1165 if (d > 3)
1965 { 1166 {
1167
1966 int need_send = 0, count; 1168 int need_send = 0, count;
1967 1169
1968 /* This block deals with spaces that are not visible for whatever 1170 /* This block deals with spaces that are not visible for whatever
1969 * reason. Still may need to send the head for this space. 1171 * reason. Still may need to send the head for this space.
1970 */ 1172 */
1971 1173
1972 oldlen = sl.len; 1174 oldlen = sl.length ();
1973 1175
1974 sl << uint16 (mask); 1176 sl << uint16 (mask);
1975 1177
1976 if (lastcell.count != -1) 1178 if (lastcell.count != -1)
1977 need_send = 1; 1179 need_send = 1;
1978 1180
1979 count = -1; 1181 count = -1;
1980 1182
1981 if (socket.mapmode == Map1aCmd && have_head (ax, ay)) 1183 /* properly clear a previously sent big face */
1982 { 1184 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1983 /* Now check to see if any heads need to be sent */ 1185 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1186 need_send = 1;
1984 1187
1985 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4; 1188 map_clearcell (&lastcell, count);
1986 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1987 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1988 1189
1989 lastcell.count = count; 1190 if ((mask & 0xf) || need_send)
1990 } 1191 sl[oldlen + 1] = mask & 0xff;
1991 else 1192 else
1992 {
1993 /* properly clear a previously sent big face */
1994 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0
1995 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1996 need_send = 1;
1997
1998 map_clearcell (&lastcell, 0, 0, 0, count);
1999 }
2000
2001 if ((mask & 0xf) || need_send)
2002 sl.buf[oldlen + 1] = mask & 0xff;
2003 else
2004 sl.len = oldlen; 1193 sl.reset (oldlen);
2005 } 1194 }
2006 else 1195 else
2007 { 1196 {
2008 /* In this block, the space is visible or there are head objects 1197 /* In this block, the space is visible.
2009 * we need to send.
2010 */ 1198 */
2011 1199
2012 /* Rather than try to figure out what everything that we might 1200 /* Rather than try to figure out what everything that we might
2013 * need to send is, then form the packet after that, 1201 * need to send is, then form the packet after that,
2014 * we presume that we will in fact form a packet, and update 1202 * we presume that we will in fact form a packet, and update
2015 * the bits by what we do actually send. If we send nothing, 1203 * the bits by what we do actually send. If we send nothing,
2016 * we just back out sl.len to the old value, and no harm 1204 * we just back out sl.length () to the old value, and no harm
2017 * is done. 1205 * is done.
2018 * I think this is simpler than doing a bunch of checks to see 1206 * I think this is simpler than doing a bunch of checks to see
2019 * what if anything we need to send, setting the bits, then 1207 * what if anything we need to send, setting the bits, then
2020 * doing those checks again to add the real data. 1208 * doing those checks again to add the real data.
2021 */ 1209 */
2022 oldlen = sl.len; 1210 oldlen = sl.length ();
2023 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2024 eoldlen = esl.len; 1211 eoldlen = esl.length ();
2025 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1212
2026 sl << uint16 (mask); 1213 sl << uint16 (mask);
2027
2028 if (socket.ext_mapinfos)
2029 esl << uint16 (emask);
2030 1214
2031 unsigned char dummy; 1215 unsigned char dummy;
2032 unsigned char *last_ext = &dummy; 1216 unsigned char *last_ext = &dummy;
2033 1217
2034 /* Darkness changed */ 1218 /* Darkness changed */
… …
2037 mask |= 0x8; 1221 mask |= 0x8;
2038 1222
2039 if (socket.extmap) 1223 if (socket.extmap)
2040 { 1224 {
2041 *last_ext |= 0x80; 1225 *last_ext |= 0x80;
2042 last_ext = sl.buf + sl.len; 1226 last_ext = &sl[sl.length ()];
2043 sl << uint8 (d); 1227 sl << uint8 (d);
2044 } 1228 }
2045 else 1229 else
2046 sl << uint8 (255 - 64 * d); 1230 sl << uint8 (255 - 64 * d);
2047 } 1231 }
2048 1232
2049 lastcell.count = d; 1233 lastcell.count = d;
2050 1234
1235 mapspace &ms = m->at (nx, ny);
1236 ms.update ();
1237
2051 if (socket.extmap) 1238 if (socket.extmap)
2052 { 1239 {
2053 uint8 stat_hp = 0; 1240 uint8 stat_hp = 0;
2054 uint8 stat_width = 0; 1241 uint8 stat_width = 0;
2055 uint8 flags = 0; 1242 uint8 flags = 0;
2056 UUID player = 0; 1243 tag_t player = 0;
2057 1244
2058 // send hp information, if applicable 1245 // send hp information, if applicable
2059 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1246 if (object *op = ms.faces_obj [0])
1247 if (op->is_head () && !op->invisible)
2060 { 1248 {
2061 if (op->head || op->invisible) 1249 if (op->stats.maxhp > op->stats.hp
2062 ; // do not show 1250 && op->stats.maxhp > 0
2063 else if (op->type == PLAYER 1251 && (op->type == PLAYER
1252 || op->type == DOOR // does not work, have maxhp 0
2064 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1253 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)))
2065 {
2066 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
2067 { 1254 {
2068 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp; 1255 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
2069 stat_width = op->arch->tail_x; 1256 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
2070 } 1257 }
2071 }
2072 1258
2073 if (op->msg && op->msg[0] == '@') 1259 if (op->msg && op->msg[0] == '@')
2074 flags |= 1; 1260 flags |= 1;
2075 1261
2076 if (op->type == PLAYER && op != pl) 1262 if (op->type == PLAYER && op != ob)
2077 player = op->count; 1263 player = op->count;
2078 } 1264 }
2079 1265
2080 if (lastcell.stat_hp != stat_hp) 1266 if (lastcell.stat_hp != stat_hp)
2081 { 1267 {
2082 lastcell.stat_hp = stat_hp; 1268 lastcell.stat_hp = stat_hp;
2083 1269
2084 mask |= 0x8; 1270 mask |= 0x8;
2085 *last_ext |= 0x80; 1271 *last_ext |= 0x80;
2086 last_ext = sl.buf + sl.len; 1272 last_ext = &sl[sl.length ()];
2087 1273
2088 sl << uint8 (5) << uint8 (stat_hp); 1274 sl << uint8 (5) << uint8 (stat_hp);
2089 1275
2090 if (stat_width > 1) 1276 if (stat_width > 1)
2091 { 1277 {
2092 *last_ext |= 0x80; 1278 *last_ext |= 0x80;
2093 last_ext = sl.buf + sl.len; 1279 last_ext = &sl[sl.length ()];
2094 1280
2095 sl << uint8 (6) << uint8 (stat_width); 1281 sl << uint8 (6) << uint8 (stat_width);
2096 } 1282 }
2097 } 1283 }
2098 1284
… …
2100 { 1286 {
2101 lastcell.player = player; 1287 lastcell.player = player;
2102 1288
2103 mask |= 0x8; 1289 mask |= 0x8;
2104 *last_ext |= 0x80; 1290 *last_ext |= 0x80;
2105 last_ext = sl.buf + sl.len; 1291 last_ext = &sl[sl.length ()];
2106 1292
2107 sl << uint8 (0x47) << uint8 (8) << (uint64)player; 1293 sl << uint8 (0x47) << uint8 (4) << (uint32)player;
2108 } 1294 }
2109 1295
2110 if (lastcell.flags != flags) 1296 if (lastcell.flags != flags)
2111 { 1297 {
2112 lastcell.flags = flags; 1298 lastcell.flags = flags;
2113 1299
2114 mask |= 0x8; 1300 mask |= 0x8;
2115 *last_ext |= 0x80; 1301 *last_ext |= 0x80;
2116 last_ext = sl.buf + sl.len; 1302 last_ext = &sl[sl.length ()];
2117 1303
2118 sl << uint8 (8) << uint8 (flags); 1304 sl << uint8 (8) << uint8 (flags);
2119 } 1305 }
2120 } 1306 }
2121 1307
2122 /* Floor face */ 1308 /* Floor face */
2123 if (update_space (sl, socket, m, nx, ny, ax, ay, 2)) 1309 if (update_space (sl, socket, ms, lastcell, 2))
2124 mask |= 0x4; 1310 mask |= 0x4;
2125 1311
2126 if (socket.EMI_smooth)
2127 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2128 emask |= 0x4;
2129
2130 /* Middle face */ 1312 /* Middle face */
2131 if (update_space (sl, socket, m, nx, ny, ax, ay, 1)) 1313 if (update_space (sl, socket, ms, lastcell, 1))
2132 mask |= 0x2; 1314 mask |= 0x2;
2133 1315
2134 if (socket.EMI_smooth) 1316 if (ms.player () == ob
2135 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1)) 1317 && (ob->invisible & (ob->invisible < 50 ? 1 : 7)))
2136 emask |= 0x2;
2137
2138 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2139 { 1318 {
1319 // force player to be visible to himself if invisible
2140 if (lastcell.faces[0] != pl->face->number) 1320 if (lastcell.faces[0] != ob->face)
2141 { 1321 {
2142 lastcell.faces[0] = pl->face->number; 1322 lastcell.faces[0] = ob->face;
1323
2143 mask |= 0x1; 1324 mask |= 0x1;
2144
2145 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2146 esrv_send_face (&socket, pl->face->number, 0);
2147
2148 sl << uint16 (pl->face->number); 1325 sl << uint16 (ob->face);
1326
1327 socket.send_faces (ob);
2149 } 1328 }
2150 } 1329 }
2151 else
2152 {
2153 /* Top face */ 1330 /* Top face */
2154 if (update_space (sl, socket, m, nx, ny, ax, ay, 0)) 1331 else if (update_space (sl, socket, ms, lastcell, 0))
2155 mask |= 0x1; 1332 mask |= 0x1;
2156
2157 if (socket.EMI_smooth)
2158 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2159 emask |= 0x1;
2160 }
2161 1333
2162 /* Check to see if we are in fact sending anything for this 1334 /* Check to see if we are in fact sending anything for this
2163 * space by checking the mask. If so, update the mask. 1335 * space by checking the mask. If so, update the mask.
2164 * if not, reset the len to that from before adding the mask 1336 * if not, reset the len to that from before adding the mask
2165 * value, so we don't send those bits. 1337 * value, so we don't send those bits.
2166 */ 1338 */
2167 if (mask & 0xf) 1339 if (mask & 0xf)
2168 sl.buf[oldlen + 1] = mask & 0xff; 1340 sl[oldlen + 1] = mask & 0xff;
2169 else 1341 else
2170 sl.len = oldlen; 1342 sl.reset (oldlen);
2171 1343
1344 if (socket.ext_mapinfos)
1345 esl << uint16 (emask);
1346
1347 if (socket.EMI_smooth)
1348 {
1349 for (int layer = 2+1; layer--; )
1350 {
1351 object *ob = ms.faces_obj [layer];
1352
1353 // If there is no object for this space, or if the face for the object
1354 // is the blank face, set the smoothlevel to zero.
1355 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1356
1357 // We've gotten what face we want to use for the object. Now see if
1358 // if it has changed since we last sent it to the client.
1359 if (lastcell.smooth[layer] != smoothlevel)
1360 {
1361 lastcell.smooth[layer] = smoothlevel;
1362 esl << uint8 (smoothlevel);
1363 emask |= 1 << layer;
1364 }
1365 }
1366
2172 if (emask & 0xf) 1367 if (emask & 0xf)
2173 esl.buf[eoldlen + 1] = emask & 0xff; 1368 esl[eoldlen + 1] = emask & 0xff;
2174 else 1369 else
2175 esl.len = eoldlen; 1370 esl.reset (eoldlen);
1371 }
2176 } /* else this is a viewable space */ 1372 } /* else this is a viewable space */
2177 } /* for x loop */ 1373 } /* for x loop */
2178 } /* for y loop */ 1374 } /* for y loop */
2179 1375
1376 socket.flush_fx ();
1377
2180 /* Verify that we in fact do need to send this */ 1378 /* Verify that we in fact do need to send this */
2181 if (socket.ext_mapinfos) 1379 if (socket.ext_mapinfos)
2182 { 1380 {
2183 if (!(sl.len > startlen || socket.sent_scroll)) 1381 if (!(sl.length () > startlen || socket.sent_scroll))
2184 { 1382 {
2185 /* No map data will follow, so don't say the client 1383 /* No map data will follow, so don't say the client
2186 * it doesn't need draw! 1384 * it doesn't need draw!
2187 */ 1385 */
2188 ewhatflag &= (~EMI_NOREDRAW); 1386 ewhatflag &= ~EMI_NOREDRAW;
2189 esl.buf[ewhatstart + 1] = ewhatflag & 0xff; 1387 esl[ewhatstart + 1] = ewhatflag & 0xff;
2190 } 1388 }
2191 1389
2192 if (esl.len > estartlen) 1390 if (esl.length () > estartlen)
2193 Send_With_Handling (&socket, &esl); 1391 socket.send_packet (esl);
2194 } 1392 }
2195 1393
2196 if (sl.len > startlen || socket.sent_scroll) 1394 if (sl.length () > startlen || socket.sent_scroll)
2197 { 1395 {
2198 Send_With_Handling (&socket, &sl); 1396 socket.send_packet (sl);
2199 socket.sent_scroll = 0; 1397 socket.sent_scroll = 0;
2200 } 1398 }
2201} 1399}
2202 1400
2203/**
2204 * Draws client map.
2205 */
2206void
2207draw_client_map (object *pl)
2208{
2209 int i, j;
2210 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */
2211 New_Face *face, *floor;
2212 New_Face *floor2;
2213 int d, mflags;
2214 struct Map newmap;
2215 maptile *m, *pm;
2216
2217 if (pl->type != PLAYER)
2218 {
2219 LOG (llevError, "draw_client_map called with non player/non eric-server\n");
2220 return;
2221 }
2222
2223 pm = pl->map;
2224
2225 /* If player is just joining the game, he isn't here yet, so the map
2226 * can get swapped out. If so, don't try to send them a map. All will
2227 * be OK once they really log in.
2228 */
2229 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2230 return;
2231
2232 memset (&newmap, 0, sizeof (struct Map));
2233
2234 for (j = (pl->y - pl->contr->socket.mapy / 2); j < (pl->y + (pl->contr->socket.mapy + 1) / 2); j++)
2235 {
2236 for (i = (pl->x - pl->contr->socket.mapx / 2); i < (pl->x + (pl->contr->socket.mapx + 1) / 2); i++)
2237 {
2238 ax = i;
2239 ay = j;
2240 m = pm;
2241 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
2242 if (mflags & P_OUT_OF_MAP)
2243 continue;
2244 if (mflags & P_NEED_UPDATE)
2245 update_position (m, ax, ay);
2246 /* If a map is visible to the player, we don't want to swap it out
2247 * just to reload it. This should really call something like
2248 * swap_map, but this is much more efficient and 'good enough'
2249 */
2250 if (mflags & P_NEW_MAP)
2251 m->timeout = 50;
2252 }
2253 }
2254 /* do LOS after calls to update_position */
2255 if (pl->contr->do_los)
2256 {
2257 update_los (pl);
2258 pl->contr->do_los = 0;
2259 }
2260
2261 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd)
2262 {
2263 /* Big maps need a different drawing mechanism to work */
2264 draw_client_map1 (pl);
2265 return;
2266 }
2267
2268 if (pl->invisible & (pl->invisible < 50 ? 4 : 1))
2269 {
2270 esrv_map_setbelow (&pl->contr->socket, pl->contr->socket.mapx / 2, pl->contr->socket.mapy / 2, pl->face->number, &newmap);
2271 }
2272
2273 /* j and i are the y and x coordinates of the real map (which is
2274 * basically some number of spaces around the player)
2275 * ax and ay are values from within the viewport (ie, 0, 0 is upper
2276 * left corner) and are thus disconnected from the map values.
2277 * Subtract 1 from the max values so that we properly handle cases where
2278 * player has specified an even map. Otherwise, we try to send them too
2279 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually
2280 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is
2281 * odd, this still works fine.
2282 */
2283 ay = 0;
2284 for (j = pl->y - pl->contr->socket.mapy / 2; j <= pl->y + (pl->contr->socket.mapy - 1) / 2; j++, ay++)
2285 {
2286 ax = 0;
2287 for (i = pl->x - pl->contr->socket.mapx / 2; i <= pl->x + (pl->contr->socket.mapx - 1) / 2; i++, ax++)
2288 {
2289
2290 d = pl->contr->blocked_los[ax][ay];
2291 /* note the out_of_map and d>3 checks are both within the same
2292 * negation check.
2293 */
2294 nx = i;
2295 ny = j;
2296 m = get_map_from_coord (pm, &nx, &ny);
2297 if (m && d < 4)
2298 {
2299 face = GET_MAP_FACE (m, nx, ny, 0);
2300 floor2 = GET_MAP_FACE (m, nx, ny, 1);
2301 floor = GET_MAP_FACE (m, nx, ny, 2);
2302
2303 /* If all is blank, send a blank face. */
2304 if ((!face || face == blank_face) && (!floor2 || floor2 == blank_face) && (!floor || floor == blank_face))
2305 {
2306 esrv_map_setbelow (&pl->contr->socket, ax, ay, blank_face->number, &newmap);
2307 }
2308 else
2309 { /* actually have something interesting */
2310 /* send the darkness mask, if any. */
2311 if (d && pl->contr->socket.darkness)
2312 esrv_map_setbelow (&pl->contr->socket, ax, ay, dark_faces[d - 1]->number, &newmap);
2313
2314 if (face && face != blank_face)
2315 esrv_map_setbelow (&pl->contr->socket, ax, ay, face->number, &newmap);
2316 if (floor2 && floor2 != blank_face)
2317 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor2->number, &newmap);
2318 if (floor && floor != blank_face)
2319 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2320 }
2321 } /* Is a valid space */
2322 }
2323 }
2324
2325 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2326
2327 check_map_change (pl->contr);
2328}
2329
2330
2331/*****************************************************************************/ 1401/*****************************************************************************/
2332
2333/* GROS: The following one is used to allow a plugin to send a generic cmd to*/ 1402/* GROS: The following one is used to allow a plugin to send a generic cmd to*/
2334
2335/* a player. Of course, the client need to know the command to be able to */ 1403/* a player. Of course, the client need to know the command to be able to */
2336
2337/* manage it ! */ 1404/* manage it ! */
2338
2339/*****************************************************************************/ 1405/*****************************************************************************/
2340void 1406void
2341send_plugin_custom_message (object *pl, char *buf) 1407send_plugin_custom_message (object *pl, char *buf)
2342{ 1408{
2343 pl->contr->socket.send_packet (buf); 1409 pl->contr->ns->send_packet (buf);
2344} 1410}
2345 1411
2346/** 1412/**
2347 * This sends the skill number to name mapping. We ignore 1413 * This sends the skill number to name mapping. We ignore
2348 * the params - we always send the same info no matter what. 1414 * the params - we always send the same info no matter what.
2349 */ 1415 */
2350void 1416void
2351send_skill_info (NewSocket *ns, char *params) 1417send_skill_info (client *ns, char *params)
2352{ 1418{
2353 packet sl; 1419 packet sl;
2354 sl << "replyinfo skill_info\n"; 1420 sl << "replyinfo skill_info\n";
2355 1421
2356 for (int i = 1; i < NUM_SKILLS; i++) 1422 for (int i = 1; i < NUM_SKILLS; i++)
2357 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1423 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2358 1424
2359 if (sl.len >= MAXSOCKBUF) 1425 if (sl.length () > MAXSOCKBUF)
2360 { 1426 {
2361 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1427 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2362 fatal (0); 1428 fatal (0);
2363 } 1429 }
2364 1430
2365 Send_With_Handling (ns, &sl); 1431 ns->send_packet (sl);
2366} 1432}
2367 1433
2368/** 1434/**
2369 * This sends the spell path to name mapping. We ignore 1435 * This sends the spell path to name mapping. We ignore
2370 * the params - we always send the same info no matter what. 1436 * the params - we always send the same info no matter what.
2371 */ 1437 */
2372void 1438void
2373send_spell_paths (NewSocket * ns, char *params) 1439send_spell_paths (client * ns, char *params)
2374{ 1440{
2375 packet sl; 1441 packet sl;
2376 1442
2377 sl << "replyinfo spell_paths\n"; 1443 sl << "replyinfo spell_paths\n";
2378 1444
2379 for (int i = 0; i < NRSPELLPATHS; i++) 1445 for (int i = 0; i < NRSPELLPATHS; i++)
2380 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1446 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2381 1447
2382 if (sl.len >= MAXSOCKBUF) 1448 if (sl.length () > MAXSOCKBUF)
2383 { 1449 {
2384 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1450 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2385 fatal (0); 1451 fatal (0);
2386 } 1452 }
2387 1453
2388 Send_With_Handling (ns, &sl); 1454 ns->send_packet (sl);
2389} 1455}
2390 1456
2391/** 1457/**
2392 * This looks for any spells the player may have that have changed their stats. 1458 * This looks for any spells the player may have that have changed their stats.
2393 * it then sends an updspell packet for each spell that has changed in this way 1459 * it then sends an updspell packet for each spell that has changed in this way
2394 */ 1460 */
2395void 1461void
2396esrv_update_spells (player *pl) 1462esrv_update_spells (player *pl)
2397{ 1463{
1464 if (!pl->ns)
1465 return;
1466
2398 if (!pl->socket.monitor_spells) 1467 if (!pl->ns->monitor_spells)
2399 return; 1468 return;
2400 1469
2401 for (object *spell = pl->ob->inv; spell; spell = spell->below) 1470 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2402 { 1471 {
2403 if (spell->type == SPELL) 1472 if (spell->type == SPELL)
… …
2433 1502
2434 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1503 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2435 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1504 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2436 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1505 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2437 1506
2438 Send_With_Handling (&pl->socket, &sl); 1507 pl->ns->send_packet (sl);
2439 } 1508 }
2440 } 1509 }
2441 } 1510 }
2442} 1511}
2443 1512
2444void 1513void
2445esrv_remove_spell (player *pl, object *spell) 1514esrv_remove_spell (player *pl, object *spell)
2446{ 1515{
2447 if (!pl->socket.monitor_spells) 1516 if (!pl->ns->monitor_spells)
2448 return; 1517 return;
2449 1518
2450 if (!pl || !spell || spell->env != pl->ob) 1519 if (!pl || !spell || spell->env != pl->ob)
2451 { 1520 {
2452 LOG (llevError, "Invalid call to esrv_remove_spell"); 1521 LOG (llevError, "Invalid call to esrv_remove_spell");
2453 return; 1522 return;
2454 } 1523 }
2455 1524
2456 packet sl; 1525 packet sl ("delspell");
2457 1526
2458 sl << "delspell "
2459 << uint32 (spell->count); 1527 sl << uint32 (spell->count);
2460 1528
2461 Send_With_Handling (&pl->socket, &sl); 1529 pl->ns->send_packet (sl);
2462} 1530}
2463 1531
2464/* appends the spell *spell to the Socklist we will send the data to. */ 1532/* appends the spell *spell to the Socklist we will send the data to. */
2465static void 1533static void
2466append_spell (player *pl, packet &sl, object *spell) 1534append_spell (player *pl, packet &sl, object *spell)
2467{ 1535{
2468 int len, i, skill = 0; 1536 int i, skill = 0;
2469 1537
2470 if (!(spell->name)) 1538 if (!(spell->name))
2471 { 1539 {
2472 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1540 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2473 return; 1541 return;
… …
2486 { 1554 {
2487 skill = i + CS_STAT_SKILLINFO; 1555 skill = i + CS_STAT_SKILLINFO;
2488 break; 1556 break;
2489 } 1557 }
2490 } 1558 }
1559
1560 // spells better have a face
1561 if (!spell->face)
1562 {
1563 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1564 spell->face = face_find ("burnout.x11", blank_face);
1565 }
1566
1567 pl->ns->send_face (spell->face);
2491 1568
2492 /* send the current values */ 1569 /* send the current values */
2493 sl << uint32 (spell->count) 1570 sl << uint32 (spell->count)
2494 << uint16 (spell->level) 1571 << uint16 (spell->level)
2495 << uint16 (spell->casting_time) 1572 << uint16 (spell->casting_time)
2496 << uint16 (spell->last_sp) 1573 << uint16 (spell->last_sp)
2497 << uint16 (spell->last_grace) 1574 << uint16 (spell->last_grace)
2498 << uint16 (spell->last_eat) 1575 << uint16 (spell->last_eat)
2499 << uint8 (skill) 1576 << uint8 (skill)
2500 << uint32 (spell->path_attuned) 1577 << uint32 (spell->path_attuned)
2501 << uint32 (spell->face ? spell->face->number : 0) 1578 << uint32 (spell->face)
2502 << data8 (spell->name) 1579 << data8 (spell->name)
2503 << data16 (spell->msg); 1580 << data16 (spell->msg);
2504} 1581}
2505 1582
2506/** 1583/**
… …
2514 { 1591 {
2515 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 1592 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2516 return; 1593 return;
2517 } 1594 }
2518 1595
2519 if (!pl->socket.monitor_spells) 1596 if (!pl->ns->monitor_spells)
2520 return; 1597 return;
2521 1598
2522 packet sl; 1599 packet sl ("addspell");
2523
2524 sl << "addspell ";
2525 1600
2526 if (!spell) 1601 if (!spell)
2527 { 1602 {
2528 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 1603 for (spell = pl->ob->inv; spell; spell = spell->below)
2529 { 1604 {
2530 /* were we to simply keep appending data here, we could exceed 1605 /* were we to simply keep appending data here, we could exceed
2531 * MAXSOCKBUF if the player has enough spells to add, we know that 1606 * MAXSOCKBUF if the player has enough spells to add, we know that
2532 * append_spells will always append 19 data bytes, plus 4 length 1607 * append_spells will always append 19 data bytes, plus 4 length
2533 * bytes and 3 strings (because that is the spec) so we need to 1608 * bytes and 3 strings (because that is the spec) so we need to
2534 * check that the length of those 3 strings, plus the 23 bytes, 1609 * check that the length of those 3 strings, plus the 23 bytes,
2535 * won't take us over the length limit for the socket, if it does, 1610 * won't take us over the length limit for the socket, if it does,
2536 * we need to send what we already have, and restart packet formation 1611 * we need to send what we already have, and restart packet formation
2537 */ 1612 */
1613 if (spell->type != SPELL)
1614 continue;
1615
2538 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1616 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
2539 * to show add_spell is 26 bytes + 2 strings. However, the overun 1617 * to show add_spell is 26 bytes + 2 strings. However, the overun
2540 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1618 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2541 * like it will fix this 1619 * like it will fix this
2542 */ 1620 */
2543 if (spell->type != SPELL)
2544 continue;
2545
2546 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1621 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2547 { 1622 {
2548 Send_With_Handling (&pl->socket, &sl); 1623 pl->ns->flush_fx ();
2549 strcpy ((char *) sl.buf, "addspell "); 1624 pl->ns->send_packet (sl);
2550 sl.len = strlen ((char *) sl.buf); 1625
1626 sl.reset ();
1627 sl << "addspell ";
2551 } 1628 }
2552 1629
2553 append_spell (pl, sl, spell); 1630 append_spell (pl, sl, spell);
2554 } 1631 }
2555 } 1632 }
… …
2559 return; 1636 return;
2560 } 1637 }
2561 else 1638 else
2562 append_spell (pl, sl, spell); 1639 append_spell (pl, sl, spell);
2563 1640
2564 if (sl.length () >= MAXSOCKBUF) 1641 if (sl.length () > MAXSOCKBUF)
2565 { 1642 {
2566 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1643 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2567 fatal (0); 1644 fatal (0);
2568 } 1645 }
2569 1646
2570 /* finally, we can send the packet */ 1647 /* finally, we can send the packet */
2571 Send_With_Handling (&pl->socket, &sl); 1648 pl->ns->flush_fx ();
2572 1649 pl->ns->send_packet (sl);
2573} 1650}
2574 1651

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines