ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.112 by root, Sun Jul 1 05:00:20 2007 UTC vs.
Revision 1.146 by root, Sat Dec 27 01:25:00 2008 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation, either version 3 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24/** 24/**
25 * \file 25 * \file
26 * Client handling. 26 * Client handling.
98 */ 98 */
99 mx = ns->mapx; 99 mx = ns->mapx;
100 my = ns->mapy; 100 my = ns->mapy;
101 101
102 /* the x and y here are coordinates for the new map, i.e. if we moved 102 /* the x and y here are coordinates for the new map, i.e. if we moved
103 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 103 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
104 * if the destination x or y coordinate is outside the viewable 104 * if the destination x or y coordinate is outside the viewable
105 * area, we clear the values - otherwise, the old values 105 * area, we clear the values - otherwise, the old values
106 * are preserved, and the check_head thinks it needs to clear them. 106 * are preserved, and the check_head thinks it needs to clear them.
107 */ 107 */
108 for (x = 0; x < mx; x++) 108 for (x = 0; x < mx; x++)
109 {
110 for (y = 0; y < my; y++) 109 for (y = 0; y < my; y++)
111 {
112 if (x >= ns->mapx || y >= ns->mapy) 110 if (x >= ns->mapx || y >= ns->mapy)
113 /* clear cells outside the viewable area */ 111 /* clear cells outside the viewable area */
114 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell)); 112 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
115 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy) 113 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
116 /* clear newly visible tiles within the viewable area */ 114 /* clear newly visible tiles within the viewable area */
117 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell)); 115 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
118 else 116 else
119 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell)); 117 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
120 }
121 }
122 118
123 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map)); 119 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
124 120
125 /* Make sure that the next "map1" command will be sent (even if it is 121 /* Make sure that the next "map1" command will be sent (even if it is
126 * empty). 122 * empty).
129} 125}
130 126
131static void 127static void
132clear_map (player *pl) 128clear_map (player *pl)
133{ 129{
130 pl->ns->mapinfo_queue_clear ();
131
134 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap)); 132 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
135 133
136 pl->ns->force_newmap = false; 134 pl->ns->force_newmap = false;
137 135
138 if (pl->ns->newmapcmd == 1) 136 if (pl->ns->newmapcmd == 1)
139 pl->ns->send_packet ("newmap"); 137 pl->ns->send_packet ("newmap");
140 138
141 pl->ns->floorbox_reset (); 139 pl->ns->floorbox_reset ();
140}
141
142static void
143send_map_info (player *pl)
144{
145 client &socket = *pl->ns;
146 object *ob = pl->observe;
147
148 if (socket.mapinfocmd)
149 {
150 if (ob->map && ob->map->path[0])
151 {
152 int flags = 0;
153
154 if (ob->map->tile_path[0]) flags |= 1;
155 if (ob->map->tile_path[1]) flags |= 2;
156 if (ob->map->tile_path[2]) flags |= 4;
157 if (ob->map->tile_path[3]) flags |= 8;
158
159 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
160 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
161 ob->map->width, ob->map->height, &ob->map->path);
162 }
163 else
164 socket.send_packet ("mapinfo current");
165 }
142} 166}
143 167
144/** check for map/region change and send new map data */ 168/** check for map/region change and send new map data */
145static void 169static void
146check_map_change (player *pl) 170check_map_change (player *pl)
147{ 171{
148 client &socket = *pl->ns; 172 client &socket = *pl->ns;
149 object *ob = pl->observe; 173 object *ob = pl->observe;
150 174
175 region *reg = ob->region ();
176 if (socket.current_region != reg)
177 {
178 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
179 socket.current_region = reg;
180 }
181
182 // first try to aovid a full newmap on tiled map scrolls
183 if (socket.current_map != ob->map && !socket.force_newmap)
184 {
185 rv_vector rv;
186
187 get_rangevector_from_mapcoord (socket.current_map, socket.current_x, socket.current_y, ob, &rv, 0);
188
189 // manhattan distance is very handy here
190 if (rv.distance < 8) // 8 works nicely for speed << 70 and buggy gcfclient
191 {
192 socket.current_map = ob->map;
193 socket.current_x = ob->x;
194 socket.current_y = ob->y;
195
196 socket_map_scroll (&socket, rv.distance_x, rv.distance_y);
197 socket.floorbox_reset ();
198 send_map_info (pl);
199 }
200 }
201
151 if (socket.current_map != ob->map || socket.force_newmap) 202 if (socket.current_map != ob->map || socket.force_newmap)
152 { 203 {
153 clear_map (pl); 204 clear_map (pl);
154 socket.current_map = ob->map; 205 socket.current_map = ob->map;
155 206 send_map_info (pl);
156 if (socket.mapinfocmd)
157 {
158 if (ob->map && ob->map->path[0])
159 {
160 int flags = 0;
161
162 if (ob->map->tile_path[0]) flags |= 1;
163 if (ob->map->tile_path[1]) flags |= 2;
164 if (ob->map->tile_path[2]) flags |= 4;
165 if (ob->map->tile_path[3]) flags |= 8;
166
167 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
168 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
169 ob->map->width, ob->map->height, &ob->map->path);
170 }
171 else
172 socket.send_packet ("mapinfo current");
173 }
174 } 207 }
175 else if (socket.current_x != ob->x || socket.current_y != ob->y) 208 else if (socket.current_x != ob->x || socket.current_y != ob->y)
176 { 209 {
177 int dx = ob->x - socket.current_x; 210 int dx = ob->x - socket.current_x;
178 int dy = ob->y - socket.current_y; 211 int dy = ob->y - socket.current_y;
179 212
180 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
181 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
182 else
183 {
184 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 213 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
185 socket.floorbox_reset (); 214 socket.floorbox_reset ();
186 }
187 } 215 }
188 216
189 socket.current_x = ob->x; 217 socket.current_x = ob->x;
190 socket.current_y = ob->y; 218 socket.current_y = ob->y;
191
192 region *reg = ob->region ();
193 if (socket.current_region != reg)
194 {
195 socket.current_region = reg;
196 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
197 }
198} 219}
199 220
200/** 221/**
201 * RequestInfo is sort of a meta command. There is some specific 222 * RequestInfo is sort of a meta command. There is some specific
202 * request of information, but we call other functions to provide 223 * request of information, but we call other functions to provide
203 * that information. 224 * that information.
204 */ 225 */
205void 226void
206RequestInfo (char *buf, int len, client * ns) 227RequestInfo (char *buf, int len, client *ns)
207{ 228{
208 char *params = NULL, *cp; 229 char *params;
209
210 /* No match */
211 char bigbuf[MAX_BUF];
212 int slen;
213
214 /* Set up replyinfo before we modify any of the buffers - this is used
215 * if we don't find a match.
216 */
217 strcpy (bigbuf, "replyinfo ");
218 slen = strlen (bigbuf);
219 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
220 230
221 /* find the first space, make it null, and update the 231 /* find the first space, make it null, and update the
222 * params pointer. 232 * params pointer.
223 */ 233 */
224 for (cp = buf; *cp != '\0'; cp++) 234 for (params = buf; *params; params++)
225 if (*cp == ' ') 235 if (*params == ' ')
226 { 236 {
227 *cp = '\0';
228 params = cp + 1; 237 *params++ = 0;
229 break; 238 break;
230 } 239 }
231 240
232 if (!strcmp (buf, "image_info")) 241 if (!strcmp (buf, "image_info"))
233 send_image_info (ns, params); 242 send_image_info (ns, params);
236 else if (!strcmp (buf, "skill_info")) 245 else if (!strcmp (buf, "skill_info"))
237 send_skill_info (ns, params); 246 send_skill_info (ns, params);
238 else if (!strcmp (buf, "spell_paths")) 247 else if (!strcmp (buf, "spell_paths"))
239 send_spell_paths (ns, params); 248 send_spell_paths (ns, params);
240 else 249 else
241 ns->send_packet (bigbuf, len); 250 {
251 // undo tokenisation above and send replyinfo with the request unchanged
252 if (*params)
253 *--params = ' ';
254
255 ns->send_packet_printf ("replyinfo %s", buf);
256 }
242} 257}
243 258
244void 259void
245ExtCmd (char *buf, int len, player *pl) 260ExtCmd (char *buf, int len, player *pl)
246{ 261{
249 264
250void 265void
251ExtiCmd (char *buf, int len, client *ns) 266ExtiCmd (char *buf, int len, client *ns)
252{ 267{
253 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len)); 268 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
269}
270
271void
272client::mapinfo_queue_clear ()
273{
274 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
275 free (*i);
276
277 mapinfo_queue.clear ();
278}
279
280bool
281client::mapinfo_try (char *buf)
282{
283 char *token = buf;
284 buf += strlen (buf) + 9;
285
286 // initial map and its origin
287 maptile *map = pl->observe->map;
288 int mapx = pl->ns->mapx / 2 - pl->observe->x;
289 int mapy = pl->ns->mapy / 2 - pl->observe->y;
290 int max_distance = 8; // limit maximum path length to something generous
291
292 while (*buf && map && max_distance)
293 {
294 int dir = *buf++ - '1';
295
296 if (dir >= 0 && dir <= 3)
297 {
298 if (!map->tile_path [dir])
299 map = 0;
300 else if (map->tile_available (dir, false))
301 {
302 maptile *neigh = map->tile_map [dir];
303
304 switch (dir)
305 {
306 case 0: mapy -= neigh->height; break;
307 case 2: mapy += map ->height; break;
308 case 3: mapx -= neigh->width ; break;
309 case 1: mapx += map ->width ; break;
310 }
311
312 map = neigh;
313 --max_distance;
314 }
315 else
316 return 0;
317 }
318 else
319 max_distance = 0;
320 }
321
322 if (!max_distance)
323 send_packet_printf ("mapinfo %s error", token);
324 else if (!map || !map->path)
325 send_packet_printf ("mapinfo %s nomap", token);
326 else
327 {
328 int flags = 0;
329
330 if (map->tile_path[0]) flags |= 1;
331 if (map->tile_path[1]) flags |= 2;
332 if (map->tile_path[2]) flags |= 4;
333 if (map->tile_path[3]) flags |= 8;
334
335 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
336 }
337
338 return 1;
339}
340
341void
342client::mapinfo_queue_run ()
343{
344 if (mapinfo_queue.empty () || !pl)
345 return;
346
347 for (int i = 0; i < mapinfo_queue.size (); ++i)
348 if (mapinfo_try (mapinfo_queue [i]))
349 {
350 free (mapinfo_queue [i]);
351 mapinfo_queue.erase (i);
352 }
353 else
354 ++i;
254} 355}
255 356
256void 357void
257MapInfoCmd (char *buf, int len, player *pl) 358MapInfoCmd (char *buf, int len, player *pl)
258{ 359{
259 // <mapinfo tag spatial tile-path 360 // <mapinfo tag spatial tile-path
260 // >mapinfo tag spatial flags x y w h hash 361 // >mapinfo tag spatial flags x y w h hash
261 362
262 char bigbuf[MAX_BUF], *token;
263
264 token = buf; 363 char *token = buf;
265 // copy token 364
266 if (!(buf = strchr (buf, ' '))) 365 if (!(buf = strchr (buf, ' ')))
267 return; 366 return;
268 367
269 *buf++ = 0;
270
271 if (!strncmp (buf, "spatial ", 8)) 368 if (!strncmp (buf, " spatial ", 9))
272 { 369 {
273 buf += 8; 370 char *copy = strdup (token);
371 copy [buf - token] = 0;
274 372
275 // initial map and its origin 373#if 0
276 maptile *map = pl->ob->map; 374 // this makes only sense when we flush the buffer immediately
277 sint16 dx, dy; 375 if (pl->ns->mapinfo_try (copy))
278 int mapx = pl->ns->mapx / 2 - pl->ob->x; 376 free (copy);
279 int mapy = pl->ns->mapy / 2 - pl->ob->y;
280 int max_distance = 8; // limit maximum path length to something generous
281
282 while (*buf && map && max_distance)
283 {
284 int dir = *buf++;
285
286 switch (dir)
287 {
288 case '1':
289 dx = 0;
290 dy = -1;
291 map = map->xy_find (dx, dy);
292 map && (mapy -= map->height);
293 break;
294 case '2':
295 mapx += map->width;
296 dx = map->width;
297 dy = 0;
298 map = map->xy_find (dx, dy);
299 break;
300 case '3':
301 mapy += map->height;
302 dx = 0;
303 dy = map->height;
304 map = map->xy_find (dx, dy);
305 break;
306 case '4':
307 dx = -1;
308 dy = 0;
309 map = map->xy_find (dx, dy);
310 map && (mapx -= map->width);
311 break;
312 }
313
314 --max_distance;
315 }
316
317 if (!max_distance)
318 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
319 else if (map && map->path[0])
320 {
321 int flags = 0;
322
323 if (map->tile_path[0]) flags |= 1;
324 if (map->tile_path[1]) flags |= 2;
325 if (map->tile_path[2]) flags |= 4;
326 if (map->tile_path[3]) flags |= 8;
327
328 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
329 }
330 else 377 else
331 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 378#endif
379 pl->ns->mapinfo_queue.push_back (copy);
332 } 380 }
333 else 381 else
334 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 382 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
335
336 pl->ns->send_packet (bigbuf);
337} 383}
338 384
339/** This is the Setup cmd */ 385/** This is the Setup cmd */
340void 386void
341SetUp (char *buf, int len, client * ns) 387SetUp (char *buf, int len, client * ns)
351 */ 397 */
352void 398void
353AddMeCmd (char *buf, int len, client *ns) 399AddMeCmd (char *buf, int len, client *ns)
354{ 400{
355 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len)); 401 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
356}
357
358/** Reply to ExtendedInfos command */
359void
360ToggleExtendedInfos (char *buf, int len, client * ns)
361{
362 char cmdback[MAX_BUF];
363 char command[50];
364 int info, nextinfo;
365
366 cmdback[0] = '\0';
367 nextinfo = 0;
368
369 while (1)
370 {
371 /* 1. Extract an info */
372 info = nextinfo;
373
374 while ((info < len) && (buf[info] == ' '))
375 info++;
376
377 if (info >= len)
378 break;
379
380 nextinfo = info + 1;
381
382 while ((nextinfo < len) && (buf[nextinfo] != ' '))
383 nextinfo++;
384
385 if (nextinfo - info >= 49) /*Erroneous info asked */
386 continue;
387
388 strncpy (command, &(buf[info]), nextinfo - info);
389
390 /* 2. Interpret info */
391 if (!strcmp ("smooth", command))
392 /* Toggle smoothing */
393 ns->EMI_smooth = !ns->EMI_smooth;
394 else
395 /*bad value */;
396
397 /*3. Next info */
398 }
399
400 strcpy (cmdback, "ExtendedInfoSet");
401
402 if (ns->EMI_smooth)
403 {
404 strcat (cmdback, " ");
405 strcat (cmdback, "smoothing");
406 }
407
408 ns->send_packet (cmdback);
409} 402}
410 403
411/* 404/*
412#define MSG_TYPE_BOOK 1 405#define MSG_TYPE_BOOK 1
413#define MSG_TYPE_CARD 2 406#define MSG_TYPE_CARD 2
511void 504void
512NewPlayerCmd (char *buf, int len, player *pl) 505NewPlayerCmd (char *buf, int len, player *pl)
513{ 506{
514 if (len <= 6) 507 if (len <= 6)
515 { 508 {
516 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 509 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
517 return; 510 return;
518 } 511 }
519 512
520 uint16 cmdid = net_uint16 ((uint8 *)buf); 513 uint16 cmdid = net_uint16 ((uint8 *)buf);
521 sint32 repeat = net_sint32 ((uint8 *)buf + 2); 514 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
659 * syntax is: move (to) (tag) (nrof) 652 * syntax is: move (to) (tag) (nrof)
660 */ 653 */
661void 654void
662MoveCmd (char *buf, int len, player *pl) 655MoveCmd (char *buf, int len, player *pl)
663{ 656{
664 int vals[3], i; 657 int to, tag, nrof;
665 658
666 /* A little funky here. We only cycle for 2 records, because 659 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
667 * we obviously are not going to find a space after the third
668 * record. Perhaps we should just replace this with a
669 * sscanf?
670 */
671 for (i = 0; i < 2; i++)
672 { 660 {
673 vals[i] = atoi (buf);
674
675 if (!(buf = strchr (buf, ' ')))
676 {
677 LOG (llevError, "Incomplete move command: %s\n", buf); 661 LOG (llevError, "Incomplete move command: %s\n", buf);
678 return; 662 return;
679 }
680
681 buf++;
682 } 663 }
683 664
684 vals[2] = atoi (buf); 665 esrv_move_object (pl->ob, to, tag, nrof);
685
686/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
687 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
688} 666}
689 667
690/****************************************************************************** 668/******************************************************************************
691 * 669 *
692 * Start of commands the server sends to the client. 670 * Start of commands the server sends to the client.
793 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS); 771 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
794 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW); 772 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
795 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA); 773 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
796 774
797 for (int s = 0; s < NUM_SKILLS; s++) 775 for (int s = 0; s < NUM_SKILLS; s++)
798 if (object *skill = opl->last_skill_ob[s]) 776 if (object *skill = opl->last_skill_ob [s])
799 if (skill->stats.exp != ns->last_skill_exp [s]) 777 if (skill->stats.exp != ns->last_skill_exp [s])
800 { 778 {
801 ns->last_skill_exp [s] = skill->stats.exp; 779 ns->last_skill_exp [s] = skill->stats.exp;
802 780
803 /* Always send along the level if exp changes. This is only 781 /* Always send along the level if exp changes. This is only
859 837
860/** 838/**
861 * Tells the client that here is a player it should start using. 839 * Tells the client that here is a player it should start using.
862 */ 840 */
863void 841void
864esrv_new_player (player *pl, uint32 weight) 842esrv_new_player (player *pl)
865{ 843{
844 sint32 weight = pl->ob->client_weight ();
845
866 packet sl ("player"); 846 packet sl ("player");
867 847
868 sl << uint32 (pl->ob->count) 848 sl << uint32 (pl->ob->count)
869 << uint32 (weight) 849 << uint32 (weight)
870 << uint32 (pl->ob->face) 850 << uint32 (pl->ob->face)
871 << data8 (pl->ob->name); 851 << data8 (pl->ob->name);
872 852
873 pl->ns->last_weight = weight; 853 pl->ns->last_weight = weight;
874 pl->ns->send_packet (sl); 854 pl->ns->send_packet (sl);
875 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
876} 855}
877 856
878/****************************************************************************** 857/******************************************************************************
879 * 858 *
880 * Start of map related commands. 859 * Start of map related commands.
937 916
938 if (!ns.faces_sent[face_num]) 917 if (!ns.faces_sent[face_num])
939 if (ob) 918 if (ob)
940 ns.send_faces (ob); 919 ns.send_faces (ob);
941 else 920 else
942 ns.send_face (face_num); 921 ns.send_face (face_num, 10);
943 922
944 sl << uint16 (face_num); 923 sl << uint16 (face_num);
945 return 1; 924 return 1;
946 } 925 }
947 926
948 /* Nothing changed */ 927 /* Nothing changed */
949 return 0; 928 return 0;
950}
951
952/**
953 * Returns the size of a data for a map square as returned by
954 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
955 * available.
956 */
957int
958getExtendedMapInfoSize (client * ns)
959{
960 int result = 0;
961
962 if (ns->ext_mapinfos)
963 {
964 if (ns->EMI_smooth)
965 result += 1; /*One byte for smoothlevel */
966 }
967
968 return result;
969} 929}
970 930
971// prefetch (and touch) all maps within a specific distancd 931// prefetch (and touch) all maps within a specific distancd
972static void 932static void
973prefetch_surrounding_maps (maptile *map, int distance) 933prefetch_surrounding_maps (maptile *map, int distance)
998{ 958{
999 object *ob = pl->observe; 959 object *ob = pl->observe;
1000 if (!ob->active) 960 if (!ob->active)
1001 return; 961 return;
1002 962
1003 maptile *plmap = ob->map;
1004
1005 /* If player is just joining the game, he isn't here yet, so the map 963 /* If player is just joining the game, he isn't here yet, so the map
1006 * can get swapped out. If so, don't try to send them a map. All will 964 * can get swapped out. If so, don't try to send them a map. All will
1007 * be OK once they really log in. 965 * be OK once they really log in.
1008 */ 966 */
1009 if (!plmap || plmap->in_memory != MAP_IN_MEMORY) 967 if (!ob->map || ob->map->in_memory != MAP_ACTIVE)
1010 return; 968 return;
1011 969
1012 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1013 int estartlen, eoldlen; 970 int startlen, oldlen;
1014 uint8 eentrysize;
1015 uint16 ewhatstart, ewhatflag;
1016 uint8 extendedinfos;
1017 971
1018 check_map_change (pl); 972 check_map_change (pl);
1019 prefetch_surrounding_maps (pl->ob); 973 prefetch_surrounding_maps (pl->ob);
1020 974
1021 /* do LOS after calls to update_position */ 975 /* do LOS after calls to update_position */
1022 if (ob != pl->ob) 976 /* unfortunately, we need to udpate los when observing, currently */
1023 clear_los (pl); 977 if (pl->do_los || pl->observe != pl->ob)
1024 else if (pl->do_los)
1025 { 978 {
1026 update_los (ob);
1027 pl->do_los = 0; 979 pl->do_los = 0;
980 pl->update_los ();
1028 } 981 }
1029 982
1030 /** 983 /**
1031 * This function uses the new map1 protocol command to send the map 984 * This function uses the new map1 protocol command to send the map
1032 * to the client. It is necessary because the old map command supports 985 * to the client. It is necessary because the old map command supports
1051 */ 1004 */
1052 1005
1053 client &socket = *pl->ns; 1006 client &socket = *pl->ns;
1054 1007
1055 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a"); 1008 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1056 packet esl;
1057 1009
1058 startlen = sl.length (); 1010 startlen = sl.length ();
1059 1011
1060 /*Extendedmapinfo structure initialisation */ 1012 int hx = socket.mapx / 2;
1061 if (socket.ext_mapinfos) 1013 int hy = socket.mapy / 2;
1062 {
1063 extendedinfos = EMI_NOREDRAW;
1064 1014
1065 if (socket.EMI_smooth) 1015 ordered_mapwalk_begin (ob, -hx, -hy, hx, hy)
1066 extendedinfos |= EMI_SMOOTH; 1016 int ax = dx + hx;
1017 int ay = dy + hy;
1067 1018
1068 ewhatstart = esl.length (); 1019 int mask = (ax << 10) | (ay << 4);
1069 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1070 could need to be taken away */
1071 eentrysize = getExtendedMapInfoSize (&socket);
1072 esl << "mapextended "
1073 << uint8 (extendedinfos)
1074 << uint8 (eentrysize);
1075
1076 estartlen = esl.length ();
1077 }
1078
1079 /* x,y are the real map locations. ax, ay are viewport relative
1080 * locations.
1081 */
1082 ay = 0;
1083
1084 /* We could do this logic as conditionals in the if statement,
1085 * but that started to get a bit messy to look at.
1086 */
1087 max_x = ob->x + (socket.mapx + 1) / 2;
1088 max_y = ob->y + (socket.mapy + 1) / 2;
1089
1090 for (y = ob->y - socket.mapy / 2; y < max_y; y++, ay++)
1091 {
1092 sint16 nx, ny;
1093 maptile *m = 0;
1094
1095 ax = 0;
1096 for (x = ob->x - socket.mapx / 2; x < max_x; x++, ax++)
1097 {
1098 // check to see if we can simply go one right quickly
1099 ++nx;
1100 if (m && nx >= m->width)
1101 m = 0;
1102
1103 if (!m)
1104 {
1105 nx = x; ny = y; m = plmap;
1106
1107 if (!xy_normalise (m, nx, ny))
1108 m = 0;
1109 }
1110
1111 int emask, mask;
1112 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1113
1114 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1020 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1115 1021
1116 /* If the coordinates are not valid, or it is too dark to see, 1022 /* If the coordinates are not valid, or it is too dark to see,
1117 * we tell the client as such 1023 * we tell the client as such
1118 */ 1024 */
1119 if (!m) 1025 if (!m)
1120 { 1026 {
1121 /* space is out of map. Update space and clear values 1027 /* space is out of map. Update space and clear values
1122 * if this hasn't already been done. If the space is out 1028 * if this hasn't already been done. If the space is out
1123 * of the map, it shouldn't have a head 1029 * of the map, it shouldn't have a head.
1124 */ 1030 */
1125 if (lastcell.count != -1) 1031 if (lastcell.count != -1)
1032 {
1033 sl << uint16 (mask);
1034 map_clearcell (&lastcell, -1);
1035 }
1036
1037 continue;
1038 }
1039
1040 int d = pl->blocked_los_uc (dx, dy);
1041
1042 if (d > 3)
1043 {
1044 /* This block deals with spaces that are not visible for whatever
1045 * reason. Still may need to send the head for this space.
1046 */
1047 if (lastcell.count != -1
1048 || lastcell.faces[0]
1049 || lastcell.faces[1]
1050 || lastcell.faces[2]
1051 || lastcell.stat_hp
1052 || lastcell.flags
1053 || lastcell.player)
1054 sl << uint16 (mask);
1055
1056 /* properly clear a previously sent big face */
1057 map_clearcell (&lastcell, -1);
1058 }
1059 else
1060 {
1061 /* In this block, the space is visible.
1062 */
1063
1064 /* Rather than try to figure out what everything that we might
1065 * need to send is, then form the packet after that,
1066 * we presume that we will in fact form a packet, and update
1067 * the bits by what we do actually send. If we send nothing,
1068 * we just back out sl.length () to the old value, and no harm
1069 * is done.
1070 * I think this is simpler than doing a bunch of checks to see
1071 * what if anything we need to send, setting the bits, then
1072 * doing those checks again to add the real data.
1073 */
1074 oldlen = sl.length ();
1075
1076 sl << uint16 (mask);
1077
1078 unsigned char dummy;
1079 unsigned char *last_ext = &dummy;
1080
1081 /* Darkness changed */
1082 if (lastcell.count != d)
1083 {
1084 mask |= 0x8;
1085
1086 if (socket.extmap)
1087 {
1088 *last_ext |= 0x80;
1089 last_ext = &sl[sl.length ()];
1090 sl << uint8 (d);
1091 }
1092 else
1093 sl << uint8 (255 - 64 * d);
1094 }
1095
1096 lastcell.count = d;
1097
1098 mapspace &ms = m->at (nx, ny);
1099 ms.update ();
1100
1101 if (expect_true (socket.extmap))
1102 {
1103 uint8 stat_hp = 0;
1104 uint8 stat_width = 0;
1105 uint8 flags = 0;
1106 tag_t player = 0;
1107
1108 // send hp information, if applicable
1109 if (object *op = ms.faces_obj [0])
1110 if (op->is_head () && !op->invisible)
1126 { 1111 {
1127 sl << uint16 (mask); 1112 if (op->stats.maxhp > op->stats.hp
1128 map_clearcell (&lastcell, -1); 1113 && op->stats.maxhp > 0
1114 && (op->type == PLAYER
1115 || op->type == DOOR // does not work, have maxhp 0
1116 || QUERY_FLAG (op, FLAG_MONSTER)
1117 || QUERY_FLAG (op, FLAG_ALIVE)
1118 || QUERY_FLAG (op, FLAG_GENERATOR)))
1119 {
1120 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1121 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1122 }
1123
1124 if (expect_false (op->has_dialogue ()))
1125 flags |= 1;
1126
1127 if (expect_false (op->type == PLAYER))
1128 player = op == ob ? pl->ob->count
1129 : op == pl->ob ? ob->count
1130 : op->count;
1129 } 1131 }
1130 1132
1131 continue; 1133 if (expect_false (lastcell.stat_hp != stat_hp))
1132 }
1133
1134 m->touch ();
1135
1136 int d = pl->blocked_los[ax][ay];
1137
1138 if (d > 3)
1139 {
1140
1141 int need_send = 0, count;
1142
1143 /* This block deals with spaces that are not visible for whatever
1144 * reason. Still may need to send the head for this space.
1145 */
1146
1147 oldlen = sl.length ();
1148
1149 sl << uint16 (mask);
1150
1151 if (lastcell.count != -1)
1152 need_send = 1;
1153
1154 count = -1;
1155
1156 /* properly clear a previously sent big face */
1157 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1158 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1159 need_send = 1;
1160
1161 map_clearcell (&lastcell, count);
1162
1163 if ((mask & 0xf) || need_send)
1164 sl[oldlen + 1] = mask & 0xff;
1165 else
1166 sl.reset (oldlen);
1167 }
1168 else
1169 {
1170 /* In this block, the space is visible.
1171 */
1172
1173 /* Rather than try to figure out what everything that we might
1174 * need to send is, then form the packet after that,
1175 * we presume that we will in fact form a packet, and update
1176 * the bits by what we do actually send. If we send nothing,
1177 * we just back out sl.length () to the old value, and no harm
1178 * is done.
1179 * I think this is simpler than doing a bunch of checks to see
1180 * what if anything we need to send, setting the bits, then
1181 * doing those checks again to add the real data.
1182 */
1183 oldlen = sl.length ();
1184 eoldlen = esl.length ();
1185
1186 sl << uint16 (mask);
1187
1188 unsigned char dummy;
1189 unsigned char *last_ext = &dummy;
1190
1191 /* Darkness changed */
1192 if (lastcell.count != d && socket.darkness)
1193 { 1134 {
1135 lastcell.stat_hp = stat_hp;
1136
1194 mask |= 0x8; 1137 mask |= 0x8;
1138 *last_ext |= 0x80;
1139 last_ext = &sl[sl.length ()];
1195 1140
1196 if (socket.extmap) 1141 sl << uint8 (5) << uint8 (stat_hp);
1142
1143 if (stat_width > 1)
1197 { 1144 {
1198 *last_ext |= 0x80; 1145 *last_ext |= 0x80;
1199 last_ext = &sl[sl.length ()]; 1146 last_ext = &sl[sl.length ()];
1200 sl << uint8 (d);
1201 }
1202 else
1203 sl << uint8 (255 - 64 * d);
1204 }
1205 1147
1206 lastcell.count = d;
1207
1208 mapspace &ms = m->at (nx, ny);
1209 ms.update ();
1210
1211 if (socket.extmap)
1212 {
1213 uint8 stat_hp = 0;
1214 uint8 stat_width = 0;
1215 uint8 flags = 0;
1216 tag_t player = 0;
1217
1218 // send hp information, if applicable
1219 if (object *op = ms.faces_obj [0])
1220 {
1221 if (op->head || op->invisible)
1222 ; // do not show
1223 else if (op->type == PLAYER
1224 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
1225 {
1226 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
1227 {
1228 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1229 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1230 }
1231 }
1232
1233 if (op->msg && op->msg[0] == '@')
1234 flags |= 1;
1235
1236 if (op->type == PLAYER && op != ob)
1237 player = op->count;
1238 }
1239
1240 if (lastcell.stat_hp != stat_hp)
1241 {
1242 lastcell.stat_hp = stat_hp;
1243
1244 mask |= 0x8;
1245 *last_ext |= 0x80;
1246 last_ext = &sl[sl.length ()];
1247
1248 sl << uint8 (5) << uint8 (stat_hp);
1249
1250 if (stat_width > 1)
1251 {
1252 *last_ext |= 0x80;
1253 last_ext = &sl[sl.length ()];
1254
1255 sl << uint8 (6) << uint8 (stat_width); 1148 sl << uint8 (6) << uint8 (stat_width);
1256 }
1257 } 1149 }
1258
1259 if (lastcell.player != player)
1260 {
1261 lastcell.player = player;
1262
1263 mask |= 0x8;
1264 *last_ext |= 0x80;
1265 last_ext = &sl[sl.length ()];
1266
1267 sl << uint8 (0x47) << uint8 (4) << (uint32)player;
1268 }
1269
1270 if (lastcell.flags != flags)
1271 {
1272 lastcell.flags = flags;
1273
1274 mask |= 0x8;
1275 *last_ext |= 0x80;
1276 last_ext = &sl[sl.length ()];
1277
1278 sl << uint8 (8) << uint8 (flags);
1279 }
1280 } 1150 }
1281 1151
1282 /* Floor face */ 1152 if (expect_false (lastcell.player != player))
1283 if (update_space (sl, socket, ms, lastcell, 2)) 1153 {
1154 lastcell.player = player;
1155
1284 mask |= 0x4; 1156 mask |= 0x8;
1157 *last_ext |= 0x80;
1158 last_ext = &sl[sl.length ()];
1285 1159
1286 /* Middle face */ 1160 sl << uint8 (0x47) << uint8 (4) << (uint32)player;
1287 if (update_space (sl, socket, ms, lastcell, 1)) 1161 }
1162
1163 if (expect_false (lastcell.flags != flags))
1164 {
1165 lastcell.flags = flags;
1166
1288 mask |= 0x2; 1167 mask |= 0x8;
1168 *last_ext |= 0x80;
1169 last_ext = &sl[sl.length ()];
1289 1170
1290 if (ms.player () == ob 1171 sl << uint8 (8) << uint8 (flags);
1291 && (ob->invisible & (ob->invisible < 50 ? 1 : 7)))
1292 { 1172 }
1173 }
1174
1175 /* Floor face */
1176 if (update_space (sl, socket, ms, lastcell, 2))
1177 mask |= 0x4;
1178
1179 /* Middle face */
1180 if (update_space (sl, socket, ms, lastcell, 1))
1181 mask |= 0x2;
1182
1183 if (expect_false (ob->invisible)
1184 && ob->invisible & (ob->invisible < 50 ? 1 : 7)
1185 && ms.player () == ob)
1186 {
1293 // force player to be visible to himself if invisible 1187 // force player to be visible to himself if invisible
1294 if (lastcell.faces[0] != ob->face) 1188 if (lastcell.faces[0] != ob->face)
1295 { 1189 {
1296 lastcell.faces[0] = ob->face; 1190 lastcell.faces[0] = ob->face;
1297 1191
1298 mask |= 0x1;
1299 sl << uint16 (ob->face);
1300
1301 socket.send_faces (ob);
1302 }
1303 }
1304 /* Top face */
1305 else if (update_space (sl, socket, ms, lastcell, 0))
1306 mask |= 0x1; 1192 mask |= 0x1;
1193 sl << uint16 (ob->face);
1307 1194
1195 socket.send_faces (ob);
1196 }
1197 }
1198 /* Top face */
1199 else if (update_space (sl, socket, ms, lastcell, 0))
1200 mask |= 0x1;
1201
1308 /* Check to see if we are in fact sending anything for this 1202 /* Check to see if we are in fact sending anything for this
1309 * space by checking the mask. If so, update the mask. 1203 * space by checking the mask. If so, update the mask.
1310 * if not, reset the len to that from before adding the mask 1204 * if not, reset the len to that from before adding the mask
1311 * value, so we don't send those bits. 1205 * value, so we don't send those bits.
1312 */ 1206 */
1313 if (mask & 0xf) 1207 if (mask & 0xf)
1314 sl[oldlen + 1] = mask & 0xff; 1208 sl[oldlen + 1] = mask & 0xff;
1315 else 1209 else
1316 sl.reset (oldlen); 1210 sl.reset (oldlen);
1317
1318 if (socket.ext_mapinfos)
1319 esl << uint16 (emask);
1320
1321 if (socket.EMI_smooth)
1322 {
1323 for (int layer = 2+1; layer--; )
1324 {
1325 object *ob = ms.faces_obj [layer];
1326
1327 // If there is no object for this space, or if the face for the object
1328 // is the blank face, set the smoothlevel to zero.
1329 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1330
1331 // We've gotten what face we want to use for the object. Now see if
1332 // if it has changed since we last sent it to the client.
1333 if (lastcell.smooth[layer] != smoothlevel)
1334 {
1335 lastcell.smooth[layer] = smoothlevel;
1336 esl << uint8 (smoothlevel);
1337 emask |= 1 << layer;
1338 }
1339 }
1340
1341 if (emask & 0xf)
1342 esl[eoldlen + 1] = emask & 0xff;
1343 else
1344 esl.reset (eoldlen);
1345 }
1346 } /* else this is a viewable space */ 1211 } /* else this is a viewable space */
1347 } /* for x loop */ 1212 ordered_mapwalk_end
1348 } /* for y loop */
1349 1213
1350 socket.flush_fx (); 1214 socket.flush_fx ();
1351
1352 /* Verify that we in fact do need to send this */
1353 if (socket.ext_mapinfos)
1354 {
1355 if (!(sl.length () > startlen || socket.sent_scroll))
1356 {
1357 /* No map data will follow, so don't say the client
1358 * it doesn't need draw!
1359 */
1360 ewhatflag &= ~EMI_NOREDRAW;
1361 esl[ewhatstart + 1] = ewhatflag & 0xff;
1362 }
1363
1364 if (esl.length () > estartlen)
1365 socket.send_packet (esl);
1366 }
1367 1215
1368 if (sl.length () > startlen || socket.sent_scroll) 1216 if (sl.length () > startlen || socket.sent_scroll)
1369 { 1217 {
1370 socket.send_packet (sl); 1218 socket.send_packet (sl);
1371 socket.sent_scroll = 0; 1219 socket.sent_scroll = 0;
1392{ 1240{
1393 packet sl; 1241 packet sl;
1394 sl << "replyinfo skill_info\n"; 1242 sl << "replyinfo skill_info\n";
1395 1243
1396 for (int i = 1; i < NUM_SKILLS; i++) 1244 for (int i = 1; i < NUM_SKILLS; i++)
1397 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1245 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names [i]);
1398 1246
1399 if (sl.length () >= MAXSOCKBUF) 1247 if (sl.length () > MAXSOCKBUF)
1400 { 1248 {
1401 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1249 LOG (llevError, "Buffer overflow in send_skill_info!\n");
1402 fatal (0); 1250 fatal (0);
1403 } 1251 }
1404 1252
1417 sl << "replyinfo spell_paths\n"; 1265 sl << "replyinfo spell_paths\n";
1418 1266
1419 for (int i = 0; i < NRSPELLPATHS; i++) 1267 for (int i = 0; i < NRSPELLPATHS; i++)
1420 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1268 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
1421 1269
1422 if (sl.length () >= MAXSOCKBUF) 1270 if (sl.length () > MAXSOCKBUF)
1423 { 1271 {
1424 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1272 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
1425 fatal (0); 1273 fatal (0);
1426 } 1274 }
1427 1275
1446 if (spell->type == SPELL) 1294 if (spell->type == SPELL)
1447 { 1295 {
1448 int flags = 0; 1296 int flags = 0;
1449 1297
1450 /* check if we need to update it */ 1298 /* check if we need to update it */
1451 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 1299 if (spell->cached_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
1452 { 1300 {
1453 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1301 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1454 flags |= UPD_SP_MANA; 1302 flags |= UPD_SP_MANA;
1455 } 1303 }
1456 1304
1457 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 1305 if (spell->cached_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
1458 { 1306 {
1459 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1307 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1460 flags |= UPD_SP_GRACE; 1308 flags |= UPD_SP_GRACE;
1461 } 1309 }
1462 1310
1463 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 1311 if (spell->cached_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
1464 { 1312 {
1465 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1313 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1466 flags |= UPD_SP_DAMAGE; 1314 flags |= UPD_SP_DAMAGE;
1467 } 1315 }
1468 1316
1469 if (flags) 1317 if (flags)
1470 { 1318 {
1472 1320
1473 sl << "updspell " 1321 sl << "updspell "
1474 << uint8 (flags) 1322 << uint8 (flags)
1475 << uint32 (spell->count); 1323 << uint32 (spell->count);
1476 1324
1477 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1325 if (flags & UPD_SP_MANA ) sl << uint16 (spell->cached_sp);
1478 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1326 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->cached_grace);
1479 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1327 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->cached_eat);
1480 1328
1481 pl->ns->send_packet (sl); 1329 pl->ns->send_packet (sl);
1482 } 1330 }
1483 } 1331 }
1484 } 1332 }
1514 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1362 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
1515 return; 1363 return;
1516 } 1364 }
1517 1365
1518 /* store costs and damage in the object struct, to compare to later */ 1366 /* store costs and damage in the object struct, to compare to later */
1519 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1367 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1520 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1368 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1521 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1369 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1522 1370
1523 /* figure out which skill it uses, if it uses one */ 1371 /* figure out which skill it uses, if it uses one */
1524 if (spell->skill) 1372 if (spell->skill)
1525 { 1373 if (object *tmp = pl->find_skill (spell->skill))
1526 for (i = 1; i < NUM_SKILLS; i++)
1527 if (!strcmp (spell->skill, skill_names[i]))
1528 {
1529 skill = i + CS_STAT_SKILLINFO; 1374 skill = tmp->subtype + CS_STAT_SKILLINFO;
1530 break;
1531 }
1532 }
1533 1375
1534 // spells better have a face 1376 // spells better have a face
1535 if (!spell->face) 1377 if (!spell->face)
1536 { 1378 {
1537 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name); 1379 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1538 spell->face = face_find ("burnout.x11", blank_face); 1380 spell->face = face_find ("burnout.x11", blank_face);
1539 } 1381 }
1382
1383 pl->ns->send_face (spell->face);
1540 1384
1541 /* send the current values */ 1385 /* send the current values */
1542 sl << uint32 (spell->count) 1386 sl << uint32 (spell->count)
1543 << uint16 (spell->level) 1387 << uint16 (spell->level)
1544 << uint16 (spell->casting_time) 1388 << uint16 (spell->casting_time)
1545 << uint16 (spell->last_sp) 1389 << uint16 (spell->cached_sp)
1546 << uint16 (spell->last_grace) 1390 << uint16 (spell->cached_grace)
1547 << uint16 (spell->last_eat) 1391 << uint16 (spell->cached_eat)
1548 << uint8 (skill) 1392 << uint8 (skill)
1549 << uint32 (spell->path_attuned) 1393 << uint32 (spell->path_attuned)
1550 << uint32 (spell->face) 1394 << uint32 (spell->face)
1551 << data8 (spell->name) 1395 << data8 (spell->name)
1552 << data16 (spell->msg); 1396 << data16 (spell->msg);
1580 * bytes and 3 strings (because that is the spec) so we need to 1424 * bytes and 3 strings (because that is the spec) so we need to
1581 * check that the length of those 3 strings, plus the 23 bytes, 1425 * check that the length of those 3 strings, plus the 23 bytes,
1582 * won't take us over the length limit for the socket, if it does, 1426 * won't take us over the length limit for the socket, if it does,
1583 * we need to send what we already have, and restart packet formation 1427 * we need to send what we already have, and restart packet formation
1584 */ 1428 */
1429 if (spell->type != SPELL)
1430 continue;
1431
1585 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1432 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
1586 * to show add_spell is 26 bytes + 2 strings. However, the overun 1433 * to show add_spell is 26 bytes + 2 strings. However, the overun
1587 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1434 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
1588 * like it will fix this 1435 * like it will fix this
1589 */ 1436 */
1590 if (spell->type != SPELL)
1591 continue;
1592
1593 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1437 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
1594 { 1438 {
1439 pl->ns->flush_fx ();
1595 pl->ns->send_packet (sl); 1440 pl->ns->send_packet (sl);
1596 1441
1597 sl.reset (); 1442 sl.reset ();
1598 sl << "addspell "; 1443 sl << "addspell ";
1599 } 1444 }
1607 return; 1452 return;
1608 } 1453 }
1609 else 1454 else
1610 append_spell (pl, sl, spell); 1455 append_spell (pl, sl, spell);
1611 1456
1612 if (sl.length () >= MAXSOCKBUF) 1457 if (sl.length () > MAXSOCKBUF)
1613 { 1458 {
1614 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1459 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
1615 fatal (0); 1460 fatal (0);
1616 } 1461 }
1617 1462
1618 /* finally, we can send the packet */ 1463 /* finally, we can send the packet */
1464 pl->ns->flush_fx ();
1619 pl->ns->send_packet (sl); 1465 pl->ns->send_packet (sl);
1620} 1466}
1621 1467

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines