ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.79 by root, Thu Mar 15 16:25:45 2007 UTC vs.
Revision 1.146 by root, Sat Dec 27 01:25:00 2008 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2001 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/** 24/**
26 * \file 25 * \file
27 * Client handling. 26 * Client handling.
99 */ 98 */
100 mx = ns->mapx; 99 mx = ns->mapx;
101 my = ns->mapy; 100 my = ns->mapy;
102 101
103 /* the x and y here are coordinates for the new map, i.e. if we moved 102 /* the x and y here are coordinates for the new map, i.e. if we moved
104 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 103 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
105 * if the destination x or y coordinate is outside the viewable 104 * if the destination x or y coordinate is outside the viewable
106 * area, we clear the values - otherwise, the old values 105 * area, we clear the values - otherwise, the old values
107 * are preserved, and the check_head thinks it needs to clear them. 106 * are preserved, and the check_head thinks it needs to clear them.
108 */ 107 */
109 for (x = 0; x < mx; x++) 108 for (x = 0; x < mx; x++)
110 {
111 for (y = 0; y < my; y++) 109 for (y = 0; y < my; y++)
112 {
113 if (x >= ns->mapx || y >= ns->mapy) 110 if (x >= ns->mapx || y >= ns->mapy)
114 /* clear cells outside the viewable area */ 111 /* clear cells outside the viewable area */
115 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell)); 112 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
116 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy) 113 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
117 /* clear newly visible tiles within the viewable area */ 114 /* clear newly visible tiles within the viewable area */
118 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell)); 115 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
119 else 116 else
120 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell)); 117 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
121 }
122 }
123 118
124 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map)); 119 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
125 120
126 /* Make sure that the next "map1" command will be sent (even if it is 121 /* Make sure that the next "map1" command will be sent (even if it is
127 * empty). 122 * empty).
130} 125}
131 126
132static void 127static void
133clear_map (player *pl) 128clear_map (player *pl)
134{ 129{
130 pl->ns->mapinfo_queue_clear ();
131
135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap)); 132 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
136 133
137 pl->ns->force_newmap = false; 134 pl->ns->force_newmap = false;
138 135
139 if (pl->ns->newmapcmd == 1) 136 if (pl->ns->newmapcmd == 1)
140 pl->ns->send_packet ("newmap"); 137 pl->ns->send_packet ("newmap");
141 138
142 pl->ns->floorbox_reset (); 139 pl->ns->floorbox_reset ();
140}
141
142static void
143send_map_info (player *pl)
144{
145 client &socket = *pl->ns;
146 object *ob = pl->observe;
147
148 if (socket.mapinfocmd)
149 {
150 if (ob->map && ob->map->path[0])
151 {
152 int flags = 0;
153
154 if (ob->map->tile_path[0]) flags |= 1;
155 if (ob->map->tile_path[1]) flags |= 2;
156 if (ob->map->tile_path[2]) flags |= 4;
157 if (ob->map->tile_path[3]) flags |= 8;
158
159 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
160 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
161 ob->map->width, ob->map->height, &ob->map->path);
162 }
163 else
164 socket.send_packet ("mapinfo current");
165 }
143} 166}
144 167
145/** check for map/region change and send new map data */ 168/** check for map/region change and send new map data */
146static void 169static void
147check_map_change (player *pl) 170check_map_change (player *pl)
148{ 171{
149 client &socket = *pl->ns; 172 client &socket = *pl->ns;
150 object *ob = pl->ob; 173 object *ob = pl->observe;
151 char buf[MAX_BUF]; /* eauugggh */
152 174
153 if (socket.force_newmap && 0) 175 region *reg = ob->region ();
176 if (socket.current_region != reg)
177 {
178 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
179 socket.current_region = reg;
154 { 180 }
155 // force newmap is used for clients that do not redraw their map 181
156 // after image uploads. 182 // first try to aovid a full newmap on tiled map scrolls
183 if (socket.current_map != ob->map && !socket.force_newmap)
184 {
185 rv_vector rv;
186
187 get_rangevector_from_mapcoord (socket.current_map, socket.current_x, socket.current_y, ob, &rv, 0);
188
189 // manhattan distance is very handy here
190 if (rv.distance < 8) // 8 works nicely for speed << 70 and buggy gcfclient
191 {
192 socket.current_map = ob->map;
193 socket.current_x = ob->x;
194 socket.current_y = ob->y;
195
196 socket_map_scroll (&socket, rv.distance_x, rv.distance_y);
197 socket.floorbox_reset ();
198 send_map_info (pl);
199 }
200 }
201
202 if (socket.current_map != ob->map || socket.force_newmap)
203 {
204 clear_map (pl);
157 socket.current_map = ob->map; 205 socket.current_map = ob->map;
158 clear_map (pl); 206 send_map_info (pl);
159 }
160 else if (socket.current_map != ob->map)
161 {
162 clear_map (pl);
163
164 if (socket.mapinfocmd)
165 {
166 if (ob->map && ob->map->path[0])
167 {
168 int flags = 0;
169
170 if (ob->map->tile_path[0])
171 flags |= 1;
172 if (ob->map->tile_path[1])
173 flags |= 2;
174 if (ob->map->tile_path[2])
175 flags |= 4;
176 if (ob->map->tile_path[3])
177 flags |= 8;
178
179 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s",
180 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, &ob->map->path);
181 }
182 else
183 snprintf (buf, MAX_BUF, "mapinfo current");
184
185 socket.send_packet (buf);
186 }
187 } 207 }
188 else if (socket.current_x != ob->x || socket.current_y != ob->y) 208 else if (socket.current_x != ob->x || socket.current_y != ob->y)
189 { 209 {
190 int dx = ob->x - socket.current_x; 210 int dx = ob->x - socket.current_x;
191 int dy = ob->y - socket.current_y; 211 int dy = ob->y - socket.current_y;
192 212
193 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
194 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
195 else
196 {
197 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 213 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
198 socket.floorbox_reset (); 214 socket.floorbox_reset ();
199 }
200 } 215 }
201 216
202 socket.current_x = ob->x; 217 socket.current_x = ob->x;
203 socket.current_y = ob->y; 218 socket.current_y = ob->y;
204
205 region *reg = ob->region ();
206 if (socket.current_region != reg)
207 {
208 socket.current_region = reg;
209 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
210 }
211} 219}
212 220
213/** 221/**
214 * RequestInfo is sort of a meta command. There is some specific 222 * RequestInfo is sort of a meta command. There is some specific
215 * request of information, but we call other functions to provide 223 * request of information, but we call other functions to provide
216 * that information. 224 * that information.
217 */ 225 */
218void 226void
219RequestInfo (char *buf, int len, client * ns) 227RequestInfo (char *buf, int len, client *ns)
220{ 228{
221 char *params = NULL, *cp; 229 char *params;
222
223 /* No match */
224 char bigbuf[MAX_BUF];
225 int slen;
226
227 /* Set up replyinfo before we modify any of the buffers - this is used
228 * if we don't find a match.
229 */
230 strcpy (bigbuf, "replyinfo ");
231 slen = strlen (bigbuf);
232 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
233 230
234 /* find the first space, make it null, and update the 231 /* find the first space, make it null, and update the
235 * params pointer. 232 * params pointer.
236 */ 233 */
237 for (cp = buf; *cp != '\0'; cp++) 234 for (params = buf; *params; params++)
238 if (*cp == ' ') 235 if (*params == ' ')
239 { 236 {
240 *cp = '\0';
241 params = cp + 1; 237 *params++ = 0;
242 break; 238 break;
243 } 239 }
244 240
245 if (!strcmp (buf, "image_info")) 241 if (!strcmp (buf, "image_info"))
246 send_image_info (ns, params); 242 send_image_info (ns, params);
249 else if (!strcmp (buf, "skill_info")) 245 else if (!strcmp (buf, "skill_info"))
250 send_skill_info (ns, params); 246 send_skill_info (ns, params);
251 else if (!strcmp (buf, "spell_paths")) 247 else if (!strcmp (buf, "spell_paths"))
252 send_spell_paths (ns, params); 248 send_spell_paths (ns, params);
253 else 249 else
254 ns->send_packet (bigbuf, len); 250 {
251 // undo tokenisation above and send replyinfo with the request unchanged
252 if (*params)
253 *--params = ' ';
254
255 ns->send_packet_printf ("replyinfo %s", buf);
256 }
255} 257}
256 258
257void 259void
258ExtCmd (char *buf, int len, player *pl) 260ExtCmd (char *buf, int len, player *pl)
259{ 261{
262 264
263void 265void
264ExtiCmd (char *buf, int len, client *ns) 266ExtiCmd (char *buf, int len, client *ns)
265{ 267{
266 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len)); 268 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
269}
270
271void
272client::mapinfo_queue_clear ()
273{
274 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
275 free (*i);
276
277 mapinfo_queue.clear ();
278}
279
280bool
281client::mapinfo_try (char *buf)
282{
283 char *token = buf;
284 buf += strlen (buf) + 9;
285
286 // initial map and its origin
287 maptile *map = pl->observe->map;
288 int mapx = pl->ns->mapx / 2 - pl->observe->x;
289 int mapy = pl->ns->mapy / 2 - pl->observe->y;
290 int max_distance = 8; // limit maximum path length to something generous
291
292 while (*buf && map && max_distance)
293 {
294 int dir = *buf++ - '1';
295
296 if (dir >= 0 && dir <= 3)
297 {
298 if (!map->tile_path [dir])
299 map = 0;
300 else if (map->tile_available (dir, false))
301 {
302 maptile *neigh = map->tile_map [dir];
303
304 switch (dir)
305 {
306 case 0: mapy -= neigh->height; break;
307 case 2: mapy += map ->height; break;
308 case 3: mapx -= neigh->width ; break;
309 case 1: mapx += map ->width ; break;
310 }
311
312 map = neigh;
313 --max_distance;
314 }
315 else
316 return 0;
317 }
318 else
319 max_distance = 0;
320 }
321
322 if (!max_distance)
323 send_packet_printf ("mapinfo %s error", token);
324 else if (!map || !map->path)
325 send_packet_printf ("mapinfo %s nomap", token);
326 else
327 {
328 int flags = 0;
329
330 if (map->tile_path[0]) flags |= 1;
331 if (map->tile_path[1]) flags |= 2;
332 if (map->tile_path[2]) flags |= 4;
333 if (map->tile_path[3]) flags |= 8;
334
335 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
336 }
337
338 return 1;
339}
340
341void
342client::mapinfo_queue_run ()
343{
344 if (mapinfo_queue.empty () || !pl)
345 return;
346
347 for (int i = 0; i < mapinfo_queue.size (); ++i)
348 if (mapinfo_try (mapinfo_queue [i]))
349 {
350 free (mapinfo_queue [i]);
351 mapinfo_queue.erase (i);
352 }
353 else
354 ++i;
267} 355}
268 356
269void 357void
270MapInfoCmd (char *buf, int len, player *pl) 358MapInfoCmd (char *buf, int len, player *pl)
271{ 359{
272 // <mapinfo tag spatial tile-path 360 // <mapinfo tag spatial tile-path
273 // >mapinfo tag spatial flags x y w h hash 361 // >mapinfo tag spatial flags x y w h hash
274 362
275 char bigbuf[MAX_BUF], *token;
276
277 token = buf; 363 char *token = buf;
278 // copy token 364
279 if (!(buf = strchr (buf, ' '))) 365 if (!(buf = strchr (buf, ' ')))
280 return; 366 return;
281 367
282 *buf++ = 0;
283
284 if (!strncmp (buf, "spatial ", 8)) 368 if (!strncmp (buf, " spatial ", 9))
285 { 369 {
286 buf += 8; 370 char *copy = strdup (token);
371 copy [buf - token] = 0;
287 372
288 // initial map and its origin 373#if 0
289 maptile *map = pl->ob->map; 374 // this makes only sense when we flush the buffer immediately
290 sint16 dx, dy; 375 if (pl->ns->mapinfo_try (copy))
291 int mapx = pl->ns->mapx / 2 - pl->ob->x; 376 free (copy);
292 int mapy = pl->ns->mapy / 2 - pl->ob->y;
293 int max_distance = 8; // limit maximum path length to something generous
294
295 while (*buf && map && max_distance)
296 {
297 int dir = *buf++;
298
299 switch (dir)
300 {
301 case '1':
302 dx = 0;
303 dy = -1;
304 map = map->xy_find (dx, dy);
305 map && (mapy -= map->height);
306 break;
307 case '2':
308 mapx += map->width;
309 dx = map->width;
310 dy = 0;
311 map = map->xy_find (dx, dy);
312 break;
313 case '3':
314 mapy += map->height;
315 dx = 0;
316 dy = map->height;
317 map = map->xy_find (dx, dy);
318 break;
319 case '4':
320 dx = -1;
321 dy = 0;
322 map = map->xy_find (dx, dy);
323 map && (mapx -= map->width);
324 break;
325 }
326
327 --max_distance;
328 }
329
330 if (!max_distance)
331 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
332 else if (map && map->path[0])
333 {
334 int flags = 0;
335
336 if (map->tile_path[0])
337 flags |= 1;
338 if (map->tile_path[1])
339 flags |= 2;
340 if (map->tile_path[2])
341 flags |= 4;
342 if (map->tile_path[3])
343 flags |= 8;
344
345 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
346 }
347 else 377 else
348 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 378#endif
379 pl->ns->mapinfo_queue.push_back (copy);
349 } 380 }
350 else 381 else
351 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 382 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
352
353 pl->ns->send_packet (bigbuf);
354} 383}
355 384
356/** This is the Setup cmd - easy first implementation */ 385/** This is the Setup cmd */
357void 386void
358SetUp (char *buf, int len, client * ns) 387SetUp (char *buf, int len, client * ns)
359{ 388{
360 int s, slen; 389 INVOKE_CLIENT (SETUP, ns, ARG_DATA (buf, len));
361 char *cmd, *param, cmdback[HUGE_BUF];
362
363 /* run through the cmds of setup
364 * syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
365 *
366 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
367 * The client then must sort this out
368 */
369
370 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
371
372 strcpy (cmdback, "setup");
373 for (s = 0; s < len; )
374 {
375 cmd = &buf[s];
376
377 /* find the next space, and put a null there */
378 for (; buf[s] && buf[s] != ' '; s++)
379 ;
380
381 buf[s++] = 0;
382
383 while (buf[s] == ' ')
384 s++;
385
386 if (s >= len)
387 break;
388
389 param = &buf[s];
390
391 for (; buf[s] && buf[s] != ' '; s++)
392 ;
393
394 buf[s++] = 0;
395
396 while (buf[s] == ' ')
397 s++;
398
399 slen = strlen (cmdback);
400 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
401 safe_strcat (cmdback, cmd, &slen, HUGE_BUF);
402 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
403
404 if (!strcmp (cmd, "sound"))
405 {
406 ns->sound = atoi (param);
407 safe_strcat (cmdback, param, &slen, HUGE_BUF);
408 }
409 else if (!strcmp (cmd, "exp64"))
410 safe_strcat (cmdback, param, &slen, HUGE_BUF);
411 else if (!strcmp (cmd, "spellmon"))
412 {
413 ns->monitor_spells = atoi (param);
414 safe_strcat (cmdback, param, &slen, HUGE_BUF);
415 }
416 else if (!strcmp (cmd, "darkness"))
417 {
418 ns->darkness = atoi (param);
419 safe_strcat (cmdback, param, &slen, HUGE_BUF);
420 }
421 else if (!strcmp (cmd, "map1cmd"))
422 {
423 if (atoi (param))
424 ns->mapmode = Map1Cmd;
425 /* if beyond this size, need to use map1cmd no matter what */
426 if (ns->mapx > 11 || ns->mapy > 11)
427 ns->mapmode = Map1Cmd;
428 safe_strcat (cmdback, ns->mapmode == Map1Cmd ? "1" : "0", &slen, HUGE_BUF);
429 }
430 else if (!strcmp (cmd, "map1acmd"))
431 {
432 if (atoi (param))
433 ns->mapmode = Map1aCmd;
434 /* if beyond this size, need to use map1acmd no matter what */
435 if (ns->mapx > 11 || ns->mapy > 11)
436 ns->mapmode = Map1aCmd;
437 safe_strcat (cmdback, ns->mapmode == Map1aCmd ? "1" : "0", &slen, HUGE_BUF);
438 }
439 else if (!strcmp (cmd, "newmapcmd"))
440 {
441 ns->newmapcmd = atoi (param);
442 safe_strcat (cmdback, param, &slen, HUGE_BUF);
443 }
444 else if (!strcmp (cmd, "mapinfocmd"))
445 {
446 ns->mapinfocmd = atoi (param);
447 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
448 }
449 else if (!strcmp (cmd, "extcmd"))
450 {
451 ns->extcmd = atoi (param);
452 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
453 }
454 else if (!strcmp (cmd, "extmap"))
455 {
456 ns->extmap = atoi (param);
457 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
458 }
459 else if (!strcmp (cmd, "facecache"))
460 {
461 ns->facecache = atoi (param);
462 safe_strcat (cmdback, param, &slen, HUGE_BUF);
463 }
464 else if (!strcmp (cmd, "faceset"))
465 {
466 char tmpbuf[20];
467 int q = atoi (param);
468
469 if (is_valid_faceset (q))
470 ns->faceset = q;
471
472 sprintf (tmpbuf, "%d", ns->faceset);
473 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
474 /* if the client is using faceset, it knows about image2 command */
475 ns->image2 = 1;
476 }
477 else if (!strcmp (cmd, "itemcmd"))
478 {
479 /* Version of the item protocol command to use. Currently,
480 * only supported versions are 1 and 2. Using a numeric
481 * value will make it very easy to extend this in the future.
482 */
483 char tmpbuf[20];
484 int q = atoi (param);
485
486 if (q < 1 || q > 2)
487 {
488 strcpy (tmpbuf, "FALSE");
489 }
490 else
491 {
492 ns->itemcmd = q;
493 sprintf (tmpbuf, "%d", ns->itemcmd);
494 }
495 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
496 }
497 else if (!strcmp (cmd, "mapsize"))
498 {
499 int x, y = 0;
500 char tmpbuf[MAX_BUF], *cp;
501
502 x = atoi (param);
503 for (cp = param; *cp != 0; cp++)
504 if (*cp == 'x' || *cp == 'X')
505 {
506 y = atoi (cp + 1);
507 break;
508 }
509
510 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
511 {
512 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
513 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
514 }
515 else
516 {
517 ns->mapx = x;
518 ns->mapy = y;
519 /* better to send back what we are really using and not the
520 * param as given to us in case it gets parsed differently.
521 */
522 sprintf (tmpbuf, "%dx%d", x, y);
523 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
524 /* If beyond this size and still using orig map command, need to
525 * go to map1cmd.
526 */
527 if ((x > 11 || y > 11) && ns->mapmode == Map0Cmd)
528 ns->mapmode = Map1Cmd;
529 }
530 }
531 else if (!strcmp (cmd, "extendedMapInfos"))
532 {
533 /* Added by tchize
534 * prepare to use the mapextended command
535 */
536 char tmpbuf[20];
537
538 ns->ext_mapinfos = (atoi (param));
539 sprintf (tmpbuf, "%d", ns->ext_mapinfos);
540 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
541 }
542 else if (!strcmp (cmd, "extendedTextInfos"))
543 {
544 /* Added by tchize
545 * prepare to use the extended text commands
546 * Client toggle this to non zero to get exttext
547 */
548 char tmpbuf[20];
549
550 ns->has_readable_type = (atoi (param));
551 sprintf (tmpbuf, "%d", ns->has_readable_type);
552 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
553 }
554 else
555 {
556 /* Didn't get a setup command we understood -
557 * report a failure to the client.
558 */
559 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
560 }
561 } /* for processing all the setup commands */
562
563 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
564 ns->send_packet (cmdback);
565} 390}
566 391
567/** 392/**
568 * The client has requested to be added to the game. 393 * The client has requested to be added to the game.
569 * This is what takes care of it. We tell the client how things worked out. 394 * This is what takes care of it. We tell the client how things worked out.
571 * it either has to be here or init_sockets needs to be exported. 396 * it either has to be here or init_sockets needs to be exported.
572 */ 397 */
573void 398void
574AddMeCmd (char *buf, int len, client *ns) 399AddMeCmd (char *buf, int len, client *ns)
575{ 400{
576 // face caching is mandatory
577 if (!ns->facecache)
578 {
579 ns->send_drawinfo (
580 "\n"
581 "\n"
582 "***\n"
583 "*** WARNING:\n"
584 "*** Your client does not support face/image caching,\n"
585 "*** or it has been disabled. Face caching is mandatory\n"
586 "*** so please enable it or use a newer client.\n"
587 "***\n"
588 "*** Look at your client preferences:\n"
589 "***\n"
590 "*** CFPlus: all known versions automatically enable the facecache.\n"
591 "*** cfclient: use the -cache commandline option.\n"
592 "*** cfclient: map will not redraw automatically (bug).\n"
593 "*** gcfclient: use -cache commandline option, or enable\n"
594 "*** gcfclient: Client=>Configure=>Map & Image=>Cache Images.\n"
595 "*** jcrossclient: your client is broken, use CFPlus or gcfclient.\n"
596 "***\n"
597 "***\n",
598 NDI_RED
599 );
600
601 if (strstr (ns->version, "jcrossclient"))
602 /* let them, for now*/;
603 else
604 {
605 ns->flush ();
606 //ns->destroy ();
607 }
608 //ns->facecache = true;
609 }
610
611 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len)); 401 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
612}
613
614/** Reply to ExtendedInfos command */
615void
616ToggleExtendedInfos (char *buf, int len, client * ns)
617{
618 char cmdback[MAX_BUF];
619 char command[50];
620 int info, nextinfo;
621
622 cmdback[0] = '\0';
623 nextinfo = 0;
624
625 while (1)
626 {
627 /* 1. Extract an info */
628 info = nextinfo;
629
630 while ((info < len) && (buf[info] == ' '))
631 info++;
632
633 if (info >= len)
634 break;
635
636 nextinfo = info + 1;
637
638 while ((nextinfo < len) && (buf[nextinfo] != ' '))
639 nextinfo++;
640
641 if (nextinfo - info >= 49) /*Erroneous info asked */
642 continue;
643
644 strncpy (command, &(buf[info]), nextinfo - info);
645
646 /* 2. Interpret info */
647 if (!strcmp ("smooth", command))
648 /* Toggle smoothing */
649 ns->EMI_smooth = !ns->EMI_smooth;
650 else
651 /*bad value */;
652
653 /*3. Next info */
654 }
655
656 strcpy (cmdback, "ExtendedInfoSet");
657
658 if (ns->EMI_smooth)
659 {
660 strcat (cmdback, " ");
661 strcat (cmdback, "smoothing");
662 }
663
664 ns->send_packet (cmdback);
665} 402}
666 403
667/* 404/*
668#define MSG_TYPE_BOOK 1 405#define MSG_TYPE_BOOK 1
669#define MSG_TYPE_CARD 2 406#define MSG_TYPE_CARD 2
726 463
727 ns->send_packet (cmdback); 464 ns->send_packet (cmdback);
728} 465}
729 466
730/** 467/**
731 * client requested an image. send it rate-limited
732 * before flushing.
733 */
734void
735AskFaceCmd (char *buf, int len, client *ns)
736{
737 ns->askface.push_back (atoi (buf));
738}
739
740/**
741 * Tells client the picture it has to use
742 * to smooth a picture number given as argument.
743 */
744void
745AskSmooth (char *buf, int len, client *ns)
746{
747 ns->send_face (atoi (buf));
748}
749
750/**
751 * This handles the general commands from the client (ie, north, fire, cast, 468 * This handles the general commands from the client (ie, north, fire, cast,
752 * etc.) 469 * etc.)
753 */ 470 */
754void 471void
755PlayerCmd (char *buf, int len, player *pl) 472PlayerCmd (char *buf, int len, player *pl)
776 * commands. 493 * commands.
777 */ 494 */
778 pl->count = 0; 495 pl->count = 0;
779} 496}
780 497
781
782/** 498/**
783 * This handles the general commands from the client (ie, north, fire, cast, 499 * This handles the general commands from the client (ie, north, fire, cast,
784 * etc.). It is a lot like PlayerCmd above, but is called with the 500 * etc.). It is a lot like PlayerCmd above, but is called with the
785 * 'ncom' method which gives more information back to the client so it 501 * 'ncom' method which gives more information back to the client so it
786 * can throttle. 502 * can throttle.
788void 504void
789NewPlayerCmd (char *buf, int len, player *pl) 505NewPlayerCmd (char *buf, int len, player *pl)
790{ 506{
791 if (len <= 6) 507 if (len <= 6)
792 { 508 {
793 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 509 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
794 return; 510 return;
795 } 511 }
796 512
797 uint16 cmdid = net_uint16 ((uint8 *)buf); 513 uint16 cmdid = net_uint16 ((uint8 *)buf);
798 sint32 repeat = net_sint32 ((uint8 *)buf + 2); 514 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
855 { 571 {
856 case ST_PLAYING: 572 case ST_PLAYING:
857 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 573 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
858 break; 574 break;
859 575
860 case ST_CHANGE_CLASS:
861 key_change_class (pl->ob, buf[0]);
862 break;
863
864 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 576 case ST_GET_PARTY_PASSWORD: /* Get password for party */
865 receive_party_password (pl->ob, 13); 577 receive_party_password (pl->ob, 13);
866 break; 578 break;
867 579
868 default: 580 default:
907 619
908 cp = strchr (cp + 1, ' '); 620 cp = strchr (cp + 1, ' ');
909 621
910 if (cp) 622 if (cp)
911 { 623 {
912 assign (ns->version, cp + 1); 624 ns->version = cp + 1;
913 625
914 if (ns->sc_version < 1026) 626 if (ns->sc_version < 1026)
915 ns->send_packet_printf ("drawinfo %d %s", NDI_RED, 627 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
916 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 628 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
917 } 629 }
940 * syntax is: move (to) (tag) (nrof) 652 * syntax is: move (to) (tag) (nrof)
941 */ 653 */
942void 654void
943MoveCmd (char *buf, int len, player *pl) 655MoveCmd (char *buf, int len, player *pl)
944{ 656{
945 int vals[3], i; 657 int to, tag, nrof;
946 658
947 /* A little funky here. We only cycle for 2 records, because 659 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
948 * we obviously are not going to find a space after the third
949 * record. Perhaps we should just replace this with a
950 * sscanf?
951 */
952 for (i = 0; i < 2; i++)
953 { 660 {
954 vals[i] = atoi (buf);
955
956 if (!(buf = strchr (buf, ' ')))
957 {
958 LOG (llevError, "Incomplete move command: %s\n", buf); 661 LOG (llevError, "Incomplete move command: %s\n", buf);
959 return; 662 return;
960 }
961
962 buf++;
963 } 663 }
964 664
965 vals[2] = atoi (buf); 665 esrv_move_object (pl->ob, to, tag, nrof);
966
967/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
968 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
969} 666}
970 667
971/****************************************************************************** 668/******************************************************************************
972 * 669 *
973 * Start of commands the server sends to the client. 670 * Start of commands the server sends to the client.
977/** 674/**
978 * Asks the client to query the user. This way, the client knows 675 * Asks the client to query the user. This way, the client knows
979 * it needs to send something back (vs just printing out a message) 676 * it needs to send something back (vs just printing out a message)
980 */ 677 */
981void 678void
982send_query (client *ns, uint8 flags, char *text) 679send_query (client *ns, uint8 flags, const char *text)
983{ 680{
984 ns->send_packet_printf ("query %d %s", flags, text ? text : ""); 681 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
682}
683
684/**
685 * Get player's current range attack in obuf.
686 */
687static void
688rangetostring (player *pl, char *obuf)
689{
690 dynbuf_text buf;
691
692 if (pl->ranged_ob)
693 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name;
694
695 if (pl->combat_ob)
696 buf << " Combat" << (pl->ob->current_weapon == pl->combat_ob ? "*" : "") << ": " << pl->combat_ob->name;
697
698#if 0
699 //TODO: remove this when slot system is working, this is only for debugging
700 if (pl->ob->chosen_skill)
701 buf << " Skill*: " << pl->ob->chosen_skill->name;
702#endif
703
704 //TODO: maybe golem should become the current_weapon, quite simply?
705 if (pl->golem)
706 buf << " Golem*: " << pl->golem->name;
707
708 buf << '\0';
709 buf.linearise (obuf);
985} 710}
986 711
987#define AddIfInt64(Old,New,Type) if (Old != New) {\ 712#define AddIfInt64(Old,New,Type) if (Old != New) {\
988 Old = New; \ 713 Old = New; \
989 sl << uint8 (Type) << uint64 (New); \ 714 sl << uint8 (Type) << uint64 (New); \
997#define AddIfShort(Old,New,Type) if (Old != New) {\ 722#define AddIfShort(Old,New,Type) if (Old != New) {\
998 Old = New; \ 723 Old = New; \
999 sl << uint8 (Type) << uint16 (New); \ 724 sl << uint8 (Type) << uint16 (New); \
1000 } 725 }
1001 726
1002#define AddIfFloat(Old,New,Type) if (Old != New) {\ 727#define AddIfFloat(Old,New,Type,mult) if (Old != New) {\
1003 Old = New; \ 728 Old = New; \
1004 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \ 729 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI*mult); \
1005 } 730 }
1006 731
1007#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 732#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1008 free(Old); Old = strdup (New);\ 733 free(Old); Old = strdup (New);\
1009 sl << uint8 (Type) << data8 (New); \ 734 sl << uint8 (Type) << data8 (New); \
1023 748
1024 client *ns = pl->ns; 749 client *ns = pl->ns;
1025 if (!ns) 750 if (!ns)
1026 return; 751 return;
1027 752
1028 object *ob = pl->ob; 753 object *ob = pl->observe;
1029 if (!ob) 754 if (!ob)
1030 return; 755 return;
756
757 player *opl = ob->contr ? static_cast<player *>(ob->contr) : pl;
1031 758
1032 packet sl ("stats"); 759 packet sl ("stats");
1033 760
1034 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP); 761 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1035 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP); 762 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1044 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS); 771 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
1045 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW); 772 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1046 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA); 773 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1047 774
1048 for (int s = 0; s < NUM_SKILLS; s++) 775 for (int s = 0; s < NUM_SKILLS; s++)
1049 if (object *skill = pl->last_skill_ob[s]) 776 if (object *skill = opl->last_skill_ob [s])
1050 if (skill->stats.exp != ns->last_skill_exp [s]) 777 if (skill->stats.exp != ns->last_skill_exp [s])
1051 { 778 {
1052 ns->last_skill_exp [s] = skill->stats.exp; 779 ns->last_skill_exp [s] = skill->stats.exp;
1053 780
1054 /* Always send along the level if exp changes. This is only 781 /* Always send along the level if exp changes. This is only
1062 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64); 789 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
1063 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL); 790 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
1064 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC); 791 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
1065 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC); 792 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
1066 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM); 793 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
1067 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED); 794 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED, 1.f/TICK);
1068 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD); 795 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
1069 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 796 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP, 1.f/TICK);
1070 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM); 797 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
1071 798
1072 flags = 0; 799 flags = 0;
1073 800
1074 if (pl->fire_on) 801 if (opl->fire_on)
1075 flags |= SF_FIREON; 802 flags |= SF_FIREON;
1076 803
1077 if (pl->run_on) 804 if (opl->run_on)
1078 flags |= SF_RUNON; 805 flags |= SF_RUNON;
1079 806
1080 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS); 807 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
1081 808
1082 if (ns->sc_version < 1025) 809 if (ns->sc_version < 1025)
1096 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE); 823 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1097 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL); 824 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1098 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY); 825 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1099 } 826 }
1100 827
1101 rangetostring (ob, buf); /* we want use the new fire & run system in new client */ 828 rangetostring (opl, buf); /* we want use the new fire & run system in new client */
1102 AddIfString (ns->stats.range, buf, CS_STAT_RANGE); 829 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1103 set_title (ob, buf); 830 set_title (ob, buf);
1104 AddIfString (ns->stats.title, buf, CS_STAT_TITLE); 831 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1105 832
1106 /* Only send it away if we have some actual data */ 833 /* Only send it away if we have some actual data */
1110 837
1111/** 838/**
1112 * Tells the client that here is a player it should start using. 839 * Tells the client that here is a player it should start using.
1113 */ 840 */
1114void 841void
1115esrv_new_player (player *pl, uint32 weight) 842esrv_new_player (player *pl)
1116{ 843{
844 sint32 weight = pl->ob->client_weight ();
845
1117 packet sl ("player"); 846 packet sl ("player");
1118 847
1119 sl << uint32 (pl->ob->count) 848 sl << uint32 (pl->ob->count)
1120 << uint32 (weight) 849 << uint32 (weight)
1121 << uint32 (pl->ob->face) 850 << uint32 (pl->ob->face)
1122 << data8 (pl->ob->name); 851 << data8 (pl->ob->name);
1123 852
1124 pl->ns->last_weight = weight; 853 pl->ns->last_weight = weight;
1125 pl->ns->send_packet (sl); 854 pl->ns->send_packet (sl);
1126 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1127} 855}
1128 856
1129/****************************************************************************** 857/******************************************************************************
1130 * 858 *
1131 * Start of map related commands. 859 * Start of map related commands.
1188 916
1189 if (!ns.faces_sent[face_num]) 917 if (!ns.faces_sent[face_num])
1190 if (ob) 918 if (ob)
1191 ns.send_faces (ob); 919 ns.send_faces (ob);
1192 else 920 else
1193 ns.send_face (face_num); 921 ns.send_face (face_num, 10);
1194 922
1195 sl << uint16 (face_num); 923 sl << uint16 (face_num);
1196 return 1; 924 return 1;
1197 } 925 }
1198 926
1199 /* Nothing changed */ 927 /* Nothing changed */
1200 return 0; 928 return 0;
1201}
1202
1203/**
1204 * Returns the size of a data for a map square as returned by
1205 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1206 * available.
1207 */
1208int
1209getExtendedMapInfoSize (client * ns)
1210{
1211 int result = 0;
1212
1213 if (ns->ext_mapinfos)
1214 {
1215 if (ns->EMI_smooth)
1216 result += 1; /*One byte for smoothlevel */
1217 }
1218
1219 return result;
1220} 929}
1221 930
1222// prefetch (and touch) all maps within a specific distancd 931// prefetch (and touch) all maps within a specific distancd
1223static void 932static void
1224prefetch_surrounding_maps (maptile *map, int distance) 933prefetch_surrounding_maps (maptile *map, int distance)
1240{ 949{
1241 prefetch_surrounding_maps (op->map, 3); 950 prefetch_surrounding_maps (op->map, 3);
1242} 951}
1243 952
1244/** 953/**
1245 * This function uses the new map1 protocol command to send the map 954 * Draws client map.
1246 * to the client. It is necessary because the old map command supports
1247 * a maximum map size of 15x15.
1248 * This function is much simpler than the old one. This is because
1249 * the old function optimized to send as few face identifiers as possible,
1250 * at the expense of sending more coordinate location (coordinates were
1251 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1252 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1253 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1254 * and use the other 4 bits for other informatiion. For full documentation
1255 * of what we send, see the doc/Protocol file.
1256 * I will describe internally what we do:
1257 * the ns->lastmap shows how the map last looked when sent to the client.
1258 * in the lastmap structure, there is a cells array, which is set to the
1259 * maximum viewable size (As set in config.h).
1260 * in the cells, there are faces and a count value.
1261 * we use the count value to hold the darkness value. If -1, then this space
1262 * is not viewable.
1263 * we use faces[0] faces[1] faces[2] to hold what the three layers
1264 * look like.
1265 */ 955 */
1266void 956void
1267draw_client_map1 (object *pl) 957draw_client_map (player *pl)
1268{ 958{
1269 int x, y, ax, ay, startlen, max_x, max_y, oldlen; 959 object *ob = pl->observe;
1270 sint16 nx, ny;
1271 int estartlen, eoldlen;
1272 uint8 eentrysize;
1273 uint16 ewhatstart, ewhatflag;
1274 uint8 extendedinfos;
1275 maptile *m;
1276
1277 client &socket = *pl->contr->ns;
1278
1279 if (!pl->active) 960 if (!ob->active)
1280 return; 961 return;
1281
1282 check_map_change (pl->contr);
1283 prefetch_surrounding_maps (pl);
1284
1285 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1286 packet esl;
1287
1288 startlen = sl.length ();
1289
1290 /*Extendedmapinfo structure initialisation */
1291 if (socket.ext_mapinfos)
1292 {
1293 extendedinfos = EMI_NOREDRAW;
1294
1295 if (socket.EMI_smooth)
1296 extendedinfos |= EMI_SMOOTH;
1297
1298 ewhatstart = esl.length ();
1299 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1300 could need to be taken away */
1301 eentrysize = getExtendedMapInfoSize (&socket);
1302 esl << "mapextended "
1303 << uint8 (extendedinfos)
1304 << uint8 (eentrysize);
1305
1306 estartlen = esl.length ();
1307 }
1308
1309 /* x,y are the real map locations. ax, ay are viewport relative
1310 * locations.
1311 */
1312 ay = 0;
1313
1314 /* We could do this logic as conditionals in the if statement,
1315 * but that started to get a bit messy to look at.
1316 */
1317 max_x = pl->x + (socket.mapx + 1) / 2;
1318 max_y = pl->y + (socket.mapy + 1) / 2;
1319
1320 maptile *plmap = pl->map;
1321
1322 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1323 {
1324 ax = 0;
1325 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1326 {
1327 int emask, mask;
1328 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1329
1330 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1331
1332 /* If the coordinates are not valid, or it is too dark to see,
1333 * we tell the client as such
1334 */
1335 nx = x;
1336 ny = y;
1337 m = get_map_from_coord (plmap, &nx, &ny);
1338
1339 if (!m)
1340 {
1341 /* space is out of map. Update space and clear values
1342 * if this hasn't already been done. If the space is out
1343 * of the map, it shouldn't have a head
1344 */
1345 if (lastcell.count != -1)
1346 {
1347 sl << uint16 (mask);
1348 map_clearcell (&lastcell, -1);
1349 }
1350
1351 continue;
1352 }
1353
1354 m->touch ();
1355
1356 int d = pl->contr->blocked_los[ax][ay];
1357
1358 if (d > 3)
1359 {
1360
1361 int need_send = 0, count;
1362
1363 /* This block deals with spaces that are not visible for whatever
1364 * reason. Still may need to send the head for this space.
1365 */
1366
1367 oldlen = sl.length ();
1368
1369 sl << uint16 (mask);
1370
1371 if (lastcell.count != -1)
1372 need_send = 1;
1373
1374 count = -1;
1375
1376 /* properly clear a previously sent big face */
1377 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1378 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1379 need_send = 1;
1380
1381 map_clearcell (&lastcell, count);
1382
1383 if ((mask & 0xf) || need_send)
1384 sl[oldlen + 1] = mask & 0xff;
1385 else
1386 sl.reset (oldlen);
1387 }
1388 else
1389 {
1390 /* In this block, the space is visible.
1391 */
1392
1393 /* Rather than try to figure out what everything that we might
1394 * need to send is, then form the packet after that,
1395 * we presume that we will in fact form a packet, and update
1396 * the bits by what we do actually send. If we send nothing,
1397 * we just back out sl.length () to the old value, and no harm
1398 * is done.
1399 * I think this is simpler than doing a bunch of checks to see
1400 * what if anything we need to send, setting the bits, then
1401 * doing those checks again to add the real data.
1402 */
1403 oldlen = sl.length ();
1404 eoldlen = esl.length ();
1405
1406 sl << uint16 (mask);
1407
1408 unsigned char dummy;
1409 unsigned char *last_ext = &dummy;
1410
1411 /* Darkness changed */
1412 if (lastcell.count != d && socket.darkness)
1413 {
1414 mask |= 0x8;
1415
1416 if (socket.extmap)
1417 {
1418 *last_ext |= 0x80;
1419 last_ext = &sl[sl.length ()];
1420 sl << uint8 (d);
1421 }
1422 else
1423 sl << uint8 (255 - 64 * d);
1424 }
1425
1426 lastcell.count = d;
1427
1428 mapspace &ms = m->at (nx, ny);
1429
1430 if (socket.extmap)
1431 {
1432 uint8 stat_hp = 0;
1433 uint8 stat_width = 0;
1434 uint8 flags = 0;
1435 UUID player = 0;
1436
1437 // send hp information, if applicable
1438 if (object *op = ms.faces_obj [0])
1439 {
1440 if (op->head || op->invisible)
1441 ; // do not show
1442 else if (op->type == PLAYER
1443 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
1444 {
1445 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
1446 {
1447 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1448 stat_width = op->arch->tail_x;
1449 }
1450 }
1451
1452 if (op->msg && op->msg[0] == '@')
1453 flags |= 1;
1454
1455 if (op->type == PLAYER && op != pl)
1456 player = op->count;
1457 }
1458
1459 if (lastcell.stat_hp != stat_hp)
1460 {
1461 lastcell.stat_hp = stat_hp;
1462
1463 mask |= 0x8;
1464 *last_ext |= 0x80;
1465 last_ext = &sl[sl.length ()];
1466
1467 sl << uint8 (5) << uint8 (stat_hp);
1468
1469 if (stat_width > 1)
1470 {
1471 *last_ext |= 0x80;
1472 last_ext = &sl[sl.length ()];
1473
1474 sl << uint8 (6) << uint8 (stat_width);
1475 }
1476 }
1477
1478 if (lastcell.player != player)
1479 {
1480 lastcell.player = player;
1481
1482 mask |= 0x8;
1483 *last_ext |= 0x80;
1484 last_ext = &sl[sl.length ()];
1485
1486 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
1487 }
1488
1489 if (lastcell.flags != flags)
1490 {
1491 lastcell.flags = flags;
1492
1493 mask |= 0x8;
1494 *last_ext |= 0x80;
1495 last_ext = &sl[sl.length ()];
1496
1497 sl << uint8 (8) << uint8 (flags);
1498 }
1499 }
1500
1501 /* Floor face */
1502 if (update_space (sl, socket, ms, lastcell, 2))
1503 mask |= 0x4;
1504
1505 /* Middle face */
1506 if (update_space (sl, socket, ms, lastcell, 1))
1507 mask |= 0x2;
1508
1509 if (ms.player () == pl
1510 && (pl->invisible & (pl->invisible < 50 ? 1 : 7)))
1511 {
1512 // force player to be visible to himself if invisible
1513 if (lastcell.faces[0] != pl->face)
1514 {
1515 lastcell.faces[0] = pl->face;
1516
1517 mask |= 0x1;
1518 sl << uint16 (pl->face);
1519
1520 socket.send_faces (pl);
1521 }
1522 }
1523 /* Top face */
1524 else if (update_space (sl, socket, ms, lastcell, 0))
1525 mask |= 0x1;
1526
1527
1528 /* Check to see if we are in fact sending anything for this
1529 * space by checking the mask. If so, update the mask.
1530 * if not, reset the len to that from before adding the mask
1531 * value, so we don't send those bits.
1532 */
1533 if (mask & 0xf)
1534 sl[oldlen + 1] = mask & 0xff;
1535 else
1536 sl.reset (oldlen);
1537
1538 if (socket.ext_mapinfos)
1539 esl << uint16 (emask);
1540
1541 if (socket.EMI_smooth)
1542 {
1543 for (int layer = 2+1; layer--; )
1544 {
1545 object *ob = ms.faces_obj [layer];
1546
1547 // If there is no object for this space, or if the face for the object
1548 // is the blank face, set the smoothlevel to zero.
1549 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1550
1551 // We've gotten what face we want to use for the object. Now see if
1552 // if it has changed since we last sent it to the client.
1553 if (lastcell.smooth[layer] != smoothlevel)
1554 {
1555 lastcell.smooth[layer] = smoothlevel;
1556 esl << uint8 (smoothlevel);
1557 emask |= 1 << layer;
1558 }
1559 }
1560
1561 if (emask & 0xf)
1562 esl[eoldlen + 1] = emask & 0xff;
1563 else
1564 esl.reset (eoldlen);
1565 }
1566 } /* else this is a viewable space */
1567 } /* for x loop */
1568 } /* for y loop */
1569
1570 /* Verify that we in fact do need to send this */
1571 if (socket.ext_mapinfos)
1572 {
1573 if (!(sl.length () > startlen || socket.sent_scroll))
1574 {
1575 /* No map data will follow, so don't say the client
1576 * it doesn't need draw!
1577 */
1578 ewhatflag &= ~EMI_NOREDRAW;
1579 esl[ewhatstart + 1] = ewhatflag & 0xff;
1580 }
1581
1582 if (esl.length () > estartlen)
1583 socket.send_packet (esl);
1584 }
1585
1586 if (sl.length () > startlen || socket.sent_scroll)
1587 {
1588 socket.send_packet (sl);
1589 socket.sent_scroll = 0;
1590 }
1591}
1592
1593/**
1594 * Draws client map.
1595 */
1596void
1597draw_client_map (object *pl)
1598{
1599 int i, j;
1600 sint16 ax, ay; /* ax and ay goes from 0 to max-size of arrays */
1601 int mflags;
1602 struct Map newmap;
1603 maptile *m, *pm;
1604
1605 if (pl->type != PLAYER)
1606 {
1607 LOG (llevError, "draw_client_map called with non player/non eric-server\n");
1608 return;
1609 }
1610
1611 pm = pl->map;
1612 962
1613 /* If player is just joining the game, he isn't here yet, so the map 963 /* If player is just joining the game, he isn't here yet, so the map
1614 * can get swapped out. If so, don't try to send them a map. All will 964 * can get swapped out. If so, don't try to send them a map. All will
1615 * be OK once they really log in. 965 * be OK once they really log in.
1616 */ 966 */
1617 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 967 if (!ob->map || ob->map->in_memory != MAP_ACTIVE)
1618 return; 968 return;
1619 969
1620 memset (&newmap, 0, sizeof (struct Map)); 970 int startlen, oldlen;
1621 971
1622 for (j = (pl->y - pl->contr->ns->mapy / 2); j < (pl->y + (pl->contr->ns->mapy + 1) / 2); j++) 972 check_map_change (pl);
1623 for (i = (pl->x - pl->contr->ns->mapx / 2); i < (pl->x + (pl->contr->ns->mapx + 1) / 2); i++) 973 prefetch_surrounding_maps (pl->ob);
974
975 /* do LOS after calls to update_position */
976 /* unfortunately, we need to udpate los when observing, currently */
977 if (pl->do_los || pl->observe != pl->ob)
978 {
979 pl->do_los = 0;
980 pl->update_los ();
981 }
982
983 /**
984 * This function uses the new map1 protocol command to send the map
985 * to the client. It is necessary because the old map command supports
986 * a maximum map size of 15x15.
987 * This function is much simpler than the old one. This is because
988 * the old function optimized to send as few face identifiers as possible,
989 * at the expense of sending more coordinate location (coordinates were
990 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
991 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
992 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
993 * and use the other 4 bits for other informatiion. For full documentation
994 * of what we send, see the doc/Protocol file.
995 * I will describe internally what we do:
996 * the ns->lastmap shows how the map last looked when sent to the client.
997 * in the lastmap structure, there is a cells array, which is set to the
998 * maximum viewable size (As set in config.h).
999 * in the cells, there are faces and a count value.
1000 * we use the count value to hold the darkness value. If -1, then this space
1001 * is not viewable.
1002 * we use faces[0] faces[1] faces[2] to hold what the three layers
1003 * look like.
1004 */
1005
1006 client &socket = *pl->ns;
1007
1008 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1009
1010 startlen = sl.length ();
1011
1012 int hx = socket.mapx / 2;
1013 int hy = socket.mapy / 2;
1014
1015 ordered_mapwalk_begin (ob, -hx, -hy, hx, hy)
1016 int ax = dx + hx;
1017 int ay = dy + hy;
1018
1019 int mask = (ax << 10) | (ay << 4);
1020 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1021
1022 /* If the coordinates are not valid, or it is too dark to see,
1023 * we tell the client as such
1024 */
1025 if (!m)
1624 { 1026 {
1625 ax = i; 1027 /* space is out of map. Update space and clear values
1626 ay = j; 1028 * if this hasn't already been done. If the space is out
1627 m = pm; 1029 * of the map, it shouldn't have a head.
1628 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
1629
1630 if (mflags & P_OUT_OF_MAP)
1631 continue;
1632
1633 /* If a map is visible to the player, we don't want to swap it out
1634 * just to reload it. This should really call something like
1635 * swap_map, but this is much more efficient and 'good enough'
1636 */ 1030 */
1637 if (mflags & P_NEW_MAP) 1031 if (lastcell.count != -1)
1638 m->timeout = 50; 1032 {
1033 sl << uint16 (mask);
1034 map_clearcell (&lastcell, -1);
1035 }
1036
1037 continue;
1639 } 1038 }
1039
1040 int d = pl->blocked_los_uc (dx, dy);
1640 1041
1641 /* do LOS after calls to update_position */ 1042 if (d > 3)
1642 if (pl->contr->do_los)
1643 { 1043 {
1644 update_los (pl); 1044 /* This block deals with spaces that are not visible for whatever
1645 pl->contr->do_los = 0; 1045 * reason. Still may need to send the head for this space.
1046 */
1047 if (lastcell.count != -1
1048 || lastcell.faces[0]
1049 || lastcell.faces[1]
1050 || lastcell.faces[2]
1051 || lastcell.stat_hp
1052 || lastcell.flags
1053 || lastcell.player)
1054 sl << uint16 (mask);
1055
1056 /* properly clear a previously sent big face */
1057 map_clearcell (&lastcell, -1);
1646 } 1058 }
1059 else
1060 {
1061 /* In this block, the space is visible.
1062 */
1647 1063
1648 /* Big maps need a different drawing mechanism to work */ 1064 /* Rather than try to figure out what everything that we might
1649 draw_client_map1 (pl); 1065 * need to send is, then form the packet after that,
1650} 1066 * we presume that we will in fact form a packet, and update
1067 * the bits by what we do actually send. If we send nothing,
1068 * we just back out sl.length () to the old value, and no harm
1069 * is done.
1070 * I think this is simpler than doing a bunch of checks to see
1071 * what if anything we need to send, setting the bits, then
1072 * doing those checks again to add the real data.
1073 */
1074 oldlen = sl.length ();
1651 1075
1076 sl << uint16 (mask);
1077
1078 unsigned char dummy;
1079 unsigned char *last_ext = &dummy;
1080
1081 /* Darkness changed */
1082 if (lastcell.count != d)
1083 {
1084 mask |= 0x8;
1085
1086 if (socket.extmap)
1087 {
1088 *last_ext |= 0x80;
1089 last_ext = &sl[sl.length ()];
1090 sl << uint8 (d);
1091 }
1092 else
1093 sl << uint8 (255 - 64 * d);
1094 }
1095
1096 lastcell.count = d;
1097
1098 mapspace &ms = m->at (nx, ny);
1099 ms.update ();
1100
1101 if (expect_true (socket.extmap))
1102 {
1103 uint8 stat_hp = 0;
1104 uint8 stat_width = 0;
1105 uint8 flags = 0;
1106 tag_t player = 0;
1107
1108 // send hp information, if applicable
1109 if (object *op = ms.faces_obj [0])
1110 if (op->is_head () && !op->invisible)
1111 {
1112 if (op->stats.maxhp > op->stats.hp
1113 && op->stats.maxhp > 0
1114 && (op->type == PLAYER
1115 || op->type == DOOR // does not work, have maxhp 0
1116 || QUERY_FLAG (op, FLAG_MONSTER)
1117 || QUERY_FLAG (op, FLAG_ALIVE)
1118 || QUERY_FLAG (op, FLAG_GENERATOR)))
1119 {
1120 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1121 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1122 }
1123
1124 if (expect_false (op->has_dialogue ()))
1125 flags |= 1;
1126
1127 if (expect_false (op->type == PLAYER))
1128 player = op == ob ? pl->ob->count
1129 : op == pl->ob ? ob->count
1130 : op->count;
1131 }
1132
1133 if (expect_false (lastcell.stat_hp != stat_hp))
1134 {
1135 lastcell.stat_hp = stat_hp;
1136
1137 mask |= 0x8;
1138 *last_ext |= 0x80;
1139 last_ext = &sl[sl.length ()];
1140
1141 sl << uint8 (5) << uint8 (stat_hp);
1142
1143 if (stat_width > 1)
1144 {
1145 *last_ext |= 0x80;
1146 last_ext = &sl[sl.length ()];
1147
1148 sl << uint8 (6) << uint8 (stat_width);
1149 }
1150 }
1151
1152 if (expect_false (lastcell.player != player))
1153 {
1154 lastcell.player = player;
1155
1156 mask |= 0x8;
1157 *last_ext |= 0x80;
1158 last_ext = &sl[sl.length ()];
1159
1160 sl << uint8 (0x47) << uint8 (4) << (uint32)player;
1161 }
1162
1163 if (expect_false (lastcell.flags != flags))
1164 {
1165 lastcell.flags = flags;
1166
1167 mask |= 0x8;
1168 *last_ext |= 0x80;
1169 last_ext = &sl[sl.length ()];
1170
1171 sl << uint8 (8) << uint8 (flags);
1172 }
1173 }
1174
1175 /* Floor face */
1176 if (update_space (sl, socket, ms, lastcell, 2))
1177 mask |= 0x4;
1178
1179 /* Middle face */
1180 if (update_space (sl, socket, ms, lastcell, 1))
1181 mask |= 0x2;
1182
1183 if (expect_false (ob->invisible)
1184 && ob->invisible & (ob->invisible < 50 ? 1 : 7)
1185 && ms.player () == ob)
1186 {
1187 // force player to be visible to himself if invisible
1188 if (lastcell.faces[0] != ob->face)
1189 {
1190 lastcell.faces[0] = ob->face;
1191
1192 mask |= 0x1;
1193 sl << uint16 (ob->face);
1194
1195 socket.send_faces (ob);
1196 }
1197 }
1198 /* Top face */
1199 else if (update_space (sl, socket, ms, lastcell, 0))
1200 mask |= 0x1;
1201
1202 /* Check to see if we are in fact sending anything for this
1203 * space by checking the mask. If so, update the mask.
1204 * if not, reset the len to that from before adding the mask
1205 * value, so we don't send those bits.
1206 */
1207 if (mask & 0xf)
1208 sl[oldlen + 1] = mask & 0xff;
1209 else
1210 sl.reset (oldlen);
1211 } /* else this is a viewable space */
1212 ordered_mapwalk_end
1213
1214 socket.flush_fx ();
1215
1216 if (sl.length () > startlen || socket.sent_scroll)
1217 {
1218 socket.send_packet (sl);
1219 socket.sent_scroll = 0;
1220 }
1221}
1652 1222
1653/*****************************************************************************/ 1223/*****************************************************************************/
1654
1655/* GROS: The following one is used to allow a plugin to send a generic cmd to*/ 1224/* GROS: The following one is used to allow a plugin to send a generic cmd to*/
1656
1657/* a player. Of course, the client need to know the command to be able to */ 1225/* a player. Of course, the client need to know the command to be able to */
1658
1659/* manage it ! */ 1226/* manage it ! */
1660
1661/*****************************************************************************/ 1227/*****************************************************************************/
1662void 1228void
1663send_plugin_custom_message (object *pl, char *buf) 1229send_plugin_custom_message (object *pl, char *buf)
1664{ 1230{
1665 pl->contr->ns->send_packet (buf); 1231 pl->contr->ns->send_packet (buf);
1674{ 1240{
1675 packet sl; 1241 packet sl;
1676 sl << "replyinfo skill_info\n"; 1242 sl << "replyinfo skill_info\n";
1677 1243
1678 for (int i = 1; i < NUM_SKILLS; i++) 1244 for (int i = 1; i < NUM_SKILLS; i++)
1679 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1245 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names [i]);
1680 1246
1681 if (sl.length () >= MAXSOCKBUF) 1247 if (sl.length () > MAXSOCKBUF)
1682 { 1248 {
1683 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1249 LOG (llevError, "Buffer overflow in send_skill_info!\n");
1684 fatal (0); 1250 fatal (0);
1685 } 1251 }
1686 1252
1699 sl << "replyinfo spell_paths\n"; 1265 sl << "replyinfo spell_paths\n";
1700 1266
1701 for (int i = 0; i < NRSPELLPATHS; i++) 1267 for (int i = 0; i < NRSPELLPATHS; i++)
1702 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1268 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
1703 1269
1704 if (sl.length () >= MAXSOCKBUF) 1270 if (sl.length () > MAXSOCKBUF)
1705 { 1271 {
1706 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1272 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
1707 fatal (0); 1273 fatal (0);
1708 } 1274 }
1709 1275
1728 if (spell->type == SPELL) 1294 if (spell->type == SPELL)
1729 { 1295 {
1730 int flags = 0; 1296 int flags = 0;
1731 1297
1732 /* check if we need to update it */ 1298 /* check if we need to update it */
1733 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 1299 if (spell->cached_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
1734 { 1300 {
1735 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1301 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1736 flags |= UPD_SP_MANA; 1302 flags |= UPD_SP_MANA;
1737 } 1303 }
1738 1304
1739 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 1305 if (spell->cached_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
1740 { 1306 {
1741 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1307 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1742 flags |= UPD_SP_GRACE; 1308 flags |= UPD_SP_GRACE;
1743 } 1309 }
1744 1310
1745 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 1311 if (spell->cached_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
1746 { 1312 {
1747 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1313 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1748 flags |= UPD_SP_DAMAGE; 1314 flags |= UPD_SP_DAMAGE;
1749 } 1315 }
1750 1316
1751 if (flags) 1317 if (flags)
1752 { 1318 {
1754 1320
1755 sl << "updspell " 1321 sl << "updspell "
1756 << uint8 (flags) 1322 << uint8 (flags)
1757 << uint32 (spell->count); 1323 << uint32 (spell->count);
1758 1324
1759 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1325 if (flags & UPD_SP_MANA ) sl << uint16 (spell->cached_sp);
1760 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1326 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->cached_grace);
1761 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1327 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->cached_eat);
1762 1328
1763 pl->ns->send_packet (sl); 1329 pl->ns->send_packet (sl);
1764 } 1330 }
1765 } 1331 }
1766 } 1332 }
1796 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1362 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
1797 return; 1363 return;
1798 } 1364 }
1799 1365
1800 /* store costs and damage in the object struct, to compare to later */ 1366 /* store costs and damage in the object struct, to compare to later */
1801 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1367 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1802 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1368 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1803 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1369 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1804 1370
1805 /* figure out which skill it uses, if it uses one */ 1371 /* figure out which skill it uses, if it uses one */
1806 if (spell->skill) 1372 if (spell->skill)
1807 { 1373 if (object *tmp = pl->find_skill (spell->skill))
1808 for (i = 1; i < NUM_SKILLS; i++)
1809 if (!strcmp (spell->skill, skill_names[i]))
1810 {
1811 skill = i + CS_STAT_SKILLINFO; 1374 skill = tmp->subtype + CS_STAT_SKILLINFO;
1812 break;
1813 }
1814 }
1815 1375
1816 // spells better have a face 1376 // spells better have a face
1817 if (!spell->face) 1377 if (!spell->face)
1818 { 1378 {
1819 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name); 1379 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1820 spell->face = face_find ("burnout.x11", blank_face); 1380 spell->face = face_find ("burnout.x11", blank_face);
1821 } 1381 }
1382
1383 pl->ns->send_face (spell->face);
1822 1384
1823 /* send the current values */ 1385 /* send the current values */
1824 sl << uint32 (spell->count) 1386 sl << uint32 (spell->count)
1825 << uint16 (spell->level) 1387 << uint16 (spell->level)
1826 << uint16 (spell->casting_time) 1388 << uint16 (spell->casting_time)
1827 << uint16 (spell->last_sp) 1389 << uint16 (spell->cached_sp)
1828 << uint16 (spell->last_grace) 1390 << uint16 (spell->cached_grace)
1829 << uint16 (spell->last_eat) 1391 << uint16 (spell->cached_eat)
1830 << uint8 (skill) 1392 << uint8 (skill)
1831 << uint32 (spell->path_attuned) 1393 << uint32 (spell->path_attuned)
1832 << uint32 (spell->face) 1394 << uint32 (spell->face)
1833 << data8 (spell->name) 1395 << data8 (spell->name)
1834 << data16 (spell->msg); 1396 << data16 (spell->msg);
1862 * bytes and 3 strings (because that is the spec) so we need to 1424 * bytes and 3 strings (because that is the spec) so we need to
1863 * check that the length of those 3 strings, plus the 23 bytes, 1425 * check that the length of those 3 strings, plus the 23 bytes,
1864 * won't take us over the length limit for the socket, if it does, 1426 * won't take us over the length limit for the socket, if it does,
1865 * we need to send what we already have, and restart packet formation 1427 * we need to send what we already have, and restart packet formation
1866 */ 1428 */
1429 if (spell->type != SPELL)
1430 continue;
1431
1867 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1432 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
1868 * to show add_spell is 26 bytes + 2 strings. However, the overun 1433 * to show add_spell is 26 bytes + 2 strings. However, the overun
1869 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1434 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
1870 * like it will fix this 1435 * like it will fix this
1871 */ 1436 */
1872 if (spell->type != SPELL)
1873 continue;
1874
1875 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1437 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
1876 { 1438 {
1439 pl->ns->flush_fx ();
1877 pl->ns->send_packet (sl); 1440 pl->ns->send_packet (sl);
1878 1441
1879 sl.reset (); 1442 sl.reset ();
1880 sl << "addspell "; 1443 sl << "addspell ";
1881 } 1444 }
1889 return; 1452 return;
1890 } 1453 }
1891 else 1454 else
1892 append_spell (pl, sl, spell); 1455 append_spell (pl, sl, spell);
1893 1456
1894 if (sl.length () >= MAXSOCKBUF) 1457 if (sl.length () > MAXSOCKBUF)
1895 { 1458 {
1896 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1459 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
1897 fatal (0); 1460 fatal (0);
1898 } 1461 }
1899 1462
1900 /* finally, we can send the packet */ 1463 /* finally, we can send the packet */
1464 pl->ns->flush_fx ();
1901 pl->ns->send_packet (sl); 1465 pl->ns->send_packet (sl);
1902} 1466}
1903 1467

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines