ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.39 by root, Fri Dec 15 03:53:44 2006 UTC vs.
Revision 1.150 by root, Mon Oct 12 14:00:59 2009 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
8 it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
9 the Free Software Foundation; either version 2 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
10 (at your option) any later version. 11 * option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
18 along with this program; if not, write to the Free Software 19 * and the GNU General Public License along with this program. If not, see
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * <http://www.gnu.org/licenses/>.
20 21 *
21 The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22*/ 23 */
23 24
24/** 25/**
25 * \file 26 * \file
26 * Client handling. 27 * Client handling.
27 * 28 *
… …
35 * have the prototype of (char *data, int datalen, int client_num). This 36 * have the prototype of (char *data, int datalen, int client_num). This
36 * way, we can use one dispatch table. 37 * way, we can use one dispatch table.
37 * 38 *
38 * esrv_map_new starts updating the map 39 * esrv_map_new starts updating the map
39 * 40 *
40 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now.
42 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations
45 *
46 */ 41 */
47 42
48#include <global.h> 43#include <global.h>
49#include <sproto.h> 44#include <sproto.h>
50 45
51#include <newclient.h>
52#include <newserver.h>
53#include <living.h> 46#include <living.h>
54#include <commands.h> 47#include <commands.h>
55 48
56/* This block is basically taken from socket.c - I assume if it works there, 49/* This block is basically taken from socket.c - I assume if it works there,
57 * it should work here. 50 * it should work here.
… …
88 -1, /* life stealing */ 81 -1, /* life stealing */
89 -1 /* Disease - not fully done yet */ 82 -1 /* Disease - not fully done yet */
90}; 83};
91 84
92static void 85static void
93socket_map_scroll (client_socket * ns, int dx, int dy) 86socket_map_scroll (client *ns, int dx, int dy)
94{ 87{
95 struct Map newmap; 88 struct Map newmap;
96 int x, y, mx, my; 89 int x, y, mx, my;
97 90
98 {
99 packet sl;
100
101 sl.printf ("map_scroll %d %d", dx, dy); 91 ns->send_packet_printf ("map_scroll %d %d", dx, dy);
102 ns->send_packet (sl);
103 }
104 92
105 /* If we are using the Map1aCmd, we may in fact send 93 /* If we are using the Map1aCmd, we may in fact send
106 * head information that is outside the viewable map. 94 * head information that is outside the viewable map.
107 * So set the mx,my to the max value we want to 95 * So set the mx,my to the max value we want to
108 * look for. Removed code to do so - it caused extra 96 * look for. Removed code to do so - it caused extra
… …
110 * that much difference in bandwidth. 98 * that much difference in bandwidth.
111 */ 99 */
112 mx = ns->mapx; 100 mx = ns->mapx;
113 my = ns->mapy; 101 my = ns->mapy;
114 102
115 if (ns->mapmode == Map1aCmd)
116 {
117 mx += MAX_HEAD_OFFSET;
118 my += MAX_HEAD_OFFSET;
119 }
120
121 /* the x and y here are coordinates for the new map, i.e. if we moved 103 /* the x and y here are coordinates for the new map, i.e. if we moved
122 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 104 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
123 * if the destination x or y coordinate is outside the viewable 105 * if the destination x or y coordinate is outside the viewable
124 * area, we clear the values - otherwise, the old values 106 * area, we clear the values - otherwise, the old values
125 * are preserved, and the check_head thinks it needs to clear them. 107 * are preserved, and the check_head thinks it needs to clear them.
126 */ 108 */
127 for (x = 0; x < mx; x++) 109 for (x = 0; x < mx; x++)
128 {
129 for (y = 0; y < my; y++) 110 for (y = 0; y < my; y++)
130 {
131 if (x >= ns->mapx || y >= ns->mapy) 111 if (x >= ns->mapx || y >= ns->mapy)
132 /* clear cells outside the viewable area */ 112 /* clear cells outside the viewable area */
133 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell)); 113 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
134 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy) 114 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
135 /* clear newly visible tiles within the viewable area */ 115 /* clear newly visible tiles within the viewable area */
136 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell)); 116 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
137 else 117 else
138 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell)); 118 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
139 }
140 }
141 119
142 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map)); 120 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
143 121
144 /* Make sure that the next "map1" command will be sent (even if it is 122 /* Make sure that the next "map1" command will be sent (even if it is
145 * empty). 123 * empty).
… …
148} 126}
149 127
150static void 128static void
151clear_map (player *pl) 129clear_map (player *pl)
152{ 130{
153 client_socket &socket = *pl->socket; 131 pl->ns->mapinfo_queue_clear ();
154 132
155 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 133 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
156 134
135 pl->ns->force_newmap = false;
136
157 if (socket.newmapcmd == 1) 137 if (pl->ns->newmapcmd == 1)
158 socket.send_packet ("newmap"); 138 pl->ns->send_packet ("newmap");
159 139
160 socket.update_look = 1; 140 pl->ns->floorbox_reset ();
161 socket.look_position = 0;
162} 141}
163 142
143static void
144send_map_info (player *pl)
145{
146 client &socket = *pl->ns;
147 object *ob = pl->observe;
148
149 if (socket.mapinfocmd)
150 {
151 if (ob->map && ob->map->path[0])
152 {
153 int flags = 0;
154
155 if (ob->map->tile_path[0]) flags |= 1;
156 if (ob->map->tile_path[1]) flags |= 2;
157 if (ob->map->tile_path[2]) flags |= 4;
158 if (ob->map->tile_path[3]) flags |= 8;
159
160 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
161 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
162 ob->map->width, ob->map->height, &ob->map->path);
163 }
164 else
165 socket.send_packet ("mapinfo current");
166 }
167}
168
164/** check for map change and send new map data */ 169/** check for map/region change and send new map data */
165static void 170static void
166check_map_change (player *pl) 171check_map_change (player *pl)
167{ 172{
168 client_socket &socket = *pl->socket; 173 client &socket = *pl->ns;
169 object *ob = pl->ob; 174 object *ob = pl->observe;
170 char buf[MAX_BUF]; /* eauugggh */
171 175
172 if (socket.current_map != ob->map) 176 region *reg = ob->region ();
177 if (socket.current_region != reg)
178 {
179 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
180 socket.current_region = reg;
173 { 181 }
182
183 // first try to aovid a full newmap on tiled map scrolls
184 if (socket.current_map != ob->map && !socket.force_newmap)
185 {
186 rv_vector rv;
187
188 get_rangevector_from_mapcoord (socket.current_map, socket.current_x, socket.current_y, ob, &rv, 0);
189
190 // manhattan distance is very handy here
191 if (rv.distance < 8) // 8 works nicely for speed << 70 and buggy gcfclient
192 {
193 socket.current_map = ob->map;
194 socket.current_x = ob->x;
195 socket.current_y = ob->y;
196
197 socket_map_scroll (&socket, rv.distance_x, rv.distance_y);
198 socket.floorbox_reset ();
199 send_map_info (pl);
200 }
201 }
202
203 if (socket.current_map != ob->map || socket.force_newmap)
204 {
205 clear_map (pl);
174 socket.current_map = ob->map; 206 socket.current_map = ob->map;
207 send_map_info (pl);
208 }
209 else if (socket.current_x != ob->x || socket.current_y != ob->y)
210 {
211 int dx = ob->x - socket.current_x;
212 int dy = ob->y - socket.current_y;
175 213
176 clear_map (pl); 214 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
215 socket.floorbox_reset ();
216 }
177 217
178 if (socket.mapinfocmd) 218 socket.current_x = ob->x;
219 socket.current_y = ob->y;
220}
221
222/**
223 * RequestInfo is sort of a meta command. There is some specific
224 * request of information, but we call other functions to provide
225 * that information.
226 */
227void
228RequestInfo (char *buf, int len, client *ns)
229{
230 char *params;
231
232 /* find the first space, make it null, and update the
233 * params pointer.
234 */
235 for (params = buf; *params; params++)
236 if (*params == ' ')
237 {
238 *params++ = 0;
239 break;
240 }
241
242 if (!strcmp (buf, "image_info"))
243 send_image_info (ns, params);
244 else if (!strcmp (buf, "image_sums"))
245 send_image_sums (ns, params);
246 else if (!strcmp (buf, "skill_info"))
247 send_skill_info (ns, params);
248 else if (!strcmp (buf, "spell_paths"))
249 send_spell_paths (ns, params);
250 else
251 {
252 // undo tokenisation above and send replyinfo with the request unchanged
253 if (*params)
254 *--params = ' ';
255
256 ns->send_packet_printf ("replyinfo %s", buf);
257 }
258}
259
260void
261ExtCmd (char *buf, int len, player *pl)
262{
263 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
264}
265
266void
267ExtiCmd (char *buf, int len, client *ns)
268{
269 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
270}
271
272void
273client::mapinfo_queue_clear ()
274{
275 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
276 free (*i);
277
278 mapinfo_queue.clear ();
279}
280
281bool
282client::mapinfo_try (char *buf)
283{
284 char *token = buf;
285 buf += strlen (buf) + 9;
286
287 // initial map and its origin
288 maptile *map = pl->observe->map;
289 int mapx = pl->ns->mapx / 2 - pl->observe->x;
290 int mapy = pl->ns->mapy / 2 - pl->observe->y;
291 int max_distance = 8; // limit maximum path length to something generous
292
293 while (*buf && map && max_distance)
294 {
295 int dir = *buf++ - '1';
296
297 if (dir >= 0 && dir <= 3)
179 { 298 {
180 if (ob->map && ob->map->path[0]) 299 if (!map->tile_path [dir])
300 map = 0;
301 else if (map->tile_available (dir, false))
181 { 302 {
182 int flags = 0; 303 maptile *neigh = map->tile_map [dir];
183 304
184 if (ob->map->tile_path[0]) 305 switch (dir)
185 flags |= 1; 306 {
186 if (ob->map->tile_path[1]) 307 case 0: mapy -= neigh->height; break;
187 flags |= 2; 308 case 2: mapy += map ->height; break;
188 if (ob->map->tile_path[2]) 309 case 3: mapx -= neigh->width ; break;
189 flags |= 4; 310 case 1: mapx += map ->width ; break;
190 if (ob->map->tile_path[3]) 311 }
191 flags |= 8;
192 312
193 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s", 313 map = neigh;
194 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 314 --max_distance;
195 } 315 }
196 else 316 else
197 snprintf (buf, MAX_BUF, "mapinfo current"); 317 return 0;
198
199 socket.send_packet (buf);
200 } 318 }
201 }
202 else if (socket.current_x != ob->x || socket.current_y != ob->y)
203 {
204 int dx = ob->x - socket.current_x;
205 int dy = ob->y - socket.current_y;
206
207 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
208 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
209 else 319 else
320 max_distance = 0;
321 }
322
323 if (!max_distance)
324 send_packet_printf ("mapinfo %s error", token);
325 else if (!map || !map->path)
326 send_packet_printf ("mapinfo %s nomap", token);
327 else
328 {
329 int flags = 0;
330
331 if (map->tile_path[0]) flags |= 1;
332 if (map->tile_path[1]) flags |= 2;
333 if (map->tile_path[2]) flags |= 4;
334 if (map->tile_path[3]) flags |= 8;
335
336 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
337 }
338
339 return 1;
340}
341
342void
343client::mapinfo_queue_run ()
344{
345 if (mapinfo_queue.empty () || !pl)
346 return;
347
348 for (int i = 0; i < mapinfo_queue.size (); ++i)
349 if (mapinfo_try (mapinfo_queue [i]))
210 { 350 {
211 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 351 free (mapinfo_queue [i]);
212 socket.update_look = 1; 352 mapinfo_queue.erase (i);
213 socket.look_position = 0;
214 } 353 }
215 } 354 else
216 355 ++i;
217 socket.current_x = ob->x;
218 socket.current_y = ob->y;
219}
220
221void
222ExtCmd (char *buf, int len, player *pl)
223{
224 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
225} 356}
226 357
227void 358void
228MapInfoCmd (char *buf, int len, player *pl) 359MapInfoCmd (char *buf, int len, player *pl)
229{ 360{
230 // <mapinfo tag spatial tile-path 361 // <mapinfo tag spatial tile-path
231 // >mapinfo tag spatial flags x y w h hash 362 // >mapinfo tag spatial flags x y w h hash
232 363
233 char bigbuf[MAX_BUF], *token;
234
235 token = buf; 364 char *token = buf;
236 // copy token 365
237 if (!(buf = strchr (buf, ' '))) 366 if (!(buf = strchr (buf, ' ')))
238 return; 367 return;
239 368
240 *buf++ = 0;
241
242 if (!strncmp (buf, "spatial ", 8)) 369 if (!strncmp (buf, " spatial ", 9))
243 { 370 {
244 buf += 8; 371 char *copy = strdup (token);
372 copy [buf - token] = 0;
245 373
246 // initial map and its origin 374#if 0
247 maptile *map = pl->ob->map; 375 // this makes only sense when we flush the buffer immediately
248 sint16 dx, dy; 376 if (pl->ns->mapinfo_try (copy))
249 int mapx = pl->socket->mapx / 2 - pl->ob->x; 377 free (copy);
250 int mapy = pl->socket->mapy / 2 - pl->ob->y;
251 int max_distance = 8; // limit maximum path length to something generous
252
253 while (*buf && map && max_distance)
254 {
255 int dir = *buf++;
256
257 switch (dir)
258 {
259 case '1':
260 dx = 0;
261 dy = -1;
262 map = get_map_from_coord (map, &dx, &dy);
263 map && (mapy -= map->height);
264 break;
265 case '2':
266 mapx += map->width;
267 dx = map->width;
268 dy = 0;
269 map = get_map_from_coord (map, &dx, &dy);
270 break;
271 case '3':
272 mapy += map->height;
273 dx = 0;
274 dy = map->height;
275 map = get_map_from_coord (map, &dx, &dy);
276 break;
277 case '4':
278 dx = -1;
279 dy = 0;
280 map = get_map_from_coord (map, &dx, &dy);
281 map && (mapx -= map->width);
282 break;
283 }
284
285 --max_distance;
286 }
287
288 if (!max_distance)
289 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
290 else if (map && map->path[0])
291 {
292 int flags = 0;
293
294 if (map->tile_path[0])
295 flags |= 1;
296 if (map->tile_path[1])
297 flags |= 2;
298 if (map->tile_path[2])
299 flags |= 4;
300 if (map->tile_path[3])
301 flags |= 8;
302
303 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, map->path);
304 }
305 else 378 else
306 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 379#endif
380 pl->ns->mapinfo_queue.push_back (copy);
307 } 381 }
308 else 382 else
309 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 383 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
310
311 pl->socket->send_packet (bigbuf);
312} 384}
313 385
314/** This is the Setup cmd - easy first implementation */ 386/** This is the Setup cmd */
315void 387void
316SetUp (char *buf, int len, client_socket * ns) 388SetUp (char *buf, int len, client * ns)
317{ 389{
318 int s, slen; 390 INVOKE_CLIENT (SETUP, ns, ARG_DATA (buf, len));
319 char *cmd, *param, cmdback[HUGE_BUF];
320
321 /* run through the cmds of setup
322 * syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
323 *
324 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
325 * The client then must sort this out
326 */
327
328 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
329
330 strcpy (cmdback, "setup");
331 for (s = 0; s < len; )
332 {
333 cmd = &buf[s];
334
335 /* find the next space, and put a null there */
336 for (; buf[s] && buf[s] != ' '; s++)
337 ;
338
339 buf[s++] = 0;
340
341 while (buf[s] == ' ')
342 s++;
343
344 if (s >= len)
345 break;
346
347 param = &buf[s];
348
349 for (; buf[s] && buf[s] != ' '; s++)
350 ;
351
352 buf[s++] = 0;
353
354 while (buf[s] == ' ')
355 s++;
356
357 slen = strlen (cmdback);
358 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
359 safe_strcat (cmdback, cmd, &slen, HUGE_BUF);
360 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
361
362 if (!strcmp (cmd, "sound"))
363 {
364 ns->sound = atoi (param);
365 safe_strcat (cmdback, param, &slen, HUGE_BUF);
366 }
367 else if (!strcmp (cmd, "exp64"))
368 {
369 ns->exp64 = atoi (param);
370 safe_strcat (cmdback, param, &slen, HUGE_BUF);
371 }
372 else if (!strcmp (cmd, "spellmon"))
373 {
374 ns->monitor_spells = atoi (param);
375 safe_strcat (cmdback, param, &slen, HUGE_BUF);
376 }
377 else if (!strcmp (cmd, "darkness"))
378 {
379 ns->darkness = atoi (param);
380 safe_strcat (cmdback, param, &slen, HUGE_BUF);
381 }
382 else if (!strcmp (cmd, "map1cmd"))
383 {
384 if (atoi (param))
385 ns->mapmode = Map1Cmd;
386 /* if beyond this size, need to use map1cmd no matter what */
387 if (ns->mapx > 11 || ns->mapy > 11)
388 ns->mapmode = Map1Cmd;
389 safe_strcat (cmdback, ns->mapmode == Map1Cmd ? "1" : "0", &slen, HUGE_BUF);
390 }
391 else if (!strcmp (cmd, "map1acmd"))
392 {
393 if (atoi (param))
394 ns->mapmode = Map1aCmd;
395 /* if beyond this size, need to use map1acmd no matter what */
396 if (ns->mapx > 11 || ns->mapy > 11)
397 ns->mapmode = Map1aCmd;
398 safe_strcat (cmdback, ns->mapmode == Map1aCmd ? "1" : "0", &slen, HUGE_BUF);
399 }
400 else if (!strcmp (cmd, "newmapcmd"))
401 {
402 ns->newmapcmd = atoi (param);
403 safe_strcat (cmdback, param, &slen, HUGE_BUF);
404// } else if (!strcmp(cmd,"plugincmd")) {
405// ns->plugincmd = atoi(param);
406// safe_strcat(cmdback, param, &slen, HUGE_BUF);
407 }
408 else if (!strcmp (cmd, "mapinfocmd"))
409 {
410 ns->mapinfocmd = atoi (param);
411 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
412 }
413 else if (!strcmp (cmd, "extcmd"))
414 {
415 ns->extcmd = atoi (param);
416 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
417 }
418 else if (!strcmp (cmd, "extmap"))
419 {
420 ns->extmap = atoi (param);
421 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
422 }
423 else if (!strcmp (cmd, "facecache"))
424 {
425 ns->facecache = atoi (param);
426 safe_strcat (cmdback, param, &slen, HUGE_BUF);
427 }
428 else if (!strcmp (cmd, "faceset"))
429 {
430 char tmpbuf[20];
431 int q = atoi (param);
432
433 if (is_valid_faceset (q))
434 ns->faceset = q;
435 sprintf (tmpbuf, "%d", ns->faceset);
436 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
437 /* if the client is using faceset, it knows about image2 command */
438 ns->image2 = 1;
439 }
440 else if (!strcmp (cmd, "itemcmd"))
441 {
442 /* Version of the item protocol command to use. Currently,
443 * only supported versions are 1 and 2. Using a numeric
444 * value will make it very easy to extend this in the future.
445 */
446 char tmpbuf[20];
447 int q = atoi (param);
448
449 if (q < 1 || q > 2)
450 {
451 strcpy (tmpbuf, "FALSE");
452 }
453 else
454 {
455 ns->itemcmd = q;
456 sprintf (tmpbuf, "%d", ns->itemcmd);
457 }
458 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
459 }
460 else if (!strcmp (cmd, "mapsize"))
461 {
462 int x, y = 0;
463 char tmpbuf[MAX_BUF], *cp;
464
465 x = atoi (param);
466 for (cp = param; *cp != 0; cp++)
467 if (*cp == 'x' || *cp == 'X')
468 {
469 y = atoi (cp + 1);
470 break;
471 }
472 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
473 {
474 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
475 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
476 }
477 else
478 {
479 ns->mapx = x;
480 ns->mapy = y;
481 /* better to send back what we are really using and not the
482 * param as given to us in case it gets parsed differently.
483 */
484 sprintf (tmpbuf, "%dx%d", x, y);
485 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
486 /* If beyond this size and still using orig map command, need to
487 * go to map1cmd.
488 */
489 if ((x > 11 || y > 11) && ns->mapmode == Map0Cmd)
490 ns->mapmode = Map1Cmd;
491 }
492 }
493 else if (!strcmp (cmd, "extendedMapInfos"))
494 {
495 /* Added by tchize
496 * prepare to use the mapextended command
497 */
498 char tmpbuf[20];
499
500 ns->ext_mapinfos = (atoi (param));
501 sprintf (tmpbuf, "%d", ns->ext_mapinfos);
502 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
503 }
504 else if (!strcmp (cmd, "extendedTextInfos"))
505 {
506 /* Added by tchize
507 * prepare to use the extended text commands
508 * Client toggle this to non zero to get exttext
509 */
510 char tmpbuf[20];
511
512 ns->has_readable_type = (atoi (param));
513 sprintf (tmpbuf, "%d", ns->has_readable_type);
514 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
515 }
516 else
517 {
518 /* Didn't get a setup command we understood -
519 * report a failure to the client.
520 */
521 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
522 }
523 } /* for processing all the setup commands */
524
525 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
526 ns->send_packet (cmdback);
527} 391}
528 392
529/** 393/**
530 * The client has requested to be added to the game. 394 * The client has requested to be added to the game.
531 * This is what takes care of it. We tell the client how things worked out. 395 * This is what takes care of it. We tell the client how things worked out.
532 * I am not sure if this file is the best place for this function. however, 396 * I am not sure if this file is the best place for this function. however,
533 * it either has to be here or init_sockets needs to be exported. 397 * it either has to be here or init_sockets needs to be exported.
534 */ 398 */
535void 399void
536AddMeCmd (char *buf, int len, client_socket * ns) 400AddMeCmd (char *buf, int len, client *ns)
537{ 401{
538 Settings oldsettings; 402 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
539
540 oldsettings = settings;
541 if (ns->status != Ns_Add || add_player (ns))
542 ns->send_packet ("addme_failed");
543 else
544 ns->send_packet ("addme_success");
545
546 settings = oldsettings;
547}
548
549/** Reply to ExtendedInfos command */
550void
551ToggleExtendedInfos (char *buf, int len, client_socket * ns)
552{
553 char cmdback[MAX_BUF];
554 char command[50];
555 int info, nextinfo;
556
557 cmdback[0] = '\0';
558 nextinfo = 0;
559
560 while (1)
561 {
562 /* 1. Extract an info */
563 info = nextinfo;
564
565 while ((info < len) && (buf[info] == ' '))
566 info++;
567
568 if (info >= len)
569 break;
570
571 nextinfo = info + 1;
572
573 while ((nextinfo < len) && (buf[nextinfo] != ' '))
574 nextinfo++;
575
576 if (nextinfo - info >= 49) /*Erroneous info asked */
577 continue;
578
579 strncpy (command, &(buf[info]), nextinfo - info);
580
581 /* 2. Interpret info */
582 if (!strcmp ("smooth", command))
583 /* Toggle smoothing */
584 ns->EMI_smooth = !ns->EMI_smooth;
585 else
586 /*bad value */;
587
588 /*3. Next info */
589 }
590
591 strcpy (cmdback, "ExtendedInfoSet");
592
593 if (ns->EMI_smooth)
594 {
595 strcat (cmdback, " ");
596 strcat (cmdback, "smoothing");
597 }
598
599 ns->send_packet (cmdback);
600} 403}
601 404
602/* 405/*
603#define MSG_TYPE_BOOK 1 406#define MSG_TYPE_BOOK 1
604#define MSG_TYPE_CARD 2 407#define MSG_TYPE_CARD 2
… …
607#define MSG_TYPE_MONUMENT 5 410#define MSG_TYPE_MONUMENT 5
608#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 411#define MSG_TYPE_SCRIPTED_DIALOG 6*/
609 412
610/** Reply to ExtendedInfos command */ 413/** Reply to ExtendedInfos command */
611void 414void
612ToggleExtendedText (char *buf, int len, client_socket * ns) 415ToggleExtendedText (char *buf, int len, client * ns)
613{ 416{
614 char cmdback[MAX_BUF]; 417 char cmdback[MAX_BUF];
615 char temp[10]; 418 char temp[10];
616 char command[50]; 419 char command[50];
617 int info, nextinfo, i, flag; 420 int info, nextinfo, i, flag;
… …
661 464
662 ns->send_packet (cmdback); 465 ns->send_packet (cmdback);
663} 466}
664 467
665/** 468/**
666 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
667 * Basically, it makes no sense to wait for the client to request a
668 * a piece of data from us that we know the client wants. So
669 * if we know the client wants it, might as well push it to the
670 * client.
671 */
672static void
673SendSmooth (client_socket * ns, uint16 face)
674{
675 uint16 smoothface;
676
677 /* If we can't find a face, return and set it so we won't try to send this
678 * again.
679 */
680 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
681 {
682
683 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name);
684 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
685 return;
686 }
687
688 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
689 esrv_send_face (ns, smoothface, 0);
690
691 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
692
693 packet sl;
694
695 sl << "smooth "
696 << uint16 (face)
697 << uint16 (smoothface);
698
699 ns->send_packet (sl);
700}
701
702 /**
703 * Tells client the picture it has to use
704 * to smooth a picture number given as argument.
705 */
706void
707AskSmooth (char *buf, int len, client_socket * ns)
708{
709 uint16 facenbr;
710
711 facenbr = atoi (buf);
712 SendSmooth (ns, facenbr);
713}
714
715/**
716 * This handles the general commands from the client (ie, north, fire, cast, 469 * This handles the general commands from the client (ie, north, fire, cast,
717 * etc.) 470 * etc.)
718 */ 471 */
719void 472void
720PlayerCmd (char *buf, int len, player *pl) 473PlayerCmd (char *buf, int len, player *pl)
721{ 474{
722
723 /* The following should never happen with a proper or honest client.
724 * Therefore, the error message doesn't have to be too clear - if
725 * someone is playing with a hacked/non working client, this gives them
726 * an idea of the problem, but they deserve what they get
727 */
728 if (pl->state != ST_PLAYING)
729 {
730 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
731 return;
732 }
733 /* Check if there is a count. In theory, a zero count could also be 475 /* Check if there is a count. In theory, a zero count could also be
734 * sent, so check for that also. 476 * sent, so check for that also.
735 */ 477 */
736 if (atoi (buf) || buf[0] == '0') 478 if (atoi (buf) || buf[0] == '0')
737 { 479 {
738 pl->count = atoi ((char *) buf); 480 pl->count = atoi ((char *) buf);
481
739 buf = strchr (buf, ' '); /* advance beyond the numbers */ 482 buf = strchr (buf, ' '); /* advance beyond the numbers */
740 if (!buf) 483 if (!buf)
741 {
742#ifdef ESRV_DEBUG
743 LOG (llevDebug, "PlayerCmd: Got count but no command.\n");
744#endif
745 return; 484 return;
746 } 485
747 buf++; 486 buf++;
748 } 487 }
749 /* This should not happen anymore. */ 488
750 if (pl->ob->speed_left < -1.0)
751 {
752 LOG (llevError, "Player has negative time - shouldn't do command.\n");
753 }
754 /* In c_new.c */
755 execute_newserver_command (pl->ob, (char *) buf); 489 execute_newserver_command (pl->ob, (char *) buf);
756 /* Perhaps something better should be done with a left over count.
757 * Cleaning up the input should probably be done first - all actions
758 * for the command that issued the count should be done before any other
759 * commands.
760 */
761 490
762 pl->count = 0;
763
764}
765
766
767/**
768 * This handles the general commands from the client (ie, north, fire, cast,
769 * etc.). It is a lot like PlayerCmd above, but is called with the
770 * 'ncom' method which gives more information back to the client so it
771 * can throttle.
772 */
773void
774NewPlayerCmd (char *buf, int len, player *pl)
775{
776 int time, repeat;
777 char command[MAX_BUF];
778 int pktlen;
779
780 if (len < 7)
781 {
782 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
783 return;
784 }
785
786 pktlen = net_uint16 ((uint8 *)buf);
787 repeat = net_uint32 ((uint8 *)buf + 2);
788
789 /* -1 is special - no repeat, but don't update */
790 if (repeat != -1)
791 pl->count = repeat;
792
793 if ((len - 4) >= MAX_BUF)
794 len = MAX_BUF - 5;
795
796 strncpy ((char *) command, (char *) buf + 6, len - 4);
797 command[len - 4] = 0;
798
799 /* This should not happen anymore. */
800 if (pl->ob->speed_left < -1.0)
801 LOG (llevError, "Player has negative time - shouldn't do command.\n");
802
803 /* In c_new.c */
804 execute_newserver_command (pl->ob, (char *) command);
805 /* Perhaps something better should be done with a left over count. 491 /* Perhaps something better should be done with a left over count.
806 * Cleaning up the input should probably be done first - all actions 492 * Cleaning up the input should probably be done first - all actions
807 * for the command that issued the count should be done before any other 493 * for the command that issued the count should be done before any other
808 * commands. 494 * commands.
809 */ 495 */
810 pl->count = 0; 496 pl->count = 0;
497}
811 498
812 if (FABS (pl->ob->speed) < 0.001) 499/**
500 * This handles the general commands from the client (ie, north, fire, cast,
501 * etc.). It is a lot like PlayerCmd above, but is called with the
502 * 'ncom' method which gives more information back to the client so it
503 * can throttle.
504 */
505void
506NewPlayerCmd (char *buf, int len, player *pl)
507{
508 if (len <= 6)
509 {
510 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
511 return;
512 }
513
514 uint16 cmdid = net_uint16 ((uint8 *)buf);
515 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
516
517 /* -1 is special - no repeat, but don't update */
518 if (repeat != -1)
519 pl->count = repeat;
520
521 buf += 6; //len -= 6;
522
523 execute_newserver_command (pl->ob, buf);
524
525 /* Perhaps something better should be done with a left over count.
526 * Cleaning up the input should probably be done first - all actions
527 * for the command that issued the count should be done before any other
528 * commands.
529 */
530 pl->count = 0;
531
532 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
533 int time = fabs (pl->ob->speed) < 0.001
813 time = MAX_TIME * 100; 534 ? time = MAX_TIME * 100
814 else
815 time = (int) (MAX_TIME / FABS (pl->ob->speed)); 535 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
816 536
817 /* Send confirmation of command execution now */ 537 /* Send confirmation of command execution now */
818 538 packet sl ("comc");
819 packet sl;
820 sl << "comc " << uint16 (pktlen) << uint32 (time); 539 sl << uint16 (cmdid) << uint32 (time);
821 pl->socket->send_packet (sl); 540 pl->ns->send_packet (sl);
822} 541}
823
824 542
825/** This is a reply to a previous query. */ 543/** This is a reply to a previous query. */
826void 544void
827ReplyCmd (char *buf, int len, player *pl) 545ReplyCmd (char *buf, int len, client *ns)
828{ 546{
547 if (ns->state == ST_CUSTOM)
548 {
549 INVOKE_CLIENT (REPLY, ns, ARG_DATA (buf, len));
550 return;
551 }
552
553 if (!ns->pl)
554 return; //TODO: depends on the exact reply we are after
555 //TODO: but right now, we always have a ns->pl
556
557 player *pl = ns->pl;
558
829 /* This is to synthesize how the data would be stored if it 559 /* This is to synthesize how the data would be stored if it
830 * was normally entered. A bit of a hack, and should be cleaned up 560 * was normally entered. A bit of a hack, and should be cleaned up
831 * once all the X11 code is removed from the server. 561 * once all the X11 code is removed from the server.
832 * 562 *
833 * We pass 13 to many of the functions because this way they 563 * We pass 13 to many of the functions because this way they
834 * think it was the carriage return that was entered, and the 564 * think it was the carriage return that was entered, and the
835 * function then does not try to do additional input. 565 * function then does not try to do additional input.
836 */ 566 */
837 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf); 567 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
838 568
839 /* this avoids any hacking here */ 569 /* this avoids any hacking here */
840 570
841 switch (pl->state) 571 switch (ns->state)
842 { 572 {
843 case ST_PLAYING: 573 case ST_PLAYING:
844 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 574 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
845 break; 575 break;
846 576
847 case ST_PLAY_AGAIN:
848 /* We can check this for return value (2==quit). Maybe we
849 * should, and do something appropriate?
850 */
851 receive_play_again (pl->ob, buf[0]);
852 break;
853
854 case ST_ROLL_STAT:
855 key_roll_stat (pl->ob, buf[0]);
856 break;
857
858 case ST_CHANGE_CLASS:
859
860 key_change_class (pl->ob, buf[0]);
861 break;
862
863 case ST_CONFIRM_QUIT:
864 key_confirm_quit (pl->ob, buf[0]);
865 break;
866
867 case ST_CONFIGURE:
868 LOG (llevError, "In client input handling, but into configure state\n");
869 pl->state = ST_PLAYING;
870 break;
871
872 case ST_GET_NAME:
873 receive_player_name (pl->ob, 13);
874 break;
875
876 case ST_GET_PASSWORD:
877 case ST_CONFIRM_PASSWORD:
878 receive_player_password (pl->ob, 13);
879 break;
880
881 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 577 case ST_GET_PARTY_PASSWORD: /* Get password for party */
882 receive_party_password (pl->ob, 13); 578 receive_party_password (pl->ob, 13);
883 break; 579 break;
884 580
885 default: 581 default:
886 LOG (llevError, "Unknown input state: %d\n", pl->state); 582 LOG (llevError, "Unknown input state: %d\n", ns->state);
887 } 583 }
888} 584}
889 585
890/** 586/**
891 * Client tells its version. If there is a mismatch, we close the 587 * Client tells its version. If there is a mismatch, we close the
… …
893 * something older than the server. If we assume the client will be 589 * something older than the server. If we assume the client will be
894 * backwards compatible, having it be a later version should not be a 590 * backwards compatible, having it be a later version should not be a
895 * problem. 591 * problem.
896 */ 592 */
897void 593void
898VersionCmd (char *buf, int len, client_socket * ns) 594VersionCmd (char *buf, int len, client * ns)
899{ 595{
900 char *cp;
901 char version_warning[256];
902
903 if (!buf) 596 if (!buf)
904 { 597 {
905 LOG (llevError, "CS: received corrupted version command\n"); 598 LOG (llevError, "CS: received corrupted version command\n");
906 return; 599 return;
907 } 600 }
908 601
909 ns->cs_version = atoi (buf); 602 ns->cs_version = atoi (buf);
910 ns->sc_version = ns->cs_version; 603 ns->sc_version = ns->cs_version;
604
605 LOG (llevDebug, "connection from client <%s>\n", buf);
606
607 //TODO: should log here just for statistics
608
911 if (VERSION_CS != ns->cs_version) 609 //if (VERSION_CS != ns->cs_version)
912 { 610 // unchecked;
913#ifdef ESRV_DEBUG 611
914 LOG (llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS, ns->cs_version);
915#endif
916 }
917 cp = strchr (buf + 1, ' '); 612 char *cp = strchr (buf + 1, ' ');
918 if (!cp) 613 if (!cp)
919 return; 614 return;
615
920 ns->sc_version = atoi (cp); 616 ns->sc_version = atoi (cp);
617
921 if (VERSION_SC != ns->sc_version) 618 //if (VERSION_SC != ns->sc_version)
922 { 619 // unchecked;
923#ifdef ESRV_DEBUG 620
924 LOG (llevDebug, "CS: scversion mismatch (%d,%d)\n", VERSION_SC, ns->sc_version);
925#endif
926 }
927 cp = strchr (cp + 1, ' '); 621 cp = strchr (cp + 1, ' ');
622
928 if (cp) 623 if (cp)
929 { 624 {
930 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host); 625 ns->version = cp + 1;
931 626
932 snprintf (ns->client, sizeof (ns->client), "%s", cp + 1);
933
934 /* This is first implementation - i skip all beta DX clients with it
935 * Add later stuff here for other clients
936 */
937
938 /* these are old dxclients */
939 /* Version 1024 added support for singular + plural name values -
940 * requiing this minimal value reduces complexity of that code, and it
941 * has been around for a long time.
942 */
943 if (ns->sc_version < 1026) 627 if (ns->sc_version < 1026)
944 { 628 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
945 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
946 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 629 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
947 ns->send_packet (version_warning);
948 }
949
950 } 630 }
951} 631}
952 632
953/** sound related functions. */ 633/** sound related functions. */
954
955void 634void
956SetSound (char *buf, int len, client_socket * ns) 635SetSound (char *buf, int len, client * ns)
957{ 636{
958 ns->sound = atoi (buf); 637 ns->sound = atoi (buf);
959} 638}
960 639
961/** client wants the map resent */ 640/** client wants the map resent */
962
963void 641void
964MapRedrawCmd (char *buf, int len, player *pl) 642MapRedrawCmd (char *buf, int len, player *pl)
965{ 643{
966
967/* This function is currently disabled; just clearing the map state results in 644/* This function is currently disabled; just clearing the map state results in
968 * display errors. It should clear the cache and send a newmap command. 645 * display errors. It should clear the cache and send a newmap command.
969 * Unfortunately this solution does not work because some client versions send 646 * Unfortunately this solution does not work because some client versions send
970 * a mapredraw command after receiving a newmap command. 647 * a mapredraw command after receiving a newmap command.
971 */ 648 */
972#if 0
973 /* Okay, this is MAJOR UGLY. but the only way I know how to
974 * clear the "cache"
975 */
976 memset (&pl->socket->lastmap, 0, sizeof (struct Map));
977 draw_client_map (pl->ob);
978#endif
979} 649}
980 650
981/** 651/**
982 * Moves an object (typically, container to inventory). 652 * Moves an object (typically, container to inventory).
983 * syntax is: move (to) (tag) (nrof) 653 * syntax is: move (to) (tag) (nrof)
984 */ 654 */
985void 655void
986MoveCmd (char *buf, int len, player *pl) 656MoveCmd (char *buf, int len, player *pl)
987{ 657{
988 int vals[3], i; 658 int to, tag, nrof;
989 659
990 /* A little funky here. We only cycle for 2 records, because 660 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
991 * we obviously am not going to find a space after the third
992 * record. Perhaps we should just replace this with a
993 * sscanf?
994 */
995 for (i = 0; i < 2; i++)
996 { 661 {
997 vals[i] = atoi (buf);
998 if (!(buf = strchr (buf, ' ')))
999 {
1000 LOG (llevError, "Incomplete move command: %s\n", buf); 662 LOG (llevError, "Incomplete move command: %s\n", buf);
1001 return; 663 return;
1002 }
1003 buf++;
1004 } 664 }
1005 vals[2] = atoi (buf);
1006 665
1007/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/ 666 esrv_move_object (pl->ob, to, tag, nrof);
1008 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
1009} 667}
1010
1011
1012 668
1013/****************************************************************************** 669/******************************************************************************
1014 * 670 *
1015 * Start of commands the server sends to the client. 671 * Start of commands the server sends to the client.
1016 * 672 *
… …
1019/** 675/**
1020 * Asks the client to query the user. This way, the client knows 676 * Asks the client to query the user. This way, the client knows
1021 * it needs to send something back (vs just printing out a message) 677 * it needs to send something back (vs just printing out a message)
1022 */ 678 */
1023void 679void
1024send_query (client_socket * ns, uint8 flags, char *text) 680send_query (client *ns, uint8 flags, const char *text)
1025{ 681{
1026 char buf[MAX_BUF];
1027
1028 sprintf (buf, "query %d %s", flags, text ? text : ""); 682 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
1029 ns->send_packet (buf); 683}
684
685/**
686 * Get player's current range attack in obuf.
687 */
688static void
689rangetostring (player *pl, char *obuf)
690{
691 dynbuf_text &buf = msg_dynbuf; buf.clear ();
692
693 if (pl->ranged_ob)
694 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name;
695
696 if (pl->combat_ob)
697 buf << " Combat" << (pl->ob->current_weapon == pl->combat_ob ? "*" : "") << ": " << pl->combat_ob->name;
698
699#if 0
700 //TODO: remove this when slot system is working, this is only for debugging
701 if (pl->ob->chosen_skill)
702 buf << " Skill*: " << pl->ob->chosen_skill->name;
703#endif
704
705 //TODO: maybe golem should become the current_weapon, quite simply?
706 if (pl->golem)
707 buf << " Golem*: " << pl->golem->name;
708
709 buf << '\0';
710 buf.linearise (obuf);
1030} 711}
1031 712
1032#define AddIfInt64(Old,New,Type) if (Old != New) {\ 713#define AddIfInt64(Old,New,Type) if (Old != New) {\
1033 Old = New; \ 714 Old = New; \
1034 sl << uint8 (Type) << uint64 (New); \ 715 sl << uint8 (Type) << uint64 (New); \
… …
1042#define AddIfShort(Old,New,Type) if (Old != New) {\ 723#define AddIfShort(Old,New,Type) if (Old != New) {\
1043 Old = New; \ 724 Old = New; \
1044 sl << uint8 (Type) << uint16 (New); \ 725 sl << uint8 (Type) << uint16 (New); \
1045 } 726 }
1046 727
1047#define AddIfFloat(Old,New,Type) if (Old != New) {\ 728#define AddIfFloat(Old,New,Type,mult) if (Old != New) {\
1048 Old = New; \ 729 Old = New; \
1049 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \ 730 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI*mult); \
1050 } 731 }
1051 732
1052#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 733#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1053 free(Old); Old = strdup (New);\ 734 free(Old); Old = strdup (New);\
1054 sl << uint8 (Type) << data8 (New); \ 735 sl << uint8 (Type) << data8 (New); \
… …
1064esrv_update_stats (player *pl) 745esrv_update_stats (player *pl)
1065{ 746{
1066 char buf[MAX_BUF]; 747 char buf[MAX_BUF];
1067 uint16 flags; 748 uint16 flags;
1068 749
1069 packet sl; 750 client *ns = pl->ns;
1070 sl << "stats "; 751 if (!ns)
752 return;
1071 753
1072 if (pl->ob != NULL) 754 object *ob = pl->observe;
1073 { 755 if (!ob)
756 return;
757
758 player *opl = ob->contr ? static_cast<player *>(ob->contr) : pl;
759
760 packet sl ("stats");
761
1074 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 762 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1075 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 763 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1076 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 764 AddIfShort (ns->last_stats.sp, ob->stats.sp, CS_STAT_SP);
1077 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 765 AddIfShort (ns->last_stats.maxsp, ob->stats.maxsp, CS_STAT_MAXSP);
1078 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 766 AddIfShort (ns->last_stats.grace, ob->stats.grace, CS_STAT_GRACE);
1079 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 767 AddIfShort (ns->last_stats.maxgrace, ob->stats.maxgrace, CS_STAT_MAXGRACE);
1080 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 768 AddIfShort (ns->last_stats.Str, ob->stats.Str, CS_STAT_STR);
1081 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT);
1082 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW);
1083 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1084 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 769 AddIfShort (ns->last_stats.Dex, ob->stats.Dex, CS_STAT_DEX);
1085 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 770 AddIfShort (ns->last_stats.Con, ob->stats.Con, CS_STAT_CON);
771 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
772 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
773 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1086 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 774 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1087 }
1088 775
1089 if (pl->socket->exp64)
1090 {
1091 uint8 s;
1092
1093 for (s = 0; s < NUM_SKILLS; s++) 776 for (int s = 0; s < NUM_SKILLS; s++)
777 if (object *skill = opl->last_skill_ob [s])
778 if (skill->stats.exp != ns->last_skill_exp [s])
1094 { 779 {
1095 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 780 ns->last_skill_exp [s] = skill->stats.exp;
1096 { 781
1097 /* Always send along the level if exp changes. This is only 782 /* Always send along the level if exp changes. This is only
1098 * 1 extra byte, but keeps processing simpler. 783 * 1 extra byte, but keeps processing simpler.
1099 */ 784 */
1100 sl << uint8 (s + CS_STAT_SKILLINFO) 785 sl << uint8 (s + CS_STAT_SKILLINFO)
1101 << uint8 (pl->last_skill_ob[s]->level) 786 << uint8 (skill->level)
1102 << uint64 (pl->last_skill_ob[s]->stats.exp); 787 << uint64 (skill->stats.exp);
1103
1104 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1105 }
1106 } 788 }
1107 }
1108 789
1109 if (pl->socket->exp64)
1110 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) } 790 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
791 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
792 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
793 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
794 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
795 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED, 1.f/TICK);
796 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
797 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP, 1.f/TICK);
798 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
799
800 flags = 0;
801
802 if (opl->fire_on)
803 flags |= SF_FIREON;
804
805 if (opl->run_on)
806 flags |= SF_RUNON;
807
808 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
809
810 if (ns->sc_version < 1025)
811 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1111 else 812 else
1112 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1113
1114 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL);
1115 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC);
1116 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC);
1117 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM);
1118 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED);
1119 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD);
1120 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1121 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM);
1122 flags = 0;
1123
1124 if (pl->fire_on)
1125 flags |= SF_FIREON;
1126
1127 if (pl->run_on)
1128 flags |= SF_RUNON;
1129
1130 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS);
1131
1132 if (pl->socket->sc_version < 1025)
1133 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1134 else
1135 {
1136 int i;
1137
1138 for (i = 0; i < NROFATTACKS; i++) 813 for (int i = 0; i < NROFATTACKS; i++)
1139 { 814 {
1140 /* Skip ones we won't send */ 815 /* Skip ones we won't send */
1141 if (atnr_cs_stat[i] == -1) 816 if (atnr_cs_stat[i] == -1)
1142 continue; 817 continue;
1143 818
1144 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 819 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
1145 } 820 }
1146 }
1147 821
1148 if (pl->socket->monitor_spells) 822 if (pl->ns->monitor_spells)
1149 { 823 {
1150 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 824 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1151 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 825 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1152 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 826 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1153 } 827 }
1154 828
1155 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 829 rangetostring (opl, buf); /* we want use the new fire & run system in new client */
1156 AddIfString (pl->socket->stats.range, buf, CS_STAT_RANGE); 830 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1157 set_title (pl->ob, buf); 831 set_title (ob, buf);
1158 AddIfString (pl->socket->stats.title, buf, CS_STAT_TITLE); 832 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1159 833
1160 /* Only send it away if we have some actual data */ 834 /* Only send it away if we have some actual data */
1161 if (sl.length () > 6) 835 if (sl.length () > 6)
1162 pl->socket->send_packet (sl); 836 ns->send_packet (sl);
1163} 837}
1164 838
1165/** 839/**
1166 * Tells the client that here is a player it should start using. 840 * Tells the client that here is a player it should start using.
1167 */ 841 */
1168void 842void
1169esrv_new_player (player *pl, uint32 weight) 843esrv_new_player (player *pl)
1170{ 844{
1171 pl->last_weight = weight; 845 sint32 weight = pl->ob->client_weight ();
1172 846
1173 packet sl; 847 packet sl ("player");
1174 sl << "player ";
1175 848
1176 sl << uint32 (pl->ob->count) 849 sl << uint32 (pl->ob->count)
1177 << uint32 (weight) 850 << uint32 (weight)
1178 << uint32 (pl->ob->face->number) 851 << uint32 (pl->ob->face)
1179 << data8 (pl->ob->name); 852 << data8 (pl->ob->name);
1180 853
1181 pl->socket->send_packet (sl); 854 pl->ns->last_weight = weight;
1182 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1183}
1184
1185/**
1186 * Need to send an animation sequence to the client.
1187 * We will send appropriate face commands to the client if we haven't
1188 * sent them the face yet (this can become quite costly in terms of
1189 * how much we are sending - on the other hand, this should only happen
1190 * when the player logs in and picks stuff up.
1191 */
1192void
1193esrv_send_animation (client_socket * ns, short anim_num)
1194{
1195 int i;
1196
1197 /* Do some checking on the anim_num we got. Note that the animations
1198 * are added in contigous order, so if the number is in the valid
1199 * range, it must be a valid animation.
1200 */
1201 if (anim_num < 0 || anim_num > num_animations)
1202 {
1203 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1204 return;
1205 }
1206
1207 packet sl;
1208
1209 sl << "anim "
1210 << uint16 (anim_num)
1211 << uint16 (0); /* flags - not used right now */
1212
1213 /* Build up the list of faces. Also, send any information (ie, the
1214 * the face itself) down to the client.
1215 */
1216 for (i = 0; i < animations[anim_num].num_animations; i++)
1217 {
1218 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1219 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1220 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1221 }
1222
1223 ns->send_packet (sl); 855 pl->ns->send_packet (sl);
1224
1225 ns->anims_sent[anim_num] = 1;
1226} 856}
1227
1228 857
1229/****************************************************************************** 858/******************************************************************************
1230 * 859 *
1231 * Start of map related commands. 860 * Start of map related commands.
1232 * 861 *
1233 ******************************************************************************/ 862 ******************************************************************************/
1234 863
1235/**
1236 * This adds face_num to a map cell at x,y. If the client doesn't have
1237 * the face yet, we will also send it.
1238 */
1239static void
1240esrv_map_setbelow (client_socket * ns, int x, int y, short face_num, struct Map *newmap)
1241{
1242 if (newmap->cells[x][y].count >= MAP_LAYERS)
1243 {
1244 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1245 return;
1246 abort ();
1247 }
1248
1249 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1250 newmap->cells[x][y].count++;
1251
1252 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1253 esrv_send_face (ns, face_num, 0);
1254}
1255
1256struct LayerCell
1257{
1258 uint16 xy;
1259 short face;
1260};
1261
1262struct MapLayer
1263{
1264 int count;
1265 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1266};
1267
1268/** Checkes if map cells have changed */
1269static int
1270mapcellchanged (client_socket * ns, int i, int j, struct Map *newmap)
1271{
1272 int k;
1273
1274 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1275 return 1;
1276 for (k = 0; k < newmap->cells[i][j].count; k++)
1277 {
1278 if (ns->lastmap.cells[i][j].faces[k] != newmap->cells[i][j].faces[k])
1279 {
1280 return 1;
1281 }
1282 }
1283 return 0;
1284}
1285
1286/**
1287 * Basically, what this does is pack the data into layers.
1288 * cnum is the client number, cur is the the buffer we put all of
1289 * this data into. we return the end of the data. layers is
1290 * how many layers of data we should back.
1291 */
1292static uint8 *
1293compactlayer (client_socket * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1294{
1295 int x, y, k;
1296 int face;
1297 unsigned char *fcur;
1298 struct MapLayer layers[MAP_LAYERS];
1299
1300 for (k = 0; k < MAP_LAYERS; k++)
1301 layers[k].count = 0;
1302 fcur = cur;
1303 for (x = 0; x < ns->mapx; x++)
1304 {
1305 for (y = 0; y < ns->mapy; y++)
1306 {
1307 if (!mapcellchanged (ns, x, y, newmap))
1308 continue;
1309 if (newmap->cells[x][y].count == 0)
1310 {
1311 *cur = x * ns->mapy + y; /* mark empty space */
1312 cur++;
1313 continue;
1314 }
1315 for (k = 0; k < newmap->cells[x][y].count; k++)
1316 {
1317 layers[k].lcells[layers[k].count].xy = x * ns->mapy + y;
1318 layers[k].lcells[layers[k].count].face = newmap->cells[x][y].faces[k];
1319 layers[k].count++;
1320 }
1321 }
1322 }
1323 /* If no data, return now. */
1324 if (fcur == cur && layers[0].count == 0)
1325 return cur;
1326 *cur = 255; /* mark end of explicitly cleared cells */
1327 cur++;
1328 /* First pack by layers. */
1329 for (k = 0; k < numlayers; k++)
1330 {
1331 if (layers[k].count == 0)
1332 break; /* once a layer is entirely empty, no layer below it can
1333 have anything in it either */
1334 /* Pack by entries in thie layer */
1335 for (x = 0; x < layers[k].count;)
1336 {
1337 fcur = cur;
1338 *cur = layers[k].lcells[x].face >> 8;
1339 cur++;
1340 *cur = layers[k].lcells[x].face & 0xFF;
1341 cur++;
1342 face = layers[k].lcells[x].face;
1343 /* Now, we back the redundant data into 1 byte xy pairings */
1344 for (y = x; y < layers[k].count; y++)
1345 {
1346 if (layers[k].lcells[y].face == face)
1347 {
1348 *cur = (uint8) layers[k].lcells[y].xy;
1349 cur++;
1350 layers[k].lcells[y].face = -1;
1351 }
1352 }
1353 *(cur - 1) = *(cur - 1) | 128; /* mark for end of xy's; 11*11 < 128 */
1354 /* forward over the now redundant data */
1355 while (x < layers[k].count && layers[k].lcells[x].face == -1)
1356 x++;
1357 }
1358 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1359 }
1360 return cur;
1361}
1362
1363/** Clears a map cell */ 864/** Clears a map cell */
1364static void 865static void
1365map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 866map_clearcell (struct MapCell *cell, int count)
1366{ 867{
1367 cell->faces[0] = face0; 868 cell->faces[0] = 0;
1368 cell->faces[1] = face1; 869 cell->faces[1] = 0;
1369 cell->faces[2] = face2; 870 cell->faces[2] = 0;
871 cell->smooth[0] = 0;
872 cell->smooth[1] = 0;
873 cell->smooth[2] = 0;
1370 cell->count = count; 874 cell->count = count;
1371 cell->stat_hp = 0; 875 cell->stat_hp = 0;
1372 cell->flags = 0; 876 cell->flags = 0;
1373 cell->player = 0; 877 cell->player = 0;
1374} 878}
1375 879
1376#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1377#define MAX_LAYERS 3 880#define MAX_LAYERS 3
1378
1379/* Using a global really isn't a good approach, but saves the over head of
1380 * allocating and deallocating such a block of data each time run through,
1381 * and saves the space of allocating this in the socket object when we only
1382 * need it for this cycle. If the serve is ever threaded, this needs to be
1383 * re-examined.
1384 */
1385
1386static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1387
1388/**
1389 * Returns true if any of the heads for this
1390 * space is set. Returns false if all are blank - this is used
1391 * for empty space checking.
1392 */
1393static inline int
1394have_head (int ax, int ay)
1395{
1396
1397 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1398 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1399 return 1;
1400 return 0;
1401}
1402
1403/**
1404 * check_head is a bit simplistic version of update_space below.
1405 * basically, it only checks the that the head on space ax,ay at layer
1406 * needs to get sent - if so, it adds the data, sending the head
1407 * if needed, and returning 1. If this no data needs to get
1408 * sent, it returns zero.
1409 */
1410static int
1411check_head (packet &sl, client_socket &ns, int ax, int ay, int layer)
1412{
1413 short face_num;
1414
1415 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1416 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1417 else
1418 face_num = 0;
1419
1420 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1421 {
1422 sl << uint16 (face_num);
1423 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1424 esrv_send_face (&ns, face_num, 0);
1425
1426 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1427 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1428 return 1;
1429 }
1430
1431 return 0; /* No change */
1432}
1433 881
1434/** 882/**
1435 * Removes the need to replicate the same code for each layer. 883 * Removes the need to replicate the same code for each layer.
1436 * this returns true if this space is now in fact different than 884 * this returns true if this space is now in fact different than
1437 * it was. 885 * it was.
1438 * sl is the socklist this data is going into. 886 * sl is the socklist this data is going into.
1439 * ns is the socket we are working on - all the info we care 887 * ns is the socket we are working on - all the info we care
1440 * about is in this socket structure, so now need not pass the 888 * about is in this socket structure, so now need not pass the
1441 * entire player object. 889 * entire player object.
1442 * mx and my are map coordinate offsets for map mp
1443 * sx and sy are the offsets into the socket structure that
1444 * holds the old values.
1445 * layer is the layer to update, with 2 being the floor and 0 the 890 * layer is the layer to update, with 2 being the floor and 0 the
1446 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ) 891 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ)
1447 * take. Interesting to note that before this function, the map1 function 892 * take. Interesting to note that before this function, the map1 function
1448 * numbers the spaces differently - I think this was a leftover from 893 * numbers the spaces differently - I think this was a leftover from
1449 * the map command, where the faces stack up. Sinces that is no longer 894 * the map command, where the faces stack up. Sinces that is no longer
1450 * the case, it seems to make more sense to have these layer values 895 * the case, it seems to make more sense to have these layer values
1451 * actually match. 896 * actually match.
1452 */ 897 */
1453
1454static int 898static int
1455update_space (packet &sl, client_socket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 899update_space (packet &sl, client &ns, mapspace &ms, MapCell &lastcell, int layer)
1456{ 900{
1457 object *ob, *head; 901 object *ob = ms.faces_obj [layer];
1458 uint16 face_num;
1459 int bx, by, i;
1460
1461 /* If there is a multipart object stored away, treat that as more important.
1462 * If not, then do the normal processing.
1463 */
1464 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1465
1466 /* Check to see if this head is part of the set of objects
1467 * we would normally send for this space. If so, then
1468 * don't use the head value. We need to do the check
1469 * here and not when setting up the heads[] value for two reasons -
1470 * 1) the heads[] values will get used even if the space is not visible.
1471 * 2) its possible the head is not on the same map as a part, and I'd
1472 * rather not need to do the map translation overhead.
1473 * 3) We need to do some extra checking to make sure that we will
1474 * otherwise send the image as this layer, eg, either it matches
1475 * the head value, or is not multipart.
1476 */
1477 if (head && !head->more)
1478 {
1479 for (i = 0; i < MAP_LAYERS; i++)
1480 {
1481 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1482 if (!ob)
1483 continue;
1484
1485 if (ob->head)
1486 ob = ob->head;
1487
1488 if (ob == head)
1489 {
1490 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1491 head = NULL;
1492 break;
1493 }
1494 }
1495 }
1496
1497 ob = head;
1498 if (!ob)
1499 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1500 902
1501 /* If there is no object for this space, or if the face for the object 903 /* If there is no object for this space, or if the face for the object
1502 * is the blank face, set the face number to zero. 904 * is the blank face, set the face number to zero.
1503 * else if we have the stored head object for this space, that takes 905 * else if we have the stored head object for this space, that takes
1504 * precedence over the other object for this space. 906 * precedence over the other object for this space.
1505 * otherwise, we do special head processing 907 * otherwise, we do special head processing
1506 */ 908 */
1507 if (!ob || ob->face == blank_face) 909 uint16 face_num = ob && ob->face != blank_face ? ob->face : 0;
1508 face_num = 0;
1509 else if (head)
1510 {
1511 /* if this is a head that had previously been stored */
1512 face_num = ob->face->number;
1513 }
1514 else
1515 {
1516 /* if the faces for the different parts of a multipart object
1517 * are the same, we only want to send the bottom right most
1518 * portion of the object. That info is in the tail_.. values
1519 * of the head. Note that for the head itself, ob->head will
1520 * be null, so we only do this block if we are working on
1521 * a tail piece.
1522 */
1523
1524 /* tail_x and tail_y will only be set in the head object. If
1525 * this is the head object and these are set, we proceed
1526 * with logic to only send bottom right. Similarly, if
1527 * this is one of the more parts but the head has those values
1528 * set, we want to do the processing. There can be cases where
1529 * the head is not visible but one of its parts is, so we just
1530 * can always expect that ob->arch->tail_x will be true for all
1531 * object we may want to display.
1532 */
1533 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1534 {
1535
1536 if (ob->head)
1537 head = ob->head;
1538 else
1539 head = ob;
1540
1541 /* Basically figure out where the offset is from where we are right
1542 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1543 * piece is from the head, and the tail is where the tail is from the
1544 * head. Note that bx and by will equal sx and sy if we are already working
1545 * on the bottom right corner. If ob is the head, the clone values
1546 * will be zero, so the right thing will still happen.
1547 */
1548 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1549 by = sy + head->arch->tail_y - ob->arch->clone.y;
1550
1551 /* I don't think this can ever happen, but better to check for it just
1552 * in case.
1553 */
1554 if (bx < sx || by < sy)
1555 {
1556 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1557 face_num = 0;
1558 }
1559 /* single part object, multipart object with non merged faces,
1560 * of multipart object already at lower right.
1561 */
1562 else if (bx == sx && by == sy)
1563 {
1564 face_num = ob->face->number;
1565
1566 /* if this face matches one stored away, clear that one away.
1567 * this code relies on the fact that the map1 commands
1568 * goes from 2 down to 0.
1569 */
1570 for (i = 0; i < MAP_LAYERS; i++)
1571 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1572 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1573 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1574 }
1575 else
1576 {
1577 /* If this head is stored away, clear it - otherwise,
1578 * there can be cases where a object is on multiple layers -
1579 * we only want to send it once.
1580 */
1581 face_num = head->face->number;
1582 for (i = 0; i < MAP_LAYERS; i++)
1583 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1584 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1585 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1586
1587 /* First, try to put the new head on the same layer. If that is used up,
1588 * then find another layer.
1589 */
1590 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1591 {
1592 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1593 }
1594 else
1595 for (i = 0; i < MAX_LAYERS; i++)
1596 {
1597 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1598 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1599 {
1600 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1601 }
1602 }
1603 face_num = 0; /* Don't send this object - we'll send the head later */
1604 }
1605 }
1606 else
1607 {
1608 /* In this case, we are already at the lower right or single part object,
1609 * so nothing special
1610 */
1611 face_num = ob->face->number;
1612
1613 /* clear out any head entries that have the same face as this one */
1614 for (bx = 0; bx < layer; bx++)
1615 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1616 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1617 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1618 }
1619 } /* else not already head object or blank face */
1620
1621 /* This is a real hack. Basically, if we have nothing to send for this layer,
1622 * but there is a head on the next layer, send that instead.
1623 * Without this, what happens is you can get the case where the player stands
1624 * on the same space as the head. However, if you have overlapping big objects
1625 * of the same type, what happens then is it doesn't think it needs to send
1626 * This tends to make stacking also work/look better.
1627 */
1628 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1629 {
1630 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1631 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1632 }
1633
1634 /* Another hack - because of heads and whatnot, this face may match one
1635 * we already sent for a lower layer. In that case, don't send
1636 * this one.
1637 */
1638 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1639 face_num = 0;
1640 910
1641 /* We've gotten what face we want to use for the object. Now see if 911 /* We've gotten what face we want to use for the object. Now see if
1642 * if it has changed since we last sent it to the client. 912 * if it has changed since we last sent it to the client.
1643 */ 913 */
1644 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num) 914 if (lastcell.faces[layer] != face_num)
1645 { 915 {
1646 ns.lastmap.cells[sx][sy].faces[layer] = face_num; 916 lastcell.faces[layer] = face_num;
917
1647 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 918 if (!ns.faces_sent[face_num])
919 if (ob)
920 ns.send_faces (ob);
921 else
1648 esrv_send_face (&ns, face_num, 0); 922 ns.send_face (face_num, 10);
1649 923
1650 sl << uint16 (face_num); 924 sl << uint16 (face_num);
1651 return 1; 925 return 1;
1652 } 926 }
1653 927
1654 /* Nothing changed */ 928 /* Nothing changed */
1655 return 0; 929 return 0;
1656} 930}
1657 931
1658/** 932// prefetch (and touch) all maps within a specific distancd
1659 * This function is mainly a copy of update_space, 933static void
1660 * except it handles update of the smoothing updates, 934prefetch_surrounding_maps (maptile *map, int distance)
1661 * not the face updates.
1662 * Removes the need to replicate the same code for each layer.
1663 * this returns true if this smooth is now in fact different
1664 * than it was.
1665 * sl is the socklist this data is going into.
1666 * ns is the socket we are working on - all the info we care
1667 * about is in this socket structure, so know need to pass the
1668 * entire player object.
1669 * mx and my are map coordinate offsets for map mp
1670 * sx and sy are the offsets into the socket structure that
1671 * holds the old values.
1672 * layer is the layer to update, with 2 being the floor and 0 the
1673 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1674 * take.
1675 */
1676
1677static inline int
1678update_smooth (packet &sl, client_socket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1679{ 935{
1680 object *ob; 936 map->touch ();
1681 int smoothlevel; /* old face_num; */
1682 937
1683 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer); 938 if (--distance)
1684 939 for (int dir = 4; --dir; )
1685 /* If there is no object for this space, or if the face for the object 940 if (const shstr &path = map->tile_path [dir])
1686 * is the blank face, set the smoothlevel to zero. 941 if (maptile *&neigh = map->tile_map [dir])
1687 */ 942 prefetch_surrounding_maps (neigh, distance);
1688 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1689 smoothlevel = 0;
1690 else
1691 {
1692 smoothlevel = ob->smoothlevel;
1693 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1694 SendSmooth (&ns, ob->face->number);
1695 } /* else not already head object or blank face */
1696
1697 /* We've gotten what face we want to use for the object. Now see if
1698 * if it has changed since we last sent it to the client.
1699 */
1700 if (smoothlevel > 255)
1701 smoothlevel = 255;
1702 else if (smoothlevel < 0)
1703 smoothlevel = 0;
1704
1705 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1706 {
1707 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1708 sl << uint8 (smoothlevel);
1709 return 1;
1710 }
1711
1712 /* Nothing changed */
1713 return 0;
1714}
1715
1716/**
1717 * Returns the size of a data for a map square as returned by
1718 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1719 * available.
1720 */
1721int
1722getExtendedMapInfoSize (client_socket * ns)
1723{
1724 int result = 0;
1725
1726 if (ns->ext_mapinfos)
1727 {
1728 if (ns->EMI_smooth)
1729 result += 1; /*One byte for smoothlevel */
1730 }
1731 return result;
1732}
1733
1734/**
1735 * This function uses the new map1 protocol command to send the map
1736 * to the client. It is necessary because the old map command supports
1737 * a maximum map size of 15x15.
1738 * This function is much simpler than the old one. This is because
1739 * the old function optimized to send as few face identifiers as possible,
1740 * at the expense of sending more coordinate location (coordinates were
1741 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1742 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1743 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1744 * and use the other 4 bits for other informatiion. For full documentation
1745 * of what we send, see the doc/Protocol file.
1746 * I will describe internally what we do:
1747 * the socket->lastmap shows how the map last looked when sent to the client.
1748 * in the lastmap structure, there is a cells array, which is set to the
1749 * maximum viewable size (As set in config.h).
1750 * in the cells, there are faces and a count value.
1751 * we use the count value to hold the darkness value. If -1, then this space
1752 * is not viewable.
1753 * we use faces[0] faces[1] faces[2] to hold what the three layers
1754 * look like.
1755 */
1756void
1757draw_client_map1 (object *pl)
1758{
1759 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen;
1760 sint16 nx, ny;
1761 int estartlen, eoldlen;
1762 uint16 mask, emask;
1763 uint8 eentrysize;
1764 uint16 ewhatstart, ewhatflag;
1765 uint8 extendedinfos;
1766 maptile *m;
1767
1768 client_socket &socket = *pl->contr->socket;
1769
1770 check_map_change (pl->contr);
1771
1772 packet sl;
1773 packet esl;
1774
1775 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1776 startlen = sl.length ();
1777
1778 /*Extendedmapinfo structure initialisation */
1779 if (socket.ext_mapinfos)
1780 {
1781 extendedinfos = EMI_NOREDRAW;
1782
1783 if (socket.EMI_smooth)
1784 extendedinfos |= EMI_SMOOTH;
1785
1786 ewhatstart = esl.length ();
1787 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1788 could need to be taken away */
1789 eentrysize = getExtendedMapInfoSize (&socket);
1790 esl << "mapextended "
1791 << uint8 (extendedinfos)
1792 << uint8 (eentrysize);
1793
1794 estartlen = esl.length ();
1795 }
1796 else
1797 {
1798 /* suppress compiler warnings */
1799 ewhatstart = 0;
1800 ewhatflag = 0;
1801 estartlen = 0;
1802 }
1803
1804 /* Init data to zero */
1805 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1806
1807 /* x,y are the real map locations. ax, ay are viewport relative
1808 * locations.
1809 */
1810 ay = 0;
1811
1812 /* We could do this logic as conditionals in the if statement,
1813 * but that started to get a bit messy to look at.
1814 */
1815 max_x = pl->x + (socket.mapx + 1) / 2;
1816 max_y = pl->y + (socket.mapy + 1) / 2;
1817
1818 if (socket.mapmode == Map1aCmd)
1819 {
1820 max_x += MAX_HEAD_OFFSET;
1821 max_y += MAX_HEAD_OFFSET;
1822 }
1823
1824 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1825 {
1826 ax = 0;
1827 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1828 {
1829
1830 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1831
1832 /* If this space is out of the normal viewable area, we only check
1833 * the heads value ax or ay will only be greater than what
1834 * the client wants if using the map1a command - this is because
1835 * if the map1a command is not used, max_x and max_y will be
1836 * set to lower values.
1837 */
1838 if (ax >= socket.mapx || ay >= socket.mapy)
1839 {
1840 int i, got_one;
1841
1842 oldlen = sl.length ();
1843
1844 sl << uint16 (mask);
1845
1846 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1847 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1848 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1849
1850 /* If all we are doing is sending 0 (blank) faces, we don't
1851 * actually need to send that - just the coordinates
1852 * with no faces tells the client to blank out the
1853 * space.
1854 */
1855 got_one = 0;
1856 for (i = oldlen + 2; i < sl.length (); i++)
1857 if (sl[i])
1858 got_one = 1;
1859
1860 if (got_one && (mask & 0xf))
1861 sl[oldlen + 1] = mask & 0xff;
1862 else
1863 { /*either all faces blank, either no face at all */
1864 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1865 sl.reset (oldlen + 2);
1866 else
1867 sl.reset (oldlen);
1868 }
1869
1870 /*What concerns extendinfos, nothing to be done for now
1871 * (perhaps effects layer later)
1872 */
1873 continue; /* don't do processing below */
1874 }
1875
1876 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1877
1878 d = pl->contr->blocked_los[ax][ay];
1879
1880 /* If the coordinates are not valid, or it is too dark to see,
1881 * we tell the client as such
1882 */
1883 nx = x;
1884 ny = y;
1885 m = get_map_from_coord (pl->map, &nx, &ny);
1886
1887 if (!m)
1888 {
1889 /* space is out of map. Update space and clear values
1890 * if this hasn't already been done. If the space is out
1891 * of the map, it shouldn't have a head
1892 */
1893 if (lastcell.count != -1)
1894 {
1895 sl << uint16 (mask);
1896 map_clearcell (&lastcell, 0, 0, 0, -1);
1897 }
1898 }
1899 else if (d > 3)
1900 {
1901 int need_send = 0, count;
1902
1903 /* This block deals with spaces that are not visible for whatever
1904 * reason. Still may need to send the head for this space.
1905 */
1906
1907 oldlen = sl.length ();
1908
1909 sl << uint16 (mask);
1910
1911 if (lastcell.count != -1)
1912 need_send = 1;
1913
1914 count = -1;
1915
1916 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
1917 {
1918 /* Now check to see if any heads need to be sent */
1919
1920 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1921 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1922 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1923
1924 lastcell.count = count;
1925 }
1926 else
1927 {
1928 /* properly clear a previously sent big face */
1929 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0
1930 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1931 need_send = 1;
1932
1933 map_clearcell (&lastcell, 0, 0, 0, count);
1934 }
1935
1936 if ((mask & 0xf) || need_send)
1937 sl[oldlen + 1] = mask & 0xff;
1938 else
1939 sl.reset (oldlen);
1940 }
1941 else 943 else
1942 { 944 neigh = maptile::find_async (path, map);
1943 /* In this block, the space is visible or there are head objects 945}
1944 * we need to send.
1945 */
1946 946
1947 /* Rather than try to figure out what everything that we might 947// prefetch a generous area around the player
1948 * need to send is, then form the packet after that, 948static void
1949 * we presume that we will in fact form a packet, and update 949prefetch_surrounding_maps (object *op)
1950 * the bits by what we do actually send. If we send nothing, 950{
1951 * we just back out sl.length () to the old value, and no harm 951 prefetch_surrounding_maps (op->map, 3);
1952 * is done.
1953 * I think this is simpler than doing a bunch of checks to see
1954 * what if anything we need to send, setting the bits, then
1955 * doing those checks again to add the real data.
1956 */
1957 oldlen = sl.length ();
1958 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1959 eoldlen = esl.length ();
1960 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1961 sl << uint16 (mask);
1962
1963 if (socket.ext_mapinfos)
1964 esl << uint16 (emask);
1965
1966 unsigned char dummy;
1967 unsigned char *last_ext = &dummy;
1968
1969 /* Darkness changed */
1970 if (lastcell.count != d && socket.darkness)
1971 {
1972 mask |= 0x8;
1973
1974 if (socket.extmap)
1975 {
1976 *last_ext |= 0x80;
1977 last_ext = &sl[sl.length ()];
1978 sl << uint8 (d);
1979 }
1980 else
1981 sl << uint8 (255 - 64 * d);
1982 }
1983
1984 lastcell.count = d;
1985
1986 if (socket.extmap)
1987 {
1988 uint8 stat_hp = 0;
1989 uint8 stat_width = 0;
1990 uint8 flags = 0;
1991 UUID player = 0;
1992
1993 // send hp information, if applicable
1994 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0))
1995 {
1996 if (op->head || op->invisible)
1997 ; // do not show
1998 else if (op->type == PLAYER
1999 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
2000 {
2001 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
2002 {
2003 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
2004 stat_width = op->arch->tail_x;
2005 }
2006 }
2007
2008 if (op->msg && op->msg[0] == '@')
2009 flags |= 1;
2010
2011 if (op->type == PLAYER && op != pl)
2012 player = op->count;
2013 }
2014
2015 if (lastcell.stat_hp != stat_hp)
2016 {
2017 lastcell.stat_hp = stat_hp;
2018
2019 mask |= 0x8;
2020 *last_ext |= 0x80;
2021 last_ext = &sl[sl.length ()];
2022
2023 sl << uint8 (5) << uint8 (stat_hp);
2024
2025 if (stat_width > 1)
2026 {
2027 *last_ext |= 0x80;
2028 last_ext = &sl[sl.length ()];
2029
2030 sl << uint8 (6) << uint8 (stat_width);
2031 }
2032 }
2033
2034 if (lastcell.player != player)
2035 {
2036 lastcell.player = player;
2037
2038 mask |= 0x8;
2039 *last_ext |= 0x80;
2040 last_ext = &sl[sl.length ()];
2041
2042 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2043 }
2044
2045 if (lastcell.flags != flags)
2046 {
2047 lastcell.flags = flags;
2048
2049 mask |= 0x8;
2050 *last_ext |= 0x80;
2051 last_ext = &sl[sl.length ()];
2052
2053 sl << uint8 (8) << uint8 (flags);
2054 }
2055 }
2056
2057 /* Floor face */
2058 if (update_space (sl, socket, m, nx, ny, ax, ay, 2))
2059 mask |= 0x4;
2060
2061 if (socket.EMI_smooth)
2062 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2063 emask |= 0x4;
2064
2065 /* Middle face */
2066 if (update_space (sl, socket, m, nx, ny, ax, ay, 1))
2067 mask |= 0x2;
2068
2069 if (socket.EMI_smooth)
2070 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1))
2071 emask |= 0x2;
2072
2073 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2074 {
2075 if (lastcell.faces[0] != pl->face->number)
2076 {
2077 lastcell.faces[0] = pl->face->number;
2078 mask |= 0x1;
2079
2080 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2081 esrv_send_face (&socket, pl->face->number, 0);
2082
2083 sl << uint16 (pl->face->number);
2084 }
2085 }
2086 else
2087 {
2088 /* Top face */
2089 if (update_space (sl, socket, m, nx, ny, ax, ay, 0))
2090 mask |= 0x1;
2091
2092 if (socket.EMI_smooth)
2093 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2094 emask |= 0x1;
2095 }
2096
2097 /* Check to see if we are in fact sending anything for this
2098 * space by checking the mask. If so, update the mask.
2099 * if not, reset the len to that from before adding the mask
2100 * value, so we don't send those bits.
2101 */
2102 if (mask & 0xf)
2103 sl[oldlen + 1] = mask & 0xff;
2104 else
2105 sl.reset (oldlen);
2106
2107 if (emask & 0xf)
2108 esl[eoldlen + 1] = emask & 0xff;
2109 else
2110 esl.reset (eoldlen);
2111 } /* else this is a viewable space */
2112 } /* for x loop */
2113 } /* for y loop */
2114
2115 /* Verify that we in fact do need to send this */
2116 if (socket.ext_mapinfos)
2117 {
2118 if (!(sl.length () > startlen || socket.sent_scroll))
2119 {
2120 /* No map data will follow, so don't say the client
2121 * it doesn't need draw!
2122 */
2123 ewhatflag &= (~EMI_NOREDRAW);
2124 esl[ewhatstart + 1] = ewhatflag & 0xff;
2125 }
2126
2127 if (esl.length () > estartlen)
2128 socket.send_packet (esl);
2129 }
2130
2131 if (sl.length () > startlen || socket.sent_scroll)
2132 {
2133 socket.send_packet (sl);
2134 socket.sent_scroll = 0;
2135 }
2136} 952}
2137 953
2138/** 954/**
2139 * Draws client map. 955 * Draws client map.
2140 */ 956 */
2141void 957void
2142draw_client_map (object *pl) 958draw_client_map (player *pl)
2143{ 959{
2144 int i, j; 960 object *ob = pl->observe;
2145 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */ 961 if (!ob->active)
2146 New_Face *face, *floor;
2147 New_Face *floor2;
2148 int d, mflags;
2149 struct Map newmap;
2150 maptile *m, *pm;
2151
2152 if (pl->type != PLAYER)
2153 {
2154 LOG (llevError, "draw_client_map called with non player/non eric-server\n");
2155 return; 962 return;
2156 }
2157
2158 pm = pl->map;
2159 963
2160 /* If player is just joining the game, he isn't here yet, so the map 964 /* If player is just joining the game, he isn't here yet, so the map
2161 * can get swapped out. If so, don't try to send them a map. All will 965 * can get swapped out. If so, don't try to send them a map. All will
2162 * be OK once they really log in. 966 * be OK once they really log in.
2163 */ 967 */
2164 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 968 if (!ob->map || ob->map->in_memory != MAP_ACTIVE)
2165 return; 969 return;
2166 970
2167 memset (&newmap, 0, sizeof (struct Map)); 971 int startlen, oldlen;
2168 972
2169 for (j = (pl->y - pl->contr->socket->mapy / 2); j < (pl->y + (pl->contr->socket->mapy + 1) / 2); j++) 973 check_map_change (pl);
2170 { 974 prefetch_surrounding_maps (pl->ob);
2171 for (i = (pl->x - pl->contr->socket->mapx / 2); i < (pl->x + (pl->contr->socket->mapx + 1) / 2); i++) 975
2172 {
2173 ax = i;
2174 ay = j;
2175 m = pm;
2176 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
2177 if (mflags & P_OUT_OF_MAP)
2178 continue;
2179 if (mflags & P_NEED_UPDATE)
2180 update_position (m, ax, ay);
2181 /* If a map is visible to the player, we don't want to swap it out
2182 * just to reload it. This should really call something like
2183 * swap_map, but this is much more efficient and 'good enough'
2184 */
2185 if (mflags & P_NEW_MAP)
2186 m->timeout = 50;
2187 }
2188 }
2189 /* do LOS after calls to update_position */ 976 /* do LOS after calls to update_position */
2190 if (pl->contr->do_los) 977 /* unfortunately, we need to udpate los when observing, currently */
978 if (pl->do_los || pl->observe != pl->ob)
2191 { 979 {
980 pl->do_los = 0;
2192 update_los (pl); 981 pl->update_los ();
2193 pl->contr->do_los = 0; 982 }
983
984 /**
985 * This function uses the new map1 protocol command to send the map
986 * to the client. It is necessary because the old map command supports
987 * a maximum map size of 15x15.
988 * This function is much simpler than the old one. This is because
989 * the old function optimized to send as few face identifiers as possible,
990 * at the expense of sending more coordinate location (coordinates were
991 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
992 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
993 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
994 * and use the other 4 bits for other informatiion. For full documentation
995 * of what we send, see the doc/Protocol file.
996 * I will describe internally what we do:
997 * the ns->lastmap shows how the map last looked when sent to the client.
998 * in the lastmap structure, there is a cells array, which is set to the
999 * maximum viewable size (As set in config.h).
1000 * in the cells, there are faces and a count value.
1001 * we use the count value to hold the darkness value. If -1, then this space
1002 * is not viewable.
1003 * we use faces[0] faces[1] faces[2] to hold what the three layers
1004 * look like.
1005 */
1006
1007 client &socket = *pl->ns;
1008
1009 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1010
1011 startlen = sl.length ();
1012
1013 int hx = socket.mapx / 2;
1014 int hy = socket.mapy / 2;
1015
1016 ordered_mapwalk_begin (ob, -hx, -hy, hx, hy)
1017 int ax = dx + hx;
1018 int ay = dy + hy;
1019
1020 int mask = (ax << 10) | (ay << 4);
1021 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1022
1023 /* If the coordinates are not valid, or it is too dark to see,
1024 * we tell the client as such
1025 */
1026 if (!m)
1027 {
1028 /* space is out of map. Update space and clear values
1029 * if this hasn't already been done. If the space is out
1030 * of the map, it shouldn't have a head.
1031 */
1032 if (lastcell.count != -1)
1033 {
1034 sl << uint16 (mask);
1035 map_clearcell (&lastcell, -1);
1036 }
1037
1038 continue;
2194 } 1039 }
1040
1041 int d = pl->blocked_los_uc (dx, dy);
2195 1042
2196 /* Big maps need a different drawing mechanism to work */ 1043 if (d > 3)
2197 draw_client_map1 (pl); 1044 {
2198} 1045 /* This block deals with spaces that are not visible for whatever
1046 * reason. Still may need to send the head for this space.
1047 */
1048 if (lastcell.count != -1
1049 || lastcell.faces[0]
1050 || lastcell.faces[1]
1051 || lastcell.faces[2]
1052 || lastcell.stat_hp
1053 || lastcell.flags
1054 || lastcell.player)
1055 sl << uint16 (mask);
2199 1056
1057 /* properly clear a previously sent big face */
1058 map_clearcell (&lastcell, -1);
1059 }
1060 else
1061 {
1062 /* In this block, the space is visible.
1063 */
1064
1065 /* Rather than try to figure out what everything that we might
1066 * need to send is, then form the packet after that,
1067 * we presume that we will in fact form a packet, and update
1068 * the bits by what we do actually send. If we send nothing,
1069 * we just back out sl.length () to the old value, and no harm
1070 * is done.
1071 * I think this is simpler than doing a bunch of checks to see
1072 * what if anything we need to send, setting the bits, then
1073 * doing those checks again to add the real data.
1074 */
1075 oldlen = sl.length ();
1076
1077 sl << uint16 (mask);
1078
1079 unsigned char dummy;
1080 unsigned char *last_ext = &dummy;
1081
1082 /* Darkness changed */
1083 if (lastcell.count != d)
1084 {
1085 mask |= 0x8;
1086
1087 *last_ext |= 0x80;
1088 last_ext = &sl[sl.length ()];
1089 sl << uint8 (d);
1090 }
1091
1092 lastcell.count = d;
1093
1094 mapspace &ms = m->at (nx, ny);
1095 ms.update ();
1096
1097 // extmap handling
1098 uint8 stat_hp = 0;
1099 uint8 stat_width = 0;
1100 uint8 flags = 0;
1101 tag_t player = 0;
1102
1103 // send hp information, if applicable
1104 if (object *op = ms.faces_obj [0])
1105 if (op->is_head () && !op->invisible)
1106 {
1107 if (op->stats.maxhp > op->stats.hp
1108 && op->stats.maxhp > 0
1109 && (op->type == PLAYER
1110 || op->type == DOOR // does not work, have maxhp 0
1111 || QUERY_FLAG (op, FLAG_MONSTER)
1112 || QUERY_FLAG (op, FLAG_ALIVE)
1113 || QUERY_FLAG (op, FLAG_GENERATOR)))
1114 {
1115 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1116 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1117 }
1118
1119 if (expect_false (op->has_dialogue ()))
1120 flags |= 1;
1121
1122 if (expect_false (op->type == PLAYER))
1123 player = op == ob ? pl->ob->count
1124 : op == pl->ob ? ob->count
1125 : op->count;
1126 }
1127
1128 if (expect_false (lastcell.stat_hp != stat_hp))
1129 {
1130 lastcell.stat_hp = stat_hp;
1131
1132 mask |= 0x8;
1133 *last_ext |= 0x80;
1134 last_ext = &sl[sl.length ()];
1135
1136 sl << uint8 (5) << uint8 (stat_hp);
1137
1138 if (stat_width > 1)
1139 {
1140 *last_ext |= 0x80;
1141 last_ext = &sl[sl.length ()];
1142
1143 sl << uint8 (6) << uint8 (stat_width);
1144 }
1145 }
1146
1147 if (expect_false (lastcell.player != player))
1148 {
1149 lastcell.player = player;
1150
1151 mask |= 0x8;
1152 *last_ext |= 0x80;
1153 last_ext = &sl[sl.length ()];
1154
1155 sl << uint8 (0x47) << uint8 (4) << (uint32)player;
1156 }
1157
1158 if (expect_false (lastcell.flags != flags))
1159 {
1160 lastcell.flags = flags;
1161
1162 mask |= 0x8;
1163 *last_ext |= 0x80;
1164 last_ext = &sl[sl.length ()];
1165
1166 sl << uint8 (8) << uint8 (flags);
1167 }
1168
1169 // faces
1170
1171 /* Floor face */
1172 if (update_space (sl, socket, ms, lastcell, 2))
1173 mask |= 0x4;
1174
1175 /* Middle face */
1176 if (update_space (sl, socket, ms, lastcell, 1))
1177 mask |= 0x2;
1178
1179 if (expect_false (ob->invisible)
1180 && ob->invisible & (ob->invisible < 50 ? 1 : 7)
1181 && ms.player () == ob)
1182 {
1183 // force player to be visible to himself if invisible
1184 if (lastcell.faces[0] != ob->face)
1185 {
1186 lastcell.faces[0] = ob->face;
1187
1188 mask |= 0x1;
1189 sl << uint16 (ob->face);
1190
1191 socket.send_faces (ob);
1192 }
1193 }
1194 /* Top face */
1195 else if (update_space (sl, socket, ms, lastcell, 0))
1196 mask |= 0x1;
1197
1198 /* Check to see if we are in fact sending anything for this
1199 * space by checking the mask. If so, update the mask.
1200 * if not, reset the len to that from before adding the mask
1201 * value, so we don't send those bits.
1202 */
1203 if (mask & 0xf)
1204 sl[oldlen + 1] = mask & 0xff;
1205 else
1206 sl.reset (oldlen);
1207 } /* else this is a viewable space */
1208 ordered_mapwalk_end
1209
1210 socket.flush_fx ();
1211
1212 if (sl.length () > startlen || socket.sent_scroll)
1213 {
1214 socket.send_packet (sl);
1215 socket.sent_scroll = 0;
1216 }
1217}
2200 1218
2201/*****************************************************************************/ 1219/*****************************************************************************/
2202
2203/* GROS: The following one is used to allow a plugin to send a generic cmd to*/ 1220/* GROS: The following one is used to allow a plugin to send a generic cmd to*/
2204
2205/* a player. Of course, the client need to know the command to be able to */ 1221/* a player. Of course, the client need to know the command to be able to */
2206
2207/* manage it ! */ 1222/* manage it ! */
2208
2209/*****************************************************************************/ 1223/*****************************************************************************/
2210void 1224void
2211send_plugin_custom_message (object *pl, char *buf) 1225send_plugin_custom_message (object *pl, char *buf)
2212{ 1226{
2213 pl->contr->socket->send_packet (buf); 1227 pl->contr->ns->send_packet (buf);
2214} 1228}
2215 1229
2216/** 1230/**
2217 * This sends the skill number to name mapping. We ignore 1231 * This sends the skill number to name mapping. We ignore
2218 * the params - we always send the same info no matter what. 1232 * the params - we always send the same info no matter what.
2219 */ 1233 */
2220void 1234void
2221send_skill_info (client_socket *ns, char *params) 1235send_skill_info (client *ns, char *params)
2222{ 1236{
2223 packet sl; 1237 packet sl;
2224 sl << "replyinfo skill_info\n"; 1238 sl << "replyinfo skill_info\n";
2225 1239
2226 for (int i = 1; i < NUM_SKILLS; i++) 1240 for (int i = 1; i < NUM_SKILLS; i++)
2227 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1241 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names [i]);
2228 1242
2229 if (sl.length () >= MAXSOCKBUF) 1243 if (sl.length () > MAXSOCKBUF)
2230 { 1244 {
2231 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1245 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2232 fatal (0); 1246 fatal (0);
2233 } 1247 }
2234 1248
… …
2238/** 1252/**
2239 * This sends the spell path to name mapping. We ignore 1253 * This sends the spell path to name mapping. We ignore
2240 * the params - we always send the same info no matter what. 1254 * the params - we always send the same info no matter what.
2241 */ 1255 */
2242void 1256void
2243send_spell_paths (client_socket * ns, char *params) 1257send_spell_paths (client * ns, char *params)
2244{ 1258{
2245 packet sl; 1259 packet sl;
2246 1260
2247 sl << "replyinfo spell_paths\n"; 1261 sl << "replyinfo spell_paths\n";
2248 1262
2249 for (int i = 0; i < NRSPELLPATHS; i++) 1263 for (int i = 0; i < NRSPELLPATHS; i++)
2250 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1264 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2251 1265
2252 if (sl.length () >= MAXSOCKBUF) 1266 if (sl.length () > MAXSOCKBUF)
2253 { 1267 {
2254 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1268 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2255 fatal (0); 1269 fatal (0);
2256 } 1270 }
2257 1271
… …
2263 * it then sends an updspell packet for each spell that has changed in this way 1277 * it then sends an updspell packet for each spell that has changed in this way
2264 */ 1278 */
2265void 1279void
2266esrv_update_spells (player *pl) 1280esrv_update_spells (player *pl)
2267{ 1281{
1282 if (!pl->ns)
1283 return;
1284
2268 if (!pl->socket->monitor_spells) 1285 if (!pl->ns->monitor_spells)
2269 return; 1286 return;
2270 1287
2271 for (object *spell = pl->ob->inv; spell; spell = spell->below) 1288 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2272 { 1289 {
2273 if (spell->type == SPELL) 1290 if (spell->type == SPELL)
2274 { 1291 {
2275 int flags = 0; 1292 int flags = 0;
2276 1293
2277 /* check if we need to update it */ 1294 /* check if we need to update it */
2278 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 1295 if (spell->cached_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
2279 { 1296 {
2280 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1297 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2281 flags |= UPD_SP_MANA; 1298 flags |= UPD_SP_MANA;
2282 } 1299 }
2283 1300
2284 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 1301 if (spell->cached_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
2285 { 1302 {
2286 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1303 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2287 flags |= UPD_SP_GRACE; 1304 flags |= UPD_SP_GRACE;
2288 } 1305 }
2289 1306
2290 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 1307 if (spell->cached_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
2291 { 1308 {
2292 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1309 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2293 flags |= UPD_SP_DAMAGE; 1310 flags |= UPD_SP_DAMAGE;
2294 } 1311 }
2295 1312
2296 if (flags) 1313 if (flags)
2297 { 1314 {
… …
2299 1316
2300 sl << "updspell " 1317 sl << "updspell "
2301 << uint8 (flags) 1318 << uint8 (flags)
2302 << uint32 (spell->count); 1319 << uint32 (spell->count);
2303 1320
2304 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1321 if (flags & UPD_SP_MANA ) sl << uint16 (spell->cached_sp);
2305 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1322 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->cached_grace);
2306 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1323 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->cached_eat);
2307 1324
2308 pl->socket->send_packet (sl); 1325 pl->ns->send_packet (sl);
2309 } 1326 }
2310 } 1327 }
2311 } 1328 }
2312} 1329}
2313 1330
2314void 1331void
2315esrv_remove_spell (player *pl, object *spell) 1332esrv_remove_spell (player *pl, object *spell)
2316{ 1333{
2317 if (!pl->socket->monitor_spells) 1334 if (!pl->ns->monitor_spells)
2318 return; 1335 return;
2319 1336
2320 if (!pl || !spell || spell->env != pl->ob) 1337 if (!pl || !spell || spell->env != pl->ob)
2321 { 1338 {
2322 LOG (llevError, "Invalid call to esrv_remove_spell"); 1339 LOG (llevError, "Invalid call to esrv_remove_spell");
2323 return; 1340 return;
2324 } 1341 }
2325 1342
2326 packet sl; 1343 packet sl ("delspell");
2327 1344
2328 sl << "delspell "
2329 << uint32 (spell->count); 1345 sl << uint32 (spell->count);
2330 1346
2331 pl->socket->send_packet (sl); 1347 pl->ns->send_packet (sl);
2332} 1348}
2333 1349
2334/* appends the spell *spell to the Socklist we will send the data to. */ 1350/* appends the spell *spell to the Socklist we will send the data to. */
2335static void 1351static void
2336append_spell (player *pl, packet &sl, object *spell) 1352append_spell (player *pl, packet &sl, object *spell)
2337{ 1353{
2338 int len, i, skill = 0; 1354 int i, skill = 0;
2339 1355
2340 if (!(spell->name)) 1356 if (!(spell->name))
2341 { 1357 {
2342 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1358 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2343 return; 1359 return;
2344 } 1360 }
2345 1361
2346 /* store costs and damage in the object struct, to compare to later */ 1362 /* store costs and damage in the object struct, to compare to later */
2347 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1363 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2348 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1364 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2349 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1365 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2350 1366
2351 /* figure out which skill it uses, if it uses one */ 1367 /* figure out which skill it uses, if it uses one */
2352 if (spell->skill) 1368 if (spell->skill)
2353 { 1369 if (object *tmp = pl->find_skill (spell->skill))
2354 for (i = 1; i < NUM_SKILLS; i++)
2355 if (!strcmp (spell->skill, skill_names[i]))
2356 {
2357 skill = i + CS_STAT_SKILLINFO; 1370 skill = tmp->subtype + CS_STAT_SKILLINFO;
2358 break; 1371
2359 } 1372 // spells better have a face
1373 if (!spell->face)
2360 } 1374 {
1375 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1376 spell->face = face_find ("burnout.x11", blank_face);
1377 }
1378
1379 pl->ns->send_face (spell->face);
2361 1380
2362 /* send the current values */ 1381 /* send the current values */
2363 sl << uint32 (spell->count) 1382 sl << uint32 (spell->count)
2364 << uint16 (spell->level) 1383 << uint16 (spell->level)
2365 << uint16 (spell->casting_time) 1384 << uint16 (spell->casting_time)
2366 << uint16 (spell->last_sp) 1385 << uint16 (spell->cached_sp)
2367 << uint16 (spell->last_grace) 1386 << uint16 (spell->cached_grace)
2368 << uint16 (spell->last_eat) 1387 << uint16 (spell->cached_eat)
2369 << uint8 (skill) 1388 << uint8 (skill)
2370 << uint32 (spell->path_attuned) 1389 << uint32 (spell->path_attuned)
2371 << uint32 (spell->face ? spell->face->number : 0) 1390 << uint32 (spell->face)
2372 << data8 (spell->name) 1391 << data8 (spell->name)
2373 << data16 (spell->msg); 1392 << data16 (spell->msg);
2374} 1393}
2375 1394
2376/** 1395/**
… …
2384 { 1403 {
2385 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 1404 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2386 return; 1405 return;
2387 } 1406 }
2388 1407
2389 if (!pl->socket->monitor_spells) 1408 if (!pl->ns->monitor_spells)
2390 return; 1409 return;
2391 1410
2392 packet sl; 1411 packet sl ("addspell");
2393
2394 sl << "addspell ";
2395 1412
2396 if (!spell) 1413 if (!spell)
2397 { 1414 {
2398 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 1415 for (spell = pl->ob->inv; spell; spell = spell->below)
2399 { 1416 {
2400 /* were we to simply keep appending data here, we could exceed 1417 /* were we to simply keep appending data here, we could exceed
2401 * MAXSOCKBUF if the player has enough spells to add, we know that 1418 * MAXSOCKBUF if the player has enough spells to add, we know that
2402 * append_spells will always append 19 data bytes, plus 4 length 1419 * append_spells will always append 19 data bytes, plus 4 length
2403 * bytes and 3 strings (because that is the spec) so we need to 1420 * bytes and 3 strings (because that is the spec) so we need to
2404 * check that the length of those 3 strings, plus the 23 bytes, 1421 * check that the length of those 3 strings, plus the 23 bytes,
2405 * won't take us over the length limit for the socket, if it does, 1422 * won't take us over the length limit for the socket, if it does,
2406 * we need to send what we already have, and restart packet formation 1423 * we need to send what we already have, and restart packet formation
2407 */ 1424 */
1425 if (spell->type != SPELL)
1426 continue;
1427
2408 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1428 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
2409 * to show add_spell is 26 bytes + 2 strings. However, the overun 1429 * to show add_spell is 26 bytes + 2 strings. However, the overun
2410 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1430 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2411 * like it will fix this 1431 * like it will fix this
2412 */ 1432 */
2413 if (spell->type != SPELL)
2414 continue;
2415
2416 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1433 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2417 { 1434 {
1435 pl->ns->flush_fx ();
2418 pl->socket->send_packet (sl); 1436 pl->ns->send_packet (sl);
2419 1437
2420 sl.reset (); 1438 sl.reset ();
2421 sl << "addspell "; 1439 sl << "addspell ";
2422 } 1440 }
2423 1441
… …
2430 return; 1448 return;
2431 } 1449 }
2432 else 1450 else
2433 append_spell (pl, sl, spell); 1451 append_spell (pl, sl, spell);
2434 1452
2435 if (sl.length () >= MAXSOCKBUF) 1453 if (sl.length () > MAXSOCKBUF)
2436 { 1454 {
2437 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1455 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2438 fatal (0); 1456 fatal (0);
2439 } 1457 }
2440 1458
2441 /* finally, we can send the packet */ 1459 /* finally, we can send the packet */
1460 pl->ns->flush_fx ();
2442 pl->socket->send_packet (sl); 1461 pl->ns->send_packet (sl);
2443} 1462}
2444 1463

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines