ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.2 by root, Thu Aug 17 20:23:32 2006 UTC vs.
Revision 1.29 by root, Wed Dec 13 21:27:09 2006 UTC

1/*
2 * static char *rcsid_init_c =
3 * "$Id: request.C,v 1.2 2006/08/17 20:23:32 root Exp $";
4 */
5
6/* 1/*
7 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
8 3
9 Copyright (C) 2001 Mark Wedel 4 Copyright (C) 2001 Mark Wedel
10 Copyright (C) 1992 Frank Tore Johansen 5 Copyright (C) 1992 Frank Tore Johansen
… …
21 16
22 You should have received a copy of the GNU General Public License 17 You should have received a copy of the GNU General Public License
23 along with this program; if not, write to the Free Software 18 along with this program; if not, write to the Free Software
24 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
25 20
26 The author can be reached via e-mail to crossfire-devel@real-time.com 21 The author can be reached via e-mail to <crossfire@schmorp.de>
27*/ 22*/
28 23
29/** 24/**
30 * \file 25 * \file
31 * Client handling. 26 * Client handling.
… …
49 * operations 44 * operations
50 * 45 *
51 * esrv_map_doneredraw finishes the map update, and ships across the 46 * esrv_map_doneredraw finishes the map update, and ships across the
52 * map updates. 47 * map updates.
53 * 48 *
54 * esrv_map_scroll tells the client to scroll the map, and does similarily
55 * for the locally cached copy.
56 */ 49 */
57 50
58#include <global.h> 51#include <global.h>
59#include <sproto.h> 52#include <sproto.h>
60 53
… …
64#include <commands.h> 57#include <commands.h>
65 58
66/* This block is basically taken from socket.c - I assume if it works there, 59/* This block is basically taken from socket.c - I assume if it works there,
67 * it should work here. 60 * it should work here.
68 */ 61 */
69#ifndef WIN32 /* ---win32 exclude unix headers */
70#include <sys/types.h> 62#include <sys/types.h>
71#include <sys/time.h> 63#include <sys/time.h>
72#include <sys/socket.h> 64#include <sys/socket.h>
73#include <netinet/in.h> 65#include <netinet/in.h>
74#include <netdb.h> 66#include <netdb.h>
75#endif /* win32 */
76 67
77#ifdef HAVE_UNISTD_H 68#ifdef HAVE_UNISTD_H
78#include <unistd.h> 69# include <unistd.h>
79#endif 70#endif
80 71
81#ifdef HAVE_SYS_TIME_H 72#ifdef HAVE_SYS_TIME_H
82#include <sys/time.h> 73# include <sys/time.h>
83#endif 74#endif
84 75
85#include "sounds.h" 76#include "sounds.h"
86 77
87/** 78/**
88 * This table translates the attack numbers as used within the 79 * This table translates the attack numbers as used within the
89 * program to the value we use when sending STATS command to the 80 * program to the value we use when sending STATS command to the
90 * client. If a value is -1, then we don't send that to the 81 * client. If a value is -1, then we don't send that to the
91 * client. 82 * client.
92 */ 83 */
93short atnr_cs_stat[NROFATTACKS] = {CS_STAT_RES_PHYS, 84short atnr_cs_stat[NROFATTACKS] = { CS_STAT_RES_PHYS,
94 CS_STAT_RES_MAG,CS_STAT_RES_FIRE, CS_STAT_RES_ELEC, 85 CS_STAT_RES_MAG, CS_STAT_RES_FIRE, CS_STAT_RES_ELEC,
95 CS_STAT_RES_COLD, CS_STAT_RES_CONF, CS_STAT_RES_ACID, 86 CS_STAT_RES_COLD, CS_STAT_RES_CONF, CS_STAT_RES_ACID,
96 CS_STAT_RES_DRAIN, -1 /* weaponmagic */, 87 CS_STAT_RES_DRAIN, -1 /* weaponmagic */ ,
97 CS_STAT_RES_GHOSTHIT, CS_STAT_RES_POISON, 88 CS_STAT_RES_GHOSTHIT, CS_STAT_RES_POISON,
98 CS_STAT_RES_SLOW, CS_STAT_RES_PARA, CS_STAT_TURN_UNDEAD, 89 CS_STAT_RES_SLOW, CS_STAT_RES_PARA, CS_STAT_TURN_UNDEAD,
99 CS_STAT_RES_FEAR, -1 /* Cancellation */, 90 CS_STAT_RES_FEAR, -1 /* Cancellation */ ,
100 CS_STAT_RES_DEPLETE, CS_STAT_RES_DEATH, 91 CS_STAT_RES_DEPLETE, CS_STAT_RES_DEATH,
101 -1 /* Chaos */, -1 /* Counterspell */, 92 -1 /* Chaos */ , -1 /* Counterspell */ ,
102 -1 /* Godpower */, CS_STAT_RES_HOLYWORD, 93 -1 /* Godpower */ , CS_STAT_RES_HOLYWORD,
103 CS_STAT_RES_BLIND, 94 CS_STAT_RES_BLIND,
104 -1, /* Internal */ 95 -1, /* Internal */
105 -1, /* life stealing */ 96 -1, /* life stealing */
106 -1 /* Disease - not fully done yet */ 97 -1 /* Disease - not fully done yet */
107}; 98};
108 99
109static void 100static void
110socket_map_scroll (NewSocket *ns, int dx, int dy) 101socket_map_scroll (NewSocket * ns, int dx, int dy)
111{ 102{
112 struct Map newmap; 103 struct Map newmap;
113 int x,y, mx, my; 104 int x, y, mx, my;
114 105
115 { 106 {
116 char buf[MAXSOCKBUF]; 107 char buf[MAXSOCKBUF];
117 108
118 sprintf(buf,"map_scroll %d %d", dx, dy); 109 sprintf (buf, "map_scroll %d %d", dx, dy);
119 Write_String_To_Socket(ns, buf, strlen (buf)); 110 Write_String_To_Socket (ns, buf, strlen (buf));
120 } 111 }
121 112
122 /* If we are using the Map1aCmd, we may in fact send 113 /* If we are using the Map1aCmd, we may in fact send
123 * head information that is outside the viewable map. 114 * head information that is outside the viewable map.
124 * So set the mx,my to the max value we want to 115 * So set the mx,my to the max value we want to
125 * look for. Removed code to do so - it caused extra 116 * look for. Removed code to do so - it caused extra
126 * complexities for the client, and probably doesn't make 117 * complexities for the client, and probably doesn't make
127 * that much difference in bandwidth. 118 * that much difference in bandwidth.
128 */ 119 */
129 mx = ns->mapx; 120 mx = ns->mapx;
130 my = ns->mapy; 121 my = ns->mapy;
131 122
132 if (ns->mapmode == Map1aCmd) { 123 if (ns->mapmode == Map1aCmd)
124 {
133 mx += MAX_HEAD_OFFSET; 125 mx += MAX_HEAD_OFFSET;
134 my += MAX_HEAD_OFFSET; 126 my += MAX_HEAD_OFFSET;
135 } 127 }
136 128
137 /* the x and y here are coordinates for the new map, i.e. if we moved 129 /* the x and y here are coordinates for the new map, i.e. if we moved
138 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 130 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
139 * if the destination x or y coordinate is outside the viewable 131 * if the destination x or y coordinate is outside the viewable
140 * area, we clear the values - otherwise, the old values 132 * area, we clear the values - otherwise, the old values
141 * are preserved, and the check_head thinks it needs to clear them. 133 * are preserved, and the check_head thinks it needs to clear them.
142 */ 134 */
143 for(x=0; x<mx; x++) { 135 for (x = 0; x < mx; x++)
144 for(y=0; y<my; y++) { 136 {
137 for (y = 0; y < my; y++)
138 {
145 if(x >= ns->mapx || y >= ns->mapy) { 139 if (x >= ns->mapx || y >= ns->mapy)
146 /* clear cells outside the viewable area */ 140 /* clear cells outside the viewable area */
147 memset(&newmap.cells[x][y], 0, sizeof(struct MapCell)); 141 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
148 }
149 else if ((x+dx) < 0 || (x+dx) >= ns->mapx || (y+dy) < 0 || (y + dy) >= ns->mapy) { 142 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
150 /* clear newly visible tiles within the viewable area */ 143 /* clear newly visible tiles within the viewable area */
151 memset(&(newmap.cells[x][y]), 0, sizeof(struct MapCell)); 144 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
145 else
146 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
147 }
152 } 148 }
153 else {
154 memcpy(&(newmap.cells[x][y]),
155 &(ns->lastmap.cells[x+dx][y+dy]),sizeof(struct MapCell));
156 }
157 }
158 }
159 149
160 memcpy(&(ns->lastmap), &newmap,sizeof(struct Map)); 150 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
161 151
162 /* Make sure that the next "map1" command will be sent (even if it is 152 /* Make sure that the next "map1" command will be sent (even if it is
163 * empty). 153 * empty).
164 */ 154 */
165 ns->sent_scroll = 1; 155 ns->sent_scroll = 1;
156}
157
158static void
159clear_map (player *pl)
160{
161 NewSocket & socket = pl->socket;
162
163 memset (&socket.lastmap, 0, sizeof (socket.lastmap));
164
165 if (socket.newmapcmd == 1)
166 Write_String_To_Socket (&socket, "newmap", 6);
167
168 socket.update_look = 1;
169 socket.look_position = 0;
166} 170}
167 171
168/** check for map change and send new map data */ 172/** check for map change and send new map data */
169static void 173static void
170check_map_change (player *pl) 174check_map_change (player *pl)
171{ 175{
172 NewSocket &socket = pl->socket; 176 NewSocket & socket = pl->socket;
173 object *ob = pl->ob; 177 object *ob = pl->ob;
174 char buf[MAX_BUF]; /* eauugggh */ 178 char buf[MAX_BUF]; /* eauugggh */
175 179
176 if (socket.current_map != ob->map) 180 if (socket.current_map != ob->map)
177 { 181 {
178 socket.current_map = ob->map; 182 socket.current_map = ob->map;
179 memset (&socket.lastmap, 0, sizeof(socket.lastmap));
180 183
181 if (socket.newmapcmd == 1) 184 clear_map (pl);
182 Write_String_To_Socket (&socket, "newmap", 6);
183
184 socket.update_look = 1;
185 socket.look_position =0;
186 185
187 if (socket.mapinfocmd) 186 if (socket.mapinfocmd)
188 { 187 {
189 if (ob->map && ob->map->path [0]) 188 if (ob->map && ob->map->path[0])
190 { 189 {
191 int flags = 0; 190 int flags = 0;
192 191
193 if (ob->map->tile_path [0]) flags |= 1; 192 if (ob->map->tile_path[0])
193 flags |= 1;
194 if (ob->map->tile_path [1]) flags |= 2; 194 if (ob->map->tile_path[1])
195 flags |= 2;
195 if (ob->map->tile_path [2]) flags |= 4; 196 if (ob->map->tile_path[2])
197 flags |= 4;
196 if (ob->map->tile_path [3]) flags |= 8; 198 if (ob->map->tile_path[3])
199 flags |= 8;
197 200
198 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s", 201 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s",
199 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, 202 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path);
200 ob->map->width, ob->map->height, ob->map->path);
201 } 203 }
202 else 204 else
203 snprintf (buf, MAX_BUF, "mapinfo current"); 205 snprintf (buf, MAX_BUF, "mapinfo current");
204 206
205 Write_String_To_Socket (&socket, buf, strlen (buf)); 207 Write_String_To_Socket (&socket, buf, strlen (buf));
206 } 208 }
207 } 209 }
208 else if (socket.current_x != ob->x || socket.current_y != ob->y) 210 else if (socket.current_x != ob->x || socket.current_y != ob->y)
209 { 211 {
212 int dx = ob->x - socket.current_x;
213 int dy = ob->y - socket.current_y;
214
215 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
216 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
217 else
218 {
210 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 219 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
211 socket.update_look = 1; 220 socket.update_look = 1;
212 socket.look_position = 0; 221 socket.look_position = 0;
222 }
213 } 223 }
214 224
215 socket.current_x = ob->x; 225 socket.current_x = ob->x;
216 socket.current_y = ob->y; 226 socket.current_y = ob->y;
217} 227}
218 228
229void
219void ExtCmd (char *buf, int len, player *pl) 230ExtCmd (char *buf, int len, player *pl)
220{ 231{
221 execute_global_event (EVENT_EXTCMD, pl, buf, len); 232 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
222} 233}
223 234
235void
224void MapInfoCmd (char *buf, int len, player *pl) 236MapInfoCmd (char *buf, int len, player *pl)
225{ 237{
226 // <mapinfo tag spatial tile-path 238 // <mapinfo tag spatial tile-path
227 // >mapinfo tag spatial flags x y w h hash 239 // >mapinfo tag spatial flags x y w h hash
228 240
229 char bigbuf[MAX_BUF], *cp, *token; 241 char bigbuf[MAX_BUF], *token;
230 242
231 token = buf; 243 token = buf;
232 // copy token 244 // copy token
233 if (!(buf = strchr (buf, ' '))) 245 if (!(buf = strchr (buf, ' ')))
234 return; 246 return;
… …
238 if (!strncmp (buf, "spatial ", 8)) 250 if (!strncmp (buf, "spatial ", 8))
239 { 251 {
240 buf += 8; 252 buf += 8;
241 253
242 // initial map and its origin 254 // initial map and its origin
243 mapstruct *map = pl->ob->map; 255 maptile *map = pl->ob->map;
244 sint16 dx, dy; 256 sint16 dx, dy;
245 int mapx = pl->socket.mapx / 2 - pl->ob->x; 257 int mapx = pl->socket.mapx / 2 - pl->ob->x;
246 int mapy = pl->socket.mapy / 2 - pl->ob->y; 258 int mapy = pl->socket.mapy / 2 - pl->ob->y;
247 int max_distance = 8; // limit maximum path length to something generous 259 int max_distance = 8; // limit maximum path length to something generous
248 260
249 while (*buf && map && max_distance) 261 while (*buf && map && max_distance)
250 { 262 {
251 int dir = *buf++; 263 int dir = *buf++;
252 264
253 switch (dir) 265 switch (dir)
254 { 266 {
255 case '1': 267 case '1':
268 dx = 0;
269 dy = -1;
256 dx = 0; dy = -1; map = get_map_from_coord (map, &dx, &dy); 270 map = get_map_from_coord (map, &dx, &dy);
257 map && (mapy -= map->height); 271 map && (mapy -= map->height);
258 break; 272 break;
259 case '2': 273 case '2':
260 mapx += map->width; 274 mapx += map->width;
275 dx = map->width;
276 dy = 0;
261 dx = map->width; dy = 0; map = get_map_from_coord (map, &dx, &dy); 277 map = get_map_from_coord (map, &dx, &dy);
262 break; 278 break;
263 case '3': 279 case '3':
264 mapy += map->height; 280 mapy += map->height;
281 dx = 0;
282 dy = map->height;
265 dx = 0; dy = map->height; map = get_map_from_coord (map, &dx, &dy); 283 map = get_map_from_coord (map, &dx, &dy);
266 break; 284 break;
267 case '4': 285 case '4':
286 dx = -1;
287 dy = 0;
268 dx = -1; dy = 0; map = get_map_from_coord (map, &dx, &dy); 288 map = get_map_from_coord (map, &dx, &dy);
269 map && (mapx -= map->width); 289 map && (mapx -= map->width);
270 break; 290 break;
271 } 291 }
272 292
273 --max_distance; 293 --max_distance;
274 } 294 }
275 295
276 if (!max_distance) 296 if (!max_distance)
277 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token); 297 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
278 else if (map && map->path [0]) 298 else if (map && map->path[0])
279 { 299 {
280 int flags = 0; 300 int flags = 0;
281 301
282 if (map->tile_path [0]) flags |= 1; 302 if (map->tile_path[0])
303 flags |= 1;
283 if (map->tile_path [1]) flags |= 2; 304 if (map->tile_path[1])
305 flags |= 2;
284 if (map->tile_path [2]) flags |= 4; 306 if (map->tile_path[2])
307 flags |= 4;
285 if (map->tile_path [3]) flags |= 8; 308 if (map->tile_path[3])
309 flags |= 8;
286 310
287 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", 311 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, map->path);
288 token, flags, mapx, mapy,
289 map->width, map->height, map->path);
290 } 312 }
291 else 313 else
292 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 314 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token);
293 } 315 }
294 else 316 else
295 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 317 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
296 318
297 Write_String_To_Socket (&pl->socket, bigbuf, strlen (bigbuf)); 319 Write_String_To_Socket (&pl->socket, bigbuf, strlen (bigbuf));
298} 320}
299 321
300/** This is the Setup cmd - easy first implementation */ 322/** This is the Setup cmd - easy first implementation */
323void
301void SetUp(char *buf, int len, NewSocket *ns) 324SetUp (char *buf, int len, NewSocket * ns)
302{ 325{
303 int s, slen; 326 int s, slen;
304 char *cmd, *param, cmdback[HUGE_BUF]; 327 char *cmd, *param, cmdback[HUGE_BUF];
305 328
306 /* run through the cmds of setup 329 /* run through the cmds of setup
307 * syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ... 330 * syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
308 * 331 *
309 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown 332 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
310 * The client then must sort this out 333 * The client then must sort this out
311 */ 334 */
312 335
313 LOG(llevInfo,"Get SetupCmd:: %s\n", buf); 336 LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
314 strcpy(cmdback,"setup"); 337 strcpy (cmdback, "setup");
315 for(s=0;s<len; ) { 338 for (s = 0; s < len;)
339 {
316 340
317 cmd = &buf[s]; 341 cmd = &buf[s];
318 342
319 /* find the next space, and put a null there */ 343 /* find the next space, and put a null there */
320 for(;buf[s] && buf[s] != ' ';s++) ; 344 for (; buf[s] && buf[s] != ' '; s++);
321 buf[s++]=0; 345 buf[s++] = 0;
322 while (buf[s] == ' ') s++; 346 while (buf[s] == ' ')
347 s++;
323 348
324 if(s>=len) 349 if (s >= len)
325 break; 350 break;
326 351
327 param = &buf[s]; 352 param = &buf[s];
328 353
329 for(;buf[s] && buf[s] != ' ';s++) ; 354 for (; buf[s] && buf[s] != ' '; s++);
330 buf[s++]=0; 355 buf[s++] = 0;
331 while (buf[s] == ' ') s++; 356 while (buf[s] == ' ')
332 357 s++;
358
333 slen = strlen(cmdback); 359 slen = strlen (cmdback);
334 safe_strcat(cmdback, " ", &slen, HUGE_BUF); 360 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
335 safe_strcat(cmdback, cmd, &slen, HUGE_BUF); 361 safe_strcat (cmdback, cmd, &slen, HUGE_BUF);
336 safe_strcat(cmdback, " ", &slen, HUGE_BUF); 362 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
337 363
338 if (!strcmp(cmd,"sound")) { 364 if (!strcmp (cmd, "sound"))
365 {
339 ns->sound = atoi(param); 366 ns->sound = atoi (param);
340 safe_strcat(cmdback, param, &slen, HUGE_BUF); 367 safe_strcat (cmdback, param, &slen, HUGE_BUF);
341 } 368 }
342 else if (!strcmp(cmd,"exp64")) { 369 else if (!strcmp (cmd, "exp64"))
370 {
343 ns->exp64 = atoi(param); 371 ns->exp64 = atoi (param);
344 safe_strcat(cmdback, param, &slen, HUGE_BUF); 372 safe_strcat (cmdback, param, &slen, HUGE_BUF);
373 }
345 } else if (!strcmp(cmd, "spellmon")) { 374 else if (!strcmp (cmd, "spellmon"))
375 {
346 ns->monitor_spells = atoi(param); 376 ns->monitor_spells = atoi (param);
347 safe_strcat(cmdback, param, &slen, HUGE_BUF); 377 safe_strcat (cmdback, param, &slen, HUGE_BUF);
378 }
348 } else if (!strcmp(cmd,"darkness")) { 379 else if (!strcmp (cmd, "darkness"))
380 {
349 ns->darkness = atoi(param); 381 ns->darkness = atoi (param);
350 safe_strcat(cmdback, param, &slen, HUGE_BUF); 382 safe_strcat (cmdback, param, &slen, HUGE_BUF);
383 }
351 } else if (!strcmp(cmd,"map1cmd")) { 384 else if (!strcmp (cmd, "map1cmd"))
352 if (atoi(param)) ns->mapmode = Map1Cmd; 385 {
386 if (atoi (param))
387 ns->mapmode = Map1Cmd;
353 /* if beyond this size, need to use map1cmd no matter what */ 388 /* if beyond this size, need to use map1cmd no matter what */
354 if (ns->mapx>11 || ns->mapy>11) ns->mapmode = Map1Cmd; 389 if (ns->mapx > 11 || ns->mapy > 11)
390 ns->mapmode = Map1Cmd;
355 safe_strcat(cmdback, ns->mapmode == Map1Cmd?"1":"0", &slen, HUGE_BUF); 391 safe_strcat (cmdback, ns->mapmode == Map1Cmd ? "1" : "0", &slen, HUGE_BUF);
392 }
356 } else if (!strcmp(cmd,"map1acmd")) { 393 else if (!strcmp (cmd, "map1acmd"))
357 if (atoi(param)) ns->mapmode = Map1aCmd; 394 {
395 if (atoi (param))
396 ns->mapmode = Map1aCmd;
358 /* if beyond this size, need to use map1acmd no matter what */ 397 /* if beyond this size, need to use map1acmd no matter what */
359 if (ns->mapx>11 || ns->mapy>11) ns->mapmode = Map1aCmd; 398 if (ns->mapx > 11 || ns->mapy > 11)
399 ns->mapmode = Map1aCmd;
360 safe_strcat(cmdback, ns->mapmode == Map1aCmd?"1":"0", &slen, HUGE_BUF); 400 safe_strcat (cmdback, ns->mapmode == Map1aCmd ? "1" : "0", &slen, HUGE_BUF);
401 }
361 } else if (!strcmp(cmd,"newmapcmd")) { 402 else if (!strcmp (cmd, "newmapcmd"))
403 {
362 ns->newmapcmd= atoi(param); 404 ns->newmapcmd = atoi (param);
363 safe_strcat(cmdback, param, &slen, HUGE_BUF); 405 safe_strcat (cmdback, param, &slen, HUGE_BUF);
364// } else if (!strcmp(cmd,"plugincmd")) { 406// } else if (!strcmp(cmd,"plugincmd")) {
365// ns->plugincmd = atoi(param); 407// ns->plugincmd = atoi(param);
366// safe_strcat(cmdback, param, &slen, HUGE_BUF); 408// safe_strcat(cmdback, param, &slen, HUGE_BUF);
409 }
367 } else if (!strcmp(cmd,"mapinfocmd")) { 410 else if (!strcmp (cmd, "mapinfocmd"))
411 {
368 ns->mapinfocmd = atoi(param); 412 ns->mapinfocmd = atoi (param);
369 safe_strcat(cmdback, "1", &slen, HUGE_BUF); 413 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
414 }
370 } else if (!strcmp(cmd,"extcmd")) { 415 else if (!strcmp (cmd, "extcmd"))
416 {
371 ns->extcmd = atoi(param); 417 ns->extcmd = atoi (param);
372 safe_strcat(cmdback, "1", &slen, HUGE_BUF); 418 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
419 }
420 else if (!strcmp (cmd, "extmap"))
421 {
422 ns->extmap = atoi (param);
423 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
424 }
373 } else if (!strcmp(cmd,"facecache")) { 425 else if (!strcmp (cmd, "facecache"))
426 {
374 ns->facecache = atoi(param); 427 ns->facecache = atoi (param);
375 safe_strcat(cmdback, param, &slen, HUGE_BUF); 428 safe_strcat (cmdback, param, &slen, HUGE_BUF);
429 }
376 } else if (!strcmp(cmd,"faceset")) { 430 else if (!strcmp (cmd, "faceset"))
431 {
377 char tmpbuf[20]; 432 char tmpbuf[20];
378 int q = atoi(param); 433 int q = atoi (param);
379 434
380 if (is_valid_faceset(q)) 435 if (is_valid_faceset (q))
381 ns->faceset=q; 436 ns->faceset = q;
382 sprintf(tmpbuf,"%d", ns->faceset); 437 sprintf (tmpbuf, "%d", ns->faceset);
383 safe_strcat(cmdback, tmpbuf, &slen, HUGE_BUF); 438 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
384 /* if the client is using faceset, it knows about image2 command */ 439 /* if the client is using faceset, it knows about image2 command */
385 ns->image2=1; 440 ns->image2 = 1;
441 }
386 } else if (!strcmp(cmd,"itemcmd")) { 442 else if (!strcmp (cmd, "itemcmd"))
443 {
387 /* Version of the item protocol command to use. Currently, 444 /* Version of the item protocol command to use. Currently,
388 * only supported versions are 1 and 2. Using a numeric 445 * only supported versions are 1 and 2. Using a numeric
389 * value will make it very easy to extend this in the future. 446 * value will make it very easy to extend this in the future.
390 */ 447 */
391 char tmpbuf[20]; 448 char tmpbuf[20];
392 int q = atoi(param); 449 int q = atoi (param);
393 if (q<1 || q>2) { 450
394 strcpy(tmpbuf,"FALSE"); 451 if (q < 1 || q > 2)
395 } else { 452 {
396 ns->itemcmd = q; 453 strcpy (tmpbuf, "FALSE");
454 }
455 else
456 {
457 ns->itemcmd = q;
397 sprintf(tmpbuf,"%d", ns->itemcmd); 458 sprintf (tmpbuf, "%d", ns->itemcmd);
398 } 459 }
399 safe_strcat(cmdback, tmpbuf, &slen, HUGE_BUF); 460 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
461 }
400 } else if (!strcmp(cmd,"mapsize")) { 462 else if (!strcmp (cmd, "mapsize"))
463 {
401 int x, y=0; 464 int x, y = 0;
402 char tmpbuf[MAX_BUF], *cp; 465 char tmpbuf[MAX_BUF], *cp;
403 466
404 x = atoi(param); 467 x = atoi (param);
405 for (cp = param; *cp!=0; cp++) 468 for (cp = param; *cp != 0; cp++)
406 if (*cp == 'x' || *cp == 'X') { 469 if (*cp == 'x' || *cp == 'X')
407 y = atoi(cp+1); 470 {
408 break; 471 y = atoi (cp + 1);
409 } 472 break;
473 }
410 if (x < 9 || y < 9 || x>MAP_CLIENT_X || y > MAP_CLIENT_Y) { 474 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
475 {
411 sprintf(tmpbuf," %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y); 476 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
412 safe_strcat(cmdback, tmpbuf, &slen, HUGE_BUF); 477 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
413 } else { 478 }
414 ns->mapx = x; 479 else
415 ns->mapy = y; 480 {
481 ns->mapx = x;
482 ns->mapy = y;
416 /* better to send back what we are really using and not the 483 /* better to send back what we are really using and not the
417 * param as given to us in case it gets parsed differently. 484 * param as given to us in case it gets parsed differently.
418 */ 485 */
419 sprintf(tmpbuf,"%dx%d", x,y); 486 sprintf (tmpbuf, "%dx%d", x, y);
420 safe_strcat(cmdback, tmpbuf, &slen, HUGE_BUF); 487 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
421 /* If beyond this size and still using orig map command, need to 488 /* If beyond this size and still using orig map command, need to
422 * go to map1cmd. 489 * go to map1cmd.
423 */ 490 */
424 if ((x>11 || y>11) && ns->mapmode == Map0Cmd) ns->mapmode = Map1Cmd; 491 if ((x > 11 || y > 11) && ns->mapmode == Map0Cmd)
425 } 492 ns->mapmode = Map1Cmd;
493 }
494 }
426 } else if (!strcmp(cmd,"extendedMapInfos")) { 495 else if (!strcmp (cmd, "extendedMapInfos"))
496 {
427 /* Added by tchize 497 /* Added by tchize
428 * prepare to use the mapextended command 498 * prepare to use the mapextended command
429 */ 499 */
430 char tmpbuf[20]; 500 char tmpbuf[20];
501
431 ns->ext_mapinfos = (atoi(param)); 502 ns->ext_mapinfos = (atoi (param));
432 sprintf(tmpbuf,"%d", ns->ext_mapinfos); 503 sprintf (tmpbuf, "%d", ns->ext_mapinfos);
433 safe_strcat(cmdback, tmpbuf, &slen, HUGE_BUF); 504 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
505 }
434 } else if (!strcmp(cmd,"extendedTextInfos")) { 506 else if (!strcmp (cmd, "extendedTextInfos"))
507 {
435 /* Added by tchize 508 /* Added by tchize
436 * prepare to use the extended text commands 509 * prepare to use the extended text commands
437 * Client toggle this to non zero to get exttext 510 * Client toggle this to non zero to get exttext
438 */ 511 */
439 char tmpbuf[20]; 512 char tmpbuf[20];
440 513
441 ns->has_readable_type = (atoi(param)); 514 ns->has_readable_type = (atoi (param));
442 sprintf(tmpbuf,"%d", ns->has_readable_type); 515 sprintf (tmpbuf, "%d", ns->has_readable_type);
443 safe_strcat(cmdback, tmpbuf, &slen, HUGE_BUF); 516 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
444 } else { 517 }
518 else
519 {
445 /* Didn't get a setup command we understood - 520 /* Didn't get a setup command we understood -
446 * report a failure to the client. 521 * report a failure to the client.
447 */ 522 */
448 safe_strcat(cmdback, "FALSE", &slen, HUGE_BUF); 523 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
449 } 524 }
450 } /* for processing all the setup commands */ 525 } /* for processing all the setup commands */
451 LOG(llevInfo,"SendBack SetupCmd:: %s\n", cmdback); 526 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
452 Write_String_To_Socket(ns, cmdback, strlen(cmdback)); 527 Write_String_To_Socket (ns, cmdback, strlen (cmdback));
453} 528}
454 529
455/** 530/**
456 * The client has requested to be added to the game. 531 * The client has requested to be added to the game.
457 * This is what takes care of it. We tell the client how things worked out. 532 * This is what takes care of it. We tell the client how things worked out.
458 * I am not sure if this file is the best place for this function. however, 533 * I am not sure if this file is the best place for this function. however,
459 * it either has to be here or init_sockets needs to be exported. 534 * it either has to be here or init_sockets needs to be exported.
460 */ 535 */
536void
461void AddMeCmd(char *buf, int len, NewSocket *ns) 537AddMeCmd (char *buf, int len, NewSocket * ns)
462{ 538{
463 Settings oldsettings; 539 Settings oldsettings;
540
464 oldsettings=settings; 541 oldsettings = settings;
465 if (ns->status != Ns_Add || add_player(ns)) { 542 if (ns->status != Ns_Add || add_player (ns))
543 {
466 Write_String_To_Socket(ns, "addme_failed",12); 544 Write_String_To_Socket (ns, "addme_failed", 12);
467 } else { 545 }
546 else
547 {
468 /* Basically, the add_player copies the socket structure into 548 /* Basically, the add_player copies the socket structure into
469 * the player structure, so this one (which is from init_sockets) 549 * the player structure, so this one (which is from init_sockets)
470 * is not needed anymore. The write below should still work, as the 550 * is not needed anymore. The write below should still work, as the
471 * stuff in ns is still relevant. 551 * stuff in ns is still relevant.
472 */ 552 */
473 Write_String_To_Socket(ns, "addme_success",13); 553 Write_String_To_Socket (ns, "addme_success", 13);
474 socket_info.nconns--; 554 socket_info.nconns--;
475 ns->status = Ns_Avail; 555 ns->status = Ns_Avail;
476 } 556 }
477 settings=oldsettings; 557 settings = oldsettings;
478} 558}
479 559
480/** Reply to ExtendedInfos command */ 560/** Reply to ExtendedInfos command */
561void
481void ToggleExtendedInfos (char *buf, int len, NewSocket *ns){ 562ToggleExtendedInfos (char *buf, int len, NewSocket * ns)
563{
482 char cmdback[MAX_BUF]; 564 char cmdback[MAX_BUF];
483 char command[50]; 565 char command[50];
484 int info,nextinfo; 566 int info, nextinfo;
567
485 cmdback[0]='\0'; 568 cmdback[0] = '\0';
486 nextinfo=0; 569 nextinfo = 0;
570
487 while (1){ 571 while (1)
572 {
488 /* 1. Extract an info*/ 573 /* 1. Extract an info */
489 info=nextinfo; 574 info = nextinfo;
575
490 while ( (info<len) && (buf[info]==' ') ) info++; 576 while ((info < len) && (buf[info] == ' '))
577 info++;
578
491 if (info>=len) 579 if (info >= len)
492 break; 580 break;
581
493 nextinfo=info+1; 582 nextinfo = info + 1;
583
494 while ( (nextinfo<len) && (buf[nextinfo]!=' ') ) 584 while ((nextinfo < len) && (buf[nextinfo] != ' '))
495 nextinfo++; 585 nextinfo++;
586
496 if (nextinfo-info>=49) /*Erroneous info asked*/ 587 if (nextinfo - info >= 49) /*Erroneous info asked */
497 continue; 588 continue;
589
498 strncpy (command,&(buf[info]),nextinfo-info); 590 strncpy (command, &(buf[info]), nextinfo - info);
499 command[nextinfo-info]='\0'; 591
500 /* 2. Interpret info*/ 592 /* 2. Interpret info */
501 if (!strcmp("smooth",command)){ 593 if (!strcmp ("smooth", command))
502 /* Toggle smoothing*/ 594 /* Toggle smoothing */
503 ns->EMI_smooth=!ns->EMI_smooth; 595 ns->EMI_smooth = !ns->EMI_smooth;
504 }else{ 596 else
505 /*bad value*/ 597 /*bad value */;
506 } 598
507 /*3. Next info*/ 599 /*3. Next info */
508 } 600 }
601
509 strcpy (cmdback,"ExtendedInfoSet"); 602 strcpy (cmdback, "ExtendedInfoSet");
603
510 if (ns->EMI_smooth){ 604 if (ns->EMI_smooth)
605 {
511 strcat (cmdback," "); 606 strcat (cmdback, " ");
512 strcat (cmdback,"smoothing"); 607 strcat (cmdback, "smoothing");
513 } 608 }
609
514 Write_String_To_Socket(ns, cmdback,strlen(cmdback)); 610 Write_String_To_Socket (ns, cmdback, strlen (cmdback));
515} 611}
612
516/* 613/*
517#define MSG_TYPE_BOOK 1 614#define MSG_TYPE_BOOK 1
518#define MSG_TYPE_CARD 2 615#define MSG_TYPE_CARD 2
519#define MSG_TYPE_PAPER 3 616#define MSG_TYPE_PAPER 3
520#define MSG_TYPE_SIGN 4 617#define MSG_TYPE_SIGN 4
521#define MSG_TYPE_MONUMENT 5 618#define MSG_TYPE_MONUMENT 5
522#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 619#define MSG_TYPE_SCRIPTED_DIALOG 6*/
620
523/** Reply to ExtendedInfos command */ 621/** Reply to ExtendedInfos command */
622void
524void ToggleExtendedText (char *buf, int len, NewSocket *ns){ 623ToggleExtendedText (char *buf, int len, NewSocket * ns)
624{
525 char cmdback[MAX_BUF]; 625 char cmdback[MAX_BUF];
526 char temp[10]; 626 char temp[10];
527 char command[50]; 627 char command[50];
528 int info,nextinfo,i,flag; 628 int info, nextinfo, i, flag;
629
529 cmdback[0]='\0'; 630 cmdback[0] = '\0';
631
530 nextinfo=0; 632 nextinfo = 0;
531 while (1){ 633 while (1)
634 {
532 /* 1. Extract an info*/ 635 /* 1. Extract an info */
533 info=nextinfo; 636 info = nextinfo;
637
534 while ( (info<len) && (buf[info]==' ') ) info++; 638 while ((info < len) && (buf[info] == ' '))
639 info++;
640
535 if (info>=len) 641 if (info >= len)
536 break; 642 break;
643
537 nextinfo=info+1; 644 nextinfo = info + 1;
645
538 while ( (nextinfo<len) && (buf[nextinfo]!=' ') ) 646 while ((nextinfo < len) && (buf[nextinfo] != ' '))
539 nextinfo++; 647 nextinfo++;
648
540 if (nextinfo-info>=49) /*Erroneous info asked*/ 649 if (nextinfo - info >= 49) /*Erroneous info asked */
541 continue; 650 continue;
651
542 strncpy (command,&(buf[info]),nextinfo-info); 652 strncpy (command, &(buf[info]), nextinfo - info);
543 command[nextinfo-info]='\0'; 653 command[nextinfo - info] = '\0';
544 /* 2. Interpret info*/ 654 /* 2. Interpret info */
545 i = sscanf(command,"%d",&flag); 655 i = sscanf (command, "%d", &flag);
656
546 if ( (i==1) && (flag>0) && (flag<=MSG_TYPE_LAST)) 657 if ((i == 1) && (flag > 0) && (flag <= MSG_TYPE_LAST))
547 ns->supported_readables|=(1<<flag); 658 ns->supported_readables |= (1 << flag);
548 /*3. Next info*/ 659 /*3. Next info */
549 } 660 }
661
550 /* Send resulting state */ 662 /* Send resulting state */
551 strcpy (cmdback,"ExtendedTextSet"); 663 strcpy (cmdback, "ExtendedTextSet");
664
552 for (i=0;i<=MSG_TYPE_LAST;i++) 665 for (i = 0; i <= MSG_TYPE_LAST; i++)
553 if (ns->supported_readables &(1<<i)){ 666 if (ns->supported_readables & (1 << i))
667 {
554 strcat (cmdback," "); 668 strcat (cmdback, " ");
555 snprintf(temp,sizeof(temp),"%d",i); 669 snprintf (temp, sizeof (temp), "%d", i);
556 strcat (cmdback,temp); 670 strcat (cmdback, temp);
557 } 671 }
672
558 Write_String_To_Socket(ns, cmdback,strlen(cmdback)); 673 Write_String_To_Socket (ns, cmdback, strlen (cmdback));
559} 674}
560 675
561/** 676/**
562 * A lot like the old AskSmooth (in fact, now called by AskSmooth). 677 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
563 * Basically, it makes no sense to wait for the client to request a 678 * Basically, it makes no sense to wait for the client to request a
564 * a piece of data from us that we know the client wants. So 679 * a piece of data from us that we know the client wants. So
565 * if we know the client wants it, might as well push it to the 680 * if we know the client wants it, might as well push it to the
566 * client. 681 * client.
567 */ 682 */
683static void
568static void SendSmooth(NewSocket *ns, uint16 face) { 684SendSmooth (NewSocket * ns, uint16 face)
685{
569 uint16 smoothface; 686 uint16 smoothface;
570 unsigned char reply[MAX_BUF];
571 SockList sl;
572 687
573 /* If we can't find a face, return and set it so we won't try to send this 688 /* If we can't find a face, return and set it so we won't try to send this
574 * again. 689 * again.
575 */ 690 */
576 if ((!FindSmooth (face, &smoothface)) && 691 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
577 (!FindSmooth ( smooth_face->number, &smoothface))) { 692 {
578 693
579 LOG(llevError,"could not findsmooth for %d. Neither default (%s)\n",face,smooth_face->name); 694 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name);
580 ns->faces_sent[face] |= NS_FACESENT_SMOOTH; 695 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
581 return; 696 return;
582 } 697 }
583 698
584 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE)) 699 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
585 esrv_send_face(ns, smoothface, 0); 700 esrv_send_face (ns, smoothface, 0);
586 701
587 ns->faces_sent[face] |= NS_FACESENT_SMOOTH; 702 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
588 703
589 sl.buf=reply; 704 SockList sl (MAXSOCKBUF);
590 strcpy((char*)sl.buf,"smooth "); 705
591 sl.len=strlen((char*)sl.buf); 706 sl << "smooth "
592 SockList_AddShort(&sl, face); 707 << uint16 (face)
593 SockList_AddShort(&sl, smoothface); 708 << uint16 (smoothface);
709
594 Send_With_Handling(ns, &sl); 710 Send_With_Handling (ns, &sl);
711 sl.free ();
595} 712}
596 713
597 /** 714 /**
598 * Tells client the picture it has to use 715 * Tells client the picture it has to use
599 * to smooth a picture number given as argument. 716 * to smooth a picture number given as argument.
600 */ 717 */
718void
601void AskSmooth (char *buf, int len, NewSocket *ns){ 719AskSmooth (char *buf, int len, NewSocket * ns)
720{
602 uint16 facenbr; 721 uint16 facenbr;
603 722
604 facenbr=atoi (buf); 723 facenbr = atoi (buf);
605 SendSmooth(ns, facenbr); 724 SendSmooth (ns, facenbr);
606} 725}
607
608
609
610
611 726
612/** 727/**
613 * This handles the general commands from the client (ie, north, fire, cast, 728 * This handles the general commands from the client (ie, north, fire, cast,
614 * etc.) 729 * etc.)
615 */ 730 */
731void
616void PlayerCmd(char *buf, int len, player *pl) 732PlayerCmd (char *buf, int len, player *pl)
617{ 733{
618 734
619 /* The following should never happen with a proper or honest client. 735 /* The following should never happen with a proper or honest client.
620 * Therefore, the error message doesn't have to be too clear - if 736 * Therefore, the error message doesn't have to be too clear - if
621 * someone is playing with a hacked/non working client, this gives them 737 * someone is playing with a hacked/non working client, this gives them
622 * an idea of the problem, but they deserve what they get 738 * an idea of the problem, but they deserve what they get
623 */ 739 */
624 if (pl->state!=ST_PLAYING) { 740 if (pl->state != ST_PLAYING)
625 new_draw_info_format(NDI_UNIQUE, 0,pl->ob,
626 "You can not issue commands - state is not ST_PLAYING (%s)", buf);
627 return;
628 } 741 {
742 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
743 return;
744 }
629 /* Check if there is a count. In theory, a zero count could also be 745 /* Check if there is a count. In theory, a zero count could also be
630 * sent, so check for that also. 746 * sent, so check for that also.
631 */ 747 */
632 if (atoi(buf) || buf[0]=='0') { 748 if (atoi (buf) || buf[0] == '0')
749 {
633 pl->count=atoi((char*)buf); 750 pl->count = atoi ((char *) buf);
634 buf=strchr(buf,' '); /* advance beyond the numbers */ 751 buf = strchr (buf, ' '); /* advance beyond the numbers */
635 if (!buf) { 752 if (!buf)
753 {
636#ifdef ESRV_DEBUG 754#ifdef ESRV_DEBUG
637 LOG(llevDebug,"PlayerCmd: Got count but no command.\n"); 755 LOG (llevDebug, "PlayerCmd: Got count but no command.\n");
638#endif 756#endif
639 return; 757 return;
640 } 758 }
641 buf++; 759 buf++;
642 } 760 }
643 /* This should not happen anymore. */ 761 /* This should not happen anymore. */
644 if (pl->ob->speed_left<-1.0) { 762 if (pl->ob->speed_left < -1.0)
763 {
645 LOG(llevError,"Player has negative time - shouldn't do command.\n"); 764 LOG (llevError, "Player has negative time - shouldn't do command.\n");
646 } 765 }
647 /* In c_new.c */ 766 /* In c_new.c */
648 execute_newserver_command(pl->ob, (char*)buf); 767 execute_newserver_command (pl->ob, (char *) buf);
649 /* Perhaps something better should be done with a left over count. 768 /* Perhaps something better should be done with a left over count.
650 * Cleaning up the input should probably be done first - all actions 769 * Cleaning up the input should probably be done first - all actions
651 * for the command that issued the count should be done before any other 770 * for the command that issued the count should be done before any other
652 * commands. 771 * commands.
653 */ 772 */
654 773
655 pl->count=0; 774 pl->count = 0;
656 775
657} 776}
658 777
659 778
660/** 779/**
661 * This handles the general commands from the client (ie, north, fire, cast, 780 * This handles the general commands from the client (ie, north, fire, cast,
662 * etc.). It is a lot like PlayerCmd above, but is called with the 781 * etc.). It is a lot like PlayerCmd above, but is called with the
663 * 'ncom' method which gives more information back to the client so it 782 * 'ncom' method which gives more information back to the client so it
664 * can throttle. 783 * can throttle.
665 */ 784 */
785void
666void NewPlayerCmd(uint8 *buf, int len, player *pl) 786NewPlayerCmd (uint8 * buf, int len, player *pl)
667{ 787{
668 int time,repeat; 788 int time, repeat;
789 char command[MAX_BUF];
669 short packet; 790 short packet;
670 unsigned char command[MAX_BUF];
671 SockList sl;
672 791
673 if (len < 7) { 792 if (len < 7)
793 {
674 LOG(llevDebug,"Corrupt ncom command <%s> not long enough - discarding\n", buf); 794 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
675 return; 795 return;
676 } 796 }
677 797
678 packet = GetShort_String(buf); 798 packet = GetShort_String (buf);
679 repeat = GetInt_String(buf+2); 799 repeat = GetInt_String (buf + 2);
680 /* -1 is special - no repeat, but don't update */ 800 /* -1 is special - no repeat, but don't update */
681 if (repeat!=-1) { 801 if (repeat != -1)
682 pl->count=repeat; 802 pl->count = repeat;
683 }
684 if ((len-4) >= MAX_BUF) len=MAX_BUF-5;
685 803
804 if ((len - 4) >= MAX_BUF)
805 len = MAX_BUF - 5;
806
686 strncpy((char*)command, (char*)buf+6, len-4); 807 strncpy ((char *) command, (char *) buf + 6, len - 4);
687 command[len-4]='\0'; 808 command[len - 4] = '\0';
688 809
689 /* The following should never happen with a proper or honest client. 810 /* The following should never happen with a proper or honest client.
690 * Therefore, the error message doesn't have to be too clear - if 811 * Therefore, the error message doesn't have to be too clear - if
691 * someone is playing with a hacked/non working client, this gives them 812 * someone is playing with a hacked/non working client, this gives them
692 * an idea of the problem, but they deserve what they get 813 * an idea of the problem, but they deserve what they get
693 */ 814 */
694 if (pl->state!=ST_PLAYING) { 815 if (pl->state != ST_PLAYING)
695 new_draw_info_format(NDI_UNIQUE, 0,pl->ob,
696 "You can not issue commands - state is not ST_PLAYING (%s)", buf);
697 return;
698 } 816 {
817 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
818 return;
819 }
699 820
700 /* This should not happen anymore. */ 821 /* This should not happen anymore. */
701 if (pl->ob->speed_left<-1.0) { 822 if (pl->ob->speed_left < -1.0)
702 LOG(llevError,"Player has negative time - shouldn't do command.\n"); 823 LOG (llevError, "Player has negative time - shouldn't do command.\n");
703 } 824
704 /* In c_new.c */ 825 /* In c_new.c */
705 execute_newserver_command(pl->ob, (char*)command); 826 execute_newserver_command (pl->ob, (char *) command);
706 /* Perhaps something better should be done with a left over count. 827 /* Perhaps something better should be done with a left over count.
707 * Cleaning up the input should probably be done first - all actions 828 * Cleaning up the input should probably be done first - all actions
708 * for the command that issued the count should be done before any other 829 * for the command that issued the count should be done before any other
709 * commands. 830 * commands.
710 */ 831 */
711 pl->count=0; 832 pl->count = 0;
712 833
834 if (FABS (pl->ob->speed) < 0.001)
835 time = MAX_TIME * 100;
836 else
837 time = (int) (MAX_TIME / FABS (pl->ob->speed));
838
713 /* Send confirmation of command execution now */ 839 /* Send confirmation of command execution now */
714 sl.buf = command; 840
715 strcpy((char*)sl.buf,"comc "); 841 SockList sl (MAXSOCKBUF);
716 sl.len=5; 842 sl << "comc " << uint16 (packet) << uint32 (time);
717 SockList_AddShort(&sl,packet);
718 if (FABS(pl->ob->speed) < 0.001) time=MAX_TIME * 100;
719 else
720 time = ( int )( MAX_TIME/ FABS(pl->ob->speed) );
721 SockList_AddInt(&sl,time);
722 Send_With_Handling(&pl->socket, &sl); 843 Send_With_Handling (&pl->socket, &sl);
844 sl.free ();
723} 845}
724 846
725 847
726/** This is a reply to a previous query. */ 848/** This is a reply to a previous query. */
849void
727void ReplyCmd(char *buf, int len, player *pl) 850ReplyCmd (char *buf, int len, player *pl)
728{ 851{
729 /* This is to synthesize how the data would be stored if it 852 /* This is to synthesize how the data would be stored if it
730 * was normally entered. A bit of a hack, and should be cleaned up 853 * was normally entered. A bit of a hack, and should be cleaned up
731 * once all the X11 code is removed from the server. 854 * once all the X11 code is removed from the server.
732 * 855 *
733 * We pass 13 to many of the functions because this way they 856 * We pass 13 to many of the functions because this way they
734 * think it was the carriage return that was entered, and the 857 * think it was the carriage return that was entered, and the
735 * function then does not try to do additional input. 858 * function then does not try to do additional input.
736 */ 859 */
737 snprintf(pl->write_buf, sizeof(pl->write_buf), ":%s", buf); 860 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
738 861
739 /* this avoids any hacking here */ 862 /* this avoids any hacking here */
740 863
741 switch (pl->state) { 864 switch (pl->state)
865 {
742 case ST_PLAYING: 866 case ST_PLAYING:
743 LOG(llevError,"Got reply message with ST_PLAYING input state\n"); 867 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
744 break; 868 break;
745 869
746 case ST_PLAY_AGAIN: 870 case ST_PLAY_AGAIN:
747 /* We can check this for return value (2==quit). Maybe we 871 /* We can check this for return value (2==quit). Maybe we
748 * should, and do something appropriate? 872 * should, and do something appropriate?
749 */ 873 */
750 receive_play_again(pl->ob, buf[0]); 874 receive_play_again (pl->ob, buf[0]);
751 break; 875 break;
752 876
753 case ST_ROLL_STAT: 877 case ST_ROLL_STAT:
754 key_roll_stat(pl->ob,buf[0]); 878 key_roll_stat (pl->ob, buf[0]);
755 break; 879 break;
756 880
757 case ST_CHANGE_CLASS: 881 case ST_CHANGE_CLASS:
758 882
759 key_change_class(pl->ob, buf[0]); 883 key_change_class (pl->ob, buf[0]);
760 break; 884 break;
761 885
762 case ST_CONFIRM_QUIT: 886 case ST_CONFIRM_QUIT:
763 key_confirm_quit(pl->ob, buf[0]); 887 key_confirm_quit (pl->ob, buf[0]);
764 break; 888 break;
765 889
766 case ST_CONFIGURE: 890 case ST_CONFIGURE:
767 LOG(llevError,"In client input handling, but into configure state\n"); 891 LOG (llevError, "In client input handling, but into configure state\n");
768 pl->state = ST_PLAYING; 892 pl->state = ST_PLAYING;
769 break; 893 break;
770 894
771 case ST_GET_NAME: 895 case ST_GET_NAME:
772 receive_player_name(pl->ob,13); 896 receive_player_name (pl->ob, 13);
773 break; 897 break;
774 898
775 case ST_GET_PASSWORD: 899 case ST_GET_PASSWORD:
776 case ST_CONFIRM_PASSWORD: 900 case ST_CONFIRM_PASSWORD:
777 receive_player_password(pl->ob,13); 901 receive_player_password (pl->ob, 13);
778 break; 902 break;
779 903
780 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 904 case ST_GET_PARTY_PASSWORD: /* Get password for party */
781 receive_party_password(pl->ob,13); 905 receive_party_password (pl->ob, 13);
782 break; 906 break;
783 907
784 default: 908 default:
785 LOG(llevError,"Unknown input state: %d\n", pl->state); 909 LOG (llevError, "Unknown input state: %d\n", pl->state);
786 } 910 }
787} 911}
788 912
789/** 913/**
790 * Client tells its version. If there is a mismatch, we close the 914 * Client tells its version. If there is a mismatch, we close the
791 * socket. In real life, all we should care about is the client having 915 * socket. In real life, all we should care about is the client having
792 * something older than the server. If we assume the client will be 916 * something older than the server. If we assume the client will be
793 * backwards compatible, having it be a later version should not be a 917 * backwards compatible, having it be a later version should not be a
794 * problem. 918 * problem.
795 */ 919 */
920void
796void VersionCmd(char *buf, int len,NewSocket *ns) 921VersionCmd (char *buf, int len, NewSocket * ns)
797{ 922{
798 char *cp; 923 char *cp;
799 char version_warning[256]; 924 char version_warning[256];
800 925
801 if (!buf) { 926 if (!buf)
927 {
802 LOG(llevError, "CS: received corrupted version command\n"); 928 LOG (llevError, "CS: received corrupted version command\n");
803 return; 929 return;
804 } 930 }
805 931
806 ns->cs_version = atoi(buf); 932 ns->cs_version = atoi (buf);
807 ns->sc_version = ns->cs_version; 933 ns->sc_version = ns->cs_version;
808 if (VERSION_CS != ns->cs_version) { 934 if (VERSION_CS != ns->cs_version)
935 {
809#ifdef ESRV_DEBUG 936#ifdef ESRV_DEBUG
810 LOG(llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS,ns->cs_version); 937 LOG (llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS, ns->cs_version);
811#endif 938#endif
812 } 939 }
813 cp = strchr(buf+1,' '); 940 cp = strchr (buf + 1, ' ');
814 if (!cp) return; 941 if (!cp)
942 return;
815 ns->sc_version = atoi(cp); 943 ns->sc_version = atoi (cp);
816 if (VERSION_SC != ns->sc_version) { 944 if (VERSION_SC != ns->sc_version)
945 {
817#ifdef ESRV_DEBUG 946#ifdef ESRV_DEBUG
818 LOG(llevDebug, "CS: scversion mismatch (%d,%d)\n",VERSION_SC,ns->sc_version); 947 LOG (llevDebug, "CS: scversion mismatch (%d,%d)\n", VERSION_SC, ns->sc_version);
819#endif 948#endif
820 } 949 }
821 cp = strchr(cp+1, ' '); 950 cp = strchr (cp + 1, ' ');
822 if (cp) { 951 if (cp)
952 {
823 LOG(llevDebug,"CS: connection from client of type <%s>, ip %s\n", cp, ns->host); 953 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host);
824 954
955 snprintf (ns->client, sizeof (ns->client), "%s", cp + 1);
956
825 /* This is first implementation - i skip all beta DX clients with it 957 /* This is first implementation - i skip all beta DX clients with it
826 * Add later stuff here for other clients 958 * Add later stuff here for other clients
827 */ 959 */
828 960
829 /* these are old dxclients */ 961 /* these are old dxclients */
830 /* Version 1024 added support for singular + plural name values - 962 /* Version 1024 added support for singular + plural name values -
831 * requiing this minimal value reduces complexity of that code, and it 963 * requiing this minimal value reduces complexity of that code, and it
832 * has been around for a long time. 964 * has been around for a long time.
833 */ 965 */
834 if(!strcmp(" CF DX CLIENT", cp) || ns->sc_version < 1024 ) 966 if (ns->sc_version < 1026)
835 { 967 {
836 sprintf(version_warning,"drawinfo %d %s", NDI_RED, "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 968 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
969 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
837 Write_String_To_Socket(ns, version_warning, strlen(version_warning)); 970 Write_String_To_Socket (ns, version_warning, strlen (version_warning));
838 } 971 }
839 972
840 } 973 }
841} 974}
842 975
843/** sound related functions. */ 976/** sound related functions. */
844 977
978void
845void SetSound(char *buf, int len, NewSocket *ns) 979SetSound (char *buf, int len, NewSocket * ns)
846{ 980{
847 ns->sound = atoi(buf); 981 ns->sound = atoi (buf);
848} 982}
849 983
850/** client wants the map resent */ 984/** client wants the map resent */
851 985
986void
852void MapRedrawCmd(char *buf, int len, player *pl) 987MapRedrawCmd (char *buf, int len, player *pl)
853{ 988{
989
854/* This function is currently disabled; just clearing the map state results in 990/* This function is currently disabled; just clearing the map state results in
855 * display errors. It should clear the cache and send a newmap command. 991 * display errors. It should clear the cache and send a newmap command.
856 * Unfortunately this solution does not work because some client versions send 992 * Unfortunately this solution does not work because some client versions send
857 * a mapredraw command after receiving a newmap command. 993 * a mapredraw command after receiving a newmap command.
858 */ 994 */
859#if 0 995#if 0
860 /* Okay, this is MAJOR UGLY. but the only way I know how to 996 /* Okay, this is MAJOR UGLY. but the only way I know how to
861 * clear the "cache" 997 * clear the "cache"
862 */ 998 */
863 memset(&pl->socket.lastmap, 0, sizeof(struct Map)); 999 memset (&pl->socket.lastmap, 0, sizeof (struct Map));
864 draw_client_map(pl->ob); 1000 draw_client_map (pl->ob);
865#endif 1001#endif
866} 1002}
867 1003
868/** 1004/**
869 * Moves an object (typically, container to inventory). 1005 * Moves an object (typically, container to inventory).
870 * syntax is: move (to) (tag) (nrof) 1006 * syntax is: move (to) (tag) (nrof)
871 */ 1007 */
1008void
872void MoveCmd(char *buf, int len,player *pl) 1009MoveCmd (char *buf, int len, player *pl)
873{ 1010{
874 int vals[3], i; 1011 int vals[3], i;
875 1012
876 /* A little funky here. We only cycle for 2 records, because 1013 /* A little funky here. We only cycle for 2 records, because
877 * we obviously am not going to find a space after the third 1014 * we obviously am not going to find a space after the third
878 * record. Perhaps we should just replace this with a 1015 * record. Perhaps we should just replace this with a
879 * sscanf? 1016 * sscanf?
880 */ 1017 */
881 for (i=0; i<2; i++) { 1018 for (i = 0; i < 2; i++)
1019 {
882 vals[i]=atoi(buf); 1020 vals[i] = atoi (buf);
883 if (!(buf = strchr(buf, ' '))) { 1021 if (!(buf = strchr (buf, ' ')))
1022 {
884 LOG(llevError,"Incomplete move command: %s\n", buf); 1023 LOG (llevError, "Incomplete move command: %s\n", buf);
885 return; 1024 return;
886 } 1025 }
887 buf++; 1026 buf++;
888 } 1027 }
889 vals[2]=atoi(buf); 1028 vals[2] = atoi (buf);
890 1029
891/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/ 1030/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
892 esrv_move_object(pl->ob,vals[0], vals[1], vals[2]); 1031 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
893} 1032}
894 1033
895 1034
896 1035
897/****************************************************************************** 1036/******************************************************************************
… …
902 1041
903/** 1042/**
904 * Asks the client to query the user. This way, the client knows 1043 * Asks the client to query the user. This way, the client knows
905 * it needs to send something back (vs just printing out a message) 1044 * it needs to send something back (vs just printing out a message)
906 */ 1045 */
1046void
907void send_query(NewSocket *ns, uint8 flags, char *text) 1047send_query (NewSocket * ns, uint8 flags, char *text)
908{ 1048{
909 char buf[MAX_BUF]; 1049 char buf[MAX_BUF];
910 1050
911 sprintf(buf,"query %d %s", flags, text?text:""); 1051 sprintf (buf, "query %d %s", flags, text ? text : "");
912 Write_String_To_Socket(ns, buf, strlen(buf)); 1052 Write_String_To_Socket (ns, buf, strlen (buf));
913} 1053}
914 1054
915#define AddIfInt64(Old,New,Type) if (Old != New) {\ 1055#define AddIfInt64(Old,New,Type) if (Old != New) {\
916 Old = New; \ 1056 Old = New; \
917 SockList_AddChar(&sl, Type); \ 1057 sl << uint8 (Type) << uint64 (New); \
918 SockList_AddInt64(&sl, New); \ 1058 }
919 }
920 1059
921#define AddIfInt(Old,New,Type) if (Old != New) {\ 1060#define AddIfInt(Old,New,Type) if (Old != New) {\
922 Old = New; \ 1061 Old = New; \
923 SockList_AddChar(&sl, Type); \ 1062 sl << uint8 (Type) << uint32 (New); \
924 SockList_AddInt(&sl, New); \ 1063 }
925 }
926 1064
927#define AddIfShort(Old,New,Type) if (Old != New) {\ 1065#define AddIfShort(Old,New,Type) if (Old != New) {\
928 Old = New; \ 1066 Old = New; \
929 SockList_AddChar(&sl, Type); \ 1067 sl << uint8 (Type) << uint16 (New); \
930 SockList_AddShort(&sl, New); \ 1068 }
931 }
932 1069
933#define AddIfFloat(Old,New,Type) if (Old != New) {\ 1070#define AddIfFloat(Old,New,Type) if (Old != New) {\
934 Old = New; \ 1071 Old = New; \
935 SockList_AddChar(&sl, Type); \ 1072 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \
936 SockList_AddInt(&sl,(long)(New*FLOAT_MULTI));\ 1073 }
937 }
938 1074
939#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 1075#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
940 if (Old) free(Old);\ 1076 free(Old); Old = strdup (New);\
941 Old = strdup_local(New);\ 1077 sl << uint8 (Type) << data8 (New); \
942 SockList_AddChar(&sl, Type); \ 1078 }
943 SockList_AddChar(&sl, ( char )strlen(New)); \
944 strcpy((char*)sl.buf + sl.len, New); \
945 sl.len += strlen(New); \
946 }
947 1079
948/** 1080/**
949 * Sends a statistics update. We look at the old values, 1081 * Sends a statistics update. We look at the old values,
950 * and only send what has changed. Stat mapping values are in newclient.h 1082 * and only send what has changed. Stat mapping values are in newclient.h
951 * Since this gets sent a lot, this is actually one of the few binary 1083 * Since this gets sent a lot, this is actually one of the few binary
952 * commands for now. 1084 * commands for now.
953 */ 1085 */
1086void
954void esrv_update_stats(player *pl) 1087esrv_update_stats (player *pl)
955{ 1088{
956 SockList sl;
957 char buf[MAX_BUF]; 1089 char buf[MAX_BUF];
958 uint16 flags; 1090 uint16 flags;
959 1091
960 sl.buf=(unsigned char*)malloc(MAXSOCKBUF); 1092 SockList sl (MAXSOCKBUF);
961 strcpy((char*)sl.buf,"stats "); 1093 sl << "stats ";
962 sl.len=strlen((char*)sl.buf); 1094
963
964 if(pl->ob != NULL) 1095 if (pl->ob != NULL)
965 { 1096 {
966 AddIfShort(pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 1097 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP);
967 AddIfShort(pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 1098 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP);
968 AddIfShort(pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 1099 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP);
969 AddIfShort(pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 1100 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP);
970 AddIfShort(pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 1101 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE);
971 AddIfShort(pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 1102 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE);
972 AddIfShort(pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 1103 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR);
973 AddIfShort(pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT); 1104 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT);
974 AddIfShort(pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW); 1105 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW);
975 AddIfShort(pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS); 1106 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
976 AddIfShort(pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 1107 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX);
977 AddIfShort(pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 1108 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON);
978 AddIfShort(pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 1109 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA);
979 }
980 if(pl->socket.exp64) {
981 uint8 s;
982 for(s=0;s<NUM_SKILLS;s++) {
983 if (pl->last_skill_ob[s] &&
984 pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) {
985
986 /* Always send along the level if exp changes. This is only
987 * 1 extra byte, but keeps processing simpler.
988 */
989 SockList_AddChar(&sl, ( char )( s + CS_STAT_SKILLINFO ));
990 SockList_AddChar(&sl, ( char )pl->last_skill_ob[s]->level);
991 SockList_AddInt64(&sl, pl->last_skill_ob[s]->stats.exp);
992 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
993 } 1110 }
994 } 1111
995 }
996 if (pl->socket.exp64) { 1112 if (pl->socket.exp64)
1113 {
1114 uint8 s;
1115
1116 for (s = 0; s < NUM_SKILLS; s++)
1117 {
1118 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp)
1119 {
1120 /* Always send along the level if exp changes. This is only
1121 * 1 extra byte, but keeps processing simpler.
1122 */
1123 sl << uint8 (s + CS_STAT_SKILLINFO)
1124 << uint8 (pl->last_skill_ob[s]->level)
1125 << uint64 (pl->last_skill_ob[s]->stats.exp);
1126
1127 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1128 }
1129 }
1130 }
1131
1132 if (pl->socket.exp64)
997 AddIfInt64(pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64); 1133 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) }
998 } else { 1134 else
999 AddIfInt(pl->last_stats.exp, ( int )pl->ob->stats.exp, CS_STAT_EXP); 1135 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1000 } 1136
1001 AddIfShort(pl->last_level, ( char )pl->ob->level, CS_STAT_LEVEL); 1137 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL);
1002 AddIfShort(pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 1138 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC);
1003 AddIfShort(pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 1139 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC);
1004 AddIfShort(pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 1140 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM);
1005 AddIfFloat(pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 1141 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED);
1006 AddIfShort(pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 1142 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD);
1007 AddIfFloat(pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 1143 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1008 AddIfInt(pl->last_weight_limit, (sint32)weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 1144 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM);
1009 flags=0; 1145 flags = 0;
1010 if (pl->fire_on) flags |=SF_FIREON;
1011 if (pl->run_on) flags |= SF_RUNON;
1012 1146
1147 if (pl->fire_on)
1148 flags |= SF_FIREON;
1149
1150 if (pl->run_on)
1151 flags |= SF_RUNON;
1152
1013 AddIfShort(pl->last_flags, flags, CS_STAT_FLAGS); 1153 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS);
1154
1014 if (pl->socket.sc_version<1025) { 1155 if (pl->socket.sc_version < 1025)
1015 AddIfShort(pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR); 1156 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1016 } else { 1157 else
1017 int i; 1158 {
1159 int i;
1018 1160
1019 for (i=0; i<NROFATTACKS; i++) { 1161 for (i = 0; i < NROFATTACKS; i++)
1162 {
1020 /* Skip ones we won't send */ 1163 /* Skip ones we won't send */
1021 if (atnr_cs_stat[i]==-1) continue; 1164 if (atnr_cs_stat[i] == -1)
1165 continue;
1166
1022 AddIfShort(pl->last_resist[i], pl->ob->resist[i], ( char )atnr_cs_stat[i]); 1167 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]);
1023 } 1168 }
1024 } 1169 }
1170
1025 if (pl->socket.monitor_spells) { 1171 if (pl->socket.monitor_spells)
1172 {
1026 AddIfInt(pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 1173 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1027 AddIfInt(pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 1174 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL);
1028 AddIfInt(pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 1175 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY);
1029 } 1176 }
1177
1030 rangetostring(pl->ob, buf); /* we want use the new fire & run system in new client */ 1178 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */
1031 AddIfString(pl->socket.stats.range, buf, CS_STAT_RANGE); 1179 AddIfString (pl->socket.stats.range, buf, CS_STAT_RANGE);
1032 set_title(pl->ob, buf); 1180 set_title (pl->ob, buf);
1033 AddIfString(pl->socket.stats.title, buf, CS_STAT_TITLE); 1181 AddIfString (pl->socket.stats.title, buf, CS_STAT_TITLE);
1034 1182
1035 /* Only send it away if we have some actual data */ 1183 /* Only send it away if we have some actual data */
1036 if (sl.len>6) { 1184 if (sl.len > 6)
1185 {
1037#ifdef ESRV_DEBUG 1186#ifdef ESRV_DEBUG
1038 LOG(llevDebug,"Sending stats command, %d bytes long.\n", sl.len); 1187 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1039#endif 1188#endif
1040 Send_With_Handling(&pl->socket, &sl); 1189 Send_With_Handling (&pl->socket, &sl);
1041 } 1190 }
1042 free(sl.buf);
1043}
1044 1191
1192 sl.free ();
1193}
1045 1194
1046/** 1195/**
1047 * Tells the client that here is a player it should start using. 1196 * Tells the client that here is a player it should start using.
1048 */ 1197 */
1198void
1049void esrv_new_player(player *pl, uint32 weight) 1199esrv_new_player (player *pl, uint32 weight)
1050{ 1200{
1051 SockList sl;
1052
1053 pl->last_weight = weight; 1201 pl->last_weight = weight;
1054 1202
1055 sl.buf=(unsigned char*)malloc(MAXSOCKBUF); 1203 SockList sl (MAXSOCKBUF);
1204 sl << "player ";
1056 1205
1057 strcpy((char*)sl.buf,"player "); 1206 sl << uint32 (pl->ob->count)
1058 sl.len=strlen((char*)sl.buf); 1207 << uint32 (weight)
1059 SockList_AddInt(&sl, pl->ob->count); 1208 << uint32 (pl->ob->face->number)
1060 SockList_AddInt(&sl, weight); 1209 << data8 (pl->ob->name);
1061 SockList_AddInt(&sl, pl->ob->face->number);
1062 1210
1063 SockList_AddChar(&sl, ( char )strlen(pl->ob->name));
1064 strcpy((char*)sl.buf+sl.len, pl->ob->name);
1065 sl.len += strlen(pl->ob->name);
1066
1067 Send_With_Handling(&pl->socket, &sl); 1211 Send_With_Handling (&pl->socket, &sl);
1068 free(sl.buf); 1212 sl.free ();
1069 SET_FLAG(pl->ob, FLAG_CLIENT_SENT); 1213 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1070} 1214}
1071
1072 1215
1073/** 1216/**
1074 * Need to send an animation sequence to the client. 1217 * Need to send an animation sequence to the client.
1075 * We will send appropriate face commands to the client if we haven't 1218 * We will send appropriate face commands to the client if we haven't
1076 * sent them the face yet (this can become quite costly in terms of 1219 * sent them the face yet (this can become quite costly in terms of
1077 * how much we are sending - on the other hand, this should only happen 1220 * how much we are sending - on the other hand, this should only happen
1078 * when the player logs in and picks stuff up. 1221 * when the player logs in and picks stuff up.
1079 */ 1222 */
1223void
1080void esrv_send_animation(NewSocket *ns, short anim_num) 1224esrv_send_animation (NewSocket * ns, short anim_num)
1081{ 1225{
1082 SockList sl;
1083 int i; 1226 int i;
1084 1227
1085 /* Do some checking on the anim_num we got. Note that the animations 1228 /* Do some checking on the anim_num we got. Note that the animations
1086 * are added in contigous order, so if the number is in the valid 1229 * are added in contigous order, so if the number is in the valid
1087 * range, it must be a valid animation. 1230 * range, it must be a valid animation.
1088 */ 1231 */
1089 if (anim_num < 0 || anim_num > num_animations) { 1232 if (anim_num < 0 || anim_num > num_animations)
1233 {
1090 LOG(llevError,"esrv_send_anim (%d) out of bounds??\n",anim_num); 1234 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1091 return; 1235 return;
1092 } 1236 }
1093 1237
1094 sl.buf = (unsigned char*) malloc(MAXSOCKBUF); 1238 SockList sl (MAXSOCKBUF);
1095 strcpy((char*)sl.buf, "anim "); 1239
1096 sl.len=5; 1240 sl << "anim "
1097 SockList_AddShort(&sl, anim_num); 1241 << uint16 (anim_num)
1098 SockList_AddShort(&sl, 0); /* flags - not used right now */ 1242 << uint16 (0); /* flags - not used right now */
1243
1099 /* Build up the list of faces. Also, send any information (ie, the 1244 /* Build up the list of faces. Also, send any information (ie, the
1100 * the face itself) down to the client. 1245 * the face itself) down to the client.
1101 */ 1246 */
1102 for (i=0; i<animations[anim_num].num_animations; i++) { 1247 for (i = 0; i < animations[anim_num].num_animations; i++)
1248 {
1103 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE)) 1249 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1104 esrv_send_face(ns,animations[anim_num].faces[i],0); 1250 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1105 SockList_AddShort(&sl, animations[anim_num].faces[i]); /* flags - not used right now */ 1251 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1106 } 1252 }
1253
1107 Send_With_Handling(ns, &sl); 1254 Send_With_Handling (ns, &sl);
1108 free(sl.buf); 1255 sl.free ();
1256
1109 ns->anims_sent[anim_num] = 1; 1257 ns->anims_sent[anim_num] = 1;
1110} 1258}
1111 1259
1112 1260
1113/****************************************************************************** 1261/******************************************************************************
1114 * 1262 *
… …
1118 1266
1119/** 1267/**
1120 * This adds face_num to a map cell at x,y. If the client doesn't have 1268 * This adds face_num to a map cell at x,y. If the client doesn't have
1121 * the face yet, we will also send it. 1269 * the face yet, we will also send it.
1122 */ 1270 */
1123static void esrv_map_setbelow(NewSocket *ns, int x,int y, 1271static void
1124 short face_num, struct Map *newmap) 1272esrv_map_setbelow (NewSocket * ns, int x, int y, short face_num, struct Map *newmap)
1125{ 1273{
1126 if(newmap->cells[x][y].count >= MAP_LAYERS) { 1274 if (newmap->cells[x][y].count >= MAP_LAYERS)
1275 {
1127 LOG(llevError,"Too many faces in map cell %d %d\n",x,y); 1276 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1128 return; 1277 return;
1129 abort(); 1278 abort ();
1130 } 1279 }
1280
1131 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num; 1281 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1132 newmap->cells[x][y].count ++; 1282 newmap->cells[x][y].count++;
1283
1133 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1284 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1134 esrv_send_face(ns,face_num,0); 1285 esrv_send_face (ns, face_num, 0);
1135} 1286}
1136 1287
1137struct LayerCell { 1288struct LayerCell
1289{
1138 uint16 xy; 1290 uint16 xy;
1139 short face; 1291 short face;
1140}; 1292};
1141 1293
1142struct MapLayer { 1294struct MapLayer
1295{
1143 int count; 1296 int count;
1144 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y]; 1297 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1145}; 1298};
1146 1299
1147/** Checkes if map cells have changed */ 1300/** Checkes if map cells have changed */
1301static int
1148static int mapcellchanged(NewSocket *ns,int i,int j, struct Map *newmap) 1302mapcellchanged (NewSocket * ns, int i, int j, struct Map *newmap)
1149{ 1303{
1150 int k; 1304 int k;
1151 1305
1152 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count) 1306 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1153 return 1; 1307 return 1;
1154 for(k=0;k<newmap->cells[i][j].count;k++) { 1308 for (k = 0; k < newmap->cells[i][j].count; k++)
1155 if (ns->lastmap.cells[i][j].faces[k] != 1309 {
1156 newmap->cells[i][j].faces[k]) { 1310 if (ns->lastmap.cells[i][j].faces[k] != newmap->cells[i][j].faces[k])
1311 {
1157 return 1; 1312 return 1;
1158 } 1313 }
1159 } 1314 }
1160 return 0; 1315 return 0;
1161} 1316}
1162 1317
1163/** 1318/**
1164 * Basically, what this does is pack the data into layers. 1319 * Basically, what this does is pack the data into layers.
1165 * cnum is the client number, cur is the the buffer we put all of 1320 * cnum is the client number, cur is the the buffer we put all of
1166 * this data into. we return the end of the data. layers is 1321 * this data into. we return the end of the data. layers is
1167 * how many layers of data we should back. 1322 * how many layers of data we should back.
1168 */ 1323 */
1324static uint8 *
1169static uint8 *compactlayer(NewSocket *ns, unsigned char *cur, int numlayers, 1325compactlayer (NewSocket * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1170 struct Map *newmap)
1171{ 1326{
1172 int x,y,k; 1327 int x, y, k;
1173 int face; 1328 int face;
1174 unsigned char *fcur; 1329 unsigned char *fcur;
1175 struct MapLayer layers[MAP_LAYERS]; 1330 struct MapLayer layers[MAP_LAYERS];
1176 1331
1177 for(k = 0;k<MAP_LAYERS;k++) 1332 for (k = 0; k < MAP_LAYERS; k++)
1178 layers[k].count = 0; 1333 layers[k].count = 0;
1179 fcur = cur; 1334 fcur = cur;
1180 for(x=0;x<ns->mapx;x++) { 1335 for (x = 0; x < ns->mapx; x++)
1181 for(y=0;y<ns->mapy;y++) { 1336 {
1337 for (y = 0; y < ns->mapy; y++)
1338 {
1182 if (!mapcellchanged(ns,x,y,newmap)) 1339 if (!mapcellchanged (ns, x, y, newmap))
1183 continue; 1340 continue;
1184 if (newmap->cells[x][y].count == 0) { 1341 if (newmap->cells[x][y].count == 0)
1342 {
1185 *cur = x*ns->mapy+y; /* mark empty space */ 1343 *cur = x * ns->mapy + y; /* mark empty space */
1186 cur++; 1344 cur++;
1187 continue; 1345 continue;
1346 }
1347 for (k = 0; k < newmap->cells[x][y].count; k++)
1348 {
1349 layers[k].lcells[layers[k].count].xy = x * ns->mapy + y;
1350 layers[k].lcells[layers[k].count].face = newmap->cells[x][y].faces[k];
1351 layers[k].count++;
1352 }
1353 }
1188 } 1354 }
1189 for(k=0;k<newmap->cells[x][y].count;k++) {
1190 layers[k].lcells[layers[k].count].xy = x*ns->mapy+y;
1191 layers[k].lcells[layers[k].count].face =
1192 newmap->cells[x][y].faces[k];
1193 layers[k].count++;
1194 }
1195 }
1196 }
1197 /* If no data, return now. */ 1355 /* If no data, return now. */
1198 if (fcur == cur && layers[0].count == 0) 1356 if (fcur == cur && layers[0].count == 0)
1199 return cur;
1200 *cur = 255; /* mark end of explicitly cleared cells */
1201 cur++;
1202 /* First pack by layers. */
1203 for(k=0;k<numlayers;k++) {
1204 if (layers[k].count == 0)
1205 break; /* once a layer is entirely empty, no layer below it can
1206 have anything in it either */
1207 /* Pack by entries in thie layer */
1208 for(x=0;x<layers[k].count;) {
1209 fcur = cur;
1210 *cur = layers[k].lcells[x].face >> 8;
1211 cur++;
1212 *cur = layers[k].lcells[x].face & 0xFF;
1213 cur++;
1214 face = layers[k].lcells[x].face;
1215 /* Now, we back the redundant data into 1 byte xy pairings */
1216 for(y=x;y<layers[k].count;y++) {
1217 if (layers[k].lcells[y].face == face) {
1218 *cur = ( uint8 )layers[k].lcells[y].xy;
1219 cur++;
1220 layers[k].lcells[y].face = -1;
1221 }
1222 }
1223 *(cur-1) = *(cur-1) | 128; /* mark for end of xy's; 11*11 < 128 */
1224 /* forward over the now redundant data */
1225 while(x < layers[k].count &&
1226 layers[k].lcells[x].face == -1)
1227 x++;
1228 }
1229 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1230 }
1231 return cur; 1357 return cur;
1358 *cur = 255; /* mark end of explicitly cleared cells */
1359 cur++;
1360 /* First pack by layers. */
1361 for (k = 0; k < numlayers; k++)
1362 {
1363 if (layers[k].count == 0)
1364 break; /* once a layer is entirely empty, no layer below it can
1365 have anything in it either */
1366 /* Pack by entries in thie layer */
1367 for (x = 0; x < layers[k].count;)
1368 {
1369 fcur = cur;
1370 *cur = layers[k].lcells[x].face >> 8;
1371 cur++;
1372 *cur = layers[k].lcells[x].face & 0xFF;
1373 cur++;
1374 face = layers[k].lcells[x].face;
1375 /* Now, we back the redundant data into 1 byte xy pairings */
1376 for (y = x; y < layers[k].count; y++)
1377 {
1378 if (layers[k].lcells[y].face == face)
1379 {
1380 *cur = (uint8) layers[k].lcells[y].xy;
1381 cur++;
1382 layers[k].lcells[y].face = -1;
1383 }
1384 }
1385 *(cur - 1) = *(cur - 1) | 128; /* mark for end of xy's; 11*11 < 128 */
1386 /* forward over the now redundant data */
1387 while (x < layers[k].count && layers[k].lcells[x].face == -1)
1388 x++;
1389 }
1390 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1391 }
1392 return cur;
1232} 1393}
1233 1394
1395static void
1234static void esrv_map_doneredraw(NewSocket *ns, struct Map *newmap) 1396esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1235{ 1397{
1236 static long frames,bytes,tbytes,tframes; 1398 static long frames, bytes, tbytes, tframes;
1237 char *cur; 1399 char *cur;
1238 SockList sl;
1239 1400
1401 SockList sl (MAXSOCKBUF);
1402 sl << "map ";
1240 1403
1241 sl.buf=(unsigned char*)malloc(MAXSOCKBUF);
1242 strcpy((char*)sl.buf,"map ");
1243 sl.len=strlen((char*)sl.buf);
1244
1245 cur = (char *) compactlayer(ns,(unsigned char*) sl.buf+sl.len,MAP_LAYERS,newmap); 1404 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1246 sl.len=cur-(char*)sl.buf; 1405 sl.len = cur - (char *) sl.buf;
1247 1406
1248/* LOG(llevDebug, "Sending map command.\n");*/ 1407/* LOG(llevDebug, "Sending map command.\n");*/
1249 1408
1250 if (sl.len>( int )strlen("map ") || ns->sent_scroll) { 1409 if (sl.len > (int) strlen ("map ") || ns->sent_scroll)
1410 {
1251 /* All of this is just accounting stuff */ 1411 /* All of this is just accounting stuff */
1252 if (tframes>100) { 1412 if (tframes > 100)
1253 tframes = tbytes = 0; 1413 tframes = tbytes = 0;
1254 } 1414
1255 tframes++; 1415 tframes++;
1256 frames++; 1416 frames++;
1257 tbytes += sl.len; 1417 tbytes += sl.len;
1258 bytes += sl.len; 1418 bytes += sl.len;
1259 memcpy(&ns->lastmap,newmap,sizeof(struct Map)); 1419 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1260 Send_With_Handling(ns, &sl); 1420 Send_With_Handling (ns, &sl);
1261 ns->sent_scroll = 0; 1421 ns->sent_scroll = 0;
1262 } 1422 }
1263 free(sl.buf); 1423
1424 sl.free ();
1264} 1425}
1265 1426
1266 1427
1267/** Clears a map cell */ 1428/** Clears a map cell */
1429static void
1268static void map_clearcell(struct MapCell *cell, int face0, int face1, int face2, int count) 1430map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count)
1269{ 1431{
1270 cell->count=count;
1271 cell->faces[0] = face0; 1432 cell->faces[0] = face0;
1272 cell->faces[1] = face1; 1433 cell->faces[1] = face1;
1273 cell->faces[2] = face2; 1434 cell->faces[2] = face2;
1435 cell->count = count;
1436 cell->stat_hp = 0;
1437 cell->flags = 0;
1438 cell->player = 0;
1274} 1439}
1275 1440
1276#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y) 1441#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1277#define MAX_LAYERS 3 1442#define MAX_LAYERS 3
1278 1443
… …
1281 * and saves the space of allocating this in the socket object when we only 1446 * and saves the space of allocating this in the socket object when we only
1282 * need it for this cycle. If the serve is ever threaded, this needs to be 1447 * need it for this cycle. If the serve is ever threaded, this needs to be
1283 * re-examined. 1448 * re-examined.
1284 */ 1449 */
1285 1450
1286static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS]; 1451static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1287 1452
1288/** 1453/**
1289 * Returns true if any of the heads for this 1454 * Returns true if any of the heads for this
1290 * space is set. Returns false if all are blank - this is used 1455 * space is set. Returns false if all are blank - this is used
1291 * for empty space checking. 1456 * for empty space checking.
1292 */ 1457 */
1293static inline int have_head(int ax, int ay) { 1458static inline int
1459have_head (int ax, int ay)
1460{
1294 1461
1295 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] || 1462 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1296 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || 1463 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1297 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2]) return 1;
1298 return 0; 1464 return 1;
1465 return 0;
1299} 1466}
1300 1467
1301/** 1468/**
1302 * check_head is a bit simplistic version of update_space below. 1469 * check_head is a bit simplistic version of update_space below.
1303 * basically, it only checks the that the head on space ax,ay at layer 1470 * basically, it only checks the that the head on space ax,ay at layer
1304 * needs to get sent - if so, it adds the data, sending the head 1471 * needs to get sent - if so, it adds the data, sending the head
1305 * if needed, and returning 1. If this no data needs to get 1472 * if needed, and returning 1. If this no data needs to get
1306 * sent, it returns zero. 1473 * sent, it returns zero.
1307 */ 1474 */
1475static int
1308static inline int check_head(SockList *sl, NewSocket *ns, int ax, int ay, int layer) 1476check_head (SockList &sl, NewSocket &ns, int ax, int ay, int layer)
1309{ 1477{
1310 short face_num; 1478 short face_num;
1311 1479
1312 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]) 1480 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1313 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number; 1481 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1314 else 1482 else
1315 face_num = 0; 1483 face_num = 0;
1316 1484
1317 if (face_num != ns->lastmap.cells[ax][ay].faces[layer]) { 1485 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1486 {
1318 SockList_AddShort(sl, face_num); 1487 SockList_AddShort (&sl, face_num);
1319 if (face_num && !(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1488 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1320 esrv_send_face(ns, face_num, 0); 1489 esrv_send_face (&ns, face_num, 0);
1490
1321 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL; 1491 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1322 ns->lastmap.cells[ax][ay].faces[layer] = face_num; 1492 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1323 return 1; 1493 return 1;
1324 } 1494 }
1325 1495
1326 return 0; /* No change */ 1496 return 0; /* No change */
1327} 1497}
1328 1498
1329/** 1499/**
1330 * Removes the need to replicate the same code for each layer. 1500 * Removes the need to replicate the same code for each layer.
1331 * this returns true if this space is now in fact different than 1501 * this returns true if this space is now in fact different than
… …
1344 * the map command, where the faces stack up. Sinces that is no longer 1514 * the map command, where the faces stack up. Sinces that is no longer
1345 * the case, it seems to make more sense to have these layer values 1515 * the case, it seems to make more sense to have these layer values
1346 * actually match. 1516 * actually match.
1347 */ 1517 */
1348 1518
1519static int
1349static inline int update_space(SockList *sl, NewSocket *ns, mapstruct *mp, int mx, int my, int sx, int sy, int layer) 1520update_space (SockList &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1350{ 1521{
1351 object *ob, *head; 1522 object *ob, *head;
1352 uint16 face_num; 1523 uint16 face_num;
1353 int bx, by,i; 1524 int bx, by, i;
1354 1525
1355 /* If there is a multipart object stored away, treat that as more important. 1526 /* If there is a multipart object stored away, treat that as more important.
1356 * If not, then do the normal processing. 1527 * If not, then do the normal processing.
1357 */ 1528 */
1358
1359 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer]; 1529 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1360 1530
1361 /* Check to see if this head is part of the set of objects 1531 /* Check to see if this head is part of the set of objects
1362 * we would normally send for this space. If so, then 1532 * we would normally send for this space. If so, then
1363 * don't use the head value. We need to do the check 1533 * don't use the head value. We need to do the check
1364 * here and not when setting up the heads[] value for two reasons - 1534 * here and not when setting up the heads[] value for two reasons -
1365 * 1) the heads[] values will get used even if the space is not visible. 1535 * 1) the heads[] values will get used even if the space is not visible.
1366 * 2) its possible the head is not on the same map as a part, and I'd 1536 * 2) its possible the head is not on the same map as a part, and I'd
1367 * rather not need to do the map translation overhead. 1537 * rather not need to do the map translation overhead.
1368 * 3) We need to do some extra checking to make sure that we will 1538 * 3) We need to do some extra checking to make sure that we will
1369 * otherwise send the image as this layer, eg, either it matches 1539 * otherwise send the image as this layer, eg, either it matches
1370 * the head value, or is not multipart. 1540 * the head value, or is not multipart.
1371 */ 1541 */
1372 if (head && !head->more) { 1542 if (head && !head->more)
1543 {
1373 for (i=0; i<MAP_LAYERS; i++) { 1544 for (i = 0; i < MAP_LAYERS; i++)
1545 {
1374 ob = GET_MAP_FACE_OBJ(mp, mx, my, i); 1546 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1375 if (!ob) continue; 1547 if (!ob)
1548 continue;
1376 1549
1377 if (ob->head) ob=ob->head; 1550 if (ob->head)
1551 ob = ob->head;
1378 1552
1379 if (ob == head) { 1553 if (ob == head)
1554 {
1380 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL; 1555 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1381 head = NULL; 1556 head = NULL;
1382 break; 1557 break;
1558 }
1559 }
1383 } 1560 }
1384 }
1385 }
1386 1561
1387 ob = head; 1562 ob = head;
1563 if (!ob)
1388 if (!ob) ob = GET_MAP_FACE_OBJ(mp, mx, my, layer); 1564 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1389 1565
1390 /* If there is no object for this space, or if the face for the object 1566 /* If there is no object for this space, or if the face for the object
1391 * is the blank face, set the face number to zero. 1567 * is the blank face, set the face number to zero.
1392 * else if we have the stored head object for this space, that takes 1568 * else if we have the stored head object for this space, that takes
1393 * precedence over the other object for this space. 1569 * precedence over the other object for this space.
1394 * otherwise, we do special head processing 1570 * otherwise, we do special head processing
1395 */ 1571 */
1396 if (!ob || ob->face == blank_face) face_num=0; 1572 if (!ob || ob->face == blank_face)
1573 face_num = 0;
1397 else if (head){ 1574 else if (head)
1575 {
1398 /* if this is a head that had previously been stored */ 1576 /* if this is a head that had previously been stored */
1399 face_num = ob->face->number; 1577 face_num = ob->face->number;
1400 } else { 1578 }
1579 else
1580 {
1401 /* if the faces for the different parts of a multipart object 1581 /* if the faces for the different parts of a multipart object
1402 * are the same, we only want to send the bottom right most 1582 * are the same, we only want to send the bottom right most
1403 * portion of the object. That info is in the tail_.. values 1583 * portion of the object. That info is in the tail_.. values
1404 * of the head. Note that for the head itself, ob->head will 1584 * of the head. Note that for the head itself, ob->head will
1405 * be null, so we only do this block if we are working on 1585 * be null, so we only do this block if we are working on
1406 * a tail piece. 1586 * a tail piece.
1407 */ 1587 */
1408 1588
1409 /* tail_x and tail_y will only be set in the head object. If 1589 /* tail_x and tail_y will only be set in the head object. If
1410 * this is the head object and these are set, we proceed 1590 * this is the head object and these are set, we proceed
1411 * with logic to only send bottom right. Similarly, if 1591 * with logic to only send bottom right. Similarly, if
1412 * this is one of the more parts but the head has those values 1592 * this is one of the more parts but the head has those values
1413 * set, we want to do the processing. There can be cases where 1593 * set, we want to do the processing. There can be cases where
1414 * the head is not visible but one of its parts is, so we just 1594 * the head is not visible but one of its parts is, so we just
1415 * can always expect that ob->arch->tail_x will be true for all 1595 * can always expect that ob->arch->tail_x will be true for all
1416 * object we may want to display. 1596 * object we may want to display.
1417 */ 1597 */
1418 if ((ob->arch->tail_x || ob->arch->tail_y) || 1598 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1419 (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y))) { 1599 {
1420 1600
1421 if (ob->head) head = ob->head; 1601 if (ob->head)
1422 else head = ob; 1602 head = ob->head;
1603 else
1604 head = ob;
1423 1605
1424 /* Basically figure out where the offset is from where we are right 1606 /* Basically figure out where the offset is from where we are right
1425 * now. the ob->arch->clone.{x,y} values hold the offset that this current 1607 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1426 * piece is from the head, and the tail is where the tail is from the 1608 * piece is from the head, and the tail is where the tail is from the
1427 * head. Note that bx and by will equal sx and sy if we are already working 1609 * head. Note that bx and by will equal sx and sy if we are already working
1428 * on the bottom right corner. If ob is the head, the clone values 1610 * on the bottom right corner. If ob is the head, the clone values
1429 * will be zero, so the right thing will still happen. 1611 * will be zero, so the right thing will still happen.
1430 */ 1612 */
1431 bx = sx + head->arch->tail_x - ob->arch->clone.x; 1613 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1432 by = sy + head->arch->tail_y - ob->arch->clone.y; 1614 by = sy + head->arch->tail_y - ob->arch->clone.y;
1433 1615
1434 /* I don't think this can ever happen, but better to check for it just 1616 /* I don't think this can ever happen, but better to check for it just
1435 * in case. 1617 * in case.
1436 */ 1618 */
1437 if (bx < sx || by < sy) { 1619 if (bx < sx || by < sy)
1620 {
1438 LOG(llevError,"update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", 1621 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1439 bx, by, sx, sy); 1622 face_num = 0;
1440 face_num = 0; 1623 }
1441 }
1442 /* single part object, multipart object with non merged faces, 1624 /* single part object, multipart object with non merged faces,
1443 * of multipart object already at lower right. 1625 * of multipart object already at lower right.
1444 */ 1626 */
1445 else if (bx == sx && by == sy) { 1627 else if (bx == sx && by == sy)
1628 {
1446 face_num = ob->face->number; 1629 face_num = ob->face->number;
1447 1630
1448 /* if this face matches one stored away, clear that one away. 1631 /* if this face matches one stored away, clear that one away.
1449 * this code relies on the fact that the map1 commands 1632 * this code relies on the fact that the map1 commands
1450 * goes from 2 down to 0. 1633 * goes from 2 down to 0.
1451 */ 1634 */
1452 for (i=0; i<MAP_LAYERS; i++) 1635 for (i = 0; i < MAP_LAYERS; i++)
1453 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] && 1636 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1454 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num) 1637 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1455 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL; 1638 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1456 } 1639 }
1457 else { 1640 else
1641 {
1458 /* If this head is stored away, clear it - otherwise, 1642 /* If this head is stored away, clear it - otherwise,
1459 * there can be cases where a object is on multiple layers - 1643 * there can be cases where a object is on multiple layers -
1460 * we only want to send it once. 1644 * we only want to send it once.
1461 */ 1645 */
1462 face_num = head->face->number; 1646 face_num = head->face->number;
1463 for (i=0; i<MAP_LAYERS; i++) 1647 for (i = 0; i < MAP_LAYERS; i++)
1464 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] && 1648 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1465 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num) 1649 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1466 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL; 1650 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1467 1651
1468 /* First, try to put the new head on the same layer. If that is used up, 1652 /* First, try to put the new head on the same layer. If that is used up,
1469 * then find another layer. 1653 * then find another layer.
1470 */ 1654 */
1471 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL) { 1655 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1656 {
1472 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head; 1657 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1473 } else for (i=0; i<MAX_LAYERS; i++) { 1658 }
1659 else
1660 for (i = 0; i < MAX_LAYERS; i++)
1661 {
1474 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL || 1662 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1475 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head) { 1663 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1664 {
1476 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head; 1665 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1477 } 1666 }
1478 } 1667 }
1479 face_num = 0; /* Don't send this object - we'll send the head later */ 1668 face_num = 0; /* Don't send this object - we'll send the head later */
1480 } 1669 }
1481 } else { 1670 }
1671 else
1672 {
1482 /* In this case, we are already at the lower right or single part object, 1673 /* In this case, we are already at the lower right or single part object,
1483 * so nothing special 1674 * so nothing special
1484 */ 1675 */
1485 face_num = ob->face->number; 1676 face_num = ob->face->number;
1486 1677
1487 /* clear out any head entries that have the same face as this one */ 1678 /* clear out any head entries that have the same face as this one */
1488 for (bx=0; bx<layer; bx++) 1679 for (bx = 0; bx < layer; bx++)
1489 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] && 1680 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1490 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num) 1681 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1491 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL; 1682 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1492 } 1683 }
1493 } /* else not already head object or blank face */ 1684 } /* else not already head object or blank face */
1494 1685
1495 /* This is a real hack. Basically, if we have nothing to send for this layer, 1686 /* This is a real hack. Basically, if we have nothing to send for this layer,
1496 * but there is a head on the next layer, send that instead. 1687 * but there is a head on the next layer, send that instead.
1497 * Without this, what happens is you can get the case where the player stands 1688 * Without this, what happens is you can get the case where the player stands
1498 * on the same space as the head. However, if you have overlapping big objects 1689 * on the same space as the head. However, if you have overlapping big objects
1499 * of the same type, what happens then is it doesn't think it needs to send 1690 * of the same type, what happens then is it doesn't think it needs to send
1500 * This tends to make stacking also work/look better. 1691 * This tends to make stacking also work/look better.
1501 */ 1692 */
1502 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer -1]) { 1693 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1694 {
1503 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer -1]->face->number; 1695 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1504 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer -1] = NULL; 1696 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1505 } 1697 }
1506 1698
1507 /* Another hack - because of heads and whatnot, this face may match one 1699 /* Another hack - because of heads and whatnot, this face may match one
1508 * we already sent for a lower layer. In that case, don't send 1700 * we already sent for a lower layer. In that case, don't send
1509 * this one. 1701 * this one.
1510 */ 1702 */
1511 if (face_num && layer+1<MAP_LAYERS && ns->lastmap.cells[sx][sy].faces[layer+1] == face_num) { 1703 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1512 face_num = 0; 1704 face_num = 0;
1513 }
1514 1705
1515 /* We've gotten what face we want to use for the object. Now see if 1706 /* We've gotten what face we want to use for the object. Now see if
1516 * if it has changed since we last sent it to the client. 1707 * if it has changed since we last sent it to the client.
1517 */ 1708 */
1518 if (ns->lastmap.cells[sx][sy].faces[layer] != face_num) { 1709 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num)
1710 {
1519 ns->lastmap.cells[sx][sy].faces[layer] = face_num; 1711 ns.lastmap.cells[sx][sy].faces[layer] = face_num;
1520 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1712 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1521 esrv_send_face(ns, face_num, 0); 1713 esrv_send_face (&ns, face_num, 0);
1522 SockList_AddShort(sl, face_num); 1714
1523 return 1; 1715 sl << uint16 (face_num);
1716 return 1;
1524 } 1717 }
1718
1525 /* Nothing changed */ 1719 /* Nothing changed */
1526 return 0; 1720 return 0;
1527} 1721}
1528 1722
1529/** 1723/**
1530 * This function is mainly a copy of update_space, 1724 * This function is mainly a copy of update_space,
1531 * except it handles update of the smoothing updates, 1725 * except it handles update of the smoothing updates,
… …
1543 * layer is the layer to update, with 2 being the floor and 0 the 1737 * layer is the layer to update, with 2 being the floor and 0 the
1544 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ 1738 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1545 * take. 1739 * take.
1546 */ 1740 */
1547 1741
1742static inline int
1548static inline int update_smooth(SockList *sl, NewSocket *ns, mapstruct *mp, int mx, int my, int sx, int sy, int layer) 1743update_smooth (SockList &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1549{ 1744{
1550 object *ob; 1745 object *ob;
1551 int smoothlevel; /* old face_num;*/ 1746 int smoothlevel; /* old face_num; */
1552 1747
1553 ob = GET_MAP_FACE_OBJ(mp, mx, my, layer); 1748 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1554 1749
1555 /* If there is no object for this space, or if the face for the object 1750 /* If there is no object for this space, or if the face for the object
1556 * is the blank face, set the smoothlevel to zero. 1751 * is the blank face, set the smoothlevel to zero.
1557 */ 1752 */
1558 if (!ob || ob->face == blank_face || MAP_NOSMOOTH(mp)) smoothlevel=0; 1753 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1754 smoothlevel = 0;
1559 else { 1755 else
1756 {
1560 smoothlevel = ob->smoothlevel; 1757 smoothlevel = ob->smoothlevel;
1561 if (smoothlevel && !(ns->faces_sent[ob->face->number] & NS_FACESENT_SMOOTH)) 1758 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1562 SendSmooth(ns, ob->face->number); 1759 SendSmooth (&ns, ob->face->number);
1563 } /* else not already head object or blank face */ 1760 } /* else not already head object or blank face */
1564 1761
1565 /* We've gotten what face we want to use for the object. Now see if 1762 /* We've gotten what face we want to use for the object. Now see if
1566 * if it has changed since we last sent it to the client. 1763 * if it has changed since we last sent it to the client.
1567 */ 1764 */
1568 if (smoothlevel>255) 1765 if (smoothlevel > 255)
1569 smoothlevel=255; 1766 smoothlevel = 255;
1570 else if (smoothlevel<0) 1767 else if (smoothlevel < 0)
1571 smoothlevel=0; 1768 smoothlevel = 0;
1769
1572 if (ns->lastmap.cells[sx][sy].smooth[layer] != smoothlevel) { 1770 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1771 {
1573 ns->lastmap.cells[sx][sy].smooth[layer] = smoothlevel; 1772 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1574 SockList_AddChar(sl, (uint8) (smoothlevel&0xFF)); 1773 sl << uint8 (smoothlevel);
1575 return 1; 1774 return 1;
1576 } 1775 }
1776
1577 /* Nothing changed */ 1777 /* Nothing changed */
1578 return 0; 1778 return 0;
1579} 1779}
1580 1780
1581/** 1781/**
1582 * Returns the size of a data for a map square as returned by 1782 * Returns the size of a data for a map square as returned by
1583 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries 1783 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1584 * available. 1784 * available.
1585 */ 1785 */
1786int
1586int getExtendedMapInfoSize(NewSocket* ns){ 1787getExtendedMapInfoSize (NewSocket * ns)
1788{
1587 int result=0; 1789 int result = 0;
1790
1588 if (ns->ext_mapinfos){ 1791 if (ns->ext_mapinfos)
1792 {
1589 if (ns->EMI_smooth) 1793 if (ns->EMI_smooth)
1590 result+=1; /*One byte for smoothlevel*/ 1794 result += 1; /*One byte for smoothlevel */
1591 } 1795 }
1592 return result; 1796 return result;
1593} 1797}
1798
1594/** 1799/**
1595 * This function uses the new map1 protocol command to send the map 1800 * This function uses the new map1 protocol command to send the map
1596 * to the client. It is necessary because the old map command supports 1801 * to the client. It is necessary because the old map command supports
1597 * a maximum map size of 15x15. 1802 * a maximum map size of 15x15.
1598 * This function is much simpler than the old one. This is because 1803 * This function is much simpler than the old one. This is because
… …
1611 * we use the count value to hold the darkness value. If -1, then this space 1816 * we use the count value to hold the darkness value. If -1, then this space
1612 * is not viewable. 1817 * is not viewable.
1613 * we use faces[0] faces[1] faces[2] to hold what the three layers 1818 * we use faces[0] faces[1] faces[2] to hold what the three layers
1614 * look like. 1819 * look like.
1615 */ 1820 */
1821void
1616void draw_client_map1(object *pl) 1822draw_client_map1 (object *pl)
1617{ 1823{
1618 int x,y,ax, ay, d, startlen, max_x, max_y, oldlen; 1824 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen;
1619 sint16 nx, ny; 1825 sint16 nx, ny;
1620 int estartlen, eoldlen; 1826 int estartlen, eoldlen;
1621 SockList sl;
1622 SockList esl; /*For extended Map info*/
1623 uint16 mask,emask; 1827 uint16 mask, emask;
1624 uint8 eentrysize; 1828 uint8 eentrysize;
1625 uint16 ewhatstart,ewhatflag; 1829 uint16 ewhatstart, ewhatflag;
1626 uint8 extendedinfos; 1830 uint8 extendedinfos;
1627 mapstruct *m; 1831 maptile *m;
1628 1832
1833 NewSocket &socket = pl->contr->socket;
1834
1629 check_map_change (pl->contr); 1835 check_map_change (pl->contr);
1630 1836
1631 sl.buf=(unsigned char*)malloc(MAXSOCKBUF); 1837 SockList sl (MAXSOCKBUF);
1632 if (pl->contr->socket.mapmode == Map1Cmd) 1838 SockList esl (MAXSOCKBUF);
1633 strcpy((char*)sl.buf,"map1 "); 1839
1634 else 1840 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1635 strcpy((char*)sl.buf,"map1a ");
1636 sl.len=strlen((char*)sl.buf);
1637 startlen = sl.len; 1841 startlen = sl.len;
1842
1638 /*Extendedmapinfo structure initialisation*/ 1843 /*Extendedmapinfo structure initialisation */
1639 if (pl->contr->socket.ext_mapinfos){ 1844 if (socket.ext_mapinfos)
1640 esl.buf=(unsigned char*)malloc(MAXSOCKBUF); 1845 {
1641 strcpy((char*)esl.buf,"mapextended ");
1642 esl.len=strlen((char*)esl.buf);
1643 extendedinfos=EMI_NOREDRAW; 1846 extendedinfos = EMI_NOREDRAW;
1847
1644 if (pl->contr->socket.EMI_smooth) 1848 if (socket.EMI_smooth)
1645 extendedinfos|=EMI_SMOOTH; 1849 extendedinfos |= EMI_SMOOTH;
1850
1646 ewhatstart=esl.len; 1851 ewhatstart = esl.len;
1647 ewhatflag=extendedinfos; /*The EMI_NOREDRAW bit 1852 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1648 could need to be taken away*/ 1853 could need to be taken away */
1649 SockList_AddChar(&esl, extendedinfos);
1650 eentrysize=getExtendedMapInfoSize(&(pl->contr->socket)); 1854 eentrysize = getExtendedMapInfoSize (&socket);
1651 SockList_AddChar(&esl, eentrysize); 1855 esl << "mapextended "
1856 << uint8 (extendedinfos)
1857 << uint8 (eentrysize);
1652 estartlen = esl.len; 1858 estartlen = esl.len;
1653 } else { 1859 }
1860 else
1861 {
1654 /* suppress compiler warnings */ 1862 /* suppress compiler warnings */
1655 ewhatstart = 0; 1863 ewhatstart = 0;
1656 ewhatflag = 0; 1864 ewhatflag = 0;
1657 estartlen = 0; 1865 estartlen = 0;
1658 } 1866 }
1867
1659 /* Init data to zero */ 1868 /* Init data to zero */
1660 memset(heads, 0, sizeof(object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS); 1869 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1661 1870
1662 /* x,y are the real map locations. ax, ay are viewport relative 1871 /* x,y are the real map locations. ax, ay are viewport relative
1663 * locations. 1872 * locations.
1664 */ 1873 */
1665 ay=0; 1874 ay = 0;
1666 1875
1667 /* We could do this logic as conditionals in the if statement, 1876 /* We could do this logic as conditionals in the if statement,
1668 * but that started to get a bit messy to look at. 1877 * but that started to get a bit messy to look at.
1669 */ 1878 */
1670 max_x = pl->x+(pl->contr->socket.mapx+1)/2; 1879 max_x = pl->x + (socket.mapx + 1) / 2;
1671 max_y = pl->y+(pl->contr->socket.mapy+1)/2; 1880 max_y = pl->y + (socket.mapy + 1) / 2;
1881
1672 if (pl->contr->socket.mapmode == Map1aCmd) { 1882 if (socket.mapmode == Map1aCmd)
1883 {
1673 max_x += MAX_HEAD_OFFSET; 1884 max_x += MAX_HEAD_OFFSET;
1674 max_y += MAX_HEAD_OFFSET; 1885 max_y += MAX_HEAD_OFFSET;
1886 }
1887
1888 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1675 } 1889 {
1890 ax = 0;
1891 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1892 {
1676 1893
1677 for(y=pl->y-pl->contr->socket.mapy/2; y<max_y; y++,ay++) {
1678 ax=0;
1679 for(x=pl->x-pl->contr->socket.mapx/2;x<max_x;x++,ax++) {
1680
1681 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1894 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1682 1895
1683 /* If this space is out of the normal viewable area, we only check 1896 /* If this space is out of the normal viewable area, we only check
1684 * the heads value ax or ay will only be greater than what 1897 * the heads value ax or ay will only be greater than what
1685 * the client wants if using the map1a command - this is because 1898 * the client wants if using the map1a command - this is because
1686 * if the map1a command is not used, max_x and max_y will be 1899 * if the map1a command is not used, max_x and max_y will be
1687 * set to lower values. 1900 * set to lower values.
1688 */ 1901 */
1689 if (ax >= pl->contr->socket.mapx || ay >= pl->contr->socket.mapy) { 1902 if (ax >= socket.mapx || ay >= socket.mapy)
1690 int i, got_one; 1903 {
1904 int i, got_one;
1691 1905
1692 oldlen = sl.len; 1906 oldlen = sl.len;
1693 1907
1908 sl << uint16 (mask);
1694 1909
1695 SockList_AddShort(&sl, mask); 1910 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1911 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1912 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1696 1913
1697 if (check_head(&sl, &pl->contr->socket, ax, ay, 2))
1698 mask |= 0x4;
1699 if (check_head(&sl, &pl->contr->socket, ax, ay, 1))
1700 mask |= 0x2;
1701 if (check_head(&sl, &pl->contr->socket, ax, ay, 0))
1702 mask |= 0x1;
1703
1704 /* If all we are doing is sending 0 (blank) faces, we don't 1914 /* If all we are doing is sending 0 (blank) faces, we don't
1705 * actually need to send that - just the coordinates 1915 * actually need to send that - just the coordinates
1706 * with no faces tells the client to blank out the 1916 * with no faces tells the client to blank out the
1707 * space. 1917 * space.
1708 */ 1918 */
1709 got_one=0; 1919 got_one = 0;
1710 for (i=oldlen+2; i<sl.len; i++) { 1920 for (i = oldlen + 2; i < sl.len; i++)
1711 if (sl.buf[i]) got_one=1; 1921 if (sl.buf[i])
1712 } 1922 got_one = 1;
1713 1923
1714 if (got_one && (mask & 0xf)) { 1924 if (got_one && (mask & 0xf))
1715 sl.buf[oldlen+1] = mask & 0xff; 1925 sl.buf[oldlen + 1] = mask & 0xff;
1716 } else { /*either all faces blank, either no face at all*/
1717 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates*/
1718 sl.len = oldlen + 2;
1719 else 1926 else
1927 { /*either all faces blank, either no face at all */
1928 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1929 sl.len = oldlen + 2;
1930 else
1931 sl.len = oldlen;
1932 }
1933
1934 /*What concerns extendinfos, nothing to be done for now
1935 * (perhaps effects layer later)
1936 */
1937 continue; /* don't do processing below */
1938 }
1939
1940 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1941
1942 d = pl->contr->blocked_los[ax][ay];
1943
1944 /* If the coordinates are not valid, or it is too dark to see,
1945 * we tell the client as such
1946 */
1947 nx = x;
1948 ny = y;
1949 m = get_map_from_coord (pl->map, &nx, &ny);
1950
1951 if (!m)
1952 {
1953 /* space is out of map. Update space and clear values
1954 * if this hasn't already been done. If the space is out
1955 * of the map, it shouldn't have a head
1956 */
1957 if (lastcell.count != -1)
1958 {
1959 sl << uint16 (mask);
1960 map_clearcell (&lastcell, 0, 0, 0, -1);
1961 }
1962 }
1963 else if (d > 3)
1964 {
1965 int need_send = 0, count;
1966
1967 /* This block deals with spaces that are not visible for whatever
1968 * reason. Still may need to send the head for this space.
1969 */
1970
1971 oldlen = sl.len;
1972
1973 sl << uint16 (mask);
1974
1975 if (lastcell.count != -1)
1976 need_send = 1;
1977
1978 count = -1;
1979
1980 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
1981 {
1982 /* Now check to see if any heads need to be sent */
1983
1984 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1985 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1986 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1987
1988 lastcell.count = count;
1989 }
1990 else
1991 {
1992 /* properly clear a previously sent big face */
1993 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0
1994 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1995 need_send = 1;
1996
1997 map_clearcell (&lastcell, 0, 0, 0, count);
1998 }
1999
2000 if ((mask & 0xf) || need_send)
2001 sl.buf[oldlen + 1] = mask & 0xff;
2002 else
1720 sl.len = oldlen; 2003 sl.len = oldlen;
1721 } 2004 }
1722 /*What concerns extendinfos, nothing to be done for now 2005 else
1723 * (perhaps effects layer later) 2006 {
1724 */
1725 continue; /* don't do processing below */
1726 }
1727
1728 d = pl->contr->blocked_los[ax][ay];
1729
1730 /* If the coordinates are not valid, or it is too dark to see,
1731 * we tell the client as such
1732 */
1733 nx=x;
1734 ny=y;
1735 m = get_map_from_coord(pl->map, &nx, &ny);
1736 if (!m) {
1737 /* space is out of map. Update space and clear values
1738 * if this hasn't already been done. If the space is out
1739 * of the map, it shouldn't have a head
1740 */
1741 if (pl->contr->socket.lastmap.cells[ax][ay].count != -1) {
1742 SockList_AddShort(&sl, mask);
1743 map_clearcell(&pl->contr->socket.lastmap.cells[ax][ay],0,0,0,-1);
1744 }
1745 } else if (d>3) {
1746 int need_send=0, count;
1747 /* This block deals with spaces that are not visible for whatever
1748 * reason. Still may need to send the head for this space.
1749 */
1750
1751 oldlen = sl.len;
1752#if 0
1753 /* First thing we do is blank out this space (clear it)
1754 * if not already done. If the client is using darkness, and
1755 * this space is at the edge, we also include the darkness.
1756 */
1757 if (d==4) {
1758 if (pl->contr->socket.darkness && pl->contr->socket.lastmap.cells[ax][ay].count != d) {
1759 mask |= 8;
1760 SockList_AddShort(&sl, mask);
1761 SockList_AddChar(&sl, 0);
1762 }
1763 count = d;
1764 } else
1765#endif
1766 {
1767 SockList_AddShort(&sl, mask);
1768 if (pl->contr->socket.lastmap.cells[ax][ay].count != -1) need_send=1;
1769 count = -1;
1770 }
1771
1772 if (pl->contr->socket.mapmode == Map1aCmd && have_head(ax, ay)) {
1773 /* Now check to see if any heads need to be sent */
1774
1775 if (check_head(&sl, &pl->contr->socket, ax, ay, 2))
1776 mask |= 0x4;
1777 if (check_head(&sl, &pl->contr->socket, ax, ay, 1))
1778 mask |= 0x2;
1779 if (check_head(&sl, &pl->contr->socket, ax, ay, 0))
1780 mask |= 0x1;
1781 pl->contr->socket.lastmap.cells[ax][ay].count = count;
1782
1783 } else {
1784 struct MapCell *cell = &pl->contr->socket.lastmap.cells[ax][ay];
1785 /* properly clear a previously sent big face */
1786 if(cell->faces[0] != 0
1787 || cell->faces[1] != 0
1788 || cell->faces[2] != 0)
1789 need_send = 1;
1790 map_clearcell(&pl->contr->socket.lastmap.cells[ax][ay], 0, 0, 0, count);
1791 }
1792
1793 if ((mask & 0xf) || need_send) {
1794 sl.buf[oldlen+1] = mask & 0xff;
1795 } else {
1796 sl.len = oldlen;
1797 }
1798 } else {
1799 /* In this block, the space is visible or there are head objects 2007 /* In this block, the space is visible or there are head objects
1800 * we need to send. 2008 * we need to send.
1801 */ 2009 */
1802 2010
1803 /* Rather than try to figure out what everything that we might 2011 /* Rather than try to figure out what everything that we might
1804 * need to send is, then form the packet after that, 2012 * need to send is, then form the packet after that,
1805 * we presume that we will in fact form a packet, and update 2013 * we presume that we will in fact form a packet, and update
1806 * the bits by what we do actually send. If we send nothing, 2014 * the bits by what we do actually send. If we send nothing,
1807 * we just back out sl.len to the old value, and no harm 2015 * we just back out sl.len to the old value, and no harm
1808 * is done. 2016 * is done.
1809 * I think this is simpler than doing a bunch of checks to see 2017 * I think this is simpler than doing a bunch of checks to see
1810 * what if anything we need to send, setting the bits, then 2018 * what if anything we need to send, setting the bits, then
1811 * doing those checks again to add the real data. 2019 * doing those checks again to add the real data.
1812 */ 2020 */
1813 oldlen = sl.len; 2021 oldlen = sl.len;
1814 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 2022 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1815 eoldlen = esl.len; 2023 eoldlen = esl.len;
1816 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 2024 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1817 SockList_AddShort(&sl, mask); 2025 sl << uint16 (mask);
1818 2026
1819 if (pl->contr->socket.ext_mapinfos) 2027 if (socket.ext_mapinfos)
1820 SockList_AddShort(&esl, emask); 2028 esl << uint16 (emask);
1821 2029
1822 /* Darkness changed */ 2030 unsigned char dummy;
1823 if (pl->contr->socket.lastmap.cells[ax][ay].count != d && pl->contr->socket.darkness) { 2031 unsigned char *last_ext = &dummy;
1824 pl->contr->socket.lastmap.cells[ax][ay].count = d;
1825 mask |= 0x8; /* darkness bit */
1826 2032
1827 /* Protocol defines 255 full bright, 0 full dark. 2033 /* Darkness changed */
1828 * We currently don't have that many darkness ranges, 2034 if (lastcell.count != d && socket.darkness)
1829 * so we current what limited values we do have. 2035 {
1830 */ 2036 mask |= 0x8;
1831 if (d==0) SockList_AddChar(&sl, 255);
1832 else if (d==1) SockList_AddChar(&sl, 191);
1833 else if (d==2) SockList_AddChar(&sl, 127);
1834 else if (d==3) SockList_AddChar(&sl, 63);
1835 }
1836 else {
1837 /* need to reset from -1 so that if it does become blocked again,
1838 * the code that deals with that can detect that it needs to tell
1839 * the client that this space is now blocked.
1840 */
1841 pl->contr->socket.lastmap.cells[ax][ay].count = d;
1842 }
1843 2037
1844 /* Floor face */ 2038 if (socket.extmap)
2039 {
2040 *last_ext |= 0x80;
2041 last_ext = sl.buf + sl.len;
2042 sl << uint8 (d);
2043 }
2044 else
2045 sl << uint8 (255 - 64 * d);
2046 }
2047
2048 lastcell.count = d;
2049
2050 if (socket.extmap)
2051 {
2052 uint8 stat_hp = 0;
2053 uint8 stat_width = 0;
2054 uint8 flags = 0;
2055 UUID player = 0;
2056
2057 // send hp information, if applicable
2058 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0))
2059 {
2060 if (op->head || op->invisible)
2061 ; // do not show
2062 else if (op->type == PLAYER
2063 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
2064 {
2065 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
2066 {
2067 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
2068 stat_width = op->arch->tail_x;
2069 }
2070 }
2071
2072 if (op->msg && op->msg[0] == '@')
2073 flags |= 1;
2074
2075 if (op->type == PLAYER && op != pl)
2076 player = op->count;
2077 }
2078
2079 if (lastcell.stat_hp != stat_hp)
2080 {
2081 lastcell.stat_hp = stat_hp;
2082
2083 mask |= 0x8;
2084 *last_ext |= 0x80;
2085 last_ext = sl.buf + sl.len;
2086
2087 sl << uint8 (5) << uint8 (stat_hp);
2088
2089 if (stat_width > 1)
2090 {
2091 *last_ext |= 0x80;
2092 last_ext = sl.buf + sl.len;
2093
2094 sl << uint8 (6) << uint8 (stat_width);
2095 }
2096 }
2097
2098 if (lastcell.player != player)
2099 {
2100 lastcell.player = player;
2101
2102 mask |= 0x8;
2103 *last_ext |= 0x80;
2104 last_ext = sl.buf + sl.len;
2105
2106 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2107 }
2108
2109 if (lastcell.flags != flags)
2110 {
2111 lastcell.flags = flags;
2112
2113 mask |= 0x8;
2114 *last_ext |= 0x80;
2115 last_ext = sl.buf + sl.len;
2116
2117 sl << uint8 (8) << uint8 (flags);
2118 }
2119 }
2120
2121 /* Floor face */
1845 if (update_space(&sl, &pl->contr->socket, m, nx, ny, ax, ay, 2)) 2122 if (update_space (sl, socket, m, nx, ny, ax, ay, 2))
1846 mask |= 0x4; 2123 mask |= 0x4;
1847 2124
1848 if (pl->contr->socket.EMI_smooth) 2125 if (socket.EMI_smooth)
1849 if (update_smooth(&esl, &pl->contr->socket, m, nx, ny, ax, ay, 2)){ 2126 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
1850 emask |= 0x4; 2127 emask |= 0x4;
1851 }
1852 2128
1853 /* Middle face */ 2129 /* Middle face */
1854 if (update_space(&sl, &pl->contr->socket, m, nx, ny, ax, ay, 1)) 2130 if (update_space (sl, socket, m, nx, ny, ax, ay, 1))
1855 mask |= 0x2; 2131 mask |= 0x2;
1856 2132
1857 if (pl->contr->socket.EMI_smooth) 2133 if (socket.EMI_smooth)
1858 if (update_smooth(&esl, &pl->contr->socket, m, nx, ny, ax, ay, 1)){ 2134 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1))
1859 emask |= 0x2; 2135 emask |= 0x2;
1860 }
1861 2136
1862
1863 if(nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1)) { 2137 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
1864 if (pl->contr->socket.lastmap.cells[ax][ay].faces[0] != pl->face->number) { 2138 {
1865 pl->contr->socket.lastmap.cells[ax][ay].faces[0] = pl->face->number; 2139 if (lastcell.faces[0] != pl->face->number)
1866 mask |= 0x1; 2140 {
2141 lastcell.faces[0] = pl->face->number;
2142 mask |= 0x1;
2143
1867 if (!(pl->contr->socket.faces_sent[pl->face->number] &NS_FACESENT_FACE)) 2144 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
1868 esrv_send_face(&pl->contr->socket, pl->face->number, 0); 2145 esrv_send_face (&socket, pl->face->number, 0);
1869 SockList_AddShort(&sl, pl->face->number); 2146
1870 } 2147 sl << uint16 (pl->face->number);
1871 } 2148 }
1872 /* Top face */ 2149 }
1873 else { 2150 else
2151 {
2152 /* Top face */
1874 if (update_space(&sl, &pl->contr->socket, m, nx, ny, ax, ay, 0)) 2153 if (update_space (sl, socket, m, nx, ny, ax, ay, 0))
1875 mask |= 0x1; 2154 mask |= 0x1;
1876 if (pl->contr->socket.EMI_smooth) 2155
1877 if (update_smooth(&esl, &pl->contr->socket, m, nx, ny, ax, ay, 0)){ 2156 if (socket.EMI_smooth)
1878 emask |= 0x1; 2157 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
1879 } 2158 emask |= 0x1;
1880 } 2159 }
2160
1881 /* Check to see if we are in fact sending anything for this 2161 /* Check to see if we are in fact sending anything for this
1882 * space by checking the mask. If so, update the mask. 2162 * space by checking the mask. If so, update the mask.
1883 * if not, reset the len to that from before adding the mask 2163 * if not, reset the len to that from before adding the mask
1884 * value, so we don't send those bits. 2164 * value, so we don't send those bits.
1885 */ 2165 */
1886 if (mask & 0xf) { 2166 if (mask & 0xf)
1887 sl.buf[oldlen+1] = mask & 0xff; 2167 sl.buf[oldlen + 1] = mask & 0xff;
1888 } else { 2168 else
1889 sl.len = oldlen; 2169 sl.len = oldlen;
1890 } 2170
1891 if (emask & 0xf) { 2171 if (emask & 0xf)
1892 esl.buf[eoldlen+1] = emask & 0xff; 2172 esl.buf[eoldlen + 1] = emask & 0xff;
1893 } else { 2173 else
1894 esl.len = eoldlen; 2174 esl.len = eoldlen;
1895 }
1896 } /* else this is a viewable space */ 2175 } /* else this is a viewable space */
1897 } /* for x loop */ 2176 } /* for x loop */
1898 } /* for y loop */ 2177 } /* for y loop */
1899 2178
1900 /* Verify that we in fact do need to send this */ 2179 /* Verify that we in fact do need to send this */
1901 if (pl->contr->socket.ext_mapinfos){ 2180 if (socket.ext_mapinfos)
2181 {
1902 if (!(sl.len>startlen || pl->contr->socket.sent_scroll)){ 2182 if (!(sl.len > startlen || socket.sent_scroll))
2183 {
1903 /* No map data will follow, so don't say the client 2184 /* No map data will follow, so don't say the client
1904 * it doesn't need draw! 2185 * it doesn't need draw!
1905 */ 2186 */
1906 ewhatflag&=(~EMI_NOREDRAW); 2187 ewhatflag &= (~EMI_NOREDRAW);
1907 esl.buf[ewhatstart+1] = ewhatflag & 0xff; 2188 esl.buf[ewhatstart + 1] = ewhatflag & 0xff;
1908 } 2189 }
2190
1909 if (esl.len>estartlen) { 2191 if (esl.len > estartlen)
1910 Send_With_Handling(&pl->contr->socket, &esl); 2192 Send_With_Handling (&socket, &esl);
1911 }
1912 free(esl.buf);
1913 } 2193 }
2194
1914 if (sl.len>startlen || pl->contr->socket.sent_scroll) { 2195 if (sl.len > startlen || socket.sent_scroll)
1915 Send_With_Handling(&pl->contr->socket, &sl);
1916 pl->contr->socket.sent_scroll = 0;
1917 } 2196 {
1918 free(sl.buf); 2197 Send_With_Handling (&socket, &sl);
2198 socket.sent_scroll = 0;
2199 }
2200
2201 sl.free ();
2202 esl.free ();
1919} 2203}
1920 2204
1921/** 2205/**
1922 * Draws client map. 2206 * Draws client map.
1923 */ 2207 */
2208void
1924void draw_client_map(object *pl) 2209draw_client_map (object *pl)
1925{ 2210{
1926 int i,j; 2211 int i, j;
1927 sint16 ax, ay, nx, ny;/* ax and ay goes from 0 to max-size of arrays */ 2212 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */
1928 New_Face *face,*floor; 2213 New_Face *face, *floor;
1929 New_Face *floor2; 2214 New_Face *floor2;
1930 int d, mflags; 2215 int d, mflags;
1931 struct Map newmap; 2216 struct Map newmap;
1932 mapstruct *m, *pm; 2217 maptile *m, *pm;
1933 2218
1934 if (pl->type != PLAYER) { 2219 if (pl->type != PLAYER)
2220 {
1935 LOG(llevError,"draw_client_map called with non player/non eric-server\n"); 2221 LOG (llevError, "draw_client_map called with non player/non eric-server\n");
1936 return; 2222 return;
1937 } 2223 }
1938 2224
1939 if (pl->contr->transport) {
1940 pm = pl->contr->transport->map;
1941 }
1942 else
1943 pm = pl->map; 2225 pm = pl->map;
1944 2226
1945 /* If player is just joining the game, he isn't here yet, so the map 2227 /* If player is just joining the game, he isn't here yet, so the map
1946 * can get swapped out. If so, don't try to send them a map. All will 2228 * can get swapped out. If so, don't try to send them a map. All will
1947 * be OK once they really log in. 2229 * be OK once they really log in.
1948 */ 2230 */
1949 if (pm==NULL || pm->in_memory!=MAP_IN_MEMORY) return; 2231 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2232 return;
1950 2233
1951 memset(&newmap, 0, sizeof(struct Map)); 2234 memset (&newmap, 0, sizeof (struct Map));
1952 2235
1953 for(j = (pl->y - pl->contr->socket.mapy/2) ; j < (pl->y + (pl->contr->socket.mapy+1)/2); j++) { 2236 for (j = (pl->y - pl->contr->socket.mapy / 2); j < (pl->y + (pl->contr->socket.mapy + 1) / 2); j++)
2237 {
1954 for(i = (pl->x - pl->contr->socket.mapx/2) ; i < (pl->x + (pl->contr->socket.mapx+1)/2); i++) { 2238 for (i = (pl->x - pl->contr->socket.mapx / 2); i < (pl->x + (pl->contr->socket.mapx + 1) / 2); i++)
1955 ax=i; 2239 {
1956 ay=j; 2240 ax = i;
2241 ay = j;
1957 m = pm; 2242 m = pm;
1958 mflags = get_map_flags(m, &m, ax, ay, &ax, &ay); 2243 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
1959 if (mflags & P_OUT_OF_MAP) 2244 if (mflags & P_OUT_OF_MAP)
1960 continue; 2245 continue;
1961 if (mflags & P_NEED_UPDATE) 2246 if (mflags & P_NEED_UPDATE)
1962 update_position(m, ax, ay); 2247 update_position (m, ax, ay);
1963 /* If a map is visible to the player, we don't want to swap it out 2248 /* If a map is visible to the player, we don't want to swap it out
1964 * just to reload it. This should really call something like 2249 * just to reload it. This should really call something like
1965 * swap_map, but this is much more efficient and 'good enough' 2250 * swap_map, but this is much more efficient and 'good enough'
1966 */ 2251 */
1967 if (mflags & P_NEW_MAP) 2252 if (mflags & P_NEW_MAP)
1968 m->timeout = 50; 2253 m->timeout = 50;
1969 } 2254 }
1970 } 2255 }
1971 /* do LOS after calls to update_position */ 2256 /* do LOS after calls to update_position */
1972 if(pl->contr->do_los) { 2257 if (pl->contr->do_los)
2258 {
1973 update_los(pl); 2259 update_los (pl);
1974 pl->contr->do_los = 0; 2260 pl->contr->do_los = 0;
1975 } 2261 }
1976 2262
1977 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd) { 2263 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd)
2264 {
1978 /* Big maps need a different drawing mechanism to work */ 2265 /* Big maps need a different drawing mechanism to work */
1979 draw_client_map1(pl); 2266 draw_client_map1 (pl);
1980 return; 2267 return;
1981 }
1982 2268 }
2269
1983 if(pl->invisible & (pl->invisible < 50 ? 4 : 1)) { 2270 if (pl->invisible & (pl->invisible < 50 ? 4 : 1))
1984 esrv_map_setbelow(&pl->contr->socket,pl->contr->socket.mapx/2,
1985 pl->contr->socket.mapy/2,pl->face->number,&newmap);
1986 } 2271 {
2272 esrv_map_setbelow (&pl->contr->socket, pl->contr->socket.mapx / 2, pl->contr->socket.mapy / 2, pl->face->number, &newmap);
2273 }
1987 2274
1988 /* j and i are the y and x coordinates of the real map (which is 2275 /* j and i are the y and x coordinates of the real map (which is
1989 * basically some number of spaces around the player) 2276 * basically some number of spaces around the player)
1990 * ax and ay are values from within the viewport (ie, 0, 0 is upper 2277 * ax and ay are values from within the viewport (ie, 0, 0 is upper
1991 * left corner) and are thus disconnected from the map values. 2278 * left corner) and are thus disconnected from the map values.
1992 * Subtract 1 from the max values so that we properly handle cases where 2279 * Subtract 1 from the max values so that we properly handle cases where
1993 * player has specified an even map. Otherwise, we try to send them too 2280 * player has specified an even map. Otherwise, we try to send them too
1994 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually 2281 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually
1995 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is 2282 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is
1996 * odd, this still works fine. 2283 * odd, this still works fine.
1997 */ 2284 */
1998 ay=0; 2285 ay = 0;
1999 for(j=pl->y-pl->contr->socket.mapy/2; j<=pl->y+(pl->contr->socket.mapy-1)/2;j++, ay++) { 2286 for (j = pl->y - pl->contr->socket.mapy / 2; j <= pl->y + (pl->contr->socket.mapy - 1) / 2; j++, ay++)
2000 ax=0; 2287 {
2288 ax = 0;
2001 for(i=pl->x-pl->contr->socket.mapx/2;i<=pl->x+(pl->contr->socket.mapx-1)/2;i++, ax++) { 2289 for (i = pl->x - pl->contr->socket.mapx / 2; i <= pl->x + (pl->contr->socket.mapx - 1) / 2; i++, ax++)
2290 {
2002 2291
2003 d = pl->contr->blocked_los[ax][ay]; 2292 d = pl->contr->blocked_los[ax][ay];
2004 /* note the out_of_map and d>3 checks are both within the same 2293 /* note the out_of_map and d>3 checks are both within the same
2005 * negation check. 2294 * negation check.
2006 */ 2295 */
2007 nx = i; 2296 nx = i;
2008 ny = j; 2297 ny = j;
2009 m = get_map_from_coord(pm, &nx, &ny); 2298 m = get_map_from_coord (pm, &nx, &ny);
2010 if (m && d<4) { 2299 if (m && d < 4)
2300 {
2011 face = GET_MAP_FACE(m, nx, ny,0); 2301 face = GET_MAP_FACE (m, nx, ny, 0);
2012 floor2 = GET_MAP_FACE(m, nx, ny,1); 2302 floor2 = GET_MAP_FACE (m, nx, ny, 1);
2013 floor = GET_MAP_FACE(m, nx, ny,2); 2303 floor = GET_MAP_FACE (m, nx, ny, 2);
2014 2304
2015 /* If all is blank, send a blank face. */ 2305 /* If all is blank, send a blank face. */
2016 if ((!face || face == blank_face) && 2306 if ((!face || face == blank_face) && (!floor2 || floor2 == blank_face) && (!floor || floor == blank_face))
2017 (!floor2 || floor2 == blank_face) && 2307 {
2018 (!floor || floor == blank_face)) { 2308 esrv_map_setbelow (&pl->contr->socket, ax, ay, blank_face->number, &newmap);
2019 esrv_map_setbelow(&pl->contr->socket,ax,ay, 2309 }
2020 blank_face->number,&newmap); 2310 else
2021 } else { /* actually have something interesting */ 2311 { /* actually have something interesting */
2022 /* send the darkness mask, if any. */ 2312 /* send the darkness mask, if any. */
2023 if (d && pl->contr->socket.darkness) 2313 if (d && pl->contr->socket.darkness)
2024 esrv_map_setbelow(&pl->contr->socket,ax,ay, 2314 esrv_map_setbelow (&pl->contr->socket, ax, ay, dark_faces[d - 1]->number, &newmap);
2025 dark_faces[d-1]->number,&newmap);
2026 2315
2027 if (face && face != blank_face) 2316 if (face && face != blank_face)
2028 esrv_map_setbelow(&pl->contr->socket,ax,ay, 2317 esrv_map_setbelow (&pl->contr->socket, ax, ay, face->number, &newmap);
2029 face->number,&newmap);
2030 if (floor2 && floor2 != blank_face) 2318 if (floor2 && floor2 != blank_face)
2031 esrv_map_setbelow(&pl->contr->socket,ax,ay, 2319 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor2->number, &newmap);
2032 floor2->number,&newmap);
2033 if (floor && floor != blank_face) 2320 if (floor && floor != blank_face)
2034 esrv_map_setbelow(&pl->contr->socket,ax,ay, 2321 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2035 floor->number,&newmap); 2322 }
2036 } 2323 } /* Is a valid space */
2037 } /* Is a valid space */ 2324 }
2038 }
2039 } 2325 }
2326
2040 esrv_map_doneredraw(&pl->contr->socket, &newmap); 2327 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2041 2328
2042 check_map_change (pl->contr); 2329 check_map_change (pl->contr);
2043} 2330}
2044 2331
2045 2332
2046/*****************************************************************************/ 2333/*****************************************************************************/
2334
2047/* GROS: The following one is used to allow a plugin to send a generic cmd to*/ 2335/* GROS: The following one is used to allow a plugin to send a generic cmd to*/
2336
2048/* a player. Of course, the client need to know the command to be able to */ 2337/* a player. Of course, the client need to know the command to be able to */
2338
2049/* manage it ! */ 2339/* manage it ! */
2340
2050/*****************************************************************************/ 2341/*****************************************************************************/
2342void
2051void send_plugin_custom_message(object *pl, char *buf) 2343send_plugin_custom_message (object *pl, char *buf)
2052{ 2344{
2053 cs_write_string(&pl->contr->socket,buf,strlen(buf)); 2345 cs_write_string (&pl->contr->socket, buf, strlen (buf));
2054} 2346}
2055 2347
2056/** 2348/**
2057 * This sends the skill number to name mapping. We ignore 2349 * This sends the skill number to name mapping. We ignore
2058 * the params - we always send the same info no matter what. 2350 * the params - we always send the same info no matter what.
2059 */ 2351 */
2352void
2060void send_skill_info(NewSocket *ns, char *params) 2353send_skill_info (NewSocket *ns, char *params)
2061{ 2354{
2062 SockList sl; 2355 SockList sl (MAXSOCKBUF);
2063 int i; 2356 sl << "replyinfo skill_info\n";
2064 2357
2065 sl.buf = (unsigned char*) malloc(MAXSOCKBUF);
2066 strcpy((char*)sl.buf,"replyinfo skill_info\n");
2067 for (i=1; i< NUM_SKILLS; i++) { 2358 for (int i = 1; i < NUM_SKILLS; i++)
2068 sprintf((char*)sl.buf + strlen((char*)sl.buf), "%d:%s\n", i + CS_STAT_SKILLINFO, 2359 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2069 skill_names[i]); 2360
2070 }
2071 sl.len = strlen((char*)sl.buf);
2072 if (sl.len >= MAXSOCKBUF) { 2361 if (sl.len >= MAXSOCKBUF)
2362 {
2073 LOG(llevError,"Buffer overflow in send_skill_info!\n"); 2363 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2074 fatal(0); 2364 fatal (0);
2075 } 2365 }
2366
2076 Send_With_Handling(ns, &sl); 2367 Send_With_Handling (ns, &sl);
2077 free(sl.buf); 2368 sl.free ();
2078} 2369}
2079 2370
2080/** 2371/**
2081 * This sends the spell path to name mapping. We ignore 2372 * This sends the spell path to name mapping. We ignore
2082 * the params - we always send the same info no matter what. 2373 * the params - we always send the same info no matter what.
2083 */ 2374 */
2375void
2084void send_spell_paths (NewSocket *ns, char *params) { 2376send_spell_paths (NewSocket * ns, char *params)
2085 SockList sl; 2377{
2086 int i; 2378 SockList sl (MAXSOCKBUF);
2087 2379
2088 sl.buf = (unsigned char*) malloc(MAXSOCKBUF); 2380 sl << "replyinfo spell_paths\n";
2089 strcpy((char*)sl.buf,"replyinfo spell_paths\n"); 2381
2090 for(i=0; i<NRSPELLPATHS; i++) 2382 for (int i = 0; i < NRSPELLPATHS; i++)
2091 sprintf((char*)sl.buf + strlen((char*)sl.buf), "%d:%s\n", 1<<i, spellpathnames[i]); 2383 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2092 sl.len = strlen((char*)sl.buf); 2384
2093 if (sl.len >= MAXSOCKBUF) { 2385 if (sl.len >= MAXSOCKBUF)
2386 {
2094 LOG(llevError,"Buffer overflow in send_spell_paths!\n"); 2387 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2095 fatal(0); 2388 fatal (0);
2096 } 2389 }
2390
2097 Send_With_Handling(ns, &sl); 2391 Send_With_Handling (ns, &sl);
2098 free(sl.buf); 2392 sl.free ();
2099} 2393}
2100 2394
2101/** 2395/**
2102 * This looks for any spells the player may have that have changed their stats. 2396 * This looks for any spells the player may have that have changed their stats.
2103 * it then sends an updspell packet for each spell that has changed in this way 2397 * it then sends an updspell packet for each spell that has changed in this way
2104 */ 2398 */
2399void
2105void esrv_update_spells(player *pl) { 2400esrv_update_spells (player *pl)
2106 SockList sl; 2401{
2107 int flags=0;
2108 object *spell;
2109 if (!pl->socket.monitor_spells) return; 2402 if (!pl->socket.monitor_spells)
2403 return;
2404
2110 for (spell=pl->ob->inv; spell!=NULL; spell=spell->below) { 2405 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2406 {
2111 if (spell->type == SPELL) { 2407 if (spell->type == SPELL)
2408 {
2409 int flags = 0;
2410
2112 /* check if we need to update it*/ 2411 /* check if we need to update it */
2113 if (spell->last_sp != SP_level_spellpoint_cost(pl->ob, spell, SPELL_MANA)) { 2412 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
2413 {
2114 spell->last_sp = SP_level_spellpoint_cost(pl->ob, spell, SPELL_MANA); 2414 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2115 flags |= UPD_SP_MANA; 2415 flags |= UPD_SP_MANA;
2116 } 2416 }
2417
2117 if (spell->last_grace != SP_level_spellpoint_cost(pl->ob, spell, SPELL_GRACE)) { 2418 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
2419 {
2118 spell->last_grace = SP_level_spellpoint_cost(pl->ob, spell, SPELL_GRACE); 2420 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2119 flags |= UPD_SP_GRACE; 2421 flags |= UPD_SP_GRACE;
2120 } 2422 }
2423
2121 if (spell->last_eat != spell->stats.dam+SP_level_dam_adjust(pl->ob, spell)) { 2424 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
2425 {
2122 spell->last_eat = spell->stats.dam+SP_level_dam_adjust(pl->ob, spell); 2426 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2123 flags |= UPD_SP_DAMAGE; 2427 flags |= UPD_SP_DAMAGE;
2428 }
2429
2430 if (flags)
2431 {
2432 SockList sl (MAXSOCKBUF);
2433
2434 sl << "updspell "
2435 << uint8 (flags)
2436 << uint32 (spell->count);
2437
2438 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2439 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2440 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2441
2442 Send_With_Handling (&pl->socket, &sl);
2443 sl.free ();
2444 }
2445 }
2124 } 2446 }
2125 if (flags !=0) {
2126 sl.buf =(unsigned char*) malloc(MAXSOCKBUF);
2127 strcpy((char*)sl.buf,"updspell ");
2128 sl.len=strlen((char*)sl.buf);
2129 SockList_AddChar(&sl, flags);
2130 SockList_AddInt(&sl, spell->count);
2131 if (flags & UPD_SP_MANA) SockList_AddShort(&sl, spell->last_sp);
2132 if (flags & UPD_SP_GRACE) SockList_AddShort(&sl, spell->last_grace);
2133 if (flags & UPD_SP_DAMAGE) SockList_AddShort(&sl, spell->last_eat);
2134 flags = 0;
2135 Send_With_Handling(&pl->socket, &sl);
2136 free(sl.buf);
2137 }
2138 }
2139 }
2140} 2447}
2141 2448
2449void
2142void esrv_remove_spell(player *pl, object *spell) { 2450esrv_remove_spell (player *pl, object *spell)
2143 SockList sl; 2451{
2144
2145 if (!pl->socket.monitor_spells) return; 2452 if (!pl->socket.monitor_spells)
2453 return;
2454
2146 if (!pl || !spell || spell->env != pl->ob) { 2455 if (!pl || !spell || spell->env != pl->ob)
2456 {
2147 LOG(llevError, "Invalid call to esrv_remove_spell"); 2457 LOG (llevError, "Invalid call to esrv_remove_spell");
2148 return; 2458 return;
2149 } 2459 }
2150 sl.buf = (unsigned char*) malloc(MAXSOCKBUF); 2460
2151 strcpy((char*)sl.buf,"delspell "); 2461 SockList sl (MAXSOCKBUF);
2152 sl.len=strlen((char*)sl.buf); 2462
2153 SockList_AddInt(&sl, spell->count); 2463 sl << "delspell "
2464 << uint32 (spell->count);
2465
2154 Send_With_Handling(&pl->socket, &sl); 2466 Send_With_Handling (&pl->socket, &sl);
2155 free(sl.buf); 2467 sl.free ();
2156} 2468}
2157 2469
2158/* appends the spell *spell to the Socklist we will send the data to. */ 2470/* appends the spell *spell to the Socklist we will send the data to. */
2471static void
2159static void append_spell (player *pl, SockList *sl, object *spell) { 2472append_spell (player *pl, SockList &sl, object *spell)
2473{
2160 int len, i, skill=0; 2474 int len, i, skill = 0;
2161 2475
2162 if (!(spell->name)) { 2476 if (!(spell->name))
2477 {
2163 LOG(llevError, "item number %d is a spell with no name.\n", spell->count); 2478 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2164 return; 2479 return;
2165 } 2480 }
2166 SockList_AddInt(sl, spell->count); 2481
2167 SockList_AddShort(sl, spell->level);
2168 SockList_AddShort(sl, spell->casting_time);
2169 /* store costs and damage in the object struct, to compare to later */ 2482 /* store costs and damage in the object struct, to compare to later */
2170 spell->last_sp = SP_level_spellpoint_cost(pl->ob, spell, SPELL_MANA); 2483 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2171 spell->last_grace = SP_level_spellpoint_cost(pl->ob, spell, SPELL_GRACE); 2484 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2172 spell->last_eat = spell->stats.dam+SP_level_dam_adjust(pl->ob, spell); 2485 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2173 /* send the current values */
2174 SockList_AddShort(sl, spell->last_sp);
2175 SockList_AddShort(sl, spell->last_grace);
2176 SockList_AddShort(sl, spell->last_eat);
2177 2486
2178 /* figure out which skill it uses, if it uses one */ 2487 /* figure out which skill it uses, if it uses one */
2179 if (spell->skill) { 2488 if (spell->skill)
2489 {
2180 for (i=1; i< NUM_SKILLS; i++) 2490 for (i = 1; i < NUM_SKILLS; i++)
2181 if (!strcmp(spell->skill, skill_names[i])) { 2491 if (!strcmp (spell->skill, skill_names[i]))
2492 {
2182 skill = i+CS_STAT_SKILLINFO; 2493 skill = i + CS_STAT_SKILLINFO;
2183 break; 2494 break;
2495 }
2184 } 2496 }
2185 }
2186 SockList_AddChar(sl, skill);
2187 2497
2188 SockList_AddInt(sl, spell->path_attuned); 2498 /* send the current values */
2189 SockList_AddInt(sl, (spell->face)?spell->face->number:0); 2499 sl << uint32 (spell->count)
2190 2500 << uint16 (spell->level)
2191 len = strlen(spell->name); 2501 << uint16 (spell->casting_time)
2192 SockList_AddChar(sl, (char)len); 2502 << uint16 (spell->last_sp)
2193 memcpy(sl->buf+sl->len, spell->name, len); 2503 << uint16 (spell->last_grace)
2194 sl->len+=len; 2504 << uint16 (spell->last_eat)
2195 2505 << uint8 (skill)
2196 if (!spell->msg) { 2506 << uint32 (spell->path_attuned)
2197 SockList_AddShort(sl, 0); 2507 << uint32 (spell->face ? spell->face->number : 0)
2198 } 2508 << data8 (spell->name)
2199 else { 2509 << data16 (spell->msg);
2200 len = strlen(spell->msg);
2201 SockList_AddShort(sl, len);
2202 memcpy(sl->buf+sl->len, spell->msg, len);
2203 sl->len+=len;
2204 }
2205} 2510}
2206 2511
2207/** 2512/**
2208 * This tells the client to add the spell *ob, if *ob is NULL, then add 2513 * This tells the client to add the spell *ob, if *ob is NULL, then add
2209 * all spells in the player's inventory. 2514 * all spells in the player's inventory.
2210 */ 2515 */
2516void
2211void esrv_add_spells(player *pl, object *spell) { 2517esrv_add_spells (player *pl, object *spell)
2212 SockList sl; 2518{
2213 if (!pl) { 2519 if (!pl)
2520 {
2214 LOG(llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 2521 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2215 return; 2522 return;
2216 } 2523 }
2524
2217 if (!pl->socket.monitor_spells) return; 2525 if (!pl->socket.monitor_spells)
2218 sl.buf = (unsigned char*) malloc(MAXSOCKBUF); 2526 return;
2219 strcpy((char*)sl.buf,"addspell "); 2527
2220 sl.len=strlen((char*)sl.buf); 2528 SockList sl (MAXSOCKBUF);
2529
2530 sl << "addspell ";
2531
2221 if (!spell) { 2532 if (!spell)
2533 {
2222 for (spell=pl->ob->inv; spell!=NULL; spell=spell->below) { 2534 for (spell = pl->ob->inv; spell != NULL; spell = spell->below)
2535 {
2223 /* were we to simply keep appending data here, we could exceed 2536 /* were we to simply keep appending data here, we could exceed
2224 * MAXSOCKBUF if the player has enough spells to add, we know that 2537 * MAXSOCKBUF if the player has enough spells to add, we know that
2225 * append_spells will always append 19 data bytes, plus 4 length 2538 * append_spells will always append 19 data bytes, plus 4 length
2226 * bytes and 3 strings (because that is the spec) so we need to 2539 * bytes and 3 strings (because that is the spec) so we need to
2227 * check that the length of those 3 strings, plus the 23 bytes, 2540 * check that the length of those 3 strings, plus the 23 bytes,
2228 * won't take us over the length limit for the socket, if it does, 2541 * won't take us over the length limit for the socket, if it does,
2229 * we need to send what we already have, and restart packet formation 2542 * we need to send what we already have, and restart packet formation
2230 */ 2543 */
2231 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 2544 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
2232 * to show add_spell is 26 bytes + 2 strings. However, the overun 2545 * to show add_spell is 26 bytes + 2 strings. However, the overun
2233 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 2546 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2234 * like it will fix this 2547 * like it will fix this
2235 */ 2548 */
2236 if (spell->type != SPELL) continue; 2549 if (spell->type != SPELL)
2237 if (sl.len >= (MAXSOCKBUF - (26 + strlen(spell->name) + 2550 continue;
2238 (spell->msg?strlen(spell->msg):0)))) { 2551
2552 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2553 {
2239 Send_With_Handling(&pl->socket, &sl); 2554 Send_With_Handling (&pl->socket, &sl);
2240 strcpy((char*)sl.buf,"addspell "); 2555 strcpy ((char *) sl.buf, "addspell ");
2241 sl.len=strlen((char*)sl.buf); 2556 sl.len = strlen ((char *) sl.buf);
2557 }
2558
2559 append_spell (pl, sl, spell);
2560 }
2242 } 2561 }
2562 else if (spell->type != SPELL)
2563 {
2564 LOG (llevError, "Asked to send a non-spell object as a spell");
2565 return;
2566 }
2567 else
2243 append_spell(pl, &sl, spell); 2568 append_spell (pl, sl, spell);
2244 } 2569
2245 }
2246 else if (spell->type != SPELL) {
2247 LOG(llevError, "Asked to send a non-spell object as a spell");
2248 return;
2249 }
2250 else append_spell(pl, &sl, spell);
2251 if (sl.len >= MAXSOCKBUF) { 2570 if (sl.length () >= MAXSOCKBUF)
2571 {
2252 LOG(llevError,"Buffer overflow in esrv_add_spells!\n"); 2572 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2253 fatal(0); 2573 fatal (0);
2254 } 2574 }
2575
2255 /* finally, we can send the packet */ 2576 /* finally, we can send the packet */
2256 Send_With_Handling(&pl->socket, &sl); 2577 Send_With_Handling (&pl->socket, &sl);
2257 free(sl.buf);
2258}
2259 2578
2579 sl.free ();
2580}
2581

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines