ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.21 by root, Sat Sep 16 22:24:13 2006 UTC vs.
Revision 1.36 by root, Thu Dec 14 04:30:33 2006 UTC

41 * if a face has not already been sent to the client, it is sent now. 41 * if a face has not already been sent to the client, it is sent now.
42 * 42 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing 43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations 44 * operations
45 * 45 *
46 * esrv_map_doneredraw finishes the map update, and ships across the
47 * map updates.
48 *
49 */ 46 */
50 47
51#include <global.h> 48#include <global.h>
52#include <sproto.h> 49#include <sproto.h>
53 50
57#include <commands.h> 54#include <commands.h>
58 55
59/* This block is basically taken from socket.c - I assume if it works there, 56/* This block is basically taken from socket.c - I assume if it works there,
60 * it should work here. 57 * it should work here.
61 */ 58 */
62#ifndef WIN32 /* ---win32 exclude unix headers */
63# include <sys/types.h> 59#include <sys/types.h>
64# include <sys/time.h> 60#include <sys/time.h>
65# include <sys/socket.h> 61#include <sys/socket.h>
66# include <netinet/in.h> 62#include <netinet/in.h>
67# include <netdb.h> 63#include <netdb.h>
68#endif /* win32 */
69 64
70#ifdef HAVE_UNISTD_H 65#ifdef HAVE_UNISTD_H
71# include <unistd.h> 66# include <unistd.h>
72#endif 67#endif
73 68
98 -1, /* life stealing */ 93 -1, /* life stealing */
99 -1 /* Disease - not fully done yet */ 94 -1 /* Disease - not fully done yet */
100}; 95};
101 96
102static void 97static void
103socket_map_scroll (NewSocket * ns, int dx, int dy) 98socket_map_scroll (client_socket * ns, int dx, int dy)
104{ 99{
105 struct Map newmap; 100 struct Map newmap;
106 int x, y, mx, my; 101 int x, y, mx, my;
107 102
108 { 103 {
109 char buf[MAXSOCKBUF]; 104 packet sl;
110 105
111 sprintf (buf, "map_scroll %d %d", dx, dy); 106 sl.printf ("map_scroll %d %d", dx, dy);
112 Write_String_To_Socket (ns, buf, strlen (buf)); 107 ns->send_packet (sl);
113 } 108 }
114 109
115 /* If we are using the Map1aCmd, we may in fact send 110 /* If we are using the Map1aCmd, we may in fact send
116 * head information that is outside the viewable map. 111 * head information that is outside the viewable map.
117 * So set the mx,my to the max value we want to 112 * So set the mx,my to the max value we want to
137 for (x = 0; x < mx; x++) 132 for (x = 0; x < mx; x++)
138 { 133 {
139 for (y = 0; y < my; y++) 134 for (y = 0; y < my; y++)
140 { 135 {
141 if (x >= ns->mapx || y >= ns->mapy) 136 if (x >= ns->mapx || y >= ns->mapy)
142 {
143 /* clear cells outside the viewable area */ 137 /* clear cells outside the viewable area */
144 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell)); 138 memset (&newmap.cells[x][y], 0, sizeof (struct MapCell));
145 }
146 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy) 139 else if ((x + dx) < 0 || (x + dx) >= ns->mapx || (y + dy) < 0 || (y + dy) >= ns->mapy)
147 {
148 /* clear newly visible tiles within the viewable area */ 140 /* clear newly visible tiles within the viewable area */
149 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell)); 141 memset (&(newmap.cells[x][y]), 0, sizeof (struct MapCell));
150 }
151 else 142 else
152 {
153 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell)); 143 memcpy (&(newmap.cells[x][y]), &(ns->lastmap.cells[x + dx][y + dy]), sizeof (struct MapCell));
154 }
155 } 144 }
156 } 145 }
157 146
158 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map)); 147 memcpy (&(ns->lastmap), &newmap, sizeof (struct Map));
159 148
164} 153}
165 154
166static void 155static void
167clear_map (player *pl) 156clear_map (player *pl)
168{ 157{
169 NewSocket & socket = pl->socket; 158 client_socket &socket = *pl->socket;
170 159
171 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 160 memset (&socket.lastmap, 0, sizeof (socket.lastmap));
172 161
173 if (socket.newmapcmd == 1) 162 if (socket.newmapcmd == 1)
174 Write_String_To_Socket (&socket, "newmap", 6); 163 socket.send_packet ("newmap");
175 164
176 socket.update_look = 1; 165 socket.update_look = 1;
177 socket.look_position = 0; 166 socket.look_position = 0;
178} 167}
179 168
180/** check for map change and send new map data */ 169/** check for map change and send new map data */
181static void 170static void
182check_map_change (player *pl) 171check_map_change (player *pl)
183{ 172{
184 NewSocket & socket = pl->socket; 173 client_socket &socket = *pl->socket;
185 object *ob = pl->ob; 174 object *ob = pl->ob;
186 char buf[MAX_BUF]; /* eauugggh */ 175 char buf[MAX_BUF]; /* eauugggh */
187 176
188 if (socket.current_map != ob->map) 177 if (socket.current_map != ob->map)
189 { 178 {
210 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 199 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path);
211 } 200 }
212 else 201 else
213 snprintf (buf, MAX_BUF, "mapinfo current"); 202 snprintf (buf, MAX_BUF, "mapinfo current");
214 203
215 Write_String_To_Socket (&socket, buf, strlen (buf)); 204 socket.send_packet (buf);
216 } 205 }
217 } 206 }
218 else if (socket.current_x != ob->x || socket.current_y != ob->y) 207 else if (socket.current_x != ob->x || socket.current_y != ob->y)
219 { 208 {
220 int dx = ob->x - socket.current_x; 209 int dx = ob->x - socket.current_x;
260 buf += 8; 249 buf += 8;
261 250
262 // initial map and its origin 251 // initial map and its origin
263 maptile *map = pl->ob->map; 252 maptile *map = pl->ob->map;
264 sint16 dx, dy; 253 sint16 dx, dy;
265 int mapx = pl->socket.mapx / 2 - pl->ob->x; 254 int mapx = pl->socket->mapx / 2 - pl->ob->x;
266 int mapy = pl->socket.mapy / 2 - pl->ob->y; 255 int mapy = pl->socket->mapy / 2 - pl->ob->y;
267 int max_distance = 8; // limit maximum path length to something generous 256 int max_distance = 8; // limit maximum path length to something generous
268 257
269 while (*buf && map && max_distance) 258 while (*buf && map && max_distance)
270 { 259 {
271 int dir = *buf++; 260 int dir = *buf++;
322 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 311 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token);
323 } 312 }
324 else 313 else
325 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 314 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
326 315
327 Write_String_To_Socket (&pl->socket, bigbuf, strlen (bigbuf)); 316 pl->socket->send_packet (bigbuf);
328} 317}
329 318
330/** This is the Setup cmd - easy first implementation */ 319/** This is the Setup cmd - easy first implementation */
331void 320void
332SetUp (char *buf, int len, NewSocket * ns) 321SetUp (char *buf, int len, client_socket * ns)
333{ 322{
334 int s, slen; 323 int s, slen;
335 char *cmd, *param, cmdback[HUGE_BUF]; 324 char *cmd, *param, cmdback[HUGE_BUF];
336 325
337 /* run through the cmds of setup 326 /* run through the cmds of setup
339 * 328 *
340 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown 329 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
341 * The client then must sort this out 330 * The client then must sort this out
342 */ 331 */
343 332
344 LOG (llevInfo, "Get SetupCmd:: %s\n", buf); 333 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
334
345 strcpy (cmdback, "setup"); 335 strcpy (cmdback, "setup");
346 for (s = 0; s < len;) 336 for (s = 0; s < len; )
347 { 337 {
348
349 cmd = &buf[s]; 338 cmd = &buf[s];
350 339
351 /* find the next space, and put a null there */ 340 /* find the next space, and put a null there */
352 for (; buf[s] && buf[s] != ' '; s++); 341 for (; buf[s] && buf[s] != ' '; s++)
342 ;
343
353 buf[s++] = 0; 344 buf[s++] = 0;
345
354 while (buf[s] == ' ') 346 while (buf[s] == ' ')
355 s++; 347 s++;
356 348
357 if (s >= len) 349 if (s >= len)
358 break; 350 break;
359 351
360 param = &buf[s]; 352 param = &buf[s];
361 353
362 for (; buf[s] && buf[s] != ' '; s++); 354 for (; buf[s] && buf[s] != ' '; s++)
355 ;
356
363 buf[s++] = 0; 357 buf[s++] = 0;
358
364 while (buf[s] == ' ') 359 while (buf[s] == ' ')
365 s++; 360 s++;
366 361
367 slen = strlen (cmdback); 362 slen = strlen (cmdback);
368 safe_strcat (cmdback, " ", &slen, HUGE_BUF); 363 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
529 * report a failure to the client. 524 * report a failure to the client.
530 */ 525 */
531 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF); 526 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
532 } 527 }
533 } /* for processing all the setup commands */ 528 } /* for processing all the setup commands */
529
534 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback); 530 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
535 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 531 ns->send_packet (cmdback);
536} 532}
537 533
538/** 534/**
539 * The client has requested to be added to the game. 535 * The client has requested to be added to the game.
540 * This is what takes care of it. We tell the client how things worked out. 536 * This is what takes care of it. We tell the client how things worked out.
541 * I am not sure if this file is the best place for this function. however, 537 * I am not sure if this file is the best place for this function. however,
542 * it either has to be here or init_sockets needs to be exported. 538 * it either has to be here or init_sockets needs to be exported.
543 */ 539 */
544void 540void
545AddMeCmd (char *buf, int len, NewSocket * ns) 541AddMeCmd (char *buf, int len, client_socket * ns)
546{ 542{
547 Settings oldsettings; 543 Settings oldsettings;
548 544
549 oldsettings = settings; 545 oldsettings = settings;
550 if (ns->status != Ns_Add || add_player (ns)) 546 if (ns->status != Ns_Add || add_player (ns))
551 { 547 ns->send_packet ("addme_failed");
552 Write_String_To_Socket (ns, "addme_failed", 12);
553 }
554 else 548 else
555 { 549 ns->send_packet ("addme_success");
556 /* Basically, the add_player copies the socket structure into 550
557 * the player structure, so this one (which is from init_sockets)
558 * is not needed anymore. The write below should still work, as the
559 * stuff in ns is still relevant.
560 */
561 Write_String_To_Socket (ns, "addme_success", 13);
562 socket_info.nconns--;
563 ns->status = Ns_Avail;
564 }
565 settings = oldsettings; 551 settings = oldsettings;
566} 552}
567 553
568/** Reply to ExtendedInfos command */ 554/** Reply to ExtendedInfos command */
569void 555void
570ToggleExtendedInfos (char *buf, int len, NewSocket * ns) 556ToggleExtendedInfos (char *buf, int len, client_socket * ns)
571{ 557{
572 char cmdback[MAX_BUF]; 558 char cmdback[MAX_BUF];
573 char command[50]; 559 char command[50];
574 int info, nextinfo; 560 int info, nextinfo;
575 561
613 { 599 {
614 strcat (cmdback, " "); 600 strcat (cmdback, " ");
615 strcat (cmdback, "smoothing"); 601 strcat (cmdback, "smoothing");
616 } 602 }
617 603
618 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 604 ns->send_packet (cmdback);
619} 605}
620 606
621/* 607/*
622#define MSG_TYPE_BOOK 1 608#define MSG_TYPE_BOOK 1
623#define MSG_TYPE_CARD 2 609#define MSG_TYPE_CARD 2
626#define MSG_TYPE_MONUMENT 5 612#define MSG_TYPE_MONUMENT 5
627#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 613#define MSG_TYPE_SCRIPTED_DIALOG 6*/
628 614
629/** Reply to ExtendedInfos command */ 615/** Reply to ExtendedInfos command */
630void 616void
631ToggleExtendedText (char *buf, int len, NewSocket * ns) 617ToggleExtendedText (char *buf, int len, client_socket * ns)
632{ 618{
633 char cmdback[MAX_BUF]; 619 char cmdback[MAX_BUF];
634 char temp[10]; 620 char temp[10];
635 char command[50]; 621 char command[50];
636 int info, nextinfo, i, flag; 622 int info, nextinfo, i, flag;
676 strcat (cmdback, " "); 662 strcat (cmdback, " ");
677 snprintf (temp, sizeof (temp), "%d", i); 663 snprintf (temp, sizeof (temp), "%d", i);
678 strcat (cmdback, temp); 664 strcat (cmdback, temp);
679 } 665 }
680 666
681 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 667 ns->send_packet (cmdback);
682} 668}
683 669
684/** 670/**
685 * A lot like the old AskSmooth (in fact, now called by AskSmooth). 671 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
686 * Basically, it makes no sense to wait for the client to request a 672 * Basically, it makes no sense to wait for the client to request a
687 * a piece of data from us that we know the client wants. So 673 * a piece of data from us that we know the client wants. So
688 * if we know the client wants it, might as well push it to the 674 * if we know the client wants it, might as well push it to the
689 * client. 675 * client.
690 */ 676 */
691static void 677static void
692SendSmooth (NewSocket * ns, uint16 face) 678SendSmooth (client_socket * ns, uint16 face)
693{ 679{
694 uint16 smoothface; 680 uint16 smoothface;
695 unsigned char reply[MAX_BUF];
696 SockList sl;
697 681
698 /* If we can't find a face, return and set it so we won't try to send this 682 /* If we can't find a face, return and set it so we won't try to send this
699 * again. 683 * again.
700 */ 684 */
701 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface))) 685 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
709 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE)) 693 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
710 esrv_send_face (ns, smoothface, 0); 694 esrv_send_face (ns, smoothface, 0);
711 695
712 ns->faces_sent[face] |= NS_FACESENT_SMOOTH; 696 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
713 697
714 sl.buf = reply; 698 packet sl;
715 strcpy ((char *) sl.buf, "smooth "); 699
716 sl.len = strlen ((char *) sl.buf); 700 sl << "smooth "
717 SockList_AddShort (&sl, face); 701 << uint16 (face)
718 SockList_AddShort (&sl, smoothface); 702 << uint16 (smoothface);
703
719 Send_With_Handling (ns, &sl); 704 Send_With_Handling (ns, &sl);
720} 705}
721 706
722 /** 707 /**
723 * Tells client the picture it has to use 708 * Tells client the picture it has to use
724 * to smooth a picture number given as argument. 709 * to smooth a picture number given as argument.
725 */ 710 */
726void 711void
727AskSmooth (char *buf, int len, NewSocket * ns) 712AskSmooth (char *buf, int len, client_socket * ns)
728{ 713{
729 uint16 facenbr; 714 uint16 facenbr;
730 715
731 facenbr = atoi (buf); 716 facenbr = atoi (buf);
732 SendSmooth (ns, facenbr); 717 SendSmooth (ns, facenbr);
733} 718}
734
735
736
737
738 719
739/** 720/**
740 * This handles the general commands from the client (ie, north, fire, cast, 721 * This handles the general commands from the client (ie, north, fire, cast,
741 * etc.) 722 * etc.)
742 */ 723 */
796 */ 777 */
797void 778void
798NewPlayerCmd (uint8 * buf, int len, player *pl) 779NewPlayerCmd (uint8 * buf, int len, player *pl)
799{ 780{
800 int time, repeat; 781 int time, repeat;
801 short packet;
802 unsigned char command[MAX_BUF]; 782 char command[MAX_BUF];
803 SockList sl; 783 int pktlen;
804 784
805 if (len < 7) 785 if (len < 7)
806 { 786 {
807 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 787 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
808 return; 788 return;
809 } 789 }
810 790
811 packet = GetShort_String (buf); 791 pktlen = net_uint16 (buf);
812 repeat = GetInt_String (buf + 2); 792 repeat = net_uint32 (buf + 2);
793
813 /* -1 is special - no repeat, but don't update */ 794 /* -1 is special - no repeat, but don't update */
814 if (repeat != -1) 795 if (repeat != -1)
815 {
816 pl->count = repeat; 796 pl->count = repeat;
817 } 797
818 if ((len - 4) >= MAX_BUF) 798 if ((len - 4) >= MAX_BUF)
819 len = MAX_BUF - 5; 799 len = MAX_BUF - 5;
820 800
821 strncpy ((char *) command, (char *) buf + 6, len - 4); 801 strncpy ((char *) command, (char *) buf + 6, len - 4);
822 command[len - 4] = '\0'; 802 command[len - 4] = '\0';
832 return; 812 return;
833 } 813 }
834 814
835 /* This should not happen anymore. */ 815 /* This should not happen anymore. */
836 if (pl->ob->speed_left < -1.0) 816 if (pl->ob->speed_left < -1.0)
837 {
838 LOG (llevError, "Player has negative time - shouldn't do command.\n"); 817 LOG (llevError, "Player has negative time - shouldn't do command.\n");
839 } 818
840 /* In c_new.c */ 819 /* In c_new.c */
841 execute_newserver_command (pl->ob, (char *) command); 820 execute_newserver_command (pl->ob, (char *) command);
842 /* Perhaps something better should be done with a left over count. 821 /* Perhaps something better should be done with a left over count.
843 * Cleaning up the input should probably be done first - all actions 822 * Cleaning up the input should probably be done first - all actions
844 * for the command that issued the count should be done before any other 823 * for the command that issued the count should be done before any other
845 * commands. 824 * commands.
846 */ 825 */
847 pl->count = 0; 826 pl->count = 0;
848 827
849 /* Send confirmation of command execution now */
850 sl.buf = command;
851 strcpy ((char *) sl.buf, "comc ");
852 sl.len = 5;
853 SockList_AddShort (&sl, packet);
854 if (FABS (pl->ob->speed) < 0.001) 828 if (FABS (pl->ob->speed) < 0.001)
855 time = MAX_TIME * 100; 829 time = MAX_TIME * 100;
856 else 830 else
857 time = (int) (MAX_TIME / FABS (pl->ob->speed)); 831 time = (int) (MAX_TIME / FABS (pl->ob->speed));
858 SockList_AddInt (&sl, time); 832
833 /* Send confirmation of command execution now */
834
835 packet sl;
836 sl << "comc " << uint16 (pktlen) << uint32 (time);
859 Send_With_Handling (&pl->socket, &sl); 837 Send_With_Handling (pl->socket, &sl);
860} 838}
861 839
862 840
863/** This is a reply to a previous query. */ 841/** This is a reply to a previous query. */
864void 842void
931 * something older than the server. If we assume the client will be 909 * something older than the server. If we assume the client will be
932 * backwards compatible, having it be a later version should not be a 910 * backwards compatible, having it be a later version should not be a
933 * problem. 911 * problem.
934 */ 912 */
935void 913void
936VersionCmd (char *buf, int len, NewSocket * ns) 914VersionCmd (char *buf, int len, client_socket * ns)
937{ 915{
938 char *cp; 916 char *cp;
939 char version_warning[256]; 917 char version_warning[256];
940 918
941 if (!buf) 919 if (!buf)
976 /* these are old dxclients */ 954 /* these are old dxclients */
977 /* Version 1024 added support for singular + plural name values - 955 /* Version 1024 added support for singular + plural name values -
978 * requiing this minimal value reduces complexity of that code, and it 956 * requiing this minimal value reduces complexity of that code, and it
979 * has been around for a long time. 957 * has been around for a long time.
980 */ 958 */
981 if (!strcmp (" CF DX CLIENT", cp) || ns->sc_version < 1024) 959 if (ns->sc_version < 1026)
982 { 960 {
983 sprintf (version_warning, "drawinfo %d %s", NDI_RED, 961 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
984 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 962 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
985 Write_String_To_Socket (ns, version_warning, strlen (version_warning)); 963 ns->send_packet (version_warning);
986 } 964 }
987 965
988 } 966 }
989} 967}
990 968
991/** sound related functions. */ 969/** sound related functions. */
992 970
993void 971void
994SetSound (char *buf, int len, NewSocket * ns) 972SetSound (char *buf, int len, client_socket * ns)
995{ 973{
996 ns->sound = atoi (buf); 974 ns->sound = atoi (buf);
997} 975}
998 976
999/** client wants the map resent */ 977/** client wants the map resent */
1009 */ 987 */
1010#if 0 988#if 0
1011 /* Okay, this is MAJOR UGLY. but the only way I know how to 989 /* Okay, this is MAJOR UGLY. but the only way I know how to
1012 * clear the "cache" 990 * clear the "cache"
1013 */ 991 */
1014 memset (&pl->socket.lastmap, 0, sizeof (struct Map)); 992 memset (&pl->socket->lastmap, 0, sizeof (struct Map));
1015 draw_client_map (pl->ob); 993 draw_client_map (pl->ob);
1016#endif 994#endif
1017} 995}
1018 996
1019/** 997/**
1057/** 1035/**
1058 * Asks the client to query the user. This way, the client knows 1036 * Asks the client to query the user. This way, the client knows
1059 * it needs to send something back (vs just printing out a message) 1037 * it needs to send something back (vs just printing out a message)
1060 */ 1038 */
1061void 1039void
1062send_query (NewSocket * ns, uint8 flags, char *text) 1040send_query (client_socket * ns, uint8 flags, char *text)
1063{ 1041{
1064 char buf[MAX_BUF]; 1042 char buf[MAX_BUF];
1065 1043
1066 sprintf (buf, "query %d %s", flags, text ? text : ""); 1044 sprintf (buf, "query %d %s", flags, text ? text : "");
1067 Write_String_To_Socket (ns, buf, strlen (buf)); 1045 ns->send_packet (buf);
1068} 1046}
1069 1047
1070#define AddIfInt64(Old,New,Type) if (Old != New) {\ 1048#define AddIfInt64(Old,New,Type) if (Old != New) {\
1071 Old = New; \ 1049 Old = New; \
1072 SockList_AddChar(&sl, Type); \ 1050 sl << uint8 (Type) << uint64 (New); \
1073 SockList_AddInt64(&sl, New); \
1074 } 1051 }
1075 1052
1076#define AddIfInt(Old,New,Type) if (Old != New) {\ 1053#define AddIfInt(Old,New,Type) if (Old != New) {\
1077 Old = New; \ 1054 Old = New; \
1078 SockList_AddChar(&sl, Type); \ 1055 sl << uint8 (Type) << uint32 (New); \
1079 SockList_AddInt(&sl, New); \
1080 } 1056 }
1081 1057
1082#define AddIfShort(Old,New,Type) if (Old != New) {\ 1058#define AddIfShort(Old,New,Type) if (Old != New) {\
1083 Old = New; \ 1059 Old = New; \
1084 SockList_AddChar(&sl, Type); \ 1060 sl << uint8 (Type) << uint16 (New); \
1085 SockList_AddShort(&sl, New); \
1086 } 1061 }
1087 1062
1088#define AddIfFloat(Old,New,Type) if (Old != New) {\ 1063#define AddIfFloat(Old,New,Type) if (Old != New) {\
1089 Old = New; \ 1064 Old = New; \
1090 SockList_AddChar(&sl, Type); \ 1065 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \
1091 SockList_AddInt(&sl,(long)(New*FLOAT_MULTI));\
1092 } 1066 }
1093 1067
1094#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 1068#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
1095 if (Old) free(Old);\
1096 Old = strdup_local(New);\ 1069 free(Old); Old = strdup (New);\
1097 SockList_AddChar(&sl, Type); \ 1070 sl << uint8 (Type) << data8 (New); \
1098 SockList_AddChar(&sl, ( char )strlen(New)); \
1099 strcpy((char*)sl.buf + sl.len, New); \
1100 sl.len += strlen(New); \
1101 } 1071 }
1102 1072
1103/** 1073/**
1104 * Sends a statistics update. We look at the old values, 1074 * Sends a statistics update. We look at the old values,
1105 * and only send what has changed. Stat mapping values are in newclient.h 1075 * and only send what has changed. Stat mapping values are in newclient.h
1107 * commands for now. 1077 * commands for now.
1108 */ 1078 */
1109void 1079void
1110esrv_update_stats (player *pl) 1080esrv_update_stats (player *pl)
1111{ 1081{
1112 SockList sl;
1113 char buf[MAX_BUF]; 1082 char buf[MAX_BUF];
1114 uint16 flags; 1083 uint16 flags;
1115 1084
1116 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1085 packet sl;
1117 strcpy ((char *) sl.buf, "stats "); 1086 sl << "stats ";
1118 sl.len = strlen ((char *) sl.buf);
1119 1087
1120 if (pl->ob != NULL) 1088 if (pl->ob != NULL)
1121 { 1089 {
1122 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 1090 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP);
1123 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 1091 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP);
1131 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS); 1099 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1132 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 1100 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX);
1133 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 1101 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON);
1134 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 1102 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA);
1135 } 1103 }
1104
1136 if (pl->socket.exp64) 1105 if (pl->socket->exp64)
1137 { 1106 {
1138 uint8 s; 1107 uint8 s;
1139 1108
1140 for (s = 0; s < NUM_SKILLS; s++) 1109 for (s = 0; s < NUM_SKILLS; s++)
1141 { 1110 {
1142 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 1111 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp)
1143 { 1112 {
1144
1145 /* Always send along the level if exp changes. This is only 1113 /* Always send along the level if exp changes. This is only
1146 * 1 extra byte, but keeps processing simpler. 1114 * 1 extra byte, but keeps processing simpler.
1147 */ 1115 */
1148 SockList_AddChar (&sl, (char) (s + CS_STAT_SKILLINFO)); 1116 sl << uint8 (s + CS_STAT_SKILLINFO)
1149 SockList_AddChar (&sl, (char) pl->last_skill_ob[s]->level); 1117 << uint8 (pl->last_skill_ob[s]->level)
1150 SockList_AddInt64 (&sl, pl->last_skill_ob[s]->stats.exp); 1118 << uint64 (pl->last_skill_ob[s]->stats.exp);
1119
1151 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp; 1120 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1152 } 1121 }
1153 } 1122 }
1154 } 1123 }
1124
1155 if (pl->socket.exp64) 1125 if (pl->socket->exp64)
1156 {
1157 AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64); 1126 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) }
1158 }
1159 else 1127 else
1160 {
1161 AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP); 1128 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1162 } 1129
1163 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 1130 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL);
1164 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 1131 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC);
1165 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 1132 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC);
1166 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 1133 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM);
1167 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 1134 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED);
1168 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 1135 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD);
1169 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 1136 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1170 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 1137 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM);
1171 flags = 0; 1138 flags = 0;
1139
1172 if (pl->fire_on) 1140 if (pl->fire_on)
1173 flags |= SF_FIREON; 1141 flags |= SF_FIREON;
1142
1174 if (pl->run_on) 1143 if (pl->run_on)
1175 flags |= SF_RUNON; 1144 flags |= SF_RUNON;
1176 1145
1177 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 1146 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS);
1147
1178 if (pl->socket.sc_version < 1025) 1148 if (pl->socket->sc_version < 1025)
1179 {
1180 AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR); 1149 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1181 }
1182 else 1150 else
1183 { 1151 {
1184 int i; 1152 int i;
1185 1153
1186 for (i = 0; i < NROFATTACKS; i++) 1154 for (i = 0; i < NROFATTACKS; i++)
1187 { 1155 {
1188 /* Skip ones we won't send */ 1156 /* Skip ones we won't send */
1189 if (atnr_cs_stat[i] == -1) 1157 if (atnr_cs_stat[i] == -1)
1190 continue; 1158 continue;
1159
1191 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 1160 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]);
1192 } 1161 }
1193 } 1162 }
1163
1194 if (pl->socket.monitor_spells) 1164 if (pl->socket->monitor_spells)
1195 { 1165 {
1196 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 1166 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1197 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 1167 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL);
1198 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 1168 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY);
1199 } 1169 }
1170
1200 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 1171 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */
1201 AddIfString (pl->socket.stats.range, buf, CS_STAT_RANGE); 1172 AddIfString (pl->socket->stats.range, buf, CS_STAT_RANGE);
1202 set_title (pl->ob, buf); 1173 set_title (pl->ob, buf);
1203 AddIfString (pl->socket.stats.title, buf, CS_STAT_TITLE); 1174 AddIfString (pl->socket->stats.title, buf, CS_STAT_TITLE);
1204 1175
1205 /* Only send it away if we have some actual data */ 1176 /* Only send it away if we have some actual data */
1206 if (sl.len > 6) 1177 if (sl.length () > 6)
1207 {
1208#ifdef ESRV_DEBUG
1209 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1210#endif
1211 Send_With_Handling (&pl->socket, &sl); 1178 Send_With_Handling (pl->socket, &sl);
1212 }
1213 free (sl.buf);
1214} 1179}
1215
1216 1180
1217/** 1181/**
1218 * Tells the client that here is a player it should start using. 1182 * Tells the client that here is a player it should start using.
1219 */ 1183 */
1220void 1184void
1221esrv_new_player (player *pl, uint32 weight) 1185esrv_new_player (player *pl, uint32 weight)
1222{ 1186{
1223 SockList sl;
1224
1225 pl->last_weight = weight; 1187 pl->last_weight = weight;
1226 1188
1227 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1189 packet sl;
1190 sl << "player ";
1228 1191
1229 strcpy ((char *) sl.buf, "player "); 1192 sl << uint32 (pl->ob->count)
1230 sl.len = strlen ((char *) sl.buf); 1193 << uint32 (weight)
1231 SockList_AddInt (&sl, pl->ob->count); 1194 << uint32 (pl->ob->face->number)
1232 SockList_AddInt (&sl, weight); 1195 << data8 (pl->ob->name);
1233 SockList_AddInt (&sl, pl->ob->face->number);
1234 1196
1235 SockList_AddChar (&sl, (char) strlen (pl->ob->name));
1236 strcpy ((char *) sl.buf + sl.len, pl->ob->name);
1237 sl.len += strlen (pl->ob->name);
1238
1239 Send_With_Handling (&pl->socket, &sl); 1197 Send_With_Handling (pl->socket, &sl);
1240 free (sl.buf);
1241 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1198 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1242} 1199}
1243
1244 1200
1245/** 1201/**
1246 * Need to send an animation sequence to the client. 1202 * Need to send an animation sequence to the client.
1247 * We will send appropriate face commands to the client if we haven't 1203 * We will send appropriate face commands to the client if we haven't
1248 * sent them the face yet (this can become quite costly in terms of 1204 * sent them the face yet (this can become quite costly in terms of
1249 * how much we are sending - on the other hand, this should only happen 1205 * how much we are sending - on the other hand, this should only happen
1250 * when the player logs in and picks stuff up. 1206 * when the player logs in and picks stuff up.
1251 */ 1207 */
1252void 1208void
1253esrv_send_animation (NewSocket * ns, short anim_num) 1209esrv_send_animation (client_socket * ns, short anim_num)
1254{ 1210{
1255 SockList sl;
1256 int i; 1211 int i;
1257 1212
1258 /* Do some checking on the anim_num we got. Note that the animations 1213 /* Do some checking on the anim_num we got. Note that the animations
1259 * are added in contigous order, so if the number is in the valid 1214 * are added in contigous order, so if the number is in the valid
1260 * range, it must be a valid animation. 1215 * range, it must be a valid animation.
1263 { 1218 {
1264 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num); 1219 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1265 return; 1220 return;
1266 } 1221 }
1267 1222
1268 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1223 packet sl;
1269 strcpy ((char *) sl.buf, "anim "); 1224
1270 sl.len = 5; 1225 sl << "anim "
1271 SockList_AddShort (&sl, anim_num); 1226 << uint16 (anim_num)
1272 SockList_AddShort (&sl, 0); /* flags - not used right now */ 1227 << uint16 (0); /* flags - not used right now */
1228
1273 /* Build up the list of faces. Also, send any information (ie, the 1229 /* Build up the list of faces. Also, send any information (ie, the
1274 * the face itself) down to the client. 1230 * the face itself) down to the client.
1275 */ 1231 */
1276 for (i = 0; i < animations[anim_num].num_animations; i++) 1232 for (i = 0; i < animations[anim_num].num_animations; i++)
1277 { 1233 {
1278 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE)) 1234 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1279 esrv_send_face (ns, animations[anim_num].faces[i], 0); 1235 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1280 SockList_AddShort (&sl, animations[anim_num].faces[i]); /* flags - not used right now */ 1236 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1281 } 1237 }
1238
1282 Send_With_Handling (ns, &sl); 1239 Send_With_Handling (ns, &sl);
1283 free (sl.buf); 1240
1284 ns->anims_sent[anim_num] = 1; 1241 ns->anims_sent[anim_num] = 1;
1285} 1242}
1286 1243
1287 1244
1288/****************************************************************************** 1245/******************************************************************************
1294/** 1251/**
1295 * This adds face_num to a map cell at x,y. If the client doesn't have 1252 * This adds face_num to a map cell at x,y. If the client doesn't have
1296 * the face yet, we will also send it. 1253 * the face yet, we will also send it.
1297 */ 1254 */
1298static void 1255static void
1299esrv_map_setbelow (NewSocket * ns, int x, int y, short face_num, struct Map *newmap) 1256esrv_map_setbelow (client_socket * ns, int x, int y, short face_num, struct Map *newmap)
1300{ 1257{
1301 if (newmap->cells[x][y].count >= MAP_LAYERS) 1258 if (newmap->cells[x][y].count >= MAP_LAYERS)
1302 { 1259 {
1303 LOG (llevError, "Too many faces in map cell %d %d\n", x, y); 1260 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1304 return; 1261 return;
1305 abort (); 1262 abort ();
1306 } 1263 }
1264
1307 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num; 1265 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1308 newmap->cells[x][y].count++; 1266 newmap->cells[x][y].count++;
1267
1309 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1268 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1310 esrv_send_face (ns, face_num, 0); 1269 esrv_send_face (ns, face_num, 0);
1311} 1270}
1312 1271
1313struct LayerCell 1272struct LayerCell
1322 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y]; 1281 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1323}; 1282};
1324 1283
1325/** Checkes if map cells have changed */ 1284/** Checkes if map cells have changed */
1326static int 1285static int
1327mapcellchanged (NewSocket * ns, int i, int j, struct Map *newmap) 1286mapcellchanged (client_socket * ns, int i, int j, struct Map *newmap)
1328{ 1287{
1329 int k; 1288 int k;
1330 1289
1331 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count) 1290 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1332 return 1; 1291 return 1;
1345 * cnum is the client number, cur is the the buffer we put all of 1304 * cnum is the client number, cur is the the buffer we put all of
1346 * this data into. we return the end of the data. layers is 1305 * this data into. we return the end of the data. layers is
1347 * how many layers of data we should back. 1306 * how many layers of data we should back.
1348 */ 1307 */
1349static uint8 * 1308static uint8 *
1350compactlayer (NewSocket * ns, unsigned char *cur, int numlayers, struct Map *newmap) 1309compactlayer (client_socket * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1351{ 1310{
1352 int x, y, k; 1311 int x, y, k;
1353 int face; 1312 int face;
1354 unsigned char *fcur; 1313 unsigned char *fcur;
1355 struct MapLayer layers[MAP_LAYERS]; 1314 struct MapLayer layers[MAP_LAYERS];
1415 *fcur = *fcur | 128; /* mark for end of faces at this layer */ 1374 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1416 } 1375 }
1417 return cur; 1376 return cur;
1418} 1377}
1419 1378
1420static void
1421esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1422{
1423 static long frames, bytes, tbytes, tframes;
1424 char *cur;
1425 SockList sl;
1426
1427
1428 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1429 strcpy ((char *) sl.buf, "map ");
1430 sl.len = strlen ((char *) sl.buf);
1431
1432 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1433 sl.len = cur - (char *) sl.buf;
1434
1435/* LOG(llevDebug, "Sending map command.\n");*/
1436
1437 if (sl.len > (int) strlen ("map ") || ns->sent_scroll)
1438 {
1439 /* All of this is just accounting stuff */
1440 if (tframes > 100)
1441 tframes = tbytes = 0;
1442
1443 tframes++;
1444 frames++;
1445 tbytes += sl.len;
1446 bytes += sl.len;
1447 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1448 Send_With_Handling (ns, &sl);
1449 ns->sent_scroll = 0;
1450 }
1451
1452 free (sl.buf);
1453}
1454
1455
1456/** Clears a map cell */ 1379/** Clears a map cell */
1457static void 1380static void
1458map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 1381map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count)
1459{ 1382{
1460 cell->faces[0] = face0; 1383 cell->faces[0] = face0;
1461 cell->faces[1] = face1; 1384 cell->faces[1] = face1;
1462 cell->faces[2] = face2; 1385 cell->faces[2] = face2;
1463 cell->count = count; 1386 cell->count = count;
1464 cell->stat_hp = 0; 1387 cell->stat_hp = 0;
1388 cell->flags = 0;
1465 cell->player = 0; 1389 cell->player = 0;
1466} 1390}
1467 1391
1468#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y) 1392#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1469#define MAX_LAYERS 3 1393#define MAX_LAYERS 3
1470 1394
1498 * needs to get sent - if so, it adds the data, sending the head 1422 * needs to get sent - if so, it adds the data, sending the head
1499 * if needed, and returning 1. If this no data needs to get 1423 * if needed, and returning 1. If this no data needs to get
1500 * sent, it returns zero. 1424 * sent, it returns zero.
1501 */ 1425 */
1502static int 1426static int
1503check_head (SockList & sl, NewSocket & ns, int ax, int ay, int layer) 1427check_head (packet &sl, client_socket &ns, int ax, int ay, int layer)
1504{ 1428{
1505 short face_num; 1429 short face_num;
1506 1430
1507 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]) 1431 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1508 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number; 1432 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1509 else 1433 else
1510 face_num = 0; 1434 face_num = 0;
1511 1435
1512 if (face_num != ns.lastmap.cells[ax][ay].faces[layer]) 1436 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1513 { 1437 {
1514 SockList_AddShort (&sl, face_num); 1438 sl << uint16 (face_num);
1515 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1439 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1516 esrv_send_face (&ns, face_num, 0); 1440 esrv_send_face (&ns, face_num, 0);
1441
1517 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL; 1442 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1518 ns.lastmap.cells[ax][ay].faces[layer] = face_num; 1443 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1519 return 1; 1444 return 1;
1520 } 1445 }
1521 1446
1541 * the case, it seems to make more sense to have these layer values 1466 * the case, it seems to make more sense to have these layer values
1542 * actually match. 1467 * actually match.
1543 */ 1468 */
1544 1469
1545static int 1470static int
1546update_space (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1471update_space (packet &sl, client_socket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1547{ 1472{
1548 object *ob, *head; 1473 object *ob, *head;
1549 uint16 face_num; 1474 uint16 face_num;
1550 int bx, by, i; 1475 int bx, by, i;
1551 1476
1552 /* If there is a multipart object stored away, treat that as more important. 1477 /* If there is a multipart object stored away, treat that as more important.
1553 * If not, then do the normal processing. 1478 * If not, then do the normal processing.
1554 */ 1479 */
1555
1556 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer]; 1480 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1557 1481
1558 /* Check to see if this head is part of the set of objects 1482 /* Check to see if this head is part of the set of objects
1559 * we would normally send for this space. If so, then 1483 * we would normally send for this space. If so, then
1560 * don't use the head value. We need to do the check 1484 * don't use the head value. We need to do the check
1725 1649
1726 /* Another hack - because of heads and whatnot, this face may match one 1650 /* Another hack - because of heads and whatnot, this face may match one
1727 * we already sent for a lower layer. In that case, don't send 1651 * we already sent for a lower layer. In that case, don't send
1728 * this one. 1652 * this one.
1729 */ 1653 */
1730 if (face_num && layer + 1 < MAP_LAYERS && ns->lastmap.cells[sx][sy].faces[layer + 1] == face_num) 1654 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1731 {
1732 face_num = 0; 1655 face_num = 0;
1733 }
1734 1656
1735 /* We've gotten what face we want to use for the object. Now see if 1657 /* We've gotten what face we want to use for the object. Now see if
1736 * if it has changed since we last sent it to the client. 1658 * if it has changed since we last sent it to the client.
1737 */ 1659 */
1738 if (ns->lastmap.cells[sx][sy].faces[layer] != face_num) 1660 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num)
1739 { 1661 {
1740 ns->lastmap.cells[sx][sy].faces[layer] = face_num; 1662 ns.lastmap.cells[sx][sy].faces[layer] = face_num;
1741 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE)) 1663 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1742 esrv_send_face (ns, face_num, 0); 1664 esrv_send_face (&ns, face_num, 0);
1743 SockList_AddShort (sl, face_num); 1665
1666 sl << uint16 (face_num);
1744 return 1; 1667 return 1;
1745 } 1668 }
1669
1746 /* Nothing changed */ 1670 /* Nothing changed */
1747 return 0; 1671 return 0;
1748} 1672}
1749 1673
1750/** 1674/**
1765 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ 1689 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1766 * take. 1690 * take.
1767 */ 1691 */
1768 1692
1769static inline int 1693static inline int
1770update_smooth (SockList * sl, NewSocket * ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1694update_smooth (packet &sl, client_socket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1771{ 1695{
1772 object *ob; 1696 object *ob;
1773 int smoothlevel; /* old face_num; */ 1697 int smoothlevel; /* old face_num; */
1774 1698
1775 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer); 1699 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1780 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp)) 1704 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1781 smoothlevel = 0; 1705 smoothlevel = 0;
1782 else 1706 else
1783 { 1707 {
1784 smoothlevel = ob->smoothlevel; 1708 smoothlevel = ob->smoothlevel;
1785 if (smoothlevel && !(ns->faces_sent[ob->face->number] & NS_FACESENT_SMOOTH)) 1709 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1786 SendSmooth (ns, ob->face->number); 1710 SendSmooth (&ns, ob->face->number);
1787 } /* else not already head object or blank face */ 1711 } /* else not already head object or blank face */
1788 1712
1789 /* We've gotten what face we want to use for the object. Now see if 1713 /* We've gotten what face we want to use for the object. Now see if
1790 * if it has changed since we last sent it to the client. 1714 * if it has changed since we last sent it to the client.
1791 */ 1715 */
1792 if (smoothlevel > 255) 1716 if (smoothlevel > 255)
1793 smoothlevel = 255; 1717 smoothlevel = 255;
1794 else if (smoothlevel < 0) 1718 else if (smoothlevel < 0)
1795 smoothlevel = 0; 1719 smoothlevel = 0;
1720
1796 if (ns->lastmap.cells[sx][sy].smooth[layer] != smoothlevel) 1721 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1797 { 1722 {
1798 ns->lastmap.cells[sx][sy].smooth[layer] = smoothlevel; 1723 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1799 SockList_AddChar (sl, (uint8) (smoothlevel & 0xFF)); 1724 sl << uint8 (smoothlevel);
1800 return 1; 1725 return 1;
1801 } 1726 }
1727
1802 /* Nothing changed */ 1728 /* Nothing changed */
1803 return 0; 1729 return 0;
1804} 1730}
1805 1731
1806/** 1732/**
1807 * Returns the size of a data for a map square as returned by 1733 * Returns the size of a data for a map square as returned by
1808 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries 1734 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1809 * available. 1735 * available.
1810 */ 1736 */
1811int 1737int
1812getExtendedMapInfoSize (NewSocket * ns) 1738getExtendedMapInfoSize (client_socket * ns)
1813{ 1739{
1814 int result = 0; 1740 int result = 0;
1815 1741
1816 if (ns->ext_mapinfos) 1742 if (ns->ext_mapinfos)
1817 { 1743 {
1847draw_client_map1 (object *pl) 1773draw_client_map1 (object *pl)
1848{ 1774{
1849 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1775 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen;
1850 sint16 nx, ny; 1776 sint16 nx, ny;
1851 int estartlen, eoldlen; 1777 int estartlen, eoldlen;
1852 SockList sl;
1853 SockList esl; /*For extended Map info */
1854 uint16 mask, emask; 1778 uint16 mask, emask;
1855 uint8 eentrysize; 1779 uint8 eentrysize;
1856 uint16 ewhatstart, ewhatflag; 1780 uint16 ewhatstart, ewhatflag;
1857 uint8 extendedinfos; 1781 uint8 extendedinfos;
1858 maptile *m; 1782 maptile *m;
1859 1783
1860 NewSocket & socket = pl->contr->socket; 1784 client_socket &socket = *pl->contr->socket;
1861 1785
1862 check_map_change (pl->contr); 1786 check_map_change (pl->contr);
1863 1787
1864 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 1788 packet sl;
1865 if (socket.mapmode == Map1Cmd) 1789 packet esl;
1866 strcpy ((char *) sl.buf, "map1 "); 1790
1867 else 1791 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a ");
1868 strcpy ((char *) sl.buf, "map1a ");
1869 sl.len = strlen ((char *) sl.buf);
1870 startlen = sl.len; 1792 startlen = sl.length ();
1793
1871 /*Extendedmapinfo structure initialisation */ 1794 /*Extendedmapinfo structure initialisation */
1872 if (socket.ext_mapinfos) 1795 if (socket.ext_mapinfos)
1873 { 1796 {
1874 esl.buf = (unsigned char *) malloc (MAXSOCKBUF);
1875 strcpy ((char *) esl.buf, "mapextended ");
1876 esl.len = strlen ((char *) esl.buf);
1877 extendedinfos = EMI_NOREDRAW; 1797 extendedinfos = EMI_NOREDRAW;
1798
1878 if (socket.EMI_smooth) 1799 if (socket.EMI_smooth)
1879 extendedinfos |= EMI_SMOOTH; 1800 extendedinfos |= EMI_SMOOTH;
1801
1880 ewhatstart = esl.len; 1802 ewhatstart = esl.length ();
1881 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 1803 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1882 could need to be taken away */ 1804 could need to be taken away */
1883 SockList_AddChar (&esl, extendedinfos);
1884 eentrysize = getExtendedMapInfoSize (&socket); 1805 eentrysize = getExtendedMapInfoSize (&socket);
1885 SockList_AddChar (&esl, eentrysize); 1806 esl << "mapextended "
1807 << uint8 (extendedinfos)
1808 << uint8 (eentrysize);
1809
1886 estartlen = esl.len; 1810 estartlen = esl.length ();
1887 } 1811 }
1888 else 1812 else
1889 { 1813 {
1890 /* suppress compiler warnings */ 1814 /* suppress compiler warnings */
1891 ewhatstart = 0; 1815 ewhatstart = 0;
1892 ewhatflag = 0; 1816 ewhatflag = 0;
1893 estartlen = 0; 1817 estartlen = 0;
1894 } 1818 }
1819
1895 /* Init data to zero */ 1820 /* Init data to zero */
1896 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS); 1821 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1897 1822
1898 /* x,y are the real map locations. ax, ay are viewport relative 1823 /* x,y are the real map locations. ax, ay are viewport relative
1899 * locations. 1824 * locations.
1903 /* We could do this logic as conditionals in the if statement, 1828 /* We could do this logic as conditionals in the if statement,
1904 * but that started to get a bit messy to look at. 1829 * but that started to get a bit messy to look at.
1905 */ 1830 */
1906 max_x = pl->x + (socket.mapx + 1) / 2; 1831 max_x = pl->x + (socket.mapx + 1) / 2;
1907 max_y = pl->y + (socket.mapy + 1) / 2; 1832 max_y = pl->y + (socket.mapy + 1) / 2;
1833
1908 if (socket.mapmode == Map1aCmd) 1834 if (socket.mapmode == Map1aCmd)
1909 { 1835 {
1910 max_x += MAX_HEAD_OFFSET; 1836 max_x += MAX_HEAD_OFFSET;
1911 max_y += MAX_HEAD_OFFSET; 1837 max_y += MAX_HEAD_OFFSET;
1912 } 1838 }
1927 */ 1853 */
1928 if (ax >= socket.mapx || ay >= socket.mapy) 1854 if (ax >= socket.mapx || ay >= socket.mapy)
1929 { 1855 {
1930 int i, got_one; 1856 int i, got_one;
1931 1857
1932 oldlen = sl.len; 1858 oldlen = sl.length ();
1933 1859
1934 SockList_AddShort (&sl, mask); 1860 sl << uint16 (mask);
1935 1861
1936 if (check_head (sl, socket, ax, ay, 2)) 1862 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1937 mask |= 0x4;
1938 if (check_head (sl, socket, ax, ay, 1)) 1863 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1939 mask |= 0x2;
1940 if (check_head (sl, socket, ax, ay, 0)) 1864 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1941 mask |= 0x1;
1942 1865
1943 /* If all we are doing is sending 0 (blank) faces, we don't 1866 /* If all we are doing is sending 0 (blank) faces, we don't
1944 * actually need to send that - just the coordinates 1867 * actually need to send that - just the coordinates
1945 * with no faces tells the client to blank out the 1868 * with no faces tells the client to blank out the
1946 * space. 1869 * space.
1947 */ 1870 */
1948 got_one = 0; 1871 got_one = 0;
1949 for (i = oldlen + 2; i < sl.len; i++) 1872 for (i = oldlen + 2; i < sl.length (); i++)
1950 {
1951 if (sl.buf[i]) 1873 if (sl.buf[i])
1952 got_one = 1; 1874 got_one = 1;
1953 }
1954 1875
1955 if (got_one && (mask & 0xf)) 1876 if (got_one && (mask & 0xf))
1956 {
1957 sl.buf[oldlen + 1] = mask & 0xff; 1877 sl.buf[oldlen + 1] = mask & 0xff;
1958 }
1959 else 1878 else
1960 { /*either all faces blank, either no face at all */ 1879 { /*either all faces blank, either no face at all */
1961 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */ 1880 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1962 sl.len = oldlen + 2; 1881 sl.reset (oldlen + 2);
1963 else 1882 else
1964 sl.len = oldlen; 1883 sl.reset (oldlen);
1965 } 1884 }
1885
1966 /*What concerns extendinfos, nothing to be done for now 1886 /*What concerns extendinfos, nothing to be done for now
1967 * (perhaps effects layer later) 1887 * (perhaps effects layer later)
1968 */ 1888 */
1969 continue; /* don't do processing below */ 1889 continue; /* don't do processing below */
1970 } 1890 }
1971 1891
1972 MapCell & lastcell = socket.lastmap.cells[ax][ay]; 1892 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1973 1893
1974 d = pl->contr->blocked_los[ax][ay]; 1894 d = pl->contr->blocked_los[ax][ay];
1975 1895
1976 /* If the coordinates are not valid, or it is too dark to see, 1896 /* If the coordinates are not valid, or it is too dark to see,
1977 * we tell the client as such 1897 * we tell the client as such
1978 */ 1898 */
1979 nx = x; 1899 nx = x;
1980 ny = y; 1900 ny = y;
1981 m = get_map_from_coord (pl->map, &nx, &ny); 1901 m = get_map_from_coord (pl->map, &nx, &ny);
1902
1982 if (!m) 1903 if (!m)
1983 { 1904 {
1984 /* space is out of map. Update space and clear values 1905 /* space is out of map. Update space and clear values
1985 * if this hasn't already been done. If the space is out 1906 * if this hasn't already been done. If the space is out
1986 * of the map, it shouldn't have a head 1907 * of the map, it shouldn't have a head
1987 */ 1908 */
1988 if (lastcell.count != -1) 1909 if (lastcell.count != -1)
1989 { 1910 {
1990 SockList_AddShort (&sl, mask); 1911 sl << uint16 (mask);
1991 map_clearcell (&lastcell, 0, 0, 0, -1); 1912 map_clearcell (&lastcell, 0, 0, 0, -1);
1992 } 1913 }
1993 } 1914 }
1994 else if (d > 3) 1915 else if (d > 3)
1995 { 1916 {
1997 1918
1998 /* This block deals with spaces that are not visible for whatever 1919 /* This block deals with spaces that are not visible for whatever
1999 * reason. Still may need to send the head for this space. 1920 * reason. Still may need to send the head for this space.
2000 */ 1921 */
2001 1922
2002 oldlen = sl.len; 1923 oldlen = sl.length ();
2003 1924
2004 SockList_AddShort (&sl, mask); 1925 sl << uint16 (mask);
1926
2005 if (lastcell.count != -1) 1927 if (lastcell.count != -1)
2006 need_send = 1; 1928 need_send = 1;
1929
2007 count = -1; 1930 count = -1;
2008 1931
2009 if (socket.mapmode == Map1aCmd && have_head (ax, ay)) 1932 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
2010 { 1933 {
2011 /* Now check to see if any heads need to be sent */ 1934 /* Now check to see if any heads need to be sent */
2012 1935
2013 if (check_head (sl, socket, ax, ay, 2)) 1936 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
2014 mask |= 0x4;
2015 if (check_head (sl, socket, ax, ay, 1)) 1937 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
2016 mask |= 0x2;
2017 if (check_head (sl, socket, ax, ay, 0)) 1938 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
2018 mask |= 0x1;
2019 1939
2020 lastcell.count = count; 1940 lastcell.count = count;
2021
2022 } 1941 }
2023 else 1942 else
2024 { 1943 {
2025 struct MapCell *cell = &lastcell;
2026
2027 /* properly clear a previously sent big face */ 1944 /* properly clear a previously sent big face */
2028 if (cell->faces[0] != 0 || cell->faces[1] != 0 || cell->faces[2] != 0) 1945 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0
1946 || lastcell.stat_hp || lastcell.flags || lastcell.player)
2029 need_send = 1; 1947 need_send = 1;
1948
2030 map_clearcell (&lastcell, 0, 0, 0, count); 1949 map_clearcell (&lastcell, 0, 0, 0, count);
2031 } 1950 }
2032 1951
2033 if ((mask & 0xf) || need_send) 1952 if ((mask & 0xf) || need_send)
2034 {
2035 sl.buf[oldlen + 1] = mask & 0xff; 1953 sl.buf[oldlen + 1] = mask & 0xff;
2036 }
2037 else 1954 else
2038 {
2039 sl.len = oldlen; 1955 sl.reset (oldlen);
2040 }
2041 } 1956 }
2042 else 1957 else
2043 { 1958 {
2044 /* In this block, the space is visible or there are head objects 1959 /* In this block, the space is visible or there are head objects
2045 * we need to send. 1960 * we need to send.
2047 1962
2048 /* Rather than try to figure out what everything that we might 1963 /* Rather than try to figure out what everything that we might
2049 * need to send is, then form the packet after that, 1964 * need to send is, then form the packet after that,
2050 * we presume that we will in fact form a packet, and update 1965 * we presume that we will in fact form a packet, and update
2051 * the bits by what we do actually send. If we send nothing, 1966 * the bits by what we do actually send. If we send nothing,
2052 * we just back out sl.len to the old value, and no harm 1967 * we just back out sl.length () to the old value, and no harm
2053 * is done. 1968 * is done.
2054 * I think this is simpler than doing a bunch of checks to see 1969 * I think this is simpler than doing a bunch of checks to see
2055 * what if anything we need to send, setting the bits, then 1970 * what if anything we need to send, setting the bits, then
2056 * doing those checks again to add the real data. 1971 * doing those checks again to add the real data.
2057 */ 1972 */
2058 oldlen = sl.len; 1973 oldlen = sl.length ();
2059 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1974 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2060 eoldlen = esl.len; 1975 eoldlen = esl.length ();
2061 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1976 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2062 SockList_AddShort (&sl, mask); 1977 sl << uint16 (mask);
2063 1978
2064 if (socket.ext_mapinfos) 1979 if (socket.ext_mapinfos)
2065 SockList_AddShort (&esl, emask); 1980 esl << uint16 (emask);
2066 1981
2067 unsigned char dummy; 1982 unsigned char dummy;
2068 unsigned char *last_ext = &dummy; 1983 unsigned char *last_ext = &dummy;
2069 1984
2070 /* Darkness changed */ 1985 /* Darkness changed */
2073 mask |= 0x8; 1988 mask |= 0x8;
2074 1989
2075 if (socket.extmap) 1990 if (socket.extmap)
2076 { 1991 {
2077 *last_ext |= 0x80; 1992 *last_ext |= 0x80;
2078 last_ext = sl.buf + sl.len; 1993 last_ext = sl.buf + sl.length ();
2079 SockList_AddChar (&sl, d); 1994 sl << uint8 (d);
2080 } 1995 }
2081 else 1996 else
2082 SockList_AddChar (&sl, 255 - 64 * d); 1997 sl << uint8 (255 - 64 * d);
2083 } 1998 }
2084 1999
2085 lastcell.count = d; 2000 lastcell.count = d;
2086 2001
2087 if (socket.extmap) 2002 if (socket.extmap)
2088 { 2003 {
2089 uint8 stat_hp = 0; 2004 uint8 stat_hp = 0;
2090 uint8 stat_width = 0; 2005 uint8 stat_width = 0;
2006 uint8 flags = 0;
2091 tag_t player = 0; 2007 UUID player = 0;
2092 2008
2093 // send hp information, if applicable 2009 // send hp information, if applicable
2094 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 2010 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0))
2095 { 2011 {
2096 if (op->head || op->invisible) 2012 if (op->head || op->invisible)
2103 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp; 2019 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
2104 stat_width = op->arch->tail_x; 2020 stat_width = op->arch->tail_x;
2105 } 2021 }
2106 } 2022 }
2107 2023
2024 if (op->msg && op->msg[0] == '@')
2025 flags |= 1;
2026
2108 if (op->type == PLAYER && op != pl) 2027 if (op->type == PLAYER && op != pl)
2109 player = op->count; 2028 player = op->count;
2110 } 2029 }
2111 2030
2112 if (lastcell.stat_hp != stat_hp) 2031 if (lastcell.stat_hp != stat_hp)
2113 { 2032 {
2114 lastcell.stat_hp = stat_hp; 2033 lastcell.stat_hp = stat_hp;
2115 2034
2116 mask |= 0x8; 2035 mask |= 0x8;
2117 *last_ext |= 0x80; 2036 *last_ext |= 0x80;
2118 last_ext = sl.buf + sl.len; 2037 last_ext = sl.buf + sl.length ();
2119 SockList_AddChar (&sl, 5); 2038
2120 SockList_AddChar (&sl, stat_hp); 2039 sl << uint8 (5) << uint8 (stat_hp);
2121 2040
2122 if (stat_width > 1) 2041 if (stat_width > 1)
2123 { 2042 {
2124 *last_ext |= 0x80; 2043 *last_ext |= 0x80;
2125 last_ext = sl.buf + sl.len; 2044 last_ext = sl.buf + sl.length ();
2126 SockList_AddChar (&sl, 6); 2045
2127 SockList_AddChar (&sl, stat_width); 2046 sl << uint8 (6) << uint8 (stat_width);
2128 } 2047 }
2129 } 2048 }
2130 2049
2131 if (lastcell.player != player) 2050 if (lastcell.player != player)
2132 { 2051 {
2133 lastcell.player = player; 2052 lastcell.player = player;
2134 2053
2135 mask |= 0x8; 2054 mask |= 0x8;
2136 *last_ext |= 0x80; 2055 *last_ext |= 0x80;
2137 last_ext = sl.buf + sl.len; 2056 last_ext = sl.buf + sl.length ();
2138 SockList_AddChar (&sl, 0x47); 2057
2139 SockList_AddChar (&sl, 4); 2058 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2140 SockList_AddInt (&sl, player); 2059 }
2060
2061 if (lastcell.flags != flags)
2062 {
2063 lastcell.flags = flags;
2064
2065 mask |= 0x8;
2066 *last_ext |= 0x80;
2067 last_ext = sl.buf + sl.length ();
2068
2069 sl << uint8 (8) << uint8 (flags);
2141 } 2070 }
2142 } 2071 }
2143 2072
2144 /* Floor face */ 2073 /* Floor face */
2145 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 2)) 2074 if (update_space (sl, socket, m, nx, ny, ax, ay, 2))
2146 mask |= 0x4; 2075 mask |= 0x4;
2147 2076
2148 if (socket.EMI_smooth) 2077 if (socket.EMI_smooth)
2149 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 2)) 2078 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2150 emask |= 0x4; 2079 emask |= 0x4;
2151 2080
2152 /* Middle face */ 2081 /* Middle face */
2153 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 1)) 2082 if (update_space (sl, socket, m, nx, ny, ax, ay, 1))
2154 mask |= 0x2; 2083 mask |= 0x2;
2155 2084
2156 if (socket.EMI_smooth) 2085 if (socket.EMI_smooth)
2157 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 1)) 2086 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1))
2158 emask |= 0x2; 2087 emask |= 0x2;
2159 2088
2160 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1)) 2089 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2161 { 2090 {
2162 if (lastcell.faces[0] != pl->face->number) 2091 if (lastcell.faces[0] != pl->face->number)
2163 { 2092 {
2164 lastcell.faces[0] = pl->face->number; 2093 lastcell.faces[0] = pl->face->number;
2165 mask |= 0x1; 2094 mask |= 0x1;
2095
2166 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE)) 2096 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2167 esrv_send_face (&socket, pl->face->number, 0); 2097 esrv_send_face (&socket, pl->face->number, 0);
2168 SockList_AddShort (&sl, pl->face->number); 2098
2099 sl << uint16 (pl->face->number);
2169 } 2100 }
2170 } 2101 }
2171 /* Top face */
2172 else 2102 else
2173 { 2103 {
2104 /* Top face */
2174 if (update_space (&sl, &socket, m, nx, ny, ax, ay, 0)) 2105 if (update_space (sl, socket, m, nx, ny, ax, ay, 0))
2175 mask |= 0x1; 2106 mask |= 0x1;
2107
2176 if (socket.EMI_smooth) 2108 if (socket.EMI_smooth)
2177 if (update_smooth (&esl, &socket, m, nx, ny, ax, ay, 0)) 2109 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2178 {
2179 emask |= 0x1; 2110 emask |= 0x1;
2180 }
2181 } 2111 }
2112
2182 /* Check to see if we are in fact sending anything for this 2113 /* Check to see if we are in fact sending anything for this
2183 * space by checking the mask. If so, update the mask. 2114 * space by checking the mask. If so, update the mask.
2184 * if not, reset the len to that from before adding the mask 2115 * if not, reset the len to that from before adding the mask
2185 * value, so we don't send those bits. 2116 * value, so we don't send those bits.
2186 */ 2117 */
2187 if (mask & 0xf) 2118 if (mask & 0xf)
2188 {
2189 sl.buf[oldlen + 1] = mask & 0xff; 2119 sl.buf[oldlen + 1] = mask & 0xff;
2190 }
2191 else 2120 else
2192 {
2193 sl.len = oldlen; 2121 sl.reset (oldlen);
2194 } 2122
2195 if (emask & 0xf) 2123 if (emask & 0xf)
2196 {
2197 esl.buf[eoldlen + 1] = emask & 0xff; 2124 esl.buf[eoldlen + 1] = emask & 0xff;
2198 }
2199 else 2125 else
2200 {
2201 esl.len = eoldlen; 2126 esl.reset (eoldlen);
2202 }
2203 } /* else this is a viewable space */ 2127 } /* else this is a viewable space */
2204 } /* for x loop */ 2128 } /* for x loop */
2205 } /* for y loop */ 2129 } /* for y loop */
2206 2130
2207 /* Verify that we in fact do need to send this */ 2131 /* Verify that we in fact do need to send this */
2208 if (socket.ext_mapinfos) 2132 if (socket.ext_mapinfos)
2209 { 2133 {
2210 if (!(sl.len > startlen || socket.sent_scroll)) 2134 if (!(sl.length () > startlen || socket.sent_scroll))
2211 { 2135 {
2212 /* No map data will follow, so don't say the client 2136 /* No map data will follow, so don't say the client
2213 * it doesn't need draw! 2137 * it doesn't need draw!
2214 */ 2138 */
2215 ewhatflag &= (~EMI_NOREDRAW); 2139 ewhatflag &= (~EMI_NOREDRAW);
2216 esl.buf[ewhatstart + 1] = ewhatflag & 0xff; 2140 esl.buf[ewhatstart + 1] = ewhatflag & 0xff;
2217 } 2141 }
2218 2142
2219 if (esl.len > estartlen) 2143 if (esl.length () > estartlen)
2220 Send_With_Handling (&socket, &esl); 2144 Send_With_Handling (&socket, &esl);
2221
2222 free (esl.buf);
2223 } 2145 }
2224 2146
2225 if (sl.len > startlen || socket.sent_scroll) 2147 if (sl.length () > startlen || socket.sent_scroll)
2226 { 2148 {
2227 Send_With_Handling (&socket, &sl); 2149 Send_With_Handling (&socket, &sl);
2228 socket.sent_scroll = 0; 2150 socket.sent_scroll = 0;
2229 } 2151 }
2230
2231 free (sl.buf);
2232} 2152}
2233 2153
2234/** 2154/**
2235 * Draws client map. 2155 * Draws client map.
2236 */ 2156 */
2260 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 2180 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2261 return; 2181 return;
2262 2182
2263 memset (&newmap, 0, sizeof (struct Map)); 2183 memset (&newmap, 0, sizeof (struct Map));
2264 2184
2265 for (j = (pl->y - pl->contr->socket.mapy / 2); j < (pl->y + (pl->contr->socket.mapy + 1) / 2); j++) 2185 for (j = (pl->y - pl->contr->socket->mapy / 2); j < (pl->y + (pl->contr->socket->mapy + 1) / 2); j++)
2266 { 2186 {
2267 for (i = (pl->x - pl->contr->socket.mapx / 2); i < (pl->x + (pl->contr->socket.mapx + 1) / 2); i++) 2187 for (i = (pl->x - pl->contr->socket->mapx / 2); i < (pl->x + (pl->contr->socket->mapx + 1) / 2); i++)
2268 { 2188 {
2269 ax = i; 2189 ax = i;
2270 ay = j; 2190 ay = j;
2271 m = pm; 2191 m = pm;
2272 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay); 2192 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
2287 { 2207 {
2288 update_los (pl); 2208 update_los (pl);
2289 pl->contr->do_los = 0; 2209 pl->contr->do_los = 0;
2290 } 2210 }
2291 2211
2292 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd)
2293 {
2294 /* Big maps need a different drawing mechanism to work */ 2212 /* Big maps need a different drawing mechanism to work */
2295 draw_client_map1 (pl); 2213 draw_client_map1 (pl);
2296 return;
2297 }
2298
2299 if (pl->invisible & (pl->invisible < 50 ? 4 : 1))
2300 {
2301 esrv_map_setbelow (&pl->contr->socket, pl->contr->socket.mapx / 2, pl->contr->socket.mapy / 2, pl->face->number, &newmap);
2302 }
2303
2304 /* j and i are the y and x coordinates of the real map (which is
2305 * basically some number of spaces around the player)
2306 * ax and ay are values from within the viewport (ie, 0, 0 is upper
2307 * left corner) and are thus disconnected from the map values.
2308 * Subtract 1 from the max values so that we properly handle cases where
2309 * player has specified an even map. Otherwise, we try to send them too
2310 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually
2311 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is
2312 * odd, this still works fine.
2313 */
2314 ay = 0;
2315 for (j = pl->y - pl->contr->socket.mapy / 2; j <= pl->y + (pl->contr->socket.mapy - 1) / 2; j++, ay++)
2316 {
2317 ax = 0;
2318 for (i = pl->x - pl->contr->socket.mapx / 2; i <= pl->x + (pl->contr->socket.mapx - 1) / 2; i++, ax++)
2319 {
2320
2321 d = pl->contr->blocked_los[ax][ay];
2322 /* note the out_of_map and d>3 checks are both within the same
2323 * negation check.
2324 */
2325 nx = i;
2326 ny = j;
2327 m = get_map_from_coord (pm, &nx, &ny);
2328 if (m && d < 4)
2329 {
2330 face = GET_MAP_FACE (m, nx, ny, 0);
2331 floor2 = GET_MAP_FACE (m, nx, ny, 1);
2332 floor = GET_MAP_FACE (m, nx, ny, 2);
2333
2334 /* If all is blank, send a blank face. */
2335 if ((!face || face == blank_face) && (!floor2 || floor2 == blank_face) && (!floor || floor == blank_face))
2336 {
2337 esrv_map_setbelow (&pl->contr->socket, ax, ay, blank_face->number, &newmap);
2338 }
2339 else
2340 { /* actually have something interesting */
2341 /* send the darkness mask, if any. */
2342 if (d && pl->contr->socket.darkness)
2343 esrv_map_setbelow (&pl->contr->socket, ax, ay, dark_faces[d - 1]->number, &newmap);
2344
2345 if (face && face != blank_face)
2346 esrv_map_setbelow (&pl->contr->socket, ax, ay, face->number, &newmap);
2347 if (floor2 && floor2 != blank_face)
2348 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor2->number, &newmap);
2349 if (floor && floor != blank_face)
2350 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2351 }
2352 } /* Is a valid space */
2353 }
2354 }
2355 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2356
2357 check_map_change (pl->contr);
2358} 2214}
2359 2215
2360 2216
2361/*****************************************************************************/ 2217/*****************************************************************************/
2362 2218
2368 2224
2369/*****************************************************************************/ 2225/*****************************************************************************/
2370void 2226void
2371send_plugin_custom_message (object *pl, char *buf) 2227send_plugin_custom_message (object *pl, char *buf)
2372{ 2228{
2373 cs_write_string (&pl->contr->socket, buf, strlen (buf)); 2229 pl->contr->socket->send_packet (buf);
2374} 2230}
2375 2231
2376/** 2232/**
2377 * This sends the skill number to name mapping. We ignore 2233 * This sends the skill number to name mapping. We ignore
2378 * the params - we always send the same info no matter what. 2234 * the params - we always send the same info no matter what.
2379 */ 2235 */
2380void 2236void
2381send_skill_info (NewSocket * ns, char *params) 2237send_skill_info (client_socket *ns, char *params)
2382{ 2238{
2383 SockList sl; 2239 packet sl;
2384 int i; 2240 sl << "replyinfo skill_info\n";
2385 2241
2386 sl.buf = (unsigned char *) malloc (MAXSOCKBUF);
2387 strcpy ((char *) sl.buf, "replyinfo skill_info\n");
2388 for (i = 1; i < NUM_SKILLS; i++) 2242 for (int i = 1; i < NUM_SKILLS; i++)
2389 { 2243 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2390 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 2244
2391 }
2392 sl.len = strlen ((char *) sl.buf);
2393 if (sl.len >= MAXSOCKBUF) 2245 if (sl.length () >= MAXSOCKBUF)
2394 { 2246 {
2395 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 2247 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2396 fatal (0); 2248 fatal (0);
2397 } 2249 }
2250
2398 Send_With_Handling (ns, &sl); 2251 Send_With_Handling (ns, &sl);
2399 free (sl.buf);
2400} 2252}
2401 2253
2402/** 2254/**
2403 * This sends the spell path to name mapping. We ignore 2255 * This sends the spell path to name mapping. We ignore
2404 * the params - we always send the same info no matter what. 2256 * the params - we always send the same info no matter what.
2405 */ 2257 */
2406void 2258void
2407send_spell_paths (NewSocket * ns, char *params) 2259send_spell_paths (client_socket * ns, char *params)
2408{ 2260{
2409 SockList sl; 2261 packet sl;
2410 int i;
2411 2262
2412 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2263 sl << "replyinfo spell_paths\n";
2413 strcpy ((char *) sl.buf, "replyinfo spell_paths\n"); 2264
2414 for (i = 0; i < NRSPELLPATHS; i++) 2265 for (int i = 0; i < NRSPELLPATHS; i++)
2415 sprintf ((char *) sl.buf + strlen ((char *) sl.buf), "%d:%s\n", 1 << i, spellpathnames[i]); 2266 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2416 sl.len = strlen ((char *) sl.buf); 2267
2417 if (sl.len >= MAXSOCKBUF) 2268 if (sl.length () >= MAXSOCKBUF)
2418 { 2269 {
2419 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 2270 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2420 fatal (0); 2271 fatal (0);
2421 } 2272 }
2273
2422 Send_With_Handling (ns, &sl); 2274 Send_With_Handling (ns, &sl);
2423 free (sl.buf);
2424} 2275}
2425 2276
2426/** 2277/**
2427 * This looks for any spells the player may have that have changed their stats. 2278 * This looks for any spells the player may have that have changed their stats.
2428 * it then sends an updspell packet for each spell that has changed in this way 2279 * it then sends an updspell packet for each spell that has changed in this way
2429 */ 2280 */
2430void 2281void
2431esrv_update_spells (player *pl) 2282esrv_update_spells (player *pl)
2432{ 2283{
2433 SockList sl;
2434 int flags = 0;
2435 object *spell;
2436
2437 if (!pl->socket.monitor_spells) 2284 if (!pl->socket->monitor_spells)
2438 return; 2285 return;
2286
2439 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2287 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2440 { 2288 {
2441 if (spell->type == SPELL) 2289 if (spell->type == SPELL)
2442 { 2290 {
2291 int flags = 0;
2292
2443 /* check if we need to update it */ 2293 /* check if we need to update it */
2444 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 2294 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
2445 { 2295 {
2446 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2296 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2447 flags |= UPD_SP_MANA; 2297 flags |= UPD_SP_MANA;
2448 } 2298 }
2299
2449 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 2300 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
2450 { 2301 {
2451 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2302 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2452 flags |= UPD_SP_GRACE; 2303 flags |= UPD_SP_GRACE;
2453 } 2304 }
2305
2454 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 2306 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
2455 { 2307 {
2456 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2308 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2457 flags |= UPD_SP_DAMAGE; 2309 flags |= UPD_SP_DAMAGE;
2458 } 2310 }
2311
2459 if (flags != 0) 2312 if (flags)
2460 { 2313 {
2461 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2314 packet sl;
2462 strcpy ((char *) sl.buf, "updspell "); 2315
2463 sl.len = strlen ((char *) sl.buf); 2316 sl << "updspell "
2464 SockList_AddChar (&sl, flags); 2317 << uint8 (flags)
2465 SockList_AddInt (&sl, spell->count); 2318 << uint32 (spell->count);
2466 if (flags & UPD_SP_MANA) 2319
2467 SockList_AddShort (&sl, spell->last_sp); 2320 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2468 if (flags & UPD_SP_GRACE) 2321 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2469 SockList_AddShort (&sl, spell->last_grace); 2322 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2470 if (flags & UPD_SP_DAMAGE) 2323
2471 SockList_AddShort (&sl, spell->last_eat);
2472 flags = 0;
2473 Send_With_Handling (&pl->socket, &sl); 2324 Send_With_Handling (pl->socket, &sl);
2474 free (sl.buf);
2475 } 2325 }
2476 } 2326 }
2477 } 2327 }
2478} 2328}
2479 2329
2480void 2330void
2481esrv_remove_spell (player *pl, object *spell) 2331esrv_remove_spell (player *pl, object *spell)
2482{ 2332{
2483 SockList sl;
2484
2485 if (!pl->socket.monitor_spells) 2333 if (!pl->socket->monitor_spells)
2486 return; 2334 return;
2335
2487 if (!pl || !spell || spell->env != pl->ob) 2336 if (!pl || !spell || spell->env != pl->ob)
2488 { 2337 {
2489 LOG (llevError, "Invalid call to esrv_remove_spell"); 2338 LOG (llevError, "Invalid call to esrv_remove_spell");
2490 return; 2339 return;
2491 } 2340 }
2492 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2341
2493 strcpy ((char *) sl.buf, "delspell "); 2342 packet sl;
2494 sl.len = strlen ((char *) sl.buf); 2343
2495 SockList_AddInt (&sl, spell->count); 2344 sl << "delspell "
2345 << uint32 (spell->count);
2346
2496 Send_With_Handling (&pl->socket, &sl); 2347 Send_With_Handling (pl->socket, &sl);
2497 free (sl.buf);
2498} 2348}
2499 2349
2500/* appends the spell *spell to the Socklist we will send the data to. */ 2350/* appends the spell *spell to the Socklist we will send the data to. */
2501static void 2351static void
2502append_spell (player *pl, SockList * sl, object *spell) 2352append_spell (player *pl, packet &sl, object *spell)
2503{ 2353{
2504 int len, i, skill = 0; 2354 int len, i, skill = 0;
2505 2355
2506 if (!(spell->name)) 2356 if (!(spell->name))
2507 { 2357 {
2508 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 2358 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2509 return; 2359 return;
2510 } 2360 }
2511 SockList_AddInt (sl, spell->count); 2361
2512 SockList_AddShort (sl, spell->level);
2513 SockList_AddShort (sl, spell->casting_time);
2514 /* store costs and damage in the object struct, to compare to later */ 2362 /* store costs and damage in the object struct, to compare to later */
2515 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 2363 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
2516 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 2364 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
2517 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 2365 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
2518 /* send the current values */
2519 SockList_AddShort (sl, spell->last_sp);
2520 SockList_AddShort (sl, spell->last_grace);
2521 SockList_AddShort (sl, spell->last_eat);
2522 2366
2523 /* figure out which skill it uses, if it uses one */ 2367 /* figure out which skill it uses, if it uses one */
2524 if (spell->skill) 2368 if (spell->skill)
2525 { 2369 {
2526 for (i = 1; i < NUM_SKILLS; i++) 2370 for (i = 1; i < NUM_SKILLS; i++)
2528 { 2372 {
2529 skill = i + CS_STAT_SKILLINFO; 2373 skill = i + CS_STAT_SKILLINFO;
2530 break; 2374 break;
2531 } 2375 }
2532 } 2376 }
2533 SockList_AddChar (sl, skill);
2534 2377
2535 SockList_AddInt (sl, spell->path_attuned); 2378 /* send the current values */
2379 sl << uint32 (spell->count)
2380 << uint16 (spell->level)
2381 << uint16 (spell->casting_time)
2382 << uint16 (spell->last_sp)
2383 << uint16 (spell->last_grace)
2384 << uint16 (spell->last_eat)
2385 << uint8 (skill)
2386 << uint32 (spell->path_attuned)
2536 SockList_AddInt (sl, (spell->face) ? spell->face->number : 0); 2387 << uint32 (spell->face ? spell->face->number : 0)
2537 2388 << data8 (spell->name)
2538 len = strlen (spell->name); 2389 << data16 (spell->msg);
2539 SockList_AddChar (sl, (char) len);
2540 memcpy (sl->buf + sl->len, spell->name, len);
2541 sl->len += len;
2542
2543 if (!spell->msg)
2544 {
2545 SockList_AddShort (sl, 0);
2546 }
2547 else
2548 {
2549 len = strlen (spell->msg);
2550 SockList_AddShort (sl, len);
2551 memcpy (sl->buf + sl->len, spell->msg, len);
2552 sl->len += len;
2553 }
2554} 2390}
2555 2391
2556/** 2392/**
2557 * This tells the client to add the spell *ob, if *ob is NULL, then add 2393 * This tells the client to add the spell *ob, if *ob is NULL, then add
2558 * all spells in the player's inventory. 2394 * all spells in the player's inventory.
2559 */ 2395 */
2560void 2396void
2561esrv_add_spells (player *pl, object *spell) 2397esrv_add_spells (player *pl, object *spell)
2562{ 2398{
2563 SockList sl;
2564
2565 if (!pl) 2399 if (!pl)
2566 { 2400 {
2567 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 2401 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2568 return; 2402 return;
2569 } 2403 }
2404
2570 if (!pl->socket.monitor_spells) 2405 if (!pl->socket->monitor_spells)
2571 return; 2406 return;
2572 sl.buf = (unsigned char *) malloc (MAXSOCKBUF); 2407
2573 strcpy ((char *) sl.buf, "addspell "); 2408 packet sl;
2574 sl.len = strlen ((char *) sl.buf); 2409
2410 sl << "addspell ";
2411
2575 if (!spell) 2412 if (!spell)
2576 { 2413 {
2577 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 2414 for (spell = pl->ob->inv; spell != NULL; spell = spell->below)
2578 { 2415 {
2579 /* were we to simply keep appending data here, we could exceed 2416 /* were we to simply keep appending data here, we could exceed
2589 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 2426 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
2590 * like it will fix this 2427 * like it will fix this
2591 */ 2428 */
2592 if (spell->type != SPELL) 2429 if (spell->type != SPELL)
2593 continue; 2430 continue;
2431
2594 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 2432 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2595 { 2433 {
2596 Send_With_Handling (&pl->socket, &sl); 2434 Send_With_Handling (pl->socket, &sl);
2597 strcpy ((char *) sl.buf, "addspell "); 2435
2598 sl.len = strlen ((char *) sl.buf); 2436 sl.reset ();
2437 sl << "addspell ";
2599 } 2438 }
2439
2600 append_spell (pl, &sl, spell); 2440 append_spell (pl, sl, spell);
2601 } 2441 }
2602 } 2442 }
2603 else if (spell->type != SPELL) 2443 else if (spell->type != SPELL)
2604 { 2444 {
2605 LOG (llevError, "Asked to send a non-spell object as a spell"); 2445 LOG (llevError, "Asked to send a non-spell object as a spell");
2606 return; 2446 return;
2607 } 2447 }
2608 else 2448 else
2609 append_spell (pl, &sl, spell); 2449 append_spell (pl, sl, spell);
2450
2610 if (sl.len >= MAXSOCKBUF) 2451 if (sl.length () >= MAXSOCKBUF)
2611 { 2452 {
2612 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 2453 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2613 fatal (0); 2454 fatal (0);
2614 } 2455 }
2456
2615 /* finally, we can send the packet */ 2457 /* finally, we can send the packet */
2616 Send_With_Handling (&pl->socket, &sl); 2458 Send_With_Handling (pl->socket, &sl);
2617 free (sl.buf);
2618} 2459}
2460

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines