ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.30 by root, Thu Dec 14 00:01:37 2006 UTC vs.
Revision 1.80 by root, Fri Mar 16 02:51:08 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (C) 2001 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 23 */
23 24
24/** 25/**
25 * \file 26 * \file
26 * Client handling. 27 * Client handling.
27 * 28 *
… …
35 * have the prototype of (char *data, int datalen, int client_num). This 36 * have the prototype of (char *data, int datalen, int client_num). This
36 * way, we can use one dispatch table. 37 * way, we can use one dispatch table.
37 * 38 *
38 * esrv_map_new starts updating the map 39 * esrv_map_new starts updating the map
39 * 40 *
40 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now.
42 *
43 * mapcellchanged, compactlayer, compactstack, perform the map compressing
44 * operations
45 *
46 * esrv_map_doneredraw finishes the map update, and ships across the
47 * map updates.
48 *
49 */ 41 */
50 42
51#include <global.h> 43#include <global.h>
52#include <sproto.h> 44#include <sproto.h>
53 45
54#include <newclient.h>
55#include <newserver.h>
56#include <living.h> 46#include <living.h>
57#include <commands.h> 47#include <commands.h>
58 48
59/* This block is basically taken from socket.c - I assume if it works there, 49/* This block is basically taken from socket.c - I assume if it works there,
60 * it should work here. 50 * it should work here.
… …
63#include <sys/time.h> 53#include <sys/time.h>
64#include <sys/socket.h> 54#include <sys/socket.h>
65#include <netinet/in.h> 55#include <netinet/in.h>
66#include <netdb.h> 56#include <netdb.h>
67 57
68#ifdef HAVE_UNISTD_H
69# include <unistd.h> 58#include <unistd.h>
70#endif
71
72#ifdef HAVE_SYS_TIME_H
73# include <sys/time.h> 59#include <sys/time.h>
74#endif
75 60
76#include "sounds.h" 61#include "sounds.h"
77 62
78/** 63/**
79 * This table translates the attack numbers as used within the 64 * This table translates the attack numbers as used within the
… …
96 -1, /* life stealing */ 81 -1, /* life stealing */
97 -1 /* Disease - not fully done yet */ 82 -1 /* Disease - not fully done yet */
98}; 83};
99 84
100static void 85static void
101socket_map_scroll (NewSocket * ns, int dx, int dy) 86socket_map_scroll (client *ns, int dx, int dy)
102{ 87{
103 struct Map newmap; 88 struct Map newmap;
104 int x, y, mx, my; 89 int x, y, mx, my;
105 90
106 {
107 char buf[MAXSOCKBUF];
108
109 sprintf (buf, "map_scroll %d %d", dx, dy); 91 ns->send_packet_printf ("map_scroll %d %d", dx, dy);
110 Write_String_To_Socket (ns, buf, strlen (buf));
111 }
112 92
113 /* If we are using the Map1aCmd, we may in fact send 93 /* If we are using the Map1aCmd, we may in fact send
114 * head information that is outside the viewable map. 94 * head information that is outside the viewable map.
115 * So set the mx,my to the max value we want to 95 * So set the mx,my to the max value we want to
116 * look for. Removed code to do so - it caused extra 96 * look for. Removed code to do so - it caused extra
… …
118 * that much difference in bandwidth. 98 * that much difference in bandwidth.
119 */ 99 */
120 mx = ns->mapx; 100 mx = ns->mapx;
121 my = ns->mapy; 101 my = ns->mapy;
122 102
123 if (ns->mapmode == Map1aCmd)
124 {
125 mx += MAX_HEAD_OFFSET;
126 my += MAX_HEAD_OFFSET;
127 }
128
129 /* the x and y here are coordinates for the new map, i.e. if we moved 103 /* the x and y here are coordinates for the new map, i.e. if we moved
130 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 104 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
131 * if the destination x or y coordinate is outside the viewable 105 * if the destination x or y coordinate is outside the viewable
132 * area, we clear the values - otherwise, the old values 106 * area, we clear the values - otherwise, the old values
133 * are preserved, and the check_head thinks it needs to clear them. 107 * are preserved, and the check_head thinks it needs to clear them.
… …
156} 130}
157 131
158static void 132static void
159clear_map (player *pl) 133clear_map (player *pl)
160{ 134{
161 NewSocket & socket = pl->socket;
162
163 memset (&socket.lastmap, 0, sizeof (socket.lastmap)); 135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
164 136
137 pl->ns->force_newmap = false;
138
165 if (socket.newmapcmd == 1) 139 if (pl->ns->newmapcmd == 1)
166 Write_String_To_Socket (&socket, "newmap", 6); 140 pl->ns->send_packet ("newmap");
167 141
168 socket.update_look = 1; 142 pl->ns->floorbox_reset ();
169 socket.look_position = 0;
170} 143}
171 144
172/** check for map change and send new map data */ 145/** check for map/region change and send new map data */
173static void 146static void
174check_map_change (player *pl) 147check_map_change (player *pl)
175{ 148{
176 NewSocket & socket = pl->socket; 149 client &socket = *pl->ns;
177 object *ob = pl->ob; 150 object *ob = pl->ob;
178 char buf[MAX_BUF]; /* eauugggh */ 151 char buf[MAX_BUF]; /* eauugggh */
179 152
180 if (socket.current_map != ob->map) 153 if (socket.force_newmap && 0)
181 { 154 {
155 // force newmap is used for clients that do not redraw their map
156 // after image uploads.
182 socket.current_map = ob->map; 157 socket.current_map = ob->map;
183
184 clear_map (pl); 158 clear_map (pl);
159 }
160 else if (socket.current_map != ob->map)
161 {
162 clear_map (pl);
163 socket.current_map = ob->map;
185 164
186 if (socket.mapinfocmd) 165 if (socket.mapinfocmd)
187 { 166 {
188 if (ob->map && ob->map->path[0]) 167 if (ob->map && ob->map->path[0])
189 { 168 {
… …
197 flags |= 4; 176 flags |= 4;
198 if (ob->map->tile_path[3]) 177 if (ob->map->tile_path[3])
199 flags |= 8; 178 flags |= 8;
200 179
201 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s", 180 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s",
202 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, ob->map->path); 181 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, &ob->map->path);
203 } 182 }
204 else 183 else
205 snprintf (buf, MAX_BUF, "mapinfo current"); 184 snprintf (buf, MAX_BUF, "mapinfo current");
206 185
207 Write_String_To_Socket (&socket, buf, strlen (buf)); 186 socket.send_packet (buf);
208 } 187 }
209 } 188 }
210 else if (socket.current_x != ob->x || socket.current_y != ob->y) 189 else if (socket.current_x != ob->x || socket.current_y != ob->y)
211 { 190 {
212 int dx = ob->x - socket.current_x; 191 int dx = ob->x - socket.current_x;
… …
215 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8)) 194 if (socket.buggy_mapscroll && (abs (dx) > 8 || abs (dy) > 8))
216 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows 195 clear_map (pl); // current (<= 1.9.1) clients have unchecked buffer overflows
217 else 196 else
218 { 197 {
219 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y); 198 socket_map_scroll (&socket, ob->x - socket.current_x, ob->y - socket.current_y);
220 socket.update_look = 1; 199 socket.floorbox_reset ();
221 socket.look_position = 0;
222 } 200 }
223 } 201 }
224 202
225 socket.current_x = ob->x; 203 socket.current_x = ob->x;
226 socket.current_y = ob->y; 204 socket.current_y = ob->y;
205
206 region *reg = ob->region ();
207 if (socket.current_region != reg)
208 {
209 socket.current_region = reg;
210 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
211 }
212}
213
214/**
215 * RequestInfo is sort of a meta command. There is some specific
216 * request of information, but we call other functions to provide
217 * that information.
218 */
219void
220RequestInfo (char *buf, int len, client * ns)
221{
222 char *params = NULL, *cp;
223
224 /* No match */
225 char bigbuf[MAX_BUF];
226 int slen;
227
228 /* Set up replyinfo before we modify any of the buffers - this is used
229 * if we don't find a match.
230 */
231 strcpy (bigbuf, "replyinfo ");
232 slen = strlen (bigbuf);
233 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
234
235 /* find the first space, make it null, and update the
236 * params pointer.
237 */
238 for (cp = buf; *cp != '\0'; cp++)
239 if (*cp == ' ')
240 {
241 *cp = '\0';
242 params = cp + 1;
243 break;
244 }
245
246 if (!strcmp (buf, "image_info"))
247 send_image_info (ns, params);
248 else if (!strcmp (buf, "image_sums"))
249 send_image_sums (ns, params);
250 else if (!strcmp (buf, "skill_info"))
251 send_skill_info (ns, params);
252 else if (!strcmp (buf, "spell_paths"))
253 send_spell_paths (ns, params);
254 else
255 ns->send_packet (bigbuf, len);
227} 256}
228 257
229void 258void
230ExtCmd (char *buf, int len, player *pl) 259ExtCmd (char *buf, int len, player *pl)
231{ 260{
232 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len)); 261 INVOKE_PLAYER (EXTCMD, pl, ARG_DATA (buf, len));
262}
263
264void
265ExtiCmd (char *buf, int len, client *ns)
266{
267 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
233} 268}
234 269
235void 270void
236MapInfoCmd (char *buf, int len, player *pl) 271MapInfoCmd (char *buf, int len, player *pl)
237{ 272{
… …
252 buf += 8; 287 buf += 8;
253 288
254 // initial map and its origin 289 // initial map and its origin
255 maptile *map = pl->ob->map; 290 maptile *map = pl->ob->map;
256 sint16 dx, dy; 291 sint16 dx, dy;
257 int mapx = pl->socket.mapx / 2 - pl->ob->x; 292 int mapx = pl->ns->mapx / 2 - pl->ob->x;
258 int mapy = pl->socket.mapy / 2 - pl->ob->y; 293 int mapy = pl->ns->mapy / 2 - pl->ob->y;
259 int max_distance = 8; // limit maximum path length to something generous 294 int max_distance = 8; // limit maximum path length to something generous
260 295
261 while (*buf && map && max_distance) 296 while (*buf && map && max_distance)
262 { 297 {
263 int dir = *buf++; 298 int dir = *buf++;
264 299
265 switch (dir) 300 switch (dir)
266 { 301 {
267 case '1': 302 case '1':
268 dx = 0; 303 dx = 0;
269 dy = -1; 304 dy = -1;
270 map = get_map_from_coord (map, &dx, &dy); 305 map = map->xy_find (dx, dy);
271 map && (mapy -= map->height); 306 map && (mapy -= map->height);
272 break; 307 break;
273 case '2': 308 case '2':
274 mapx += map->width; 309 mapx += map->width;
275 dx = map->width; 310 dx = map->width;
276 dy = 0; 311 dy = 0;
277 map = get_map_from_coord (map, &dx, &dy); 312 map = map->xy_find (dx, dy);
278 break; 313 break;
279 case '3': 314 case '3':
280 mapy += map->height; 315 mapy += map->height;
281 dx = 0; 316 dx = 0;
282 dy = map->height; 317 dy = map->height;
283 map = get_map_from_coord (map, &dx, &dy); 318 map = map->xy_find (dx, dy);
284 break; 319 break;
285 case '4': 320 case '4':
286 dx = -1; 321 dx = -1;
287 dy = 0; 322 dy = 0;
288 map = get_map_from_coord (map, &dx, &dy); 323 map = map->xy_find (dx, dy);
289 map && (mapx -= map->width); 324 map && (mapx -= map->width);
290 break; 325 break;
291 } 326 }
292 327
293 --max_distance; 328 --max_distance;
294 } 329 }
295 330
… …
306 if (map->tile_path[2]) 341 if (map->tile_path[2])
307 flags |= 4; 342 flags |= 4;
308 if (map->tile_path[3]) 343 if (map->tile_path[3])
309 flags |= 8; 344 flags |= 8;
310 345
311 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, map->path); 346 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
312 } 347 }
313 else 348 else
314 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 349 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token);
315 } 350 }
316 else 351 else
317 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 352 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
318 353
319 Write_String_To_Socket (&pl->socket, bigbuf, strlen (bigbuf)); 354 pl->ns->send_packet (bigbuf);
320} 355}
321 356
322/** This is the Setup cmd - easy first implementation */ 357/** This is the Setup cmd - easy first implementation */
323void 358void
324SetUp (char *buf, int len, NewSocket * ns) 359SetUp (char *buf, int len, client * ns)
325{ 360{
326 int s, slen; 361 int s, slen;
327 char *cmd, *param, cmdback[HUGE_BUF]; 362 char *cmd, *param, cmdback[HUGE_BUF];
328 363
329 /* run through the cmds of setup 364 /* run through the cmds of setup
… …
331 * 366 *
332 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown 367 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
333 * The client then must sort this out 368 * The client then must sort this out
334 */ 369 */
335 370
336 LOG (llevInfo, "Get SetupCmd:: %s\n", buf); 371 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
372
337 strcpy (cmdback, "setup"); 373 strcpy (cmdback, "setup");
338 for (s = 0; s < len;) 374 for (s = 0; s < len; )
339 { 375 {
340
341 cmd = &buf[s]; 376 cmd = &buf[s];
342 377
343 /* find the next space, and put a null there */ 378 /* find the next space, and put a null there */
344 for (; buf[s] && buf[s] != ' '; s++); 379 for (; buf[s] && buf[s] != ' '; s++)
380 ;
381
345 buf[s++] = 0; 382 buf[s++] = 0;
383
346 while (buf[s] == ' ') 384 while (buf[s] == ' ')
347 s++; 385 s++;
348 386
349 if (s >= len) 387 if (s >= len)
350 break; 388 break;
351 389
352 param = &buf[s]; 390 param = &buf[s];
353 391
354 for (; buf[s] && buf[s] != ' '; s++); 392 for (; buf[s] && buf[s] != ' '; s++)
393 ;
394
355 buf[s++] = 0; 395 buf[s++] = 0;
396
356 while (buf[s] == ' ') 397 while (buf[s] == ' ')
357 s++; 398 s++;
358 399
359 slen = strlen (cmdback); 400 slen = strlen (cmdback);
360 safe_strcat (cmdback, " ", &slen, HUGE_BUF); 401 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
… …
365 { 406 {
366 ns->sound = atoi (param); 407 ns->sound = atoi (param);
367 safe_strcat (cmdback, param, &slen, HUGE_BUF); 408 safe_strcat (cmdback, param, &slen, HUGE_BUF);
368 } 409 }
369 else if (!strcmp (cmd, "exp64")) 410 else if (!strcmp (cmd, "exp64"))
370 {
371 ns->exp64 = atoi (param);
372 safe_strcat (cmdback, param, &slen, HUGE_BUF); 411 safe_strcat (cmdback, param, &slen, HUGE_BUF);
373 }
374 else if (!strcmp (cmd, "spellmon")) 412 else if (!strcmp (cmd, "spellmon"))
375 { 413 {
376 ns->monitor_spells = atoi (param); 414 ns->monitor_spells = atoi (param);
377 safe_strcat (cmdback, param, &slen, HUGE_BUF); 415 safe_strcat (cmdback, param, &slen, HUGE_BUF);
378 } 416 }
… …
401 } 439 }
402 else if (!strcmp (cmd, "newmapcmd")) 440 else if (!strcmp (cmd, "newmapcmd"))
403 { 441 {
404 ns->newmapcmd = atoi (param); 442 ns->newmapcmd = atoi (param);
405 safe_strcat (cmdback, param, &slen, HUGE_BUF); 443 safe_strcat (cmdback, param, &slen, HUGE_BUF);
406// } else if (!strcmp(cmd,"plugincmd")) {
407// ns->plugincmd = atoi(param);
408// safe_strcat(cmdback, param, &slen, HUGE_BUF);
409 } 444 }
410 else if (!strcmp (cmd, "mapinfocmd")) 445 else if (!strcmp (cmd, "mapinfocmd"))
411 { 446 {
412 ns->mapinfocmd = atoi (param); 447 ns->mapinfocmd = atoi (param);
413 safe_strcat (cmdback, "1", &slen, HUGE_BUF); 448 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
… …
432 char tmpbuf[20]; 467 char tmpbuf[20];
433 int q = atoi (param); 468 int q = atoi (param);
434 469
435 if (is_valid_faceset (q)) 470 if (is_valid_faceset (q))
436 ns->faceset = q; 471 ns->faceset = q;
472
437 sprintf (tmpbuf, "%d", ns->faceset); 473 sprintf (tmpbuf, "%d", ns->faceset);
438 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF); 474 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
439 /* if the client is using faceset, it knows about image2 command */ 475 /* if the client is using faceset, it knows about image2 command */
440 ns->image2 = 1; 476 ns->image2 = 1;
441 } 477 }
… …
469 if (*cp == 'x' || *cp == 'X') 505 if (*cp == 'x' || *cp == 'X')
470 { 506 {
471 y = atoi (cp + 1); 507 y = atoi (cp + 1);
472 break; 508 break;
473 } 509 }
510
474 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y) 511 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
475 { 512 {
476 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y); 513 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
477 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF); 514 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
478 } 515 }
… …
521 * report a failure to the client. 558 * report a failure to the client.
522 */ 559 */
523 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF); 560 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
524 } 561 }
525 } /* for processing all the setup commands */ 562 } /* for processing all the setup commands */
563
526 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback); 564 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
527 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 565 ns->send_packet (cmdback);
528} 566}
529 567
530/** 568/**
531 * The client has requested to be added to the game. 569 * The client has requested to be added to the game.
532 * This is what takes care of it. We tell the client how things worked out. 570 * This is what takes care of it. We tell the client how things worked out.
533 * I am not sure if this file is the best place for this function. however, 571 * I am not sure if this file is the best place for this function. however,
534 * it either has to be here or init_sockets needs to be exported. 572 * it either has to be here or init_sockets needs to be exported.
535 */ 573 */
536void 574void
537AddMeCmd (char *buf, int len, NewSocket * ns) 575AddMeCmd (char *buf, int len, client *ns)
538{ 576{
539 Settings oldsettings; 577 // face caching is mandatory
540 578 if (!ns->facecache)
541 oldsettings = settings;
542 if (ns->status != Ns_Add || add_player (ns))
543 {
544 Write_String_To_Socket (ns, "addme_failed", 12);
545 } 579 {
580 ns->send_drawinfo (
581 "\n"
582 "\n"
583 "***\n"
584 "*** WARNING:\n"
585 "*** Your client does not support face/image caching,\n"
586 "*** or it has been disabled. Face caching is mandatory\n"
587 "*** so please enable it or use a newer client.\n"
588 "***\n"
589 "*** Look at your client preferences:\n"
590 "***\n"
591 "*** CFPlus: all known versions automatically enable the facecache.\n"
592 "*** cfclient: use the -cache commandline option.\n"
593 "*** cfclient: map will not redraw automatically (bug).\n"
594 "*** gcfclient: use -cache commandline option, or enable\n"
595 "*** gcfclient: Client=>Configure=>Map & Image=>Cache Images.\n"
596 "*** jcrossclient: your client is broken, use CFPlus or gcfclient.\n"
597 "***\n"
598 "***\n",
599 NDI_RED
600 );
601
602 if (strstr (ns->version, "jcrossclient"))
603 /* let them, for now*/;
546 else 604 else
605 {
606 ns->flush ();
607 //ns->destroy ();
608 }
609 //ns->facecache = true;
547 { 610 }
548 /* Basically, the add_player copies the socket structure into 611
549 * the player structure, so this one (which is from init_sockets) 612 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
550 * is not needed anymore. The write below should still work, as the
551 * stuff in ns is still relevant.
552 */
553 Write_String_To_Socket (ns, "addme_success", 13);
554 socket_info.nconns--;
555 ns->status = Ns_Avail;
556 }
557 settings = oldsettings;
558} 613}
559 614
560/** Reply to ExtendedInfos command */ 615/** Reply to ExtendedInfos command */
561void 616void
562ToggleExtendedInfos (char *buf, int len, NewSocket * ns) 617ToggleExtendedInfos (char *buf, int len, client * ns)
563{ 618{
564 char cmdback[MAX_BUF]; 619 char cmdback[MAX_BUF];
565 char command[50]; 620 char command[50];
566 int info, nextinfo; 621 int info, nextinfo;
567 622
… …
605 { 660 {
606 strcat (cmdback, " "); 661 strcat (cmdback, " ");
607 strcat (cmdback, "smoothing"); 662 strcat (cmdback, "smoothing");
608 } 663 }
609 664
610 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 665 ns->send_packet (cmdback);
611} 666}
612 667
613/* 668/*
614#define MSG_TYPE_BOOK 1 669#define MSG_TYPE_BOOK 1
615#define MSG_TYPE_CARD 2 670#define MSG_TYPE_CARD 2
… …
618#define MSG_TYPE_MONUMENT 5 673#define MSG_TYPE_MONUMENT 5
619#define MSG_TYPE_SCRIPTED_DIALOG 6*/ 674#define MSG_TYPE_SCRIPTED_DIALOG 6*/
620 675
621/** Reply to ExtendedInfos command */ 676/** Reply to ExtendedInfos command */
622void 677void
623ToggleExtendedText (char *buf, int len, NewSocket * ns) 678ToggleExtendedText (char *buf, int len, client * ns)
624{ 679{
625 char cmdback[MAX_BUF]; 680 char cmdback[MAX_BUF];
626 char temp[10]; 681 char temp[10];
627 char command[50]; 682 char command[50];
628 int info, nextinfo, i, flag; 683 int info, nextinfo, i, flag;
… …
668 strcat (cmdback, " "); 723 strcat (cmdback, " ");
669 snprintf (temp, sizeof (temp), "%d", i); 724 snprintf (temp, sizeof (temp), "%d", i);
670 strcat (cmdback, temp); 725 strcat (cmdback, temp);
671 } 726 }
672 727
673 Write_String_To_Socket (ns, cmdback, strlen (cmdback)); 728 ns->send_packet (cmdback);
674} 729}
675 730
676/**
677 * A lot like the old AskSmooth (in fact, now called by AskSmooth).
678 * Basically, it makes no sense to wait for the client to request a
679 * a piece of data from us that we know the client wants. So
680 * if we know the client wants it, might as well push it to the
681 * client.
682 */
683static void
684SendSmooth (NewSocket * ns, uint16 face)
685{
686 uint16 smoothface;
687
688 /* If we can't find a face, return and set it so we won't try to send this
689 * again.
690 */
691 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface)))
692 {
693
694 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name);
695 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
696 return;
697 }
698
699 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
700 esrv_send_face (ns, smoothface, 0);
701
702 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
703
704 SockList sl (MAXSOCKBUF);
705
706 sl << "smooth "
707 << uint16 (face)
708 << uint16 (smoothface);
709
710 Send_With_Handling (ns, &sl);
711 sl.free ();
712}
713
714 /** 731/**
732 * client requested an image. send it rate-limited
733 * before flushing.
734 */
735void
736AskFaceCmd (char *buf, int len, client *ns)
737{
738 ns->askface.push_back (atoi (buf));
739}
740
741/**
715 * Tells client the picture it has to use 742 * Tells client the picture it has to use
716 * to smooth a picture number given as argument. 743 * to smooth a picture number given as argument.
717 */ 744 */
718void 745void
719AskSmooth (char *buf, int len, NewSocket * ns) 746AskSmooth (char *buf, int len, client *ns)
720{ 747{
721 uint16 facenbr; 748 ns->send_face (atoi (buf));
722
723 facenbr = atoi (buf);
724 SendSmooth (ns, facenbr);
725} 749}
726 750
727/** 751/**
728 * This handles the general commands from the client (ie, north, fire, cast, 752 * This handles the general commands from the client (ie, north, fire, cast,
729 * etc.) 753 * etc.)
730 */ 754 */
731void 755void
732PlayerCmd (char *buf, int len, player *pl) 756PlayerCmd (char *buf, int len, player *pl)
733{ 757{
734
735 /* The following should never happen with a proper or honest client.
736 * Therefore, the error message doesn't have to be too clear - if
737 * someone is playing with a hacked/non working client, this gives them
738 * an idea of the problem, but they deserve what they get
739 */
740 if (pl->state != ST_PLAYING)
741 {
742 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
743 return;
744 }
745 /* Check if there is a count. In theory, a zero count could also be 758 /* Check if there is a count. In theory, a zero count could also be
746 * sent, so check for that also. 759 * sent, so check for that also.
747 */ 760 */
748 if (atoi (buf) || buf[0] == '0') 761 if (atoi (buf) || buf[0] == '0')
749 { 762 {
750 pl->count = atoi ((char *) buf); 763 pl->count = atoi ((char *) buf);
764
751 buf = strchr (buf, ' '); /* advance beyond the numbers */ 765 buf = strchr (buf, ' '); /* advance beyond the numbers */
752 if (!buf) 766 if (!buf)
753 {
754#ifdef ESRV_DEBUG
755 LOG (llevDebug, "PlayerCmd: Got count but no command.\n");
756#endif
757 return; 767 return;
758 } 768
759 buf++; 769 buf++;
760 } 770 }
761 /* This should not happen anymore. */ 771
762 if (pl->ob->speed_left < -1.0)
763 {
764 LOG (llevError, "Player has negative time - shouldn't do command.\n");
765 }
766 /* In c_new.c */
767 execute_newserver_command (pl->ob, (char *) buf); 772 execute_newserver_command (pl->ob, (char *) buf);
768 /* Perhaps something better should be done with a left over count.
769 * Cleaning up the input should probably be done first - all actions
770 * for the command that issued the count should be done before any other
771 * commands.
772 */
773 773
774 pl->count = 0;
775
776}
777
778
779/**
780 * This handles the general commands from the client (ie, north, fire, cast,
781 * etc.). It is a lot like PlayerCmd above, but is called with the
782 * 'ncom' method which gives more information back to the client so it
783 * can throttle.
784 */
785void
786NewPlayerCmd (uint8 * buf, int len, player *pl)
787{
788 int time, repeat;
789 char command[MAX_BUF];
790 short packet;
791
792 if (len < 7)
793 {
794 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
795 return;
796 }
797
798 packet = net_uint16 (buf);
799 repeat = net_uint32 (buf + 2);
800
801 /* -1 is special - no repeat, but don't update */
802 if (repeat != -1)
803 pl->count = repeat;
804
805 if ((len - 4) >= MAX_BUF)
806 len = MAX_BUF - 5;
807
808 strncpy ((char *) command, (char *) buf + 6, len - 4);
809 command[len - 4] = '\0';
810
811 /* The following should never happen with a proper or honest client.
812 * Therefore, the error message doesn't have to be too clear - if
813 * someone is playing with a hacked/non working client, this gives them
814 * an idea of the problem, but they deserve what they get
815 */
816 if (pl->state != ST_PLAYING)
817 {
818 new_draw_info_format (NDI_UNIQUE, 0, pl->ob, "You can not issue commands - state is not ST_PLAYING (%s)", buf);
819 return;
820 }
821
822 /* This should not happen anymore. */
823 if (pl->ob->speed_left < -1.0)
824 LOG (llevError, "Player has negative time - shouldn't do command.\n");
825
826 /* In c_new.c */
827 execute_newserver_command (pl->ob, (char *) command);
828 /* Perhaps something better should be done with a left over count. 774 /* Perhaps something better should be done with a left over count.
829 * Cleaning up the input should probably be done first - all actions 775 * Cleaning up the input should probably be done first - all actions
830 * for the command that issued the count should be done before any other 776 * for the command that issued the count should be done before any other
831 * commands. 777 * commands.
832 */ 778 */
833 pl->count = 0; 779 pl->count = 0;
780}
834 781
835 if (FABS (pl->ob->speed) < 0.001) 782
783/**
784 * This handles the general commands from the client (ie, north, fire, cast,
785 * etc.). It is a lot like PlayerCmd above, but is called with the
786 * 'ncom' method which gives more information back to the client so it
787 * can throttle.
788 */
789void
790NewPlayerCmd (char *buf, int len, player *pl)
791{
792 if (len <= 6)
793 {
794 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf);
795 return;
796 }
797
798 uint16 cmdid = net_uint16 ((uint8 *)buf);
799 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
800
801 /* -1 is special - no repeat, but don't update */
802 if (repeat != -1)
803 pl->count = repeat;
804
805 buf += 6; //len -= 6;
806
807 execute_newserver_command (pl->ob, buf);
808
809 /* Perhaps something better should be done with a left over count.
810 * Cleaning up the input should probably be done first - all actions
811 * for the command that issued the count should be done before any other
812 * commands.
813 */
814 pl->count = 0;
815
816 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
817 int time = fabs (pl->ob->speed) < 0.001
836 time = MAX_TIME * 100; 818 ? time = MAX_TIME * 100
837 else
838 time = (int) (MAX_TIME / FABS (pl->ob->speed)); 819 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
839 820
840 /* Send confirmation of command execution now */ 821 /* Send confirmation of command execution now */
841 822 packet sl ("comc");
842 SockList sl (MAXSOCKBUF);
843 sl << "comc " << uint16 (packet) << uint32 (time); 823 sl << uint16 (cmdid) << uint32 (time);
844 Send_With_Handling (&pl->socket, &sl); 824 pl->ns->send_packet (sl);
845 sl.free ();
846} 825}
847
848 826
849/** This is a reply to a previous query. */ 827/** This is a reply to a previous query. */
850void 828void
851ReplyCmd (char *buf, int len, player *pl) 829ReplyCmd (char *buf, int len, client *ns)
852{ 830{
831 if (ns->state == ST_CUSTOM)
832 {
833 INVOKE_CLIENT (REPLY, ns, ARG_DATA (buf, len));
834 return;
835 }
836
837 if (!ns->pl)
838 return; //TODO: depends on the exact reply we are after
839 //TODO: but right now, we always have a ns->pl
840
841 player *pl = ns->pl;
842
853 /* This is to synthesize how the data would be stored if it 843 /* This is to synthesize how the data would be stored if it
854 * was normally entered. A bit of a hack, and should be cleaned up 844 * was normally entered. A bit of a hack, and should be cleaned up
855 * once all the X11 code is removed from the server. 845 * once all the X11 code is removed from the server.
856 * 846 *
857 * We pass 13 to many of the functions because this way they 847 * We pass 13 to many of the functions because this way they
858 * think it was the carriage return that was entered, and the 848 * think it was the carriage return that was entered, and the
859 * function then does not try to do additional input. 849 * function then does not try to do additional input.
860 */ 850 */
861 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf); 851 snprintf (pl->write_buf, sizeof (pl->write_buf), ":%s", buf);
862 852
863 /* this avoids any hacking here */ 853 /* this avoids any hacking here */
864 854
865 switch (pl->state) 855 switch (ns->state)
866 { 856 {
867 case ST_PLAYING: 857 case ST_PLAYING:
868 LOG (llevError, "Got reply message with ST_PLAYING input state\n"); 858 LOG (llevError, "Got reply message with ST_PLAYING input state\n");
869 break; 859 break;
870 860
871 case ST_PLAY_AGAIN:
872 /* We can check this for return value (2==quit). Maybe we
873 * should, and do something appropriate?
874 */
875 receive_play_again (pl->ob, buf[0]);
876 break;
877
878 case ST_ROLL_STAT:
879 key_roll_stat (pl->ob, buf[0]);
880 break;
881
882 case ST_CHANGE_CLASS: 861 case ST_CHANGE_CLASS:
883
884 key_change_class (pl->ob, buf[0]); 862 key_change_class (pl->ob, buf[0]);
885 break; 863 break;
886 864
887 case ST_CONFIRM_QUIT:
888 key_confirm_quit (pl->ob, buf[0]);
889 break;
890
891 case ST_CONFIGURE:
892 LOG (llevError, "In client input handling, but into configure state\n");
893 pl->state = ST_PLAYING;
894 break;
895
896 case ST_GET_NAME:
897 receive_player_name (pl->ob, 13);
898 break;
899
900 case ST_GET_PASSWORD:
901 case ST_CONFIRM_PASSWORD:
902 receive_player_password (pl->ob, 13);
903 break;
904
905 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 865 case ST_GET_PARTY_PASSWORD: /* Get password for party */
906 receive_party_password (pl->ob, 13); 866 receive_party_password (pl->ob, 13);
907 break; 867 break;
908 868
909 default: 869 default:
910 LOG (llevError, "Unknown input state: %d\n", pl->state); 870 LOG (llevError, "Unknown input state: %d\n", ns->state);
911 } 871 }
912} 872}
913 873
914/** 874/**
915 * Client tells its version. If there is a mismatch, we close the 875 * Client tells its version. If there is a mismatch, we close the
… …
917 * something older than the server. If we assume the client will be 877 * something older than the server. If we assume the client will be
918 * backwards compatible, having it be a later version should not be a 878 * backwards compatible, having it be a later version should not be a
919 * problem. 879 * problem.
920 */ 880 */
921void 881void
922VersionCmd (char *buf, int len, NewSocket * ns) 882VersionCmd (char *buf, int len, client * ns)
923{ 883{
924 char *cp;
925 char version_warning[256];
926
927 if (!buf) 884 if (!buf)
928 { 885 {
929 LOG (llevError, "CS: received corrupted version command\n"); 886 LOG (llevError, "CS: received corrupted version command\n");
930 return; 887 return;
931 } 888 }
932 889
933 ns->cs_version = atoi (buf); 890 ns->cs_version = atoi (buf);
934 ns->sc_version = ns->cs_version; 891 ns->sc_version = ns->cs_version;
892
893 LOG (llevDebug, "connection from client <%s>\n", buf);
894
895 //TODO: should log here just for statistics
896
935 if (VERSION_CS != ns->cs_version) 897 //if (VERSION_CS != ns->cs_version)
936 { 898 // unchecked;
937#ifdef ESRV_DEBUG 899
938 LOG (llevDebug, "CS: csversion mismatch (%d,%d)\n", VERSION_CS, ns->cs_version);
939#endif
940 }
941 cp = strchr (buf + 1, ' '); 900 char *cp = strchr (buf + 1, ' ');
942 if (!cp) 901 if (!cp)
943 return; 902 return;
903
944 ns->sc_version = atoi (cp); 904 ns->sc_version = atoi (cp);
905
945 if (VERSION_SC != ns->sc_version) 906 //if (VERSION_SC != ns->sc_version)
946 { 907 // unchecked;
947#ifdef ESRV_DEBUG 908
948 LOG (llevDebug, "CS: scversion mismatch (%d,%d)\n", VERSION_SC, ns->sc_version);
949#endif
950 }
951 cp = strchr (cp + 1, ' '); 909 cp = strchr (cp + 1, ' ');
910
952 if (cp) 911 if (cp)
953 { 912 {
954 LOG (llevDebug, "CS: connection from client of type <%s>, ip %s\n", cp, ns->host); 913 assign (ns->version, cp + 1);
955 914
956 snprintf (ns->client, sizeof (ns->client), "%s", cp + 1);
957
958 /* This is first implementation - i skip all beta DX clients with it
959 * Add later stuff here for other clients
960 */
961
962 /* these are old dxclients */
963 /* Version 1024 added support for singular + plural name values -
964 * requiing this minimal value reduces complexity of that code, and it
965 * has been around for a long time.
966 */
967 if (ns->sc_version < 1026) 915 if (ns->sc_version < 1026)
968 { 916 ns->send_packet_printf ("drawinfo %d %s", NDI_RED,
969 sprintf (version_warning, "drawinfo %d %s", NDI_RED,
970 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****"); 917 "**** VERSION WARNING ****\n**** CLIENT IS TOO OLD!! UPDATE THE CLIENT!! ****");
971 Write_String_To_Socket (ns, version_warning, strlen (version_warning));
972 }
973
974 } 918 }
975} 919}
976 920
977/** sound related functions. */ 921/** sound related functions. */
978
979void 922void
980SetSound (char *buf, int len, NewSocket * ns) 923SetSound (char *buf, int len, client * ns)
981{ 924{
982 ns->sound = atoi (buf); 925 ns->sound = atoi (buf);
983} 926}
984 927
985/** client wants the map resent */ 928/** client wants the map resent */
986
987void 929void
988MapRedrawCmd (char *buf, int len, player *pl) 930MapRedrawCmd (char *buf, int len, player *pl)
989{ 931{
990
991/* This function is currently disabled; just clearing the map state results in 932/* This function is currently disabled; just clearing the map state results in
992 * display errors. It should clear the cache and send a newmap command. 933 * display errors. It should clear the cache and send a newmap command.
993 * Unfortunately this solution does not work because some client versions send 934 * Unfortunately this solution does not work because some client versions send
994 * a mapredraw command after receiving a newmap command. 935 * a mapredraw command after receiving a newmap command.
995 */ 936 */
996#if 0
997 /* Okay, this is MAJOR UGLY. but the only way I know how to
998 * clear the "cache"
999 */
1000 memset (&pl->socket.lastmap, 0, sizeof (struct Map));
1001 draw_client_map (pl->ob);
1002#endif
1003} 937}
1004 938
1005/** 939/**
1006 * Moves an object (typically, container to inventory). 940 * Moves an object (typically, container to inventory).
1007 * syntax is: move (to) (tag) (nrof) 941 * syntax is: move (to) (tag) (nrof)
… …
1010MoveCmd (char *buf, int len, player *pl) 944MoveCmd (char *buf, int len, player *pl)
1011{ 945{
1012 int vals[3], i; 946 int vals[3], i;
1013 947
1014 /* A little funky here. We only cycle for 2 records, because 948 /* A little funky here. We only cycle for 2 records, because
1015 * we obviously am not going to find a space after the third 949 * we obviously are not going to find a space after the third
1016 * record. Perhaps we should just replace this with a 950 * record. Perhaps we should just replace this with a
1017 * sscanf? 951 * sscanf?
1018 */ 952 */
1019 for (i = 0; i < 2; i++) 953 for (i = 0; i < 2; i++)
1020 { 954 {
1021 vals[i] = atoi (buf); 955 vals[i] = atoi (buf);
956
1022 if (!(buf = strchr (buf, ' '))) 957 if (!(buf = strchr (buf, ' ')))
1023 { 958 {
1024 LOG (llevError, "Incomplete move command: %s\n", buf); 959 LOG (llevError, "Incomplete move command: %s\n", buf);
1025 return; 960 return;
1026 } 961 }
962
1027 buf++; 963 buf++;
1028 } 964 }
965
1029 vals[2] = atoi (buf); 966 vals[2] = atoi (buf);
1030 967
1031/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/ 968/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
1032 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]); 969 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
1033} 970}
1034
1035
1036 971
1037/****************************************************************************** 972/******************************************************************************
1038 * 973 *
1039 * Start of commands the server sends to the client. 974 * Start of commands the server sends to the client.
1040 * 975 *
… …
1043/** 978/**
1044 * Asks the client to query the user. This way, the client knows 979 * Asks the client to query the user. This way, the client knows
1045 * it needs to send something back (vs just printing out a message) 980 * it needs to send something back (vs just printing out a message)
1046 */ 981 */
1047void 982void
1048send_query (NewSocket * ns, uint8 flags, char *text) 983send_query (client *ns, uint8 flags, char *text)
1049{ 984{
1050 char buf[MAX_BUF];
1051
1052 sprintf (buf, "query %d %s", flags, text ? text : ""); 985 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
1053 Write_String_To_Socket (ns, buf, strlen (buf));
1054} 986}
1055 987
1056#define AddIfInt64(Old,New,Type) if (Old != New) {\ 988#define AddIfInt64(Old,New,Type) if (Old != New) {\
1057 Old = New; \ 989 Old = New; \
1058 sl << uint8 (Type) << uint64 (New); \ 990 sl << uint8 (Type) << uint64 (New); \
… …
1088esrv_update_stats (player *pl) 1020esrv_update_stats (player *pl)
1089{ 1021{
1090 char buf[MAX_BUF]; 1022 char buf[MAX_BUF];
1091 uint16 flags; 1023 uint16 flags;
1092 1024
1093 SockList sl (MAXSOCKBUF); 1025 client *ns = pl->ns;
1094 sl << "stats "; 1026 if (!ns)
1027 return;
1095 1028
1096 if (pl->ob != NULL) 1029 object *ob = pl->ob;
1097 { 1030 if (!ob)
1031 return;
1032
1033 packet sl ("stats");
1034
1098 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 1035 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1099 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 1036 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1100 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 1037 AddIfShort (ns->last_stats.sp, ob->stats.sp, CS_STAT_SP);
1101 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 1038 AddIfShort (ns->last_stats.maxsp, ob->stats.maxsp, CS_STAT_MAXSP);
1102 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 1039 AddIfShort (ns->last_stats.grace, ob->stats.grace, CS_STAT_GRACE);
1103 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 1040 AddIfShort (ns->last_stats.maxgrace, ob->stats.maxgrace, CS_STAT_MAXGRACE);
1104 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 1041 AddIfShort (ns->last_stats.Str, ob->stats.Str, CS_STAT_STR);
1105 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT);
1106 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW);
1107 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS);
1108 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 1042 AddIfShort (ns->last_stats.Dex, ob->stats.Dex, CS_STAT_DEX);
1109 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 1043 AddIfShort (ns->last_stats.Con, ob->stats.Con, CS_STAT_CON);
1044 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
1045 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
1046 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1110 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 1047 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1111 }
1112 1048
1113 if (pl->socket.exp64)
1114 {
1115 uint8 s;
1116
1117 for (s = 0; s < NUM_SKILLS; s++) 1049 for (int s = 0; s < NUM_SKILLS; s++)
1118 { 1050 if (object *skill = pl->last_skill_ob[s])
1119 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 1051 if (skill->stats.exp != ns->last_skill_exp [s])
1120 { 1052 {
1053 ns->last_skill_exp [s] = skill->stats.exp;
1054
1121 /* Always send along the level if exp changes. This is only 1055 /* Always send along the level if exp changes. This is only
1122 * 1 extra byte, but keeps processing simpler. 1056 * 1 extra byte, but keeps processing simpler.
1123 */ 1057 */
1124 sl << uint8 (s + CS_STAT_SKILLINFO) 1058 sl << uint8 (s + CS_STAT_SKILLINFO)
1125 << uint8 (pl->last_skill_ob[s]->level) 1059 << uint8 (skill->level)
1126 << uint64 (pl->last_skill_ob[s]->stats.exp); 1060 << uint64 (skill->stats.exp);
1127
1128 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1129 } 1061 }
1130 }
1131 }
1132 1062
1133 if (pl->socket.exp64)
1134 { AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64) } 1063 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
1135 else
1136 { AddIfInt (pl->last_stats.exp, (int) pl->ob->stats.exp, CS_STAT_EXP) }
1137
1138 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 1064 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
1139 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 1065 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
1140 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 1066 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
1141 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 1067 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
1142 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 1068 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED);
1143 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 1069 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
1144 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 1070 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1145 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 1071 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
1072
1146 flags = 0; 1073 flags = 0;
1147 1074
1148 if (pl->fire_on) 1075 if (pl->fire_on)
1149 flags |= SF_FIREON; 1076 flags |= SF_FIREON;
1150 1077
1151 if (pl->run_on) 1078 if (pl->run_on)
1152 flags |= SF_RUNON; 1079 flags |= SF_RUNON;
1153 1080
1154 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 1081 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
1155 1082
1156 if (pl->socket.sc_version < 1025) 1083 if (ns->sc_version < 1025)
1157 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) } 1084 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1158 else 1085 else
1159 {
1160 int i;
1161
1162 for (i = 0; i < NROFATTACKS; i++) 1086 for (int i = 0; i < NROFATTACKS; i++)
1163 { 1087 {
1164 /* Skip ones we won't send */ 1088 /* Skip ones we won't send */
1165 if (atnr_cs_stat[i] == -1) 1089 if (atnr_cs_stat[i] == -1)
1166 continue; 1090 continue;
1167 1091
1168 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 1092 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
1169 } 1093 }
1170 }
1171 1094
1172 if (pl->socket.monitor_spells) 1095 if (pl->ns->monitor_spells)
1173 { 1096 {
1174 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 1097 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1175 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 1098 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1176 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 1099 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1177 } 1100 }
1178 1101
1179 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 1102 rangetostring (ob, buf); /* we want use the new fire & run system in new client */
1180 AddIfString (pl->socket.stats.range, buf, CS_STAT_RANGE); 1103 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1181 set_title (pl->ob, buf); 1104 set_title (ob, buf);
1182 AddIfString (pl->socket.stats.title, buf, CS_STAT_TITLE); 1105 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1183 1106
1184 /* Only send it away if we have some actual data */ 1107 /* Only send it away if we have some actual data */
1185 if (sl.len > 6) 1108 if (sl.length () > 6)
1186 { 1109 ns->send_packet (sl);
1187#ifdef ESRV_DEBUG
1188 LOG (llevDebug, "Sending stats command, %d bytes long.\n", sl.len);
1189#endif
1190 Send_With_Handling (&pl->socket, &sl);
1191 }
1192
1193 sl.free ();
1194} 1110}
1195 1111
1196/** 1112/**
1197 * Tells the client that here is a player it should start using. 1113 * Tells the client that here is a player it should start using.
1198 */ 1114 */
1199void 1115void
1200esrv_new_player (player *pl, uint32 weight) 1116esrv_new_player (player *pl, uint32 weight)
1201{ 1117{
1202 pl->last_weight = weight; 1118 packet sl ("player");
1203
1204 SockList sl (MAXSOCKBUF);
1205 sl << "player ";
1206 1119
1207 sl << uint32 (pl->ob->count) 1120 sl << uint32 (pl->ob->count)
1208 << uint32 (weight) 1121 << uint32 (weight)
1209 << uint32 (pl->ob->face->number) 1122 << uint32 (pl->ob->face)
1210 << data8 (pl->ob->name); 1123 << data8 (pl->ob->name);
1211 1124
1212 Send_With_Handling (&pl->socket, &sl); 1125 pl->ns->last_weight = weight;
1213 sl.free (); 1126 pl->ns->send_packet (sl);
1214 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1127 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1215} 1128}
1216
1217/**
1218 * Need to send an animation sequence to the client.
1219 * We will send appropriate face commands to the client if we haven't
1220 * sent them the face yet (this can become quite costly in terms of
1221 * how much we are sending - on the other hand, this should only happen
1222 * when the player logs in and picks stuff up.
1223 */
1224void
1225esrv_send_animation (NewSocket * ns, short anim_num)
1226{
1227 int i;
1228
1229 /* Do some checking on the anim_num we got. Note that the animations
1230 * are added in contigous order, so if the number is in the valid
1231 * range, it must be a valid animation.
1232 */
1233 if (anim_num < 0 || anim_num > num_animations)
1234 {
1235 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1236 return;
1237 }
1238
1239 SockList sl (MAXSOCKBUF);
1240
1241 sl << "anim "
1242 << uint16 (anim_num)
1243 << uint16 (0); /* flags - not used right now */
1244
1245 /* Build up the list of faces. Also, send any information (ie, the
1246 * the face itself) down to the client.
1247 */
1248 for (i = 0; i < animations[anim_num].num_animations; i++)
1249 {
1250 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1251 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1252 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1253 }
1254
1255 Send_With_Handling (ns, &sl);
1256 sl.free ();
1257
1258 ns->anims_sent[anim_num] = 1;
1259}
1260
1261 1129
1262/****************************************************************************** 1130/******************************************************************************
1263 * 1131 *
1264 * Start of map related commands. 1132 * Start of map related commands.
1265 * 1133 *
1266 ******************************************************************************/ 1134 ******************************************************************************/
1267 1135
1268/**
1269 * This adds face_num to a map cell at x,y. If the client doesn't have
1270 * the face yet, we will also send it.
1271 */
1272static void
1273esrv_map_setbelow (NewSocket * ns, int x, int y, short face_num, struct Map *newmap)
1274{
1275 if (newmap->cells[x][y].count >= MAP_LAYERS)
1276 {
1277 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1278 return;
1279 abort ();
1280 }
1281
1282 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1283 newmap->cells[x][y].count++;
1284
1285 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1286 esrv_send_face (ns, face_num, 0);
1287}
1288
1289struct LayerCell
1290{
1291 uint16 xy;
1292 short face;
1293};
1294
1295struct MapLayer
1296{
1297 int count;
1298 struct LayerCell lcells[MAP_CLIENT_X * MAP_CLIENT_Y];
1299};
1300
1301/** Checkes if map cells have changed */
1302static int
1303mapcellchanged (NewSocket * ns, int i, int j, struct Map *newmap)
1304{
1305 int k;
1306
1307 if (ns->lastmap.cells[i][j].count != newmap->cells[i][j].count)
1308 return 1;
1309 for (k = 0; k < newmap->cells[i][j].count; k++)
1310 {
1311 if (ns->lastmap.cells[i][j].faces[k] != newmap->cells[i][j].faces[k])
1312 {
1313 return 1;
1314 }
1315 }
1316 return 0;
1317}
1318
1319/**
1320 * Basically, what this does is pack the data into layers.
1321 * cnum is the client number, cur is the the buffer we put all of
1322 * this data into. we return the end of the data. layers is
1323 * how many layers of data we should back.
1324 */
1325static uint8 *
1326compactlayer (NewSocket * ns, unsigned char *cur, int numlayers, struct Map *newmap)
1327{
1328 int x, y, k;
1329 int face;
1330 unsigned char *fcur;
1331 struct MapLayer layers[MAP_LAYERS];
1332
1333 for (k = 0; k < MAP_LAYERS; k++)
1334 layers[k].count = 0;
1335 fcur = cur;
1336 for (x = 0; x < ns->mapx; x++)
1337 {
1338 for (y = 0; y < ns->mapy; y++)
1339 {
1340 if (!mapcellchanged (ns, x, y, newmap))
1341 continue;
1342 if (newmap->cells[x][y].count == 0)
1343 {
1344 *cur = x * ns->mapy + y; /* mark empty space */
1345 cur++;
1346 continue;
1347 }
1348 for (k = 0; k < newmap->cells[x][y].count; k++)
1349 {
1350 layers[k].lcells[layers[k].count].xy = x * ns->mapy + y;
1351 layers[k].lcells[layers[k].count].face = newmap->cells[x][y].faces[k];
1352 layers[k].count++;
1353 }
1354 }
1355 }
1356 /* If no data, return now. */
1357 if (fcur == cur && layers[0].count == 0)
1358 return cur;
1359 *cur = 255; /* mark end of explicitly cleared cells */
1360 cur++;
1361 /* First pack by layers. */
1362 for (k = 0; k < numlayers; k++)
1363 {
1364 if (layers[k].count == 0)
1365 break; /* once a layer is entirely empty, no layer below it can
1366 have anything in it either */
1367 /* Pack by entries in thie layer */
1368 for (x = 0; x < layers[k].count;)
1369 {
1370 fcur = cur;
1371 *cur = layers[k].lcells[x].face >> 8;
1372 cur++;
1373 *cur = layers[k].lcells[x].face & 0xFF;
1374 cur++;
1375 face = layers[k].lcells[x].face;
1376 /* Now, we back the redundant data into 1 byte xy pairings */
1377 for (y = x; y < layers[k].count; y++)
1378 {
1379 if (layers[k].lcells[y].face == face)
1380 {
1381 *cur = (uint8) layers[k].lcells[y].xy;
1382 cur++;
1383 layers[k].lcells[y].face = -1;
1384 }
1385 }
1386 *(cur - 1) = *(cur - 1) | 128; /* mark for end of xy's; 11*11 < 128 */
1387 /* forward over the now redundant data */
1388 while (x < layers[k].count && layers[k].lcells[x].face == -1)
1389 x++;
1390 }
1391 *fcur = *fcur | 128; /* mark for end of faces at this layer */
1392 }
1393 return cur;
1394}
1395
1396static void
1397esrv_map_doneredraw (NewSocket * ns, struct Map *newmap)
1398{
1399 static long frames, bytes, tbytes, tframes;
1400 char *cur;
1401
1402 SockList sl (MAXSOCKBUF);
1403 sl << "map ";
1404
1405 cur = (char *) compactlayer (ns, (unsigned char *) sl.buf + sl.len, MAP_LAYERS, newmap);
1406 sl.len = cur - (char *) sl.buf;
1407
1408/* LOG(llevDebug, "Sending map command.\n");*/
1409
1410 if (sl.len > (int) strlen ("map ") || ns->sent_scroll)
1411 {
1412 /* All of this is just accounting stuff */
1413 if (tframes > 100)
1414 tframes = tbytes = 0;
1415
1416 tframes++;
1417 frames++;
1418 tbytes += sl.len;
1419 bytes += sl.len;
1420 memcpy (&ns->lastmap, newmap, sizeof (struct Map));
1421 Send_With_Handling (ns, &sl);
1422 ns->sent_scroll = 0;
1423 }
1424
1425 sl.free ();
1426}
1427
1428
1429/** Clears a map cell */ 1136/** Clears a map cell */
1430static void 1137static void
1431map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 1138map_clearcell (struct MapCell *cell, int count)
1432{ 1139{
1433 cell->faces[0] = face0; 1140 cell->faces[0] = 0;
1434 cell->faces[1] = face1; 1141 cell->faces[1] = 0;
1435 cell->faces[2] = face2; 1142 cell->faces[2] = 0;
1143 cell->smooth[0] = 0;
1144 cell->smooth[1] = 0;
1145 cell->smooth[2] = 0;
1436 cell->count = count; 1146 cell->count = count;
1437 cell->stat_hp = 0; 1147 cell->stat_hp = 0;
1438 cell->flags = 0; 1148 cell->flags = 0;
1439 cell->player = 0; 1149 cell->player = 0;
1440} 1150}
1441 1151
1442#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1443#define MAX_LAYERS 3 1152#define MAX_LAYERS 3
1444
1445/* Using a global really isn't a good approach, but saves the over head of
1446 * allocating and deallocating such a block of data each time run through,
1447 * and saves the space of allocating this in the socket object when we only
1448 * need it for this cycle. If the serve is ever threaded, this needs to be
1449 * re-examined.
1450 */
1451
1452static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1453
1454/**
1455 * Returns true if any of the heads for this
1456 * space is set. Returns false if all are blank - this is used
1457 * for empty space checking.
1458 */
1459static inline int
1460have_head (int ax, int ay)
1461{
1462
1463 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1464 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1465 return 1;
1466 return 0;
1467}
1468
1469/**
1470 * check_head is a bit simplistic version of update_space below.
1471 * basically, it only checks the that the head on space ax,ay at layer
1472 * needs to get sent - if so, it adds the data, sending the head
1473 * if needed, and returning 1. If this no data needs to get
1474 * sent, it returns zero.
1475 */
1476static int
1477check_head (SockList &sl, NewSocket &ns, int ax, int ay, int layer)
1478{
1479 short face_num;
1480
1481 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1482 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1483 else
1484 face_num = 0;
1485
1486 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1487 {
1488 SockList_AddShort (&sl, face_num);
1489 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1490 esrv_send_face (&ns, face_num, 0);
1491
1492 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1493 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1494 return 1;
1495 }
1496
1497 return 0; /* No change */
1498}
1499 1153
1500/** 1154/**
1501 * Removes the need to replicate the same code for each layer. 1155 * Removes the need to replicate the same code for each layer.
1502 * this returns true if this space is now in fact different than 1156 * this returns true if this space is now in fact different than
1503 * it was. 1157 * it was.
1504 * sl is the socklist this data is going into. 1158 * sl is the socklist this data is going into.
1505 * ns is the socket we are working on - all the info we care 1159 * ns is the socket we are working on - all the info we care
1506 * about is in this socket structure, so now need not pass the 1160 * about is in this socket structure, so now need not pass the
1507 * entire player object. 1161 * entire player object.
1508 * mx and my are map coordinate offsets for map mp
1509 * sx and sy are the offsets into the socket structure that
1510 * holds the old values.
1511 * layer is the layer to update, with 2 being the floor and 0 the 1162 * layer is the layer to update, with 2 being the floor and 0 the
1512 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ) 1163 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ)
1513 * take. Interesting to note that before this function, the map1 function 1164 * take. Interesting to note that before this function, the map1 function
1514 * numbers the spaces differently - I think this was a leftover from 1165 * numbers the spaces differently - I think this was a leftover from
1515 * the map command, where the faces stack up. Sinces that is no longer 1166 * the map command, where the faces stack up. Sinces that is no longer
1516 * the case, it seems to make more sense to have these layer values 1167 * the case, it seems to make more sense to have these layer values
1517 * actually match. 1168 * actually match.
1518 */ 1169 */
1519
1520static int 1170static int
1521update_space (SockList &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1171update_space (packet &sl, client &ns, mapspace &ms, MapCell &lastcell, int layer)
1522{ 1172{
1523 object *ob, *head; 1173 object *ob = ms.faces_obj [layer];
1524 uint16 face_num;
1525 int bx, by, i;
1526
1527 /* If there is a multipart object stored away, treat that as more important.
1528 * If not, then do the normal processing.
1529 */
1530 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1531
1532 /* Check to see if this head is part of the set of objects
1533 * we would normally send for this space. If so, then
1534 * don't use the head value. We need to do the check
1535 * here and not when setting up the heads[] value for two reasons -
1536 * 1) the heads[] values will get used even if the space is not visible.
1537 * 2) its possible the head is not on the same map as a part, and I'd
1538 * rather not need to do the map translation overhead.
1539 * 3) We need to do some extra checking to make sure that we will
1540 * otherwise send the image as this layer, eg, either it matches
1541 * the head value, or is not multipart.
1542 */
1543 if (head && !head->more)
1544 {
1545 for (i = 0; i < MAP_LAYERS; i++)
1546 {
1547 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1548 if (!ob)
1549 continue;
1550
1551 if (ob->head)
1552 ob = ob->head;
1553
1554 if (ob == head)
1555 {
1556 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1557 head = NULL;
1558 break;
1559 }
1560 }
1561 }
1562
1563 ob = head;
1564 if (!ob)
1565 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1566 1174
1567 /* If there is no object for this space, or if the face for the object 1175 /* If there is no object for this space, or if the face for the object
1568 * is the blank face, set the face number to zero. 1176 * is the blank face, set the face number to zero.
1569 * else if we have the stored head object for this space, that takes 1177 * else if we have the stored head object for this space, that takes
1570 * precedence over the other object for this space. 1178 * precedence over the other object for this space.
1571 * otherwise, we do special head processing 1179 * otherwise, we do special head processing
1572 */ 1180 */
1573 if (!ob || ob->face == blank_face) 1181 uint16 face_num = ob && ob->face != blank_face ? ob->face : 0;
1574 face_num = 0;
1575 else if (head)
1576 {
1577 /* if this is a head that had previously been stored */
1578 face_num = ob->face->number;
1579 }
1580 else
1581 {
1582 /* if the faces for the different parts of a multipart object
1583 * are the same, we only want to send the bottom right most
1584 * portion of the object. That info is in the tail_.. values
1585 * of the head. Note that for the head itself, ob->head will
1586 * be null, so we only do this block if we are working on
1587 * a tail piece.
1588 */
1589
1590 /* tail_x and tail_y will only be set in the head object. If
1591 * this is the head object and these are set, we proceed
1592 * with logic to only send bottom right. Similarly, if
1593 * this is one of the more parts but the head has those values
1594 * set, we want to do the processing. There can be cases where
1595 * the head is not visible but one of its parts is, so we just
1596 * can always expect that ob->arch->tail_x will be true for all
1597 * object we may want to display.
1598 */
1599 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1600 {
1601
1602 if (ob->head)
1603 head = ob->head;
1604 else
1605 head = ob;
1606
1607 /* Basically figure out where the offset is from where we are right
1608 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1609 * piece is from the head, and the tail is where the tail is from the
1610 * head. Note that bx and by will equal sx and sy if we are already working
1611 * on the bottom right corner. If ob is the head, the clone values
1612 * will be zero, so the right thing will still happen.
1613 */
1614 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1615 by = sy + head->arch->tail_y - ob->arch->clone.y;
1616
1617 /* I don't think this can ever happen, but better to check for it just
1618 * in case.
1619 */
1620 if (bx < sx || by < sy)
1621 {
1622 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1623 face_num = 0;
1624 }
1625 /* single part object, multipart object with non merged faces,
1626 * of multipart object already at lower right.
1627 */
1628 else if (bx == sx && by == sy)
1629 {
1630 face_num = ob->face->number;
1631
1632 /* if this face matches one stored away, clear that one away.
1633 * this code relies on the fact that the map1 commands
1634 * goes from 2 down to 0.
1635 */
1636 for (i = 0; i < MAP_LAYERS; i++)
1637 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1638 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1639 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1640 }
1641 else
1642 {
1643 /* If this head is stored away, clear it - otherwise,
1644 * there can be cases where a object is on multiple layers -
1645 * we only want to send it once.
1646 */
1647 face_num = head->face->number;
1648 for (i = 0; i < MAP_LAYERS; i++)
1649 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1650 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1651 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1652
1653 /* First, try to put the new head on the same layer. If that is used up,
1654 * then find another layer.
1655 */
1656 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1657 {
1658 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1659 }
1660 else
1661 for (i = 0; i < MAX_LAYERS; i++)
1662 {
1663 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1664 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1665 {
1666 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1667 }
1668 }
1669 face_num = 0; /* Don't send this object - we'll send the head later */
1670 }
1671 }
1672 else
1673 {
1674 /* In this case, we are already at the lower right or single part object,
1675 * so nothing special
1676 */
1677 face_num = ob->face->number;
1678
1679 /* clear out any head entries that have the same face as this one */
1680 for (bx = 0; bx < layer; bx++)
1681 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1682 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1683 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1684 }
1685 } /* else not already head object or blank face */
1686
1687 /* This is a real hack. Basically, if we have nothing to send for this layer,
1688 * but there is a head on the next layer, send that instead.
1689 * Without this, what happens is you can get the case where the player stands
1690 * on the same space as the head. However, if you have overlapping big objects
1691 * of the same type, what happens then is it doesn't think it needs to send
1692 * This tends to make stacking also work/look better.
1693 */
1694 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1695 {
1696 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1697 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1698 }
1699
1700 /* Another hack - because of heads and whatnot, this face may match one
1701 * we already sent for a lower layer. In that case, don't send
1702 * this one.
1703 */
1704 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1705 face_num = 0;
1706 1182
1707 /* We've gotten what face we want to use for the object. Now see if 1183 /* We've gotten what face we want to use for the object. Now see if
1708 * if it has changed since we last sent it to the client. 1184 * if it has changed since we last sent it to the client.
1709 */ 1185 */
1710 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num) 1186 if (lastcell.faces[layer] != face_num)
1711 { 1187 {
1712 ns.lastmap.cells[sx][sy].faces[layer] = face_num; 1188 lastcell.faces[layer] = face_num;
1189
1713 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1190 if (!ns.faces_sent[face_num])
1191 if (ob)
1192 ns.send_faces (ob);
1193 else
1714 esrv_send_face (&ns, face_num, 0); 1194 ns.send_face (face_num);
1715 1195
1716 sl << uint16 (face_num); 1196 sl << uint16 (face_num);
1717 return 1;
1718 }
1719
1720 /* Nothing changed */
1721 return 0;
1722}
1723
1724/**
1725 * This function is mainly a copy of update_space,
1726 * except it handles update of the smoothing updates,
1727 * not the face updates.
1728 * Removes the need to replicate the same code for each layer.
1729 * this returns true if this smooth is now in fact different
1730 * than it was.
1731 * sl is the socklist this data is going into.
1732 * ns is the socket we are working on - all the info we care
1733 * about is in this socket structure, so know need to pass the
1734 * entire player object.
1735 * mx and my are map coordinate offsets for map mp
1736 * sx and sy are the offsets into the socket structure that
1737 * holds the old values.
1738 * layer is the layer to update, with 2 being the floor and 0 the
1739 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1740 * take.
1741 */
1742
1743static inline int
1744update_smooth (SockList &sl, NewSocket &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1745{
1746 object *ob;
1747 int smoothlevel; /* old face_num; */
1748
1749 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1750
1751 /* If there is no object for this space, or if the face for the object
1752 * is the blank face, set the smoothlevel to zero.
1753 */
1754 if (!ob || ob->face == blank_face || MAP_NOSMOOTH (mp))
1755 smoothlevel = 0;
1756 else
1757 {
1758 smoothlevel = ob->smoothlevel;
1759 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1760 SendSmooth (&ns, ob->face->number);
1761 } /* else not already head object or blank face */
1762
1763 /* We've gotten what face we want to use for the object. Now see if
1764 * if it has changed since we last sent it to the client.
1765 */
1766 if (smoothlevel > 255)
1767 smoothlevel = 255;
1768 else if (smoothlevel < 0)
1769 smoothlevel = 0;
1770
1771 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1772 {
1773 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1774 sl << uint8 (smoothlevel);
1775 return 1; 1197 return 1;
1776 } 1198 }
1777 1199
1778 /* Nothing changed */ 1200 /* Nothing changed */
1779 return 0; 1201 return 0;
… …
1783 * Returns the size of a data for a map square as returned by 1205 * Returns the size of a data for a map square as returned by
1784 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries 1206 * mapextended. There are CLIENTMAPX*CLIENTMAPY*LAYERS entries
1785 * available. 1207 * available.
1786 */ 1208 */
1787int 1209int
1788getExtendedMapInfoSize (NewSocket * ns) 1210getExtendedMapInfoSize (client * ns)
1789{ 1211{
1790 int result = 0; 1212 int result = 0;
1791 1213
1792 if (ns->ext_mapinfos) 1214 if (ns->ext_mapinfos)
1793 { 1215 {
1794 if (ns->EMI_smooth) 1216 if (ns->EMI_smooth)
1795 result += 1; /*One byte for smoothlevel */ 1217 result += 1; /*One byte for smoothlevel */
1796 } 1218 }
1219
1797 return result; 1220 return result;
1221}
1222
1223// prefetch (and touch) all maps within a specific distancd
1224static void
1225prefetch_surrounding_maps (maptile *map, int distance)
1226{
1227 map->last_access = runtime;
1228
1229 if (--distance)
1230 for (int dir = 4; --dir; )
1231 if (const shstr &path = map->tile_path [dir])
1232 if (maptile *&neigh = map->tile_map [dir])
1233 prefetch_surrounding_maps (neigh, distance);
1234 else
1235 neigh = maptile::find_async (path, map);
1236}
1237
1238// prefetch a generous area around the player
1239static void
1240prefetch_surrounding_maps (object *op)
1241{
1242 prefetch_surrounding_maps (op->map, 3);
1798} 1243}
1799 1244
1800/** 1245/**
1801 * This function uses the new map1 protocol command to send the map 1246 * This function uses the new map1 protocol command to send the map
1802 * to the client. It is necessary because the old map command supports 1247 * to the client. It is necessary because the old map command supports
… …
1808 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off 1253 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1809 * maps no sense. Instead, we actually really only use 12 bits for coordinates, 1254 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1810 * and use the other 4 bits for other informatiion. For full documentation 1255 * and use the other 4 bits for other informatiion. For full documentation
1811 * of what we send, see the doc/Protocol file. 1256 * of what we send, see the doc/Protocol file.
1812 * I will describe internally what we do: 1257 * I will describe internally what we do:
1813 * the socket->lastmap shows how the map last looked when sent to the client. 1258 * the ns->lastmap shows how the map last looked when sent to the client.
1814 * in the lastmap structure, there is a cells array, which is set to the 1259 * in the lastmap structure, there is a cells array, which is set to the
1815 * maximum viewable size (As set in config.h). 1260 * maximum viewable size (As set in config.h).
1816 * in the cells, there are faces and a count value. 1261 * in the cells, there are faces and a count value.
1817 * we use the count value to hold the darkness value. If -1, then this space 1262 * we use the count value to hold the darkness value. If -1, then this space
1818 * is not viewable. 1263 * is not viewable.
… …
1820 * look like. 1265 * look like.
1821 */ 1266 */
1822void 1267void
1823draw_client_map1 (object *pl) 1268draw_client_map1 (object *pl)
1824{ 1269{
1825 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1270 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1826 sint16 nx, ny; 1271 sint16 nx, ny;
1827 int estartlen, eoldlen; 1272 int estartlen, eoldlen;
1828 uint16 mask, emask;
1829 uint8 eentrysize; 1273 uint8 eentrysize;
1830 uint16 ewhatstart, ewhatflag; 1274 uint16 ewhatstart, ewhatflag;
1831 uint8 extendedinfos; 1275 uint8 extendedinfos;
1832 maptile *m; 1276 maptile *m;
1833 1277
1834 NewSocket &socket = pl->contr->socket; 1278 client &socket = *pl->contr->ns;
1279
1280 if (!pl->active)
1281 return;
1835 1282
1836 check_map_change (pl->contr); 1283 check_map_change (pl->contr);
1284 prefetch_surrounding_maps (pl);
1837 1285
1838 SockList sl (MAXSOCKBUF);
1839 SockList esl (MAXSOCKBUF);
1840
1841 sl << (socket.mapmode == Map1Cmd ? "map1 " : "map1a "); 1286 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1287 packet esl;
1288
1842 startlen = sl.len; 1289 startlen = sl.length ();
1843 1290
1844 /*Extendedmapinfo structure initialisation */ 1291 /*Extendedmapinfo structure initialisation */
1845 if (socket.ext_mapinfos) 1292 if (socket.ext_mapinfos)
1846 { 1293 {
1847 extendedinfos = EMI_NOREDRAW; 1294 extendedinfos = EMI_NOREDRAW;
1848 1295
1849 if (socket.EMI_smooth) 1296 if (socket.EMI_smooth)
1850 extendedinfos |= EMI_SMOOTH; 1297 extendedinfos |= EMI_SMOOTH;
1851 1298
1852 ewhatstart = esl.len; 1299 ewhatstart = esl.length ();
1853 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit 1300 ewhatflag = extendedinfos; /*The EMI_NOREDRAW bit
1854 could need to be taken away */ 1301 could need to be taken away */
1855 eentrysize = getExtendedMapInfoSize (&socket); 1302 eentrysize = getExtendedMapInfoSize (&socket);
1856 esl << "mapextended " 1303 esl << "mapextended "
1857 << uint8 (extendedinfos) 1304 << uint8 (extendedinfos)
1858 << uint8 (eentrysize); 1305 << uint8 (eentrysize);
1306
1859 estartlen = esl.len; 1307 estartlen = esl.length ();
1860 }
1861 else
1862 { 1308 }
1863 /* suppress compiler warnings */
1864 ewhatstart = 0;
1865 ewhatflag = 0;
1866 estartlen = 0;
1867 }
1868
1869 /* Init data to zero */
1870 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1871 1309
1872 /* x,y are the real map locations. ax, ay are viewport relative 1310 /* x,y are the real map locations. ax, ay are viewport relative
1873 * locations. 1311 * locations.
1874 */ 1312 */
1875 ay = 0; 1313 ay = 0;
… …
1878 * but that started to get a bit messy to look at. 1316 * but that started to get a bit messy to look at.
1879 */ 1317 */
1880 max_x = pl->x + (socket.mapx + 1) / 2; 1318 max_x = pl->x + (socket.mapx + 1) / 2;
1881 max_y = pl->y + (socket.mapy + 1) / 2; 1319 max_y = pl->y + (socket.mapy + 1) / 2;
1882 1320
1883 if (socket.mapmode == Map1aCmd) 1321 maptile *plmap = pl->map;
1884 {
1885 max_x += MAX_HEAD_OFFSET;
1886 max_y += MAX_HEAD_OFFSET;
1887 }
1888 1322
1889 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1323 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1890 { 1324 {
1891 ax = 0; 1325 ax = 0;
1892 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1326 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1893 { 1327 {
1894 1328 int emask, mask;
1895 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1329 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1896 1330
1897 /* If this space is out of the normal viewable area, we only check
1898 * the heads value ax or ay will only be greater than what
1899 * the client wants if using the map1a command - this is because
1900 * if the map1a command is not used, max_x and max_y will be
1901 * set to lower values.
1902 */
1903 if (ax >= socket.mapx || ay >= socket.mapy)
1904 {
1905 int i, got_one;
1906
1907 oldlen = sl.len;
1908
1909 sl << uint16 (mask);
1910
1911 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1912 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1913 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1914
1915 /* If all we are doing is sending 0 (blank) faces, we don't
1916 * actually need to send that - just the coordinates
1917 * with no faces tells the client to blank out the
1918 * space.
1919 */
1920 got_one = 0;
1921 for (i = oldlen + 2; i < sl.len; i++)
1922 if (sl.buf[i])
1923 got_one = 1;
1924
1925 if (got_one && (mask & 0xf))
1926 sl.buf[oldlen + 1] = mask & 0xff;
1927 else
1928 { /*either all faces blank, either no face at all */
1929 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1930 sl.len = oldlen + 2;
1931 else
1932 sl.len = oldlen;
1933 }
1934
1935 /*What concerns extendinfos, nothing to be done for now
1936 * (perhaps effects layer later)
1937 */
1938 continue; /* don't do processing below */
1939 }
1940
1941 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1331 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1942
1943 d = pl->contr->blocked_los[ax][ay];
1944 1332
1945 /* If the coordinates are not valid, or it is too dark to see, 1333 /* If the coordinates are not valid, or it is too dark to see,
1946 * we tell the client as such 1334 * we tell the client as such
1947 */ 1335 */
1948 nx = x; 1336 nx = x;
1949 ny = y; 1337 ny = y;
1950 m = get_map_from_coord (pl->map, &nx, &ny); 1338 m = get_map_from_coord (plmap, &nx, &ny);
1951 1339
1952 if (!m) 1340 if (!m)
1953 { 1341 {
1954 /* space is out of map. Update space and clear values 1342 /* space is out of map. Update space and clear values
1955 * if this hasn't already been done. If the space is out 1343 * if this hasn't already been done. If the space is out
1956 * of the map, it shouldn't have a head 1344 * of the map, it shouldn't have a head
1957 */ 1345 */
1958 if (lastcell.count != -1) 1346 if (lastcell.count != -1)
1959 { 1347 {
1960 sl << uint16 (mask); 1348 sl << uint16 (mask);
1961 map_clearcell (&lastcell, 0, 0, 0, -1); 1349 map_clearcell (&lastcell, -1);
1962 } 1350 }
1351
1352 continue;
1963 } 1353 }
1354
1355 m->touch ();
1356
1357 int d = pl->contr->blocked_los[ax][ay];
1358
1964 else if (d > 3) 1359 if (d > 3)
1965 { 1360 {
1361
1966 int need_send = 0, count; 1362 int need_send = 0, count;
1967 1363
1968 /* This block deals with spaces that are not visible for whatever 1364 /* This block deals with spaces that are not visible for whatever
1969 * reason. Still may need to send the head for this space. 1365 * reason. Still may need to send the head for this space.
1970 */ 1366 */
1971 1367
1972 oldlen = sl.len; 1368 oldlen = sl.length ();
1973 1369
1974 sl << uint16 (mask); 1370 sl << uint16 (mask);
1975 1371
1976 if (lastcell.count != -1) 1372 if (lastcell.count != -1)
1977 need_send = 1; 1373 need_send = 1;
1978 1374
1979 count = -1; 1375 count = -1;
1980 1376
1981 if (socket.mapmode == Map1aCmd && have_head (ax, ay)) 1377 /* properly clear a previously sent big face */
1982 { 1378 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1983 /* Now check to see if any heads need to be sent */ 1379 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1380 need_send = 1;
1984 1381
1985 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4; 1382 map_clearcell (&lastcell, count);
1986 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1987 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1988 1383
1989 lastcell.count = count; 1384 if ((mask & 0xf) || need_send)
1990 } 1385 sl[oldlen + 1] = mask & 0xff;
1991 else 1386 else
1992 {
1993 /* properly clear a previously sent big face */
1994 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0
1995 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1996 need_send = 1;
1997
1998 map_clearcell (&lastcell, 0, 0, 0, count);
1999 }
2000
2001 if ((mask & 0xf) || need_send)
2002 sl.buf[oldlen + 1] = mask & 0xff;
2003 else
2004 sl.len = oldlen; 1387 sl.reset (oldlen);
2005 } 1388 }
2006 else 1389 else
2007 { 1390 {
2008 /* In this block, the space is visible or there are head objects 1391 /* In this block, the space is visible.
2009 * we need to send.
2010 */ 1392 */
2011 1393
2012 /* Rather than try to figure out what everything that we might 1394 /* Rather than try to figure out what everything that we might
2013 * need to send is, then form the packet after that, 1395 * need to send is, then form the packet after that,
2014 * we presume that we will in fact form a packet, and update 1396 * we presume that we will in fact form a packet, and update
2015 * the bits by what we do actually send. If we send nothing, 1397 * the bits by what we do actually send. If we send nothing,
2016 * we just back out sl.len to the old value, and no harm 1398 * we just back out sl.length () to the old value, and no harm
2017 * is done. 1399 * is done.
2018 * I think this is simpler than doing a bunch of checks to see 1400 * I think this is simpler than doing a bunch of checks to see
2019 * what if anything we need to send, setting the bits, then 1401 * what if anything we need to send, setting the bits, then
2020 * doing those checks again to add the real data. 1402 * doing those checks again to add the real data.
2021 */ 1403 */
2022 oldlen = sl.len; 1404 oldlen = sl.length ();
2023 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
2024 eoldlen = esl.len; 1405 eoldlen = esl.length ();
2025 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1406
2026 sl << uint16 (mask); 1407 sl << uint16 (mask);
2027
2028 if (socket.ext_mapinfos)
2029 esl << uint16 (emask);
2030 1408
2031 unsigned char dummy; 1409 unsigned char dummy;
2032 unsigned char *last_ext = &dummy; 1410 unsigned char *last_ext = &dummy;
2033 1411
2034 /* Darkness changed */ 1412 /* Darkness changed */
… …
2037 mask |= 0x8; 1415 mask |= 0x8;
2038 1416
2039 if (socket.extmap) 1417 if (socket.extmap)
2040 { 1418 {
2041 *last_ext |= 0x80; 1419 *last_ext |= 0x80;
2042 last_ext = sl.buf + sl.len; 1420 last_ext = &sl[sl.length ()];
2043 sl << uint8 (d); 1421 sl << uint8 (d);
2044 } 1422 }
2045 else 1423 else
2046 sl << uint8 (255 - 64 * d); 1424 sl << uint8 (255 - 64 * d);
2047 } 1425 }
2048 1426
2049 lastcell.count = d; 1427 lastcell.count = d;
1428
1429 mapspace &ms = m->at (nx, ny);
2050 1430
2051 if (socket.extmap) 1431 if (socket.extmap)
2052 { 1432 {
2053 uint8 stat_hp = 0; 1433 uint8 stat_hp = 0;
2054 uint8 stat_width = 0; 1434 uint8 stat_width = 0;
2055 uint8 flags = 0; 1435 uint8 flags = 0;
2056 UUID player = 0; 1436 UUID player = 0;
2057 1437
2058 // send hp information, if applicable 1438 // send hp information, if applicable
2059 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1439 if (object *op = ms.faces_obj [0])
2060 { 1440 {
2061 if (op->head || op->invisible) 1441 if (op->head || op->invisible)
2062 ; // do not show 1442 ; // do not show
2063 else if (op->type == PLAYER 1443 else if (op->type == PLAYER
2064 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1444 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
… …
2081 { 1461 {
2082 lastcell.stat_hp = stat_hp; 1462 lastcell.stat_hp = stat_hp;
2083 1463
2084 mask |= 0x8; 1464 mask |= 0x8;
2085 *last_ext |= 0x80; 1465 *last_ext |= 0x80;
2086 last_ext = sl.buf + sl.len; 1466 last_ext = &sl[sl.length ()];
2087 1467
2088 sl << uint8 (5) << uint8 (stat_hp); 1468 sl << uint8 (5) << uint8 (stat_hp);
2089 1469
2090 if (stat_width > 1) 1470 if (stat_width > 1)
2091 { 1471 {
2092 *last_ext |= 0x80; 1472 *last_ext |= 0x80;
2093 last_ext = sl.buf + sl.len; 1473 last_ext = &sl[sl.length ()];
2094 1474
2095 sl << uint8 (6) << uint8 (stat_width); 1475 sl << uint8 (6) << uint8 (stat_width);
2096 } 1476 }
2097 } 1477 }
2098 1478
… …
2100 { 1480 {
2101 lastcell.player = player; 1481 lastcell.player = player;
2102 1482
2103 mask |= 0x8; 1483 mask |= 0x8;
2104 *last_ext |= 0x80; 1484 *last_ext |= 0x80;
2105 last_ext = sl.buf + sl.len; 1485 last_ext = &sl[sl.length ()];
2106 1486
2107 sl << uint8 (0x47) << uint8 (8) << (uint64)player; 1487 sl << uint8 (0x47) << uint8 (8) << (uint64)player;
2108 } 1488 }
2109 1489
2110 if (lastcell.flags != flags) 1490 if (lastcell.flags != flags)
2111 { 1491 {
2112 lastcell.flags = flags; 1492 lastcell.flags = flags;
2113 1493
2114 mask |= 0x8; 1494 mask |= 0x8;
2115 *last_ext |= 0x80; 1495 *last_ext |= 0x80;
2116 last_ext = sl.buf + sl.len; 1496 last_ext = &sl[sl.length ()];
2117 1497
2118 sl << uint8 (8) << uint8 (flags); 1498 sl << uint8 (8) << uint8 (flags);
2119 } 1499 }
2120 } 1500 }
2121 1501
2122 /* Floor face */ 1502 /* Floor face */
2123 if (update_space (sl, socket, m, nx, ny, ax, ay, 2)) 1503 if (update_space (sl, socket, ms, lastcell, 2))
2124 mask |= 0x4; 1504 mask |= 0x4;
2125 1505
2126 if (socket.EMI_smooth)
2127 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
2128 emask |= 0x4;
2129
2130 /* Middle face */ 1506 /* Middle face */
2131 if (update_space (sl, socket, m, nx, ny, ax, ay, 1)) 1507 if (update_space (sl, socket, ms, lastcell, 1))
2132 mask |= 0x2; 1508 mask |= 0x2;
2133 1509
2134 if (socket.EMI_smooth) 1510 if (ms.player () == pl
2135 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1)) 1511 && (pl->invisible & (pl->invisible < 50 ? 1 : 7)))
2136 emask |= 0x2;
2137
2138 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
2139 { 1512 {
1513 // force player to be visible to himself if invisible
2140 if (lastcell.faces[0] != pl->face->number) 1514 if (lastcell.faces[0] != pl->face)
2141 { 1515 {
2142 lastcell.faces[0] = pl->face->number; 1516 lastcell.faces[0] = pl->face;
1517
2143 mask |= 0x1; 1518 mask |= 0x1;
2144
2145 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
2146 esrv_send_face (&socket, pl->face->number, 0);
2147
2148 sl << uint16 (pl->face->number); 1519 sl << uint16 (pl->face);
1520
1521 socket.send_faces (pl);
2149 } 1522 }
2150 } 1523 }
2151 else
2152 {
2153 /* Top face */ 1524 /* Top face */
2154 if (update_space (sl, socket, m, nx, ny, ax, ay, 0)) 1525 else if (update_space (sl, socket, ms, lastcell, 0))
2155 mask |= 0x1; 1526 mask |= 0x1;
2156
2157 if (socket.EMI_smooth)
2158 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
2159 emask |= 0x1;
2160 } 1527
2161 1528
2162 /* Check to see if we are in fact sending anything for this 1529 /* Check to see if we are in fact sending anything for this
2163 * space by checking the mask. If so, update the mask. 1530 * space by checking the mask. If so, update the mask.
2164 * if not, reset the len to that from before adding the mask 1531 * if not, reset the len to that from before adding the mask
2165 * value, so we don't send those bits. 1532 * value, so we don't send those bits.
2166 */ 1533 */
2167 if (mask & 0xf) 1534 if (mask & 0xf)
2168 sl.buf[oldlen + 1] = mask & 0xff; 1535 sl[oldlen + 1] = mask & 0xff;
2169 else 1536 else
2170 sl.len = oldlen; 1537 sl.reset (oldlen);
2171 1538
1539 if (socket.ext_mapinfos)
1540 esl << uint16 (emask);
1541
1542 if (socket.EMI_smooth)
1543 {
1544 for (int layer = 2+1; layer--; )
1545 {
1546 object *ob = ms.faces_obj [layer];
1547
1548 // If there is no object for this space, or if the face for the object
1549 // is the blank face, set the smoothlevel to zero.
1550 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1551
1552 // We've gotten what face we want to use for the object. Now see if
1553 // if it has changed since we last sent it to the client.
1554 if (lastcell.smooth[layer] != smoothlevel)
1555 {
1556 lastcell.smooth[layer] = smoothlevel;
1557 esl << uint8 (smoothlevel);
1558 emask |= 1 << layer;
1559 }
1560 }
1561
2172 if (emask & 0xf) 1562 if (emask & 0xf)
2173 esl.buf[eoldlen + 1] = emask & 0xff; 1563 esl[eoldlen + 1] = emask & 0xff;
2174 else 1564 else
2175 esl.len = eoldlen; 1565 esl.reset (eoldlen);
1566 }
2176 } /* else this is a viewable space */ 1567 } /* else this is a viewable space */
2177 } /* for x loop */ 1568 } /* for x loop */
2178 } /* for y loop */ 1569 } /* for y loop */
2179 1570
2180 /* Verify that we in fact do need to send this */ 1571 /* Verify that we in fact do need to send this */
2181 if (socket.ext_mapinfos) 1572 if (socket.ext_mapinfos)
2182 { 1573 {
2183 if (!(sl.len > startlen || socket.sent_scroll)) 1574 if (!(sl.length () > startlen || socket.sent_scroll))
2184 { 1575 {
2185 /* No map data will follow, so don't say the client 1576 /* No map data will follow, so don't say the client
2186 * it doesn't need draw! 1577 * it doesn't need draw!
2187 */ 1578 */
2188 ewhatflag &= (~EMI_NOREDRAW); 1579 ewhatflag &= ~EMI_NOREDRAW;
2189 esl.buf[ewhatstart + 1] = ewhatflag & 0xff; 1580 esl[ewhatstart + 1] = ewhatflag & 0xff;
2190 } 1581 }
2191 1582
2192 if (esl.len > estartlen) 1583 if (esl.length () > estartlen)
2193 Send_With_Handling (&socket, &esl); 1584 socket.send_packet (esl);
2194 } 1585 }
2195 1586
2196 if (sl.len > startlen || socket.sent_scroll) 1587 if (sl.length () > startlen || socket.sent_scroll)
2197 { 1588 {
2198 Send_With_Handling (&socket, &sl); 1589 socket.send_packet (sl);
2199 socket.sent_scroll = 0; 1590 socket.sent_scroll = 0;
2200 } 1591 }
2201
2202 sl.free ();
2203 esl.free ();
2204} 1592}
2205 1593
2206/** 1594/**
2207 * Draws client map. 1595 * Draws client map.
2208 */ 1596 */
2209void 1597void
2210draw_client_map (object *pl) 1598draw_client_map (object *pl)
2211{ 1599{
2212 int i, j; 1600 int i, j;
2213 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */ 1601 sint16 ax, ay; /* ax and ay goes from 0 to max-size of arrays */
2214 New_Face *face, *floor;
2215 New_Face *floor2;
2216 int d, mflags; 1602 int mflags;
2217 struct Map newmap; 1603 struct Map newmap;
2218 maptile *m, *pm; 1604 maptile *m, *pm;
2219 1605
2220 if (pl->type != PLAYER) 1606 if (pl->type != PLAYER)
2221 { 1607 {
… …
2232 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY) 1618 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
2233 return; 1619 return;
2234 1620
2235 memset (&newmap, 0, sizeof (struct Map)); 1621 memset (&newmap, 0, sizeof (struct Map));
2236 1622
2237 for (j = (pl->y - pl->contr->socket.mapy / 2); j < (pl->y + (pl->contr->socket.mapy + 1) / 2); j++) 1623 for (j = (pl->y - pl->contr->ns->mapy / 2); j < (pl->y + (pl->contr->ns->mapy + 1) / 2); j++)
2238 {
2239 for (i = (pl->x - pl->contr->socket.mapx / 2); i < (pl->x + (pl->contr->socket.mapx + 1) / 2); i++) 1624 for (i = (pl->x - pl->contr->ns->mapx / 2); i < (pl->x + (pl->contr->ns->mapx + 1) / 2); i++)
2240 { 1625 {
2241 ax = i; 1626 ax = i;
2242 ay = j; 1627 ay = j;
2243 m = pm; 1628 m = pm;
2244 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay); 1629 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
1630
2245 if (mflags & P_OUT_OF_MAP) 1631 if (mflags & P_OUT_OF_MAP)
2246 continue; 1632 continue;
2247 if (mflags & P_NEED_UPDATE) 1633
2248 update_position (m, ax, ay);
2249 /* If a map is visible to the player, we don't want to swap it out 1634 /* If a map is visible to the player, we don't want to swap it out
2250 * just to reload it. This should really call something like 1635 * just to reload it. This should really call something like
2251 * swap_map, but this is much more efficient and 'good enough' 1636 * swap_map, but this is much more efficient and 'good enough'
2252 */ 1637 */
2253 if (mflags & P_NEW_MAP) 1638 if (mflags & P_NEW_MAP)
2254 m->timeout = 50; 1639 m->timeout = 50;
2255 } 1640 }
2256 } 1641
2257 /* do LOS after calls to update_position */ 1642 /* do LOS after calls to update_position */
2258 if (pl->contr->do_los) 1643 if (pl->contr->do_los)
2259 { 1644 {
2260 update_los (pl); 1645 update_los (pl);
2261 pl->contr->do_los = 0; 1646 pl->contr->do_los = 0;
2262 } 1647 }
2263 1648
2264 if (pl->contr->socket.mapmode == Map1Cmd || pl->contr->socket.mapmode == Map1aCmd)
2265 {
2266 /* Big maps need a different drawing mechanism to work */ 1649 /* Big maps need a different drawing mechanism to work */
2267 draw_client_map1 (pl); 1650 draw_client_map1 (pl);
2268 return;
2269 }
2270
2271 if (pl->invisible & (pl->invisible < 50 ? 4 : 1))
2272 {
2273 esrv_map_setbelow (&pl->contr->socket, pl->contr->socket.mapx / 2, pl->contr->socket.mapy / 2, pl->face->number, &newmap);
2274 }
2275
2276 /* j and i are the y and x coordinates of the real map (which is
2277 * basically some number of spaces around the player)
2278 * ax and ay are values from within the viewport (ie, 0, 0 is upper
2279 * left corner) and are thus disconnected from the map values.
2280 * Subtract 1 from the max values so that we properly handle cases where
2281 * player has specified an even map. Otherwise, we try to send them too
2282 * much, ie, if mapx is 10, we would try to send from -5 to 5, which is actually
2283 * 11 spaces. Now, we would send from -5 to 4, which is properly. If mapx is
2284 * odd, this still works fine.
2285 */
2286 ay = 0;
2287 for (j = pl->y - pl->contr->socket.mapy / 2; j <= pl->y + (pl->contr->socket.mapy - 1) / 2; j++, ay++)
2288 {
2289 ax = 0;
2290 for (i = pl->x - pl->contr->socket.mapx / 2; i <= pl->x + (pl->contr->socket.mapx - 1) / 2; i++, ax++)
2291 {
2292
2293 d = pl->contr->blocked_los[ax][ay];
2294 /* note the out_of_map and d>3 checks are both within the same
2295 * negation check.
2296 */
2297 nx = i;
2298 ny = j;
2299 m = get_map_from_coord (pm, &nx, &ny);
2300 if (m && d < 4)
2301 {
2302 face = GET_MAP_FACE (m, nx, ny, 0);
2303 floor2 = GET_MAP_FACE (m, nx, ny, 1);
2304 floor = GET_MAP_FACE (m, nx, ny, 2);
2305
2306 /* If all is blank, send a blank face. */
2307 if ((!face || face == blank_face) && (!floor2 || floor2 == blank_face) && (!floor || floor == blank_face))
2308 {
2309 esrv_map_setbelow (&pl->contr->socket, ax, ay, blank_face->number, &newmap);
2310 }
2311 else
2312 { /* actually have something interesting */
2313 /* send the darkness mask, if any. */
2314 if (d && pl->contr->socket.darkness)
2315 esrv_map_setbelow (&pl->contr->socket, ax, ay, dark_faces[d - 1]->number, &newmap);
2316
2317 if (face && face != blank_face)
2318 esrv_map_setbelow (&pl->contr->socket, ax, ay, face->number, &newmap);
2319 if (floor2 && floor2 != blank_face)
2320 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor2->number, &newmap);
2321 if (floor && floor != blank_face)
2322 esrv_map_setbelow (&pl->contr->socket, ax, ay, floor->number, &newmap);
2323 }
2324 } /* Is a valid space */
2325 }
2326 }
2327
2328 esrv_map_doneredraw (&pl->contr->socket, &newmap);
2329
2330 check_map_change (pl->contr);
2331} 1651}
2332 1652
2333 1653
2334/*****************************************************************************/ 1654/*****************************************************************************/
2335 1655
… …
2341 1661
2342/*****************************************************************************/ 1662/*****************************************************************************/
2343void 1663void
2344send_plugin_custom_message (object *pl, char *buf) 1664send_plugin_custom_message (object *pl, char *buf)
2345{ 1665{
2346 cs_write_string (&pl->contr->socket, buf, strlen (buf)); 1666 pl->contr->ns->send_packet (buf);
2347} 1667}
2348 1668
2349/** 1669/**
2350 * This sends the skill number to name mapping. We ignore 1670 * This sends the skill number to name mapping. We ignore
2351 * the params - we always send the same info no matter what. 1671 * the params - we always send the same info no matter what.
2352 */ 1672 */
2353void 1673void
2354send_skill_info (NewSocket *ns, char *params) 1674send_skill_info (client *ns, char *params)
2355{ 1675{
2356 SockList sl (MAXSOCKBUF); 1676 packet sl;
2357 sl << "replyinfo skill_info\n"; 1677 sl << "replyinfo skill_info\n";
2358 1678
2359 for (int i = 1; i < NUM_SKILLS; i++) 1679 for (int i = 1; i < NUM_SKILLS; i++)
2360 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1680 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
2361 1681
2362 if (sl.len >= MAXSOCKBUF) 1682 if (sl.length () >= MAXSOCKBUF)
2363 { 1683 {
2364 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1684 LOG (llevError, "Buffer overflow in send_skill_info!\n");
2365 fatal (0); 1685 fatal (0);
2366 } 1686 }
2367 1687
2368 Send_With_Handling (ns, &sl); 1688 ns->send_packet (sl);
2369 sl.free ();
2370} 1689}
2371 1690
2372/** 1691/**
2373 * This sends the spell path to name mapping. We ignore 1692 * This sends the spell path to name mapping. We ignore
2374 * the params - we always send the same info no matter what. 1693 * the params - we always send the same info no matter what.
2375 */ 1694 */
2376void 1695void
2377send_spell_paths (NewSocket * ns, char *params) 1696send_spell_paths (client * ns, char *params)
2378{ 1697{
2379 SockList sl (MAXSOCKBUF); 1698 packet sl;
2380 1699
2381 sl << "replyinfo spell_paths\n"; 1700 sl << "replyinfo spell_paths\n";
2382 1701
2383 for (int i = 0; i < NRSPELLPATHS; i++) 1702 for (int i = 0; i < NRSPELLPATHS; i++)
2384 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1703 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
2385 1704
2386 if (sl.len >= MAXSOCKBUF) 1705 if (sl.length () >= MAXSOCKBUF)
2387 { 1706 {
2388 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1707 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
2389 fatal (0); 1708 fatal (0);
2390 } 1709 }
2391 1710
2392 Send_With_Handling (ns, &sl); 1711 ns->send_packet (sl);
2393 sl.free ();
2394} 1712}
2395 1713
2396/** 1714/**
2397 * This looks for any spells the player may have that have changed their stats. 1715 * This looks for any spells the player may have that have changed their stats.
2398 * it then sends an updspell packet for each spell that has changed in this way 1716 * it then sends an updspell packet for each spell that has changed in this way
2399 */ 1717 */
2400void 1718void
2401esrv_update_spells (player *pl) 1719esrv_update_spells (player *pl)
2402{ 1720{
1721 if (!pl->ns)
1722 return;
1723
2403 if (!pl->socket.monitor_spells) 1724 if (!pl->ns->monitor_spells)
2404 return; 1725 return;
2405 1726
2406 for (object *spell = pl->ob->inv; spell; spell = spell->below) 1727 for (object *spell = pl->ob->inv; spell; spell = spell->below)
2407 { 1728 {
2408 if (spell->type == SPELL) 1729 if (spell->type == SPELL)
… …
2428 flags |= UPD_SP_DAMAGE; 1749 flags |= UPD_SP_DAMAGE;
2429 } 1750 }
2430 1751
2431 if (flags) 1752 if (flags)
2432 { 1753 {
2433 SockList sl (MAXSOCKBUF); 1754 packet sl;
2434 1755
2435 sl << "updspell " 1756 sl << "updspell "
2436 << uint8 (flags) 1757 << uint8 (flags)
2437 << uint32 (spell->count); 1758 << uint32 (spell->count);
2438 1759
2439 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1760 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp);
2440 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1761 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace);
2441 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1762 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat);
2442 1763
2443 Send_With_Handling (&pl->socket, &sl); 1764 pl->ns->send_packet (sl);
2444 sl.free ();
2445 } 1765 }
2446 } 1766 }
2447 } 1767 }
2448} 1768}
2449 1769
2450void 1770void
2451esrv_remove_spell (player *pl, object *spell) 1771esrv_remove_spell (player *pl, object *spell)
2452{ 1772{
2453 if (!pl->socket.monitor_spells) 1773 if (!pl->ns->monitor_spells)
2454 return; 1774 return;
2455 1775
2456 if (!pl || !spell || spell->env != pl->ob) 1776 if (!pl || !spell || spell->env != pl->ob)
2457 { 1777 {
2458 LOG (llevError, "Invalid call to esrv_remove_spell"); 1778 LOG (llevError, "Invalid call to esrv_remove_spell");
2459 return; 1779 return;
2460 } 1780 }
2461 1781
2462 SockList sl (MAXSOCKBUF); 1782 packet sl ("delspell");
2463 1783
2464 sl << "delspell "
2465 << uint32 (spell->count); 1784 sl << uint32 (spell->count);
2466 1785
2467 Send_With_Handling (&pl->socket, &sl); 1786 pl->ns->send_packet (sl);
2468 sl.free ();
2469} 1787}
2470 1788
2471/* appends the spell *spell to the Socklist we will send the data to. */ 1789/* appends the spell *spell to the Socklist we will send the data to. */
2472static void 1790static void
2473append_spell (player *pl, SockList &sl, object *spell) 1791append_spell (player *pl, packet &sl, object *spell)
2474{ 1792{
2475 int len, i, skill = 0; 1793 int i, skill = 0;
2476 1794
2477 if (!(spell->name)) 1795 if (!(spell->name))
2478 { 1796 {
2479 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1797 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2480 return; 1798 return;
… …
2492 if (!strcmp (spell->skill, skill_names[i])) 1810 if (!strcmp (spell->skill, skill_names[i]))
2493 { 1811 {
2494 skill = i + CS_STAT_SKILLINFO; 1812 skill = i + CS_STAT_SKILLINFO;
2495 break; 1813 break;
2496 } 1814 }
1815 }
1816
1817 // spells better have a face
1818 if (!spell->face)
1819 {
1820 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1821 spell->face = face_find ("burnout.x11", blank_face);
2497 } 1822 }
2498 1823
2499 /* send the current values */ 1824 /* send the current values */
2500 sl << uint32 (spell->count) 1825 sl << uint32 (spell->count)
2501 << uint16 (spell->level) 1826 << uint16 (spell->level)
… …
2503 << uint16 (spell->last_sp) 1828 << uint16 (spell->last_sp)
2504 << uint16 (spell->last_grace) 1829 << uint16 (spell->last_grace)
2505 << uint16 (spell->last_eat) 1830 << uint16 (spell->last_eat)
2506 << uint8 (skill) 1831 << uint8 (skill)
2507 << uint32 (spell->path_attuned) 1832 << uint32 (spell->path_attuned)
2508 << uint32 (spell->face ? spell->face->number : 0) 1833 << uint32 (spell->face)
2509 << data8 (spell->name) 1834 << data8 (spell->name)
2510 << data16 (spell->msg); 1835 << data16 (spell->msg);
2511} 1836}
2512 1837
2513/** 1838/**
… …
2521 { 1846 {
2522 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player"); 1847 LOG (llevError, "esrv_add_spells, tried to add a spell to a NULL player");
2523 return; 1848 return;
2524 } 1849 }
2525 1850
2526 if (!pl->socket.monitor_spells) 1851 if (!pl->ns->monitor_spells)
2527 return; 1852 return;
2528 1853
2529 SockList sl (MAXSOCKBUF); 1854 packet sl ("addspell");
2530
2531 sl << "addspell ";
2532 1855
2533 if (!spell) 1856 if (!spell)
2534 { 1857 {
2535 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 1858 for (spell = pl->ob->inv; spell; spell = spell->below)
2536 { 1859 {
2537 /* were we to simply keep appending data here, we could exceed 1860 /* were we to simply keep appending data here, we could exceed
2538 * MAXSOCKBUF if the player has enough spells to add, we know that 1861 * MAXSOCKBUF if the player has enough spells to add, we know that
2539 * append_spells will always append 19 data bytes, plus 4 length 1862 * append_spells will always append 19 data bytes, plus 4 length
2540 * bytes and 3 strings (because that is the spec) so we need to 1863 * bytes and 3 strings (because that is the spec) so we need to
… …
2548 * like it will fix this 1871 * like it will fix this
2549 */ 1872 */
2550 if (spell->type != SPELL) 1873 if (spell->type != SPELL)
2551 continue; 1874 continue;
2552 1875
2553 if (sl.len >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1876 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
2554 { 1877 {
2555 Send_With_Handling (&pl->socket, &sl); 1878 pl->ns->send_packet (sl);
2556 strcpy ((char *) sl.buf, "addspell "); 1879
2557 sl.len = strlen ((char *) sl.buf); 1880 sl.reset ();
1881 sl << "addspell ";
2558 } 1882 }
2559 1883
2560 append_spell (pl, sl, spell); 1884 append_spell (pl, sl, spell);
2561 } 1885 }
2562 } 1886 }
… …
2573 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1897 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
2574 fatal (0); 1898 fatal (0);
2575 } 1899 }
2576 1900
2577 /* finally, we can send the packet */ 1901 /* finally, we can send the packet */
2578 Send_With_Handling (&pl->socket, &sl); 1902 pl->ns->send_packet (sl);
2579
2580 sl.free ();
2581} 1903}
2582 1904

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines