ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.66 by root, Thu Feb 15 04:04:23 2007 UTC vs.
Revision 1.77 by root, Wed Mar 14 15:44:47 2007 UTC

… …
36 * have the prototype of (char *data, int datalen, int client_num). This 36 * have the prototype of (char *data, int datalen, int client_num). This
37 * way, we can use one dispatch table. 37 * way, we can use one dispatch table.
38 * 38 *
39 * esrv_map_new starts updating the map 39 * esrv_map_new starts updating the map
40 * 40 *
41 * esrv_map_setbelow allows filling in all of the faces for the map.
42 * if a face has not already been sent to the client, it is sent now.
43 *
44 */ 41 */
45 42
46#include <global.h> 43#include <global.h>
47#include <sproto.h> 44#include <sproto.h>
48 45
… …
100 * complexities for the client, and probably doesn't make 97 * complexities for the client, and probably doesn't make
101 * that much difference in bandwidth. 98 * that much difference in bandwidth.
102 */ 99 */
103 mx = ns->mapx; 100 mx = ns->mapx;
104 my = ns->mapy; 101 my = ns->mapy;
105
106 if (ns->mapmode == Map1aCmd)
107 {
108 mx += MAX_HEAD_OFFSET;
109 my += MAX_HEAD_OFFSET;
110 }
111 102
112 /* the x and y here are coordinates for the new map, i.e. if we moved 103 /* the x and y here are coordinates for the new map, i.e. if we moved
113 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 104 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
114 * if the destination x or y coordinate is outside the viewable 105 * if the destination x or y coordinate is outside the viewable
115 * area, we clear the values - otherwise, the old values 106 * area, we clear the values - otherwise, the old values
… …
440 } 431 }
441 else if (!strcmp (cmd, "newmapcmd")) 432 else if (!strcmp (cmd, "newmapcmd"))
442 { 433 {
443 ns->newmapcmd = atoi (param); 434 ns->newmapcmd = atoi (param);
444 safe_strcat (cmdback, param, &slen, HUGE_BUF); 435 safe_strcat (cmdback, param, &slen, HUGE_BUF);
445// } else if (!strcmp(cmd,"plugincmd")) {
446// ns->plugincmd = atoi(param);
447// safe_strcat(cmdback, param, &slen, HUGE_BUF);
448 } 436 }
449 else if (!strcmp (cmd, "mapinfocmd")) 437 else if (!strcmp (cmd, "mapinfocmd"))
450 { 438 {
451 ns->mapinfocmd = atoi (param); 439 ns->mapinfocmd = atoi (param);
452 safe_strcat (cmdback, "1", &slen, HUGE_BUF); 440 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
… …
471 char tmpbuf[20]; 459 char tmpbuf[20];
472 int q = atoi (param); 460 int q = atoi (param);
473 461
474 if (is_valid_faceset (q)) 462 if (is_valid_faceset (q))
475 ns->faceset = q; 463 ns->faceset = q;
464
476 sprintf (tmpbuf, "%d", ns->faceset); 465 sprintf (tmpbuf, "%d", ns->faceset);
477 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF); 466 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
478 /* if the client is using faceset, it knows about image2 command */ 467 /* if the client is using faceset, it knows about image2 command */
479 ns->image2 = 1; 468 ns->image2 = 1;
480 } 469 }
… …
508 if (*cp == 'x' || *cp == 'X') 497 if (*cp == 'x' || *cp == 'X')
509 { 498 {
510 y = atoi (cp + 1); 499 y = atoi (cp + 1);
511 break; 500 break;
512 } 501 }
502
513 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y) 503 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
514 { 504 {
515 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y); 505 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
516 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF); 506 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
517 } 507 }
… …
572 * This is what takes care of it. We tell the client how things worked out. 562 * This is what takes care of it. We tell the client how things worked out.
573 * I am not sure if this file is the best place for this function. however, 563 * I am not sure if this file is the best place for this function. however,
574 * it either has to be here or init_sockets needs to be exported. 564 * it either has to be here or init_sockets needs to be exported.
575 */ 565 */
576void 566void
577AddMeCmd (char *buf, int len, client * ns) 567AddMeCmd (char *buf, int len, client *ns)
578{ 568{
569 // face caching is mandatory
570 if (!ns->facecache)
571 {
572 ns->send_drawinfo (
573 "\n"
574 "\n"
575 "***\n"
576 "*** WARNING:\n"
577 "*** Your client does not support face/image caching,\n"
578 "*** or it has been disabled. Face caching is mandatory\n"
579 "*** so please enable it or use a newer client.\n"
580 "***\n"
581 "*** I will proceed as if face caching were enabled.\n"
582 "\n"
583 "***\n",
584 NDI_RED
585 );
586 //ns->facecache = true;
587 }
588
579 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len)); 589 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
580} 590}
581 591
582/** Reply to ExtendedInfos command */ 592/** Reply to ExtendedInfos command */
583void 593void
… …
694 704
695 ns->send_packet (cmdback); 705 ns->send_packet (cmdback);
696} 706}
697 707
698/** 708/**
699 * A lot like the old AskSmooth (in fact, now called by AskSmooth). 709 * client requested an image. send it rate-limited
700 * Basically, it makes no sense to wait for the client to request a 710 * before flushing.
701 * a piece of data from us that we know the client wants. So
702 * if we know the client wants it, might as well push it to the
703 * client.
704 */
705static void
706SendSmooth (client *ns, uint16 face)
707{
708 uint16 smoothface;
709
710 /* If we can't find a face, return and set it so we won't try to send this
711 * again.
712 */ 711 */
713 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface))) 712void
714 { 713AskFaceCmd (char *buf, int len, client *ns)
715 714{
716 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name); 715 ns->askface.push_back (atoi (buf));
717 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
718 return;
719 }
720
721 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
722 esrv_send_face (ns, smoothface, 0);
723
724 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
725
726 packet sl ("smooth");
727
728 sl << uint16 (face)
729 << uint16 (smoothface);
730
731 ns->send_packet (sl);
732} 716}
733 717
734 /** 718/**
735 * Tells client the picture it has to use 719 * Tells client the picture it has to use
736 * to smooth a picture number given as argument. 720 * to smooth a picture number given as argument.
737 */ 721 */
738void 722void
739AskSmooth (char *buf, int len, client *ns) 723AskSmooth (char *buf, int len, client *ns)
740{ 724{
741 SendSmooth (ns, atoi (buf)); 725 ns->send_face (atoi (buf));
742} 726}
743 727
744/** 728/**
745 * This handles the general commands from the client (ie, north, fire, cast, 729 * This handles the general commands from the client (ie, north, fire, cast,
746 * etc.) 730 * etc.)
… …
882 866
883 ns->cs_version = atoi (buf); 867 ns->cs_version = atoi (buf);
884 ns->sc_version = ns->cs_version; 868 ns->sc_version = ns->cs_version;
885 869
886 LOG (llevDebug, "connection from client <%s>\n", buf); 870 LOG (llevDebug, "connection from client <%s>\n", buf);
887
888 871
889 //TODO: should log here just for statistics 872 //TODO: should log here just for statistics
890 873
891 //if (VERSION_CS != ns->cs_version) 874 //if (VERSION_CS != ns->cs_version)
892 // unchecked; 875 // unchecked;
… …
1111{ 1094{
1112 packet sl ("player"); 1095 packet sl ("player");
1113 1096
1114 sl << uint32 (pl->ob->count) 1097 sl << uint32 (pl->ob->count)
1115 << uint32 (weight) 1098 << uint32 (weight)
1116 << uint32 (pl->ob->face->number) 1099 << uint32 (pl->ob->face)
1117 << data8 (pl->ob->name); 1100 << data8 (pl->ob->name);
1118 1101
1119 pl->ns->last_weight = weight; 1102 pl->ns->last_weight = weight;
1120 pl->ns->send_packet (sl); 1103 pl->ns->send_packet (sl);
1121 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 1104 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1122} 1105}
1123
1124/**
1125 * Need to send an animation sequence to the client.
1126 * We will send appropriate face commands to the client if we haven't
1127 * sent them the face yet (this can become quite costly in terms of
1128 * how much we are sending - on the other hand, this should only happen
1129 * when the player logs in and picks stuff up.
1130 */
1131void
1132esrv_send_animation (client * ns, short anim_num)
1133{
1134 /* Do some checking on the anim_num we got. Note that the animations
1135 * are added in contigous order, so if the number is in the valid
1136 * range, it must be a valid animation.
1137 */
1138 if (anim_num < 0 || anim_num > num_animations)
1139 {
1140 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1141 return;
1142 }
1143
1144 packet sl ("anim");
1145
1146 sl << uint16 (anim_num)
1147 << uint16 (0); /* flags - not used right now */
1148
1149 /* Build up the list of faces. Also, send any information (ie, the
1150 * the face itself) down to the client.
1151 */
1152 for (int i = 0; i < animations[anim_num].num_animations; i++)
1153 {
1154 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1155 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1156
1157 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1158 }
1159
1160 ns->send_packet (sl);
1161
1162 ns->anims_sent[anim_num] = 1;
1163}
1164
1165 1106
1166/****************************************************************************** 1107/******************************************************************************
1167 * 1108 *
1168 * Start of map related commands. 1109 * Start of map related commands.
1169 * 1110 *
1170 ******************************************************************************/ 1111 ******************************************************************************/
1171 1112
1172/**
1173 * This adds face_num to a map cell at x,y. If the client doesn't have
1174 * the face yet, we will also send it.
1175 */
1176static void
1177esrv_map_setbelow (client * ns, int x, int y, short face_num, struct Map *newmap)
1178{
1179 if (newmap->cells[x][y].count >= MAP_LAYERS)
1180 {
1181 //TODO: one or the other, can't both have abort and return, verify and act
1182 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1183 return;
1184 abort ();
1185 }
1186
1187 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1188 newmap->cells[x][y].count++;
1189
1190 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1191 esrv_send_face (ns, face_num, 0);
1192}
1193
1194/** Clears a map cell */ 1113/** Clears a map cell */
1195static void 1114static void
1196map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 1115map_clearcell (struct MapCell *cell, int count)
1197{ 1116{
1198 cell->faces[0] = face0; 1117 cell->faces[0] = 0;
1199 cell->faces[1] = face1; 1118 cell->faces[1] = 0;
1200 cell->faces[2] = face2; 1119 cell->faces[2] = 0;
1120 cell->smooth[0] = 0;
1121 cell->smooth[1] = 0;
1122 cell->smooth[2] = 0;
1201 cell->count = count; 1123 cell->count = count;
1202 cell->stat_hp = 0; 1124 cell->stat_hp = 0;
1203 cell->flags = 0; 1125 cell->flags = 0;
1204 cell->player = 0; 1126 cell->player = 0;
1205} 1127}
1206 1128
1207#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1208#define MAX_LAYERS 3 1129#define MAX_LAYERS 3
1209
1210/* Using a global really isn't a good approach, but saves the over head of
1211 * allocating and deallocating such a block of data each time run through,
1212 * and saves the space of allocating this in the socket object when we only
1213 * need it for this cycle. If the server is ever threaded, this needs to be
1214 * re-examined.
1215 */
1216static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1217
1218/**
1219 * Returns true if any of the heads for this
1220 * space is set. Returns false if all are blank - this is used
1221 * for empty space checking.
1222 */
1223static inline int
1224have_head (int ax, int ay)
1225{
1226 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1227 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1228 return 1;
1229
1230 return 0;
1231}
1232
1233/**
1234 * check_head is a bit simplistic version of update_space below.
1235 * basically, it only checks the that the head on space ax,ay at layer
1236 * needs to get sent - if so, it adds the data, sending the head
1237 * if needed, and returning 1. If this no data needs to get
1238 * sent, it returns zero.
1239 */
1240static int
1241check_head (packet &sl, client &ns, int ax, int ay, int layer)
1242{
1243 short face_num;
1244
1245 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1246 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1247 else
1248 face_num = 0;
1249
1250 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1251 {
1252 sl << uint16 (face_num);
1253 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1254 esrv_send_face (&ns, face_num, 0);
1255
1256 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1257 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1258 return 1;
1259 }
1260
1261 return 0; /* No change */
1262}
1263 1130
1264/** 1131/**
1265 * Removes the need to replicate the same code for each layer. 1132 * Removes the need to replicate the same code for each layer.
1266 * this returns true if this space is now in fact different than 1133 * this returns true if this space is now in fact different than
1267 * it was. 1134 * it was.
1268 * sl is the socklist this data is going into. 1135 * sl is the socklist this data is going into.
1269 * ns is the socket we are working on - all the info we care 1136 * ns is the socket we are working on - all the info we care
1270 * about is in this socket structure, so now need not pass the 1137 * about is in this socket structure, so now need not pass the
1271 * entire player object. 1138 * entire player object.
1272 * mx and my are map coordinate offsets for map mp
1273 * sx and sy are the offsets into the socket structure that
1274 * holds the old values.
1275 * layer is the layer to update, with 2 being the floor and 0 the 1139 * layer is the layer to update, with 2 being the floor and 0 the
1276 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ) 1140 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ)
1277 * take. Interesting to note that before this function, the map1 function 1141 * take. Interesting to note that before this function, the map1 function
1278 * numbers the spaces differently - I think this was a leftover from 1142 * numbers the spaces differently - I think this was a leftover from
1279 * the map command, where the faces stack up. Sinces that is no longer 1143 * the map command, where the faces stack up. Sinces that is no longer
1280 * the case, it seems to make more sense to have these layer values 1144 * the case, it seems to make more sense to have these layer values
1281 * actually match. 1145 * actually match.
1282 */ 1146 */
1283static int 1147static int
1284update_space (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 1148update_space (packet &sl, client &ns, mapspace &ms, MapCell &lastcell, int layer)
1285{ 1149{
1286 object *ob, *head; 1150 object *ob = ms.faces_obj [layer];
1287 uint16 face_num;
1288 int bx, by, i;
1289
1290 /* If there is a multipart object stored away, treat that as more important.
1291 * If not, then do the normal processing.
1292 */
1293 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1294
1295 /* Check to see if this head is part of the set of objects
1296 * we would normally send for this space. If so, then
1297 * don't use the head value. We need to do the check
1298 * here and not when setting up the heads[] value for two reasons -
1299 * 1) the heads[] values will get used even if the space is not visible.
1300 * 2) its possible the head is not on the same map as a part, and I'd
1301 * rather not need to do the map translation overhead.
1302 * 3) We need to do some extra checking to make sure that we will
1303 * otherwise send the image as this layer, eg, either it matches
1304 * the head value, or is not multipart.
1305 */
1306 if (head && !head->more)
1307 {
1308 for (i = 0; i < MAP_LAYERS; i++)
1309 {
1310 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1311 if (!ob)
1312 continue;
1313
1314 if (ob->head)
1315 ob = ob->head;
1316
1317 if (ob == head)
1318 {
1319 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1320 head = NULL;
1321 break;
1322 }
1323 }
1324 }
1325
1326 ob = head;
1327 if (!ob)
1328 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1329 1151
1330 /* If there is no object for this space, or if the face for the object 1152 /* If there is no object for this space, or if the face for the object
1331 * is the blank face, set the face number to zero. 1153 * is the blank face, set the face number to zero.
1332 * else if we have the stored head object for this space, that takes 1154 * else if we have the stored head object for this space, that takes
1333 * precedence over the other object for this space. 1155 * precedence over the other object for this space.
1334 * otherwise, we do special head processing 1156 * otherwise, we do special head processing
1335 */ 1157 */
1336 if (!ob || ob->face == blank_face) 1158 uint16 face_num = ob && ob->face != blank_face ? ob->face : 0;
1337 face_num = 0;
1338 else if (head)
1339 {
1340 /* if this is a head that had previously been stored */
1341 face_num = ob->face->number;
1342 }
1343 else
1344 {
1345 /* if the faces for the different parts of a multipart object
1346 * are the same, we only want to send the bottom right most
1347 * portion of the object. That info is in the tail_.. values
1348 * of the head. Note that for the head itself, ob->head will
1349 * be null, so we only do this block if we are working on
1350 * a tail piece.
1351 */
1352
1353 /* tail_x and tail_y will only be set in the head object. If
1354 * this is the head object and these are set, we proceed
1355 * with logic to only send bottom right. Similarly, if
1356 * this is one of the more parts but the head has those values
1357 * set, we want to do the processing. There can be cases where
1358 * the head is not visible but one of its parts is, so we just
1359 * can always expect that ob->arch->tail_x will be true for all
1360 * object we may want to display.
1361 */
1362 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1363 {
1364
1365 if (ob->head)
1366 head = ob->head;
1367 else
1368 head = ob;
1369
1370 /* Basically figure out where the offset is from where we are right
1371 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1372 * piece is from the head, and the tail is where the tail is from the
1373 * head. Note that bx and by will equal sx and sy if we are already working
1374 * on the bottom right corner. If ob is the head, the clone values
1375 * will be zero, so the right thing will still happen.
1376 */
1377 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1378 by = sy + head->arch->tail_y - ob->arch->clone.y;
1379
1380 /* I don't think this can ever happen, but better to check for it just
1381 * in case.
1382 */
1383 if (bx < sx || by < sy)
1384 {
1385 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1386 face_num = 0;
1387 }
1388 /* single part object, multipart object with non merged faces,
1389 * of multipart object already at lower right.
1390 */
1391 else if (bx == sx && by == sy)
1392 {
1393 face_num = ob->face->number;
1394
1395 /* if this face matches one stored away, clear that one away.
1396 * this code relies on the fact that the map1 commands
1397 * goes from 2 down to 0.
1398 */
1399 for (i = 0; i < MAP_LAYERS; i++)
1400 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1401 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1402 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1403 }
1404 else
1405 {
1406 /* If this head is stored away, clear it - otherwise,
1407 * there can be cases where a object is on multiple layers -
1408 * we only want to send it once.
1409 */
1410 face_num = head->face->number;
1411 for (i = 0; i < MAP_LAYERS; i++)
1412 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1413 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1414 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1415
1416 /* First, try to put the new head on the same layer. If that is used up,
1417 * then find another layer.
1418 */
1419 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1420 {
1421 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1422 }
1423 else
1424 for (i = 0; i < MAX_LAYERS; i++)
1425 {
1426 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1427 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1428 {
1429 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1430 }
1431 }
1432 face_num = 0; /* Don't send this object - we'll send the head later */
1433 }
1434 }
1435 else
1436 {
1437 /* In this case, we are already at the lower right or single part object,
1438 * so nothing special
1439 */
1440 face_num = ob->face->number;
1441
1442 /* clear out any head entries that have the same face as this one */
1443 for (bx = 0; bx < layer; bx++)
1444 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1445 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1446 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1447 }
1448 } /* else not already head object or blank face */
1449
1450 /* This is a real hack. Basically, if we have nothing to send for this layer,
1451 * but there is a head on the next layer, send that instead.
1452 * Without this, what happens is you can get the case where the player stands
1453 * on the same space as the head. However, if you have overlapping big objects
1454 * of the same type, what happens then is it doesn't think it needs to send
1455 * This tends to make stacking also work/look better.
1456 */
1457 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1458 {
1459 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1460 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1461 }
1462
1463 /* Another hack - because of heads and whatnot, this face may match one
1464 * we already sent for a lower layer. In that case, don't send
1465 * this one.
1466 */
1467 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1468 face_num = 0;
1469 1159
1470 /* We've gotten what face we want to use for the object. Now see if 1160 /* We've gotten what face we want to use for the object. Now see if
1471 * if it has changed since we last sent it to the client. 1161 * if it has changed since we last sent it to the client.
1472 */ 1162 */
1473 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num) 1163 if (lastcell.faces[layer] != face_num)
1474 { 1164 {
1475 ns.lastmap.cells[sx][sy].faces[layer] = face_num; 1165 lastcell.faces[layer] = face_num;
1166
1476 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 1167 if (!ns.faces_sent[face_num])
1168 if (ob)
1169 ns.send_faces (ob);
1170 else
1477 esrv_send_face (&ns, face_num, 0); 1171 ns.send_face (face_num);
1478 1172
1479 sl << uint16 (face_num); 1173 sl << uint16 (face_num);
1480 return 1;
1481 }
1482
1483 /* Nothing changed */
1484 return 0;
1485}
1486
1487/**
1488 * This function is mainly a copy of update_space,
1489 * except it handles update of the smoothing updates,
1490 * not the face updates.
1491 * Removes the need to replicate the same code for each layer.
1492 * this returns true if this smooth is now in fact different
1493 * than it was.
1494 * sl is the socklist this data is going into.
1495 * ns is the socket we are working on - all the info we care
1496 * about is in this socket structure, so know need to pass the
1497 * entire player object.
1498 * mx and my are map coordinate offsets for map mp
1499 * sx and sy are the offsets into the socket structure that
1500 * holds the old values.
1501 * layer is the layer to update, with 2 being the floor and 0 the
1502 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1503 * take.
1504 */
1505
1506static inline int
1507update_smooth (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1508{
1509 object *ob;
1510 int smoothlevel; /* old face_num; */
1511
1512 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1513
1514 /* If there is no object for this space, or if the face for the object
1515 * is the blank face, set the smoothlevel to zero.
1516 */
1517 if (!ob || ob->face == blank_face)
1518 smoothlevel = 0;
1519 else
1520 {
1521 smoothlevel = ob->smoothlevel;
1522 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1523 SendSmooth (&ns, ob->face->number);
1524 } /* else not already head object or blank face */
1525
1526 /* We've gotten what face we want to use for the object. Now see if
1527 * if it has changed since we last sent it to the client.
1528 */
1529 if (smoothlevel > 255)
1530 smoothlevel = 255;
1531 else if (smoothlevel < 0)
1532 smoothlevel = 0;
1533
1534 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1535 {
1536 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1537 sl << uint8 (smoothlevel);
1538 return 1; 1174 return 1;
1539 } 1175 }
1540 1176
1541 /* Nothing changed */ 1177 /* Nothing changed */
1542 return 0; 1178 return 0;
… …
1606 * look like. 1242 * look like.
1607 */ 1243 */
1608void 1244void
1609draw_client_map1 (object *pl) 1245draw_client_map1 (object *pl)
1610{ 1246{
1611 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1247 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1612 sint16 nx, ny; 1248 sint16 nx, ny;
1613 int estartlen, eoldlen; 1249 int estartlen, eoldlen;
1614 uint16 mask, emask;
1615 uint8 eentrysize; 1250 uint8 eentrysize;
1616 uint16 ewhatstart, ewhatflag; 1251 uint16 ewhatstart, ewhatflag;
1617 uint8 extendedinfos; 1252 uint8 extendedinfos;
1618 maptile *m; 1253 maptile *m;
1619 1254
… …
1646 << uint8 (extendedinfos) 1281 << uint8 (extendedinfos)
1647 << uint8 (eentrysize); 1282 << uint8 (eentrysize);
1648 1283
1649 estartlen = esl.length (); 1284 estartlen = esl.length ();
1650 } 1285 }
1651 else
1652 {
1653 /* suppress compiler warnings */
1654 ewhatstart = 0;
1655 ewhatflag = 0;
1656 estartlen = 0;
1657 }
1658
1659 /* Init data to zero */
1660 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1661 1286
1662 /* x,y are the real map locations. ax, ay are viewport relative 1287 /* x,y are the real map locations. ax, ay are viewport relative
1663 * locations. 1288 * locations.
1664 */ 1289 */
1665 ay = 0; 1290 ay = 0;
… …
1668 * but that started to get a bit messy to look at. 1293 * but that started to get a bit messy to look at.
1669 */ 1294 */
1670 max_x = pl->x + (socket.mapx + 1) / 2; 1295 max_x = pl->x + (socket.mapx + 1) / 2;
1671 max_y = pl->y + (socket.mapy + 1) / 2; 1296 max_y = pl->y + (socket.mapy + 1) / 2;
1672 1297
1673 if (socket.mapmode == Map1aCmd) 1298 maptile *plmap = pl->map;
1674 {
1675 max_x += MAX_HEAD_OFFSET;
1676 max_y += MAX_HEAD_OFFSET;
1677 }
1678 1299
1679 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1300 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1680 { 1301 {
1681 ax = 0; 1302 ax = 0;
1682 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1303 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1683 { 1304 {
1305 int emask, mask;
1684 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1306 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1685 1307
1686 /* If this space is out of the normal viewable area, we only check
1687 * the heads value ax or ay will only be greater than what
1688 * the client wants if using the map1a command - this is because
1689 * if the map1a command is not used, max_x and max_y will be
1690 * set to lower values.
1691 */
1692 if (ax >= socket.mapx || ay >= socket.mapy)
1693 {
1694 int i, got_one;
1695
1696 oldlen = sl.length ();
1697
1698 sl << uint16 (mask);
1699
1700 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1701 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1702 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1703
1704 /* If all we are doing is sending 0 (blank) faces, we don't
1705 * actually need to send that - just the coordinates
1706 * with no faces tells the client to blank out the
1707 * space.
1708 */
1709 got_one = 0;
1710 for (i = oldlen + 2; i < sl.length (); i++)
1711 if (sl[i])
1712 got_one = 1;
1713
1714 if (got_one && (mask & 0xf))
1715 sl[oldlen + 1] = mask & 0xff;
1716 else
1717 { /*either all faces blank, either no face at all */
1718 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1719 sl.reset (oldlen + 2);
1720 else
1721 sl.reset (oldlen);
1722 }
1723
1724 /*What concerns extendinfos, nothing to be done for now
1725 * (perhaps effects layer later)
1726 */
1727 continue; /* don't do processing below */
1728 }
1729
1730 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1308 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1731
1732 d = pl->contr->blocked_los[ax][ay];
1733 1309
1734 /* If the coordinates are not valid, or it is too dark to see, 1310 /* If the coordinates are not valid, or it is too dark to see,
1735 * we tell the client as such 1311 * we tell the client as such
1736 */ 1312 */
1737 nx = x; 1313 nx = x;
1738 ny = y; 1314 ny = y;
1739 m = get_map_from_coord (pl->map, &nx, &ny); 1315 m = get_map_from_coord (plmap, &nx, &ny);
1740 1316
1741 if (!m) 1317 if (!m)
1742 { 1318 {
1743 /* space is out of map. Update space and clear values 1319 /* space is out of map. Update space and clear values
1744 * if this hasn't already been done. If the space is out 1320 * if this hasn't already been done. If the space is out
1745 * of the map, it shouldn't have a head 1321 * of the map, it shouldn't have a head
1746 */ 1322 */
1747 if (lastcell.count != -1) 1323 if (lastcell.count != -1)
1748 { 1324 {
1749 sl << uint16 (mask); 1325 sl << uint16 (mask);
1750 map_clearcell (&lastcell, 0, 0, 0, -1); 1326 map_clearcell (&lastcell, -1);
1751 } 1327 }
1328
1329 continue;
1752 } 1330 }
1331
1332 m->touch ();
1333
1334 int d = pl->contr->blocked_los[ax][ay];
1335
1753 else if (d > 3) 1336 if (d > 3)
1754 { 1337 {
1755 m->touch ();
1756 1338
1757 int need_send = 0, count; 1339 int need_send = 0, count;
1758 1340
1759 /* This block deals with spaces that are not visible for whatever 1341 /* This block deals with spaces that are not visible for whatever
1760 * reason. Still may need to send the head for this space. 1342 * reason. Still may need to send the head for this space.
1761 */ 1343 */
1762 1344
1763 oldlen = sl.length (); 1345 oldlen = sl.length ();
1764 1346
1765 sl << uint16 (mask); 1347 sl << uint16 (mask);
… …
1767 if (lastcell.count != -1) 1349 if (lastcell.count != -1)
1768 need_send = 1; 1350 need_send = 1;
1769 1351
1770 count = -1; 1352 count = -1;
1771 1353
1772 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
1773 {
1774 /* Now check to see if any heads need to be sent */
1775
1776 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1777 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1778 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1779
1780 lastcell.count = count;
1781 }
1782 else
1783 {
1784 /* properly clear a previously sent big face */ 1354 /* properly clear a previously sent big face */
1785 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0 1355 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1786 || lastcell.stat_hp || lastcell.flags || lastcell.player) 1356 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1787 need_send = 1; 1357 need_send = 1;
1788 1358
1789 map_clearcell (&lastcell, 0, 0, 0, count); 1359 map_clearcell (&lastcell, count);
1790 }
1791 1360
1792 if ((mask & 0xf) || need_send) 1361 if ((mask & 0xf) || need_send)
1793 sl[oldlen + 1] = mask & 0xff; 1362 sl[oldlen + 1] = mask & 0xff;
1794 else 1363 else
1795 sl.reset (oldlen); 1364 sl.reset (oldlen);
1796 } 1365 }
1797 else 1366 else
1798 { 1367 {
1799 m->touch ();
1800
1801 /* In this block, the space is visible or there are head objects 1368 /* In this block, the space is visible.
1802 * we need to send.
1803 */ 1369 */
1804 1370
1805 /* Rather than try to figure out what everything that we might 1371 /* Rather than try to figure out what everything that we might
1806 * need to send is, then form the packet after that, 1372 * need to send is, then form the packet after that,
1807 * we presume that we will in fact form a packet, and update 1373 * we presume that we will in fact form a packet, and update
… …
1810 * is done. 1376 * is done.
1811 * I think this is simpler than doing a bunch of checks to see 1377 * I think this is simpler than doing a bunch of checks to see
1812 * what if anything we need to send, setting the bits, then 1378 * what if anything we need to send, setting the bits, then
1813 * doing those checks again to add the real data. 1379 * doing those checks again to add the real data.
1814 */ 1380 */
1815 oldlen = sl.length (); 1381 oldlen = sl.length ();
1816 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1817 eoldlen = esl.length (); 1382 eoldlen = esl.length ();
1818 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1383
1819 sl << uint16 (mask); 1384 sl << uint16 (mask);
1820
1821 if (socket.ext_mapinfos)
1822 esl << uint16 (emask);
1823 1385
1824 unsigned char dummy; 1386 unsigned char dummy;
1825 unsigned char *last_ext = &dummy; 1387 unsigned char *last_ext = &dummy;
1826 1388
1827 /* Darkness changed */ 1389 /* Darkness changed */
… …
1839 sl << uint8 (255 - 64 * d); 1401 sl << uint8 (255 - 64 * d);
1840 } 1402 }
1841 1403
1842 lastcell.count = d; 1404 lastcell.count = d;
1843 1405
1406 mapspace &ms = m->at (nx, ny);
1407
1844 if (socket.extmap) 1408 if (socket.extmap)
1845 { 1409 {
1846 uint8 stat_hp = 0; 1410 uint8 stat_hp = 0;
1847 uint8 stat_width = 0; 1411 uint8 stat_width = 0;
1848 uint8 flags = 0; 1412 uint8 flags = 0;
1849 UUID player = 0; 1413 UUID player = 0;
1850 1414
1851 // send hp information, if applicable 1415 // send hp information, if applicable
1852 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1416 if (object *op = ms.faces_obj [0])
1853 { 1417 {
1854 if (op->head || op->invisible) 1418 if (op->head || op->invisible)
1855 ; // do not show 1419 ; // do not show
1856 else if (op->type == PLAYER 1420 else if (op->type == PLAYER
1857 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1421 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
… …
1911 sl << uint8 (8) << uint8 (flags); 1475 sl << uint8 (8) << uint8 (flags);
1912 } 1476 }
1913 } 1477 }
1914 1478
1915 /* Floor face */ 1479 /* Floor face */
1916 if (update_space (sl, socket, m, nx, ny, ax, ay, 2)) 1480 if (update_space (sl, socket, ms, lastcell, 2))
1917 mask |= 0x4; 1481 mask |= 0x4;
1918 1482
1919 if (socket.EMI_smooth)
1920 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
1921 emask |= 0x4;
1922
1923 /* Middle face */ 1483 /* Middle face */
1924 if (update_space (sl, socket, m, nx, ny, ax, ay, 1)) 1484 if (update_space (sl, socket, ms, lastcell, 1))
1925 mask |= 0x2; 1485 mask |= 0x2;
1926 1486
1927 if (socket.EMI_smooth) 1487 if (ms.player () == pl
1928 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1)) 1488 && (pl->invisible & (pl->invisible < 50 ? 1 : 7)))
1929 emask |= 0x2;
1930
1931 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
1932 { 1489 {
1490 // force player to be visible to himself if invisible
1933 if (lastcell.faces[0] != pl->face->number) 1491 if (lastcell.faces[0] != pl->face)
1934 { 1492 {
1935 lastcell.faces[0] = pl->face->number; 1493 lastcell.faces[0] = pl->face;
1494
1936 mask |= 0x1; 1495 mask |= 0x1;
1937
1938 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
1939 esrv_send_face (&socket, pl->face->number, 0);
1940
1941 sl << uint16 (pl->face->number); 1496 sl << uint16 (pl->face);
1497
1498 socket.send_faces (pl);
1942 } 1499 }
1943 } 1500 }
1944 else
1945 {
1946 /* Top face */ 1501 /* Top face */
1947 if (update_space (sl, socket, m, nx, ny, ax, ay, 0)) 1502 else if (update_space (sl, socket, ms, lastcell, 0))
1948 mask |= 0x1; 1503 mask |= 0x1;
1949
1950 if (socket.EMI_smooth)
1951 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
1952 emask |= 0x1;
1953 } 1504
1954 1505
1955 /* Check to see if we are in fact sending anything for this 1506 /* Check to see if we are in fact sending anything for this
1956 * space by checking the mask. If so, update the mask. 1507 * space by checking the mask. If so, update the mask.
1957 * if not, reset the len to that from before adding the mask 1508 * if not, reset the len to that from before adding the mask
1958 * value, so we don't send those bits. 1509 * value, so we don't send those bits.
… …
1960 if (mask & 0xf) 1511 if (mask & 0xf)
1961 sl[oldlen + 1] = mask & 0xff; 1512 sl[oldlen + 1] = mask & 0xff;
1962 else 1513 else
1963 sl.reset (oldlen); 1514 sl.reset (oldlen);
1964 1515
1516 if (socket.ext_mapinfos)
1517 esl << uint16 (emask);
1518
1519 if (socket.EMI_smooth)
1520 {
1521 for (int layer = 2+1; layer--; )
1522 {
1523 object *ob = ms.faces_obj [layer];
1524
1525 // If there is no object for this space, or if the face for the object
1526 // is the blank face, set the smoothlevel to zero.
1527 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1528
1529 // We've gotten what face we want to use for the object. Now see if
1530 // if it has changed since we last sent it to the client.
1531 if (lastcell.smooth[layer] != smoothlevel)
1532 {
1533 lastcell.smooth[layer] = smoothlevel;
1534 esl << uint8 (smoothlevel);
1535 emask |= 1 << layer;
1536 }
1537 }
1538
1965 if (emask & 0xf) 1539 if (emask & 0xf)
1966 esl[eoldlen + 1] = emask & 0xff; 1540 esl[eoldlen + 1] = emask & 0xff;
1967 else 1541 else
1968 esl.reset (eoldlen); 1542 esl.reset (eoldlen);
1543 }
1969 } /* else this is a viewable space */ 1544 } /* else this is a viewable space */
1970 } /* for x loop */ 1545 } /* for x loop */
1971 } /* for y loop */ 1546 } /* for y loop */
1972 1547
1973 /* Verify that we in fact do need to send this */ 1548 /* Verify that we in fact do need to send this */
… …
1976 if (!(sl.length () > startlen || socket.sent_scroll)) 1551 if (!(sl.length () > startlen || socket.sent_scroll))
1977 { 1552 {
1978 /* No map data will follow, so don't say the client 1553 /* No map data will follow, so don't say the client
1979 * it doesn't need draw! 1554 * it doesn't need draw!
1980 */ 1555 */
1981 ewhatflag &= (~EMI_NOREDRAW); 1556 ewhatflag &= ~EMI_NOREDRAW;
1982 esl[ewhatstart + 1] = ewhatflag & 0xff; 1557 esl[ewhatstart + 1] = ewhatflag & 0xff;
1983 } 1558 }
1984 1559
1985 if (esl.length () > estartlen) 1560 if (esl.length () > estartlen)
1986 socket.send_packet (esl); 1561 socket.send_packet (esl);
… …
1998 */ 1573 */
1999void 1574void
2000draw_client_map (object *pl) 1575draw_client_map (object *pl)
2001{ 1576{
2002 int i, j; 1577 int i, j;
2003 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */ 1578 sint16 ax, ay; /* ax and ay goes from 0 to max-size of arrays */
2004 facetile *face, *floor;
2005 facetile *floor2;
2006 int d, mflags; 1579 int mflags;
2007 struct Map newmap; 1580 struct Map newmap;
2008 maptile *m, *pm; 1581 maptile *m, *pm;
2009 1582
2010 if (pl->type != PLAYER) 1583 if (pl->type != PLAYER)
2011 { 1584 {
… …
2192 1765
2193/* appends the spell *spell to the Socklist we will send the data to. */ 1766/* appends the spell *spell to the Socklist we will send the data to. */
2194static void 1767static void
2195append_spell (player *pl, packet &sl, object *spell) 1768append_spell (player *pl, packet &sl, object *spell)
2196{ 1769{
2197 int len, i, skill = 0; 1770 int i, skill = 0;
2198 1771
2199 if (!(spell->name)) 1772 if (!(spell->name))
2200 { 1773 {
2201 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1774 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2202 return; 1775 return;
… …
2214 if (!strcmp (spell->skill, skill_names[i])) 1787 if (!strcmp (spell->skill, skill_names[i]))
2215 { 1788 {
2216 skill = i + CS_STAT_SKILLINFO; 1789 skill = i + CS_STAT_SKILLINFO;
2217 break; 1790 break;
2218 } 1791 }
1792 }
1793
1794 // spells better have a face
1795 if (!spell->face)
1796 {
1797 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1798 spell->face = face_find ("burnout.x11", blank_face);
2219 } 1799 }
2220 1800
2221 /* send the current values */ 1801 /* send the current values */
2222 sl << uint32 (spell->count) 1802 sl << uint32 (spell->count)
2223 << uint16 (spell->level) 1803 << uint16 (spell->level)
… …
2225 << uint16 (spell->last_sp) 1805 << uint16 (spell->last_sp)
2226 << uint16 (spell->last_grace) 1806 << uint16 (spell->last_grace)
2227 << uint16 (spell->last_eat) 1807 << uint16 (spell->last_eat)
2228 << uint8 (skill) 1808 << uint8 (skill)
2229 << uint32 (spell->path_attuned) 1809 << uint32 (spell->path_attuned)
2230 << uint32 (spell->face ? spell->face->number : 0) 1810 << uint32 (spell->face)
2231 << data8 (spell->name) 1811 << data8 (spell->name)
2232 << data16 (spell->msg); 1812 << data16 (spell->msg);
2233} 1813}
2234 1814
2235/** 1815/**
… …
2250 1830
2251 packet sl ("addspell"); 1831 packet sl ("addspell");
2252 1832
2253 if (!spell) 1833 if (!spell)
2254 { 1834 {
2255 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 1835 for (spell = pl->ob->inv; spell; spell = spell->below)
2256 { 1836 {
2257 /* were we to simply keep appending data here, we could exceed 1837 /* were we to simply keep appending data here, we could exceed
2258 * MAXSOCKBUF if the player has enough spells to add, we know that 1838 * MAXSOCKBUF if the player has enough spells to add, we know that
2259 * append_spells will always append 19 data bytes, plus 4 length 1839 * append_spells will always append 19 data bytes, plus 4 length
2260 * bytes and 3 strings (because that is the spec) so we need to 1840 * bytes and 3 strings (because that is the spec) so we need to

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines