ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.56 by root, Mon Jan 1 12:28:47 2007 UTC vs.
Revision 1.83 by root, Mon Apr 2 18:04:47 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel 5 * Copyright (C) 2001 Mark Wedel
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The author can be reached via e-mail to <crossfire@schmorp.de> 22 * The author can be reached via e-mail to <crossfire@schmorp.de>
22*/ 23 */
23 24
24/** 25/**
25 * \file 26 * \file
26 * Client handling. 27 * Client handling.
27 * 28 *
35 * have the prototype of (char *data, int datalen, int client_num). This 36 * have the prototype of (char *data, int datalen, int client_num). This
36 * way, we can use one dispatch table. 37 * way, we can use one dispatch table.
37 * 38 *
38 * esrv_map_new starts updating the map 39 * esrv_map_new starts updating the map
39 * 40 *
40 * esrv_map_setbelow allows filling in all of the faces for the map.
41 * if a face has not already been sent to the client, it is sent now.
42 *
43 */ 41 */
44 42
45#include <global.h> 43#include <global.h>
46#include <sproto.h> 44#include <sproto.h>
47 45
100 * that much difference in bandwidth. 98 * that much difference in bandwidth.
101 */ 99 */
102 mx = ns->mapx; 100 mx = ns->mapx;
103 my = ns->mapy; 101 my = ns->mapy;
104 102
105 if (ns->mapmode == Map1aCmd)
106 {
107 mx += MAX_HEAD_OFFSET;
108 my += MAX_HEAD_OFFSET;
109 }
110
111 /* the x and y here are coordinates for the new map, i.e. if we moved 103 /* the x and y here are coordinates for the new map, i.e. if we moved
112 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason, 104 * (dx,dy), newmap[x][y] = oldmap[x-dx][y-dy]. For this reason,
113 * if the destination x or y coordinate is outside the viewable 105 * if the destination x or y coordinate is outside the viewable
114 * area, we clear the values - otherwise, the old values 106 * area, we clear the values - otherwise, the old values
115 * are preserved, and the check_head thinks it needs to clear them. 107 * are preserved, and the check_head thinks it needs to clear them.
140static void 132static void
141clear_map (player *pl) 133clear_map (player *pl)
142{ 134{
143 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap)); 135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
144 136
137 pl->ns->force_newmap = false;
138
145 if (pl->ns->newmapcmd == 1) 139 if (pl->ns->newmapcmd == 1)
146 pl->ns->send_packet ("newmap"); 140 pl->ns->send_packet ("newmap");
147 141
148 pl->ns->floorbox_reset (); 142 pl->ns->floorbox_reset ();
149} 143}
150 144
151/** check for map change and send new map data */ 145/** check for map/region change and send new map data */
152static void 146static void
153check_map_change (player *pl) 147check_map_change (player *pl)
154{ 148{
155 client &socket = *pl->ns; 149 client &socket = *pl->ns;
156 object *ob = pl->ob; 150 object *ob = pl->ob;
157 char buf[MAX_BUF]; /* eauugggh */ 151 char buf[MAX_BUF]; /* eauugggh */
158 152
159 if (socket.current_map != ob->map) 153 if (socket.force_newmap)
160 { 154 {
155 // force newmap is used for clients that do not redraw their map
156 // after image uploads.
161 socket.current_map = ob->map; 157 socket.current_map = ob->map;
162
163 clear_map (pl); 158 clear_map (pl);
159 }
160 else if (socket.current_map != ob->map)
161 {
162 clear_map (pl);
163 socket.current_map = ob->map;
164 164
165 if (socket.mapinfocmd) 165 if (socket.mapinfocmd)
166 { 166 {
167 if (ob->map && ob->map->path[0]) 167 if (ob->map && ob->map->path[0])
168 { 168 {
200 } 200 }
201 } 201 }
202 202
203 socket.current_x = ob->x; 203 socket.current_x = ob->x;
204 socket.current_y = ob->y; 204 socket.current_y = ob->y;
205
206 region *reg = ob->region ();
207 if (socket.current_region != reg)
208 {
209 socket.current_region = reg;
210 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
211 }
205} 212}
206 213
207/** 214/**
208 * RequestInfo is sort of a meta command. There is some specific 215 * RequestInfo is sort of a meta command. There is some specific
209 * request of information, but we call other functions to provide 216 * request of information, but we call other functions to provide
290 { 297 {
291 int dir = *buf++; 298 int dir = *buf++;
292 299
293 switch (dir) 300 switch (dir)
294 { 301 {
295 case '1': 302 case '1':
296 dx = 0; 303 dx = 0;
297 dy = -1; 304 dy = -1;
298 map = get_map_from_coord (map, &dx, &dy); 305 map = map->xy_find (dx, dy);
299 map && (mapy -= map->height); 306 map && (mapy -= map->height);
300 break; 307 break;
301 case '2': 308 case '2':
302 mapx += map->width; 309 mapx += map->width;
303 dx = map->width; 310 dx = map->width;
304 dy = 0; 311 dy = 0;
305 map = get_map_from_coord (map, &dx, &dy); 312 map = map->xy_find (dx, dy);
306 break; 313 break;
307 case '3': 314 case '3':
308 mapy += map->height; 315 mapy += map->height;
309 dx = 0; 316 dx = 0;
310 dy = map->height; 317 dy = map->height;
311 map = get_map_from_coord (map, &dx, &dy); 318 map = map->xy_find (dx, dy);
312 break; 319 break;
313 case '4': 320 case '4':
314 dx = -1; 321 dx = -1;
315 dy = 0; 322 dy = 0;
316 map = get_map_from_coord (map, &dx, &dy); 323 map = map->xy_find (dx, dy);
317 map && (mapx -= map->width); 324 map && (mapx -= map->width);
318 break; 325 break;
319 } 326 }
320 327
321 --max_distance; 328 --max_distance;
322 } 329 }
323 330
345 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 352 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token);
346 353
347 pl->ns->send_packet (bigbuf); 354 pl->ns->send_packet (bigbuf);
348} 355}
349 356
350/** This is the Setup cmd - easy first implementation */ 357/** This is the Setup cmd */
351void 358void
352SetUp (char *buf, int len, client * ns) 359SetUp (char *buf, int len, client * ns)
353{ 360{
354 int s, slen; 361 INVOKE_CLIENT (SETUP, ns, ARG_DATA (buf, len));
355 char *cmd, *param, cmdback[HUGE_BUF];
356
357 /* run through the cmds of setup
358 * syntax is setup <cmdname1> <parameter> <cmdname2> <parameter> ...
359 *
360 * we send the status of the cmd back, or a FALSE is the cmd is the server unknown
361 * The client then must sort this out
362 */
363
364 //LOG (llevInfo, "Get SetupCmd:: %s\n", buf);
365
366 strcpy (cmdback, "setup");
367 for (s = 0; s < len; )
368 {
369 cmd = &buf[s];
370
371 /* find the next space, and put a null there */
372 for (; buf[s] && buf[s] != ' '; s++)
373 ;
374
375 buf[s++] = 0;
376
377 while (buf[s] == ' ')
378 s++;
379
380 if (s >= len)
381 break;
382
383 param = &buf[s];
384
385 for (; buf[s] && buf[s] != ' '; s++)
386 ;
387
388 buf[s++] = 0;
389
390 while (buf[s] == ' ')
391 s++;
392
393 slen = strlen (cmdback);
394 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
395 safe_strcat (cmdback, cmd, &slen, HUGE_BUF);
396 safe_strcat (cmdback, " ", &slen, HUGE_BUF);
397
398 if (!strcmp (cmd, "sound"))
399 {
400 ns->sound = atoi (param);
401 safe_strcat (cmdback, param, &slen, HUGE_BUF);
402 }
403 else if (!strcmp (cmd, "exp64"))
404 safe_strcat (cmdback, param, &slen, HUGE_BUF);
405 else if (!strcmp (cmd, "spellmon"))
406 {
407 ns->monitor_spells = atoi (param);
408 safe_strcat (cmdback, param, &slen, HUGE_BUF);
409 }
410 else if (!strcmp (cmd, "darkness"))
411 {
412 ns->darkness = atoi (param);
413 safe_strcat (cmdback, param, &slen, HUGE_BUF);
414 }
415 else if (!strcmp (cmd, "map1cmd"))
416 {
417 if (atoi (param))
418 ns->mapmode = Map1Cmd;
419 /* if beyond this size, need to use map1cmd no matter what */
420 if (ns->mapx > 11 || ns->mapy > 11)
421 ns->mapmode = Map1Cmd;
422 safe_strcat (cmdback, ns->mapmode == Map1Cmd ? "1" : "0", &slen, HUGE_BUF);
423 }
424 else if (!strcmp (cmd, "map1acmd"))
425 {
426 if (atoi (param))
427 ns->mapmode = Map1aCmd;
428 /* if beyond this size, need to use map1acmd no matter what */
429 if (ns->mapx > 11 || ns->mapy > 11)
430 ns->mapmode = Map1aCmd;
431 safe_strcat (cmdback, ns->mapmode == Map1aCmd ? "1" : "0", &slen, HUGE_BUF);
432 }
433 else if (!strcmp (cmd, "newmapcmd"))
434 {
435 ns->newmapcmd = atoi (param);
436 safe_strcat (cmdback, param, &slen, HUGE_BUF);
437// } else if (!strcmp(cmd,"plugincmd")) {
438// ns->plugincmd = atoi(param);
439// safe_strcat(cmdback, param, &slen, HUGE_BUF);
440 }
441 else if (!strcmp (cmd, "mapinfocmd"))
442 {
443 ns->mapinfocmd = atoi (param);
444 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
445 }
446 else if (!strcmp (cmd, "extcmd"))
447 {
448 ns->extcmd = atoi (param);
449 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
450 }
451 else if (!strcmp (cmd, "extmap"))
452 {
453 ns->extmap = atoi (param);
454 safe_strcat (cmdback, "1", &slen, HUGE_BUF);
455 }
456 else if (!strcmp (cmd, "facecache"))
457 {
458 ns->facecache = atoi (param);
459 safe_strcat (cmdback, param, &slen, HUGE_BUF);
460 }
461 else if (!strcmp (cmd, "faceset"))
462 {
463 char tmpbuf[20];
464 int q = atoi (param);
465
466 if (is_valid_faceset (q))
467 ns->faceset = q;
468 sprintf (tmpbuf, "%d", ns->faceset);
469 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
470 /* if the client is using faceset, it knows about image2 command */
471 ns->image2 = 1;
472 }
473 else if (!strcmp (cmd, "itemcmd"))
474 {
475 /* Version of the item protocol command to use. Currently,
476 * only supported versions are 1 and 2. Using a numeric
477 * value will make it very easy to extend this in the future.
478 */
479 char tmpbuf[20];
480 int q = atoi (param);
481
482 if (q < 1 || q > 2)
483 {
484 strcpy (tmpbuf, "FALSE");
485 }
486 else
487 {
488 ns->itemcmd = q;
489 sprintf (tmpbuf, "%d", ns->itemcmd);
490 }
491 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
492 }
493 else if (!strcmp (cmd, "mapsize"))
494 {
495 int x, y = 0;
496 char tmpbuf[MAX_BUF], *cp;
497
498 x = atoi (param);
499 for (cp = param; *cp != 0; cp++)
500 if (*cp == 'x' || *cp == 'X')
501 {
502 y = atoi (cp + 1);
503 break;
504 }
505 if (x < 9 || y < 9 || x > MAP_CLIENT_X || y > MAP_CLIENT_Y)
506 {
507 sprintf (tmpbuf, " %dx%d", MAP_CLIENT_X, MAP_CLIENT_Y);
508 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
509 }
510 else
511 {
512 ns->mapx = x;
513 ns->mapy = y;
514 /* better to send back what we are really using and not the
515 * param as given to us in case it gets parsed differently.
516 */
517 sprintf (tmpbuf, "%dx%d", x, y);
518 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
519 /* If beyond this size and still using orig map command, need to
520 * go to map1cmd.
521 */
522 if ((x > 11 || y > 11) && ns->mapmode == Map0Cmd)
523 ns->mapmode = Map1Cmd;
524 }
525 }
526 else if (!strcmp (cmd, "extendedMapInfos"))
527 {
528 /* Added by tchize
529 * prepare to use the mapextended command
530 */
531 char tmpbuf[20];
532
533 ns->ext_mapinfos = (atoi (param));
534 sprintf (tmpbuf, "%d", ns->ext_mapinfos);
535 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
536 }
537 else if (!strcmp (cmd, "extendedTextInfos"))
538 {
539 /* Added by tchize
540 * prepare to use the extended text commands
541 * Client toggle this to non zero to get exttext
542 */
543 char tmpbuf[20];
544
545 ns->has_readable_type = (atoi (param));
546 sprintf (tmpbuf, "%d", ns->has_readable_type);
547 safe_strcat (cmdback, tmpbuf, &slen, HUGE_BUF);
548 }
549 else
550 {
551 /* Didn't get a setup command we understood -
552 * report a failure to the client.
553 */
554 safe_strcat (cmdback, "FALSE", &slen, HUGE_BUF);
555 }
556 } /* for processing all the setup commands */
557
558 LOG (llevInfo, "SendBack SetupCmd:: %s\n", cmdback);
559 ns->send_packet (cmdback);
560} 362}
561 363
562/** 364/**
563 * The client has requested to be added to the game. 365 * The client has requested to be added to the game.
564 * This is what takes care of it. We tell the client how things worked out. 366 * This is what takes care of it. We tell the client how things worked out.
565 * I am not sure if this file is the best place for this function. however, 367 * I am not sure if this file is the best place for this function. however,
566 * it either has to be here or init_sockets needs to be exported. 368 * it either has to be here or init_sockets needs to be exported.
567 */ 369 */
568void 370void
569AddMeCmd (char *buf, int len, client * ns) 371AddMeCmd (char *buf, int len, client *ns)
570{ 372{
571 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len)); 373 INVOKE_CLIENT (ADDME, ns, ARG_DATA (buf, len));
572} 374}
573 375
574/** Reply to ExtendedInfos command */ 376/** Reply to ExtendedInfos command */
686 488
687 ns->send_packet (cmdback); 489 ns->send_packet (cmdback);
688} 490}
689 491
690/** 492/**
691 * A lot like the old AskSmooth (in fact, now called by AskSmooth). 493 * client requested an image. send it rate-limited
692 * Basically, it makes no sense to wait for the client to request a 494 * before flushing.
693 * a piece of data from us that we know the client wants. So
694 * if we know the client wants it, might as well push it to the
695 * client.
696 */
697static void
698SendSmooth (client *ns, uint16 face)
699{
700 uint16 smoothface;
701
702 /* If we can't find a face, return and set it so we won't try to send this
703 * again.
704 */ 495 */
705 if ((!FindSmooth (face, &smoothface)) && (!FindSmooth (smooth_face->number, &smoothface))) 496void
706 { 497AskFaceCmd (char *buf, int len, client *ns)
707 498{
708 LOG (llevError, "could not findsmooth for %d. Neither default (%s)\n", face, &smooth_face->name); 499 ns->askface.push_back (atoi (buf));
709 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
710 return;
711 }
712
713 if (!(ns->faces_sent[smoothface] & NS_FACESENT_FACE))
714 esrv_send_face (ns, smoothface, 0);
715
716 ns->faces_sent[face] |= NS_FACESENT_SMOOTH;
717
718 packet sl ("smooth");
719
720 sl << uint16 (face)
721 << uint16 (smoothface);
722
723 ns->send_packet (sl);
724} 500}
725 501
726 /** 502/**
727 * Tells client the picture it has to use 503 * Tells client the picture it has to use
728 * to smooth a picture number given as argument. 504 * to smooth a picture number given as argument.
729 */ 505 */
730void 506void
731AskSmooth (char *buf, int len, client *ns) 507AskSmooth (char *buf, int len, client *ns)
732{ 508{
733 SendSmooth (ns, atoi (buf)); 509 ns->send_face (atoi (buf));
734} 510}
735 511
736/** 512/**
737 * This handles the general commands from the client (ie, north, fire, cast, 513 * This handles the general commands from the client (ie, north, fire, cast,
738 * etc.) 514 * etc.)
797 * commands. 573 * commands.
798 */ 574 */
799 pl->count = 0; 575 pl->count = 0;
800 576
801 //TODO: schmorp thinks whatever this calculates, it makes no sense at all 577 //TODO: schmorp thinks whatever this calculates, it makes no sense at all
802 int time = FABS (pl->ob->speed) < 0.001 578 int time = fabs (pl->ob->speed) < 0.001
803 ? time = MAX_TIME * 100 579 ? time = MAX_TIME * 100
804 : time = (int) (MAX_TIME / FABS (pl->ob->speed)); 580 : time = (int) (MAX_TIME / fabs (pl->ob->speed));
805 581
806 /* Send confirmation of command execution now */ 582 /* Send confirmation of command execution now */
807 packet sl ("comc"); 583 packet sl ("comc");
808 sl << uint16 (cmdid) << uint32 (time); 584 sl << uint16 (cmdid) << uint32 (time);
809 pl->ns->send_packet (sl); 585 pl->ns->send_packet (sl);
845 621
846 case ST_CHANGE_CLASS: 622 case ST_CHANGE_CLASS:
847 key_change_class (pl->ob, buf[0]); 623 key_change_class (pl->ob, buf[0]);
848 break; 624 break;
849 625
850 case ST_CONFIRM_QUIT:
851 key_confirm_quit (pl->ob, buf[0]);
852 break;
853
854 case ST_GET_PARTY_PASSWORD: /* Get password for party */ 626 case ST_GET_PARTY_PASSWORD: /* Get password for party */
855 receive_party_password (pl->ob, 13); 627 receive_party_password (pl->ob, 13);
856 break; 628 break;
857 629
858 default: 630 default:
879 ns->cs_version = atoi (buf); 651 ns->cs_version = atoi (buf);
880 ns->sc_version = ns->cs_version; 652 ns->sc_version = ns->cs_version;
881 653
882 LOG (llevDebug, "connection from client <%s>\n", buf); 654 LOG (llevDebug, "connection from client <%s>\n", buf);
883 655
884
885 //TODO: should log here just for statistics 656 //TODO: should log here just for statistics
886 657
887 //if (VERSION_CS != ns->cs_version) 658 //if (VERSION_CS != ns->cs_version)
888 // unchecked; 659 // unchecked;
889 660
914{ 685{
915 ns->sound = atoi (buf); 686 ns->sound = atoi (buf);
916} 687}
917 688
918/** client wants the map resent */ 689/** client wants the map resent */
919
920void 690void
921MapRedrawCmd (char *buf, int len, player *pl) 691MapRedrawCmd (char *buf, int len, player *pl)
922{ 692{
923/* This function is currently disabled; just clearing the map state results in 693/* This function is currently disabled; just clearing the map state results in
924 * display errors. It should clear the cache and send a newmap command. 694 * display errors. It should clear the cache and send a newmap command.
969/** 739/**
970 * Asks the client to query the user. This way, the client knows 740 * Asks the client to query the user. This way, the client knows
971 * it needs to send something back (vs just printing out a message) 741 * it needs to send something back (vs just printing out a message)
972 */ 742 */
973void 743void
974send_query (client *ns, uint8 flags, char *text) 744send_query (client *ns, uint8 flags, const char *text)
975{ 745{
976 ns->send_packet_printf ("query %d %s", flags, text ? text : ""); 746 ns->send_packet_printf ("query %d %s", flags, text ? text : "");
977} 747}
978 748
979#define AddIfInt64(Old,New,Type) if (Old != New) {\ 749#define AddIfInt64(Old,New,Type) if (Old != New) {\
1011esrv_update_stats (player *pl) 781esrv_update_stats (player *pl)
1012{ 782{
1013 char buf[MAX_BUF]; 783 char buf[MAX_BUF];
1014 uint16 flags; 784 uint16 flags;
1015 785
786 client *ns = pl->ns;
1016 if (!pl->ns) 787 if (!ns)
1017 return; 788 return;
1018 789
790 object *ob = pl->ob;
791 if (!ob)
792 return;
793
1019 packet sl ("stats"); 794 packet sl ("stats");
1020 795
1021 if (pl->ob)
1022 {
1023 AddIfShort (pl->last_stats.hp, pl->ob->stats.hp, CS_STAT_HP); 796 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
1024 AddIfShort (pl->last_stats.maxhp, pl->ob->stats.maxhp, CS_STAT_MAXHP); 797 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
1025 AddIfShort (pl->last_stats.sp, pl->ob->stats.sp, CS_STAT_SP); 798 AddIfShort (ns->last_stats.sp, ob->stats.sp, CS_STAT_SP);
1026 AddIfShort (pl->last_stats.maxsp, pl->ob->stats.maxsp, CS_STAT_MAXSP); 799 AddIfShort (ns->last_stats.maxsp, ob->stats.maxsp, CS_STAT_MAXSP);
1027 AddIfShort (pl->last_stats.grace, pl->ob->stats.grace, CS_STAT_GRACE); 800 AddIfShort (ns->last_stats.grace, ob->stats.grace, CS_STAT_GRACE);
1028 AddIfShort (pl->last_stats.maxgrace, pl->ob->stats.maxgrace, CS_STAT_MAXGRACE); 801 AddIfShort (ns->last_stats.maxgrace, ob->stats.maxgrace, CS_STAT_MAXGRACE);
1029 AddIfShort (pl->last_stats.Str, pl->ob->stats.Str, CS_STAT_STR); 802 AddIfShort (ns->last_stats.Str, ob->stats.Str, CS_STAT_STR);
1030 AddIfShort (pl->last_stats.Dex, pl->ob->stats.Dex, CS_STAT_DEX); 803 AddIfShort (ns->last_stats.Dex, ob->stats.Dex, CS_STAT_DEX);
1031 AddIfShort (pl->last_stats.Con, pl->ob->stats.Con, CS_STAT_CON); 804 AddIfShort (ns->last_stats.Con, ob->stats.Con, CS_STAT_CON);
1032 AddIfShort (pl->last_stats.Int, pl->ob->stats.Int, CS_STAT_INT); 805 AddIfShort (ns->last_stats.Int, ob->stats.Int, CS_STAT_INT);
1033 AddIfShort (pl->last_stats.Wis, pl->ob->stats.Wis, CS_STAT_WIS); 806 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
1034 AddIfShort (pl->last_stats.Pow, pl->ob->stats.Pow, CS_STAT_POW); 807 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
1035 AddIfShort (pl->last_stats.Cha, pl->ob->stats.Cha, CS_STAT_CHA); 808 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
1036 }
1037 809
1038 for (int s = 0; s < NUM_SKILLS; s++) 810 for (int s = 0; s < NUM_SKILLS; s++)
1039 if (pl->last_skill_ob[s] && pl->last_skill_exp[s] != pl->last_skill_ob[s]->stats.exp) 811 if (object *skill = pl->last_skill_ob[s])
812 if (skill->stats.exp != ns->last_skill_exp [s])
1040 { 813 {
814 ns->last_skill_exp [s] = skill->stats.exp;
815
1041 /* Always send along the level if exp changes. This is only 816 /* Always send along the level if exp changes. This is only
1042 * 1 extra byte, but keeps processing simpler. 817 * 1 extra byte, but keeps processing simpler.
1043 */ 818 */
1044 sl << uint8 (s + CS_STAT_SKILLINFO) 819 sl << uint8 (s + CS_STAT_SKILLINFO)
1045 << uint8 (pl->last_skill_ob[s]->level) 820 << uint8 (skill->level)
1046 << uint64 (pl->last_skill_ob[s]->stats.exp); 821 << uint64 (skill->stats.exp);
1047
1048 pl->last_skill_exp[s] = pl->last_skill_ob[s]->stats.exp;
1049 } 822 }
1050 823
1051 AddIfInt64 (pl->last_stats.exp, pl->ob->stats.exp, CS_STAT_EXP64); 824 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
1052 AddIfShort (pl->last_level, (char) pl->ob->level, CS_STAT_LEVEL); 825 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
1053 AddIfShort (pl->last_stats.wc, pl->ob->stats.wc, CS_STAT_WC); 826 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
1054 AddIfShort (pl->last_stats.ac, pl->ob->stats.ac, CS_STAT_AC); 827 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
1055 AddIfShort (pl->last_stats.dam, pl->ob->stats.dam, CS_STAT_DAM); 828 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
1056 AddIfFloat (pl->last_speed, pl->ob->speed, CS_STAT_SPEED); 829 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED);
1057 AddIfShort (pl->last_stats.food, pl->ob->stats.food, CS_STAT_FOOD); 830 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
1058 AddIfFloat (pl->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 831 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP);
1059 AddIfInt (pl->last_weight_limit, (sint32) weight_limit[pl->ob->stats.Str], CS_STAT_WEIGHT_LIM); 832 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
833
1060 flags = 0; 834 flags = 0;
1061 835
1062 if (pl->fire_on) 836 if (pl->fire_on)
1063 flags |= SF_FIREON; 837 flags |= SF_FIREON;
1064 838
1065 if (pl->run_on) 839 if (pl->run_on)
1066 flags |= SF_RUNON; 840 flags |= SF_RUNON;
1067 841
1068 AddIfShort (pl->last_flags, flags, CS_STAT_FLAGS); 842 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
1069 843
1070 if (pl->ns->sc_version < 1025) 844 if (ns->sc_version < 1025)
1071 { AddIfShort (pl->last_resist[ATNR_PHYSICAL], pl->ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) } 845 { AddIfShort (ns->last_resist[ATNR_PHYSICAL], ob->resist[ATNR_PHYSICAL], CS_STAT_ARMOUR) }
1072 else 846 else
1073 for (int i = 0; i < NROFATTACKS; i++) 847 for (int i = 0; i < NROFATTACKS; i++)
1074 { 848 {
1075 /* Skip ones we won't send */ 849 /* Skip ones we won't send */
1076 if (atnr_cs_stat[i] == -1) 850 if (atnr_cs_stat[i] == -1)
1077 continue; 851 continue;
1078 852
1079 AddIfShort (pl->last_resist[i], pl->ob->resist[i], (char) atnr_cs_stat[i]); 853 AddIfShort (ns->last_resist[i], ob->resist[i], atnr_cs_stat[i]);
1080 } 854 }
1081 855
1082 if (pl->ns->monitor_spells) 856 if (pl->ns->monitor_spells)
1083 { 857 {
1084 AddIfInt (pl->last_path_attuned, pl->ob->path_attuned, CS_STAT_SPELL_ATTUNE); 858 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
1085 AddIfInt (pl->last_path_repelled, pl->ob->path_repelled, CS_STAT_SPELL_REPEL); 859 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
1086 AddIfInt (pl->last_path_denied, pl->ob->path_denied, CS_STAT_SPELL_DENY); 860 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
1087 } 861 }
1088 862
1089 rangetostring (pl->ob, buf); /* we want use the new fire & run system in new client */ 863 rangetostring (ob, buf); /* we want use the new fire & run system in new client */
1090 AddIfString (pl->ns->stats.range, buf, CS_STAT_RANGE); 864 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
1091 set_title (pl->ob, buf); 865 set_title (ob, buf);
1092 AddIfString (pl->ns->stats.title, buf, CS_STAT_TITLE); 866 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
1093 867
1094 /* Only send it away if we have some actual data */ 868 /* Only send it away if we have some actual data */
1095 if (sl.length () > 6) 869 if (sl.length () > 6)
1096 pl->ns->send_packet (sl); 870 ns->send_packet (sl);
1097} 871}
1098 872
1099/** 873/**
1100 * Tells the client that here is a player it should start using. 874 * Tells the client that here is a player it should start using.
1101 */ 875 */
1102void 876void
1103esrv_new_player (player *pl, uint32 weight) 877esrv_new_player (player *pl, uint32 weight)
1104{ 878{
1105 pl->last_weight = weight;
1106
1107 packet sl ("player"); 879 packet sl ("player");
1108 880
1109 sl << uint32 (pl->ob->count) 881 sl << uint32 (pl->ob->count)
1110 << uint32 (weight) 882 << uint32 (weight)
1111 << uint32 (pl->ob->face->number) 883 << uint32 (pl->ob->face)
1112 << data8 (pl->ob->name); 884 << data8 (pl->ob->name);
1113 885
886 pl->ns->last_weight = weight;
1114 pl->ns->send_packet (sl); 887 pl->ns->send_packet (sl);
1115 SET_FLAG (pl->ob, FLAG_CLIENT_SENT); 888 SET_FLAG (pl->ob, FLAG_CLIENT_SENT);
1116} 889}
1117
1118/**
1119 * Need to send an animation sequence to the client.
1120 * We will send appropriate face commands to the client if we haven't
1121 * sent them the face yet (this can become quite costly in terms of
1122 * how much we are sending - on the other hand, this should only happen
1123 * when the player logs in and picks stuff up.
1124 */
1125void
1126esrv_send_animation (client * ns, short anim_num)
1127{
1128 /* Do some checking on the anim_num we got. Note that the animations
1129 * are added in contigous order, so if the number is in the valid
1130 * range, it must be a valid animation.
1131 */
1132 if (anim_num < 0 || anim_num > num_animations)
1133 {
1134 LOG (llevError, "esrv_send_anim (%d) out of bounds??\n", anim_num);
1135 return;
1136 }
1137
1138 packet sl ("anim");
1139
1140 sl << uint16 (anim_num)
1141 << uint16 (0); /* flags - not used right now */
1142
1143 /* Build up the list of faces. Also, send any information (ie, the
1144 * the face itself) down to the client.
1145 */
1146 for (int i = 0; i < animations[anim_num].num_animations; i++)
1147 {
1148 if (!(ns->faces_sent[animations[anim_num].faces[i]] & NS_FACESENT_FACE))
1149 esrv_send_face (ns, animations[anim_num].faces[i], 0);
1150
1151 sl << uint16 (animations[anim_num].faces[i]); /* flags - not used right now */
1152 }
1153
1154 ns->send_packet (sl);
1155
1156 ns->anims_sent[anim_num] = 1;
1157}
1158
1159 890
1160/****************************************************************************** 891/******************************************************************************
1161 * 892 *
1162 * Start of map related commands. 893 * Start of map related commands.
1163 * 894 *
1164 ******************************************************************************/ 895 ******************************************************************************/
1165 896
1166/**
1167 * This adds face_num to a map cell at x,y. If the client doesn't have
1168 * the face yet, we will also send it.
1169 */
1170static void
1171esrv_map_setbelow (client * ns, int x, int y, short face_num, struct Map *newmap)
1172{
1173 if (newmap->cells[x][y].count >= MAP_LAYERS)
1174 {
1175 //TODO: one or the other, can't both have abort and return, verify and act
1176 LOG (llevError, "Too many faces in map cell %d %d\n", x, y);
1177 return;
1178 abort ();
1179 }
1180
1181 newmap->cells[x][y].faces[newmap->cells[x][y].count] = face_num;
1182 newmap->cells[x][y].count++;
1183
1184 if (!(ns->faces_sent[face_num] & NS_FACESENT_FACE))
1185 esrv_send_face (ns, face_num, 0);
1186}
1187
1188/** Clears a map cell */ 897/** Clears a map cell */
1189static void 898static void
1190map_clearcell (struct MapCell *cell, int face0, int face1, int face2, int count) 899map_clearcell (struct MapCell *cell, int count)
1191{ 900{
1192 cell->faces[0] = face0; 901 cell->faces[0] = 0;
1193 cell->faces[1] = face1; 902 cell->faces[1] = 0;
1194 cell->faces[2] = face2; 903 cell->faces[2] = 0;
904 cell->smooth[0] = 0;
905 cell->smooth[1] = 0;
906 cell->smooth[2] = 0;
1195 cell->count = count; 907 cell->count = count;
1196 cell->stat_hp = 0; 908 cell->stat_hp = 0;
1197 cell->flags = 0; 909 cell->flags = 0;
1198 cell->player = 0; 910 cell->player = 0;
1199} 911}
1200 912
1201#define MAX_HEAD_POS MAX(MAX_CLIENT_X, MAX_CLIENT_Y)
1202#define MAX_LAYERS 3 913#define MAX_LAYERS 3
1203
1204/* Using a global really isn't a good approach, but saves the over head of
1205 * allocating and deallocating such a block of data each time run through,
1206 * and saves the space of allocating this in the socket object when we only
1207 * need it for this cycle. If the server is ever threaded, this needs to be
1208 * re-examined.
1209 */
1210static object *heads[MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS];
1211
1212/**
1213 * Returns true if any of the heads for this
1214 * space is set. Returns false if all are blank - this is used
1215 * for empty space checking.
1216 */
1217static inline int
1218have_head (int ax, int ay)
1219{
1220 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS] ||
1221 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 1] || heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + 2])
1222 return 1;
1223
1224 return 0;
1225}
1226
1227/**
1228 * check_head is a bit simplistic version of update_space below.
1229 * basically, it only checks the that the head on space ax,ay at layer
1230 * needs to get sent - if so, it adds the data, sending the head
1231 * if needed, and returning 1. If this no data needs to get
1232 * sent, it returns zero.
1233 */
1234static int
1235check_head (packet &sl, client &ns, int ax, int ay, int layer)
1236{
1237 short face_num;
1238
1239 if (heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer])
1240 face_num = heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer]->face->number;
1241 else
1242 face_num = 0;
1243
1244 if (face_num != ns.lastmap.cells[ax][ay].faces[layer])
1245 {
1246 sl << uint16 (face_num);
1247 if (face_num && !(ns.faces_sent[face_num] & NS_FACESENT_FACE))
1248 esrv_send_face (&ns, face_num, 0);
1249
1250 heads[(ay * MAX_HEAD_POS + ax) * MAX_LAYERS + layer] = NULL;
1251 ns.lastmap.cells[ax][ay].faces[layer] = face_num;
1252 return 1;
1253 }
1254
1255 return 0; /* No change */
1256}
1257 914
1258/** 915/**
1259 * Removes the need to replicate the same code for each layer. 916 * Removes the need to replicate the same code for each layer.
1260 * this returns true if this space is now in fact different than 917 * this returns true if this space is now in fact different than
1261 * it was. 918 * it was.
1262 * sl is the socklist this data is going into. 919 * sl is the socklist this data is going into.
1263 * ns is the socket we are working on - all the info we care 920 * ns is the socket we are working on - all the info we care
1264 * about is in this socket structure, so now need not pass the 921 * about is in this socket structure, so now need not pass the
1265 * entire player object. 922 * entire player object.
1266 * mx and my are map coordinate offsets for map mp
1267 * sx and sy are the offsets into the socket structure that
1268 * holds the old values.
1269 * layer is the layer to update, with 2 being the floor and 0 the 923 * layer is the layer to update, with 2 being the floor and 0 the
1270 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ) 924 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ)
1271 * take. Interesting to note that before this function, the map1 function 925 * take. Interesting to note that before this function, the map1 function
1272 * numbers the spaces differently - I think this was a leftover from 926 * numbers the spaces differently - I think this was a leftover from
1273 * the map command, where the faces stack up. Sinces that is no longer 927 * the map command, where the faces stack up. Sinces that is no longer
1274 * the case, it seems to make more sense to have these layer values 928 * the case, it seems to make more sense to have these layer values
1275 * actually match. 929 * actually match.
1276 */ 930 */
1277static int 931static int
1278update_space (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer) 932update_space (packet &sl, client &ns, mapspace &ms, MapCell &lastcell, int layer)
1279{ 933{
1280 object *ob, *head; 934 object *ob = ms.faces_obj [layer];
1281 uint16 face_num;
1282 int bx, by, i;
1283
1284 /* If there is a multipart object stored away, treat that as more important.
1285 * If not, then do the normal processing.
1286 */
1287 head = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer];
1288
1289 /* Check to see if this head is part of the set of objects
1290 * we would normally send for this space. If so, then
1291 * don't use the head value. We need to do the check
1292 * here and not when setting up the heads[] value for two reasons -
1293 * 1) the heads[] values will get used even if the space is not visible.
1294 * 2) its possible the head is not on the same map as a part, and I'd
1295 * rather not need to do the map translation overhead.
1296 * 3) We need to do some extra checking to make sure that we will
1297 * otherwise send the image as this layer, eg, either it matches
1298 * the head value, or is not multipart.
1299 */
1300 if (head && !head->more)
1301 {
1302 for (i = 0; i < MAP_LAYERS; i++)
1303 {
1304 ob = GET_MAP_FACE_OBJ (mp, mx, my, i);
1305 if (!ob)
1306 continue;
1307
1308 if (ob->head)
1309 ob = ob->head;
1310
1311 if (ob == head)
1312 {
1313 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer] = NULL;
1314 head = NULL;
1315 break;
1316 }
1317 }
1318 }
1319
1320 ob = head;
1321 if (!ob)
1322 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1323 935
1324 /* If there is no object for this space, or if the face for the object 936 /* If there is no object for this space, or if the face for the object
1325 * is the blank face, set the face number to zero. 937 * is the blank face, set the face number to zero.
1326 * else if we have the stored head object for this space, that takes 938 * else if we have the stored head object for this space, that takes
1327 * precedence over the other object for this space. 939 * precedence over the other object for this space.
1328 * otherwise, we do special head processing 940 * otherwise, we do special head processing
1329 */ 941 */
1330 if (!ob || ob->face == blank_face) 942 uint16 face_num = ob && ob->face != blank_face ? ob->face : 0;
1331 face_num = 0;
1332 else if (head)
1333 {
1334 /* if this is a head that had previously been stored */
1335 face_num = ob->face->number;
1336 }
1337 else
1338 {
1339 /* if the faces for the different parts of a multipart object
1340 * are the same, we only want to send the bottom right most
1341 * portion of the object. That info is in the tail_.. values
1342 * of the head. Note that for the head itself, ob->head will
1343 * be null, so we only do this block if we are working on
1344 * a tail piece.
1345 */
1346
1347 /* tail_x and tail_y will only be set in the head object. If
1348 * this is the head object and these are set, we proceed
1349 * with logic to only send bottom right. Similarly, if
1350 * this is one of the more parts but the head has those values
1351 * set, we want to do the processing. There can be cases where
1352 * the head is not visible but one of its parts is, so we just
1353 * can always expect that ob->arch->tail_x will be true for all
1354 * object we may want to display.
1355 */
1356 if ((ob->arch->tail_x || ob->arch->tail_y) || (ob->head && (ob->head->arch->tail_x || ob->head->arch->tail_y)))
1357 {
1358
1359 if (ob->head)
1360 head = ob->head;
1361 else
1362 head = ob;
1363
1364 /* Basically figure out where the offset is from where we are right
1365 * now. the ob->arch->clone.{x,y} values hold the offset that this current
1366 * piece is from the head, and the tail is where the tail is from the
1367 * head. Note that bx and by will equal sx and sy if we are already working
1368 * on the bottom right corner. If ob is the head, the clone values
1369 * will be zero, so the right thing will still happen.
1370 */
1371 bx = sx + head->arch->tail_x - ob->arch->clone.x;
1372 by = sy + head->arch->tail_y - ob->arch->clone.y;
1373
1374 /* I don't think this can ever happen, but better to check for it just
1375 * in case.
1376 */
1377 if (bx < sx || by < sy)
1378 {
1379 LOG (llevError, "update_space: bx (%d) or by (%d) is less than sx (%d) or sy (%d)\n", bx, by, sx, sy);
1380 face_num = 0;
1381 }
1382 /* single part object, multipart object with non merged faces,
1383 * of multipart object already at lower right.
1384 */
1385 else if (bx == sx && by == sy)
1386 {
1387 face_num = ob->face->number;
1388
1389 /* if this face matches one stored away, clear that one away.
1390 * this code relies on the fact that the map1 commands
1391 * goes from 2 down to 0.
1392 */
1393 for (i = 0; i < MAP_LAYERS; i++)
1394 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] &&
1395 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i]->face->number == face_num)
1396 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + i] = NULL;
1397 }
1398 else
1399 {
1400 /* If this head is stored away, clear it - otherwise,
1401 * there can be cases where a object is on multiple layers -
1402 * we only want to send it once.
1403 */
1404 face_num = head->face->number;
1405 for (i = 0; i < MAP_LAYERS; i++)
1406 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] &&
1407 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i]->face->number == face_num)
1408 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = NULL;
1409
1410 /* First, try to put the new head on the same layer. If that is used up,
1411 * then find another layer.
1412 */
1413 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] == NULL)
1414 {
1415 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + layer] = head;
1416 }
1417 else
1418 for (i = 0; i < MAX_LAYERS; i++)
1419 {
1420 if (heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == NULL ||
1421 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] == head)
1422 {
1423 heads[(by * MAX_HEAD_POS + bx) * MAX_LAYERS + i] = head;
1424 }
1425 }
1426 face_num = 0; /* Don't send this object - we'll send the head later */
1427 }
1428 }
1429 else
1430 {
1431 /* In this case, we are already at the lower right or single part object,
1432 * so nothing special
1433 */
1434 face_num = ob->face->number;
1435
1436 /* clear out any head entries that have the same face as this one */
1437 for (bx = 0; bx < layer; bx++)
1438 if (heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] &&
1439 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx]->face->number == face_num)
1440 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + bx] = NULL;
1441 }
1442 } /* else not already head object or blank face */
1443
1444 /* This is a real hack. Basically, if we have nothing to send for this layer,
1445 * but there is a head on the next layer, send that instead.
1446 * Without this, what happens is you can get the case where the player stands
1447 * on the same space as the head. However, if you have overlapping big objects
1448 * of the same type, what happens then is it doesn't think it needs to send
1449 * This tends to make stacking also work/look better.
1450 */
1451 if (!face_num && layer > 0 && heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1])
1452 {
1453 face_num = heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1]->face->number;
1454 heads[(sy * MAX_HEAD_POS + sx) * MAX_LAYERS + layer - 1] = NULL;
1455 }
1456
1457 /* Another hack - because of heads and whatnot, this face may match one
1458 * we already sent for a lower layer. In that case, don't send
1459 * this one.
1460 */
1461 if (face_num && layer + 1 < MAP_LAYERS && ns.lastmap.cells[sx][sy].faces[layer + 1] == face_num)
1462 face_num = 0;
1463 943
1464 /* We've gotten what face we want to use for the object. Now see if 944 /* We've gotten what face we want to use for the object. Now see if
1465 * if it has changed since we last sent it to the client. 945 * if it has changed since we last sent it to the client.
1466 */ 946 */
1467 if (ns.lastmap.cells[sx][sy].faces[layer] != face_num) 947 if (lastcell.faces[layer] != face_num)
1468 { 948 {
1469 ns.lastmap.cells[sx][sy].faces[layer] = face_num; 949 lastcell.faces[layer] = face_num;
950
1470 if (!(ns.faces_sent[face_num] & NS_FACESENT_FACE)) 951 if (!ns.faces_sent[face_num])
952 if (ob)
953 ns.send_faces (ob);
954 else
1471 esrv_send_face (&ns, face_num, 0); 955 ns.send_face (face_num);
1472 956
1473 sl << uint16 (face_num); 957 sl << uint16 (face_num);
1474 return 1;
1475 }
1476
1477 /* Nothing changed */
1478 return 0;
1479}
1480
1481/**
1482 * This function is mainly a copy of update_space,
1483 * except it handles update of the smoothing updates,
1484 * not the face updates.
1485 * Removes the need to replicate the same code for each layer.
1486 * this returns true if this smooth is now in fact different
1487 * than it was.
1488 * sl is the socklist this data is going into.
1489 * ns is the socket we are working on - all the info we care
1490 * about is in this socket structure, so know need to pass the
1491 * entire player object.
1492 * mx and my are map coordinate offsets for map mp
1493 * sx and sy are the offsets into the socket structure that
1494 * holds the old values.
1495 * layer is the layer to update, with 2 being the floor and 0 the
1496 * top layer (this matches what the GET_MAP_FACE and GET_MAP_FACE_OBJ
1497 * take.
1498 */
1499
1500static inline int
1501update_smooth (packet &sl, client &ns, maptile *mp, int mx, int my, int sx, int sy, int layer)
1502{
1503 object *ob;
1504 int smoothlevel; /* old face_num; */
1505
1506 ob = GET_MAP_FACE_OBJ (mp, mx, my, layer);
1507
1508 /* If there is no object for this space, or if the face for the object
1509 * is the blank face, set the smoothlevel to zero.
1510 */
1511 if (!ob || ob->face == blank_face)
1512 smoothlevel = 0;
1513 else
1514 {
1515 smoothlevel = ob->smoothlevel;
1516 if (smoothlevel && !(ns.faces_sent[ob->face->number] & NS_FACESENT_SMOOTH))
1517 SendSmooth (&ns, ob->face->number);
1518 } /* else not already head object or blank face */
1519
1520 /* We've gotten what face we want to use for the object. Now see if
1521 * if it has changed since we last sent it to the client.
1522 */
1523 if (smoothlevel > 255)
1524 smoothlevel = 255;
1525 else if (smoothlevel < 0)
1526 smoothlevel = 0;
1527
1528 if (ns.lastmap.cells[sx][sy].smooth[layer] != smoothlevel)
1529 {
1530 ns.lastmap.cells[sx][sy].smooth[layer] = smoothlevel;
1531 sl << uint8 (smoothlevel);
1532 return 1; 958 return 1;
1533 } 959 }
1534 960
1535 /* Nothing changed */ 961 /* Nothing changed */
1536 return 0; 962 return 0;
1551 if (ns->EMI_smooth) 977 if (ns->EMI_smooth)
1552 result += 1; /*One byte for smoothlevel */ 978 result += 1; /*One byte for smoothlevel */
1553 } 979 }
1554 980
1555 return result; 981 return result;
982}
983
984// prefetch (and touch) all maps within a specific distancd
985static void
986prefetch_surrounding_maps (maptile *map, int distance)
987{
988 map->last_access = runtime;
989
990 if (--distance)
991 for (int dir = 4; --dir; )
992 if (const shstr &path = map->tile_path [dir])
993 if (maptile *&neigh = map->tile_map [dir])
994 prefetch_surrounding_maps (neigh, distance);
995 else
996 neigh = maptile::find_async (path, map);
997}
998
999// prefetch a generous area around the player
1000static void
1001prefetch_surrounding_maps (object *op)
1002{
1003 prefetch_surrounding_maps (op->map, 3);
1556} 1004}
1557 1005
1558/** 1006/**
1559 * This function uses the new map1 protocol command to send the map 1007 * This function uses the new map1 protocol command to send the map
1560 * to the client. It is necessary because the old map command supports 1008 * to the client. It is necessary because the old map command supports
1578 * look like. 1026 * look like.
1579 */ 1027 */
1580void 1028void
1581draw_client_map1 (object *pl) 1029draw_client_map1 (object *pl)
1582{ 1030{
1583 int x, y, ax, ay, d, startlen, max_x, max_y, oldlen; 1031 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1584 sint16 nx, ny; 1032 sint16 nx, ny;
1585 int estartlen, eoldlen; 1033 int estartlen, eoldlen;
1586 uint16 mask, emask;
1587 uint8 eentrysize; 1034 uint8 eentrysize;
1588 uint16 ewhatstart, ewhatflag; 1035 uint16 ewhatstart, ewhatflag;
1589 uint8 extendedinfos; 1036 uint8 extendedinfos;
1590 maptile *m; 1037 maptile *m;
1591 1038
1592 client &socket = *pl->contr->ns; 1039 client &socket = *pl->contr->ns;
1593 1040
1041 if (!pl->active)
1042 return;
1043
1594 check_map_change (pl->contr); 1044 check_map_change (pl->contr);
1045 prefetch_surrounding_maps (pl);
1595 1046
1596 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a"); 1047 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1597 packet esl; 1048 packet esl;
1598 1049
1599 startlen = sl.length (); 1050 startlen = sl.length ();
1614 << uint8 (extendedinfos) 1065 << uint8 (extendedinfos)
1615 << uint8 (eentrysize); 1066 << uint8 (eentrysize);
1616 1067
1617 estartlen = esl.length (); 1068 estartlen = esl.length ();
1618 } 1069 }
1619 else
1620 {
1621 /* suppress compiler warnings */
1622 ewhatstart = 0;
1623 ewhatflag = 0;
1624 estartlen = 0;
1625 }
1626
1627 /* Init data to zero */
1628 memset (heads, 0, sizeof (object *) * MAX_HEAD_POS * MAX_HEAD_POS * MAX_LAYERS);
1629 1070
1630 /* x,y are the real map locations. ax, ay are viewport relative 1071 /* x,y are the real map locations. ax, ay are viewport relative
1631 * locations. 1072 * locations.
1632 */ 1073 */
1633 ay = 0; 1074 ay = 0;
1636 * but that started to get a bit messy to look at. 1077 * but that started to get a bit messy to look at.
1637 */ 1078 */
1638 max_x = pl->x + (socket.mapx + 1) / 2; 1079 max_x = pl->x + (socket.mapx + 1) / 2;
1639 max_y = pl->y + (socket.mapy + 1) / 2; 1080 max_y = pl->y + (socket.mapy + 1) / 2;
1640 1081
1641 if (socket.mapmode == Map1aCmd) 1082 maptile *plmap = pl->map;
1642 {
1643 max_x += MAX_HEAD_OFFSET;
1644 max_y += MAX_HEAD_OFFSET;
1645 }
1646 1083
1647 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1084 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++)
1648 { 1085 {
1649 ax = 0; 1086 ax = 0;
1650 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1087 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++)
1651 { 1088 {
1089 int emask, mask;
1652 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1090 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1653 1091
1654 /* If this space is out of the normal viewable area, we only check
1655 * the heads value ax or ay will only be greater than what
1656 * the client wants if using the map1a command - this is because
1657 * if the map1a command is not used, max_x and max_y will be
1658 * set to lower values.
1659 */
1660 if (ax >= socket.mapx || ay >= socket.mapy)
1661 {
1662 int i, got_one;
1663
1664 oldlen = sl.length ();
1665
1666 sl << uint16 (mask);
1667
1668 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1669 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1670 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1671
1672 /* If all we are doing is sending 0 (blank) faces, we don't
1673 * actually need to send that - just the coordinates
1674 * with no faces tells the client to blank out the
1675 * space.
1676 */
1677 got_one = 0;
1678 for (i = oldlen + 2; i < sl.length (); i++)
1679 if (sl[i])
1680 got_one = 1;
1681
1682 if (got_one && (mask & 0xf))
1683 sl[oldlen + 1] = mask & 0xff;
1684 else
1685 { /*either all faces blank, either no face at all */
1686 if (mask & 0xf) /*at least 1 face, we know it's blank, only send coordinates */
1687 sl.reset (oldlen + 2);
1688 else
1689 sl.reset (oldlen);
1690 }
1691
1692 /*What concerns extendinfos, nothing to be done for now
1693 * (perhaps effects layer later)
1694 */
1695 continue; /* don't do processing below */
1696 }
1697
1698 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1092 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1699
1700 d = pl->contr->blocked_los[ax][ay];
1701 1093
1702 /* If the coordinates are not valid, or it is too dark to see, 1094 /* If the coordinates are not valid, or it is too dark to see,
1703 * we tell the client as such 1095 * we tell the client as such
1704 */ 1096 */
1705 nx = x; 1097 nx = x;
1706 ny = y; 1098 ny = y;
1707 m = get_map_from_coord (pl->map, &nx, &ny); 1099 m = get_map_from_coord (plmap, &nx, &ny);
1708 1100
1709 if (!m) 1101 if (!m)
1710 { 1102 {
1711 /* space is out of map. Update space and clear values 1103 /* space is out of map. Update space and clear values
1712 * if this hasn't already been done. If the space is out 1104 * if this hasn't already been done. If the space is out
1713 * of the map, it shouldn't have a head 1105 * of the map, it shouldn't have a head
1714 */ 1106 */
1715 if (lastcell.count != -1) 1107 if (lastcell.count != -1)
1716 { 1108 {
1717 sl << uint16 (mask); 1109 sl << uint16 (mask);
1718 map_clearcell (&lastcell, 0, 0, 0, -1); 1110 map_clearcell (&lastcell, -1);
1719 } 1111 }
1112
1113 continue;
1720 } 1114 }
1115
1116 m->touch ();
1117
1118 int d = pl->contr->blocked_los[ax][ay];
1119
1721 else if (d > 3) 1120 if (d > 3)
1722 { 1121 {
1723 m->touch ();
1724 1122
1725 int need_send = 0, count; 1123 int need_send = 0, count;
1726 1124
1727 /* This block deals with spaces that are not visible for whatever 1125 /* This block deals with spaces that are not visible for whatever
1728 * reason. Still may need to send the head for this space. 1126 * reason. Still may need to send the head for this space.
1729 */ 1127 */
1730 1128
1731 oldlen = sl.length (); 1129 oldlen = sl.length ();
1732 1130
1733 sl << uint16 (mask); 1131 sl << uint16 (mask);
1735 if (lastcell.count != -1) 1133 if (lastcell.count != -1)
1736 need_send = 1; 1134 need_send = 1;
1737 1135
1738 count = -1; 1136 count = -1;
1739 1137
1740 if (socket.mapmode == Map1aCmd && have_head (ax, ay))
1741 {
1742 /* Now check to see if any heads need to be sent */
1743
1744 if (check_head (sl, socket, ax, ay, 2)) mask |= 0x4;
1745 if (check_head (sl, socket, ax, ay, 1)) mask |= 0x2;
1746 if (check_head (sl, socket, ax, ay, 0)) mask |= 0x1;
1747
1748 lastcell.count = count;
1749 }
1750 else
1751 {
1752 /* properly clear a previously sent big face */ 1138 /* properly clear a previously sent big face */
1753 if (lastcell.faces[0] != 0 || lastcell.faces[1] != 0 || lastcell.faces[2] != 0 1139 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1754 || lastcell.stat_hp || lastcell.flags || lastcell.player) 1140 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1755 need_send = 1; 1141 need_send = 1;
1756 1142
1757 map_clearcell (&lastcell, 0, 0, 0, count); 1143 map_clearcell (&lastcell, count);
1758 }
1759 1144
1760 if ((mask & 0xf) || need_send) 1145 if ((mask & 0xf) || need_send)
1761 sl[oldlen + 1] = mask & 0xff; 1146 sl[oldlen + 1] = mask & 0xff;
1762 else 1147 else
1763 sl.reset (oldlen); 1148 sl.reset (oldlen);
1764 } 1149 }
1765 else 1150 else
1766 { 1151 {
1767 m->touch ();
1768
1769 /* In this block, the space is visible or there are head objects 1152 /* In this block, the space is visible.
1770 * we need to send.
1771 */ 1153 */
1772 1154
1773 /* Rather than try to figure out what everything that we might 1155 /* Rather than try to figure out what everything that we might
1774 * need to send is, then form the packet after that, 1156 * need to send is, then form the packet after that,
1775 * we presume that we will in fact form a packet, and update 1157 * we presume that we will in fact form a packet, and update
1778 * is done. 1160 * is done.
1779 * I think this is simpler than doing a bunch of checks to see 1161 * I think this is simpler than doing a bunch of checks to see
1780 * what if anything we need to send, setting the bits, then 1162 * what if anything we need to send, setting the bits, then
1781 * doing those checks again to add the real data. 1163 * doing those checks again to add the real data.
1782 */ 1164 */
1783 oldlen = sl.length (); 1165 oldlen = sl.length ();
1784 mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1785 eoldlen = esl.length (); 1166 eoldlen = esl.length ();
1786 emask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1167
1787 sl << uint16 (mask); 1168 sl << uint16 (mask);
1788
1789 if (socket.ext_mapinfos)
1790 esl << uint16 (emask);
1791 1169
1792 unsigned char dummy; 1170 unsigned char dummy;
1793 unsigned char *last_ext = &dummy; 1171 unsigned char *last_ext = &dummy;
1794 1172
1795 /* Darkness changed */ 1173 /* Darkness changed */
1807 sl << uint8 (255 - 64 * d); 1185 sl << uint8 (255 - 64 * d);
1808 } 1186 }
1809 1187
1810 lastcell.count = d; 1188 lastcell.count = d;
1811 1189
1190 mapspace &ms = m->at (nx, ny);
1191
1812 if (socket.extmap) 1192 if (socket.extmap)
1813 { 1193 {
1814 uint8 stat_hp = 0; 1194 uint8 stat_hp = 0;
1815 uint8 stat_width = 0; 1195 uint8 stat_width = 0;
1816 uint8 flags = 0; 1196 uint8 flags = 0;
1817 UUID player = 0; 1197 UUID player = 0;
1818 1198
1819 // send hp information, if applicable 1199 // send hp information, if applicable
1820 if (object *op = GET_MAP_FACE_OBJ (m, nx, ny, 0)) 1200 if (object *op = ms.faces_obj [0])
1821 { 1201 {
1822 if (op->head || op->invisible) 1202 if (op->head || op->invisible)
1823 ; // do not show 1203 ; // do not show
1824 else if (op->type == PLAYER 1204 else if (op->type == PLAYER
1825 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1205 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR))
1879 sl << uint8 (8) << uint8 (flags); 1259 sl << uint8 (8) << uint8 (flags);
1880 } 1260 }
1881 } 1261 }
1882 1262
1883 /* Floor face */ 1263 /* Floor face */
1884 if (update_space (sl, socket, m, nx, ny, ax, ay, 2)) 1264 if (update_space (sl, socket, ms, lastcell, 2))
1885 mask |= 0x4; 1265 mask |= 0x4;
1886 1266
1887 if (socket.EMI_smooth)
1888 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 2))
1889 emask |= 0x4;
1890
1891 /* Middle face */ 1267 /* Middle face */
1892 if (update_space (sl, socket, m, nx, ny, ax, ay, 1)) 1268 if (update_space (sl, socket, ms, lastcell, 1))
1893 mask |= 0x2; 1269 mask |= 0x2;
1894 1270
1895 if (socket.EMI_smooth) 1271 if (ms.player () == pl
1896 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 1)) 1272 && (pl->invisible & (pl->invisible < 50 ? 1 : 7)))
1897 emask |= 0x2;
1898
1899 if (nx == pl->x && ny == pl->y && pl->invisible & (pl->invisible < 50 ? 4 : 1))
1900 { 1273 {
1274 // force player to be visible to himself if invisible
1901 if (lastcell.faces[0] != pl->face->number) 1275 if (lastcell.faces[0] != pl->face)
1902 { 1276 {
1903 lastcell.faces[0] = pl->face->number; 1277 lastcell.faces[0] = pl->face;
1278
1904 mask |= 0x1; 1279 mask |= 0x1;
1905
1906 if (!(socket.faces_sent[pl->face->number] & NS_FACESENT_FACE))
1907 esrv_send_face (&socket, pl->face->number, 0);
1908
1909 sl << uint16 (pl->face->number); 1280 sl << uint16 (pl->face);
1281
1282 socket.send_faces (pl);
1910 } 1283 }
1911 } 1284 }
1912 else
1913 {
1914 /* Top face */ 1285 /* Top face */
1915 if (update_space (sl, socket, m, nx, ny, ax, ay, 0)) 1286 else if (update_space (sl, socket, ms, lastcell, 0))
1916 mask |= 0x1; 1287 mask |= 0x1;
1917
1918 if (socket.EMI_smooth)
1919 if (update_smooth (esl, socket, m, nx, ny, ax, ay, 0))
1920 emask |= 0x1;
1921 } 1288
1922 1289
1923 /* Check to see if we are in fact sending anything for this 1290 /* Check to see if we are in fact sending anything for this
1924 * space by checking the mask. If so, update the mask. 1291 * space by checking the mask. If so, update the mask.
1925 * if not, reset the len to that from before adding the mask 1292 * if not, reset the len to that from before adding the mask
1926 * value, so we don't send those bits. 1293 * value, so we don't send those bits.
1928 if (mask & 0xf) 1295 if (mask & 0xf)
1929 sl[oldlen + 1] = mask & 0xff; 1296 sl[oldlen + 1] = mask & 0xff;
1930 else 1297 else
1931 sl.reset (oldlen); 1298 sl.reset (oldlen);
1932 1299
1300 if (socket.ext_mapinfos)
1301 esl << uint16 (emask);
1302
1303 if (socket.EMI_smooth)
1304 {
1305 for (int layer = 2+1; layer--; )
1306 {
1307 object *ob = ms.faces_obj [layer];
1308
1309 // If there is no object for this space, or if the face for the object
1310 // is the blank face, set the smoothlevel to zero.
1311 int smoothlevel = ob && ob->face != blank_face ? ob->smoothlevel : 0;
1312
1313 // We've gotten what face we want to use for the object. Now see if
1314 // if it has changed since we last sent it to the client.
1315 if (lastcell.smooth[layer] != smoothlevel)
1316 {
1317 lastcell.smooth[layer] = smoothlevel;
1318 esl << uint8 (smoothlevel);
1319 emask |= 1 << layer;
1320 }
1321 }
1322
1933 if (emask & 0xf) 1323 if (emask & 0xf)
1934 esl[eoldlen + 1] = emask & 0xff; 1324 esl[eoldlen + 1] = emask & 0xff;
1935 else 1325 else
1936 esl.reset (eoldlen); 1326 esl.reset (eoldlen);
1327 }
1937 } /* else this is a viewable space */ 1328 } /* else this is a viewable space */
1938 } /* for x loop */ 1329 } /* for x loop */
1939 } /* for y loop */ 1330 } /* for y loop */
1940 1331
1941 /* Verify that we in fact do need to send this */ 1332 /* Verify that we in fact do need to send this */
1944 if (!(sl.length () > startlen || socket.sent_scroll)) 1335 if (!(sl.length () > startlen || socket.sent_scroll))
1945 { 1336 {
1946 /* No map data will follow, so don't say the client 1337 /* No map data will follow, so don't say the client
1947 * it doesn't need draw! 1338 * it doesn't need draw!
1948 */ 1339 */
1949 ewhatflag &= (~EMI_NOREDRAW); 1340 ewhatflag &= ~EMI_NOREDRAW;
1950 esl[ewhatstart + 1] = ewhatflag & 0xff; 1341 esl[ewhatstart + 1] = ewhatflag & 0xff;
1951 } 1342 }
1952 1343
1953 if (esl.length () > estartlen) 1344 if (esl.length () > estartlen)
1954 socket.send_packet (esl); 1345 socket.send_packet (esl);
1966 */ 1357 */
1967void 1358void
1968draw_client_map (object *pl) 1359draw_client_map (object *pl)
1969{ 1360{
1970 int i, j; 1361 int i, j;
1971 sint16 ax, ay, nx, ny; /* ax and ay goes from 0 to max-size of arrays */ 1362 sint16 ax, ay; /* ax and ay goes from 0 to max-size of arrays */
1972 New_Face *face, *floor;
1973 New_Face *floor2;
1974 int d, mflags; 1363 int mflags;
1975 struct Map newmap; 1364 struct Map newmap;
1976 maptile *m, *pm; 1365 maptile *m, *pm;
1977 1366
1978 if (pl->type != PLAYER) 1367 if (pl->type != PLAYER)
1979 { 1368 {
2160 1549
2161/* appends the spell *spell to the Socklist we will send the data to. */ 1550/* appends the spell *spell to the Socklist we will send the data to. */
2162static void 1551static void
2163append_spell (player *pl, packet &sl, object *spell) 1552append_spell (player *pl, packet &sl, object *spell)
2164{ 1553{
2165 int len, i, skill = 0; 1554 int i, skill = 0;
2166 1555
2167 if (!(spell->name)) 1556 if (!(spell->name))
2168 { 1557 {
2169 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1558 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
2170 return; 1559 return;
2182 if (!strcmp (spell->skill, skill_names[i])) 1571 if (!strcmp (spell->skill, skill_names[i]))
2183 { 1572 {
2184 skill = i + CS_STAT_SKILLINFO; 1573 skill = i + CS_STAT_SKILLINFO;
2185 break; 1574 break;
2186 } 1575 }
1576 }
1577
1578 // spells better have a face
1579 if (!spell->face)
1580 {
1581 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1582 spell->face = face_find ("burnout.x11", blank_face);
2187 } 1583 }
2188 1584
2189 /* send the current values */ 1585 /* send the current values */
2190 sl << uint32 (spell->count) 1586 sl << uint32 (spell->count)
2191 << uint16 (spell->level) 1587 << uint16 (spell->level)
2193 << uint16 (spell->last_sp) 1589 << uint16 (spell->last_sp)
2194 << uint16 (spell->last_grace) 1590 << uint16 (spell->last_grace)
2195 << uint16 (spell->last_eat) 1591 << uint16 (spell->last_eat)
2196 << uint8 (skill) 1592 << uint8 (skill)
2197 << uint32 (spell->path_attuned) 1593 << uint32 (spell->path_attuned)
2198 << uint32 (spell->face ? spell->face->number : 0) 1594 << uint32 (spell->face)
2199 << data8 (spell->name) 1595 << data8 (spell->name)
2200 << data16 (spell->msg); 1596 << data16 (spell->msg);
2201} 1597}
2202 1598
2203/** 1599/**
2218 1614
2219 packet sl ("addspell"); 1615 packet sl ("addspell");
2220 1616
2221 if (!spell) 1617 if (!spell)
2222 { 1618 {
2223 for (spell = pl->ob->inv; spell != NULL; spell = spell->below) 1619 for (spell = pl->ob->inv; spell; spell = spell->below)
2224 { 1620 {
2225 /* were we to simply keep appending data here, we could exceed 1621 /* were we to simply keep appending data here, we could exceed
2226 * MAXSOCKBUF if the player has enough spells to add, we know that 1622 * MAXSOCKBUF if the player has enough spells to add, we know that
2227 * append_spells will always append 19 data bytes, plus 4 length 1623 * append_spells will always append 19 data bytes, plus 4 length
2228 * bytes and 3 strings (because that is the spec) so we need to 1624 * bytes and 3 strings (because that is the spec) so we need to

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines