ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/socket/request.C
(Generate patch)

Comparing deliantra/server/socket/request.C (file contents):
Revision 1.97 by root, Thu May 17 14:14:56 2007 UTC vs.
Revision 1.134 by root, Mon Jul 14 23:57:46 2008 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2001 Mark Wedel 5 * Copyright (©) 2001,2007 Mark Wedel
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The author can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/** 24/**
26 * \file 25 * \file
27 * Client handling. 26 * Client handling.
… …
130} 129}
131 130
132static void 131static void
133clear_map (player *pl) 132clear_map (player *pl)
134{ 133{
134 pl->ns->mapinfo_queue_clear ();
135
135 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap)); 136 memset (&pl->ns->lastmap, 0, sizeof (pl->ns->lastmap));
136 137
137 pl->ns->force_newmap = false; 138 pl->ns->force_newmap = false;
138 139
139 if (pl->ns->newmapcmd == 1) 140 if (pl->ns->newmapcmd == 1)
140 pl->ns->send_packet ("newmap"); 141 pl->ns->send_packet ("newmap");
141 142
142 pl->ns->floorbox_reset (); 143 pl->ns->floorbox_reset ();
144}
145
146static void
147send_map_info (player *pl)
148{
149 client &socket = *pl->ns;
150 object *ob = pl->observe;
151
152 if (socket.mapinfocmd)
153 {
154 if (ob->map && ob->map->path[0])
155 {
156 int flags = 0;
157
158 if (ob->map->tile_path[0]) flags |= 1;
159 if (ob->map->tile_path[1]) flags |= 2;
160 if (ob->map->tile_path[2]) flags |= 4;
161 if (ob->map->tile_path[3]) flags |= 8;
162
163 socket.send_packet_printf ("mapinfo - spatial %d %d %d %d %d %s",
164 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y,
165 ob->map->width, ob->map->height, &ob->map->path);
166 }
167 else
168 socket.send_packet ("mapinfo current");
169 }
143} 170}
144 171
145/** check for map/region change and send new map data */ 172/** check for map/region change and send new map data */
146static void 173static void
147check_map_change (player *pl) 174check_map_change (player *pl)
148{ 175{
149 client &socket = *pl->ns; 176 client &socket = *pl->ns;
150 object *ob = pl->ob; 177 object *ob = pl->observe;
151 char buf[MAX_BUF]; /* eauugggh */ 178
179 region *reg = ob->region ();
180 if (socket.current_region != reg)
181 {
182 INVOKE_PLAYER (REGION_CHANGE, pl, ARG_REGION (reg), ARG_REGION (socket.current_region));
183 socket.current_region = reg;
184 }
185
186 // first try to aovid a full newmap on tiled map scrolls
187 if (socket.current_map != ob->map && !socket.force_newmap)
188 {
189 rv_vector rv;
190
191 get_rangevector_from_mapcoord (socket.current_map, socket.current_x, socket.current_y, ob, &rv, 0);
192
193 // manhattan distance is very handy here
194 if (rv.distance < 8) // 8 works nicely for speed << 70 and buggy gcfclient
195 {
196 socket.current_map = ob->map;
197 socket.current_x = ob->x;
198 socket.current_y = ob->y;
199
200 socket_map_scroll (&socket, rv.distance_x, rv.distance_y);
201 socket.floorbox_reset ();
202 send_map_info (pl);
203 }
204 }
152 205
153 if (socket.current_map != ob->map || socket.force_newmap) 206 if (socket.current_map != ob->map || socket.force_newmap)
154 { 207 {
155 clear_map (pl); 208 clear_map (pl);
156 socket.current_map = ob->map; 209 socket.current_map = ob->map;
157 210 send_map_info (pl);
158 if (socket.mapinfocmd)
159 {
160 if (ob->map && ob->map->path[0])
161 {
162 int flags = 0;
163
164 if (ob->map->tile_path[0]) flags |= 1;
165 if (ob->map->tile_path[1]) flags |= 2;
166 if (ob->map->tile_path[2]) flags |= 4;
167 if (ob->map->tile_path[3]) flags |= 8;
168
169 snprintf (buf, MAX_BUF, "mapinfo - spatial %d %d %d %d %d %s",
170 flags, socket.mapx / 2 - ob->x, socket.mapy / 2 - ob->y, ob->map->width, ob->map->height, &ob->map->path);
171 }
172 else
173 snprintf (buf, MAX_BUF, "mapinfo current");
174
175 socket.send_packet (buf);
176 }
177 } 211 }
178 else if (socket.current_x != ob->x || socket.current_y != ob->y) 212 else if (socket.current_x != ob->x || socket.current_y != ob->y)
179 { 213 {
180 int dx = ob->x - socket.current_x; 214 int dx = ob->x - socket.current_x;
181 int dy = ob->y - socket.current_y; 215 int dy = ob->y - socket.current_y;
… …
189 } 223 }
190 } 224 }
191 225
192 socket.current_x = ob->x; 226 socket.current_x = ob->x;
193 socket.current_y = ob->y; 227 socket.current_y = ob->y;
194
195 region *reg = ob->region ();
196 if (socket.current_region != reg)
197 {
198 socket.current_region = reg;
199 socket.send_packet_printf ("drawinfo 0 You are now %s.\n(use whereami for more details)", &reg->longname);
200 }
201} 228}
202 229
203/** 230/**
204 * RequestInfo is sort of a meta command. There is some specific 231 * RequestInfo is sort of a meta command. There is some specific
205 * request of information, but we call other functions to provide 232 * request of information, but we call other functions to provide
206 * that information. 233 * that information.
207 */ 234 */
208void 235void
209RequestInfo (char *buf, int len, client * ns) 236RequestInfo (char *buf, int len, client *ns)
210{ 237{
211 char *params = NULL, *cp; 238 char *params;
212
213 /* No match */
214 char bigbuf[MAX_BUF];
215 int slen;
216
217 /* Set up replyinfo before we modify any of the buffers - this is used
218 * if we don't find a match.
219 */
220 strcpy (bigbuf, "replyinfo ");
221 slen = strlen (bigbuf);
222 safe_strcat (bigbuf, buf, &slen, MAX_BUF);
223 239
224 /* find the first space, make it null, and update the 240 /* find the first space, make it null, and update the
225 * params pointer. 241 * params pointer.
226 */ 242 */
227 for (cp = buf; *cp != '\0'; cp++) 243 for (params = buf; *params; params++)
228 if (*cp == ' ') 244 if (*params == ' ')
229 { 245 {
230 *cp = '\0';
231 params = cp + 1; 246 *params++ = 0;
232 break; 247 break;
233 } 248 }
234 249
235 if (!strcmp (buf, "image_info")) 250 if (!strcmp (buf, "image_info"))
236 send_image_info (ns, params); 251 send_image_info (ns, params);
… …
239 else if (!strcmp (buf, "skill_info")) 254 else if (!strcmp (buf, "skill_info"))
240 send_skill_info (ns, params); 255 send_skill_info (ns, params);
241 else if (!strcmp (buf, "spell_paths")) 256 else if (!strcmp (buf, "spell_paths"))
242 send_spell_paths (ns, params); 257 send_spell_paths (ns, params);
243 else 258 else
244 ns->send_packet (bigbuf, len); 259 {
260 // undo tokenisation above and send replyinfo with the request unchanged
261 if (*params)
262 *--params = ' ';
263
264 ns->send_packet_printf ("replyinfo %s", buf);
265 }
245} 266}
246 267
247void 268void
248ExtCmd (char *buf, int len, player *pl) 269ExtCmd (char *buf, int len, player *pl)
249{ 270{
… …
252 273
253void 274void
254ExtiCmd (char *buf, int len, client *ns) 275ExtiCmd (char *buf, int len, client *ns)
255{ 276{
256 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len)); 277 INVOKE_CLIENT (EXTICMD, ns, ARG_DATA (buf, len));
278}
279
280void
281client::mapinfo_queue_clear ()
282{
283 for (auto (i, mapinfo_queue.begin ()); i != mapinfo_queue.end (); ++i)
284 free (*i);
285
286 mapinfo_queue.clear ();
287}
288
289bool
290client::mapinfo_try (char *buf)
291{
292 char *token = buf;
293 buf += strlen (buf) + 9;
294
295 // initial map and its origin
296 maptile *map = pl->observe->map;
297 int mapx = pl->ns->mapx / 2 - pl->observe->x;
298 int mapy = pl->ns->mapy / 2 - pl->observe->y;
299 int max_distance = 8; // limit maximum path length to something generous
300
301 while (*buf && map && max_distance)
302 {
303 int dir = *buf++ - '1';
304
305 if (dir >= 0 && dir <= 3)
306 {
307 if (!map->tile_path [dir])
308 map = 0;
309 else if (map->tile_available (dir, false))
310 {
311 maptile *neigh = map->tile_map [dir];
312
313 switch (dir)
314 {
315 case 0: mapy -= neigh->height; break;
316 case 2: mapy += map ->height; break;
317 case 3: mapx -= neigh->width ; break;
318 case 1: mapx += map ->width ; break;
319 }
320
321 map = neigh;
322 --max_distance;
323 }
324 else
325 return 0;
326 }
327 else
328 max_distance = 0;
329 }
330
331 if (!max_distance)
332 send_packet_printf ("mapinfo %s error", token);
333 else if (!map || !map->path)
334 send_packet_printf ("mapinfo %s nomap", token);
335 else
336 {
337 int flags = 0;
338
339 if (map->tile_path[0]) flags |= 1;
340 if (map->tile_path[1]) flags |= 2;
341 if (map->tile_path[2]) flags |= 4;
342 if (map->tile_path[3]) flags |= 8;
343
344 send_packet_printf ("mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
345 }
346
347 return 1;
348}
349
350void
351client::mapinfo_queue_run ()
352{
353 if (mapinfo_queue.empty () || !pl)
354 return;
355
356 for (int i = 0; i < mapinfo_queue.size (); ++i)
357 if (mapinfo_try (mapinfo_queue [i]))
358 {
359 free (mapinfo_queue [i]);
360 mapinfo_queue.erase (i);
361 }
362 else
363 ++i;
257} 364}
258 365
259void 366void
260MapInfoCmd (char *buf, int len, player *pl) 367MapInfoCmd (char *buf, int len, player *pl)
261{ 368{
262 // <mapinfo tag spatial tile-path 369 // <mapinfo tag spatial tile-path
263 // >mapinfo tag spatial flags x y w h hash 370 // >mapinfo tag spatial flags x y w h hash
264 371
265 char bigbuf[MAX_BUF], *token;
266
267 token = buf; 372 char *token = buf;
268 // copy token 373
269 if (!(buf = strchr (buf, ' '))) 374 if (!(buf = strchr (buf, ' ')))
270 return; 375 return;
271 376
272 *buf++ = 0;
273
274 if (!strncmp (buf, "spatial ", 8)) 377 if (!strncmp (buf, " spatial ", 9))
275 { 378 {
276 buf += 8; 379 char *copy = strdup (token);
380 copy [buf - token] = 0;
277 381
278 // initial map and its origin 382#if 0
279 maptile *map = pl->ob->map; 383 // this makes only sense when we flush the buffer immediately
280 sint16 dx, dy; 384 if (pl->ns->mapinfo_try (copy))
281 int mapx = pl->ns->mapx / 2 - pl->ob->x; 385 free (copy);
282 int mapy = pl->ns->mapy / 2 - pl->ob->y;
283 int max_distance = 8; // limit maximum path length to something generous
284
285 while (*buf && map && max_distance)
286 {
287 int dir = *buf++;
288
289 switch (dir)
290 {
291 case '1':
292 dx = 0;
293 dy = -1;
294 map = map->xy_find (dx, dy);
295 map && (mapy -= map->height);
296 break;
297 case '2':
298 mapx += map->width;
299 dx = map->width;
300 dy = 0;
301 map = map->xy_find (dx, dy);
302 break;
303 case '3':
304 mapy += map->height;
305 dx = 0;
306 dy = map->height;
307 map = map->xy_find (dx, dy);
308 break;
309 case '4':
310 dx = -1;
311 dy = 0;
312 map = map->xy_find (dx, dy);
313 map && (mapx -= map->width);
314 break;
315 }
316
317 --max_distance;
318 }
319
320 if (!max_distance)
321 snprintf (bigbuf, MAX_BUF, "mapinfo %s error", token);
322 else if (map && map->path[0])
323 {
324 int flags = 0;
325
326 if (map->tile_path[0]) flags |= 1;
327 if (map->tile_path[1]) flags |= 2;
328 if (map->tile_path[2]) flags |= 4;
329 if (map->tile_path[3]) flags |= 8;
330
331 snprintf (bigbuf, MAX_BUF, "mapinfo %s spatial %d %d %d %d %d %s", token, flags, mapx, mapy, map->width, map->height, &map->path);
332 }
333 else 386 else
334 snprintf (bigbuf, MAX_BUF, "mapinfo %s nomap", token); 387#endif
388 pl->ns->mapinfo_queue.push_back (copy);
335 } 389 }
336 else 390 else
337 snprintf (bigbuf, MAX_BUF, "mapinfo %s unsupported", token); 391 pl->ns->send_packet_printf ("mapinfo %s unsupported", token);
338
339 pl->ns->send_packet (bigbuf);
340} 392}
341 393
342/** This is the Setup cmd */ 394/** This is the Setup cmd */
343void 395void
344SetUp (char *buf, int len, client * ns) 396SetUp (char *buf, int len, client * ns)
… …
473 525
474 ns->send_packet (cmdback); 526 ns->send_packet (cmdback);
475} 527}
476 528
477/** 529/**
478 * client requested an image. send it rate-limited
479 * before flushing.
480 */
481void
482AskFaceCmd (char *buf, int len, client *ns)
483{
484 ns->askface.push_back (atoi (buf));
485}
486
487/**
488 * Tells client the picture it has to use
489 * to smooth a picture number given as argument.
490 */
491void
492AskSmooth (char *buf, int len, client *ns)
493{
494 ns->send_face (atoi (buf));
495 ns->flush_fx ();
496}
497
498/**
499 * This handles the general commands from the client (ie, north, fire, cast, 530 * This handles the general commands from the client (ie, north, fire, cast,
500 * etc.) 531 * etc.)
501 */ 532 */
502void 533void
503PlayerCmd (char *buf, int len, player *pl) 534PlayerCmd (char *buf, int len, player *pl)
… …
524 * commands. 555 * commands.
525 */ 556 */
526 pl->count = 0; 557 pl->count = 0;
527} 558}
528 559
529
530/** 560/**
531 * This handles the general commands from the client (ie, north, fire, cast, 561 * This handles the general commands from the client (ie, north, fire, cast,
532 * etc.). It is a lot like PlayerCmd above, but is called with the 562 * etc.). It is a lot like PlayerCmd above, but is called with the
533 * 'ncom' method which gives more information back to the client so it 563 * 'ncom' method which gives more information back to the client so it
534 * can throttle. 564 * can throttle.
… …
536void 566void
537NewPlayerCmd (char *buf, int len, player *pl) 567NewPlayerCmd (char *buf, int len, player *pl)
538{ 568{
539 if (len <= 6) 569 if (len <= 6)
540 { 570 {
541 LOG (llevDebug, "Corrupt ncom command <%s> not long enough - discarding\n", buf); 571 LOG (llevDebug, "%s: corrupt ncom command <%s>: not long enough (%d) - discarding\n", pl->ns->host, buf, len);
542 return; 572 return;
543 } 573 }
544 574
545 uint16 cmdid = net_uint16 ((uint8 *)buf); 575 uint16 cmdid = net_uint16 ((uint8 *)buf);
546 sint32 repeat = net_sint32 ((uint8 *)buf + 2); 576 sint32 repeat = net_sint32 ((uint8 *)buf + 2);
… …
684 * syntax is: move (to) (tag) (nrof) 714 * syntax is: move (to) (tag) (nrof)
685 */ 715 */
686void 716void
687MoveCmd (char *buf, int len, player *pl) 717MoveCmd (char *buf, int len, player *pl)
688{ 718{
689 int vals[3], i; 719 int to, tag, nrof;
690 720
691 /* A little funky here. We only cycle for 2 records, because 721 if (3 != sscanf (buf, "%d %d %d", &to, &tag, &nrof))
692 * we obviously are not going to find a space after the third
693 * record. Perhaps we should just replace this with a
694 * sscanf?
695 */
696 for (i = 0; i < 2; i++)
697 { 722 {
698 vals[i] = atoi (buf);
699
700 if (!(buf = strchr (buf, ' ')))
701 {
702 LOG (llevError, "Incomplete move command: %s\n", buf); 723 LOG (llevError, "Incomplete move command: %s\n", buf);
703 return; 724 return;
704 }
705
706 buf++;
707 } 725 }
708 726
709 vals[2] = atoi (buf); 727 esrv_move_object (pl->ob, to, tag, nrof);
710
711/* LOG(llevDebug,"Move item %d (nrof=%d) to %d.\n", vals[1], vals[2], vals[0]);*/
712 esrv_move_object (pl->ob, vals[0], vals[1], vals[2]);
713} 728}
714 729
715/****************************************************************************** 730/******************************************************************************
716 * 731 *
717 * Start of commands the server sends to the client. 732 * Start of commands the server sends to the client.
… …
740 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name; 755 buf << " Range" << (pl->ob->current_weapon == pl->ranged_ob ? "*" : "") << ": " << pl->ranged_ob->name;
741 756
742 if (pl->combat_ob) 757 if (pl->combat_ob)
743 buf << " Combat" << (pl->ob->current_weapon == pl->combat_ob ? "*" : "") << ": " << pl->combat_ob->name; 758 buf << " Combat" << (pl->ob->current_weapon == pl->combat_ob ? "*" : "") << ": " << pl->combat_ob->name;
744 759
760#if 0
761 //TODO: remove this when slot system is working, this is only for debugging
762 if (pl->ob->chosen_skill)
763 buf << " Skill*: " << pl->ob->chosen_skill->name;
764#endif
765
745 //TODO: maybe golem should become the current_weapon, quite simply? 766 //TODO: maybe golem should become the current_weapon, quite simply?
746 if (pl->golem) 767 if (pl->golem)
747 buf << " Golem*: " << pl->golem->name; 768 buf << " Golem*: " << pl->golem->name;
748 769
770 buf << '\0';
749 buf.linearise (obuf); 771 buf.linearise (obuf);
750 obuf [buf.size ()] = 0;
751} 772}
752 773
753#define AddIfInt64(Old,New,Type) if (Old != New) {\ 774#define AddIfInt64(Old,New,Type) if (Old != New) {\
754 Old = New; \ 775 Old = New; \
755 sl << uint8 (Type) << uint64 (New); \ 776 sl << uint8 (Type) << uint64 (New); \
… …
763#define AddIfShort(Old,New,Type) if (Old != New) {\ 784#define AddIfShort(Old,New,Type) if (Old != New) {\
764 Old = New; \ 785 Old = New; \
765 sl << uint8 (Type) << uint16 (New); \ 786 sl << uint8 (Type) << uint16 (New); \
766 } 787 }
767 788
768#define AddIfFloat(Old,New,Type) if (Old != New) {\ 789#define AddIfFloat(Old,New,Type,mult) if (Old != New) {\
769 Old = New; \ 790 Old = New; \
770 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI); \ 791 sl << uint8 (Type) << uint32 (New*FLOAT_MULTI*mult); \
771 } 792 }
772 793
773#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\ 794#define AddIfString(Old,New,Type) if (Old == NULL || strcmp(Old,New)) {\
774 free(Old); Old = strdup (New);\ 795 free(Old); Old = strdup (New);\
775 sl << uint8 (Type) << data8 (New); \ 796 sl << uint8 (Type) << data8 (New); \
… …
789 810
790 client *ns = pl->ns; 811 client *ns = pl->ns;
791 if (!ns) 812 if (!ns)
792 return; 813 return;
793 814
794 object *ob = pl->ob; 815 object *ob = pl->observe;
795 if (!ob) 816 if (!ob)
796 return; 817 return;
818
819 player *opl = ob->contr ? static_cast<player *>(ob->contr) : pl;
797 820
798 packet sl ("stats"); 821 packet sl ("stats");
799 822
800 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP); 823 AddIfShort (ns->last_stats.hp, ob->stats.hp, CS_STAT_HP);
801 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP); 824 AddIfShort (ns->last_stats.maxhp, ob->stats.maxhp, CS_STAT_MAXHP);
… …
810 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS); 833 AddIfShort (ns->last_stats.Wis, ob->stats.Wis, CS_STAT_WIS);
811 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW); 834 AddIfShort (ns->last_stats.Pow, ob->stats.Pow, CS_STAT_POW);
812 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA); 835 AddIfShort (ns->last_stats.Cha, ob->stats.Cha, CS_STAT_CHA);
813 836
814 for (int s = 0; s < NUM_SKILLS; s++) 837 for (int s = 0; s < NUM_SKILLS; s++)
815 if (object *skill = pl->last_skill_ob[s]) 838 if (object *skill = opl->last_skill_ob[s])
816 if (skill->stats.exp != ns->last_skill_exp [s]) 839 if (skill->stats.exp != ns->last_skill_exp [s])
817 { 840 {
818 ns->last_skill_exp [s] = skill->stats.exp; 841 ns->last_skill_exp [s] = skill->stats.exp;
819 842
820 /* Always send along the level if exp changes. This is only 843 /* Always send along the level if exp changes. This is only
… …
828 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64); 851 AddIfInt64 (ns->last_stats.exp, ob->stats.exp, CS_STAT_EXP64);
829 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL); 852 AddIfShort (ns->last_level, ob->level, CS_STAT_LEVEL);
830 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC); 853 AddIfShort (ns->last_stats.wc, ob->stats.wc, CS_STAT_WC);
831 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC); 854 AddIfShort (ns->last_stats.ac, ob->stats.ac, CS_STAT_AC);
832 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM); 855 AddIfShort (ns->last_stats.dam, ob->stats.dam, CS_STAT_DAM);
833 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED); 856 AddIfFloat (ns->last_speed, ob->speed, CS_STAT_SPEED, 1.f/TICK);
834 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD); 857 AddIfShort (ns->last_stats.food, ob->stats.food, CS_STAT_FOOD);
835 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP); 858 AddIfFloat (ns->last_weapon_sp, pl->weapon_sp, CS_STAT_WEAP_SP, 1.f/TICK);
836 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM); 859 AddIfInt (ns->last_weight_limit, weight_limit[ob->stats.Str], CS_STAT_WEIGHT_LIM);
837 860
838 flags = 0; 861 flags = 0;
839 862
840 if (pl->fire_on) 863 if (opl->fire_on)
841 flags |= SF_FIREON; 864 flags |= SF_FIREON;
842 865
843 if (pl->run_on) 866 if (opl->run_on)
844 flags |= SF_RUNON; 867 flags |= SF_RUNON;
845 868
846 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS); 869 AddIfShort (ns->last_flags, flags, CS_STAT_FLAGS);
847 870
848 if (ns->sc_version < 1025) 871 if (ns->sc_version < 1025)
… …
862 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE); 885 AddIfInt (ns->last_path_attuned, ob->path_attuned, CS_STAT_SPELL_ATTUNE);
863 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL); 886 AddIfInt (ns->last_path_repelled, ob->path_repelled, CS_STAT_SPELL_REPEL);
864 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY); 887 AddIfInt (ns->last_path_denied, ob->path_denied, CS_STAT_SPELL_DENY);
865 } 888 }
866 889
867 rangetostring (pl, buf); /* we want use the new fire & run system in new client */ 890 rangetostring (opl, buf); /* we want use the new fire & run system in new client */
868 AddIfString (ns->stats.range, buf, CS_STAT_RANGE); 891 AddIfString (ns->stats.range, buf, CS_STAT_RANGE);
869 set_title (ob, buf); 892 set_title (ob, buf);
870 AddIfString (ns->stats.title, buf, CS_STAT_TITLE); 893 AddIfString (ns->stats.title, buf, CS_STAT_TITLE);
871 894
872 /* Only send it away if we have some actual data */ 895 /* Only send it away if we have some actual data */
… …
876 899
877/** 900/**
878 * Tells the client that here is a player it should start using. 901 * Tells the client that here is a player it should start using.
879 */ 902 */
880void 903void
881esrv_new_player (player *pl, uint32 weight) 904esrv_new_player (player *pl)
882{ 905{
906 sint32 weight = pl->ob->client_weight ();
907
883 packet sl ("player"); 908 packet sl ("player");
884 909
885 sl << uint32 (pl->ob->count) 910 sl << uint32 (pl->ob->count)
886 << uint32 (weight) 911 << uint32 (weight)
887 << uint32 (pl->ob->face) 912 << uint32 (pl->ob->face)
… …
954 979
955 if (!ns.faces_sent[face_num]) 980 if (!ns.faces_sent[face_num])
956 if (ob) 981 if (ob)
957 ns.send_faces (ob); 982 ns.send_faces (ob);
958 else 983 else
959 ns.send_face (face_num); 984 ns.send_face (face_num, 10);
960 985
961 sl << uint16 (face_num); 986 sl << uint16 (face_num);
962 return 1; 987 return 1;
963 } 988 }
964 989
… …
1006{ 1031{
1007 prefetch_surrounding_maps (op->map, 3); 1032 prefetch_surrounding_maps (op->map, 3);
1008} 1033}
1009 1034
1010/** 1035/**
1011 * This function uses the new map1 protocol command to send the map 1036 * Draws client map.
1012 * to the client. It is necessary because the old map command supports
1013 * a maximum map size of 15x15.
1014 * This function is much simpler than the old one. This is because
1015 * the old function optimized to send as few face identifiers as possible,
1016 * at the expense of sending more coordinate location (coordinates were
1017 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1018 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1019 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1020 * and use the other 4 bits for other informatiion. For full documentation
1021 * of what we send, see the doc/Protocol file.
1022 * I will describe internally what we do:
1023 * the ns->lastmap shows how the map last looked when sent to the client.
1024 * in the lastmap structure, there is a cells array, which is set to the
1025 * maximum viewable size (As set in config.h).
1026 * in the cells, there are faces and a count value.
1027 * we use the count value to hold the darkness value. If -1, then this space
1028 * is not viewable.
1029 * we use faces[0] faces[1] faces[2] to hold what the three layers
1030 * look like.
1031 */ 1037 */
1032void 1038void
1033draw_client_map1 (object *pl) 1039draw_client_map (player *pl)
1034{ 1040{
1041 object *ob = pl->observe;
1042 if (!ob->active)
1043 return;
1044
1045 maptile *plmap = ob->map;
1046
1047 /* If player is just joining the game, he isn't here yet, so the map
1048 * can get swapped out. If so, don't try to send them a map. All will
1049 * be OK once they really log in.
1050 */
1051 if (!plmap || plmap->in_memory != MAP_ACTIVE)
1052 return;
1053
1035 int x, y, ax, ay, startlen, max_x, max_y, oldlen; 1054 int x, y, ax, ay, startlen, max_x, max_y, oldlen;
1036 sint16 nx, ny;
1037 int estartlen, eoldlen; 1055 int estartlen, eoldlen;
1038 uint8 eentrysize; 1056 uint8 eentrysize;
1039 uint16 ewhatstart, ewhatflag; 1057 uint16 ewhatstart, ewhatflag;
1040 uint8 extendedinfos; 1058 uint8 extendedinfos;
1041 maptile *m;
1042 1059
1043 client &socket = *pl->contr->ns;
1044
1045 if (!pl->active)
1046 return;
1047
1048 check_map_change (pl->contr); 1060 check_map_change (pl);
1049 prefetch_surrounding_maps (pl); 1061 prefetch_surrounding_maps (pl->ob);
1062
1063 /* do LOS after calls to update_position */
1064 if (ob != pl->ob)
1065 clear_los (pl);
1066 else if (pl->do_los)
1067 {
1068 update_los (ob);
1069 pl->do_los = 0;
1070 }
1071
1072 /**
1073 * This function uses the new map1 protocol command to send the map
1074 * to the client. It is necessary because the old map command supports
1075 * a maximum map size of 15x15.
1076 * This function is much simpler than the old one. This is because
1077 * the old function optimized to send as few face identifiers as possible,
1078 * at the expense of sending more coordinate location (coordinates were
1079 * only 1 byte, faces 2 bytes, so this was a worthwhile savings). Since
1080 * we need 2 bytes for coordinates and 2 bytes for faces, such a trade off
1081 * maps no sense. Instead, we actually really only use 12 bits for coordinates,
1082 * and use the other 4 bits for other informatiion. For full documentation
1083 * of what we send, see the doc/Protocol file.
1084 * I will describe internally what we do:
1085 * the ns->lastmap shows how the map last looked when sent to the client.
1086 * in the lastmap structure, there is a cells array, which is set to the
1087 * maximum viewable size (As set in config.h).
1088 * in the cells, there are faces and a count value.
1089 * we use the count value to hold the darkness value. If -1, then this space
1090 * is not viewable.
1091 * we use faces[0] faces[1] faces[2] to hold what the three layers
1092 * look like.
1093 */
1094
1095 client &socket = *pl->ns;
1050 1096
1051 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a"); 1097 packet sl (socket.mapmode == Map1Cmd ? "map1" : "map1a");
1052 packet esl; 1098 packet esl;
1053 1099
1054 startlen = sl.length (); 1100 startlen = sl.length ();
… …
1078 ay = 0; 1124 ay = 0;
1079 1125
1080 /* We could do this logic as conditionals in the if statement, 1126 /* We could do this logic as conditionals in the if statement,
1081 * but that started to get a bit messy to look at. 1127 * but that started to get a bit messy to look at.
1082 */ 1128 */
1083 max_x = pl->x + (socket.mapx + 1) / 2; 1129 max_x = ob->x + (socket.mapx + 1) / 2;
1084 max_y = pl->y + (socket.mapy + 1) / 2; 1130 max_y = ob->y + (socket.mapy + 1) / 2;
1085 1131
1086 maptile *plmap = pl->map;
1087
1088 for (y = pl->y - socket.mapy / 2; y < max_y; y++, ay++) 1132 for (y = ob->y - socket.mapy / 2; y < max_y; y++, ay++)
1089 { 1133 {
1134 sint16 nx, ny;
1135 maptile *m = 0;
1136
1090 ax = 0; 1137 ax = 0;
1091 for (x = pl->x - socket.mapx / 2; x < max_x; x++, ax++) 1138 for (x = ob->x - socket.mapx / 2; x < max_x; x++, ax++)
1092 { 1139 {
1140 // check to see if we can simply go one right quickly
1141 ++nx;
1142 if (m && nx >= m->width)
1143 m = 0;
1144
1145 if (!m)
1146 {
1147 nx = x; ny = y; m = plmap;
1148
1149 if (xy_normalise (m, nx, ny))
1150 m->touch ();
1151 else
1152 m = 0;
1153 }
1154
1093 int emask, mask; 1155 int emask, mask;
1094 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4; 1156 emask = mask = (ax & 0x3f) << 10 | (ay & 0x3f) << 4;
1095 1157
1096 MapCell &lastcell = socket.lastmap.cells[ax][ay]; 1158 MapCell &lastcell = socket.lastmap.cells[ax][ay];
1097 1159
1098 /* If the coordinates are not valid, or it is too dark to see, 1160 /* If the coordinates are not valid, or it is too dark to see,
1099 * we tell the client as such 1161 * we tell the client as such
1100 */ 1162 */
1101 nx = x;
1102 ny = y;
1103 m = get_map_from_coord (plmap, &nx, &ny);
1104
1105 if (!m) 1163 if (!m)
1106 { 1164 {
1107 /* space is out of map. Update space and clear values 1165 /* space is out of map. Update space and clear values
1108 * if this hasn't already been done. If the space is out 1166 * if this hasn't already been done. If the space is out
1109 * of the map, it shouldn't have a head 1167 * of the map, it shouldn't have a head
… …
1115 } 1173 }
1116 1174
1117 continue; 1175 continue;
1118 } 1176 }
1119 1177
1120 m->touch ();
1121
1122 int d = pl->contr->blocked_los[ax][ay]; 1178 int d = pl->blocked_los[ax][ay];
1123 1179
1124 if (d > 3) 1180 if (d > 3)
1125 { 1181 {
1126
1127 int need_send = 0, count; 1182 int need_send = 0, count;
1128 1183
1129 /* This block deals with spaces that are not visible for whatever 1184 /* This block deals with spaces that are not visible for whatever
1130 * reason. Still may need to send the head for this space. 1185 * reason. Still may need to send the head for this space.
1131 */ 1186 */
… …
1137 if (lastcell.count != -1) 1192 if (lastcell.count != -1)
1138 need_send = 1; 1193 need_send = 1;
1139 1194
1140 count = -1; 1195 count = -1;
1141 1196
1142 /* properly clear a previously sent big face */
1143 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2] 1197 if (lastcell.faces[0] || lastcell.faces[1] || lastcell.faces[2]
1144 || lastcell.stat_hp || lastcell.flags || lastcell.player) 1198 || lastcell.stat_hp || lastcell.flags || lastcell.player)
1145 need_send = 1; 1199 need_send = 1;
1146 1200
1201 /* properly clear a previously sent big face */
1147 map_clearcell (&lastcell, count); 1202 map_clearcell (&lastcell, count);
1148 1203
1149 if ((mask & 0xf) || need_send) 1204 if ((mask & 0xf) || need_send)
1150 sl[oldlen + 1] = mask & 0xff; 1205 sl[oldlen + 1] = mask & 0xff;
1151 else 1206 else
… …
1190 } 1245 }
1191 1246
1192 lastcell.count = d; 1247 lastcell.count = d;
1193 1248
1194 mapspace &ms = m->at (nx, ny); 1249 mapspace &ms = m->at (nx, ny);
1250 ms.update ();
1195 1251
1196 if (socket.extmap) 1252 if (socket.extmap)
1197 { 1253 {
1198 uint8 stat_hp = 0; 1254 uint8 stat_hp = 0;
1199 uint8 stat_width = 0; 1255 uint8 stat_width = 0;
1200 uint8 flags = 0; 1256 uint8 flags = 0;
1201 tag_t player = 0; 1257 tag_t player = 0;
1202 1258
1203 // send hp information, if applicable 1259 // send hp information, if applicable
1204 if (object *op = ms.faces_obj [0]) 1260 if (object *op = ms.faces_obj [0])
1261 if (op->is_head () && !op->invisible)
1205 { 1262 {
1206 if (op->head || op->invisible) 1263 if (op->stats.maxhp > op->stats.hp
1207 ; // do not show 1264 && op->stats.maxhp > 0
1208 else if (op->type == PLAYER 1265 && (op->type == PLAYER
1266 || op->type == DOOR // does not work, have maxhp 0
1209 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)) 1267 || QUERY_FLAG (op, FLAG_MONSTER) || QUERY_FLAG (op, FLAG_ALIVE) || QUERY_FLAG (op, FLAG_GENERATOR)))
1210 {
1211 if (op->stats.maxhp > 0 && (unsigned) op->stats.maxhp > (unsigned) op->stats.hp)
1212 { 1268 {
1213 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp; 1269 stat_hp = 255 - (op->stats.hp * 255 + 254) / op->stats.maxhp;
1214 stat_width = op->arch->tail_x; 1270 stat_width = op->arch->max_x - op->arch->x; //TODO: should be upper-left edge
1215 } 1271 }
1216 }
1217 1272
1218 if (op->msg && op->msg[0] == '@') 1273 if (op->has_dialogue ())
1219 flags |= 1; 1274 flags |= 1;
1220 1275
1221 if (op->type == PLAYER && op != pl) 1276 if (op->type == PLAYER)
1222 player = op->count; 1277 player = op->count;
1223 } 1278 }
1224 1279
1225 if (lastcell.stat_hp != stat_hp) 1280 if (lastcell.stat_hp != stat_hp)
1226 { 1281 {
1227 lastcell.stat_hp = stat_hp; 1282 lastcell.stat_hp = stat_hp;
1228 1283
… …
1270 1325
1271 /* Middle face */ 1326 /* Middle face */
1272 if (update_space (sl, socket, ms, lastcell, 1)) 1327 if (update_space (sl, socket, ms, lastcell, 1))
1273 mask |= 0x2; 1328 mask |= 0x2;
1274 1329
1275 if (ms.player () == pl 1330 if (ms.player () == ob
1276 && (pl->invisible & (pl->invisible < 50 ? 1 : 7))) 1331 && (ob->invisible & (ob->invisible < 50 ? 1 : 7)))
1277 { 1332 {
1278 // force player to be visible to himself if invisible 1333 // force player to be visible to himself if invisible
1279 if (lastcell.faces[0] != pl->face) 1334 if (lastcell.faces[0] != ob->face)
1280 { 1335 {
1281 lastcell.faces[0] = pl->face; 1336 lastcell.faces[0] = ob->face;
1282 1337
1283 mask |= 0x1; 1338 mask |= 0x1;
1284 sl << uint16 (pl->face); 1339 sl << uint16 (ob->face);
1285 1340
1286 socket.send_faces (pl); 1341 socket.send_faces (ob);
1287 } 1342 }
1288 } 1343 }
1289 /* Top face */ 1344 /* Top face */
1290 else if (update_space (sl, socket, ms, lastcell, 0)) 1345 else if (update_space (sl, socket, ms, lastcell, 0))
1291 mask |= 0x1; 1346 mask |= 0x1;
1292
1293 1347
1294 /* Check to see if we are in fact sending anything for this 1348 /* Check to see if we are in fact sending anything for this
1295 * space by checking the mask. If so, update the mask. 1349 * space by checking the mask. If so, update the mask.
1296 * if not, reset the len to that from before adding the mask 1350 * if not, reset the len to that from before adding the mask
1297 * value, so we don't send those bits. 1351 * value, so we don't send those bits.
… …
1356 socket.send_packet (sl); 1410 socket.send_packet (sl);
1357 socket.sent_scroll = 0; 1411 socket.sent_scroll = 0;
1358 } 1412 }
1359} 1413}
1360 1414
1361/**
1362 * Draws client map.
1363 */
1364void
1365draw_client_map (object *pl)
1366{
1367 int i, j;
1368 sint16 ax, ay; /* ax and ay goes from 0 to max-size of arrays */
1369 int mflags;
1370 struct Map newmap;
1371 maptile *m, *pm;
1372
1373 if (pl->type != PLAYER)
1374 {
1375 LOG (llevError, "draw_client_map called with non player/non eric-server\n");
1376 return;
1377 }
1378
1379 pm = pl->map;
1380
1381 /* If player is just joining the game, he isn't here yet, so the map
1382 * can get swapped out. If so, don't try to send them a map. All will
1383 * be OK once they really log in.
1384 */
1385 if (pm == NULL || pm->in_memory != MAP_IN_MEMORY)
1386 return;
1387
1388 memset (&newmap, 0, sizeof (struct Map));
1389
1390 for (j = (pl->y - pl->contr->ns->mapy / 2); j < (pl->y + (pl->contr->ns->mapy + 1) / 2); j++)
1391 for (i = (pl->x - pl->contr->ns->mapx / 2); i < (pl->x + (pl->contr->ns->mapx + 1) / 2); i++)
1392 {
1393 ax = i;
1394 ay = j;
1395 m = pm;
1396 mflags = get_map_flags (m, &m, ax, ay, &ax, &ay);
1397
1398 if (mflags & P_OUT_OF_MAP)
1399 continue;
1400
1401 /* If a map is visible to the player, we don't want to swap it out
1402 * just to reload it. This should really call something like
1403 * swap_map, but this is much more efficient and 'good enough'
1404 */
1405 if (mflags & P_NEW_MAP)
1406 m->timeout = 50;
1407 }
1408
1409 /* do LOS after calls to update_position */
1410 if (pl->contr->do_los)
1411 {
1412 update_los (pl);
1413 pl->contr->do_los = 0;
1414 }
1415
1416 /* Big maps need a different drawing mechanism to work */
1417 draw_client_map1 (pl);
1418}
1419
1420
1421/*****************************************************************************/ 1415/*****************************************************************************/
1422
1423/* GROS: The following one is used to allow a plugin to send a generic cmd to*/ 1416/* GROS: The following one is used to allow a plugin to send a generic cmd to*/
1424
1425/* a player. Of course, the client need to know the command to be able to */ 1417/* a player. Of course, the client need to know the command to be able to */
1426
1427/* manage it ! */ 1418/* manage it ! */
1428
1429/*****************************************************************************/ 1419/*****************************************************************************/
1430void 1420void
1431send_plugin_custom_message (object *pl, char *buf) 1421send_plugin_custom_message (object *pl, char *buf)
1432{ 1422{
1433 pl->contr->ns->send_packet (buf); 1423 pl->contr->ns->send_packet (buf);
… …
1444 sl << "replyinfo skill_info\n"; 1434 sl << "replyinfo skill_info\n";
1445 1435
1446 for (int i = 1; i < NUM_SKILLS; i++) 1436 for (int i = 1; i < NUM_SKILLS; i++)
1447 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]); 1437 sl.printf ("%d:%s\n", i + CS_STAT_SKILLINFO, &skill_names[i]);
1448 1438
1449 if (sl.length () >= MAXSOCKBUF) 1439 if (sl.length () > MAXSOCKBUF)
1450 { 1440 {
1451 LOG (llevError, "Buffer overflow in send_skill_info!\n"); 1441 LOG (llevError, "Buffer overflow in send_skill_info!\n");
1452 fatal (0); 1442 fatal (0);
1453 } 1443 }
1454 1444
… …
1467 sl << "replyinfo spell_paths\n"; 1457 sl << "replyinfo spell_paths\n";
1468 1458
1469 for (int i = 0; i < NRSPELLPATHS; i++) 1459 for (int i = 0; i < NRSPELLPATHS; i++)
1470 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]); 1460 sl.printf ("%d:%s\n", 1 << i, spellpathnames[i]);
1471 1461
1472 if (sl.length () >= MAXSOCKBUF) 1462 if (sl.length () > MAXSOCKBUF)
1473 { 1463 {
1474 LOG (llevError, "Buffer overflow in send_spell_paths!\n"); 1464 LOG (llevError, "Buffer overflow in send_spell_paths!\n");
1475 fatal (0); 1465 fatal (0);
1476 } 1466 }
1477 1467
… …
1496 if (spell->type == SPELL) 1486 if (spell->type == SPELL)
1497 { 1487 {
1498 int flags = 0; 1488 int flags = 0;
1499 1489
1500 /* check if we need to update it */ 1490 /* check if we need to update it */
1501 if (spell->last_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA)) 1491 if (spell->cached_sp != SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA))
1502 { 1492 {
1503 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1493 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1504 flags |= UPD_SP_MANA; 1494 flags |= UPD_SP_MANA;
1505 } 1495 }
1506 1496
1507 if (spell->last_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE)) 1497 if (spell->cached_grace != SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE))
1508 { 1498 {
1509 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1499 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1510 flags |= UPD_SP_GRACE; 1500 flags |= UPD_SP_GRACE;
1511 } 1501 }
1512 1502
1513 if (spell->last_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell)) 1503 if (spell->cached_eat != spell->stats.dam + SP_level_dam_adjust (pl->ob, spell))
1514 { 1504 {
1515 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1505 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1516 flags |= UPD_SP_DAMAGE; 1506 flags |= UPD_SP_DAMAGE;
1517 } 1507 }
1518 1508
1519 if (flags) 1509 if (flags)
1520 { 1510 {
… …
1522 1512
1523 sl << "updspell " 1513 sl << "updspell "
1524 << uint8 (flags) 1514 << uint8 (flags)
1525 << uint32 (spell->count); 1515 << uint32 (spell->count);
1526 1516
1527 if (flags & UPD_SP_MANA ) sl << uint16 (spell->last_sp); 1517 if (flags & UPD_SP_MANA ) sl << uint16 (spell->cached_sp);
1528 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->last_grace); 1518 if (flags & UPD_SP_GRACE ) sl << uint16 (spell->cached_grace);
1529 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->last_eat); 1519 if (flags & UPD_SP_DAMAGE) sl << uint16 (spell->cached_eat);
1530 1520
1531 pl->ns->send_packet (sl); 1521 pl->ns->send_packet (sl);
1532 } 1522 }
1533 } 1523 }
1534 } 1524 }
… …
1564 LOG (llevError, "item number %d is a spell with no name.\n", spell->count); 1554 LOG (llevError, "item number %d is a spell with no name.\n", spell->count);
1565 return; 1555 return;
1566 } 1556 }
1567 1557
1568 /* store costs and damage in the object struct, to compare to later */ 1558 /* store costs and damage in the object struct, to compare to later */
1569 spell->last_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA); 1559 spell->cached_sp = SP_level_spellpoint_cost (pl->ob, spell, SPELL_MANA);
1570 spell->last_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE); 1560 spell->cached_grace = SP_level_spellpoint_cost (pl->ob, spell, SPELL_GRACE);
1571 spell->last_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell); 1561 spell->cached_eat = spell->stats.dam + SP_level_dam_adjust (pl->ob, spell);
1572 1562
1573 /* figure out which skill it uses, if it uses one */ 1563 /* figure out which skill it uses, if it uses one */
1574 if (spell->skill) 1564 if (spell->skill)
1575 { 1565 {
1576 for (i = 1; i < NUM_SKILLS; i++) 1566 for (i = 1; i < NUM_SKILLS; i++)
… …
1586 { 1576 {
1587 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name); 1577 LOG (llevError, "%s: spell has no face, but face is mandatory.\n", &spell->name);
1588 spell->face = face_find ("burnout.x11", blank_face); 1578 spell->face = face_find ("burnout.x11", blank_face);
1589 } 1579 }
1590 1580
1581 pl->ns->send_face (spell->face);
1582
1591 /* send the current values */ 1583 /* send the current values */
1592 sl << uint32 (spell->count) 1584 sl << uint32 (spell->count)
1593 << uint16 (spell->level) 1585 << uint16 (spell->level)
1594 << uint16 (spell->casting_time) 1586 << uint16 (spell->casting_time)
1595 << uint16 (spell->last_sp) 1587 << uint16 (spell->cached_sp)
1596 << uint16 (spell->last_grace) 1588 << uint16 (spell->cached_grace)
1597 << uint16 (spell->last_eat) 1589 << uint16 (spell->cached_eat)
1598 << uint8 (skill) 1590 << uint8 (skill)
1599 << uint32 (spell->path_attuned) 1591 << uint32 (spell->path_attuned)
1600 << uint32 (spell->face) 1592 << uint32 (spell->face)
1601 << data8 (spell->name) 1593 << data8 (spell->name)
1602 << data16 (spell->msg); 1594 << data16 (spell->msg);
… …
1630 * bytes and 3 strings (because that is the spec) so we need to 1622 * bytes and 3 strings (because that is the spec) so we need to
1631 * check that the length of those 3 strings, plus the 23 bytes, 1623 * check that the length of those 3 strings, plus the 23 bytes,
1632 * won't take us over the length limit for the socket, if it does, 1624 * won't take us over the length limit for the socket, if it does,
1633 * we need to send what we already have, and restart packet formation 1625 * we need to send what we already have, and restart packet formation
1634 */ 1626 */
1627 if (spell->type != SPELL)
1628 continue;
1629
1635 /* Seeing crashes by overflowed buffers. Quick arithemetic seems 1630 /* Seeing crashes by overflowed buffers. Quick arithemetic seems
1636 * to show add_spell is 26 bytes + 2 strings. However, the overun 1631 * to show add_spell is 26 bytes + 2 strings. However, the overun
1637 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem 1632 * is hundreds of bytes off, so correcting 22 vs 26 doesn't seem
1638 * like it will fix this 1633 * like it will fix this
1639 */ 1634 */
1640 if (spell->type != SPELL)
1641 continue;
1642
1643 if (sl.length () >= (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0)))) 1635 if (sl.length () > (MAXSOCKBUF - (26 + strlen (spell->name) + (spell->msg ? strlen (spell->msg) : 0))))
1644 { 1636 {
1637 pl->ns->flush_fx ();
1645 pl->ns->send_packet (sl); 1638 pl->ns->send_packet (sl);
1646 1639
1647 sl.reset (); 1640 sl.reset ();
1648 sl << "addspell "; 1641 sl << "addspell ";
1649 } 1642 }
… …
1657 return; 1650 return;
1658 } 1651 }
1659 else 1652 else
1660 append_spell (pl, sl, spell); 1653 append_spell (pl, sl, spell);
1661 1654
1662 if (sl.length () >= MAXSOCKBUF) 1655 if (sl.length () > MAXSOCKBUF)
1663 { 1656 {
1664 LOG (llevError, "Buffer overflow in esrv_add_spells!\n"); 1657 LOG (llevError, "Buffer overflow in esrv_add_spells!\n");
1665 fatal (0); 1658 fatal (0);
1666 } 1659 }
1667 1660
1668 /* finally, we can send the packet */ 1661 /* finally, we can send the packet */
1662 pl->ns->flush_fx ();
1669 pl->ns->send_packet (sl); 1663 pl->ns->send_packet (sl);
1670} 1664}
1671 1665

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines