ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/gvpe/src/connection.C
(Generate patch)

Comparing gvpe/src/connection.C (file contents):
Revision 1.94 by root, Sun Mar 6 19:40:28 2011 UTC vs.
Revision 1.108 by root, Fri Oct 11 04:07:24 2013 UTC

1/* 1/*
2 connection.C -- manage a single connection 2 connection.C -- manage a single connection
3 Copyright (C) 2003-2008,2010,2011 Marc Lehmann <gvpe@schmorp.de> 3 Copyright (C) 2003-2008,2010,2011,2013 Marc Lehmann <gvpe@schmorp.de>
4 4
5 This file is part of GVPE. 5 This file is part of GVPE.
6 6
7 GVPE is free software; you can redistribute it and/or modify it 7 GVPE is free software; you can redistribute it and/or modify it
8 under the terms of the GNU General Public License as published by the 8 under the terms of the GNU General Public License as published by the
… …
33 33
34#include <list> 34#include <list>
35#include <queue> 35#include <queue>
36#include <utility> 36#include <utility>
37 37
38#include <openssl/opensslv.h>
38#include <openssl/rand.h> 39#include <openssl/rand.h>
39#include <openssl/evp.h> 40#include <openssl/evp.h>
40#include <openssl/rsa.h> 41#include <openssl/rsa.h>
41#include <openssl/err.h> 42#include <openssl/err.h>
43
44// openssl 0.9.8 compatibility
45#if OPENSSL_VERSION_NUMBER < 0x10100000
46 #define require101(exp) exp
47#else
48 #define require101(exp) equire (exp)
49#endif
42 50
43#include "conf.h" 51#include "conf.h"
44#include "slog.h" 52#include "slog.h"
45#include "device.h" 53#include "device.h"
46#include "vpn.h" 54#include "vpn.h"
47#include "connection.h" 55#include "connection.h"
56#include "hkdf.h"
48 57
49#include "netcompat.h" 58#include "netcompat.h"
50 59
51#if !HAVE_RAND_PSEUDO_BYTES
52# define RAND_pseudo_bytes RAND_bytes
53#endif
54
55#define MAGIC_OLD "vped\xbd\xc6\xdb\x82" // 8 bytes of magic (still used in the protocol)
56#define MAGIC "gvpe\xbd\xc6\xdb\x82" // 8 bytes of magic (understood but not generated) 60#define MAGIC "gvpe\xbd\xc6\xdb\x82" // 8 bytes of magic
61#define MAGIC "HUHN\xbd\xc6\xdb\x82" // 8 bytes of magic//D
57 62
58#define ULTRA_FAST 1 63#define ULTRA_FAST 1
59#define HLOG 15 64#define HLOG 15
60#include "lzf/lzf.h" 65#include "lzf/lzf.h"
61#include "lzf/lzf_c.c" 66#include "lzf/lzf_c.c"
… …
108struct crypto_ctx 113struct crypto_ctx
109{ 114{
110 EVP_CIPHER_CTX cctx; 115 EVP_CIPHER_CTX cctx;
111 HMAC_CTX hctx; 116 HMAC_CTX hctx;
112 117
113 crypto_ctx (const rsachallenge &challenge, int enc); 118 crypto_ctx (const auth_data &auth1, const auth_data &auth2, const ecdh_key &a, const ecdh_key &b, int enc);
114 ~crypto_ctx (); 119 ~crypto_ctx ();
115}; 120};
116 121
117crypto_ctx::crypto_ctx (const rsachallenge &challenge, int enc) 122crypto_ctx::crypto_ctx (const auth_data &auth1, const auth_data &auth2, const ecdh_key &a, const ecdh_key &b, int enc)
118{ 123{
124 ecdh_key s;
125
126 curve25519_combine (a, b, s);
127
128 {
129 u8 mac_key[MAC_KEYSIZE];
130 static const unsigned char mac_info[] = "gvpe mac key";
131
132 hkdf kdf (auth2.rsa.hkdf_salt, sizeof (auth2.rsa.hkdf_salt), HKDF_XTR_HASH ());
133 kdf.extract (auth1.rsa.mac_key, sizeof (auth1.rsa.mac_key));
134 kdf.extract (s, sizeof (s));
135 kdf.extract_done (HKDF_PRF_HASH ());
136 kdf.expand (mac_key, sizeof (mac_key), mac_info, sizeof (mac_info));
137
138 HMAC_CTX_init (&hctx);
139 require101 (HMAC_Init_ex (&hctx, mac_key, MAC_KEYSIZE, MAC_DIGEST (), 0));
140 }
141
142 {
143 u8 cipher_key[CIPHER_KEYSIZE];
144 static const unsigned char cipher_info[] = "gvpe cipher key";
145
146 hkdf kdf (auth2.rsa.hkdf_salt, sizeof (auth2.rsa.hkdf_salt), HKDF_XTR_HASH ());
147 kdf.extract (auth1.rsa.cipher_key, sizeof (auth1.rsa.cipher_key));
148 kdf.extract (s, sizeof (s));
149 kdf.extract_done (HKDF_PRF_HASH ());
150 kdf.expand (cipher_key, sizeof (cipher_key), cipher_info, sizeof (cipher_info));
151
119 EVP_CIPHER_CTX_init (&cctx); 152 EVP_CIPHER_CTX_init (&cctx);
120 require (EVP_CipherInit_ex (&cctx, CIPHER, 0, &challenge[CHG_CIPHER_KEY], 0, enc)); 153 require (EVP_CipherInit_ex (&cctx, CIPHER (), 0, cipher_key, 0, enc));
121 HMAC_CTX_init (&hctx); 154 }
122 HMAC_Init_ex (&hctx, &challenge[CHG_HMAC_KEY], HMAC_KEYLEN, DIGEST, 0);
123} 155}
124 156
125crypto_ctx::~crypto_ctx () 157crypto_ctx::~crypto_ctx ()
126{ 158{
127 require (EVP_CIPHER_CTX_cleanup (&cctx)); 159 require (EVP_CIPHER_CTX_cleanup (&cctx));
128 HMAC_CTX_cleanup (&hctx); 160 HMAC_CTX_cleanup (&hctx);
129} 161}
130 162
163static inline void
164auth_encrypt (RSA *key, const auth_data &auth, auth_encr &encr)
165{
166 if (RSA_public_encrypt (sizeof (auth.rsa),
167 (unsigned char *)&auth.rsa, (unsigned char *)&encr.rsa,
168 key, RSA_PKCS1_OAEP_PADDING) < 0)
169 fatal ("RSA_public_encrypt error");
170
171 memcpy (&encr.ecdh, &auth.ecdh, sizeof (encr.ecdh));
172}
173
174static inline bool
175auth_decrypt (RSA *key, const auth_encr &encr, auth_data &auth)
176{
177 u8 rsa_decrypt[RSA_KEYLEN];
178
179 if (RSA_private_decrypt (sizeof (encr.rsa),
180 (const unsigned char *)&encr.rsa, (unsigned char *)rsa_decrypt,
181 key, RSA_PKCS1_OAEP_PADDING) != sizeof (auth.rsa))
182 return 0;
183
184 memcpy (&auth.rsa, rsa_decrypt, sizeof (auth.rsa));
185 memcpy (&auth.ecdh, &encr.ecdh, sizeof (auth.ecdh));
186
187 return 1;
188}
189
131static void 190static void
132rsa_hash (const rsaid &id, const rsachallenge &chg, rsaresponse &h) 191auth_hash (const auth_data &auth, const ecdh_key &b, auth_mac &mac)
133{ 192{
134 EVP_MD_CTX ctx; 193 hkdf kdf (b, sizeof b, AUTH_DIGEST ()); // use response ecdh b as salt
135 194 kdf.extract (&auth.rsa, sizeof (auth.rsa));
136 EVP_MD_CTX_init (&ctx); 195 kdf.extract_done ();
137 require (EVP_DigestInit (&ctx, RSA_HASH)); 196 kdf.expand (mac, sizeof mac, auth.ecdh, sizeof (auth.ecdh)); // use challenge ecdh b as info
138 require (EVP_DigestUpdate(&ctx, &chg, sizeof chg));
139 require (EVP_DigestUpdate(&ctx, &id, sizeof id));
140 require (EVP_DigestFinal (&ctx, (unsigned char *)&h, 0));
141 EVP_MD_CTX_cleanup (&ctx);
142} 197}
143 198
144struct rsa_entry 199void
200connection::generate_auth_data ()
145{ 201{
146 tstamp expire; 202 if (auth_expire < ev_now ())
147 rsaid id;
148 rsachallenge chg;
149};
150
151struct rsa_cache : list<rsa_entry>
152{
153 inline void cleaner_cb (ev::timer &w, int revents); ev::timer cleaner;
154
155 bool find (const rsaid &id, rsachallenge &chg)
156 {
157 for (iterator i = begin (); i != end (); ++i)
158 { 203 {
159 if (!memcmp (&id, &i->id, sizeof id) && i->expire > ev_now ()) 204 // request data
160 { 205 rand_fill (snd_auth.rsa);
161 memcpy (&chg, &i->chg, sizeof chg); 206 curve25519_generate (snd_ecdh_a, snd_auth.ecdh);
162 207
163 erase (i); 208 // eventual response data
164 return true; 209 curve25519_generate (rcv_ecdh_a, rcv_ecdh_b);
165 }
166 } 210 }
167 211
168 if (!cleaner.is_active ()) 212 // every use prolongs the expiry
169 cleaner.again ();
170
171 return false;
172 }
173
174 void gen (rsaid &id, rsachallenge &chg)
175 {
176 rsa_entry e;
177
178 RAND_bytes ((unsigned char *)&id, sizeof id);
179 RAND_bytes ((unsigned char *)&chg, sizeof chg);
180
181 e.expire = ev_now () + RSA_TTL; 213 auth_expire = ev_now () + AUTH_TTL;
182 e.id = id;
183 memcpy (&e.chg, &chg, sizeof chg);
184
185 push_back (e);
186
187 if (!cleaner.is_active ())
188 cleaner.again ();
189 }
190
191 rsa_cache ()
192 {
193 cleaner.set<rsa_cache, &rsa_cache::cleaner_cb> (this);
194 cleaner.set (RSA_TTL, RSA_TTL);
195 }
196
197} rsa_cache;
198
199void
200rsa_cache::cleaner_cb (ev::timer &w, int revents)
201{
202 if (empty ())
203 w.stop ();
204 else
205 {
206 for (iterator i = begin (); i != end (); )
207 if (i->expire <= ev_now ())
208 i = erase (i);
209 else
210 ++i;
211 }
212} 214}
213 215
214////////////////////////////////////////////////////////////////////////////// 216//////////////////////////////////////////////////////////////////////////////
215 217
216pkt_queue::pkt_queue (double max_ttl, int max_queue) 218pkt_queue::pkt_queue (double max_ttl, int max_queue)
… …
365 } 367 }
366} 368}
367 369
368///////////////////////////////////////////////////////////////////////////// 370/////////////////////////////////////////////////////////////////////////////
369 371
370unsigned char hmac_packet::hmac_digest[EVP_MAX_MD_SIZE];
371
372void 372void
373hmac_packet::hmac_gen (crypto_ctx *ctx) 373hmac_packet::hmac_gen (crypto_ctx *ctx, u8 *hmac_digest)
374{ 374{
375 unsigned int xlen;
376
377 HMAC_CTX *hctx = &ctx->hctx; 375 HMAC_CTX *hctx = &ctx->hctx;
378 376
379 HMAC_Init_ex (hctx, 0, 0, 0, 0); 377 require101 (HMAC_Init_ex (hctx, 0, 0, 0, 0));
380 HMAC_Update (hctx, ((unsigned char *) this) + sizeof (hmac_packet), 378 require101 (HMAC_Update (hctx, ((unsigned char *) this) + sizeof (hmac_packet), len - sizeof (hmac_packet)));
381 len - sizeof (hmac_packet)); 379 require101 (HMAC_Final (hctx, hmac_digest, 0));
382 HMAC_Final (hctx, (unsigned char *) &hmac_digest, &xlen);
383} 380}
384 381
385void 382void
386hmac_packet::hmac_set (crypto_ctx *ctx) 383hmac_packet::hmac_set (crypto_ctx *ctx)
387{ 384{
388 hmac_gen (ctx); 385 unsigned char hmac_digest[EVP_MAX_MD_SIZE];
389 386 hmac_gen (ctx, hmac_digest);
390 memcpy (hmac, hmac_digest, HMACLENGTH); 387 memcpy (hmac, hmac_digest, HMACLENGTH);
391} 388}
392 389
393bool 390bool
394hmac_packet::hmac_chk (crypto_ctx *ctx) 391hmac_packet::hmac_chk (crypto_ctx *ctx)
395{ 392{
396 hmac_gen (ctx); 393 unsigned char hmac_digest[EVP_MAX_MD_SIZE];
397 394 hmac_gen (ctx, hmac_digest);
398 return !memcmp (hmac, hmac_digest, HMACLENGTH); 395 return !memcmp (hmac, hmac_digest, HMACLENGTH);
399} 396}
400 397
401void 398void
402vpn_packet::set_hdr (ptype type_, unsigned int dst) 399vpn_packet::set_hdr (ptype type_, unsigned int dst)
… …
451 d[1] = cl; 448 d[1] = cl;
452 } 449 }
453 } 450 }
454#endif 451#endif
455 452
456 require (EVP_EncryptInit_ex (cctx, 0, 0, 0, 0)); 453 require (EVP_CipherInit_ex (cctx, 0, 0, 0, 0, 1));
457 454
458 struct { 455 struct {
459#if RAND_SIZE 456#if RAND_SIZE
460 u8 rnd[RAND_SIZE]; 457 u8 rnd[RAND_SIZE];
461#endif 458#endif
462 u32 seqno; 459 u32 seqno;
463 } datahdr; 460 } datahdr;
464 461
465 datahdr.seqno = ntohl (seqno); 462 datahdr.seqno = ntohl (seqno);
466#if RAND_SIZE 463#if RAND_SIZE
467 RAND_pseudo_bytes ((unsigned char *) datahdr.rnd, RAND_SIZE); 464 // NB: a constant (per session) random prefix
465 // is likely enough, but we don't take any chances.
466 conn->oiv.get (datahdr.rnd, RAND_SIZE);
468#endif 467#endif
469 468
470 require (EVP_EncryptUpdate (cctx, 469 require (EVP_EncryptUpdate (cctx,
471 (unsigned char *) data + outl, &outl2, 470 (unsigned char *) data + outl, &outl2,
472 (unsigned char *) &datahdr, DATAHDR)); 471 (unsigned char *) &datahdr, DATAHDR));
… …
494 int outl = 0, outl2; 493 int outl = 0, outl2;
495 tap_packet *p = new tap_packet; 494 tap_packet *p = new tap_packet;
496 u8 *d; 495 u8 *d;
497 u32 l = len - data_hdr_size (); 496 u32 l = len - data_hdr_size ();
498 497
499 require (EVP_DecryptInit_ex (cctx, 0, 0, 0, 0)); 498 require (EVP_CipherInit_ex (cctx, 0, 0, 0, 0, 0));
500 499
501#if ENABLE_COMPRESSION 500#if ENABLE_COMPRESSION
502 u8 cdata[MAX_MTU]; 501 u8 cdata[MAX_MTU];
503 502
504 if (type == PT_DATA_COMPRESSED) 503 if (type == PT_DATA_COMPRESSED)
505 d = cdata; 504 d = cdata;
506 else 505 else
507#endif 506#endif
508 d = &(*p)[6 + 6 - DATAHDR]; 507 d = &(*p)[6 + 6] - DATAHDR;
509 508
510 /* this overwrites part of the src mac, but we fix that later */ 509 // we play do evil games with the struct layout atm.
510 // pending better solutions, we at least do some verification.
511 // this is fine, as we left ISO territory long ago.
512 require (DATAHDR <= 16);
513 require ((u8 *)(&p->len + 1) == &(*p)[0]);
514
515 // this can overwrite the len/dst/src fields
511 require (EVP_DecryptUpdate (cctx, 516 require (EVP_DecryptUpdate (cctx,
512 d, &outl2, 517 d, &outl2,
513 (unsigned char *)&data, len - data_hdr_size ())); 518 (unsigned char *)&data, len - data_hdr_size ()));
514 outl += outl2; 519 outl += outl2;
515 520
… …
546 } 551 }
547}; 552};
548 553
549struct config_packet : vpn_packet 554struct config_packet : vpn_packet
550{ 555{
551 // actually, hmaclen cannot be checked because the hmac 556 u8 serial[SERIAL_SIZE];
552 // field comes before this data, so peers with other
553 // hmacs simply will not work.
554 u8 prot_major, prot_minor, randsize, hmaclen; 557 u8 prot_major, prot_minor, randsize;
555 u8 flags, challengelen, features, pad3; 558 u8 flags, features, pad6, pad7, pad8;
556 u32 cipher_nid, digest_nid, hmac_nid; 559 u32 cipher_nid, mac_nid, auth_nid;
557 560
558 void setup (ptype type, int dst); 561 void setup (ptype type, int dst);
559 bool chk_config () const; 562 bool chk_config (const conf_node *conf, const sockinfo &rsi) const;
560 563
561 static u8 get_features () 564 static u8 get_features ()
562 { 565 {
563 u8 f = 0; 566 u8 f = 0;
564#if ENABLE_COMPRESSION 567#if ENABLE_COMPRESSION
… …
578config_packet::setup (ptype type, int dst) 581config_packet::setup (ptype type, int dst)
579{ 582{
580 prot_major = PROTOCOL_MAJOR; 583 prot_major = PROTOCOL_MAJOR;
581 prot_minor = PROTOCOL_MINOR; 584 prot_minor = PROTOCOL_MINOR;
582 randsize = RAND_SIZE; 585 randsize = RAND_SIZE;
583 hmaclen = HMACLENGTH;
584 flags = 0; 586 flags = 0;
585 challengelen = sizeof (rsachallenge);
586 features = get_features (); 587 features = get_features ();
587 588
589 strncpy ((char *)serial, conf.serial, sizeof (serial));
590
588 cipher_nid = htonl (EVP_CIPHER_nid (CIPHER)); 591 cipher_nid = htonl (EVP_CIPHER_nid (CIPHER ()));
589 digest_nid = htonl (EVP_MD_type (RSA_HASH));
590 hmac_nid = htonl (EVP_MD_type (DIGEST)); 592 mac_nid = htonl (EVP_MD_type (MAC_DIGEST ()));
593 auth_nid = htonl (EVP_MD_type (AUTH_DIGEST ()));
591 594
592 len = sizeof (*this) - sizeof (net_packet); 595 len = sizeof (*this) - sizeof (net_packet);
593 set_hdr (type, dst); 596 set_hdr (type, dst);
594} 597}
595 598
596bool 599bool
597config_packet::chk_config () const 600config_packet::chk_config (const conf_node *conf, const sockinfo &rsi) const
598{ 601{
599 if (prot_major != PROTOCOL_MAJOR) 602 if (prot_major != PROTOCOL_MAJOR)
600 slog (L_WARN, _("major version mismatch (remote %d <=> local %d)"), prot_major, PROTOCOL_MAJOR); 603 slog (L_WARN, _("%s(%s): major version mismatch (remote %d <=> local %d)"),
604 conf->nodename, (const char *)rsi, prot_major, PROTOCOL_MAJOR);
601 else if (randsize != RAND_SIZE) 605 else if (randsize != RAND_SIZE)
602 slog (L_WARN, _("rand size mismatch (remote %d <=> local %d)"), randsize, RAND_SIZE); 606 slog (L_WARN, _("%s(%s): rand size mismatch (remote %d <=> local %d)"),
603 else if (hmaclen != HMACLENGTH) 607 conf->nodename, (const char *)rsi, randsize, RAND_SIZE);
604 slog (L_WARN, _("hmac length mismatch (remote %d <=> local %d)"), hmaclen, HMACLENGTH);
605 else if (challengelen != sizeof (rsachallenge))
606 slog (L_WARN, _("challenge length mismatch (remote %d <=> local %d)"), challengelen, sizeof (rsachallenge));
607 else if (cipher_nid != htonl (EVP_CIPHER_nid (CIPHER))) 608 else if (cipher_nid != htonl (EVP_CIPHER_nid (CIPHER ())))
608 slog (L_WARN, _("cipher mismatch (remote %x <=> local %x)"), ntohl (cipher_nid), EVP_CIPHER_nid (CIPHER)); 609 slog (L_WARN, _("%s(%s): cipher algo mismatch (remote %x <=> local %x)"),
609 else if (digest_nid != htonl (EVP_MD_type (RSA_HASH))) 610 conf->nodename, (const char *)rsi, ntohl (cipher_nid), EVP_CIPHER_nid (CIPHER ()));
610 slog (L_WARN, _("digest mismatch (remote %x <=> local %x)"), ntohl (digest_nid), EVP_MD_type (RSA_HASH));
611 else if (hmac_nid != htonl (EVP_MD_type (DIGEST))) 611 else if (mac_nid != htonl (EVP_MD_type (MAC_DIGEST ())))
612 slog (L_WARN, _("hmac mismatch (remote %x <=> local %x)"), ntohl (hmac_nid), EVP_MD_type (DIGEST)); 612 slog (L_WARN, _("%s(%s): mac algo mismatch (remote %x <=> local %x)"),
613 conf->nodename, (const char *)rsi, ntohl (mac_nid), EVP_MD_type (MAC_DIGEST ()));
614 else if (auth_nid != htonl (EVP_MD_type (AUTH_DIGEST ())))
615 slog (L_WARN, _("%s(%s): auth algo mismatch (remote %x <=> local %x)"),
616 conf->nodename, (const char *)rsi, ntohl (auth_nid), EVP_MD_type (AUTH_DIGEST ()));
613 else 617 else
618 {
619 int cmp = memcmp (serial, ::conf.serial, sizeof (serial));
620
621 if (cmp > 0)
622 slog (L_WARN, _("%s(%s): remote serial newer than local serial - outdated config?"),
623 conf->nodename, (const char *)rsi);
624 else if (cmp == 0)
614 return true; 625 return true;
626 }
615 627
616 return false; 628 return false;
617} 629}
618 630
619struct auth_req_packet : config_packet 631struct auth_req_packet : config_packet // UNPROTECTED
620{ 632{
621 char magic[8]; 633 char magic[8];
622 u8 initiate; // false if this is just an automatic reply 634 u8 initiate; // false if this is just an automatic reply
623 u8 protocols; // supported protocols (will be patched on forward) 635 u8 protocols; // supported protocols (will be patched on forward)
624 u8 pad2, pad3; 636 u8 pad2, pad3;
625 rsaid id; 637 auth_encr encr;
626 rsaencrdata encr;
627 638
628 auth_req_packet (int dst, bool initiate_, u8 protocols_) 639 auth_req_packet (int dst, bool initiate_, u8 protocols_)
629 { 640 {
630 config_packet::setup (PT_AUTH_REQ, dst); 641 config_packet::setup (PT_AUTH_REQ, dst);
631 strncpy (magic, MAGIC_OLD, 8); 642 memcpy (magic, MAGIC, 8);
632 initiate = !!initiate_; 643 initiate = !!initiate_;
633 protocols = protocols_; 644 protocols = protocols_;
634 645
635 len = sizeof (*this) - sizeof (net_packet); 646 len = sizeof (*this) - sizeof (net_packet);
636 } 647 }
637}; 648};
638 649
639struct auth_res_packet : config_packet 650struct auth_res_packet : vpn_packet // UNPROTECTED
640{ 651{
641 rsaid id;
642 u8 pad1, pad2, pad3;
643 u8 response_len; // encrypted length
644 rsaresponse response; 652 auth_response response;
645 653
646 auth_res_packet (int dst) 654 auth_res_packet (int dst)
647 { 655 {
648 config_packet::setup (PT_AUTH_RES, dst); 656 set_hdr (PT_AUTH_RES, dst);
649 657
650 len = sizeof (*this) - sizeof (net_packet); 658 len = sizeof (*this) - sizeof (net_packet);
651 } 659 }
652}; 660};
653 661
… …
683}; 691};
684 692
685///////////////////////////////////////////////////////////////////////////// 693/////////////////////////////////////////////////////////////////////////////
686 694
687void 695void
688connection::connection_established () 696connection::connection_established (const sockinfo &rsi)
689{ 697{
690 slog (L_NOISE, _("%s: possible connection establish (ictx %d, octx %d)"), conf->nodename, !!ictx, !!octx); 698 if (!have_snd_auth || !have_rcv_auth)
699 return;
691 700
692 if (ictx && octx) 701 si = rsi;
702 protocol = rsi.prot;
703
704 slog (L_INFO, _("%s(%s): connection established (%s), protocol version %d.%d."),
705 conf->nodename, (const char *)rsi,
706 vpn->can_direct (THISNODE, conf) ? "direct" : "forwarded",
707 PROTOCOL_MAJOR, prot_minor);
708
709 if (::conf.script_node_up)
710 {
711 run_script_cb *cb = new run_script_cb;
712 cb->set<connection, &connection::script_node_up> (this);
713 run_script_queued (cb, _("node-up command execution failed, continuing."));
693 { 714 }
715
716 delete ictx; ictx = new crypto_ctx (rcv_auth, snd_auth, rcv_ecdh_a, rcv_auth.ecdh, 0);
717 iseqno.reset (ntohl (rcv_auth.rsa.seqno) & 0x7fffffff);
718
719 delete octx; octx = new crypto_ctx (snd_auth, rcv_auth, snd_ecdh_a, snd_ecdh_b , 1);
720 oseqno = ntohl (snd_auth.rsa.seqno) & 0x7fffffff;
721
722 oiv.reset ();
723
694 // make sure rekeying timeouts are slightly asymmetric 724 // make sure rekeying timeouts are slightly asymmetric
695 ev::tstamp rekey_interval = ::conf.rekey + (conf->id > THISNODE->id ? 10 : 0); 725 ev::tstamp rekey_interval = ::conf.rekey + (conf->id > THISNODE->id ? 10 : 0);
696 rekey.start (rekey_interval, rekey_interval); 726 rekey.start (rekey_interval, rekey_interval);
727
728 hmac_error = 0.;
729
697 keepalive.start (::conf.keepalive); 730 keepalive.start (::conf.keepalive);
698 731
699 // send queued packets 732 // send queued packets
700 if (ictx && octx)
701 {
702 while (tap_packet *p = (tap_packet *)data_queue.get ()) 733 while (tap_packet *p = (tap_packet *)data_queue.get ())
703 { 734 {
704 if (p->len) send_data_packet (p); 735 if (p->len) send_data_packet (p);
705 delete p; 736 delete p;
706 } 737 }
707 738
708 while (vpn_packet *p = (vpn_packet *)vpn_queue.get ()) 739 while (vpn_packet *p = (vpn_packet *)vpn_queue.get ())
709 { 740 {
710 if (p->len) send_vpn_packet (p, si, IPTOS_RELIABILITY); 741 if (p->len) send_vpn_packet (p, si, IPTOS_RELIABILITY);
711 delete p; 742 delete p;
712 } 743 }
713 }
714 744
715 vpn->connection_established (this); 745 vpn->connection_established (this);
716 }
717 else
718 {
719 retry_cnt = 0;
720 establish_connection.start (5);
721 keepalive.stop ();
722 rekey.stop ();
723 }
724} 746}
725 747
726void 748void
727connection::reset_si () 749connection::reset_si ()
728{ 750{
… …
733 slog (L_TRACE, _("%s: direct connection denied by config."), conf->nodename); 755 slog (L_TRACE, _("%s: direct connection denied by config."), conf->nodename);
734 protocol = 0; 756 protocol = 0;
735 } 757 }
736 758
737 si.set (conf, protocol); 759 si.set (conf, protocol);
738
739 is_direct = si.valid ();
740} 760}
741 761
742// ensure sockinfo is valid, forward if necessary 762// ensure sockinfo is valid, forward if necessary
743const sockinfo & 763const sockinfo &
744connection::forward_si (const sockinfo &si) const 764connection::forward_si (const sockinfo &si) const
… …
763 783
764void 784void
765connection::send_vpn_packet (vpn_packet *pkt, const sockinfo &si, int tos) 785connection::send_vpn_packet (vpn_packet *pkt, const sockinfo &si, int tos)
766{ 786{
767 if (!vpn->send_vpn_packet (pkt, si, tos)) 787 if (!vpn->send_vpn_packet (pkt, si, tos))
768 reset_connection (); 788 reset_connection ("packet send error");
769} 789}
770 790
771void 791void
772connection::send_ping (const sockinfo &si, u8 pong) 792connection::send_ping (const sockinfo &si, u8 pong)
773{ 793{
774 ping_packet *pkt = new ping_packet; 794 ping_packet *pkt = new ping_packet;
775 795
776 pkt->setup (conf->id, pong ? ping_packet::PT_PONG : ping_packet::PT_PING); 796 pkt->setup (conf->id, pong ? ping_packet::PT_PONG : ping_packet::PT_PING);
777 797
778 slog (L_TRACE, "%s << %s [%s]", conf->nodename, pong ? "PT_PONG" : "PT_PING", (const char *)si); 798 slog (L_TRACE, "%s << %s [%s]", conf->nodename, pong ? "PT_PONG" : "PT_PING", (const char *)si);
779
780 send_vpn_packet (pkt, si, IPTOS_LOWDELAY); 799 send_vpn_packet (pkt, si, IPTOS_LOWDELAY);
781 800
782 delete pkt; 801 delete pkt;
783} 802}
784 803
… …
799void 818void
800connection::send_auth_request (const sockinfo &si, bool initiate) 819connection::send_auth_request (const sockinfo &si, bool initiate)
801{ 820{
802 auth_req_packet *pkt = new auth_req_packet (conf->id, initiate, THISNODE->protocols); 821 auth_req_packet *pkt = new auth_req_packet (conf->id, initiate, THISNODE->protocols);
803 822
804 rsachallenge chg; 823 generate_auth_data ();
805 rsa_cache.gen (pkt->id, chg);
806 rsa_encrypt (conf->rsa_key, chg, pkt->encr); 824 auth_encrypt (conf->rsa_key, snd_auth, pkt->encr);
807 825
808 slog (L_TRACE, "%s << PT_AUTH_REQ [%s]", conf->nodename, (const char *)si); 826 slog (L_TRACE, "%s << PT_AUTH_REQ [%s]", conf->nodename, (const char *)si);
809
810 send_vpn_packet (pkt, si, IPTOS_RELIABILITY | IPTOS_LOWDELAY); // rsa is very very costly 827 send_vpn_packet (pkt, si, IPTOS_RELIABILITY | IPTOS_LOWDELAY); // rsa is very very costly
811 828
812 delete pkt; 829 delete pkt;
813} 830}
814 831
815void 832void
816connection::send_auth_response (const sockinfo &si, const rsaid &id, const rsachallenge &chg) 833connection::send_auth_response (const sockinfo &si)
817{ 834{
818 auth_res_packet *pkt = new auth_res_packet (conf->id); 835 auth_res_packet *pkt = new auth_res_packet (conf->id);
819 836
820 pkt->id = id; 837 memcpy (pkt->response.ecdh, rcv_ecdh_b, sizeof rcv_ecdh_b);
821 838 auth_hash (rcv_auth, rcv_ecdh_b, pkt->response.mac);
822 rsa_hash (id, chg, pkt->response);
823
824 pkt->hmac_set (octx);
825 839
826 slog (L_TRACE, "%s << PT_AUTH_RES [%s]", conf->nodename, (const char *)si); 840 slog (L_TRACE, "%s << PT_AUTH_RES [%s]", conf->nodename, (const char *)si);
827
828 send_vpn_packet (pkt, si, IPTOS_RELIABILITY); // rsa is very very costly 841 send_vpn_packet (pkt, si, IPTOS_RELIABILITY); // rsa is very very costly
829 842
830 delete pkt; 843 delete pkt;
831} 844}
832 845
… …
856 { 869 {
857 // a bit hacky, if ondemand, and packets are no longer queued, then reset the connection 870 // a bit hacky, if ondemand, and packets are no longer queued, then reset the connection
858 // and stop trying. should probably be handled by a per-connection expire handler. 871 // and stop trying. should probably be handled by a per-connection expire handler.
859 if (connectmode == conf_node::C_ONDEMAND && vpn_queue.empty () && data_queue.empty ()) 872 if (connectmode == conf_node::C_ONDEMAND && vpn_queue.empty () && data_queue.empty ())
860 { 873 {
861 reset_connection (); 874 reset_connection ("no demand");
862 return; 875 return;
863 } 876 }
864 877
865 last_establish_attempt = ev_now (); 878 last_establish_attempt = ev_now ();
866 879
… …
907 w.start (retry_int); 920 w.start (retry_int);
908 } 921 }
909} 922}
910 923
911void 924void
912connection::reset_connection () 925connection::reset_connection (const char *reason)
913{ 926{
914 if (ictx && octx) 927 if (ictx && octx)
915 { 928 {
916 slog (L_INFO, _("%s(%s): connection lost"), 929 slog (L_INFO, _("%s(%s): connection lost (%s)"),
917 conf->nodename, (const char *)si); 930 conf->nodename, (const char *)si, reason);
918 931
919 if (::conf.script_node_down) 932 if (::conf.script_node_down)
920 { 933 {
921 run_script_cb *cb = new run_script_cb; 934 run_script_cb *cb = new run_script_cb;
922 cb->set<connection, &connection::script_node_down> (this); 935 cb->set<connection, &connection::script_node_down> (this);
… …
927 delete ictx; ictx = 0; 940 delete ictx; ictx = 0;
928 delete octx; octx = 0; 941 delete octx; octx = 0;
929 942
930 si.host = 0; 943 si.host = 0;
931 944
945 have_snd_auth = false;
946 have_rcv_auth = false;
947 auth_expire = 0.;
948
932 last_activity = 0.; 949 last_activity = 0.;
933 //last_si_change = 0.; 950 //last_si_change = 0.;
934 retry_cnt = 0; 951 retry_cnt = 0;
935 952
936 rekey.stop (); 953 rekey.stop ();
… …
942connection::shutdown () 959connection::shutdown ()
943{ 960{
944 if (ictx && octx) 961 if (ictx && octx)
945 send_reset (si); 962 send_reset (si);
946 963
947 reset_connection (); 964 reset_connection ("shutdown");
948} 965}
949 966
950// poor-man's rekeying 967// poor-man's rekeying
951inline void 968inline void
952connection::rekey_cb (ev::timer &w, int revents) 969connection::rekey_cb (ev::timer &w, int revents)
953{ 970{
954 reset_connection (); 971 reset_connection ("rekeying");
955 establish_connection (); 972 establish_connection ();
956} 973}
957 974
958void 975void
959connection::send_data_packet (tap_packet *pkt) 976connection::send_data_packet (tap_packet *pkt)
… …
1046 // about our desire for communication. 1063 // about our desire for communication.
1047 establish_connection (); 1064 establish_connection ();
1048 break; 1065 break;
1049 1066
1050 case vpn_packet::PT_RESET: 1067 case vpn_packet::PT_RESET:
1068 slog (L_TRACE, "%s >> PT_RESET", conf->nodename);
1069
1070 if (ictx && octx)
1051 { 1071 {
1052 reset_connection (); 1072 reset_connection ("remote reset");
1053 1073
1054 config_packet *p = (config_packet *) pkt; 1074 config_packet *p = (config_packet *) pkt;
1055 1075
1056 if (!p->chk_config ()) 1076 if (p->chk_config (conf, rsi) && connectmode == conf_node::C_ALWAYS)
1057 {
1058 slog (L_WARN, _("%s(%s): protocol mismatch, disabling node."),
1059 conf->nodename, (const char *)rsi);
1060 connectmode = conf_node::C_DISABLED;
1061 }
1062 else if (connectmode == conf_node::C_ALWAYS)
1063 establish_connection (); 1077 establish_connection ();
1064 } 1078 }
1079
1065 break; 1080 break;
1066 1081
1067 case vpn_packet::PT_AUTH_REQ: 1082 case vpn_packet::PT_AUTH_REQ:
1068 if (auth_rate_limiter.can (rsi)) 1083 if (auth_rate_limiter.can (rsi))
1069 { 1084 {
… …
1071 1086
1072 slog (L_TRACE, "%s >> PT_AUTH_REQ(%s,p%02x,f%02x)", 1087 slog (L_TRACE, "%s >> PT_AUTH_REQ(%s,p%02x,f%02x)",
1073 conf->nodename, p->initiate ? "initiate" : "reply", 1088 conf->nodename, p->initiate ? "initiate" : "reply",
1074 p->protocols, p->features); 1089 p->protocols, p->features);
1075 1090
1091 if (memcmp (p->magic, MAGIC, 8))
1092 {
1093 slog (L_WARN, _("%s(%s): protocol magic mismatch - stray packet?"),
1094 conf->nodename, (const char *)rsi);
1095 }
1076 if (p->chk_config () 1096 else if (p->chk_config (conf, rsi))
1077 && (!memcmp (p->magic, MAGIC_OLD, 8) || !memcmp (p->magic, MAGIC, 8)))
1078 { 1097 {
1079 if (p->prot_minor != PROTOCOL_MINOR) 1098 if (p->prot_minor != PROTOCOL_MINOR)
1080 slog (L_INFO, _("%s(%s): protocol minor version mismatch: ours is %d, %s's is %d."), 1099 slog (L_INFO, _("%s(%s): protocol minor version mismatch: ours is %d, %s's is %d."),
1081 conf->nodename, (const char *)rsi, 1100 conf->nodename, (const char *)rsi,
1082 PROTOCOL_MINOR, conf->nodename, p->prot_minor); 1101 PROTOCOL_MINOR, conf->nodename, p->prot_minor);
1083 1102
1084 if (p->initiate) 1103 if (p->initiate)
1104 {
1085 send_auth_request (rsi, false); 1105 send_auth_request (rsi, false);
1086 1106
1087 rsachallenge k; 1107 if (ictx && octx)
1108 reset_connection ("reconnect");
1109 }
1088 1110
1111 auth_data auth;
1112
1089 if (!rsa_decrypt (::conf.rsa_key, p->encr, k)) 1113 if (!auth_decrypt (::conf.rsa_key, p->encr, auth))
1090 { 1114 {
1091 slog (L_ERR, _("%s(%s): challenge illegal or corrupted (%s). mismatched key or config file?"), 1115 slog (L_ERR, _("%s(%s): challenge illegal or corrupted (%s). mismatched key or config file?"),
1092 conf->nodename, (const char *)rsi, ERR_error_string (ERR_get_error (), 0)); 1116 conf->nodename, (const char *)rsi, ERR_error_string (ERR_get_error (), 0));
1093 break;
1094 } 1117 }
1095 else 1118 else
1096 { 1119 {
1097 delete octx; 1120 bool chg = !have_rcv_auth || memcmp (&rcv_auth, &auth, sizeof auth);
1098 1121
1099 octx = new crypto_ctx (k, 1); 1122 rcv_auth = auth;
1100 oseqno = ntohl (*(u32 *)&k[CHG_SEQNO]) & 0x7fffffff; 1123 have_rcv_auth = true;
1101 1124
1125 send_auth_response (rsi);
1126
1127 if (chg)
1128 {
1102 conf->protocols = p->protocols; 1129 conf->protocols = p->protocols;
1103 features = p->features & config_packet::get_features (); 1130 features = p->features & config_packet::get_features ();
1104 1131
1105 send_auth_response (rsi, p->id, k);
1106
1107 connection_established (); 1132 connection_established (rsi);
1108
1109 break; 1133 }
1110 } 1134 }
1135
1136 break;
1111 } 1137 }
1112 else
1113 slog (L_WARN, _("%s(%s): protocol mismatch."),
1114 conf->nodename, (const char *)rsi);
1115 1138
1116 send_reset (rsi); 1139 send_reset (rsi);
1117 } 1140 }
1118 1141
1119 break; 1142 break;
… …
1122 { 1145 {
1123 auth_res_packet *p = (auth_res_packet *)pkt; 1146 auth_res_packet *p = (auth_res_packet *)pkt;
1124 1147
1125 slog (L_TRACE, "%s >> PT_AUTH_RES", conf->nodename); 1148 slog (L_TRACE, "%s >> PT_AUTH_RES", conf->nodename);
1126 1149
1127 if (p->chk_config ()) 1150 auth_mac local_mac;
1151 auth_hash (snd_auth, p->response.ecdh, local_mac);
1152
1153 if (memcmp (&p->response.mac, local_mac, sizeof local_mac))
1128 { 1154 {
1129 if (p->prot_minor != PROTOCOL_MINOR)
1130 slog (L_INFO, _("%s(%s): protocol minor version mismatch: ours is %d, %s's is %d."),
1131 conf->nodename, (const char *)rsi,
1132 PROTOCOL_MINOR, conf->nodename, p->prot_minor);
1133
1134 rsachallenge chg;
1135
1136 if (!rsa_cache.find (p->id, chg))
1137 {
1138 slog (L_ERR, _("%s(%s): unrequested auth response, ignoring."), 1155 slog (L_ERR, _("%s(%s): unrequested or outdated auth response, ignoring."),
1139 conf->nodename, (const char *)rsi); 1156 conf->nodename, (const char *)rsi);
1140 break;
1141 } 1157 }
1142 else 1158 else if (!have_snd_auth)
1143 { 1159 {
1144 crypto_ctx *cctx = new crypto_ctx (chg, 0); 1160 memcpy (snd_ecdh_b, p->response.ecdh, sizeof snd_ecdh_b);
1145 1161
1146 if (!p->hmac_chk (cctx)) 1162 have_snd_auth = true;
1147 {
1148 slog (L_ERR, _("%s(%s): hmac authentication error on auth response, received invalid packet\n"
1149 "could be an attack, or just corruption or a synchronization error."),
1150 conf->nodename, (const char *)rsi);
1151 break;
1152 }
1153 else
1154 {
1155 rsaresponse h;
1156
1157 rsa_hash (p->id, chg, h);
1158
1159 if (!memcmp ((u8 *)&h, (u8 *)p->response, sizeof h))
1160 {
1161 prot_minor = p->prot_minor;
1162
1163 delete ictx; ictx = cctx;
1164
1165 iseqno.reset (ntohl (*(u32 *)&chg[CHG_SEQNO]) & 0x7fffffff); // at least 2**31 sequence numbers are valid
1166
1167 si = rsi;
1168 protocol = rsi.prot;
1169
1170 slog (L_INFO, _("%s(%s): connection established (%s), protocol version %d.%d."),
1171 conf->nodename, (const char *)rsi,
1172 is_direct ? "direct" : "forwarded",
1173 p->prot_major, p->prot_minor);
1174
1175 connection_established (); 1163 connection_established (rsi);
1176
1177 if (::conf.script_node_up)
1178 {
1179 run_script_cb *cb = new run_script_cb;
1180 cb->set<connection, &connection::script_node_up> (this);
1181 run_script_queued (cb, _("node-up command execution failed, continuing."));
1182 }
1183
1184 break;
1185 }
1186 else
1187 slog (L_ERR, _("%s(%s): sent and received challenge do not match."),
1188 conf->nodename, (const char *)rsi);
1189 }
1190
1191 delete cctx;
1192 }
1193 } 1164 }
1194 } 1165 }
1195
1196 send_reset (rsi);
1197 break; 1166 break;
1198 1167
1199 case vpn_packet::PT_DATA_COMPRESSED: 1168 case vpn_packet::PT_DATA_COMPRESSED:
1200#if !ENABLE_COMPRESSION 1169#if !ENABLE_COMPRESSION
1201 send_reset (rsi); 1170 send_reset (rsi);
… …
1207 if (ictx && octx) 1176 if (ictx && octx)
1208 { 1177 {
1209 vpndata_packet *p = (vpndata_packet *)pkt; 1178 vpndata_packet *p = (vpndata_packet *)pkt;
1210 1179
1211 if (!p->hmac_chk (ictx)) 1180 if (!p->hmac_chk (ictx))
1181 {
1182 // rekeying often creates temporary hmac auth floods
1183 // we assume they don't take longer than a few seconds normally,
1184 // and suppress messages and resets during that time.
1185 //TODO: should be done per source address
1186 if (!hmac_error)
1187 {
1188 hmac_error = ev_now () + 3;
1189 break;
1190 }
1191 else if (hmac_error >= ev_now ())
1192 break; // silently suppress
1193 else
1194 {
1212 slog (L_ERR, _("%s(%s): hmac authentication error, received invalid packet\n" 1195 slog (L_ERR, _("%s(%s): hmac authentication error, received invalid packet\n"
1213 "could be an attack, or just corruption or a synchronization error."), 1196 "could be an attack, or just corruption or a synchronization error."),
1214 conf->nodename, (const char *)rsi); 1197 conf->nodename, (const char *)rsi);
1198 // reset
1199 }
1200 }
1215 else 1201 else
1216 { 1202 {
1217 u32 seqno; 1203 u32 seqno;
1218 tap_packet *d = p->unpack (this, seqno); 1204 tap_packet *d = p->unpack (this, seqno);
1219 int seqclass = iseqno.seqno_classify (seqno); 1205 int seqclass = iseqno.seqno_classify (seqno);
1206
1207 hmac_error = 0;
1220 1208
1221 if (seqclass == 0) // ok 1209 if (seqclass == 0) // ok
1222 { 1210 {
1223 vpn->tap->send (d); 1211 vpn->tap->send (d);
1224 1212
… …
1310 1298
1311 c->conf->protocols = p->protocols; 1299 c->conf->protocols = p->protocols;
1312 protocol = best_protocol (c->conf->protocols & THISNODE->protocols & p->si.supported_protocols (c->conf)); 1300 protocol = best_protocol (c->conf->protocols & THISNODE->protocols & p->si.supported_protocols (c->conf));
1313 p->si.upgrade_protocol (protocol, c->conf); 1301 p->si.upgrade_protocol (protocol, c->conf);
1314 1302
1315 slog (L_TRACE, "%s >> PT_CONNECT_INFO(%s,%s,p%02x) [%d]", 1303 slog (L_TRACE, "%s >> PT_CONNECT_INFO(%s,%s,protocols=%02x,protocol=%02x,upgradable=%02x) [%d]",
1316 conf->nodename, 1304 conf->nodename,
1317 vpn->conns[p->id - 1]->conf->nodename, 1305 vpn->conns[p->id - 1]->conf->nodename,
1318 (const char *)p->si, 1306 (const char *)p->si,
1319 p->protocols, 1307 p->protocols,
1308 protocol,
1309 p->si.supported_protocols (c->conf),
1320 !c->ictx && !c->octx); 1310 !c->ictx && !c->octx);
1321 1311
1322 const sockinfo &dsi = forward_si (p->si); 1312 const sockinfo &dsi = forward_si (p->si);
1323 1313
1324 if (dsi.valid ()) 1314 if (dsi.valid ())
1325 c->send_auth_request (dsi, true); 1315 c->send_auth_request (dsi, true);
1316 else
1317 slog (L_INFO, "connect info for %s received (%s), but still unable to contact.",
1318 vpn->conns[p->id - 1]->conf->nodename,
1319 (const char *)p->si);
1326 } 1320 }
1327 else 1321 else
1328 slog (L_WARN, 1322 slog (L_WARN,
1329 _("received authenticated connection request from unknown node #%d, config file mismatch?"), 1323 _("received authenticated connection request from unknown node #%d, config file mismatch?"),
1330 p->id); 1324 p->id);
… …
1339} 1333}
1340 1334
1341inline void 1335inline void
1342connection::keepalive_cb (ev::timer &w, int revents) 1336connection::keepalive_cb (ev::timer &w, int revents)
1343{ 1337{
1344 if (ev_now () >= last_activity + ::conf.keepalive + 15) 1338 ev_tstamp when = last_activity + ::conf.keepalive - ev::now ();
1339
1340 if (when >= 0)
1341 w.start (when);
1342 else if (when < -15)
1345 { 1343 {
1346 reset_connection (); 1344 reset_connection ("keepalive overdue");
1347 establish_connection (); 1345 establish_connection ();
1348 } 1346 }
1349 else if (ev_now () < last_activity + ::conf.keepalive)
1350 w.start (last_activity + ::conf.keepalive - ev::now ());
1351 else if (conf->connectmode != conf_node::C_ONDEMAND 1347 else if (conf->connectmode != conf_node::C_ONDEMAND
1352 || THISNODE->connectmode != conf_node::C_ONDEMAND) 1348 || THISNODE->connectmode != conf_node::C_ONDEMAND)
1353 { 1349 {
1350 w.start (3);
1354 send_ping (si); 1351 send_ping (si);
1355 w.start (3);
1356 } 1352 }
1357 else if (ev_now () < last_activity + ::conf.keepalive + 10) 1353 else if (when >= -10)
1358 // hold ondemand connections implicitly a few seconds longer 1354 // hold ondemand connections implicitly a few seconds longer
1359 // should delete octx, though, or something like that ;) 1355 // should delete octx, though, or something like that ;)
1360 w.start (last_activity + ::conf.keepalive + 10 - ev::now ()); 1356 w.start (when + 10);
1361 else 1357 else
1362 reset_connection (); 1358 reset_connection ("keepalive timeout");
1363} 1359}
1364 1360
1365void 1361void
1366connection::send_connect_request (int id) 1362connection::send_connect_request (int id)
1367{ 1363{
… …
1467 1463
1468 // queue a dummy packet to force an initial connection attempt 1464 // queue a dummy packet to force an initial connection attempt
1469 if (connectmode != conf_node::C_ALWAYS && connectmode != conf_node::C_DISABLED) 1465 if (connectmode != conf_node::C_ALWAYS && connectmode != conf_node::C_DISABLED)
1470 vpn_queue.put (new net_packet); 1466 vpn_queue.put (new net_packet);
1471 1467
1472 reset_connection (); 1468 reset_connection ("startup");
1473} 1469}
1474 1470
1475connection::~connection () 1471connection::~connection ()
1476{ 1472{
1477 shutdown (); 1473 shutdown ();

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines