[ViewVC] Diff of: cvs/gvpe/src/connection.C

Comparing gvpe/src/connection.C (file contents):
Revision 1.51 by pcg, Wed Mar 23 20:07:56 2005 UTC vs.
Revision 1.58 by pcg, Sat Jul 9 02:35:42 2005 UTC

     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
     You should have received a copy of the GNU General Public License
     along with gvpe; if not, write to the Free Software
-    Foundation, Inc. 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+    Foundation, Inc. 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 */
 #include "config.h"
-#include <cassert>
 #include <list>
 #include <openssl/rand.h>
 #include <openssl/evp.h>
 }
 void
 connection::send_connect_info (int rid, const sockinfo &rsi, u8 rprotocols)
 {
-  slog (L_TRACE, ">>%d PT_CONNECT_INFO(%d,%s)\n",
+  slog (L_TRACE, ">>%d PT_CONNECT_INFO(%d,%s)",
                  conf->id, rid, (const char *)rsi);
   connect_info_packet *r = new connect_info_packet (conf->id, rid, rsi, rprotocols);
   r->hmac_set (octx);
     {
       slog (L_INFO, _("%s(%s): connection lost"),
             conf->nodename, (const char *)si);
       if (::conf.script_node_down)
-        run_script (run_script_cb (this, &connection::script_node_down), false);
+        if (!run_script (run_script_cb (this, &connection::script_node_down), false))
+          slog (L_WARN, _("node-down command execution failed, continuing."));
     }
   delete ictx; ictx = 0;
   delete octx; octx = 0;
 #if ENABLE_DNS
 {
   if (ictx && octx)
     send_data_packet (pkt);
   else
     {
-      if (!broadcast)//DDDD
+      if (!broadcast)
         data_queue.put (new tap_packet (*pkt));
       establish_connection ();
     }
 }
                           slog (L_INFO, _("%s(%s): connection established, protocol version %d.%d"),
                                 conf->nodename, (const char *)rsi,
                                 p->prot_major, p->prot_minor);
                           if (::conf.script_node_up)
-                            run_script (run_script_cb (this, &connection::script_node_up), false);
+                            if (!run_script (run_script_cb (this, &connection::script_node_up), false))
+                              slog (L_WARN, _("node-up command execution failed, continuing."));
                           break;
                         }
                       else
                         slog (L_ERR, _("%s(%s): sent and received challenge do not match"),
                   {
                     vpn->tap->send (d);
                     if (si != rsi)
                       {
-                        // fast re-sync on connection changes, useful especially for tcp/ip
+                        // fast re-sync on source address changes, useful especially for tcp/ip
                         si = rsi;
                         slog (L_INFO, _("%s(%s): socket address changed to %s"),
                               conf->nodename, (const char *)si, (const char *)rsi);
                       }
       case vpn_packet::PT_CONNECT_REQ:
         if (ictx && octx && rsi == si && pkt->hmac_chk (ictx))
           {
             connect_req_packet *p = (connect_req_packet *) pkt;
-            assert (p->id > 0 && p->id <= vpn->conns.size ()); // hmac-auth does not mean we accept anything
+            if (p->id > 0 && p->id <= vpn->conns.size ())
-            connection *c = vpn->conns[p->id - 1];
-            conf->protocols = p->protocols;
-            slog (L_TRACE, "<<%d PT_CONNECT_REQ(%d) [%d]\n",
-                           conf->id, p->id, c->ictx && c->octx);
-            if (c->ictx && c->octx)
               {
+                connection *c = vpn->conns[p->id - 1];
+                conf->protocols = p->protocols;
+                slog (L_TRACE, "<<%d PT_CONNECT_REQ(%d) [%d]",
+                               conf->id, p->id, c->ictx && c->octx);
+                if (c->ictx && c->octx)
+                  {
-                // send connect_info packets to both sides, in case one is
+                    // send connect_info packets to both sides, in case one is
-                // behind a nat firewall (or both ;)
+                    // behind a nat firewall (or both ;)
-                c->send_connect_info (conf->id, si, conf->protocols);
+                    c->send_connect_info (conf->id, si, conf->protocols);
-                send_connect_info (c->conf->id, c->si, c->conf->protocols);
+                    send_connect_info (c->conf->id, c->si, c->conf->protocols);
+                  }
+                else
+                  c->establish_connection ();
               }
             else
-              c->establish_connection ();
+              slog (L_WARN,
+                    _("received authenticated connection request from unknown node #%d, config file mismatch?"),
+                    p->id);
           }
         break;
       case vpn_packet::PT_CONNECT_INFO:
         if (ictx && octx && rsi == si && pkt->hmac_chk (ictx))
           {
             connect_info_packet *p = (connect_info_packet *)pkt;
-            if (p->id > 0 && p->id <= vpn->conns.size ()) // hmac-auth does not mean we accept anything
+            if (p->id > 0 && p->id <= vpn->conns.size ())
               {
                 connection *c = vpn->conns[p->id - 1];
                 c->conf->protocols = p->protocols;
                 protocol = best_protocol (c->conf->protocols & THISNODE->protocols & p->si.supported_protocols (c->conf));
                 const sockinfo &dsi = forward_si (p->si);
                 if (dsi.valid ())
                   c->send_auth_request (dsi, true);
               }
+            else
+              slog (L_WARN,
+                    _("received authenticated connection request from unknown node #%d, config file mismatch?"),
+                    p->id);
           }
         break;
       default:
   send_vpn_packet (p, si);
   delete p;
 }
+void connection::script_init_env (const char *ext)
+{
+  char *env;
+  asprintf (&env, "IFUPDATA%s=%s", ext, conf->if_up_data); putenv (env);
+  asprintf (&env, "NODENAME%s=%s", ext, conf->nodename); putenv (env);
+  asprintf (&env, "MAC%s=%02x:%02x:%02x:%02x:%02x:%02x", ext,
+            0xfe, 0xfd, 0x80, 0x00, conf->id >> 8,
+            conf->id & 0xff); putenv (env);
+}
-void connection::script_node ()
+void connection::script_init_connect_env ()
 {
-  vpn->script_if_up ();
+  vpn->script_init_env ();
   char *env;
   asprintf (&env, "DESTID=%d",   conf->id); putenv (env);
   asprintf (&env, "DESTNODE=%s", conf->nodename); putenv (env);
   asprintf (&env, "DESTIP=%s",   si.ntoa ()); putenv (env);
   asprintf (&env, "DESTPORT=%d", ntohs (si.port)); putenv (env);
 }
 const char *connection::script_node_up ()
 {
-  script_node ();
+  script_init_connect_env ();
   putenv ("STATE=up");
+  char *filename;
+  asprintf (&filename,
+            "%s/%s",
+            confbase,
-  return ::conf.script_node_up ? ::conf.script_node_up : "node-up";
+            ::conf.script_node_up ? ::conf.script_node_up : "node-up");
+  return filename;
 }
 const char *connection::script_node_down ()
 {
-  script_node ();
+  script_init_connect_env ();
   putenv ("STATE=down");
-  return ::conf.script_node_up ? ::conf.script_node_down : "node-down";
+  char *filename;
+  asprintf (&filename,
+            "%s/%s",
+            confbase,
+            ::conf.script_node_down ? ::conf.script_node_down : "node-down");
+  return filename;
 }
 connection::connection (struct vpn *vpn, conf_node *conf)
 : vpn(vpn), conf(conf)
 , rekey (this, &connection::rekey_cb)

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing gvpe/src/connection.C (file contents): Revision 1.51 by pcg, Wed Mar 23 20:07:56 2005 UTC vs. Revision 1.58 by pcg, Sat Jul 9 02:35:42 2005 UTC

Diff Legend

Comparing gvpe/src/connection.C (file contents):
Revision 1.51 by pcg, Wed Mar 23 20:07:56 2005 UTC vs.
Revision 1.58 by pcg, Sat Jul 9 02:35:42 2005 UTC